Activity
From 06/21/2020 to 06/27/2020
06/27/2020
-
09:26 PM Bug #16997 (Open): IO#gets converts some \r\n to \n with universal_newline: false
- Reproduction code:
```
IO.binwrite "t.csv", ("a" * 100 + "\r\n") * 100
File.open("t.csv", encoding: "BOM|UTF-8", universal_newline: false) do |input|
p input.gets(nil, 32 * 1024) # => "a...a\n...\na...a\r\n...\r\n"
end
```
It ... -
07:12 PM Feature #16984: Remove write barrier exemption for T_ICLASS
- Thank you for great work. This kind of hack can cause BUGs easily.
> Private app A's heap size is about 22 MiB compared to B's 250 MiB.
Could you measure the memory/objects consumption before and after this patch if it is not diffi... -
06:31 PM Feature #16986: Anonymous Struct literal
- First of all, this is super cool idea!
I do have habit to use hash since it is seems to be elegant (as described in original proposal background section) and I end up having problems later (since I need to use fetch everywhere to get ... -
- Other syntax ideas, by others:
* Other prefixes
* `::{a: 1}`
* `\{a: 1}`
* `<>` to indicate
* `{<> a:1}` for anonymous Struct.
* `{<A> a:1}` for named Struct, the name is `A`.
* Similar with `%`
* `{% a:1}` for anonymous Struc... -
- # Q&A
## Splat like Hash literal and method arguments
https://bugs.ruby-lang.org/issues/16986#note-3
> I was wondering if ${} can do the following things compared to Hash literals:
Not allowed because of vulnerability concerns (please... -
02:28 PM Feature #16986: Anonymous Struct literal
- I like the idea of being able to quickly create an anonymous Struct but am concerned about the use of `$` for the syntax since that hinders readability and causes confusion due to `$` generally denoting a *global variable*. Why not allow...
-
12:37 PM Feature #16986: Anonymous Struct literal
- `struct = (a: 1, b: 2)` would be a great syntax, because I think anonymous struct is something like Tuple of Python.
But, there are two problems:
1. `()` returns `nil`, not an empty struct.
2. The meaning of `p(a: 1)` and `p (a: 1)... -
05:07 PM Revision 0703e014 (git): Mark some Integer methods as inline (#3264)
- 05:03 PM Revision 247dd874 (git): * 2020-06-28 [ci skip]
-
04:37 PM Bug #16996: Hash should avoid doing unnecessary rehash
- Dan0042 (Daniel DeLorme) wrote in #note-2:
> Shouldn't the rehash be tied to a change in the number of buckets rather than which method is used?
> ...
I think you might be confusing the re-organizing of a Hash's internal structure into... -
04:00 PM Bug #16996: Hash should avoid doing unnecessary rehash
- Very surprising results for `Hash#dup`. I even tried `h.rehash` before the benchmark, with no effect.
Shouldn't the rehash be tied to a change in the number of buckets rather than which method is used?
`select{true}` doesn't change t... -
11:48 AM Bug #16996: Hash should avoid doing unnecessary rehash
- Completely agreed, `Hash#dup` should not rehash (and it already doesn't on TruffleRuby).
-
- Pop quiz: Which is the fastest way to get a copy of a Hash `h`?
If, like me, you thought `h.dup` (of course, right?), you are actually wrong.
The fastest way is to call `h.merge`. Try it:
```
require 'benchmark/ips'
lengths ... -
04:03 PM Revision c405a8d3 (git): [ruby/fiddle] try bundled libffi by default
- If no installed libffi found, use bundled libffi unless explicitly
`--disable-bundled-libffi` option is given. - 02:54 PM Revision f2bcdc72 (git): [ruby/fiddle] Support MSWIN (#43)
- https://github.com/ruby/fiddle/commit/f16e7ff6e0
- 02:54 PM Revision a40b390b (git): [ruby/fiddle] test windows: use _snprintf
- https://github.com/ruby/fiddle/commit/aa261bdb9f
- 02:54 PM Revision 6429b6d9 (git): [ruby/fiddle] Add missing include
- https://github.com/ruby/fiddle/commit/4ca61efcd7
- 02:54 PM Revision ae18220f (git): [ruby/fiddle] Add support for variadic arguments
- GitHub: fix GH-39
Reported by kojix2. Thanks!!!
https://github.com/ruby/fiddle/commit/6c4cb904dc - 02:54 PM Revision 9f740aca (git): [ruby/fiddle] Use meaningful variable name
- https://github.com/ruby/fiddle/commit/2cac24b7c8
- 02:54 PM Revision 50fbd00e (git): [ruby/fiddle] Use "do { } while (0)" to ensure requiring ";"
- https://github.com/ruby/fiddle/commit/2155ae5979
-
-
-
-
-
09:14 AM Feature #16812: Allow slicing arrays with ArithmeticSequence
- > But a negative start with a non-negative end is quite weird. What is that operation even supposed to mean? What is it useful for?
I believe such edge cases might emerge not being directly written, but when dynamically calculated. Im... -
- sawa (Tsuyoshi Sawada) wrote in #note-2:
> Would
> ...
It will definitely work, but it will be the same as `Set.new(h.keys)` (a bit slower because enumerator is a bit slow). It still iterates on the keys, and add them to the new hash.
... -
01:55 AM Feature #16993: Sets: from hash keys using Hash#key_set
- Would
```ruby
Set.new(h.each_key)
```
not work? -
- This reverts commit 5c03e4680e724faeedb2c5fc1581d5fcb66aaff2.
I gave up stabilizing Rinda::TupleSpaceProxyTest#test_cancel_02. As the
test uses sleep, it's probably not gonna be stable with --jit-wait.
http://ci.rvm.jp/results/trunk-mj... -
04:53 AM Revision 600f3990 (git): Cosmetic change
-
-
04:51 AM Revision c9ee34a1 (git): Add #deconstruct cache to find pattern
-
-
-
03:29 AM Bug #16979: FileUtils#cp_r with preserve, lchmod fails with ENOTSUPP
- ruby_2_7 799c5766a4dc215d139d2c26ac68636f43a64fbf merged revision(s) a19228f878d955eaf2cce086bcf53f46fdf894b9.
-
- Closed to backport.
-
- brace the fact that lchmod(2) can EOPNOTSUPP
Musl libc has this function as a tiny wrapper of fchmodat(3posix). On
the other hand Linux kernel does not support changing modes of a symlink.
The operation always f... -
- ruby_2_7 d8a32b146561a0ddd3e60da9863a082b7e7725db merged revision(s) 263b941321c3de6afc8f9dafbc2625f866b7437e.
-
- [ripper] fix mismatched indentations warning [Bug #16981]
The scanner location has to be set from `lex.ptok` before it is
flushed by dispatching the scanner event. -
-
- I don’t this is an implementation bug, but a documentation issue.
- 01:55 AM Revision d6c9c014 (git): * 2020-06-27 [ci skip]
-
-
- Moved this hack mark to an argument to `compile_hash`.
> Bad Hack: temporarily mark hash node with flag so
> compile_hash can compile call differently.
06/26/2020
-
- This is quite minor, but `Set#<=>` should be refined.
Reminder: `Set` defines `<`, `>`, etc. as inclusion, but does not have a corresponding `<=>`:
```ruby
Set[1] < Set[1, 2] # => true
Set[1] <=> Set[1, 2] # => nil, should be -1
... -
- I would like a shorthand syntax for *frozen Sets of symbols or of strings*.
I am thinking of:
```ruby
%ws{hello world} # => Set['hello', 'world'].freeze
%is{hello world} # => Set[:hello, :world].freeze
```
The individual stri... -
- To create a set from hash keys currently implies a temporary array for all keys, rehashing all those keys and rebuilding a hash. Instead, the hash could be copied and its values set to `true`.
```ruby
h = {a: 1}
# Now:
Set.new(h.ke... -
- Officially, set elements have uncertain order. This predades when Hash started being ordered (Ruby 1.9.0, Xmas 2007). Sets have since been de-facto insertion-ordered. FYI, in those 13 years, there have been about 70 commits to `lib/set.r...
-
- I'd like to add `#join` to `Set`:
```ruby
# Now:
Set[1, 2, 3].join('x') # => NoMethodError
# After
Set[1, 2, 3].join('x') # => "1x2x3"
```
I'd make this join never recursive. (I've never wanted to use the recursivity of `Array... -
- We currently have `set <operator> array` work fine:
```ruby
Set[1] + [2] # => Set[1, 2]
```
Nothing works in the reverse order:
```ruby
[1] + Set[2] # => no implicit conversion of Set into Array
# should be:
[1] + Set[2] # ... -
- I am opening a series of feature requests on `Set`, all of them based on this usecase.
The main usecase I have in mind is my recent experience with `RuboCop`. I noticed a big number of frozen arrays being used only to later call `incl... -
- mrkn (Kenta Murata) wrote in #note-7:
> It may be better to change the behavior of `[*0..10][-100..100]`
I somewhat agree with that. When using range slicing most combinations make sense:
```ruby
[*0..10][0..4] #first elements
... -
06:08 PM Bug #16988 (Closed): Kernel.load loads file from current directory without '.' in path
- Ruby allows to load files using ```Kernel.load``` without explicitly specifying the relative path with ```.``` I'm not sure it's a bug or a feature, but since documentation in master doesn't say anything about it and the behavior differs...
-
- Thinking a bit more about it, I see more of a conceptual problem.
Introducing new literal in a language, we kinda introduce a new concept of the core collection. But what's that collection is, how'd you explain it to a novice?
It i... -
11:15 AM Feature #16986: Anonymous Struct literal
- > Or yeah just a simple Struct() or Struct[] with no additional syntax as suggested just above.
Actually I just realized that it can't really work as it would allow for `**kwargs`. -
- > Matz said he thought about {|a: 1, b: 2 |} syntax.
Might be just me but `{|` on first sight makes me think: this is a block.
What about a `%` syntax? `%s` and `%S` already exists, but `%O` could make sense: `%O{foo: 1, bar: 42}`.... -
- Another (unrelated, but conflicting) matter: I am not sure we have/had a discussion for this, but I remember Bozhidar Batsov in his "Ruby 4: To Infinity and Beyond" proposed `${}` as a literal for *set* (which for me seems more important...
-
- WDYT about half-solution (without syntax change)?
E.g. for me, the problem with `Struct.new(:a, :b).new(1, 2)` is not that it is "too long to write" but just that it is looks "hacky" (like, "you are using Struct against its expectation... -
10:09 AM Feature #16986: Anonymous Struct literal
- hi, I like this idea :)
I was wondering if `${}` can do the following things compared to Hash literals:
```ruby
# Can a value that is not a Symbol be used as a key (Symbol only?)
${ "a" => 1 }
${ 1 => 1 }
# Can variables be use... -
09:36 AM Feature #16986: Anonymous Struct literal
- First, I like the idea, so +1 for the idea. It also reminds me of
a more "prototypic-based approach" in general with structs, so if
the syntax could be made simpler to type, that seems to be a
possible improvement. And it fits into othe... -
- # Abstract
How about introducing anonymous Struct literal such as `${a: 1, b: 2}`?
It is almost the same as `Struct.new(:a, :b).new(1, 2)`.
# Proposal
## Background
In many cases, people use hash objects to represent a set o... -
- Since it's an error in 3.0, shouldn't it be made a non-verbose warning in 2.7?
-
- sam.saffron (Sam Saffron) wrote in #note-28:
> If we keep `foo(a: 1)` working a developer may get confused (despite everything operating 100% correctly):
> ...
I feel compelled to make a quick note here that what Sam is saying above is... -
- Enumerations are designed to be greedy (immediately executed on each method call within a chain) by default. Sometimes, that is not useful for practical purposes (e.g. 2 mln strings array, drop comments, split into fields, find the first...
-
- That's interesting...
My understanding was that the "find" and "load" operations were supposed to be orthogonal, so that we could have e.g.
1. find in:
* directory
* gems (cache)
* zip file
2. load:
* .rb
* .so
... -
- To add an "opinion perspective"... I, for one, even if not fascinated but at least intrigued by new syntax.
My reasoning is as follows:
* The most precious Ruby's quality for me is "expressiveness at the level of the single 'phrase... -
- I don't have any big preference, but I tend to agree with sawa too.
When I first read the proposal, I was confused in that two suggestions seem to be combined - or at the least I was reading it that way.
(1) Display "foo: bar" rather t... -
07:58 AM Feature #16985: Improve `pp` for `Hash` and `String`
- I wish the hashrocket stays and the syntax is consistent without exceptions for symbol.
-
- shyouhei (Shyouhei Urabe) wrote in #note-4:
> There are lots of debatable points on String#inspect (for instance its return value depends on runtime locale, why?). Improving it can quite easily jump into a bikeshed. You might want to s... -
02:01 AM Feature #16985: Improve `pp` for `Hash` and `String`
- There are lots of debatable points on String#inspect (for instance its return value depends on runtime locale, why?). Improving it can quite easily jump into a bikeshed. You might want to separate Hash's and String's discussions and fo...
-
- For `String`, I meant to say that current format would be kept the same except if the single quote version exist and has no escape.
```ruby
pp "Hello" # => "Hello" (no change)
pp "Won't\nwork \"Marc-André\"" # => "Won't\nwork \"Marc-And... -
-
- asked by ko1 to put this.
-
- and a related VM improvement.
JIT related commits:
* Code size reduction
* Deduplicate functions on JIT compaction 818d6d33368a396d9cd3d1a34a84015a9e76c5c8
* Avoid always inlining cold paths of ivar fcd257629063a345c48ff2d8057fa8ab... -
- https://github.com/ruby/fiddle/commit/a09e66adf4
https://github.com/ruby/fiddle/commit/6cab9b45d6
https://github.com/ruby/fiddle/commit/ab72b19bed -
- and add a debug log
-
- for opt_* insns.
opt_eq handles rb_obj_equal inside opt_eq, and all other cfunc is
handled by opt_send_without_block. Therefore we can't decide which insn
should be generated by checking whether it's cfunc cc or not.
```
$ benchmark-dr... -
- to make sure :opt_invokebuiltin_delegate_leave doesn't become
:(trace_)opt_invokebuiltin_delegate.
This is to prevent a warning like
> /tmp/ruby/v3/src/trunk-test/test/ruby/test_jit.rb:618: warning:
'opt_invokebuiltin_delegate_leave' in... -
05:15 AM Revision a640bcee (git): test/ruby/test_settracefunc.rb: Suppress a warning
- http://rubyci.s3.amazonaws.com/ubuntu2004/ruby-master/log/20200626T033003Z.log.html.gz
```
/home/chkbuild/chkbuild/tmp/build/20200626T033003Z/ruby/test/ruby/test_settracefunc.rb:2299: warning: ambiguous first argument; put parentheses or... -
- To prevent random failure with --jit-wait like
http://ci.rvm.jp/results/trunk-mjit-wait@silicon-docker/3026615 -
- If :return event is specified for a opt_invokebuiltin_delegate_leave
and leave combination, the instructions should be
opt_invokebuiltin_delegate
trace_return
instructions. To make it, opt_invokebuiltin_delegate_leave
instruction wil...
06/25/2020
-
- Eregon (Benoit Daloze) wrote in #note-23:
> Noteworthy is the current syntax in trunk is `def name(*args) = expr` (and not `def: name`), so there is *no* visual cue that this is a endless method definition except the `=` which comes ver... -
- Noteworthy is the current syntax in trunk is `def name(*args) = expr` (and not `def: name`), so there is *no* visual cue that this is a endless method definition except the `=` which comes very late.
I agree with @marcandre, I think it ... -
- tldnr; I am against this proposal, it decreases readability, increases complexity and doesn't bring anything to the table (in that order)
I read the thread carefully and couldn't find a statement of what is the intended gain.
@matz, co... -
- I think `symbol_key: value` would be nice in Hash#inspect, even if there are also non-Symbol keys.
I think changing String#inspect might be confusing, I'm used to see Strings always starting with a `"` for `p string`. -
- Could we improve `pp` for `Hash` and `String`:
```ruby
pp({hello: 'My name is "Marc-André"'})
# =>
{hello: 'My name is "Marc-André"'}
# instead of
{:hello=>"My name is \"Marc-André\""}
```
If any key is non-symbol, they woul... -
06:23 PM Feature #16147: List Comprehensions in Ruby
- In my opinion, the more useful types of list comprehensions are when multiple inputs are needed.
The Ruby syntax in example one looks best, but requires more array manipulation, even if Enumerable#filter_map replaces select.map. Example... - 03:21 PM Revision 289a28e6 (git): * 2020-06-26 [ci skip]
- 03:21 PM Revision 2d89af45 (git): Add require to Delegator examples
- In Ruby 2.7.1 SimpeDelegator cannot be used without requiring `delegate` this PR adds the require to the first example for each class so that devs don't have to hunt for what require to use.
-
- Digging a bit into this issue, I was wrong that this is just s390x.
~~~
for i in {1..10000}
do
echo "******** $i"
make runruby TESTRUN_SCRIPT="-Itool/lib test/-ext-/bug_reporter/test_bug_reporter.rb -v"
done
... snip ...... -
- While `spec/bundler` and `spec/bundler/` are treated different
targets by GNU make 4, the same target by GNU make 3. The latter
target, ending with a slash, was to run `test-bundler-parallel`,
instead of `spec/bundler/%`. -
08:09 AM Feature #16897: General purpose memoizer in Ruby 3 with Ruby 2 performance
- Understood Jeremy, there are always compromises.
```
def bar(a:); end
def foo(*args); bar(*args); end;
```
There was a deliberate decision made to break `foo(a: 1)` here (by default) which has both its upsides and downsides.
... -
- As it is ignored and set at building packages automatically, it is
just nonsense to set in gemspec file for input. -
06:32 AM Revision 4eff8a66 (git): [flori/json] add metadata
- https://github.com/flori/json/commit/9f430a7bba
-
06:32 AM Revision 1b076ca3 (git): [flori/json] Gem::Specification#date is set automatically by RubyGems.org.
- https://github.com/flori/json/commit/1920653013
-
- https://github.com/flori/json/commit/78ec5e2bd3
-
- It's probably not worth it because there's nothing we can optimize in
such builtin methods. It's worth JIT only when inlined. -
- to prevent a random failure like
http://ci.rvm.jp/results/trunk-random2@phosphorus-docker/3024287 -
01:03 AM Feature #16984 (Closed): Remove write barrier exemption for T_ICLASS
- Currently, iclasses are "shady", or not protected by write
barriers. Because of that, the GC needs to spend more time marking these
objects than otherwise. Let's insert write barriers for iclasses.
Applications that use modules heav... -
12:01 AM Bug #16977: Ambiguous lookup super for refinements
- ssnickolay (Nikolay Sverchkov) wrote:
> [In specification](https://docs.ruby-lang.org/en/2.7.0/syntax/refinements_rdoc.html) we have the note
> ...
(snip)
> I don’t understand why `include` works differently than refining a method dir...
06/24/2020
-
06:31 PM Revision 5e860ed4 (git): [ci skip] Enhanced RDoc for Array (#3252)
- Methods:
map/collect
map!/collect!
values_at
select/filter
select!/filter! -
- Because it does not have closing `end`.
-
- 03:20 PM Revision 5dfe95d1 (git): * 2020-06-25 [ci skip]
-
-
-
- This was fixed in master:
https://github.com/ruby/ruby/commit/a18e81d797135de6e143a600e4f4d2b00ab23bf9
https://github.com/ruby/ruby/commit/5aa5aad48aa3effce60de3559d9bd107bfc9a91d
https://github.com/ruby/ruby/commit/07dca5c02c95322a... -
12:34 PM Bug #16904: rubygems: psych: superclass mismatch for class Mark (TypeError)
- Is it possible to do backport the fixes to Ruby 2.7?
For Fedora Ruby, we applied the following 4 patches (merged pull-requests) to fix this issue in Fedora.
https://github.com/rubygems/rubygems/pull/3124
https://github.com/rubygem... -
12:57 PM Bug #16983 (Closed): RubyVM::AbstractSyntaxTree.of(method) returns meaningless node if the method is defined in eval
# Problem
`RubyVM::AST.of(method)` returns a meaningless node if the method is defined in eval.
For example:
```ruby
p 'blah'
eval <<~RUBY, binding, __FILE__, __LINE__ + 1
def foo
end
RUBY
method = method(:foo)
...-
- I found two problems with `DelegateClass`.
The patch is available on GitHub. https://github.com/ruby/ruby/pull/3221
# `instance_methods`
First, `instance_methods` method's result does not contain the names of methods that are adde... -
- Applied in changeset commit:git|263b941321c3de6afc8f9dafbc2625f866b7437e.
----------
[ripper] fix mismatched indentations warning [Bug #16981]
The scanner location has to be set from `lex.ptok` before it is
flushed by dispatching the s... -
- ```
$ ruby2.5 -v -rripper -e 'r = Ripper.new("begin\n end"); def r.warn(*e) p e; end; r.parse'
ruby 2.5.8p224 (2020-03-31 revision 67882) [x86_64-darwin19]
["mismatched indentations at '%s' with '%s' at %d", "end", "begin", 1]
$ r... -
- The scanner location has to be set from `lex.ptok` before it is
flushed by dispatching the scanner event. -
-
- A test worker process may already be enabling TracePoint, which results
in changing the insn name in this test.
http://ci.rvm.jp/results/trunk-random0@phosphorus-docker/3022750 -
-
-
-
- ```
$ benchmark-driver -v --rbenv 'before;after;before --jit;after --jit' benchmark/mjit_class.yml --repeat-count=4
before: ruby 2.8.0dev (2020-06-23T07:09:54Z master 37a2e48d76) [x86_64-linux]
after: ruby 2.8.0dev (2020-06-23T17:29:56Z ... -
- using opt_invokebuiltin_delegate_leave insn.
Since Ruby 2.7, :return of methods using builtin have not been traced properly. - 06:18 AM Revision fbb32b1f (git): * 2020-06-24 [ci skip]
-
- RubyVM::AbstractSyntaxTree is a module actually, but the document says "class".
-
- I guess this is already fixed in changeset commit:a19228f878d955eaf2cce086bcf53f46fdf894b9
06/23/2020
-
- Ping.
This still happens and is annoying as it fails consistently in ruby/spec's CI (e.g., https://github.com/ruby/spec/pull/774).
I will now exclude it there, but the bug is still present. -
06:04 PM Misc #16980 (Closed): Improve documentation on JSON#parse and JSON#parse!
- Adds information about raised error when fails to parse on JSON#parse and JSON#parse!
-
03:49 PM Feature #16897: General purpose memoizer in Ruby 3 with Ruby 2 performance
- sam.saffron (Sam Saffron) wrote in #note-26:
> > In terms of usability, matz seems to like handling *args, **kwargs because it is explicit and not so complex.
> ...
The alternative is breaking compatibility with code that never used k... -
- > In terms of usability, matz seems to like handling *args, **kwargs because it is explicit and not so complex.
To me the design we arrived at is very very non-intuitive sadly, @matz
```
def bar(a: 1)
end
def foo(*x)
puts... -
03:34 PM Bug #16979 (Closed): FileUtils#cp_r with preserve, lchmod fails with ENOTSUPP
Hello,
I encountered an issue copying a directory tree with symlinks with FileUtils#cp_r with preserve flag.
Apparently FileUtils considers the possibility that lchmod raises NotImplementedError, however it apparently does not bu...-
- Methods:
#rotate!
#rotate
#sort!
#sort
#bsearch
#bsearch_index -
- I think even just doing the first one, "Positional Hash Argument to Keyword Argument Conversion", is only going to make everything more confusing and delay migration.
In other words, I think there will be far more pain points that way th... -
- This is the simplest test case:
~~~
$ mkdir a
$ echo "puts __FILE__" > a/test.rb
$ ln -s a b
$ ruby -Ib -e "require 'test'"
/builddir/a/test.rb
~~~
This behavior is problematic, because Ruby should not know nothing abou... -
- only for opt_nil_p and opt_not.
While vm_method_cfunc_is is used for opt_eq too, many fast paths of it
don't call it. So if it's populated, it should generate opt_send,
regardless of cfunc or not. And again, opt_neq isn't relevant due t... -
-
- https://github.com/ruby/psych/commit/4e7794fc2c
-
- https://github.com/ruby/psych/commit/68da645c7e
-
- https://github.com/ruby/psych/commit/39996192cc
-
- https://github.com/ruby/psych/commit/ef74fc01e2
-
-
- Interesting, I can reproduce the performance difference:
```
$ time ./miniruby -e '100000.times { Time.utc(2007, 11, 1, 15, 25, 0, 123456.789.to_r) }'
real 0m0.633s
user 0m0.622s
sys 0m0.011s
$ time ./miniruby -e '1... -
- and default jit-verbose to 1 if no argument.
-
-
06/22/2020
-
11:27 PM Revision e2d94f61 (git): Convert RMoved to a doubly linked list
- This commit converts RMoved slots to a doubly linked list. I want to
convert this to a doubly linked list because the read barrier (currently
in development) must remove nodes from the moved list sometimes.
Removing nodes from the list i... -
06:33 PM Bug #16977 (Closed): Ambiguous lookup super for refinements
- [In specification](https://docs.ruby-lang.org/en/2.7.0/syntax/refinements_rdoc.html) we have the note
> Note that super in a method of a refinement invokes the method in the refined class even if there is another refinement which has ... -
- Eregon (Benoit Daloze) wrote in #note-9:
> One consideration here is performance.
> ...
Well, Time converts Float to Rational both with and without the patch (the values are passed through `num_exact`, which is where the conversion tak... -
- One consideration here is performance.
For instance `Time.at(Float)` is quite slow, due to going through Rational, etc.
Could you measure the other methods you changed to see how they perform compared to before? -
- I've added an alternative approach, which uses Float#rationalize for all Float conversions in Time, except for Time.at (one test depends on `Time.at(float).to_f == float`): https://github.com/ruby/ruby/pull/3248
-
-
- This was fixed earlier in commit:39a1959d289ecba5e61431deaef239123c3f0fcc. I don't consider it worth backporting.
-
- Thanks for the report! I'll fix the documentation shortly.
-
04:27 PM Bug #16976 (Closed): Documentation bug in Proc
- https://ruby-doc.org/core-2.7.0/Proc.html
About 1/3 of the way through the docs, it states:
Lambda semantics is typically preserved during the proc lifetime, including &-deconstruction to a block of code:
``` ruby
p = proc {|x,... - 03:31 PM Revision 079ed74d (git): * 2020-06-23 [ci skip]
-
- Exclude linker flags for external libraries used by no longer
built extension libraries when static-linked-ext. -
- Thanks for the tip; all these years and I never realized `FileUtils.mkdir_p` had this `mode:` argument (and/or never realized what it was for).
I can _imagine_ use cases for this generic solution: chown, chgrp, touch index.html
And in ge... -
02:08 PM Bug #16973: Rails Active Support unit test fails since 41582d5866
- Opened a pull request at Rails https://github.com/rails/rails/pull/39697 Thank you for the useful information.
-
09:34 AM Revision 6adbdb56 (git): Fix Encoding::CompatibilityError in `FileUtils::Entry_#join`
-
-
-
09:13 AM Feature #16975: Warn when value from environment is being ignored by `Dir.tmpdir`
- @nobu You are totally right, I misread the code. What we would need is indeed to split the following conditions.
-
- I think it would be acceptable.
That "silent rescue" is actually for `File.stat` only, that is an obvious case.
I guess you may want to split the following conditions. -
- because opt_nil/opt_not/opt_eq populates cc even when it doesn't
fallback to opt_send_without_block because of vm_method_cfunc_is.
```
$ benchmark-driver -v --rbenv 'before --jit;after --jit' benchmark/mjit_opt_cc_insns.yml --repeat-cou... -
- `path_info` contains filesystem encoding and binary.
Example is `"/webrick.cgi/%A5%DB%A4%B2/%A4%DB%A4%B2"` in `TestWEBrickCGI#test_cgi`. -
-
-
-
-
-
- These days I don't use `make benchmark`. The YAML files should be
executable with bare `benchmark-driver` CLI without passing
`RUBYOPT=-Ibenchmark/lib`. -
- It failed again
http://ci.rvm.jp/results/trunk-mjit-wait@silicon-docker/3018488
06/21/2020
-
- This tries to fix a random failure like
http://ci.rvm.jp/results/trunk-mjit-wait@silicon-docker/3017837 -
- 05:27 PM Revision 0e3ead34 (git): * 2020-06-22 [ci skip]
-
- * Verify builtin inline annotation with VM_CHECK_MODE
* Remove static to fix the link issue on MJIT -
- Currently, if you set `ENV["TMPDIR"]` to a value that doesn't meet `Dir.tmpdir` criteria to become the temporary folder, the environment variable is silently ignored and the next variable in the chain is checked.
This makes issues qui... -
-
12:04 PM Bug #16974 (Closed): frozen string issue in lib/reline/ansi.rb on ruby-2.7.1
- `RUBYOPT=--enable-frozen-string irb` throws a `/Users/user/.rvm/rubies/ruby-2.7.1/lib/ruby/2.7.0/reline/ansi.rb:109:in `block in cursor_pos': can't modify frozen String: "" (FrozenError)`. Have created a PR to fix this here - https://git...
-
- Great to see `Primitive.name` is used now :)
Somehow Redmine didn't send me any notification for the issue being closed.
@k0kubun agreed for the first one. -
- I have no preference on whether it should be called "primitive" or "builtin", but can we at least make the naming consistent? The `Primitive` change introduced naming inconsistency inside CRuby and it's causing cognitive overhead when re...
-
- Trying to eliminate some newer random failures
http://ci.rvm.jp/results/trunk-mjit-wait@silicon-docker/3016543 -
-
-
- https://github.com/ruby/date/commit/5f4ac92947
-
- https://github.com/ruby/date/commit/81a057db11
-
- Either 95b0fed371 or 7561db8c00 started to cause
https://rubyci.org/logs/rubyci.s3.amazonaws.com/rhel_zlinux/ruby-master/log/20200621T053303Z.fail.html.gz
But so far no idea why it's happening. Until I get direct ssh access to
debug the... -
-
- `Gem::Commands::EnvironmentCommand` expects that `Gem.ruby` has
the transformed basename. -
- yuki24 (Yuki Nishijima) wrote in #note-4:
> Not sure if this is helpful but here is a link to the place where `ActiveSupport::ToJsonWithActiveSupportEncoder` is prepended on a number of classes: https://github.com/rails/rails/blob/0b9a5... -
- Applied in changeset commit:git|7561db8c009bb79a75024fa4ed0350bfb3d0626c.
----------
Introduce Primitive.attr! to annotate 'inline' (#3242)
[Feature #15589] -
- [Feature #15589]