Activity
From 04/24/2020 to 04/30/2020
04/30/2020
-
07:42 PM Feature #16822: Array slicing: nils and edge cases
- I do not have a strong preference here either way; I guess one can reason in
favour for both behaviour types/styles, and I think a primary point in the
suggestion is that it refers to startless/endless situations, such as "5..",
whic... -
10:44 AM Feature #16822 (Rejected): Array slicing: nils and edge cases
- (First of all, I understand that the proposed change can break code, but I expect it not to be a large amount empirically.)
I propose that methods that slice an array (`#slice` and `#[]`) and return a sub-array in the normal case, sho... -
07:18 PM Misc #16775: DevelopersMeeting20200514Japan
- * [Feature #9758] Allow setting SSLContext#extra_chain_cert in Net::HTTP (stan3)
* useful to allow https with cert chain, small patch, few :+1s -
- * [Feature #16822] Array slicing: nils and edge cases (zverok)
* Never return `nil` from `ary[start...end]` even if out of arrays' bounds - 05:32 PM Revision 9014c900 (git): * 2020-05-01 [ci skip]
-
05:32 PM Revision 5a9d2da7 (git): Remove deprecated rb_require_safe
-
01:54 PM Revision 4a8acf46 (git): [ruby/irb] Restore the default encodings
- IRB::ReadlineInputMethod#initialize sets via IRB.set_encoding.
-
12:20 PM Bug #16823 (Closed): Bundler related manual pages are corrupted
- We recently found out that bundler related manual pages we get by building and installing ruby 2.6 (and as far as I can tell all newer versions as well) are corrupted (we are building with `--with-mantype=man`).
The reason is that, e.... -
09:00 AM Feature #13820: Add a nil coalescing operator
- Your proposal to distinguish `nil` from `false` is ad hoc, and is not a real solution for your use case, which is to add a value to a hash only when it does not yet have a corresponding key.
Following your way of doing it, you would sti... -
02:50 AM Feature #13820: Add a nil coalescing operator
- bsarrazin (Ben Sarrazin) wrote in #note-7:
> Kotlin has this feature, Swift has this feature, many other languages have this feature.
No. Kotlin does not have this feature (distinguish `false` and `null`). It is a really bad idea f... -
04:16 AM Feature #16821: gem version notation for "rational version" compatibility
- Thank you for the quick response. Yes, I will do refile there. Sorry for mistakenly filing here.
-
- Can you report it to rubygems' upstream? It has its own tracker: https://github.com/rubygems/rubygems
-
-
- 02:48 AM Revision 14b5a3b4 (git): * 2020-04-30 [ci skip]
-
- Readline::VERSION may not be a single word, e.g EditLine wrapper
when linked with editline.
04/29/2020
-
11:24 PM Feature #16150: Add a way to request a frozen string from to_s
- I can confirm that Discourse bench and Discourse works with symbol-fstring today.
Old versions of pry were broken, but stuff seems fine now. -
- When a gemspec wants to express a version requirement, we typically use the `'~> '` notation like this:
```ruby
spec.add_dependency 'nokogiri', '~> 1.8'
```
This indicates compatibility following the "rational versioning" as descri... -
08:05 PM Feature #13820: Add a nil coalescing operator
- Kotlin has this feature, Swift has this feature, many other languages have this feature.
Ruby _needs_ this feature :D
```ruby
"a truthy value" || foo("something else") # The operator also short circuits so the method `foo` will neve... -
10:13 AM Revision 7e5253d1 (git): [ruby/irb] Suppress "method redefined" warning
- https://github.com/ruby/irb/commit/5f0aee56fa
-
- https://github.com/ruby/irb/commit/cdbb9dfc9f
-
- https://github.com/ruby/irb/commit/a6fe58e916
-
- https://github.com/ruby/reline/commit/13420197b8
-
- https://github.com/ruby/reline/commit/298144b06a
-
- And unlimited is default.
https://github.com/ruby/reline/commit/f5149c3ca6 -
- https://github.com/ruby/reline/commit/9bdbed9cbc
-
- https://specifications.freedesktop.org/basedir-spec/basedir-spec-latest.html
> All paths set in these environment variables must be absolute.
> ...
https://github.com/ruby/reline/commit/45af6eea77 -
- OK, thank you for clarification. Then we don't have to bother them in LEGAL.
-
08:50 AM Bug #16820: LEGAL is out of sync
- I see.
> If you didn't intend to change their license (== they are still dual-licensed), then their gemspec shall be updated to reflect that info like s.licenses = ["Ruby", "BSD-2-Clause"].
We should update it to gemspec files esp... -
- @hsbt Did you want to change license of those libraries from Ruby's to "BSD only"? Then we should list up all of them in LEGAL. If you didn't intend to change their license (== they are still dual-licensed), then their gemspec shall be...
-
- Should we update the sentence about dual license with BSD-2-Clause to `LEGAL` file? I'm not sure what your expectation.
-
- At the very beginning of `LEGAL`, it reads:
> All the files in this distribution are covered under either the Ruby's
> ...
This means that the exception list must be comprehensive. If we miss someone else's software there, it would ... -
- It may contain symbolic links.
-
-
04/28/2020
-
08:49 PM Feature #16786: Light-weight scheduler for improved concurrency.
- @sam.saffron I'll let @ioquatix reply in more details but my point of view on that is:
#13618 is not flexible, and rather hardcodes everything including the scheduler, the IO selectors, etc, which would add a huge implementation cost to... -
- My big concern here is that this does not cover why #13618 was deficient and this complete greenfield implementation solves the issues it had?
#13618 had kqueue and epoll implementations which this would leave unimplemented, as far a... -
-
03:05 PM Revision 1994ed90 (git): Remove debugging code from gc.c
- Partially revert adab82b9a71f60ad1c7f4f8c134a5ae9198ab32a and
c63b5c6179d700ceacf5cae8d3ee86da1294c781.
The issue that these commits attempt to address was maybe fixed with
1c7f5a57125001447dc6173847dc68aa50bd8e93. - 03:01 PM Revision 31a4ee4c (git): * 2020-04-29 [ci skip]
-
- Even without this limit, these assertions almost certainly cause a
NoMemoryError by removing the fix in 72ad8595f20. -
-
-
03:33 AM Feature #16818: Rename `Range#%` to `Range#/`
- I visualise a bag of grain. If I'm asked to divide it by three, I will make three piles of grain. If I'm asked to modulate it by three, I will make many piles, each of three grains.
> why you need to refer to complex numbers
This i... -
- inopinatus (Joshua GOODALL) wrote in #note-8:
> their division seems intuitively identical to cutting a line into parts. [...] Division is therefore cutting that line into parts
That is exactly what I am saying (although I am not sure ... - 02:39 AM Revision 3acdb318 (git): * 2020-04-28 [ci skip]
-
- https://github.com/rubygems/rubygems/commit/d4486ca061
-
02:04 AM Revision 5b77fc8a (git): [rubygems/rubygems] Remove commented out code
- https://github.com/rubygems/rubygems/commit/42aa0d7ebc
-
- Some tests had failed under `umask 077` mode. As far as I investigated,
there is no actual bug. All failures were caused by tests that create a
wrong-permission file or expect wrong permission.
This changeset fixes the tests.
https:/... -
- English.rb is extracted to the default gems at
https://github.com/ruby/ruby/commit/2c5764ec223d976e0d0da1494596a1519104be3e
https://github.com/rubygems/rubygems/commit/532f488c0b
04/27/2020
-
- > x / y reads "divide x by y", not "divide x into y parts"
I'm not sure I understand the difference, but nevertheless I agree with Eragon's intuition.
To me, a range is not a matrix, not a sequence either. I think of ranges as int... -
06:18 PM Bug #16819 (Assigned): Line reporting off by one when reporting line of a hash?
- If I run this program:
```
TracePoint.new(:line) { |t| p t.lineno}.enable
def foo(a, b) # 2
a + b # 3
end # 4
# 5
foo 1, 2 # 6
# 7
A = { # 8
a: 1, # 9
b: 2... -
10:58 AM Feature #16150: Add a way to request a frozen string from to_s
- Could we consider `Symbol#to_s` retuning frozen strings again?
We've been running with https://github.com/Shopify/symbol-fstring for a about 5 months now, and I think the backward incompatibility problem is much less important now.
... -
-
- Couldn't figure out failed/fixed versions.
-
- That bug has been fixed by ec0c394b9eb, and the test has been
added by 181ffea5e04. -
12:41 AM Revision fd2df584 (git): Fix a typo [ci skip]
04/26/2020
-
11:43 PM Feature #16818: Rename `Range#%` to `Range#/`
- Eregon (Benoit Daloze) wrote in #note-2:
> Just my opinion, but I find `%` a lot more intuitive, and would find `/` very confusing in this context.
> ...
I agree. Of course, `/` and `%` are related, so it's no surprise that there are a... -
- > x / y reads "divide x by y", not "divide x into y parts".
Makes sense.
It is language difference probably: in my native Ukrainian (and Russian I was taught in school) it reads as (roughly translating) "divide into y"; therefore... -
- zverok (Victor Shepelev) wrote in #note-4:
> I'd say that `(5..14) / 3` reads definitely like "split the range into 3 parts" (expecting, IDK, 3 sub-ranges or jumps over `(14-5) / 3` spans).
x / y reads "divide x by y", not "divide x in... -
- I'd say that `(5..14) / 3` reads definitely like "split the range into 3 parts" (expecting, IDK, 3 sub-ranges or jumps over `(14-5) / 3` spans).
`(5..14) % 3` at least reads (for me) like "range 5—14 `<something>` 3", bearing no imme... -
- I somewhat agree with sawa's comment that % on Range may confuse some ruby
folks; I think % is more typically the modulo operator? I can not say how
strong this confusion may be, perhaps small, perhaps not, but I concur with
his origi... -
- Just my opinion, but I find `%` a lot more intuitive, and would find `/` very confusing in this context.
One interpretation of `%` here is `by` or "so that (element % n) is always the same, starting with the Range#begin value" -
- `Range#%` was introduced as an alias of `Range#step` by 14697, but it is counter-intuitive and confusing.
Iteration in the following:
```ruby
((5..14) % 3).each{|i| p i}
#>> 5
#>> 8
#>> 11
#>> 14
```
is not based on `x % y... -
- FYI: I re-enabled the test in question with 93ed465dcdc866013cd93c3662937497900c8086
-
- Revert 9948addda67f4b7a6e3575f1eba9025f998811d2.
It is now discussed in https://bugs.ruby-lang.org/issues/16814, and an
assert is added with a217d3cedce3f5aa5c27a1ce6c72b65ec37da057.
It would be good to give it a try. -
- 03:54 PM Revision 33767d1e (git): * 2020-04-27 [ci skip]
-
-
-
-
- yield `home_dir` when HOMEDIR is not falsy only.
https://github.com/ruby/ruby/blob/d0f41aa2382612022162d033ddb3d9c9cc62099e/lib/rdoc/ri/paths.rb#L43
```
yield home_dir, :home if home and HOMEDIR
```
https://rubyci.org/logs/ruby... -
-
-
-
03:39 AM Revision 034b8472 (git): remove unused rb_str_clear define (#3059)
-
- https://rubyci.org/logs/rubyci.s3.amazonaws.com/scw-ad7f67/ruby-master/log/20200425T175405Z.fail.html.gz
```
4) Error:
TestRDocServlet#test_asset:
NoMethodError: undefined method `replace' for nil:NilClass
/home/chkbuild/build/2020...
04/25/2020
-
- As there is no immediate rejection, I updated the implementation, making it more robust.
@Dan0042, I tried to make edge cases consistent, so now they are...
```ruby
(0..20).to_a[10.step(by: -2)]
# => [10, 8, 6, 4, 2, 0] -- avoids... - 05:01 PM Revision 9fd3f243 (git): * 2020-04-26 [ci skip]
-
05:00 PM Revision 7ccb7a99 (git): [DOC] explicit_bzero exists in modern Linux
- [ci skip]
-
02:27 PM Feature #16817 (Open): attr_predicate or attr_query or attr_something for ? methods
- I would like `attr_predicate` like attr_reader etc.
`attr_predicate :cat` would define a method named `:cat?` that returned the value for ivar `@cat`.
I would like this because i find myself writing this:
```
def cat?
@cat
en... -
-
08:05 AM Feature #16816: Prematurely terminated Enumerator should stay terminated
- Thank you, I've fixed the link.
-
-
-
-
04/24/2020
-
11:05 PM Bug #16814: Segmentation fault in GC while running test/ruby/test_fiber.rb on s390x
- Did you mean`any->as.data.dfree`? It points to no valid location.
```
(gdb) print any->as.data
$4 = {basic = {flags = 12, klass = 2930849422520}, dmark = 0x0, dfree = 0x1,
data = 0x2aa6449f9e0}
(gdb) print any->as.typeddata
$5 = {basic... -
- > disappeared on April 15.
You may know, but the test has been skipped on s390x since 9948addda67f4b7a6e3575f1eba9025f998811d2. -
- Where does `any->as.data.free` point?
Is `any->as.basic.klass` a valid class object?
If you compile gc.c as `make DEFS=-DGC_DEBUG gc.o`, `any->file` and `any->line` have the location in ruby level, and could help you. -
- A segmentation fault almost always happens in test/ruby/test_fiber.rb with certain commits of latest Ruby on s390x.
```
$ make test-all TESTS=test/ruby/test_fiber.rb
Run options:
--seed=90044
"--ruby=./miniruby -I./lib -I. -I.... -
- ( Just a brief typo-correction, I think you meant the link https://github.com/jruby/jruby/issues/6157 and not https://github.com/jruby/jruby/issue/6157 )
-
- A simpler way to say why I believe this is a bug...
If I have an Enumerator with custom logic, and it is constructed and used once, I expect the iteration block will be entered *exactly* once and exited *exactly* once. -
- When iterating over an Enumerator, there are three different possible results of calling `next`:
1. The next item is returned and a cursor is advanced
2. There's no next item and the Enumerator will forever raise `StopIteration`
3. ... -
- https://github.com/ruby/rdoc/commit/6c4801d1f6
-
- https://github.com/ruby/rdoc/commit/00fb4dd2a3
- 05:36 PM Revision cf5b3d67 (git): * 2020-04-25 [ci skip]
-
-
-
-
- > We already have situations in JRuby and TruffleRuby where unsynchronized access to shared mutable state can cause a crash or data corruption. So why is this different?
Let's not introduce more bugs (and IMHO those bugs should be fix... -
10:23 AM Feature #8215: Support accessing Fiber-locals and backtraces for a Fiber
- > It's of course unacceptable if a Ruby implementation behaves unsafely (e.g., crashes or loses fiber local variable) for this, so it is a relevant concern for this issue.
We already have situations in JRuby and TruffleRuby where unsy... -
- To make it clearer about "clean API": if we have Fiber#[] and Thread#[] then Thread#[] is just deceptive and doesn't do anything different.
OTOH, with Fiber[:foo] and Thread[:foo] we can actually have the intuitive semantics. -
- @ioquatix Please create a separate feature ticket for `Fiber#backtrace`, as already asked by nobu in https://bugs.ruby-lang.org/issues/8215#note-5
I'd like to keep the discussion here about Fiber locals, not mix it with an unrelated meth... -
10:40 AM Bug #16787: [patch] allow Dir.home to work for non-login procs when $HOME not set
- Attaching version "v7" of the patch. This version corresponds with the changes I just pushed on my [ads/b.r-l.o-issue-16787](https://github.com/salewski/ruby/tree/ads/b.r-l.o-issue-16787) branch for [PR 3034](https://github.com/ruby/ruby...
-
-
-
- I think `Fiber()` is OK after your replies, if it raises if there is no scheduler so there is no silent error. It would just need good documentation.
`Fiber.new(blocking: false)` should be clearly marked as "should only be used by sch... -
- I asked for more feedback from community.
https://twitter.com/ioquatix/status/1251024336502190081
- `Fiber do ... end`: ~49% like it.
- `AsyncFiber do ... end`: ~27% like it.
- `Fiber.new(blocking:false) do ... end.resume`: ~20% ... -
- I think this makes sense and can definitely be useful for debugging.
If called on a `Fiber` of another `Thread`, that might be slow on non-GIL implementations, but that's the same as `Thread#backtrace` so I think not really an issue. -
- Use `Thread#backtrace` as example.
-
- Previously discussed here: https://bugs.ruby-lang.org/issues/8215
Add a new method `Fiber#backtrace`. It would produce a backtrace similar to how `Thread#backtrace` works. -
- https://github.com/ruby/reline/commit/9b1327d2f4
-
- In the XDG Specification, if ~/.config/readline/inputrc exists, then ~/.inputrc
should not be read, but for compatibility with GNU Readline, if ~/.inputrc
exists, then it is given priority.
https://github.com/ruby/reline/commit/97f1e7db04 -
- Closing. Let me know if you can still reproduce the issue on mastar.
-
05:13 AM Misc #16775: DevelopersMeeting20200514Japan
- * [Feature #16806] Struct#initialize accepts keyword arguments too by default (k0kubun)
* This obviates `keyword_init: true`. Is the described incompatibility and release plan (3.0: warn, 3.1: introduce) acceptable? -
- - [Feature #16815] Introduce `Fiber#backtrace`. (ioquatix)
- Add `Fiber#backtrace` which gets any fiber backtrace. Very useful for debugging fiber state.
- [Feature #16786] Light weight scheduler for improved concurrency. (ioquatix)
... -
05:09 AM Feature #16812 (Assigned): Allow slicing arrays with ArithmeticSequence
- I'm positive this if the behavior is the same as Python's list slicing.
If the behavior will be different from Python's, I'm negative because it confuses PyCall users. -
- A few bugs.
* `Float` `ArithmeticSequence` crashes.
```shell
$ ./ruby -e '[*0..10][(0.0..)%10]'
Assertion Failed: ../src/include/ruby/3/arithmetic/long.h:136:ruby3_fix2long_by_shift:"RB_FIXNUM_P(x)"
```
* If o... -
12:19 AM Feature #16812: Allow slicing arrays with ArithmeticSequence
- Theoretically I'm in favor but there's some edge cases that need consideration.
```ruby
nums = (0..20).to_a
s = 10.step(by: -2) # 10, 8, 6, 4, 2, 0, -2, ...
nums[s] #=> [10, 8, 6, 4, 2, 0, 19, 17, ...] ???
s = (-5..5) % 2 # -5... -
- Applied in changeset commit:git|ac2106acc276854ae2ac8cc5fa6859aa28362f2f.
----------
[DOC] Fixed explanation for Method#>> [Bug #16813] [ci skip] - 03:23 AM Revision 71f84018 (git): * 2020-04-24 [ci skip]
-
-