Activity
From 03/22/2020 to 03/28/2020
03/28/2020
-
10:23 PM Revision cf191872 (git): Increase the number of Process.times attempts
- CI of 5806c54447439f2ba22892e4045e78dd80f96f0c did not succeed
https://travis-ci.org/github/ruby/ruby/jobs/668072714 -
- 07:45 PM Revision addf43d7 (git): * 2020-03-29 [ci skip]
-
07:44 PM Revision 2b6848af (git): [ruby/irb] Require jruby lib to get JRuby.compile_ir
- https://github.com/ruby/irb/commit/dc59afe4f6
-
06:16 PM Feature #16741 (Open): Implement Shellwords.shellescape correctly for Windows
- `shellwords` module was originally designed and developed for *NIX, and currently works like this:
```ruby
require 'shellwords'
Shellwords.shellescape("/home/me/test with space.txt")
# => "/home/me/test\\ with\\ space.txt"
She... -
02:31 PM Revision f432b5e5 (git): Fixed relative paths for test-spec
-
01:39 PM Revision 5806c544 (git): Improve reliability of the Process.times spec
-
- * Since the spec might not spend any time in system calls.
-
-
- * Otherwise it might segfault, since C has no idea of the type of varargs,
and the C code must assume all varargs are VALUE. -
- * Almost all platforms return incorrect values for Process.clock_getres,
it should be removed: https://bugs.ruby-lang.org/issues/16740 -
- In #16740 I propose to remove this API because it almost always returns incorrect and useless values.
-
- clock_getres(2) is incorrect (doesn't match the actual resolution for many clocks), buggy (e.g. can return negative values) on almost all platforms and for almost all clock_id.
This is an observation based running specs for it:
https... -
- * It segfaults on MRI.
-
10:31 AM Revision 34b0a7be (git): spec/ruby/library/rbconfig/rbconfig_spec.rb: restore "not windows" guard
- https://github.com/ruby/ruby/runs/541455267
```
1)
RbConfig::CONFIG libdir/LIBRUBY_SO is the path to libruby and it exists if and only if ENABLE_SHARED FAILED
Expected File.exist? "d:/Ruby26-x64/lib/x64-msvcrt-ruby260.dll"
to be truthy b... -
- As the currently released/snapshot tarballs should contain the
bundled gems extracted already, RUNRUBY is not required when
building from them with GNU make. -
-
-
- I think the wrong terminating argument cannot work.
To stop the noisy CI failures, the spec is tentatively suspended.
03/27/2020
-
-
-
10:59 PM Bug #16195 (Closed): Invalid certificate on https://ruby-lang.org/
- ruby-lang.org no longer has a DNS A record. And https://www.ruby-lang.org now has a valid SSL certificate. So I think this can be closed.
-
- matz (Yukihiro Matsumoto) wrote in #note-8:
> Although the use of class variables is not recommended (like global variables), proposed behavior changes introduce huge incompatibility.
> ...
I've submitted a pull request to convert the ... - 09:14 PM Revision ecf874ed (git): * 2020-03-28 [ci skip]
-
09:12 PM Bug #16738: RbConfig::CONFIG["SDKROOT"] not frozen on macOS
- ruby_2_7 5ccf57f23eb7a35ac699edc2fc598c47fa1844a0.
-
- (cherry picked from commit 501f2c44e6ae79c02a5c4d0f872fc7fa77258fcf)
-
- (cherry picked from commit c8d0bf0156878df03a71fffc97c44abf7333d5d7)
-
-
06:31 PM Bug #16737 (Closed): File::BINARY doesn't work
- Applied in changeset commit:git|e1e4ea8fa91a0c62dea69977d989d0bb2b526b64.
----------
Set external encoding correctly for File.open('f', FILE::BINARY) on Windows
Previously, the external encoding was only set correctly for
File::BINARY ... -
- I agree with @nobu that this isn't a bug on !Windows. The documentation for `File::Constants::BINARY` states "disable line code conversion", nothing about setting binary mode. I guess the constant name is a bit misleading, but due to b...
- 06:31 PM Revision d214c188 (git): * 2020-03-28 [ci skip]
-
- Previously, the external encoding was only set correctly for
File::BINARY if keyword arguments were provided. This copies
the logic for the keyword arguments case to the no keyword
arguments case. Possibly it should be refactored into ... -
- commit:54072e329cab7207fba133caba4fc12b45add8f9 was added as a feature in Ruby 2.7, and we only backport bug fixes to released versions, not features. You will have to upgrade to Ruby 2.7 if you would like this to work, using the new `:...
-
-
- This is the related commit for backporting: commit:67bb95936d241bd452f3bcfb76276e0ab61234f0.
Note that Ruby 2.5 will be moving from the normal maintenance phase to the security maintenance phase in about 4 days. -
- https://github.com/ruby/reline/commit/f4eac8c76f
-
- The test seems to fail sometimes due to a warning message of circular
require on very slow machine.
```
1) Failure:
TestDigest::TestDigestParen#test_race_mixed [/export/home/rubyci/unstable10s/tmp/build/20200326T091911Z/ruby/test/dige... -
- (cherry picked from commit 65dd50fc25f6522536d5c4749055384bde1f9371)
-
- (cherry picked from commit f5c904c2a907013e22ff74bc3686952c5448d493)
-
05:57 AM Revision 93aaa0bc (git): Allow trailing comma in hash pattern
- (cherry picked from commit d25a4f413dce6ad3a8baaf61591415b9a8cce082)
-
- As `RbConfig.expand` modifies the argument and involved `CONFIG`
values, its values should be mutable.
(cherry picked from commit 4adb2d655dcd54b28366b4d17e86b21e2b622cd1) -
05:43 AM Revision 7b513380 (git): Merge bundler-2.1.4
-
03:33 AM Revision 39c965f2 (git): [ci skip] Doc-only enhancements for Hash
- About the defalut values.
-
02:43 AM Bug #15499: Breaking behavior on ruby 2.6: rb_thread_call_without_gvl doesn't invoke unblock_function when used on the main thread
- The ff98931dac is the fix for 23444302d9 and the 23444302d9 have not been backported into ruby_2_6 branch. 23444302d9 seems a kind of performance improvement.
I will restore Backport field to 2.6: DONE. -
- I created the patch for ruby_2_6 branch (attatched file).
But the test_ar2st failed.
```
1) Failure:
TestHash#test_ar2st [/Users/nagachika/opt/ruby-2.6/src/ruby_2_6/test/ruby/test_hash.rb:1749]:
<"{0=>0, 1=>1, 2=>2, 3=>3, 4=>4...
03/26/2020
- 05:14 PM Revision 18aff426 (git): * 2020-03-27 [ci skip]
-
05:14 PM Revision 0d5db771 (git): Fix AppVeyor pull request CI (#2983)
-
- ruby_2_7 ab6f78bc926f6fc12dc8d7846056fc9c04d63ead.
-
- ruby_2_7 95c3bb6c426a11253644a86137bb67c542fd5799.
- 02:51 PM Revision 572021c6 (git): * 2020-03-26 [ci skip]
-
- ruby_2_7 2a3027b7b54a3118731f70c9e88aabbd495bb9fe.
-
- "test_close_after_socket_close" checks if ssl.close is no-op even after
the wrapped socket is closed. The test itself is fair, but the other
endpoint that is reading the SSL connection may fail with SSLError:
"SSL_read: unexpected eof w... -
12:18 PM Revision 897d4e31 (git): check ar_table first.
- RHASH_AR_TABLE_SIZE() has assertion that it is a ar_talbe.
The last commit breaks this assumption so check ar_table first.
(cherry picked from commit c3584dfacce4d0f2058d8403de6fdce4fd4d686b) -
- ar_table can be converted to st_table just after `ar_do_hash()`
function which calls `#hash` method. We need to check
the representation to detect this mutation.
[Bug #16676]
(cherry picked from commit 4c019f5a626523e99e2827ed917802e309... -
- RB_NOGVL_UBF_ASYNC_SAFE is wrongly specified because flags
is not checked.
[Bug #15499] 23444302
(cherry picked from commit ff98931daca1265e5bd33025d160c77e452c399e) -
12:18 PM Revision 2a3027b7 (git): Add missing write barrier for Hash#transform_values{,!}
- 21994b7fd686f263544fcac1616ecf3189fb78b3 removed the write barrier that
was present in rb_hash_aset(). Re-insert it to not crash during GC.
[Bug #16689]
(cherry picked from commit 713dc619f5372a645b66bef9dacee217c4101cb4) -
- (cherry picked from commit 8a6ba10f9dd456cf54de800203cf04bbe42271fb)
-
- Mainly for pry compatibility in test
https://github.com/k-tsj/power_assert/commit/dcc14cbef48d9790187fa400a5df7531d81a5971
Also include "Show full_message if available"
https://github.com/k-tsj/power_assert/commit/53ce0400bf47f722830d66... -
- 09:06 AM Revision b0b6d0a6 (git): * remove trailing spaces. [ci skip]
-
09:06 AM Revision 9e8d75e8 (git): [ruby/uri] Remove RCS keywords
- https://github.com/ruby/uri/commit/1bcb1203ad
- 09:06 AM Revision 5e9e1629 (git): [ruby/uri] Remove revision lines from comments
- https://github.com/ruby/uri/commit/f1c133a7d6
- 09:06 AM Revision 92a238a2 (git): [ruby/uri] Add support for WebSockets
- https://github.com/ruby/uri/commit/805a95786a
- 09:06 AM Revision 844ff7ea (git): [ruby/uri] Simplify construction of URI instances using parser interface.
- https://github.com/ruby/uri/commit/c145017dd7
-
- So that we don't need to search the LOAD_PATH, given that we know which
files we want to load in advance.
https://github.com/ruby/uri/commit/cbecefb788 -
08:41 AM Revision 69cd27c9 (git): [ruby/reline] Suppress error when check ambiguous char width in LANG=C
- https://github.com/ruby/reline/commit/623dffdd75
-
- https://github.com/ruby/reline/commit/2a8061daec
-
- https://github.com/ruby/reline/commit/b0f32f5de4
-
- https://github.com/ruby/reline/commit/f092519525
-
- https://github.com/ruby/reline/commit/bce7e7562b
-
- https://github.com/ruby/reline/commit/962ebf5a1b
-
- https://github.com/ruby/irb/commit/13572d8cdc
-
- The old implementation performance test code:
require 'objspace'
puts "%.5g MB" % (ObjectSpace.memsize_of_all * 0.001 * 0.001)
/\A.*\Z/ !~ ('abc' * 20_000_000)
puts "%.5g MB" % (ObjectSpace.memsize_of_all * 0.001 * 0.001... -
- https://github.com/ruby/irb/commit/0a641a69b0
-
- To fix this properly, we'd need to configure timeout for the server and
the client because waiting for compilation takes time.
Until we figure out how to do it, let me skip this.
03/25/2020
-
06:38 PM Feature #14718: Use jemalloc by default?
- I just tried this and saw dramatic reduction in memory use per time. Why isn't this the default??
-
- Thank you for the examples and links.
`filter_map` looks good enough for this to me.
In general I think we avoid adding blocks to core methods, because indeed it's not clear if people expect #map, #select or #filter_map behavior, a... -
03:31 PM Feature #16739: Allow Hash#keys and Hash#values to accept a block for filtering output
- > All it does is saves you from typing `select`. It does not look like the proposed feature makes much difference unless such situation is frequently met. Do you have any use case?
I see code that could be improved with this all the tim... -
- I doubt if it is obvious. See the following code. I believe that many people expect `.map`.
```ruby
hash.keys {|k| k.to_s }
```
If you want to avoid an intermediate array, you may want to use `.each_key` or `.filter_map`.
``... -
03:31 AM Feature #16739: Allow Hash#keys and Hash#values to accept a block for filtering output
- All it does is saves you from typing `select`. It does not look like the proposed feature makes much difference unless such situation is frequently met. Do you have any use case?
Also, the purpose of a block following the methods `keys`... - 04:19 PM Revision eaf06f45 (git): * 2020-03-26 [ci skip]
-
- RB_NOGVL_UBF_ASYNC_SAFE is wrongly specified because flags
is not checked.
[Bug #15499] 23444302 -
-
- Just noting that I have a similar (but different) proposal in #16739.
-
- Applied in changeset commit:git|4adb2d655dcd54b28366b4d17e86b21e2b622cd1.
----------
Make RbConfig::CONFIG values mutable [Bug #16738]
As `RbConfig.expand` modifies the argument and involved `CONFIG`
values, its values should be mutable. -
- As `RbConfig.expand` modifies the argument and involved `CONFIG`
values, its values should be mutable. -
-
- It's rather misleading to get `f.binmode? #=> true` and `f.external_encoding #=> #<Encoding:ASCII-8BIT>` with `'wb'` on unix-family OS.
-
- Binary mode makes sense only on Windows.
Just ignore it. -
04:58 AM Feature #1089: Stable sorting for sort and sort_by
- "sad"
It's just surprising that "depending on OS" sometimes sort is always stable. Then occasionally isn't. Without it nested `sort_by`'s don't work as you'd expect (secondary, tertiary sort), without high performance hit of the #wi...
03/24/2020
-
- Pull request submitted: https://github.com/ruby/ruby/pull/2978
This includes a GC change to prevent a use-after-free, but I'm not sure if the change introduces a memory leak. Someone that knows more about GC and in what cases iclasse... -
- This is due to the origin pointers on the module iclasses being incorrectly set to the module's origin instead of the iclass origin. Setting the origin pointers correctly requires using a stack, as the origin iclasses are created after ...
-
-
- According to bisect, the behavior was changed by commit:5069c5f5214ce68df8b3954321ad9114c5368dc3.
@jeremyevans0 Could you please check it out? -
02:09 PM Bug #16736 (Closed): Prepending blank module breaks super call in aliased method
- Here is the test script:
```
class A
def key
["some_key"]
end
end
module M
prepend Module.new
def self.included(base)
base.alias_method :base_key, :key
end
def key
super + ["new_key"]
end
... -
- I often see code like the following:
``` ruby
hash.select { |_, v| v == :some_value }.keys
hash.keys.select { |k| k.nil? || k.even? }
hash.select { |k, v| valid_key?(k) && valid_value?(v) }.values
```
Each of these code snippet... -
- The reason RbConfig entries cannot be frozen currently is because RbConfig.expand which calls String#replace.
So I think this is a bug, and we should ensure all RbConfig entries are mutable, hence the spec.
Alternatively, one could t... -
03:57 PM Bug #16738 (Closed): RbConfig::CONFIG["SDKROOT"] not frozen on macOS
- The `RbConfig::CONFIG["SDKROOT"]` is not frozen on macOS when the `SDKROOT` environment variable is set which causes the kernel spec (https://github.com/ruby/ruby/blob/1b3339528c0804aa0e673bd3f15be8b087d17bd8/spec/ruby/library/rbconfig/r...
- 04:45 PM Revision edffe78a (git): * 2020-03-25 [ci skip]
-
-
02:24 PM Bug #16737 (Closed): File::BINARY doesn't work
- `File.open` takes a `mode` argument which can be given as a string or as an integer using `File::Constants`.
When using the latter, the constant `File::BINARY` doesn't have any effect:
```ruby
# this works:
File.open('foo', 'wb')... -
-
- RubyGems chooses available one from the two: /usr/bin/env or /bin/env
https://github.com/rubygems/rubygems/blob/20b0d609484df2b514954ba9ef890a7cbdd01d18/lib/rubygems/installer.rb#L38
So, it is good not to hard-code /usr/bin/env in test... -
- 06:36 AM Revision 930b012a (git): Add rexml to fix rss of test-bundled-gems (#2976)
-
-
- This spec fails too often
https://github.com/ruby/ruby/runs/529546249
https://github.com/ruby/ruby/runs/524933256 -
- hoping to fix https://github.com/ruby/actions/runs/527422022
-
-
- And then the environment variable.
- 01:56 AM Revision 448c76be (git): * 2020-03-24 [ci skip]
-
- ... because it conflicts with test/ruby/test_m17n.rb.
An exception `incompatible character encodings: UTF-8 and UTF-16BE`
occurs when:
* a non-existence relative path is added to $LOAD_PATH,
* ASCII-incompatible encoding is set to defa...
03/23/2020
-
-
01:10 PM Bug #16702: test-all failure - JIT tests - mswin
- The last cron build of mswin passed. Haven't looked thru the commits yet.
```
Passed: ruby 2.8.0dev (2020-03-23T06:15:50Z master 13e9551b97) [x64-mswin64_140]
```
Ok to close... -
- The ruby-loco mswin build has been passing for quite a while (done three times a day).
It failed as below on test-all. Appears to be JIT related tests.
```
Failed: ruby 2.8.0dev (2020-03-23T02:32:20Z master 21d8e69248) [x64-mswin64... -
- I often see code that intends to remove a portion of the namespace from a module/class name like this:
```ruby
class A; class B class C; end end end
A::B::C.name.delete_prefix("A::") # => "B::C"
A::B::C.name.delete_prefix("A::B::")... -
- for consistency
-
-
- variable of make instead of d059714746 as requested.
You can disable this like `make MJIT_WITHOUT_TABS=false` or
`export MJIT_WITHOUT_TABS=false`. -
- in debugflags, as requested by nobu
I actually wanted to check debugflags directly rather than MJIT_DEBUGFLAGS
because debugflags is always used but MJIT_DEBUGFLAGS may not be always used.
But I couldn't find a better way to check debug... -
- On Deiban 9 environment, the thread tests failed and
this maximum threads information can finish up the machine
resources. To check it, I turned-off showing this information. -
03/22/2020
-
- rb_class_of is indented with tabs
-
- This didn't exist in my machine, but it may exist in some CI
environments. -
-
- It's to be fixed properly later. But this should be able to avoid the failure.
https://travis-ci.org/github/ruby/ruby/jobs/665580361
https://rubyci.org/logs/rubyci.s3.amazonaws.com/solaris10-gcc/ruby-master/log/20200322T190003Z.fail.htm... -
- This is necessary to avoid converting a hard tab to just 1 space in
preprocessor to generate rb_mjit_header.h, which is helpful when using
gdb or perf report.
See also: [Misc #16112]
This reverts commit 91acdd17c4b4bb69a8fa3ada46e09dad... -
- The test is executed with -j8, so printing someting to stdout may break.
-
- This is expected behavior. You can't use both named block parameters and numbered block parameters in the same block. You either need:
```ruby
i.each {|first_argument, second_argument|
pp first_argument
pp second_argume... -
04:17 PM Bug #16701: Odd output when using _1 ("ordinary parameter is defined")
- Yikes, small copy/paste typo from me above; should be
def foobar(i = @hash)
-
- I have tried to reproduce this issue into a small script, so first the code, to ease
copy/pasting (don't mind the quality; I encountered this in a larger script, so I
just tried to narrow this down):
@hash = {}
@hash['abc']... - 04:30 PM Revision f7573303 (git): * 2020-03-23 [ci skip]
-
- Applied in changeset commit:git|4f7b435c955792af780fe9e94f98d3dde839e056.
----------
Support obj.clone(freeze: true) for freezing clone
This freezes the clone even if the receiver is not frozen. It
is only for consistency with freeze:... -
- Correctly show defined class for aliases of aliases
-
- This freezes the clone even if the receiver is not frozen. It
is only for consistency with freeze: false not freezing the clone
even if the receiver is frozen.
Because Object#clone is now partially implemented in Ruby and
not fully imp... -
- http://ci.rvm.jp/logfiles/brlog.trunk-test-random.20200322-221411
```
I, [2020-03-22T22:15:50.761950 #23076] INFO -- : 1) Error:
I, [2020-03-22T22:15:50.761963 #23076] INFO -- : TestM17N#test_object_inspect_external:
I, [2020-03-22T2... -
- This test takes 40..50 seconds under Solaris 11, so the timeout (60
seconds) was too strict. This change increases it to 180 seconds.
https://rubyci.org/logs/rubyci.s3.amazonaws.com/solaris11-gcc/ruby-master/log/20200322T100007Z.fail.h... -
- This reverts commit 57119dd561418c917b885db5f5af7f129a96d1ec.
Temporarily reverting for Travis failures -
- I can't live without this when using gdb or perf report.
See also: [Misc #16112] - 04:09 AM Revision 0bed561f (git): * 2020-03-22 [ci skip]
-
- This update fixes test-bundled-gems failures:
https://github.com/ruby/actions/actions/runs/60272820
https://github.com/ruby/actions/actions/runs/60273425 -
02:23 AM Bug #16694: JIT vs hardened GCC with PCH
- On 03/21/2020 03:13 PM, takashikkbn@gmail.com wrote:
> Issue #16694 has been updated by k0kubun (Takashi Kokubun).
>
>
>> But how about performance? It has to lead to slower compilation (at least the second time). I worry about ...