Activity
From 09/06/2019 to 09/12/2019
09/12/2019
-
07:57 PM Misc #16157: What is the correct and *portable* way to do generic delegation?
- Ok, I misunderstood what `pass_keywords` was doing; I thought it would only apply to `baz(*args)` in this case.
-
03:40 PM Misc #16157: What is the correct and *portable* way to do generic delegation?
- Dan0042 (Daniel DeLorme) wrote:
> After some more thinking I believe the `pass_keywords` behavior would be appropriate for 100% of methods with an argument splat but no keywords.
We do not want this as the default behavior. Consider... -
- After some more thinking I believe the `pass_keywords` behavior would be appropriate for 100% of methods with an argument splat but no keywords.
* If forwarding to a method with no keyword arguments
* The kwarg will be converted t... -
- > Then if you call `foo` with keywords, keywords will be passed to `bar`. This should allow for more backwards compatible behavior with older versions of Ruby.
Ah, great! So we no longer need the RUBY_VERSION check!
I have a feeli... - 03:35 PM Revision 69acf40b (git): * 2019-09-13 [ci skip]
-
03:34 PM Revision bcd49a46 (git): Upgrade benchmark_driver to v0.15.5
- Fixed new Struct-related keyword argument warnings
-
11:19 AM Feature #14781 (Closed): Enumerator.generate - Applied in changeset commit:git|775037613bffe6f90e7af510b7f46a2ac10610be.
----------
Implement Enumerator.produce [Feature #14781] - 11:18 AM Revision ac3e8834 (git): Document and test Enumerator.produce
- Co-authored-by: Victor Shepelev <zverok.offline@gmail.com>
- 11:18 AM Revision 77503761 (git): Implement Enumerator.produce [Feature #14781]
-
09:43 AM Bug #16161: tailcall_optimization may be disabled after r67315
- How about adding `vm_call_iseq_setup_tailcall_opt_start` as same as `vm_call_iseq_setup_normal_opt_start`?
(Copy-and-paste code, sorry!)
```patch
diff --git a/vm_insnhelper.c b/vm_insnhelper.c
index a83e3a952a..4abee2fadd 100644
-... -
09:28 AM Revision 9f86e5ec (git): Moved coverage.yml to https://github.com/ruby/actions [ci skip]
-
09:25 AM Feature #16102: `Symbol#call`
- I propose this general solution.
diff --git a/array.c b/array.c
index 3717c3ff34..3809af01cf 100644
--- a/array.c
+++ b/array.c
@@ -6988,6 +6988,7 @@ Init_Array(void)
rb_define_method(rb_cArray, "dig"... -
06:47 AM Bug #16164: ENV.each with block returns ENV object itself, not Hash
- I remember the old pickaxe having mentioned ENV as a hash-like
object. I guess the documentation could be updated to include
e. g. specifically a .is_a? Hash check too, and explain that
ENV is not completely a "full" Hash. -
03:26 AM Bug #16164: ENV.each with block returns ENV object itself, not Hash
- That is a documentation bug.
-
01:04 AM Bug #16165: Endless ranges have inconsistency between #cover? and #include?
- For the sake of archives & potential future search engine hits - this got fixed a few days ago and will be in whatever public release of Rails comes after 6.0.0.
https://github.com/rails/rails/pull/36460
09/11/2019
-
11:41 PM Bug #16165 (Closed): Endless ranges have inconsistency between #cover? and #include?
- Closing as per your request. Thank you for your investigation anyway.
-
- Doh, this needs closing; my apologies. I had not realised that I was testing in an execution environment that had pulled in ActiveSupport from Rails 6. This seems to break `#include?` in an endless Range. When I'm careful to use "vanilla...
-
- In an endless Range, I'd expect to be able to use `#include?` just as I do with a Range that has an end value. It would amount to just a check on whether the argument was greater than or equal to the start value of that Range (and likewi...
-
- Dan0042 (Daniel DeLorme) wrote:
> Of course this is all *extremely* unconventional usage and doesn't really deserve a fix. But I thought it was weird/interesting.
Very interesting actually. However, while you think this method is wr... -
- After discussion with some other committers, I have an alternative approach in https://github.com/ruby/ruby/pull/2449. This allows you to do the following:
```ruby
class Foo
def foo(*args, &block)
bar(*args, &block)
end
... -
- > Prior to the keyword argument separation branch merge, it was not even possible for a C method to tell if it was called with keywords or called with a positional hash.
That's the same situation as ruby methods used to be in. So *th... -
09:58 PM Revision 515b1989 (git): Make NODE_ARYPTN layout consistent between Ripper and AST
- We are seeing SEGVs in CI:
http://ci.rvm.jp/results/trunk-gc-asserts@ruby-sky1/2253563
This is happening because Ripper constructs AST nodes differently than
parse.y normally does. Specifically in this case Ripper is assigning 3
`VA... -
- I added an alternative approach for handling delegate keyword warnings in https://github.com/ruby/ruby/pull/2449. This approach also uses a VM frame flag and a Module method (`Module#pass_keywords`), and allows for passing keywords thro...
-
09:24 PM Bug #16164 (Closed): ENV.each with block returns ENV object itself, not Hash
- My code:
x = ENV.each { |name, value| }
puts "Return value class: #{x.class}"
puts "Return value is a Hash? #{x.kind_of?(Hash)}"
puts "Return value is actually ENV itself? #{x.object_id == ENV.object_id}"
Its output:
Return ... -
09:23 PM Revision 21994b7f (git): Avoid rehashing keys in transform_values
- Previously, calling transform_values would call rb_hash_aset for each
key, needing to rehash it and look up its location.
Instead, we can use rb_hash_stlike_foreach_with_replace to replace the
values as we iterate without rehashing the ... -
- 06:21 PM Revision 1febb6f4 (git): * 2019-09-12 [ci skip]
-
06:20 PM Revision ed96c9f2 (git): Emit missing keyword argument separation warnings for define_method
- Previously, the warning functions skipped warning in these cases.
This removes the skipping, and uses a less descriptive warning
instead.
This affected both last argument to keyword warnings and keyword
split warnings. -
05:35 PM Bug #16159: rubyspec about time fails in Asia/Kuala_Lumpur timezone
- Also, I ran it multiple times between 11pm - 1.30am
-
- GMT+8
```
$ date +%z
+0800
``` -
03:59 PM Bug #16158: "st" Character Sequence In Regex Look-Behind Causes Illegal Pattern Error When Combined With POSIX Bracket Expressions And Case Insensitivity Flag
- Thank you both.
I can confirm the encoding being a factor. It's an issue even if it is not the default.
```
2.5.6 :013 > str = "(?<!a st)\\p{Space}".force_encoding("ISO-8859-5")
=> "(?<!a st)\\p{Space}"
2.5.6 :014 > Regexp.ne... -
- This appears to be an issue if the default encoding is UTF-8:
```
$ ruby -ve 'pat = /(?<!a st)\p{Space}/i'
ruby 2.6.4p104 (2019-08-28 revision 67798) [x86_64-openbsd]
$ LC_CTYPE=en_US.UTF-8 ruby -ve 'pat = /(?<!a st)\p{Space}/i' ... -
- I can reproduce the bug in all versions of ruby.
```
$ 2.5 ruby -ve 'pat = /(?<!a st)\p{Space}/i'
ruby 2.5.6p167 (2019-05-30 revision 67709) [x86_64-linux]
-e:1: invalid pattern in look-behind: /(?<!a st)\p{Space}/i
$ 2.6 ruby -... -
03:03 PM Misc #16152: DevelopersMeeting20190919Japan
- - [Feature #16131] Remove $SAFE, taint and trust
- What do you think about the proposed schedule?
- I am asking because this might inform the fix for [Bug #16151]
- [Feature #16123] Allow calling a private method with `self.`
... -
02:48 PM Feature #14737: Split default gems into separate directory structure
- I opened PR [1] implementing this.
[1]: https://github.com/rubygems/rubygems/pull/2909 -
-
- What you're asking for is a O(n²) operation. I'm not sure it's a good idea to make that so easy and transparent as a core method.
This is quite easy to code and makes the (inefficiency of) two loops more apparent:
```ruby
all.reject... -
12:36 PM Revision fc3bfd52 (git): Fixed the function signature to rb_rescue2
-
09:03 AM Feature #16163 (Closed): Reduce the output of `RubyVM::InstructionSequence#to_binary`
- ## Abstract
The output of `RubyVM::InstructionSequence#to_binary` is extremely large.
We have reduced the output of `#to_binary` by more than 70%.
The execution speed of `RubyVM::InstructionSequence.load_from_binary` is about 7% s... -
-
07:01 AM Revision 655c65d6 (git): &$$->nd_lit is uninitialized at this point
- See also https://travis-ci.org/ruby/ruby/jobs/583031687#L1874
-
- Bump. I would like to revisit this. Do we need this many call to malloc_usable_size()?
-
- https://docs.aws.amazon.com/cli/latest/reference/s3/sync.html
> --no-progress (boolean) File transfer progress is not displayed. This flag is only applied when the quiet and only-show-errors flags are not provided. -
- This is still an issue in the master branch. I've added a pull request for rdoc that will treat `rb_define_method` to the same C function as an alias (similar to `rb_define_alias`): https://github.com/ruby/rdoc/pull/742
09/10/2019
-
- Macros can't be expressions, that is a GNU extension (I didn't know
that). This commit converts the macro to a function so that everything
will compile correctly on non-GNU compatible compilers. -
- Dan0042 (Daniel DeLorme) wrote:
> > The only time you really need the `RUBY_VERSION` check is for complete argument delegation to arbitrary methods with arbitrary arguments.
> ...
Let's say the target method is `foo(*args, **kw)`, and ... -
- > Note that the `RUBY_VERSION` check is only needed in a subset of the cases. In cases where the target method does not accept keyword arguments, no changes are needed
Yes, I know, that's exactly what I was saying.
But my point wa... -
- Note that the `RUBY_VERSION` check is only needed in a subset of the cases. In cases where the target method does not accept keyword arguments, no changes are needed (no need to introduce keyword arguments at all). In cases where the l...
-
- Hmm, ok, that's what I was afraid of. I mean, it's not exactly a pretty solution. And it's not limited to method_missing; any method that accepts `*args` and forwards it to another method may have to be changed. Even if it doesn't have t...
-
-
07:06 PM Feature #16150: Add a way to request a frozen string from to_s
- @eregon, for context Matz recently refused a very similar change https://bugs.ruby-lang.org/issues/15836
-
08:12 AM Feature #16150: Add a way to request a frozen string from to_s
- I tried running ActiveSupport tests from Rails master on Ruby 2.6.2 + my PR, and found that one change is needed:
```
Error:
ConfigurableActiveSupport#test_configuration_accessors_are_not_available_on_instance:
FrozenError: can't m... -
- Dan0042 (Daniel DeLorme) wrote:
> But I can't agree to a backward-incompatible change without a proper deprecation period.
> ...
I'm unsure if such troubles are necessary, because the practical incompatibility might be extremely low, s... -
-
05:42 PM Feature #16144: Honor Logger#level overrides in Logger#add
- My GitHub PR was merged, so I think this can be closed.
- 05:45 PM Revision 721cab47 (git): * 2019-09-11 [ci skip]
-
- Fixes a test in RubySpec
-
- As some background for the dev meeting, I tried a couple of different approaches before this that didn't work.
One approach was to flag methods and have all positional hashes be treated as positional hashes (Ruby 3 behavior). That di... -
- Ruby 2.3.8 is no longer supported, can you please try with Ruby 2.5.6, 2.6.4, or the master branch?
-
12:33 PM Bug #16162 (Closed): Resque::DirtyExit - Child process received unhandled signal (You may have encountered a bug in the Ruby interpreter or extension libraries)
- My background jobs are all failing with the following error Resque::DirtyExit Child process received unhandled signal. After I restart the server they work for some minutes and then start failing. If I run the single jobs from Resque-sch...
-
- What timezone are you using?
-
- https://github.com/ruby/io-console/commit/4e17c90788
-
- About unused variables and a function.
https://github.com/ruby/io-console/commit/32baf54e7a -
- LONG_MAX_as_double is not needed when long is small enough to be
exactly representable as a double, e.g., IL32LLP64 platforms. -
- Silly typo.
-
- "GCC diagnostic push/pop" seems appeared at gcc 4.6.
-
- While not intuitive, I think this behavior is expected and not a bug. It is not relating to class cloning, it is due to class variable lookup. Normal class variable lookup (e.g. not using `Module#class_variable_{g,s}et`), uses crefs, m...
-
03:39 AM Revision f5024de0 (git): Remove check of ai.protocol
- Solaris 10 returns addrinfo.ai_protocol as 0, not 6.
-
- See also https://rubyci.org/logs/rubyci.s3.amazonaws.com/centos6/ruby-master/log/20190910T003005Z.fail.html.gz
-
- From my testing with `class Object; define_method(:bar) {send(:bar)}; bar end`:
1.9-2.1: SystemStackError
2.2-2.4: segfault
2.5-master: SystemStackError
As this issue appears to have been fixed, closing. If you can reproduce wit... -
-
- Addrinfo.getaddrinfo and .foreach now accepts :timeout in seconds as
a keyword argument. If getaddrinfo_a(3) is available, the timeout will be
applied for name resolution. Otherwise, it will be ignored.
Socket.tcp accepts :resolv_timeou... -
- Before r67315:
```
$ ./miniruby -v -e 'iseq = RubyVM::InstructionSequence.compile("def foo(n, s = 0);return s if n < 1;foo(n - 1, n + s); end", tailcall_optimization: true); iseq.eval; p foo(900_000)'
ruby 2.7.0dev (2019-03-20 trunk...
09/09/2019
-
- The documentation for `owner` states: `Returns the class or module that defines the method.`. The example given in the documentation shows `method` being called on a Range instance, but having an owner of Enumerable. So I don't think d...
-
- I tried on Ruby 2.5.6 and was not able to reproduce:
```
$ irb25
irb(main):001:0> pat = /(?<!a st)\p{Space}/i
=> /(?<!a st)\p{Space}/i
irb(main):002:0> pat = /(?i)(?<!a st)\p{Space}/
=> /(?i)(?<!a st)\p{Space}/
irb(main):003:0> ... -
- Sorry, bad paste on the OP with the success examples.
```
2.5.0 :007 > pat = /((?<!Costa)Mesa|Arlington(?=(\p{Space}|\p{Punct})+(AZ|Arizona)))/
=> /((?<!Costa)Mesa|Arlington(?=(\p{Space}|\p{Punct})+(AZ|Arizona)))/
2.5.0 :008 > p... -
- *This is my first Ruby bug submission. Please let me know if there is anything else that I can provide that would be helpful. Thanks for your time!*
I've tried just about as many combinations as I can think of and I have been able to ... -
- https://github.com/ruby/io-console/commit/ee648fa8bb
-
- https://github.com/ruby/io-console/commit/83e70de8ab
-
- https://github.com/ruby/io-console/commit/e6344108a1
-
- https://github.com/ruby/io-console/commit/143a9d5764
-
- https://github.com/ruby/io-console/commit/21d340e4a2
-
- https://github.com/ruby/io-console/commit/7f2b1b473d
-
- https://github.com/ruby/io-console/commit/41a6a6cace
-
- A function to query console info.
https://github.com/ruby/io-console/commit/db75a07fa3 -
- https://github.com/ruby/io-console/commit/972ceb081d
-
- Applied in changeset commit:git|00744a03d576f308d7fa586c2d04b5c1cb8fe3f4.
----------
Update documentation for Exception [ci skip]
Mostly from burdettelamar@yahoo.com (Burdette Lamar).
Implements [Misc #16156] -
- Thanks, I'll merge this shortly with some minor changes.
-
- Enhancements (in my view) to doc for class Exception.
The git diff for error.c is attached.
Affects doc only for class Exception, not its methods or subclasses.
Mostly:
- Adds headers.
- Forms some text into bullet lists.
-
- Mostly from burdettelamar@yahoo.com (Burdette Lamar).
Implements [Misc #16156] -
09:40 PM Misc #16152: DevelopersMeeting20190919Japan
- * [Misc #16160] Lazy init thread local storage (methodmissing)
* Storage for Fiber local storage of execution context for `Thread#[]` and `Thread#[]=` APIs are lazy initialized.
* I think the same pattern should be applied to real ... -
- * [Misc #16124] Let the transient heap belong to objspace (methodmissing)
* As per PR and outline of pros and cons in the issue, I think it's stable and performance enough to be coupled a little tighter to objspace instead of just bei... -
- * [Bug #16154] lib/delegate.rb issues keyword argument warnings
* `Module#pass_positional_hash` for disabling false positive warnings in delegation. This is just for 2.7 migration path. Can we commit this? -
- References PR https://github.com/ruby/ruby/pull/2295
### Why?
The `local_storage` member of execution context is lazy initialized and drives the `Thread#[]` and `Thread#[]=` APIs, which are Fiber local and not Thread local storage.... -
- This patch changes parse.y to only use `add_mark_object` in Ripper.
Previously we were seeing a bug in write barrier verification. I had
changed `add_mark_object` to execute the write barrier, but the problem
is that we had code like th... -
- This reverts commit 092f31e7e23c0ee04df987f0c0f979d036971804.
-
09:16 PM Feature #16155: Add an Array#intersection method
- connorshea (Connor Shea) wrote:
>
> ...
The question should be: is it needed? -
07:10 PM Feature #16155: Add an Array#intersection method
- shevegen (Robert A. Heiler) wrote:
> You could consider adding this to the upcoming developer meeting:
> ...
Thanks, I will :)
After thinking about the proposal a bit more, one other thing I wanted to ask was about whether we should... -
- I sort of agree with your reasoning. A slight add-on, though,
on that part:
> This would essentially just be a more readable alias for Array#&
It is probably easier to search for it (e. g. a google-search for
.intersection) than ... -
- `Array#union` and `Array#difference` were added in Ruby 2.6 ([see this bug](https://bugs.ruby-lang.org/issues/14097)), but an equivalent for `&` (intersection) was not.
I'd like to propose `Array#intersection`. This would essentially ... -
- Dan0042 (Daniel DeLorme) wrote:
> I've compiled your delegate-keyword-argument-separation branch to test this. BTW in your example it should be `respond_to?(:pass_positional_hash, true)`
> ...
Thank you for working on this and providin... -
- I've compiled your delegate-keyword-argument-separation branch to test this. BTW in your example it should be `respond_to?(:pass_positional_hash, true)`
The portability result is... Almost there, but not quite. In 2.6 and 2.7, `o.empt... -
- I haven't tested this, but I think it should work the same between 2.0 - 3.0 (assuming #16154 is accepted):
```ruby
class ProxyWithKW < BasicObject
def initialize(target)
@target = target
end
def method_missing(*a, **o,... -
- With the keyword argument changes in 2.7 we must now specify keyword arguments explicitly when doing generic delegation. But this change is not compatible with 2.6, where it adds an empty hash to the argument list of methods that do not ...
-
- Ran it 3 times and oddly enough they all fail at `Expected 1932 to equal 1933`
-
- Steps to reproduce:
1. Check out current master from Github (89c5d5a64e12cea23b230913b79c3d499bf30b12)
2. Run `autoconf`
3. Run `./configure`
4. Run `make check -- --with-openssl-dir=/usr/local/opt/openssl/lib`
Result:
```
... -
05:16 PM Bug #12984: `rescue *[]` should be equivalent to `rescue` as `method_call(*[])` is equivalent to `method_call`
- > I think it's is less surprising than rescue *no_classes to "magically" rescue StandardError
It is the current behavior that's magical. If you try to deduce what `rescue *[]` means from the primitives, it goes like this:
- `*[]` ... -
05:12 PM Feature #16146: Array .difference allow custom comparison
- As recommended I'll place in example directly here:
The feature I am requesting is to allow custom comparison of the Array #difference.
Currently it is comparing with each item's #eql and #hash but in the case of Objects you would ne... - 03:57 PM Revision 9b53a69d (git): * 2019-09-10 [ci skip]
-
-
-
-
- This is an issue for *all* delegation code. This `pass_positional_hash` workaround is ok for the stdlib, but what about gems? What if a gem wants to stay compatible with 2.6? This is a question I really don't know the answer to, so I'm a...
-
- In the current master branch, `lib/delegate.rb` (e.g. `Delegator`/`SimpleDelegator`/`DelegateClass`) does not delegate keyword arguments, leading to keyword argument warnings when using it. It is simple to fix this by changing it to del...
-
- This is a test extension so we basically want test failures rather
than a configure breakage but if there is no C++ compiler, we need
no test at all because there will be no chance for the tested
header file to be used later.
This makes... -
- Not the case of recent compilers, but compilers before C++11
rejected ruby.h, like https://ci.appveyor.com/project/ruby/ruby/builds/27225706/job/qjca7dpe204dytbd
This is supposedly because a struct with a member qualified with
a const e... -
- These variables then get their room for storage.
See also https://github.com/ruby/ruby/runs/214042030 -
-
- This reverts commit 53d21087da078cf999cc4757b03b2ff0fab4c2cf.
-
- This reverts commit 6382f5cc91ac9e36776bc854632d9a1237250da7.
test failed on Solaris. -
- Calling some syscall functions such as Dir.chroot causes SIGSYS instead
of EPERM on Android.
This change skips all tests that stops the test-suite run. -
-
- Thx.
However, I wonder if there is some explanation for disabling the test. I see a lot of comments such as `# These clocks in practice on Linux do not seem to match their reported resolution.` or `# These clocks in practice on ARM on... -
10:16 AM Revision 551edf64 (git): Reline: Fix wrong variable name
- This raised a NameError before.
-
-
- change service name to fix failed test on Solaris
-
- committed in 6382f5cc91ac9e36776bc854632d9a1237250da7
-
-
- This removes an invalid keyword argument separation warning for
code such as:
```ruby
def foo(arg)
arg
end
kw = {}
foo(*[1], **kw)
```
This warning was caused because the remove_empty_keyword_hash
was set based on a comparison with t... -
- Addrinfo.getaddrinfo and .foreach now accepts :timeout in seconds as
a keyword argument. If getaddrinfo_a(3) is available, the timeout will be
applied for name resolution. Otherwise, it will be ignored.
Socket.tcp accepts :resolv_timeou... -
- > So, let's make Symbol#to_s frozen?
> ...
That makes sense, and I agree that's the cleanest solution. There's really nothing in the contract that says `to_s` is supposed to return a non-frozen string.
But I can't agree to a backward-i... -
- Freezing strings can give us a nice performance boost, but freezing previously non-frozen strings is a backward-incompatible change which is hard to handle because the place where the string is mutated can be far from where it was frozen...
-
01:12 AM Bug #16136: String corruption in 2.6.4
- Our blog system was fixed at commit:ade1283ca276f7d589ffd3539fbc7b9817f682d5
-
- Can you file this to https://github.com/ruby/bugs.ruby-lang.org/issues?
Our tracker only handles the language issues.
09/08/2019
-
- That general approach sounds good to me, but please let me mention some caveats.
```diff
@@ -1308,8 +1310,6 @@ str_new_frozen(VALUE klass, VALUE orig)
RBASIC(str)->flags |= RBASIC(orig)->flags & STR_NOFREE;
RBASIC(orig)... -
- Probably, `STR_IS_SHARED_M` string must not get its buffer replaced.
And I don't think that memory leaks, resulted by setting `STR_NOFREE` regardless the original string, is acceptable.
Although I'm not sure why it is restricted to `... -
- My reading is that `STR_NOFREE` exists solely for strings that point to C string literals. It exists to prevent `free("literal")` which is UB.
There are checks for `STR_NOFREE` everywhere buffers are freed in case a static string shows ... -
- In addition to `STR_NOFREE` , there are more two things that I cannot understand about string representation.
* What relation is between `STR_NOFREE` and `STR_IS_SHARED_M`? `STR_IS_SHARED_M` seems to be the flag for a shared root, bu... -
- Hi @alanwu , thank you for taking time to this issue.
I may be wrong, but I think that the code path you pointed is benign itself. It calls `str_replace_shared_without_enc` which may free the string buffer. However, it does not fre... -
- ashmaroli (Ashwin Maroli) wrote:
> Similar to `Symbol#to_s`, even `nil.to_s` allocates a new string.
Right, as mentioned in the description, nil, true and false#to_s could all be frozen and cached the same way as for Symbol#to_s.
Al... -
- For methods that convert object to a string, we already have three:
* `to_s`
* `to_str`
* `inspect`
Adding yet another method (or an option for an existing method) would make the picture too complicated. It might be a good time t... -
10:10 AM Feature #16150: Add a way to request a frozen string from to_s
- Similar to `Symbol#to_s`, even `nil.to_s` allocates a new string.
``` shell
irb(main):001:0> 5.times { p nil.to_s.__id__ }
21118460
21118340
21118180
21118100
21118000
```
IMO, since `nil` is a singleton, `nil.to_s` should als... -
- PR at https://github.com/ruby/ruby/pull/2437
-
- I also tried this version which always returns the same String for a given Symbol:
```diff
diff --git a/string.c b/string.c
index 05ce0ed8d6..f306c905bc 100644
--- a/string.c
+++ b/string.c
@@ -10866,7 +10866,7 @@ sym_inspect(VAL... -
- How about specifically making Symbol#to_s return a frozen String?
I tried this trivial patch:
```diff
diff --git a/string.c b/string.c
index 05ce0ed8d6..1a0fa48a6a 100644
--- a/string.c
+++ b/string.c
@@ -10866,7 +10866,9 @@ sym... -
- > For example, String#to_s returns itself and mutating sth.to_s is therefore not safe if sth can be a String.
`String#to_s` is of course a special case. But that means if a string is currently not frozen, `to_frozen_string` would have... -
02:19 AM Feature #16150: Add a way to request a frozen string from to_s
- > For example, String#to_s returns itself and mutating sth.to_s is therefore not safe if sth can be a String.
This is a very good point. I'd love to see all immutable core types start returning frozen string but I didn't want to push ... -
- * [Feature #16150] Add a way to request a frozen string from to_s
* Can I commit https://github.com/ruby/ruby/pull/2437 (make Symbol#to_s frozen)? It seems compatible enough. What about making true/false/nil#to_s return a frozen cache... -
- * [Bug #12984] `rescue *[]` should be equivalent to `rescue` as `method_call(*[])` is equivalent to `method_call`
* I think the current behavior is expected. Can matz confirm?
* [Bug #11022] opening an eigenclass does not change the ... -
- Please comment on your favorite ticket numbers you want to ask to discuss with your *SHORT* comment or summary.
(your summary/comment will help us because we don't need to read all of the ticket comments)
*DO NOT* discuss then on thi... -
- No code changes are necessary, but we didn't have as extensive
tests for these calls previously. - 03:27 PM Revision d636feb6 (git): * 2019-09-09 [ci skip]
-
- And test-rubyspec is deprecated.
-
-
-
-
09/07/2019
-
07:56 PM Feature #16122: Data: simple immutable value object
- @palkan I have a strong **feeling** of "value object notion should be a part of the language, not an externally implemented optional thingy", but it is not easy to rationalize it.
Maybe the thing is that "value object" is a notion mos... -
- Pull request: https://github.com/ruby/ruby/pull/2435
## The bug
Run the following against master(e9bc8b3) to observe use-after-free:
```ruby
-('a' * 30).force_encoding(Encoding::ASCII)
a = ('a' * 30).force_encoding(Encoding::A... -
06:26 PM Revision e9bc8b35 (git): Behave ESC key correctly when vi command mode
-
- and add some comments.
(I confirm that `foo(**{})` allocates no hash object.) -
- This is a similar refactoring to 8c908c989077c74eed26e02912b98362e509b8a3,
but the target is compile_hash. -
-
-
- As this tool has been intended to use in a working directory,
assume that the toplevel directory is under the VCS, and SVN will
no longer be canonical. -
- nd_alen and nd_brace is the same field, but nd_brace is more suitable
for this case. -
-
- NODE_ZLIST case is handled in compile_hash, so iseq_compile_each0
doesn't have to do the same check redundantly. -
- The length of NODE_LIST chain in NODE_HASH is always even because it
represents key-value pairs. There is no need to check for the
odd-length case. -
- The array is just for a temporal buffer to create a hash, not stored in
the final iseq. -
- 03:23 PM Revision b543f5b2 (git): * 2019-09-08 [ci skip]
-
-
-
- when it's not used. This macro is not used when it's direct threaded code.
This patch is purely for readability and has no impact for any behavior. -
- graywolf (Gray Wolf) wrote:
> Out of curiosity, why is this issue closed if it was not yet backported to 2.6 branch?
Don't worry. The branch maintainers, @nagachika and @usa, are going to check all tickets whose "Backport" field is ... -
11:25 AM Bug #16136: String corruption in 2.6.4
- Out of curiosity, why is this issue closed if it was not yet backported to 2.6 branch?
-
06:53 AM Bug #16136: String corruption in 2.6.4
- @mame I'm sorry you had to do extra work to figure that out! I'll post proper reproduction steps next time :)
-
- @vcsjones Good to hear! Thank you for confirming. And your investigation by bisect was very helpful.
@deivid The most difficult part for me was to read .circleci/config.yml to reproduce the issue on my machine :-) - 01:22 PM Revision a9b63db3 (git): * remove trailing spaces. [ci skip]
-
- The original code looks unnecessarily complicated (to me).
Also, it creates a pre-allocated array only for the prefix of the array.
The new code optimizes not only the prefix but also the subsequence that
is longer than 0x40 elements.
... -
- @matz Thank you for the decision, I agree _1 is more readable than @1.
I'm a bit sad to hear that @marcandre's point about "it's only really useful for 1 unnamed argument" isn't used in this decision.
What will be the semantics of ... -
- Great idea.
This definitely has to be a new method because using `to_s(frozen: true)` would require to know if the object supports the `frozen` keyword for its `to_s` method.
As a method, the default implementation would be `to_s(*... -
- Just a short comment - I originally had to write more, but I think my statement would
be too diluted.
> Also, to_s definitions for user classes seem likely to already return
> ...
IMO, it currently can not be assumed to hold true be... -
- Another possibility: make/let #to_s methods of core types return frozen strings.
The general contract of `to_s` would become: "return a String representing the object, which might be frozen. Use `.to_s.dup` if you need a mutable string"... -
- Another idea: #to_z
-
05:22 AM Feature #16150: Add a way to request a frozen string from to_s
- Thank you for writing up the proposal. This would certainly helped my optimization case. Here’s the PR I referenced in my talk where I had to work around the allocations from calling to_s on a symbol: https://github.com/rails/rails/pull...
-
- Much of the time when a user calls to_s, they are just looking for a simple string representation to display or to interpolate into another string. In my brief exploration, the result of to_s is rarely mutated directly.
It seems that ... -
- I agree it would be best to remove the implicit taint state, and particularly the interaction with $SAFE.
FWIW, TruffleRuby already prevents setting $SAFE to anything else than 0:
https://github.com/oracle/truffleruby/blob/master/doc... -
- The same refactoring as to b601b13c7267889bf394146353c5f2b0eb488278.
-
- "popped" case can be so simple, so this change moves the branch to the
first, instead of scattering `if (popped)` branches to the main part.
Also, the return value "len" is not used. So it returns just 0 or 1. -
- With the new pattern matching:
```ruby
case 11
in n if n.positive?
p :positive
end
```
Isn't that more readable and general? -
- I fixed the spec.
Those clocks were already excluded for armv7l but not armv7hl, so I generalized to armv7. -
- Applied in changeset commit:git|324dd9d01f0c97631a2588f63231bcb651844cca.
----------
armv7l and armv7l are the same platform, generalize to armv7
[Bug #16007] -
- [Bug #16007]
-
- The core of this is that `rescue` (which means rescue StandardError) vs `rescue *classes` (which means rescue any of `classes`) is detected at parse time, not at runtime.
I think the current logic makes sense in that regard, and I think... -
- duerst (Martin Dürst) wrote:
> We want programs to be fast, and tail call optimization makes them faster.
That's not true in general.
It might make recursive methods faster, but it makes normal methods calls that happen at the end o... -
- Dan0042 (Daniel DeLorme) wrote:
> Questions:
> ...
That's heavier than a normal method call; we don't "keep" a `Thread::Backtrace::Location` now. Instances of that class are constructed on-the-fly when necessary. However if we do a "pa... -
-
-
- compile_list was for the compilation of Array literal and Hash literal.
I guess it was originally reasonable to handle them in one function, but
now, compilation of Array is very different from Hash. So the function
was complicated by m... -
- An array literal [1,2,...,301] was compiled to the following iseq:
duparray [1,2,...,300]
putobject [301]
concatarray
The Array literal optimization took every two elements maybe because it
must handle not only Array but also Has... -
- `[{}, {}, {}, ..., {}, *{}]` is wrongly created.
A big array literal is created and concatenated for every 256 elements.
The newarraykwsplat must be emitted only at the last chunk. -
-
- from array to list.
Follow up to ac50ac03aeb210763730cdc45f230e236519223d -
- and NODE_ZARRAY to NODE_ZLIST.
NODE_ARRAY is used not only by an Array literal, but also the contents
of Hash literals, method call arguments, dynamic string literals, etc.
In addition, the structure of NODE_ARRAY is a linked list, not ... -
-
-
-
-
- This were previously hidden because calls from C were not warned.
-
-
- Previously, Ruby did not warn in these cases, and in some cases
did not have the same behavior. This makes calls from C handled
the same way as calls from Ruby. -
- This makes objects created via #to_enum and related methods pass
keyword arguments as keywords.
To implement this, add a kw_splat member of struct enumerator and
struct iter_method_arg, and add rb_block_call_kw, which is the
same as rb_... -
- Also add keyword argument separation warnings for Class#new and Method#call.
To allow for keyword argument to required positional hash converstion in
cfuncs, add a vm frame flag indicating the cfunc was called with an empty
keyword hash... -
-
-
-
-
- * check --srcdir if given twice or more
* falls back to the current working directory if no --srcdir
option is given.
* define common VCS options. -
-
01:48 AM Revision 4068be1d (git): appveyor.yml - msys2 update code
- As AppVeyor's MSYS2 install gets out of date, this may require 'special' code...
This code also adds updating the database, which currently updates gcc from 9.1.0 to 9.2.0. -
- This return skips `va_end(ap)`, which is not intended, I guess.
Coverity Scan found this. -
- Fixing a bug on Windows introduced in v0.15.0
09/06/2019
-
11:06 PM Bug #16026 (Rejected): `Set#count` performance issues
- Given the discussion, I'm okay if we just reject this feature. @knu it's up to you if you want to implement it or not. Even thought it can make sense from one POV, the correct solution for most users is just to use `#size` when it's avai...
-
- jeremyevans0 (Jeremy Evans) wrote:
> Can you please submit this as a pull request to ruby/logger: https://github.com/ruby/logger/pulls
> ...
[Done](https://github.com/ruby/logger/pull/41). -
- Can you please submit this as a pull request to ruby/logger: https://github.com/ruby/logger/pulls
For feature requests and bug reports for Ruby itself, it's best to open an issue on this bug tracker, but for feature requests and bug f... -
- Applied in changeset commit:git|258843106f343d05732499dd1832958eb1bf64f0.
----------
Fix SortedSet subclasses that override initialize
The first time SortedSet#initialize is called, it overwrites
itself, then recalls #initialize, which... -
- The first time SortedSet#initialize is called, it overwrites
itself, then recalls #initialize, which results in calling the
subclass's initialize, not the current initialize.
Just inline the default initialize behavior to avoid this iss... -
- Can you please try Ruby 2.5.6 or 2.6.4 and see if the problem has already been fixed? Also, if you can reproduce the issue with one of those versions, please post the entire output from the program, not just the crash file, as the crash...
-
08:48 PM Bug #16149 (Closed): Segfault during page reload in rails
- See attached file
-
- > The explicit syntax for rescue nothing is rescue *[] :)
Splat is not part of the rescue syntax, it composes with it, the same way it composes with other constructs that take a comma separated list (invocations, not sure if there are... -
05:28 PM Feature #16147: List Comprehensions in Ruby
- sammomichael (Samuel Michael) wrote:
> shevegen (Robert A. Heiler) wrote:
> ...
Yes it is real, and yes, I should have changed it to be a feature and not a bug
> > Next, I will briefly comment on this statement:
> ...
I use Ruby's ... -
- There is nothing wrong with the current ruby syntax of using enumerables such as map/select/filter_map to generate the same type of list. But as you said ruby is all about many ways of doing things. And as many languages offer some versi...
-
- I am not sure how serious the proposal is; but I will assume, for sake of simplicity, that
the suggestion is "real". First a minor comment - it should be filed under "features"
rather than "bug", since it is a suggestion for a change, ... -
- What's wrong with existing well-established object-oriented ruby idioms?
```ruby
(1..10).to_a
(1..10).select(&:even?)
(1..10).select(&:even?).map{ |x| x**2 }
(1..10).map{ |x| x**2 }
```
or in ruby 2.7:
```ruby
(1..10).to_a... -
- ## List comprehensions are present in many languages and programmers are quite fond of their simplicity and power. Add to that the fact that Ruby has a for...in loop that is rarely used but could possibly be repurposed.
### Currently... -
- I have a gmail address on the bugs.ruby-lang.org account that's active and working. I am not receiving notifications (they are not in spam)
-
- Wow! Thanks so much for providing this solution in such a timely manner! <3
-
03:13 PM Bug #16136: String corruption in 2.6.4
- I applied the patch to ruby 2.6.4 and I cannot reproduce the issue any more. This patch appears to resolve the issue for 2.6.4. Thank you very much for taking the time to investigate the issue.
```diff
diff --git a/symbol.c b/symbo... -
- I've committed ade1283ca276f7d589ffd3539fbc7b9817f682d5, which is a workaround for the issue. I confirm that activeadmin test runs successfully with this patch.
I think that this issue is related to the fstring mechanism, but I have ... -
- Applied in changeset commit:git|ade1283ca276f7d589ffd3539fbc7b9817f682d5.
----------
Fix a use-after-free bug by avoiding rb_str_new_frozen
`str2 = rb_str_new_frozen(str1)` seems to make str1 a shared string that
refers to str2, but st... -
- I faced the same error maybe.
Our company blog generated by middleman was failed with Ruby 2.6.4 and 2.7.0 built by master branch. This issue was completely reproduced with them. We could build with Ruby 2.5.6.
I will investigate ... -
- @vcsjones You're right, my raw guess at the culprit was wrong since I just got the issue again with the ruby I built excluding the commits I mentioned. I'm going to build the same ruby you built now to confirm that the culprit is https:/...
-
- I wonder if these bugs exist on master or are specific to 2.6.4.
- 03:45 PM Revision 2d076dd5 (git): * 2019-09-07 [ci skip]
-
- It got some nice features for better support of
benchmark_driver-output-charty, Windows, ridk, and rbenv. -
- `str2 = rb_str_new_frozen(str1)` seems to make str1 a shared string that
refers to str2, but str2 is not marked as STR_IS_SHARED_M nor
STR_NOFREE.
`rb_fstring(str2)` frees str2's ptr because it is not marked, and the
free'ed pointer is t... -
-
-
-
- Kill the failing tests.
-
- https://github.com/ruby/ruby/runs/213995386#step:7:810
```
cxxanyargs.cpp
C:\Program Files (x86)\Windows Kits\10\include\10.0.17763.0\ucrt\corecrt_malloc.h(54): error C2485: '__restrict': unrecognized extended attribute
``` -
- Seems to be the same link as https://bugs.ruby-lang.org/issues/16118; so perhaps accidental double
post; could close one of these two - or perhaps both. :D
As there was not yet any comment on the other post, I'll comment briefly here... -
02:05 AM Feature #16146: Array .difference allow custom comparison
- Please provide an actual usage example directly in this issue, not only by reference.
-
- Otherwise the dynamic linker cannot find this function.
See also https://ci.appveyor.com/project/ruby/ruby/builds/27224231/job/4pg6lxlsnsjotu2l -
- Should use numeric 0 for maximum portability.
See also https://travis-ci.org/ruby/ruby/jobs/581543798 -
- See also https://github.com/ruby/ruby/runs/213964487
-
-
- Compilation of extension libraries written in C++ are reportedly
broken due to https://github.com/ruby/ruby/pull/2404
The root cause of this issue was that the definition of ANYARGS
differ between C and C++, and that of C++ is incompati... -
-
- Definitely a bug. Confirmed on master (ruby -v
ruby 2.7.0dev (2019-07-06T03:43:38Z trunk f296c260ef) [x86_64-cygwin])
"CAFÉ" =~ /x|é/i
works. So that may be an alternative until this is fixed. It may also give some hints on where th... -
- This reverts commit 433c9c00d96124e3b416d0a20ff795b0ad4273fa.
Successfully captured some traces, and
3b60e5e6bc2c84b971bea9c8312eb5d33ada2ff5 seems to fix the issue. -
- 12:50 AM Revision dd81af7b (git): * remove trailing spaces. [ci skip]
-
- mame pointed out that vm_args.c is included in vm_insnhelper.c.
-
- Hopefully this fixes MJIT errors on AppVeyor.
-
- This is the same as the bmethod, sym proc, and send cases,
where we don't remove the keyword splat, so later code can
move it to a required positional parameter and warn. -
- This is the same as the bmethod and send cases, where we don't
remove the keyword splat, so later code can move it to to a
a required positional parameter and warn. -
- The lambda case is similar to the attr_writer case, except we have
to determine the number of required parameters from the iseq
instead of being able to assume a single required parameter.
This fixes a lot of lambda tests which were swi... -
- In general, we want to ignore empty keyword hashes. The only case
where we want to allow them for backwards compatibility is when
they are necessary to satify the final required positional argument.
In that case, we want to not ignore t... -
- While doing so is not backwards compatible with Ruby 2.6, it is
necessary for generic argument forwarding to work for all methods:
```ruby
def foo(*args, **kw, &block)
bar(*args, **kw, &block)
end
```
If you do not remove empty keywo... -
- and lambda.
When define_method is a simple iseq (`define_method(:m) {|x| ... }`),
passing keywords to it (`m(**kw)`) didn't print a warning. -
- Similar to 38e9c1bc35d5549575fbb263afff560e97db068e
-
- Similar to 38e9c1bc35d5549575fbb263afff560e97db068e
-
- Now the mechanism that conveys kw_splat flag is gradually established,
so the hack to drop the empty keyword hash is not needed for
vm_call_opt_send. -
- not via Object#send which uses a fast path vm_call_opt_send.
-
- Actually, the following call is wrongly warned without this change.
```
class C
def method_missing(x, *args, **opt)
end
end
C.new.foo(k: 1)
# warning: The last argument is used as the keyword parameter
# warning: for `method_mis... -
-
-
-
- ...only when a "remove_empty_keyword_hash" flag is specified.
After CALLER_SETUP_ARG is called, `ci->flag & VM_CALL_KW_SPLAT` must not
be used. Instead. use `calling->kw_splat`. This is because
CALLER_SETUP_ARG may modify argv and upd... -
-
- There are two styles that argv contains keyword arguments: one is
VM_CALL_KWARG which contains value elements in argv (to avoid a hash
object creation if possible), and the other is VM_CALL_KW_SPLAT which
contains one last hash in argv.
... -
-
- Make rb_sym_proc_call take a flag for whether a keyword argument
is used, and use the new rb_funcall_with_block_kw function to
pass that information. -
- Otherwise the last positional hash could be considered as the
keyword arguments. -
- This is needed for C functions to call methods with keyword arguments.
This is a copy of rb_funcall_with_block with an extra argument for
the keyword flag.
There isn't a clean way to implement this that doesn't involve
changing a lot of... -
-
- I think this is easier to read than using literal 0 with comments
in every case where it is used. -
- The kw_splat flag is whether the original call passes keyword or not.
Some types of methods (e.g., bmethod and sym_proc) drops the
information. This change tries to propagate the flag to the final
callee, as far as I can. -