Activity
From 08/06/2019 to 08/12/2019
08/12/2019
-
11:59 PM Bug #11467 (Closed): Memory leak in win32 signal init
-
11:57 PM Bug #11442 (Closed): Bug: Symbols should be taintable.
- Ruby makes `taint` and `untaint` just return the receiver if called on any object that is not considered taintable. That includes all immediate objects (symbols, integers(fixnums), true, false, nil), as well as integers(bignums) and flo...
-
11:37 PM Bug #11437 (Closed): IO.pipe problem on windows console
-
11:35 PM Bug #11399 (Rejected): Regexp's free-spacing mode adding whitespace to character classes
- This is not a bug. The documentation suggestions the use of character classes if you want to match whitespace (https://docs.ruby-lang.org/en/trunk/regexp_rdoc.html#label-Free-Spacing+Mode+and+Comments).
-
11:33 PM Bug #11381 (Closed): String のサブクラスをハッシュのキーに指定した時に hash メソッドが呼ばれない
-
11:33 PM Bug #11359 (Closed): scalar_scanner segmentation fault
-
11:27 PM Bug #11261 (Closed): Time.parse of javascript formatted timestamp: wrong results in certain timezones
-
11:22 PM Bug #11214 (Closed): Cannot Get Correct Binding from inside of C Method
-
11:21 PM Bug #11205 (Closed): Problem with __dir__ or it's description
- I don't think this is a bug in `__dir__`. It's just that `__FILE__` inside `eval` depends on either the binding or file argument given to `eval` (in Ruby 3, it will only depend on the file argument, see #4352).
If you rewrite your ex... -
11:06 PM Bug #4352 (Open): [patch] Fix eval(s, b) backtrace; make eval(s, b) consistent with eval(s)
-
10:59 PM Bug #11189: alias prepended module
- ko1 (Koichi Sasada) wrote:
> ちなみに、私の予想は
> ...
This output would be against my expection. If `C1` prepends `P`, then methods in `P` must be considered before methods in `C1`. Consider `C1.ancestors`:
```ruby
[P, C1, C0, Object, Ke... -
10:23 PM Bug #11188: Method#inspect for chaining alias methods
- I agree with ko1's opinion. Attached is a patch that implements his proposal.
Note that this change cannot be made in `method_inspect`, because at that time, the necessary information has already been lost. To implement ko1's propos... -
09:13 PM Bug #14972: Net::HTTP inconsistently raises EOFError when peer closes the connection
- naruse (Yui NARUSE) wrote:
> joshc (Josh C) wrote:
> ...
If you save the first response body, and make a new request with ```Range: bytes=X-Y```, then the `Content-Length` header in the second response should specify the number of byte... -
08:44 PM Revision aac4d9d6 (git): Rename rb_gc_mark_no_pin -> rb_gc_mark_movable
- Renaming this function. "No pin" leaks some implementation details. We
just want users to know that if they mark this object, the reference may
move and they'll need to update the reference accordingly. -
06:08 PM Bug #11175 (Closed): possible fibers memory leak or risky GC behavior
-
06:02 PM Bug #11160 (Closed): Subclasses of Proc converted when passed to a block
- This was fixed between Ruby 2.2 and 2.3:
`t.rb`:
```ruby
class MyClass < Proc
end
def foo (&x)
p [:foo, x.class]
end
x = Proc.new {|&x| p [:x, x.class]}
z = MyClass.new {}
foo &z
x.call &z
```
output:
```
$ ruby2... -
05:55 PM Bug #11152: Resolv::DNS should use Search Domains provided in /etc/resolv.conf by default
- It looks like the problem is a kubernetes-specific issue. With your `resolv.conf` file, I get the following for `Resolv::DNS::Config.default_config_hash`:
```
{:nameserver=>["10.7.240.10"], :search=>["staging.svc.cluster.local", "sv... -
05:25 PM Bug #11134 (Closed): resolution of "localhost" in windows server 2012 (ipv6 over ipv4)
- I don't think this is a bug. `TCPServer.new` binds to the first address that matches for the hostname. In your example, you are explicitly binding to the IPv6 address and not the IPv4 address, so if the DNS resolution in your environme...
-
05:13 PM Bug #11102 (Closed): Segmentation fault while running the db:create command in Rails
-
05:01 PM Bug #10691 (Closed): Bad or Non-existent class names listed on 'Index of Files, Classes & Methods in Ruby' page.
- Applied in changeset commit:git|404850e13446c79fb6142f1b32b219753e5cd726.
----------
Remove documentation that fatal cannot be rescued [ci skip]
You can rescue it:
f = ObjectSpace.each_object(Class){|c| break c if c.name == 'fatal'}
b... -
05:34 AM Bug #10691: Bad or Non-existent class names listed on 'Index of Files, Classes & Methods in Ruby' page.
- ```ruby
Thread.start{Thread.stop}
begin
Thread.stop
rescue Exception => fatal
p fatal.class #=> fatal
end
``` -
04:56 AM Bug #10691: Bad or Non-existent class names listed on 'Index of Files, Classes & Methods in Ruby' page.
- The documentation is not accurate indeed.
To be accurate, it is impossible to rescue the `fatal` raised by `rb_fatal` function. -
02:49 AM Bug #10691: Bad or Non-existent class names listed on 'Index of Files, Classes & Methods in Ruby' page.
- `Complex::compatible`, `unknown`, `Rational::compatible` were removed by Ruby 2.6.0. `fatal` is still documented, but that exists even though you cannot reference it directly:
```ruby
f = ObjectSpace.each_object(Class){|c| break c i... -
04:56 PM Revision 404850e1 (git): Remove documentation that fatal cannot be rescued [ci skip]
- You can rescue it:
f = ObjectSpace.each_object(Class){|c| break c if c.name == 'fatal'}
begin
raise f
rescue f
2
end # => 2
It's not a good idea to rescue fatal exceptions you didn't generate
yourself, though.
Fixes [Bug #10691] -
04:53 PM Misc #16094 (Assigned): Allow only "Rebase and merge" or "Squash and merge" on GitHub master branch, and sync it on git.ruby-lang.org update hook
- This is almost implemented. It's still under testing and only available for admin now, but you may see some usages for testing. I'll add one more guard and then enable "write" to merge pull requests for ruby-committers team.
I also no... -
11:26 AM Misc #16094: Allow only "Rebase and merge" or "Squash and merge" on GitHub master branch, and sync it on git.ruby-lang.org update hook
- Experimentally, I'll move GitHub sync from post-receive hook to update hook, which blocks git push a little more. Still most of the behavior would be the same, but you might feel git push became slower.
-
08:09 AM Misc #16094: Allow only "Rebase and merge" or "Squash and merge" on GitHub master branch, and sync it on git.ruby-lang.org update hook
- > we found that we could automatically attach notes to "Rebase and merge"d commits on our git.ruby-lang.org's post-commit hook.
I implemented this in https://github.com/ruby/ruby-commit-hook/blob/d05f66c9df2eabe45f7cb1d8bd3d51c356144e... -
04:45 PM Revision 3979f22c (git): Explain the current status of branches [ci skip] (#2350)
- 04:34 PM Revision e688ab26 (git): * expand tabs.
-
04:34 PM Revision 6749682f (git): also unpin `final` on weak maps
-
04:34 PM Revision 76a928ba (git): Unpin default value objects
- We're already updating the location of default values, so we may as well
unpin them. -
04:29 PM Revision 4e418a6c (git): Update check_branch description a little [ci skip]
-
04:21 PM Revision 957bdfba (git): Update docs to use more natural English
- Just a few updates to make the English sound a bit more natural
-
04:03 PM Revision 0f10828f (git): Fix a typo [ci skip]
- 03:51 PM Revision 4d3fb247 (git): * 2019-08-13
-
03:48 PM Revision b8b5e7d5 (git): Stop rewriting message to include PR URL
-
02:44 PM Revision edd25382 (git): Add a quick job to be used for branch protection
-
02:28 PM Revision 8d302c91 (git): string.c (rb_str_sub, _gsub): improve the rdoc
- This change:
* Added an explanation about back references except \n and \k<n>
(\` \& \' \+ \0)
* Added an explanation about an escape (\\)
* Added some rdoc references
* Rephrased and clarified the reason why double escape is needed, ... -
11:41 AM Revision 3fc10eff (git): date_parse.c: trim off
- * ext/date/date_parse.c (date_zone_to_diff): trim off by zone name
length. -
11:41 AM Revision d96feee3 (git): date_parse.c: avoid copying
- * ext/date/date_parse.c (date_zone_to_diff): get rid of copying
the whole argument string. -
11:40 AM Revision e6a0a954 (git): Add another test for frame omitted inlining
-
11:20 AM Revision a5f93060 (git): Simplify sudo specification
-
11:11 AM Revision 18838105 (git): added --disable-install-doc to Windows workflow of GitHub Actions
- Closes: https://github.com/ruby/ruby/pull/2346
-
11:11 AM Revision ab3ab07b (git): Removed configuration of Azure Pipelines
-
11:11 AM Revision 8d50bf40 (git): Try to nmake test
-
11:11 AM Revision 0fd0f745 (git): Try to merge windows 2016 and 2019
-
11:11 AM Revision 040bf4c0 (git): Added windows-2019 workflow
-
11:11 AM Revision 981f0be6 (git): Try to nmake
-
11:11 AM Revision bbc5e97b (git): Migrate Windows 2016 env to GitHub Actions from AzurePipelines
-
10:52 AM Revision 1bec27f0 (git): Add exec to apt-get update
- to propagate exit status to travis_retry properly.
-
10:13 AM Revision f9149c55 (git): Minor wording fix in NEWS [ci skip]
- pushing a trivial commit for testing post-receive hook
-
10:02 AM Revision 066a3498 (git): Include commits notes in ChangeLog
-
09:34 AM Misc #16091 (Closed): gsub
-
08:55 AM Revision 5edf921e (git): Revert "Roughly retry `brew update` on GitHub Actions"
- This reverts commit 5ee11a95ffbf194a73d1bea300a35f5d6250d203.
Sorry, timeout(1) was missing. -
08:46 AM Revision 927a43a5 (git): Drop unused ccache
- unlike Travis, it seems not used.
-
08:44 AM Revision 5ee11a95 (git): Roughly retry `brew update` on GitHub Actions
- because it has failed often on Travis.
-
08:15 AM Feature #14164: [Suggestion] Type system for ruby 3x to be usable for e. g. rubocop or autogenerating crystal code and so forth
- >> Crystal is in many ways similar to ruby;
> ...
To the best of my memory/understanding, it is not a myth, but a _historical_ fact: Crystal started as an attempt to just make a "compiled Ruby" (probably with type system, but "invisib... -
07:37 AM Revision d5250808 (git): Try testing openssl@1.1 on GitHub Actions
- because somebody may want to remove the duplicated Travis osx usage
later. - 07:11 AM Revision 765cc17c (git): Update IRB man page
-
06:14 AM Revision 0d0ff827 (git): rb_trap_exec has been removed since 1.9
-
05:37 AM Revision b1ef1417 (git): We did not have tool/ before checkout
- anyway we don't need authorization here.
Also retry does not seem to work in the original version, so let's
extend this with retries as a separate github action later. -
05:30 AM Revision 4f10a61e (git): Stop relying on actions/checkout
- because it randomly fails on authorization like:
https://github.com/ruby/ruby/runs/190887455
Also the backoff seems too short. Maybe we need tool/travis_retry.sh for
this too.
Cloning ruby/ruby does not need authorization. We don't need... -
05:11 AM Revision 2b3d84d5 (git): Use rev-parse
- Use simpler rev-parse to check if pull request was fetched.
-
04:48 AM Bug #10453: NUM2CHR() does not perform additional bounds checks
- As `CHR` should stand for `char` type of C, so exceeding the limit of `char` will make confusion, I guess.
I'm curious for what purpose @silverhammermba needs the range check.
If it is to get a codepoint, I don't think extracting the... -
02:41 AM Bug #10453: NUM2CHR() does not perform additional bounds checks
- Attached is a patch that will add a range check to `NUM2CHR`. However, it breaks a test:
```
1) Error:
TestStringIO#test_putc_nonascii:
RangeError: value to large to convert to char: 12356
/home/jeremy/tmp/ruby/test/stringio/... -
04:45 AM Revision b1ad628c (git): Resurrect travis_wait for test-all
- as we dropped -v.
-
04:37 AM Bug #10778 (Rejected): `defined?(expr)` should be equivalent to `defined? (expr)` not `(defined? expr)`
- In Ruby, a space before an opening parenthesis often has significant meanings.
Combining `defined?(a)` higher than `&&` is considered reasonable. -
02:21 AM Bug #10778: `defined?(expr)` should be equivalent to `defined? (expr)` not `(defined? expr)`
- There isn't a description of the actual problem caused by this behavior, but I'm guessing, it is something like this:
```ruby
defined? a && defined? b # defined?(a && defined? b)
# => "expression"
defined? (a) && defined? (b) # d... -
04:02 AM Bug #11055: autoload resets private_constant
- I doubt dropping the existing constant visibility information is intentional behavior. You can work around the current behavior by resetting `private_constant`/`deprecate_constant` inside the autoloaded file, but that leads to duplicati...
- 03:59 AM Revision 63d3c4fe (git): * 2019-08-12
-
03:58 AM Revision bf1f8729 (git): Removed duplicated jobs with GitHub Actions.
- Closes: https://github.com/ruby/ruby/pull/2340
-
03:45 AM Bug #16098 (Closed): SEGV with RUBY_ISEQ_DUMP_DEBUG=to_binary make check
- I get a SEGV in `TestSetTraceFunc` when I run `env RUBY_ISEQ_DUMP_DEBUG=to_binary make check`.
The crash doesn't happen when I run just that test file with `make test-all TESTOPTS="test/ruby/test_settracefunc.rb"`.
I only investigated ... -
03:14 AM Revision ed9d59af (git): Added example filter for Linux of GitHub Actions.
-
03:14 AM Revision 8a8f680f (git): Re-use GITHUB_ACTION variables for filtering bundler examples.
-
03:14 AM Revision e96321d0 (git): Removed make check
-
03:14 AM Revision fc97aa93 (git): Fixed the world writable dirs on Ubuntu environment.
-
03:14 AM Revision cfb192a7 (git): Added test-bundled-gems to GitHub Actions
-
03:01 AM Revision 11a09d78 (git): Port ubuntu workflow based on macos
-
02:51 AM Bug #10895 (Closed): /usr/lib/ruby/2.2.0/socket.rb:232: [BUG] rb_sys_fail(getaddrinfo) - errno == 0
-
02:23 AM Bug #10655 (Closed): Segmentation fault on chef-client run
-
02:23 AM Bug #10788 (Closed): Timeout not work with socket
-
02:23 AM Bug #10789 (Closed): X-forwarded-Proto required when using Reverse Proxy
-
02:22 AM Bug #10842 (Closed): rake update to 10.4.2 -> Segmentation fault : ruby 2.1.5p273 (2014-11-13 revision 48405) [x64-mingw32]
-
01:58 AM Bug #10626 (Closed): BUS error from nesting lambda's and calls to methods defined with define_method
-
01:58 AM Bug #10632 (Closed): 2.2rc1 Fails to Compile with Mingw64 NET_LUID
08/11/2019
-
11:26 PM Bug #10314: Default argument lookup fails in Ruby 2.2 for circular shadowed variable names
- Attached is a patch to turn circular argument reference from a warning to a SyntaxError. Do we still want to do that?
-
10:00 PM Feature #14164: [Suggestion] Type system for ruby 3x to be usable for e. g. rubocop or autogenerating crystal code and so forth
- shevegen (Robert A. Heiler) wrote:
> Crystal is in many ways similar to ruby;
It really isn't. I don't know where this myth originated and why it is so widespread and persistent.
> ...
Yes, that is true. However, of the three part... -
09:34 PM Feature #14399: Add Enumerable#product
- jzakiya (Jabari Zakiya) wrote:
> That's interesting because I never intuitively understood the use of `inject`
This is bastardized from Smalltalk. In Smalltalk, method names consist of multiple words and the arguments are written in ... -
09:10 PM Feature #14781: Enumerator.generate
- zverok (Victor Shepelev) wrote:
> > However, literally as I am writing this, a thought pops into my mind: how about Enumerator::produce as the dual to Enumerable#reduce? Scala also has iterate which is the restricted variant of unfold.
... -
08:34 PM Feature #14781: Enumerator.generate
- > However, literally as I am writing this, a thought pops into my mind: how about Enumerator::produce as the dual to Enumerable#reduce? Scala also has iterate which is the restricted variant of unfold.
In the [first](https://bugs.ruby... -
08:06 PM Feature #14781: Enumerator.generate
- zverok (Victor Shepelev) wrote:
> This is alternative proposal to `Object#enumerate` (#14423), which was considered by many as a good idea, but with unsure naming and too radical (`Object` extension). This one is _less_ radical, and, at... -
10:30 AM Feature #14781: Enumerator.generate
- Attached is a patch with the implementation I initially described, and with the name Matz seems to be accepting of (`Enumerator.generate`).
I am not 100% sure about the code (as it is my first contribution to core C code), but at least ... -
08:46 PM Feature #14701: If the object is not frozen, I want to be able to redefine the compound assignment operator.
- It is possible to find sane semantics for this. [Scala](https://scala-lang.org/files/archive/spec/2.13/06-expressions.html#assignment-operators), for example, has the following semantics:
```scala
a ω= b
```
is first tried to be ... -
08:30 PM Feature #16095: 2 Features: remove (simplify) 'new' keyword and Property Shorthand
- **figured out how to do it:**
``` ruby
%P[arg1 arg2]
```
in def initialize:
``` ruby
def initialize(arg1, arg2)
%P[arg1 arg2] # equals to: @arg1 = arg1, @arg2 = arg2
end
```
in hash:
``` ruby
a = 1
b = 2
h = %p[a b]... -
08:00 AM Feature #16095: 2 Features: remove (simplify) 'new' keyword and Property Shorthand
- First, please do not mix requests for irrelevant features in one ticket.
D1mon (Dim F) wrote:
> I correctly understood that this function will be added in version 2.7? https://github.com/ruby/ruby/pull/2231/commits/7da3cdc9aa132307ef... -
07:31 AM Feature #16095: 2 Features: remove (simplify) 'new' keyword and Property Shorthand
- I correctly understood that this function will be added in version 2.7? https://github.com/ruby/ruby/pull/2231/commits/7da3cdc9aa132307eff0e4376ad6a3819940fc2d
-
07:24 AM Feature #16095: 2 Features: remove (simplify) 'new' keyword and Property Shorthand
- Feature 1: I agree that you can do anything with the help of metaprogramming, and this will have to be registered in each library. Therefore, I propose to do this at the language level (Ruby core).
-
08:26 PM Bug #10167: Prime#include?(mod) hangs up
- I've added a pull request for this at https://github.com/ruby/prime/pull/6.
-
08:01 PM Bug #9986: WEBrick content-length being set when transfer-encoding is chunked
- I added a pull request for this: https://github.com/ruby/webrick/pull/24
-
07:44 PM Bug #9868 (Closed): bigdecimal#VpAlloc causes out-of-bounds read
- I think this is fixed by https://github.com/ruby/bigdecimal/commit/e738c1377108baa0c2fd03cdee0eeb1239f627b2.
-
07:43 PM Feature #14967: Any type
- baweaver (Brandon Weaver) wrote:
> In Scala, there's the concept of an Any type which can be used to match anything.
This is a very odd characterization of `scala.Any`. In Scala, `Any` is the *top type* (in the type-theoretical sense... -
07:36 PM Bug #9836: Bad Implementation of Time.strptime
- I tried updating the patch to apply to the master branch (it is attached). It doesn't appear to handle `%W` correctly:
```ruby
str = Time.local(2019, 1, 30).strftime('%w %W %Y')
# => "3 04 2019"
Date.strptime(str, '%w %W %Y')
#... -
07:32 PM Bug #14241: Time.strptime() doesn't support the directive "%W".
- Here's an updated patch that handles `%V`, `%g`, and `%G` as well.
-
06:23 PM Bug #9822: Ruby doesn't respect system OpenSSL configuration
- I submitted a pull request to ruby-openssl to use `OPENSSL_config`: https://github.com/ruby/openssl/pull/267
-
06:23 PM Bug #9833 (Closed): OpenSSL::X509::Certificate#inspect がわかりにくくなっている
- This was fixed between Ruby 2.4 and 2.5:
```
$ ruby24 t/t.rb www.ruby-lang.org 443
#<OpenSSL::X509::Certificate: subject=#<OpenSSL::X509::Name:0x000005eb8490b120>, issuer=#<OpenSSL::X509::Name:0x000005eb8490b058>, serial=#<OpenSSL:... -
05:52 PM Bug #9774 (Closed): Net::HTTP failure to validate certificate
-
05:50 PM Bug #9759 (Closed): [TracePoint API] return event missing when raising exception
-
05:49 PM Bug #9712 (Closed): Dir.entries replace Unicode character with questionmarks
-
05:48 PM Bug #9643 (Closed): error on install dir contain space .
- This should be fixed by commit:4de117a61517e839f2c45eaf45d56fc243d6d5b2, which updated to Rubygems 2.4.1 and removed the use of `RUBYOPT` from `Gem::Ext::ExtConfBuilder.build`.
-
05:43 PM Bug #9641 (Closed): Digest libraries are built incorrectly due to ambiguous location of "extconf.h"
-
05:41 PM Bug #9504 (Feedback): X509 certificate incorrectly loaded (because of try-pem-first-else-asn1)
- I worked on implementing support for adding a :format keyword to `OpenSSL::X509::Certificate#initialize`, allowing you to specify `format: :der` if you didn't want to try loading it as a PEM. A patch for that is attached (for the ruby-o...
-
04:34 PM Bug #9564 (Rejected): Tainted string permitted in Kernel.trap in safe level 1
-
03:40 PM Bug #16097 (Closed): [PATCH] Don't accidentally name anonymous module/class
- My patch in #15765 accidentally introduced a behavior change.
`ruby -ve 'Module.new { class self::A; end; p name }'` outputs a name
similar to `Module#inspect` when it should output `nil` like in Ruby 2.6.x.
I have a pull request to... -
03:12 PM Feature #15236: add support for hash shorthand
- Well, if the syntax is misleading or intersects with an existing design. Make another syntax to work, why cancel (reject) a very cool thing which will make the code smaller (write less) and it will be nice to read the code. ? Please do n...
-
12:18 PM Bug #15965: String#grapheme_clusters does not work with wide encodings
- ruby_2_6 r67741 merged revision(s) 8aecc90974ab1ac87056f77e2cb3406c5c041504,2f6cc15cdb3d64135b29cfd5ee376a5a03ebbee7.
-
12:17 PM Revision ad6ffac7 (git): merge revision(s) 8aecc90974ab1ac87056f77e2cb3406c5c041504,2f6cc15cdb3d64135b29cfd5ee376a5a03ebbee7: [Backport #15965]
- Hoisted out WIDE_ENCODINGS
Fixed String#grapheme_clusters with wide encodings
* string.c (get_reg_grapheme_cluster): make regexp from properly
encoded sources fro wide-char encodings. [Bug #15965]
*... -
10:35 AM Misc #15996: DevelopersMeeting20190829Japan
- * [Feature #14781] `Enumerator.generate`. Patch provided; Matz seem to have liked the idea and name proposed, can we have it in 2.7?
* [Feature #14784] `Comparable#clamp` with a range. Implementation details are discussed, but generally... -
09:33 AM Misc #16096: each in each (multiple uses 'each')
- this method is not suitable since the 3rd search (find_elements) is also used.
Are you saying this is a bug? you can do issue? -
07:41 AM Misc #16094: Allow only "Rebase and merge" or "Squash and merge" on GitHub master branch, and sync it on git.ruby-lang.org update hook
- As @nobu wanted to know which commit is associated to which pull request using git without accessing GitHub, he experimented `git notes` a little bit, and we found that we could automatically attach notes to "Rebase and merge"d commits o...
-
04:29 AM Misc #16094: Allow only "Rebase and merge" or "Squash and merge" on GitHub master branch, and sync it on git.ruby-lang.org update hook
- I'm personally okay with "squash and merge" too, especially because "rebase and merge" cannot update a commit message when we want to add a thing like `[Bug #12345]`. We can allow both "rebase and merge" and "squash and merge", and make ...
-
04:16 AM Misc #16094: Allow only "Rebase and merge" or "Squash and merge" on GitHub master branch, and sync it on git.ruby-lang.org update hook
- "Rebase and merge" makes the target commits unable to track the original pull request from `git log`.
So I propose "squash and merge", or pushing a marking commit at the sync after "rebase and merge". -
07:20 AM Revision 9fe7e042 (git): Note the reference to the pull request [ci skip]
-
06:47 AM Revision 51d9d0f8 (git): Use already fetched pull request [ci skip]
-
05:15 AM Revision 1c7eadf7 (git): Debug which test hangs on mswin
- debugging failure of
https://ci.appveyor.com/project/ruby/ruby/builds/26613960/job/nemi6pvc5s5843io -
03:17 AM Revision 053bee64 (git): Cleanup the duplicated tasks on Azure Pipelines.
- Closes: https://github.com/ruby/ruby/pull/2336
-
03:17 AM Revision 91fcd87f (git): Increase fetch-depth
-
03:17 AM Revision bb2f2425 (git): GitHub Actions does not support ANSI color code. Skip failing examples.
-
03:17 AM Revision c685679e (git): Use check.
-
03:17 AM Revision e7996e0f (git): Try to migrate test-bundler to Actions.
-
02:44 AM Bug #16050: :@ is not parsed correctly
- Ah, but `:@1` is not parsed either, even though it's now (unfortunately) valid as a numbered block parameter.
Depending on how #15723 goes, `:@1` and/or `:@` should be parsed if they are valid identifiers. -
02:26 AM Feature #15192: Introduce a new "shortcut assigning" syntax to convenient setup instance variables
- Instead of an entirely new syntax maybe something like this would be good enough?
```ruby
def set_ivars_from_locals(binding, except: [])
names = binding.local_variables - except
values = eval("["+names.join(",")+"]", binding)
... -
02:01 AM Revision 6017e81b (git): Update power_assert to 1.1.5
-
01:15 AM Revision f731cc09 (git): Use `end_with?` instead of Regexp with missing escape
08/10/2019
-
11:54 PM Misc #16093 (Rejected): Prohibit a "foxtrot merge" instead of a merge commit
-
08:14 PM Misc #16093: Prohibit a "foxtrot merge" instead of a merge commit
- Looks good to me. If I'm not mistaken, neither "Rebase and merge" nor "Squash and merge" create merge commits, they are just fast forward merges, so both could be choices acceptable in the UI.
-
02:35 PM Misc #16093: Prohibit a "foxtrot merge" instead of a merge commit
- k0kubun (Takashi Kokubun) wrote:
> As @marcandre suggested, I thought of an approach to use "Rebase and merge", [Misc #16094]. In that plan, we'll be able to make a pull request "Merged" without creating a merge commit, while we continu... -
09:34 AM Misc #16093 (Feedback): Prohibit a "foxtrot merge" instead of a merge commit
- As @marcandre suggested, I thought of an approach to use "Rebase and merge", [Misc #16094]. In that plan, we'll be able to make a pull request "Merged" without creating a merge commit, while we continue to use git.ruby-lang.org as the Ru...
-
05:02 AM Misc #16093: Prohibit a "foxtrot merge" instead of a merge commit
- > I'm probably missing something, but Github allows rebasing from the UI.
GitHub UI allows "rebase and merge" but
1. Our primary repository is git.ruby-lang.org; we don't use "rebase and merge" on GitHub
2. Because of 1., we need to... -
03:52 AM Misc #16093: Prohibit a "foxtrot merge" instead of a merge commit
- Thank you for your comment.
> I'm probably missing something, but Github allows rebasing from the UI.
There are three situations:
1. The parent of a pull request's commits is master:
* It's the only situation which is *not* ... -
11:32 PM Misc #16096 (Rejected): each in each (multiple uses 'each')
- D1mon (Dim F) wrote:
> **selenium**
> ...
You probably want something like:
```ruby
driver.find_elements(xpath: "...").each do |el|
(el.find_elements(xpath: "...").to_a + el.find_elements(xpath: "...").to_a).each do |e1|
# ... -
11:15 PM Misc #16096: each in each (multiple uses 'each')
- **selenium**
``` ruby
for el in driver.find_elements(xpath: <some_xpath>)
for e1 in el.find_elements(xpath: ...)
...
end
for e2 in el.find_elements(xpath: ...)
...
end
end
```
I need to do two searches in one... -
10:35 PM Misc #16096: each in each (multiple uses 'each')
- In ruby it is in general very rare that deeply nested (and multiple) .each
are necessary.
I recommend to you to use "pp" before you run the loop, such as:
pp obj
Perhaps you have an empty Array there - that happens to me so... -
10:27 PM Misc #16096 (Feedback): each in each (multiple uses 'each')
- Can you explain what you are trying to do, and provide a self-contained example? It is not clear from the description or the code what you think the problem is. I can only guess that the object returned by `a.some_method2` has an `each...
-
09:43 PM Misc #16096 (Rejected): each in each (multiple uses 'each')
- ``` ruby
obj.each {|a|
a.some_method1.each {|b|
... # comes here (enter)
}
a.some_method2.each {|c|
... # does not enter here
}
}
# tried and that way. also does not go
for a in obj
for b ... -
11:30 PM Misc #16091: gsub
- alanwu (Alan Wu) wrote:
> `gsub(pattern, replacement)` always interprets `replacement` as a regex replacement directive.
> ...
Nice, tank you. -
04:12 AM Misc #16091: gsub
- `gsub(pattern, replacement)` always interprets `replacement` as a regex replacement directive.
You can use the block form to substitute verbatim:
```ruby
a = "test ?"
b = "?"
c = "\\&"
a.gsub(b) { c } #=> "test \\&"
```
-
12:24 AM Misc #16091: gsub
- #### on Python 3.7.1
```python
import html
def r():
a = input('Enter original:')
b = input('Enter a pattern to replace:')
c = input('Enter a replacement:')
print(f"a: {a}")
print(f"b: {b}")
print(f"c: {c}")
c = ht... -
12:05 AM Misc #16091 (Open): gsub
-
12:04 AM Misc #16091: gsub
- ```ruby
include ERB::Util
def r
puts "Enter original"
a = gets.chomp
puts "Enter a pattern to replace"
b = gets.chomp
puts "Enter a replacement"
c = gets.chomp
puts "a: #{a}"
puts "b: #{b}"
puts "c: #{c}"
... -
10:40 PM Feature #16095: 2 Features: remove (simplify) 'new' keyword and Property Shorthand
- The net-gain from removing .new would be quite minimal. I also think it is less
readable too, if .new were removed - but even well aside from this, this seems to
be backwards incompatible and may have to require a long transition time ... -
10:22 PM Feature #16095: 2 Features: remove (simplify) 'new' keyword and Property Shorthand
- D1mon (Dim F) wrote:
> 1) feature: remove 'new' keyword:
> ...
`new` is a method, not a keyword. You can already get what you want:
```
module Kernel
private
def A(arg1, arg2)
A.new(arg1, arg2)
end
end
```
Add... -
09:16 PM Feature #16095 (Rejected): 2 Features: remove (simplify) 'new' keyword and Property Shorthand
- **common use:**
``` ruby
class A
def initialize(arg1, arg2)
@arg1 = arg1
@arg2 = arg2
end
end
A.new(1,2)
```
1) feature: remove 'new' keyword:
``` ruby
A(1,2) # shorter and more comfortable
```
2) feature:... -
09:14 PM Revision 2990c2cc (git): Use capture_output instead of capture_io.
- It's preparation for migrating test-unit on upstream.
-
06:46 PM Bug #10220 (Closed): enc/trans/*.c の依存関係不足?
-
06:44 PM Bug #9017 (Closed): irb crash with message "... 'join': incompatible character encodings: ASCII-8BIT and UTF-8 ..."
- This was fixed between Ruby 2.0 and 2.1:
```
$ irb20 -I pyper/lib -r pyper
irb(main):001:0> [''].τmsτ # τ is Greek tau
ArgumentError: no method name given
/usr/local/lib/ruby/2.0/irb.rb:526:in `join': incompatible character encod... -
06:39 PM Bug #10246 (Closed): CSV.parse(csv_string, headers: col_headers) reports undefined method `table'
-
03:54 PM Feature #15912: Allow some reentrancy during TracePoint events
- Regarding your questions, `reopen` would work for me, and regarding passing events, I think a list of the events to be reopened like `TracePoint.new(*events)` would work.
If I understand what you are proposing, we would be giving full... - 03:45 PM Revision 7ee948c3 (git): * 2019-08-11
-
03:44 PM Revision d29bccb3 (git): Adjust indent [ci skip]
-
03:44 PM Revision 46df7fe9 (git): prereq.status deals with removal of nmake VPATH notations [ci skip]
-
03:18 PM Bug #10011 (Closed): Passing a string to Pathname#relative_path_from results in NoMethodError
- This was fixed between Ruby 2.5 and 2.6:
```
$ ruby25 -r pathname -e 'p Pathname.new("/usr/bin/cc").relative_path_from("/usr/bin")'
Traceback (most recent call last):
1: from -e:1:in `<main>'
/usr/local/lib/ruby/2.5/pathn... -
03:15 PM Bug #9850 (Closed): FileUtils.mv shouldn't try to make sure the owner is preserved
-
02:58 PM Bug #9365 (Closed): Sporadic TypeError (wrong argument type Thread (expected VM/thread)) from IO#close (via Net:HTTP)
-
02:57 PM Revision 0609087a (git): Parallelize osx test-all too
-
02:50 PM Bug #8770 (Closed): [PATCH] process.c: avoid EINTR from Process.spawn
-
02:49 PM Bug #8594 (Closed): [BUG] rb_update_max_fd: invalid fd (4) given
-
02:37 PM Bug #8178 (Closed): OpenSSL::PKCS7::SignerInfo
-
02:30 PM Revision c21c0017 (git): Re-enable parallel build/test on OSX
-
02:19 PM Revision 52bd4716 (git): rb_numeric_quo: support Complex
-
11:25 AM Revision c1c85770 (git): Fix wrong pull_request filter
- The specification was not triggered on a pull request.
-
10:50 AM Revision 00e7ef7e (git): Suppress flags messages [ci skip]
-
10:44 AM Revision a6c5ce7a (git): Increase the fetch-depth of GitHub Actions
- because small numbers had made Azure Pipelines in the past and it's
using 20 now. I heard GitHub Actions has more parallelism, so it should
be okay. -
10:38 AM Revision b3903ef2 (git): Set more descriptive labels to workflow
-
10:33 AM Revision 59a8003a (git): Drop confusing label from workflow
- because it's doing more than test-all
-
10:29 AM Revision 6205f955 (git): Escape asterisk on pull request paths
-
10:28 AM Revision e43b3bb4 (git): Skip running GitHub Actions on trunk
-
10:19 AM Revision 9b203959 (git): Rename workflow.yml to macos.yml
- to allow having other workflows separately, and configure `name` to
simplify a tooltip label on GitHub. -
09:30 AM Misc #16094 (Closed): Allow only "Rebase and merge" or "Squash and merge" on GitHub master branch, and sync it on git.ruby-lang.org update hook
- ## Problem
* Our pull request merge strategy confuses contributors, as described in [Misc #16093].
* In [Misc #16093], some committers did not like accepting a merge commit.
## Solution
* Allow using GitHub's "Rebase and merge" (su... -
07:33 AM Revision 5e3fb0b3 (git): Touch the checked out source to fix clock skew on all platform
-
06:48 AM Revision c5fbe2a1 (git): Moved options to $travis_apt_get_options
-
05:57 AM Bug #16087 (Third Party's Issue): Signal.trap(:INT) doesn't work on msys2 mingw64 ?
- This was due to the limit of mintty.
There can be a chance that this will be solved by mintty (and other terminal emulators for Windows) using Windows Pseudo Console in the future, I guess. -
05:38 AM Revision d69ffa4d (git): Expanded f_quo
-
05:31 AM Bug #8542: BigMath::exp modifies its first argument
- This bug is still present in the master branch. This is actually a fairly significant bug since Ruby 2.6, as starting in Ruby 2.6, BigDecimal instances are frozen and should never be mutated. Attached is a patch that fixes this issue. ...
-
05:22 AM Revision 98c22c78 (git): Expanded f_real_p
-
04:42 AM Bug #8400 (Closed): skip `Rinda::TestRingFinger` tests on platforms not implementing `getifaddrs()`
- This should be fixed by commit:66ee8a17852bb7657712afd3ac088a8b9b293d71;
-
04:36 AM Bug #8442 (Closed): sendmesg (blocking) of class BasicSocket is repeatably sent by the ruby kernel
-
04:33 AM Bug #8297: extend & inherited class variable issue
- This bug is still present in the master branch. I think the best way to fix it is to modify `Module#class_variables` for singleton classes of classes/modules to use the same lookup order as `Module#class_variable_get`:
* Singleton Cl... -
04:18 AM Revision ffdef367 (git): Warn instance variable `E`
- It is not dumped, as it is a short alias for `:encoding`.
- 02:43 AM Revision 3c3783ac (git): * expand tabs.
-
02:38 AM Revision ab31693a (git): Share caches for short encoding ivar name.
-
02:26 AM Revision 07e42e88 (git): Close created files [ci skip]
-
12:35 AM Revision 69028247 (git): Fix typo in comment [ci skip]
- s/Thtread/Thread
-
12:34 AM Revision 49f88eb2 (git): Try building workflow on push
-
12:06 AM Revision 789776be (git): Added some examples to the documentation for String#unpack1 because
- there are currently no examples and to contrast with String#unpack.
08/09/2019
-
11:59 PM Misc #16093: Prohibit a "foxtrot merge" instead of a merge commit
- Another +1 for no merge commits.
> Therefore, we have not been able to make a pull request "Merged" when a pull request's branch needs to be rebased before pushing it to the master branch.
I'm probably missing something, but Github... -
05:39 PM Misc #16093: Prohibit a "foxtrot merge" instead of a merge commit
- I updated the description according to my further investigation of the history. Thank you @mame for helping it.
I also prepared a patch to keep a consistent linear history (step 2 of the "Solution") in https://github.com/ruby/ruby-commi... -
04:33 PM Misc #16093: Prohibit a "foxtrot merge" instead of a merge commit
- Apologies, according to the chat history, it turned out that @mame was not the only person opposed to merge commits. I'll update the description to reflect the facts later.
> keep a true linear history, as I find it makes reviewing th... -
04:18 PM Misc #16093: Prohibit a "foxtrot merge" instead of a merge commit
- I prefer rebasing commits on master instead of merging to keep a true linear history, as I find it makes reviewing the history simpler. In my opinion, the "Problem" as specified in the post is not a significant issue, and the disadvanta...
-
03:13 PM Misc #16093 (Rejected): Prohibit a "foxtrot merge" instead of a merge commit
- ## Background
* When we migrated the canonical Ruby repository from Subversion to Git [Misc #14632], in that ticket nobody had objected to allowing a merge commit in the repository.
* At first, we decided to prohibit merge commits beca... -
11:33 PM Revision 9d298b9d (git): Allow Array#join to allocate smaller strings
- rb_str_buf_new always allocates at least 127 bytes of capacity, even
when less is requested.
> ObjectSpace.dump(%w[a b c].join)
{"address":"0x7f935f06ebf0", "type":"STRING", "class":"0x7f935d8b7bb0", "bytesize":3, "capacity":127... -
11:24 PM Bug #8287 (Rejected): Regexp performance issue
- From the general problem statement, and looking at the regexp's nested use of `*` and `+` along with `\g`, this regexp probably exhibits exponential backtracking. See https://docs.ruby-lang.org/en/2.6.0/Regexp.html#class-Regexp-label-Per...
-
11:23 PM Revision b1678338 (git): Fix typo: duplicated the [skip-ci]
-
10:59 PM Misc #16091 (Rejected): gsub
- This is not a bug. Ruby treats `\&` in a replacement string specially, representing the entire matched string (note that `"\\&"` is the same as `'\&'`):
```ruby
"test ?".sub("?", "1\\&2")
=> "test 1?2"
```
So `"\\&"` as a replac... -
10:54 PM Misc #16091: gsub
- @thiaguerd I don't understand - the `String#replace` method only takes one argument - you're calling it with two so that's not going to work for a start. Secondly, the method doesn't replace occurrences of one string with another, which ...
-
10:47 PM Misc #16091: gsub
- shyouhei (Shyouhei Urabe) wrote:
> Really sorry that I have to say I don't understand this report at all. Please tell us about your problem a bit more in detail.
the replacement doesn't happen
try in python and see the diff
```
... -
02:30 PM Misc #16091: gsub
- Really sorry that I have to say I don't understand this report at all. Please tell us about your problem a bit more in detail.
-
10:36 AM Misc #16091 (Feedback): gsub
-
10:10 AM Misc #16091 (Closed): gsub
- ```ruby
a = "test ?"
b = "?"
c = "\\&"
a.gsub(b,c)
``` -
09:25 PM Bug #8219 (Rejected): ruby 2.0.0-p0 socket.recv MSG_OOB problem?
- This issue appears to be specific to Windows, and the master branch still has the same behavior as Ruby 2.0. I do not think this is a bug. Windows appears to allow multiple TCP OOB bytes, where most other implements support only a singl...
-
09:24 PM Bug #16087: Signal.trap(:INT) doesn't work on msys2 mingw64 ?
- I checked:
```
ruby 2.7.0dev (2019-08-09T15:04:06Z master 8d7e0159c0) [x64-mingw32] ruby-loco
ruby 2.6.3p62 (2019-04-16 revision 67580) [x64-mingw32] RubyInstaller2 / OneClick
```
JFYI, tried both in a PowerSh... -
06:51 PM Bug #16092 (Feedback): [doc] precedence of modifier-rescue
- Ok, I'm starting to see. The difference between statements and expressions is why we get this
```ruby
puts( 1 if 2 ) #=> SyntaxError
puts((1 if 2)) #=> 1
puts(if 2;1;end) #=> 1 ...interesting
puts( 1 rescue 2 ) #=> SyntaxErr... -
02:48 PM Bug #16092 (Rejected): [doc] precedence of modifier-rescue
- The current doc about precedence is correct. The behavior you showed is not caused by precedence, but by the grammer itself.
The point is, that `<stmt> rescue <stmt>` is a statement, not an expression. The right side of modifier-if ... -
02:18 PM Bug #16092 (Closed): [doc] precedence of modifier-rescue
- The docs state that modifier-rescue has higher precedence than assignments which have higher precedence than modifier-if. This is true for
`v = expr rescue $! if condition` but not for
`v = expr if condition rescue $!` which is treated... -
04:41 PM Revision 162cf287 (git): Init function is need to link statically
-
04:38 PM Bug #14689: bootsnap gets object index out of range: 266287972352 (IndexError) since r63113
- Would it be possible to backport this patch for ruby2.5? Debian has unfortunately not yet updated to 2.6 and the bug affects Debian's sparc64 port.
The patch as-is doesn't apply to the 2.5 tree. -
04:28 PM Feature #8239 (Closed): Inline rescue bug
- Applied in changeset commit:git|53b3be5d58a9bf1efce229b3dce723f96e820c79.
----------
Fix parsing of mutiple assignment with rescue modifier
Single assignment with rescue modifier applies rescue to the RHS:
a = raise rescue 1 # a = (... -
04:28 PM Bug #8279 (Closed): Single-line rescue parsing
- Applied in changeset commit:git|53b3be5d58a9bf1efce229b3dce723f96e820c79.
----------
Fix parsing of mutiple assignment with rescue modifier
Single assignment with rescue modifier applies rescue to the RHS:
a = raise rescue 1 # a = (... -
05:57 AM Bug #8279: Single-line rescue parsing
- Thank you, it seems fine. I've missed this at all.
-
03:12 AM Bug #8279: Single-line rescue parsing
- This bug is still present in the master branch. Attached is a patch that fixes it, so that multiple assignment with rescue modifier is consistent with single assignment with rescue modifier. After the patch:
```
a = raise rescue 1 #... -
04:25 PM Revision 53b3be5d (git): Fix parsing of mutiple assignment with rescue modifier
- Single assignment with rescue modifier applies rescue to the RHS:
a = raise rescue 1 # a = (raise rescue 1)
Previously, multiple assignment with rescue modifier applied rescue
to the entire expression:
a, b = raise rescue [1, 2] #... -
04:05 PM Revision cecae859 (git): Removed unnecessary headers
-
04:04 PM Revision 88db6fa4 (git): Use ENC_REPLICATE to copy an encoding
- 03:04 PM Revision 8d7e0159 (git): * 2019-08-10
-
03:01 PM Revision a8ba22cd (git): Revert "Removed unused includes"
- This reverts commit c9eb8f82e9febeb634a23bec6aeea915eb25fe26.
The change caused "implicit declaration" warning and actual segfault.
```
/tmp/ruby/v2/src/trunk-gc-asserts/enc/gb2312.c: In function ‘Init_gb2312’:
/tmp/ruby/v2/src/trunk-g... -
02:28 PM Bug #15952: Issue with Array#unshift, sometimes doesn't respect frozenness of array
- ruby_2_6 r67740 merged revision(s) ec8e5f5aa64e2a54cf1e303f2b012c98e8d521ba,5a187e26adc8aa32367f294c1496935c7356d386.
-
02:28 PM Revision e68627da (git): merge revision(s) ec8e5f5aa64e2a54cf1e303f2b012c98e8d521ba,5a187e26adc8aa32367f294c1496935c7356d386: [Backport #15952]
- array.c: always check frozenness in Array#unshift. Fixes [Bug #15952]
Closes: https://github.com/ruby/ruby/pull/2251
array.c add back shared array optimization to
ary_ensure_room_for_unshift
Bug fix in... -
02:10 PM Revision 314b50d7 (git): #include <> for system headers
-
02:08 PM Revision c9eb8f82 (git): Removed unused includes
-
01:48 PM Revision 3ddbba84 (git): gc.c: Double STACKFRAME_FOR_CALL_CFUNC (1024->2048)
- ef64ab917eec02491f6bf7233a4031a8c35385e3 didn't fix the issue, so the
size seems not enough yet.
https://rubyci.org/logs/rubyci.s3.amazonaws.com/osx1014/ruby-master/log/20190809T114503Z.fail.html.gz -
01:42 PM Bug #15946: Undefined behavior can occur with memcpy in String#sub!
- ruby_2_6 r67739 merged revision(s) 8f51da5d41f0642d5a971e4223d1ba14643c6398.
-
01:42 PM Revision ec1666eb (git): merge revision(s) 8f51da5d41f0642d5a971e4223d1ba14643c6398: [Backport #15946]
- Get rid of undefined behavior
* string.c (rb_str_sub_bang): str and repl can be same.
[Bug #15946]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_6@67739 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
01:41 PM Bug #15937: Segmentation fault when String#initialize given same string with capacity field
- ruby_2_6 r67738 merged revision(s) 28678997e40869f5591eae60edd9757334426ffb,8797f48373dcfa3ff8e748667732dea8aea4347e.
-
01:41 PM Revision ce0d99e4 (git): merge revision(s) 28678997e40869f5591eae60edd9757334426ffb,8797f48373dcfa3ff8e748667732dea8aea4347e: [Backport #15937]
- Preserve the string content at self-copying
* string.c (rb_str_init): preserve the embedded content when
self-copying with a capacity. [Bug #15937]
New buffer for shared string
* string.c (rb_str_ini... -
10:04 AM Feature #16090: RUBY_ON_BUG envval to debug
- In general I think this is fine (if we don't forget to document it :) ).
It would give people a way to influence the behaviour there, if they need to,
e. g. the example you gave via using "gdb -p". So this is a convenience
feature ... -
08:43 AM Feature #16090 (Closed): RUBY_ON_BUG envval to debug
- How about to introduce `RUBY_ON_BUG` environment variable which specify the command launched at `rb_bug()`?
`RUBY_ON_BUG='gdb -p' ruby ...`
In this case, `gdb -p [PID]` is invoked when `rb_bug()` is called.
after that, we can spy ... -
08:48 AM Revision 63384591 (git): restore timeout
-
08:31 AM Revision ef64ab91 (git): gc.c: Increase STACKFRAME_FOR_CALL_CFUNC
- On macOS Mojave, the child process invoked in TestFiber#test_stack_size
gets stuck because the stack overflow detection is too late.
(ko1 figured out the mechanism of the failure.)
This change attempts to detect stack overflow earlier. -
08:07 AM Bug #7877: E::Lazy#with_index should be lazy
- Thank you, I've missed it.
-
07:36 AM Bug #16086 (Closed): OpenStruct method access with a block does not raise
-
07:36 AM Bug #16086: OpenStruct method access with a block does not raise
- > That is OpenStruct, an undefined key does not raise an exception.
> ...
Right, this behavior seems to be universal:
```ruby
> { foo: :bar }[:foo] { 'hello' }
=> :bar
> ...
=> 1
```
> I haven't seen such behavior.
> ...
Hm... -
07:29 AM Revision a4a2dd79 (git): Revert a6e32855d079e8f3806d8be8a5f5cf7b3a967133 partially
- Fix TypeError when typing `''.[TAB]`
-
07:08 AM Revision 3cbd56d5 (git): complement `test_` prefix.
- `make test-all TESTS=name` can specify running test files by name.
name can be dirname ('dir/') or a file ('.../test_foo.rb'). This
patch complement `test_` prefix for a test. So we only need to
specify `TESTS=ruby/hash` which means `TES... -
06:23 AM Revision 26cf4c91 (git): extend timeout to debug.
-
05:11 AM Revision 3b39cc6b (git): gc.h is required on mswin build.
- thread.c requires gc.h on mswin build. Sorry.
-
05:01 AM Revision 6bf8db9a (git): add rp() and bp() in internal.h.
- debug utility macro rp() (rp_m()) and bp() are introduced.
* rp(obj) shows obj information w/o any side-effect to STDERR.
* rp_m(m, obj) is similar to rp(obj), but show m before.
* bp() is alias of ruby_debug_breakpoint(), which is regis... -
04:15 AM Revision cb390e87 (git): Add more runners
- Closes: https://github.com/ruby/ruby/pull/2327
-
04:15 AM Revision 54bdfe27 (git): Run macOS tests on GitHub Actions
- This commit sets up the CI integration on GitHub Actions. We should
give it a try because queue times are lower and I think we get more
CPUs.
Closes: https://github.com/ruby/ruby/pull/2327
Co-Authored-By: John Hawthorn <john@hawthorn.... -
04:08 AM Revision 37eefb11 (git): remove useless include and dependency
-
04:04 AM Revision a9fd5705 (git): double memory limit on MJIT.
- On test with MJIT, sometimes it fails like:
http://ci.rvm.jp/results/trunk-mjit-wait@silicon-docker/2189967 -
02:39 AM Revision 0176e74d (git): Add missing dependency
- just fix CI failure
https://travis-ci.org/ruby/ruby/jobs/569625233 -
02:35 AM Misc #16089: Explain that github prs do not get merged
- Good news is, yesterday I discussed this issue with @mame who was the person opposed to having a merge commit, and we got an idea to solve his problems.
Once it's implemented (work in progress; @mame implemented one, and I'm going to ... -
02:13 AM Bug #15877: Incorrect constant lookup result in method on cloned class
- > solve "duplicate :raise event" [Bug #15877]
sorry my mistake :p -
02:11 AM Bug #15877 (Closed): Incorrect constant lookup result in method on cloned class
- Applied in changeset commit:git|71efad1ed391ee0c5398a76306fdbaaadd4dc52e.
----------
introduce RCLASS_CLONED flag for inline cache.
Methods on duplicated class/module refer same constant inline
cache (IC). Constant access lookup should... - 02:11 AM Revision 4e9382a8 (git): * expand tabs.
-
02:05 AM Revision 71efad1e (git): introduce RCLASS_CLONED flag for inline cache.
- Methods on duplicated class/module refer same constant inline
cache (IC). Constant access lookup should be done for cloned
class/modules but inline cache doesn't check it.
To check it, this patch introduce new RCLASS_CLONED flag which
ar...
08/08/2019
-
11:26 PM Bug #8178: OpenSSL::PKCS7::SignerInfo
- I submitted a pull request upstream to remove the `OpenSSL::PKCS7::SignerInfo#name` method: https://github.com/ruby/openssl/pull/266
-
11:18 PM Bug #14972: Net::HTTP inconsistently raises EOFError when peer closes the connection
- When a range is requested, the content-length of the response is the number of bytes in the partial response, so I would still expect an exception to be raised if the partial response is truncated:
```
$ curl -s -v -r 0-100 -O http... -
11:04 PM Bug #8067 (Closed): Checking a network connection in a loop never succeeds even if the connection is available.
-
11:01 PM Bug #8039: DRB/dRuby server throws an exception when probed on its port
- This bug is still present in the master branch. I've updated drbrain's patch to apply to the master branch, including adding some additional exceptions to rescue.
-
09:38 PM Feature #15939: Dump symbols reference to their fstr in ObjectSpace.dump()
- > Do you need a list of String objects referenced from static symbols?
It would be useful yes. Because otherwise you might see strings with only one reference and thing that you could reclaim there by removing that reference, but in r... -
05:38 AM Feature #15939: Dump symbols reference to their fstr in ObjectSpace.dump()
- Do you need a list of String objects referenced from static symbols?
-
08:54 PM Bug #7881 (Closed): Windows でパスに日本語を含むスクリプトからの require が失敗する
- This appears to have been fixed between Ruby 2.4 and 2.5:
```
D:\テスト>c:\Ruby24-x64\bin\ruby a.rb
a.rb: No such file or directory @ realpath_rec - D:/??? (Errno::ENOENT)
D:\テスト>c:\Ruby25-x64\bin\ruby a.rb
No Problem.
``` -
08:45 PM Bug #7877: E::Lazy#with_index should be lazy
- This bug is still present in the master branch. I've updated nobu's patch to apply to the master branch, which required a significant rewrite. The updated patch is attached.
-
08:10 PM Feature #13241: Method(s) to access Unicode properties for characters/strings
- I had a go at this, and a naive implementation is quite simple. The only issue really is where to store the list of unicode properties.
```ruby
class String
def unicode_properties(*categs)
@@props ||= Hash.new.tap do |hash|
... -
06:29 PM Revision c7acb372 (git): Enable GitHub Actions on Ruby
- This just enables GitHub actions on our repository so we can try it out.
-
05:09 PM Bug #7844: include/prepend satisfiable module dependencies are not satisfied
- This is still a bug in the master branch. I think the main problem in this example is that when calling `Module#include`, you can get a module inserted before the receiver in the lookup chain instead of behind the receiver.
mame correc... -
04:39 PM Misc #16089 (Closed): Explain that github prs do not get merged
- I've updated the wiki to reflect this. If you think additional changes are needed, please reply.
-
04:20 PM Misc #16089: Explain that github prs do not get merged
- I actually realize that this is wrong & that technically it's "accepted pull requests are _often_ closed, not merged, because..."
-
04:19 PM Misc #16089 (Closed): Explain that github prs do not get merged
- The fact that fixes which are accepted still get closed, rather than being merged, is confusing. The (easiest) solution is to modify
https://bugs.ruby-lang.org/projects/ruby/wiki/HowToContribute
Change submit section to something l... -
04:32 PM Bug #16088 (Closed): [patch] Call #to_binary on iseq containing pattern match crashes
- Applied in changeset commit:git|050b932152fb3004c78af223186afe1aa397f06f.
----------
Iseq#to_binary: Add support for NoMatchingPatternError and TypeError
Binary dumping the iseq for `case foo in []; end` used to crash as
there was no h... -
03:33 PM Bug #16088 (Closed): [patch] Call #to_binary on iseq containing pattern match crashes
- Crasher: `miniruby -e 'RubyVM::InstructionSequence.compile("case foo in []; end").to_binary'`
It crashes since there is no handling for dumping `TypeError` and `NoMatchingPatternError` in the binary dumper.
Patch: https://github.com/ru... - 04:32 PM Revision 57288f5d (git): * expand tabs.
-
04:29 PM Revision 050b9321 (git): Iseq#to_binary: Add support for NoMatchingPatternError and TypeError
- Binary dumping the iseq for `case foo in []; end` used to crash as
there was no handling for these exception classes.
Pattern matching generates these classes as operands to `putobject`.
[Bug #16088]
Closes: https://github.com/ruby/rub... -
04:27 PM Revision 830fd041 (git): C99 allows trailing comma in enum
- 03:16 PM Revision c0f49438 (git): * 2019-08-09
-
03:12 PM Revision ad3f7a36 (git): Should require without wrapper module
-
02:35 PM Bug #16087 (Third Party's Issue): Signal.trap(:INT) doesn't work on msys2 mingw64 ?
- My environment is Windows 10 msys2 mingw64
```
yama@JPC00183513 ~/b/p/sample> uname -a
MINGW64_NT-10.0-17763 JPC00183513 3.0.7-338.x86_64 2019-05-27 06:58 UTC x86_64 Msys
yama@JPC00183513 ~/b/p/sample> ruby --version
ruby 2.6.3p62... -
01:40 PM Revision a2067387 (git): Remove temporary directory [ci skip]
-
01:36 PM Revision a9b9f9d1 (git): Revert "Drop -j from msys2 build for debugging"
- This reverts commit b1594ca3d6b72edb60927418482652ce93209499.
Revert "Debug appveyor mingw failure"
This reverts commit fa29f65416f1fb3d734a279855728bb0616dbb34.
Though I preserved V=1 for future debugging. -
01:30 PM Bug #15877 (Open): Incorrect constant lookup result in method on cloned class
- I copied the wrong commit log, sorry.
-
12:31 PM Bug #15877 (Closed): Incorrect constant lookup result in method on cloned class
- Applied in changeset commit:git|76bd0714cf1140ffd64bf564446c76c54f2c4870.
----------
solve "duplicate :raise event" in require too [Bug #15877] -
09:46 AM Bug #15877 (Assigned): Incorrect constant lookup result in method on cloned class
- Re-open. This ticket has been closed accidentally by b004d3e8.
I'll correct commit link. -
08:59 AM Bug #15877 (Closed): Incorrect constant lookup result in method on cloned class
- Applied in changeset commit:git|b004d3e8300ba803d4a499148fa4fc6a690149e6.
----------
solve "duplicate :raise event" [Bug #15877]
Without this patch, "raise" event invoked twice when raise an
exception in "load"ed script.
This patch by ... -
01:28 PM Revision 995c2e95 (git): Reduce unnecessary EXEC_TAG in require
-
01:22 PM Bug #16086 (Feedback): OpenStruct method access with a block does not raise
- kke (Kimmo Lehto) wrote:
> This can cause confusion.
> ...
That is `OpenStruct`, an undefined key does not raise an exception.
And an unused block is silently ignored in common.
> A defined key with a block seems to yield the value... -
08:56 AM Bug #16086 (Closed): OpenStruct method access with a block does not raise
- This can cause confusion.
```ruby
> OpenStruct.new(hello: 'world').each { |k, v| puts k.upcase } # there's no "each" method
=> nil
> OpenStruct.new(hello: 'world').eahc_pair { |k, v| puts k.upcase } # each_pair typo
=> nil... -
01:18 PM Revision 2a6d7fad (git): Arrange installed packages like ruby-loco
- to fix a build error like:
https://ci.appveyor.com/project/ruby/ruby/builds/26547644/job/4j7n41e7in97a9kx
Basically copy-pasted what's currently done in MSP-Greg/ruby-loco.
Co-Authored-By: MSP-Greg <greg.mpls@gmail.com> -
12:27 PM Revision 76bd0714 (git): solve "duplicate :raise event" in require too [Bug #15877]
-
12:27 PM Revision 3d87b774 (git): Use `ec` instead of `th->ec` where the `th` came from the `ec`
-
11:37 AM Revision b1594ca3 (git): Drop -j from msys2 build for debugging
-
09:43 AM Bug #15885 (Closed): Duplicated `:raise` tracepoint event when exception inside `load` call happens
- The patch seems committed at b004d3e8300ba803d4a499148fa4fc6a690149e6. (ticket number reference miss).
- 08:59 AM Revision 29bdfeb0 (git): * expand tabs.
-
08:56 AM Revision b004d3e8 (git): solve "duplicate :raise event" [Bug #15877]
- Without this patch, "raise" event invoked twice when raise an
exception in "load"ed script.
This patch by danielwaterworth (Daniel Waterworth).
[Bug #15877] -
08:36 AM Revision 20cb8e8a (git): main.c: Add doxygen mainpage
- The document is experimentally produced in:
https://rubyci.s3.amazonaws.com/doxygen/modules.html -
08:19 AM Revision b39efb16 (git): Aliases capture_output to capture_io for test-unit compatiblity.
-
05:50 AM Feature #15912: Allow some reentrancy during TracePoint events
- In this case, your solution (allow fire different type of trace) because the problematic case `:line` event and `:class` event are different.
However, maybe it is accidentally. Someone can use `:line` event as usual.
`reopen` will al... -
05:26 AM Feature #15963 (Closed): Add *_start and *_running methods to VM_COLLECT_USAGE_DETAILS API
- Thank you, committed!
1ad0f4e593563d460e3015fc4a2542ce1bb80d6e -
05:22 AM Revision 1ad0f4e5 (git): Add *_clear methods to VM_COLLECT_USAGE_DETAILS API
- Add RubyVM::USAGE_ANALYSIS_INSN_CLEAR, RubyVM::USAGE_ANALYSIS_OPERAND_CLEAR,
and RubyVM::USAGE_ANALYSIS_REGISTER_CLEAR to clear VM instruction hash constants.
Closes: https://github.com/ruby/ruby/pull/2258 -
05:22 AM Revision 1c7d3a13 (git): Add *_start and *_running methods to VM_COLLECT_USAGE_DETAILS API
- Add RubyVM::USAGE_ANALYSIS_INSN_START, RubyVM::USAGE_ANALYSIS_OPERAND_START,
and RubyVM::USAGE_ANALYSIS_REGISTER_START to begin collecting VM instructions.
Add RubyVM::USAGE_ANALYSIS_INSN_RUNNING, RubyVM::USAGE_ANALYSIS_OPERAND_RUNNING,... -
12:17 AM Bug #16085 (Third Party's Issue): when running rspec I get this issue
-
12:14 AM Bug #16085 (Third Party's Issue): when running rspec I get this issue
- Attached the crash log, Not much initial investigation done yet..
08/07/2019
-
11:10 PM Bug #16052: net/http get_fields doesn't return correct value for set-cookie
- I think this was changed in #15394. Since the symbol and the string both refer to the same header, I think it's reasonable to treat them the same.
-
02:25 PM Bug #16052 (Closed): net/http get_fields doesn't return correct value for set-cookie
- This is the code that reproduces the problem:
``` ruby
require 'net/http'
require 'net/https'
path = "/authorize?client_id=kbyuFDidLLm280LIwVFiazOqjO3ty8KH&response_type=code"
http = Net::HTTP.new('samples.auth0.com', 44... -
06:08 PM Bug #7833: DRb has problems with BasicObject
- This is still a bug in the master branch. Attached is a patch that fixes the issue. It's a decent size patch as there are many parts of drb that need to be modified to handle BasicObject instances. This patch also fixes a bug in the r...
-
05:36 PM Revision 70fd0992 (git): Add a way to print debug counters without exiting
- I am trying to study debug counters inside a Rails application.
Accessing debug counters by killing the process is hard because child
processes don't get the same TRAP as the parent, and Rails seems to
intercept calls to `exit`. Adding ... -
04:42 PM Bug #7806 (Closed): inconsistency between Method#inspect and Method#name
-
04:36 PM Bug #7615 (Closed): assignment to context variable changes the precedence order of function call with followed by ' (' (whitespace-bracket)
- This was fixed between Ruby 2.4 and 2.5:
```
$ ruby24 -e '
> def foo(x); 99; end
> ...
a: 99 b: 9
$ ruby25 -e '
> def foo(x); 99; end
> ...
a: 99 b: 99
``` -
04:33 PM Bug #7537 (Closed): OptionParser treats negative digits as options
- I don't think this is a bug, I think this is expected behavior. When parsing `-p -1`, where `-p` accepts an optional argument, OptionParser correctly treats the `-1` as a new option, and raises an error as the parser does not accept that...
-
04:31 PM Bug #16051: Backport 43730256e800dd8e0c5cc482e9861868590ae037 and 1e54903684aa3c9ea3fe54520157846a1b1f07be
- ruby_2_6 r67737 merged revision(s) ae2a904ce9bffedee7d110dc60fd51c0a2879a5b,165ddfda20f6db8a3149d14c4f431fc242ddab70,fa7a768fdfe5223a29db4fa71b3e6101fb02ad51.
-
12:42 PM Bug #16051: Backport 43730256e800dd8e0c5cc482e9861868590ae037 and 1e54903684aa3c9ea3fe54520157846a1b1f07be
- Ah, the following 3 commits may be also required for rubygems tests.
https://github.com/ruby/ruby/commit/ae2a904ce9bffedee7d110dc60fd51c0a2879a5b
https://github.com/ruby/ruby/commit/165ddfda20f6db8a3149d14c4f431fc242ddab70
https://g... -
12:38 PM Bug #16051: Backport 43730256e800dd8e0c5cc482e9861868590ae037 and 1e54903684aa3c9ea3fe54520157846a1b1f07be
- ruby_2_6 r67735 merged revision(s) 1e54903684aa3c9ea3fe54520157846a1b1f07be.
-
12:35 PM Bug #16051 (Closed): Backport 43730256e800dd8e0c5cc482e9861868590ae037 and 1e54903684aa3c9ea3fe54520157846a1b1f07be
- This is a ticket for backport management.
Re-generate stronger certifications and private keys to pass tests on OpenSSL 1.1.1.
43730256e800dd8e0c5cc482e9861868590ae037 for open-uri tests.
1e54903684aa3c9ea3fe54520157846a1b1f07be f... -
04:30 PM Revision 0e5d4b32 (git): merge revision(s) ae2a904ce9bffedee7d110dc60fd51c0a2879a5b,165ddfda20f6db8a3149d14c4f431fc242ddab70,fa7a768fdfe5223a29db4fa71b3e6101fb02ad51: [Backport #16051]
- Update the certificate files to make the test pass on Debian 10
The old certificate files (for example, test/rubygems/ca_cert.pem) were
signed by SHA1. This message digest is considered too weak and rejected
by ... -
04:14 PM Bug #7522: Non-core "Type()" Kernel methods return new objects
- This issue still exists in the master branch, and while it isn't a bug, I think we should make the change. This change should cause no issues for BigDecimal and Complex, since those instances are already frozen. It could potentially ca...
-
03:42 PM Bug #7491 (Closed): BigMath.#exp に Float、Rational を指定できない
-
03:39 PM Bug #7469 (Closed): WEBrick "Could not determine content-length of response body. Set content-length of the response..." even when content-length is set
-
03:39 PM Bug #7460 (Closed): メインスレッド終了後のサブスレッド終了待ち処理においてデッドロック検知が動作していない
-
03:37 PM Bug #7391 (Closed): Allow to use require_relative from eval and irb environment
- `require_relative` works in irb starting in Ruby 2.0:
```
$ irb19
irb(main):001:0> require_relative "test.rb"
LoadError: cannot infer basepath
from (irb):1:in `require_relative'
from (irb):1
from /usr/loc... - 03:11 PM Revision 2f379511 (git): * 2019-08-08
-
03:10 PM Revision fa29f654 (git): Debug appveyor mingw failure
- It has been unstable for recent builds:
https://ci.appveyor.com/project/ruby/ruby/builds/26531442/job/0ycp7woekqqx97x9
https://ci.appveyor.com/project/ruby/ruby/builds/26531687/job/xui3rctcvi7r49iv
https://ci.appveyor.com/project/ruby/ru... -
02:22 PM Bug #16050 (Rejected): :@ is not parsed correctly
- I don't think this is a bug. Just because `:@iv` is valid syntax does not imply that `:@` should also be valid syntax. You should use a quoted symbol (note that `Symbol#inspect` quotes the symbol):
```ruby
:'@'
# => :"@"
'@'.to_s... -
10:56 AM Bug #16050 (Rejected): :@ is not parsed correctly
- Symbol literal allows `@` as the first character:
```ruby
:@foo # => :@foo
```
Nevertheless, it does not allow `@` by itself:
```ruby
:@ # >> SyntaxError: `@' without identifiers is not allowed as an instance variable name
`... -
01:56 PM Revision f82633b6 (git): array.c: gc.h is not needed
-
01:54 PM Revision 3229e058 (git): hash.c: gc.h is needed when HASH_DEBUG mode
-
01:43 PM Revision 0cf6bfca (git): hash.c: gc.h is no longer needed
-
01:30 PM Revision f5481e35 (git): Added separator for failing commits from default gems.
-
01:29 PM Revision 67cde179 (git): Skip merge commit created by bundlerbot.
-
01:25 PM Revision 82527d9b (git): fix spelling
- Closes: https://github.com/ruby/ruby/pull/2323
-
01:24 PM Revision 58dec962 (git): enum.c: Remove unused #include
- transient_heap.h is no longer needed.
-
01:11 PM Revision 0d2aa6fe (git): Upgrade benchmark-driver version
- as I already started to use --runner=block introduced in v0.14.20 like:
https://github.com/ruby/ruby/pull/2321#issuecomment-518638663 -
01:10 PM Misc #15996: DevelopersMeeting20190829Japan
- This was a missed carry-over on the last month.
* [Bug #15908] Detecting BOM with non-UTF encoding -
03:04 AM Misc #15996: DevelopersMeeting20190829Japan
- Schedule was changed!!
Before: 2019/08/20 (Thu) 13:00-17:00 (JST)
After: 2019/08/29 (Thu) 13:00-17:00 (JST)
Thanks,
Koichi -
01:05 PM Bug #16041: eval's path argument seems to trigger GC bug
- ruby_2_6 r67736 merged revision(s) 5931857281ce45c1c277aa86d1588119ab00a955,76e2370f132f83c16c9de39a0a9356579f364527.
-
12:48 PM Bug #16041: eval's path argument seems to trigger GC bug
- I accidentally backported 53e9908d8a with this issue. I'll backport additional fixes.
-
01:05 PM Revision a93a2f88 (git): merge revision(s) 5931857281ce45c1c277aa86d1588119ab00a955,76e2370f132f83c16c9de39a0a9356579f364527: [Backport #16041]
- Fix dangling path name from fstring
* parse.y (yycompile): make sure in advance that the `__FILE__`
object shares a fstring, to get rid of dangling path name.
Fixed up 53e9908d8afc7f03109b0aafd1698ab35f512b05... -
12:47 PM Revision 330e3f19 (git): Refactor .travis.yml by introducing travis_retry.sh
- Not using official travis_retry.bash, because it's not supporting to
modify backoff seconds.
https://github.com/travis-ci/travis-build/blob/0ad8f1886b2c31994d847e126dc5842b7b3513e3/lib/travis/build/bash/travis_retry.bash
Not using offic... -
12:38 PM Revision a3843824 (git): merge revision(s) 1e54903684aa3c9ea3fe54520157846a1b1f07be: [Backport #16051]
- test/openssl: Support OpenSSL 1.1.1
OpenSSL 1.1.1 rejects some shorter keys, which caused some failures of
`make test-all TESTS=openssl`.
https://rubyci.org/logs/rubyci.s3.amazonaws.com/debian/ruby-master/log/20... -
12:25 PM Revision eaddc972 (git): merge revision(s) 43730256e800dd8e0c5cc482e9861868590ae037:
- open-uri: Regenerate server certificates for tests
OpenSSL 1.1.1 requires 2048 bits or more. This change will fix:
https://rubyci.org/logs/rubyci.s3.amazonaws.com/debian/ruby-master/log/20190527T003004Z.fail.html.gz#tes... -
12:23 PM Bug #15934: String#b can lead to memory corruption
- ruby_2_6 r67733 merged revision(s) 9dec4e8fc3a6018261834b5ac9b9877f787b97ca.
-
12:23 PM Revision 8a94d4b0 (git): merge revision(s) 9dec4e8fc3a6018261834b5ac9b9877f787b97ca: [Backport #15934]
- String#b: Don't depend on dependent string
Registering a string that depend on a dependent string as fstring
can lead to use-after-free. See c06ddfe and 3f95620 for details.
The following script triggers use-aft... -
12:03 PM Bug #15916: Memory leak in Regexp literal interpolation
- ruby_2_6 r67732 merged revision(s) 53e9908d8afc7f03109b0aafd1698ab35f512b05.
-
12:03 PM Revision da36d570 (git): merge revision(s) 53e9908d8afc7f03109b0aafd1698ab35f512b05: [Backport #15916]
- Fix memory leak
* string.c (str_replace_shared_without_enc): free previous buffer
before replaced.
* parse.y (gettable): make sure in advance that the `__FILE__`
object shares a fstring, to get rid o... -
11:45 AM Bug #15792: GC can leave strings used as hash keys in a corrupted state
- ruby_2_6 r67731 merged revision(s) 3f9562015e651735bfc2fdd14e8f6963b673e22a,c06ddfee878524168e4af07443217ed2f8d0954b,3b3b4a44e57dfe03ce3913009d69a33d6f6100be.
-
11:45 AM Revision f5930c87 (git): merge revision(s) 3f9562015e651735bfc2fdd14e8f6963b673e22a,c06ddfee878524168e4af07443217ed2f8d0954b,3b3b4a44e57dfe03ce3913009d69a33d6f6100be: [Backport #15792]
- Get rid of indirect sharing
* string.c (str_duplicate): share the root shared string if the
original string is already sharing, so that all shared strings
refer the root shared string directly. indirect shar... -
10:54 AM Bug #16032: 2.6 branch is failing on darwin17 on Travis-CI
- Backported into ruby_2_6 at r67730.
-
10:52 AM Revision b405ad8e (git): Update Xcode or Homebrew (apply https://github.com/nobu/ruby/commit/c86b74dc431d4cbdeb7d3c3fe5ac0693dc731bb1) [Bug #16032]
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_6@67730 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
10:13 AM Feature #16049: optimization for frozen dynamic string literals "#{exp}".dup and +"#{exp}"
- Part of the explanation:
String#freeze never allocates a new String, it just freezes the receiver in place.
String#-@ deduplicates/interns the String, to do so it needs to return a new String instance (unless it's already an interned S... -
01:41 AM Revision e6901cea (git): Fixed deprecation message
-
12:43 AM Revision 1bf796c6 (git): Fix Date#step test
- The document states that "the limit should be a date object".
-
12:42 AM Feature #15974: Warn in verbose mode on defining a finalizer that captures the object
- Yes we could do that, and enable it always as that'd be cheap.
-
12:41 AM Feature #15974: Warn in verbose mode on defining a finalizer that captures the object
- Ah, good point.
But maybe `ObjectSpace.define_finalizer(obj, aProc)` should raise an error if `aProc.binding.receiver.equal?(obj)`, because that's a reference that can never be cleared. -
12:40 AM Revision a0fe3965 (git): Simplify break logic of Travis retries
- Co-Authored-By: Nobuyoshi Nakada <nobu@ruby-lang.org>
-
12:03 AM Revision b839721a (git): .travis.yml: Use `-eq` instead `=` to compare integers
08/06/2019
-
11:55 PM Feature #15974: Warn in verbose mode on defining a finalizer that captures the object
- > Question: shouldn't this be an error rather than a warning?
No, because it's possible to have a reference from the finaliser to the object when the finaliser is created, but then to later clear that reference and the finaliser to wo... -
11:50 PM Feature #15974: Warn in verbose mode on defining a finalizer that captures the object
- Question: shouldn't this be an error rather than a warning? Defining a finalizer that immortalizes its object and can never run seems like an outright bug, not something that you should merely warn about in verbose mode only.
-
11:05 PM Bug #7216 (Closed): object.c defines clone method for objects that cannot be cloned.
- Ruby started allowing `clone` on immediate values (true, false, nil, symbol, integer, float) in Ruby 2.4:
```
$ ruby23 -e 'p true.clone'
-e:1:in `clone': can't clone TrueClass (TypeError)
from -e:1:in `<main>'
$ ruby24 -e ... -
10:55 PM Bug #7021: WEBrick::HTTPUtils.parse_header "normalizing" white space of cookie values.
- I agree this is a bug that violates RFC 2616 and RFC 7230 and have submitted a pull request to fix this issue: https://github.com/ruby/webrick/pull/23
-
07:25 PM Feature #16049 (Closed): optimization for frozen dynamic string literals "#{exp}".dup and +"#{exp}"
- When the decision was made that `frozen_string_literal: true` should also apply to dynamic string literals, it was mitigated with the following explanation:
> "#{exp}".dup can be optimized so it won’t allocate extra objects like "..."... -
06:49 PM Feature #15963: Add *_start and *_running methods to VM_COLLECT_USAGE_DETAILS API
- I have been using `Hash#clear` to clear the constants, but that's because a `clear` method doesn't exist. I will add the following to the PR:
```
rb_define_singleton_method(rb_cRubyVM, "USAGE_ANALYSIS_INSN_CLEAR", usage_analysis_insn... -
06:13 PM Revision 8877dbe4 (git): ext/ripper/lib/ripper/lexer.rb: Consistently use `Array#push`
- instead of <<. All the other callsites use `push`.
-
06:12 PM Revision ef8c5161 (git): ext/ripper/lib/ripper/lexer.rb: fix a wrong delegation
- The target method name is a typo.
-
05:43 PM Misc #16047: Reconsider impact of frozen_string_literal on dynamic strings
- > Ruby already optimizes this case
TIL indeed. I should have used a random method call instead.
-
02:41 PM Misc #16047: Reconsider impact of frozen_string_literal on dynamic strings
- byroot (Jean Boussier) wrote:
> The speedup mostly come from reduced GC pressure. Consider the following snippet:
> ...
Unfortunately, this is not a good example, because even without `frozen_string_literal: true`, Ruby already optimiz... -
02:15 PM Misc #16047: Reconsider impact of frozen_string_literal on dynamic strings
- > I am interested in the claimed/perceived speedup. I had seen some benchmarks that claimed no difference in speed. And that made sense to me since deduplication is a memory optimization, not a significant CPU optimization.
The speedu... -
01:59 AM Misc #16047: Reconsider impact of frozen_string_literal on dynamic strings
@shevegen, I didn't suggest what I would like to change because I was mostly looking for insight on people's real-world usage of frozen_string_literal and how it might compare to mine. That's why I put this under the Misc tracker and n...-
05:13 PM Bug #16044 (Open): Float::ROUNDS (FLT_ROUNDS) should not be a constant.
-
03:07 PM Bug #16044 (Closed): Float::ROUNDS (FLT_ROUNDS) should not be a constant.
- Applied in changeset commit:git|e89d9f3debab353d1c5a5162752af8f201d98d49.
----------
Deprecate Float::ROUNDS, which should not be a constant
[Bug #16044] -
01:22 AM Bug #16044: Float::ROUNDS (FLT_ROUNDS) should not be a constant.
- That would be nice.
Matz.
-
04:26 PM Revision 2d6b92c5 (git): Retry ubuntu-toolchain-r-test apt source setup
- In 614c90fe21cf1d9cf6fb18684187d8c7e2f61de6, I assumed
apt-add-repository has been stable recently, but I saw PR randomly
failed for it today.
This commit only deals with "ubuntu-toolchain-r-test" and does NOT deal
with `llvm-toolchain-... - 03:07 PM Revision 66a13413 (git): * 2019-08-07
-
03:02 PM Revision e89d9f3d (git): Deprecate Float::ROUNDS, which should not be a constant
- [Bug #16044]
-
02:39 PM Revision 0ed298f3 (git): Refine time_to_r
- * time.c (time_to_r): get rid canonicalize and uncanonicalize
one-denominator rational, by rb_time_unmagnify_to_rational. -
02:00 PM Revision a04e3585 (git): Extracted wmap_live_p
- 11:59 AM Revision 3e6b9926 (git): * expand tabs.
-
11:59 AM Revision b5146e37 (git): leafify opt_plus
- Inspired by 346aa557b31fe96760e505d30da26eb7a846bac9
Closes: https://github.com/ruby/ruby/pull/2321 -
11:28 AM Revision 43b52ac0 (git): Revert "Don't echo results of assignment expressions"
- This reverts commit 1ee88c51b3c319b74b69540e111e4a1c24833cad.
-
11:15 AM Revision 1ee88c51 (git): Don't echo results of assignment expressions
-
11:03 AM Revision 84236479 (git): Use host_os from RbConfig to detect host OS.
- RUBY_PLATFORM on JRuby is always "java", so it will not reflect
the host operating system. This regex appears to be the consensus
way to detect Windows based on a search of Ruby code on Github:
https://github.com/search?q=%2Fmswin%7Cmsy... -
11:03 AM Revision d626ca1e (git): Remove obsolete TODO comment
-
11:03 AM Revision 81a15d63 (git): Update Unicode URL to 12.1.0
-
09:41 AM Bug #16032 (Closed): 2.6 branch is failing on darwin17 on Travis-CI
- ありがとうございます、取り込んでみます。Backport のため status は Closed にします。
-
03:06 AM Revision 4daff3a6 (git): The value of rb_scan_args_verify is never used
-
02:52 AM Revision 5cff9968 (git): Distinguish bad scan format from no argument variables
-
12:01 AM Revision 146cf2f4 (git): Removing duplicated assertions on test_array.rb - MINUS method
- Closes: https://github.com/ruby/ruby/pull/1790
-
12:01 AM Revision 4f1a00a7 (git): Improve same directory detection in FileUtils
- Closes: https://github.com/ruby/ruby/pull/1425