Activity
From 07/02/2019 to 07/08/2019
07/08/2019
- 11:39 PM Revision 9b18cb34 (git): * 2019-07-09
-
11:37 PM Feature #15897: `it` as a default block parameter
- @JonRowe Thank you for your opinion, but I'd be happy if you could read my original proposal carefully. I've already pointed out the issue (and said my opinion against the issue).
> Cons:
> ...
I hear from some people that they are ... -
04:36 PM Feature #15897: `it` as a default block parameter
- Its worth pointing out that this would always have to be lower priority than methods and other such locals defined in order to allow code to work. If precedence for this was changed to later override existing definitions of it, or simply...
-
11:31 PM Revision 2a8be8ec (git): Suppress uninitialized instance variable warnings
-
05:08 PM Feature #15991: Allow questionmarks in variable names
- > I thought such an issue would've already been discussed but no number of searches
> ...
I think this has been discussed before - I can not point to another issue request for this,
though, so perhaps I misremember. I also don't rememb... -
10:13 AM Feature #15991: Allow questionmarks in variable names
- If this proposal will not cause some serious conflicts, it seems to be also useful for those cases:
```ruby
class Task
def initiailize(name, ready)
@name, @ready = name, ready
end
attr_reader :name
def ready?
... -
09:18 AM Feature #15991 (Assigned): Allow questionmarks in variable names
- Hi,
I thought such an issue would've already been discussed but no number of searches allowed me to find a similar request. Feel free to close if I missed a previous refusal.
From time to time, especially when trying to clear up co... -
01:49 PM Feature #15973: Let Kernel#lambda always return a lambda
- "It's already broken, why not break it more" is not what I can follow.
Can I ask you why you need this feature? If this not more than a matter of consistency, I would like to second @eregon's proposal: lambdas without literal blocks ... -
12:35 AM Feature #15973: Let Kernel#lambda always return a lambda
- I would also like to note that if we revert back to the behavior in 2.4, code that relied on `lambda` without block will not have an easy upgrade path.
```ruby
def make_a_lambda
lambda
end
```
is not equivalent to
```rub... -
- The 2.4 spec is a bit problematic since it makes it impossible to forward a
block to `Kernel#lambda` with a block pass. In the rest of the language
forwarding a block has no effect on semantics compared to passing one
literally. The i... -
11:31 AM Revision ad38f026 (git): Adopt the directory structure of ruby repository for racc extension.
-
10:02 AM Feature #5735 (Closed): Extending the use of splat operator to when it is inside a hash
-
09:53 AM Feature #5735: Extending the use of splat operator to when it is inside a hash
- A similar feature has already been realized as the double splat operator. Please close this issue.
-
09:16 AM Bug #15989: irb-1.1.0.pre.1 crashes on using arrow up, home and delete
- I can reproduce (by hitting del at the end of the line). The cause is in the snippet below.
``` ruby
Reline::Unicode.get_next_mbchar_size('')
# => nil
```
`get_next_mbchar_size()` doesn't always return a number.
According to ... -
-
- 07:00 AM Revision 93c9405e (git): * expand tabs.
-
-
-
04:30 AM Revision 612cad5d (git): Let struct dump_config in objspace fit in a single cache line
- Let dump_config boolean members roots and full_heap be bit flags
instead
Closes: https://github.com/ruby/ruby/pull/2274 -
04:05 AM Bug #10626 (Feedback): BUS error from nesting lambda's and calls to methods defined with define_method
- I tried the last two gists with many Ruby versions (1.9-2.7) and could not produce a crash. These were compiled with clang 7 on OpenBSD. It's possible with a different compiler and compiler options the results would be different. Can ...
-
-
- `cmp_failed` was removed in Ruby 2.3.
-
-
- anatolik (Anatol Pomozov) wrote:
> Could anyone explain what this change tries to do?
It tries to separate the `-I` cflags from the non `-I` ones, as they are stored in different global variables. In general it probably doesn't caus... -
- sawa (Tsuyoshi Sawada) wrote:
> Can someone answer my question in https://bugs.ruby-lang.org/issues/14183#note-68? Perhaps @mame knows? If it is not decisive yet, that is fine. I just want to know what the developers have in mind at thi... -
- Can someone answer my question in https://bugs.ruby-lang.org/issues/14183#note-68? Perhaps @mame knows? If it is not decisive yet, that is fine. I just want to know what the developers have in mind at this point.
-
- It looks like `WEBrick::HTTPResponse#to_s` is currently broken anyway (https://github.com/ruby/webrick/pull/20). I agree that it makes sense to remove the method, and added a pull request to do so (https://github.com/ruby/webrick/pull/22).
-
01:59 AM Bug #10928 (Closed): optparse Switch#summarize code doesn't reflect its documentation
- Applied in changeset commit:git|3fcffceafd2bce7186851bf4899484c545a9ace8.
----------
Fix default argument values for OptParse::Switch#summarize
The documentation describes these arguments being hashes, and the method
is called with has... -
- Thank you, I've missed it.
Commit it please. - 01:59 AM Revision a2e0aaea (git): * 2019-07-08
-
- I'm not sure I would consider this a bug, but it seems like a reasonable change. Attached is an updated patch that applies against master.
-
- I don't think this is a bug. If Apache doesn't pass the `X-Forwarded-Proto` header, and the `X-Forwarded-Host` header doesn't include the port, then how would Webrick know that the request was originally submitted via https? I'm not su...
-
- This was fixed between 2.6 and 2.7.0-preview1:
```
$ ruby26 a.rb
in b
true
$ ruby27 a.rb
true
``` -
- From testing, this issue was resolved between Ruby 2.4 and 2.5.
2.4 output:
```
c_return -e:3 enable
line -e:5
c_call -e:5 method_added
c_return -e:5 method_added
line -e:8
... -
-
- This was apparently fixed between Ruby 2.3 and 2.4:
```
$ ruby23 -e 'p("<".force_encoding("UTF-8") =~ /[[:punct:]]/)'
nil
$ ruby24 -e 'p("<".force_encoding("UTF-8") =~ /[[:punct:]]/)'
0
```
-
-
- I think this is a bug and it should be fixed. Attached is a patch that fixes the issue by checking if the receiver is already a singleton class, and if so, calling `rb_singleton_class` to force the creation of the singleton class of the...
07/07/2019
-
- This appears to be a bug in the ffi gem, see https://github.com/ffi/ffi/issues/337.
-
- Considering `String#b` has now been present since Ruby 2.0, and renaming it would break tons of code, I think there is no chance of it being renamed. It looks like Radix has adjusted to it and works with `String#b` being defined by defa...
-
09:04 PM Feature #15897: `it` as a default block parameter
- Eregon (Benoit Daloze) wrote:
> I think this ambiguity is fairly intuitive and easy to resolve:
> ...
I would echo Benoit's comments here. As an avid RSpec user, I employ `it "does something"` without a block fairly often for prototyp... -
- I agree that this is a bug and it should be fixed. You can trigger it by calling `OptionParser::Switch#summarize` without arguments:
```ruby
require 'optparse'
o = OptionParser.new
o.on('-c'){}
o.instance_variable_get(:@stack)[2]... -
- The documentation describes these arguments being hashes, and the method
is called with hashes, so a hash default makes more sense.
The method would fail previously if called without arguments and @short
or @long contained a non-integer... -
-
- It appears this was fixed between ruby 2.3 and 2.4:
```
$ ruby24 /home/jeremy/Downloads/zlib.rb
62780
generating len=1000000000 string...
string length=1000000000
compressing...
^CINT
decompressing...
true
$ ruby23 /home/... -
- The `ng_assoc19.rb` and `ng_assoc19_strvalue.rb` examples are no longer syntax errors, so I think this can be closed.
-
11:16 AM Revision c1ebb384 (git): Fix a typo
-
-
10:02 AM Bug #11022: opening an eigenclass does not change the class variable definition context
- Class variable lookup just ignores singleton classes currently.
I assume this is intentional behavior so one can use the same variable in singleton methods (when defined under `class<<self`) and instance methods. -
- This issue is not specific to opening a singleton class (`class <<`), but applies to any case where the class being opened is a singleton class. You get the same output for:
```ruby
module Mod1
O = Object.new.singleton_class
c... -
- Get rid of unknown escape sequence warning, as `#` is not a
special character in C.
```
version.c:126:26: warning: unknown escape sequence '\#' [-Wunknown-escape-sequence]
fputs("last_commit=" RUBY_LAST_COMMIT_TITLE, stdout);
... -
09:33 AM Revision 68e58040 (git): Add coroutine context switch for i386-mingw32
- It's essentially a translation of Context.asm from Intel
to AT&T syntax. -
-
- Applied in changeset commit:git|d548073f68ae719933c328686df224f74a60d366.
----------
Enable indentation warning against `if` just after `else`
```ruby
if false
puts 'false'
else if true
puts 'true'
end # -:5: warning: mismatched in... -
- Warning only after a syntax error?
```
$ ./ruby -w
if false
else if true
end
-:3: syntax error, unexpected end-of-input, expecting `end'
-:3: `end' of `if' matched `else' before `if'
-:2: maybe `elsif'?
``` -
12:18 AM Feature #15990: "else if" causes confusing syntax error
The problem is that this is valid Ruby:
``` ruby
if false
puts 'false'
else if true
puts 'true'
end
end
```
So we can't really tell if `else if` is invalid until we parse the second `end`.
- 06:50 AM Revision a33948f4 (git): * 2019-07-07
-
- ```ruby
if false
puts 'false'
else if true
puts 'true'
end # -:5: warning: mismatched indentations at 'end' with 'if' at 3
end
```
[Feature #15990] -
-
-
- Fixed by commit:7be5169804ee0cfe1991903fa10c31f8bd6525bd.
-
-
- I don't think this is a bug. Killing a thread requires running ensure blocks until the thread exits, the ensure block for `ConditionVariable#wait` needs to reacquire the mutex. If it didn't, the method would exit with the mutex not loc...
-
-
-
- Looking at the mentioned commit, I'm not sure how it is possible that the commit broke it. The only code change is:
```diff
- http = klass.new(target_host, target_port)
+ http = proxy ? klass.new(target_host, target_port) : k...
07/06/2019
-
- @sawa Could you write a code example in the description? It would be very helpful to make the developer meeting efficiently.
```
p Integer("z", exception: false) #=> nil
p Integer("z", exception: nil) #=> excepted: nil, actual: i... -
- I agree for methods taking an :exception keyword argument.
I would consider this a bug to treat `nil` as "want exception".
Do you have examples of other methods taking a boolean option and treating `nil` the same as `true`?
Those sh... -
- * [Feature #15987] Let boolean option (such as `exception` in `Kernel#Complex`, `Kernel#Float`, `Kernel#Integer`, `Kernel#Rational`) be falsy vs. truthy
* Does this issue need matz approval or can it be fixed directly? If it does, doe... -
- josh.cheek (Josh Cheek) wrote:
> Why not a comment pragma for this, too? A flag seems out of place.
Thanks for your reply.
I think a pragma is pretty bad for changing the default value when there is no pragma, from the experience wi... -
- palkan (Vladimir Dementyev) wrote:
> I think, most gems won't use these features anyway: we, gem authors, need to support older versions;
Thanks for your reply. Agreed, I was thinking to that as well but did not mention it explictly.... -
- JonRowe (Jon Rowe) wrote:
> > FWIW, MSpec's it requires the description argument, so it cannot ever be ambiguous for the user.
> ...
I think this ambiguity is fairly intuitive and easy to resolve:
it's exactly the same rule as for met... -
- `$1` - `$N` (there can be more than 9 of them) are treated specially by the parser.
In fact, the only way they can work is special treatment by the parser, because there is potentially an infinite number of them.
And that's probably ... -
-
- I guess it should be possible to distinguish between "else if" and "elsif"
by the ruby parser already, since it does fail if the 'e ' part is there
in the first case, as otherwise the parser would accept the syntax. So I
think it woul... -
01:53 AM Feature #15990 (Closed): "else if" causes confusing syntax error
- ```ruby
if false
puts 'false'
else if true
puts 'true'
end
```
This fails with "syntax error: unexpected end-of-input, expecting end". `else if` isn't `elsif`, of course, but if a file contains `else if` (especially on one l... -
- I've noticed it and have a patch, but haven't committed it yet as not written the test using dummy timezone objects.
-
- Applied in changeset commit:git|f296c260ef3b2d1a9299dbb4a84df567972453f2.
----------
Fix segfault when using method reference operator without using result
Fixes [Bug #15985] -
- Seems fine.
-
- Fixes [Bug #15985]
-
-
07/05/2019
-
- Fixed by commit:01b3a3804334be19d013526d3edde2b84399ae43.
-
-
- I think this may be operating system/platform specific and could be fixed in a previous version. I could replicate the behavior on ruby 2.4.1p111 on x86_64-linux, but memory seemed to stablize around 180MB on ruby 2.7.0dev on i686-linux...
-
- Rubygems upstream merged the pull request, so this can be closed.
-
11:03 PM Bug #11214: Cannot Get Correct Binding from inside of C Method
- > I'm fairly sure having binding capture arguments passed to C methods is not possible.
TruffleRuby could do that! Sorry I know it's boasting and not relevant to MRI :) -
- I'm fairly sure having `binding` capture arguments passed to C methods is not possible. Ruby doesn't know the C function's parameter names at runtime. Even if that were possible, you wouldn't be able to handle cases where a C function t...
-
-
- I think this can be closed. It doesn't look like 2.3 actually shipped with `RubyVM::InstructionSequence.load` (disabled at commit:22ea03bb7e213d60e49a9cdd1ec1b221ef802e2a), and the equivalent code with `RubyVM::InstructionSequence.load_...
-
- 10:20 PM Revision 833cfeb2 (git): * 2019-07-06
-
10:19 PM Revision 89e178c7 (git): Fix showing document of ClassName.method_name in IRB
- In IRB, Time.new is split as "Time", ".", and "new". The receiver "Time"
is processed by #class method but it means that "Time" changes to
"Class". This commit fixes it. -
- I agree that this is a bug that should be fixed. The implementation automatically percent escapes invalid characters instead of rejecting them by design. However, I don't think that implies we should accept invalid percent escapes alrea...
-
-
-
- This was fixed between Ruby 2.2 and Ruby 2.3:
```
$ ruby23 -e "module M; end; class A; prepend M; end; class B<A; prepend M; end; p B.ancestors"
[M, B, M, A, Object, Kernel, BasicObject]
$ ruby22 -e "module M; end; class A; prepend... -
- The behavior seems even worse in the master branch and 2.7.0-preview1, with a RuntimeError without a calculation, and always false after a calculation:
```ruby
require 'tzinfo'
z = TZInfo::Timezone.get('Europe/Kiev')
t = Time.new(2... -
- Even funnier:
```ruby
winter = Time.new(2019, 12, 1, 14, 30, 12, z) # => 2019-12-01 14:30:12 +0200 -- offset is correct
winter.dst? # => true -- this is wrong!
(winter + 1).dst? ... -
- My current timezone is Europe/Kiev.
With default zone (how it was previously):
```ruby
summer = Time.new(2019, 6, 1, 14, 30, 12) # => 2019-06-01 14:30:12 +0300
summer.zone # => "EEST"
summer.dst? ... -
- All of the other similar regexp variables (`$& $' $+ $~ $(backquote)`) are listed by `global_variables`, so it would make sense for `$1` and similar to appear, or alternatively for the other 5 regexp globals not to appear if there is no ...
-
- This issue still exists in the master branch. Eric's patch no longer applies, but attached is a similar approach that works and includes a test. However, maybe there was a reason this wasn't committed originally?
-
04:40 PM Bug #15989: irb-1.1.0.pre.1 crashes on using arrow up, home and delete
- Adding a demo gif code
-
- When I do this:
1. Start irb
2. Define empty string `''`
3. Press arrow up
4. Press Home
5. Press Delete to remove first `'`
6. irb crashes
I get following exception:
```
33: from ../install/bin/irb:23:in `<main>'
32: f... -
-
12:38 PM Bug #15841: SegFault in OpenSSL::PKey::RSA#private_encrypt
- Both of PR is merged and this issue is resolved, so this can be closed.
- https://github.com/ruby/openssl/pull/255
- https://github.com/ruby/openssl/pull/258
Thanks! -
- It has unintentionally passed since 2.5.
-
- * [Feature #15631] Let round_capa for ID table not allocate excess capacity for power of 2 ints >= 4
* PR and further due diligence comments in https://github.com/ruby/ruby/pull/2278
- 10:01 AM Revision 0a2f598d (git): * 2019-07-05
-
-
- > Is that used in practice though? I know pending examples, but I would expect they at least have a description.
No but as Ruby doesn't allow method overloading you do create that ambiguity, and the possibility for future bugs due to ... -
06:23 AM Feature #15966: Introducing experimental features behind a flag, disabled by default
- > This is how frozen string literal support was introduced to Ruby (in addition to the per-file magic comment).
Why not a comment pragma for this, too? A flag seems out of place. A flag also sets it globally, preventing one from optin... -
- I don't have a huge preference either way, but this may be a design decision, so perhaps we
can ask matz either way; also in how strong the concept of "falsy" and "truthy" is in ruby.
I assume there were design considerations for when ... -
- The `exception` option in `Kernel#Complex`, `Kernel#Float`, `Kernel#Integer`, and `Kernel#Rational` distinguishes `false` vs. other values.
```ruby
Integer("z", exception: false) #=> nil
Integer("z", exception: nil) #>> ArgumentErro... -
- tk was removed in Ruby 2.4.
-
-
- This behavior hasn't changed since the initial report. However, it seems odd to just treat string subclasses (or strings with singleton classes) differently. Currently the behavior is to use C functions for (at least) String, Symbol, I...
-
- This was fixed in commit:965e9df38045594d126991e6a109c5746242d2ba.
-
-
- I don't think this is a significant issue with current Ruby, though it was certainly a bigger issue in previous versions. From some testing:
```
$ ruby22 -r active_record -e "t = Time.now; require 'English'; p(Time.now - t)"
0.004... -
- This was fixed between Ruby 2.3 and 2.4:
```
$ ruby23 -e '
> class C; def a() end end
> ...
nil
$ ruby24 -e '
> class C; def a() end end
> ...
#<UnboundMethod: C#a>
```
07/04/2019
-
- I think the attached patch should fix it. Passes `make check`. This is my first time working on the compiler though, so a more experienced committer should probably check the patch.
With the patch:
```
$ ruby --dump=insns -e 'ni... -
- I can reproduce this. Here's a backtrace:
```
Thread 1 received signal SIGSEGV, Segmentation fault.
0x000006441ce6cdcd in check_funcall_callable (ec=0x643ddd44e48, me=0x64472043dc0) at ./vm_eval.c:365
365 return rb_method... -
- I have a simple script that actually does nothing:
``` ruby
nil.:|;1
```
or
```ruby
:|.:!;:|
```
When I run it with `make run` for `miniruby` or I run it with the full built master.
I get a segmentation fault as follow... -
10:14 PM Feature #15966: Introducing experimental features behind a flag, disabled by default
- Eregon (Benoit Daloze) wrote:
> I expect gems wouldn't use it anyway because of the extra needed flag.
I think, most gems won't use these features anyway: we, gem authors, need to support older versions; it doesn't make a lot of sens... -
-
- > This generates a wrong output collection after doing this action.
Could you provide some examples and explain exactly what is wrong with the output collection? -
- I don't think ruby should disallow this via an exception. The use case
seems fairly odd, too - it is often more idiomatic to do .map, .select,
.reject etc... -
09:38 AM Bug #15984: deleting from a collection while iterating on it
- that totally depends on how you interate over the collection.
if you do it right, ruby has no problem with that -
07:58 AM Bug #15984 (Closed): deleting from a collection while iterating on it
- If you tried to delete from a collection while iterating on it Ruby will allow you to do this flawlessly. This generates a wrong output collection after doing this action. An exception should be thrown to disallow this to be done.
-
- JonRowe (Jon Rowe) wrote:
> it # creates a pending example with no implementation
Is that used in practice though? I know pending examples, but I would expect they at least have a description.
FWIW, MSpec's `it` requires the descr... -
10:17 AM Feature #15897: `it` as a default block parameter
- Eregon (Benoit Daloze) wrote:
> What do you think about `_`?
> ...
I think Jon express my feelings with a clear example.
For `_` same thing. It is already use and it can lead to an issue: https://bugs.ruby-lang.org/issues/15897#note-3 -
- > I would appreciate feedback on whether this more detailed error message is an improvement.
I think this depends on what the ruby user at hand is doing; and how much expertise that
ruby user may have. Some behaviour in ruby can be c... -
- nobu (Nobuyoshi Nakada) wrote:
> Is “a Integer” OK? :)
"a(n) Integer" -
- Is “a Integer” OK? :)
-
01:15 AM Feature #11460: Unhelpful error message when naming a module with the same name as an existing class
- jeremyevans0 (Jeremy Evans) wrote:
> So I don't think there is a bug here. It is possible to change the format the error message, though. Attached is a patch that changes the error message to the include the current class of the objec... -
12:54 PM Bug #15986 (Assigned): `TestJIT#test_block_handler_with_possible_frame_omitted_inlining` fails on s390x and armv7hl
- Thanks to report. I'd like to know more about the context to fix the issue.
* Does the error happen at the same place when you retry running the tests?
* If so, could you share the output of the following command and all .c/.h files ... -
12:24 PM Bug #15986 (Closed): `TestJIT#test_block_handler_with_possible_frame_omitted_inlining` fails on s390x and armv7hl
- I am trying to build the Ruby 2.7 snapshot for Fedora Rawhide [1], but I observe the following test failure on s390x and aarch64 platforms:
~~~
1) Failure:
TestJIT#test_block_handler_with_possible_frame_omitted_inlining [/builddir... -
-
- I would like to ask for clarification.
I understand that this feature removes the rule that complements argument-final brace-less key-value pairs with braces. That is, the rule that interprets:
```ruby
foo("bar", a: 1, b:2)
```
... -
-
-
-
-
- Applied in changeset commit:git|ee861e43f70d827abd1f8d26b2e97920237348b4.
----------
Skip indented comment lines [Bug #15981] -
- I was asked (apparently in private mail) about `^D` and `^C`. `^D` produces the same Traceback. `^C` produces another prompt, still with the number 001.
-
- I attached my .inputrc, and my .irbrc also just in case you might need that. I can't remember ever modifying these files in any way. I didn't even know there was a .inputrc file.
-
-
-
- * [Feature #11460] Unhelpful error message when naming a module with the same name as an existing class
-
- Let's look at this purely from a syntax point of view first, so that we can avoid
other issues such as backwards incompatible changes (which may be a big reason
why this request will not be implemented; but you have to ask matz).
I ... -
- There are other languages that use $ in string interpolation. One of them is Perl. Perl is much more famous and widely used than V. Ruby was created as a better Perl. $variable_name may work (most of the time, but not always) in language...
-
05:43 AM Feature #15983 (Rejected): Can we have a similar syntax (string interpolation) the way V language has?
- Sorry, guys, This is the first feature that I am writing in this Ruby issue tracking system, and If I make any mistake, please understand :).
Today I was going through this language, i.e. V language (mainly their website) and found it... -
- Applied in changeset commit:git|f19e048d244c709e2990ddbb0f986e8b51357bd2.
----------
Do not dispatch a nil token in ripper
As a comment token includes the newline, so delayed newline token
just follows it should not be dispatched. [Bu... -
- > `[ruby-core:<unknown>]`
This seems not having sent to the ML, and it happens sometimes, but I'm not sure why. -
- Thank you for the patch, somehow I've missed this issue at all.
`dispatch_delayed_token` is an empty expression unless ripper, so it is useless inside `#ifndef RIPPER`.
And delayed tokens should not be `nil` generally. -
- As a comment token includes the newline, so delayed newline token
just follows it should not be dispatched. [Bug #11485]
Co-Authored-By: Jeremy Evans <code@jeremyevans.net>
07/03/2019
-
- The reason for the difference in behavior here is due to Ruby's open classes. When using `class X` or `module X`, if the constant `X` is already defined, Ruby will reopen the class or module definition, so you can operate in the context...
-
- `Init_signal` is only called once at startup. It appears the memory allocation here happens inside `signal`, in the MS C runtime. Does Windows provide a way to free such memory?
-
- `Init_Thread` is only called once on Ruby startup. There are 3 mutexes initialized in `Init_Thread` in the master branch. It appears that these mutexes are used, so I wouldn't consider them leaked. 2 of the mutexes appear to be destroy...
-
- I think the vsnprintf.c issue is spurious, even in 2.2.3. I can't see a case were `uqval` isn't set and line 1074 is reached. case `x`/`X` sets it in line 1041. case `d`/`D` sets on line 846. case `u`/`U` sets it on line 1027. case `o`/`...
-
- 👋Hello! As the current maintainer of RSpec I'm concerned about the confusion here.
```ruby
RSpec.describe do
it "will do the thing" do
it # now refers to the first argument to the block? (Which ironically is the example itsel... -
- This bug is still present on master. Attached is a patch that fixes it, by not calling `dispatch_delayed_token` when ripper is used if the dispatched value is `nil`.
-
- It has caused CI failures.
* d0cd0866d82a58933e5dccd073c753c0c2ad4eb5
Disable GC during rb_objspace_reachable_object_p
* 89cef1c56b3a0f9c5e6ccc22a5044477a4fd16c1
Version guard for [Feature #15974]
* 796eeb6339952d92ae1b353d450c7... - 04:04 PM Revision 5d9e91af (git): * 2019-07-04
- 04:04 PM Revision c62aac10 (git): * expand tabs.
-
- Try to fix CI breakage by [Feature #15974].
-
- BTW I am asking this question, because their shebang should be updated otherwise:
https://github.com/ruby/ruby/blob/master/libexec/racc2y#L1
-
- The y2racc and racc2y are not available upstream anymore:
https://github.com/ruby/racc/commit/2d360188e9ed474d559ad2fa9bb0636feb445ea2
I know this is development branch commit, but is it worth of shipping them in Ruby if they are g... -
-
- Please show me your `~/.inputrc`.
-
- When invoking irb, the first prompt comes up, but as soon as any character (incl. e.g. space or tab) is typed, it immediately crashes it.
```
duerst@Arnisee /cygdrive/c/Data/ruby
$ irb
irb(main):001:0> Traceback (most recent call l... -
-
02:22 PM Misc #15978 (Rejected): Deprecate FIXNUM_MIN and FIXNUM_MAX
- robertomiranda (Roberto Miranda) wrote:
> Yeah sure basically for consistency, now that Bignum and Fixnum classes have been deprecated in favour of Integer. I think that FIXNUM_MIN and FIXNUM_MAX should be deprecated and replaced for so... -
09:18 AM Misc #15978: Deprecate FIXNUM_MIN and FIXNUM_MAX
- Yeah sure basically for consistency, now that Bignum and Fixnum classes have been deprecated in favour of Integer. I think that FIXNUM_MIN and FIXNUM_MAX should be deprecated and replaced for something that reflects that ruby has a singl...
-
- Can you tell us why? We only expose these constants into C and there _are_ fixnums in C. Usages of them are seen in the wild, for instance https://github.com/ged/ruby-pg/blob/master/ext/pg_text_decoder.c
I fail to see any reason to de... -
02:21 PM Misc #15723: Reconsider numbered parameters
- I've been following this for a while, hopeful that it (or something quite similar) stays in. I've grown to appreciate thinking of the `@1` in a sense of "an instance var of this block", since `@1` can't exist in code today.
However, ... -
01:45 PM Revision 6bd49b33 (git): Ensure that GC is disabled during compaction
- Various things can cause GC to occur when compaction is running, for
example resizing the object identity map:
```
frame #24: 0x000000010c784a10 ruby`gc_grey [inlined] push_mark_stack(stack=<unavailable>, data=<unavailable>) at gc.c... -
- I just wonder what FS are supported actually. I am using Ext4, which is not an esoteric FS IMO and this works:
~~~
$ stat --printf='%w' test/ruby/test_file_exhaustive.rb
2019-07-03 12:33:07.270913105 +0200
~~~ -
- ```
.../ruby/lib/delegate.rb:405:in `__getobj__': not delegated (ArgumentError)
```
https://rubyci.org/logs/rubyci.s3.amazonaws.com/debian9/ruby-master/log/20190703T063006Z.fail.html.gz -
-
- `check` includes `test-testframework`, `test-short` and its
preceeding tests, but `test-all` does not. -
- This error still occurs in master. However, I'm not sure it is fixable with the example you gave. Your example does not raise `NoMethodError`, it raises `NameError`, because you used `NoMethodError` instead of `::NoMethodError`. Even i...
-
- The following code shows line 2 (`while true`) as uncovered:
```ruby
raise if 1 == 2
while true
break
end
```
Coverage reports the following for this file: `[1, 0, 1, nil]`. Note that `true` isn't important, any `while` con... -
-
- No. I'm against it. We have discussed this before multiple times. See the issues I linked just now.
-
- This partially reverts commit 712a66b0741605f5b2db670a292b9bb352f8a716.
The previous fix made CI strange like:
http://ci.rvm.jp/results/trunk-vm-asserts@silicon-docker/2124178
Let me just downgrade the behavior for now and deal with it... -
- https://travis-ci.org/ruby/ruby/jobs/553346285
-
12:27 AM Bug #15979 (Rejected): URI.parse does not validate components
- ``` ruby
URI.parse("https://-._~%2C!$&'()*+,;=:@-._~%2C!$&'()*+,;=:/foo?/-._~%2C!$&'()*+,;=:@/?")
```
happily return a `URI::HTTPS` object, even though it has an invalid component and cannot be constructed using `URI::HTTPS.build`
...
07/02/2019
-
09:05 PM Feature #15976: Add Array#overlap? for whether the intersection of 2 arrays is non empty?
- shevegen (Robert A. Heiler) wrote:
> To me the name of the method appears to make sense and I am slightly in
> ...
Thanks. Matz suggested today that the name was not so clear to him. An alternative that springs to mind would be `inter... -
- To me the name of the method appears to make sense and I am slightly in
favour of the suggestion. I can not say how useful this method would be
in general, though, mostly because I think I needed to do something
such as (array1 & arr... -
- This is semantically equivalent to `(ary1 & ary2).any?`, but more efficient and makes the intent more obvious.
For example bundler [checks]( https://github.com/ruby/ruby/blob/master/lib/bundler/runtime.rb#L61 ) whether the list of req... -
- I posted more thoughts on #15973. Maybe we should simply `raise` when not giving a literal block to `lambda`/`proc`, since it's useless or dangerous (changes semantics of code) otherwise.
-
- I propose we fix the regression first, the optimization introduced let's fix that, regardless of desired semantics in the future.
-
- I'm not sure changing this is good, because it can be very surprising for the code to change semantics dynamically.
Also, should `proc(&lambda)` make a non-lambda Proc then? It would be inconsistent if not.
As I said in https://bugs.... -
- I agree. Even though we have to investigate how big the consequence of the change first.
Matz.
-
- When Kernel#lambda receives a Proc that is not a lambda,
it returns it without modification. l propose to change `Kernel#lambda`
so it always returns a lambda.
Calling a method called lambda and having it do nothing in effect is
no... -
- chrisseaton (Chris Seaton) wrote:
> I think Ruby Spec considers warnings to be user-visible features, so does normally spec them. This prompts alternative implementations like JRuby and TruffleRuby to implement the same warning so that ... -
- Applied in changeset commit:git|928260c2a613bbdd4402c300e0bf86ae7562e52a.
----------
Warn in verbose mode on defining a finalizer that captures the object
[Feature #15974]
Closes: https://github.com/ruby/ruby/pull/2264 -
- I think Ruby Spec considers warnings to be user-visible features, so does normally spec them. This prompts alternative implementations like JRuby and TruffleRuby to implement the same warning so that the user experience is the same on al...
-
- This is a good feature, but I don't think this should belong to the "spec" as seems an implementation detail.
-
- > Matz has approved this proposal.
\o/ -
- Matz has approved this proposal.
-
02:41 PM Feature #15974: Warn in verbose mode on defining a finalizer that captures the object
- it makes sense.
-
- There's a really common mistake people make when using `define_finalizer` - they capture the object in the finalizer.
https://www.mikeperham.com/2010/02/24/the-trouble-with-ruby-finalizers/
This PR warns about that, when in verbose... - 07:26 PM Revision 9f262424 (git): * expand tabs.
-
- * Fixed warning condition
* Fixed function signature
* Use ident hash -
- [Feature #15974]
Closes: https://github.com/ruby/ruby/pull/2264 -
-
- This reverts commit ea30dd702512ff9df34fe8c71c825f8f901bf5b1.
because it fails when VM_CHECK_MODE=1. -
- 05:13 PM Revision c07165be (git): * expand tabs.
-
- The latter is same as the former, removed the duplicate function.
-
-
- FYI, I see the bad behaviour on 2.6 and master too. I think the root of the issue is here: https://github.com/ruby/ruby/blob/master/vm_args.c#L405 - it uses a bitmask to capture which kwargs have been passed, and that bitmask is stored i...
-
- Applied in changeset commit:git|0f283054e7f568f09fbfc952d57ea6daf4abbd88.
----------
Check that String#scrub block does not modify receiver
Similar to the check used for String#gsub. Can fix possible
segfault.
Fixes [Bug #15941] -
- Hmm. I don't doubt that this may possibly be useful, but the method name is
a bit ... weird. My first association with this name, oddly enough, is to
associate duck typing with it, and then to "pluck the duck" (yes, strange
associatio... -
02:05 PM Feature #15975 (Rejected): Add Array#pluck
- Inspired by https://github.com/rails/rails/issues/20339
While developing web applications I've often wanted to quickly extract an array of values from an array of hashes.
With an array of objects, this is possible:
```rb
irb(ma... -
- Similar to the check used for String#gsub. Can fix possible
segfault.
Fixes [Bug #15941] -
- Applied in changeset commit:git|7582287eb27e6b649789ce31ffdcbbb9ffcaf726.
----------
Make String#-@ not freeze receiver if called on unfrozen subclass instance
rb_fstring behavior in this case is to freeze the receiver. I'm
not sure i... -
- rb_fstring behavior in this case is to freeze the receiver. I'm
not sure if that should be changed, so this takes the conservative
approach of duping the receiver in String#-@ before passing
to rb_fstring.
Fixes [Bug #15926] -
- Applied in changeset commit:git|a4b5aaa9a7225693168e43455de2e10c3721b789.
----------
Remove Changelog section from doc/contributing.rdoc [ci skip]
Replace it with a section on commit message formatting. Also,
move the section on rebas... -
- Replace it with a section on commit message formatting. Also,
move the section on rebasing to the bottom, since that only
applies to committers and not most contributors.
Fixes [Bug #14886] - 03:19 PM Revision 40d31073 (git): * 2019-07-03
-
- Applied in changeset commit:git|ced640951b0e7164a12ea1770330eba3e6109fc2.
----------
Implement Array#minmax
Array#minmax was previous not implemented, so calling #minmax on
array was actually calling Enumerable#minmax. This is a simpl... -
- Array#minmax was previous not implemented, so calling #minmax on
array was actually calling Enumerable#minmax. This is a simple
implementation of #minmax by just calling rb_ary_min and
rb_ary_max, which improves performance significantl... -
-
03:02 PM Bug #15977 (Closed): Unobvious result value from #next_rotate_time and #previous_period_end methods of Logger::Period module
- I found that #next_rotate_time and #previous_period_end methods can return different time objects in some case.
When we call these methods with valid `shift_age` option methods returns a new Time object with the local machine's timez... -
- This is a retry of 181b966e7553ac53d034266a7cdc18664d080814.
"Revert "Add a missing tests for Logger::Period module"" is also
reverted. -
- This is a perfect bug report having a minimum code which reproduces the bug in Ruby 2.7 JIT's method inlining.
I wish we could catch this automatically by one of our CIs, but this time it didn't go well.
Thank you for testing Ruby 2.... -
- Applied in changeset commit:git|ea30dd702512ff9df34fe8c71c825f8f901bf5b1.
----------
Avoid corrupting VM stack on inlined setlocal
setlocal relies on cfp->ep, and frame-omitted method inlining introduced
in Ruby 2.7 kept it wrong.
Thi... -
-
11:14 AM Bug #15971: Segfault with --jit-wait when using simple *= operator
- When I change "a *= b" to "a * b" it doesn't crash.
-
- I get a segfault with the very simple Ruby code below with JIT debug options. Runs fine with only "--jit" (no --jit-wait or --jit-save-temps).
Ruby with "ruby --jit --jit-save-temps --jit-wait ./multiply.rb"
Ruby version: ruby 2.7.0d... -
- This reverts commit 181b966e7553ac53d034266a7cdc18664d080814.
-
- setlocal relies on cfp->ep, and frame-omitted method inlining introduced
in Ruby 2.7 kept it wrong.
This change might slow down frame-omitted method inlining for cfp->ep
manipulation, and it obviously complicates the implementaion more.... -
- Closes: https://github.com/ruby/ruby/pull/2266
-
- * [Feature #15973] Make `Kernel#lambda` always return lambda
-
10:07 AM Misc #15930: DevelopersMeeting20190711Japan
- * [Feature #15940] Coerce symbols internal fstrings in UTF8 rather than ASCII to better share memory with string literals
* Saves some resident memory
* Makes symbols & constant names defined in UTF-8 files UTF-8 encoded, which is ... -
- Applied in changeset commit:git|e9ea494171745cc22f458952b0aaf4443820caa9.
----------
The behavior of statx(2) depends on the filesystem
birthtime may not be supported on some filesystems, and
NotImplementedError can be raised. [Bug #1... -
- On my Fedora Rawhide, I observer following test failure:
~~~
1) Error:
TestFileExhaustive#test_birthtime:
NotImplementedError: birthtime is unimplemented on this filesystem
/builddir/build/BUILD/ruby-2.7.0-76851381cb/test/ru... -
-
- birthtime may not be supported on some filesystems, and
NotImplementedError can be raised. [Bug #15972] -
-
- Benoit_Tigeot (Benoit Tigeot) wrote:
> Thanks for the clarification. As member of the RSpec team but expressing my own view I was worried about a strong conflict. I still think this not a good idea to use "it" because it is used a lot i... -
- I added an updated patch version. The patch has been tested with existing examples that mame shared initially.
Also I tested the patch against rspec-core without any issues. https://github.com/rspec/rspec-core/issues/2645 -
- jeremyevans0 (Jeremy Evans) wrote:
> mikegee (Michael Gee) wrote:
> ...
Thanks for the clarification. As member of the RSpec team but expressing my own view I was worried about a strong conflict. I still think this not a good idea to u... -
07:31 AM Feature #15897: `it` as a default block parameter
- FWIW, wrt "This is Perlish": at least one modern language has adopted a similar feature: Swift. I've used it in practice, and it is really nice to use.
This page has a running example expressed in different ways: https://docs.swift.o... -
- joanbm (Joan Blackmoore) wrote:
> Although I can understand rationale behind this proposal, I'm not sure it fits Ruby development model too well and in the end it may only lead to its fragmentation. It assumes diligent use of optional e... -
- ioquatix (Samuel Williams) wrote:
> I think there are two separate concerns that have been raised in this issue.
Thank you for your reply.
> ...
I think we need to not overuse it, like @jeremyevans0 said.
Features which are not e... -
- jeremyevans0 (Jeremy Evans) wrote:
> I think the idea of a flag for experimental features makes sense.
> ...
Thank you for your reply.
I think that would be reasonable. That would mean it's experimental for at least a year, which seem... -
- mame (Yusuke Endoh) wrote:
> I have not yet made up my mind to this proposal, but I think of:
Thank you for your reply! I will reply inline for better context.
> ...
I think it's better a bit slower than rushing a feature which is... -
- This really sounds like a bug to me. Please make a patch and I will apply it.
-
- Done.
-
- I'm fine with this proposal, it would be interesting to hear what others think.
@byroot Could you add this issue to #15930 for discussion? -
- > would it help if Symbol.to_s or Module.name would return a shared string?
It's not really about the returned string, it's about the internal frozen string that is kept in the symbol table.
> ...
I already proposed it, but it was... -
-
-
-
-
- Applied in changeset commit:git|0b858425e1e4f2de40dc0d8e5dd105a2fd93e478.
----------
Use GitHub ruby.git for make-snapshot
Previously @hsbt disabled https git clone from git.ruby-lang.org.
Using git.ruby-lang.org for non-commit purpos... -
- Previously @hsbt disabled https git clone from git.ruby-lang.org.
Using git.ruby-lang.org for non-commit purposes is discouraged. GitHub
mirror is actually recommended because it's reliable than single-hosted
git.ruby-lang.org, the mirr... -
-
-
-
-
-
-
-
-
-
-
- They are moved under the tool directory now.
-