Activity
From 06/02/2019 to 06/08/2019
06/08/2019
-
01:20 PM Bug #15907: gem bin stub commands are failing
- Hiroshi,
Good evening. A ruby-loco CRON job just happened to run on 3776c48cf4, and it passed.
Thank you, and sorry for the delay, I recently woke up.
JFYI, a while ago I added CLI output to ruby-loco CI, but I didn't add code ... -
04:55 AM Bug #15907 (Assigned): gem bin stub commands are failing
- Hi, Greg.
Thanks to your report. I reverted b76630f73e for another reason. Can you try with the current master as https://github.com/ruby/ruby/commit/3776c48cf41950d2cc994676bb2735ee1a0a474e ? -
- Sorry for forgetting (to many hours coding today).
One should be able to repo this by copying the lib/rubygems folder from master/trunk to an existing install, then run a CLI command similar to any of the above... -
- Commands like
```ruby
bundle version
irb --version
rake --version
rdoc --version
```
are failing. All failure are something similar to:
```
bundle : lib/ruby/2.7.0/rubygems/core_ext/kernel_gem.rb:64:in `synchronize': deadlock; ... -
12:58 PM Misc #15874: DevelopersMeeting20190613Japan
- * [Feature #14912] Introduce pattern matching syntax ([pitr.ch](https://twitter.com/pitr_ch))
* Could the pattern matching be made available as a first-class citizen to be used as a filter when searching in data structures and to be a... -
12:46 PM Misc #15874: DevelopersMeeting20190613Japan
- * [Bug #15908] Detecting BOM with non-UTF encoding
-
- Currently, "bom|" encoding prefix to `File.open` is ignored if the encoding name is not a UTF.
But one usage of BOM is to tell if the stream is a UTF or not, and especially common on Windows, e.g. UTF-16LE or OEMCP.
So I think this res... -
12:17 PM Bug #15857: <=> の右辺が <=> を実装していない場合の振る舞い
- The patch looks good to me.
-
- Hi, I am really looking forward to this feature. Looks great!
However I'd like to make few suggestions which I believe should be part of the first pattern matching experimental release. I'll include use-cases and try to explain why i... -
- I cannot tell the order just by commit hashes.
-
-
- With the SDK of Xcode 10.2.1, `API_AVAILABLE` and so on macros are
not defined in <os/availability.h> when using a compiler other
than clang (which has `__has_feature` and `__has_attribute`), but
`__API_AVAILABLE` macro and so on are def... -
- * lib/rubygems/commands/unpack_command.rb: 'rubygems/package' is
required here, to fix broken `gem unpack` command. -
-
05:24 AM Bug #15807: Range#minmax is slow and never returns for endless ranges
- I think this is a bug we should fix, even if it breaks code relying on this bug ("all bug fixes are incompatibilities" :)).
I worked on a patch for #15867, before realizing mohsen created a pull request for this. My patch ended up be... -
- This reverts commit b76630f73e8362d3072bfa7178471ddc5d21c235.
It fails with `make test-bundler BUNDLER_SPECS=runtime/setup_spec.rb:1204` -
12:42 AM Feature #15665: Cannot compile socket extension on Mojave
- @nobu This should be a bug, not feature. Please mark it as a bug and backport it into 2.6 branch.
06/07/2019
-
11:44 PM Feature #15894: Remove support for IA64
- Here is a brief overview of one possible plan:
- We remove IA64 from 2.7.
- We retain IA64 in 2.6 which has a theoretical EOL date in 2022. That's 5 years past the last date of the CPU being manufactured, and 3 years past the archite... - 03:15 PM Revision 1696f80f (git): * 2019-06-08
-
03:14 PM Revision 19977cc7 (git): Remove unnecessary variables
-
-
02:37 PM Revision 75751dca (git): test/openssl/utils.rb: Extend the timeout for armv7l
- https://rubyci.org/logs/rubyci.s3.amazonaws.com/scw-9d6766/ruby-master/log/20190607T051708Z.fail.html.gz
-
- * lib/rubygems/commands/unpack_command.rb: 'rubygems/package' is
required. fix the failure of `gem unpack` command.
* lib/rubygems/source/local.rb: ditto.
* lib/rubygems/source/specific_file.rb: ditto. -
- Does it occur with 2.5.5, 2.6.3, or 2.7.0-preview1?
-
- * lib/rdoc/parser/ripper_state_lex.rb (RDoc::Parser::RipperStateLex):
chomp newline, including CR, from here document terminator.
Closes: ruby/rdoc#694
Closes: ruby/rdoc#697
Closes: ruby/rdoc#705 -
- Applied in changeset commit:git|a6a26e42b15c46f117f4fce07a2050e9d727355d.
----------
compile.c: Partially revert r63870 which caused wrong optimization
[Bug #15906] -
05:20 AM Bug #15906 (Closed): a=a のような式をもつ条件分岐が意図しない挙動をする
- [ruby-list:50781] から一部転載します。
```
下記スクリプトの結果が期待と違います。なぜでしょうか？
a = a は不要ですが、なにもしないことを明示するために書いたものです。
なおOS付属の ruby 2.3.7p456 では期待通りの結果でした。
a = "aaa"
if a == "bbb" || a == "ccc" then
a = a
else
puts "OK"
end
puts "EN... -
- [Bug #15906]
-
04:46 AM Revision b8af33e6 (git): Skip one assertion for OpenSSL::PKey::EC::Point#mul on LibreSSL
- LibreSSL 2.8.0+ does not support multiple elements in the first
argument. -
- Skip Process clockres specs that don't work on either FreeBSD or
Solaris/AIX in addition to OpenBSD.
Run most current String#crypt specs on non-OpenBSD, and add a new
set of crypt specs for OpenBSD, which support bcrypt but not DES
in c... -
- I'm not sure nobu's changesets are bug or feature.
But this issue was marked with "Feature" by nobu. We never backport the new feature to stable versions.
-
-
- https://rubyci.org/logs/rubyci.s3.amazonaws.com/scw-9d6766/ruby-master/log/20190606T171708Z.fail.html.gz
-
-
-
- This reverts commits:
* 6f9d5fafe040cb02a1278fbfcdcb8063d564824c
* bb3c89b6437049e26669b2156310670d5e06e386
And remove the dependency of Makefile on Makefile.in
transitionally.
06/06/2019
-
-
-
- Hello? Any update? Would it be included in 2.6.4?
- 05:04 PM Revision aee77901 (git): * 2019-06-07
-
- * ext/win32/lib/win32/registry.rb (Win32::Registry#each_value):
advance the index even if an error occurred in #read. -
- knu (Akinori MUSHA) wrote:
> Yeah, that would be the way completely against duck-typing.
Right, to clarify I meant the library would need the extra `.to_a` where it expects an Enumerator method to return an Array and not just some `E... -
01:55 PM Feature #15901: Enumerator::Lazy#eager
- > One argument would be the callee should do take_while {}.to_a if they really want an Array and not just an Enumerable (which has most of Array's methods).
> ...
Yeah, that would be the way completely against duck-typing. In my opinio... -
- knu (Akinori MUSHA) wrote:
> Suppose I want to pass the `enum` to another method that takes an Enumerable object where the passed object is expected to act eagerly. One of the most significant use cases is when the callee uses `take_wh... -
- Suppose I want to pass the `enum` to another method that takes an Enumerable object where the passed object is expected to act eagerly. One of the most significant use cases is when the callee uses `take_while` on a given object expecti...
-
-
- `LINKFORSHARED` means dynamically loaded extension libraries?
If so, `--with-static-linked-ext` configuration option makes all extension libraries linked statically (except for test libraries).
Or uncommenting the `option nodynamic` li... -
10:47 AM Misc #15905 (Feedback): [Documentation] [Request for the wiki at https://bugs.ruby-lang.org/projects/ruby-trunk/wiki] - Consider adding more information to statically compiled ruby variants
- I think maintaining the existing documentations already exceeded our capacity and some of them are still outdated, despite of our day-to-day continuous effort. So adding a new Wiki would be a big burden. Please suggest to delete an unnec...
-
10:36 AM Misc #15905: [Documentation] [Request for the wiki at https://bugs.ruby-lang.org/projects/ruby-trunk/wiki] - Consider adding more information to statically compiled ruby variants
- I think the document should be in doc/ of Ruby repository.
Feel free to create a patch.
Background:
Recently our Redmine wiki is suffered by spam, and I decided to restrict the edit permission.
Therefore it's now not a suitable pla... -
09:58 AM Misc #15905 (Feedback): [Documentation] [Request for the wiki at https://bugs.ruby-lang.org/projects/ruby-trunk/wiki] - Consider adding more information to statically compiled ruby variants
- Hello ruby core team in particular and other ruby folks,
This issue request here is primarily about documentation, in particular in regards to a "statically compiled
ruby". This refers either to a ruby that is completely static (no l... -
- https://rubyci.org/logs/rubyci.s3.amazonaws.com/unstable10s/ruby-master/log/20190602T031908Z.fail.html.gz
-
- https://rubyci.org/logs/rubyci.s3.amazonaws.com/unstable10s/ruby-master/log/20190605T231909Z.fail.html.gz
-
- Eregon (Benoit Daloze) wrote:
> mame (Yusuke Endoh) wrote:
> ...
Oh sorry I missed the point. Fair enough. I'll ask matz's opinion at the next meeting.
> > At least, I don't want to do that until we receive an actual request to ... -
- deep-cover might be interested by this too, cc @marcandre
-
- byroot (Jean Boussier) wrote:
> This is kinda tengential, so sorry if it's shifting the discussion. But if `resolve_feature_path` is to be made a first class public API, I wonder if it could be the occasion to make `Kernel#require` invo... -
- mame (Yusuke Endoh) wrote:
> However, we can't be too careful to add anything to `Kernel` nowadays.
I propose only as a class method, not an instance method, so I think there is literally no chance for conflicts. What's your concern?... -
- Great!
-
- * [Feature #15903] Move RubyVM.resolve_feature_path to Kernel.resolve_feature_path
* matz: is it OK to add `Kernel.resolve_feature_path` (only class method)? I think RubyVM is not a good place for `resolve_feature_path` which is not M... -
- * [Bug #15210] UTF-8 BOM should be removed from String in internal representation
A method to set the encoding on an `IO` by BOM? -
07:49 AM Revision fcc36d76 (git): Revert "Stop `circular require` warning"
- This reverts commit c2a9c350249588677cf68b506539093504927eac.
It cannot stop `circular require` warning. -
07:32 AM Bug #15904: Ruby crashes when executing Pronto gem with Rubocop
- Update: Interestingly, this crash does not happen when executing `pronto run -c develop` without the `bundle exec` in front.
-
- When running `bundle exec pronto run -c develop` ("develop" is a branch name) on console, Ruby crashed and asked me to report this as a bug. I tried again and the same thing happened.
This project's Pronto is set up with Rubocop. I'm ... -
07:28 AM Misc #15723: Reconsider numbered parameters
- sawa (Tsuyoshi Sawada) wrote:
> I just realized that there can be a rationale for using `@` as (part of) the default block parameter. That is, `@` is already used in method names of unary operators, such as `Numeric#+@`. There, `@` stan... -
07:00 AM Feature #15899: String#before and String#after
- > Using partition looks reasonable, and it can accept regexes.
It also has the problem of creating extra objects that you need to discard with `_` or assign and just leave unused.
> ...
more with time-based operations; and rack/sin... -
-
- Bundler.setup changes Gem::DefaultUserInteraction.ui and does not close
it. This change makes sure that it is closed. -
- OpenSSL 1.1.1 rejects some shorter keys, which caused some failures of
`make test-all TESTS=openssl`.
https://rubyci.org/logs/rubyci.s3.amazonaws.com/debian/ruby-master/log/20190606T003005Z.fail.html.gz
This change merges 6bbc31ddd1 an... -
-
- sawa (Tsuyoshi Sawada) wrote:
> jeremyevans0 (Jeremy Evans) wrote:
> ...
Thank you for providing some background on the purpose of the `real?` method. I agree that it doesn't make sense to change `real?`. Attached is a patch that onl...
06/05/2019
-
-
- (I'm an author of `RubyVM.resolve_feature_path`.)
Sorry but I'm not so positive. From perspective of module design, I agree that `Kernel` module looks the best place to add the method. However, we can't be too careful to add anythin... -
10:51 PM Feature #15903: Move RubyVM.resolve_feature_path to Kernel.resolve_feature_path
- This is kinda tengential, so sorry if it's shifting the discussion. But if `resolve_feature_path` is to be made a first class public API, I wonder if it could be the occasion to make `Kernel#require` invoke `Kernel#resolve_feature_path` ...
-
- RubyVM contains mostly MRI-specific features but `resolve_feature_path` is clearly not MRI-specific.
So I propose to move it as a class method of `Kernel`.
I think this makes sense given the related `load` and `require` are defined i... -
- Eregon (Benoit Daloze) wrote:
> @mame should the behavior that @znz reports be fixed?
I hear @nobu has already fixed the issue. (Thanks!) -
- @mame should the behavior that @znz reports be fixed?
`resolve_feature_path` sounds like it should always resolve a feature, no matter if the feature is loaded or not. -
- 07:25 PM Revision fd173372 (git): * 2019-06-06
-
-
05:37 PM Misc #15723: Reconsider numbered parameters
- By this post, I have no intention of expressing my preference to any proposal.
I just realized that there can be a rationale for using `@` as (part of) the default block parameter. That is, `@` is already used in method names of unary... -
- FWIW, we already inline `nil?` in the AST for TruffleRuby:
https://github.com/oracle/truffleruby/commit/57628008#diff-09677670ed37ee212c217374c6468718
Makes sense since it's such a small operation and it's frequently used. -
04:28 PM Feature #15902 (Closed): Add a specialized instruction for `.nil?`
- I'd like to add a specialized instruction for `.nil?`. We have specialized instructions for `.length` and `.empty?`, and surprisingly our application also calls `.nil?` a lot:
```
[aaron@TC ~/g/github (gc-boot-stats)]$ git grep '.em... -
- shugo (Shugo Maeda) wrote:
> I don't like both proposals, but I prefer `@1` to `it` because `@1` looks ugly and may help prevent overuse.
I think we should never purposefully introduce something ugly in the language.
Preventing over... -
01:20 AM Feature #15897: `it` as a default block parameter
- > Thus, I don't like my own proposal so much, honestly. But it would be much better than Perlish @1.
I don't like both proposals, but I prefer `@1` to `it` because `@1` looks ugly and may help prevent overuse.
Furthermore, the propos... -
- Why not `Enumerator::Lazy#force` (or `to_a`) ?
```ruby
enum = huge_collection.lazy.flat_map(&:children).reject(&:disabled?)
enum.map {|x| ...}.force # an array is returned
``` -
- There are cases where you want to create and pass a normal Enumerable object to a consumer where the methods like map and select are expected to return an array, but the calculation would be so space costly without using Enumerator::Lazy...
-
- See https://github.com/ruby/ruby/pull/2226 for benchmark results.
-
- and switch-case branches.
Buffer allocation optimization using `ALLOCA_N` would be the main
benefit of patch. It eliminates the O(N) buffer extensions.
It also reduces the number of branches using escape table like
https://mattn.kaoriy... -
- Because some `log.*` git configs may change the result of `git log`,
`RUBY_LAST_COMMIT_TITLE` can be wrongly formatted and break version.c
compilation. So the `git log` executions should not respect user's gitconfig. -
11:05 AM Bug #15900 (Closed): Resolv::DNS#each_name doesn't accept Resolv::IPv{4,6} against documents
- In resolv library, document says `Resolv::DNS#each_name` accepts `String`, `Resolv::IPv4` and `Resolv::IPv6`.
But `Resolv::DNS::IPv{4,6}` raises ResolvError.
```ruby
require 'resolv'
dns = Resolv::DNS.new
dns.each_name(Resolv::IPv... -
- I can see where it may be useful, since it could shorten code like this:
first_part = "hello world!".split(' ').first
To:
first_part = "hello world!.before(' ')
It is not a huge improvement in my opinion, though. ... -
- Using `partition` looks reasonable, and it can accept regexes.
```ruby
str = 'application/json; charset=utf-8'
before, _, after = str.partition(/; /)
before # => "application/json"
after # => "charset=utf-8"
``` -
- Since you are mentioning that `String#delete_suffix` and `String#delete_prefix` do not accept regexps and that is a weak point, you should better use regexps in the examples illustrating your proposal.
-
- There seems to be no methods for getting a substring before or after a marker.
Too often I see and have to resort to variations of:
``` ruby
str[/(.+?);/, 1]
str.split(';').first
substr, _ = str.split(';', 2)
str.sub(/.*;/, ''... -
- jeremyevans0 (Jeremy Evans) wrote:
> I think [that] Complex numbers with an imaginary part of zero should be treated as real numbers, and that `Complex#real?` should return `true` for such numbers.
Changing `Complex#real?`'s meaning ... -
- I agree that this is a bug. `Complex#<=>` should be implemented, even if it did return `nil` for all arguments.
However, I think Complex numbers with an imaginary part of zero should be treated as real numbers, and that `Complex#real... -
- When describing "Runtime errors", raise a `RuntimeError` as-is.
-
05:03 AM Revision f2581370 (git): Fix grammar of macro name: ECCESSED -> ECCESSIVE
- Fix the name of the macro variable introduced in 0872ea5330
from NODE_SPECIAL_EXCESSED_COMMA to NODE_SPECIAL_EXCESSIVE_COMMA. -
04:57 AM Bug #15886: return in rescue block breaks Timeout.timeout
- I like this proposed wording, thanks for taking care of this!
-
-
-
- This reverts commit 22cd4027349f803efc7ede284376b7a7013f8dfe.
It did not make sense due to a typo `@srcidr`. -
-
- Committed as commit:f1f04caf60e4fc9dc3b12109e0be831f2d692810
-
- 02:29 AM Revision 7c776038 (git): * expand tabs.
-
- FrozenError#receiver was added recently for getting the related
object programmatically. However, there are cases where FrozenError
is raised and not handled, and in those cases the resulting error
messages lack detail, which makes debu... -
- Documentation requested in [Bug #15886].
-
- I agree this is a bug and the easiest way to fix it is to inline the `SortedSet#initialize` implementation defined by `SortedSet.setup` into the default implementation of `SortedSet#initialize`. Attached is a patch that implements that.
-
-
-
-
- I submitted a pull request to ruby/ipaddr to fix this: https://github.com/ruby/ipaddr/pull/17
- 02:01 AM Revision 6b66a76f (git): * expand tabs.
-
- This reverts commit 8d81e59aa7a62652caf85f9c8db371703668c149.
`ALLOCA_N` does not check stack overflow unlike ALLOCV. I'll fix it and
re-commit it again. - 01:13 AM Revision 804a7907 (git): * 2019-06-05
-
- and switch-case branches.
Buffer allocation optimization using `ALLOCA_N` would be the main
benefit of patch. It eliminates the O(N) buffer extensions.
It also reduces the number of branches using escape table like
https://mattn.kaoriy...
06/04/2019
-
- I like the proposal and I think it reads nicer than `@`.
It's a bit magical that giving it an argument changes the semantics, but that's somewhat similar to having a `p` local variable, and I think it's worth the better readability and ... -
- mikegee (Michael Gee) wrote:
> > RSpec won't break because their "it" requires an argument
> ...
That's a block argument :). In any case, the parser treats it differently as NODE_ITER/NODE_FCALL, not as NODE_VCALL:
```ruby
RubyVM:... -
02:29 PM Feature #15897: `it` as a default block parameter
- > RSpec won't break because their "it" requires an argument
Unfortunately this is not accurate. RSpec has a shorthand style like this:
`subject { fortytwo }
it { is_expected.to eq 42 }` -
08:32 AM Feature #15897: `it` as a default block parameter
- shevegen (Robert A. Heiler) wrote:
> I was about to write a very lengthy reply, but I think it would be too difficult to read for others, so this is a somewhat shorter variant.
Good grief. -
- Hanmac (Hans Mackowiak) wrote:
> @mame you got me wrong, i mean you might not use `_` for this like you said in your P.S.
Isn't `{|_| _ }` no more or less conflicting than `{|it| it }` ? You can either use positional args, or a defa... -
- I was about to write a very lengthy reply, but I think it would be too difficult to read for others, so this is a somewhat shorter variant. So just the main gist:
(1) I don't quite like the name "it", mostly due to semantics (the name... -
07:51 AM Feature #15897: `it` as a default block parameter
- @mame you got me wrong, i mean you might not use `_` for this like you said in your P.S.
-
- @hanmac,
You cannot use both `it` and the ordinal parameter `|a,_,b|` simultaneously. It will cause a SyntaxError like this.
```
$ ./miniruby -e '1.times {|a,_,b| it }'
-e:1: ordinary parameter is defined
``` -
- `_` can't be used as default block parameter because it already has a special meaning when using block variables like `{|a,_,_,b| }`
-
- How about considering "it" as a keyword for the block parameter only if it is the form of a local varaible reference and if there is no variable named "it"?
```
[1, 2, 3].map { it.to_s } #=> ["1", "2", "3"]
```
If you are familia... -
- mame (Yusuke Endoh) wrote:
> * Incomplete pattern matching also rewrites variables: `[1, 2, 3] in x, 42, z` will write 1 to the variable "x". This behavior is the same as the current "case...in".
This sounds concerning to me.
With ... -
- destrozates (Socrates Medina) wrote:
> Thanks for your answer, and sorry for my late reply. I just wanted to be sure that this is not a Ruby issue. Can we say that we are sure about that?
We may not be 100% sure, but the segmentation... -
05:03 PM Bug #15862: Segmentation fault when running Rails commands
- mame (Yusuke Endoh) wrote:
> I think this issue is a bug or spec of rb-inotify. If it is a bug, it should be fixed. If it is a spec, rails should not use rb-inotify in such an environment. Anyway, you have already filed a ticket in t... -
03:45 PM Bug #13018: end of file reached (EOFError) from SMTP
- Excuse me, why isn't it fixed in 2.4? Does it break something?
I've probably misconfigured ports around my docker environment (it's yet to be investigated) and was now very confused with this. Had to run the program a lot of times, rese... - 02:17 PM Revision b31e1b4a (git): * expand tabs.
-
- It is used to represent "no default expression" for keyword argument:
`def foo(key:)`. This change uses NODE_SPECIAL_REQUIRED_KEYWORD. -
- `(ID)1` was assigned to NODE_ARGS#rest_arg for `{|x,| }`.
This change removes the magic number by introducing an explicit macro
variable for it: NODE_SPECIAL_EXCESSED_COMMA. -
- Sorry for the late response. See #15898. (In short, please use a newer Ruby.)
-
- Ruby 2.3 has ended.
https://www.ruby-lang.org/en/news/2019/03/31/support-of-ruby-2-3-has-ended/
I don't know the particular issue, but the following article (written in Japanese) says that Ruby 2.5 works without the issue.
https... -
12:43 PM Bug #15898 (Rejected): RoR server segmentation fault [arm-linux-gnueabihf] Rpi3
- Hi everyone,
### Configuration
- Ruby on Rails (v 5.2.3)
- Raspberry Pi 3 model B
- Raspbian (4.14.98-v7+ #1200 SMP Tue Feb 12 20:27:48 GMT 2019 armv7l GNU/Linux)
- Ruby (ruby 2.3.3p222 (2016-11-21) [arm-linux-gnueabihf])
### P... -
-
- I plan to fix this and copy the backtrace too in MRI, because it looks not intentional and inconsistent.
Anyone against? - 10:55 AM Revision 2e2cd829 (git): * expand tabs.
-
- * random.c: renamed random_data_type as random_mt_type, and append
"MT" to `wrap_struct_name`, respecting the implementation. -
- This reverts a commit miss, 24a96a0228ccf355826644a9daad69e11b67b53b.
-
-
- * marshal.c (rb_marshal_dump_limited): new function for extension
libraries to dump object with limited nest level.
* marshal.c (rb_marshal_load_with_proc): new function for extension
libraries to load object with hook proc. -
-
-
-
- [ci skip]
-
- [ci skip]
-
- [ci skip]
-
- [ci skip]
-
05:00 AM Feature #15878: Make exit faster by not running GC
- > A rough sketch of the process is that we first run GC normally, then if something remains, that is force-recycled.
No. We don't run GC at last.
````
diff --git a/gc.c b/gc.c
index 19ddf9bf20..d9f83dfaf8 100644
--- a/gc.c
+++ ... -
- I can confirm that the bug also happens on OpenBSD 6.5 with LibreSSL 2.9.1.
I created a pull request with a fix: https://github.com/ruby/openssl/pull/255 - 03:39 AM Revision ce4b5d90 (git): * remove trailing spaces. [ci skip]
-
-
- 02:40 AM Revision b0cb4bdb (git): * expand tabs.
-
-
- Your patch looks correct to me, but can you submit it as a pull request to the ruby/openssl repo: https://github.com/ruby/openssl/pulls
- 12:36 AM Revision 14b5ccf9 (git): * expand tabs.
-
- Terminate the input from a TTY by 2 ^D at the middle of line, like
as many programs, `cat`, `perl` and so on, do. By the first ^D,
the line will be sent without a newline, and then EOF will be send
by the next ^D.
06/03/2019
-
-
- to fix
https://dev.azure.com/rubylang/ruby/_build/results?buildId=1162&view=logs -
-
- Hashes that compare by identity care about the location of the object in
memory. Since they care about the memory location, we can't let them
move. -
-
-
- This commit adds compaction support to method and proc objects. It just
unpins references and implements the "compact" callback and updates
references. - 06:52 PM Revision ca22cccc (git): get rid of a warning of VC++
-
- I agree with benoit and jeremy, also in regards to the use case description; even speed/cache considerations aside, matz
possibly may consider the proposal to not fit into/to class Symbol by default. It is actually already awesome that ... -
- I am against adding this to core. Symbols represent identifiers, not data/text. Strings should be used for data/text. I don't think we should add methods to Symbol that further blur the line between String and Symbol.
I would rather ... -
- FWIW, there is no need for a cache, since Symbols are interned (and an explicit cache would leak memory).
I think Symbols are generally different than Strings, so #+ feels a bit out of place for me here.
Can you show a realistic use ... -
04:47 PM Feature #15896 (Rejected): Symbol#+
- I've made this today
``` ruby
class Symbol
@@cache_add = Hash.new {|h1,k1| h1[k1] = Hash.new {|h2,k2| h2[k2] = :"#{k1}#{k2}"}}
def +(s) @@cache_add[self][s] end
end
:abc + :def
# => :abcdef
```
I thought it was so awesome ... -
- jeremyevans0 (Jeremy Evans) wrote:
> However, I think it makes sense to expand the Timeout.timeout documentation to mention that you should not use it with blocks that you do not trust, with examples of things that can go wrong (such as... -
- moio (Silvio Moioli) wrote:
> jeremyevans0 (Jeremy Evans) wrote:
> ...
The documentation is technically accurate, so I would not classify this as a documentation bug. The exception is raised, but the code swallows it.
However, I thi... -
- jeremyevans0 (Jeremy Evans) wrote:
> moio (Silvio Moioli) wrote:
> ...
I understand your reasoning - but in this case I would suggest to clarify the method documentation to be more explicit about the limits of what Ruby guarantees here... -
04:52 PM Bug #15895 (Closed): String#gsub and String#sub should return original string if no substitution(s) have been made
-
- Thank you for pointing me to `CGI.escape_html`. I was not aware of it being faster than the `gsub` route. Moreover, you're right about the `gsub` usage not being a bottleneck in my codebase.
It simply resulted in numerous string alloc... -
- I can understand why you want it, but that would be a breaking change for existing code which assumes that `gsub` always creates a new String instance and performs a destructive operation on the `gsub`'s return value. In that code the or...
-
- Currently if one were to call `'Hello World'.gsub(/[<&>]/, html_entities_hash)` , a copy of 'Hello World' is allocated and returned. If such a call were to occur inside a loop, then that would cause numerous copies to be allocated simply...
-
-
- 0c459af7c233adb5f44022350bfe8fa132d8053e changed the meaning of
`detect_compile_error`, and this commit lets it follow the change. -
-
- in de541fe1961370e64541d73c96cf790d30f28604 :bow:
-
- Actually de541fe1961370e64541d73c96cf790d30f28604 was still needed.
This commit would improve the test coverage using the branch. -
- This was needed before 0c459af7c233adb5f44022350bfe8fa132d8053e but it
could be actually useless now. But I added this anyway just in case. - 03:20 PM Revision 6498c733 (git): * 2019-06-04
-
- * lib/irb/color.rb (IRB::Color.scan): ignore "incomplete end of
input" error only, to colorize invalid characters, e.g., control
characters, and invalid symbols, as errors. -
- This reverts commit 4c0e21add7c87b70df27fbff81d8f192a467556d
because we're not using /bin/bash.
See 11d3986d6557eb3cfcecbdd0ef6e21b18c7c960b and
1b2b0e1f244b3e71812fa9859e8b87150ea30434 to know its context.
In short, 4c0e21add7c87b70df2... -
- This reverts commit 11d3986d6557eb3cfcecbdd0ef6e21b18c7c960b.
Travis was broken by that. -
- at least on Ubuntu.
The brace expansion does not work on Ubuntu /bin/sh (dash), and so
4c0e21add7c87b70df27fbff81d8f192a467556d effectively broke /bin/sh
compatibility of common.mk.
I guess he was using macOS whose /bin/sh is bash. -
- Since 72ad092960c413b6a5687c552747b20a5ed78b22, we cannot run full `make benchmark`
because default BENCH_RUBY is miniruby and it fails to require 'time'.
Using miniruby for benchmark by default seems reasonable for some cases,
but now ... -
11:09 AM Bug #15637: Backport RubyGems 3.0.3/2.7.9
- @hsbt, sure. Thank you for the checking!
-
- Ruby 2.6 supports endless range, and ruby 2.7 will support beginless range.
-
- The operators are using @waiting_operator_proc in vi mode.
-
- Nobody uses this function other than gc.c. We only need
RVALUE_PINNED(). -
- * parse.y (tok_hex): flush token after dispatching the "invalid
hex escape" parse error. -
- Could you try a newer version, such as 2.5.5, 2.6.3 or 2.7.0-preview1?
-
-
- And dump the title as US-ASCII.
-
- Applied in changeset commit:git|17af8bfce6508951edca8650155be5525a894f65.
----------
Make size on an infinite each_slice enumerator return Infinity
Fixes [Bug #15889] -
- Fixes [Bug #15889]
-
-
- ```
% cat ~/bench-split.yml
prelude: |
s = "foo\nbar\nbaz\n"
benchmark:
'/(?<=\n)/': |
s.split(/(?<=\n)/)
'/^/': |
s.split(/^/)
'lines': |
s.lines
Warming up --------------------------------------
/(?<=\n)/...
06/02/2019
-
-
-
-
-
- 04:36 PM Revision aeb3a2b3 (git): * 2019-06-03
-
- Closes: https://github.com/ruby/ruby/pull/2221
-
- Closes: https://github.com/ruby/ruby/pull/2222
-
- Closes: https://github.com/ruby/ruby/pull/2222
-
-
- @jaruga
Sorry, my late response. your list is correct commits.. -
- Maybe 2.7.0-preview1 resolved this feature request.
-
-
- hsbt merged the pull request, so this can be closed.
-
- Psych is a default gem, it is managed on GitHub. I've added a pull request to implement this: https://github.com/ruby/psych/pull/403. Assigning this to hsbt as he is a psych maintainer and has done most of the recent maintenance.
For... -
- Fixes Ruby Bug #15890
-
- While the conversion from `open` or `Kernel.open` to `URI.open` is simple, this is likely to break a lot of existing Ruby code. However, I can see the security advantages of deprecating this, as having `open` implicitly open URIs is a s...
-
03:17 AM Misc #15723: Reconsider numbered parameters
- Seems to me like there's some kind of consensus about making this feature available for one argument only.
I would echo the desire to go with `it`, in line with Ruby's principles of elegance. It seems most objections that have been ra...