Activity
From 05/18/2019 to 05/24/2019
05/24/2019
-
11:24 PM Revision 19430b77 (git): Fix wrong variable name
-
-
11:02 PM Bug #15875: const_defined? behavior inconsistency in 2.6.x series
- ### Side Note #1
`const_get()` could get this constant for all released versions, but has been intentionally changed in 2.7. Correct?
```
% ruby -e "module A; end; B = 1; p Object.const_get('A::B')"
[1.9.3...2.6.3]
1
[2.7.0... -
- `Module#const_defined?` returns true for unreachable nested fully qualified module name.
Here are the results of `const_defined?` for each ruby version on my machine.
```
% ruby -e "module A; end; B = 1; p Object.const_defined?('A::... -
09:45 PM Bug #15872: CSV.parse omits close call when block is given – intended or bug?
- `CSV.parse` expects a `String` as the input. So `close` isn't necessary.
If you have a problem case, could you report this with the problem case to https://github.com/ruby/csv/issues ? -
10:01 AM Bug #15872 (Rejected): CSV.parse omits close call when block is given – intended or bug?
- When a block is given and the argument is an IO-like object, it may not reach its end after exiting the `each` method.
-
09:08 AM Bug #15872 (Rejected): CSV.parse omits close call when block is given – intended or bug?
- The current implementation of `CSV.parse` doesn't call `close` when a block is given:
```ruby
def self.parse(*args, &block)
csv = new(*args)
return csv.each(&block) if block_given?
begin
csv.read
ensure
csv.cl... -
08:39 PM Misc #15874: DevelopersMeeting20190613Japan
- - [Bug #15792] GC can leave strings used as hash keys in a corrupted state / bad fstring + shared string interaction can lead to use-after-free
- I have a PR https://github.com/ruby/ruby/pull/2183 for a case of this with `String#b` th... -
03:58 PM Misc #15874 (Closed): DevelopersMeeting20190613Japan
- Please comment your favorite ticket numbers you want to ask to discuss with your *SHORT* comment or summary.
(your summary/comment will help us because we don't need to read all of ticket comments)
*DO NOT* discuss then on this ticke... -
-
-
-
-
-
03:46 PM Misc #15843: Make "trunk" a symbolic-ref of "master" on git.ruby-lang.org
- If you're talking about commit:5da52d1210625fb00acd573b3f32281b4bde1730 and commit:a205e24747497391390ef7c004293a8a7934dd96, that's not related to this ticket. Please comment on #14632 or in a new ticket instead.
-
02:51 PM Misc #15843: Make "trunk" a symbolic-ref of "master" on git.ruby-lang.org
- Maybe the changes to RUBY_DESCRIPTION (ruby -v) and RUBY_REVISION could be noted somewhere...
-
- Sorry for your inconvenience, it was originally written in the ticket but I somehow deleted that in the later edit. I just resurrected the "Expected outcome" section in the original description.
-
09:09 AM Misc #15843: Make "trunk" a symbolic-ref of "master" on git.ruby-lang.org
- Please not only give us a schedule, but tell us exactly (in terms of git commands) what this means for people which are not *totally* familiar with git. Please do NOT assume that everybody "just knows".
-
- This reverts commit 481ccf73d88797914f700e6e27711bf1ce997eb0.
-
-
- 03:25 PM Revision b2150548 (git): * 2019-05-25
-
-
- Probably you are using `frozen-string-literal` pragma.
Since 2.6, OpenURI clears the buffer from `Net::HTTPResponse#read_body` to reduce memory usage.
See [Feature #14320].
-
12:58 PM Bug #15873: FrozenError when using OpenURI.open
- nobu (Nobuyoshi Nakada) wrote:
> Does it occur even if the body is `"Random information".dup`?
Just tried and no, when using `.dup` it worked as expected! -
- Does it occur even if the body is `"Random information".dup`?
-
- I just updated from Ruby 2.5.1 to 2.6.3 and I encountered a strange problem on a part that was working fine previously. It's on a Rails application, and on one of the tests I'm stubbing (using [webmock](https://github.com/bblimke/webmock...
-
12:48 PM Revision 2d34087a (git): Add notes for the Process#clock_getres spec
-
- * https://rubyci.org/logs/rubyci.s3.amazonaws.com/aix71_ppc/ruby-trunk/log/20190522T103301Z.fail.html.gz
-
10:39 AM Feature #15831: Add `Array#extract`, `Hash#extract`, and `ENV.extract`
- > I also concern about the name conflict with the ActiveSupport method.
I guess this comment addressed https://bugs.ruby-lang.org/issues/15863 that adds `Hash#slice!`, right?
Active Support doesn't have any `extract` methods, only `e... -
10:03 AM Revision 706c816a (git): Escape dots in regexp
- 10:00 AM Revision a4da223c (git): * expand tabs.
-
- This reverts commit 712c027524e3a03500b3098d950fc2f0608ce897.
-
- Unicode version 12.1.0 was officially released on May 7th, 2019.
There were no changes at all from the "real" beta
published shortly after the new era name "Reiwa" was announced.
So we can switch UNICODE_BETA back to NO.
... -
08:52 AM Revision b0a4d81f (git): check RVALUE on verifier.
- GC.verify_internal_consistency() checks health of each RVALUE with
check_rvalue_consistency(). However, this function is enabled
only on debug environment (RGENGC_CHECK_MODE>1). So introduce
new function check_rvalue_consistency_force() ... -
- is_pointer_to_heap() checks if it is in valid pointer to the
RVALUE in any heap_page_body. However, it returns true if it
points tomb pages. This patch check it points to eden pages. -
-
-
-
- * time.c (ndigits_denominator): calculate the denominator for
digits. -
- Ruby came out of Unicode 12.1 BETA with commit e713c2bde8. So this issue can be closed.
The reason it is more difficult to get out of beta than to enter beta is because the behavior in beta is to always check for new versions of files... -
- Completed with commit e713c2bde8
-
-
-
-
-
- 上に貼ったチケットを見る感じでは、mysql2 0.5.2 で修正されたのではないかと思っています。
-
05:03 AM Bug #15855: bundle exec rake db:migrateでsegmentation fault が発生する
- https://github.com/brianmario/mysql2/tree/master/ext/mysql2
これを見てUpdate encoding tables from MySQL 8.0.16のコミットが見つかったので、最新状態に更新したのですが、依然同じエラーが吐かれます。
mysql 8.0.16
mysql2 0.4.10です。
-
- Unicode version 12.1.0 was officially released on May 7th, 2019.
There were no changes at all from the "real" beta published shortly
after the new era name "Reiwa" was announced. So we can switch
UNICODE_BETA back to NO.
common.mk: swit... -
-
05:02 AM Bug #11512: DelegateClass.#public_{instance_}methods are returning difference values.
- This appears to still be a bug. The patch needed a little manual help to apply, and the tests needed to be updated, but after those changes, all tests passed. Attached is an updated patch. I'll try to commit it next week unless I hear...
-
- I've added a GitHub pull request to fix the `String#crypt` tests on OpenBSD (https://github.com/ruby/ruby/pull/2200). It's less invasive than the previous patch, and should result in the same behavior on !OpenBSD. I plan on merging it ...
-
- Applied in changeset commit:git|dfc21a0467d39af00666aec5098530529924cf48.
----------
Ignore generated files by in-place build [Bug #15870] -
- When I try to use git, I often get messages like the following:
```
Untracked files:
(use "git add <file>..." to include in what will be committed)
bin/cygruby270.dll
bin/goruby.exe
bin/ruby.exe
... -
- Applied in changeset commit:git|7f2f56b2f51269f42f822ecf346375b040267595.
----------
Define GITPULLOPTION to rebase [Bug #15871] -
- With svn, I have been using "make up" to get my local version up to date.
This works with git, except that it seems to just use `git pull` rather than `git pull --rebase`.
There is an environment variable `GITPULLOPTIONS`, which is... -
-
-
- https://rubyci.org/logs/rubyci.s3.amazonaws.com/aix71_ppc/ruby-trunk/log/20190522T103301Z.fail.html.gz
-
- It fails on some CI environments.
https://rubyci.org/logs/rubyci.s3.amazonaws.com/debian8/ruby-trunk/log/20190524T003006Z.fail.html.gz
https://rubyci.org/logs/rubyci.s3.amazonaws.com/unstable11s/ruby-trunk/log/20190523T002505Z.fail.html.gz -
- As delegate.rb is unmaintained, unless someone objects in the next week, I plan on committing this feature.
05/23/2019
-
10:51 PM Feature #15868: Implement `File.absolute_path?`
- Out of interest, how does it treat relative paths like `C:foo\bar`?
(Funny observation: according to Microsoft, `\foo\bar` is an absolute path in Windows, according to their definition of "absolute path") -
02:07 PM Feature #15868: Implement `File.absolute_path?`
- Thanks @nobu, I updated the patch! Copy-pasta... :|
-
01:32 PM Feature #15868: Implement `File.absolute_path?`
- I have no particular pro/con opinion on the suggestion itself, but I should state that since Pathname was mentioned - I
myself use File.* related methods exclusively. I used to use pathname in the past but I sort of gave up on it eventu... -
- > ```diff
> ...
The method name is wrong, and `File.absolute_path?("/foo/bar")` should be false on Windows as it doesn't have the drive letter. -
- Ouch!
I actually read the `Pathname` docs, which state:
* "However non-Unix pathnames are supported experimentally", in the main section.
* "It returns true if the pathname begins with a slash", in the `#pathname` docs.
And ... -
- `Pathname("C:/foo/bar").absolute?` should return `true` on Windows.
I think it does already:
https://github.com/ruby/ruby/blob/fe3ff5afb07e171fd950623c69abfbabbb2762a3/test/pathname/test_pathname.rb#L278-L282
On non-Windows platform... -
- Currently there's no way to check whether a path is absolute or not in a way that works accross OSs. The pathname library has the #absolute? method, but that only checks whether the path starts with a slash, which is not appropriate for ...
-
- Interesting. Not sure if this has to do with Markov Chain per se, but for storing state
through automata (in bioinformatics), hidden markov models are also used. Perhaps
extending Matrix may be beneficial in general (for ruby as a lar... -
08:15 PM Feature #15869: Add abs to Matrix
- bonafernando (Fernando Wolf Bona) wrote:
> While I was studying Markov Chain I had to find the maximum absolute value of the Matrix to divide the matrix in numbers from 0 to 1 to be able to make further analysis. Like this:
> ...
PR: h... -
- While I was studying Markov Chain I had to find the maximum absolute value of the Matrix to divide the matrix in numbers from 0 to 1 to be able to make further analysis. Like this:
```
q = Matrix[ ... ]
max = q.to_a.flatten.map { |e... -
-
- IIRC, at the last meeting (20190522), the conclusion was that this method should select non-nil values only, like as `Array#compact`.
Am I correct?
-
05:51 AM Feature #15323 (Closed): [PATCH] Proposal: Add Enumerable#filter_map
- Applied in changeset commit:git|0acbdd1ed0d2302743525a5188cc5a0d6251680c.
----------
Adding Enumerable#filter_map
[Feature #15323]
Closes: https://github.com/ruby/ruby/pull/2017 - 03:42 PM Revision dde8ceaf (git): * 2019-05-24
-
- because too-large Wercker output is truncated.
ruby/mjit-debug is a private repository for now, because the person
fixing it is likely to be me or another committer. -
- for debugging
http://ci.rvm.jp/results/trunk-mjit-wait@silicon-docker/2048247 -
-
-
-
-
- Closed by [f5415a95ce1d393a3fd1d7f657ba85d85171356a](https://bugs.ruby-lang.org/projects/ruby-trunk/repository/git/revisions/f5415a95ce1d393a3fd1d7f657ba85d85171356a)
I missed the tag to close the ticket. -
02:59 AM Feature #15772: Proposal: Add Time#ceil
- Thank you!
- 01:39 PM Revision 0b4d51b0 (git): * expand tabs.
-
- Closes: https://github.com/ruby/ruby/pull/2133
-
- Applied in changeset commit:git|fe3ff5afb07e171fd950623c69abfbabbb2762a3.
----------
Suppress paranoid warnings for external/3rd-party libraries
[Feature #15665] -
- From where `-Werror` and `-Wunused-parameter` came?
```
"clang -I../../.ext/include/x86_64-darwin18 -I../.././include -I../.././ext/socket -I../.. -I../../. -I/opt/local/include -D_XOPEN_SOURCE -D_DARWIN_C_SOURCE -D_DARWIN_UNLIMITED... -
05:11 AM Feature #15665: Cannot compile socket extension on Mojave
- nobu (Nobuyoshi Nakada) wrote:
> That check is necessary only for very old, 6 years ago, header.
> ...
Please find attached. I was trying to install 2.6.3 version. -
- [Feature #15665]
-
-
08:24 AM Revision 878a06ef (git): add comments [ci skip]
- Also requested by Ko1.
-
- requested by Ko1.
-
- Sanitizers and fortifications do not interface, and there is currently
no plan for them to work together.
See also https://github.com/google/sanitizers/issues/247 -
- Caller of gc_pin() should check it is a mark-able object.
So gc_pin() doesn't need to check it. With this fix,
we can refactoring around it. -
- 06:33 AM Revision c5cbabf8 (git): Use colorized IRB on Windows without checking `TERM`
-
- [Feature #15323]
Closes: https://github.com/ruby/ruby/pull/2017 -
-
- OpenBSD deprecated `crypt(3)` in November 2014 (https://github.com/openbsd/src/commit/608633c1c51b59b1f0d77d3d5b646ff8d27407aa). However, I doubt that `crypt(3)` will be removed in the near future, if ever. OpenBSD didn't remove `gets(3...
-
04:54 AM Bug #15839 (Closed): mixed encoding heredoc should be a syntax error regardless the order
- Applied in changeset commit:git|c05eaa93258ddc01e685b6cc3a0da82998a2af48.
----------
Fix mixed encoding in heredoc
Heredocs are parsed line-by-line, so we need to keep track of the
temporary encoding of the string. Previously, a hered... -
- Heredocs are parsed line-by-line, so we need to keep track of the
temporary encoding of the string. Previously, a heredoc would
only detect mixed encoding errors if they were on the same line,
this changes things so they will be caught ... -
- Applied in changeset commit:git|f91b1ab33d397fdcdf452d563d7f59469a078d88.
----------
Skip assertion in readline test if Readline version is 4.3
Previously, the entire method was not run for Readline 4.3, probably
because it was known t... -
- Previously, the entire method was not run for Readline 4.3, probably
because it was known to fail. Commit
c754e979d3eeca51f1b13778f19f347df3da656e removed the check for
Readline 4.3. Other than this one assertion, which also doesn't
wor... -
- rb_gc() no longer invokes finalizers, so there are T_ZOMBE objects.
-
- Objects pointed by "maybe" pointers because of conservative marking
should be pinned down. -
- Applied in changeset commit:git|136ae55892ae120bb94e4ff2d025c745fdaa1091.
----------
Do not kick finalizers on rb_gc().
rb_gc() kicks gc_finalize_deferred(), which invokes finalizers.
This means that any Ruby program can be run this po... -
- rb_gc() kicks gc_finalize_deferred(), which invokes finalizers.
This means that any Ruby program can be run this point and
it may be thread switching points and so on.
However, it is difficult to think it invokes any Ruby programs.
For ... -
- ARRAY_ASET() does not change the length of array, so
use rb_ary_push() instead of ARRAY_ASET(). It prevents
updating reference on GC.compact.
05/22/2019
-
-
- Always checks termination if you press Enter at last line.
-
09:52 PM Bug #15867 (Closed): Enumerable#minmax inconsistent behavior with Time ranges
- With `Date` the behavior is consistent for inclusive and exclusive ranges:
```
>> (Date.new(2019, 7, 1)..Date.new(2019, 7, 3)).min
=> #<Date: 2019-07-01 ((2458666j,0s,0n),+0s,2299161j)>
> ...
=> #<Date: 2019-07-03 ((2458668j,0s,0n)... -
- > Let me see the real-world use-case, please.
Since proposed `Hash#slice!` method is the same as `Hash#extract!` from the Active Support, there is one use-case where we have some `options` then we extract some known by keys options an... -
07:44 AM Feature #15863 (Rejected): Add `Hash#slice!` and `ENV.slice!`
- I don't think we have seen the use-case that this method is absolutely necessary.
Let me see the real-world use-case, please.
Matz. -
- This reverts commit 1ebe9a2f82fef5190454e68d430004282f5da172.
because it did not help. -
- CI seems to have a weired behavior now. Debugging.
Revert "azure-pipelines.yml: Fix typo"
This reverts commit f69d28fbca1eec8b9722cea1f989ee9554e8dad5.
Revert "azure-pipelines.yml: Use simpler trigger syntax"
This reverts commit 7097... -
- follow up for d3f1c615c5
-
-
-
-
-
-
- Applied in changeset commit:git|9d39eb6b40966deeeaa23c28f0be640c56545644.
----------
range.c (inspect_range): omit beginless "nil"
except the special case `(nil..nil)`.
```
(1..).inspect #=> "1.."
(..5).inspect #=> "..5"
(ni... -
- I'd pick the following representation:
```
(1..).inspect #=> "1.."
(..5).inspect #=> "..5"
(nil..nil).inspect #=> "nil..nil"
```
Matz. -
- except the special case `(nil..nil)`.
```
(1..).inspect #=> "1.."
(..5).inspect #=> "..5"
(nil..nil).inspect #=> "nil..nil"
```
[Bug #15745] -
-
-
- Applied in changeset commit:git|d3f1c615c5b81319e422e9c92e1cb8ba82209fba.
----------
hash.c (rb_hash_s_create): Reject `Hash[[nil]]`
The behavior of `Hash[[nil]] #=> {}` was a bug until 1.9.3, but had been
remained with a warning becau... -
- The behavior of `Hash[[nil]] #=> {}` was a bug until 1.9.3, but had been
remained with a warning because some programs depended upon it.
Now, six years passed. We can remove the compatibility behavior.
[Bug #7300] - 03:15 PM Revision 4d622969 (git): * 2019-05-23
-
-
- * tool/make-snapshot: default to the current branch if no branch
but srcdir is given. -
- * tool/make-snapshot (package): dump to stringize GIT revisions
properly. -
- @jeremyevans0
Thanks a lot! I think that your v3 patch is correct...so please commit it yourself. Welcome. -
- @jeremyevans0 Congrats! Please wait for @hsbt's guidance. (He will ask you to send your ssh key.)
-
- @jeremyevans0 Welcome to the committers.
Matz. -
- * tool/make-snapshot (package): use the last revision of the whole
tree as the revision name, not a single file.
* tool/file2lastrev.rb: ditto. dump without unnecessary subrange
and literal quotes, to stringize SVN revisions properly. -
- * tool/vcs.rb (VCS::GITSVN.revision_name): should delegate to the
same method of SVN, not an undefined method. -
- > If you change something, pls tell your schedule and we can check the CI system.
Sure. I updated the description.
Once I make a symbolic-ref tomorrow, I'll post an email to ruby-core to share the schedule and ask for updating CI sys... -
- I'm negative against the Main part (moving the branch) immediately, which seems a too big change.
Why not making "master" as a symbolic-ref at first? -
- If you change something, pls tell your schedule and we can check the CI system.
-
06:30 AM Misc #15843: Make "trunk" a symbolic-ref of "master" on git.ruby-lang.org
- I don't disagree this proposal.
But, I want to know what do you mean in the term "Out of scope (for a short term)".
What is "short" ? -
- akr (Akira Tanaka) wrote:
> We are not sure the stability of RubyVM::AbstractSyntaxTree.
> ...
Right, so I think we need to document it's not stable yet as clearly as possible.
> We want to know such unstability has big impact for
... -
07:41 AM Feature #14844: Future of RubyVM::AST?
- We are not sure the stability of RubyVM::AbstractSyntaxTree.
For example, Ruby 2.7 will add new node for pattern match.
We want to know such unstability has big impact for
practical applications or not.
I feel it is difficult to ... -
- @matz Do you mean `in` rather than `if` for the keyword?
-
- I am pretty positive about adding single line pattern matching in Ruby. I am still wondering whether `if` is a right keyword for it. Let me think about it for a while.
Matz.
-
- ko1 (Koichi Sasada) wrote:
> We can't introduce guard pattern (`pat if expr`) because it will conflict with `expr if cond`.
You have to write as `val in expr and cond`. -
- Trivial comment.
We can't introduce guard pattern (`pat if expr`) because it will conflict with `expr if cond`. -
- matz (Yukihiro Matsumoto) wrote:
> I don't think we have seen the use-case that this method is absolutely necessary. I also concern about the name conflict with the ActiveSupport method.
> ...
There are use-cases of `Array#extract` in ... -
- I don't think we have seen the use-case that this method is absolutely necessary. I also concern about the name conflict with the ActiveSupport method.
Let me see the real-world use-case, please.
Matz. -
09:29 AM Bug #15625: Module#name performance has exponential-time worst case by aliased constants
- This was fixed in https://bugs.ruby-lang.org/issues/15765
-
- This was fixed in https://bugs.ruby-lang.org/issues/15765
-
- Interesting idea. We need to investigate the idea further.
Matz.
-
- I am against having `finite?` or `infinite?` methods. I don't think there's use-case for those methods.
Meanwhile, I see the small possibility for the usage of `beginless?` and `endless?` methods. But I don't like the names.
Matz.
-
- Do you mean that `Range#infinite?` is no longer needed if the behavior of `("a"..).size` is changed? If not, I think it is a different topic from this ticket.
-
- How about doing this?
```ruby
("a".."z").size # => nil
(.."z").size # => Infinity
("a"..).size # => Infinity
```
-
- Thanks comments!
> I think infinite? is a different concept, which already exists as Numeric#infinite?, and should definitely handle the Float::INFINITY case if introduced
I also considered the following implementation.
```ruby
... -
- Note of this issue:
We assume that `ary` in `RARRAY_ASET(ary, ...)` is not FROZEN and SHARED. This code violate this assumption.
Nobu's fix solved this issue by using `rb_ary_push()` which works with a SHARED array (and added a trick... - 07:54 AM Revision 2fb69b32 (git): * expand tabs.
-
- * gc.c (rb_raw_obj_info): new string objects cannot allocate to
create new class path name during GC. -
-
- Closed by [b00f280d4b](https://bugs.ruby-lang.org/projects/ruby-trunk/repository/git/revisions/b00f280d4b9569e7153365d7e1c522b3d6b3c6cf)
-
- * variable.c (set_namespace_path): set path to the whole namespace
tree. [Feature #15765] -
- * variable.c (build_const_pathname): build constant path from
name as a string. [Feature #15765] -
- * variable.c: make the hidden ivars `classpath` and `tmp_classpath` the source
of truth for module and constant names. Assign to them when modules are bind
to constants.
* variable.c: remove references to module name cache, as what ... -
- I accepted the proposal at the last developer meeting but forgot to post here.
I do reject having both block and block argument at the same time. [[ruby-core:92505]](https://bugs.ruby-lang.org/issues/15323#change-77866)
Regarding `filt... -
- Could you give me speed benchmark results, for example with discourse (any rails benchmark is okay)?
If it is difficult, I'll check it.
> Same sequence of redmine requests - 6 for this branch and trunk respectively using this as a si... -
05:57 AM Bug #15866: [BUG] Segmentation fault at 0x0000000000000020
NOTE: does not happen if i remove following line from code:
request.body = "{"data":{"post ID 1":{"se_name":"google.co.uk","se_language":"English","loc_name_canonical":"London,England,United Kingdom","key":"rank checker"}}}"
-
- /bin/bash -c "/home/test/.rvm/bin/rvm ruby-2.5.0 do /home/test/.rvm/rubies/ruby-2.5.0/bin/ruby /opt/rails/test/bin/rails server -b 0.0.0.0 -p 3001 -e production"
=> Booting WEBrick
=> Rails 5.0.2 application starting in production on h... -
05:47 AM Feature #14915: Deprecate String#crypt
- Just removing deprecated feature doesn't provide additional value.
In this case UNIX crypt(3) is sometimes used as a basic building block.
Removing a wrapper of such block may cause a compatibility issue.
As usa says why OpenBSD s... -
- I feel warning is too strong.
crypt function is required to implement password checking for /etc/passwd.
-
- As a matter of practice, OpenBSD still has `crypt`.
It means that it's too difficult to remove this function at this timing, IMO.
We'll remove it in the future, I guess, but not now. -
- Accepted.
Matz.
-
02:41 AM Misc #15782: DevelopersMeeting20190522Japan
- Today's venue has been changed to Speee Inc. at Roppongi.
Do not go pixiv.
05/21/2019
-
-
- I have no strong opinion to the proposal itself, but I'm also skeptical to the motivating example. I'd like to write:
```ruby
def search_in(range)
path = "/search"
query = []
query << "from=#{ range.begin }" if range.begin
... -
- Why is `range.begin.nil? || range.end.nil?` not enough to check if beginless or endless Range?
Maybe we should integrate beginless/endless in pattern matching?
The use-case can be simplified quite a bit if we can assume `false` is ... -
- I think the proposal makes sense. The method names are a bit odd though.
I have no huge qualms with the inf* related methods, such as infinite? or
finite? although it reads a bit odd; but I think that .beginless? and
.endless? are v... -
## Summary
Proposal to add methods to determine if it is an infinite range.
## Current status
```ruby
# begin / end return nil
p (..10).begin # => nil
p (1..).end # => nil
# But, first / last raise an exception
p...-
-
09:52 PM Bug #15856: Performance of redundant `Kernel.require` is slow when many gems are activated
- Okay that explains what I was seeing, I just didn't realize that it was that subtle around .so loading, but I think I've verified that this is for those native libraries only.
I'd argue that your patch results in more correct and less... -
-
- RHS assignment looks a bit weird to me.
I guess most languages have `<pattern>` SIGIL/KEYWORD `<expr>`, which seems more natural like:
```ruby
x, y, z = [1, 2, 3]
{ name:, age: } = json
if { name:, age: (20..), address: { city... -
- Oops, the first example was wrong. Fixed.
```
-[1, 2, 3] in 1, 2, 3 #=> false
+[1, 2, 3] in 1, 2, 4 #=> false
``` -
- I don't have a big pro/contra opinion per se on the whole topic of pattern matching,
but I would wait a bit before finalizing more and more additions on top of it. Now pattern
matching is probably there to say, I understand that, but i... -
- How about adding a syntax for one-line pattern matching: `<expr> in <pattern>` ?
```
[1, 2, 3] in x, y, z #=> true (with assigning 1 to x, 2 to y, and 3 to z)
[1, 2, 3] in 1, 2, 4 #=> false
```
More realistic example:
```
js... -
-
- 05:14 PM Revision 232f1117 (git): * 2019-05-22
-
-
- hsbt (Hiroshi SHIBATA) wrote:
> Do not change status field.
> ...
That is a *workaround*. It will break in the future. Please read the bold text in the quote. If by your definition my environment is broken, then maybe next year *all* m... -
- Closed by ac00bdc8a8ac2c62a94dd36a7784d15bbcb7df19
-
- Just a note, for compatibility there is often a gap between what the documentation states and what Ruby programs assume.
So even though the documentation says it's unordered, I would guess there are programs relying on Sets being ordere... -
09:42 AM Feature #15281: Speed up Set#intersect with size check.
- I'm not sure it should be called `Tuple` - to me that implies that elements can appear more than once - that it's a multi-set - and this isn't the case.
-
08:25 AM Feature #15281: Speed up Set#intersect with size check.
- There is a mathematical term "ordered set", which means a different thing: an algebra in which the elements are given intrinsic order.
The concept in question should be named `Tuple` or `UniqueTuple`. -
02:52 AM Feature #15281: Speed up Set#intersect with size check.
- It is clearly stated that Set is an unordered collection and it doesn't even guarantee any determinacy about the order of elements, and as you know, it's just it happened to become ordered and deterministic when the underlying data struc...
-
- This unifies our explanation with
https://github.com/ruby/www.ruby-lang.org/pull/2069
Co-authored-by: OKURA Masafumi <masafumi.o1988@gmail.com> -
-
- on initialize
This fixes https://github.com/ruby/ruby/pull/2188 -
-
-
-
-
-
-
08:38 AM Feature #15854: Tracing instance variable assignment
- Thanks to comments.
> :ivar_assign (close to original proposal)
> ...
Looks good. I feel they are good to read, so better than my suggested :iasgn.
> Cloud you describe a use case? ... but I don't think it applies to :casgn.
I'... -
-
-
-
- [Bug #15821]
-
-
- > It should behave in the way Hash#slice does, except one thing Hash#slice! modifies the object. (See, for instance, how Array#slice and Array#slice! work, they return the same value)
I agree that it is ideal. However, in practical, ... -
- * [Feature #15865] `<expr> in <pattern>` expression
* One-line pattern matching. ktsj, ko1, nobu, and me like it. WDYT? -
- * [Feature #15864] Proposal: Add methods to determine if it is an infinite range
* I want to hear the opinions of developers.
-
-
05/20/2019
-
-
-
- I have not read all comments (sorry) and it is way outside of my league to come to any meaningful
conclusion; I only skimmed through it and since it may be mentioned at the next developer meeting
I may comment (I only saw it because it... -
-
- 04:10 PM Revision 8023b3ce (git): * 2019-05-21
-
-
- I had a look at this. I manage to reproduce the issue only when requiring `openssl`. In general, I think it can be reproduced when a ruby feature requires an dynamic library of the same name. In this case, `require "openssl"` resolves to...
- 01:08 PM Revision 583ecd5f (git): * expand tabs.
-
-
-
-
- This is accepted & implemented as per #11090.
-
- Just leaving a comment that I wanted this method in my pet project just now. So +1.
-
- On my Linux guest machine on Hyper-V, I got an error.
Process.clock_gettime(CLOCK_MONOTONIC_RAW, :nanosecond) returns like:
...
875573945119100
875573945119600
...
even if `Process.clock_getres(value, :nanosecond)` returns 1.
S... -
- nobu (Nobuyoshi Nakada) wrote:
> Would you commit that patch by yourself?
Assuming matz approves a commit bit for me at the next developer meeting, I would be happy to. -
- Would you commit that patch by yourself?
-
-
- * [Feature #14915] Deprecate String#crypt
- Is anybody against adding warning?
05/19/2019
-
-
10:05 PM Feature #15799: pipeline operator
- Eregon (Benoit Daloze) wrote:
> Also, if we actually introduce a pipeline operator, I think it's much more useful to have Elixir semantics of passing the result as the first argument of the RHS, than just a different syntax for `.`.
... -
- * [Feature #15863] Add `Hash#slice!` and `ENV.slice!`(bogdanvlviv)
* I would like to discuss these methods(name, behavior, implementation), and whether we want to add them to Ruby.
* [Feature #15831] Add `Array#extract`, `Hash#extrac... - 07:52 PM Revision f659e2f9 (git): * 2019-05-20
-
-
- I do not know how Hash#extract from Active* works but the name does not make to me
a whole lot of sense to me; however had, we have Hash#slice already so I guess it may
make sense to add .slice!; and if so, it may make sense to add it ... -
- ## Add `Hash#slice!`
In https://bugs.ruby-lang.org/issues/8499 we added `Hash#slice`.
`Hash#slice!` removes and returns the key/value pairs matching the given keys:
```ruby
h = {a: 100, b: 200, c: 300}
h.slice!(:a) # => {:a=>1... -
08:21 AM Bug #15791: Clarify reason for RbConfig's ruby_version not reflecting "teeny" value
- ruby_version is user configurable variable:
https://github.com/ruby/ruby/blob/trunk/configure.ac#L3663
It was introduced to make possible parallel install e.g. two Ruby 2.6.0 side by side. Later somebody start to interpret it and a... -
-
- That check is necessary only for very old, 6 years ago, header.
It is strange that `IN6_IS_ADDR_UNSPECIFIED` code cannot compile.
Could you show how it failed in mkmf.log? -
- I think this issue is a bug or spec of rb-inotify. If it is a bug, it should be fixed. If it is a spec, rails should not use rb-inotify in such an environment. Anyway, you have already filed a ticket in that bug tracker: https://githu...
05/18/2019
-
- jeremyevans0 (Jeremy Evans) wrote:
> Looking at RFC 8089, Appendix E (`Nonstandard Syntax Variations`) states:
> ...
"may be encountered" here is meant to mean that old "poorly formed" URIs exist in the wild, and occasionally we encou... -
- This is definitely intentional behavior, by the way. This is how the current tests look:
```
u = URI("file:///c:/path/to/file")
assert_equal "/c:/path/to/file", u.path
# this form is not supported
u = URI("file:c:/path/t... -
- Yep, that's correct.
The alternative is to use the alternative form, but as you point out, the preceding slash is certainly inconvenient.
Anyways, thanks for considering this. -
- Looking at RFC 8089, Appendix E (`Nonstandard Syntax Variations`) states:
```
These variations may be encountered by existing usages of the file
URI scheme but are not supported by the normative syntax of
Section 2.
... -
- Recently ruby has getting better at parsing URIs using the "file" scheme, with the addition of "URI::File". Still, some Windows edge cases are not implemented, and it would be nice to have them. For example, while the [addressable gem](h...
-
10:31 PM Feature #15665 (Rejected): Cannot compile socket extension on Mojave
- Do not change status field.
Maybe you can resolve this with `sudo installer -pkg /Library/Developer/CommandLineTools/Packages/macOS_SDK_headers_for_macOS_10.14.pkg -target /` -
- @hsbt That location has been [deprecated](https://developer.apple.com/documentation/xcode_release_notes/xcode_10_release_notes#3035624):
> The command line tools will search the SDK for system headers by default. However, some softwar... - 08:45 PM Revision cc764e5d (git): * 2019-05-19
-
-
04:19 PM Bug #15862 (Third Party's Issue): Segmentation fault when running Rails commands
- I´ve been trying to install rbenv, ruby and rails in my Raspberry Pi 3 B+ in the past couple of days and after some issues here and there, I've managed to get everything installed with no errors
With rbenv I installed both Ruby 2.6.3 ... -
- Attached is an updated patch against trunk for deprecating `String#crypt`. This patch always warns when `String#crypt` is called, instead of just warning in verbose mode, since I would like the deprecation to be obvious in 2.7 for any r...
-
- I just changed the implementation of `Hash#extract` and `ENV::extract` as it's described in the previous note https://bugs.ruby-lang.org/issues/15831#note-4
-
- jeremyevans0 (Jeremy Evans) wrote:
> I have added a pull request to logger upstream for this: https://github.com/ruby/logger/pull/30
Pull request was merged, so this can be closed. -
11:06 AM Revision 60de1725 (git): [DOC] Shorten examples for Time#{round,floor}
-
- Use numbers that are more illustrative for #floor.
-
-
-
09:24 AM Revision 154a67f1 (git): Rename rb_gc_new_location to rb_gc_location
- The function will return new or existing locations depending on whether
or not the object actually moved, so give it a more appropriate name. -
-
- Second try with https://bugs.ruby-lang.org/issues/15858
-
- The `UNICODE_BETA = yes` flag is causing a full download of the relevant `index.html` files to get the actual filenames of the files we need (because in beta, these do change). But we use `If-Modified-Since` even in BETA, so there are no...
-
-
-
- I'm debugging [Bug #15821] but my patch introduces another issue.
So I simply skip this test and re-enable it later. -
01:04 AM Bug #15763: Segmentation fault in timeout.rb / sleep
- Nix that: single Puma worker makes no difference. Back to segfault in timeout.rb.
-
- I came here after seeing the same segfault in timeout.rb / CFUNC :sleep on ruby 2.6.2 on MacOS with a Rails project running with Puma and 2 worker threads.
Installed 2.6.3 and now seeing the segfault coming from pg - but interestingly... -
-
-
- [Misc #15859]
-