Activity
From 03/27/2019 to 04/02/2019
04/02/2019
-
09:59 PM Revision dd2479bc (git): Fix more ASAN errors
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67421 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- I will use this from another function in compaction
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67420 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Also fix tests
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67419 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
08:05 PM Misc #15744: Improvement needed to documentation of 'Literals'
- I am not sure if your definition can be used. For example, you refer to "compile time", but what is meant with
compile time? As far as I know, ruby is not compiled in the sense of generating some binaries/binary executable,
such as whe... -
05:34 PM Misc #15744 (Open): Improvement needed to documentation of 'Literals'
- Documentation of "Literals" for v2.6.0 is given here: https://docs.ruby-lang.org/en/2.6.0/syntax/literals_rdoc.html. (I don't think it has been changed for some time.) It gives examples of literals but does not provide a definition. It i...
- 07:13 PM Revision 714c2b0a (git): * 2019-04-03
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67418 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- This code was trying to access memory before unpoisoning it.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67417 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- This commit just adds poisoning around the freelist to help debugging.
Also verify that the freelist only contains T_NONE objects when checking
the heap integrity
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67416 b2dd03c8-39d4-4d8... -
06:39 PM Feature #15743: RubyVM should be renamed to CRuby
- > whereas CRuby refers to ... what name exactly?
CRuby is the name some people (including Matz I believe) used to refer to the standard implementation of Ruby. Other people use the name MRI. It literally means 'the Ruby VM implemented... -
05:37 PM Feature #15743: RubyVM should be renamed to CRuby
- I agree with making the "RubyVM" namespace a little less generic. In JRuby and TruffleRuby, we both have our own "JRuby" and "TruffleRuby" namespaces, which tuck away our implementation-specific stuff.
However I'm not sure CRuby is re... -
- I am not involved in any of this so this should be up to those who are
involved; but one comment that is somewhat unrelated is that, at the least
to me, the meaning of the words are different. RubyVM sort of indicates
some VM, wherea... -
11:53 AM Feature #15743 (Closed): RubyVM should be renamed to CRuby
- My understanding is that `RubyVM` is supposed to only exist on MRI/CRuby, and not on any other Ruby implementation.
In fact, almost all features under `RubyVM` are not realistically implementable on other major Ruby implementations (JRu... -
06:34 PM Misc #15459: DevelopersMeeting before/after RubyKaigi2019
- [Feature #13683] Add strict `Enumerable#single`
* Matz already showed his discontent with the name `single`, but `only` could be a good alternative as proposed by nobu and Lisa on that issue. -
04:11 PM Feature #13683: Add strict Enumerable#single
- I was pointed here after sharing the following code with my team mates. I really like the idea, and find I often reach for it. I second the name `only`.
``` ruby
module Enumerable
def only
only!
rescue IndexError
nil
... -
11:48 AM Revision f28be7e0 (git): Merge rubygems/rubygems from upstream.
- The current master branch is
https://github.com/rubygems/rubygems/commit/97b264f0fa248c864b6ee9a23d3ff1cdd217dddb
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67415 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
11:39 AM Misc #15723: Reconsider numbered parameters
- I fail to see how the downsides outweigh the problems. The @-syntax looks ugly, misleading and adds even more complexity to the language. The `\1`, `\2`, etc. syntax makes much more sense if you deal with regular expressions a lot, but o...
-
11:00 AM Misc #15723: Reconsider numbered parameters
- shevegen (Robert A. Heiler) wrote:
> Why would it be completely impossible to, for example, add BOTH @1 @2 AND "it"
> ...
The `itself` keyword is already used under different scope (wider than a block). And `it` has already been exclud... -
- I was about to comment on what ted wrote, but it would have become too long,
so here is a significantly shorter variant to just focus on a few points:
- I think "itself" is very similar to "it". Kotlin makes use of "itself", so
it i... -
07:57 AM Misc #15723: Reconsider numbered parameters
- What strikes me is that this feature attempts to solve a problem that is very limited in scope:
- Blocks where the arguments can't be given a meaningful name arguably become more noisy than they may need to.
with a very big hammer:... -
01:29 AM Misc #15723: Reconsider numbered parameters
- zverok (Victor Shepelev) wrote:
>
> ...
I hate this. Suddenly you have `&` and `.:` and `.()`, and where everything outside the parens has an obvious receiver-message relationship, nothing inside does.
At least this:
```ruby
HT... -
10:51 AM Revision 53702443 (git): Azure Pipeline tests on Linux are not reliable
- test-bundler started to fail with r67383
https://dev.azure.com/rubylang/ruby/_build/results?buildId=278
which is very unlikely to be Ruby implementation's fault.
test-bundled_gems also started to fail with r67413
https://dev.azure.com/r... -
- I think it's early that only you maintain them. We welcome to your patch or direct commit.
-
08:08 AM Revision 79de8e9f (git): downloader.rb: keep linked file newer than cached file
- * tool/downloader.rb (Downloader.save_cache): keep linked file
newer than cached file, so that GNU make triggers when the
content is updated. it uses the timestamp of symlink itself
instead of the target.
git-svn-id: svn+ssh://ci... -
07:41 AM Feature #15742: Add Date#jisx0301 support new Japanese era
- nobu (Nobuyoshi Nakada) wrote:
> Maybe, we should await next JIS X 0301?
I think it is too late.
JIS X 0301 update schedule is not shown.
However, we can wait vendors such as Microsoft.
Microsoft also needs the single letter a... -
- akr (Akira Tanaka) wrote:
> I think no-era representation is similar to truncation of ISO 8601:2000.
> ...
It reminds me the second parameter to `Time.parse`:
> We can change the date used to infer our missing elements by passing a
>... -
02:52 AM Feature #15742: Add Date#jisx0301 support new Japanese era
- Can this be handled like thread exceptions?
```ruby
Thread.abort_on_exception=true
```
I like this approach because it's dynamic and changes the behavior for
the current runtime.
```ruby
Date.japanese_era_exception=true
```
Or... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67412 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67411 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 03:49 AM Revision 5f3e5e6f (git): * expand tabs.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67410 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67409 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
04/01/2019
-
- verify_internal_consistency_i and gc_verify_heap_page would walk the
heap, reading data from each slot, but would not unpoison the object
before reading. This commit unpoisons the slot before reading so that
we won't get ASAN errors
gi... -
11:09 PM Feature #14183: "Real" keyword argument
- jeremyevans0 (Jeremy Evans) wrote:
> mame (Yusuke Endoh) wrote:
> ...
mame,
With your revised branch, it looks like the the keyword argument separation for positional splats has already happened, and there is no warning. Both your ... -
02:52 PM Feature #14183: "Real" keyword argument
- @jeremyevans0 I **will** investigate your proposal. I was not fully satisfied with the complete separation model proposed for 3.0, but I didn't think of any other model which is intuitive and clean, especially considering static type ana...
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67407 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 10:52 PM Revision f4bff3a7 (git): * expand tabs.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67406 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- This fixes some ASAN errors
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67405 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * Other implementations should not define RubyVM.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67404 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67403 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 08:35 PM Revision d48783bb (git): * 2019-04-02
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67402 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * AIX, Solaris, etc have a different binary representation.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67401 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- nobu (Nobuyoshi Nakada) wrote:
> Note: JIS X 0301 states the era symbol is optional, but doesn't mention the default era in the case it is omitted.
> ...
JIS X 0301:2002 is a Japanese translation of ISO 8601:2000 with era-description... -
10:55 AM Feature #15742: Add Date#jisx0301 support new Japanese era
- nobu (Nobuyoshi Nakada) wrote:
> Note: JIS X 0301 states the era symbol is optional, but doesn't mention the default era in the case it is omitted.
> ...
It's a sign that the committee responsible for JIS X 0301 wasn't able to agree,... -
- nobu (Nobuyoshi Nakada) wrote:
> kaishuu0123 (Koki Oyatsu) wrote:
> ...
Note: JIS X 0301 states the era symbol is optional, but doesn't mention the default era in the case it is omitted.
At the best, it will be defined by the applicat... -
- kaishuu0123 (Koki Oyatsu) wrote:
> I was surprised that handled the omission of era in `Date#jisx0301`.
More surprisingly, it is required by JIS X 0301; its definition is basically non-era, and the era *may* be preceded.
> ...
(tran... -
07:57 AM Feature #15742: Add Date#jisx0301 support new Japanese era
- > Considering Heisei is just 30years, omission of era can cause deadly confusions now and coming decades.
(As a premise, difficult to dicard current spec.)
I was surprised that handled the omission of era in `Date#jisx0301`.
Becau... -
- Considering Heisei is just 30years, omission of era can cause deadly confusions now and coming decades.
I think it should be an error, rather than assuming the latest era. -
- Tentative patch.
https://github.com/nobu/ruby/pull/new/feature/japanese-reiwa -
- mame (Yusuke Endoh) wrote:
> Thanks, that's good to know. However, we should wait for the new revision of JIS X 0301. Could you let us know if the spec is actually revised?
It may be that the spec is revised, but this usually takes... -
- nobu (Nobuyoshi Nakada) wrote:
> It defaults to Heisei if no era initial letter is found.
> ...
Yes, incompatibilities like this are unavoidable with a date system such as the Japanese era names. -
- znz (Kazuhiro NISHIYAMA) wrote:
> It seems `Date.jisx0301` supports Japanese era too.
It defaults to Heisei if no era initial letter is found.
I guess it probably would be expected to the new era now, but it is an incompatibility of... -
- kaishuu0123 (Koki Oyatsu) wrote:
> * new era (Reiwa?) starts from 2019/05/01
> ...
I'm also not 100% sure the new letter will be "R", but given that all major Romanization methods
(https://en.wikipedia.org/wiki/Hepburn_romanization,... -
04:26 AM Feature #15742: Add Date#jisx0301 support new Japanese era
- It seems `Date.jisx0301` supports Japanese era too.
-
04:26 AM Feature #15742 (Feedback): Add Date#jisx0301 support new Japanese era
- Thanks, that's good to know. However, we should wait for the new revision of JIS X 0301. Could you let us know if the spec is actually revised?
-
- ## Reproduce process
```
irb(main):002:0> require 'date'
=> true
irb(main):003:0> Date.new(2019, 5, 1).jisx0301
=> "H31.05.01"
```
* ruby version: trunk
## Result of reproduce process
```
irb(main):003:0> Date.new(2019,... -
- microweb10 (Julian Herrero) wrote:
> I never contributed to Ruby and I'm a bit lost on how to start. I'm more familiar with Open source contributions via PRs.
You can contribute PRs to Ruby on github: see https://github.com/ruby/ru... -
- shevegen (Robert A. Heiler) wrote:
> Check the date sawa. :)
I see. Honestly, I have never felt this kind of stuff to be funny. -
- Check the date sawa. :)
The thing is, though ... if we ignore the date (and I guess nobu is having fun
since it may seem less obvious if mame creates the issue ;) ) ... actually I did
want to propose adding .second .third and so for... -
- I do not think that 1-based is a problem at all. As some have already noticed in a different thread, regex captures are 1-based, and no one has complained about it. I think it is more natural to have it 1-based.
-
- Numbered parameters have been introduced into trunk, and are still being hotly debated in #15723.
One of the problems of the feature is, too short, too symbolic, and then too cryptic. It resembles Perl.
I counterpropose "ordinal p... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67400 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- duerst (Martin Dürst) wrote:
> This raises the question of whether we should release a Ruby version before May 1st (with the beta data) or after May 7th. For the former, we would have to cheat a bit by introducing some logic into the ... -
- A beta release for Unicode 12.1.0 should be available by tomorrow. The official release of Unicode 12.1.0 is planned for **May** 7.
This raises the question of whether we should release a Ruby version before May 1st (with the beta dat... -
- The new era name has been announced a few minutes ago:
令和 U+4EE4 U+548C
Reading: REIWA -
- As now we have `@1` and so on, revised and refined this patch.
https://github.com/nobu/ruby/pull/new/feature/circled_numparams -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67399 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 05:21 AM Revision e836cd0b (git): * expand tabs.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67398 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67397 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
04:05 AM Feature #15667: Introduce malloc_trim(0) in full gc cycles
- @tessi
My tests were with 3.6.0, I will do a side by side now that I have all the infrastructure of 5 vs 3.6 and even tcmalloc.
Nice to see that gem! Looking at my graphs I think best bang would just be to spin a thread that does...
03/31/2019
- 03:37 PM Revision 367362b9 (git): * 2019-04-01
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67396 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67395 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
03:30 PM Feature #13677: Add more details to error "Name or service not known (SocketError)"
- duerst (Martin Dürst) wrote:
> Please do, patches are always welcome.
I never contributed to Ruby and I'm a bit lost on how to start. I'm more familiar with Open source contributions via PRs.
Could you please give me some pointers... -
03:01 PM Bug #15650: Segmentation fault when accessing $! in at_exit within a forked process
- ruby_2_4 r67392 merged revision(s) 67201.
- 03:01 PM Revision 15012683 (git): * 2019-04-01
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_4@67393 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 03:01 PM Revision c0404b8c (git): merge revision(s) 67201: [Backport #15650]
- eval.c: clear internal errinfo
* eval.c (ruby_cleanup): clear internal error info when invoking
end procs. [ruby-core:91731] [Bug #15650]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_4@67392 b2dd03c8-3... -
- ruby_2_4 r67391 merged revision(s) 67188.
- 02:58 PM Revision 7a27746e (git): merge revision(s) 67188: [Backport #15642]
- io.c: chomp CR at the end of read buffer
* io.c (rb_io_getline_fast): chomp CR followed by LF but separated
by the read buffer boundary. [ruby-core:91707] [Bug #15642]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/bran... - 02:46 PM Revision 4e0420f5 (git): * 2019-03-31
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67390 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67389 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
09:35 AM Misc #15723: Reconsider numbered parameters
- (my small branch in this burning fire)
For me the biggest problem with the new feature is not the particular syntax, but the simple fact that the feature (as far as I can understand) is "orphan", just kinda "nice (or not-that-nice, de... -
- Changed title from "How to deal with new Japanese era" to "Deal with new Japanese era".
-
- Issue for backporting feature #15195 (deal with new Japanese era) once that feature's implementation has been completed in a few days or weeks.
-
01:52 AM Feature #15667: Introduce malloc_trim(0) in full gc cycles
- FYI: For easier testing this idea, I just pushed a small gem to rubygems `malloc_trim` (https://github.com/tessi/malloc_trim). This gives access to `malloc_trim` to ruby land to let us play with it without the need to re-compile ruby and...
03/30/2019
-
- The documentation of these three methods fails to explain how they interact. For example:
h = { a: [1,2,3] }
h.dig(:a, 1) #=> 2
`Hash#dig` is used first:
a = h.dig(:a) #=> [1,2,3]
Then `Array#dig` is invoked:
... -
05:05 PM Misc #15723: Reconsider numbered parameters
- Hi.
I'm aware this issue is just a tip of an iceberg and Matz has the final say,however I'm worried the Ruby project is slipping from its original path. I mean, how easily it gives green-light to half-assed proposals, how there is con... -
11:57 AM Misc #15723: Reconsider numbered parameters
- For me a big problem is that the syntax additions obviously affect what's being valued/promoted and so on. In the example you gave about the safe navigation operator, the real problem is that `f` could be nil in the first place. When you...
-
- Applied in changeset trunk|r67388.
----------
ruby.c: respect features by command line
* ruby.c (process_options): feature options in command line
arguments take precedence over options in RUBYOPT environment
variable. [ruby-core:... -
- > I would expect the command line arguments always override RUBYOPT arguments.
I agree.
I do not know all specifics but it makes sense to me as to agree with what Benoit
wrote in regards to explicit commandline option(s) being abl... -
- * ruby.c (process_options): feature options in command line
arguments take precedence over options in RUBYOPT environment
variable. [ruby-core:92052] [Bug #15738]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67388 b2dd03c8-39d... -
02:06 PM Bug #15649: Dir.glob regression with braces and Windows drive letters
- ruby_2_6 r67353 merged revision(s) 67332.
-
- Borrowed the style of code/pre from bugs.ruby-lang.org.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67387 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67386 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67385 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- I'm happy to chat/review this code and the overall _id2ref change at RubyKaigi in a few weeks, btw.
03/29/2019
- 11:26 PM Revision 031e2f12 (git): * 2019-03-30
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67384 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- By adding `(void)`. This makes Coverity Scan happy.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67383 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- I'll close this issue, I filed #15738 for the strange behavior.
-
- MSP-Greg (Greg L) wrote:
> Sorry & fixed. My test code had some `disable=gems` in test-all, and I never cleared it for spec. The new tests aren't happy with that.
Great.
Now, it is weird that the command line doesn't override the ... -
01:45 AM Bug #15736: r67361 Update to ruby/spec@e81b3cd - spec failures on MinGW ?
- @Eregon
Sorry & fixed. My test code had some `disable=gems` in test-all, and I never cleared it for spec. The new tests aren't happy with that.
Note that I run tests in ruby-loco from the install folder, so I don't use make. Esse... -
- From #15736:
It seems unexpected that the command line argument doesn't override the RUBYOPT options:
```
$ RUBYOPT=--disable-gems ruby --enable=gems -e 'p defined?(Gem)'
nil
```
That seems a bug. I would expect the command l... -
- mame (Yusuke Endoh) wrote:
> > # My Proposed Alternative
> ...
Correct. Sorry about that.
>
> ...
Correct, in Ruby 3 assuming the behavior changes for keyword arguments are in effect. With your branch+my patch:
```ruby
foo({... -
- Jeremy,
I really appreciate you to use time for this issue. And sorry for my late response.
I have misunderstood some points of your proposal, and now I feel that it is fairly good. But please let me consider for a while... This t... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67382 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67381 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- It seems that `debug_counter_show_results_at_exit` could be called
earlier than `mjit_finish` sometimes.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67380 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67379 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67378 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67377 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Actually what has randomly failed was `make install`:
https://travis-ci.org/ruby/ruby/jobs/512988177
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67376 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67375 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67374 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- This spec is unstable on our CI environment:
https://gist.github.com/ko1/efa58acf4cd1d7b5bf1f63881537afe8
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67373 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- > I vote for 3 (and hashrockets ;))
I'd add a fourth variant - that is to use both explicit names and
@1 @2 @3. :)
But to keep my comment somewhat short - since hashrockets was mentioned, even with a
twinkling smiley, I initially... -
08:21 AM Misc #15723: Reconsider numbered parameters
- mame (Yusuke Endoh) wrote:
> Vote:
I vote for 3 (and hashrockets ;)) - 06:36 AM Revision ce9e0ffd (git): * expand tabs.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67372 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
06:36 AM Revision 35e677dd (git): use GET_CFP() instead of access reg_cfp directly.
- GET_CFP() macro contains performance counter logic.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67371 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
04:30 AM Feature #15667: Introduce malloc_trim(0) in full gc cycles
- Thanks Sam, a very nice set of results.
Notice that 99th percentile Topic list was faster with the patch, whilst slower with Topic view. So I'm not sure we can say that the patch will always be slower on the worst runs.
Query, what... -
- FYI, here is rb_ps output:
```
(gdb) rb_ps
$1 = (rb_vm_t *) 0x7f3f8e840400
* #<Thread:0x7f3f8e98f330 rb_thread_t:0x7f3f8e80f080 native_thread:0x7f3f9088e780>
29:0x55895629eb90 <rb_queue_pop at thread_sync.c:943>:in `pop'
28:/usr/... -
- With Ruby 2.6, my single-worker application https://github.com/k0kubun/ruboty sometimes stops to respond to a message. `rb_queue_pop` does not seem to be waken up in `rb_sigwait_sleep` in some condition.
```
strace: Process 18699 att... -
- * process.c (rb_f_spawn): fix markups as rdoc.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67370 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * process.c (rb_clock_getres): fix code markups, as `+` can not
include parentheses.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67369 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67368 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- previous retry logic did not work
https://dev.azure.com/rubylang/ruby/_build/results?buildId=266
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67367 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
03/28/2019
-
- @Eregon
> Could you investigate why they fail?
Yes. I haven't had time to check it locally, will check tonite...
-
- @MSP-Greg Could you investigate why they fail?
Those specs look fine and portable from a quick look.
Does "The --enable and --disable flags can be used with frozen-string-literal" passes?
That's very similar, could it be a bug of co... -
- ruby-loco (MinGW trunk) had the following failures in spec tests as of r67365 (r67357 passed)
```
1)
The --enable and --disable flags can be used with gems FAILED
Expected "nil"
to equal "\"constant\""
/ruby/spec/ruby/command_... -
- If that is the case, that might also mean the fix in https://bugs.ruby-lang.org/issues/14998 might not be sufficient.
-
06:46 PM Bug #15735 (Closed): Thread#handle_interrupt does not prevent Thread#kill from interrupting
- https://docs.ruby-lang.org/en/trunk/Thread.html#method-c-handle_interrupt
According to the documentation above, `Thread#handle_interrupt(Exception => :never)` would prevent the interrupts from `Thread#kill`.
In the following code, ... -
05:50 PM Feature #15734 (Open): Parsing of shorthand IPv4 addresses compatible with inet_aton
- Hi Ruby team!
I've created pull request to ipaddr gem: https://github.com/ruby/ipaddr/pull/12
I want it to be merged and included to the version of gem that bundled in Ruby itself.
---
Many applications (like browsers, `curl`, ... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67366 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- This test fails on AppVeyor mswin so often:
https://ci.appveyor.com/project/ruby/ruby/builds/23427134/job/rowv0dohwni0xa37
https://ci.appveyor.com/project/ruby/ruby/builds/22970385/job/qdkqus13bhnyyfxf
https://ci.appveyor.com/project/rub... - 03:25 PM Revision 233267db (git): * 2019-03-29
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67364 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 03:25 PM Revision 7ce0e963 (git): * properties.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67363 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67362 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67361 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67360 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
12:28 PM Feature #15554: warn/error passing a block to a method which never use a block
- This is great! Ignored blocks can be very confusing.
> A method called by super doesnt warn warning even if this method doesn't use a block.
> ...
Would it be possible for a method called by `super` to only ignore an unexpected block... -
11:44 AM Feature #15554: warn/error passing a block to a method which never use a block
- To detect if a block is used, binding would also need to be detected, e.g.: `def b(arg); arg.eval("yield"); end; def a; b(binding); end`
-
- The reason why this feature was introduced, is that people want a shorthand for `ary.map {|x| x.to_i(16) }` and `ary.map {|x| x.to_i.chr }`.
Vote:
1. Ad-hocly extend `ary.map(&:to_i)`: `ary.map(&:to_i.(16))` and `ary.map(&(:to_i >>... -
- Eregon (Benoit Daloze) wrote:
> duerst (Martin Dürst) wrote:
> ...
What's easy or hard to read is definitely to quite some extent subjective, but just a few more points:
* You have seen the later many many times over already, but ... -
- So, the main thing I was thinking about is passing blocks that then get silently ignored. I was thinking a good way to solve this would be to have a strict mode, and then I tried to come up with things that could be in a strict mode too....
-
- This suggestion confuses me quite a bit. I am not sure of the use case; or
perhaps I don't quite understand it.
I think what you essentially suggest is to be able to run/interprete any
given .rb file with additional restrictions in ... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67359 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * parse.y: show compile error and the error line separately,
instead of building the error message by snprintf then yyerror.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67358 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67357 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- I have no personal preference here either way but I can also understand Satoshi's
explanation / confusion.
This may be good to suggest for an upcoming developer meeting. __DIR__ might have
an advantage of being faster than a method ... -
02:12 AM Bug #15733 (Rejected): Inconsistent __FILE__ and Kernel#__dir__
- This might be duplicated with #7975, #8098 and #3346, but I believe it's worth to revisit.
Now, Ruby has `__FILE__` keyword and `Kernel#__dir__` method. One is of upper-case chars, and the other is of lower-case chars.
I make mistake... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67356 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67355 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67354 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- dir.c: fix Dir.glob starts with brace
* dir.c (ruby_glob0): expand braces if a glob pattern starts with
brace.
[ruby-core:91728] [Bug #15649]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_6@673... -
- ruby_2_6 r67352 merged revision(s) 67270.
-
- dsym should be treated as string [ruby-core:91852] [Bug #15670]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_6@67352 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- ruby_2_6 r67351 merged revision(s) 67247.
-
- Guard out the test when it is run under root permission
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_6@67351 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- @mame / @carlos attached is a screenshot of side by side testing on live traffic patterns
containers run multiple ruby processes (a few unicorn workers and a sidekiq worker)
standard14 = Ruby 2.6.2 + jemalloc
standard14_a = Ruby 2... -
- Use `map.with_index`.
Matz.
03/27/2019
- 11:56 PM Revision 832bc507 (git): * 2019-03-28
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67350 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67349 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- localhostdotdev (localhost .dev) wrote:
> A lot of issues could be easily prevented with a strict mode, for instance:
> ...
This is being discussed in #15554.
> - $1, $2, etc. variables when matching with a regex would not be create... -
- A lot of issues could be easily prevented with a strict mode, for instance:
- Passing a block to a method that doesn't accept blocks could raise an exception, e.g. methods would be required to explicitly ask for a block (def a(..., &b... -
- matz (Yukihiro Matsumoto) wrote:
> The **possibility** to make code cryptic itself should not be the reason to withdraw a feature.
Agreed. However, so far I think almost every example I saw with more than one @-parameter feels crypti... -
- duerst (Martin Dürst) wrote:
> > ``` ruby
> ...
Actually, I would think `@1`, `@2` start to look much like Perl, i.e. cryptic sigils, that someone not already familiar with them would wonder why would people want to use something so un... -
10:26 AM Misc #15723: Reconsider numbered parameters
- duerst (Martin Dürst) wrote:
> > * The '@n' syntax complicates the idea of what '@' identifies in Ruby, making the language potentially harder to learn.
> ...
Yes, but in my mind it carries misleading hints about the scope of the var... -
- ahvetm (Erik Madsen) wrote:
> I signed up just to comment on this thread, because I also feel that this change is rather weird, and I would like to propose an alternative, that I don't think has been discussed.
> ...
In general I'd agr... -
- > I disagree. To only accept uncontroversial features is the death knell for progress. Design by committee is the last thing Ruby needs.
I'm not a fan of design by committee as well. I was referring to the fact he seemed unhappy with ... -
- I signed up just to comment on this thread, because I also feel that this change is rather weird, and I would like to propose an alternative, that I don't think has been discussed.
I understand the need for the feature, and it's a wel... -
- joanbm (Joan Blackmoore) wrote:
>
> ...
You forgot to complain about `sym: value` hash syntax, `->` lambdas, `foo(&:bar)` proc-blocks, etc. etc.
Personally I find `@1` the least intrusive bit of syntactic magic added to Ruby in the... -
- I do not have any particularly strong opinion either way. Jabari has made one point,
though, independent of crystal, in that it may make sense to have a corresponding
.map_with_index if .each_with_index exists already. But I think ulti... -
- jzakiya (Jabari Zakiya) wrote:
> I was converting some Ruby code to Crystal on Rosetta Code and came across this Ruby snippet,
> ...
Enumerator#with_index already exists:
```ruby
[1,3,5].map.with_index{ |x, i| (x+i)**2}
=> [1, 16... -
04:58 PM Feature #15730 (Closed): Add map_with_index method
- I was converting some Ruby code to Crystal on Rosetta Code and came across this Ruby snippet,
```
arry.each_with_index.map{ |x,y| ......}
```
where ``arry`` is an array of integers.
This wouldn't convert directly into Crystal (w... -
08:43 PM Feature #15724: Optionally suppress output from IRB for assignment expressions
- Thanks to some feedback on the [PR](https://github.com/ruby/irb/pull/12), I've updated it to use [Ripper](https://ruby-doc.org/stdlib-2.6.2/libdoc/ripper/rdoc/Ripper.html), so it doesn't rely on internals of CRuby ([RubyVM](https://ruby-...
-
08:31 PM Feature #12655: Accessing the method visibility
- I know its been two years already.
but do you think we could get those new methods merged into trunk?
-
06:37 PM Bug #15731: Wrong evaluation of many keyword default arguments in 2.3 - 2.5
- Edits:
Print 1 to ... => Print 0 to ...
Ruby 2.4 bug => Ruby 2.2/2.3/24 bug
Ruby 2.6 ok => Ruby 2.1 and 2.6 ok
We => Me and Maxime Lapointe
-
- I don't know if it's worth fixing at this point, but we found a strange bug with evaluation of default keyword arguments when there are many of them (more than 32).
```
def foo(
k0: puts(0), k1: puts(1), k2: puts(2), k3: puts(3), ... -
- In a test like test/drb/ut_drb_drbssl.rb, `ossl_ssl_connect` (`OpenSSL::SSL::SSLSocket#connect`) sleeps in `rb_wait_for_single_fd` and sometimes it's never waken up.
I think it's related to timer thread elimination in Ruby 2.6 and so I ... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67348 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- headius (Charles Nutter) wrote:
> @eregon Are you talking about the PR? That has the version of code that should be merged into CRuby. The link in the description was just to show the diff in place in our CRuby fork, but it didn't base ... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67347 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
09:51 AM Feature #7148: Improved Tempfile w/o DelegateClass
- I guess this is related:
``` ruby
tf = Tempfile.new
tf.unlink
tf2 = tf.dup
puts tf.fileno
# => 10
puts tf2.fileno
# => 11
tf2.close
print tf2.fileno
# => 11
print tf.fileno
IOError: closed stream
from /usr/local/rvm/rub... - 08:26 AM Revision b51b9d50 (git): * 2019-03-27
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67346 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- It includes the following updates:
* https://github.com/ruby/fileutils/pull/26
* https://github.com/ruby/fileutils/pull/27
* https://github.com/ruby/fileutils/pull/29
* https://github.com/ruby/fileutils/pull/34
git-svn-id: svn+... -
01:44 AM Bug #15727: [BUG] Segmentation fault at 0x0000000000000000 ruby 2.5.3p105 (2018-10-18 revision 65156) [x86_64-linux]
- It may be as the same issue as #14553 and fixed at r66130 that is backport of r63040.
Would you please try ruby-2.5.5?