Activity
From 03/02/2019 to 03/08/2019
03/08/2019
-
11:45 PM Bug #15646: method_defined? inside method_added behaves differently for `initialize`
- I think it is documented somewhere, but can't remember where it is now.
Anyway, these methods are always defined as private, unless singleton methods.
`initialize`, `initialize_copy`, `initialize_clone`, `initialize_dup`, `respond_to... -
09:05 PM Bug #15646: method_defined? inside method_added behaves differently for `initialize`
- Ah, I didn't know `initialize` is always private:
```ruby
irb(main):001:0> class A
irb(main):002:1> def initialize
irb(main):003:2> end
irb(main):004:1> end
=> :initialize
irb(main):005:0> A.new.initialize
Traceback (most r... -
- Repro:
```ruby
class MethodAddedSpecialCase
def self.method_added(name)
puts "#{name} added, method_defined?: #{method_defined?(name)}"
end
def hello
end
def initialize
end
def world
end
end
```
... -
- It is known that reserved words can be keyword arguments.
And `Binding#local_variable_get` has been added for that purpose, `if` argument for instance. -
11:14 PM Bug #15647: Disallow "in" as a keyword argument name
- This would break the Kernel#spawn family's backward compatibility make wrapping methods in this family harder than it already is, as you can work around this with Binding#local_variable_get.
I think this should be rejected. -
11:06 PM Bug #15647 (Rejected): Disallow "in" as a keyword argument name
- "`in`" is a reserved keyword and thus can't be accessed directly anyway.
e.g. the following is a syntax error:
```ruby
def m(in:); p in; end; m(in: 1)
```
And as usual, doing `in = 1` doesn't work.
"`in`" could still be pas... -
01:03 PM Feature #5455 (Rejected): $SAFE should be removed
- The latest decision by Matz (making $SAFE no effect in 2.7) was made in #14353. So closing this ticket to prefer that ticket as a log.
-
12:13 PM Feature #5455 (Assigned): $SAFE should be removed
-
- We are working at https://bugs.ruby-lang.org/issues/14632
-
- See https://bugs.ruby-lang.org/issues/15611#note-7
-
- >Is there a particular reason to have Bundler as a default gem?
Already @mame said. Bundler will merge into RubyGems in the feature. In fact, after RubyGems 2.7+ integrated the part of dependency resolver of Bundler.
Therefore We sh... -
- @schneems
I couldn't reproduce the latest ruby_2_6 branch with fixed #15582. Please wait for releasing next stable version 2.6.2. -
02:55 AM Bug #15642: IO#readline に chomp: true オプションを指定した場合に正しく行区切りを取り除かれないケースが存在する
- I confirmed that it was fixed, thanks.
```console
$ RBENV_VERSION=2.7.0-dev ruby -v test_chomp.rb
ruby 2.7.0dev (2019-03-08 trunk 67194) [x86_64-darwin18]
"size: 8193 result: a"
"size: 16385 result: a"
"size: 24577 result: a"
"s... -
- 12:35 AM Revision caa2a5bb (git): * 2019-03-08
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67194 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
12:35 AM Revision e185c971 (git): use __GNUC__ instead of __GCC__.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67193 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
03/07/2019
-
- Since normal Ruby methods can't differentiate between a literal block and a block pass, having `#lambda` behave like a normal method gives us more consistency.
`#lambda` doesn't need to mutate its argument, it could return a lambda proc... -
06:05 PM Bug #15620: Block argument usage affects lambda semantic
- Right, `define_method` is kind of an exception.
However, it doesn't mutate the lambda-ness of the Proc, it creates a new Proc from that block with lambda semantics.
It's still confusing for the user though, as a given literal block c... -
04:27 PM Bug #15620: Block argument usage affects lambda semantic
- Eregon (Benoit Daloze) wrote:
> `lambda(&proc{}).lambda?` returns false because I think the rule is:
> ...
Right. I was wondering why this is the "rule", what's the rationale. It makes `lambda(&...)` equivalent to `...to_proc` but less... -
- `lambda(&proc{}).lambda?` returns false because I think the rule is:
once a Proc is created, it never changes its lambda-ness.
So the only way to create a lambda is passing a block directly to `lambda` (or through `send`), or using `... -
03:31 PM Bug #15635: Inconsistent handling of dummy encodings and code range
- ruby_2_5 r67192 merged revision(s) 67167.
-
- string.c: respect the actual encoding
* string.c (rb_enc_str_coderange): respect the actual encoding of
if a BOM presents, and scan for the actual code range.
[ruby-core:91662] [Bug #15635]
git-svn-id: svn+s... -
- ruby_2_5 r67191 merged revision(s) 67188.
-
- Applied in changeset trunk|r67188.
----------
io.c: chomp CR at the end of read buffer
* io.c (rb_io_getline_fast): chomp CR followed by LF but separated
by the read buffer boundary. [ruby-core:91707] [Bug #15642] -
- @alanwu, Thanks your feedbacks.
Sorry, There was an error in the repro script.
The correct repro script including your feedback is as follows.
repro script:
```rb
require 'tempfile'
(1..10).each do |i|
Tempfile.open do |tm... -
- io.c: chomp CR at the end of read buffer
* io.c (rb_io_getline_fast): chomp CR followed by LF but separated
by the read buffer boundary. [ruby-core:91707] [Bug #15642]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/bran... -
- When `GEM_HOME` was shared with CRuby and JRuby. RubyGems try to
handle both platforms. It should be ignored the different platform.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67190 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 05:11 AM Revision 8cc53044 (git): * 2019-03-07
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67189 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * io.c (rb_io_getline_fast): chomp CR followed by LF but separated
by the read buffer boundary. [ruby-core:91707] [Bug #15642]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67188 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
03/06/2019
-
- I ran the repro script on my Mac and I get
```
"size: 8194 result: a"
"size: 16386 result: a"
"size: 24578 result: a"
"size: 32770 result: a"
"size: 40962 result: a"
"size: 49154 result: a"
"size: 57346 result: a"
"size: 65538 r... -
- ## 内容
`IO#readline` に `chomp: true` オプションを指定して文字列を読み込んだ場合に、
先頭から特定の長さになる行(具体的には 8,192 の n 倍 + 1バイト)について、
行の区切りが "\r\n" であっても "\n" しか取り除かれないという現象が発生します。
`IO#each_line` についても同じ現象が発生しますが、
引数の先頭に rs として "\r\n" を与えた場合には当該現象は発生しません。
... -
06:28 PM Bug #15645 (Closed): It is possible to escape `Mutex#synchronize` without releasing the mutex
- Hello, I hope this finds you well.
I have a persistent deadlocking issue in a project that relies both on `Mutex#synchronize` and `Thread#raise`, and I believe I have reduced the problem to the following example, in which it is possib... -
03:49 PM Misc #15614: DevelopersMeeting20190311Japan
- * [Feature #15323] Proposal: Add `Enumerable#filter_map`
* I would like to hear more feedback about this feature proposal -
05:29 AM Misc #15614: DevelopersMeeting20190311Japan
- * [Feature #15195] How to deal with new Japanese era
* Just adding this to the list so that we can (re)check how we want to proceed. -
01:20 PM Bug #15644 (Closed): ThreadsWait problems with Thread#report_on_exception
- Using ThreadsWait with Thread.report_on_exception is confusing.
ThreadsWait spawns a new thread for waiting on a thread:
```
# thwait.rb:87
def join_nowait(*threads)
threads.flatten!
@threads.concat threads
for... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67187 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- ruby_2_5 r67186 merged revision(s) 67183.
-
09:50 AM Bug #15607: RuntimeError (can't get Master/Slave device) using PTY.open
- ruby_2_6 r67184 merged revision(s) 67183.
-
- Applied in changeset trunk|r67183.
----------
Fix PTY.open on OpenBSD [Bug #15607]
From: Jeremy Evans <code@jeremyevans.net> -
- Fix PTY.open on OpenBSD [Bug #15607]
From: Jeremy Evans <code@jeremyevans.net>
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_5@67186 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Applied in changeset trunk|r67185.
----------
proc.c: call respond_to_missing? with a symbol
[ruby-core:91683] [Bug #15640] -
10:40 AM Bug #15640: Inconsistent value passed to respond_to_missing?
- @nobu should the value depending on the value used for method, or should respond_to_missing? always has Symbol as parameter?
i think the best would be to make it simple and always have it use Symbol -
- Good catch.
This behavior was to get rid of inadvertent symbol creation before symbol-GC,
so it is no longer needed. -
12:22 AM Bug #15640 (Closed): Inconsistent value passed to respond_to_missing?
- If the symbol has been defined, then it is passed. Otherwise a string is passed the first time.
```ruby
class SomeBug
def respond_to_missing?(m, *)
p m
true
end
end
if false then
# uncomment to force to sy... -
- [ruby-core:91683] [Bug #15640]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67185 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Fix PTY.open on OpenBSD [Bug #15607]
From: Jeremy Evans <code@jeremyevans.net>
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_6@67184 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- From: Jeremy Evans <code@jeremyevans.net>
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67183 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- ruby_2_6 r67182 merged the patch.
-
05:19 AM Bug #15637: Backport RubyGems 3.0.3/2.7.9
- hsbt (Hiroshi SHIBATA) wrote:
> Thanks, I fixed it at v2 patches. Can you try them again?
Yes, all patches apply now, thank you very much. -
- I attached the patches with r67171.
@jeremyevans0
Thanks, I fixed it at v2 patches. Can you try them again? -
- It looks like the uploaded patch files for 2.4.5 and 2.5.3 do not apply with either BSD or GNU patch, resulting in:
```
patch: **** malformed patch at line 391: package = Gem::Package.new @gem
```
Line 350 in both patch file... -
- I added a test fix at r67171 for Windows platform. Please backport it too.
-
- * Fixed following vulnerabilities:
* CVE-2019-8320: Delete directory using symlink when decompressing tar
* CVE-2019-8321: Escape sequence injection vulnerability in verbose
* CVE-2019-8322: Escape sequence ... -
- ruby_2_6 r67181 merged revision(s) 67167.
-
- string.c: respect the actual encoding
* string.c (rb_enc_str_coderange): respect the actual encoding of
if a BOM presents, and scan for the actual code range.
[ruby-core:91662] [Bug #15635]
git-svn-id: svn+s... -
- ruby_2_6 r67180 merged revision(s) 66984.
-
- Fixed gemspec location of bundler.
FileCollector of rbinstall.rb requires location of gemspec under
the sub-direcotry with the same name as default gems.
I forgot to fix it with r66867.
[Bug #15... -
-
- The rubygems team changed the behavior of `BundlerVersionFinder`.
It makes detecting only the major version of Bundler from strict version matching.
This patch can be applied after https://bugs.ruby-lang.org/issues/15637 -
- ruby_2_6 r67179 merged revision(s) 67006.
-
- Ignore to add bundler lib direcotry if it is same as rubylibdir.
[Bug #15469][ruby-core:90742]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_6@67179 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- ruby_2_6 r67177 merged revision(s) 66972.
-
- Remove deprecated `sudo: false` in .travis.yml
- https://blog.travis-ci.com/2018-11-19-required-linux-infrastructure-migration
- https://docs.travis-ci.com/user/reference/overview/#deprecated-virtualization-environments
... -
- Fix exception namespace
* lib/fileutils.rb (remove_entry_secure): EISDIR is under the
Errno namespace. [ruby-core:91362] [Bug #15577]
From: Tietew (Toru Iwase) <tietew@tietew.net>
git-svn-id: svn+ssh://ci.ru... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_6@67176 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- ruby_2_6 r67175 merged revision(s) 67169,67173,67174.
-
- Issue for backporting.
This is needed if we follow the agressive strategy in #15195. -
- update Unicode version (and Emoji version) to 12.0.0
- common.mk: set UNICODE_VERSION and UNICODE_EMOJI_VERSION to 12.0.0
- lib/unicode_normalize/tables.rb: update table data to Unicode version 12.0.0
- enc/uni... -
- This commit is also part of this issue: r67174
-
- Unicode Version 12.0.0 has officially been released. The announcement is at http://blog.unicode.org/2019/03/announcing-unicode-standard-version-120.html.
-
- this completes and closes feature #15321
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67174 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67173 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
03:04 AM Revision fdc42bf8 (git): Remove deprecated `sudo: false` in .travis.yml
- - https://blog.travis-ci.com/2018-11-19-required-linux-infrastructure-migration
- https://docs.travis-ci.com/user/reference/overview/#deprecated-virtualization-environments
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67172 b2dd03c... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67171 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 01:55 AM Revision ad398b7e (git): * 2019-03-06
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67170 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- - common.mk: set UNICODE_VERSION and UNICODE_EMOJI_VERSION to 12.0.0
- lib/unicode_normalize/tables.rb: update table data to Unicode version 12.0.0
- enc/unicode/12.0.0/casefold.h, enc/unicode/12.0.0/name2ctype.h: add generated
files...
03/05/2019
-
07:35 PM Bug #15634: TracePoint seems to be skipping some methods.
- Here is more elaborate example:
```ruby
#!/usr/bin/env ruby
trace_point = TracePoint.new(:call, :return, :line, :c_call, :c_return, :b_call, :b_return) do |trace|
puts [trace.path, trace.lineno].join(":")
end
trace_point.... -
04:51 PM Bug #15639: [BUG] Segmentation fault at 0x000000010e82ca3a
- Guys, if this is a duplicate - feel free to close it. Thanks
-
- This happen when I start a rails server in Rubymine and try to open a page in browser. But when I run a server in terminal - it works just fine
-
- Seems same as #15490.
-
- (description and method to reproduce required)
-
- The last update of rb-readline is 2 years ago. I think we shouldn't replace it.
And @aycabta try to create the readline alternative. If we replace readline to pure ruby implementation, we should use it. -
10:46 AM Bug #15638 (Closed): Another race conditions in MonitorMixin when interrupted?
- Hi, I believe I've got a race condition issue in MonitorMixin when interrupted (by TimeoutError in my example). It looks very similar to https://bugs.ruby-lang.org/issues/14998#change-75226 but unfortunately it looks like this fix landed...
-
09:30 AM Bug #15636 (Rejected): ::Socket#to_a hangs Ruby interpreter
- I don't think it's a bug of socket library.
arturmoczulski (Artur Moczulski) wrote:
> ## Result
> ...
No, it desn't. It just takes a long time. It properly exits after 60 seconds (from my machine at least).
> ## Expected
> ...... -
08:21 AM Bug #14702: On Ruby 2.5.1, tracepoint isn't working on the file that is loaded by load_iseq
- For reference: https://github.com/rails/rails/issues/35475.
-
- @duerst
Thanks for your proofreading :) -
- It says "They contain multiple vulnerabilities.". I hope the intent was to write something like "They fix multiple vulnerabilities." or "They contain multiple vulnerability fixes.".
-
- Current behavior is clearly a bug due to the block passing implementation.
It's actually not clear to me why `lambda(&proc{}).lambda?` returns `false`. It doesn't seem useful and is counter-intuitive to me.
If others think we could... -
- It fixed the multiple vulnerabilities.
https://blog.rubygems.org/2019/03/05/security-advisories-2019-03.html
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67168 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
03:10 AM Misc #15614: DevelopersMeeting20190311Japan
- * [Misc #15617] Release 2.5.4? (blowmage)
* There are several bug fixes backported to 2.5 that have not been released yet. Do we know when they will be released? -
- We are also interested in seeing 2.5.4 released quickly, to get the #14561 backport.
-
- Applied in changeset trunk|r67167.
----------
string.c: respect the actual encoding
* string.c (rb_enc_str_coderange): respect the actual encoding of
if a BOM presents, and scan for the actual code range.
[ruby-core:91662] [Bug #15... -
- * string.c (rb_enc_str_coderange): respect the actual encoding of
if a BOM presents, and scan for the actual code range.
[ruby-core:91662] [Bug #15635]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67167 b2dd03c8-39d4-4d8f-98ff-... - 12:28 AM Revision 4045cb82 (git): * 2019-03-05
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67166 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67165 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
03/04/2019
-
- Hi!
Rails 6 applcations have bootsnap and Zeitwerk enabled by default. Right now, that needs Ruby 2.6 because Zeitwerk sets a trace point on the :class event to support what I call "explicit namespaces".
Just wanted to let you know... -
- I released RubyGems 3.0.3 and 2.7.9 today. They contain multiple vulnerability fixes.
* https://blog.rubygems.org/2019/03/05/3.0.3-released.html
* https://blog.rubygems.org/2019/03/05/2.7.9-released.html
I attached the patches for... -
10:02 PM Bug #15636 (Rejected): ::Socket#to_a hangs Ruby interpreter
- `ruby -v`: `ruby 2.6.1p33 (2019-01-30 revision 66950) [x86_64-linux]`
## Reproducible script
``` ruby
require 'socket'
s = Socket.new(:INET, :STREAM)
s.connect Socket.pack_sockaddr_in(80, 'example.com')
s.to_a
```
## Result
... -
04:28 PM Bug #15635: Inconsistent handling of dummy encodings and code range
- I also tested some older Ruby releases. The issue is also present in `ruby 2.4.4p296 (2018-03-28 revision 63013) [x86_64-linux]` and `ruby 2.5.1p57 (2018-03-29 revision 63029) [x86_64-linux]`.
-
- It's hard to write code that works properly with dummy encodings, so they should really be avoided altogether. However, I've come across a code path that I think yields inconsistent results when it comes to dummy encodings with a minimum...
-
- Why is such a search performed every time?
Is it not enough to cache the name in the Module instance (since it keeps the name even after the constant is removed anyway) ?
Also, I think naming can be done proactively when assigning co... -
- Of course it is possible to check duplicated paths to refine worst cases, but it is a trade-off for usual case; no aliased constants.
### trunk
| user| system| total| real
------+----------:|----------:|-... -
- ```ruby
trace_point = TracePoint.new(:call, :return, :line, :c_call, :c_return, :b_call, :b_return) do |trace|
puts [trace.path, trace.lineno].join(":")
end
trace_point.enable
values = {foo: 10}
def shell_escape(x)
x... -
- Applied in changeset trunk|r67163.
----------
FindFirstFile cannot glob share names
* win32/file.c (replace_to_long_name): do not try to glob host
names and share names by FindFirstFile which is useless for that
purpose. [ruby-cor... - 08:13 AM Revision ba982a3d (git): * 2019-03-04
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67164 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * win32/file.c (replace_to_long_name): do not try to glob host
names and share names by FindFirstFile which is useless for that
purpose. [ruby-core:91656] [Bug #15633]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67163 b2dd03c... -
- IIRC, it was rejected (or suspended at least) by matz at the previous developers' meeting.
-
- At first, as no syntax to name a singleton class like ordinary classes/modules, singleton classes cannot have a name.
And name-by-assignment is a “best effort” (or “better than nothing”).
03/03/2019
-
- to shorten time to clone
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67162 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
12:30 PM Bug #15633 (Closed): Pathological slowdown in File.expand_path on UNC paths on Windows
- For a while now, including Ruby 2.5, calling File.expand_path on an absolute UNC path seems to be strangely slow. I've put together some benchmarks here:
```
require 'benchmark'
MAX = 200000
Benchmark.bm(30) do |x|
x.report(... -
10:33 AM Bug #14716: SecureRandom throwing an error in Ruby 2.5.1
- Hi,
we're on "Ubuntu 14.04.5 LTS", kernel version "3.13.0-165".
```
2019-03-03T05:00:00.798Z 12950 TID-ors73fmw2 WARN: RuntimeError: failed to get urandom
2019-03-03T05:00:00.798Z 12950 TID-ors73fmw2 WARN: /usr/lib/ruby/2.5.0/sec... -
06:18 AM Revision 2e9d4b9f (git): do not close FSs explicitly.
- * test/ruby/test_dir.rb: r67159 closes all files explicitly
but this change breaks attempt of this test introduced at
r56467. Try another solution which removes all references
from an Array with `#clear`.
git-svn-id: svn+ssh://ci... - 12:17 AM Revision 7ebea695 (git): * 2019-03-03
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67160 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- to fix a test failure like
http://ci.rvm.jp/results/trunk-theap-asserts@silicon-docker/1804207
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67159 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
03/02/2019
-
- To get your proposal accepted, we always need to have a real-world use case. Just showing a project that calls `Object#method` with a dynamic method name might be sufficient to make us understand why it's helpful.