Activity
From 02/18/2019 to 02/24/2019
02/24/2019
-
06:57 PM Bug #15620 (Closed): Block argument usage affects lambda semantic
- The following snippet demonstrate the issue:
``` ruby
def pass_after_use(&block)
raise unless block
lambda(&block).call
end
def direct_pass(&block)
lambda(&block).call
end
pass_after_use do |_arg|
puts "fine, beca... -
06:41 PM Feature #15619 (Third Party's Issue): Support blacklisting certain dependency versions
- # Abstract
This feature request proposes introducing a new dependency constraint "!=", which will allow to blacklist a specific buggy version of some gem dependency without dropping support for older releases.
# Background
I am ... -
05:16 PM Feature #15618: Implement Enumerator::Yielder#to_proc
- I have no particularly strong pro or con opinion on the functionality itself.
I have only one comment about syntax, though. While { |line| y << line } }
may or may not be redundant (let's leave that open for the moment), and is
defi... -
03:55 PM Feature #15618 (Closed): Implement Enumerator::Yielder#to_proc
- When writing an Enumerator block, you often want to delegate iteration to another method like this:
```ruby
enum = Enumerator.new { |y|
Dir.glob("*.rb") { |file|
File.open(file) { |f| f.each_line { |line| y << line } }
}
... -
11:57 AM Revision 23a8183b (git): Check stx_btime in struct statx
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67131 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 05:27 AM Revision a582007e (git): * 2019-02-24
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67130 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
05:27 AM Revision 8b8285e2 (git): configure.ac: remove check for broken memmem
- the bug of memmem(3) was fixed in glibc 2.1 released in 1999.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67129 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
02/23/2019
-
- とりあえず`NotImplementedError`とも一番近そうな`ENOSYS`を投げるようにしましたが、本来セットされていない`errno`を装うよりは`RuntimeError`あたりのほうがいいのではないかと思います。
もしくは次点で`nil`。 -
- Linux and AIX have statx() with different prototype.
Linux: int statx(int, const char*, int, unsigned int, struct statx*)
AIX: int statx(char, struct stat*, int, int)
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67128 b2dd03c8-39d... -
03:43 AM Revision 6604e1b7 (git): Merge json-2.2.0 from flori/json.
- https://github.com/flori/json/releases/tag/v2.2.0
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67127 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
02:22 AM Revision f22ffd83 (git): spec/../rbconfig_spec.rb: skip spec not working on MinGW
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67126 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 02:17 AM Revision 0dab1fce (git): * 2019-02-23
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67125 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- due to MJIT worker's known race condition.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67124 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
02/22/2019
-
10:54 PM Misc #15617 (Closed): Any chance we can ship 2.5.4 sooner rather than later?
- We started carrying code like this in Discourse due to #14634 breaking Queue after fork.
https://review.discourse.org/t/dev-disable-async-logging-in-development-on-broken-ruby/1829
I was wondering if there is any chance we can fa... -
04:07 PM Bug #15613 (Open): Enumerator::Chain#each doesn't relay block signature
-
03:51 PM Bug #15616: Chained destructive methods fail when using +@ to unfreeze a frozen string
- ```
+foo.gsub!("bar", "car")
```
stands for
```
+(foo.gsub!("bar", "car"))
```
and because foo is frozen, you'll get an error, see #15606
try this
```
foo = "bar".freeze
foo = (+foo).gsub!("bar", "car")
```
or
```
foo... -
02:52 PM Bug #15616 (Rejected): Chained destructive methods fail when using +@ to unfreeze a frozen string
- Using the +@ syntax to unfreeze a string does not work when chaining destructive methods
Consider the following;
``` ruby
foo = "bar".freeze
+foo.gsub!("bar", "car")
```
This raises;
``` ruby
FrozenError: can't modify frozen ... -
- [Misc #15615] File.birthtimeがLinux環境で有効なファイル作成時刻を得られなかった場合の挙動について
-
10:20 AM Misc #15614: DevelopersMeeting20190311Japan
- * [Feature #14609] `Kernel#p` without args shows the receiver (aycabta)
* carry over -
- Please comment your favorite ticket numbers you want to ask to discuss with your *SHORT* comment or summary.
(your summary/comment will help us because we don't need to read all of ticket comments)
*DO NOT* discuss then on this ticke... -
- `File.birthtime`はファイルの作成時刻を返すメソッドです。
これまでLinux環境ではこのメソッドは実装されておらず、呼び出すと`NotImplementedError`が発生していましたが、r67088から一部のLinux環境でも`File.birthtime`が動作するようになりました。
Linux環境での`File.birthtime`は、`statx()`というLinux 4.11から導入されたシステムコールを使うことで実装されています。
... - 07:25 AM Revision f53548a8 (git): * expand tabs.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67123 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
07:25 AM Revision b1c1ee71 (git): change `cfunc->invoker` type for opt.
- * vm_insnhelper.c: change `call_cfunc_*` parameters order
and specify a function type for the passed func ptr.
This fix reduce the number of asm instructions, such as:
# before this patch
0000000000000110 <call_cfunc_0>:
... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67121 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67120 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67119 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67118 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67117 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67116 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67115 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
02/21/2019
- 08:59 PM Revision 67032770 (git): * expand tabs.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67114 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * compile.c: refacetoring:
* initialize `branches` with Qfalse intead of 0.
* make compile_call* functions from `iseq_compile_each0()`
to make modifying them easy.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67113 b2dd03c... -
08:02 PM Feature #12745: String#(g)sub(!) should pass a MatchData to the block, not a String
- sawa (Tsuyoshi Sawada) wrote:
> What about having `Enumerator#with_m`, such that
> ...
This doesn't make sense to add to Enumerator in my opinion, since most Enumerators will not be created from `gsub`/`sub`:
```ruby
[1].each.with_... -
07:17 PM Feature #12745: String#(g)sub(!) should pass a MatchData to the block, not a String
- What about having `Enumerator#with_m`, such that
```ruby
gsub(pattern).with_m{|match, match_data| block} → new_str
sub(pattern).with_m{|match, match_data| block} → new_str
```
And if we want to expand that to `scan`, we can intr... -
03:38 PM Revision da797623 (git): Update to ruby/spec@7a16e01
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67112 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 03:38 PM Revision b8e389a0 (git): * 2019-02-22
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67111 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 03:38 PM Revision 203d9467 (git): * properties.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67110 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67109 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
03:28 PM Feature #15605: json library needs more frequent releases
- > Perhaps a better general solution may be to allow the ruby main team to decide who is co-owner of gems IF these gems are part of the official ruby distribution.
This seems like a good rule of thumb. I know we've had trouble finding ... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67108 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67107 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 06:12 AM Revision 32f3961f (git): * 2019-02-21
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67106 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67105 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
02/20/2019
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67104 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- It fails by EPERM for unknown reason.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67103 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Docker's default seccomp whitelist does not include statx syscall
by the default. Skipt this error for now.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67102 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67101 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67100 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67099 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
07:19 AM Revision f2d3b362 (git): Fix document and return value of `IO#autoclose=`
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67098 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * file.c (rb_file_s_birthtime): export for pathname to check if
birthtime is supported.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67097 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Applied in changeset trunk|r67095.
----------
* spec/ruby: Tweak Enuemrator::Chain#rewind spec so that arity of block matches what is yielded
Calling `and_yield(*args)` adds an implicit expectation that all the `args` are passed to a b... -
- Currently, the block given when iterating on the components of a `Enumerator::Chain` always have arity of -1 and `lambda?` is always `false`:
```ruby
class Foo
include Enumerable
def each(&block)
return to_enum unless bloc... - 04:39 AM Revision d034fcb1 (git): * properties.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67096 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 04:39 AM Revision b7f89968 (git): * spec/ruby: Tweak Enuemrator::Chain#rewind spec so that arity of block matches what is yielded
- Calling `and_yield(*args)` adds an implicit expectation that all the `args` are passed to a block that can accept them, even though blocks that are not lambda-like don't mind extra arguments.
It so happens that this spec passed on Ruby 2... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67094 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67093 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
02:59 AM Bug #15604: Backport r66349 to 2.5
- rafaelfranca (Rafael França) wrote:
> Thank you! Do you need to change the backport field to point it needs to be backported to 2.5 but not to 2.6?
Thank you. But leaving that field UNKNOWN is just OK. -
- jeremyevans0 (Jeremy Evans) wrote:
> As blocks already do what you want, why not just:
> ...
You can "declare" overriding local variables.
```ruby
foo = "bar"
tap do |;foo|
foo = "foo"
foo # => "foo"
end
foo # => "bar"
```
-
- Attached is a fix to this issue, by just adding `|| defined(__OpenBSD__)`.
The example in the PTY document works correctly with this patch.
02/19/2019
-
10:39 PM Feature #15612: A construct to restrict the scope of local variables
- On top of what others have said, methods in Ruby should normally be quite short. If you have a method that's so long that you think you need restricted scopes for local variables, you should look at how to split the code into several met...
-
- sawa (Tsuyoshi Sawada) wrote:
> In order to improve readability of the code by explicitly indicating the scope of such local variables, and to avoid pollution by the variable, I propose to have some construct to restrict the scope of lo... -
- I think this is an interesting idea but the syntax is a bit confusing (to
me).
This may be because I am so used to:
begin
code_that_may_break
rescue Duck
puts 'all ducklings were rescued.'
end
It see... -
01:28 PM Feature #15612 (Feedback): A construct to restrict the scope of local variables
- I am not sure how readability improved by adding explicit scoping. So you have to prove it first.
From my point of view, overriding local variables in the example is a source of confusion, rather than readability.
Matz.
-
- We sometimes have local variables that are to be used only to keep track of some temporal states/values during a short routine:
```ruby
...
foo = some_initial_value
some_routine_that_uses_foo
...
```
Currently, the scope of lo... -
05:56 PM Feature #15611: Shipping Bundler as a bundled gem, not a default gem
- > Also, moving bundler to a default gem would still keep the same problem...
When I said "default gem" before I meant "bundled gem", but I think you understood me... :)
> ...
Will both repositories become one and the code be reused... -
- > As far as I know, bundler is planned to be merged to rubygems.
What would that mean exactly? (that's a question for Bundler/RubyGems devs)
Will both repositories become one and the code be reused for both parts? That's what I would... -
- Yes, I was going to comment exactly along the same lines mame presents.
Also, moving bundler to a default gem would still keep the same problem in https://bugs.ruby-lang.org/issues/15610, but only for the rubygems code. Although to be... -
12:59 AM Feature #15611: Shipping Bundler as a bundled gem, not a default gem
- As far as I know, bundler is planned to be merged to rubygems. If shipping bundler as a gem is ephemeral, it looks less significant to me whether bundler should be a bundled gem or a default one.
In fact, rubygems already includes so... - 03:39 PM Revision 5210b89f (git): * 2019-02-20
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67092 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- related: r66982
Sadly opt_regexpmatch2 was not a leaf insn either.
http://ci.rvm.jp/results/trunk-vm-asserts@silicon-docker/1751213
CHECK_INTERRUPT_IN_MATCH_AT is just like RUBY_VM_CHECK_INTS, and it may
call arbitrary Ruby method, for ... - 05:45 AM Revision fe0f98e7 (git): * 2019-02-19
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67090 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 05:45 AM Revision d3ff5647 (git): * expand tabs.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67089 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- enable File.birthtime on Linux if statx(2) is available.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67088 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
02/18/2019
-
-
- @deivid I have another proposal in https://bugs.ruby-lang.org/issues/15611, what do you think?
-
- I can not answer the question, as I think that is up to the ruby core team, Hiroshi,
the gem-team and the bundler team. However had perhaps it may be worthwhile to actually
consider a new unified name? Perhaps for ruby 3.0 or if that i... -
- Currently bundler & rubygems are shipped together with the rest of the standard library (in `RbConfig::CONFIG["rubylibdir"]`). The fact that they share their folder with the rest of the standard library has caused some issues that wouldn...
-
- I think this would simplify many things, and would allow to update or remove the shipped Bundler easily on Ruby 2.6.
Is there a particular reason to have Bundler as a default gem?
Also, given how Bundler magically switches which ve... - 01:33 PM Revision 5f090b8d (git): * properties.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67087 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- It break the examples of bundler. Because some examples detect the
different version of system ruby than test target version like trunk.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67086 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
11:44 AM Revision e19e5d24 (git): Fix return value name in docs for Array#union
- Throughout the docs, `new_ary` is used to indicate a new array, whereas `ary` refers to the receiver.
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67085 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 09:46 AM Revision 5c11d854 (git): * 2019-02-18
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67084 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67083 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- `rb_f_sleep` uses `time()` internally, so it always returns Integer even if it called with Float.
https://github.com/ruby/ruby/blob/124957566f041e5c6e8f678dfaf62cae381826dc/process.c#L4840-L4857
I think returning Float is more usef...