Activity
From 11/20/2018 to 11/26/2018
11/26/2018
-
11:30 PM Revision 51196cf5 (git): improve messages for test failures
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66010 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 08:16 PM Revision 27b1553b (git): * remove trailing spaces.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66009 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
08:16 PM Revision 72e60a04 (git): `TracePoint#enable(target_line:)` is supported. [Feature #15289]
- * vm_trace.c: `TracePoint#enable(target_line:)` is supported.
This option enables a hook only at specified target_line.
target_line should be combination with target and :line event.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trun... -
08:12 PM Bug #15343: String#each_grapheme_cluster wrongly splits some emoji (genie, zombie, wrestling)
- This issue is epic due to its title alone! (I don't quite know whether
there are indeed genie and zombie emojis yet but it makes me curious.)
> except those relating to genies, zombies, and wrestling (THIS IS NOT
> ...
Awww .... :) -
- All the codepoint combinations that turn up in the various emoji files provided by Unicode (currently we use those at https://www.unicode.org/Public/emoji/5.0/) are recognized as grapheme clusters by `String#each_grapheme_cluster`, excep...
-
- > The map(&method(:local_method)) or yield_self(&method(:local_method)) pattern is absolutely real
> ...
Everyone who suggests something tends to think of it as useful and often pretty too. :-)
I personally have become too picky perh... -
- * cont.c (cont_restore_thread): cause error if trace-status is changed.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66007 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * iseq.c (iseq_add_local_tracepoint_i): extract aggregate initialization.
See https://travis-ci.org/ruby/ruby/jobs/459881277
* iseq.c (iseq_remove_local_tracepoint_i): ditto.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66006 b... -
- * iseq.c (iseq_iterate_children): should use cast to `int`.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66005 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Applied in changeset trunk|r66003.
----------
Support targetting TracePoint [Feature #15289]
* vm_trace.c (rb_tracepoint_enable_for_target): support targetting
TracePoint. [Feature #15289]
Tragetting TracePoint is only enabled on ... - 06:16 PM Revision 61c8247d (git): * expand tabs.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66004 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * vm_trace.c (rb_tracepoint_enable_for_target): support targetting
TracePoint. [Feature #15289]
Tragetting TracePoint is only enabled on specified method, proc
and so on, example: `tp.enable(target: code)`.
`code` should be con... -
04:32 PM Feature #15331: [PATCH] Faster hashing for short string literals
- nobu (Nobuyoshi Nakada) wrote:
> About the macro `BUILTIN_SINGLE_BYTE_ENC_IDX_P`, its name is misleading as it is true for UTF-8.
I agree. I removed it.
> ...
Done.
I moved away from using +1 in the buffer size, since it could ... -
01:47 PM Feature #15331: [PATCH] Faster hashing for short string literals
- alanwu (Alan Wu) wrote:
> I've taken multi-byte terminators into account and updated my implementation. I've also included a test that should warn us about hash clobbering.
Seems nice.
About the macro `BUILTIN_SINGLE_BYTE_ENC_IDX_... -
- I've taken multi-byte terminators into account and updated my implementation. I've also included a test that should warn us about hash clobbering.
I also noticed that the benchmark that creates many unique fstrings is actually 5% slower... -
04:13 PM Revision 2c9259e6 (git): test_jit.rb: skip a test for Windows for now
- https://ci.appveyor.com/project/ruby/ruby/builds/20558412
removing CloseHandle disallows us to remove the DLL.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66002 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Applied in changeset trunk|r66001.
----------
vm_trace.c: MJIT-limited thread-safety for postponed_job
[Bug #15316] -
- [Bug #15316]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66001 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 03:12 PM Revision 01e2bf35 (git): * 2018-11-27
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66000 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- because JIT-ed code may still be on stack at this time, unlike
in ruby_cleanup().
This hopes to fix: (take 2)
http://ci.rvm.jp/results/trunk-mjit-wait@silicon-docker/1480207
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65999 b2dd0... -
- This reverts commit 0e6aba22c6b876a36adc39cac5314ce6e626954c.
because it didn't help, at all.
http://ci.rvm.jp/results/trunk-mjit-wait@silicon-docker/1480207
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65998 b2dd03c8-39d4-4d8f-98... -
- http://ci.rvm.jp/results/trunk-mjit-wait@silicon-docker/1480173
It tries to print C backtrace but fails. And core file on the server
seems to be stopping on the irrelevant place due to its own signal
handler for the dump.
And I failed ... - 02:03 PM Revision c8c265f4 (git): * properties.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65996 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65995 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- to prevent ruby from leaving MJIT-related files.
test_jit.rb: add a test to prevent that
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65994 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- after MJIT worker stop.
r65928 didn't fix the SEGV. This commit hopes to fix
http://ci.rvm.jp/results/trunk-mjit-wait@silicon-docker/1478576
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65993 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- by Bundler integration, like:
http://ci.rvm.jp/results/trunk-no-mjit@silicon-docker/1479769
This resurrects r65629 which was accidentally reverted by r65904.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65992 b2dd03c8-39d4-4d8f-98... -
12:23 PM Revision a2456daf (git): Sync the executables of rdoc from upstream repository.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65991 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- @schneems
I fixed this issue with https://github.com/ruby/ruby/commit/a94332819463589fe4537cc62beb41a0ee354cf3
Can you try the current trunk revision? -
11:38 AM Bug #15335: Ruby 2.6.0 is not properly fortified
- Testing with r65990 on x86_64 and the test passed. I guess I should not try to build on other arches yet, right?
-
- Add file test/ruby/enc/test_emoji_breaks.rb to test String#each_grapheme_cluster
test data provided by Unicode (at https://www.unicode.org/Public/emoji/#{EMOJI_VERSION}/).
Lines containing emoji for genies, zombies, and wrestling are ig... -
07:55 AM Revision ebff9dc1 (git): object.c: Deprecate Object#=~ and add NilClass#=~`
- Object#=~ always returns nil. This behavior is not only unuseful but
also troublesome because it may hide a type error.
This change deprecates Object#=~. For compatibility, NilClass#=~ is
newly introduced. [Feature #15231]
git-svn-i... -
- RubyGems is very indifferent for type.
This change is needed for removal of `Object#=~`. [Feature #15231]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65988 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65987 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
05:46 AM Misc #15336: Duplicate builds on travis-ci?
- I don't have answers for every questions but for the first one: we enable cron builds for Travis-CI, which run every day. This is a handy occasion to do lots of additional tests. Compare these two results:
- https://travis-ci.org/ru... -
- RDoc::Options#@exclude is initialized as an empty array.
Then, #finish converts it to a regexp or nil and reassign it to @exclude.
Some methods of RDoc assumes that #finish has been already called.
So, this change forces to assign nil to... -
05:45 AM Misc #15342: DevelopersMeeting20181212Japan
- * [Feature #13581] Syntax sugar for method reference
-
- Please comment your favorite ticket numbers you want to ask to discuss with your *SHORT* comment or summary.
(your summary/comment will help us because we don't need to read all of ticket comments)
*DO NOT* discuss then on this ticke... -
- `@res` is an Array, so `@res =~ /\n\z/` calls `Object#=~` which always
returns nil.
I guess it should be `@res.last =~ /\n\z/`, but the change causes test
failures.
This bug was found during work for removal of `Object#=~`.
[Feature #15... -
- Applied in changeset trunk|r65984.
----------
lib/webrick: explicitly convert header values to a string
The values of @header are expected to be all strings;
WEBrick::HTTPResponse::[]=(key, val) explicitly converts the second
argument ... -
- The values of @header are expected to be all strings;
WEBrick::HTTPResponse::[]=(key, val) explicitly converts the second
argument to a string and assigns it to @header hash.
However, there were some points in WEBrick internal code that ... -
-
- The Emoji version is different from the Unicode version. Currently, the Unicode version is accessible from `RbConfig::CONFIG['UNICODE_VERSION']`, but it's not possible to get the Emoji version.
I need the Emoji version for testing, so... -
- I agree that `#visibility` is the best solution. When somebody mentioned this at the recent Ruby committers' meeting, I immediately thought "that's it". Benoit provides some more background.
There are arguments that this may be misund... -
- * common.mk (ruby.imp): extract the first word on the next lines
of MJIT_FUNC_EXPORTED, regardless the prefix. duplicate symbols
will be removed by `sort -u`.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65983 b2dd03c8-39d4-4d... -
- We can set environment variables to avoid before_script.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65982 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
02:31 AM Revision 9e2acbca (git): un.rb: add more options for httpd to help message [ci skip]
- see r65965
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65981 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Exclude OpenSSL because we don't plan to debug libssl,
also track origins of uninitialized bits.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65980 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
-
-
- Applied in changeset trunk|r65979.
----------
Removed `bundle_ruby` command. Because It's no longer shipped from Bundler 1.0.2.
[Bug #15291][ruby-dev:50663] -
- [Bug #15291][ruby-dev:50663]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65979 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
01:43 AM Feature #15000: Prevent to initialize MonitorMixin twice
- znz (Kazuhiro NISHIYAMA) wrote:
> How about checking owner object?
Could you commit it if it passes tests?
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65978 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65977 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
11/25/2018
-
- In common.mk, add the files emoji-sequences.txt, emoji-test.txt,
emoji-variation-sequences.txt, and emoji-zwj-sequences.txt to
UNICODE_EMOJI_DOWNLOAD for download with `make update-unicode-property-files`.
These files will be used for au... -
08:04 PM Bug #15339: CI - add checks for std-lib CLI ?
- Added 3 lines to rbinstall.rb, added bundle_ruby to Bundler's executables.
Both are minor fixups to r65963. Passes on Appveyor. Patch file updated. Nothing changed re Travis... -
- @junaruga
1) I believe I have seen discussions on whether `make install` should be included in CI or not.
2) The test suites can be run before `make install`.
3) I'm not a good choice for making changes re Makefile, especially f... -
12:01 PM Bug #15339: CI - add checks for std-lib CLI ? - How about creating this check in make task "make test" or "make test-all"?
-
- Sorry for not mentioning it, but GH PR is just for Appveyor. Not sure if code should be added to all Travis builds...
PR CI failed for all three builds on Appveyor. All errors similar to:
```
\usr\bin\bundle --version
C:/usr/bi... -
- Currently, CI is largely ignorant of the install.
Adding checks for the std-lib items with binstubs/executables is simple and adds a minimal amount of time to the CI.
See [GitHub PR #2028](https://github.com/ruby/ruby/pull/2028). -
04:23 PM Bug #15340 (Closed): Time.local behaving inconsistently for excess days after 2038
- Applied in changeset trunk|r65974.
----------
Normalize month-mday before finding epoch
Especially over the year 2038, 30 Feb and so on may cause odd behavior
on validating found epoch with given year-month-day [Bug #15340] -
- > I thought I observed a case 2038-02-30 is recognized as 2038-03-01 when ENV['TZ']=nil, but just now I couldn't reproduce the case. It might be my mistake in operations, but let me leave the log just in case. (It might be because I was ...
-
02:53 PM Bug #15340 (Closed): Time.local behaving inconsistently for excess days after 2038
- Time.local accepts a day of month that exceeds the largest day of the month, for example, 2018-02-31. The behavior looks inconsistent before v.s. after 2038. Are they expected behavior?
The behavior looks somewhat reasonable before 20... - 04:23 PM Revision b1a40c10 (git): * 2018-11-26
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65975 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Especially over the year 2038, 30 Feb and so on may cause odd behavior
on validating found epoch with given year-month-day [Bug #15340]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65974 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
12:31 PM Revision dd782579 (git): Fix locations of NODE_UNDEF in undef with multiple args
- * parse.y: Fix the beginning position of trailing NODE_UNDEF.
e.g. The location of the NODE_UNDEF for `b` is fixed:
```
undef a, b
```
* Before
```
NODE_UNDEF (line: 1, location: (1,6)-(1,10))
```
* After
```
... -
- Refactoring: In regparse.c, extract creation of a new CClass node and
initialization using a property into a new function create_property_node().
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65972 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- In the function onigenc_unicode_case_map() in enc/unicode.c, deal
with the case that the ONIGENC_CASE_IS_TITLECASE flag is set on
lowercase characters. This is in preparation for Georgian Mtavruli,
which are uppercase but not titlecase, ... -
- As for the implementation, this `rb_gv_defined` will add new ID just by asking if the gv is defined.
-
- * tool/vcs.rb (VCS::GIT#export_changelog): improve the
compatibility with svn-log.
remained differences are:
- in svn-log
- accented characters, left/right single quotation marks, and
non-break spaces are translated to ... -
- [Fix GH-2011]
From: Akim Demaille <akim.demaille@gmail.com>
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65969 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65968 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65967 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65966 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65965 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- One idea is to shrink `MEMO_HASH_LEN_MAX` for a wide-char terminators.
-
03:10 AM Bug #15332: coverage and InstructionSequence regression
- I don't have an important use case, no.
-
- Applied in changeset trunk|r65963.
----------
Use stub executables generated by RubyGems istead of original executables.
It resolved the conflict issues when invoking `gem i rdoc` and the binstub
issues with Bundler and Rails.
[Bug #... - 01:20 AM Revision 9ba098f1 (git): * properties.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65964 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- It resolved the conflict issues when invoking `gem i rdoc` and the binstub
issues with Bundler and Rails.
[Bug #5060][ruby-core:38257][Fix GH-2023]
* https://github.com/rubygems/rubygems/pull/2338
* https://github.com/heroku/hero...
11/24/2018
-
09:40 PM Feature #14982: Improve namespace system in ruby to avoiding top-level names chaos
- > As you can see, it is bundled twice. The problem is that although there should be one copy of Molinillo, there are two copies, which artificially differs in namespace, to avoid collision if there was Molinillo gem installed.
In that... -
- Not mentioning that Bundler bundles other libraries, such as net-http-persistent and Thor. It would make update of this libraries easier, e.g. they could be submodule in code base, because they would not need modified namespace.
-
- Eregon (Benoit Daloze) wrote:
> Or is there any hidden problem in there?
Yes, support of older RubyGems I suppose. -
08:35 PM Feature #14982: Improve namespace system in ruby to avoiding top-level names chaos
- IMHO, the case of Molinillo is the job of RubyGems/Bundler developers to solve: settle on one version, and reuse RubyGems' vendored copy for Bundler.
Or is there any hidden problem in there? -
- ciconia (Sharon Rosner) wrote:
> > Would you mind to show us, how it could help to improve situation with things like Molinillo bundled twice in Ruby, once in RubyGems, second time in Bundler?
> ...
Molinillo is not external dependency... -
08:51 PM Bug #15329 (Closed): Native implementation of coroutines - segfault
- Great, thanks for the report. Let me know if you have any other issues.
-
05:59 PM Bug #15329: Native implementation of coroutines - segfault
- good news! I can confirm it's fixed by https://github.com/ruby/ruby/commit/f33adbc11e0fa0a2bd73b96ee3a3529481eb111d . Thanks!
-
- Can you please try trunk now? This issue might be fixed.
-
08:42 PM Feature #15338: Provide way for C extensions to query if global variable is defined
- > https://bugs.ruby-lang.org/issues/15338
> Let's introduce third function `rb_gv_defined` to complement `rb_gv_get` and `rb_gv_set`.
> PS: At the moment I'm doing `if
> (RTEST(rb_eval_string("defined?($XX) && $XX"))) { ... }` bu... -
08:21 PM Feature #15338 (Open): Provide way for C extensions to query if global variable is defined
- As far as I can tell, there is no way for C extension to check if global variable is defined. I can `rb_gv_get`, but that produces warning when `$VERBOSE = true`.
Let's introduce third function `rb_gv_defined` to complement `rb_gv_get... -
- Greg.mpls@gmail.com wrote:
> Using `ruby 2.6.0dev (2018-11-24 trunk 65959) [x64-mingw32]`, applied the patch in msg 32, passed all tests.
Thanks, committed as r65962
> bootstraptest suite is back to mid 40's, it had jumped to m... -
- @normalperson Eric,
Using `ruby 2.6.0dev (2018-11-24 trunk 65959) [x64-mingw32]`, applied the patch in msg 32, passed all tests.
bootstraptest suite is back to mid 40's, it had jumped to mid to high 80's.
Thanks, Greg -
- @normalperson Eric,
> Do you have any more details on the slowdown (e.g. profiling info?)
I pointed it out thinking it might help with the issues. I concentrated more on determining what's failing in test-all.
> ...
(Same as r... -
- Greg.mpls@gmail.com wrote:
>
> @normalperson Eric,
>
> After a few more builds, the intermittent test failures seem to be:
> TestIO#test_readpartial_lock
r65948 might help with that one (does IO#nonblock= work for you?)
> ... - 07:59 PM Revision 608b9c29 (git): io.c: disable nonblocking-by-default on win32 pipes
- Lets admit Windows will always be too different from POSIX-like
platforms and non-blocking may never work as well or consistently.
[ruby-core:90042] [ruby-core:90044] [Bug #14968]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65962... - 07:54 PM Revision cc6020b7 (git): * 2018-11-25
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65961 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 07:54 PM Revision a5e91822 (git): * common.mk: revise r65767 because AIX's grep does not support -A
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65960 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- mame (Yusuke Endoh) wrote:
> Eregon (Benoit Daloze) wrote:
> ...
Because you'd want to list files whose name is actually "foo[bar]baz.txt"?
I see, makes sense.
My impression is everyone knows "glob'ing" and Dir.glob but very few kn... -
- Thx. I hope I'll be able to check it on Monday.
-
- I've merged the first set of changes into trunk, for amd64 - @vo.x if you confirm this has fixed the issue I will extend to other architectures.
-
- I'm attempting to fix this issue here: https://github.com/ruby/ruby/pull/2027
@vo.x do you mind trying to build that PR? -
- Thanks Eric. Those two suggestions are really helpful. I'll investigate it now.
-
- > https://bugs.ruby-lang.org/issues/15335#change-75132
samuel@oriontransfer.net wrote:
> How can we solve this problem?
Fedora can configure with --disable-fiber-coroutine option
as a stopgap...
> I.e. the coroutines assembly... -
- How can we solve this problem?
-
-
- mame (Yusuke Endoh) wrote:
> FYI: The reason why matz does not like the term "visibility", is because the method attribute is not a visibility. In fact, all methods are visible in Ruby. Instead, the method attribute restricts how and ... -
- FYI: The reason why matz does not like the term "visibility", is because the method attribute is not a visibility. In fact, all methods are visible in Ruby. Instead, the method attribute restricts how and where it can be called. We br...
-
- I think visibility is the perfect, accurate and unambiguous term for this (e.g., it's even used in the documentation of #private).
Returning the corresponding Symbol also seems very intuitive.
So take my vote as +1 for Method#visibil... -
- I don't think that `send("#{method.visibility}_instance_methods")` would be a frequent, strongly-recommended idiom. You can do it more explicitly as follows.
```
def visibility(method)
case
when method.public? then "public_... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65959 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65958 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 12:26 PM Revision 64148e66 (git): * expand tabs.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65957 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65956 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Once we have a fix for this bug, it should be backported to all the versions that implement \X and that we still support.
-
- Applied in changeset trunk|r65954.
----------
Don't use single byte optimization on grapheme clusters
Unicode Text Segmentation considers CRLF as a character. [Bug #15337] -
- The method `each_grapheme_cluster` on the `String` class wrongly splits CRLF into two clusters, as follows:
```
[duerst@stazersee ruby2]$ ./ruby -e 'puts "\r\n".each_grapheme_cluster.to_a.inspect'
["\r", "\n"]
[duerst@stazersee rub... -
- Add file test/ruby/enc/test_grapheme_breaks.rb to test String#each_grapheme_cluster
and \X extended grapheme cluster matcher in regular expressions against test data
provided by Unicode (ucd/auxiliary/GraphemeBreakTest.txt).
Some lines ... -
- Unicode Text Segmentation considers CRLF as a character. [Bug #15337]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65954 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 11:35 AM Revision f33adbc1 (git): Ensure stack is correctly protected
- See https://bugs.ruby-lang.org/issues/15335 for more details.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65953 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 11:35 AM Revision e64f71f8 (git): Change Makefile rule for assembly to use .S rather than .s
- It is more conventional to use compiler to pre-process and
assemble the `.S` file rather than forcing Makefile to use `.s`.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65952 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Use $(ASMEXT) instead of `.s` directly, as well as `.SUFFIXES:`
line.
Also, use the same suffix at compiling from `.c`. These are
different things traditionally, but we won't mix same name files
with `.c` and `.s`.
git-svn-id: svn+ssh... -
08:38 AM Feature #15144 (Closed): Enumerator#chain
- Applied in changeset trunk|r65949.
----------
Implement Enumerator#+ and Enumerable#chain [Feature #15144]
They return an Enumerator::Chain object which is a subclass of
Enumerator, which represents a chain of enumerables that works as... - 08:38 AM Revision 94ec8e0d (git): Add entries regarding Enumerator::Chain to NEWS
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65950 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 08:38 AM Revision 045b0e54 (git): Implement Enumerator#+ and Enumerable#chain [Feature #15144]
- They return an Enumerator::Chain object which is a subclass of
Enumerator, which represents a chain of enumerables that works as a
single enumerator.
```ruby
e = (1..3).chain([4, 5])
e.to_a #=> [1, 2, 3, 4, 5]
e = (1..3).each + [4, 5]
... - 08:23 AM Revision c0e20037 (git): io.c: wait on FD readability w/o GVL reacquisition
- Since non-blocking I/O is the default after [Bug #14968],
we will hit it more often and cause more acquisition/release
of GVL to wait on single FD.
This also lets us avoid touching the temporal string locking
as much and lets us clean u... -
08:21 AM Feature #15286: Proposal: Add Kernel.#expand(*args)
- OK, Thank you, matz :)
-
- The change itself is actually not intended.
But I'm unsure if it should handle ISeq-loaded code as a measuring target, because currently eval-loaded code is not a target:
```
require 'coverage'
Coverage.start
eval("puts 'hi'", bin... -
- Ah I see the problem with wide-char encodings now. There are some C APIs that write a codepoint-wide terminator at `arr[RSTRING_EMBED_LEN]`, which can clobber the hash memo.
I will benchmark to see if fetching the encoding struct is slo... -
- Add `clean-srcs` target to clean sources in the build directory,
and `realclean-srcs` target to clean autogenerated sources in the
source directory. Also `realclean-srcs-extra` target to clean
sources which are generatable but need to i... -
- Make platform independent header, ext/etc/constdefs.h, by `make
srcs-ext`.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65946 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 02:31 AM Revision 64591128 (git): Fix argument order.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65945 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 02:31 AM Revision 4b0a256e (git): Enable msys2 to check build status.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65944 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- [Fix GH-2022]
From: MSP-Greg <greg.mpls@gmail.com>
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65943 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
11/23/2018
-
- In common.mk, add the file GraphemeBreakeTests.txt to UNICODE_PROPERTY_FILES
to be downloaded. This will be used for automatic tests for /\X/ and
String#each_grapheme_cluster.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65942 b2dd... -
- stanhu (Stan Hu) wrote:
> We can close this bug report in favor of https://bugs.ruby-lang.org/issues/15105. I've confirmed applying the patch in https://bugs.ruby-lang.org/projects/ruby-trunk/repository/revisions/64800 has made the seg ... -
10:40 PM Bug #15325: Ruby 2.5.3 seg fault after find block returns
- We can close this bug report in favor of https://bugs.ruby-lang.org/issues/15105. I've confirmed applying the patch in https://bugs.ruby-lang.org/projects/ruby-trunk/repository/revisions/64800 has made the seg fault go away.
-
- Ok, I think this bug is caused by https://bugs.ruby-lang.org/issues/15105. We were using the binding_of_caller gem, which calls `rb_debug_inspector_open`. The seg fault doesn't happen if we omit that call.
-
- I've confirmed that r64800 makes the seg fault go away. I cherry-picked that commit on top of the 2.5.3 tag. Would love to see a backport to 2.5.4 for this.
-
- This bug also appears to cause a seg fault in certain situations with Ruby 2.5.3 but not with 2.4.5. We were using the binding_of_caller gem, which calls https://github.com/banister/debug_inspector/blob/7160c09906b383846a6e55671913c1ad55...
- 10:01 PM Revision 4f6e3029 (git): * expand tabs.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65941 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 10:01 PM Revision dab99d4e (git): thread.c (rb_wait_for_single_fd): do not miss IO#close notifications
- RUBY_VM_CHECK_INTS_BLOCKING may switch threads and cause `fd'
to be closed. So we must ensure we register the waiting_fd
before checking for interrupts.
This only affects the ppoll/poll-using implementation of
rb_wait_for_single_fd, as... - 09:38 PM Revision a6a7d988 (git): io.c (io_fd_check_closed): prioritize cross-thread "stream closed"
- This may fix failures from TestIO#test_recycled_fd_close because
interrupts may be missed due to TOCTOU in other places.
cf. http://ci.rvm.jp/results/trunk-nopara@silicon-docker/1475034
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk... -
- Yes, it's non-trivial to fix unfortunately.
I remember doing the same in TruffleRuby and saw many Rails tests fail IIRC.
Also, we got a bug report with a variant to avoid re-initialization:
https://github.com/oracle/truffleruby/issu... -
- jeremyevans0 (Jeremy Evans) wrote:
> autoload functionality is fairly easy to remove while remaining backwards compatible syntax-wise, just have autoload ignore the first argument and require the second. :)
In theory, but not in prac... -
06:28 PM Feature #15330: autoload_relative
- Rails plans to implement its reload feature that today is based on `const_missing` using [`autoload`](https://github.com/Shopify/autoload_reloader), so we would prefer if that feature would not be removed, and instead improved. Our exper...
-
06:15 PM Feature #15330: autoload_relative
- matz (Yukihiro Matsumoto) wrote:
> I do not like autoload for its indeterministic nature (#5653).
> ...
autoload functionality is fairly easy to remove while remaining backwards compatible syntax-wise, just have autoload ignore the fir... -
- matz (Yukihiro Matsumoto) wrote:
> I do not like autoload for its indeterministic nature (#5653).
> ...
It seems all of these 3 bugs are solved nowadays.
#5653 mentions "But autoload itself has fundamental flaw under multi-thread en... -
08:32 AM Feature #15330: autoload_relative
- I do not like autoload for its indeterministic nature (#5653).
It caused issues (#10892, #11384, #12688) and they are hard to solve.
But autoload is so widely used (especially in Rails), we couldn't have removed it.
So, even though ... -
- > Maybe, the last comparison should be `<=`, as the size of `ary` is `MEMO_HASH_LEN_MAX + 1`?
Yes! I was one byte too conservative.
> ...
I don't see why we need to special-case any encoding. `RSTRING_EMBED_LEN` gets the size in by... -
- ```c
#define CAN_MEMO_HASH(str) \
(RB_FL_TEST_RAW((str), RSTRING_NOEMBED | RUBY_FL_FREEZE) == RUBY_FL_FREEZE && RSTRING_EMBED_LEN(str) < MEMO_HASH_LEN_MAX)
```
Maybe, the last comparison should be `<=`, as the size of `ary` is ... -
- I like the idea!
Matz.
- 06:19 PM Revision 34f0e8ed (git): * 2018-11-24
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65938 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 06:19 PM Revision f9fcffed (git): io.c (fptr_finalize_flush): close race leading to EBADF
- The previous ordering was:
a) notify waiting_fd threads of impending close
b) waiting on busy list from a)
c) invalidate fptr->fd
d) calling close()
However, it was possible for a new thread to enter
the waiting_fd list while schedulin... -
- > Would you mind to show us, how it could help to improve situation with things like Molinillo bundled twice in Ruby, once in RubyGems, second time in Bundler?
This is not what Modulation is meant to solve. External dependencies (in t... -
- ciconia (Sharon Rosner) wrote:
> I'd like to show something I've been working on for the last few months. It's called Modulation
Wow, that sounds super useful. This is one of the few things I'd love to see included in StdLib.
Woul... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65936 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Sorry for late response. I was not able to build/test ruby for various other failures. But finally, I was able to build/test r65928 and it seems to pass the tests just fine. Thx for the fix.
-
- * proc.c: [DOC] refine proc-compistion examples by using same
Proc/Method and different composition orders.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65935 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65934 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
10:46 AM Feature #15301: Symbol#call, returning method bound with arguments
- @matz, but this is the whole point. Since introduction of `.call()` / `.()` synonyms, I looked for a good use for them, and this one looks almost perfect.
-
10:16 AM Feature #15302: Proc#with and Proc#by, for partial function application and currying
- matz (Yukihiro Matsumoto) wrote:
> I wonder those words do not cause confusion which works which way? At least I was confused.
I agree with your assessment Matz. Both 'with' and 'by' are such flexible words, they're the first words t... -
- When I did a commit today, I was checking https://travis-ci.org/ruby/ruby/builds to make sure there were no errors.
I noticed a few somewhat strange things:
```
trunk CRON prepare for Unicode 11.0.0 update
duerst #28798 passe... -
- For some while, we carry this test in Fedora package [1]:
~~~
checksec -f libruby.so.%{ruby_version} | \
grep "Full RELRO.*Canary found.*NX enabled.*DSO.*No RPATH.*No RUNPATH.*Yes.*\d*.*\d*.*libruby.so.%{ruby_version}"
~~~
Th... -
- When testing for upgrade to Unicode 11.0.0, I'm running into the following error:
```
$$ ./ruby test/runner.rb test/ruby/test_m17n.rb
Run options:
# Running tests:
[124/139] TestM17N#test_utf_16_32_inspect(UTF-16BE) 1 [ma... -
- - enc/unicode/case-folding.rb:
- Convert unpredicted case to actual flag setting
- Eliminate an unused variable
- Change a variable name to avoid a warning
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65933 b2dd03c8-39d4-4d8f... -
- @normalperson Eric,
After a few more builds, the intermittent test failures seem to be:
TestIO#test_readpartial_lock
TestIO#test_recycled_fd_close
These often fail during parallel, occasionally fail during retry.
I've noticed... -
- @normalperson Eric,
Well, Appveyor testing can be intermittent. After r65931, the following issues in ruby Appveyor CI:
```
mswqin vc140
1) Failure:
TestIO#test_readpartial_lock [C:/projects/ruby/test/ruby/test_io.rb:1366]:
... -
- Just for the record, the good news was at r65920. It may have started quite a bit before that, though.
-
- I created a patch for fixing this.
https://github.com/ruby/ruby/pull/2023
@nobu Can you review the above patch? -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65932 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
11/22/2018
-
11:56 PM Bug #15333 (Closed): make check fails looking for Bundler 2.0
- Just pulled the latest trunk from github. The log from "make check" seems to indicate a bundler 2.0 missing. Using bundler 1.17.1 installed by gem.
ruby -v: ruby 2.6.0dev (2018-11-23 trunk 65931) [x86_64-linux]
making mjit_build_dir... -
- With the current head:
```ruby
require 'coverage'
Coverage.start
RubyVM::InstructionSequence.compile("puts 'hi'", 'hello_world.rb').eval
Coverage.result # => {}, should be {'hello_world.rb' => [1]}
```
This is ... -
- > holiday where you are
Yes, but I'm more or less not afk now. JFYI, unless I'm 'pinged', I don't receive messages via email even if I 'watch' the thread, which is a change from a few months ago...
I just built from r65930, and it... -
- > > https://bugs.ruby-lang.org/issues/14968#change-75083
>
> Thanks for the reports, I'm trying r65929 to disable non-blocking-by-default
> on Win32. However, this change may expose existing bugs:
Greg: can you try reverting r65... -
- > https://bugs.ruby-lang.org/issues/14968#change-75083
Thanks for the reports, I'm trying r65929 to disable non-blocking-by-default
on Win32. However, this change may expose existing bugs:
> Also, some of the TestNetHTTPS tests ... -
- Further testing (net, openssl, & socket):
```
1) Error:
TestSocket#test_udp_recv_truncation:
Errno::EMSGSIZE: A message sent on a datagram socket was larger than the internal message buffer or some other network limit, or the buffe... -
- ruby-loco built r65909 green, and failed on r65922 and r65927.
Using the r65927 build locally, test_drb.rb freezes on various tests intermittently:
```
DRbTests::TestDRbAry#test_07_break_18
DRbTests::TestDRbCore#test_07_private_mis... -
- Well, at the same time you seem to have introduced a bug on Windows. As of r65925 on AppVeyor of both mswin and MinGW, MinGW hangs on test-all's test_drbssl, and mswin hangs on some test (it doesn't produce helpful logs).
You can't se... -
- Thanks, that's fixed now.
-
- takashikkbn@gmail.com wrote:
> r65922 made Travis x86_64-darwin build fail
> https://travis-ci.org/ruby/ruby/jobs/458319172. Could you take
> a look at it?
I assume below failure is all that is relevant, maybe r65925 fixes it.
... -
- r65922 made Travis x86_64-darwin build fail https://travis-ci.org/ruby/ruby/jobs/458319172. Could you take a look at it?
~~~
1) Failure:
TestSocket_BasicSocket#test_read_write_nonblock [/Users/travis/build/ruby/ruby/test/socket/te... -
- ko1@atdot.net wrote:
> Honestly speaking, we are not sure we can introduce it into
> Ruby 2.6 (incompatibility, stability and so on).
Understood, but all sockets in 1.8 relied on non-blocking I/O, too.
Most scalability problems ar... -
- Applied in changeset trunk|r65922.
----------
io + socket: make pipes and sockets nonblocking by default
All normal Ruby IO methods (IO#read, IO#gets, IO#write, ...) are
all capable of appearing to be "blocking" when presented with a
f... -
- Honestly speaking, we are not sure we can introduce it into Ruby 2.6 (incompatibility, stability and so on).
So please commit it and let's try it.
If we find troubles we can't solve, we may revert them.
Thanks,
Koichi
- 10:44 PM Revision 8a233ea6 (git): io.c: revalidate fptr->fd after rb_io_wait_readable
- fptr->fd may become -1 while GVL is released in
rb_wait_for_single_fd, so we must check it after reacquiring
GVL. This should avoid EBADF errors exposed by making pipes
non-blocking by default:
http://ci.rvm.jp/results/trunk-test@ruby-... -
- Interesting idea of partial evaluation, but `call` is too generic, and could cause confusion. I am not positive about the expression.
Matz.
-
- This kind of partial evaluation is an interesting idea, but as a non-native speaker, I wonder those words do not cause confusion which works which way? At least I was confused.
Matz.
-
- I am against the idea for some reasons:
* I don't think `expand` is the right name for the behavior
* meta-programming is too much for this half-baked substitute for #15236
Regarding #15236, we are waiting for the time when our re... -
- I vote for the proposed change. Let's give deprecation warning first. I don't think we need to remove `!~` from `Kernel`.
Matz.
-
- ## Background
It's common for applications to use string literals as hash keys, especially
for applications that work with YAML or JSON:
```
paylod['name']
```
At the moment (r65895), hash lookups using a string key is about ... - 08:02 PM Revision fc0a92ab (git): * 2018-11-23
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65930 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 08:02 PM Revision 0698c496 (git): socket: disable nonblocking-by-default on win32
- Perhaps this fixes test failures reported by Greg and k0kubun.
However, the failure of certain tests to handle non-blocking I/O
seems to indicate pre-existing problems on win32 platforms.
Somebody knowledgeable about win32 should be abl... -
05:51 PM Feature #11689: Add methods allow us to get visibility from Method and UnboundMethod object.
- I mean, as seen in yui-knk's example with `pry`, I think it's helpful to be able to essentially do `send("#{method.visibility}_instance_methods")`. I'm not picky on the name though if there is something better than visibility.
But I t... -
- The proposal sounds nice, but I am not fully satisfied with the term **visibility**. So how about adding `public?`, `private?` and `protected?` methods instead?
Matz.
-
- I noticed that the original patch doesn't compile with GCC.
-Werror=declaration-after-statement doesn't seem to have any effect on Clang: https://godbolt.org/z/8Qykk4 (switch to gcc to see it fail to compile. It compiles on Clang)
seem... -
- I'm mistaken. Windows 10 (Appveyor?) will process a plain '~'
The test should pass with:
```ruby
if windows?
assert_equal(File.expand_path("~"), Dir.home(user))
else
assert_equal(File.expa... -
- @naruse
Re r65926, I believe Windows has never processed '~'. Also, Window doesn't natively have ENV['USER'], but Ruby sets it. Regardless, the revised test fails...
Thanks, Greg -
- Applied in changeset trunk|r65926.
----------
Use File.expand_path("~username") instead of ENV["HOME"]
File.expand_path("~username") uses getpwnam() independently from
Dir.home. [Bug #15324]
From: Chris Seaton <chris@chrisseaton.com> -
03:40 PM Feature #13618: [PATCH] auto fiber schedule for rb_wait_for_single_fd and rb_waitpid
- normalperson (Eric Wong) wrote:
>
> ...
Nice! Now it works. Moreover, the example above was extracted from a bigger one example for a common web scenario: "dumb" http server which accepts clients requests to the queue in a native thr... -
- > > I've just tested this branch(`osx/kqueue`). It looks like
> > `sleep` does not work as expected(it blocks forever) inside
> > light thread if some blocking queue is used, see ex:
> I think you also need to join thread::Light to... -
- me@dmitry.it wrote:
> @normalperson thank you for your work!
You're welcome.
> I've just tested this branch(`osx/kqueue`). It looks like `sleep` does not work as expected(it blocks forever) inside light thread if some blocking qu... -
- @normalperson thank you for your work!
normalperson (Eric Wong) wrote:
> https://80x24.org/ruby.git thread-light-r65903
> ...
I've just tested this branch(`osx/kqueue`). It looks like `sleep` does not work as expected(it blocks f... -
03:11 PM Bug #15244: Method #extname return empty string if filename is dot ('.')
- Still present.
-
- I'd like to show something I've been working on for the last few months. It's called Modulation, a small (less than 300 LOC) gem providing an alternative way to manage dependencies in Ruby applications. Modulation provides complete isola...
-
- Thx, testing with r65928, I got past that point.
-
-
- like this http://ci.rvm.jp/results/trunk-mjit@silicon-docker/1471633
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65928 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- I'll let you know if I find something useful. Thanks
-
- I only experience crash with -O3, I think it's an alignment issue. I am going to look into it more tomorrow, right now I wouldn't spend too much time on this until I investigate alignment issues. Thanks for your continued reports and help.
-
- ```
rvm install ruby-head --disable-binary -- --enable-shared CC=clang
```
also tested with gcc-8 (Ubuntu 8.1.0-5ubuntu1~14.04) 8.1.0 - exactly the same error
passing -O0 debugflags=-ggdb3" makes no change
for comparsion
```
rvm... -
- Also, on gcc, can you please try:
```
./configure optflags="-O0" debugflags="-ggdb3" && mingw32-make
```
See if that still has crash when running tests. -
- Based on all the evidence, I think it's compiler bug.
Do you mind testing with clang? It will help to support this hypothesis if it doesn't crash and give me a better idea of what to check next. -
- You need to use debugger to get stack trace.
Here is an example of running it in GDB to get stack trace:
```
(gdb) run --disable-gems -I. -I../lib -I../test/lib ../test/ruby/test_enumerator.rb
Starting program: C:\msys64\home\sam... -
- the same error
```
./miniruby -I./lib -I. -I.ext/common ./tool/runruby.rb --extout=.ext -- --disable-gems -r./x86_64-linux-fake ./tool/rbinstall.rb --make="make" --dest-dir="" --extout=".ext" --mflags="" --make-flags="" --data-mode=0... -
- Native fiber implementation is all about speed and consistent interface across all supported platforms. It's good to hear there is speed improvement on WSL with native fiber. It also looks like it's a little bit faster than CreateFiber W...
-
- hmm, it has something to do with rvm...
I've tried to build trunk manually and it works
I double checked a few commits before
https://github.com/ruby/ruby/commit/07a324a0f6464f31765ee4bc5cfc23a99d426705
and there's no segfault if... -
- https://rubyci.org/logs/rubyci.s3.amazonaws.com/unstable11x/ruby-trunk/log/20181121T212405Z.diff.html.gz
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65927 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- File.expand_path("~username") uses getpwnam() independently from
Dir.home. [Bug #15324]
From: Chris Seaton <chris@chrisseaton.com>
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65926 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 10:13 AM Revision 0bd8193e (git): ext/socket/init.c (rsock_socket0): non-blocking for non-SOCK_NONBLOCK
- We need to make sockets non-blocking for systems without
SOCK_CLOEXEC/SOCK_NONBLOCK macros at all.
[ruby-core:89965] [Bug #14968]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65925 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Applied in changeset trunk|r65923.
----------
Revert r63030
* array.c (rb_ary_collect): no longer splat sole array for lambda.
[ruby-core:89734] [Bug #15285] - 09:18 AM Revision 31649a24 (git): * expand tabs.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65924 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * array.c (rb_ary_collect): no longer splat sole array for lambda.
[ruby-core:89734] [Bug #15285]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65923 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- What about making the replacement of sub/gsub optional? (`str.gsub(/re/, repl='')`)
`sub` here might be considered as short for "subtract". 😆 - 08:46 AM Revision 6a65f2b1 (git): io + socket: make pipes and sockets nonblocking by default
- All normal Ruby IO methods (IO#read, IO#gets, IO#write, ...) are
all capable of appearing to be "blocking" when presented with a
file description with the O_NONBLOCK flag set; so there is
little risk of incompatibility within Ruby-using ... - 08:46 AM Revision b009de13 (git): configure.ac: support 32-bit builds on x86-64 systems
- Because RAM is still expensive :<
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65921 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Applied in changeset trunk|r65920.
----------
Enable refinements at Object#respond_to?
[Feature #15327] [Fix GH-2020]
From: osyo-manga <manga.osyo@gmail.com> -
- `defined?(obj.method)` should work.
-
- [Feature #15327] [Fix GH-2020]
From: osyo-manga <manga.osyo@gmail.com>
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65920 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- キャッシュ化を無効化していない場合は `test_to_proc_arg_with_refinements_override` で落ちるはずです。
後ほどこちらでも確認してみます。 -
- キャッシュ化を無効にしなくてもテストは通るようですが、これはテストが意図したとおりになっていないということでしょうか。
-
- duerst (Martin Dürst) wrote:
> duerst (Martin Dürst) wrote:
> ...
`/\p{Grapheme_Cluster_Break=E_Modifier}/` is specially introduced for `/\X/`.
But the source of \X, Unicode Text Segmentation (https://unicode.org/reports/tr29/) but wh... -
- The opinions at the committer meeting were tending towards producing an error or a warning, because this would make it possible to find places that need to be rewritten to produce whatever may have been the desired result.
The discuss... -
- duerst (Martin Dürst) wrote:
> - Hiragana_or_Katakana is an old obsolete script property, which currently leads to an error with `'abc' =~ /\p{hiragara_or_katakana}/'`
A more recent example: `'abc' =~ /\p{Grapheme_Cluster_Break=E_M... -
- First, I have good news. This error doesn't occur anymore. I discovered this yesterday when I was preparing to apply your third patch, and today I was able to confirm that it also applies without any of the patches you sent, on trunk. I ...
-
- I got Matz's approval.
I'll implement it and commit soon before ruby 2.6 rc1.
Now, I finished most of features, except handling at exception.
-
- I got Matz's approval except naming "loaded" because the name "loaded" can be after `require/load`. This proposal is just after compiling (iseq genration) and just before running loading code.
Other possibility:
* `iseq_generated` (i... -
- Applied in changeset trunk|r65919.
----------
Enable refinements to public_send.
[Feature #15326] [Fix GH-2019]
From: manga_osyo <manga.osyo@gmail.com> -
- [Feature #15326] [Fix GH-2019]
From: manga_osyo <manga.osyo@gmail.com>
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65919 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- We got Matz's approval for adding Enumerable#chain (instead of Enumerator#chain) and Enumerator#+.
-
- Applied in changeset trunk|r65918.
----------
mjit_archflag.sh: fix bare word in the header
[ruby-dev:50674] [Bug #15319] -
- [ruby-dev:50674] [Bug #15319]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65918 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65917 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65916 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- and exclude under coroutine only.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65915 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- How about checking owner object?
```diff
diff --git a/lib/monitor.rb b/lib/monitor.rb
index 288ed755ea..1a17e9bc7d 100644
--- a/lib/monitor.rb
+++ b/lib/monitor.rb
@@ -251,9 +251,13 @@ def initialize(*args)
# Initializes the ... -
- Applied in changeset trunk|r65911.
----------
proc.c: Implement Proc#* for Proc composition
* proc.c (proc_compose): Implement Proc#* for Proc composition, enabling
composition of Procs and Methods. [Feature #6284]
* test/ruby/test_... -
- [Feature #6284]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65914 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * proc.c (proc_compose): support any object with a call method rather
than supporting only procs. [Feature #6284]
* proc.c (compose): use the function call on the given object rather
than rb_proc_call_with_block in order to support ... -
- * proc.c (rb_method_compose): Implement Method#* for Method composition,
which delegates to Proc#*.
* test/ruby/test_method.rb: Add test cases for Method composition.
From: Paul Mucur <mudge@mudge.name>
git-svn-id: svn+ssh://ci.ruby... -
- * proc.c (proc_compose): Implement Proc#* for Proc composition, enabling
composition of Procs and Methods. [Feature #6284]
* test/ruby/test_proc.rb: Add test cases for Proc composition.
From: Paul Mucur <mudge@mudge.name>
git-svn-id... -
- I do not have much to add to autoload_relative as such, although I would like to
mention that, similar to require_relative, the shorter variants are easier to
write - e. g. "require 'path'" versus "require_relative 'path'"; similar to... -
- You can commit it but ", default is 9 digits " should also be removed.
-
- The comment has been already removed.
-
- Closing. Please reopen if anyone could reproduce the bug.
-
- This reverts commit d12bcfc186f2aea5e83f2f59716958ea12b5c937.
pause on --jit-wait looks not working... I'll fix that first.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65910 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 02:17 AM Revision 38f7bb48 (git): Use VirtualAlloc/VirtualProtect/VirtualFree for windows stack allocation.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65909 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * [Bug #6087] How should inherited methods deal with return values of their own subclass?
* 6 years ago, matz decided that `class A < Array; end; A.new.flatten.class #=> A in 2.X, Array in 3.0`. Just confirm: has the decision been st... -
12:46 AM Misc #15007: Let all Init_xxx and extension APIs frequently called from init code paths be considered cold
- ko1 (Koichi Sasada) wrote:
> > Does that seem reasonable as a unit of work to you?
> ...
I added some investigation and conclusions with gcc and clang to the reduced scope PR https://github.com/ruby/ruby/pull/2005 -
- In a GC language, it's impossible to ensure this, unless you want the GC to invoke some functionality.
I suggest adding something like `Fiber#stop` which causes internally `Fiber#resume` to raise exception.
It should be up to user ...
11/21/2018
-
- Yes if the return events can fire as usual even when tail calls happen it would be perfect and would fix #15303.
I don't see a way to fire the return events in the normal order without extra allocations, though. Maybe it's possible?
... -
- fix #15303 (invoke return event) doesn't solve it?
BTW, if you provide an API, sample code will help us to understand.
-
- * [Feature #15330] Proposal: autoload_relative (marcandre)
* This feature is actually more useful than `autoload` and should be added to 2.6 -
- * [Feature #15327] Proposal: Enable refinements to `#respond_to?`
* [Feature #15326] Proposal: Enable refinements to `#public_send`
* [Feature #15114] Symbol#to_proc does not work with refinements?
* I want to more refinements!
-
- * [Feature #10548] remove callcc (Callcc is now going obsoleted. Please use Fiber.) (ioquatix)
* It's unofficially deprecated, unsupported in most implementations of Ruby, and not used very much. Do you think it's a good idea to drop ... -
- I'd like to propose a way to autoload a constant using a relative path.
It could look like:
```
autoload_relative :MyConst, 'models/my_const'
```
My proposal raises two questions:
1) what's the future of `autoload`?
I be... -
- This ticket was duplicated by ##10075, and that ticket has been already closed with documentation improvement. So I'm closing this.
- 10:44 PM Revision e7d919d2 (git): * configure.ac: On AIX, LDFLAGS must be after -L../.. in TRY_LINK,
- not to refer to a system-installed libruby-static.a
when configuring the ext libraries
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65908 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Interesting, I did some research about WSL, apparently it can run unmodified binaries from Linux.
I checked the configure log and it says
```
checking native coroutine implementation for x86_64-linux... amd64
```
Do you mind ... -
- Sure, could you give me a hint how to get it? Unfortunatelly it isn't present in any of standard build logs...
-
- I need stack trace can you please try to get it for me?
-
- Hi, after https://github.com/ruby/ruby/commit/07a324a0f6464f31765ee4bc5cfc23a99d426705 issue #14739 was merged I'm getting a segfault
uname -a (WSL)
```
Linux DESKTOP-2POPPQP 4.4.0-17134-Microsoft #345-Microsoft Wed Sep 19 17:47:00 ... -
- Since this may be discussed in the next upcoming developer meeting, perhaps
callcc could be put into a standalone gem, if it is removed? Just in the event
that some people may want to keep it, could install it if they want to (a bit
l... - 08:39 PM Revision 7028d5b0 (git): * 2018-11-22
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65907 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 08:39 PM Revision 33853957 (git): errno.h must be included after config.h because config.h might define
- _REENTRANT, _THREAD_SAFE, etc., which affect how errno is defined
on some architectures
* ext/openssl/ossl.h: include errno.h after ruby.h
* include/ruby/io.h: include errno.h after ruby/config.h
git-svn-id: svn+ssh://ci.ruby-lang.org... -
- njti_worker.c fails to build with r65905:
~~~
---
... snip ...
Configuration summary for ruby version 2.6.0
* Installation prefix: /usr
* exec prefix: /usr
* arch: x86_64-linux
* site arch... -
04:44 PM Bug #15319 (Open): Since r65735, tool/mjit_archflag.sh related error on Solaris 10
- r65902にて、シェルのエラーは出なくなったのですが、mjit_worker.cのコンパイルエラーは出続けています。
~~~
gcc -O -m64 -D_FORTIFY_SOURCE=2 -fstack-protector -fno-strict-overflow -DRUBY_DEVEL=1 -fvisibility=hidden -fexcess-precision=standard -DRUBY_EXPORT -fPIE -DCANONICALIZAT... -
- Applied in changeset trunk|r65902.
----------
Makefile.in: get rid of `local` for Solaris sh
[ruby-dev:50673] [Bug #15319] -
- Makefile.inの呼び出し側で `indent=$${archs:+' '} define_arch_flags` と渡すのはどうでしょうか。
-
- r65808 の修正後、別のエラーになりました。（r65894で確認）
抜粋すると、bash等のローカル変数作成用の予約語 `local` がSolarisの/bin/shでは普通のコマンド扱いされています。
~~~
+ local indent=
/bin/sh: local: not found
~~~
tool/mjit_archflag.sh の以下の行が原因と思われます。
~~~
define_arch_flags() {
... -
- Something is quite odd. I tried a number of variations:
1. `break build` appears to work with Ruby 2.4.5 and 2.5.3.
1. Instead of `break build`, use `true`: In Ruby 2.5.3, this by itself seems to cause selection to be nil. I got a se... -
- Thanks nobu :)
> Interesting feature, but I don't think the name Kernel#expand is acceptable.
Yes, I looking for a more good name.
Are there any good names?
> ...
Yes..., but `binding.expand(:a, :b, :c)` is long...
`Kernel.#ex... -
- Refinements are enabled with various contexts and methods.
* `#send`
* `#__send__`
* Symbol#to_proc
* `#to_s`
* called by `"#{hoge}"`
* `#to_proc`
* call to `&:hoge`
* since ruby 2.6
I want to enable refinements for ... -
- Sometimes we use `#public_send` rather than` #send` to avoid calling the `private` method.
```ruby
def meth(a)
# Not call private method
# Use #public_send
a.public_send(a.name)
end
```
However, `#send` support to refin... -
- because we can't configure timeout for remote fetcher.
We've sometimes hit timeout.
https://app.wercker.com/ruby/ruby/runs/mjit-test2/5bf5213c183106002857d355?step=5bf530de63e94600071b0785
https://app.wercker.com/ruby/ruby/runs/mjit-tes... -
- > But I think this is a good change to maintain compatibility
> and avoid inadvertant switching:
Updated patch on top of 2/2 to disable switching properly
with Mutex locked:
https://80x24.org/spew/20181121095520.v4ddgpn6lufbvuvt@w... -
- * Enable Style/MethodDefParentheses in Rubocop
https://github.com/rubygems/rubygems/pull/2478
* Enable Style/MultilineIfThen in Rubocop
https://github.com/rubygems/rubygems/pull/2479
* Fix required_ruby_version with prereleas... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65903 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- [ruby-dev:50673] [Bug #15319]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65902 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65901 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- It seems that decades ago, ruby was written under assumption that
char is unsigned. Which is of course a false assumption. We
need to explicitly store a numeric value into an unsigned char
variable to tell we expect 0..255 value.
git... -
- knu (Akinori MUSHA) wrote:
> - The constructor is currently `Enumerator::Chain.new(*enums)` but it should probably be `Enumerator::Chain.new(enums)` to make it extensible to take an enumerable in general, with `itertools.chain.from_iter... -
- I've written an initial implementation as attached:
- `Enumerator.chain(*enums)` to generate an enumerator chain of `enums`
- `Enumerator#+(other)` to generate an enumerator chain of `[self, other]`
- `Enumerator#chain(*others)` to ... -
- It looks already fixed. I'm unsure if this behavior is guaranteed, though. Whether it is guaranteed or not, I think we can close this issue.
-
- * configure.ac: add --disable-fiber-coroutine option, and disable
it on x86-mingw32 for now.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65899 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65898 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
11/20/2018
-
- Note that I've managed to remove the `return` statement inside the `find` block, and this appears to make the seg fault go away.
~~~diff
diff --git a/app/services/ci/register_job_service.rb b/app/services/ci/register_job_service.rb
... -
- In https://gitlab.com/gitlab-org/gitlab-ce/blob/233af8f1731734aaad7e5055af39f26c16608649/app/services/ci/register_job_service.rb#L48, we see a repeatable seg fault on both MacOS and Ubuntu with Rails 5.0.7 in a development environment. T...
-
- If there's no dwarf and symbol table, this will be a last resort.
(mainly on macOS)
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65897 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65896 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- I see that this will probably be discussed in the upcoming developer meeting.
I have no particular pro or con to add to any of the functionality, yet alone
internal code-side of it, but I would like to point out that any API decision... -
- Koichi Sasada <ko1@atdot.net> wrote:
> On 2018/11/20 17:44, Eric Wong wrote:
> ...
I'm not sure how deadlock detection would work, and I don't
think there is data race there.
Main synchronization should be Queue/SizedQueue (like "m... -
- On 2018/11/20 17:44, Eric Wong wrote:
> Mutex and ConditionVariable are NOT scheduling points for
> Thread::Light switching; however they may process signal
> handling and handle I/O dispatch for other native threads.
Why not?
Ho... -
- > https://bugs.ruby-lang.org/issues/13618
Updated pull request against r65832 with new name: "Thread::Light"
The following changes since commit 8d9a9aab67d6d517995532737a37379c20dc7f76:
thread_pthread.c (rb_reserved_fd_p): fals... - 08:09 PM Revision 26adef94 (git): Fix indentation.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65895 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- I think the functionality, that is to combine .filter (be it select
or reject, is secondary to me), and .map, could be useful. I don't
really need it myself but I find it is not entirely out of the question
that others may find it use... -
02:29 PM Feature #15323: [PATCH] Proposal: Add Enumerable#filter_map
- Could't we use reduce for this?
~~~ ruby
(1..10).reduce([]) { |a, i| i.even? ? a << (i * 2) : a }
~~~
-
11:59 AM Feature #15323 (Closed): [PATCH] Proposal: Add Enumerable#filter_map
- This is a proposal for a combined `filter` + `map` method (https://bugs.ruby-lang.org/issues/5663).
This method both filters and maps the elements of an enumerable in just one iteration:
~~~ ruby
(1..10).filter_map { |i| i * 2 if ... -
04:10 PM Bug #15324 (Closed): Dir.home test doesn't match actual Ruby or system behaviour
- This test currently asserts that `Dir.home(user)` should return ENV['HOME'] if user is the current user.
We don't think this is correct - `Dir.home(user)` uses the expanded value of `~user`, which explictly uses the login database, an... -
04:09 PM Feature #11266: [PATCH] WEBrick: allow subclassing of Response and Request
- It has been... a very long time. Nobu, is there something else I can do?
- 03:46 PM Revision 9423a752 (git): * 2018-11-21
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65894 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Let me silence this until I have time to work on them, and make the CI
usable for testing other features.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65893 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- because it had already been SEGV-ed in pull request'S CI
https://ci.appveyor.com/project/ruby/ruby/builds/20427065/job/32oahrcd58b8ubb1
and has never worked on trunk either.
Please make sure it does not SEGVs on your MinGW environment o... -
- https://ci.appveyor.com/project/ruby/ruby/builds/20432223/job/yhwbku8dg2s40e9e
C:/projects/ruby/test/lib/test/unit.rb:1004: warning: undefining `object_id' may cause serious problems
C:/projects/ruby/test/lib/test/unit.rb:1004: warning: ... - 01:39 PM Revision 3bbc2abc (git): * properties.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65890 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- because it SEGVs on setup like:
https://ci.appveyor.com/project/ruby/ruby/builds/20431217/job/97no5h1gqv50k1vf
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65889 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- test on MinGW.
https://ci.appveyor.com/project/ruby/ruby/builds/20427662/job/tnnw50opqtj6x0xq
https://ci.appveyor.com/project/ruby/ruby/builds/20429129/job/dpgbx5atkxjiwh7q
To investigate issues, let's try running this without -j.
git-... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65887 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65886 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
11:59 AM Bug #15304: Package build with extensions is not reproducible
- I created the PR https://github.com/rubygems/rubygems/pull/2481 to address these issues.
-
- By the default of GNU make, .S is used to be compiled with CC, but
we have already used .s as ia64.s, and now coroutine/*/Context.s.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65885 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- by r65880
https://travis-ci.org/ruby/ruby/jobs/457384539
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65884 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- This is hoped to fix the SEGV:
https://app.wercker.com/ruby/ruby/runs/mjit-test1/5bf392cf183106002856c1f0?step=5bf3bddc87436a0006292535
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65883 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- FIBER_USE_NATIVE is always defined as 0 or 1, use `#if` instead of
`#ifdef`.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65882 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65881 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * common.mk (coroutine/amd64/Context.$(OBJEXT)): fix a typo,
$(OBJECT).
* common.mk (coroutine/amd64): recipe to make object directory.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65880 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Some pointers obtained from an Unicode-internal discussion:
- All (including past) property values are available from the Relax NG schema for UCD in XML at http://www.unicode.org/reports/tr42/tr42-23.rnc, linked off https://www.unicod... - 10:18 AM Revision 3ccb5b97 (git): Support Visual C++ (mswin)
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65879 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 10:18 AM Revision 1fa02b8d (git): Fix windows builds.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65878 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 10:18 AM Revision 638be684 (git): * properties.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65877 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 10:18 AM Revision 495dffba (git): GAS style assembly for win64 (mingw).
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65876 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 10:18 AM Revision 5e8a1dad (git): Expose stack functions to coroutine and non-windows implementations.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65875 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 10:18 AM Revision c5d3b83a (git): Fix exposure of stack allocations.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65874 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 10:18 AM Revision 8b1b056e (git): Use malloc/free for windows stack allocation.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65873 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 10:18 AM Revision 0ba0ad8b (git): Fix struct usage.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65872 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 10:17 AM Revision 972cc2d5 (git): Fix message result.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65871 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 10:17 AM Revision 76c6b6d1 (git): Fix configure.ac typo.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65870 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 10:17 AM Revision 49e92085 (git): Fix line endings.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65869 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 10:17 AM Revision 0b5e1442 (git): Initial support for x64-mingw32
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65868 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 10:17 AM Revision d97c9280 (git): Better (?) support for Windows TIB.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65867 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 10:17 AM Revision 904af4ae (git): Be even more specific, for some reason it was selecting amd64 on x64-mingw32.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65866 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 10:17 AM Revision 43d7fd09 (git): Limit coroutine implementations to Linux.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65865 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 10:17 AM Revision 98e26e96 (git): Tidy up assembly make rule.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65864 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 10:17 AM Revision a2cd16e5 (git): Expose dependency between cont.c and coroutine implementation.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65863 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 10:17 AM Revision cdb8f3f9 (git): * expand tabs.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65862 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 10:17 AM Revision ae3c8c20 (git): Prefer "static inline" to avoid duplicate symbols.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65861 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 10:17 AM Revision a3de4a09 (git): Remove trailing whitespace.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65860 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 10:17 AM Revision 5547c65b (git): Rename fiber chain benchmark.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65859 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 10:17 AM Revision a8848860 (git): Restore native non-coroutine code path.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65858 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 10:17 AM Revision 83c84182 (git): Formatting changes.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65857 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 10:16 AM Revision 9481461c (git): Ensure start function has correct declaration.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65856 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 10:16 AM Revision 42575570 (git): Try using compiler for assembling.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65855 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 10:16 AM Revision 11b672f3 (git): Print out what the assembler is doing to figure out why it's not working.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65854 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 10:16 AM Revision 99346f74 (git): Mark COROUTINE as noreturn.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65853 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 10:16 AM Revision b58dc42a (git): * remove trailing spaces.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65852 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 10:16 AM Revision 20f1c6c1 (git): Remove `Benchmark` times.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65851 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 10:16 AM Revision 3710dedc (git): Tidy up comments.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65850 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 10:14 AM Revision dba6b87b (git): * properties.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65849 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 10:14 AM Revision d4a58838 (git): * expand tabs.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65848 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 10:13 AM Revision 3e9beaf7 (git): Initial effort to support 32-bit Linux.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65847 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 10:13 AM Revision ff86d1b6 (git): It cannot be const because it is being passed to destructive operation (destroy).
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65846 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 10:13 AM Revision 9a324cf9 (git): Better benchmark name.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65845 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 10:09 AM Revision 3f0ae691 (git): * remove trailing spaces.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65844 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 10:09 AM Revision 12ae8c08 (git): Fix broken benchmark
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65843 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 10:06 AM Revision 635dd340 (git): * remove trailing spaces.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65842 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 10:06 AM Revision 995f6ee1 (git): Fix code climate cognitive complexity issue
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65841 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 10:06 AM Revision 4aa44a76 (git): Create output directory when assembling file
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65840 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 09:59 AM Revision ec0d3ba1 (git): Restore return value assignment
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65839 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 09:59 AM Revision dc049ad8 (git): * properties.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65838 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 09:59 AM Revision acd84d32 (git): * remove trailing spaces.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65837 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 09:59 AM Revision 748c497a (git): Rewrite fiber benchmark
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65836 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 09:59 AM Revision 990ddcfc (git): Better support for amd64 platforms
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65835 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 09:59 AM Revision 07a324a0 (git): Native implementation of coroutines to improve performance of fibers
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65834 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- takashikkbn@gmail.com wrote:
> > 1) will remain dangerous
>
> Is this about Bug #15316?
Partially, yes (sorry, just (mostly) wrapped up Thread::Light
for review on Linux and unlikely to be online much due to
family stuff. -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65833 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * [Bug #15285] lambda return behavior regression from #14639
-
- > https://bugs.ruby-lang.org/issues/15229
[Feature #13618] Thread::Light for 2.6 [ruby-core:89900] -
08:12 AM Bug #15322 (Closed): Time.strptime does not support %3N, %6N, %9N
- ~~~
Time.strptime("2018-11-20 17:11:22.123", "%Y-%m-%d %H:%M:%S.%3N")
# => raise ArgumentError: invalid strptime format - `%Y-%m-%d %H:%M:%S.%3N'
Time.strptime("2018-11-20 17:11:22.123456", "%Y-%m-%d %H:%M:%S.%6N")
# => raise Argumen... -
- The announcement for the draft list of emoji candidates is at http://blog.unicode.org/2018/10/draft-candidates-for-emoji-120-beta.html.
-
- The beta announcement is at http://unicode.org/versions/beta-12.0.0.html, the draft summary is at http://unicode.org/versions/Unicode12.0.0/. A blog entry is at http://blog.unicode.org/2018/11/unicode-120-beta-review.html.
A draft li... -
- Unicode Version 12.0.0 will be published in 2019, earlier than Unicode 11.0.0 in 2018. This is an issue to manage updating Ruby to Unicode 12.0.0. Details to follow.
The target version may be Ruby 2.6.1 or 2.7. - 07:27 AM Revision 8d9a9aab (git): thread_pthread.c (rb_reserved_fd_p): false-positive on negative FD
- Negative-numbered FDs are never valid FDs on POSIX-like
platforms, and we initialize our self-pipes/eventfd values
to "-1", so stop treating -1 as a reserved FD if our system
is too low on resources to allocate FDs at startup.
git-svn-i... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65831 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65830 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 05:18 AM Revision 34f3f916 (git): Simply treat IO::WaitReadable just like Errno::EAGAIN
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65829 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
05:14 AM Feature #15151: String#slice!(0,..) creates a duplicate of original string
- ping @nobu
-
- Here, recv can be INT2FIX(-1), which is 0xFFFF_FFFFul.
INT2FIX(1) is 3ul. So `recv - 1 + INT2FIX(1)` is:
recv 0xFFFF_FFFFul
recv-1 0xFFFF_FFFEul (note: unsigned)
recv-1+INT2FIX(1) 0x0000_0001ul Here is the overf... -
- Reverted r65822 because mon_initialize_spec.rb fails:
```
1)
MonitorMixin#mon_initialize can be called in initialize_copy to get a new M
utex and used with synchronize ERROR
ThreadError: already initialized
/home/... -
- Applied in changeset trunk|r65822.
----------
lib/monitor.rb: prevent to initialize MonitorMixin twice
Suggested by Benoit Daloze. [ruby-core:88504] [Feature #15000] -
- Because mon_initialized may be used to re-initialize copied objects intentionally.
mon_initialize_spec.rb fails:
1)
MonitorMixin#mon_initialize can be called in initialize_copy to get a new Mutex and used with synchronize ERROR
ThreadE... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65826 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65825 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65824 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 03:01 AM Revision 9ba7aece (git): * properties.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65823 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Suggested by Benoit Daloze. [ruby-core:88504] [Feature #15000]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65822 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- From: MSP-Greg <greg.mpls@gmail.com>
https://github.com/ruby/ruby/commit/5187ea768f57315e61486122d688f1992d4cb21f
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65821 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- normalperson (Eric Wong) wrote:
> "Socket.tcp" been part of the public Ruby API for around 10 years
> ...
Agreed.
@sock is a private API and Socket is recommended over TCPSocket, so I wouldn't like to
revert the change.
-
- msys2.
https://ci.appveyor.com/project/ruby/ruby/builds/20419607/job/fuvrfcmrhxr1r1cr
https://ci.appveyor.com/project/ruby/ruby/builds/20395349/job/2nqewb06b5eanwea
https://ci.appveyor.com/project/ruby/ruby/builds/20382452/job/658pvl1cq... -
- > If you can't solve it, can you wait until after the 11/22 developers meeting?
As tracked in [Bug #15320], I succeeded to fix it in r 65817. So, please never mind about that.
http://ci.rvm.jp/results/trunk-mjit-wait@silicon-docker/1... -
- @normalperson Eric,
> would introduce no portability problems or performance overhead if I'm wrong...
> ...
No idea about performance, but MinGW built & tested fine.
ruby 2.6.0dev (2018-11-20 trunk 65818) [x64-mingw32] -
- Instead of r65815, please try the latest trunk (r65819).
-
- * configure.ac: Check if CFLAGS actually includes -fcf-protection
instead of checking if the flag is valid by RUBY_TRY_CFLAGS.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65819 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65818 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Applied in changeset trunk|r65817.
----------
process.c: do not try to pause MJIT
while child handler is disabled.
trying to fix [Bug #15320] -
- while child handler is disabled.
trying to fix [Bug #15320]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65817 b2dd03c8-39d4-4d8f-98ff-823fe69b080e