Activity
From 09/23/2018 to 09/29/2018
09/29/2018
-
05:49 PM Revision ef69efef (git): no-op if it is T_STRING
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64887 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 05:49 PM Revision 47a02bff (git): * 2018-09-30
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64886 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 05:49 PM Revision 19e6af9f (git): * expand tabs.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64885 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
05:49 PM Revision 7bcc535a (git): Remove unnecessary use of function pointer
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64884 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
03:54 PM Bug #14807: 2.6.0-preview2 segfaults on OpenBSD due to missing pthread_condattr_init call
- Hi,
Wheather `PTHREAD_COND_INITIALIZER` is work on OpenBSD or not, it should be used for initialize `pthread_cond_t` variable and
it should not be used for initialize `pthread_condattr_t` variable since they are diffrernet type and i... -
03:43 PM Bug #15178 (Closed): Wrong paramaters passing to pthread_setname_np(3)
- Ruby 2.6.0-preview2の動作を調べている途中で見つけました。
[Bug #9586]の修正r45713で、NetBSDの場合のpthread_setname_np(3)の引数を修正しています。
ここは第2引数と第3引数を入れ替えるのではなく、単に二重引用符を適切にquoteするだけとすべき
だったのではないでしょうか。
また、実際にthread_pthread.cで`SET_CURRENT_THREAD_NAME`を介してpthread_... -
02:14 PM Feature #11815: Proposal for method `Array#difference`
- I could use this method for fixing this bug [1] in ActiveRecord.
To me it looks like a valuable addition.
It's about replacing collection associations which can be partially persisted, with persisted records being handled differen... -
11:12 AM Bug #15177 (Closed): 起動した後にTZを変更するとTime#utcがずれることがある
- 起動時に `TZ` を `right/Asia/Tokyo` にしていると `Time#utc` でローカルタイムと同じ時分秒になりますが、 `TZ=Asia/Tokyo` で起動してから `ENV['TZ']='right/Asia/Tokyo'` で変更すると `Time#utc` の結果がうるう秒のぶんだけずれます。
```
$ TZ=Asia/Tokyo ruby -ve "ENV['TZ']='right/Asia/Tokyo';t=Time.at(2... -
07:21 AM Revision fe0818c4 (git): common.mk: upgrade benchmark_driver
- since maybe r64870 implicitly depends on
https://github.com/benchmark-driver/benchmark-driver/pull/47 too.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64883 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
07:04 AM Revision a0ff2a6a (git): Expand gemspec path to the real path
- `make install` has loaded forwardable.rb twice, from
forwardable.gemspec and prime.gemspec.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64882 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
06:47 AM Bug #15162 (Closed): Encoding::Converter.search_convpath(Encoding::ASCII_8BIT, Encoding::Emacs_Mule) crashes on MinGW - Applied in changeset trunk|r64879.
----------
transcode.c: add GC guard on raise
* transcode.c (econv_s_search_convpath): add GC guard to fix SEGV
on raise.
[Bug #15162] [ruby-core:89172] -
06:46 AM Bug #15162: Encoding::Converter.search_convpath(Encoding::ASCII_8BIT, Encoding::Emacs_Mule) crashes on MinGW
- Thank you for test.
This issue seems to be related to #12411 fix. - 06:47 AM Revision b8c23ce3 (git): * expand tabs.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64881 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
06:47 AM Revision 29b2ea6b (git): Revert search_convpath spec
- Remove .name since SEGV on MinGW is fixed.
[ruby-core:89200]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64880 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
06:47 AM Revision b965781e (git): transcode.c: add GC guard on raise
- * transcode.c (econv_s_search_convpath): add GC guard to fix SEGV
on raise.
[Bug #15162] [ruby-core:89172]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64879 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
12:45 AM Bug #15175 (Closed): Segfault (Invalid read of size 4) in rb_bigzero_p
- Applied in changeset trunk|r64877.
----------
rational.c: may be float
* rational.c (f_muldiv): Integer#** can return Rational with Float
right now. [ruby-core:89212] [Bug #15175] - 12:45 AM Revision 4add701a (git): * expand tabs.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64878 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
12:45 AM Revision 36c4713e (git): rational.c: may be float
- * rational.c (f_muldiv): Integer#** can return Rational with Float
right now. [ruby-core:89212] [Bug #15175]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64877 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 12:43 AM Revision c655db52 (git): * 2018-09-29
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64876 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
12:43 AM Revision 85aee954 (git): Split assertion expressions
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64875 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
09/28/2018
-
10:56 PM Bug #15175 (Closed): Segfault (Invalid read of size 4) in rb_bigzero_p
- My build is built with jemalloc, but the crash also happens without.
Note: this error only happens when ruby is run with --disable=gems. I'm unsure why.
Reproducer:
~~~
jtruba@sf201:~/rubies/ruby-trunk-clean$ cat poc
V = 1118111... -
10:45 PM Bug #15174 (Rejected): Sorting array of elements using "&:size" block, in which more than 1 element
- An expected behavior.
-
10:25 PM Bug #15174: Sorting array of elements using "&:size" block, in which more than 1 element
- You want `sort_by`, not `sort`:
~~~ ruby
[1..2, 4..5].sort_by(&:size)
# => [1..2, 4..5]
~~~
The difference in behavior between `{ |x| x.size }` and `(&:size)` is due to how ruby handles `Symbol#to_proc` when multiple arguments a... -
09:30 PM Bug #15174 (Rejected): Sorting array of elements using "&:size" block, in which more than 1 element
- Example with ranges(first with what defined bug), but also tested on strings, symbols, integers
Good
~~~ ruby
[1..2].sort { |x| x.size }
[1..2, 4..5].sort { |x| x.size }
[1..2].sort(&:size)
~~~
Bad
~~~ ruby
[1..2, 4..5].sort... -
06:04 PM Misc #15129: DevelopersMeeting20181010Japan
- * [Feature #15144] `Enumerator#chain`
-
12:50 PM Bug #15173: Segmentation fault
- When I replace this:
~~~ ruby
16 return [] unless s3.file_exists?(date, region_dirname)
17 CSV.parse(s3.contents(date, region_dirname)).drop(1).map do |value|
18 with_date = value.push(date.to_s)
... -
08:05 AM Bug #15173 (Closed): Segmentation fault
- Here is the code I'm trying to run:
~~~ ruby
6 def self.sync(db, s3, from, to)
7 db.create_table(SQL::Schema.table(TABLE_NAME))
8 from = Date.parse(from)
9 to = Date.parse(to)
10 keys = SQL::Sch... -
09:23 AM Revision a9375ab3 (git): Adjust indent [ci skip]
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64874 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
09:16 AM Bug #15162: Encoding::Converter.search_convpath(Encoding::ASCII_8BIT, Encoding::Emacs_Mule) crashes on MinGW
- MSP-Greg (Greg L) wrote:
> Benoit - I can't seem to ping you using either @eregon or @Eregon
Odd, not sure why it doesn't work.
-
12:43 AM Bug #15162: Encoding::Converter.search_convpath(Encoding::ASCII_8BIT, Encoding::Emacs_Mule) crashes on MinGW
- @hsbt & @h.shirosaki
I apologize for that mistake. I hope to not make it again.
We have a saying something like 'foot in mouth' referring to speech. I'm not sure what the equivalent is for written... Thanks, Greg -
12:24 AM Bug #15162: Encoding::Converter.search_convpath(Encoding::ASCII_8BIT, Encoding::Emacs_Mule) crashes on MinGW
- @MSP-Greg
You mistake to mention about `@shirosaki`, not `@hsbt`. -
06:25 AM Revision 41aa841a (git): Add Range#% to call-seq [ci skip]
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64873 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
05:28 AM Revision f251ce9f (git): don't use GC::Profiler on default.
- * benchmark/gc/gcbench.rb: disable GC::Profiler on default.
add -p option instead.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64872 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
03:35 AM Revision aa1023ed (git): add debug counters more.
- * debug_counter.h: add debug counters to count frame state transitions:
* frame_R2R: Ruby frame to Ruby frame
* frame_R2C: Ruby frame to C frame
* frame_C2C: C frame to C frame
* frame_C2R: C frame to Ruby frame
* vm_insnhelper.... -
03:32 AM Revision cebd2c4a (git): add small utility for benchmarking.
- * benchmark/lib/load.rb: add small utility which requires
benchmark-driver.rb. You can load this file and can
use benchmark-driver.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64870 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
02:42 AM Feature #13618: [PATCH] auto fiber schedule for rb_wait_for_single_fd and rb_waitpid
- shannonskipper@gmail.com wrote:
> Thread::Light seems nice. Or how about Thread::Feather? A
> thread as lights as a feather.
Sorry, but no to "Feather". Again, I don't want to introduce new
usage of words.
"Light" is common us... -
02:19 AM Feature #14697 (Closed): Introducing Range#% as an alias to Range#step
- Applied in changeset trunk|r64869.
----------
range.c: Add Range#%
[Feature #14697] [ruby-core:86588] - 02:18 AM Revision 85f192b0 (git): range.c: Add Range#%
- [Feature #14697] [ruby-core:86588]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64869 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 01:10 AM Revision b7d63679 (git): * 2018-09-28
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64868 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
01:10 AM Revision df5ec410 (git): add debug counters more.
- * debug_counter.h: add the following counters.
* frame_push: control frame counts (total counts).
* frame_push_*: control frame counts per every frame type.
* obj_*: add free'ed counts for each type.
* gc.c: ditto.
* vm_insnhelpe... -
12:48 AM Feature #15166: 2.5 times faster implementation than current gcd implmentation
- No, no. You can just use `__builtin_ctzl` when it is available. All you need is check if it is available or not, and keep the original code for the case where `__builtin_ctzl` is unavailable. Gcc and clang provide it, so it is actuall...
09/27/2018
-
11:17 PM Bug #15162: Encoding::Converter.search_convpath(Encoding::ASCII_8BIT, Encoding::Emacs_Mule) crashes on MinGW
- @hsbt
I just did twenty runs of core/encoding, then twenty runs of the full spec suite. No silent SEGV's.
Hence, the patch works. Thank you. Whoever does the commmit, please remember to remove the two `.name` method calls on... -
10:37 PM Feature #15166: 2.5 times faster implementation than current gcd implmentation
- Hi
I just submitted this issue feature request:
https://bugs.ruby-lang.org/issues/15172
to deal with the issue of using (or not) the ``__builtin_ctz`` compiler directive.
I implemented code that mimicked it that also greatl... -
10:18 PM Feature #15170: Allow WEBrick::HTTPServlet::initialize to accept an array in server[:CGIInterpreter]
- I do not have any pro or con opinion (I rarely use webrick these days) but I
think if you can retain backward compatibility then this may make any patch
in this regard a lot easier.
If you have the time, I would like to suggest to ... -
03:54 PM Feature #15170 (Closed): Allow WEBrick::HTTPServlet::initialize to accept an array in server[:CGIInterpreter]
- There is currently no nice way to give WEBrick::HTTPServlet a command with arguments as an array. This force scripts to escape the paths to the given command.
One way to let people specify either a string or an array of strings would ... -
10:08 PM Feature #15172 (Open): Performance: create method(s) to mimic __builtin_ctz compiler directive functionality
- **Background**
This proposal emanates from issues I raised with regard to speeding up Ruby's implementation of it's ``gcd``.
https://bugs.ruby-lang.org/issues/15166
The use case for these proposed methods exists for many mathema... -
09:40 PM Feature #15171: [patch] Use OpenSSL 1.1.1 for Appveyor MinGW build
- @naruse
I guess I was referring to the two VC builds on Appveyor. With three serial builds on Appveyor, the CI can get quite backed up. Sometimes I've started a new ruby-loco build just to check...
I'm probably mistaken but I thi... -
09:09 PM Feature #15171: [patch] Use OpenSSL 1.1.1 for Appveyor MinGW build
- MSP-Greg (Greg L) wrote:
> Lastly, given any thought to moving the VC builds to Azure? I may see if I can make both VC12 and VC14 OpenSSL packages. Seems inappropriate to load different runtimes with (I think) VC12.
It is bad if VC... -
08:36 PM Feature #15171 (Closed): [patch] Use OpenSSL 1.1.1 for Appveyor MinGW build
- @nobu
Thanks for your work with the Appveyor testing. It took three revisions, but MSYS2 has jumped from OpenSSL 1.0.2 to 1.1.1. The package release 1.1.1-4 should build fine on Appveyor MinGW. I don't think it has hit the MSYS2 re... -
09:12 PM Bug #15163 (Closed): [BUG] Segmentation fault at 0x0000000000000000
- Duplicated with #14959
-
07:17 PM Bug #15169: rb_funcallv crashes when argc is -1
- nobu (Nobuyoshi Nakada) wrote:
> `argc` is the number of arguments, pointed by `argv`.
> ...
No, it's actually a bug in the fuzzer I'm building to pass -1 to that function. But I'm getting that crash when I do that. The actual code is ... -
12:25 PM Bug #15169 (Rejected): rb_funcallv crashes when argc is -1
- `argc` is the number of arguments, pointed by `argv`.
Do you want to pass -1 arguments? -
11:39 AM Bug #15169 (Rejected): rb_funcallv crashes when argc is -1
- The native function rb_funcallv casues a segmentation fault on 0xffffffffffffffd8 when the argc parameter is -1.
Example:
~~~ c
VALUE argv[1];
argv[0] = Qnil;
rb_funcallv(INT2NUM(1), rb_intern("round"), -1, argv);
~~~
Atta... -
10:22 AM Revision 0e3e0f82 (git): Fix messages for too small year
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64866 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
10:22 AM Revision ce77c385 (git): Sort in alphabetical order [ci skip]
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64865 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
10:15 AM Revision 0fb505d2 (git): NEWS: Replace tab with spaces
- [ci skip]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64864 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
10:03 AM Feature #14802: Update Unicode data to Unicode Version 11.0.0
- Just a note, the definition of extended grapheme cluster is changed in Unicode 11 (Unicode® Standard Annex #29
UNICODE TEXT SEGMENTATION revision 33: https://www.unicode.org/reports/tr29/tr29-33.html)
This affects Regexp /\X/ which is ... - 09:29 AM Revision 00e21090 (git): NEWS: Add ArithmeticSequence related things
- [ci skip]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64863 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
09:25 AM Bug #15160: ArgumentError: year too big to marshal
- This is a limit of current marshal format of `Time`, not a bug.
This is a [patch] to extend the limit, but it has a little problem on marshal data compatibility.
```
$ ./ruby -e 'Marshal.dump(Time.new(1900), STDOUT)'|ruby -e 'p Ma... -
04:33 AM Revision 55702df2 (git): move GCC version check from marshal.c to configure.ac
- I think it should be done in configure
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64862 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
09/26/2018
-
11:33 PM Feature #15166 (Assigned): 2.5 times faster implementation than current gcd implmentation
- Thanks. Assigned to @watson1978.
It would be very helpful if you could provide us a patch and perform the benchmark with Ruby implementation, not a toy benchmark program. Note that `__builtin_ctzl` is not available on some compilers... -
06:30 PM Feature #15166 (Assigned): 2.5 times faster implementation than current gcd implmentation
- This is to be more explicit (and accurate) than https://bugs.ruby-lang.org/issues/15161
This is my modified gcd benchmarks code, originally presented by Daniel Lemire (see 15161).
https://gist.github.com/jzakiya/44eae4feeda8f6b048e... -
11:29 PM Bug #15162: Encoding::Converter.search_convpath(Encoding::ASCII_8BIT, Encoding::Emacs_Mule) crashes on MinGW
- @hsbt, thanks for the work on this. I (quickly) did a lambda in a block, and that didn't cause the SEGV.
Using existing ruby-loco builds (I save all of them locally), I found that the issue doesn't exist on:
`ruby 2.6.0dev (2018-09-... -
11:42 AM Bug #15162: Encoding::Converter.search_convpath(Encoding::ASCII_8BIT, Encoding::Emacs_Mule) crashes on MinGW
- I found a smaller test to reproduce SEGV.
```
$ ./miniruby -ve "loop do loop do loop do Encoding::Converter.search_convpath(Encoding::ASCII_8BIT, Encoding::ASCII_8BIT) end end end"
ruby 2.6.0dev (2018-09-26 trunk 64852) [x64-mingw32... -
09:35 AM Bug #15162 (Closed): Encoding::Converter.search_convpath(Encoding::ASCII_8BIT, Encoding::Emacs_Mule) crashes on MinGW
- It seems to work fine with String arguments, but not Encoding objects where it SEGV, at least in some runs.
See https://github.com/ruby/ruby/commit/f00bf242724d40d59a242c6bf9e567d18c9e1872#commitcomment-30650955
cc @MSP-Greg -
09:25 PM Misc #15129: DevelopersMeeting20181010Japan
- [[Feature #14912]](https://bugs.ruby-lang.org/issues/14912) Introduce pattern matching syntax (greggzst)
Many modern languages have introduced pattern matching. I used it in scala and found it very easy to utilize and understand especia... -
05:24 PM Bug #15164 (Closed): mkmf doesn't work with miniruby on Windows
- Applied in changeset trunk|r64860.
----------
fallback env encoding to ASCII-8BIT
* hash.c (env_enc_str_new): as no locale/filesystem encoding is
available in miniruby on Windows, fallback the encoding to
ASCII-8BIT so it is valid ... -
03:29 PM Bug #15164 (Closed): mkmf doesn't work with miniruby on Windows
- After r59449 `nmake` failes to run when making ripper and so on.
It because miniruby sets UTF-8 encoding even though the content is CP932 (on Japanese Windows).
It should set ASCII-8BIT and handle as it is.
```
ripper:
" Could... - 05:24 PM Revision ea4b9f8f (git): * properties.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64861 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
05:24 PM Revision 7f0d337b (git): fallback env encoding to ASCII-8BIT
- * hash.c (env_enc_str_new): as no locale/filesystem encoding is
available in miniruby on Windows, fallback the encoding to
ASCII-8BIT so it is valid encoding when the conversion failed.
[ruby-core:89177] [Bug #15164]
git-svn-id: s... -
05:14 PM Bug #15165: heap-use-after-free (READ of size 8) in obj_free (gc.c:2266)
- ko1 (Koichi Sasada) wrote:
> Thank you.
> ...
Yes, both are needed.
ASAN needs the -fsanitize=address passed for both compile and linking. The ASAN library also has to be linked to the final executable, so you need to use clang inst... -
04:56 PM Bug #15165: heap-use-after-free (READ of size 8) in obj_free (gc.c:2266)
- Thank you.
I want to know how to use clang's ASAN. You specified CFLAGS and LDFLAGS. both needed? -
04:51 PM Bug #15165 (Closed): heap-use-after-free (READ of size 8) in obj_free (gc.c:2266)
- Applied in changeset trunk|r64857.
----------
fix use-after-free in obj_free.
* gc.c (obj_free): a table can be accessed for debug counters.
[Bug #15165] [Fix GH-1964]
A patch from Joe Truba <jtruba@meraki.com>
Also check USE_D... -
04:17 PM Bug #15165 (Closed): heap-use-after-free (READ of size 8) in obj_free (gc.c:2266)
- This is triggered while compiling 22de2030c5 on my Debian machine. Compiled with:
~~~
CC=clang CXX=clang++ LDFLAGS="-O0 -fno-omit-frame-pointer -g3 -fsanitize=address -fsanitize-coverage=trace-pc-guard" ASAN_OPTIONS=detect_leaks=0 CF... - 04:51 PM Revision 2fa31671 (git): * 2018-09-27
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64859 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 04:51 PM Revision 9cf53c45 (git): * expand tabs.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64858 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
04:51 PM Revision e0b3e5e1 (git): fix use-after-free in obj_free.
- * gc.c (obj_free): a table can be accessed for debug counters.
[Bug #15165] [Fix GH-1964]
A patch from Joe Truba <jtruba@meraki.com>
Also check USE_DEBUG_COUNTER macro.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64857 b2... -
02:15 PM Bug #15163 (Closed): [BUG] Segmentation fault at 0x0000000000000000
- Hi guys, I'm working with the ruby-2.6.0-preview2 in a Ubuntu 18.04.
When I try to run a "rails server" command I get a intermitenty error:
"/home/alexvirtualbr/.rvm/gems/ruby-2.6.0-preview2/gems/bootsnap-1.3.2/lib/bootsnap/compile_... -
11:13 AM Bug #11667: Ruby process crashes when TracePoint.new(:raise) is enabled and SystemStackError is raised
- We recently ran into this same problem in Ruby 2.4.x, however this appears to be fixed in Ruby 2.5.
In the command below you should see an exception in the output, but instead the application crashes with no output.
~~~ text
$ rub... -
10:24 AM Bug #15027: When Struct#each method is overriden Struct#select and Struct#to_a use wrong collections
- Hi,
let me know if you have any further feedback on this one? -
09:33 AM Revision 22de2030 (git): * ext/win32ole/lib/win32ole.rb (methods): COM method elements should be
- symbol in return value of methods.
* test/win32ole/test_win32ole.rb ditto.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64856 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
09:32 AM Revision 38989c76 (git): Use String arguments for #search_convpath
- * Otherwise it seems to SEGV on Windows, see
https://github.com/ruby/ruby/commit/f00bf242724d40d59a242c6bf9e567d18c9e1872#commitcomment-30650955
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64855 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
08:11 AM Revision d3a9ebeb (git): fix OPT_CALL_THREADED_CODE issue.
- * insns.def (opt_send_without_block): reorder insn position because
`opt_str_freeze` insn refer this insn (function) when
OPT_CALL_THREADED_CODE is true.
* vm_opts.h (OPT_THREADED_CODE): introduce new macro to select
threaded code... -
07:28 AM Revision ee819b0d (git): add some debug counters.
- * debug_counter.h: new debug counters obj_promote, obj_wb_unprotect
and obj_struct_(ptr|embed) are added.
* gc.c: ditto.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64853 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
06:16 AM Revision bc2d493e (git): use configure-defined macro instead of __GNUC__
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64852 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
06:10 AM Bug #13167: Dir.glob is 25x slower since Ruby 2.2
- I hope so too (not confident enough since it was a random failure). Thank you for your attention to these CIs.
-
04:09 AM Bug #13167: Dir.glob is 25x slower since Ruby 2.2
- k0kubun (Takashi Kokubun) wrote:
> After this commit is merged, some CIs that has -DVM_CHECK_MODE=2 and continue to test latest revision started to randomly crash "TestGem#test_load_plugins":
> ...
Is that fixed by r64849? Thanks for t... - 02:38 AM Revision 8ab2230b (git): * expand tabs.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64851 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
02:38 AM Revision 6e62e59e (git): revert r64847, r64846 and r64839
- because r64849 seems to fix issues which we were confused about.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64850 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
02:23 AM Revision fa3d1ca0 (git): fix "initialize miss".
- * dir.c (glob_helper): initialize `args.pathtype`.
missed at r64810.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64849 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
02:02 AM Revision 226b9159 (git): yet another -Wparentheses tweak
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64848 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 01:11 AM Revision 1d782010 (git): * expand tabs.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64847 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
01:11 AM Revision e08f4182 (git): revert r64838 and r64839
- because some build failures persisted
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64846 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
09/25/2018
-
11:31 PM Revision ac178357 (git): Expand spec files to realpaths
- * spec/mspec/lib/mspec/utils/script.rb (MSpecScript#entries): expand
the given spec path to the realpath, not to require a library by
realpath and symbolic link path from the spec file.
reapply r64749 and r64751 overridden by r648... -
10:33 PM Feature #15161 (Closed): making gcd faster for 3x3
- It already uses the variant of the binary (Stein's) algorithm.
https://github.com/ruby/ruby/blob/3abbaab1a7a97d18f481164c7dc48749b86d7f39/rational.c#L285-L307
See #13503. -
09:05 PM Feature #15161: making gcd faster for 3x3
- I think a benchmark may be useful to the issue here.
I don't think the ruby team minds any speed improvement but what
is usually done is to verify any potential gain through benchmarks
(e. g. optcarrot for, I think, ruby 3x3 goals). -
06:14 PM Feature #15161 (Closed): making gcd faster for 3x3
- With the goal of making Ruby as fast as possible for 3x3 I would like to propose
a faster implementation of the ``gcd`` function. I use ``gcd`` a lot in my
``primes-utils`` gem, and in cryptography and Number Theory problems.
The cu... -
10:20 PM Misc #15129: DevelopersMeeting20181010Japan
- * [Feature #11505] Module#=== should call #kind_of? on the object rather than rb_obj_is_kind_of which only searches the ancestor heirarchy
* This would allow patterns as Decorator and Proxy to work with case statements. -
08:30 PM Bug #15152: Thread Crashes
- It turns out the Ubuntu computer was freezing due to an unstable overclock of the RAM. Perhaps the thread crashed because my code or a library I'm using is not thread safe.
- 06:47 PM Revision 3abbaab1 (git): * properties.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64844 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
06:47 PM Revision e2d74af3 (git): Update to ruby/mspec@2bca8cb
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64843 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 06:13 PM Revision 2466288d (git): * expand tabs.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64842 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
06:13 PM Revision cdc614cd (git): refactoring debug_counter.
- * debug_counter.h: add comments for each counters.
* debug_counter.h: add some counters (see added comments for details).
* obj_newobj
* obj_newobj_slowpath
* obj_newobj_wb_unprotected
* obj_hash_empty
* obj_hash_under4
* ob... -
05:26 PM Revision 989fc2de (git): appveyor.yml: increase timeout for vs
- because `TestThreadQueue#test_queue_with_trap` is too unstable
especially on vs140.
https://ci.appveyor.com/project/ruby/ruby/build/9731/job/sevjm9lrmssg4dub
Increasing timeout may not fix the issue, but let me test this first to
check ... -
05:20 PM Revision 2b610ec2 (git): insns.def: drop bitblt insn
- as a workaround to fix the build pipeline broken by r64824,
because optimizing Ruby should be prioritized higher than supporting unused jokes.
In the current build system, exceeding 200 insns somehow crashes C
extension build on some of... -
05:19 PM Revision 08c9f030 (git): Revert "Revert r64824 to fix build failure on AppVeyor"
- This reverts commit r64829. I'll prepare another temporary fix, but I'll
separately commit that to make it easier to revert that later.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64838 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
03:50 PM Bug #15160 (Closed): ArgumentError: year too big to marshal
- I encountered the problem, that marshaling a Time object does not always work.
Try run following commands in irb that will raise an error:
~~~ ruby
Marshal.dump(Time.new(1900))
#Traceback (most recent call last):
# 3: fro... - 03:31 PM Revision 3f4d174c (git): * 2018-09-26
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64837 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
03:31 PM Revision f73d504c (git): dir.c: fix glob with recursive and brace
- Fixed bug that glob with recursive and braces (**/{a,b}) pattern
fails.
[Feature #13167]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64836 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
03:31 PM Revision b1432544 (git): dir.c: fix memory leak of glob with braces
- join_path uses malloc. So free is required.
[Feature #13167]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64835 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
03:05 PM Bug #15159 (Third Party's Issue): Some options of win32screenshot gem not working with Ruby 2.5.1.
- Hello,
The following options are not working for the win32screenshot gem (or possibly rautomation) in Ruby 2.5.1. The error I get is below. I have attached a log as well. The code works in Ruby 2.4.4.
C:/Selenium_Ruby/runtime/li... - 01:42 PM Revision 7ef91e62 (git): * expand tabs.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64834 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
01:42 PM Revision d7278b5b (git): Moved `struct vtm` stuff from internal.h to timev.h
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64833 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
11:26 AM Feature #11625: Unlock GVL for SHA1 calculations
- Hi,
I had a similar problem like Aaron, but with MD5 instead of SHA1. I stumbled upon this thread and completed the patch for all digest algorithms.
Hope it helps!
best,
Steve
- 10:41 AM Revision b3484e59 (git): * properties.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64832 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
10:41 AM Revision e87fb88b (git): Update to ruby/spec@241f9e7
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64831 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
10:40 AM Revision e59bf54b (git): Update to ruby/mspec@3fb5112
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64830 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
09:32 AM Bug #15130: Nested Timeouts hang on cygwin
- duerst@it.aoyama.ac.jp wrote:
> When I run this, I get all the expected output, as follows:
> ```
> Before sleeping
> After sleeping, before method call
> Before sleeping in method
> After sleeping in method
> ```
> but this scr... -
09:32 AM Bug #15130: Nested Timeouts hang on cygwin
- duerst@it.aoyama.ac.jp wrote:
> normalperson (Eric Wong) wrote:
>
> > Is there something which shows system call traces which could be
> > useful in diagnosing this?
>
> `strace` seems to do that, see https://cygwin.com/cygwin... -
06:32 AM Bug #15130: Nested Timeouts hang on cygwin
- I managed to create a very short script that seem so recreate the problem (or at least something similar).
It seems to happen with a `Timeout` inside a `Timeout` (I didn't manage to create a problem with only one `Timeout`).
Here's... -
06:13 AM Bug #15130: Nested Timeouts hang on cygwin
- normalperson (Eric Wong) wrote:
> Is there something which shows system call traces which could be
> ...
`strace` seems to do that, see https://cygwin.com/cygwin-ug-net/strace.html.
```
strace ./ruby -ropen-uri -e 'open "http://... -
12:52 AM Bug #15130: Nested Timeouts hang on cygwin
- duerst@it.aoyama.ac.jp wrote:
> What I was wondering is: Why do things get stuck in a case
> where the Timeout isn't actually invoked (as far as I
> understand). Shouldn't the program just move ahead? Any
> background information on... -
12:42 AM Bug #15130: Nested Timeouts hang on cygwin
- duerst@it.aoyama.ac.jp wrote:
> normalperson (Eric Wong) wrote:
> > This brings the Cygwin pthreads timer thread closer to what was
> > in 2.5 by setting ec->interrupt_flag (via rb_threadptr_check_signal):
> >
> > https://80x2... -
12:24 AM Bug #15130: Nested Timeouts hang on cygwin
- What I was wondering is: Why do things get stuck in a case where the Timeout isn't actually invoked (as far as I understand). Shouldn't the program just move ahead? Any background information on what may be happening and why is appreciat...
-
12:22 AM Bug #15130: Nested Timeouts hang on cygwin
- normalperson (Eric Wong) wrote:
> This brings the Cygwin pthreads timer thread closer to what was
> ...
Thanks!
Should I use together with or separately from 0001-thread_pthread.c-fall-back-to-UBF_TIMER_PTHREAD-for-.patch ?
-
06:43 AM Feature #15156 (Third Party's Issue): Have a 'c_headers' specifier in Gem::Specification.
- https://github.com/rubygems/rubygems/issues/2408
-
04:03 AM Feature #15156 (Third Party's Issue): Have a 'c_headers' specifier in Gem::Specification.
- Currently if one Ruby gem depends on the C extension of another Ruby gem, the only way
find the header of that gem is to run a `Gem::Specification.find_by_name` in the extconf.rb
of the gem needing the header and then adding the folder... -
04:03 AM Revision f00bf242 (git): Revert r64824 to fix build failure on AppVeyor
- AppVeyor msys2/MinGW build started to fail like:
https://ci.appveyor.com/project/ruby/ruby/build/9722/job/b94kixi004klmye3
Until I can investigate that, I revert this for now.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64829 b2d... -
03:22 AM Feature #15149: extend string format to nil safe
- foonlyboy (Eike Dierks) wrote:
> I believe that `%p` is for pointers.
It's true in C, but Ruby does not show bare pointers.
`%p` calls `inspect` instead.
> ...
I meant that such library would need to stick the old behavior or
br... -
12:53 AM Feature #15149: extend string format to nil safe
- Hi nobu,
thanks for your reply, let's talk about this
I believe that `%p` is for pointers.
Actually `%p` already behaves like this:
```ruby
'%p' % nil #=> "nil"
```
(I was not aware of that)
Please explain your complaints a... -
03:02 AM Bug #15154 (Closed): OpenBSD make(1) can't build node_name.inc
- The [make(1)](https://man.openbsd.org/make) command in OpenBSD can't build node_name.inc of Ruby trunk in an out-of-source build. GNU make works. OpenBSD make misses node.h in the source directory, and tries to use node.h in the build ...
09/24/2018
- 11:23 PM Revision b0156ad0 (git): * 2018-09-25
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64828 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
11:23 PM Revision 4172d082 (git): test/unit.rb: fix --subprocess-timeout-scale
- * test/lib/test/unit.rb (Test::Unit::SubprocessOption#non_options):
set timeout scale after parsing options. the option value will be
set after returning from setup_options.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64827 b... -
11:18 PM Feature #15112: Introducing the short form of `STDERR.puts expr.inspect`.
- Any object which has `#write` method can be assigned to `$stderr`, so we should not expect `$stderr` to have `p`, I think.
-
04:16 PM Misc #15129: DevelopersMeeting20181010Japan
- Feature suggestion #15112 Introduce the new singleton method STDERR.p (by Kenta Murata)
I am mostly curious what the ruby core team thinks about Kenta Murata's proposal; it probably will not take too much time away discussing it briefly... -
02:26 PM Revision c0f0cff5 (git): Check whether to skip every frame
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64826 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
01:04 PM Revision d5a7c704 (git): Kernel#warn accepts multiple messages
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64825 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
12:40 PM Revision fb80f6c7 (git): insns.def: optimize & and | of Integer [experimental]
- not optimizing Array#& and Array#| because vm_insnhelper.c can't easily
inline it (large amount of array.c code would be needed in vm_insnhelper.c)
and the method body is a little complicated compared to Integer's ones.
So I thought only... -
07:52 AM Bug #15146: [PATCH] webrick: raise EOFError in parse when read line is nil
- > https://bugs.ruby-lang.org/issues/15146
Thanks, committed as r64823 -
07:48 AM Bug #15146 (Closed): [PATCH] webrick: raise EOFError in parse when read line is nil
- Applied in changeset trunk|r64823.
----------
webrick: raise EOFError in parse when read line is nil
[Bug #15146]
From: Justin Li <git@justinli.net> - 07:48 AM Revision 1aef602d (git): webrick: raise EOFError in parse when read line is nil
- [Bug #15146]
From: Justin Li <git@justinli.net>
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64823 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
07:46 AM Revision d54d9ba7 (git): revert r64817: kernel_warn.rb: skip kernel_require.rb
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64822 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
06:21 AM Revision 7a18e298 (git): _mjit_compile_send.erb: remove TODO comment solved [ci skip]
- which was solved by r64820
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64821 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
06:09 AM Revision 36265861 (git): _mjit_compile_send.erb: refactor code to setup iseq
- by sharing vm_call_iseq_setup_normal. This is a retry of r64280.
vm_insnhelper.c: Remove unused argument `ci` and pass `me` instead of
`cc` to share this with JIT. Declare this with ALWAYS_INLINE to make
sure this function is inlined in... - 03:14 AM Revision b96ff9e0 (git): * 2018-09-24
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64819 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 03:14 AM Revision b0daae1d (git): * properties.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64818 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
03:14 AM Revision 7fbe79f6 (git): kernel_warn.rb: skip kernel_require.rb
- * lib/rubygems/core_ext/kernel_warn.rb (Kernel#warn): skip
kernel_require.rb's frames when `uplevel` option is given.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64817 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
02:47 AM Feature #15149: extend string format to nil safe
- Rather it feels the role of `inspect`, that is used by `%p`.
Regarding the compatibility, that new format string can't work with earlier versions.
That means libraries which want to support earlier versions can't use it.
09/23/2018
-
11:16 PM Bug #15152 (Closed): Thread Crashes
- When I run my rails test suite with the parallel_test gem a thread crashes. The test suite completely passes when I don't run the tests in parallel and it also works fine when I run unit tests in parallel, but if I run enough system test...
-
03:27 PM Feature #15151 (Open): String#slice!(0,..) creates a duplicate of original string
- String#slice! when used at beginning of string (e.g. slice!(0,10)) calls rb_str_drop_bytes which creates shared string for non embedded string. str_modify_keep_cr clears the flag of shared string which is called before rb_str_drop_bytes....
-
12:40 PM Revision 85e5424a (git): test_win32api.rb: suppress a warning
- * test/test_win32api.rb: suppress a warning, which we know already
well.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64816 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
08:52 AM Bug #15130: Nested Timeouts hang on cygwin
- duerst@it.aoyama.ac.jp wrote:
>
> Please tell me what I can do to help you solve this problem.
Oops, I guess pthread_kill isn't going to work in cygwin :x
This brings the Cygwin pthreads timer thread closer to what was
in 2.5 ... -
08:04 AM Bug #14807: 2.6.0-preview2 segfaults on OpenBSD due to missing pthread_condattr_init call
- > https://bugs.ruby-lang.org/issues/14807#change-74146
Right, already in trunk at r63548
And back to Jeremy's earlier comment:
> It's defined but I don't think it would be usable:
>
> /usr/include/pthread.h:#define PTHREAD_CON... -
02:35 AM Bug #13167: Dir.glob is 25x slower since Ruby 2.2
- After this commit is merged, some CIs that has -DVM_CHECK_MODE=2 and continue to test latest revision started to randomly crash "TestGem#test_load_plugins":
http://ci.rvm.jp/results/trunk-asserts@silicon-docker
http://ci.rvm.jp/results...