Activity
From 07/19/2018 to 07/25/2018
07/25/2018
-
11:36 PM Feature #14940 (Closed): Support bcrypt password hashing in webrick
- Related to #14915, this adds bcrypt password hash support when using htpasswd files with Webrick basic auth, allowing a migration path away from the current String#crypt usage.
- 10:32 PM Revision 1516b85d (git): test/ruby/test_io.rb (test_select_leak): skip with MJIT
- We need better ways to test for leaks :<
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64059 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
09:37 PM Bug #14939 (Closed): [PATCH] cont.c (ec_switch): prevent delayed/missed trap interrupt race
- ko1: I noticed this while working on timer-thread elimination/lazy-spawning.
However, it looks like a bug we introduced in 2.5 with `ec'.
Can you check this patch? Thanks.
cont.c (ec_switch): prevent delayed/missed trap interrupt ... -
06:31 PM Feature #14938: Provide API to get same result as ruby -wc
- This may also be useful for irb/pry add-ons, I think.
Perhaps Koichi-san can comment on the issue if he has time. -
03:58 PM Feature #14938 (Open): Provide API to get same result as ruby -wc
- I'm the author of an implementation of Ruby Language Server.
Currently, it uses `RubyVM::InstructionSequence.compile` to get the result of `ruby -wc` and parses message and location by regexp.
https://github.com/mtsmfm/language_serve... -
06:09 PM Revision 3b60f4a5 (git): [Doc] Recover example about Queue
- `trunk@42862` dropped example's last line.
https://github.com/ruby/ruby/commit/e334bb2ce5d8876b020ab681f21595e2e1c9d601#diff-8783a9b452e430bcf0d7b0c6e34f1db0L144
https://github.com/ruby/ruby/commit/e334bb2ce5d8876b020ab681f21595e2e1c9d6... -
- Since 2.5, Module#define_method is public. (feature #14133)
Co-Authored-By: Miguel Landaeta <miguel@miguel.cc>
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64057 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Co-Authored-By: Matias Korhonen <matias@kiskolabs.com>
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64056 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 06:00 PM Revision a818fca3 (git): * 2018-07-26
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64055 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Co-Authored-By: Robert Mosolgo <rdmosolgo@gmail.com>
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64054 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Hi, we've been hitting this bug at work too. I tested these commits (backported them on to Ruby 2.5) and they seem to clear up the issue. Naruse, could we have these backported to the ruby_2_5 branch? I made backport commits here: htt...
-
- (Sorry for this short comment but I think the issue here is filed under
"Bug" presently, but should perhaps be moved towards "Misc" instead,
like the two prior dev-meetings.) -
02:55 PM Revision a763bc3c (git): insns.def: s/handles_frame/handles_sp/
- because it's more suitable to describe the current behavior now.
tool/ruby_vm/models/bare_instructions.rb: ditto.
tool/ruby_vm/views/_insn_entry.erb: ditto.
tool/ruby_vm/views/_mjit_compile_insn_body.erb: ditto.
tool/ruby_vm/views/_mjit... -
- I'm going to build a large .so file that combines multiple .o files.
For that change, I want to confirm the impact to performance by this
change. So far, I haven't seen the significant change on the max
performance.
* before
$ for i in ... -
- by whether on mswin or not.
This is needed because I'm going to renew the compilation process for
unix, keeping mswin builds as it is, at first.
This commit is not changing the behavior at all.
git-svn-id: svn+ssh://ci.ruby-lang.org/r... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64050 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
12:31 PM Revision 3a1e3d35 (git): Update latest default gems on maintainers.rdoc and standard_library.rdoc.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64049 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * lib/mutex_m.gemspec: Added initial gemspec.
* lib/mutex_m.rb: Added Mutex_m::VERSION for gemspec.
* tool/sync_default_gems.rb: Support Mutex_m.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64048 b2dd03c8-39d4-4d8f-98ff-823fe6... - 12:26 PM Revision 27785eec (git): * properties.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64047 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * lib/e2mmap.gemspec: Added initial gemspec.
* lib/e2mmap/version.rb: Added Exception2MessageMapper::VERSION for gemspec.
* tool/sync_default_gems.rb: Support Exception2MessageMapper.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trun... -
12:21 PM Misc #14937: [PATCH] thread_pthread: lazy-spawn timer-thread only on contention
- @normalperson
Eric,
In addition to the build mentioned above, there have been two more ruby-loco builds, both with all three patches, and both passed all tests
> Thanks for testing; I guess 47 minutes is not unusual for a busy ... -
08:32 AM Misc #14937: [PATCH] thread_pthread: lazy-spawn timer-thread only on contention
- On 2018/07/25 17:20, Eric Wong wrote:
> I don't know, current behavior seems intentional and documented
> in RDoc:
>
> * Note that this method can wakeup without explicit Thread#wakeup call.
> * For example, receiving ... -
- Koichi Sasada <ko1@atdot.net> wrote:
> I need to read your proposal with more concentrations, but one thing:
Thanks. I noticed a bug where it sometimes still get
stuck when I run "make exam" in a loop. Will have to dig deeper
to... -
- Greg.mpls@gmail.com wrote:
> Tested with the attached patch. When Appveyor is busy, and
> with test-all using retry, and something in MJIT failing or
> erroring, the test took 47 minutes.
>
> Anyway, all good, ran with r64038, an... -
- @normalperson
Eric,
Tested with the attached patch. When Appveyor is busy, and with test-all using retry, and something in MJIT failing or erroring, the test took 47 minutes.
Anyway, all good, ran with r64038, and all tests p... -
- > > git repository also available at:
> > https://80x24.org/ruby.git tt-lazy
> > (commit a2990cefccba55300ad44275ee4adf18e6f95ece)
>
> Now up to commit 6fb72ad7334a61e3c4341aa5fa17749671cbb867
Sorry, didn't finish testing th... -
- > git repository also available at:
> https://80x24.org/ruby.git tt-lazy
> (commit a2990cefccba55300ad44275ee4adf18e6f95ece)
Now up to commit 6fb72ad7334a61e3c4341aa5fa17749671cbb867
[PATCH 2/1] thread.c (rb_threadptr_execut... -
- > https://bugs.ruby-lang.org/issues/14937
Hi Greg, Can you try the patch in this ticket? It shouldn't
affect win32, but maybe I made typos. I couldn't add you
as a watcher to this ticket from Redmine (since that requires
JavaSc... - 12:15 PM Revision ddb6e1f7 (git): * properties.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64045 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * lib/thwait.gemspec: Added initial gemspec.
* lib/thwait/version.rb: Added ThWait::VERSION for gemspec.
* tool/sync_default_gems.rb: Support ThWait.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64044 b2dd03c8-39d4-4d8f-98ff-82... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64043 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * lib/forwardable.rb: Added Forwardable::VERSION and re-use it.
* lib/forwardable/forwardable.gemspec: Added initial gemspec.
* tool/sync_default_gems.rb: Support forwaradable repository.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64041 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64040 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * net-telnet-0.2.0
* power_assert-1.1.3
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64039 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
-
- http://ci.rvm.jp/results/trunk-test@frontier/1153126
doesn't fixed yet :( -
07:44 AM Feature #14922 (Assigned): Resolv getaddresses ignores AAAA records for IPv6
- Mmm, I think this is a real bug.
RUBYOPT does not work well in this case because resolve.rb is a library while RUBYOPT is for the process. Adding parameter to the constructor is an option though. -
06:22 AM Bug #14934: Unicode: Hangul normalize bug
- I have quickly looked at the tests. I understand what issue they are checking (NFC in case of a mix of current Hangul and old-style-only Hangul jamos). I think Ruby should pass these tests.
Ruby has tests for this case, see
https://s... -
- jeremyevans0 (Jeremy Evans) wrote:
> So there are no security issues in the `sub(/\A\$2y\$/, '$2a$')`.
Great. Thank you for confirmation. -
- normalperson (Eric Wong) wrote:
> Allowing options which other servers do not support is not
> ...
Fair enough, I'll work on adding support for `:password_hash=>:bcrypt|:crypt` (currently defaulting to :crypt if not given for backword... -
- shyouhei (Shyouhei Urabe) wrote:
> Off topic but,
> ...
There is only a difference between `$2a$` and `$2b$` on OpenBSD if the password length is 256 characters or longer. Such passwords are very rare. The `bcrypt` gem currently only... -
- merch-redmine@jeremyevans.net wrote:
> normalperson (Eric Wong) wrote:
> > Can you do it as a single option which doesn't involve having
> > users copy+paste code? Something like:
> >
> > :password_hash => (:bcrypt|:crypt|:b... -
- Off topic but,
jeremyevans0 (Jeremy Evans) wrote:
> Apache htpasswd generates passwords using `$2y$`, but the hashes are the same as `$2a$` format, and Apache handles `$2a$` format just fine. The bcrypt gem does not consider `$2y$` ... -
12:34 AM Bug #14936 (Rejected): Ruby 2.5.1 crahes when running on Mac OS X High Sierra 10.13.6
- It is 2.2, which has reached the EOL.
https://www.ruby-lang.org/en/news/2018/06/20/support-of-ruby-2-2-has-ended/ -
07/24/2018
-
- [ruby-core:87773]
```
thread_pthread: lazy-spawn timer-thread only on contention
To reduce resource use and reduce CI failure; lazy spawn
timer-thread only in processes which use Ruby Threads AND those
Ruby Threads hit contention.... -
- normalperson (Eric Wong) wrote:
> Can you do it as a single option which doesn't involve having
> ...
One issue with that is it doesn't offer a way to specify the password hash cost. For example, the bcrypt gem defaults to cost 10, a... -
- <snip> Thanks for the research on this matter
merch-redmine@jeremyevans.net wrote:
> Should I prepare a patch to Webrick to accept
> :create_password_hash and :check_password_hash options, and
> add documentation with an example u... -
- jeremyevans0 (Jeremy Evans) wrote:
> .htpasswd is an Apache-specific format, and Apache currently supports only 5 password formats: bcrypt, MD5, SHA1, crypt, plain text (https://httpd.apache.org/docs/2.4/misc/password_encryptions.html).... -
- Here's an alternative proposal, with the basic idea that behavior for historical ruby 1.6+ code that doesn't use keyword arguments remains the same.
## OK: Historical ruby 1.6+ (maybe before) usage (hash argument with omitted braces)
... -
08:24 PM Revision f1186a3d (git): Revert "dir.c: fix glob with base when no DT_UNKNOWN"
- This reverts commit r63982.
It breaks build on Solaris 11.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64038 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
07:22 PM Feature #14922: Resolv getaddresses ignores AAAA records for IPv6
- Greetings. I work behind Donovan (this bug's reporter) and am also dealing with this same issue. I tracked down the source of this behavior by looking through the Ruby resolv.rb source code. Apparently the DefaultResolver only resolves I...
-
05:13 PM Bug #14935: Inconsitent behaviour with puts and enumerator with different block format.
- I think this is because `do ... end` blocks has lower precedence than `{...}` blocks. As documented in [1]. So, probably, not a bug.
~~~
method1 method2 { ... } # method2's block
method1 method2 do ... end # method1's block
~~... -
03:54 PM Bug #14935: Inconsitent behaviour with puts and enumerator with different block format.
- #puts returns `nil`, so when you're mapping you end up with `[nil, nil, nil]`, which prints with #puts as three blank lines. If you use `p` instead of `puts` inside the block, the block will return `i` instead of `nil` and you'll see the...
-
12:29 PM Bug #14935 (Rejected): Inconsitent behaviour with puts and enumerator with different block format.
- ### Case: 1
```
➜ ~ ruby
puts [1,2,3].map do |i|
puts i
end
#<Enumerator:0x007ffe930b76d0>
➜ ~
# block does get evaluated.
```
Case 2:
```
➜ ~ ruby
puts [1, 2, 3].map { |i| puts i }
1
2
3
➜ ~
# Block gets ... -
05:01 PM Bug #14936 (Rejected): Ruby 2.5.1 crahes when running on Mac OS X High Sierra 10.13.6
- When attempting to run Arachni 1.5.1 on my Mac OS X High Sierra, I get a Ruby crash every time. I am attaching the Ruby crash report.
-
- which was missing in r64033.
Prior to r64033, memory allocation failure had been checked by
TRY_WITH_GC and handled by rb_memerror. But calling rb_memerror on MJIT
worker is problematic since it does EC_JUMP_TAG in the end. Threads
exce... - 03:17 PM Revision 461c79f1 (git): * 2018-07-25
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64036 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- because such inconsistency may result in the regression fixed in r64034.
vm_exec is not touched since renaming it may be controversial...
vm_args.c: ditto.
vm_eval.c: ditto.
vm_insnhelper.c: ditto.
vm_method.c: ditto.
git-svn-id: svn+... -
- on r64031. Compiling vm_search_method_slowpath is very slow.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64034 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- mjit_compile.c: ditto.
REALLOC_N, ALLOC_N and xmalloc trigger GC but it's not expected.
Other allocation calls in mjit.c are executed on Ruby's main thread and
thus fine.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64033 b2dd03c8... -
- in a short term, and add retries to prevent random CI failures by it.
I remember this and will address it later for sure.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64032 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
12:15 PM Bug #14934: Unicode: Hangul normalize bug
- > Can you provide some test case(s)?
That is what frustrated me. I simply translated Python's test-cases for this issue[1] to Ruby.
[1] https://github.com/python/cpython/commit/d134809cd3764c6a634eab7bb8995e3e2eff14d5
But them pas... -
- @MaLin: Can you provide some test case(s)?
All the test data provided by Unicode (e.g. https://www.unicode.org/Public/10.0.0/ucd/NormalizationTest.txt) is used for testing. But I know that there are some corner cases in Hangul that ar... -
- I'm not a expert of Ruby, I would suggest to examine the code of Hangul normalize, it looks too simple than the Unicode Standard's demonstration code.
-
- I was involved to fix a similar bug in Python, I found Ruby also has bug code.
We should fix this line[1] like this:
[1] https://github.com/ruby/ruby/blob/96db72ce38b27799dd8e80ca00696e41234db6ba/lib/unicode_normalize/normalize.rb#L7... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64031 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64030 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
09:15 AM Revision 004f5521 (git): Try to suppress warning on some CI
- http://ci.rvm.jp/results/trunk-asserts-nopara@silicon-docker/1149270
```
/home/ko1/ruby/src/trunk-asserts-nopara/process.c: In function 'assert_close_on_exec':
/home/ko1/ruby/src/trunk-asserts-nopara/process.c:298:9: warning: ignoring re... -
- Applied in changeset trunk|r64028.
----------
time.rb: yday support
* lib/time.rb (Time.make_time): added yday support.
[ruby-core:87545] [Bug #14860] -
- Applied in changeset trunk|r64028.
----------
time.rb: yday support
* lib/time.rb (Time.make_time): added yday support.
[ruby-core:87545] [Bug #14860] -
- * lib/time.rb (Time.make_time): added yday support.
[ruby-core:87545] [Bug #14860]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64028 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64027 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 05:38 AM Revision 8099b927 (git): * 2018-07-24
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64026 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * include/ruby/ruby.h (UNREACHABLE_RETURN): UNREACHABLE at the end
of non-void functions.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64025 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- egi (Satoshi Egi) wrote:
> Let me propose you to import the functions for non-linear pattern matching with backtracking that I have implemented as a Ruby gem in the following repository.
Open a new issue for that, please. Don't hija... -
04:49 AM Feature #14912: Introduce pattern matching syntax
- Let me propose you to import the functions for non-linear pattern matching with backtracking that I have implemented as a Ruby gem in the following repository.
https://github.com/egison/egison-ruby/
This pattern-matching system all... -
- normalperson (Eric Wong) wrote:
> Maybe Sequel and AR can have add optional PID checks
> ...
My problem with doing this by default is that it penalizes knowledgeable users just to avoid problems for users that don't read the documenta... -
- tenderlove@ruby-lang.org wrote:
> normalperson (Eric Wong) wrote:
> > eregontp@gmail.com wrote:
> > > I want to help protect future programmers from such bugs, if at all possible.
> > > And I believe it's possible.
> > >
... -
- tenderlovemaking (Aaron Patterson) wrote:
> I think library authors can make things easier though. Web frameworks, like Rails for example, are expected to handle this situation for the user. In addition, say a library author provided ... -
02:02 AM Feature #10982: Clarify location of NoMethod error
- I just ran into a `SyntaxError` on heapy today (in Ruby 2.1.6) and it did exactly what I wish would occur for `NoMethodError`:
```
$ heapy read ruby-heap-2018-07-24\ 01\:29\:05.dump
/Users/olivierlacan/.rbenv/versions/2.1.6/lib/rub...
07/23/2018
-
- normalperson (Eric Wong) wrote:
> eregontp@gmail.com wrote:
> ...
I've experienced a data leak similar to this. Saying the impact was "catastrophic" would be an understatement. :(
> fork is full of caveats; using atfork hook to wo... -
- normalperson (Eric Wong) wrote:
> Can you provide pre-defined, accepted-as-secure implementations
> ...
.htpasswd is an Apache-specific format, and Apache currently supports only 5 password formats: bcrypt, MD5, SHA1, crypt, plain tex... -
- merch-redmine@jeremyevans.net wrote:
> shyouhei (Shyouhei Urabe) wrote:
> > - Basic authentication itself does not require DES. It is an
> > implementation detail. You can safely migrate to another
> > hash function at will. R... -
- shyouhei (Shyouhei Urabe) wrote:
> Maybe this was my misunderstanding. Are BasicAuth and DigestAuth
> ...
No, basic auth and digest auth are very different, you can't just substitute one for the other. Digest auth requires MD5 for o... -
- On Fri, Jul 20, 2018 at 5:51 PM, Eric Wong <normalperson@yhbt.net> wrote:
> "Urabe, Shyouhei" <shyouhei@ruby-lang.org> wrote:
>> normalperson (Eric Wong) wrote:
>> > It's only the BasicAuth code and I have no idea how many people
>... -
- > https://bugs.ruby-lang.org/issues/14921
[Feature #14717] thread: allow disabling preempt -
03:06 PM Bug #14933 (Closed): Time.strptime with ordinal dates
- Using `Time`, I cannot parse an ordinal date (https://en.wikipedia.org/wiki/ISO_8601#Ordinal_dates).
It should work with `%j` according to the documentation: https://ruby-doc.org/stdlib-2.5.1/libdoc/time/rdoc/Time.html#method-c-strptime... - 09:56 AM Revision c7894575 (git): * properties.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64024 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64023 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64022 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64021 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 06:22 AM Revision 7ca648e9 (git): 60 sec is not enough at all
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64020 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * test/ruby/test_io.rb (test_select_leak): increase timeout seconds
to pass this test on a high-load machine.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64019 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
03:18 AM Feature #14924 (Rejected): // floor division operator
- Closing this ticket as per OP's request. Thank you for your understanding.
-
- Jeremy, thank you for discussing this issue seriously.
jeremyevans0 (Jeremy Evans) wrote:
> If that was the only change, it wouldn't be a big deal. However, in addition to `foo(:key => val)` calls, there are also `foo(hsh)` calls. S... -
- mame (Yusuke Endoh) wrote:
> jeremyevans0 (Jeremy Evans) wrote:
> ...
If that was the only change, it wouldn't be a big deal. However, in addition to `foo(:key => val)` calls, there are also `foo(hsh)` calls. So all callers that pass ... -
- Sorry, it seems my original description was unclear. I think it can be rephased very simply:
* keyword argument MUST be always received as a keyword parameter
* non-keyword argument MUST be always received as a non-keyword parameter... -
- jeremyevans0 (Jeremy Evans) wrote:
> For a method definition like:
> ...
No, it will not work. You need to rewrite the definition to `def foo(**hsh)`.
> One performance issue with keyword arguments is that keyword splats allocate... -
01:54 AM Feature #14912: Introduce pattern matching syntax
- ktsj (Kazuki Tsujimoto) wrote:
> Thanks for the feedback.
> ...
Hm. I didn't explan my intent well.
My intent is deconstructing pattern is not well correspondence to
pattern matching of functional languages.
In functional langu... -
- ktsj (Kazuki Tsujimoto) wrote:
> > - Deconstruction seems fragile; For instance the following case statement matches, which is very counter-intuitive.
> ...
Do you really think they are worth trading off?
What is, then, the purpose... - 01:07 AM Revision 8a3ed368 (git): Revert "thread.c (rb_thread_fd_select): remove unnecessary rb_fd_resize calls"
- This reverts commit r64017
(git commit 2ff85621690f4f5b0dff9226ac68418a950a6919).
Nevermind, haven't had enough coffee, yet :x
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64018 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 12:51 AM Revision 2ff85621 (git): thread.c (rb_thread_fd_select): remove unnecessary rb_fd_resize calls
- There's no need to resize each rb_fdset_t to match the size of
the biggest one. This can allow some small memory savings if
watching several sets of FDs simultaneously.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64017 b2dd03c8-3...
07/22/2018
-
10:55 PM Feature #12306: Implement String #blank? #present? and improve #strip and family to handle unicode
- > I've proposed String#space_only?, like String#ascii_only?.
I very much support `#space_only?`, it still fills the original goal of the ticket which is to eliminate the the fast_blank gem! -
- I am not sure exactly how we can pull this off, but this very much fits into our mission of making Ruby fast
http://engineering.appfolio.com/appfolio-engineering/2018/7/18/rubys-global-method-cache
https://engineering.shopify.com/1... -
09:59 PM Bug #14928: [BUG] Segmentation fault | Fiddle with Windows APIs
- > The second argument of RtlMoveMemory is source pointer, not the size.
> ...
While troubleshooting, I tried to allocate a memory, returns a pointer as the following:
~~~ ruby
buf = Pointer.malloc(Fiddle::SIZEOF_CHAR * shellcode.size... -
-
- This is a bug in your code, not ruby's.
```
rtl_move_memory.call(ptr.to_i, buf.size.to_i, shellcode_calc.size.to_i)
```
The second argument of `RtlMoveMemory` is source pointer, not the size.
And, `buf` is an array of single cha... -
06:42 PM Feature #14924: // floor division operator - > Out of curiosity what are you doing that needs integer division? :)
For example in my window manager I have some rules to determine how
windows should be sized and positioned (tiling).
~~~ ruby
# how many windows with 484px wi... - 04:03 PM Revision 0c32ffc7 (git): * 2018-07-23
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64016 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * object.c (rb_f_integer): prefer `base` optional argument over
keyword arguments. this issue should be resolved more generally
by separating keyword arguments from hashes in the future.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/... -
- Applied in changeset trunk|r64014.
----------
fix sum on infinity
* array.c (rb_ary_sum): consider non-finite floats.
[ruby-core:88024] [Bug #14926]
* enum.c (sum_iter): ditto. -
- * array.c (rb_ary_sum): consider non-finite floats.
[ruby-core:88024] [Bug #14926]
* enum.c (sum_iter): ditto.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64014 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- `nacl` support already removed by https://github.com/ruby/ruby/pull/1726.
[Fix GH-1920]
From: yuuji.yaginuma <yuuji.yaginuma@gmail.com>
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64013 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Some methods accept exception keyword argument since 2.6.0, but it is not documented in rdoc yet.
In NEWS,
* Kernel.#Complex takes :exception option to specify the way of error handling [Feature #12732]
* Kernel.#Float take... -
- funny.falcon@gmail.com wrote:
> normalperson (Eric Wong) wrote:
> > Yes. The "timeout scheduler" is the same idea I used for auto-fiber.
> > It uses ccan/list to manage a sorted list of timeouts.
>
> Still wonder, why you don't... -
- sample/trick2018/03-tompng ですが、trunk では動かないようです。
* `Gemfile` で `ruby '2.5.0'` に固定されているので、そのままだと trunk で bundle install できない
* `source 'https://rubygems.org'` がないので `bundle install` できないことがある (bundler の挙動がよくわかっていなくてできる場合とできない場合の違いがよくわ... - 02:53 AM Revision 0cc4bb7d (git): * 2018-07-22
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64012 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- with --jit.
`./ruby --jit -Itest/lib test/ruby/test_rubyoptions.rb -n "TestRubyOptions#test_verbose"`
has failed without -DMJIT_FORCE_ENABLE like:
1) Failure:
TestRubyOptions#test_verbose [/home/travis/build/k0kubun/mjit-test/test/ru...
07/21/2018
-
10:37 PM Bug #14926: Different results between Enumerable#sum and #reduce when Float::INFINITY present
- Yes, definitely a bug in the algorithm trying to minimize floating errors. Result must be `Float::INFINITY`.
shevegen (Robert A. Heiler) wrote:
> I am a bit surprised about infinity though:
> ...
Using `p` instead of `puts` will sho... -
- Applied in changeset trunk|r64008.
----------
sample/trick2018/: adds the top-five entries of TRICK 2018
See https://github.com/tric/trick2018 for TRICK 2018.
Fixes #14930. -
- まだ TRICK FINAL の上位作品が sample に追加されていないようです。
https://github.com/tric/trick2018
過去の回も含めて情報を探してみると以下のように、何作品を追加するのかは、以下の情報しかみつけられなかったので、以前の回の上位作品を追加した @mame さんに assign しておきます。
https://magazine.rubyist.net/articles/0043/0043-TRICK2013... - 01:07 PM Revision 85402fa3 (git): * properties.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64010 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 01:07 PM Revision c5229a94 (git): * append newline at EOF.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64009 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- See https://github.com/tric/trick2018 for TRICK 2018.
Fixes #14930.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64008 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 12:49 PM Feature #14924: // floor division operator
- ~~~ text
I think it may be subjective, 99 % of the time I do want integer
~~~
Out of curiosity what are you doing that needs integer division? :)
Still I think that 99% of people expect that when you divide 3 / 2 you get 1.5 (i... -
- We welcomed your feature. But We have some concerns.
The bundled documents increases tarball size caused by many of inode.
We need to resolve the problem of package size and other issues before accepting your proposal.
-
08:09 AM Feature #14859: [PATCH] implement Timeout in VM
- normalperson (Eric Wong) wrote:
> Yes. The "timeout scheduler" is the same idea I used for auto-fiber.
> ...
Still wonder, why you don't use binary min-heap for timers - most commonly used datastructure for this task.
It has guaran... -
- normalperson (Eric Wong) wrote:
> merch-redmine@jeremyevans.net wrote:
> ...
I think that a single iteration of MD5 is not a significant security improvement on DES:
```
class DigestAuth
def self.make_passwd(realm, use... -
- Applied in changeset trunk|r64007.
----------
thread.c (do_select): fix leak on exception
When do_select is interrupted and raise happens from
RUBY_VM_CHECK_INTS_BLOCKING, the original FD sets we copied
do not get freed, leading to a m... -
- ```
thread.c (do_select): fix leak on exception
When do_select is interrupted and raise happens from
RUBY_VM_CHECK_INTS_BLOCKING, the original FD sets we copied
do not get freed, leading to a memory leak. Wrap up all the
FD sets ... - 03:26 AM Revision 8d0f5f1b (git): thread.c (do_select): fix leak on exception
- When do_select is interrupted and raise happens from
RUBY_VM_CHECK_INTS_BLOCKING, the original FD sets we copied
do not get freed, leading to a memory leak. Wrap up all the
FD sets into a Ruby object to ensure the GC can release an
allo... -
12:34 AM Feature #14912: Introduce pattern matching syntax
- Thanks for the feedback.
> But I feel the deconstruct method of Struct in the sample code is tricky
> ...
It is trade-off with duck typing.
Consider following case.
```ruby
class MyA
def deconstruct
dummy = A[nil, nil]...
07/20/2018
- 10:30 PM Revision 33c74657 (git): * 2018-07-21
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64006 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 10:30 PM Revision 8f78430d (git): test/-ext-/gvl/test_last_thread.rb: skip under MJIT
- Spurious wakeup is unavoidable with MJIT; and any real
code must be able to deal with spurious wakeup anyways.
[ruby-core:87882] https://bugs.ruby-lang.org/issues/14901
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64005 b2dd03c8-3... -
- Hello guys
I need help in `Fiddle` it's really missing documentation and examples
I have the following code (https://gist.github.com/KINGSABRI/1871e748b51b6ef5c8f61a49a909b8c3)
The full error is right down the code
I'm trying to c... -
- eregontp@gmail.com wrote:
> normalperson (Eric Wong) wrote:
> > It's been a known problem for decades, now (at least since the
> > days of mod_perl + DBI on Apache 1.x); and AFAIK there's no data
> > leaks from it. Anybody who m... -
12:06 PM Feature #5446: at_fork callback API
- normalperson (Eric Wong) wrote:
> It's been a known problem for decades, now (at least since the
> ...
Yes, it's not a new problem.
I disagree about no production leaks, because it happened to me on a website running for a national p... -
- eregontp@gmail.com wrote:
> IMHO, this is is still very much needed for cases using plain fork().
> The default close-on-exec behavior is irrelevant for fork() without exec() and does not help.
Agreed.
> Inheriting, e.g., a data... -
08:23 PM Feature #14927: Loading multiple files at once
- Dir glob has to find all files, sort them, create objects.
Then require loads them again from the filesystem...
I think Dir.glob + require is a very common pattern and if we have a function like require_directory / require_tree? some... -
- I wanted to propose a more sophisticated load-process in ruby some time ago, but I never got
around it. I am even thinking of being able to load files based on abbreviations/shortcuts,
without necessiting a hardcoded path (e. g. requir... - 06:13 PM Feature #14927 (Assigned): Loading multiple files at once
- Just a proof concept I wanted to share. Maybe it could be useful?
Say you want to load all the .rb files in your lib directory:
~~~ ruby
Dir['lib/**/*.rb'].each { |file| load(file) }
~~~
This approach may not work if your ... -
- I sort of agree; I would have expected the same result.
Other arrays with numbers output the same result:
[1, 2, 3, 4, 5, 6, 7, 8, 9, 10].reduce(0, &:+) # => 55
[1, 2, 3, 4, 5, 6, 7, 8, 9, 10].sum # => 55
So ... -
04:25 PM Bug #14926 (Closed): Different results between Enumerable#sum and #reduce when Float::INFINITY present
- When `Float::INFINITY` is present in array, `Enumerable#sum` and `Enumerable#reduce(0, &:+)` are giving different results.
```
puts [Float::INFINITY].sum
puts [Float::INFINITY].reduce(0, &:+)
```
results in
```
NaN
Infinity... - 05:32 PM Feature #14924: // floor division operator
- > In my job, I have to do many math operations. And it's kind of a pain because of integer division (3 / 2 == 1). I have to constantly cast integers to floats.
I'm not sure if this is better for your use case, but as an
alternative ... - 01:45 PM Feature #14924: // floor division operator
- Oh too bad regular expressions use the same synthax. :(
Yes, it's a big breaking change to always return a float when dividing two integers. I understand that Matz doesn't want that.
So you can close this ticket then.
Thanks guys! -
- Changing the behavior of Integer#/ has been already rejected.
https://bugs.ruby-lang.org/issues/5512#note-12
> Too big incompatibility. Abandoned.
> ...
It might be possible to add a new operator // as an alias to Integer#quo, but... -
- There was an exactly same proposal (I can't remember the issue number), but rejected because it conflicted with a Regexp literal.
- 01:13 PM Feature #14924 (Rejected): // floor division operator
- Hello!
In my job, I have to do many math operations. And it's kind of a pain because of integer division (3 / 2 == 1). I have to constantly cast integers to floats.
Would it be a good idea to always return a float when you divide t... -
05:31 PM Bug #14923: Segmentation fault when running tests
- Please, disregard this bug.
-
- I can't say whether it is necessary or not; I test my ruby code
quite differently (and really sparingly) compared to many other
ruby hackers so I am not a good candidate to ask for any test
or assertion system/framework.
Some testi... - 01:27 PM Feature #14925 (Open): Kernel#assert(expression)
- Sometimes, you want to quickly test your code, but it's overkill to reach for a unit test library.
So could it be useful to add this method to Ruby?
~~~ ruby
def assert(expression)
expression or raise AssertionError, 'assertion... -
- I've proposed `String#space_only?`, like `String#ascii_only?`.
-
- merch-redmine@jeremyevans.net wrote:
> Personally, I think it's best to punt and require the user
> provide implementations for creating a password hash and
> checking the password hash via two callable options (e.g.
> :create_passw... -
- "Urabe, Shyouhei" <shyouhei@ruby-lang.org> wrote:
> normalperson (Eric Wong) wrote:
> > It's only the BasicAuth code and I have no idea how many people
> > use it; probably not many, but I don't want to break a single
> > user se... -
- * doc/*: Move entry to default gems category from standard library.
* lib/shell/*: Added `Shell::VERSION` and re-used it with @RELEASE_VERSION.
* test/shell/test_command_processor.rb: added missing require for test library.
* tool/... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64003 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64002 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 01:26 AM Revision 997830cd (git): * 2018-07-20
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64001 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64000 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
07/19/2018
-
- Dear developers.
When running minitest tests on my project https://github.com/diegojromerolopez/babik on branch feature/method-chaining there is a crash on the Ruby Virtual Machine.
To reproduce this problem:
- git clone git@githu... -
- IMHO, this is is still very much needed for cases using plain fork().
The default close-on-exec behavior is irrelevant for fork() without exec() and does not help.
Inheriting, e.g., a database connection in such a case is extremely har... -
- ashe@kivikakk.ee wrote:
> Are we still interested in pursuing something like this? I'd
> be happy to push it forward.
I'm not sure it's necessary, anymore. Most programs and libs
already have workarounds at this point. pthread_a... -
06:29 AM Feature #5446: at_fork callback API
- Are we still interested in pursuing something like this? I'd be happy to push it forward.
-
07:09 PM Feature #14922 (Closed): Resolv getaddresses ignores AAAA records for IPv6
- I'd like some feedback here as I'm not totally convinced this is a bug quite yet. I may have done something silly with my DNS configuration.
I have a local DNS server set up with the following /etc/resolv.conf
~~~
[root@ip-10-20-0-1... -
06:34 PM Bug #14920: Backport r63857 to fix performance problem on Time class in MacOs systems
- Thank you for changing the status and the backport information.
Yes, that patch seems safer, but when I applied only r63994 on top of v2_4_4 tag I still see the same results running the following script.
```
require 'benchmark'
... -
- Maybe r63994 is better to backport.
-
- (Changing status to closed; which triggers backporting process. This doesn't mean the request was rejected.)
-
- This retries r62655, which was reverted at r63863 for r63763.
tool/ruby_vm/views/_mjit_compile_insn.erb: revert the revert.
tool/ruby_vm/views/_mjit_compile_insn_body.erb: ditto.
tool/ruby_vm/views/_mjit_compile_pc_and_sp.erb: ditto.
to... - 11:22 AM Revision 33f2c894 (git): * 2018-07-19
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@63998 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@63997 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- I understand that FD inheritance dependent program doesn't work well with Ruby.
But I doubt that all external library create FDs with close-on-exec now.
spawn's close_others option would be useful workaround to avoid FD leak
with su... -
- Handle backport on #14920, close this ticket.
-
- shyouhei (Shyouhei Urabe) wrote:
> - Basic authentication itself does not require DES. It is an
> ...
Note that OpenSSL::KDF.scrypt is only defined if the OpenSSL library defines EVP_PBE_scrypt, so it isn't always available. I belie... -
- normalperson (Eric Wong) wrote:
> It's only the BasicAuth code and I have no idea how many people
> use it; probably not many, but I don't want to break a single
> user setup without adequate notice.
Understand your concern. T... -
- ```
ko1@atdot.net wrote:
> Hi,
>
> Could you explain your algorithm in pseudo code (or English)?
> Current `timeout` method call makes a thread and use `Thread#raise`.
>
> I assume that your idea is creating "timeout scheduler"... -
- Hi,
Could you explain your algorithm in pseudo code (or English)?
Current `timeout` method call makes a thread and use `Thread#raise`.
I assume that your idea is creating "timeout scheduler" in VM and it manages `timeout` calls an... -
-
- Please comment your favorite ticket numbers you want to ask to discuss with your *SHORT* comment or summary.
(your summary/comment will help us because we don't need to read all of ticket comments)
*DO NOT* discuss then on this ticke... -
- derosm2 (Mike DeRosa) wrote:
> `Date.new(2016, 3, 6).age #=> 2`
It might be nice to be able to specify a unit of time other than year.
~~~ ruby
Date.new(2016, 3, 6).age #=> 2
Date.new(2016, 3, 6).age(:year) #=> 2
Date.new(2016,... -
12:33 AM Bug #6282: strptime and fractions of seconds
- The docs at ruby-doc.org doesn't seem to reflect the fact that this functionality isn't available.
-
12:03 AM Feature #14473: Add Range#subrange?
- Thank you for your proposal Matz, having thought about it over the last few months, I agree.
I have updated my patch accordingly (which has greatly simplified/improved it), I welcome any comments.