Project

General

Profile

Activity

From 07/10/2018 to 07/16/2018

07/16/2018

06:42 PM Feature #14915: Deprecate String#crypt
merch-redmine@jeremyevans.net wrote:
> Because extensions use extconf.rb instead of configure for their
> configuration, this ports the related configure.ac code to
> extconf.rb. I'm not sure that is done correctly and works on
> a...
normalperson (Eric Wong)
05:53 PM Feature #14915 (Rejected): Deprecate String#crypt
This method is system and implementation dependent, and the
portable usage mentioned in the documentation is not truly
portable (doesn't work on OpenBSD) and insecure as it uses DES.
For systems that lack a crypt(3) implementation, Ru...
jeremyevans0 (Jeremy Evans)
06:17 PM Misc #14861: DevelopersMeeting20180718Japan
* [Feature #14914] Add BasicObject#instance_exec_with_block
* [Feature #14915] Deprecate String#crypt, move implementation to string/crypt
jeremyevans0 (Jeremy Evans)
06:44 AM Misc #14861: DevelopersMeeting20180718Japan
* [optimize `to_s` methods](https://github.com/ruby/ruby/compare/trunk...nobu:feature/opt_to_s)
nobu (Nobuyoshi Nakada)
05:12 PM Feature #14328: SIMD vectorization
@naruse I saw your blank implementation, impressive
https://github.com/ruby/ruby/commit/e6bc209abf81d53c2e3374dc52c2a128570c6055
the complexity for a hand written simd code is probably too high. Ruby supports a lot of platforms, so w...
ahorek (Pavel Rosický)
05:17 AM Feature #14328 (Open): SIMD vectorization
nobu (Nobuyoshi Nakada)
04:07 PM Feature #14914 (Rejected): Add BasicObject#instance_exec_with_block
Currently, you cannot use `instance_exec` with a block that requires a block argument. If you have a block that requires a block argument and you want to get the equivalent of `instance_exec`, you have to do something like:
~~~ ruby
...
jeremyevans0 (Jeremy Evans)
03:06 PM Revision e75fbfda (git): * 2018-07-17
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@63981 b2dd03c8-39d4-4d8f-98ff-823fe69b080e svn[bot]
03:06 PM Revision 400e5e33 (git): [DOC] Update doc of NameError.new [ci skip]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@63980 b2dd03c8-39d4-4d8f-98ff-823fe69b080e znz (Kazuhiro NISHIYAMA)
02:43 PM Revision 2af66d34 (git): No one knows how many leap seconds in year 2100
Just check whether leep seconds are considered or not.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@63979 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
naruse (Yui NARUSE)
10:20 AM Revision abb74388 (git): tool/downloader.rb:
* remove initial "./" from destdir to make downloading
./enc/unicode/data/11.0.0/ucd/auxiliary/GraphemeBreakProperty.txt
work properly
* tweak a comment
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@63978 b2dd03c8-39d4-4d8f-98ff...
duerst (Martin Dürst)
05:17 AM Feature #14382 (Closed): Make public access of a private constant call const_missing
nobu (Nobuyoshi Nakada)
05:05 AM Revision e39b2cff (git): ruby.c: disable DidYouMean as gem
* ruby.c (process_options): as DidYouMean requires Rubygems, disable
the former when the latter is disabled too.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@63977 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
nobu (Nobuyoshi Nakada)
04:35 AM Feature #14869: Proposal to add Hash#===
> また、再帰的なハッシュに対して使用したときに無限再帰にならないようにする必要がありそうです。
`Hash#==` を参考に `rb_exec_recursive_paired` を使用して再帰チェックするようにしてみました。
`rb_exec_recursive_paired` の挙動に関して詳細に理解していないのでそのあたりをレビューして頂けると助かります。
osyo (manga osyo)
02:07 AM Revision e70cad60 (git): parse.y (heredoc_identifier): Update comment for term_len
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@63976 b2dd03c8-39d4-4d8f-98ff-823fe69b080e yui-knk (Kaneko Yuichiro)
01:26 AM Revision 35244642 (git): * 2018-07-16
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@63975 b2dd03c8-39d4-4d8f-98ff-823fe69b080e svn[bot]
01:26 AM Revision d21f468d (git): parse.y: Add comment for `rb_strterm_heredoc_struct.sourceline`
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@63974 b2dd03c8-39d4-4d8f-98ff-823fe69b080e yui-knk (Kaneko Yuichiro)

07/15/2018

11:03 PM Feature #14912: Introduce pattern matching syntax
> Is the above exclusive for "in" in case, or can it be combined with "when"?
The former is right, but I don't have any strong opinion about it.
The reason why I select the former is that "in" is superset of "when".
ktsj (Kazuki Tsujimoto)
04:36 PM Feature #14912: Introduce pattern matching syntax
I have one question:
- Is the above exclusive for "in" in case, or can it be
combined with "when"?
E. g.:
case A[0, 1]
when 3
puts 'bla'
in (A, 1, 1)
# etc
?
shevegen (Robert A. Heiler)
04:35 PM Feature #14913: Extend case to match several values at once
I don't have a big pro or con opinion on the functionality itself.
However had, for the alternative syntax of:
case |x, y|
I think it is too reminiscent of block syntax style such as:
object.each {|x, y|
I would ra...
shevegen (Robert A. Heiler)
01:35 PM Feature #14913 (Closed): Extend case to match several values at once
This proposal is part of the search for how pattern matching or its elements could be gently introduced to Ruby.
[This blog post](https://zverok.github.io/blog/2018-06-26-pattern-matching.html) (authored by me) provides context and "ful...
zverok (Victor Shepelev)
02:13 PM Misc #14861: DevelopersMeeting20180718Japan
* [Feature #14913] Extend case to match several values at once
* some steps towards better pattern matching
zverok (Victor Shepelev)
11:15 AM Misc #14861: DevelopersMeeting20180718Japan
* [Feature #14912] Introduce pattern matching syntax
* pattern matching
mame (Yusuke Endoh)
11:45 AM Revision 7b98385d (git): node.h: remove unused macro nd_compile_option
Follow up of r61610
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@63973 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
ktsj (Kazuki Tsujimoto)
11:42 AM Revision a343f660 (git): vm_core.h, vm_dump.c: fix cast
Revert r63968 and cast at caller side to prevent unintentional casting.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@63972 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
ktsj (Kazuki Tsujimoto)
09:57 AM Revision 62870d2c (git): process.c: adjust indent [ci skip]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@63971 b2dd03c8-39d4-4d8f-98ff-823fe69b080e nobu (Nobuyoshi Nakada)
09:48 AM Revision 78a2a1be (git): insns.def: fix typo in comment
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@63970 b2dd03c8-39d4-4d8f-98ff-823fe69b080e ktsj (Kazuki Tsujimoto)
09:47 AM Revision 99b6ef93 (git): vm_dump.c: fix warning about constness
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@63969 b2dd03c8-39d4-4d8f-98ff-823fe69b080e ktsj (Kazuki Tsujimoto)
09:45 AM Revision 59b38273 (git): vm_core.h: add missing cast
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@63968 b2dd03c8-39d4-4d8f-98ff-823fe69b080e ktsj (Kazuki Tsujimoto)

07/14/2018

11:24 PM Feature #14912 (Closed): Introduce pattern matching syntax
I propose new pattern matching syntax.
# Pattern syntax
Here's a summary of pattern syntax.
```
# case version
case expr
in pat [if|unless cond]
...
in pat [if|unless cond]
...
else
...
end
pat: var ...
ktsj (Kazuki Tsujimoto)
05:04 PM Revision a70d5ff0 (git): * 2018-07-15
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@63967 b2dd03c8-39d4-4d8f-98ff-823fe69b080e svn[bot]
05:04 PM Revision 91061e74 (git): Fix documentation in Object#remove_instance_variable
It should be described that the string argument will be accept like Object#instance_variable_get.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@63966 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
watson1978 (Shizuo Fujita)
01:38 PM Feature #14473: Add Range#subrange?
How about `Range#{<,<=,>,>=}` like `Hash#{<,<=,>,>=}` for method names? znz (Kazuhiro NISHIYAMA)
11:18 AM Feature #5481: Gemifying Ruby standard library
hsbt (Hiroshi SHIBATA) wrote:
> You can commit it only github or MRI repo(SVN).
Good to know, so contributing to the gem's GitHub repo or directly in MRI are both supported?
> ...
This sounds a bit similar to the synchronization w...
Eregon (Benoit Daloze)
01:55 AM Feature #5481: Gemifying Ruby standard library
> @marcandre
> ...
You can commit it only github or MRI repo(SVN).
When you did commit code to github repo only, I merge them to MRI repo each week or month.
(The case of MRI to GitHub is same instructions.)
I'm developing a me...
hsbt (Hiroshi SHIBATA)
04:24 AM Bug #14911 (Rejected): Segmentation fault
nobu (Nobuyoshi Nakada)
02:59 AM Revision 1761f458 (git): * 2018-07-14
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@63965 b2dd03c8-39d4-4d8f-98ff-823fe69b080e svn[bot]
02:59 AM Revision b9f9986a (git): webrick/httpresponse: set_redirect requires a valid URI
Prevents response splitting and HTML injection attacks in
poorly-written applications which blindly pass along user input
in redirects.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@63964 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
Eric Wong

07/13/2018

03:43 PM Feature #12306: Implement String #blank? #present? and improve #strip and family to handle unicode
Sam suggested the topic to be discussed at the next upcoming ruby
developer meeting here recently:
https://bugs.ruby-lang.org/issues/14861
I'll add a few comments to the issue here as a consequence.
I am mostly neutral to the w...
shevegen (Robert A. Heiler)
03:18 PM Bug #14909: Method call with object that has to_hash method crashes (method with splat and keyword arguments)
https://bugs.ruby-lang.org/issues/14909#note-2 doesn't resolve the issue for me
> Why your object has to_hash method?
the objects in question are instances of `Dry::Validation::Result` (dry-validation gem)
> ...
Could this mayb...
johannes_luedke (Johannes Lüdke)
04:52 AM Bug #14909: Method call with object that has to_hash method crashes (method with splat and keyword arguments)
Why your object has `to_hash` method?
Ruby uses long named methods for implicit conversion: `to_str` - if your object should act as a string, `to_int` - if your object should act as an integer, `to_ary` - if your object should act as ...
funny_falcon (Yura Sokolov)
02:43 PM Bug #14911: Segmentation fault
Have you tried with 2.5.1 ? It does not seg fault with 2.5.1 ned (Ned Hadzo)
01:45 PM Bug #14911 (Rejected): Segmentation fault
Hi,
This `SyntaxError`
~~~ ruby
def foobar
‘x’, 'y'
end
~~~
But this `Segmentation fault`
~~~ ruby
def foobar
‘x’,nil
end
~~~
askn (Aşkın Gedik)
06:38 AM Misc #14861: DevelopersMeeting20180718Japan
Would it be possible to discuss: https://bugs.ruby-lang.org/issues/12306
"Implement String #blank? #present? and improve #strip and family to handle unicode"
sam.saffron (Sam Saffron)
06:05 AM Revision eb53b0ff (git): process.c (assert_close_on_exec): quiet warning about unused result
Not much we can do if writing to STDERR_FILENO fails.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@63963 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
Eric Wong
04:59 AM Bug #14908: Enumerator::Lazy creates unnecessary Array objects.
Indeed, as long as `Yielder#yield` is kept with arity -1 (as in this patch), indeed I don't think that would be an "incompatibility" we should worry about. marcandre (Marc-Andre Lafortune)
04:46 AM Bug #14908: Enumerator::Lazy creates unnecessary Array objects.
Eregon (Benoit Daloze) wrote:
> Changing Enumerator::Yielder#<< to have arity 1 seems fine to me, as I guess nobody calls << on an Enumerator::Yielder with more than 1 argument, isn't it?
Yes, that will be the general case. Exception...
chopraanmol1 (Anmol Chopra)
04:58 AM Bug #14891: Pathname#join has different behaviour to File.join
I'd rather say that File.join is currently broken, and it should behave like Pathname.join. But probably I'm missing something. funny_falcon (Yura Sokolov)
03:15 AM Revision 83b737d8 (git): test/ruby/test_signal.rb (test_sigchld_ignore): increase timeout
I suspect CI test machine was overloaded at the time,
or swapping at the time due to parallel build with mjit.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@63962 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
Eric Wong
01:15 AM Bug #14910: /usr/local/Cellar/ruby/2.5.1/lib/ruby/2.5.0/x86_64-darwin17/openssl.bundle: [BUG] Segmentation fault at 0x0000000000000001
nobu (Nobuyoshi Nakada) wrote:
> Seems that it happened in BoringSSL.
> ...
I don't konw, I use proxychains-ng as the proxy for the terminal.
I updated my system to 10.13.6 yesterday, and the programs related to ruby are not working a...
huangyanpeng (彦鹏 黄)

07/12/2018

11:23 PM Revision 20d3e1c8 (git): * 2018-07-13
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@63961 b2dd03c8-39d4-4d8f-98ff-823fe69b080e svn[bot]
11:23 PM Revision c6b85fcd (git): timer_thread: do not close pipes around fork
There's actually no need to close the pipes used by the
sleepy timer thread before forking, only to stop the timer
thread itself.
Instead, we only close the parent pipes in the child process,
either via close-on-exec flag or when reinit...
Eric Wong
09:39 PM Feature #14473: Add Range#subrange?
Not directly related, but if your ranges are such that begin <= end, then I think you can use `range.max > idx.max` for the last part. marcandre (Marc-Andre Lafortune)
06:55 AM Feature #14473: Add Range#subrange?
As real-world use-case,
I want it(include,cover version) for guarding NArray's Index arguments.
NArray#[] can accept Integer and Range.
Currently, to limit the access range, We have to write complex code.
~~~ ruby
def check(idx,ra...
tarui (Masaya Tarui)
01:05 PM Bug #14910 (Feedback): /usr/local/Cellar/ruby/2.5.1/lib/ruby/2.5.0/x86_64-darwin17/openssl.bundle: [BUG] Segmentation fault at 0x0000000000000001
Seems that it happened in BoringSSL.
https://boringssl.googlesource.com/boringssl/+/master#boringssl
> Although BoringSSL is an open source project, it is not intended for general use, as OpenSSL is. We don't recommend that third par...
nobu (Nobuyoshi Nakada)
11:16 AM Bug #14910 (Closed): /usr/local/Cellar/ruby/2.5.1/lib/ruby/2.5.0/x86_64-darwin17/openssl.bundle: [BUG] Segmentation fault at 0x0000000000000001
```
-- Control frame information -----------------------------------------------
c:0026 p:-17561534676150 s:0174 e:000173 TOP [FINISH]
c:0025 p:---- s:0171 e:000170 CFUNC :require
c:0024 p:0110 s:0166 e:000165 METHOD /usr/local/C...
huangyanpeng (彦鹏 黄)
12:29 PM Bug #14909: Method call with object that has to_hash method crashes (method with splat and keyword arguments)
At least, it behaves the same if passing a keyword arguments directly:
~~~ruby
def my_func(*objects, error_code: 400)
objects.inspect
end
my_func(to_hash_key: "to_hash") # => unknown keyword: to_hash_key (ArgumentError)
~~~
...
Eregon (Benoit Daloze)
11:21 AM Bug #14909 (Feedback): Method call with object that has to_hash method crashes (method with splat and keyword arguments)
In the plan of Ruby 3 (#14183), keyword arguments will be separated from other kinds of arguments. If this plan is implemented successfully, you can use `my_func(Test.new)` and `my_func(**Test.new)` for each purpose. If you call `my_fu... mame (Yusuke Endoh)
07:37 AM Bug #14909 (Closed): Method call with object that has to_hash method crashes (method with splat and keyword arguments)
In a method with a splat method argument followed by a keyword argument, it leads to an `ArgumentError` when calling the method with an object that reacts to `to_hash`
~~~ruby
def my_func(*objects, error_code: 400)
objects.inspe...
johannes_luedke (Johannes Lüdke)
09:25 AM Bug #14908: Enumerator::Lazy creates unnecessary Array objects.
Changing Enumerator::Yielder#<< to have arity 1 seems fine to me, as I guess nobody calls << on an Enumerator::Yielder with more than 1 argument, isn't it? Eregon (Benoit Daloze)
05:03 AM Bug #14908: Enumerator::Lazy creates unnecessary Array objects.
shyouhei (Shyouhei Urabe) wrote:
> Understand the problem. The proposed fix however involves spec change. We need to discuss effects of it before applying this patch.
If this is a big breaking change than alternate will be to creat...
chopraanmol1 (Anmol Chopra)
12:12 AM Bug #14908: Enumerator::Lazy creates unnecessary Array objects.
Understand the problem. The proposed fix however involves spec change. We need to discuss effects of it before applying this patch. shyouhei (Shyouhei Urabe)
07:53 AM Bug #12548: Rounding modes inconsistency between round versus sprintf
Ok
How about listing them in the format
name ......... height (rounded to whole centimetre)
sprintf would seem a great choice for that but fails due to it's rounding choices. By the way, I noticed this in the first place because...
unclekiki (Kieran McCusker)
12:53 AM Bug #12548: Rounding modes inconsistency between round versus sprintf
unclekiki (Kieran McCusker) wrote:
> Imagine you take the height of 100 school children to the nearest half centimetre and then want to output frequencies using sprintf to the nearest whole centimetre. Do you really want the frequencies...
nobu (Nobuyoshi Nakada)
07:35 AM Misc #14861: DevelopersMeeting20180718Japan
* [Bug #14908] `Enumerator::Lazy` creates unnecessary `Array` objects. nobu (Nobuyoshi Nakada)
06:40 AM Misc #14861: DevelopersMeeting20180718Japan
[Feature #14473] Add Range#subrange? (tarui)
tarui (Masaya Tarui)
05:01 AM Revision cb5598a4 (git): Improve branch misses
Improve branch misses on frozen object predicate checks negatively
affecting performance of most setters as most objects are not frozen.
[Fix GH-1913]
From: Lourens Naudé <lourens@bearmetal.eu>
git-svn-id: svn+ssh://ci.ruby-lang.org/r...
nobu (Nobuyoshi Nakada)
03:59 AM Revision bcf8ce84 (git): Fix compile error on debian8 and gentoo
https://rubyci.org/logs/rubyci.s3.amazonaws.com/debian8/ruby-trunk/log/20180711T213004Z.log.html.gz#miniruby
https://rubyci.org/logs/rubyci.s3.amazonaws.com/gentoo/ruby-trunk/log/20180711T213003Z.log.html.gz#miniruby
```
./include/ruby/r...
znz (Kazuhiro NISHIYAMA)
03:52 AM Bug #14906: MinGW failure - TestIO#test_copy_stream_no_busy_wait
normalperson (Eric Wong) wrote:
> Oops, sorry about that :x
No problem. I don't expect you or anyone else to know Windows. I'm well aware that the vast majority of production Ruby apps don't run on Windows.
It wasn't that lon...
MSP-Greg (Greg L)
03:32 AM Misc #14905 (Rejected): Strange behavior in Dir.glob using ** operator
It is same as zsh. nobu (Nobuyoshi Nakada)
12:06 AM Misc #14905: Strange behavior in Dir.glob using ** operator
Oops, sorry about that! In my efforts to anonymize the example, I broke it.
It's actually more like this:
~~~ text
human_records
├ project1 ─ records.yml
└ common ┬ records_one.yml
└ records_two.yml
cloud_records...
trobinson (Trevor Robinson)
02:29 AM Revision 1c904182 (git): removed unusecd constants
* ruby-runner.c (ruby_libm_func): removed as the following test
actually doesn't need the path of libm.
* test/fiddle/test_pointer.rb (Fiddle::TestPointer#test_free=):
removed never used constants and instance variables.
git-svn-id...
nobu (Nobuyoshi Nakada)
02:14 AM Revision 7c5a79ef (git): exe/ruby: link libm for fiddle test
* common.mk (exe/ruby): $(LIBS) should come after the source file
due to the ld spec.
* ruby-runner.c (ruby_libm_func): force to link libm for fiddle
test.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@63956 b2dd03c8-39d4-4d8f-...
nobu (Nobuyoshi Nakada)

07/11/2018

10:49 PM Revision 727e9017 (git): * 2018-07-12
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@63955 b2dd03c8-39d4-4d8f-98ff-823fe69b080e svn[bot]
10:49 PM Revision 706d2664 (git): benchmark/README.md: skip showing --timeout option [ci skip]
because it's only available for limited platforms for now.
I'll make it portable and show it later.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@63954 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
k0kubun (Takashi Kokubun)
08:03 PM Bug #14906: MinGW failure - TestIO#test_copy_stream_no_busy_wait
Greg.mpls@gmail.com wrote:
> r63947 was causing a test-all failure, as on Windows, one
> can't do `File.unlink(t.path)` if t is open (or before
> `t.close`). I did a PR, and a moment later, @znz pushed a
> commit. mswin passed te...
normalperson (Eric Wong)
01:29 PM Bug #14906: MinGW failure - TestIO#test_copy_stream_no_busy_wait
@normalperson
Eric,
r63947 was causing a test-all failure, as on Windows, one can't do `File.unlink(t.path)` if t is open (or before `t.close`). I did a PR, and a moment later, @znz pushed a commit. mswin passed test-all.
Tha...
MSP-Greg (Greg L)
09:52 AM Bug #14906: MinGW failure - TestIO#test_copy_stream_no_busy_wait
Greg.mpls@gmail.com wrote:
> https://bugs.ruby-lang.org/issues/14906

I made r63950 to skip tests to diagnose the issue.
I don't think threads are running at that point, but maybe
the thread leakchecker can find them...

You will...
normalperson (Eric Wong)
04:17 AM Bug #14906 (Closed): MinGW failure - TestIO#test_copy_stream_no_busy_wait
ruby-loco just had a failure on `TestIO#test_copy_stream_no_busy_wait` for the first time.
```
8) Failure:
TestIO#test_copy_stream_no_busy_wait [C:/projects/ruby-loco/src/ruby/test/ruby/test_io.rb:557]:
r58534 [ruby-core:80969] [...
MSP-Greg (Greg L)
07:52 PM Misc #14907: [PATCH] io.c: do not close inherited FDs by default
nobu@ruby-lang.org wrote:
> ```diff
> + r.close_on_exec = true
> + r.close_on_exec = true
> ```
>
> The second is `w`?

Yes :) But I prefer we drop this hunk and use make IO#new
set FD_CLOEXEC [ruby-core...
normalperson (Eric Wong)
03:29 PM Misc #14907: [PATCH] io.c: do not close inherited FDs by default
```diff
+ r.close_on_exec = true
+ r.close_on_exec = true
```
The second is `w`?
nobu (Nobuyoshi Nakada)
11:12 AM Misc #14907: [PATCH] io.c: do not close inherited FDs by default
> https://bugs.ruby-lang.org/issues/14907
> ...
Maybe this is a good complimentary change:
```diff
diff --git a/ext/socket/basicsocket.c b/ext/socket/basicsocket.c
index 2641b4410b..0418c022cf 100644
--- a/ext/socket/basicsocket...
normalperson (Eric Wong)
10:33 AM Misc #14907 (Closed): [PATCH] io.c: do not close inherited FDs by default
io.c: do not close inherited FDs by default
While I fully agree Ruby should create FDs with close-on-exec by
default (as it has since 2.0.0); I don't believe Ruby should be
arbitrarily closing file descriptors it does not know about...
normalperson (Eric Wong)
01:23 PM Bug #14908 (Closed): Enumerator::Lazy creates unnecessary Array objects.
Benchmark result on trunk:
~~~
user system total real
Lazy: 0.120000 0.000000 0.120000 ( 0.119958)
Normal: 0.056000 0.004000 0.060000 ( 0.062848)
2.142857 0.00000...
chopraanmol1 (Anmol Chopra)
01:00 PM Revision f2dec4ab (git): Failed to unlink before close on mswin
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@63953 b2dd03c8-39d4-4d8f-98ff-823fe69b080e znz (Kazuhiro NISHIYAMA)
12:33 PM Bug #12548: Rounding modes inconsistency between round versus sprintf
It is a real bug, it's just that, as I have said before, the "fix" took the wrong direction. sprintf should behave like round (as it does, or at least did, in jruby with no apparent issues). Round even is a very specialised use case.
...
unclekiki (Kieran McCusker)
01:55 AM Bug #12548: Rounding modes inconsistency between round versus sprintf
The current status is:
- We once have fixed this bug.
- That caused rails breakage.
- Everybody complained.
- So we reverted.
I personally believe this issue is a real bug but it seems I am a minority here. The consensus, if an...
shyouhei (Shyouhei Urabe)
10:28 AM Revision 304b5446 (git): test/ruby/test_io.rb (test_copy_stream_to_duplex_io): join thread
Don't leave runaway threads as it could affect other tests.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@63952 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
Eric Wong
09:56 AM Revision dae0f438 (git): Make block spacing consistent
[Fix GH-1910] [ci skip]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@63951 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
nobu (Nobuyoshi Nakada)
09:47 AM Revision 44d1929d (git): test/ruby/test_io.rb: skip garbage and CPU tests if multi-threaded
Threads should not be active during these tests, but
maybe they are...
ref: https://bugs.ruby-lang.org/issues/14906
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@63950 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
Eric Wong
09:26 AM Feature #9123: Make Numeric#nonzero? behavior consistent with Numeric#zero?
ana06 (Ana Maria Martinez Gomez) wrote:
> It is already 4 years since this was pointed out. I am really surprised that it is still inconsistent. It is not expected and make developers checking the documentation for something that could ...
bozhidar (Bozhidar Batsov)
08:49 AM Revision b2056425 (git): thread_pthread: avoid redundant error message on pipe2() fail
Seeing one error for pipe creation is enough.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@63949 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
Eric Wong
08:49 AM Revision 23f4ba46 (git): thread_pthread.c: use mask for timer implementation
timer-thread will continue to be supported, but future
"timer" implementation may not be a thread.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@63948 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
Eric Wong
08:33 AM Revision e22f3bf9 (git): test/test_{tempfile,tmpdir}: get rid of leftover files
I ran out of inodes in $TMPDIR
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@63947 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
Eric Wong
08:33 AM Revision 9366d709 (git): spec/ruby/security/cve_2018_6914_spec.rb: get rid of leftover files
I ran out of inodes in $TMPDIR :<
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@63946 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
Eric Wong
05:03 AM Feature #14904: Make it possible to run instance_eval with zero-arguments lambda
prijutme4ty (Ilya Vorontsov) wrote:
> My use case is just a simple example showing why current behavior isn't as good as it can be.
> ...
One problem here is the slippery slope. There are probably many core methods that take blocks wh...
jeremyevans0 (Jeremy Evans)
02:35 AM Feature #14904: Make it possible to run instance_eval with zero-arguments lambda
My use case is just a simple example showing why current behavior isn't as good as it can be.
That's not about lambdas at all. That's about instance_eval being more clever, because there's no reason to yield receiver to a block when b...
prijutme4ty (Ilya Vorontsov)
12:34 AM Revision 3e93bf3b (git): common.mk: upgrade benchmark_driver
benchmark/README.md: fix help output, which is changed on v0.14.6.
Especially `e1::path1,arg1,...; e2::path2,arg2` part was wrong since `,`
can't be used to split arguments anymore.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@6394...
k0kubun (Takashi Kokubun)
12:08 AM Misc #14905 (Feedback): Strange behavior in Dir.glob using ** operator
I cannot reproduce the issue on Linux. What OS are you using?
```
$ ruby -v
ruby 2.5.1p57 (2018-03-29 revision 63029) [x86_64-linux]
$ find human_records/ cloud_records/ -type f
human_records/person2/other_records.yml
human_re...
mame (Yusuke Endoh)

07/10/2018

11:56 PM Revision 1053c3d4 (git): benchmark/README.md: some are defined with YAML [ci skip]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@63944 b2dd03c8-39d4-4d8f-98ff-823fe69b080e k0kubun (Takashi Kokubun)
11:12 PM Misc #14905 (Rejected): Strange behavior in Dir.glob using ** operator
Hello,
I didn't want to report this as a bug because I'm not sure if it's intentional or not. The documentation didn't say either way. The `**` operator appears to work somewhat strangely when used in certain contexts.
An example s...
trobinson (Trevor Robinson)
05:41 PM Bug #12548: Rounding modes inconsistency between round versus sprintf
I don't think that Float#round and sprintf should have different default behavior. Whichever rounding mode is considered default should apply to both. Is there any consensus on this issue? vor_lord (Brett Williams)
04:10 PM Revision 4b2f2225 (git): Use "diagnose_if" attribute for clang
Before this patch, clang shows many "division by zero is undefined" errors
if a files has syntax error.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@63943 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
naruse (Yui NARUSE)
04:03 PM Revision fdd7f57b (git): benchmark/README.md: fix typo [ci skip]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@63942 b2dd03c8-39d4-4d8f-98ff-823fe69b080e k0kubun (Takashi Kokubun)
03:58 PM Revision 3efcb740 (git): benchmark: revise ERB benchmarks using YAML syntax
to improve the accuracy of measurement by stop using block.
benchmark/app_erb.rb -> benchmark/app_erb.yml: renamed and revised
benchmark/erb_render.rb -> benchmark/erb_render.yml: ditto
benchmark/README.md: follow renames
git-svn-id: ...
k0kubun (Takashi Kokubun)
03:51 PM Revision 498487ec (git): benchmark/README.md: erb_render is no longer yml but rb [ci skip]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@63940 b2dd03c8-39d4-4d8f-98ff-823fe69b080e k0kubun (Takashi Kokubun)
03:49 PM Revision 301cb9ea (git): benchmark/README.md: wording consistency in one sentence [ci skip]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@63939 b2dd03c8-39d4-4d8f-98ff-823fe69b080e k0kubun (Takashi Kokubun)
03:44 PM Revision cf438cae (git): * properties.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@63938 b2dd03c8-39d4-4d8f-98ff-823fe69b080e svn[bot]
03:44 PM Revision 5d35664a (git): output/driver.rb: add output plugin to reproduce
the original behavior of benchmark/driver.rb.
Probably I won't use this but this is requested by ko1.
Use this with:
make benchmark OPTS="-o driver"
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@63937 b2dd03c8-39d4-4d8f-98ff-823fe6...
k0kubun (Takashi Kokubun)
03:06 PM Revision 020bb758 (git): revert r63899
this is no longer needed due to r63926
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@63936 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
k0kubun (Takashi Kokubun)
03:01 PM Revision eaf312d0 (git): * properties.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@63935 b2dd03c8-39d4-4d8f-98ff-823fe69b080e svn[bot]
03:01 PM Revision 2d47a1eb (git): * 2018-07-11
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@63934 b2dd03c8-39d4-4d8f-98ff-823fe69b080e svn[bot]
03:01 PM Revision f328fe40 (git): benchmark_driver/runner: add runners for metrics
supported by legacy benchmark/driver.rb.
benchmark/README.md: document them
common.mk: update benchmark_driver to correct 0.0 output and to fix
spacing format of `-o simple` and `-o markdown`.
git-svn-id: svn+ssh://ci.ruby-lang.org/ru...
k0kubun (Takashi Kokubun)
02:16 PM Revision 79a8c10b (git): runner/size.rb: fix metric passed to output
runner/peak.rb: ditto
This is needed to make commands like `make -C .ruby-svn benchmark
ITEM=erb OPTS="-r size -o simple"` succeed.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@63932 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
k0kubun (Takashi Kokubun)
01:41 PM Revision 34eed0cd (git): benchmark/README.md: add help output [ci skip]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@63931 b2dd03c8-39d4-4d8f-98ff-823fe69b080e k0kubun (Takashi Kokubun)
01:36 PM Revision 59ec265e (git): benchmark/README.md: don't recommend alias installation [ci skip]
benchmark_driver is the official way to install benchmark_driver.
benchmark-driver is just an alias for it.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@63930 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
k0kubun (Takashi Kokubun)
01:16 PM Revision 83c53894 (git): common.mk: execute benchmark alphabetically
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@63929 b2dd03c8-39d4-4d8f-98ff-823fe69b080e k0kubun (Takashi Kokubun)
01:08 PM Revision 433af161 (git): benchmark: drop all bm_ prefix for legacy driver.rb
benchmark/*.rb is only benchmarks now. We don't need prefixes.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@63928 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
k0kubun (Takashi Kokubun)
01:05 PM Revision f992f425 (git): * properties.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@63927 b2dd03c8-39d4-4d8f-98ff-823fe69b080e svn[bot]
01:05 PM Revision 8068d34c (git): Revert "benchmark/*.yml: convert from benchmark/bm_*.rb"
This reverts r63900.
Having single-execution benchmark as a normal Ruby script is preferred
by ko1. I'm not a big fan of having inconsistent benchmark formats, but
I can understand some benefits of it.
common.mk: remove obsolsted bench...
k0kubun (Takashi Kokubun)
12:14 PM Revision bd12037e (git): * properties.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@63925 b2dd03c8-39d4-4d8f-98ff-823fe69b080e svn[bot]
12:14 PM Revision 12a38cba (git): benchmark: resurrect peak / size metrics
by adding runner plugins for them.
benchmark/lib/benchmark_driver/runner/peak.rb: added peak runner plugin
benchmark/lib/benchmark_driver/runner/size.rb: added size runner plugin
common.mk: allow using them
benchmark/memory_wrapper.rb:...
k0kubun (Takashi Kokubun)
04:18 AM Feature #5481: Gemifying Ruby standard library
Thank you for putting matrix and ostruct as gems :-)
I’m not sure where to commit changes to the libraries now: do the
commits need to be done in the gem’s github repo *and* in MRI’s repo?
(Sorry, I couldn’t find instructions!)
marcandre (Marc-Andre Lafortune)
01:12 AM Feature #14904: Make it possible to run instance_eval with zero-arguments lambda
-1. Seems you are already aware of the fact that lambdas are different from procs in handling of the arguments. Lambdas are strict, procs are loose. You are requesting to confuse this distinction. This is not a wise idea. At the beg... shyouhei (Shyouhei Urabe)
 

Also available in: Atom