Activity
From 04/10/2018 to 04/16/2018
04/16/2018
-
10:45 PM Feature #13683: Add strict Enumerable#single
- matz (Yukihiro Matsumoto) wrote:
> Hmm, I don't like the name `single`. Besides that, I think it may be useful for database access, but I don't see the use-case of this method for generic Enumerable.
> ...
I think of single as a method... -
12:46 PM Bug #14689 (Closed): bootsnap gets object index out of range: 266287972352 (IndexError) since r63113
- Applied in changeset trunk|r63167.
----------
compile.c: align range
* compile.c (ibf_dump_object_struct): align range elements.
[ruby-core:86548] [Bug #14689] -
06:52 AM Bug #14689 (Closed): bootsnap gets object index out of range: 266287972352 (IndexError) since r63113
- # Steps to reproduce
~~~ text
$ rbenv install 2.6.0-dev
$ rbenv global 2.6.0-dev
$ git clone https://github.com/Shopify/bootsnap
$ cd bootsnap
$ bundle
$ rake
$ bundle exec bin/testunit
~~~
# Expected result as of r63112
~~~... -
- * compile.c (ibf_dump_object_struct): align range elements.
[ruby-core:86548] [Bug #14689]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@63167 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
12:33 PM Bug #14690 (Closed): Invalid CMDARG state after command_args followed by tLBRACE_ARG
- ~~~ ruby
assert_valid_syntax('let () { m(a) do; end }')
~~~
The patch that fixes it is attached.
tLBRACE_ARG does "CMDARG_PUSH(0)" in the lexer and then the parser leaves the "command_args" rule. The parser does "CMDARG_POP" to r... -
10:20 AM Revision b2839bac (git): [DOC] Fix links of cve [ci skip]
- `http://www.cve.mitre.org/` seem to move `http://cve.mitre.org/`.
I can't access `http://www.cve.mitre.org/`.
[Fix GH-1857]
From: willnet <netwillnet@gmail.com>
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@63166 b2dd03c8-39d4-4d8... -
10:03 AM Feature #14344: refine at class level
- I am a MRI committer. This is just my opinion, but I'm confident it is shared by other committers as well.
I believe changing the semantics of `refine` (to be using+Module.new+refine) based on whether the receiver is a Class or Module... -
- I like this. If nobody has an objection, I want to `deprecate_constant` the old one, and would like the same fix for Net::ProtoServerError as well.
-
- * parse.y (keyword_else): warn less-indented `else` than `case`.
[ruby-core:86492] [Bug #14674]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@63165 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Applied in changeset trunk|r63164.
----------
string.c: fix dumped suffix
* string.c (rb_str_dump): get rid of an error on evaling with
frozen-string-literal enabled. [ruby-core:86539] [Bug #14687] -
- * string.c (rb_str_dump): get rid of an error on evaling with
frozen-string-literal enabled. [ruby-core:86539] [Bug #14687]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@63164 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 06:37 AM Revision bfbf7a35 (git): * 2018-04-16
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@63163 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * string.c (str_undump): check for suffix before if Unicode escape
conflicts with it. the message "but used force_encoding" sounds
strange when it is not used.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@63162 b2dd03c8-39d4-4...
04/15/2018
-
04:12 PM Feature #14656: Improve mkmf error message when ruby.h is missing
- nobu already solved this, but I wanted to make one comment to:
> Maybe the error message could hint at this solution?
I think one problem is that the splitting of packages is done
by distributions, not by the ruby core team or... -
- Let's let nil remain nil rather than maybe become maybe-nil.
-
01:37 PM Feature #14688 (Closed): Net::HTTPResponse#value raises "Net::HTTPServerException" in 4xx response
- Call `value` method to an instance of `Net::HTTPResponse` it raises `Net::HTTPServerException` in case of HTTP response status code is 4xx.
But HTTP response status code 4xx means "Client error response" not "Server response" so I thi...
04/14/2018
-
04:51 PM Revision 5bae48bd (git): thread_sync.c: [DOC] fix typo
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@63161 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@63160 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@63159 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@63158 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@63157 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@63156 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@63155 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * random.c: [DOC] improve language and RDoc markup in Random.bytes docs;
also adjust call-seq style of Random.bytes and Random#bytes.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@63154 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 04:43 PM Revision 136643a8 (git): * 2018-04-15
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@63153 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * complex.c: [DOC] correct term "real value" to "real part", and same
for imaginary part, in documentation for Complex#{finite?,infinite?}.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@63152 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
02:05 PM Revision 0cd595cb (git): Extend timeout
- On armv7 environment, the timeout is too short
http://rubyci.s3.amazonaws.com/scw-9d6766/ruby-trunk/log/20180319T191706Z.diff.html.gz
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@63151 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Applied in changeset trunk|r63150.
----------
irb.rb: restore the last error
* lib/irb.rb (eval_input): restore the last error `$!`, as the
previous result. [Feature #14684]
* lib/irb/context.rb (evaluate): add `exception` keyword ... -
- * lib/irb.rb (eval_input): restore the last error `$!`, as the
previous result. [Feature #14684]
* lib/irb/context.rb (evaluate): add `exception` keyword argument
to set the last error.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@63149 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@63148 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
04/13/2018
-
09:36 PM Revision 5bafb6c5 (git): Add write barrier calls for direct marking objects.
- This commit adds write barriers for objects marked from `rb_iseq_mark`.
r62851 introduced direct marking from iseqs to:
* keyword arg default values
* catch table iseqs
* VALUEs embedded in encoded instructions
This patch adds missing ... -
- * lib/irb.rb (handle_exception): show backtrace from the topmost
if stdout is not a tty.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@63146 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 06:06 PM Revision a90e2426 (git): * 2018-04-14
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@63145 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@63144 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
03:20 PM Feature #14685: IRB doesn't print exception cause
- Note that per @Hanmac above in comment #2, separate work might be necessary to also print the `#cause` in default Ruby uncaught exception print out. But that is not the subject of this issue.
Hanmac -- should I open a separate issue t... -
- May I ask: a very quick path to solving this would be for me (or someone else) to turn my workaround monkey-patch of IRB (see comment #1 above) into a pull request to IRB in the standard library.
Ruby maintainers: are you interested i... -
05:46 AM Feature #14685: IRB doesn't print exception cause
- i tested it with multiple ruby versions, both irb and ruby, because i wanted to see what happen
irb doesn't print the cause, but ruby itself doesn't do too.
should that be done in ruby itself too?
(and maybe a way to disable that?) -
- nobu (Nobuyoshi Nakada) wrote:
> `$!` isn't accessible outside `rescue` clause, even without irb.
In IRB, should `$!` be set, or a proxy for it be set, when the IRB eval handles an exception? -
- `$!` isn't accessible outside `rescue` clause, even without irb.
-
12:50 AM Feature #14684 (Assigned): IRB swallows exceptions
-
- * file.c (ruby_is_fd_loadable): allow character devices to load,
e.g., `ruby /dev/null` exits successfully.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@63143 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
03:22 AM Bug #14687 (Closed): TestM17N#test_str_dump, String.dump, frozen-string
- The test `TestM17N#test_str_dump` located in `test/ruby/test_m17n.rb` (link at https://github.com/ruby/ruby/blob/83c961665def138e78a66d8bef0b4fa1da49ac69/test/ruby/test_m17n.rb#L324-L363), fails when run with frozen-string.
The test i... -
01:50 AM Bug #13670: [BUG] Bus Error at 0xefce7b (armv7l) (ruby 2.3.4p301)
- Disregard the failed tests above - second build installed okay.
Still hitting the bug very occasionally, but finding it very hard to reproduce reliably.
-
- Probably better to use `Function.const_defined?(:STDCALL)` than `defined?(Function::STDCALL)`
-
- While testing the test/ruby folder with frozen-string, I came across a few issues. More later...
I had the following failures in test_rubyoptions.rb, which were due to output on stderr:
```
3) Failure:
TestRubyOptions#test_fro... -
04/12/2018
-
- Applied in changeset trunk|r63141.
----------
parse.y: `when` indent
* parse.y (k_when): warn less-indented `when` than `case`.
[ruby-core:86492] [Bug #14674] -
07:23 AM Bug #14674: New mismatched indentations warnings?
- I agree with @marcandre. I used to prefer "indented when" style once, and still think it is pretty acceptable.
When Ruby has introduced interpreter warnings about mismatched indentation, I thought it is a good thing, allowing to catc... -
05:11 AM Bug #14674: New mismatched indentations warnings?
- I strongly believe that it is not Ruby's parser job to warn us about styling, especially if there's no strong reason to suspect that it's a programmer error.
I realize rubocop is not official or part of MRI, but it has the required qu... -
- It was intentional, but mismatched with your style?
- 10:13 PM Revision 83c96166 (git): * 2018-04-13
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@63142 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * parse.y (k_when): warn less-indented `when` than `case`.
[ruby-core:86492] [Bug #14674]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@63141 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- nobu (Nobuyoshi Nakada) wrote:
> `RubyVM::InstructionSequence#to_binary` and `RubyVM::InstructionSequence.load_from_binary` had bugs around word alignments.
> ...
Getting 3 failures from `make check`
~~~
1) Failure:
DRbTests::Te... -
- `RubyVM::InstructionSequence#to_binary` and `RubyVM::InstructionSequence.load_from_binary` had bugs around word alignments.
I think the trunk has been fixed, couldn't you try it? -
- For Ruby 2.3.4, here is a working monkey-patch which causes IRB to behave as expected above:
https://gist.github.com/ms-ati/c11658166c8844dfa6b1caed480d02b3 -
- # Summary
IRB doesn't print `Exception#cause`.
Because IRB also doesn't offer access to raised exceptions (see https://bugs.ruby-lang.org/issues/14684), in effect this make the `#cause` of exceptions inaccessible without extra wor... -
04:50 PM Feature #14683: IRB with Ripper
- ref. https://github.com/ruby/rdoc/pull/512
-
- I replaced lexical analyzer with Ripper. It's important for supporting new syntax.
I explain what I did.
## Replace with Ripper
I talked with @matz about it and I decided to use mirb of mruby as a reference.
https://github.com/... -
- # Summary
IRB swallows exceptions, doesn't provide programatic access to raised exception in session.
## Details
On Ruby 2.3.4, we find it surprising that exceptions in IRB are swallowed, and are not accessible at the two locati... - 02:24 PM Revision 2625c6a7 (git): * properties.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@63140 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
02:24 PM Revision dfeafff3 (git): [DOC] Add win32/README.win32 to .document
- see https://github.com/ruby/docs.ruby-lang.org/issues/56
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@63139 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@63138 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * error.c (name_err_init_attr): hide the receiver object from
Marshal, as DRb depends on it.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@63137 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
07:09 AM Bug #14682 (Closed): Error [BUG] unexpected THREAD_KILLED
- Hi there an error, and the attached file.
./Users/murbano/.rvm/rubies/ruby-2.5.1/lib/ruby/2.5.0/monitor.rb:200: [BUG] unexpected THREAD_KILLED
ruby 2.5.1p57 (2018-03-29 revision 63029) [x86_64-darwin17]
-- Crash Report log informa... -
04:06 AM Feature #13626: Add String#byteslice!
- By the way, I ended up implementing https://github.com/socketry/async-io/blob/master/lib/async/io/binary_string.rb which I guess is okay but it's not ideal.
-
- If you round trip UTF-8 to ASCII-8BIT and back again, the result should be the same IMHO. It's just the interpretation of the bytes which is different, but the underlying data should be the same. I still think adding `String#byteslice!` ...
-
- Applied in changeset trunk|r63136.
----------
error.c: super in method_missing
* error.c (nometh_err_initialize): do not shirtcut rb_call_super,
to push proper control frame. [ruby-dev:50522] [Bug #14670]
* error.c (rb_nomethod_err... -
- * error.c (nometh_err_initialize): do not shirtcut rb_call_super,
to push proper control frame. [ruby-dev:50522] [Bug #14670]
* error.c (rb_nomethod_err_new): allocate and initialize a new
NoMethodError instance.
* vm_eval.c (rb_m... - 03:40 AM Revision fe96e87e (git): * 2018-04-12
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@63135 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * test/ruby/marshaltestlib.rb (test_exception): use separate
clean object to raise an exception. TestCase instance often has
modules included.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@63134 b2dd03c8-39d4-4d8f-98ff-823fe69b... -
- I confirmed the issue also applies to 2.5.1
I add a mutex to the write and close operations (which should not be necessary) and it "fixes" the issue.
```
100.times.collect do
Thread.new do
mutex = Mutex.new
input, output =... -
- Perhaps related to https://bugs.ruby-lang.org/issues/13632
Here is a sample to reproduce the issue.
```
#!/usr/bin/env ruby
require 'thread'
puts RUBY_VERSION
100.times.collect do
Thread.new do
input, output = IO.pip...
04/11/2018
-
- Can confirm this still happening in 2.5.1
~~~
ruby 2.5.1p57 (2018-03-29 revision 63029) [armv7l-linux-eabihf]
bootsnap (1.3.0)
Rails 5.2.0
~~~
Rails adds bootsnap to a new app by default as of version 5.2.0
any call to `rails` (... -
08:02 PM Feature #14680: Adding +@ and -@ to hash and array
- I don't think it's as common these days to see `.freeze` all over the place, since the linters explicitly tell you to use the frozen string literal comment. But that's explicitly for literals. There are plenty of cases where you'd want t...
-
- I like `.dup` and `.freeze`, more than `+` and `-` on class `String`.
https://ruby-doc.org/core-2.5.0/String.html#method-i-2B-40
The only good thing is that I don't have to use any of these
methods so ultimately I don't have to ca... -
- Since we have `-@` and `+@` for strings and it's very useful (and reads better than `.freeze`) I'd like to propose adding the same API to hash and array. Especially with constants, linters are always telling me to freeze them, and I'd li...
-
03:56 PM Feature #14672: Introduce a Date.safe_parse method
- http://blog.honeybadger.io/benchmarking-exceptions-in-ruby-yep-theyre-slow
exceptions are used a lot in parsers
https://github.com/ruby/csv/blob/master/lib/csv.rb#L342
having an oportunity to skip exception handing could also improv... -
02:29 PM Feature #14672: Introduce a Date.safe_parse method
- Why not just use a one line rescue?
~~~ ruby
Date.parse(some_value) rescue Date.new(2018,1,1)
~~~
It shows IMHO the intention very clear. -
- I agree with the points above, so this issue can be closed (or someone can teach me how to close these, I'm not entirely sure how).
-
- I haven't contributed before so I'm not sure how to bump this ticket, but I'd like to keep pushing on this. Could someone from core take a look at this proposal? I'd love to help introduce this syntax.
-
-
12:01 PM Bug #14679: StdLib gems should properly specify their dependencies
- Also, if Ruby one day decides to drop JSON support for whatever reason, the RDoc won't be usable after installation, since it will be missing json dependency.
-
- Could you please properly specify gem dependencies for gems included in StdLib? The current situation is unfortunate.
Let me give you hypothetical example. Lets say there is RDoc 7.x under development and it will depend on JSON 3.x li... -
- Could you show small code to reproduce it and/or show local variables with a debugger?
-
10:21 AM Bug #14678 (Closed): Segmentation fault in pg
- This error don't reproduce in Ruby 2.5.0 but reproduce in 2.5.1
~~~
$ bundle ex rspec
/Users/tanimichi.tsukuru/ghq/github.com/moneyforward/moneyplus/vendor/bundle/ruby/2.5.0/gems/pg-0.21.0/lib/pg.rb:56: [BUG] Segmentation fault at 0... -
08:08 AM Bug #14566: `raise` in `Exception#message` causes infinite loop
- Thx!
-
- Applied in changeset trunk|r63133.
----------
eval_error.c: fix loop on exception in message
* error.c (rb_get_message): accessor to the message.
* eval_error.c (rb_ec_error_print): handle exceptions on fetching
the message. [Bug #... -
- It should work as well as 2.4, not `fatal`.
-
- Thank you, I've missed the report mail.
I think it fatal. -
- * error.c (rb_get_message): accessor to the message.
* eval_error.c (rb_ec_error_print): handle exceptions on fetching
the message. [Bug #14566]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@63133 b2dd03c8-39d4-4d8f-98ff-823fe69... -
- I think in the long run it would be nice if ruby hackers have more
control over non-error messages (e. g. warnings).
Some may prefer ruby providing cues for a more consistent code
layout but others may not necessarily care that much... -
- It's issue of https://github.com/ConnorAtherton/rb-readline
-
- It's issue of https://github.com/ConnorAtherton/rb-readline
-
- It's issue of https://github.com/ConnorAtherton/rb-readline
-
- At present, RubyInstaller2 builds are using RbReadline (the rb-readline gem). RubyInstaller builds also used it.
The gem is not really maintained. I believe Lars Kanis is working on updating the readline package to work with Windows...
04/10/2018
-
10:46 PM Bug #14676: On Windows Readline's input is not correctly filled after autocomplete
- Works when the string is actual prefix for the completion.
```
require 'readline'
Readline.completion_proc = Proc.new do |word|
['aafoo', 'aabar']
end
while buf = Readline.readline('> ')
pp buf
end
```
produces
```
... -
- When Readline.completion_proc returns more than one match, you are presented with empty line insted of what you have already put in.
```
require 'readline'
Readline.completion_proc = Proc.new do |word|
['foo', 'bar']
end
while ... -
- I think it should raise NotImplementedError instead as other method in Readline claim to do.
-
- On Windows Readline.redisplay raises NoMethodError while according to docs it should raise NotImplementedError.
-
- I recently got a failure in my test suite because ruby head warns of indentation it considers mismatched:
```
$ ruby -w -e "
case
when :foo
end
"
-e:3: warning: mismatched indentations at 'when' with 'case' at 2
```
I hop... -
- I can understand the proposal.
I think your primary use case is to be able to use less code,
without needing to rescue all (or the important) errors specifically
via begin/rescue.
Perhaps it can be mentioned in the ruby developer... -
07:19 AM Feature #14672 (Open): Introduce a Date.safe_parse method
- This feature request is about a Date.safe_parse method.
The method should call the original Date.parse method but avoid raising an exception and returning a fallback value instead.
An implementation in ActiveSupport has been proposed h... - 03:29 PM Revision a7c7cfb8 (git): * 2018-04-11
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@63132 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- see https://github.com/ruby/docs.ruby-lang.org/issues/56
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@63131 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- I tried making a patch fixing this issue. See attached.
This patch makes the behaviour similar to the old Ruby, rescuing any exceptions in the "message" method, but also warns that an exception was automatically caught.
I'm not 100... -
09:51 AM Misc #14673 (Open): Documentation for `Array#drop` / `drop_while` unclear in regard to modification
- The documentation for [`Array#drop`](http://ruby-doc.org/core-2.5.0/Array.html#method-i-drop) says:
> Drops first `n` elements from `ary` and returns the rest of the elements in an array.
It's unclear if the receiver is being chang... -
06:27 AM Bug #14671 (Rejected): Refining Module#refine itself introduces strange state
- ```ruby
using Module.new {
refine Module do
def refine *;
puts self
end
public :refine
end
}
Object.refine # => NoMethodError
```
It is possible to refine Module#refine, but there seems to be no way to ... -
- Applied in changeset trunk|r63130.
----------
symbol.c: non-ASCII constant names
* symbol.c (rb_sym_constant_char_p): support for non-ASCII
constant names. [Feature #13770]
* object.c (rb_mod_const_get, rb_mod_const_defined): suppo... -
- * symbol.c (rb_sym_constant_char_p): support for non-ASCII
constant names. [Feature #13770]
* object.c (rb_mod_const_get, rb_mod_const_defined): support for
non-ASCII constant names.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/tru... -
12:04 AM Bug #14480 (Open): miniruby crashing when compiled with -O2 or -O1 on aarch64
- Sorry for the confusion, I am not one of "upstream".
So I revert the issue status and there are no upstream opinion.
I am sorry again.