Activity
From 03/19/2018 to 03/25/2018
03/25/2018
-
09:47 PM Bug #14556: Please fetch Ripper's new features from nobu's patches bag (irb-ripper branch)
- I implemented IRB's new logic with Ripper without these patches. Please close this.
-
09:41 PM Bug #14263: Array Intersection does not seem to use hash
- Attached are two patches:
- One which uses hash comparison for both the optimised "small" array branch and the default implementation of the `Array` set operations (essentially restoring the behaviour of Ruby < 2.5)
- Another which a... -
03:56 PM Feature #14473: Add Range#subrange?
- I've attached an updated patch; it includes the renamed (by `s/set/range/`) methods and a performance improvement for `strict_subset?` (before, we would calculate `max` on the receiver twice, which is potentially slow when the receiver ...
-
03:54 PM Bug #14630 (Closed): DON'T IGNORE ME!!! Uncaught exception: SSL_connect returned=1 errno=0 state=error: certificate verify failed (error number 1)
- I'm attempting to connect to a server with verify_mode = OpenSSL::SSL::VERIFY_PEER. It fails with the error:
Uncaught exception: SSL_connect returned=1 errno=0 state=error: certificate verify failed (error number 1)
/usr/local/Cella... -
02:06 PM Revision f28d6165 (git): assertions for r62914
- * test/ruby/test_keyword.rb (test_splat_hash): assertion on
mandatory and rest arguments. r62914 is not only for optional
argument.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62919 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Now:
```
$ ruby -e ' \ '
-e:1: syntax error, unexpected escaped space
```
Close this for now. -
-
07:32 AM Feature #14594: Rethink yield_self's name
- I disagree with the names proposed, but I agree that the current name is too long.
Here are yet other name candidates from me:
* deform
* expand
* reform
Edit. I just realized that reform has already been mentioned. Sorry. -
- `map` is one of the worst names for this feature in my opinion. Generalizaing from cmoel's proposal to use `map` for this feature, we expect:
```ruby
[1].map{|e| e * 2} #=> [1, 1]
```
but that is not what we currently have, nor d... -
06:11 AM Bug #14604: Backport r62725 to ruby 2.3 to 2.5
- ruby_2_4 r62918 merged revision(s) 62725.
-
- Fix setting method visibility on method wrapped with prepend
Ignore prepended modules when looking for already defined methods on a
class to set the visibility on.
[Fix GH-1834]
From: Dylan Thacker-Smith... -
- ruby_2_4 r62917 merged revision(s) 62673.
-
- thread.c: deadlock in backtrace
* thread.c (unblock_function_set): check interrupts just once
during raising exceptions, as they are deferred since r16651.
[ruby-core:85939] [Bug #14577]
git-svn-id: svn+ssh:... -
- ruby_2_4 r62916 merged revision(s) 62394,62395.
-
- vm_insnhelper.c: rb_autoloading_value flag
* vm_insnhelper.c (vm_get_ev_const): add flag argument of
`rb_autoloading_value`.
* constant.h (rb_autoloading_value): moved the declaration from
vm_core.h ... -
- ruby_2_4 r62915 merged revision(s) 62671.
-
- resolv.rb: close socket
* lib/resolv.rb (UnconnectedUDP#lazy_initialize): store new
sockets before binding, so the sockets get closed when the
requester is closing.
* lib/resolv.rb (ConnectedUDP#lazy... -
- * vm_args.c (setup_parameters_complex): [EXPERIMENTAL] warn when
splat keyword arguments is passed as a single ordinary argument,
not as a keyword rest argument.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62914 b2dd03c8-39d4-... - 01:52 AM Revision 0de07300 (git): * 2018-03-25
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62913 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62912 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- normalperson (Eric Wong) wrote:
> Opinions? Should we raise or just return 0 when no args are given?
I vote for the latter.
03/24/2018
-
04:36 PM Bug #14629: Option Parser bug
- nobu (Nobuyoshi Nakada) wrote:
> It is a spec, the long option name completion, so that users do not have to type the whole option name.
Thanks ! Sorry for the false positive -
- It is a spec, the long option name completion, so that users do not have to type the whole option name.
-
- Reproduce process:
Case 1:
$ruby testarg.rb --fail-if-changed
"fail if change arg provided"
Case 2:
$ruby testarg.rb --fail-if-change
"fail if change arg provided"
Case 3:
$ruby testarg.rb --fail-if-chang
"fail if change a... -
04:02 PM Bug #14403: Crash and coredump (Stack consistency error) on ruby 2.5.0
- ruby_2_5 r62911 merged revision(s) 61587,61617,61618.
-
- ruby_2_5 r62911 merged revision(s) 61587,61617,61618.
-
- Added r61587 to associated revisions.
-
- compile.c: next label
* compile.c (compile_next): label for jump to the end of block is
removable.
compile.c: remove more unreachable chunk
* compile.c (remove_unreachable_chunk): remove beyond labels... -
03:27 PM Bug #14626: One failing test on trunk 58fbe69a5b and OSX
- > but do I need to run
Most build systems do perform `configure`, `make`, and `make install` before testing.
If you want to run tests on an existing build, you can run something like the following (when in the test folder):
```
... -
- * configure.ac: turned section block comments into named blocks.
http://c16e.com/1603281120/
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62910 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
01:58 PM Bug #14345: http_proxy setting should respect both parent domain and subdomain
- I think this will be discussed at the next ruby developer meeting
in April 2018 so stay tuned for updates to it (less than a month
to go for the next developer meeting).
See here:
https://bugs.ruby-lang.org/projects/ruby/wiki/D... -
- ruby_2_5 r62909 merged revision(s) 62723,62724.
-
- parse.y: reduce duplicate code
parse.y: fix interpolated string literal dedent
* parse.y (heredoc_dedent): fix interpolated string literal dedent,
remove indentations from only nodes with the newline flag.
... -
- * compile.c (add_insn_info, add_adjust_info): split for each
list->type, to remove unnecessary repeated conditions and casts.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62908 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 11:04 AM Revision b19a14ec (git): * 2018-03-24
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62907 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * compile.c (add_insn_info): move return statement to suppress
missing-noreturn warning.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62906 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- ruby_2_5 r62905 merged revision(s) 62548,62894.
-
- eval_error.c: rb_error_write flags
* eval_error.c (rb_error_write): add highlight and reverse mode
flags. defaulted to rb_stderr_tty_p() if Qnil.
error.c: full_message options
* error.c (exc_full_mes... -
- Thank you, that bug has been fixed already in the repository, and the next release will work fine.
-
- Indeed, good find.
I believe the ruby parser is correct when it thinks it is a
constant, since it obviously is a constant (A, B, C).
However had, I think the ruby parser makes two mistakes:
(1) it assumes that there is a dynami... -
07:24 AM Bug #14628 (Closed): Misplaced colon causes segmentation fault
- The following program with a misplaced colon causes a segmentation fault when you try to run it in Ruby 2.5.0p0 on both the Manjaro Linux and the MSYS2 platforms:
~~~{ruby}
def a(x)
case x
when A
:
when B, C
end
end... -
-
- I can't reproduce it.
```
$ ruby -v -e 'Class.new.class_eval "def foo(N:)\n end"'
ruby 2.5.0p0 (2017-12-25 revision 61468) [x86_64-linux-gnu]
Traceback (most recent call last):
1: from -e:1:in `<main>'
-e:1:in `class_eval': (eva...
03/23/2018
-
08:16 PM Feature #14594: Rethink yield_self's name
- > Why not use `map`
```ruby
paragraphs
.map { something }
.reject { something }
.yield_self { |ps| external_post_processor(ps, **options) }
``` -
08:08 PM Feature #14594: Rethink yield_self's name
- I also agree `yield_self` isn't the best name but I'm also skeptical of `then`. Why not use `map`, which we already have for collections? Generally speaking, the `map` function isn't just about collections (though that's usually how it's...
-
- I can't answer all questions zverok posed but in regards to:
```ruby
.yield_self(method :filter2)
```
versus
```ruby
.yield_self(&method(:filter1))
```
The first variant is cleaner IMO.
As for `(&.:filter1)` I don't re... -
Question 1. How is this (proposed):
```ruby
result = collection
.yield_self(method :filter1)
.yield_self(method :filter2)
```
better than this (already works):
```ruby
result = collection
.yield_self(&method(:filte...-
08:04 AM Feature #14625 (Open): yield_self accepts an argument, calling to_proc
- Currently, yield_self doesn't accept any argument other than a block.
But there are situations where I would like to pass a method object to yield_self.
e.g.
~~~ ruby
result = collection
.yield_self(&method(:filter1))
.yie... -
05:01 PM Bug #14627 (Closed): class_eval "def foo(N:)\n end" regression
- Ruby crashes with a segfault in case of `class_eval` defining method with a keyword starts with a capital letter. It seems like it's a regression of one of the latest versions.
-
- ruby_2_4 r62904 merged revision(s) 60162.
-
- socket.c: null byte at Socket.getnameinfo
* ext/socket/socket.c (sock_s_getnameinfo): check null byte.
patched by tommy (Masahiro Tomita) in [ruby-dev:50286].
[Bug #13994]
git-svn-id: svn+ssh://ci.ruby-lang.... -
- ruby_2_4 r62903 merged revision(s) 62607.
-
- file.c: realpath on special symlink
* file.c (realpath_rec): fallback to symlink path when it is
accessible but the link target is not actual entry on file
systems. [ruby-dev:50487] [Bug #14557]
git-svn-id:... -
09:22 AM Feature #14624: #{nil} allocates a fresh empty string each time
- i have a problem with that, what if someone might do:
~~~ ruby
x = obj.to_s
x << obj2.to_s
~~~
then it might be `nil`, return a frozen string and it would do a `RuntimeError`
better imo would be that if `"#{nil}"` would do a ... -
03:49 AM Feature #14624 (Open): #{nil} allocates a fresh empty string each time
- This causes a bunch of unnecessary string allocations in the following scenario: `"#{'rails' unless boolean_condition} is great"`. Each time this line is called when `boolean_condition` is true, it evaluates to `nil` and when `nil` is in...
-
09:12 AM Bug #14626: One failing test on trunk 58fbe69a5b and OSX
- I will follow this guide http://engineering.appfolio.com/appfolio-engineering/2016/6/7/git-bisect-to-find-a-ruby-regression
-
- I'm using ruby/trunk on 58fbe69a5b. When I run *make test-all TESTS='rubygems/test_require.rb'*
~~~ text
Run options: "--ruby=./miniruby -I../ruby/lib -I. -I.ext/common ../ruby/tool/runruby.rb --extout=.ext -- --disable-gems" --exc... -
06:21 AM Bug #14596: Ruby master is broken with bootsnap
- https://github.com/Shopify/bootsnap/issues/145
-
- https://github.com/ruby/ruby/commit/f3fbf1dfadea80646c68719d439da699d527b0dc
```bash
$ rails s
/Users/fudoshiki/.rvm/gems/ruby-head/bundler/gems/rails-6aa5cf03ea82/activesupport/lib/active_support/dependencies.rb:253: [BUG] Segmenta... -
- * parse.y (bodystmt): expand opt_else to show the error message at
the right place.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62902 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * parse.y (bodystmt): [EXPERIMENTAL] make `else` without `rescue`
a syntax error. [DevelopersMeeting20180315Japan]
https://bugs.ruby-lang.org/projects/ruby/wiki/DevelopersMeeting20180315Japan
https://docs.google.com/document/d/1R...
03/22/2018
-
09:03 PM Feature #12306: Implement String #blank? #present? and improve #strip and family to handle unicode
- This seems to be the number one time-wasters in my project (metasploit-framework), where nobody can agree if we should use it, shouldn't, whether it affects performance, behavior on nil, etc.
It would be great if this just got added t... -
- Obviously, 2.2 changes are soon to be stopped.
Recently in Puma, Travis was changed from 2.2.8 to 2.2.9, and in code using a pipe, the "can't modify frozen IOError" occurred.
This was not an issue with 2.2.8, which was used in Puma... - 04:05 PM Revision 631272ff (git): * 2018-03-23
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62900 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62899 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
01:01 PM Revision 9d091c85 (git): sample/timeout.rb: Remove unnecessary increment [ci skip]
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62898 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Now URI is normally UTF-8, and US-ASCII URI string is considered as
escaped a UTF-8 string.
https://github.com/rails/rails/issues/32294
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62897 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- ruby_2_5 r62896 merged revision(s) 62892,62893.
-
- Applied in changeset trunk|r62892.
----------
fix each_grapheme_cluster's size [Bug #14363]
From: Hugo Peixoto hugo.peixoto@gmail.com -
- fix each_grapheme_cluster's size [Bug #14363]
From: Hugo Peixoto <hugo.peixoto@gmail.com>
Factor out get_reg_grapheme_cluster
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_5@62896 b2dd03c8-39d4-4d8f-98ff-... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_5@62895 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Applied in changeset trunk|r62894.
----------
error.c: full_message options
* error.c (exc_full_message): add highlight: and reverse: keyword
options. [Bug #14324] -
- * error.c (exc_full_message): add highlight: and reverse: keyword
options. [Bug #14324]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62894 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62893 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- From: Hugo Peixoto <hugo.peixoto@gmail.com>
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62892 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- This reverts commit r62887.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62891 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- ruby_2_5 r62889 merged revision(s) 62042,62044.
- 07:00 AM Revision 9e11d394 (git): * 2018-03-22
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_5@62890 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- hash.c: support key swapping in Hash#transform_keys!
* hash.c (rb_hash_transform_keys_bang): support key swapping in
Hash#transform_keys!
[Bug #14380] [ruby-core:84951]
* test/ruby/test_hash.rb (test... -
- From: Stefan Schüßler <mail@stefanschuessler.de>
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62888 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * parse.y (new_args_tail): reorder required and optional keyword
argument variable IDs in the place.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62887 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 06:38 AM Revision 889afb8b (git): merge revision(s) 57081:
- Removed the obstacle to running test-all with VC14.
* test/fiddle/test_import.rb (LIBC.fprintf): VC14's `fprintf` is very distinct
name, then, just ignore this test.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branch... - 03:33 AM Revision c2fdfb05 (git): merge https://github.com/ruby/openssl/commit/3af2635f117f8da563d180bc1c58702aecb16e0c
- patched by Kazuki Yamaguchi <k@rhe.jp>
bio: prevent possible GC issue in ossl_obj2bio()
Prevent the new object created by StringValue() from being GCed.
Luckily, as none of the callers of ossl_obj2bio() reads fr... - 02:28 AM Revision 85ddcb93 (git): merge revision(s) 54737,54740,55792: [Backport #14623]
- Support MSVC14 and 15 [Bug #11118]
Search _pioinfo which is not exported after MSVC14.
[Bug #12014] [GH-884]
win32.c: suppress warnings
* win32/win32.c (set_pioinfo_extra): remove "/*" within comment.
... -
01:29 AM Bug #14623 (Closed): backport r54737, r54740 and r55792
- バックポート管理用チケットです。
-
12:40 AM Misc #14622: Improve documentation for 'string '.split to also mention trailing spaces being ignored
- Thanks :-)
03/21/2018
-
-
- The current documentation only talks about leading spaces being ignored when a single space is used as an argument. I've suggested a few changes to the documentation and example to make it clearer that trailing spaces are also ignored in...
-
04:44 PM Bug #14616: Segmentation fault in net/http/response
- The trace is great. Please also try to make a minimal ruby example to reproduce it.
What made you suspect the memory leak as the cause of the seg fault?
Also please explain a little about this part of your application: is it an htt... -
04:17 PM Bug #14363: each_grapheme_cluster.size returns the wrong size
- Calculating the enumerator size here requires iterating through the whole text and do grapheme detection on all bytes, so I'm not sure what's the right approach.
I'm attaching two patches, one that makes it return `nil` and one that d... -
- ruby_2_4 r62883 merged revision(s) 62572.
-
- date_core.c: defensive code
* ext/date/date_core.c (f_cmp): check comparison failure.
* ext/date/date_core.c (d_lite_step): deal with the comparison
result more defensively. [ruby-core:85796] [Bug #14549]
gi... -
04:10 PM Feature #14197: `Enumerable#{select,reject}` accept a pattern argument
- The point is that the phrase "hard to remember" in the OP is bit weak when we already have methods with the proposed behavior (`grep` and `grep_v`).
Matz.
-
03:49 PM Feature #14197: `Enumerable#{select,reject}` accept a pattern argument
- This issue is also related https://bugs.ruby-lang.org/issues/9602
One interesting point there is the case where a pattern and a block are given:
~~~ ruby
%w{ant bear cat}.select(/bear/) {||x| x === "cat" }
~~~
This issue also ... -
- Improve code coverage and clarify meaning of hierarchical based on RFC
text.
[Fix GH-1846]
From: Xavier Riley <xavriley@hotmail.com>
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62882 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- The documentation didn't mention trailing spaces and the
example only demonstrated the case with leading spaces.
[Fix GH-1845]
From: Rodrigo Rosenfeld Rosas <rr.rosas@gmail.com>
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62881 b... -
- ruby_2_4 r62880 merged revision(s) 61862.
-
- parse.y (new_regexp): Fix SEGV of `/#{"\u3042"}#{'{U+3044}'}/` in non UTF-8
Mixing other encoding string literals in one Regexp caused SEGV.
This bug was found by CoverityScan.
git-svn-id: svn+ssh://ci.ruby-lang.org/rub... - 03:46 PM Revision eb02dd3c (git): * 2018-03-22
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62879 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Passing a proc as the second argument to eval is no longer supported.
[Fix GH-1843]
From: Tieg Zaharia <tieg.zaharia@gmail.com>
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62878 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- ruby_2_4 r62877 merged revision(s) 62107.
-
- force fixable
* complex.c (nucomp_hash): force hash values fixable.
[ruby-core:85224] [Bug #14420]
* rational.c (nurat_hash): ditto.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_4@62877 b2dd03c... -
- ruby_2_4 r62875 merged revision(s) 62040.
- 03:04 PM Revision 49e950c8 (git): * 2018-03-22
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_4@62876 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- string.c: clear substring code range
* string.c (str_substr): substring of broken code range string may
be valid or broken. patch by tommy (Masahiro Tomita) at
[ruby-dev:50430] [Bug #14388].
git-svn-id: svn... -
03:01 PM Bug #14573: rb_ary_or doesn't check objects hash when the array contains less than SMALL_ARRAY_LEN
- Related to https://bugs.ruby-lang.org/issues/14263. We have posted a note there about our investigation and the inconsistent behaviour between small and larger arrays.
-
- I was unable to reproduce this with alpine 3.7 in docker, with ruby 2.4.3p205:
```
$ docker run --rm -ti alpine:3.7
/ # apk update && apk add ruby-irb
...
/ # ruby -v
ruby 2.4.3p205 (2017-12-14 revision 61247) [x86_64-linux-mus... -
- shevegen (Robert A. Heiler) wrote:
> Is there a standard that mandates or prefers either variant?
RFC 5952 recommends the usage of lower case letters: https://tools.ietf.org/html/rfc5952#section-4.3
The `Resolv` module seems to be... -
- We (myself and [Lewis Buckley](https://github.com/lewispb)) investigated this issue as part of the Ruby Hack Day at Cookpad.
We were able to replicate the issue on Ruby 2.6 (trunk)—digging a bit deeper we found that the unexpected beh... -
- ruby_2_4 r62874 merged revision(s) 57637.
-
- win32.c: memcpy instead of strlcpy
* win32/win32.c (cmdglob): memcpy the exact size instead of
strlcpy with +1.
* win32/win32.c (w32_cmdvector): ditto, with NUL-terminating.
git-svn-id: svn+ssh://ci.ruby-lang... -
- Applied in changeset trunk|r62873.
----------
parse.y: terminator at continued line
* parse.y (here_document): a continuing line is not the
terminator. [ruby-core:86283] [Bug #14621] -
-
- r62872 has a bug.
```ruby
<<-TEXT
\
TEXT
```
should raise a syntax error, "`can't find string "TEXT" anywhere before EOF`".
I'll fix it.
-
- Applied in changeset trunk|r62872.
----------
parse.y: unindent continued line
* parse.y (tokadd_string): stop at continued line in dedented here
documents, to dedent for each lines before removing escaped
newlines. [ruby-core:862... -
06:43 AM Bug #14621: Extra whitespace in squiggly heredoc with escaped newline
- Tested in ruby 2.5.0p0 (2017-12-25 revision 61468) [x86_64-linux] - same result.
-
- ~~~ruby
puts <<~TXT.inspect
1 \
2
TXT
~~~
Expected:
~~~
"1 2\n"
~~~
Got:
~~~
"1 2\n"
~~~ -
- * parse.y (here_document): a continuing line is not the
terminator. [ruby-core:86283] [Bug #14621]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62873 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * parse.y (tokadd_string): stop at continued line in dedented here
documents, to dedent for each lines before removing escaped
newlines. [ruby-core:86236] [Bug #14621]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62872 b2dd03c... -
- * test/ruby/test_iseq.rb (test_to_binary_with_objects): disable
load_from_binary right now, r62851 seems having a trouble around
get_insn_info_succinct_bitvector() yet.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62871 b2dd03c... -
- My e-mail to the mailing list [ruby-core] is not synced with Redmine.
http://blade.nagaokaut.ac.jp/cgi-bin/scat.rb/ruby/ruby-core/86213 - 02:20 AM Revision 53865346 (git): * 2018-03-21
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62870 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62869 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
03/20/2018
-
- ruby_2_4 r62868 merged revision(s) 61603.
-
- check array for zsuper. [Bug #14279]
* compile.c (iseq_compile_each0): for zsuper (NODE_ZSUPER), we need to check
given argument is Array or not.
* test/ruby/test_super.rb: add a test for this bug.
git-svn-i... -
- ruby_2_4 r62867 merged revision(s) 61639.
-
- net/ftp: fix FrozenError in BufferedSocket
I noticed this bug while working on something else with
RUBYOPT=-d on, existing test cases all passed with it.
Note: I use String.new because it is the local style, her... -
05:30 PM Feature #13383: [PATCH] Module#source_location
- What is the status of this proposal? I think this feature would be very nice for debugging. If being able to show all the locations of where the class is defined is not possible, I think pointing to the last location would be the most us...
-
- ruby_2_4 r62866 merged revision(s) 62115.
-
- proc: fix super_method segfault after bind
* proc.c: handle undefined iclass
[ruby-core:85231] [Bug #14421]
From: Eric Wong <e@80x24.org>
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_4@62866 b2... -
- ruby_2_4 r62865 merged revision(s) 58245,60127.
-
- Refactored using Method#owner.
proc.c: super_method of included method
* proc.c (method_super_method): search the next super method along
the included ancestor chain. [ruby-core:83114] [Bug #13973]
... -
03:41 PM Bug #14380: Expected transform_keys! to work just as transform_keys, but it doesn't
- > change will also be applied in ActiveSupport
Where did you get that information?
This change silently breaks applications when upgrading to 2.6 version. Backward compatibility not only with active support but with an already rele... -
- Considered a bug and the behavior change will also be applied in ActiveSupport.
-
- It has been backported to 2.2 and released already.
As we don't release branch-from-branch, "patch for 2.2.2" doesn't make sense.
-
03:28 PM Bug #14619: method(m) is not invoking respond_to_missing?
- Thanks nobu, indeed, I just wanted to make sure this is seen for a possible p9? patch for 2.2.2, feel free to close if this doesn't need to be backported.
-
- It works in ruby 2.2.9.
-
- Already fixed bug.
-
02:52 PM Bug #14620: Incorrect assignment causes segfault
- Actually just the last line is enough to cause the fault.
-
01:01 PM Bug #14620 (Closed): Incorrect assignment causes segfault
- The following code when executed on Ruby 2.5 causes a segfault on my machine (macOS High Sierra). This has been reproduced with a self-compiled Ruby as well as one from home-brew.
~~~ruby
def foo
puts 'hi'
end
foo, true
~~~
... -
02:37 PM Bug #14273: Stack Consistency Error from return in loop
- Ah okay sorry, thanks!
-
- Backporting is managed with "Backport" field.
Status: Closed is expected one. -
- ruby_2_4 r62864 merged revision(s) 61564,61565,61571.
-
- fix SEGV touching uninitialized memory
This function can be called from Init_VM().
No assumption can be made about object internals.
(lldb) run
Process 15734 launched: './miniruby' (x86_64)
Proce... -
- ruby_2_4 r62863 merged revision(s) 61471,61472.
-
- Use UINT128_T support flag from configure
Current check for __uint128_t in hash.c is not valid, since it ignores
compilers other than gcc. We hit this on lcc on e2k platform.
Configure script properly checks fro... -
- ruby_2_4 r62849 merged revision(s) 61413.
-
- ruby_2_4 r62862 merged revision(s) 58438,58439,58451.
-
- clean autogenerated files
* enc/depend (clean, clean-srcs): fix path of name2ctype.h, and
remove casefold.h too.
* enc/jis/props.h: autogenerated file.
[ruby-core:80823] [Bug #13493]
use $(s... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62861 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- ruby_2_5 r62860 merged revision(s) 62725.
-
- Fix setting method visibility on method wrapped with prepend
Ignore prepended modules when looking for already defined methods on a
class to set the visibility on.
[Fix GH-1834]
From: Dylan Thacker-Smith... -
- ruby_2_5 r62859 merged revision(s) 62734.
-
- Add missing class FrozenError to Exception subclasses list documentation
[Fix GH-1818]
From: Miguel Landaeta <miguel@miguel.cc>
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_5@62859 b2dd03c8-39d4-4d8f-98f... -
- ruby_2_5 r62858 merged revision(s) 62396.
-
- st.c: retry operations if rebuilt
Calling the .eql? and .hash methods during a Hash operation can
result in a thread switch or a signal handler to run: allowing
one execution context to rebuild the hash table whi... -
09:09 AM Feature #14245 (Closed): Add File.read etc.
- Applied in changeset trunk|r62857.
----------
io.c: Methods of File should not invoke external commands
For security reasons, File.read, File.binread, File.write, File.binwrite,
File.foreach, and File.readlines should not invoke extern... -
- For security reasons, File.read, File.binread, File.write, File.binwrite,
File.foreach, and File.readlines should not invoke external commands even
if the path starts with the pipe character |.
[ruby-core:84495] [Feature #14245]
git-svn... -
- * compile.c (ibf_load_iseq_each): manage iseq_size to point loaded
objects in iseq_encoded. now marking iseq scans iseq_encoded
directly.
* test/ruby/test_iseq.rb (test_to_binary_with_objects): skip for
now, but fix argument orde... - 05:36 AM Revision 9852802c (git): * test/ruby/test_vm_dump.rb: try to fix test failures on darwin introduced at
- r62810. ruby_2_3 does not output "[IMPORTANT]" message.
see [Backport #13566]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_3@62855 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- ruby_2_5 r62854 merged revision(s) 62673.
-
- thread.c: deadlock in backtrace
* thread.c (unblock_function_set): check interrupts just once
during raising exceptions, as they are deferred since r16651.
[ruby-core:85939] [Bug #14577]
git-svn-id: svn+ssh:... -
- ruby_2_5 r62852 merged revision(s) 62668.
- 02:08 AM Revision c28d3d02 (git): * 2018-03-20
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_5@62853 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- thread.c: reset waitq of keeping mutexes in child
We must not maintain references to threads in the parent process
in any mutexes held by the child process.
* thread_sync.c (rb_mutex_cleanup_keeping_mutexes): ne... -
01:57 AM Bug #14617 (Assigned): rdoc crashes when expression contains embedded comment: no implicit conversion of nil into String (TypeError)
03/19/2018
-
- Martin Dürst is doing some unicode stuff; perhaps he can chime in
when he has some time. -
09:02 PM Feature #14618: Add display width method to String for CLI - Dne 19.3.2018 v 20:00 aycabta@gmail.com napsal(a):
>
> ## Use-case
>
> I'm developing Readline compatible library by pure Ruby implementation for Ruby core.
> https://github.com/aycabta/reline
>
> I'm discussing it with @hsbt, an... -
- ## Abstract
Unicode has display width data of characters, "Narrow" or "Wide".
For example, "A" is "Narrow", "💎" ("\u{1f48e}") is "Wide".
http://unicode.org/reports/tr11/
This data is very important for CLI tools.
## Use-case
... -
- Possibly a regression from a fix that was made for https://bugs.ruby-lang.org/issues/10985?
-
- ~~~ ruby
class VariantHash < Hash
def respond_to_missing?(method_name, *args)
true
end
def method_missing(method_name, *args, &blk)
42
end
end
m = "foo_"
h = VariantHash.new(m => 'a')
puts h.method(m)
pu... -
-
06:21 PM Revision 9e26858e (git): Reverting r62775, this should fix i686 builds
- We need to mark default values for kwarg methods. This also fixes
Bootsnap. IBF iseq loading needed to mark iseqs as "having markable
objects".
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62851 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- ruby_2_4 r62850 merged revision(s) 61562,61563,61566,61568,61569.
-
- fix SEGV touching uninitialized memory
This function can be called from boot_defclass().
No assumption can be made about object internals.
(lldb) run
Process 2386 launched: './miniruby' (x86_64)
... -
- force hash values fixable
* include/ruby/ruby.h (RB_ST2FIX): force fixable on LLP64 environment.
* hash.c (any_hash): ditto.
[ruby-core:84395] [Bug #14218]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branche... -
- ruby_2_4 r62848 merged revision(s) 61359.
-
- raise error if value contains CR/LF in iniheader of initialize_http_header
like r59693, initialize_http_header also should raise error. [Bug #14208]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_4@62848 b2dd03c8-3... -
- ruby_2_4 r62847 merged revision(s) 61346.
-
- parse.y: end of script at newline
* parse.y (parser_yylex): deal with end of script chars just after
ignored newline as other places. [ruby-core:84349] [Bug #14206]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branche... -
- ruby_2_4 r62846 merged revision(s) 61278,61281.
-
- IO.new doesn't recive "-" as external_encoding [Bug #13655]
[DOC] `IO.new` accepts `external_encoding`
Revert part of r61278 [Bug #13655]
[ci skip]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_4@... -
- Update openssl to 2.0.7 in ruby_2_4 branch at r62845.
-
- Update openssl 2.0.6 in ruby_2_4 branch at r62842.
I made a mistake in my commit message...
-
- The patch is provided by Kazuki Yamaguchi.
From: Kazuki Yamaguchi <k@rhe.jp>
Date: Mon, 25 Sep 2017 01:32:02 +0900
Subject: [PATCH] openssl: import v2.0.7
Import Ruby/OpenSSL 2.0.7. This contains only bug fixes and test
improvements. T... - 03:40 PM Revision c9dee850 (git): * 2018-03-20
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62844 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 03:40 PM Revision de87b969 (git): * win32/README.win32: `make up` is only necessary when building from SVN source.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62843 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- The patch is provided by Kazuki Yamaguchi.
From: Kazuki Yamaguchi <k@rhe.jp>
Date: Mon, 25 Sep 2017 01:32:02 +0900
Subject: [PATCH] openssl: import v2.0.6
Import Ruby/OpenSSL 2.0.6. This contains only bug fixes and test
improvements. T... -
- * parse.y (yycompile): in some cases (warning, error, dtrace,...),
ruby_sourcefile is expected to be NUL-terminated, so ensure it.
* template/prelude.c.tmpl (prelude_name): NUL-terminate to get rid
of copying static data.
git-svn-i... - 01:04 PM Revision 68f37472 (git): note that patch is required and need to run make up before make
- * win32/README.win32: patch(1) is required, and running `make up` before
`make` is also required.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62840 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- > I was made aware of this issue via this bug [1] report, but it has been already reported [2] and fixed [3] upstream. Would be nice if this is fixed in RDoc shipped in Ruby.
> ...
Sorry, I understand this issue's intention.
This iss... -
- This bug is fixed. RDoc 6.0.2 was released two days ago. Please use it.
-
11:42 AM Bug #14617: rdoc crashes when expression contains embedded comment: no implicit conversion of nil into String (TypeError)
- ~~~
$ rdoc -v
6.0.1
~~~ -
- RDoc might fail when comment is inside code, such as:
~~~ruby
def meth
variable # comment
.chain
end
~~~
I was made aware of this issue via this bug [1] report, but it has been already reported [2] and fixed [3] upstream... -
- * parse.y (k_rescue, k_ensure): revert r62838.
* parse.y (k_do, k_do_LAMBDA, k_do_block): push token infos of
`do`.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62839 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
11:32 AM Bug #14616 (Closed): Segmentation fault in net/http/response
- I'm seeing a memory leak in my production application, which is culminating an a segmentation fault from within net/http/response.rb.
I'm not sure exactly what information you need but here's a backtrace:
~~~
2018-03-18T21:56:59Z:... -
- * parse.y (k_rescue, k_ensure): ignore indentations of `do`, it
is not at the beginning of line usually.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62838 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- ruby_2_5 r62837 merged revision(s) 62244,62246,62301,62302,62303,62422,62436,62452.
-
- Merge RubyGems-2.7.5 from upstream.
Please see its details: http://blog.rubygems.org/2018/02/06/2.7.5-released.html
test_gem_util.rb: fix broken test
* test/rubygems/test_gem_util.rb: no guarantee that tmpdir... -
- * parse.y (k_rescue, k_ensure, k_when, k_else, k_elsif): warn
mismatched indentations at keywords in middle of blocks.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62836 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_5@62835 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- fix concurrent test.
* test/rubygems/test_require.rb (test_concurrent_require):
Synchronizations should be in ensure clause. Sometimes
`require` fails (not sure why) and latch is not released.
Such ... -
- Applied in changeset trunk|r62833.
----------
compile.c: arg var index
* compile.c (iseq_set_arguments): determine argument variable
indexes by the order, not by just IDs. arguments begin with `_`
can be duplicate, so by-ID index ... -
- * compile.c (iseq_set_arguments): determine argument variable
indexes by the order, not by just IDs. arguments begin with `_`
can be duplicate, so by-ID index may result in a wrong value.
[ruby-core:86159] [Bug #14611]
git-svn-id... -
- * parse.y (f_kwrest): add the variable name as an argument, as
well as an internal variable.
* parse.y (new_args_tail): now keyword rest argument variable is
always placed between keyword arguments and block argument, so
so just r... -
-
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62831 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 12:32 AM Revision affd2b76 (git): * 2018-03-19
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62830 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62829 b2dd03c8-39d4-4d8f-98ff-823fe69b080e