Activity
From 03/14/2018 to 03/20/2018
03/20/2018
-
06:07 PM Bug #14279: Modifying splat argument causes segmentation fault
- ruby_2_4 r62868 merged revision(s) 61603.
-
- check array for zsuper. [Bug #14279]
* compile.c (iseq_compile_each0): for zsuper (NODE_ZSUPER), we need to check
given argument is Array or not.
* test/ruby/test_super.rb: add a test for this bug.
git-svn-i... -
- ruby_2_4 r62867 merged revision(s) 61639.
-
- net/ftp: fix FrozenError in BufferedSocket
I noticed this bug while working on something else with
RUBYOPT=-d on, existing test cases all passed with it.
Note: I use String.new because it is the local style, her... -
05:30 PM Feature #13383: [PATCH] Module#source_location
- What is the status of this proposal? I think this feature would be very nice for debugging. If being able to show all the locations of where the class is defined is not possible, I think pointing to the last location would be the most us...
-
- ruby_2_4 r62866 merged revision(s) 62115.
-
- proc: fix super_method segfault after bind
* proc.c: handle undefined iclass
[ruby-core:85231] [Bug #14421]
From: Eric Wong <e@80x24.org>
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_4@62866 b2... -
- ruby_2_4 r62865 merged revision(s) 58245,60127.
-
- Refactored using Method#owner.
proc.c: super_method of included method
* proc.c (method_super_method): search the next super method along
the included ancestor chain. [ruby-core:83114] [Bug #13973]
... -
03:41 PM Bug #14380: Expected transform_keys! to work just as transform_keys, but it doesn't
- > change will also be applied in ActiveSupport
Where did you get that information?
This change silently breaks applications when upgrading to 2.6 version. Backward compatibility not only with active support but with an already rele... -
02:18 PM Bug #14380 (Closed): Expected transform_keys! to work just as transform_keys, but it doesn't
- Considered a bug and the behavior change will also be applied in ActiveSupport.
-
03:33 PM Bug #14619: method(m) is not invoking respond_to_missing?
- It has been backported to 2.2 and released already.
As we don't release branch-from-branch, "patch for 2.2.2" doesn't make sense.
-
03:28 PM Bug #14619: method(m) is not invoking respond_to_missing?
- Thanks nobu, indeed, I just wanted to make sure this is seen for a possible p9? patch for 2.2.2, feel free to close if this doesn't need to be backported.
-
- It works in ruby 2.2.9.
-
- Already fixed bug.
-
02:52 PM Bug #14620: Incorrect assignment causes segfault
- Actually just the last line is enough to cause the fault.
-
01:01 PM Bug #14620 (Closed): Incorrect assignment causes segfault
- The following code when executed on Ruby 2.5 causes a segfault on my machine (macOS High Sierra). This has been reproduced with a self-compiled Ruby as well as one from home-brew.
~~~ruby
def foo
puts 'hi'
end
foo, true
~~~
... -
02:37 PM Bug #14273: Stack Consistency Error from return in loop
- Ah okay sorry, thanks!
-
- Backporting is managed with "Backport" field.
Status: Closed is expected one. -
- ruby_2_4 r62864 merged revision(s) 61564,61565,61571.
-
- fix SEGV touching uninitialized memory
This function can be called from Init_VM().
No assumption can be made about object internals.
(lldb) run
Process 15734 launched: './miniruby' (x86_64)
Proce... -
- ruby_2_4 r62863 merged revision(s) 61471,61472.
-
- Use UINT128_T support flag from configure
Current check for __uint128_t in hash.c is not valid, since it ignores
compilers other than gcc. We hit this on lcc on e2k platform.
Configure script properly checks fro... -
- ruby_2_4 r62849 merged revision(s) 61413.
-
- ruby_2_4 r62862 merged revision(s) 58438,58439,58451.
-
- clean autogenerated files
* enc/depend (clean, clean-srcs): fix path of name2ctype.h, and
remove casefold.h too.
* enc/jis/props.h: autogenerated file.
[ruby-core:80823] [Bug #13493]
use $(s... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62861 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- ruby_2_5 r62860 merged revision(s) 62725.
-
- Fix setting method visibility on method wrapped with prepend
Ignore prepended modules when looking for already defined methods on a
class to set the visibility on.
[Fix GH-1834]
From: Dylan Thacker-Smith... -
- ruby_2_5 r62859 merged revision(s) 62734.
-
- Add missing class FrozenError to Exception subclasses list documentation
[Fix GH-1818]
From: Miguel Landaeta <miguel@miguel.cc>
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_5@62859 b2dd03c8-39d4-4d8f-98f... -
- ruby_2_5 r62858 merged revision(s) 62396.
-
- st.c: retry operations if rebuilt
Calling the .eql? and .hash methods during a Hash operation can
result in a thread switch or a signal handler to run: allowing
one execution context to rebuild the hash table whi... -
09:09 AM Feature #14245 (Closed): Add File.read etc.
- Applied in changeset trunk|r62857.
----------
io.c: Methods of File should not invoke external commands
For security reasons, File.read, File.binread, File.write, File.binwrite,
File.foreach, and File.readlines should not invoke extern... -
- For security reasons, File.read, File.binread, File.write, File.binwrite,
File.foreach, and File.readlines should not invoke external commands even
if the path starts with the pipe character |.
[ruby-core:84495] [Feature #14245]
git-svn... -
- * compile.c (ibf_load_iseq_each): manage iseq_size to point loaded
objects in iseq_encoded. now marking iseq scans iseq_encoded
directly.
* test/ruby/test_iseq.rb (test_to_binary_with_objects): skip for
now, but fix argument orde... - 05:36 AM Revision 9852802c (git): * test/ruby/test_vm_dump.rb: try to fix test failures on darwin introduced at
- r62810. ruby_2_3 does not output "[IMPORTANT]" message.
see [Backport #13566]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_3@62855 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- ruby_2_5 r62854 merged revision(s) 62673.
-
- thread.c: deadlock in backtrace
* thread.c (unblock_function_set): check interrupts just once
during raising exceptions, as they are deferred since r16651.
[ruby-core:85939] [Bug #14577]
git-svn-id: svn+ssh:... -
- ruby_2_5 r62852 merged revision(s) 62668.
- 02:08 AM Revision c28d3d02 (git): * 2018-03-20
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_5@62853 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- thread.c: reset waitq of keeping mutexes in child
We must not maintain references to threads in the parent process
in any mutexes held by the child process.
* thread_sync.c (rb_mutex_cleanup_keeping_mutexes): ne... -
01:57 AM Bug #14617 (Assigned): rdoc crashes when expression contains embedded comment: no implicit conversion of nil into String (TypeError)
03/19/2018
-
11:55 PM Feature #14618: Add display width method to String for CLI
- Martin Dürst is doing some unicode stuff; perhaps he can chime in
when he has some time. -
09:02 PM Feature #14618: Add display width method to String for CLI - Dne 19.3.2018 v 20:00 aycabta@gmail.com napsal(a):
>
> ## Use-case
>
> I'm developing Readline compatible library by pure Ruby implementation for Ruby core.
> https://github.com/aycabta/reline
>
> I'm discussing it with @hsbt, an... -
07:00 PM Feature #14618 (Open): Add display width method to String for CLI
- ## Abstract
Unicode has display width data of characters, "Narrow" or "Wide".
For example, "A" is "Narrow", "💎" ("\u{1f48e}") is "Wide".
http://unicode.org/reports/tr11/
This data is very important for CLI tools.
## Use-case
... -
- Possibly a regression from a fix that was made for https://bugs.ruby-lang.org/issues/10985?
-
- ~~~ ruby
class VariantHash < Hash
def respond_to_missing?(method_name, *args)
true
end
def method_missing(method_name, *args, &blk)
42
end
end
m = "foo_"
h = VariantHash.new(m => 'a')
puts h.method(m)
pu... -
-
06:21 PM Revision 9e26858e (git): Reverting r62775, this should fix i686 builds
- We need to mark default values for kwarg methods. This also fixes
Bootsnap. IBF iseq loading needed to mark iseqs as "having markable
objects".
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62851 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- ruby_2_4 r62850 merged revision(s) 61562,61563,61566,61568,61569.
-
- fix SEGV touching uninitialized memory
This function can be called from boot_defclass().
No assumption can be made about object internals.
(lldb) run
Process 2386 launched: './miniruby' (x86_64)
... -
- force hash values fixable
* include/ruby/ruby.h (RB_ST2FIX): force fixable on LLP64 environment.
* hash.c (any_hash): ditto.
[ruby-core:84395] [Bug #14218]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branche... -
- ruby_2_4 r62848 merged revision(s) 61359.
-
- raise error if value contains CR/LF in iniheader of initialize_http_header
like r59693, initialize_http_header also should raise error. [Bug #14208]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_4@62848 b2dd03c8-3... -
- ruby_2_4 r62847 merged revision(s) 61346.
-
- parse.y: end of script at newline
* parse.y (parser_yylex): deal with end of script chars just after
ignored newline as other places. [ruby-core:84349] [Bug #14206]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branche... -
- ruby_2_4 r62846 merged revision(s) 61278,61281.
-
- IO.new doesn't recive "-" as external_encoding [Bug #13655]
[DOC] `IO.new` accepts `external_encoding`
Revert part of r61278 [Bug #13655]
[ci skip]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_4@... -
- Update openssl to 2.0.7 in ruby_2_4 branch at r62845.
-
- Update openssl 2.0.6 in ruby_2_4 branch at r62842.
I made a mistake in my commit message...
-
- The patch is provided by Kazuki Yamaguchi.
From: Kazuki Yamaguchi <k@rhe.jp>
Date: Mon, 25 Sep 2017 01:32:02 +0900
Subject: [PATCH] openssl: import v2.0.7
Import Ruby/OpenSSL 2.0.7. This contains only bug fixes and test
improvements. T... - 03:40 PM Revision c9dee850 (git): * 2018-03-20
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62844 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 03:40 PM Revision de87b969 (git): * win32/README.win32: `make up` is only necessary when building from SVN source.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62843 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- The patch is provided by Kazuki Yamaguchi.
From: Kazuki Yamaguchi <k@rhe.jp>
Date: Mon, 25 Sep 2017 01:32:02 +0900
Subject: [PATCH] openssl: import v2.0.6
Import Ruby/OpenSSL 2.0.6. This contains only bug fixes and test
improvements. T... -
- * parse.y (yycompile): in some cases (warning, error, dtrace,...),
ruby_sourcefile is expected to be NUL-terminated, so ensure it.
* template/prelude.c.tmpl (prelude_name): NUL-terminate to get rid
of copying static data.
git-svn-i... - 01:04 PM Revision 68f37472 (git): note that patch is required and need to run make up before make
- * win32/README.win32: patch(1) is required, and running `make up` before
`make` is also required.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62840 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- > I was made aware of this issue via this bug [1] report, but it has been already reported [2] and fixed [3] upstream. Would be nice if this is fixed in RDoc shipped in Ruby.
> ...
Sorry, I understand this issue's intention.
This iss... -
- This bug is fixed. RDoc 6.0.2 was released two days ago. Please use it.
-
11:42 AM Bug #14617: rdoc crashes when expression contains embedded comment: no implicit conversion of nil into String (TypeError)
- ~~~
$ rdoc -v
6.0.1
~~~ -
- RDoc might fail when comment is inside code, such as:
~~~ruby
def meth
variable # comment
.chain
end
~~~
I was made aware of this issue via this bug [1] report, but it has been already reported [2] and fixed [3] upstream... -
- * parse.y (k_rescue, k_ensure): revert r62838.
* parse.y (k_do, k_do_LAMBDA, k_do_block): push token infos of
`do`.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62839 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
11:32 AM Bug #14616 (Closed): Segmentation fault in net/http/response
- I'm seeing a memory leak in my production application, which is culminating an a segmentation fault from within net/http/response.rb.
I'm not sure exactly what information you need but here's a backtrace:
~~~
2018-03-18T21:56:59Z:... -
- * parse.y (k_rescue, k_ensure): ignore indentations of `do`, it
is not at the beginning of line usually.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62838 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- ruby_2_5 r62837 merged revision(s) 62244,62246,62301,62302,62303,62422,62436,62452.
-
- Merge RubyGems-2.7.5 from upstream.
Please see its details: http://blog.rubygems.org/2018/02/06/2.7.5-released.html
test_gem_util.rb: fix broken test
* test/rubygems/test_gem_util.rb: no guarantee that tmpdir... -
- * parse.y (k_rescue, k_ensure, k_when, k_else, k_elsif): warn
mismatched indentations at keywords in middle of blocks.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62836 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_5@62835 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- fix concurrent test.
* test/rubygems/test_require.rb (test_concurrent_require):
Synchronizations should be in ensure clause. Sometimes
`require` fails (not sure why) and latch is not released.
Such ... -
- Applied in changeset trunk|r62833.
----------
compile.c: arg var index
* compile.c (iseq_set_arguments): determine argument variable
indexes by the order, not by just IDs. arguments begin with `_`
can be duplicate, so by-ID index ... -
- * compile.c (iseq_set_arguments): determine argument variable
indexes by the order, not by just IDs. arguments begin with `_`
can be duplicate, so by-ID index may result in a wrong value.
[ruby-core:86159] [Bug #14611]
git-svn-id... -
- * parse.y (f_kwrest): add the variable name as an argument, as
well as an internal variable.
* parse.y (new_args_tail): now keyword rest argument variable is
always placed between keyword arguments and block argument, so
so just r... -
-
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62831 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 12:32 AM Revision affd2b76 (git): * 2018-03-19
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62830 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62829 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
03/18/2018
-
- I'd say it is ok to add .ok?
:D
What is missing is a description as to what the method `ok?` exactly
does. In the link that you provided it is unclear to which part
exactly you refer the "`#ok?`" method. It may be easier for whoe... -
10:42 PM Feature #14615 (Open): Consider introducing shortcut to check Net::HTTP response type
- Currently you need to either use `kind_of?` or `HTTPResponse#code` to find out the type of a response.
~~~ ruby
response = Net::HTTP.start(uri.hostname,
uri.port,
use_ssl: (uri... -
03:35 PM Bug #14047: SEGV happen when running script under OneDrive directory if File On-Demand is enabled
- ruby_2_3 r62828 merged revision(s) 60421.
-
- ruby_2_4 r62804 merged revision(s) 60421.
- 03:35 PM Revision 5c57eb83 (git): merge revision(s) 60421: [Backport #14047]
- win32.c: unknown reparse tags
* win32/win32.c (rb_w32_read_reparse_point): skip unknown reparse
tags. [ruby-core:83539] [Bug #14047]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_3@62828 b2dd03c8-39d4-4... -
- ruby_2_3 r62827 merged revision(s) 60666,60667,60668.
- 03:33 PM Revision f8b4df93 (git): merge revision(s) 60666,60667,60668: [Backport #14082]
- Fix size on Enumerable#cycle when the size is 0 [Bug #14082].
Patch by Kenichi Kamiya
test/ruby/test_lazy_enumerator.rb: test for [Bug #14082]
enum.c: check argument first
* enum.c (enum_cycle_size): c... -
- ruby_2_3 r62826 merged revision(s) 53573.
- 03:29 PM Revision 091f98cf (git): merge revision(s) 53573: [Backport #11989]
- * parse.y (parser_here_document): an escaped newline is not an
actual newline, and the rest part should not be dedented.
[ruby-core:72855] [Bug #11989]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_3@6... -
- ruby_2_3 r62825 merged revision(s) 60384.
- 03:27 PM Revision ca310ba6 (git): merge revision(s) 60384: [Backport #13887]
- thread_pthread: do not corrupt stack
This fixes stuck test/ruby/test_io.rb with FIBER_USE_NATIVE=0 on
GNU/Linux because linked-list pointers used by glibc get
corrupted when fiber stacks are copied.
Than... -
- ruby_2_3 r62824 merged revision(s) 60437.
- 03:23 PM Revision e9a9f674 (git): merge revision(s) 60437: [Backport #14057]
- TracePoint#enable, #disable: Don't yield any argument. [Bug #14057]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_3@62824 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- ruby_2_3 r62823 merged revision(s) 60294.
- 03:21 PM Revision fdb2421c (git): merge revision(s) 60294: [Backport #11638]
- Clarify the behavior of IO.write without offset in write mode.
https://github.com/ruby/ruby/pull/1571
Patch by @takanabe [fix GH-1571]
[Bug #11638][ruby-core:71277]
git-svn-id: svn+ssh://ci.ruby-lang.org/... -
- ruby_2_3 r62822 merged revision(s) 60160.
- 03:16 PM Revision c1724210 (git): merge revision(s) 60160: [Backport #13998]
- parse.y: token info with BOM
* parse.y (parser_prepare): set token_info_enabled flag first,
before returning at BOM. [ruby-dev:50288] [Bug #13998]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_3@62822 b... -
- ruby_2_3 r62821 merged revision(s) 60055.
- 03:07 PM Revision 541f4f25 (git): merge revision(s) 60055: [Backport #13856]
- io.c: fix segfault with closing socket on Windows
* io.c (fptr_finalize_flush): add an argument to keep GVL.
* io.c (fptr_finalize): adjust for above change.
* io.c (io_close_fptr): closing without GVL causes ano... -
- ruby_2_3 r62820 merged revision(s) 55372.
- 03:04 PM Revision bec19f49 (git): merge revision(s) 55372: [Backport #14179]
- * lib/forwardable.rb (_delegator_method): leave the backtrace
untouched during accessor. forwardable.rb does not appear in
the backtrace during delegated method because of tail-call
optimization.
git-svn-... -
- ruby_2_3 r62818 merged revision(s) 60000,60001,60002.
- 03:00 PM Revision 57647b8a (git): * 2018-03-19
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_3@62819 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 03:00 PM Revision 1816ba09 (git): merge revision(s) 60000,60001,60002: [Backport #13925]
- dup String#partition return value
* string.c (rb_str_partition): return duplicated receiver, when no
splits. [ruby-core:82911] [Bug#13925]
Author: Seiei Miyagi <hanachin@gmail.com>
dup String#rpar... -
- ruby_2_3 r62817 merged revision(s) 59970.
- 02:58 PM Revision 4afc46dc (git): merge revision(s) 59970: [Backport #13736]
- ruby.c: paragraph mode by -00
* ruby.c (proc_options): set to paragraph mode, if -00 is given,
as well as perl and -R0 option in 0.49.
[ruby-core:81987] [Bug #13736]
git-svn-id: svn+ssh://ci.ruby-lang.org/ru... -
02:56 PM Bug #14614 (Closed): Error when running `make update-gems`
- ~~~
vitalkanev@vitalkanev-HP-Mate:~/power/ruby/ruby-2.5.0$ make update-gems
Downloading bundled gem files...
executable host ruby is required. use --with-baseruby option.
# Next line might look-like that:
uncommon.mk:1139: error whi... -
- ruby_2_3 r62816 merged revision(s) 59975.
- 02:56 PM Revision cfb61e59 (git): merge revision(s) 59975: [Backport #13916]
- process: block/unblock signals around fork
As with forking for execve(2) in `spawn', we must block signals
to ensure they are handled correctly in a freshly `fork'-ed child.
* process.c (retry_fork_ruby): block/... -
- ruby_2_3 r62815 merged revision(s) 59956.
- 02:53 PM Revision 2fd7044e (git): merge revision(s) 59956: [Backport #13705]
- vm.c: fix `cfp consistency error' which occurs
when raising exception in bmethod call event
* vm.c (invoke_bmethod): set FINISH flag just before calling vm_exec.
[ruby-dev:50162] [Bug #13705]
git-svn-id: svn+s... -
- ruby_2_3 r62814 merged revision(s) 59602,59887.
- 02:39 PM Revision cc23dc6b (git): merge revision(s) 59602,59887: [Backport #13816]
- High Sierra's APFS cannot use invalid filenames [Bug #13816]
added workaround for APFS file format.
* TestFileExhaustive#test_atime: It fails with nano-sec precise.
I changed to use unixtime for this asser... -
- ruby_2_3 r62813 merged revision(s) 58431,58447.
- 02:34 PM Revision 68506159 (git): merge revision(s) 58431,58447: [Backport #13489]
- test_framework.rb: for case-sensitive filesystem
* test/mkmf/test_framework.rb (test_single_framework): fix header
file name for case-sensitive filesystem. it may not be same as
the framework name, but shoul... -
- ruby_2_3 r62812 merged revision(s) 59867.
- 02:30 PM Revision 1521768c (git): merge revision(s) 59867: [Backport #13894]
- test/win32ole/test_word.rb: word quit without confirmation dialog to save
files. [Bug #13894] Thanks to h.shirosaki.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_3@62812 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- ruby_2_3 r62811 merged revision(s) 59893,59922.
- 02:27 PM Revision d9a7903c (git): merge revision(s) 59893,59922: [Backport #13895]
- fix the case High Sierra's mincore(2) may return -128 [Bug #13895]
Fix typos [ci skip]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_3@62811 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- ruby_2_3 r62810 merged revision(s) 58769,59710,59712.
- 02:25 PM Revision 148f1b91 (git): merge revision(s) 58769,59710,59712: [Backport #13566]
- Treat NULL reference case [Bug #13566]
Fix C level backtrace on Darwin
SEGV caused by invalid instruction call.
skip unless PLATFORM is darwin.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_3@62... -
- ruby_2_3 r62809 merged revision(s) 53798,59454,59954.
- 02:15 PM Revision 89ceb340 (git): merge revision(s) 53798,59454,59954: [Backport #14118]
- * configure.in (ARFLAGS): check if deterministic mode flag is
effective, which is on by default on Ubuntu.
configure.in: use libtool
* configure.in: use libtool on macOS to suppress a warning against
... -
- ruby_2_3 r62808 merged revision(s) 62506,62508.
- 01:56 PM Revision 8602707d (git): merge revision(s) 62506,62508: [Backport #14438]
- test_time_tz.rb: past Japanese DST tzdata fix
* test/ruby/test_time_tz.rb (TestTimeTZ#test_asia_tokyo): follow
the tzdata 2018 fix of Japanese DST transitions (1948-1951).
[ruby-core:85373] [Bug #14438]
... -
01:42 PM Bug #14561: Consistent 2.5.0 seg fault in GC, related to accessing an enumerator in a thread
- It seems to be a `FIBER_USE_NATIVE == 0` environment issue.
Perhaps it may be a potential `Enumerator`'s behaviour issue.
First, `Fiber.new` and `Fiber#resume` must be in same thread, but `Enumerator.new` and `Enumerator#peek` don't ... -
12:24 PM Bug #14613 (Closed): [Docs] Backport r62734 to ruby 2.5
- Please backport r62734 (https://github.com/ruby/ruby/commit/175c514a0dd4134b43e613934caeaa1c115aefa8) since the bug applies to ruby-2.5 documentation.
-
- * compile.c (ibf_dump_object_object): fix a probable typo in the
function name, s/lbf/ibf/.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62807 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
10:28 AM Revision dce4a3f5 (git): Improve CSV performance
- If it will not use special variables (like $1, $&, $`...),
it can improve the performance by using Regexp#match? or String#match? instead of Regexp#=~ or String#=~.
This patch is same idea as https://github.com/ruby/ruby/pull/1836
[Fix... -
06:54 AM Revision 01e9d9ac (git): Remove duplicated `,` [ci skip]
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62805 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- win32.c: unknown reparse tags
* win32/win32.c (rb_w32_read_reparse_point): skip unknown reparse
tags. [ruby-core:83539] [Bug #14047]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_4@62804 b2dd03c8-39d4-4... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_4@62803 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- テストが通らなかったので ruby_2_4 へのバックポート r62797, r62784 は revert しました。
- 03:57 AM Revision 9363d720 (git): * 2018-03-18
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_4@62802 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_4@62801 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62800 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Is there a standard that mandates or prefers either variant?
If not then perhaps ruby should decide on which variant to
prefer.
03/17/2018
-
11:52 PM Bug #14612 (Closed): IPv6 address inconsistency (downcase vs. upcase)
- I've noticed that sometimes ip addresses re shown using a-f characters in downcase, other times upcase. Here is a small script to show results:
```ruby
require "resolv"
require "socket"
puts TCPSocket.getaddress("nghttp2.org") #=> ... -
10:32 PM Feature #14473: Add Range#subrange?
- Are there any further thoughts on my latest patch? Based on the discussion above, I think I should rename the added methods: `s/set/range/` and perhaps also prevent the "bad performance" cases where either range has `exclude_end?` true a...
- 03:13 PM Revision d0b207ee (git): * 2018-03-18
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62799 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 03:13 PM Revision 3381ffee (git): If host of URI is omitted, make it with IP address.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62798 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- I backported additionally r57484,r58767,r58938,r59041 to try to get rid of CI failure.
http://mswinci.japaneast.cloudapp.azure.com/vc12-x64/ruby-2.4/log/20180316T201433Z.fail.html.gz -
- ruby.c: forbid options
* ruby.c (forbid_setid): constified.
* ruby.c (process_options): forbid if setid earlier.
ruby.c: encode script name
* ruby.c (process_options): encode script name to locale enco... -
- You see wrong place.
`alphanumeric` is a method defined in [`Random::Formatter`].
[`Random::Formatter`]: http://ruby-doc.org/stdlib-2.5.0/libdoc/securerandom/rdoc/Random/Formatter.html#method-i-alphanumeric -
- I've made a patch.
-
- * compile.c (ibf_dump_align): resize the dump buffer.
rb_str_modify_expand expands the buffer but not set the length.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62796 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62795 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
06:41 AM Revision f5fc032e (git): Remove unused variables
- This fixes following warning:
```
test/logger/test_logger.rb:329: warning: assigned but unused variable - read_read
```
[Fix GH-1840]
From: yuuji.yaginuma <yuuji.yaginuma@gmail.com>
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@6... -
- It can be specified from 2.0. Ref: https://bugs.ruby-lang.org/issues/7103
[Fix GH-1841]
From: yuuji.yaginuma <yuuji.yaginuma@gmail.com>
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62793 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- ENV didn't have any useful information.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62792 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * compile.c (ibf_dump_align): expand the buffer for alignment.
* compile.c (ibf_dump_iseq_list, ibf_dump_object_list): align as
ibf_offset_t. not all processors do not allow unaligned word,
or larger, access.
git-svn-id: svn+ssh:/... -
- * string.c (rb_str_split_m): [DOC] about split with block.
[Feature #4780]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62790 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- I did not know that either.
I guess the problem was that bogdan was using variables with
a leading '`_`'.
With this:
```ruby
def x(a,a,b)
puts 'HI'
end
```
I get in IRB:
`SyntaxError ((irb):1: duplicated argument na... -
12:22 AM Bug #14611: Exotic method parameters bug
- Hanmac (Hans Mackowiak) wrote:
> @phluid61 not so fast, ruby allows duplicate "_" as parameters so you can say that you don't want them and ruby should just ignore them
> ...
... really? When did that happen? I had a look in syntax.rdo... -
- Applied in changeset trunk|r62789.
----------
misc/ruby-style.el: use spaces for indentation
instead of hard tabs.
[Bug #14246] -
- instead of hard tabs.
[Bug #14246]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62789 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * tool/transform_mjit_header.rb (MJITHeader.check_code): read
output and errors than discarding errors. also cl.exe prints
the source file name which is a garbage at this time.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@6278... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62787 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 02:00 AM Revision 73b631dd (git): * 2018-03-17
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62786 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Sometimes test hangs in `mjit_get_iseq_func` like this:
http://ci.rvm.jp/results/trunk-test@ruby-sky3/659391
It seems that a process waiting in `mjit_get_iseq_func` does no longer
have MJIT worker thread. We don't wait for JIT finish fo...
03/16/2018
-
- Agreed.
> If my class documentation would be accepted,
You added a lot more examples too if I understand the patch
correctly, so I guess it is better than the old status quo.
The old status quo did not have ... a lot of example... -
11:10 AM Misc #14610 (Closed): Enhance Proc docs
- What caught me recently while mentoring students: there is almost no "canonical" explanation about procs in [Ruby's core docs](https://docs.ruby-lang.org/en/trunk/): Nothing in `doc/*.rdoc`, and for the `Proc` class, documentation of wha...
-
- `git bisect` shows this is from r60440 [Feature #14038].
-
08:00 PM Bug #14596: Ruby master is broken with bootsnap
- Fixed
-
- ruby_2_4 r62784 merged revision(s) 58745,58780,59040,60743.
-
- rb_w32_ugetcwd: UTF-8 version getcwd
* dir.c (rb_dir_getwd): convert from UTF-8.
* win32/win32.c (w32_getcwd): codepage aware getcwd using
GetCurrentDirectoryW.
potential memory leak
* dir.c (... - 04:41 PM Revision 3ca42c04 (git): * 2018-03-17
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_4@62783 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Fix size on Enumerable#cycle when the size is 0 [Bug #14082].
Patch by Kenichi Kamiya
test/ruby/test_lazy_enumerator.rb: test for [Bug #14082]
enum.c: check argument first
* enum.c (enum_cycle_size): c... -
03:34 PM Bug #14611: Exotic method parameters bug
- @phluid61 not so fast, ruby allows duplicate "_" as parameters so you can say that you don't want them and ruby should just ignore them
so you don't get a SyntaxError about duplicated argument name like your change did
That has nothi... -
- bogdan (Bogdan Gusiev) wrote:
>
> ...
Underscore as "not used" here is a convention of Rubocop; your code is no different from:
~~~ruby
def test(a, x, *a)
x
end
~~~
I would say the bug is that it didn't reject the `def` in... -
01:27 PM Bug #14611 (Closed): Exotic method parameters bug
- Consider the following code:
~~~ ruby
def test(_, x, *_)
x
end
test(1,2,3) # => nil
~~~
By some reason second parameter is nil when the rest of parameters declared as not used.
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62781 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- warning: Object#timeout is deprecated, use Timeout.timeout instead.
[ci skip]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62780 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Applied in changeset trunk|r62779.
----------
re.c: do not escape terminator in Regexp.union
* re.c (rb_reg_str_with_term): change terminator.
* re.c (rb_reg_s_union): terminator in source string does not need
to be escaped. termin... -
- Interesting. I would have expected them to be the same.
Would be nice if it could be explained in the official docs
too at http://ruby-doc.org/core-2.5.0/Regexp.html#method-c-union -
- * re.c (rb_reg_str_with_term): change terminator.
* re.c (rb_reg_s_union): terminator in source string does not need
to be escaped. terminators are outside of regexp source itself.
[ruby-core:86149] [Bug #14608]
git-svn-id: svn+ss... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62778 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
12:57 PM Bug #14387: Ruby 2.5 を Alpine Linux で実行すると比較的浅めで SystemStackError 例外になる
- this is somewhat related to this comment: https://bugs.ruby-lang.org/issues/9454#note-6
There is a problem with pthread_getattr_np() when running main thread since we get different results depending on implementation. The `_np` means ... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62777 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
12:14 PM Feature #14022: String#surround
- I admit that now we can use `yield_self`. I didn't think interpolation was elegant enough, but I think I can live with the combination of `yield_self` and `%`.
```ruby
["foo", "bar"]
.join(", ")
.yield_self{|s| '<%s>' % s}
# => "<... -
- * test/ruby/test_iseq.rb (test_to_binary_with_objects): #to_binary
does not support iseq compiled with coverage, just skip.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62776 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- hm i have a slightly problem with this
check out the different return types there:
~~~ ruby
a = []
p *a #=> nil
a = [1]
p *a #=> 1
a = [1,2]
p *a #=> [1,2]
~~~
-
- Small notice: If #13581 would be once acted upon, attaching `p` in the middle of the chain could be as simple as (using one of the proposed syntaxes)
```ruby
.yield_self { |response| JSON.parse(response) }.tap(&:.p)
.dig('object... -
03:11 AM Feature #14609: Let `Kernel#p` without an argument print the receiver
- +1
`Kernel#p` is one of the greatest feature in Ruby. It would be further great to make it useful. -
01:29 AM Feature #14609 (Rejected): Let `Kernel#p` without an argument print the receiver
- # Abstract
`Kernel#p(obj)` prints `obj` as `inspect`ed.
How about printing the receiver if an argument is not given?
# Background
We recently introduced `yield_self`, which encourages block chain.
https://zverok.github.io/bl... -
- This reverts commit r62706.
It causes SEGV on i686-linux (debian) and armv7l-linux-eabihf:
http://www.rubyist.net/~akr/chkbuild/debian/ruby-trunk/log/20180309T204300Z.diff.html.gz
http://rubyci.s3.amazonaws.com/scw-9d6766/ruby-trunk/log... -
- This reverts commit r62708.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62774 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- This reverts commit r62709.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62773 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
06:12 AM Feature #11541: Let attr_accessor, _reader & _writer return symbols of the defined methods
- +1
I'm about to issue the same feature request😆 -
- * compile.c (ibf_load_iseq_each): realpath may be nil. follow up
r59709. [fix https://github.com/Shopify/bootsnap/issues/132]
From: nobu <nobu@b2dd03c8-39d4-4d8f-98ff-823fe69b080e>
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@... -
- * defs/gmake.mk: expand MJIT header file rules for each
architectures.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62771 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * configure.ac (DLDFLAGS): copy LDFLAGS before adding arch flags.
multiple arch flags on universal binary make mjit_header.h
failed.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62770 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- I'm not against the removeal.
BTW, surprisingly, the following code works "as intended."
```
def fib(x)
if x >= 2
a = fib(x - 1)
b = fib(x - 2)
return a + b
end else x
end
p fib(10) #=> 55
```
03/15/2018
-
06:57 PM Bug #14608 (Closed): Regexp::union and forward slashes
- When using Regexp::union and a regular expression with a forward slash, there seem to be some inconsistencies.
~~~ ruby
# this is weird
Regexp.union(/\//, '') # => /(?-mix:\/)|/
Regexp.union(/\//, '') == /(?-mix:\/... -
- Applied in changeset trunk|r62767.
----------
Introduce URI::File to handle file URI scheme
* the default value of URI::File's authority is "" (localhost).
Both nil and "localhost" is normalized to "" by default.
* URI::File ignores ... -
- It breaks Solaris:
http://rubyci.s3.amazonaws.com/unstable11s/ruby-trunk/log/20180301T012502Z.diff.html.gz
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62769 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 04:51 PM Revision 01b46043 (git): * properties.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62768 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * the default value of URI::File's authority is "" (localhost).
Both nil and "localhost" is normalized to "" by default.
* URI::File ignores setting userinfo and port
[Feature #14035]
fix https://github.com/ruby/ruby/pull/1719
fic http... - 03:20 PM Revision 09fb6248 (git): * 2018-03-16
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62766 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * configure.ac (rb_cv_gcc_compiler_cas): do not use one variable
for multiple AC_CACHE_CHECK. in one check, select by different
values.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62765 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
03:00 PM Bug #14541: Class variables have broken semantics, let's fix them
- @Hanmac: Both problems exist, see the example in the description.
The semantics are confusing, that's why I wish we could simplify to avoid inheritance between class variables.
But, matz says it is too incompatible. -
- @Eregon: the problem is the other way around ...
a class variable in a superclass DOES NOT removes class variables in subclasses.
BUT if you define the class variable in the superclass BEFORE the one is defined in the subclasses,
... -
- matz (Yukihiro Matsumoto) wrote:
> It's possible to make those warning replaced by exceptions. I am strongly positive about it.
OK, at least that would remove the very confusing semantics of a class variable in a superclass removes clas... -
07:15 AM Bug #14541: Class variables have broken semantics, let's fix them
- Although the use of class variables is not recommended (like global variables), proposed behavior changes introduce huge incompatibility.
Error-prone cases like above examples, we already give warnings.
* "warning: class variable a... -
02:55 PM Bug #14607 (Closed): Fix use of the rb_profile_frames start parameter
- rb_profile_frames was always behaving as if the value given for the start parameter was 0.
The reason for this was that it would check `if (start > 0) {` then `continue` without updating the control frame pointer or anything other tha... -
- naruse (Yui NARUSE) wrote:
> reverted ruby_2_5 r62426. it caused test failure
Forgive me if I'm misunderstanding, but should this be reopened if the Ruby 2.5 backport was reverted? -
- Accepted.
Matz.
-
07:59 AM Feature #14606 (Open): Change begin-else-end without rescue from warning to syntax error
- ~~~ ruby
begin
p :foo
else
p :bar
end
# => :foo
# => :bar
~~~
~~~ ruby
[1,2,3].each do
p :foo
else
p :bar
end
# => :foo
# => :bar
~~~
begin-else-end without rescue is useless and dangerous. (especially, ... -
- what about something when you don't have method name or arguments to expose?
like that idea with a combined Enumerator?
that does interate [1,2,3] first, then ["a", "b", "c"] and so on.
for such thing i don't think that there is m... -
- This seems fine but very specific.
I still think exposing an Enumerator's receiver, method name and arguments is better as it is more general, intuitive and useful.
I don't think there is anything wrong with checking the condition me... -
- Sounds reasonable. Accepted.
Matz.
-
06:35 AM Feature #13904 (Assigned): getter for original information of Enumerator
- (Continue from #14044)
Following today's developers meeting, I propose to introduce a subclass of Enumerator.
This is the example implementation of the subclass:
```ruby
class Enumerator::ArithmeticSequence < Enumerator
attr... - 12:01 PM Revision b12d7f17 (git): NEWS: add descriptions of [Feature #12732]
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62764 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- I'm rejecting this issue because this is meaningless now.
-
- Applied in changeset trunk|r62763.
----------
string.c: split with block
* string.c (rb_str_split_m): yield each split substrings if the
block is given, instead of returing the array. [Feature #4780] -
- Accepted.
Matz.
-
- * string.c (rb_str_split_m): yield each split substrings if the
block is given, instead of returing the array. [Feature #4780]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62763 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- shyouhei (Shyouhei Urabe) wrote:
> Benoit Daloze wrote:
> ...
Not with a Symbol though.
So I think `gsub(/regexp/, md: true)` would not conflict with existing usages.
matz (Yukihiro Matsumoto) wrote:
> `subm` and`gsubm` are accept... -
- `subm` and`gsubm` are acceptable.
Matz.
-
08:09 AM Feature #12745: String#(g)sub(!) should pass a MatchData to the block, not a String
- How about String#subm and String#gsubm ?
It is bit longer but not so long. -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62762 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
-
08:14 AM Feature #14022 (Feedback): String#surround
- It appears like `yield_self` or `%s` formatting can satisfy the use cases noted here.
Changing this ticket to Feedback for now. @sawa, could you update your opinion by taking a look into this discussion? -
07:54 AM Feature #14476: Adding same_all? for checking whether all items in an Array are same
- duerst (Martin Dürst) wrote:
> Example:
> ...
Sorry, this should have been:
[1, 2, 3].uniform? % => true
[:a, :b, :c].uniform? % => true
[1, :b, 'c'].uniform? % => false
-
- matz (Yukihiro Matsumoto) wrote:
> * uniform? - I like this best, but can uniform mean equality?
When seeing uniform?, one thing I think about is that it means "Are all elements of the same type?".
Example:
[1, 2, 3].uniform? ... -
- I am not satisfied with any of the candidates.
* same_all? - weird word order
* all_same? - word order is OK, but there's an ambiguity that "same" means equality or identical.
* all_equal? - the name suggests comparison is done by `... -
- Ah, sorry. Posted to the wrong proposal.
Regarding this issue, we have the naming issue. I agree to add the functionality.
Matz.
-
- Rejected. Unfortunately, the incompatibility this proposal would bring is too big.
Besides that, we have performance concern too.
Matz.
-
- matz (Yukihiro Matsumoto) wrote:
> Agreed for mostly security reasons.
Is this incompatibility acceptable in Ruby 2.6?
-
- Agreed for mostly security reasons.
Matz. -
- matz (Yukihiro Matsumoto) wrote:
> I prefer this syntax to #11105, but this introduces a Ruby-specific syntax different from ES6 syntax.
> ...
So I withdraw this proposal.
-
- I prefer this syntax to #11105, but this introduces a Ruby-specific syntax different from ES6 syntax.
Besides that, I don't like both anyway because they are not intuitive (for me).
Matz.
-
- ruby_2_5 r62761 merged revision(s) 62394,62395.
-
- vm_insnhelper.c: rb_autoloading_value flag
* vm_insnhelper.c (vm_get_ev_const): add flag argument of
`rb_autoloading_value`.
* constant.h (rb_autoloading_value): moved the declaration from
vm_core.h ... - 07:19 AM Revision c6ab3498 (git): Add `exception:` keyword in Kernel#Complex()
- Support `exception:` keyword argument in `Kernel#Complex()`.
If `exception:` is `false`, `Kernel#Complex()` returns `nil` if the given
value cannot be interpreted as a complex value.
The default value of `exception:` is `true`.
This is p... -
- Applied in changeset ruby-trunk:trunk|r62757.
----------
Add `exception:` keyword in Kernel#Integer()
Support `exception:` keyword argument in Kernel#Integer().
If `exception:` is `false`, `Kernel#Integer()` returns `nil` if the given
... - 07:19 AM Revision 0dc74b94 (git): Add `exception:` keyword in Kernel#Rational()
- Support `exception:` keyword argument in `Kernel#Rational()`.
If `exception:` is `false`, `Kernel#Rational()` returns `nil` if the given
value cannot be interpreted as a rational value.
The default value of `exception:` is `true`.
This i... - 07:19 AM Revision 2993b442 (git): Add `exception:` keyword in Kernel#Float()
- Support `exception:` keyword argument in `Kernel#Float()`.
If `exception:` is `false`, `Kernel#Float()` returns `nil` if the given
value cannot be interpreted as a float value.
The default value of `exception:` is `true`.
This is part of... - 07:19 AM Revision 2cfc5b03 (git): Add `exception:` keyword in Kernel#Integer()
- Support `exception:` keyword argument in Kernel#Integer().
If `exception:` is `false`, `Kernel#Integer()` returns `nil` if the given
value cannot be interpreted as an integer value.
The default value of `exception:` is `true`.
This is pa... -
07:16 AM Feature #4017: [PATCH] CSV parsing speedup
- > Does the comparison result say "the patch will improve performance"?
> ...
I attempted to solve the problem that `CSV#line` does not work, but this fix seems to obviously degrade the performance from the original patch.
(After fix co... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62756 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- I've discussed this issue and #13904 in today's developer meeting.
Following the discussion, I decided to withdraw the proposal of range with step.
Instead I propose to introduce a subclass of Enumerator that provides the attributes of... -
- * enumerator.c (append_method): pretty format for keyword
arguments.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62755 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Rejected. Unfortunately, the incompatibility this proposal would bring is too big.
Besides that, we have performance concern too.
Matz. -
- * test/ruby/test_io.rb: use SIGUSR2 instead of SIGUSR1 to confirm
unknown SIGUSR1 exception. On parallel testing, sometime
(1 per some days) SIGUSR1 exception. This fix will make clear which
signal is a suspect.
http://ci.rvm.jp... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62753 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- I've attached a patch that removes `original_iseq` from the `rb_iseq_constant_body` definition. In order to do this, I had to replace `rb_iseq_original_iseq` with a function that calls a callback along with the decoded instructions. Th...
-
- Applied in changeset trunk|r62752.
----------
vm.c: refined error message
* vm.c (kw_check_symbol): refined the error message for non-symbol
key. [Feature #14603] -
- * vm.c (kw_check_symbol): refined the error message for non-symbol
key. [Feature #14603]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62752 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
03/14/2018
-
- I guess I can see how this is a behavior change, but these two objects shouldn't `eql?` each other. It seems like a bug in the `eql?` implementation of the `X` class. These instances won't deal with hash collisions correctly, so I'm no...
- 11:27 PM Revision d9abf6ef (git): * 2018-03-15
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62751 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- `TRACE_INSN_P` doesn't need to know about encoded iseqs, it just needs
to look at decoded iseqs. We have the decoded iseqs available, so no
reason to look at encoded ones. This change allows us to clear
`original_iseq` from the iseq st... -
- Please backport r62725 (https://github.com/ruby/ruby/pull/1834) since the bug applies to all ruby versions under normal maintenance (2.3 to 2.5).
-
- Ideally we could have some means to control the warning/error format. That
way people could select which variant to prefer, the default one or any
other way, like the one shown above. -
03:05 PM Feature #14603 (Closed): Better error message when double-splatting hash with string keys
- I couldn't find an existing issue even though I remember reading about it somewhere.
When double-splatting a hash with string keys, the error message is very cryptic.
~~~ ruby
a( **{ "key" => 1} )
#=> TypeError (wrong argument ... -
02:35 PM Feature #4017: [PATCH] CSV parsing speedup
- Thanks. I've added the benchmark script to the repository.
Does the comparison result say "the patch will improve performance"?
If so, can you complete your work to adapt the patch to the master and create a pull request? -
- In addition, I'm porting patches in this issue and got benchmark results.
## Result
- Ruby version: ruby 2.5.0p0 (2017-12-25 revision 61468) [x86_64-darwin16]
- Processor: Intel Core i7 6700K @ 4 GHz
- Memory: 16 GB
- Target revis... -
- I tried to create a benchmark script for `CSV.parse`
(Using `benchmark-ips` gem)
## Script
```
# benchmark script for CSV.parse
# Usage: `ruby $0 [rows count(default: 1000)]`
require 'csv'
require 'benchmark/ips'
Benchmark.... -
- * configure.ac: basic libraries like -lm are necessary for some
extension libraries on some platforms.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62749 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
01:01 PM Feature #14602: Version of dig that raises error if a key is not present
- duerst (Martin Dürst) wrote:
> Would a keyword parameter to dig work for you?
> ...
I appreciate the thought. I personally would be more likely to do `hash.fetch(:name).fetch(:middle)` instead of adding a keyword argument to `#dig`, un... -
- shevegen (Robert A. Heiler) wrote:
> I think this may be somewhat problematic since it does not appear
> ...
You have a good point about the bang methods often signifying an in-place operation rather than an error-prone one; the latter... -
- Would a keyword parameter to dig work for you?
E.g. `hash.dig!(:name, :middle, raise_error: true)` or something similar. -
- * test/ruby/test_weakmap.rb (test_include?): create and release
the object to be garbage-collected in deeper frame.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62748 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
11:40 AM Bug #14561: Consistent 2.5.0 seg fault in GC, related to accessing an enumerator in a thread
- I believe I've run into this bug too.
macOS: 10.13.3
Ruby: 2.5.0
I was running this code:
https://github.com/socketry/async-websocket/tree/ruby-segv
Specifically, in the "chat/" directory, run `./config.ru` to start the serv... -
10:16 AM Feature #4483 (Rejected): PStoreをデフォルトで複数のスレッドから扱えるようにしたい
-
02:59 AM Bug #14600: test-all & REXML - fixup
- To all & @kou
Apologizes for not providing more detail. The results above are for tests not run parallel, which (as I recall) adds 3 asserts for every test. I've got the test system patched to account for that and also output the nu... -
-
- * sprintf.c (ruby__sfvextra): quote symbols as identifiers.
* string.c (rb_id_quote_unprintable): ditto.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62747 b2dd03c8-39d4-4d8f-98ff-823fe69b080e