Activity
From 03/10/2018 to 03/16/2018
03/16/2018
-
11:18 PM Misc #14610: Enhance Proc docs
- Agreed.
> If my class documentation would be accepted,
You added a lot more examples too if I understand the patch
correctly, so I guess it is better than the old status quo.
The old status quo did not have ... a lot of example... -
11:10 AM Misc #14610 (Closed): Enhance Proc docs
- What caught me recently while mentoring students: there is almost no "canonical" explanation about procs in [Ruby's core docs](https://docs.ruby-lang.org/en/trunk/): Nothing in `doc/*.rdoc`, and for the `Proc` class, documentation of wha...
-
08:23 PM Bug #14561: Consistent 2.5.0 seg fault in GC, related to accessing an enumerator in a thread
- `git bisect` shows this is from r60440 [Feature #14038].
-
08:00 PM Bug #14596: Ruby master is broken with bootsnap
- Fixed
-
05:34 PM Bug #13863: RUBYLIB にカレントディレクトリを設定した場合、－E cp932:utf-8 を指定するとスクリプトが全く実行されない
- ruby_2_4 r62784 merged revision(s) 58745,58780,59040,60743.
-
- rb_w32_ugetcwd: UTF-8 version getcwd
* dir.c (rb_dir_getwd): convert from UTF-8.
* win32/win32.c (w32_getcwd): codepage aware getcwd using
GetCurrentDirectoryW.
potential memory leak
* dir.c (... - 04:41 PM Revision 3ca42c04 (git): * 2018-03-17
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_4@62783 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Fix size on Enumerable#cycle when the size is 0 [Bug #14082].
Patch by Kenichi Kamiya
test/ruby/test_lazy_enumerator.rb: test for [Bug #14082]
enum.c: check argument first
* enum.c (enum_cycle_size): c... -
03:34 PM Bug #14611: Exotic method parameters bug
- @phluid61 not so fast, ruby allows duplicate "_" as parameters so you can say that you don't want them and ruby should just ignore them
so you don't get a SyntaxError about duplicated argument name like your change did
That has nothi... -
03:11 PM Bug #14611: Exotic method parameters bug
- bogdan (Bogdan Gusiev) wrote:
>
> ...
Underscore as "not used" here is a convention of Rubocop; your code is no different from:
~~~ruby
def test(a, x, *a)
x
end
~~~
I would say the bug is that it didn't reject the `def` in... -
01:27 PM Bug #14611 (Closed): Exotic method parameters bug
- Consider the following code:
~~~ ruby
def test(_, x, *_)
x
end
test(1,2,3) # => nil
~~~
By some reason second parameter is nil when the rest of parameters declared as not used.
-
02:12 PM Revision 6cd5db89 (git): test_weakmap.rb: skip unstable assertion
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62781 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
02:09 PM Revision 23358107 (git): sample/timeout.rb: fix warnings
- warning: Object#timeout is deprecated, use Timeout.timeout instead.
[ci skip]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62780 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Applied in changeset trunk|r62779.
----------
re.c: do not escape terminator in Regexp.union
* re.c (rb_reg_str_with_term): change terminator.
* re.c (rb_reg_s_union): terminator in source string does not need
to be escaped. termin... -
- Interesting. I would have expected them to be the same.
Would be nice if it could be explained in the official docs
too at http://ruby-doc.org/core-2.5.0/Regexp.html#method-c-union -
- * re.c (rb_reg_str_with_term): change terminator.
* re.c (rb_reg_s_union): terminator in source string does not need
to be escaped. terminators are outside of regexp source itself.
[ruby-core:86149] [Bug #14608]
git-svn-id: svn+ss... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62778 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
12:57 PM Bug #14387: Ruby 2.5 を Alpine Linux で実行すると比較的浅めで SystemStackError 例外になる
- this is somewhat related to this comment: https://bugs.ruby-lang.org/issues/9454#note-6
There is a problem with pthread_getattr_np() when running main thread since we get different results depending on implementation. The `_np` means ... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62777 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
12:14 PM Feature #14022: String#surround
- I admit that now we can use `yield_self`. I didn't think interpolation was elegant enough, but I think I can live with the combination of `yield_self` and `%`.
```ruby
["foo", "bar"]
.join(", ")
.yield_self{|s| '<%s>' % s}
# => "<... -
- * test/ruby/test_iseq.rb (test_to_binary_with_objects): #to_binary
does not support iseq compiled with coverage, just skip.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62776 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- hm i have a slightly problem with this
check out the different return types there:
~~~ ruby
a = []
p *a #=> nil
a = [1]
p *a #=> 1
a = [1,2]
p *a #=> [1,2]
~~~
-
- Small notice: If #13581 would be once acted upon, attaching `p` in the middle of the chain could be as simple as (using one of the proposed syntaxes)
```ruby
.yield_self { |response| JSON.parse(response) }.tap(&:.p)
.dig('object... -
03:11 AM Feature #14609: Let `Kernel#p` without an argument print the receiver
- +1
`Kernel#p` is one of the greatest feature in Ruby. It would be further great to make it useful. -
01:29 AM Feature #14609 (Rejected): Let `Kernel#p` without an argument print the receiver
- # Abstract
`Kernel#p(obj)` prints `obj` as `inspect`ed.
How about printing the receiver if an argument is not given?
# Background
We recently introduced `yield_self`, which encourages block chain.
https://zverok.github.io/bl... -
07:59 AM Revision 94c40622 (git): Revert "Add direct marking on iseq operands"
- This reverts commit r62706.
It causes SEGV on i686-linux (debian) and armv7l-linux-eabihf:
http://www.rubyist.net/~akr/chkbuild/debian/ruby-trunk/log/20180309T204300Z.diff.html.gz
http://rubyci.s3.amazonaws.com/scw-9d6766/ruby-trunk/log... -
- This reverts commit r62708.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62774 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- This reverts commit r62709.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62773 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
06:12 AM Feature #11541: Let attr_accessor, _reader & _writer return symbols of the defined methods
- +1
I'm about to issue the same feature request😆 -
- * compile.c (ibf_load_iseq_each): realpath may be nil. follow up
r59709. [fix https://github.com/Shopify/bootsnap/issues/132]
From: nobu <nobu@b2dd03c8-39d4-4d8f-98ff-823fe69b080e>
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@... -
- * defs/gmake.mk: expand MJIT header file rules for each
architectures.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62771 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * configure.ac (DLDFLAGS): copy LDFLAGS before adding arch flags.
multiple arch flags on universal binary make mjit_header.h
failed.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62770 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- I'm not against the removeal.
BTW, surprisingly, the following code works "as intended."
```
def fib(x)
if x >= 2
a = fib(x - 1)
b = fib(x - 2)
return a + b
end else x
end
p fib(10) #=> 55
```
03/15/2018
-
06:57 PM Bug #14608 (Closed): Regexp::union and forward slashes
- When using Regexp::union and a regular expression with a forward slash, there seem to be some inconsistencies.
~~~ ruby
# this is weird
Regexp.union(/\//, '') # => /(?-mix:\/)|/
Regexp.union(/\//, '') == /(?-mix:\/... -
- Applied in changeset trunk|r62767.
----------
Introduce URI::File to handle file URI scheme
* the default value of URI::File's authority is "" (localhost).
Both nil and "localhost" is normalized to "" by default.
* URI::File ignores ... -
- It breaks Solaris:
http://rubyci.s3.amazonaws.com/unstable11s/ruby-trunk/log/20180301T012502Z.diff.html.gz
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62769 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 04:51 PM Revision 01b46043 (git): * properties.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62768 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * the default value of URI::File's authority is "" (localhost).
Both nil and "localhost" is normalized to "" by default.
* URI::File ignores setting userinfo and port
[Feature #14035]
fix https://github.com/ruby/ruby/pull/1719
fic http... - 03:20 PM Revision 09fb6248 (git): * 2018-03-16
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62766 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * configure.ac (rb_cv_gcc_compiler_cas): do not use one variable
for multiple AC_CACHE_CHECK. in one check, select by different
values.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62765 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
03:00 PM Bug #14541: Class variables have broken semantics, let's fix them
- @Hanmac: Both problems exist, see the example in the description.
The semantics are confusing, that's why I wish we could simplify to avoid inheritance between class variables.
But, matz says it is too incompatible. -
- @Eregon: the problem is the other way around ...
a class variable in a superclass DOES NOT removes class variables in subclasses.
BUT if you define the class variable in the superclass BEFORE the one is defined in the subclasses,
... -
- matz (Yukihiro Matsumoto) wrote:
> It's possible to make those warning replaced by exceptions. I am strongly positive about it.
OK, at least that would remove the very confusing semantics of a class variable in a superclass removes clas... -
07:15 AM Bug #14541: Class variables have broken semantics, let's fix them
- Although the use of class variables is not recommended (like global variables), proposed behavior changes introduce huge incompatibility.
Error-prone cases like above examples, we already give warnings.
* "warning: class variable a... -
02:55 PM Bug #14607 (Closed): Fix use of the rb_profile_frames start parameter
- rb_profile_frames was always behaving as if the value given for the start parameter was 0.
The reason for this was that it would check `if (start > 0) {` then `continue` without updating the control frame pointer or anything other tha... -
02:15 PM Bug #14273: Stack Consistency Error from return in loop
- naruse (Yui NARUSE) wrote:
> reverted ruby_2_5 r62426. it caused test failure
Forgive me if I'm misunderstanding, but should this be reopened if the Ruby 2.5 backport was reverted? -
- Accepted.
Matz.
-
07:59 AM Feature #14606 (Open): Change begin-else-end without rescue from warning to syntax error
- ~~~ ruby
begin
p :foo
else
p :bar
end
# => :foo
# => :bar
~~~
~~~ ruby
[1,2,3].each do
p :foo
else
p :bar
end
# => :foo
# => :bar
~~~
begin-else-end without rescue is useless and dangerous. (especially, ... -
- what about something when you don't have method name or arguments to expose?
like that idea with a combined Enumerator?
that does interate [1,2,3] first, then ["a", "b", "c"] and so on.
for such thing i don't think that there is m... -
- This seems fine but very specific.
I still think exposing an Enumerator's receiver, method name and arguments is better as it is more general, intuitive and useful.
I don't think there is anything wrong with checking the condition me... -
- Sounds reasonable. Accepted.
Matz.
-
06:35 AM Feature #13904 (Assigned): getter for original information of Enumerator
- (Continue from #14044)
Following today's developers meeting, I propose to introduce a subclass of Enumerator.
This is the example implementation of the subclass:
```ruby
class Enumerator::ArithmeticSequence < Enumerator
attr... - 12:01 PM Revision b12d7f17 (git): NEWS: add descriptions of [Feature #12732]
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62764 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- I'm rejecting this issue because this is meaningless now.
-
- Applied in changeset trunk|r62763.
----------
string.c: split with block
* string.c (rb_str_split_m): yield each split substrings if the
block is given, instead of returing the array. [Feature #4780] -
- Accepted.
Matz.
-
- * string.c (rb_str_split_m): yield each split substrings if the
block is given, instead of returing the array. [Feature #4780]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62763 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- shyouhei (Shyouhei Urabe) wrote:
> Benoit Daloze wrote:
> ...
Not with a Symbol though.
So I think `gsub(/regexp/, md: true)` would not conflict with existing usages.
matz (Yukihiro Matsumoto) wrote:
> `subm` and`gsubm` are accept... -
- `subm` and`gsubm` are acceptable.
Matz.
-
08:09 AM Feature #12745: String#(g)sub(!) should pass a MatchData to the block, not a String
- How about String#subm and String#gsubm ?
It is bit longer but not so long. -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62762 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
-
08:14 AM Feature #14022 (Feedback): String#surround
- It appears like `yield_self` or `%s` formatting can satisfy the use cases noted here.
Changing this ticket to Feedback for now. @sawa, could you update your opinion by taking a look into this discussion? -
07:54 AM Feature #14476: Adding same_all? for checking whether all items in an Array are same
- duerst (Martin Dürst) wrote:
> Example:
> ...
Sorry, this should have been:
[1, 2, 3].uniform? % => true
[:a, :b, :c].uniform? % => true
[1, :b, 'c'].uniform? % => false
-
- matz (Yukihiro Matsumoto) wrote:
> * uniform? - I like this best, but can uniform mean equality?
When seeing uniform?, one thing I think about is that it means "Are all elements of the same type?".
Example:
[1, 2, 3].uniform? ... -
- I am not satisfied with any of the candidates.
* same_all? - weird word order
* all_same? - word order is OK, but there's an ambiguity that "same" means equality or identical.
* all_equal? - the name suggests comparison is done by `... -
- Ah, sorry. Posted to the wrong proposal.
Regarding this issue, we have the naming issue. I agree to add the functionality.
Matz.
-
- Rejected. Unfortunately, the incompatibility this proposal would bring is too big.
Besides that, we have performance concern too.
Matz.
-
07:52 AM Feature #14245: Add File.read etc.
- matz (Yukihiro Matsumoto) wrote:
> Agreed for mostly security reasons.
Is this incompatibility acceptable in Ruby 2.6?
-
- Agreed for mostly security reasons.
Matz. -
- matz (Yukihiro Matsumoto) wrote:
> I prefer this syntax to #11105, but this introduces a Ruby-specific syntax different from ES6 syntax.
> ...
So I withdraw this proposal.
-
- I prefer this syntax to #11105, but this introduces a Ruby-specific syntax different from ES6 syntax.
Besides that, I don't like both anyway because they are not intuitive (for me).
Matz.
-
- ruby_2_5 r62761 merged revision(s) 62394,62395.
-
- vm_insnhelper.c: rb_autoloading_value flag
* vm_insnhelper.c (vm_get_ev_const): add flag argument of
`rb_autoloading_value`.
* constant.h (rb_autoloading_value): moved the declaration from
vm_core.h ... - 07:19 AM Revision c6ab3498 (git): Add `exception:` keyword in Kernel#Complex()
- Support `exception:` keyword argument in `Kernel#Complex()`.
If `exception:` is `false`, `Kernel#Complex()` returns `nil` if the given
value cannot be interpreted as a complex value.
The default value of `exception:` is `true`.
This is p... -
- Applied in changeset ruby-trunk:trunk|r62757.
----------
Add `exception:` keyword in Kernel#Integer()
Support `exception:` keyword argument in Kernel#Integer().
If `exception:` is `false`, `Kernel#Integer()` returns `nil` if the given
... - 07:19 AM Revision 0dc74b94 (git): Add `exception:` keyword in Kernel#Rational()
- Support `exception:` keyword argument in `Kernel#Rational()`.
If `exception:` is `false`, `Kernel#Rational()` returns `nil` if the given
value cannot be interpreted as a rational value.
The default value of `exception:` is `true`.
This i... - 07:19 AM Revision 2993b442 (git): Add `exception:` keyword in Kernel#Float()
- Support `exception:` keyword argument in `Kernel#Float()`.
If `exception:` is `false`, `Kernel#Float()` returns `nil` if the given
value cannot be interpreted as a float value.
The default value of `exception:` is `true`.
This is part of... - 07:19 AM Revision 2cfc5b03 (git): Add `exception:` keyword in Kernel#Integer()
- Support `exception:` keyword argument in Kernel#Integer().
If `exception:` is `false`, `Kernel#Integer()` returns `nil` if the given
value cannot be interpreted as an integer value.
The default value of `exception:` is `true`.
This is pa... -
07:16 AM Feature #4017: [PATCH] CSV parsing speedup
- > Does the comparison result say "the patch will improve performance"?
> ...
I attempted to solve the problem that `CSV#line` does not work, but this fix seems to obviously degrade the performance from the original patch.
(After fix co... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62756 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- I've discussed this issue and #13904 in today's developer meeting.
Following the discussion, I decided to withdraw the proposal of range with step.
Instead I propose to introduce a subclass of Enumerator that provides the attributes of... -
- * enumerator.c (append_method): pretty format for keyword
arguments.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62755 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Rejected. Unfortunately, the incompatibility this proposal would bring is too big.
Besides that, we have performance concern too.
Matz. -
- * test/ruby/test_io.rb: use SIGUSR2 instead of SIGUSR1 to confirm
unknown SIGUSR1 exception. On parallel testing, sometime
(1 per some days) SIGUSR1 exception. This fix will make clear which
signal is a suspect.
http://ci.rvm.jp... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62753 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
12:33 AM Feature #14605 (Open): Remove `original_iseq` from `rb_iseq_constant_body`
- I've attached a patch that removes `original_iseq` from the `rb_iseq_constant_body` definition. In order to do this, I had to replace `rb_iseq_original_iseq` with a function that calls a callback along with the decoded instructions. Th...
-
- Applied in changeset trunk|r62752.
----------
vm.c: refined error message
* vm.c (kw_check_symbol): refined the error message for non-symbol
key. [Feature #14603] -
- * vm.c (kw_check_symbol): refined the error message for non-symbol
key. [Feature #14603]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62752 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
03/14/2018
-
- I guess I can see how this is a behavior change, but these two objects shouldn't `eql?` each other. It seems like a bug in the `eql?` implementation of the `X` class. These instances won't deal with hash collisions correctly, so I'm no...
- 11:27 PM Revision d9abf6ef (git): * 2018-03-15
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62751 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- `TRACE_INSN_P` doesn't need to know about encoded iseqs, it just needs
to look at decoded iseqs. We have the decoded iseqs available, so no
reason to look at encoded ones. This change allows us to clear
`original_iseq` from the iseq st... -
- Please backport r62725 (https://github.com/ruby/ruby/pull/1834) since the bug applies to all ruby versions under normal maintenance (2.3 to 2.5).
-
- Ideally we could have some means to control the warning/error format. That
way people could select which variant to prefer, the default one or any
other way, like the one shown above. -
03:05 PM Feature #14603 (Closed): Better error message when double-splatting hash with string keys
- I couldn't find an existing issue even though I remember reading about it somewhere.
When double-splatting a hash with string keys, the error message is very cryptic.
~~~ ruby
a( **{ "key" => 1} )
#=> TypeError (wrong argument ... -
02:35 PM Feature #4017: [PATCH] CSV parsing speedup
- Thanks. I've added the benchmark script to the repository.
Does the comparison result say "the patch will improve performance"?
If so, can you complete your work to adapt the patch to the master and create a pull request? -
- In addition, I'm porting patches in this issue and got benchmark results.
## Result
- Ruby version: ruby 2.5.0p0 (2017-12-25 revision 61468) [x86_64-darwin16]
- Processor: Intel Core i7 6700K @ 4 GHz
- Memory: 16 GB
- Target revis... -
- I tried to create a benchmark script for `CSV.parse`
(Using `benchmark-ips` gem)
## Script
```
# benchmark script for CSV.parse
# Usage: `ruby $0 [rows count(default: 1000)]`
require 'csv'
require 'benchmark/ips'
Benchmark.... -
- * configure.ac: basic libraries like -lm are necessary for some
extension libraries on some platforms.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62749 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
01:01 PM Feature #14602: Version of dig that raises error if a key is not present
- duerst (Martin Dürst) wrote:
> Would a keyword parameter to dig work for you?
> ...
I appreciate the thought. I personally would be more likely to do `hash.fetch(:name).fetch(:middle)` instead of adding a keyword argument to `#dig`, un... -
- shevegen (Robert A. Heiler) wrote:
> I think this may be somewhat problematic since it does not appear
> ...
You have a good point about the bang methods often signifying an in-place operation rather than an error-prone one; the latter... -
- Would a keyword parameter to dig work for you?
E.g. `hash.dig!(:name, :middle, raise_error: true)` or something similar. -
- * test/ruby/test_weakmap.rb (test_include?): create and release
the object to be garbage-collected in deeper frame.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62748 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
11:40 AM Bug #14561: Consistent 2.5.0 seg fault in GC, related to accessing an enumerator in a thread
- I believe I've run into this bug too.
macOS: 10.13.3
Ruby: 2.5.0
I was running this code:
https://github.com/socketry/async-websocket/tree/ruby-segv
Specifically, in the "chat/" directory, run `./config.ru` to start the serv... -
10:16 AM Feature #4483 (Rejected): PStoreをデフォルトで複数のスレッドから扱えるようにしたい
-
02:59 AM Bug #14600: test-all & REXML - fixup
- To all & @kou
Apologizes for not providing more detail. The results above are for tests not run parallel, which (as I recall) adds 3 asserts for every test. I've got the test system patched to account for that and also output the nu... -
-
- * sprintf.c (ruby__sfvextra): quote symbols as identifiers.
* string.c (rb_id_quote_unprintable): ditto.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62747 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
03/13/2018
-
- I think this may be somewhat problematic since it does not appear
to fit to other methods that end with a "!", such as .chop() versus
.chop!() for a String or .map() versus .map!() for an Array.
In the past I thought that "!" would... -
- Currently, if I have a hash like this:
~~~ ruby
{
:name => {
:first => "Ariel",
:last => "Caplan"
}
}
~~~
and I want to navigate confidently and raise a KeyError if something is missing, I can do:
... -
- Possible fix or workaround:
~~~
diff --git a/thread_pthread.c b/thread_pthread.c
index 951885ffa0..e2d662143b 100644
--- a/thread_pthread.c
+++ b/thread_pthread.c
@@ -721,7 +721,7 @@ ruby_init_stack(volatile VALUE *addr
... -
- Since this will soon be discussed in the upcoming ruby developer
meeting, I only wanted to add two small things:
**First**, Yusuke Endoh wrote back then:
> "" as a StringBuilder is acutally useful. "".dup is too tiring.
I mysel... -
02:33 AM Feature #11473 (Assigned): Immutable String literal in Ruby 3
-
- Forgot about this one. The file `ruby/test_m17n_comb.rb` will not run with 'frozen string". I patched that, and also sped things up a bit (about a 30% drop in time). Test & assertion count remain the same.
Patch is at https://githu... -
- @nobu
Are there imaginable real-life incompatibilities introduced by changing semantics?
I believe that `begin.include_range?` is more problematic: all older gems and libraries should implement it (or it should be monkeypatched into... -
- tom_dalling (Tom Dalling) wrote:
> 2. If it's a range of strings, it uses `rb_str_include_range_p`
> ...
I thought handling it by `begin.include_range?` method, and `rb_str_include_range_p` was the implementation for `String`. -
- > I can see that changing the behaviour of (3) might lead to incompatibility issues.
Any real case on mind? I can't think of any (well, maybe somebody really relies on the fact how `date..date+1` does not match datetimes in between..... -
07:36 AM Feature #14575: Switch Range#=== to use cover? instead of include?
- The `Range#===` methods currently works in one of three different ways. The code is here: https://github.com/ruby/ruby/blob/df1cd0f438bd17a4d3fbe9077e0b308e0b25c4b5/range.c#L1151-L1158
1. If it's a range of "numeric values", it uses `... - 03:11 PM Revision 251c7892 (git): * 2018-03-14
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62746 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62745 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- First of all, thanks to @nobu for 62738, a quick look shows that the variance in test count for both Travis & Appveyor is much smaller (or non-existent) than before.
Anyway, the main test patch that is still in Ruby-loco is a patch fo... -
01:03 PM Revision 0e60fdc5 (git): test/ripper/test_lexer.rb: add test for r62743
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62744 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Currently `Ripper.slice` raises a FrozenError
```ruby
require 'ripper'
p Ripper.slice('foo', 'ident')
```
```
/path/to/g/lib/ruby/2.6.0/ripper/lexer.rb:193:in `concat': can't modify frozen String (FrozenError)
from /path/to/g/l... -
- Actually r62741 defined the macro... It wasn't intentional.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62742 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Doing `rb_ary_aref` to `global_symbols.ids` is not thread-safe and
randomly causes SEGV.
https://gist.github.com/k0kubun/ab60727c6be7c0e777d2b4241f59173c
But it's convenient for development. So I keep it optionally available.
git-svn-i... -
- update to https://github.com/ruby/ruby/commit/ccc25765143ef294c0a68b48d829c37d86c93b65
1rst run `rails s`, `spring` stopped
```bash
$ rails s
Traceback (most recent call last):
36: from bin/rails:5:in `<main>'
35: from bin/... -
09:15 AM Bug #14599 (Closed): Improve Pathname performance
- Applied in changeset trunk|r62740.
----------
Improve Pathname performance
If it will not use special variables (like $1, $&, $`...),
it can improve the performance by using Regexp#match? instead of Regexp#=~.
Because Regexp#=~ will ge... -
- If it will not use special variables (like $1, $&, $`...),
it can improve the performance by using Regexp#match? instead of Regexp#=~.
Because Regexp#=~ will generate the objects to special variables by pattern matching.
This patch ... -
- If it will not use special variables (like $1, $&, $`...),
it can improve the performance by using Regexp#match? instead of Regexp#=~.
Because Regexp#=~ will generate the objects to special variables by pattern matching.
This patch will... -
- Applied in changeset trunk|r62739.
----------
Add FileUtils#cp_lr
* lib/fileutils.rb: Add FileUtils#cp_lr. This method creates hard links
of each file from directory to another directory recursively.
This patch is based on Thomas ... -
- * lib/fileutils.rb: Add FileUtils#cp_lr. This method creates hard links
of each file from directory to another directory recursively.
This patch is based on Thomas Sawyers and Zachary Scott.
[Feature #4189] [ruby-core:33820]
git-... -
- [Fix GH-1763]
From: MSP-Greg <MSP-Greg@users.noreply.github.com>
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62738 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * eval_error.c (print_errinfo): reset all attributes for each
lines before newlines.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62737 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * eval_error.c (print_errinfo): do not print an empty line at the
end when the message ends with a newline.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62736 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- I'm still not clear why a new name needs to be introduced. `Fiber` should be sufficient IMHO, if you want to enable/disable auto yield on blocking operations, perhaps make it an option to Fiber, e.g. `Fiber.new(non_blocking: true)`. That...
-
- * test/ruby/test_enumerator.rb (test_uniq): remove assertions
which ared duplicate of lazy enumerator tests in
test_lazy_enumerator.rb.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62735 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- [Fix GH-1818]
From: Miguel Landaeta <miguel@miguel.cc>
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62734 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62733 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- And thus avoiding Module#name calls. Those are slow, especially in
larger projects, with lots of anonymous modules.
[Fix GH-1798]
From: Dmitry Gutov <dgutov@yandex.ru>
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62732 b2dd03c8-3... -
- * enumerator.c (lazy_uniq_i): create new hash for each calls.
[Fix GH-1820]
Currently
2.5.0-preview1 :001 > arr = (0..100).lazy.uniq{|i| i % 10}
=> #<Enumerator::Lazy: #<Enumerator::Lazy: 0..100>:uniq>
2.5.0-... -
- At least, that test should not be in `test_parse`, but in `test_set_component` or others.
03/12/2018
-
08:42 PM Feature #11210: IPAddr has no public method to get the current subnet mask
- https://github.com/ruby/ipaddr/commit/293ad5ac6ed704f91d418ecaf24ae58156a587e7 fixes this in the ipaddr gem. Good enough for me, I guess this issue can be closed.
- 03:19 PM Revision 3438cfa7 (git): * 2018-03-13
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62730 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * test/lib/test/unit/assertions.rb (assert_not_all): fix missing
parentheses.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62729 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- The explanations and reasons have been stated and given already, Tectract.
See the comments made by bdewater or mrkn or yuki24. It is not a "bug" so
it makes no real sense to claim that there is one when there is not. -
- Applied in changeset trunk|r62728.
----------
eval_error.c: fix underflow
* eval_error.c (print_errinfo): get rid of negative string length.
[ruby-core:86086] [Bug #14598] -
10:31 AM Bug #14598: [2.6.0 Preview1] Flood of error message occurs when throwing an error including "\n" in its message.
- I tried to translate the original text.
----
Version:
ruby 2.6.0preview1 (2018-02-24 trunk 62554) [x86_64-darwin17]
Environment:
MacOS 10.13.3
Macbook Pro(Core i7, 16GB RAM)
How to reproduce:
ruby -e 'fail "\n"'
On cal... -
- Sorry to have sent the japanese report. I had to send it to ruby-dev.
-
- 2.6.0-preview1にて表題の現象にぶつかったため報告致します。
バージョン:
ruby 2.6.0preview1 (2018-02-24 trunk 62554) [x86_64-darwin17]
環境:
MacOS 10.13.3
Macbook Pro(Core i7, 16GB RAM)
再現方法:
ruby -e 'fail "\n"'
現象:
fail/raiseで文字列を飛ばしたとき、"\n"が含まれていると、... -
- * eval_error.c (print_errinfo): get rid of negative string length.
[ruby-core:86086] [Bug #14598]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62728 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Applied in changeset trunk|r62727.
----------
ripper: fix escaped space
* parse.y: use tSP same as ripper instead of tSPACE.
[ruby-core:86080] [Bug #14597]
* ext/ripper/eventids2.c: tSP is defined in ripper.c now. -
- * parse.y: use tSP same as ripper instead of tSPACE.
[ruby-core:86080] [Bug #14597]
* ext/ripper/eventids2.c: tSP is defined in ripper.c now.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62727 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 06:54 AM Revision 26eb7b3d (git): * 2018-03-12
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62726 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Ignore prepended modules when looking for already defined methods on a
class to set the visibility on.
[Fix GH-1834]
From: Dylan Thacker-Smith <Dylan.Smith@shopify.com>
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62725 b2dd03c8-3... -
- Seems related to [Feature #14370].
03/11/2018
-
11:38 PM Feature #14585: Array#each_pair
- Great explanation, Matthew. Thank you! Sounds like I just need to practice this some more to really get the terminology into my vocabulary :)
-
09:03 PM Bug #9572: Restarting Coverage does not produce correct coverage result
- OK, this lead me on a big journey of chasing better benchmarking related to `Coverage` and Coverband, which is my primary use case for `Coverage`. I learned a lot about getting better benchmarking data as well as where the actual time co...
-
08:13 PM Bug #14076: Installing Ruby 2.3.1 - Ubuntu 17.10
- kubak (Kuba Krzempek) wrote:
> The problem stems from default gcc version (it's 7) used on Ubuntu 17.10.
> ...
That helped me. Thanks. -
07:38 PM Bug #14561: Consistent 2.5.0 seg fault in GC, related to accessing an enumerator in a thread
- I think I'm running into the same bug. I'm new to reading these types of traces, so please let me know if this needs to be a separate issue instead. Running Ruby 2.5.0 on OS X.
~~~
/Users/briankephart/.rvm/rubies/ruby-2.5.0/lib/ruby/... -
- The following code generates a Ripper FATAL stop. 62674 is okay, but 62681 errors. Possibly #62675 parse.y: tSPACE for old bison?
```
require 'ripper'
str = '* The \ must be doubled if not followed by white space: \\.'
tokens = R... -
- Applied in changeset trunk|r62724.
----------
parse.y: fix interpolated string literal dedent
* parse.y (heredoc_dedent): fix interpolated string literal dedent,
remove indentations from only nodes with the newline flag.
[ruby-core... -
- * parse.y (heredoc_dedent): fix interpolated string literal dedent,
remove indentations from only nodes with the newline flag.
[ruby-core:85983] [Bug #14584]
* parse.y (here_document): set the newline flag on literal string
nodes ... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62723 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- issues
https://github.com/Shopify/bootsnap/issues/139
https://github.com/Shopify/bootsnap/issues/132
with https://github.com/ruby/ruby/commit/6679ffd3b5a60ebc13fdefeff6d066b43854029b
```bash
$ rails s
/Users/fudoshiki/.rvm/gem... -
- instead of stdout.
We would not capture the output as test results.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62722 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62721 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Sometimes gcc fails to exec cc1 like this:
https://gist.github.com/ko1/c3db8b193e9cc65c39c541e10d957509
I'm not sure why it happens at all. Please let me add this debugging
output to inspect the random failure on CI for now.
I'll remove... -
- Applied in r62706
- 12:05 AM Revision 6679ffd3 (git): * 2018-03-11
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62719 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * re.c (unescape_nonascii): escaped multibyte character should be
copied as-is, just with checking if the encoding matches.
https://twitter.com/sakuro/status/972014409986883584
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62718...
03/10/2018
-
- iamvery (Jay Hayes) wrote:
> Thank you all for the feedback! I agree, and I'm glad your responses matched my intuition. Do you have any suggestions for how one might better remember `each_cons`? Ruby has a history of introducing aliases... -
- Thank you all for the feedback! I agree, and I'm glad your responses matched my intuition. Do you have any suggestions for how one might better remember `each_cons`? Ruby has a history of introducing aliases for the purpose of clarity. C...
-
- This change assumes that continuously reading `parent_iseq` from block
ISeq would reach non-block ISeq finally.
test/ruby/test_jit.rb: add test that catches 2-depth exception
Combination of r62654 and r62678 caused following error in t... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62716 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * signal.c (trap_signm): check NUL bytes explicitly before raising
"unsupported signal" ArgumentError.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62715 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Thanks for your report.
I've fixed it at master: https://github.com/ruby/csv/commit/71d66af9824e4a30ed616668fc4ce8d9b68a5026 -
- Thanks for your report.
I've fixed it at the master: https://github.com/ruby/csv/commit/ba560e407a152afffea589d832084c249471eeb6 -
- We need some benchmark scripts based on `benchmark` library (or similar library) to work on speedup.
Can someone work on creating benchmark scripts? -
- This code works again with the latest csv.
```ruby
require "csv"
CSV.parse(%|,""|, converters: lambda{|v| v || ""})
#=> [["", ""]]
``` -
- `mjit_finish` may destroy mutex even while it's still locked by
`worker` by race condition. That would result in the following error:
[BUG] pthread_mutex_destroy: Device or resource busy (EBUSY)
Actually I couldn't get a core dump for i... -
06:46 AM Revision e144481e (git): ext/win32ole/win32ole.c: fix typo. [ci skip]
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62713 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
03:21 AM Bug #14595 (Closed): Set filename when initializing a logger with a File object to make reopen work
- see https://github.com/rails/rails/issues/32211#issuecomment-371995187
would be great if it could auto-set filename from file.path
or alternatively handle the case of dev being a `File` during reopen -
- ruby_2_4 r62712 merged revision(s) 60384.
-
- thread_pthread: do not corrupt stack
This fixes stuck test/ruby/test_io.rb with FIBER_USE_NATIVE=0 on
GNU/Linux because linked-list pointers used by glibc get
corrupted when fiber stacks are copied.
Than... -
- ruby_2_4 r62711 merged revision(s) 59963.
-
- thread.c: report then abort
* thread.c (thread_start_func_2): report then abort on exception,
if both are set. [ruby-core:79280] [Bug #13163]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_4@62711 b2dd03... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62710 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- ```
.../ruby/iseq.c: In function ‘rb_vm_insn_null_translator’:
.../ruby/iseq.c:137:12: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
return (int)addr;
^
```
git-svn-id: svn+ssh://ci.rub... -
- http://ci.rvm.jp/results/trunk_clang_50@silicon-docker/627906
```
iseq.h:41:36: error: implicit conversion loses integer precision: 'rb_num_t' (aka 'unsigned long') to 'int' [-Werror,-Wshorten-64-to-32]
int cnt = iseq->body->variable...