Activity
From 03/05/2018 to 03/11/2018
03/11/2018
-
11:38 PM Feature #14585: Array#each_pair
- Great explanation, Matthew. Thank you! Sounds like I just need to practice this some more to really get the terminology into my vocabulary :)
-
09:03 PM Bug #9572: Restarting Coverage does not produce correct coverage result
- OK, this lead me on a big journey of chasing better benchmarking related to `Coverage` and Coverband, which is my primary use case for `Coverage`. I learned a lot about getting better benchmarking data as well as where the actual time co...
-
08:13 PM Bug #14076: Installing Ruby 2.3.1 - Ubuntu 17.10
- kubak (Kuba Krzempek) wrote:
> The problem stems from default gcc version (it's 7) used on Ubuntu 17.10.
> ...
That helped me. Thanks. -
07:38 PM Bug #14561: Consistent 2.5.0 seg fault in GC, related to accessing an enumerator in a thread
- I think I'm running into the same bug. I'm new to reading these types of traces, so please let me know if this needs to be a separate issue instead. Running Ruby 2.5.0 on OS X.
~~~
/Users/briankephart/.rvm/rubies/ruby-2.5.0/lib/ruby/... -
06:33 PM Bug #14597 (Closed): Ripper Issue - introduced between 62674 & 62681
- The following code generates a Ripper FATAL stop. 62674 is okay, but 62681 errors. Possibly #62675 parse.y: tSPACE for old bison?
```
require 'ripper'
str = '* The \ must be doubled if not followed by white space: \\.'
tokens = R... -
12:19 PM Bug #14584 (Closed): Squigly heredoc with interpolation that has a string literal withe spaces gets incorrect value
- Applied in changeset trunk|r62724.
----------
parse.y: fix interpolated string literal dedent
* parse.y (heredoc_dedent): fix interpolated string literal dedent,
remove indentations from only nodes with the newline flag.
[ruby-core... -
- * parse.y (heredoc_dedent): fix interpolated string literal dedent,
remove indentations from only nodes with the newline flag.
[ruby-core:85983] [Bug #14584]
* parse.y (here_document): set the newline flag on literal string
nodes ... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62723 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
12:01 PM Bug #14596 (Closed): Ruby master is broken with bootsnap
- issues
https://github.com/Shopify/bootsnap/issues/139
https://github.com/Shopify/bootsnap/issues/132
with https://github.com/ruby/ruby/commit/6679ffd3b5a60ebc13fdefeff6d066b43854029b
```bash
$ rails s
/Users/fudoshiki/.rvm/gem... -
09:47 AM Revision fd04ea0a (git): test_jit.rb: show debugging output on stderr
- instead of stdout.
We would not capture the output as test results.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62722 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62721 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Sometimes gcc fails to exec cc1 like this:
https://gist.github.com/ko1/c3db8b193e9cc65c39c541e10d957509
I'm not sure why it happens at all. Please let me add this debugging
output to inspect the random failure on CI for now.
I'll remove... -
12:47 AM Feature #14370 (Closed): Directly mark instruction operands and avoid mark_ary usage on rb_iseq_constant_body
- Applied in r62706
- 12:05 AM Revision 6679ffd3 (git): * 2018-03-11
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62719 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * re.c (unescape_nonascii): escaped multibyte character should be
copied as-is, just with checking if the encoding matches.
https://twitter.com/sakuro/status/972014409986883584
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62718...
03/10/2018
-
10:16 PM Feature #14585: Array#each_pair
- iamvery (Jay Hayes) wrote:
> Thank you all for the feedback! I agree, and I'm glad your responses matched my intuition. Do you have any suggestions for how one might better remember `each_cons`? Ruby has a history of introducing aliases... -
- Thank you all for the feedback! I agree, and I'm glad your responses matched my intuition. Do you have any suggestions for how one might better remember `each_cons`? Ruby has a history of introducing aliases for the purpose of clarity. C...
-
- This change assumes that continuously reading `parent_iseq` from block
ISeq would reach non-block ISeq finally.
test/ruby/test_jit.rb: add test that catches 2-depth exception
Combination of r62654 and r62678 caused following error in t... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62716 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * signal.c (trap_signm): check NUL bytes explicitly before raising
"unsupported signal" ArgumentError.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62715 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
09:02 AM Bug #10013 (Closed): [CSV] Yielding all elements from a row
- Thanks for your report.
I've fixed it at master: https://github.com/ruby/csv/commit/71d66af9824e4a30ed616668fc4ce8d9b68a5026 -
- Thanks for your report.
I've fixed it at the master: https://github.com/ruby/csv/commit/ba560e407a152afffea589d832084c249471eeb6 -
- We need some benchmark scripts based on `benchmark` library (or similar library) to work on speedup.
Can someone work on creating benchmark scripts? -
- This code works again with the latest csv.
```ruby
require "csv"
CSV.parse(%|,""|, converters: lambda{|v| v || ""})
#=> [["", ""]]
``` -
- `mjit_finish` may destroy mutex even while it's still locked by
`worker` by race condition. That would result in the following error:
[BUG] pthread_mutex_destroy: Device or resource busy (EBUSY)
Actually I couldn't get a core dump for i... -
06:46 AM Revision e144481e (git): ext/win32ole/win32ole.c: fix typo. [ci skip]
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62713 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
03:21 AM Bug #14595 (Closed): Set filename when initializing a logger with a File object to make reopen work
- see https://github.com/rails/rails/issues/32211#issuecomment-371995187
would be great if it could auto-set filename from file.path
or alternatively handle the case of dev being a `File` during reopen -
02:46 AM Bug #13887: test/ruby/test_io.rb may get stuck with FIBER_USE_NATIVE=0 on Linux
- ruby_2_4 r62712 merged revision(s) 60384.
-
- thread_pthread: do not corrupt stack
This fixes stuck test/ruby/test_io.rb with FIBER_USE_NATIVE=0 on
GNU/Linux because linked-list pointers used by glibc get
corrupted when fiber stacks are copied.
Than... -
- ruby_2_4 r62711 merged revision(s) 59963.
-
- thread.c: report then abort
* thread.c (thread_start_func_2): report then abort on exception,
if both are set. [ruby-core:79280] [Bug #13163]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_4@62711 b2dd03... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62710 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
12:34 AM Revision af0d504f (git): Fix warning: cast from pointer to integer of different size
- ```
.../ruby/iseq.c: In function ‘rb_vm_insn_null_translator’:
.../ruby/iseq.c:137:12: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
return (int)addr;
^
```
git-svn-id: svn+ssh://ci.rub... -
- http://ci.rvm.jp/results/trunk_clang_50@silicon-docker/627906
```
iseq.h:41:36: error: implicit conversion loses integer precision: 'rb_num_t' (aka 'unsigned long') to 'int' [-Werror,-Wshorten-64-to-32]
int cnt = iseq->body->variable...
03/09/2018
- 08:11 PM Revision ff43e243 (git): * 2018-03-10
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62707 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Directly marking iseq operands allows us to eliminate the "mark array"
stored on ISEQ objects, which will reduce the amount of memory ISEQ
objects consume. This patch changes the iseq mark function to:
* Directly marks ISEQ operands
* ... -
01:50 PM Feature #14594: Rethink yield_self's name
- I agree to your statement that yield_self is not a good, descriptive
name.
Though I have to admit that I never used yield_self so far. I can
not even say what it does, either. :)
I like yield and self. I don't like the name yield... -
09:46 AM Feature #14594 (Closed): Rethink yield_self's name
- *I feel really uncomfortable raising the question again, but...*
In several months since 2.5 release I've written a lot of code with `yield_self` (using `backports` gem with earlier versions of Ruby when necessary), and explained it s... -
10:00 AM Bug #14541: Class variables have broken semantics, let's fix them
- If changing class variables to no longer be inherited between classes is considered too hard for compatibility (but I'd like a real-world example),
how about at least removing the semantics that defining a class variable in a superclass... -
07:18 AM Bug #14541: Class variables have broken semantics, let's fix them
- shevegen (Robert A. Heiler) wrote:
> A bit similar to the doc that explains the "Symbol versus String" situation that has been added recently.
Can you please paste here the link to the “Symbol versus String” doc? -
- > This is one of those change requests that I have thought about for
> ...
I may be wrong but I think that matz has indicated a possibility to
change the behaviour (for ruby 3.x, I assume, probably not in the
2.x branch). Perhaps it m... -
08:59 AM Feature #14579: Hash value omission
- Eregon (Benoit Daloze) wrote:
> I'd prefer a syntax which is different than "key syntax without value", and refers to the variable name used for the value more clearly, like:
> ...
I proposed the above syntax in #11105, but it was reje... -
- I agree with Matthew.
I understand the suggestion trying to make the syntax even more succinct
(less to type) but I think it's one step too much. Ruby already has a
quite condensed syntax.
I think this syntax here, asked by Benoi... -
- * Makefile.in, win32/Makefile.sub: move CANONICALIZATION_FOR_MATHN
from config.h which affects all extension libraries to XCFLAGS
for the core only.
* configure.ac: added --disable-mathn option.
git-svn-id: svn+ssh://ci.ruby-lang.o... -
- * math.c (math_log, rb_math_log): inverted calling order, to
remove unused argument.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62704 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62703 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Fixnums can be compared by object values themselves only.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62702 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Fixnums can be compared by object values themselves only.
Addition/subtraction/mulplication of fixnum 0 do not affect the
sign.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62701 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62700 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
01:48 AM Bug #14592 (Rejected): /Users/cathyyee/.rvm/gems/ruby-2.3.0@global/gems/did_you_mean-1.0.0/lib/did_you_mean/spell_checkers/name_error_checkers/variable_name_checker.rb:10: [BUG] Segmentation fault at 0x000000000000cb
-
- Some extension libraries, e.g., ones using swig, need a C++ compiler.
-
12:24 AM Bug #4157 (Closed): test_pty で、たまに出る Failure
- rubyci の FreeBSD のログを手動で少しだけ見てみましたが、再現は見当たりませんでした。
http://rubyci.s3.amazonaws.com/freebsd11zfs/ruby-trunk/summary.html
岸本さんのところでも再現環境がすぐに用意できなくなっていると聞いたので、
とりあえず close しときたいと思います。
03/08/2018
-
- > If the programmer doesn't care about errors (as in my case) the
> ...
Agreed.
Reminds me of my own suggestion to have a variant of require
where we don't have to use begin/rescue (e. g. because of a
similar reason that you mentio... -
- > rescue Errno::ENOENT, Errno::EACCES, Errno::ENOTDIR, Errno::ELOOP, Errno::ENAMETOOLONG, Errno::EINVAL
> ...
I am not sure.
It requires of ruby hackers to know all these various error types that they
want to rescue. It's ok to be... -
02:36 PM Bug #14591 (Closed): Files with invalid multi-byte characters will cause Find::find() to raise EINVAL exception
- This can be easily duplicated by the following simple program. I believe this is mostly going to be a problem for users on Windows, where Unicode filenames are common. The example below was the name of a real file in my Recycle Bin:
... -
09:15 PM Feature #14593: Add `Enumerator#concat`
- > When it comes to one-liner, it is quite long, and IMO not very readable. I consider adding Enumerator#concat as better solution.
I totally agree the one-liner is strange, unwieldy and hard to read. -
06:02 PM Feature #14593: Add `Enumerator#concat`
- shan (Shannon Skipper) wrote:
> That ^ pure Ruby implementation is a bit confusing and like the original one-liner it produces a lazy rather than eager enum.
The reference implementation I have presented is meant to clarify what I me... -
04:51 PM Feature #14593: Add `Enumerator#concat`
- the size object in `Enumerator.new` can be a proc too
that would make the call lazy? -
- Just for fun I tried modifying the one-liner to add a lazily caluculated size:
~~~ ruby
enums.lazy.flat_map(&:lazy).to_enum { enums.sum(&:size) if enums.all?(&:size) }
~~~
That ^ pure Ruby implementation is a bit confusing and li... -
- I propose introducing an `Enumerator#concat(other_enum1, other_enum2, ...)` which returns an enumerator being a concatenation of `self` and passed arguments.
Expectation
-----------
~~~ ruby
enum1 = [1, 2, 3].each
enum2 = %w[a b... -
04:13 PM Bug #14592: /Users/cathyyee/.rvm/gems/ruby-2.3.0@global/gems/did_you_mean-1.0.0/lib/did_you_mean/spell_checkers/name_error_checkers/variable_name_checker.rb:10: [BUG] Segmentation fault at 0x000000000000cb
- You can ignore the crash report. I figured it out. It was a mistake I made in the code on my end. :P
-
- Hi,
I'm a junior developer so still learning about ruby and rails.
I got this error message. Can you explain what it means and how I can fix it? I've included the crash report. Please let me know what other information you need fr... - 04:07 PM Revision 2697ae45 (git): * 2018-03-09
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62699 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
04:07 PM Revision 0f7b26ab (git): Raise ArgumentError if host component is nil
- From: oss92 <mohamed.o.alnagdy@gmail.com>
fix https://github.com/ruby/ruby/pull/1278
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62698 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
02:57 PM Bug #14584: Squigly heredoc with interpolation that has a string literal withe spaces gets incorrect value
- Interestingly enough, it doesn't happen when you have:
~~~ruby
text1 = <<~FOO
one#{" two " * 1}
FOO
~~~
So it seems Ruby does this only when the interpolation has a string literal, presumably to optimize that out and em... -
01:43 AM Bug #14584: Squigly heredoc with interpolation that has a string literal withe spaces gets incorrect value
- 👍 I can confirm this bug exists in 2.5.0p0.
Also, it seems like the number of spaces it's removing is based on the gutter size as well (which is expected?)
~~~ ruby
# two spaces gutter, four leading spaces in literal
<<~FOO
tw... -
02:04 PM Feature #4483: PStoreをデフォルトで複数のスレッドから扱えるようにしたい
- 今となっては僕もどういう状況で困っていたのか忘れてしまったので、他に要望がなければクローズしようと思います。
-
- これ、どうしますか？まだやる気があったら、ハンドルをお願いします。ないなら、close しましょう。（現在、PStore はメンテナ不在です）
以下は個人的意見です。互換性のため、「いきなり消す」はないと思います。どうしても消したいなら、警告期間を用意すべきでしょう。「デフォルトを thread_safe = true にする」はありうるかもしれませんが、慎重な調査や検討が必要かもしれません。 -
01:32 PM Bug #14387: Ruby 2.5 を Alpine Linux で実行すると比較的浅めで SystemStackError 例外になる
- jhealy (James Healy) wrote:
> There's a very similar sounding issue being discussed on the python bug tracker: https://bugs.python.org/issue32307
I first thought that this is same/similar issue as the python, but it is not. (I think ... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62697 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
11:59 AM Feature #14580: Hash#store accepts a block
- Eregon (Benoit Daloze) wrote:
> Soilent (Konstantin x) wrote:
> ...
I see your point, but the example was not about String to Time caching. Let's say you receive an HTTP POST request with the body `timestamp=2018-03-08T11:24:44Z&temper... -
- mame (Yusuke Endoh) wrote:
> I think it is not so simple to optimize the double lookup by this API. Consider:
> ...
I think that an exception should be thrown if the block modifies the hash. -
- mame (Yusuke Endoh) wrote:
> We need to keep a flag if rehash occurred or not during the block executed.
Also, what should happen with:
~~~ruby
hash.store(:a) { |v| hash.delete(:a); v + 42 }
~~~
"store" starts to feel to me l... -
- Soilent (Konstantin x) wrote:
> Consider another example `hash.store(:time) { |ts| Time.parse(ts) }`
That looks weird to me.
Either the Hash is caching String to Time, and then it should use
~~~ruby
Hash.new { |h,k| h[k] = Time.... -
- I think it is not so simple to optimize the double lookup by this API. Consider:
hash.store(:a) {|val| 10000.times {|n| hash[n] = true }; val + 42 }
or:
hash.store(:a) {|val| hash.rehash; val + 42 }
We need to keep a... -
- sawa (Tsuyoshi Sawada) wrote:
> Why not write `hash[:a]+= 42`?
Good point, but this works only for arithmetic operators (and also does 2 key lookups). Consider another example `hash.store(:time) { |ts| Time.parse(ts) }` -
04:45 AM Feature #14580: Hash#store accepts a block
- Why not write `hash[:a]+= 42`?
-
- Eregon (Benoit Daloze) wrote:
> I'd prefer a syntax which is different than "key syntax without value", and refers to the variable name used for the value more clearly, like:
> ...
Please no, this is too close to perl's weird handling ... -
- Should this also work for non-Symbols keys like:
~~~ruby
x = 1
y = 2
h = { "x" => , "y" => }
~~~ -
- I find this syntax very confusing.
The two occurrences of `password:` above means two very different things (required kwarg and auto-hash creation).
For
~~~ruby
x = 1
y = 2
h = {x:, y:}
~~~
it looks to me like the values ... -
10:09 AM Bug #14588: math library functions should NOT raise exceptions
- I don't even care anymore. I just hate the guts of the ruby devs now. I'll make sure to make all my bug reports to your repos as anonymous users from now on so you can't try to get me banned in revenge for pointing out your increasingly ...
-
- Your behavior isn't acceptable.
Going on personal vendettas and threatening to get users banned from github because you didn't like how they re-opened a ticket you closed is not acceptable.
-
- > `Kernel` methods like `Float()`, `Integer()`, and `BigDecimal()` are all explicitly for the purpose of ensure strict conformance with numeric representation.
Are you a robot? NaN should not be an exception. No form of NaN should an ... -
- I suggest that those who think that passing new types of exceptions upstream as asserts is not a BUG are the ones who need to learn programming, not myself. Force-closing actual bug reports and banning users because you think your little...
-
- BigDecimal(".")
ArgumentError: invalid value for BigDecimal(): "." -
- Or is this like a personal vendetta thing for you now?
-
- My points all stand. Please unban me.
-
- Your behavior isn't acceptable. Do not open new issues when your issue is closed and locked. It is very bad manners.
> I'm so sorry, that I reported, as a bug, the fact that my code started breaking because I updated BigDecimal and it... -
- The whole point was meant to be about code fragility and backwards compatility. You guys missed it.
-
- I'm so sorry, that I reported, as a bug, the fact that my code started breaking because I updated BigDecimal and it choked on a random NaN.
-
- Or is this like a personal vendetta thing for you now?
-
- My points all stand. Please unban me.
-
- Kernel methods like `Float()`, `Integer()`, and `BigDecimal()` are all explicitly for the purpose of ensure strict conformance with numeric representation. Each of these Kernel methods raise a `TypeError` when the argument does not stric...
-
- https://github.com/ruby/bigdecimal/issues/95
I request to be unbanned from the FOSS repo. I won't bug your BigDecimal devs anymore, but seriously, I shouldn't have to worry about new and exotic NAN exceptions that ASSERT any time I up... -
- Two points of advice:
1) I was not able to find the issue you mention on github. Please provide a pointer.
2) If you think others have been rude to you, that's not a reason to shout at everybody here (most of us have heard about th... -
- Sorry, sir, the spaceship crashed because BigDecimal asserted, when a "." was passed to the orbital processor, causing the entire Arithmetic Logic Unit to cease operating. If only it had WARNED us instead of refusing to calculate any fur...
-
- Codebases that become more fragile over time will lose old users and fail to attract new ones. Passing asserts up and out of scope in new and fantastic new ways should be considered a BUG. These math libraries need to stay quiet and just...
-
- Maybe the issue is too many asserts and not enough warnings. Maybe these stray NaN cases should be warnings instead of asserts. Maybe puts/print should know how to print integers.
-
- > What Github issue and bugs.ruby-lang.org issue are you referring to?
> ...
Strong typing is not the issue, the issue is codebase FRAGILITY, and ruby is becoming increasingly fragile. Strong typing is fine, but the problem is that ever... -
- What Github issue and bugs.ruby-lang.org issue are you referring to?
> We REFUSE to attempt .to_s automatically
It seems you're wanting Ruby to be weakly typed. Ruby is strongly typed and is likely to stay that way.
> ...
Did yo... -
- To me, passing a breaking error back up to the top level and saying "oops! we couldn't figure out what to do!" is a BUG in any program. You had one job. Cast to integer, literally, shouldn't be that hard to classify error cases here. The...
-
- I've been BANNED from the ruby github repo, for reporting this bug. Wow. You guys are truly insane.
-
- This just represents another way that the mentality of the Ruby programmers seems "sticky", to me.
No implicit conversion of int to string!!! We REFUSE to attempt .to_s automatically, and we INSIST on wasting everyone's time with this... -
- BigDecimal, Integer, Float, none of these should raise exceptions, but they should all fail SILENTLY or return NaN during error cases.
I shouldn't have to go fix every possible way that BigDecimal might throw a breaking change in a th... -
- Applied in changeset trunk|r62695.
----------
fix error if the input is mixed Unicode and percent-escapes
Reported by kivikakk (Ashe Connor) with tests and doc fix
Patch based on mame and fix by naruse
[Bug #14586] -
- I'm unfamiliar with encoding, so this is just my impression: `str.dup.force_encoding(Encoding::ASCII_8BIT)` always creates a string object, so `str.gsub(re) { [$&[1, 2].hex].pack('C').force_encoding(str.encoding) }` might be better?
(... -
01:55 AM Bug #14586 (Closed): URI::RFC2396_Parser#unescape raises an exception if the input is mixed Unicode and percent-escapes
- Currently, the following test case passes:
~~~ ruby
def test_unescape
p1 = URI::Parser.new
assert_equal("\xe3\x83\x90", p1.unescape("\xe3\x83\x90"))
assert_equal("\xe3\x83\x90", p1.unescape('%e3%83%90'))
end
~~~
But the... - 09:38 AM Revision 1529ccf6 (git): * 2018-03-08
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62696 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Reported by kivikakk (Ashe Connor) with tests and doc fix
Patch based on mame and fix by naruse
[Bug #14586]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62695 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
09:27 AM Feature #4907 (Rejected): enumerable#permutation and combination
-
- No use case is shown, so I close this issue.
-
- I continue this issue at https://github.com/ruby/bigdecimal/issues/99
-
- @normalperson, I think that this issue has been fixed more elegantly by introducing `read_nonblock(exception: false)`. Am I right?
-
- i don't like it because i think `each_pair` should react like `each_slice(2)`
-
- I think you have the wrong data structure in the first place. I think you either should have an array of arrays of length two, or a hash.
-
- I though same behavior as phluid61 wrote.
-
- > it may not be clear that Array#each_pair groups overlapping pairs vs. chunking elements
Yeah, I think that's one reason I'm against an ambiguous method like this. I feel like `each_cons(2)` is already good for the job and more fitti... -
- learn the difference between `to_s` and `to_str`
one is explicit, the other is implicit
-
- Too many people's time have been wasted trying to make sure their puts/prints statements don't assert because of failed implicit string conversions. This should be handled by an explicit `.to_s` attempt, and a warning instead of a break.
-
- I'll commit this patch that introduces `FileUtils.cp_lr` in a few days. Let me know if there is a problem.
-
- > It does not "crash". It raises a specific error.
Halting executing while raising an error is called 'crashing' to most people. -
- https://bugs.ruby-lang.org/issues/14589
Not satisfied. -
- Seems satisfied.
-
- GServer has been already moved to GitHub by #5480. I've created [a ticket](https://github.com/ruby/gserver/issues/3) into its tracker, so I'd like to close this ticket.
-
- @kou, could you check this ticket?
-
- @kou, could you check this ticket?
-
- @kou, could you check this ticket?
-
- @kou, could you check this ticket?
-
07:19 AM Bug #14590 (Closed): Why is config script checking for g++
- I am wondering what is the reason the configuration scripts are checking for availability of g++?
~~~
checking for x86_64-redhat-linux-gnu-g++... no
checking for x86_64-redhat-linux-gnu-c++... no
checking for x86_64-redhat-linux-gn... -
- Why has this bug report been rejected?
The bug was rejected at github because I was referred to open a ticket at ruby-lang.org.
The bug was rejectet at ruby-lang.org because the ticket was closed at github.
No critical thought r... -
- This just represents another way that the mentality of the Ruby programmers seems "sticky", to me.
No implicit conversion of int to string!!! We REFUSE to attempt .to_s automatically, and we INSIST on wasting everyone's time with thi... -
05:14 AM Bug #14587 (Rejected): math library functions should NOT raise exceptions
- Rejecting here as we've locked the previous issue at GitHub.
-
- BigDecimal maintainers have actually gotten so angry about reports of this bug that they are locking new threads about it.
They WANT my code to break, lol. -
- BigDecimal, Integer, Float, none of these should raise exceptions, but they should all fail SILENTLY or return NaN during error cases.
See: https://github.com/ruby/bigdecimal/issues/95
I shouldn't have to go fix every possible way... -
04:42 AM Feature #14546: Hash#delete!
- sawa (Tsuyoshi Sawada) wrote:
> What is wrong with using `fetch`?
> ...
Hash#fetch is not mutative. This proposal is for a whiny version of #delete.
```ruby
hsh = { a: 'a' }; hsh.delete!(:a); hsh # => {}
hsh = { a: 'a' }; hsh.dele...
03/07/2018
-
- -1
If I saw a method `Array#each_pair` I'd expect it to behave like:
~~~ruby
class Array
def each_pair
each_with_index do |element, index|
yield index, element
end
end
end
~~~
Further, if you were to pr... -
- # Abstract
I propose we add the method #each_pair to Array. It would effectively be a name for the common case each_cons(2).
# Background
A few times now, I have wanted to do something pairwise on an array of values. One example... -
- Clearly the only accurate name for this method is `store_recursive_with_autovivification`
A lot of people ask for it, but I still can't see how this is a good thing to add to the language. In your personal code, sure -- maybe even in... -
05:29 PM Feature #14564: `dig` opposite method
- I know about those 2 proposals. I references them in the description )
Name is a hard topic. As for types - I'd say that having same type as a receiver is enough.
So, `{}.whatever_name(*)` will generate nested Hashes. `[].whatever_na... -
08:23 PM Bug #14583 (Feedback): #method() is reporting the wrong self in exception
- Oops, misread your report, sorry. Previous answer removed.
Now I'd say that it's a third party issue (pry), unless you can reproduce it in pure ruby... -
05:35 PM Bug #14583 (Closed): #method() is reporting the wrong self in exception
- This is hard to explain but I'll do my best:
When running an rspec test I get this exception:
~~~
Failure/Error: resource_class.write_attributes_via_call(model, attributes.select(&resource.method(:valid_attribute?)))
Nam... -
- Given this program:
~~~ruby
text1 = <<~FOO
one#{" two "}
FOO
text2 = <<~FOO
one#{" two "}
FOO
p text1
p text2
~~~
The output is:
~~~
"one two \n"
"one two \n"
~~~
The two should be equal.
... -
- Hanmac (Hans Mackowiak) wrote:
> ~~~ ruby
> ...
Thanks for the question.
I think that `hash.store(:b)` should yield the default value if the key does not exist, i.e. option b.
But in case of `hash.transform_values(:a, :b)`, when we... -
- Eregon (Benoit Daloze) wrote:
> What should happen if the given key doesn't exist in Hash?
> ...
Good question, thank you. I think, the result of default_proc or the default value should be yielded. -
- Maybe a bit off-topic, but I experimented with same ideas in [hm](https://github.com/zverok/hm) gem. It allows code like this:
```ruby
Hm(hash)
.transform_values(:a) { |val| val + 42 }
.to_h
```
After trying several approac... -
- Hi Robert,
Thank you for your reply. You understood everything correctly.
Also, I might be wrong, but it seems to me that in the following case
~~~ruby
hash[:a] = hash[:a] + 42
~~~
Ruby VM will look up the key twice. The pr... -
~~~ ruby
hash.transform_values(:a, :b) { |val| val + 42 }
hash[:a] #=> 44
~~~
what about the b key? should it:
a) throw exception
b) gives `nil` to the block ? which your code would be an `NoMethod + for nil`
c) will be skipped-
- What should happen if the given key doesn't exist in Hash?
This looks like a compute-if-present operation. -
- If I understood your proposal correctly then you want an
additional way to update an existing value in a hash, correct?
So the comparable syntax parts would be:
hash[:a] = hash[:a] + 42
versus
hash.store(:a) { |val| ... -
- Yeah, having capability to shut down MJIT worker earlier looks important, especially when it becomes matured and we consider enabling it by default.
It's interesting to know your new project of multi-tier JIT. If inlining takes longer... -
03:11 PM Feature #14489: MJIT needs a reusable cache
- On 03/07/2018 08:50 AM, takashikkbn@gmail.com wrote:
> Issue #14489 has been updated by k0kubun (Takashi Kokubun).
>
>
> We should make sure what we're going to solve here first before introducing such mechanism. At least I prefer h... -
- We should make sure what we're going to solve here first before introducing such mechanism. At least I prefer having Feature#14492 first and I suspect boot time would not be the issue after that. With --jit enabled, it takes time to wait...
-
01:02 PM Feature #14489: MJIT needs a reusable cache
- .o file may be reusable if it can be separated from embedded value.
How about `extern const TYPE var;` place holders and other .c file that defines `const TYPE var = (val)`?
Here is a just PoC patch based on r62681 and a result example... -
- ruby_2_4 r62694 merged revision(s) 60437.
-
- TracePoint#enable, #disable: Don't yield any argument. [Bug #14057]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_4@62694 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * Optcarrot
before,--jit: ruby 2.6.0dev (2018-03-07 trunk 62689) +JIT [x86_64-linux]
after,--jit: ruby 2.6.0dev (2018-03-07 trunk 62689) +JIT [x86_64-linux]
last_commit=transform_mjit_header.rb: inline ivar operations
Calculating ------... -
- ruby_2_4 r62692 merged revision(s) 60294.
-
- Clarify the behavior of IO.write without offset in write mode.
https://github.com/ruby/ruby/pull/1571
Patch by @takanabe [fix GH-1571]
[Bug #11638][ruby-core:71277]
git-svn-id: svn+ssh://ci.ruby-lang.org/... -
- ruby_2_4 r62691 merged revision(s) 60160.
-
- parse.y: token info with BOM
* parse.y (parser_prepare): set token_info_enabled flag first,
before returning at BOM. [ruby-dev:50288] [Bug #13998]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_4@62691 b... -
- ruby_2_4 r62690 merged revision(s) 60055.
-
- io.c: fix segfault with closing socket on Windows
* io.c (fptr_finalize_flush): add an argument to keep GVL.
* io.c (fptr_finalize): adjust for above change.
* io.c (io_close_fptr): closing without GVL causes ano... -
- * complex.c (m_cos, m_sin): determine the type by the internal
type, not by a method.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62689 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * complex.c (nucomp_s_canonicalize_internal): determine the type
by the internal type, not by a method.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62688 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Since r37702, parsing complex and rational do not use regexp.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62687 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62686 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
11:42 AM Misc #14581: Update JSON docs
- >what's the maintenance status of the upstream?
It's active. -
- (In addition, as far as I understand, there is some discrepancy between "standalone" `json` and in-Ruby `json`: the latter does not include "pure" part of JSON library, virtually rendering half of its code **and docs** false.)
-
- @hsbt BTW, what's the maintenance status of the upstream? Currently, I can see there:
* the last PR is merged in October, last before that in Jun, last before that in spring, there are several uncommented PRs (including ones with seri... -
- @hsbt Ah, OK. I've tried to find the "upstream" version but failed to do so. Thanks for pointing it out.
-
- Can you submit an upstream repository first?
https://github.com/flori/json
-
11:32 AM Bug #14582: Unable to use `method__entry` and `method_return` tracing probes since 2.5
- Oh. I decided to dig a little bit deeper. Found this this: https://bugs.ruby-lang.org/issues/14104 apparently is required to do:
```
TracePoint.new{}.enable
```
I've added to my code and it works.
I was expecting that this d... -
- Hi,
I am trying to use dtrace/systemtap probes and not being able to use it after the 2.5. The 2.4 version works fine. I was hoping this was fixed on 2.6-preview, but apparently not (just downloaded dev and tested).
I tried on OSX ... -
- * ext/date/date_core.c (offset_to_sec, d_lite_plus): check
conversion results, to get rid of infinite recursion.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62685 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62684 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * object.c (rb_to_integer, rb_check_to_int): convert to Integer
with method ID.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62683 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
-
- I guess this issue will be fixed to backport r55372.
But Ruby 2.2 status is "security maintenance" and its EOL date is scheduled for 2018-03-31.
https://www.ruby-lang.org/en/downloads/branches/
So ruby_2_2 branch would not backport bu... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62682 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
03/06/2018
-
- What is here:
* adding docs for (questionable, yet present) "additions" feature;
* cleaning up (both formatting and formulations) docs of `JSON.generate`: current docs are poorly formatted and its documentation shifted more towards (... -
07:31 PM Bug #14577: CPU 100% in custom backtrace method with IO.readlines
- Rebuilt ruby-trunk. Issue is fixed!
-
- Thank you nobu! I'll retry to build ruby-trunk today and give it a try!
-
- Applied in changeset trunk|r62673.
----------
thread.c: deadlock in backtrace
* thread.c (unblock_function_set): check interrupts just once
during raising exceptions, as they are deferred since r16651.
[ruby-core:85939] [Bug #14577] -
04:01 PM Bug #14179: Forwardable Segmentation fault ruby 2.2.8p477 (2017-09-14 revision 59906)
- Bump. Issue still seems to happen on ruby 2.2.9.
Following https://bugs.ruby-lang.org/projects/ruby/wiki/HowToReport, I'm supposed to assign the ticket to the maintainer ( https://github.com/ruby/ruby/blob/trunk/doc/maintainers.rdoc ... -
- Given a hash
~~~ ruby
hash = { a: 2 }
~~~
I want to update a single value in the hash:
~~~ ruby
hash[:a] = hash[:a] + 42
hash[:a] #=> 44
~~~
But instead, I would like to have a method that yields the current value for a ... - 03:14 PM Revision 125acf40 (git): * 2018-03-07
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62681 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * vm_insnhelper.c (vm_call_opt_block_call): get block handler from
the method local frame. fix segfault at calling the proxy in
rescue. http://twitter.com/wannabe53/status/970955247626567680
git-svn-id: svn+ssh://ci.ruby-lang.org/... -
- How about to allow value omission in Hash literals:
```ruby
x = 1
y = 2
h = {x:, y:}
p h #=> {:x=>1, :y=>2}
```
And in keyword arguments:
```ruby
def login(username: ENV["USER"], password:)
p(username:, password:)
end
... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62679 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- The other methods are defined in securerandom.rb.
-
12:48 PM Bug #14576: rdoc of Random::Formatter
- https://github.com/ruby/rdoc/issues/605
-
- on !body->catch_except_p. We need to move pc only when JIT execution is
canceled if the frame does not catch an exception.
_mjit_compile_insn.erb: lazily move pc for such optimized case
_mjit_compile_insn_body.erb: ditto
_mjit_compile_s... -
- akr (Akira Tanaka) wrote:
> If I understand this proposal correctly,
> ...
Yes.
> Apart from that, we should list all affected methods explicitly (without "etc.").
The following methods will be affected:
* read
* binread
* w... -
- * Optcarrot benchmark (--jit)
Before: 62.42 fps
After: 65.31 fps
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62677 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Now RubyCI is stable for this part. We no longer use this.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62676 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * parse.y (tSPACE): define a separate token for escaped space, to
fix `redefining user token number of ' '` error at word list
separator on bison 2.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62675 b2dd03c8-39d4-4d8f-98ff-823... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62674 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * thread.c (unblock_function_set): check interrupts just once
during raising exceptions, as they are deferred since r16651.
[ruby-core:85939] [Bug #14577]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62673 b2dd03c8-39d4-4d8f-98... -
- * lib/resolv.rb (Resolv::DNS.rangerand): rand and random_number
accept a Range.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62672 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Applied in changeset trunk|r62671.
----------
resolv.rb: close socket
* lib/resolv.rb (UnconnectedUDP#lazy_initialize): store new
sockets before binding, so the sockets get closed when the
requester is closing.
* lib/resolv.rb (Co... -
- Just to clarify, do those file descriptors get closed by GC?
-
- * lib/resolv.rb (UnconnectedUDP#lazy_initialize): store new
sockets before binding, so the sockets get closed when the
requester is closing.
* lib/resolv.rb (ConnectedUDP#lazy_initialize): ditto.
* lib/resolv.rb (UnconnectedUDP#clo... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62670 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
03/05/2018
-
11:03 PM Bug #14578: Forking a child process inside of a mutex crashes the ruby interpreter
- Eric Wong wrote:
> ben.govero@gmail.com wrote:
> > https://bugs.ruby-lang.org/issues/14578
>
> My fault. r58604 ("reduce rb_mutex_t size from 160 to 80 bytes on 64-bit")
> Hope I can fix it soon before I'm offline.
r62668 work... -
10:58 PM Bug #14578 (Closed): Forking a child process inside of a mutex crashes the ruby interpreter - Applied in changeset trunk|r62668.
----------
thread.c: reset waitq of keeping mutexes in child
We must not maintain references to threads in the parent process
in any mutexes held by the child process.
* thread_sync.c (rb_mutex_clean... -
- ben.govero@gmail.com wrote:
> https://bugs.ruby-lang.org/issues/14578
My fault. r58604 ("reduce rb_mutex_t size from 160 to 80 bytes on 64-bit")
Hope I can fix it soon before I'm offline. -
07:45 PM Bug #14578 (Closed): Forking a child process inside of a mutex crashes the ruby interpreter
- OS: Mac OS X 10.13.3 (High Sierra)
Affects ruby versions 2.5.0 and 2.6.0preview1
Issue **not** present in 2.4.1
Consider the following script. I contrived it as an experiment for a more complicated project. We have a resource that... - 10:58 PM Revision b544db97 (git): * 2018-03-06
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62669 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 10:58 PM Revision 1b455428 (git): thread.c: reset waitq of keeping mutexes in child
- We must not maintain references to threads in the parent process
in any mutexes held by the child process.
* thread_sync.c (rb_mutex_cleanup_keeping_mutexes): new function
* thread.c (rb_thread_atfork): cleanup keeping mutexes
[ruby-c... -
- Forgot to mention, this is repro on darwin (10.12.6) and linux (CentOS 6.9).
-
- Hello,
First bug reported in ruby redmine; I'll do my best to make it easy to diagnose. Please, let me know more information is needed.
- It's possible, with a very small script, to have ruby CPU usage goes to 100% and locking the ... -
- ko1 (Koichi Sasada) wrote:
> I realize my misunderstanding on aaron's proposal and now I'm very positive on it.
> ...
Cool. Do you mind if I apply the patch? (Just checking 😀) -
- ruby_2_4 r62667 merged revision(s) 60000,60001,60002.
-
- dup String#partition return value
* string.c (rb_str_partition): return duplicated receiver, when no
splits. [ruby-core:82911] [Bug#13925]
Author: Seiei Miyagi <hanachin@gmail.com>
dup String#rpar... -
- ruby_2_4 r62666 merged revision(s) 59970.
-
- ruby.c: paragraph mode by -00
* ruby.c (proc_options): set to paragraph mode, if -00 is given,
as well as perl and -R0 option in 0.49.
[ruby-core:81987] [Bug #13736]
git-svn-id: svn+ssh://ci.ruby-lang.org/ru... -
- ruby_2_4 r62665 merged revision(s) 59975.
-
- process: block/unblock signals around fork
As with forking for execve(2) in `spawn', we must block signals
to ensure they are handled correctly in a freshly `fork'-ed child.
* process.c (retry_fork_ruby): block/... -
- thread_safe build just fine with the patch applied. Closing this so the patch can be backported soon.
-
- Thx for fixing the latter.
Unfortunately, this does not address the original issue. So is there any hope this will be improved upstream? I would like to avoid some rbconfig.rb hacks to remove the configuration flags in question. -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62664 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- https://docs.ruby-lang.org/en/trunk/Random/Formatter.html has following methods:
```
#alphanumeric
#base64
#choose
#gen_random
#hex
#rand
#random_bytes
#random_number
#urlsafe_base64
#uuid
```
But `Random::Formatter.inst... -
- I'd guess nobody took the time to look at them yet.
I think it's OK to post a new message on those issue asking for to review the changes and commit them.
I wanted to merge this one as I remember being confused by the YAML docs as we... -
- > I don't recall having seen that out in the wild.
I did that once (around the time I've written the first ticket ¯\\\_(ツ)_/¯). Values were not explicitly in code, they've loaded from config, and the final solution looked like...
`... -
- Does anyone really write code such as:
IPAddress("172.16.10.1")..IPAddress("172.16.11.255"):
?
I don't recall having seen that out in the wild.
To me that is also less readable than method checks such
as .valid_ip? or si... -
- * parse.y: named escaped whitespaces to show unexpected character.
bare whitespaces should not appear outside of word_list.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62663 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- `mailto:` scheme on text looking like email-address is unnecessary
in Markdown. [Fix GH-1827]
Co-Authored-By: YoeriH <yoeri90@gmail.com>
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62662 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- The previous logic would overwrite the error message, replacing the message with the `fd` number.
This tiny update will print the message in full.
(I'm trying to debug an issue with the timer thread on my machine and the lack of error ... -
- `Gem::Text` is a Module. It's expected behavior.
-
- From the code `__FILE__ == $0`, we can tell that what matters is that this condition is within the main file that is executed. If we are to write something like `if __main__` or `if main?`, I have a concern that it will become less clear...
-
- Fix `test-spec` failures when the build directory is a symbolic
link.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62660 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * win32/Makefile.sub (reconfig): phony target to force reconfigure
with previous options.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62659 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
01:17 AM Revision 8d9c6e32 (git): add prefix to the function name.
- * vm.c (handle_exception): rename to vm_exce_handle_exception.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62658 b2dd03c8-39d4-4d8f-98ff-823fe69b080e