Activity
From 02/10/2018 to 02/16/2018
02/16/2018
-
05:19 PM Bug #14484 (Rejected): Error - using - ruby 2.2.1
- Try to run some rails server / console command. It's my first when I do sth with ruby (need to changes some front-end stuff only).
~~~
/Users/DL/.rvm/gems/ruby-2.2.1/gems/liquid-2.4.1/lib/liquid/htmltags.rb:43: warning: duplicated ke... -
04:41 PM Bug #13782: Backport r57733: kwrest arg name in --dump=parsetree
- ruby_2_4 r62444 merged revision(s) 57733,57734.
-
04:40 PM Revision 4828fe38 (git): merge revision(s) 57733,57734: [Backport #13782]
- kwrest arg name
* compile.c (iseq_set_arguments_keywords): make keyword rest
argument name nd_vid consistently, regardless of whether other
keyword arguments are present. [Fix GH-1529]
* parse.y (ne... - 04:35 PM Revision 20ad678d (git): merge revision(s) 62422,62436: [Backport #14481]
- Merge RubyGems 2.7.6 from upstream.
It fixed some security vulnerabilities.
http://blog.rubygems.org/2018/02/15/2.7.6-released.html
fix regexp literal warning.
* test/rubygems/test_gem_server.rb: elimi... - 04:34 PM Revision e4317b5e (git): merge revision(s) 62422,62436: [Backport #14481]
- Merge RubyGems 2.7.6 from upstream.
It fixed some security vulnerabilities.
http://blog.rubygems.org/2018/02/15/2.7.6-released.html
fix regexp literal warning.
* test/rubygems/test_gem_server.rb: elimi... - 04:27 PM Revision 664b94fd (git): merge revision(s) 58471,58493,62436: [Backport #13505]
- load.c: backtrace of circular require
* load.c (load_lock): print backtrace of circular require via
`Warning.warn` [ruby-core:80850] [Bug #13505]
Send the backtrace of the circular require warning as a singl... -
04:27 PM Bug #14424: Backport r59984 to ruby_2_4 and ruby_2_3
- ruby_2_4 r62440 merged revision(s) 59983,59984.
-
04:26 PM Bug #14372: Memory leak in require with Pathnames in the $LOAD_PATH in 2.3/2.4
- ruby_2_4 r62440 merged revision(s) 59983,59984.
-
04:25 PM Bug #10222: require_relative and require should be compatible with each other when symlinks are used
- ruby_2_4 r62440 merged revision(s) 59983,59984.
-
04:25 PM Revision eaba9da1 (git): merge revision(s) 59983,59984: [Backport #10222] [Backport #14372] [Backport #14424]
- file.c: rb_check_realpath
* file.c (rb_check_realpath): returns real path which has no
symbolic links. similar to rb_realpath except for returning
Qnil if any parts did not exist.
load.c: real path ... - 04:21 PM Revision 08fb5c21 (git): merge revision(s) 58471,58493,62436: [Backport #13505]
- load.c: backtrace of circular require
* load.c (load_lock): print backtrace of circular require via
`Warning.warn` [ruby-core:80850] [Bug #13505]
Send the backtrace of the circular require warning as a singl... -
04:10 PM Revision 99c76a47 (git): merge revision(s) 62436: [Backport #14481]
- fix regexp literal warning.
test/rubygems/test_gem_server.rb: eliminate duplicated character class warning.
[Bug #14481]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_4@62438 b2dd03c8-39d4-4d8f-98ff-823fe6... - 04:04 PM Revision 21249d84 (git): * 2018-02-17
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62437 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
04:04 PM Revision d8d19683 (git): fix regexp literal warning.
- test/rubygems/test_gem_server.rb: eliminate duplicated character class warning.
[Bug #14481]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62436 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
04:00 PM Bug #14481: Backport request for RubyGems 2.7.6
- I've found that ruby -wc test/rubygems/test_gem_server.rb report some warnings.
Due to this warnings, `TEST_RIPPER_RATIO=1 make test-all TESTS=ripper/test_files.rb` failed.
The default value of TEST_RIPPER_RATIO is 0.05, so the test fa... -
02:58 PM Bug #14481 (Closed): Backport request for RubyGems 2.7.6
- Applied in changeset ruby_2_4|r62434.
----------
merge revision(s) 62422: [Backport #14481]
Merge RubyGems 2.7.6 from upstream.
It fixed some security vulnerabilities.
http://blog.rubygems.org/2018/02/15/2.7.6-released.html -
11:04 AM Bug #14481: Backport request for RubyGems 2.7.6
- >So, Ruby 2.2 contained RubyGems 2.4. It's affected by its vulnerability.
oops, "It's NOT affected" is correct status. -
11:01 AM Bug #14481 (Closed): Backport request for RubyGems 2.7.6
- RubyGems 2.7.6 has been released. It contained the several vulnerability fixes.
http://blog.rubygems.org/2018/02/15/2.7.6-released.html
I created patches for all of the active branches of Ruby.
### rubygems-276-for-ruby25.patch
... -
03:27 PM Bug #13505: circular require prints the backtrace directly to stderr
- ruby_2_4 r62435 merged revision(s) 58471,58493.
-
03:26 PM Bug #13505: circular require prints the backtrace directly to stderr
- I believe this is a bug of Warning.warn feature in 2.4.
I will move this ticket to Bug to backport the changesets. -
03:27 PM Revision ac84c2ae (git): merge revision(s) 58471,58493: [Backport #13505]
- load.c: backtrace of circular require
* load.c (load_lock): print backtrace of circular require via
`Warning.warn` [ruby-core:80850] [Bug #13505]
Send the backtrace of the circular require warning as a single ... -
02:58 PM Revision 4237809a (git): merge revision(s) 62422: [Backport #14481]
- Merge RubyGems 2.7.6 from upstream.
It fixed some security vulnerabilities.
http://blog.rubygems.org/2018/02/15/2.7.6-released.html
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_4@62434 b2dd03c8-39d4-... -
02:45 PM Revision e3e8af93 (git): mjit.c: fix deadlock on class serial increment
- This is reported by @hasimo. Fixing a case like this:
#0 __lll_lock_wait () at ../sysdeps/unix/sysv/linux/x86_64/lowlevellock.S:135
#1 0x00007fc7bd824dbd in __GI___pthread_mutex_lock (mutex=mutex@entry=0x55946d294440 <mjit_engine_mu... -
02:35 PM Revision 2b1ba325 (git): ruby_check_va_copy.m4: for cross compiling
- * tool/m4/ruby_check_va_copy.m4 (RUBY_CHECK_VA_COPY): use
AC_TRY_LINK instead of AC_TRY_RUN for cross compiling.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62432 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
01:36 PM Bug #14466: Errno::ECONNRESET or Errno::EPIPE raised instead of HTTPResponse returned when POSTing with large body
- sk (SK Liew) wrote:
> Expected: HTTPResponse with status code of 404.
> ...
are you sure it's not the server that's aborting the connection before returning a 404? use eg. wireshark to confirm. -
12:11 PM Bug #14483: Enchance Method docs
- \o/
-
11:55 AM Bug #14483 (Closed): Enchance Method docs
- Main changes:
* fix conflict with `Proc` methods documentation (currently [one can see](http://ruby-doc.org/core-2.5.0/Method.html#method-i-call) in fact `Proc#call` docs in place of `Method#call`);
* add code examples to various `Me... -
11:50 AM Bug #14482 (Closed): headerが重複したCSVをheaders:trueでparseした場合、row.to_h[key] と row[key] の結果が一致しない
- 1行目に重複したkeyがあるcsvファイルをheaders: trueでparseした場合、
row[key]とrow.to_h[key]が異なる値を返します。
~~~ruby
require 'csv'
invalid_header_csv = "id,name,name\n1,ichiro,ICHIRO\n2,jack,JACK"
rows = CSV.parse invalid_header_csv, headers: true
puts rows... -
08:54 AM Bug #14480 (Closed): miniruby crashing when compiled with -O2 or -O1 on aarch64
- Recently, it is not possible to build Ruby 2.5.0 on aarch64 on Fedora Rawhide, because miniruby fails during build:
~~~
... snip ...
./miniruby -I./lib -I. -I.ext/common -n \
-e 'BEGIN{version=ARGV.shift;mis=ARGV.dup}' \
-e 'EN... -
08:51 AM Revision 62916542 (git): add NEWS entry for VM generator renewal [ci skip]
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62431 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
08:49 AM Revision 28d0fee9 (git): add casts (cosmetic; just be explicit)
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62430 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
08:39 AM Revision c8094ff1 (git): no ID cache in Init functions
- Init functions are called only once, cache is useless.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62429 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
08:34 AM Bug #14314: Marshalling broken in Ruby 2.5.0 for Structs with keyword_init: true
- ruby_2_5 r62428 merged revision(s) 61616.
-
08:34 AM Revision 15f641a5 (git): merge revision(s) 61616: [Backport #14314]
- marshal.c: allow marshalling keyword_init struct
struct.c: define rb_struct_s_keyword_init to shared with marshal.c
internal.h: add the declaration to be used by marshal.c
test/ruby/test_marshal.rb: add test fo... -
08:31 AM Bug #14346: [PATCH] dir.c: pass flags to openat(2) correctly
- ruby_2_5 r62427 merged revision(s) 61754.
-
08:31 AM Revision 55c5054c (git): merge revision(s) 61754: [Backport #14346]
- dir.c: pass flags to openat(2) correctly
Flags are 3rd argument of openat(2) while the 4th argument
(mode_t) is unnecessary for our uses. This bug exists since
Ruby 2.5 from r58860 and was discoverd by strace.
... -
08:28 AM Bug #14273: Stack Consistency Error from return in loop
- ruby_2_5 r62426 merged revision(s) 61617,61618.
-
08:28 AM Revision 38aa1376 (git): merge revision(s) 61617,61618: [Backport #14273]
- compile.c: remove more unreachable chunk
* compile.c (remove_unreachable_chunk): remove beyond labels to be
removed.
compile.c: fix stack consistency error
* compile.c (iseq_peephole_optimize): fix st... -
08:28 AM Bug #14323: net/ftp: fix FrozenError in BufferedSocket
- ruby_2_5 r62425 merged revision(s) 61639.
-
08:17 AM Revision d3eeb14d (git): merge revision(s) 61639: [Backport #14323]
- net/ftp: fix FrozenError in BufferedSocket
I noticed this bug while working on something else with
RUBYOPT=-d on, existing test cases all passed with it.
Note: I use String.new because it is the local style, her... -
08:08 AM Revision 24dfe5e7 (git): Fixed tempfile leak.
- From: SHIBATA Hiroshi <hsbt@ruby-lang.org>
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62424 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 08:08 AM Revision 3a4de69e (git): * remove trailing spaces.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62423 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
08:08 AM Revision 7619cb3d (git): Merge RubyGems 2.7.6 from upstream.
- It fixed some security vulnerabilities.
http://blog.rubygems.org/2018/02/15/2.7.6-released.html
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62422 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
07:36 AM Bug #14257: the chomp option removes newlines in additon to the provided separator for String#each_line and String#lines
- ruby_2_5 r62421 merged revision(s) 61636.
-
07:36 AM Revision 54cab006 (git): merge revision(s) 61636: [Backport #14257]
- string.c: out-of-bounds access
* string.c (rb_str_enumerate_lines): fix out-of-bounds access when
record separator is longer than the last element. [Bug #14257]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ru... -
07:32 AM Bug #14279: Modifying splat argument causes segmentation fault
- ruby_2_5 r62420 merged revision(s) 61603.
-
07:32 AM Revision 53859b79 (git): merge revision(s) 61603: [Backport #14279]
- check array for zsuper. [Bug #14279]
* compile.c (iseq_compile_each0): for zsuper (NODE_ZSUPER), we need to check
given argument is Array or not.
* test/ruby/test_super.rb: add a test for this bug.
git-svn-i... -
02:10 AM Revision 7a453b15 (git): non-constant aggregate initializer is a C99ism
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62419 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
01:17 AM Bug #14438: TestTimeTZ: failures with recent version of tzdata
- Just a note: this is caused by a tzdata bugfix reported at <http://mm.icann.org/pipermail/tz/2018-January/025896.html>.
-
12:20 AM Bug #14438: TestTimeTZ: failures with recent version of tzdata
- So this is a test which checks if ruby can understand real-world timezone glitches. And the reality changed. I think we should consider this test being invalid now.
-
01:15 AM Revision 86de3e41 (git): compile.c: keep debug info
- * compile.c (iseq_peephole_optimize): keep freezestring insn
with debug info. [Bug #14475]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62418 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
12:54 AM Revision b67f65db (git): test_rubyoptions.rb: assert_same to check identity
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62417 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 12:49 AM Revision afc7be75 (git): * 2018-02-16
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62416 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
12:49 AM Revision daeefae9 (git): test_rubyoptions.rb: show code in failure messages
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62415 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
02/15/2018
-
08:12 PM Feature #8158: lightweight structure for loaded features index
- > https://bugs.ruby-lang.org/issues/8158
I am curious, what is the significance of the 0xfea7009e
initializer passed to st_hash?
Would it be appropriate to use for the `st_hash' call in
hash.c::hash_i as well?
Thanks. -
04:48 PM Feature #14478: String #uminus should de-dupe unconditionally
- I don't have any pro or con opinion here but I wanted to comment on
one statement:
> maybe only another like 5 people know about the uminus change in 2.5 :)
Actually I noticed it first when nobu was using it, several months ago. :... -
12:10 PM Feature #14478: String #uminus should de-dupe unconditionally
- Since it's var = -str, it's very clear the return value should be used (and deduped) and we can't expect `str` to changed.
So if the only concern is returning str if str is frozen in -str, I agree that seems a very low compatibility risk. -
09:43 AM Feature #14478: String #uminus should de-dupe unconditionally
- > how about we do heap sharing
I am very against this, I just don't see the compatibility risk I think myself and maybe only another like 5 people know about the uminus change in 2.5 :) I am willing to bet a very large sum of money n... -
06:51 AM Feature #14478: String #uminus should de-dupe unconditionally
- To reduce compatibility risk, how about we do heap sharing with
fstring for already-frozen strings when calling uminus?
It would deduplicate large strings which require separate
allocations; but won't reduce object count or help wi... -
05:14 AM Feature #14478: String #uminus should de-dupe unconditionally
- Summary of this issue:
# Background
We changed to return dedup-ed string with `String-@`.
https://bugs.ruby-lang.org/issues/13077#note-7
> For the time being, let us make -@ to call rb_fstring.
# Issue
However, it retu... -
02:21 AM Feature #14478: String #uminus should de-dupe unconditionally
- The contract says "possibly pre-existing copy of it." ... where possibly means "if the string is not frozen"
So the contract now is "return a de-duplicated string if the string is not frozen" which is a bit of a crazy contract if you... -
02:13 AM Feature #14478: String #uminus should de-dupe unconditionally
- sam.saffron (Sam Saffron) wrote:
> > -@ should be one such exposure
> ...
That's an implementation detail. `-@`'s contract is about freezing, and says nothing about deduplication. What you're proposing is to change the contract, and ... -
02:04 AM Feature #14478: String #uminus should de-dupe unconditionally
- > -@ should be one such exposure
Oh this is already the case, see the source:
```
/*
* call-seq:
* -str -> str (frozen)
*
* If the string is frozen, then return the string itself.
*
* If the string is not frozen, r... -
01:28 AM Feature #14478: String #uminus should de-dupe unconditionally
- sam.saffron (Sam Saffron) wrote:
>
> ...
That makes sense, thanks. It seems there are two parts to the issue:
1. we should expose deduplication in the language
2. `-@` should be one such exposure
I agree with 1. I also agree... -
03:29 PM Feature #14476: Adding same_all? for checking whether all items in an Array are same
- nobu (Nobuyoshi Nakada) wrote:
> `Array#uniq?` sounds like that all elements are unique, `ary.uniq.size == ary.size`.
I agree it makes more sense for that situation.
-
09:52 AM Feature #14476: Adding same_all? for checking whether all items in an Array are same
- `Array#uniq?` sounds like that all elements are unique, `ary.uniq.size == ary.size`.
-
04:53 AM Feature #14476: Adding same_all? for checking whether all items in an Array are same
- Four points.
First, re. uniq?:
mrkn (Kenta Murata) wrote:
> We don't have Array#uniq?.
> ...
I remember having suggested a method named `uniq?`. Unfortunately, I didn't find the issue (yet). But the meaning was different. The m... -
12:45 AM Feature #14476: Adding same_all? for checking whether all items in an Array are same
- mrkn (Kenta Murata) wrote:
> We don't have Array#uniq?.
> ...
That is what I meant with:
"Instead of `Array#same_all?` why not `Array#uniq?`"
`Array#uniq?` makes sense to me and maps well with the logic of `ary.uniq.size < 2` ... -
12:38 AM Feature #14476: Adding same_all? for checking whether all items in an Array are same
- > I suppose that Array#uniq? could work as Array#all? returning once false?
We don't have Array#uniq?.
Do you suggest adding such a new method? -
01:13 PM Feature #13618: [PATCH] auto fiber schedule for rb_wait_for_single_fd and rb_waitpid
- The PG gem which uses libpq provides both synchronous and asynchronous APIs, and it is up to the client code to select one or the other. You can already use poll/select with the PG gem, that is not the issue here. Making it transparently...
-
04:11 AM Feature #13618: [PATCH] auto fiber schedule for rb_wait_for_single_fd and rb_waitpid
- samuel@oriontransfer.org wrote:
> How does Process.wait behave in `Thread::Green`?
Process.wait* methods use rb_waitpid internally, so it's
always been a scheduling point which lets other
auto-fibers/green-threads/whatever-we-call... -
03:22 AM Feature #13618: [PATCH] auto fiber schedule for rb_wait_for_single_fd and rb_waitpid
- How does Process.wait behave in `Thread::Green`?
- 11:16 AM Revision d6db2d95 (git): Avoid using `@` in macro substitution that confuses FreeBSD make
- ```
making mjit_config.h
make: Unknown modifier ' '
make: Unclosed variable specification (expecting ')') for "Q" (value "") modifier
/bin/sh: Syntax error: end of file unexpected (expecting "}")
*** Error code 2
Stop.
```
The at sign ... -
10:18 AM Misc #14470: Use Commit together with co-authors Github feature in svn commits
- brianmario (Brian Lopez) wrote:
> fwiw GitHub's implementation of trailer parsing is based on the rules defined by git-interpret-trailers. Which for parsing, are as follows:
Thank you for the info.
`git-interpret-trailers` seems to ... -
10:00 AM Revision 41e9e19b (git): Array#values_at optimization
- * array.c (rb_ary_values_at): optimization range argument case.
bulk concatenation than pushing for each element.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62413 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
06:14 AM Revision 9a9a4e87 (git): Benchmarks for Array#values_at
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62412 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
05:34 AM Revision 0efd8bbd (git): test/io/console/test_io_console.rb (test_oflush): Avoid race condition
- Add a ad-hoc wait. Follows test_ioflush2.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62411 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
05:29 AM Bug #14477 (Closed): tzdata 2018c seems break test suite
-
04:04 AM Feature #14362: use BigDecimal instead of Float by default
- yugui,
> Why do you think they are not familiar with floating-point values like IEEE754?
In my experience, most developers are not intimately familiar with the details of floating point implementations. I have witnessed a number of... -
03:09 AM Bug #14479 (Rejected): Exceptions raised from a :call tracepoint can sometimes be "rescued" inside the method
- This is a Ruby 2.5 regression.
If you raise an exception from a :call tracepoint, it can, in certain circumstances, be caught by a rescue block inside the called method. Here is an illustration:
```
def foo
begin
puts "hi"... -
01:59 AM Revision b4b4b943 (git): gc.c: force STACK_GROW_DIRECTION for emscripten
- The configure script fails to guess the direction on emscripten.
Perhaps this is because of https://github.com/kripken/emscripten/issues/2093
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62410 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
01:59 AM Revision 50700c4d (git): thread_pthread.c: Use `getpagesize()` when `pthread_attr_getguardsize` is unavailable
- This is also for emscripten.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62409 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
01:59 AM Revision 8df47f8c (git): configure.ac: Use `pthread_create` to determine if pthread is available
- Instead of `pthread_kill`. This is because emscripten supports
`pthread_create` but not `pthread_kill`.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62408 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
02/14/2018
-
11:42 PM Bug #14475: String de-duplication is broken in files with frozen_string_literal: true
- I created a new topic for this at: https://bugs.ruby-lang.org/issues/14478
> At this point, it may break existing code :<
I think it is worth the risk cause adding #fstring here seem overkill and almost nobody would be using uminu... -
10:52 PM Bug #14475: String de-duplication is broken in files with frozen_string_literal: true
- sam.saffron@gmail.com wrote:
> "If the string is frozen, then return the string itself."
>
> Yeah I do not agree with this documentation, I think it should be changed.
>
> Trouble is that there is no simple way to de-duplicate
... -
10:45 PM Bug #14475: String de-duplication is broken in files with frozen_string_literal: true
- Opened https://bugs.ruby-lang.org/issues/14478 to discuss change to uminus
-
10:35 PM Bug #14475 (Closed): String de-duplication is broken in files with frozen_string_literal: true - Applied in changeset trunk|r62407.
----------
compile.c: drop freezestring insn on String#-@
Followup to r62039 and remove the redundant freezestring
insn which was preventing deduplication from String#-@
* compile.c (iseq_peephole_op... -
10:27 PM Bug #14475: String de-duplication is broken in files with frozen_string_literal: true
- "If the string is frozen, then return the string itself."
Yeah I do not agree with this documentation, I think it should be changed.
Trouble is that there is no simple way to de-duplicate unconditionally without inefficiency:
S... -
10:12 PM Bug #14475: String de-duplication is broken in files with frozen_string_literal: true
- sam.saffron@gmail.com wrote:
> Workaround ... whenever de-duping strings always use `-+`
Yes, String#-@ documentation states:
"If the string is frozen, then return the string itself."
So I guess it is spec...
However, it se... -
08:43 PM Bug #14475: String de-duplication is broken in files with frozen_string_literal: true
- Workaround ... whenever de-duping strings always use `-+`
```
x = "#{1}".freeze
# this is always properly de-duped
x = -+x
```
Any objections to changing:
```
static VALUE
str_uminus(VALUE str)
{
if (OBJ_FROZEN(str)... -
08:40 PM Bug #14475: String de-duplication is broken in files with frozen_string_literal: true
- Simpler repro:
```
x = "#{1}".freeze
p x.object_id
x = -x
p x.object_id
x = "#{1}".freeze
p x.object_id
x = -x
p x.object_id
```
```
70210401536460
70210401536460
70210401536240
70210401536240
``` -
07:37 AM Bug #14475 (Closed): String de-duplication is broken in files with frozen_string_literal: true
- Create 2 files:
test.rb
```
$LOAD_PATH.unshift(File.dirname(__FILE__))
require 'frozen'
puts frozen.object_id
puts frozen.object_id
```
frozen.rb
```
# frozen_string_literal: true
A = "a"
def frozen
-"#{A}"
en... -
11:38 PM Feature #14478: String #uminus should de-dupe unconditionally
- > Why not make it impossible to create a frozen string that isn't deduped?
This can not be done without enormous breakage, it would break the semantics of freeze, was already discussed with Matz and decided against.
```
puts x.ob... -
11:25 PM Feature #14478: String #uminus should de-dupe unconditionally
- Why not make it impossible to create a frozen string that isn't deduped? That way the current `-x` works fine by default.
(I thought that was already the case..?) -
10:45 PM Feature #14478 (Closed): String #uminus should de-dupe unconditionally
- continuing: https://bugs.ruby-lang.org/issues/14475
Current documentation for String uminus says: "If the string is frozen, then return the string itself."
Trouble is that there is no simple way to de-duplicate unconditionally with... - 10:35 PM Revision 7606806c (git): compile.c: drop freezestring insn on String#-@
- Followup to r62039 and remove the redundant freezestring
insn which was preventing deduplication from String#-@
* compile.c (iseq_peephole_optimize): drop freezestring insn on String#-@
[ruby-core:85542] [Bug #14475]
git-svn-id: svn+... - 10:35 PM Revision dc9ce328 (git): test/ruby/test_optimization.rb: fix compile kwarg
- Fixes: r62177 ("compile.c: fix string Range optimization with FSL")
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62406 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
10:22 PM Bug #14477 (Closed): tzdata 2018c seems break test suite
- Upgraded tzdata to 2018c on both my Debian stretch (stable) and jessie
(oldstable) machines via "apt-get dist-upgrade" and noticed test failures:
```
[ 4/325] TestTimeTZ#test_asia_tokyo = 0.00 s
1) Failure:
TestTimeTZ#test_asia... -
06:39 PM Feature #14460 (Closed): Speed up `require` and reduce memory usage
- Fixed in r62404. See Feature #8158
-
10:56 AM Feature #14460: Speed up `require` and reduce memory usage
- Aaron, while I'm going to accept commit right, I'm asking you to apply my patch.
With regards,
Yura. -
06:39 PM Feature #8158 (Closed): lightweight structure for loaded features index
- Committed in r62404. Thanks Yura!!
-
10:53 AM Feature #8158: lightweight structure for loaded features index
- Year after I think I am more stable person, so I'm going to accept commit rights with gratitude, honor and great responsibility.
But until I passed procedure, I'd be thankful if @tenderlovemaking will commit this one.
With regards,... - 06:38 PM Revision a08d41ea (git): * 2018-02-15
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62405 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
06:38 PM Revision bf04b4e1 (git): load.c: reduce memory usage of loaded_features_index
- Use integer hashsum instead of string as a key in loaded_features_index.
Do not use ruby strings for substring operation, just plain pointer
and length.
[ruby-core:53688]
Co-authored-by: Sokolov Yura aka funny_falcon <funny.falcon@gmai... -
05:47 PM Misc #14470: Use Commit together with co-authors Github feature in svn commits
- brianmario (Brian Lopez) wrote:
> > Better to make trailer interpretation tolerate empty lines;
> ...
I guess as a user I would expect git-svn to be additive; if there are no trailers in my commit message, then add them (for the id), o... -
05:43 PM Misc #14470: Use Commit together with co-authors Github feature in svn commits
- normalperson (Eric Wong) wrote:
> tenderlove@ruby-lang.org wrote:
> ...
fwiw GitHub's implementation of trailer parsing is based on the rules defined by git-interpret-trailers. Which for parsing, are as follows:
> Existing trailers ... -
05:30 PM Misc #14470: Use Commit together with co-authors Github feature in svn commits
- normalperson (Eric Wong) wrote:
> tenderlove@ruby-lang.org wrote:
> ...
Thanks for the background! Maybe we can get this fixed in git then. I'll see what I can find out! -
05:45 PM Feature #14476: Adding same_all? for checking whether all items in an Array are same
- mrkn (Kenta Murata) wrote:
> uniq scans all elements, whereas all? and == don't.
> ...
That makes sense.
I suppose that `Array#uniq?` could work as `Array#all?` returning once `false`? -
05:15 PM Feature #14476: Adding same_all? for checking whether all items in an Array are same
- `uniq` scans all elements, whereas `all?` and `==` don't.
And `uniq` allocates a new array, so `uniq` is always slower than `all?-method-3` and `opt-item` in all cases of my benchmark.
Eregon, if we write it in C, we can avoid using ... -
04:45 PM Feature #14476: Adding same_all? for checking whether all items in an Array are same
- I believe we could even do:
```ruby
ary.uniq?(&:foo)
``` -
04:37 PM Feature #14476: Adding same_all? for checking whether all items in an Array are same
- Why would it be more efficient in C?
A sufficiently smart JIT (or of course it can be done manually) could turn
ary.all? {|e| e.foo == ary[0].foo }
into (assuming foo has no side effects):
e0 = ary[0].foo
ary.all... -
04:32 PM Feature #14476: Adding same_all? for checking whether all items in an Array are same
- Usually I use the following code to achieve the same purpose:
```ruby
ary.uniq.size < 2
```
I didn't test but if you need to use that complex code I expect this example to be less performant.
Instead of `Array#same_all?` why n... -
03:41 PM Feature #14476 (Assigned): Adding same_all? for checking whether all items in an Array are same
- In this issue, I propose to introduce `same_all?` instance method of `Array` class. This new method checks whether all items in the receiver are the same.
Today, I needed to write a code to judge whether all items in an `Array` are th... -
02:09 PM Revision 8c8d298c (git): appveyor.yml: refactor r62402
- We have good feature to share common configuration between branches:
https://www.appveyor.com/docs/branches/#sharing-common-configuration-between-branches
Let's try this.
By the way, the intention of r62402 was excluding PR notification... -
12:34 PM Revision 7da8fa1c (git): appveyor.yml: notify slack only for trunk
- Using conditional build configuration.
https://www.appveyor.com/docs/branches/#conditional-build-configuration
This copy-pasting is so ugly, but AppVeyor doesn't have a feature to
filter notification based on branch.
https://github.com/... -
06:54 AM Feature #14463: Allow comments to precede dots in member expressions
- There is extensive discussion on this at #7636. Please check.
-
05:11 AM Revision 8fd16730 (git): mjit.h: compare as pointer
- * mjit.c (mjit_get_iseq_func), mjit.h (mjit_exec): do not compare
a pointer as shorter type. by loosing the precision, different
values can result in "equal" wrongly. enum type is an alias of
`int`, and is often shorter than a po... -
04:27 AM Bug #14474 (Open): skip "TestException#test_thread_signal_location" as known bug
-
01:51 AM Bug #14474 (Closed): skip "TestException#test_thread_signal_location" as known bug
- Applied in changeset trunk|r62400.
----------
skip "TestException#test_thread_signal_location" as a known bug [Bug #14474] -
01:37 AM Bug #14474 (Closed): skip "TestException#test_thread_signal_location" as known bug
- `TestException#test_thread_signal_location` fails randomly
https://gist.github.com/ko1/797b0f058f2d09ae57c9af1ee07a42b2#file-brlog-trunk-nopara-20180213-224440-L380
> `[BUG] pthread_mutex_lock: Invalid argument (EINVAL)`
https://g... -
04:12 AM Bug #14472: `File::open` closes the file too early when used with callcc
- I used raw continuations for the simplicity of explanation but I found it was a bit confusing (and I was also confused).
> ... code above must be the same as code below, which works fine:
It was wrong. and
> ...
is absolutely co... -
03:28 AM Bug #14472: `File::open` closes the file too early when used with callcc
- > You can do it by `File.open` without a block.
I know that. Again, I'm not in trouble.
> ...
I understand it isn't a bug, but an expected behaviour.
Then the question is why this behaviour?
> If `callcc` weren't fire ensures, ... -
01:37 AM Bug #14472 (Rejected): `File::open` closes the file too early when used with callcc
- blackenedgold (Sunrin SHIMURA) wrote:
> This code throws an IOError, but expected to exit normally:
`callcc` rollbacks `ensure`s.
> ...
You can do it by `File.open` without a block.
If `callcc` weren't fire `ensure`s, it's unpred... -
02:11 AM Bug #14334: Segmentation fault after running rspec (ruby/2.5.0/erb.rb:885 / simplecov/source_file.rb:85)
- Eric Wong wrote:
> pragtob@gmail.com wrote:
> > issue" means, but I'm relatively certain that it's a bug in
> > Ruby we managed to reproduce it without any simplecov involved
> > purely using the coverage library:
> > https://githu... -
01:50 AM Revision 381650ea (git): skip "TestException#test_thread_signal_location" as a known bug [Bug #14474]
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62400 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
01:14 AM Feature #14362: use BigDecimal instead of Float by default
- As a maintainer of BigDecimal, I don't agree with you about BigDecimal is more developer friendly than Float.
And the current BigDecimal is not better than Rational for representing rational numbers because it has problems in its precis... -
12:52 AM Feature #13581: Syntax sugar for method reference
- cben (Beni Cherniavsky-Paskin) wrote:
> A non-syntax idea: could `Math.method.sqrt` look significantly nicer than `Math.method(:sqrt)`?
> ...
Hey Beni! Thank you! This is a great idea! For my taste it looks significantly better!
Als...
02/13/2018
-
11:11 PM Misc #14470: Use Commit together with co-authors Github feature in svn commits
- tenderlove@ruby-lang.org wrote:
> nobu (Nobuyoshi Nakada) wrote:
> > The feature page says "Include your trailers at the end of
> > your commit message", does it work even if "git-svn-id:"
> > line is appended by `git svn dcommit`?
... -
07:18 PM Misc #14470: Use Commit together with co-authors Github feature in svn commits
- nobu (Nobuyoshi Nakada) wrote:
> The feature page says "Include your trailers at the end of your commit message", does it work even if "git-svn-id:" line is appended by `git svn dcommit`?
It will work, but we have to ensure there is ... -
04:12 PM Misc #14470: Use Commit together with co-authors Github feature in svn commits
- The feature page says "Include your trailers at the end of your commit message", does it work even if "git-svn-id:" line is appended by `git svn dcommit`?
-
02:50 PM Misc #14470: Use Commit together with co-authors Github feature in svn commits
- Why doesn't Github see `From:` header too?
-
11:51 AM Misc #14470: Use Commit together with co-authors Github feature in svn commits
- I think the ruby core team and/or matz has to decide on attribution.
It can probably be done in SVN as-is, without depending on git/github.
I was a bit confused about the initial wording of the suggestion,
but then I looked at the l... -
10:27 AM Misc #14470 (Closed): Use Commit together with co-authors Github feature in svn commits
- As currently Ruby is using SVN, for "merging" a PR, the PR is closed and the changes added in a SVN commit. In this commit the author is someone from the Ruby core and not the person who wrote the code. The person who wrote the code is m...
-
10:41 PM Feature #13618: [PATCH] auto fiber schedule for rb_wait_for_single_fd and rb_waitpid
- sam.saffron@gmail.com wrote:
> > How long does it release the GVL for?
> I would see it heavily depends on workload, but usually for
> our loads it is milliseconds for v8 work, in PGs case shortest
> duration is probably 0.5ms wi... -
09:39 PM Feature #8158: lightweight structure for loaded features index
- Hi Yura,
I think the commit rights here reduce the amount of work for the rest of the Ruby team.
This change is approved and reviewed, so you can commit it directly once you have the rights, no need to make other people do the co... -
09:31 PM Bug #14357: thread_safe tests suite segfaults
- On 02/13/2018 05:13 AM, Eric Wong wrote:
> vmakarov@redhat.com wrote:
>> File thread-table-rebuild.patch added
> Thank you for working on this!
>
>> This problem results in ICE for new hash tables. For old hash
>> tables, the ... -
10:22 AM Bug #14357: thread_safe tests suite segfaults
- vmakarov@redhat.com wrote:
> File thread-table-rebuild.patch added
Thank you for working on this!
> This problem results in ICE for new hash tables. For old hash
> tables, the problem would have corrupted hash table structure... -
08:58 PM Feature #14473 (Closed): Add Range#subrange?
- Hi there,
I'd like to propose a method that returns true when a range that the method gets called on is a subrange of a range passed in as an argument.
Example:
~~~ ruby
(2..4).subrange?(1...4)
=> true
(-2..2).subrange?(-1..... -
08:22 PM Bug #14472 (Rejected): `File::open` closes the file too early when used with callcc
- First of all, I know `callcc` is deprecated feature and I'm not in trouble with this bug.
I was just curious and happened to find this bug.
# Bug Description
This code throws an IOError, but expected to exit normally:
~~~ ruby
... -
06:23 PM Feature #14460: Speed up `require` and reduce memory usage
- Hi,
I didn't see that ticket, but I made a comparison now:

They are very close. My patch ends slightly... -
10:41 AM Feature #14460: Speed up `require` and reduce memory usage
- Did you compare it with https://bugs.ruby-lang.org/issues/8158 ?
-
05:14 PM Bug #14471 (Closed): DRb mixing up function return values between PIDs after fork()
- This is likely a duplicate of https://bugs.ruby-lang.org/issues/2718, although the Backport191 project in redmine appears to be dead.
We have found the exact same problem with modern rubies such as 2.3, 2.4, 2.5.
The summary is t... - 03:58 PM Revision 01a656c3 (git): * 2018-02-14
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62399 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
03:58 PM Revision ddb65f0b (git): mjit_compile.inc.erb: replace opt_key insn
- with opt_send_without_block insn if call cache has valid ISeq.
If the receiver is not optimized target of opt_key (i.e. Hash or Array),
it triggers JIT cancel and it would be slow.
This change allows JIT to drop the check for Hash/Array... -
01:29 PM Revision 6593c3af (git): Fixing some minimal formating on enum.c examples
- This will fix the formatting shown on detect|find and revese_arch
generated by RDoc.
[Fix GH-1816]
From: Espartaco Palma <esparta@gmail.com>
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62397 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
10:24 AM Feature #14468: Add Proc#dig
- I am also not a fan of this particular case, but I think it makes sense to let `dig` call `fetch` (or `[]`) recursively, whenever the element responds to it.
-
04:32 AM Feature #14468: Add Proc#dig
- I don't oppose it, but I'm not very enthusiastic about it. `Integer` and `String` also respond_to `[]`, and I don't quite see dig for these either.
-
12:24 AM Feature #14468: Add Proc#dig
- I am not one of the devs so this is just my own opinion.
I sort of agree with the proposal; not so much because I would
need it (my style is very awkward and I do not use procs that
often; I used them for callbacks in the past in ru... - 10:02 AM Revision 4663c224 (git): st.c: retry operations if rebuilt
- Calling the .eql? and .hash methods during a Hash operation can
result in a thread switch or a signal handler to run: allowing
one execution context to rebuild the hash table while another is
still reading or writing the table. This res... -
09:36 AM Revision 248ff4f1 (git): variable.c: flags at autoloading
- * variable.c (const_tbl_update): flags by deprecate_constant /
private_constant set during autoloading should be preserved
after required. [ruby-core:85516] [Bug #14469]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62395 b2dd0... -
09:34 AM Revision 8cdac548 (git): vm_insnhelper.c: rb_autoloading_value flag
- * vm_insnhelper.c (vm_get_ev_const): add flag argument of
`rb_autoloading_value`.
* constant.h (rb_autoloading_value): moved the declaration from
vm_core.h for `rb_const_flag_t`. [ruby-core:85516] [Bug #14469]
git-svn-id: svn+ssh:... - 09:34 AM Revision 66652bb6 (git): revert r62392
- check the declaration of `rb_autoloading_value()` in vm_core.h and the call in
vm_insnhelper.c, and retry it.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62393 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
09:11 AM Bug #14469 (Closed): private_constant and deprecate_constant are ignored by autoloading
- Applied in changeset trunk|r62392.
----------
variable.c: flags at autoloading
* variable.c (const_tbl_update): flags by deprecate_constant /
private_constant set during autoloading should be preserved
after required. [ruby-core:8... -
08:49 AM Bug #14469 (Closed): private_constant and deprecate_constant are ignored by autoloading
- Consider the following code in file "zzz.rb":
```ruby
class ZZZ
P = D = 1
private_constant :P
deprecate_constant :D
end
```
After loading the file, accesses to `ZZZ::P` and `ZZZ:D` cause an exception and a warning respe... -
09:11 AM Revision a6a596a5 (git): variable.c: flags at autoloading
- * variable.c (const_tbl_update): flags by deprecate_constant /
private_constant set during autoloading should be preserved
after required. [ruby-core:85516] [Bug #14469]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62392 b2dd0... -
09:08 AM Bug #14458 (Rejected): RubyVM::InstructionSequence compilation loses Regexp encoding
-
07:42 AM Revision 9b96817b (git): process.c (try_with_sh): fix the wrong number of arguments
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62391 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
12:03 AM Revision c8a5126d (git): xmalloc never returns NULL
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62390 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
02/12/2018
-
11:54 PM Feature #13581: Syntax sugar for method reference
- A non-syntax idea: could `Math.method.sqrt` look significantly nicer than `Math.method(:sqrt)`?
That is, .method without args would return a magic object that for any message returns the bound method of that name.
~~~ruby
[1, 4, 9].... -
09:04 PM Feature #14468 (Rejected): Add Proc#dig
- Since Proc already responds to [], it would be cool if Procs could participate in a recursive dig. Like this:
Current Behavior:
~~~
obj = [
0,
{
a: ->(x) { x * 2 },
b: "c"
},
]
obj[1][:a][4] == 8 # true
obj... -
04:41 PM Bug #14467 (Rejected): a bug encounter when try to create a controller using Ruby on Rails (on Pi3)
- platform: Raspberry Pi 3
Ruby version: ruby 2.3.3p222 (2016-11-21) [arm-linux-gnueabihf]
Rails version: Rails 5.1.4
gem version: 2.5.2.1
context: I installed Ruby on Rails successfully on my Pi3. I am able to create a new Rails ap... -
04:00 PM Bug #14357: thread_safe tests suite segfaults
- vmakarov (Vladimir Makarov) wrote:
>
> ...
The following patch solves the problem of rebuilding table in one
thread during a search of the same table in another thread. The
thread switch can happen in Ruby method implementing equa... - 03:25 PM Revision e6337582 (git): * 2018-02-13
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62389 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
03:25 PM Revision 1fd81680 (git): vm_insnhelper.c: inline array aref with integer
- internal.h: define inlinable rb_ary_entry_internal.
array.c: use rb_ary_entry_internal.
* Benchmark
ruby --jit mame/optcarrot/bin/optcarrot --benchmark mame/optcarrot/examples/Lan_Master.nes
** Before
checksum: 59662
fps: 58.09517501... -
03:17 PM Bug #14458: RubyVM::InstructionSequence compilation loses Regexp encoding
- znz (Kazuhiro NISHIYAMA) wrote:
> I think `/p{Alnum}/` is US-ASCII only, so encoding is US-ASCII.
> ...
Well, colour me embarrassed. Thank you for pointing out that subtlety in my example. I'm pretty sure we can close this one as inval... -
06:36 AM Bug #14458: RubyVM::InstructionSequence compilation loses Regexp encoding
- I think `/p{Alnum}/` is US-ASCII only, so encoding is US-ASCII.
```
% irb -r irb/completion --simple-prompt
>> puts "/\p{Alnum}/.encoding"
/p{Alnum}/.encoding
=> nil
> ...
=> #<Encoding:US-ASCII>
```
You can use `"/\\p{Alnum}... -
09:19 AM Bug #14466 (Closed): Errno::ECONNRESET or Errno::EPIPE raised instead of HTTPResponse returned when POSTing with large body
- Using `net/http`, when trying to POST to an endpoint with a large body, Errno::ECONNRESET or Errno::EPIPE would be raised.
How to reproduce:
1. In a terminal, run `ruby -run -e httpd -- -p 3000 .` to run a HTTP webserver.
2. In an... -
09:05 AM Revision 1012e50a (git): insns.def: remove unnecessary sp motion
- This seems obsoleted after r62087.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62387 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
09:02 AM Revision 9bb7cb78 (git): use <<- instead of <<~ for older baseruby
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62386 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
08:09 AM Revision 1f3f1248 (git): Makefile.in: drop obsoleted debug output
- mjit_config.h errors are already fixed.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62385 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
07:27 AM Revision 268d9236 (git): _mjit_compile_insn_body.erb: refactor
- renamed from tool/ruby_vm/views/_mjit_compile_insn_line.erb.
Basically this file should handle everything about macro on JIT.
_mjit_compile_insn.erb: follow the refactoring
common.mk: follow the rename
git-svn-id: svn+ssh://ci.ruby-la... -
06:54 AM Revision f6cebb97 (git): _mjit_compile_insn_line.erb: carve out macro expansion
- in _mjit_compile_insn.erb to this file. As I'm going to add macro
expansions later, I want to separate such complex things from whole insn
compilation.
_mjit_compile_insn.erb: _mjit_compile_insn_line.erb part was removed.
common.mk: up... -
05:21 AM Bug #14464: MJIT & MinGW / gcc 7.3.0 seemed ok as of 62337, fail or skip after
- @k0kubun,
Appveyor run of 62377 had the following (added backticks for web view):
```
Retrying...
[1/2] 8 TestJIT#test_compile_insns = 11.33 s = F
[2/2] 7 TestJIT#test_jit_output = 5.58 s = .
1) Failure:
TestJIT#... -
02:24 AM Bug #14464: MJIT & MinGW / gcc 7.3.0 seemed ok as of 62337, fail or skip after
- k0kubun,
Thank you for the response. A few notes:
The test-all log for 62337 showed the two MJIT tests passing, but subsequent builds skipped (or failed with RUBY_FORCE_TEST_JIT).
In the 62375 build (after my first post), both ... -
01:33 AM Bug #14464: MJIT & MinGW / gcc 7.3.0 seemed ok as of 62337, fail or skip after
- It seems that all JIT compilations on MinGW started to fail from r62340, and I fixed it on r62376. Now the tests won't be skipped on MinGW builds. For now, I recommend to specify environment variable RUBY_FORCE_TEST_JIT=1 when running te...
-
05:04 AM Revision dd64636a (git): mjit.c: print JIT failure
- mjit_compile.inc.erb: show unsupported insn name on --jit-verbose=1 too.
Also, removed osboleted workaround. Now some insn-related functions are
declared with MAYBE_UNUSED.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62382 b2dd03c... -
04:35 AM Revision 7a0bc1f3 (git): test_jit.rb: prettify script in message
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62381 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
04:00 AM Revision 48e4f02f (git): test_jit.rb: explicitly skip for unsupported ones
- MSP-Greg watches this metrics and this would be helpful for him.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62380 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
03:39 AM Revision 9dc2d285 (git): no --jit-cc
- * ruby.c (setup_mjit_options): removed --jit-cc option, since
mjit header is affected by generated config.h which depends on
the given compiler, so it cannot work with different compilers.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby... -
03:33 AM Revision 30bcbfd3 (git): test_jit.rb: split test_compile_insns
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62378 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 01:00 AM Revision 8547caed (git): * 2018-02-12
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62377 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
01:00 AM Revision 1894e602 (git): mjit_compile.c: fix invalid suffix on MinGW
- This commit fixes following error.
$ RUBY_FORCE_TEST_JIT=1 ./ruby -I. -Ilib -Itest/lib --disable-gems test/ruby/test_jit.rb
Run options:
# Running tests:
Environment variable changed: TestJIT#test_compile_insns : "TEMP" changed : "C:...
02/11/2018
-
11:54 PM Feature #14362: use BigDecimal instead of Float by default
- > I think most developers are familiar with the inaccurate nature of division on computers. ... However, with Float you end up with errors that are less predictable
These statements sounded weird for me. Why do you think they are not ... -
09:18 PM Feature #14465 (Open): rename/alias and then obsolete UDPSocket::send
The method name "send" on UDPSocket <https://ruby-doc.org/stdlib-2.5.0/libdoc/socket/rdoc/UDPSocket.html#method-i-send> is confusing and inconsistent.
The underlying libc method is called sendto(2) (or sendmsg()). The method "send" ...-
03:44 PM Feature #14411: URI#secure?
- Perhaps `#https?` might work? (as phluid61 actually suggested with the only difference that "is" is "#...?" in Ruby)
Used in Rails: https://github.com/rails/rails/blob/2090615d39c071c9eb25e715275eb79f3f9b6266/actionpack/lib/action_dis... -
02:38 PM Revision e19457e6 (git): Makefile.in: prevent from building `"",` macro
- Loop removal in r62373 caused the CI failure like:
https://travis-ci.org/ruby/ruby/builds/340136977
mjit_config.h was:
#ifndef RUBY_MJIT_CONFIG_H
#define RUBY_MJIT_CONFIG_H 1
#define MJIT_CC_COMMON "gcc",
#define MJIT_CFLAGS "... -
02:37 PM Bug #14464 (Closed): MJIT & MinGW / gcc 7.3.0 seemed ok as of 62337, fail or skip after
- First of all, a thank you to those working on MJIT.
At least three builds of ruby-loco MinGW passed the MJIT tests (62327, 62331, 62337), but after that, the tests have either failed or skipped. First fail was at 62341.
The most r... -
02:18 PM Revision b9bedc2d (git): Makefile.in: debug mjit_config.h again
- Somehow r62373 is failing on travis...
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62374 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
02:01 PM Revision b3606bb4 (git): Makefile.in: use "%s"
- * Makefile.in (mjit_config.h): use "%s" not to interprete % in
arguments. and `set` and `loop` are not needed.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62373 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
01:46 PM Revision f9d79161 (git): Makefile.in: use printf
- `echo -n` is sometimes not available.
https://rubyci.org/logs/rubyci.s3.amazonaws.com/unstable11s/ruby-trunk/log/20180211T132503Z.log.html.gz#miniruby
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62372 b2dd03c8-39d4-4d8f-98ff-823fe... -
12:54 PM Feature #14462: MJIT enabled should be displayed in the version string
- I think this makes sense and makes it easier to distinguish for benchmarks/tests/bug reports/etc.
I think the +JIT should be part of RUBY_DESCRIPTION for consistency.
But that seems a bit tricky, could you take a look at it, @k0kubun? -
03:53 AM Feature #14462: MJIT enabled should be displayed in the version string
- I assume that it helps to distinguish causes of bugs too, so I'm in favor of it.
-
12:44 AM Feature #14462: MJIT enabled should be displayed in the version string
- I somewhat agree with the general notion of the suggestion. I am not
entirely sure whether it should also be added to the ruby version
string, but I also have no problem with it either, so I am fine either
way.
For benchmarks, it ... -
12:50 PM Revision 71385538 (git): Makefile.in: define macro in one line
- Having macro definition in multiple definitions makes compiler error
output hard to read, like the commit message of r62367.
Probably build failures will be fixed by r62370, but let me simplify the
mjit_config.h content for future debug... -
12:40 PM Revision d76179ce (git): mjit_config.h: moved backslashs outside quotes
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62370 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
12:28 PM Revision 8f7d3542 (git): mjit.c: some flags are no longer for GCC
- Obviously they are for clang. For simplicity, just inlined them.
Also another obsoleted commant was removed.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62369 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
12:21 PM Revision ebda42fa (git): _mjit_compile_send.erb: resolve warnings on clang
- /var/folders/tp/g1f_46nj7md_d5_j799rfb140000gn/T//_ruby_mjit_p17396u162.c:2920:143: warning: incompatible integer
to pointer conversion passing 'long' to parameter of type 'const VALUE *' (aka 'const unsigned long *')
[-Wint-... -
12:04 PM Revision 003b6846 (git): Makefile.in: add output to debug rubyci
- build failure.
From current output, I can't know what's wrong from current error log.
https://rubyci.org/logs/rubyci.s3.amazonaws.com/centos7/ruby-trunk/log/20180211T110003Z.log.html.gz#miniruby
compiling mjit.c
mjit.c:573:1: error: s... -
09:00 AM Revision aae7d3d6 (git): win32/Makefile.sub: fix typo, missing comma
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62366 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
08:57 AM Revision 58dfae46 (git): mjit.c: alwasy -fPIC flag to gcc
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62365 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
07:35 AM Revision f3f3e278 (git): appveyor.yml: finish notification test
- Now it succeeds to notify. Notifying all CI success would be noisy.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62364 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
07:28 AM Revision f0df9902 (git): appveyor.yml: encrypt config with ruby's account
- Currently it's encrypted with k0kubun's account and the notification is
failing.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62363 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
07:10 AM Revision fa6e2917 (git): mjit_config.h: include trailing comma for empty list
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62362 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
06:36 AM Bug #14356: Backport 61605
- In r62359 and r62361, I configured Travis to send notification to another channel too.
Both channels are for private team unfortunately. -
06:33 AM Revision b818f7c3 (git): .travis.yml: resurrect notification to #commits
- I heard at least Shibata-san sees the channel for the notification.
But I want #alets to have all CI failure notifications too.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62361 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
06:03 AM Revision 9d93d58f (git): appveyor.yml: send AppVeyor slack notification
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62360 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
05:49 AM Revision 23c71575 (git): .travis.yml: send notification to #alerts
- instead of #commits.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62359 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
05:32 AM Revision 4122066a (git): NEWS: note about --jit [ci skip]
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62358 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
05:29 AM Revision 29777e30 (git): common.mk: add comments about r62355 [ci skip]
- transform_mjit_header.rb: ditto
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62357 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
04:54 AM Revision 8f668769 (git): mjit_config.h: more macros
- * Makefie.in, win32/Makefile.sub: add more macros for compiler to
mjit_config.h.
* mjit.c: unification VC and GCC in progress.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62356 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
04:20 AM Revision 3b6bb3de (git): common.mk: define MJIT_HEADER earlier
- so that other predefined macros won't be removed by
`MJITHeader.remove_predefined_macros!`.
Currently macro like -DVM_CHECK_MODE=2 is removed when it's passed in
configure. But it is needed during JIT compilation.
gc.c: export rb_obj_i... -
02:48 AM Feature #14463 (Open): Allow comments to precede dots in member expressions
- I, coming from other languages, find it *extremely* odd that the first three are considered valid, but the fourth is a syntax error (tested in Ruby 2.3.4 + 2.5.0, Rubocop's parser for 2.3):
~~~ ruby
# 1
foo = -> {}
foo.
call
... -
02:41 AM Revision 8d590c99 (git): _mjit_compile_insn.erb: comment_id
- * tool/ruby_vm/views/_mjit_compile_insn.erb: comment ID of
constant, calling method, and Symbol literal.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62354 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
02:41 AM Revision 4854b14b (git): _mjit_compile_{insn,send}.erb: suppress warnings
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62353 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
01:01 AM Revision cb1cde46 (git): Makefile.sub: cpp out for older VC
- * win32/Makefile.sub (CPPOUTFLAG, MJIT_HEADER_FLAGS): -Fi option
is available since VC 10. redirect stdout on older versions.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62352 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
12:19 AM Revision 2b79ab51 (git): _mjit_compile_send.erb: PRI_SERIALT_PREFIX
- * tool/ruby_vm/views/_mjit_compile_send.erb: `printf` modifier for
`rb_serial_t` which may not be `long long`, and '%ll' may not be
supported.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62351 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
02/10/2018
-
11:38 PM Bug #14461: Public SecureRandom.alphanumeric method does not appear in rdoc generated documentation
- Apologies, this looks like a bug in rdoc that was resolved late 2017:
https://github.com/ruby/rdoc/pull/435
I've confirmed I can see `.alphanumeric` method in my own local rdoc (v6.0.1) output. Informed the maintainers of http://r... -
07:46 PM Bug #14461 (Rejected): Public SecureRandom.alphanumeric method does not appear in rdoc generated documentation
- The `private def` keywords for methods above the `SecureRandom.alphanumeric` definition (method via #10849) appear to have caused rdoc generation to not output anything for the method.
See http://ruby-doc.org/stdlib-2.5.0/libdoc/secur... -
09:23 PM Feature #14462 (Closed): MJIT enabled should be displayed in the version string
- Whether or not MJIT is enabled will probably be an important part of diagnosing bugs. It's also useful for when benchmarking - we often run benchmarks with `-v`, and other implementations that have JITs give information about whether the...
-
04:54 PM Revision aea14e68 (git): insns.def: cache nil const
- * insns.def (getinlinecache): Qnil is a valid value as a constant.
this can be observable when accessing a deprecated constant
which is nil. non-nil constant is warned just once for each
location, but every time if it is nil.
git... - 04:09 PM Revision 7b6f0478 (git): * 2018-02-11
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62349 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
04:09 PM Revision 92413440 (git): test_jit.rb: cover most insn compilations
- test_compile_insns has only basic tests to improve coverage.
Other severer tests should be added with different names.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62348 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
10:07 AM Revision b40f9d55 (git): mjit_config.h: show content if verbose
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62347 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
10:07 AM Revision a16e93fb (git): mjit.c: constified command arguments
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62346 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
06:42 AM Revision 1a873c6a (git): vcs.rb: dryrun: option of GIT::SVN#commit
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62345 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
06:38 AM Revision 9a63e76b (git): select each files for architectures
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62344 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
06:22 AM Revision f6ca5edf (git): mjit_config.h
- * Makefie.in, win32/Makefile.sub: make mjit_config.h from
configured variables, including necessary options, e.g., `-m32`
for 32bit binary on 64bit platform.
* mjit.c: always use configured CC command. as config.h depends
on the ... -
06:02 AM Revision 61f26a1b (git): .gdbinit (print_lineno): support a succinct bitvector implementation [ci skip]
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62342 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
01:55 AM Revision 5b794fee (git): mjit.c: replaced magic numbers
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62341 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
01:28 AM Revision 0e1a5ece (git): mjit_compile.c: original_body_iseq
- * mjit_compile.c (mjit_compile): name the original iseq pointer to
eliminate magic numbers.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62340 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
01:23 AM Revision 9da6b8df (git): mjit.c: chomp suffix first
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62339 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
01:07 AM Revision b30b1c13 (git): mjit.c: binary mode
- * mjit.c (convert_unit_to_func): write source code in binary
mode. not conversion is needed.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62338 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
12:31 AM Feature #14460 (Closed): Speed up `require` and reduce memory usage
- Hi,
I've attached a patch that speeds up require and reduces memory usage. Before this patch, we could copy copy keys using `rb_strdup` for the `loaded_features_index` table. This patch changes the hash population functions to just ...