Activity
From 01/14/2018 to 01/20/2018
01/20/2018
-
10:09 PM Misc #14381 (Closed): [PATCH] ruby/ruby.h: remove unnecessary exports from C-API
- Note this depends on r61995, will wait a few days for review
(ENOSPC on my end to run gem-codesearch)
```
Needlessly exporting can reduce performance locally and increase
binary size.
Increasing the footprint of our C-API larger... - 10:07 PM Revision 903b6628 (git): load.c: use rb_warning directly
- This removes the last dependency on rb_mWarning outside of
error.c and allows future commits to mark it static.
Yes, I expect this to slow down the emitting of a warning
message in a cold code path slightly :P
git-svn-id: svn+ssh://ci.... -
07:44 PM Bug #14380: Expected transform_keys! to work just as transform_keys, but it doesn't
- Here is the current documentation:
http://ruby-doc.org/core-2.5.0/Hash.html#method-i-transform_keys
After looking at the example you gave, I can not say whether this is
deliberate or not - but either way, I think IF the behaviour ... -
07:03 PM Bug #14380 (Closed): Expected transform_keys! to work just as transform_keys, but it doesn't
- This seriously violates the Principle of Least Surprise to me:
{1 => :a, -1 => :b}.transform_keys{|k| -k} #=> {-1=>:a, 1=>:b}
{1 => :a, -1 => :b}.transform_keys!{|k| -k} # => {1=>:a}
# This fails:
ht=(1..10).map{|... -
05:52 PM Revision 8a489a7d (git): ext/ripper/tools/dsl.rb: Use String#sub instead of delete_suffix
- It fails when baseruby is old.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61994 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61993 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61992 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- To avoid the unspecified behavior (the evaluation order of arguments).
In `$$ = foo(bar(), baz());`, it is unspecified which `bar` or `baz` is
called earlier.
This commit changes the code to `v1=bar(); v2=baz(); $$ = foo();`.
git-svn-i... -
04:50 PM Bug #14379: Exit code 3 when running the sass compiler
- Oh, never thought about Onedrive, thank you!
Also, I apologize for the source file name, I forgot to change it, it slipped ||._. -
12:46 PM Bug #14379 (Closed): Exit code 3 when running the sass compiler
- Seems #14047.
-
- Edit: It shouldn't be a SASS error, as my colleague is working with the same Ruby release, SASS release, and SCSS source file
-
- Hi,
I was told by my IDE (JetBrains' WebStorm) support center to upload here a report about
a problem I'm encountering on windows 10 64bit, when launching the SASS compiler.
I installed Ruby 2.4.3-1 (x64), using the Installer.
I've... -
04:34 PM Bug #13496: Patches for MinGW builds - gnu_printf in 'config' & defines.h
- Since I've been building trunk, the gnu_printf patch has moved from
Configure.in -> Configure.ac -> tool/m4/ruby_check_printf_prefix.m4
Given that both ruby-loco and RubyInstaller2 use a patch for this, it would certainly be helpfu... -
- Currently, parser.y includes core parser and Ripper parser obscurity.
In addition, *some* Ripper code uses the result of the core parser,
which make it difficult to separate the two parsers.
I want to simplify this, not by separating th... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61989 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61988 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61987 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61986 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 04:21 PM Revision 4b902422 (git): * 2018-01-21
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61985 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61984 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Please ignore the above files. Patch is located at https://github.com/MSP-Greg/ruby-loco/blob/498b640b81d798c8d69badb7f24738b977caad00/patches/gte20600/spec-ruby-core-file-chmod_umask.patch or https://raw.githubusercontent.com/MSP-Greg/...
-
02:22 PM Feature #14378: Increase Fixnum range on Windows from 31 bits to 63 bits
- This is indeed very surprising that on a platform with 64-bit pointers, Fixnum are still only 30 bits.
+1 to making this more intuitive.
It creates a lot of weird edge cases in ruby/spec.
There are also places in the code where VALU... -
12:01 PM Feature #14378: Increase Fixnum range on Windows from 31 bits to 63 bits
- nobu (Nobuyoshi Nakada) wrote:
> To "fix" this, or relax this limitation, we have to replace tons of `long` in the source code.
Oh...I tried just now. The codes uses so large amount of '#define' to alias types' names, it makes the wo... -
- I'm using vs2017 and embed ruby interpreter in my game engine. In certain situation I need to use Fixnum to pass values of pointers(64-bits pointers). So ruby will use big integer to pass the pointer's values, what may cause unsatisfying...
-
- HfCloud (Xiangyu Shi) wrote:
> So, it is that FIXNUM of the 64-bits ruby is a 32-bits data?
Yes, we are using `long` for fixnums, and Windows is the so-called IL32LLP64 platform.
To "fix" this, or relax this limitation, we have to r... -
- On windows, start an IRB of a 64-bits ruby, enter these code:
~~~ruby
(1<<29).equal?(1<<29)
#=>true
(1<<30).equal?(1<<30)
#=>false
~~~
So, it is that FIXNUM of the 64-bits ruby is a 32-bits data?
But my friend try these co... -
07:14 AM Revision 58393960 (git): Emacs friendliness [ci skip]
- Just add comment by:
sed -i $'1i\\\n# -*- Autoconf -*-' tool/m4/*.m4
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61983 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- We do not use aclocal(1) by default. But in case users do so,
AC_CONFIG_MACRO_DIRS help them reconstruct the same contents as
this commit includes.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61982 b2dd03c8-39d4-4d8f-98ff-823fe69b... -
- This does not (yet) change anything. The generated configure file
is the identical to previous one (except several empty lines added
and deleted).
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61981 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * win32/Makefile.sub (MISSING): nan() is available since msvcrr120.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61980 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- I thought this trick was needed because the result of var_field was
passed to different arguments, as follows:
```
$1 = var_field(p, $1);
$$ = backref_assign_error(p, $1, $1, &@$);
```
Currently the DSL supports that one result is pass... -
- * parse.y (dot_or_colon): made type of `dot_or_colon` and EXPR_DOT
tokens to <id> and set those IDs at tokenization. type cast at
primary in ripper is no longer needed.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61978 b2dd03... -
- * parse.y (block_param): embed excessed_comma event result in
place of rest argument, instead of dispatching with the whole
parameters.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61977 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * ext/ripper/tools/dsl.rb (DSL#initialize): define `p` for `struct
parser_params *p`.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61976 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * ext/ripper/tools/dsl.rb (DSL#method_missing): expand ID
constnats without parentheses.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61975 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * ext/ripper/tools/dsl.rb (DSL.const_missing): define to expand
Qnil and Qundef as-is.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61974 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * ext/ripper/tools/dsl.rb (DSL#generate): indent after surrounding
by braces.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61973 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61972 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- instead of scattering #ifdef HAVE_NANF here and there define our
own nan() unless defined elsewhere.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61971 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
02:51 AM Feature #14370: Directly mark instruction operands and avoid mark_ary usage on rb_iseq_constant_body
- ko1 (Koichi Sasada) wrote:
> Cool.
> ...
Yes. I had to add marking for catch table iseq as well as marking the instructions. To verify the array contents I used the iterator code from this patch and printed out addresses from the ins... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61970 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
12:34 AM Feature #14377: Improve documentation for `OpenSSL::X509::Store#verify_callback=` and `OpenSSL::SSL::SSLContext#verify_callback=`
- In case it's relevant, certs were generated using
```
openssl req -x509 -newkey rsa:4096 -sha512 -nodes -keyout server.key -out server.crt -subj "/CN=server"
openssl req -x509 -newkey rsa:4096 -sha512 -nodes -keyout client.key -out ...
01/19/2018
-
- I'm trying to use `OpenSSL::X509::Store#verify_callback=` to ignore all error during certificate validation, which according to `man SSL_CTX_set_verify` should be possible:
> If verify_callback always returns 1, the TLS/SSL handshake ... -
- `OpenSSL::X509::Store#verify_callback=` must return `true` exactly, not just anything truthy. Switching the check in ossl_x509store.c:88 to
if (ret == Qfalse || ret == Qnil) {
if (X509_STORE_CTX_get_error(ctx) == X509_V_OK)
X5... -
- @Eregon,
Attached are three files (one patch, and two spec files from repo). Changes allow it to pass on MinGW. Rearranged things, not sure if that's appropriate (or done correctly)...
Thanks, Greg -
- Below are the results of spec tests for 61964. The previous build, `ruby 2.6.0dev (2018-01-19 trunk 61949) [x64-mingw32]` did not have these failures.
Thanks, Greg
```
1)
File#chmod always succeeds with any numeric values FAIL... -
06:55 PM Revision c151679c (git): r61950 changes mode_t to ushort on FreeBSD and Darwin
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61969 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61968 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61967 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61966 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61965 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- I think that they are not used.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61964 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 03:22 PM Revision 2a628a43 (git): * 2018-01-20
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61963 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- `foo!(...)` means Ripper event, and `foo(...)` means C function/macro
call. This is for fail-safe; if I forget `!` accidentally, it would
fail to compile, instead of wrongly adding a new Ripper event.
git-svn-id: svn+ssh://ci.ruby-lang... -
- https://github.com/nobu/ruby/tree/feature/14371-transform_keys-recursive
-
- * test/ruby/test_io.rb (TestIO#test_copy_stream_socket7): reduce
memory usage so the worker process will not die by OOM.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61961 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * parse.y (command): assign to $$. should not rely upon
undocumented behavior.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61960 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- My apologies!
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61959 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61958 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Instead of `_foo`. This makes it useful to do word boundary search of
the editor.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61957 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
12:15 PM Revision 814daf85 (git): Fix warning
- ``lib/net/protocol.rb:214: warning: `*' interpreted as argument prefix``
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61956 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61955 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- It was replaced with `/*% ripper[brace]: ... %*/`
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61954 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 10:48 AM Revision 340dc036 (git): * properties.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61953 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Currently, parse.y actions are hard to read and write because the code
has double meaning (for core parser and for ripper). I think that, if
it is easy to write ripper's code shortly and simply, the double meaning
trick is not needed.
... -
- I believe that the assignment to `$$` was just forgotten.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61951 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- POSIX only defines mode_t to be "an integer typea", and in fact
MacOS defines it to be uint16_t. We didn't have NUM2USHORT before
so it did not make sense but now that we have it. Why not check
apptopriately.
git-svn-id: svn+ssh://ci.... -
- In general, it is said that `for` statement and `each` method call are similar, except for the scope of loop variables.
I found another difference, since 1.9.
```ruby
a = [Struct.new(:to_ary).new([1, 2])]
a.each {|i, j| p [i, j]} ... -
- r61827, r61947 was about to fix this. The proper way to allocate
memory region is called ALLOCV_N.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61949 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Previous commit fails in CI.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61948 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- r61827 was about to fix this. The proper way to allocate memory
region is called ALLOCV_N.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61947 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- introduce new enum for it.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61946 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * vm_args.c (KW_SPECIFIED_BITS_MAX): subtracted 1bit for
FIXNUM_FLAG. [ruby-core:84921] [Bug #14373]
* vm_insnhelper.c (vm_check_keyword): unsigned for bit operation.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61945 b2dd03c8-... -
- gcc -Wjump-misses-init warns this goto. That is a false alert.
However why on earth do we need to use goto here?
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61944 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61943 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61942 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61941 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
03:10 AM Feature #14183: "Real" keyword argument
- It’s not clear for me all the implications of this change.
Would it be possible to exemplify the before and after behaviours in the description?
It feels to me that with this implementation it would be possible to consider both symbo... -
- Applied in changeset trunk|r61940.
----------
vm_insnhelper.c: fix many keyword arguments
* vm_insnhelper.c (vm_check_keyword): if the index exceeds the
width of unspecified bits, that argument is specified.
`unspecified_bits` stil... -
- * vm_insnhelper.c (vm_check_keyword): if the index exceeds the
width of unspecified bits, that argument is specified.
`unspecified_bits` still be a fixnum if the actual arguments do
not exceed the limit, regardless the formal param... -
- * vm_insnhelper.c (vm_check_keyword): invert unspecified value
flag as `checkkeyword` result. fix up r58390.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61939 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
02:16 AM Feature #14370: Directly mark instruction operands and avoid mark_ary usage on rb_iseq_constant_body
- Cool.
Did you verify the references between your patch and current implementation?
You can have two sets of referring objects from iseq->mark_ary and iseq (w/ your patch) and you can compare them to verify the reference.
> I fig... -
- matz (Yukihiro Matsumoto) wrote:
> rosenfeld (Rodrigo Rosenfeld Rosas), that sounds like if the de-facto JSON library can automatically convert map keys to symbols, most of the needs are fulfilled. And that must be much easier and sim... -
12:58 AM Feature #14336: Create new method String#symbol? and deprecate Symbol class
- matz (Yukihiro Matsumoto) wrote:
> @rosenfeld, that sounds like if the de-facto JSON library can automatically convert map keys to symbols, most of the needs are fulfilled. And that must be much easier and simpler than unifying symbols ... -
12:39 AM Feature #14336: Create new method String#symbol? and deprecate Symbol class
- @rosenfeld, that sounds like if the de-facto JSON library can automatically convert map keys to symbols, most of the needs are fulfilled. And that must be much easier and simpler than unifying symbols and strings.
Matz.
-
- It seems HUGE_VAL is already used. Why not eliminate INTINITY.
NAN is also float. That of double is called nan(). This is also
fixed.
Signed-off-by: Urabe, Shyouhei <shyouhei@ruby-lang.org>
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/t...
01/18/2018
-
09:34 PM Bug #14372: Memory leak in require with Pathnames in the $LOAD_PATH in 2.3/2.4
- I did a small change to see how the number of Pathnames in the `$LOAD_PATH` changes the leak amount at the script's completion.
It looks like the memory leak is linear:
1 74.6 MB
2 149.5 MB
3 214 MB
4 290 MB
5 353.6 MB
9 575.4 ... -
- It's worth mentioning that more `Pathname` objects in the `$LOAD_PATH` may make this leak worse as even on ruby 2.5.0, the time for require increases with each added Pathname to the `$LOAD_PATH`.
-
- There is a memory leak that we have found on ruby 2.3.6 and 2.4.3 that happens on Mac OSX and Linux. Ruby 2.2.6 and 2.5.0 do not leak. We have not tested other platforms.
If `$LOAD_PATH` contains one or more Pathname objects, `requi... -
- normalperson (Eric Wong) wrote:
> tenderlove@ruby-lang.org wrote:
> ...
I figured this might be the case. This patch should make ISeq marking slower, but I wasn't sure if it would be mitigated by the fact that the ISeq objects get old... -
- I ran the code and indeed, this is very strange behaviour.
The bigget surprise to me was the "prints nothing in 2.5, prints
a1 in 2.4 and 2.3" part. I know way too little to say anything
but to me this looks like a bug/regression.
... -
05:23 PM Bug #14373 (Closed): Methods with more than 32 keyword arguments with default values have some of the arguments set to default despite being passed in.
- ~~~ ruby
class Test
# 33 keyword arguments
def test1(a0: '', a1: '', a2: '', a3: '', a4: '', a5: '', a6: '', a7: '', a8: '', b0: '', b1: '', b2: '', b3: '', b4: '', b5: '', b6: '', b7: '', b8: '', c0: '', c1: '', c2: '', c3: '', ... - 03:48 PM Revision 09b4d6e8 (git): * 2018-01-19
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61937 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * compile.c (ibf_dump_object_list): allocate known-size array by
ALLOCV_N instead of rb_ary_tmp_new.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61936 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- r61883
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61935 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61934 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- I agree with the proposal.
If it is approved, please do not forget meaningful documentation + perhaps
at the least one short example for using it (I refer to the recursive: true
option; http://ruby-doc.org/core-2.5.0/Hash.html#metho... -
05:59 AM Feature #14371: New option "recursive: true" for Hash#transform_keys!
- > Why prefer `each` over `transform_keys!`?
> ...
Your points are correct. The ideal pseudo code is here:
```ruby
def transform_keys!(recursive: false, &block)
# do original transform_keys! here
values.each do |v|
if v.re... -
- tagomoris (Satoshi TAGOMORI) wrote:
> ```ruby
> ...
Why prefer `each` over `transform_keys!`?
And probably you wanted to write `elsif`. -
- `Hash#transform_keys!` is available when we want to symbolize hash keys.
But in some/many cases (for example, receiver hash object is nested configuration tree loaded from any files), hash object are
nested object, which has hashes or ... -
11:44 AM Revision ef9bc609 (git): Fix typos.
- * rememberd -> remembered
* refered -> referred
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61933 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61932 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61931 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61930 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61929 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61928 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61927 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61926 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61925 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61924 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61923 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61922 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61921 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61920 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61919 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61918 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61917 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61916 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61915 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61914 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61913 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- This is the -Wsuggest-attribute=noreturn equivalent option for clang.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61912 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61911 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61910 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61909 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61908 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61907 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61906 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61905 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * vm_eval.c (rb_type_str): moved `case`s and semicolons so auto
indentation works.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61904 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * eval_intern.h (pass_passed_block_handler): remove duplicate
check. vm_block_handler_verify() is called in the successive
function call.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61903 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
04:42 AM Bug #14232: Unused refinement still breaks method search
- You cannot refine Module on 2.3.x.
I set DONTNEED for 2.3. -
- It your ruby is compiled with that option, `long long` should not be used.
-
- You can write "exact" number by `1.2r`.
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61902 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
-
- * parse.y (assignable): no longer needs to undef since r61899.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61901 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61900 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * parse.y (REQUIRED_KEYWORD): special argument for required
keyword argument, for core and ripper.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61899 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Applied in changeset trunk|r61898.
----------
resolv.rb: NUL hosts
* lib/resolv.rb (Resolv::Hosts::DefaultFileName): fallback to NUL
device when Win32::Resolv.get_hosts_path() returned nil, to get
rid of TypeError in lazy_initializ... -
- What configuration causes it?
No TCP/IP stack? -
- * lib/resolv.rb (Resolv::Hosts::DefaultFileName): fallback to NUL
device when Win32::Resolv.get_hosts_path() returned nil, to get
rid of TypeError in lazy_initialize.
[ruby-core:84907] [Bug #14369] [Fix GH-1791]
git-svn-id: svn+s... -
- * lib/resolv.rb (each_address): use safe navigation operator to
avoid extra hash lookups, as well as each_name since r56890.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61897 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * marshal.c (r_object0): initialize `keywords` and removed
`keyword_init` flag, to get rid of maybe-uninitialized warning.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61896 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * ext/win32/lib/win32/resolv.rb: call rb_w32_osid instead of
direct GetVersionExA API.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61895 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 12:52 AM Revision f729089f (git): logger: use safe navigation operator
- Saves a few hundred bytes of bytecode in a frequently loaded module.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61894 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
01/17/2018
-
- tenderlove@ruby-lang.org wrote:
> I was concerned that this patch might impact GC time, but
> `make gcbench-rdoc` didn't seem to show any significant
> difference in GC time between trunk and this patch. If it
> turns out there is ... -
- Hi,
I've attached a patch that changes rb_iseq_mark to directly mark instruction operands rather than adding them to a mark array. I observed a ~3% memory reduction by directly marking operands, and I didn't observe any difference in... -
06:12 PM Bug #14369: Win32::Resolv.get_hosts_path may return nil, causing Resolv to fail
- Added [GitHub PR #1791](https://github.com/ruby/ruby/pull/1791)
-
- [Win32::Resolv.get_hosts_path()](https://github.com/ruby/ruby/blob/e0468f5ce87ef77c1ad08bc0d107a967e4906783/ext/win32/lib/win32/resolv.rb#L14) may return `nil`.
The `Resolv` class uses that [to get the hosts filename](https://github.c... -
- It breaks AIX build:
https://rubyci.org/logs/rubyci.s3.amazonaws.com/aix71_ppc/ruby-trunk/log/20180117T113303Z.log.html.gz
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61893 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61892 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
04:54 PM Bug #13889: FileUtils.rmdir が Errno::ENOTEMPTY を無視している
- The decision to not backport this is questionable IMO.
For example, the test suite of spring-watcher-listen passes testing against Ruby 2.4, but unintentionally leaves files/directories behind, because the FileUtils.rmdir secretly swa... - 03:28 PM Revision 4fd6391c (git): * 2018-01-18
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61891 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * iseq.c (iseq_data_to_ary): when OPT_CALL_THREADED_CODE is used,
iseq_encoded is overwritten by instructions with trace and the
original_iseq is not stored. convert these instructions to the
original instructions as external repr... -
01:31 PM Feature #14362: use BigDecimal instead of Float by default
- In TruffleRuby we represent values that have a single logical class using multiple implementation techniques, transparently to the user. For example for `Hash` can be either a linear array of values, or an array of buckets, and `Fixnum` ...
-
- * node.c: strucutre -> structure
* random.c: acquried -> acquired
* thread.c: accross -> across
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61889 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- backport 管理用チケットです。
-
- * process.c (get_clk_tck): prefer CLK_TCK over older HZ, next to
_SC_CLK_TCK.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61888 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * process.c (get_clk_tck): remove useless cast, implicitly cast to
long again.
* process.c (rb_proc_times): cast explicitly.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61887 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * common.mk (ripper.c): strip nmake-style VPATH from depend file,
as well as mkmf.rb does.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61886 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Hanmac (Hans Mackowiak) wrote:
> the problem is this:
> ...
No, I believe that isn't the problem. For instance /\c\x7F/ works.
```sh
% LC_ALL=C ruby -ve 'p(/\c\x7F/ =~ "\c\x7F")'
ruby 2.0.0p648 (2015-12-16 revision 53162) [univer... -
10:04 AM Bug #14367: Wrong interpretation of backslash C in regexp literals
- the problem is this:
~~~ ruby
/\c\xFF/.source == "\\c\\xFF"
~~~
which is already escaped
you might want this:
~~~ ruby
/#{"\c\xFF"}/ == /ƒ/
~~~
or use this:
~~~ ruby
Regexp.compile("\c\xFF")
~~~
PS: it is c... -
- Following ruby code returns nil.
```sh
% LC_ALL=C ruby -ve 'p(/\c\xFF/ =~ "\c\xFF")'
ruby 2.6.0dev (2018-01-16 trunk 61875) [x86_64-darwin15]
nil
```
Is this intentional? -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61885 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- graywolf (Gray Wolf) wrote:
> Out of curiosity, is there any particular reason we still stick with c90?
Because VC++ and Solaris' cc doesn't support part of C99.
Therefore we use C90+some extensions.
What extensions we use are desc... -
- Out of curiosity, is there any particular reason we still stick with c90?
-
- Let me reject this. Using long long when available must never be a bad thing.
Also, we do check availability of long long using configure. If you really have to kill long long, try `configure --with-gcc="gcc --pedantic-errors"` or so... -
- * test/-ext-/ast/test_ast.rb: exclude base directory name from
test method names.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61884 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61883 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
06:16 AM Bug #11119: Anonymous classes and modules have terrible #name and #inspect performance
- Some new benchmarks with recent MRI versions:
Ruby 2.3.6:
```
named
0.300000 0.010000 0.310000 ( 0.305285)
anon
31.550000 0.120000 31.670000 ( 32.200161)
anon obj
33.820000 0.180000 34.000000 ( 34.864390)
```
... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61882 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 05:03 AM Revision 377b1895 (git): time.c: use "unsigned int" for bitfields
- Followup to r61870
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61881 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61880 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
02:09 AM Bug #14360 (Rejected): Regression CSV#open method for writing from Ruby 2.4.3 to 2.5.0
01/16/2018
-
- DeveloperHowto says that ruby should be C90, not C99, however it's not possible
to compile C extension using `-std=c90` command line argument with error:
```
C:/Ruby25/include/ruby-2.5.0/ruby/defines.h:224:25: warning: ISO C90 does ... -
- > would it not be better if this were an error?
I have not yet reached the build-up chain that you described above,
but I think the biggest issue in your report so far is the focus
on an error.
Why should this be an error? The sy... -
05:34 PM Feature #14365 (Open): irreconcilable ancestor chain ordering expectations should perhaps produce an error
- ```ruby
module Module1
def foo
puts 'Module1#foo'
super
end
end
module Module2
include Module1
def foo
puts 'Module2#foo'
super
end
end
class SuperClass1
def foo
puts "SuperClass1#f... -
05:53 PM Feature #14362: use BigDecimal instead of Float by default
- That's absolutely true. However, it's much less likely and I would say less surprising than the issues you find with a `Float`. Switching to use `Rational` where possible is an option but felt like a step too far. In short, it's not perf...
-
09:00 AM Feature #14362: use BigDecimal instead of Float by default
- "arbitrary-precision" doesn't mean that `BigDecimal` is immune to rounding problems:
```ruby
a = BigDecimal(1)
b = BigDecimal(3)
(a / b) * b
#=> 0.999999999999999999e0
``` -
- I've filed a bug report some time ago, maybe you could add it as a related issue: https://bugs.ruby-lang.org/issues/11993
-
05:23 PM Bug #14364 (Open): Regexp last match variable in procs
- While working on TruffleRuby's regexp variables implementation I found the following behaviour when comparing our behaviour with MRI 2.3.5 and 2.5.0.
Some core methods such as `String#scan` take an optional block argument, and if this... -
- > Of course, I proposed $SAFE as Fiber local.
:)
If $SAFE had no effect at all, then I think it would be fine to make $SAFE a normal process-wide global variable.
But this is not the case, $SAFE still causes SecurityError.
Theref... -
- Of course, I proposed `$SAFE` as `Fiber` local.
However, Matz said process global is enough.
akr also said nobody use `$SAFE` correctly, so that such incompatibility is not a matter.
I'm neutral. Matz, please decide it.
-
- Confirmed with 2.5.0, 2.4.3 did not occur. Below shows 2.6/trunk info:
```
ruby 2.6.0dev (2017-12-31 trunk 61522) [x64-mingw32] Failed SEGV
ruby 2.6.0dev (2018-01-01 trunk 61530) [x64-mingw32] Passed Syntax Error
ruby 2.5.... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61879 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61878 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 03:12 PM Revision d52e51ec (git): * 2018-01-17
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61877 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61876 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
03:03 PM Feature #12306: Implement String #blank? #present? and improve #strip and family to handle unicode
- I would also like to have `blank?` and `present?` in Ruby. @matz says he doesn't see the benefit of having them, but I think they improve readability.
-
12:21 PM Bug #14360: Regression CSV#open method for writing from Ruby 2.4.3 to 2.5.0
- jeremyevans0 (Jeremy Evans) wrote:
> This isn't a regression, it's an intentional bug fix. If you tell it to write the headers, it should write the headers even if there are no rows. See #9988 and r59640. If someone really wants the ... -
- This is NG. The ISO C section 6.7.2.1 explicitly states that
structs having flexible array members "shall not be a member
of a structure or an element of an array."
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61875 b2dd03c8-39d4-4... -
- as per https://bugs.ruby-lang.org/projects/ruby-trunk/wiki/Assumptions
we are officially giving up 509 characters limit of C string
literal length.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61874 b2dd03c8-39d4-4d8f-98ff-823fe69b... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61873 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * parse.y (top_compstmt, compstmt): unified void_stmts with
ripper.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61872 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Ruby 2.5 adds `String#each_grapheme_cluster` to enumerate the string's grapheme clusters:
```ruby
str = "a\u0300i\u0301" #=> "àí"
str.each_grapheme_cluster.to_a #=> ["à", "í"]
```
Unfortunately, the enumerator's `s... -
- NODE_FOR was used both for "for"-statement itself and for
multi-assignment of for-statement (for x, y, in...end).
This change separates the two purposes, NODE_FOR for the former, and
newly introduced NODE_FOR_MASGN for the latter.
git-s... - 06:36 AM Revision 56524df9 (git): timev.h: just use "unsigned int" for bitfields
- There's no point in having separate types depending on C dialect
when using bitfields, "unsigned int" bitfields are bitfields
anywhere.
Note: we also have test_memsize in test_time.rb in case
users of other platforms want to enable size... -
05:49 AM Revision f62a2fd1 (git): fix macro argument names inconsistency
- * include/ruby/defines.h (RUBY_ALIGNAS): Fix macro definition.
Fix compile error with Fujitsu C Compiler (fcc) on Solaris.
* include/ruby/defines.h (RUBY_ALIGNOF): Fix macro argument name.
Fix compile error with fcc and Oracle Solar... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61868 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61867 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * parse.y (tokadd_mbchar): renamed and expand callers with p.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61866 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Reported by mame. Thanks.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61865 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61864 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61863 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Mixing other encoding string literals in one Regexp caused SEGV.
This bug was found by CoverityScan.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61862 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61861 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
01/15/2018
- 11:43 PM Revision f6c65935 (git): * properties.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61860 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
11:43 PM Revision 0f3dcbdf (git): Add tests for Node code locations
- * test/-ext-/ast/test_ast.rb: Add tests for Node
code locations. This file tests
1. There are no Node whose code location is default
value (#test_not_cared)
2. There are no Node whose children's code locations
exceed pa... -
- > I realize this goes against the 3x3 goal but I think BigDecimal
> ...
That's an interesting comment. :)
You could ask matz whether 3x3 is more important than making life
of developers easier. I am not saying that your proposal mak... -
- When writing a decimal the default type assigned is `Float`:
```ruby
> 1.2.class
=> Float
```
This is great for memory savings and for application speed but it comes with accuracy issues:
```ruby
> ...
=> 12994.999999999998
... -
- Well, well, well Aaron. What have you been doing? Gmail has an eye on you!
Your messages are being considered spam. :-)
Is it just me again? -
10:03 PM Bug #9572: Restarting Coverage does not produce correct coverage result
- I am seeing emails from Aaron's comments.
-
- Aaron, why aren’t we seeing email notifications from your comments? Or is it just me?
-
- > Pause / Resume just seems like ignoring coverage information for some code.
Yes, the goal would be to ignore it for some code, but with reduced performance costs.
My thought was much of the performance cost was related to tracki... -
- Hello,
Below are the two failures for `test_rubyoptions.rb`, using `ruby 2.4.4p228 (2018-01-15 revision 61854) [x64-mingw32]` and `test_rubyoptions.rb` at the same commit:
```
# Note - Two skips for 'platform dependent feature'
... -
- Hello, Grep
Thank you very much for your investigation!
I confirmed that the revision r59040 was depend on some other changesets, and it isn't clear that it can be backported without unexpected behavior change.
Anyway please show ... -
- This isn't a regression, it's an intentional bug fix. If you tell it to write the headers, it should write the headers even if there are no rows. See #9988 and r59640. If someone really wants the old broken behavior, maybe we can add ...
-
- Eric Wong <normalperson@yhbt.net> wrote:
> doc/maintainers.rdoc points to GH.
... for the CSV gem; as parts of the stdlib are separated into
different repos. -
- shevegen@gmail.com wrote:
> Issue #14360 has been updated by shevegen (Robert A. Heiler).
> > This issue is also open in its repository because it's not clear to me
> > where is the appropriate place to open the issue
>
> Don't wo... -
- > This issue is also open in its repository because it's not clear to me
> ...
Don't worry - the tracker here is still the official bug/feature/misc
tracker for the ruby language. Github issues are secondary and often
primarily useful... -
- I have noticed a different behaviour between Ruby <= 2.4.3 and Ruby 2.5.0 for the `#open` method.
This issue is also open in its repository because it's not clear to me where is the appropriate place to open the issue, https://github.... -
05:42 PM Bug #14361 (Closed): Segmentation fault when array includes two nil's without a comma between them: [nil nil, nil]
- Easily reproduced segmentation fault relating to forgetting to type a comma between nil's in an array. Doesn't occur if array only contains the `nil nil` entry, instead throws a syntax error, which is what I would expect in this case.
... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61858 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 03:04 PM Revision e7c8b324 (git): * 2018-01-16
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61857 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- There were four cases that uses new_command_qcall and then
method_add_block. This change factors out the four rules.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61856 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- The bison rules were not covered.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61855 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- In Ruby's IO, a "byte" means an integer of range 0...256.
However IO#ungetbyte is the only exception.
It does not check the argument to accept liberal integers.
```ruby
File.open("/dev/zero") {|f| f.ungetbyte(-1); p f.read(2) } # =... -
- ruby_2_4 r61854 merged revision(s) 60079.
-
- thread_pthread.c: do not wakeup inside child processes
* thread_pthread.c (rb_thread_wakeup_timer_thread): check
ownership before incrementing
(rb_thread_wakeup_timer_thread_low): ditto
[Bug #13794]... -
- * test/-ext-/win32/test_console_attr.rb (reverse_video): fix test
when reverse video is set.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61853 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * gc.c: beacuse -> because.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61852 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- It's a private team.
-
- What is that slack channel?
Is it open to subscription? -
- It fixed secure token of the slack channel.
-
11:53 AM Bug #14358 (Closed): URI.encode_www_form_component doesn't encode bad chars properly
- ~~~ruby
URI.encode_www_form_component "\u02DA", Encoding::WINDOWS_1252
#=> "%26730%3B"
# Expected:
#=> "%26%23730%3B"
~~~
As per http://www.w3.org/TR/2013/CR-html5-20130806/forms.html#url-encoded-form-data :
"For each charac... -
- * win32/win32.c: wrok -> work
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61851 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- The thread_safe gem is not maintained anymore, but I don't see any reason why its test suite should segfault with Ruby 2.5.
~~~
+ rspec -Ilib spec
Randomized with seed 62008
............./builddir/build/BUILD/thread_safe-0.3.6/usr/... -
- tIDENTIFIER is now always a local id (except fname).
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61850 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Nowadays, there are less rules whose return value is NULL.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61849 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- There are many usages assuming that bodystmt always returns non-null.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61848 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61847 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- same as r61833
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61846 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61845 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * ext/socket/raddrinfo.c (parse_numeric_port): necessary
regardless of GETADDRINFO_EMU.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61844 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- win32ole.c includes ALLOCA_N(struct myCPINFOEX, 1). On such case
it is not a wise idea to align to the size of that struct.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61843 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61842 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Follow up of r28123 (!)
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61841 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61840 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Reports show that gcc (Raspbian 4.9.2-10) 4.9.2 fails here.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61839 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61838 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- The code fragments were commented out in YARV merge era.
I believe that it will be never needed in near future.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61837 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- It seems to be a false positive that the configure detects this
undocumented function to be available on the compiler.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61836 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- rb_setup_fake_str() can take arbitrary char* address, typicalluy
C string literals. These arguments have no guarantee of
alignment at all. It was not a wise idea for me to think
RSTRING_PTR can be aligned.
git-svn-id: svn+ssh://ci.rub... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61834 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Use compile-time constant expression instead.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61833 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * tool/ytab.sed: fix for more old bison which does not support %lex-param
at yydestruct (missed at the previous commit).
define yy_stack_print macro to add `p` argument instead of
replacement at callers.
git-svn-id: svn+ssh://ci.r... -
- I can't count to 8 in
```
xargs grep --files-with-match '^ '`
```
, sorry, just ignore me. :/ -
- @graywolf we are talking about C codes here. The "Do not use TABs" policy applies to non-C files.
-
- Before this NORETURN was checked only for __attribute__ or __declspec,
but nowadays other ways are there to tell compilers that a function
never returns. Take them into account.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61831 b... -
- ALLOCA_N takes type arugment. It is natural that the returned
value to be used as an array of type, thus type-aligned.
Luckily GCC has a builtin to tell compiler such alignment info.
This should generate beter instructions.
git-svn-id:... -
- These casts are guarded. Must be safe to assume alignments.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61829 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- C11 and C++11 has this feature so why not use it when available.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61828 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- For instance array.c:rb_ary_product() uses RSTRING_PTR() as an
array of int. So to avoid misaligned memory access RSTRING_PTR()
must at least be sizeof(int)-aligned. However the type of
RSTRING_PTR() is char*, which of course can expect... -
- * tool/ytab.sed: `p` is too short to distinguish alone from other
names. fix for more old bison which does not support %lex-param
at yydestruct. add `p` argument to non-prototype declaration of
yy_stack_print.
git-svn-id: svn+ss... - 12:45 AM Revision 5f3ddb32 (git): * 2018-01-15
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61825 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- At least, I confirmed bison 2.3 (because macOS uses the version).
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61824 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
01/14/2018
-
- > The more important piece of the change is being able to pause and resume coverage.
Pause / Resume just seems like ignoring coverage information for some code. This case seems like you can handle by taking snapshots around the execu... -
- Thanks for the reply... So you are right about the calculating the current coverage with `peek_result` and if we want to avoid complexity, it would be fine to drop the reset method and have the user app handle calculating the difference....
-
- I have two questions:
1. How is this different than recording the current coverage with `peek_result`, then subtracting later? Like this for example: https://gist.github.com/tenderlove/eefcce7dcadb0ed48968f575698e3f04
2. Is there ... -
- I would like to work on closing this out but I believe due to changes in the API expectations since the bug was filed this is likely to not be considered a bug anymore but more likely to be considered to be expanding the feature set. I a...
-
- As documented, `Object#clone` and `Object#dup` do shallow copies by default, so this behavior is expected. Create your own class and override `initialize_copy` (or `initialize_dup` and `initialize_clone`) as appropriate for the behavior...
-
07:27 PM Bug #14355 (Rejected): clone issue
- #!/usr/bin/env ruby
aMutantSpeak = [[nil,nil],[nil,nil]]
aDogSpeak = aMutantSpeak.clone
aCatSpeak = aMutantSpeak.clone
aDogSpeak[0][0] = "W"
aCatSpeak[0][0] = "m"
aCatSpeak[0][1] = "e"
aDogSpeak[0][1] = "O"
aCatSpeak[1][0] = "o"
... -
- As @vo.x already pointed out, there are guidelines for the indentation. So based on the guidelines the 101 files are (probably) correctly indented and the 76 (10 + 66) files are (probably) wrongly indented.
-
- @nagachika
First of all, I'd like to apologize for the above, as it is incorrect. I revisited this (ruby-loco 'broke' due to the renaming of configure.in to configure.ac), and the commit that fixed the failure was 59040 aac0b43 (by @... -
03:24 PM Misc #13968: [Ruby 3.x perhaps] - A (minimal?) static variant of ruby
- What You think about mrubyc ?
Second idea is turn off float and stdio
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61823 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * parse.y (yydebug): define to disable a global variable and get
rid of linker error when static linked ext.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61822 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- I don't know what it was, but seems that it has been already fixed since
r12117.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61821 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61820 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- The current parse.y won't compile with yacc since it depends on many
bison's extensions. Also, configure.ac does not have a check for yacc,
so the macro OLD_YACC is no longer used.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@6181... -
- In parse.y many functions were suffixed "_gen" and had companion macros
to pass struct parser_params implicitly, which made parse.c bigger and
more obscure.
This change expands and removes almost all "*_gen" macros. This
requires expli... -
- For example, `lex_strterm` is expanded to `p->lex.strterm`.
I believe that this expansion make the code straightforward.
They look not so annoying because "parser" was renamed to "p".
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61816 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Because I want to use the name "p" for struct parser_params through
parse.c. This change renames "p" to "ptr", "paren", etc. depending upon
the context.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61815 b2dd03c8-39d4-4d8f-98ff-82... -
01:41 PM Bug #14354 (Closed): Remove confusing doc comments for 2.3
- Broken doc comments are removed at @56285:
https://bugs.ruby-lang.org/projects/ruby-trunk/repository/revisions/56285/diff
An issue is reported to RDoc because of this is not backported to 2.3:
https://github.com/ruby/rdoc/issues/429 -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61814 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
02:44 AM Feature #14339 (Closed): [PATCH] net/http: use writev for HTTP chunked request bodies - Applied in changeset trunk|r61812.
----------
net/http: use writev for HTTP chunked request bodies
This reduces both user and system CPU time for large
uploads with dynamically-generated request bodies.
user system ... - 02:44 AM Revision bbea0270 (git): * 2018-01-14
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61813 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 02:44 AM Revision 7db24a62 (git): net/http: use writev for HTTP chunked request bodies
- This reduces both user and system CPU time for large
uploads with dynamically-generated request bodies.
user system total real
before: 0.393334 1.580000 1.973334 ( 1.971066)
after: 0.223334 0.97...