Activity
From 12/15/2017 to 12/21/2017
12/21/2017
- 11:28 PM Revision 93dcc40b (git): * 2017-12-22
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61394 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
11:28 PM Revision c5520076 (git): Extend timeout for CI.
- http://ci.rvm.jp/results/trunk-asserts-nopara@ruby-sky1/266962
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61393 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
02:15 PM Revision bf287424 (git): open-uri defines URI.open defined as an alias.
- open-uri's Kernel.open will be deprecated in future.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61392 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
12:05 PM Misc #14216: webrick: audit and fix Kernel#open misuse
- normalperson@yhbt.net wrote:
> https://bugs.ruby-lang.org/issues/14216
I don't think there's actual bugs in webrick because of Kernel#open.
The following series tightens down wrong/nonsensical behavior,
and makes future code aud... -
- Based on [Bug #14205] (resolv) and [Bug #14212] (logger),
webrick also needs to be checked for Kernel#open misuse.
-
11:59 AM Revision 7a54b5b4 (git): test for [Bug #14214]
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61391 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
10:55 AM Bug #14215 (Closed): result_with_hash change local variable by hash value.
- When there is a local variable with the same name as the hash key,
ERB#result_with_hash changes the local variable by hash value.
This is sample code.
~~~ ruby
require "erb"
erb_obj = ERB.new("<%=name%> \"Hello <%=first_name... -
09:43 AM Bug #14213: cross build fails
- Thank you @nobu !
-
- Applied in changeset trunk|r61385.
----------
common.mk: revert r58542 [Bug #14213] -
- For [rake-compiler-dock](https://github.com/rake-compiler/rake-compilder-dock) Ruby is built per cross compiler for Linux 32/64 and Windows 32/64. This fails for ruby-2.5.0-rc1.
~~~
$ ./configure --host=i686-linux-gnu --target=i686-l... -
09:29 AM Revision 72230626 (git): Added detailed version of Bundler on NEWS.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61390 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
09:29 AM Revision 82d63fca (git): Simplify Thread#[]= spec
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61389 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61388 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
08:30 AM Bug #14214 (Closed): The direction of branch instruction is broken when block argument is used.
- Applied in changeset trunk|r61387.
----------
revert r61371 for [Bug #14214]
Reverted patch doesn't check overwritten value. -
08:12 AM Bug #14214 (Closed): The direction of branch instruction is broken when block argument is used.
- The result of this code is changed
```ruby
def a(&block)
block = 1
p block
p 2 if block
end
a()
```
```
ruby 2.5.0rc1 (2017-12-14 trunk 61243) [x86_64-darwin17]
1
2
```
```
ruby 2.5.0dev (2017-12-21 trunk 613... -
- Reverted patch doesn't check overwritten value.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61387 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61386 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61385 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
07:27 AM Feature #12318 (Closed): Returning the evaluated value of a block
- avit (Andrew Vit) wrote:
> This is now implemented as `yield_self`
> ...
Yes. Closing. -
06:15 AM Feature #12318: Returning the evaluated value of a block
- This is now implemented as `yield_self`
Close please? -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61384 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
06:52 AM Revision c2f10299 (git): parse.y: change NODE_SCOPE's nd_loc to one of the parent NODE
- This change (ad-hocly) adjusts the code range of NODE_SCOPE in
class/module definition because the same adjust is already done in
method definition. I intend to just remove inconsistency between
class/module definition and method defini... -
- * iseq.c (rb_iseq_code_range): added to access iseq's code range.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61382 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
05:09 AM Revision 05d1d29d (git): Don't allow mixed escape
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61381 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61380 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61379 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
05:07 AM Bug #14212 (Closed): Logger uses Kernel.#open to open a file, so it can open something more than files
- Applied in changeset trunk|r61378.
----------
* lib/logger.rb (Logger::LogDevice#open_logfile, #create_logfile):
Logger should be able to open only files [Bug #14212] -
- It is not intended behavior.
-
- Logger should be able to open only files [Bug #14212]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61378 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- I use all of these and am more than willing to maintain them
from ruby-core mailing list <=> https://bugs.ruby-lang.org/
as a communications channel as I do with webrick.
Once again, I will never use non-Free software or services to... -
- I use all of these and would be willing to maintain them if
nobody else steps up.
I can probably maintain net/pop3, too, even though I don't currently
use it.
Hopefully this isn't controversial since they're all maintained
i... -
-
12:40 AM Revision 2c075d38 (git): Fix `imemo_name` to dump new imemo types
- New IMEMO types were introduced, this just fixes the function that
converts the type to support the new types.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61377 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
12:26 AM Bug #14195 (Closed): [PATCH] IO#pwrite uses tmp buffer to avoid parallel modification - Applied in changeset trunk|r61376.
----------
io.c: IO#pwrite uses tmp buffer to avoid parallel modification
Since we release GVL, we must freeze and duplicate the string buffer
to prevent other threads from modifying our buffer while ... - 12:26 AM Revision 3b174fb7 (git): io.c: IO#pwrite uses tmp buffer to avoid parallel modification
- Since we release GVL, we must freeze and duplicate the string buffer
to prevent other threads from modifying our buffer while we are
waiting on pwrite(2).
* io.c (rb_io_pwrite): use_rb_str_tmp_frozen_{acquire/release}
[Bug #14195]
gi...
12/20/2017
-
- * spec/ruby/core/thread/element_set_spec.rb: `t` can be uninitialized.
Use `Thread.current` explicitly.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61375 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
11:42 PM Bug #13305: Occasional segfaults after defining methods while running coverage
- Can this fix be backported to the Ruby 2.4 release series? 2.4.3 is still affected by this crash.
-
- r58439 is needed.
-
02:35 PM Bug #13493: `make realclean` removes aclocal.m4 and enc/jis/props.h
- I'm sorry I added r58440 as related revision to this ticket, but it may be a mistake.
Anyway, after backporting r58438 to ruby_2_4 branch, `make` show the error as below.
make: *** No rule to make target `../ruby_2_4/enc/jis/pr... -
09:29 PM Feature #14197: `Enumerable#{select,reject}` accept a pattern argument
- I think this suggestion looks ok, unless I may have missed something.
The main difference Kazuhiro is suggesting, appears to be the shorter
notation via regex given to .reject() rather than use the (longer)
block variant.
Here is... -
06:10 PM Bug #14193: --enable-frozen-string-literal and rubygems, erb, & rdoc
- aycabta (aycabta .) wrote:
> Then, lib/rdoc/rd/block_parser.rb and lib/rdoc/rd/inline_parser.rb are generated from *.ry by Racc, so it's Racc's issue.
Thanks for pointing that out.
The rubygems patch was accepted there, I'll patch... -
05:09 PM Bug #14193: --enable-frozen-string-literal and rubygems, erb, & rdoc
- k0kubun (Takashi Kokubun) wrote:
> I believe RDoc upstream is https://github.com/ruby/rdoc and it's just copied from that place to ruby core. Thus I think it's better to post an issue or create PR to https://github.com/ruby/rdoc too, fo... -
- znz (Kazuhiro NISHIYAMA) wrote:
> I think `''.dup` is better than `String.new` in most cases. Because `String.new.encoding` is ASCII-8BIT, so it may be incompatible.
> ...
Thanks. I did not know about the encoding difference.
Also,... -
01:00 PM Bug #14193: --enable-frozen-string-literal and rubygems, erb, & rdoc
- I think `''.dup` is better than `String.new` in most cases. Because `String.new.encoding` is ASCII-8BIT, so it may be incompatible.
`String.new` is better in some cases. For example: https://github.com/ruby/ruby/blob/373babeaac8c3e663e1... -
- ko1 (Koichi Sasada) wrote:
> What happen on exception from deep backtrace, occurred by other more
> ...
Yes, although we can omit the common part of the backtrace in the cause backtraces like in Java:
http://www.codejava.net/java-cor... -
- Fixed by @usa in 61374, thank you, Greg
Please close... -
- See attached. I assume that Errno::EINVAL is acceptable as an error, along with Errno::ENOENT...
Thanks, Greg - 04:04 PM Revision 098c8d54 (git): fix test errors on Windows
- * test/resolv/test_addr.rb (test_hosts_by_command): on Windows, `|` is
invalid charactor for path and raises `Errno::EINVAL` if trying to
open.
* test/resolv/test_dns.rb (test_resolv_conf_by_command): ditto.
... -
- ruby_2_4 r61373 merged revision(s) 60021.
-
- HTTPHeader#add_field should allow binary [Bug #13926]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_4@61373 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 03:45 PM Revision ac6db01f (git): * 2017-12-21
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61372 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * compile.c (compile_branch_condition): replace block param value
in branch conditions with `defined(yield)`, to get rid of
creating proc value.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61371 b2dd03c8-39d4-4d8f-98ff-823fe69... -
- ruby_2_4 r61370 merged revision(s) 58410,58411.
-
- ri.1: rewrite ri man page
* man/ri.1: update the (very outdated) ri man page:
* update document date
* fix document title formatting and volume name
* update descriptions and options to current ri -... -
- ruby_2_4 r61369 merged revision(s) 59372.
-
- lib/net/imap.rb: Ignore trailing space for Microsoft Exchange Server
Based on the patch by keysen (Jeremy Carlier).
[ruby-core:81641] [Bug #13649]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_4@61369 b2dd... -
- ruby_2_4 r61368 merged revision(s) 58208.
-
- Add documents on Process::CLOCK_* constants
* process.c: Add documents on Process::CLOCK_* constants.
Patch by Sunao Komuro <sunao-komuro@cookpad.com>.
Closes [GH-1567] [Bug #13386]
git-svn-id: svn+ssh://ci.... -
- ruby_2_4 r61367 merged revision(s) 58146,58150,58156.
-
- error.c: refactor warning messages
* error.c (with_warning_string): extract building warning message
string from variadic arguments.
* error.c (syserr_warning): write warning message with the system
... -
- ruby_2_4 r61366 merged revision(s) 58409.
-
- ri.1: fix errors in ri man page
* man/ri.1: fix some errors in ri man page (add missing options,
remove options that do not exist, fix formatter list).
Reported by Josh Cheek. [ruby-core:68065] [Bug #10838]... -
- ruby_2_4 r61365 merged revision(s) 58020.
-
- date_core.c: fix error in DateTime docs
* ext/date/date_core.c: [DOC] fix format string for DateTime#rfc3339.
Reported by Andreas Rayo Kniep. [ruby-core:68418] [Bug #10936]
* ext/date/date_core.c: [DOC] ditto... -
- ruby_2_4 r61364 merged revision(s) 57887.
-
- lib/ostruct.rb: [DOC] revise docs for OpenStruct
* update paragraph on implementation:
define_singleton_method is used, not define_method
* add call-seq with return values for each_pair
* adopt descript... -
- ruby_2_4 r61363 merged revision(s) 57686.
-
- rational.c: fix rdoc
* rational.c: [DOC] fix wrong indentations and comment out some lines
in code examples to make them valid Ruby code and syntax highlighted
on the rendered page.
[ci skip] [ruby-c... -
- ruby_2_4 r61362 merged revision(s) 57536.
-
- doc: Add example for Symbol#to_s
* string.c: add example for Symbol#to_s.
The docs for Symbol#to_s only include an example for
Symbol#id2name, but not for #to_s which is an alias;
the docs should include... -
- ruby_2_4 r61361 merged revision(s) 57649,57651.
-
- array.c: finish_exact_sum
* array.c (finish_exact_sum): extract duplicate code from
rb_ary_sum.
array.c: check if numeric
* array.c (finish_exact_sum): add 0 and the initial value to check
i... -
- * iseq.c (rb_insn_operand_intern): show local variable name at
getblockparam/setblockparam too.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61360 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Applied in changeset trunk|r61359.
----------
raise error if value contains CR/LF in iniheader of initialize_http_header
like r59693, initialize_http_header also should raise error. [Bug #14208] -
- like r59693, initialize_http_header also should raise error.
https://twitter.com/DouweM/status/943441930142220289 -
- like r59693, initialize_http_header also should raise error. [Bug #14208]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61359 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- ruby_2_4 r61358 merged revision(s) 60182.
-
03:50 AM Bug #14009: macOS High Sierra and “fork” compatibility
- @nagachika thank you for the update! I am glad it hasn’t been forgotten. :)
-
- Thank you for your notice.
It's just due to my laziness that the backport has been delayed.
I will backport this soon. -
- Just for reference, people seem confused about the fact this patch hasn’t made it into Ruby 2.4.3; as far as I can tell it will only appear in version 2.5. Is a backport forthcoming or is the idea for people who need High Sierra compatib...
-
- configure.ac: link Foundation framework
* configure.ac (XLDFLAGS): link against Foundation framework and
let __NSPlaceholderDictionary initialize, to get rid of crash
after fork on macOS High Sierra. [ruby-c... -
09:51 AM Revision 677c539d (git): NEWS: update news for Psych
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61357 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61356 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61355 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61354 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
08:27 AM Bug #14207: Failed to build 2.5.0-rc1 on CircleCI
- patch にゴミが混ざっていたので差し替え
-
- copy_file_range の man みる限り EPERM は来なそうなので、こういう救いかたは出来ない事はないのだけれど…。
やはりその環境だと apt-get で降ってくるバイナリとかも同じ目にあいそうな気がするので Ruby だけで救うっていうのもなんかなーという気持ちがありますね。 -
- 補足すると、ビルド時 configure チェックしたところで結局新しいユーザーランドのパッケージマネージャから降ってくるバイナリはそういうのが含まれる可能性が高いので難しい話になってきた。
個人的にはホストより新しいカーネルを期待しているユーザーランドをコンテナで動かさないでください、という話になりそうで 3rd party issue にしたい気持ちが若干あります。
(本件、CircleCI って事で難易度たかそうですが…) -
- 1. ビルド環境にある unistd の __NR_copy_file_range のマクロの有無だけで判断している
2. ユーザーランドにある unistd は Docker 等コンテナホスト側のカーネルのバージョンなんて知らない
3. ビルドは copy_file_range システムコールが使えるものと信じて進行する
4. しかしビルドされたところでそんなシステムコールは存在しない訳なのでエラーになる
- `docker run --privile... -
03:39 AM Bug #14207: Failed to build 2.5.0-rc1 on CircleCI
- sorah (Sorah Fukumori) wrote:
> 手元で大丈夫な時の Linux カーネルバージョンって 4.5 以降ですかね?
はい、4.5 以降です。
~~~
tsuyoshi@wezen% uname -a
Linux wezen 4.14.0-1-amd64 #1 SMP Debian 4.14.2-1 (2017-11-30) x86_64 GNU/Linux
~~~
-
- 手元で大丈夫な時の Linux カーネルバージョンって 4.5 以降ですかね?
Ubuntu 16.04 および CircleCI (v2) は 4.4.0 系なので当該システムコールは動かないものの、Debian 9.x はそれより新しいのを想定しているはずなので、
まあちゃんと configure で見ましょうという感じがするな…。 -
- CircleCI の docker 上で ruby 2.5.0-rc1 をビルドしてみたらエラーになりました。
make 時に多くの拡張ライブラリが "Could not be configured. It will not be installed" となっていて、
fileutilsで "Operation not permitted - copy_file_range" というメッセージが出ていました。
~~~
linking ruby
make... -
- This change introduces get_insn_info_binary_search, which is (should be)
equivalent to the old get_insn_info.
The old get_insn_info is renamed to get_insn_info_linear_search. When
VM_CHECK_MODE > 0, the equivalence is validated at finis... -
- A follow up of r61350
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61352 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Sangyong Sim told me that 2.5's line coverage measurement was slower than 2.4 because of some reasons. I talked with ko1, and decided to revert the changes of line coverage (2.4 and 2.5 use a special event and special instruction for li...
-
- * lib/resolv.rb (Resolv::Config.parse_resolv_conf): fixed
potential command injection by use of Kernel#open.
[ruby-core:84347] [Bug #14205]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61351 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- 2.5's line coverage measurement was about two times slower than 2.4
because of two reasons; (1) vm_trace uses rb_iseq_event_flags (which
takes O(n) currently where n is the length of iseq) to get an event
type, and (2) RUBY_EVENT_LINE us... -
- Applied in changeset trunk|r61349.
----------
Fixed command Injection
* resolv.rb (Resolv::Hosts#lazy_initialize): fixed potential
command Injection in Hosts::new() by use of Kernel#open.
[Fix GH-1777] [ruby-core:84347] [Bug #14205... -
- * resolv.rb (Resolv::Hosts#lazy_initialize): fixed potential
command Injection in Hosts::new() by use of Kernel#open.
[Fix GH-1777] [ruby-core:84347] [Bug #14205]
From: Drigg3r <drigg3r@yandex.com>
git-svn-id: svn+ssh://ci.ruby-lan... -
- Typical code clone bug.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61348 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * test/ruby/test_process.rb (test_threading_works_after_exec_fail):
extend timeout limit from 30 to 90 because some test nodes fails
with timeout error.
Also use a Queue instead of a local variable to communicate with
threads.
... -
- It's a bug since 1.9, by "fluent style".
-
- Applied in changeset trunk|r61346.
----------
parse.y: end of script at newline
* parse.y (parser_yylex): deal with end of script chars just after
ignored newline as other places. [ruby-core:84349] [Bug #14206] -
- * parse.y (parser_yylex): deal with end of script chars just after
ignored newline as other places. [ruby-core:84349] [Bug #14206]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61346 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
12:01 AM Feature #13129: Refinements cannot refine method_missing and respond_to_missing?
-
- Currently, I feel negative about the proposal.
First, as Shugo commented, `method_missing` etc. are considered indirect method calls.
Second, mixing refinements (static rebinding) and `method-missing` (dynamic rebinding) are very com...
12/19/2017
-
05:09 PM Revision b37fc5aa (git): skip test_aspawn_too_long_path on Solaris 10 or earlier
- * test/ruby/test_process.rb (TestProcess#test_aspawn_too_long_path):
skip test_aspawn_too_long_path on Solaris 10 or earlier versions
because they lack Process::RLIMIT_NPROC and the test creates
extraordinary number of processes th... -
- Applied in changeset trunk|r61344.
----------
Workaround for optimization bug of Oracle Developer Studio 12.4-12.6
* pack.c (pack_unpack, AVOID_CC_BUG): Very ugly workaround for
optimization bug of Oracle Developer Studio (Oracle Sol... -
- Reopen because this is also observed with Oracle Developer Studio 12.6.
-
- * pack.c (pack_unpack, AVOID_CC_BUG): Very ugly workaround for
optimization bug of Oracle Developer Studio (Oracle Solaris Studio)
12.4, 12.5, and 12.6 on Solaris 10 with -xO4 optimization option.
[Bug #11684] [ruby-core:84351]
g... -
- I also applied @seki's fix in r61342.
- 03:40 PM Revision 8c34a8a1 (git): * 2017-12-20
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61343 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * Patch by @seki:
https://gist.github.com/seki/ae8bef20238c37c94a91b5461c4bfbdd
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61342 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
03:37 PM Bug #14206 (Closed): Null-byte ignored inside class/module/method bodies
- I would have expected the following code to not be accepted by the Ruby parser, but instead it acts as if the zero-byte wasn't part of the string.
~~~ ruby
eval("def m\n\0end")
~~~
Changing to a block to start with begin
~~~ r... -
02:26 PM Bug #14203 (Closed): miniruby crashes just after r61309 on mswin CI
- Applied in changeset trunk|r61341.
----------
Revert "Improve performance of creating Hash object"
This reverts commit r61309
Because it was unstable on mswin CI.
[ruby-dev:50370][Bug #14203] -
- 調査が難しそうなので、いったん r61309 は revert しておきます。お騒がせしました。
-
09:38 AM Bug #14203 (Assigned): miniruby crashes just after r61309 on mswin CI
-
- r61309 のマージ後、mswin CIで、minirubyがクラッシュするようになっています。
http://mswinci.japaneast.cloudapp.azure.com/vc12-x64/ruby-trunk/recent.html
手元で再現できてないので残念ながらまだ詳細はわかりませんが、とにかくヤバそうということで。 -
- This reverts commit r61309
Because it was unstable on mswin CI.
[ruby-dev:50370][Bug #14203]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61341 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- From: SHIBATA Hiroshi <hsbt@ruby-lang.org>
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61340 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- From: SHIBATA Hiroshi <hsbt@ruby-lang.org>
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61339 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * st.c (_st_table_list, _st_table_pool): symbols beginning with an
underscore and a lower letter are preserved by the standard.
* st.c (get_st_table): protoized.
* st.c (st_insert_generic): adjust local variable type to an
argument... -
- * thread_sync.c (define_thread_class): hide rb_define_class_under
from rdoc, so that fake code to teach rdoc takes effect.
* thread_sync.c (Init_thread_sync): teach rdoc Mutex.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61337 ... -
10:08 AM Bug #14205: Unsanitizied filename leads to command injection in 'resolv.rb'
- PoC Concept Code
~~~ ruby
require 'resolv'
a = Resolv::Hosts::new("|echo 1 > /tmp/rce")
a.getaddress("test")
~~~
-
- Here is the pull request
https://github.com/ruby/ruby/pull/1777 -
- It version changed fallback option to keywoad argument
on `Yaml.load` method. It break backword compatiblity.
see detailed discuttion: https://github.com/ruby/psych/issues/340
From: SHIBATA Hiroshi <hsbt@ruby-lang.org>
git-svn-id:... -
- ```
socket: use frozen string buffer when releasing GVL
Using a non-frozen string buffer when GVL is released is
dangerous because another thread may modify that buffer.
This may lead to the contents of an invalid pointer being
wr... -
- I updated gemspec at r61333.
But I couldn't ship strscan gem to rubygems.org:
https://github.com/rubygems/rubygems.org/pull/1696
If above pull request is not handled until Ruby 2.5 release, I will release strscan-1.0.0 in next y... -
- https://bugs.ruby-lang.org/projects/ruby-trunk/repository/revisions/19197
Matz's intention is very clear that this kind of expression shall render syntax errors. -
- * error.c (key_err_receiver, key_err_key): [DOC] documents of
KeyError methods.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61335 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * tool/vcs.rb (VCS::GIT#commit): no --add-author-from option if
author equals committer.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61334 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- But we couldn't ship strscan (and stringio) gem. Because rubygems.org
still masked them.
https://github.com/rubygems/rubygems.org/pull/1696
I'm going to ship them after it deployed.
From: SHIBATA Hiroshi <hsbt@ruby-lang.org>
gi... -
- It needs to support header file installation and uninstallation.
But current RubyGems didn't support it feature yet.
From: SHIBATA Hiroshi <hsbt@ruby-lang.org>
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61332 b2dd03c8-39d4-4d8... -
- * compile.c (compile_array): pop splat result without creating a
new hash if the whole hash is popped.
[ruby-core:84340] [Bug #14201]
From: Nobuyoshi Nakada <nobu@ruby-lang.org>
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@613... -
- When doing the difference of a small array with a big one it is not
efficient in both time and memory to convert the second one to a hash.
From: Ana María Martínez Gómez <ammartinez@suse.de>
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/... -
- Applied in changeset trunk|r61329.
----------
compile.c: side effect in splat
* compile.c (compile_array): splat which may have side effects
should be compiled even if the result will be popped.
[ruby-core:84340] [Bug #14201]
From... -
- * compile.c (compile_array): splat which may have side effects
should be compiled even if the result will be popped.
[ruby-core:84340] [Bug #14201]
From: Nobuyoshi Nakada <nobu@ruby-lang.org>
git-svn-id: svn+ssh://ci.ruby-lang.org/... -
12:30 AM Bug #13670: [BUG] Bus Error at 0xefce7b (armv7l) (ruby 2.3.4p301)
- Can confirm this occurs with 2.4.1, just install bootsnap and try and launch a rails application.
Tested on a H3 (armv7l) -
-
- `system` also accepts redirections.
And child processes inherit STDIN/STDOUT/STDERR from their parent process by the default, you don't need such arguments at all usually.
If you want to capture the outputs and the errors, `IO.popen(%w...
12/18/2017
-
08:54 PM Bug #14202 (Closed): gem install rails fails
- When running 'gem install rails' I get the attached error and printed core dump.
-
08:27 PM Bug #14201 (Closed): Regression due to over optimization of hash splat
- The following doesn't print anything nor raise anything in 2.5.0-rc1 or trunk:
```
$ ruby -e "{**puts('hello')}; 42"
```
It should be the same as in Ruby 2.0-2.4:
```
hello
-e:1:in `<main>': no implicit conversion of nil into ... -
06:01 PM Bug #14198: Error forwarding standard input to subprocess
- Using `Process.spawn` indeed works :) Unfortunately, I cannot figure out a way to forward the standard output and standard error to the console (i.e, STDOUT and STDERR) as well as storing that output in a variable.
The example in `tes... -
- I din't have a windows machine right now so not sure this is the solution for you. But JFYI you can reroute the IOs by specifying arguments to spawn like this:
```ruby
def exec(cmd)
pid = Process.spawn(cmd, in: STDIN, out: STDOUT... -
- I am developing a wrapper for Terraform (https://www.terraform.io/), which at some point during its execution, it may request user input. So, my application must forward everything typed on its stdin to the subprocess' stdin. The followi...
-
- ruby_2_4 r61328 merged revision(s) 59748.
-
- st.c: fix num_entries
* st.c (st_insert2): should manage num_entries when the key is
undefined, as well as st_insert().
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_4@61328 b2dd03c8-39d4-4d8f-98ff-823fe... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61327 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Applied in changeset trunk|r61326.
----------
Support C89 if possible
* addr2line.c: Because stdbool.h is a C99 feature, compile error
occurs with some old compilers without specifying C99 options.
Fix compile error with Oracle Sol... -
- r60841 にて、 addr2line.c では stdbool.h を使用するようになりましたが、
stdbool.h は C99 にて追加された仕様のため、
デフォルトが C89 になっている Solaris 10 上の古めのコンパイラの多くでは、
Solarisの標準ヘッダファイルに含まれるC標準バージョンチェックを通過できず、
以下のようなエラーになり、コンパイルに失敗します。
~~~
cc -errtags=yes -xO4 -xtarge... -
- * addr2line.c: Because stdbool.h is a C99 feature, compile error
occurs with some old compilers without specifying C99 options.
Fix compile error with Oracle Solaris Studio 12.4 on Solaris 10.
[Bug #14200] [ruby-dev:50366]
* missi... -
- とりあえず、ここ(redmine)で該当リビジョンを表示し、「関連するチケット」の「追加」をしてやれば、ここでの見た目上だけは、なんかうまくやったように誤魔化すことができます :)
(なお将来バックポートが必要とかになったときにメンテナが助かるので割と推奨) -
- Applied in changeset r61324
しかし、svnのコミットログに `[Bug #14199] [ruby-dev:50365]` を含めるのをうっかり忘れていました。 -
- おそらく r61154 以降、Solaris 10 上の Oracle Solaris Studio 12.4 にて、
下記のエラーにより eval.c のコンパイルに失敗します。
write_warn, write_warn2, write_warn_str の各マクロ定義中にて、
三項演算子「? :」の右側の2項（「AAA ? BBB : CCC」の BBB と CCC）の型が不統一、
具体的には void型を返す関数 と VALUE型を返す関数が混在し... - 03:46 PM Revision 5a2a9577 (git): * 2017-12-19
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61325 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * eval_error.c (write_warn, write_warn2, write_warn_str): Fix compile
error "operands have incompatible types" with Oracle Solaris Studio
12.4 on Solaris 10.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61324 b2dd03c8-39d4-4d8... -
03:27 PM Bug #13358: OpenStruct overriding allocate
- Any chance this could be backported to ruby 2.3? It's creating issues because we're loading OpenStruct from the database and Ruby 2.4 is still several months ahead for this project.
-
03:04 PM Feature #9992: Access Modifiers (Internal Interfaces)
- Sorry. The previous code was with a bug. I corrected it but here it is again:
What about this use case:
~~~ruby
module Foo; end
##
# Template class
#
# ==== Example
#
# Foo::SubClass.run(:arg1)
# ... -
- What about this use case:
~~~ruby
module Foo; end
##
# Template class
#
# ==== Example
#
# Foo::SubClass.run(:arg1)
# #=> ...
class Foo::Base
def initialize(arg)
@arg = arg
end
... -
- `#all?`, `#any?`, `#none?`, and `#one?` accept pattern arguments since 2.5.0.
`#grep`, and `#grep_v` have such feature, but it is hard for me to remember them since I would be thinking of using `#select`, or `#reject`, and `#select` a... -
-
09:11 AM Bug #14192: rb_frame_method_id_and_class not exported, breaks ruby-prof and other gems
- Assuming the method gets removed with 2.6, how should we replace it?
Can it be replaced now?
I haven't found a replacement for it. -
- Greg.mpls@gmail.com wrote:
> I tried the attached patch to remove the :uplevel parameter
> for ruby < 2.5, and it passed on Appveyor & Travis for Ruby
> 2.4. Assumes 2.10 never exists. Most Ruby 2.3 versions had
> one failure.
... - 08:54 AM Bug #14189 (Closed): Webrick 1.4.0. release requires unreleased ruby version 2.5.0dev
- Applied in changeset trunk|r61322.
----------
webrick 1.4.1 release
* lib/webrick/version.rb: bump version
* lib/webrick/webrick.gemspec: support Ruby 2.3+
[Bug #14189] -
- hsbt@ruby-lang.org wrote:
> Issue #14189 has been updated by hsbt (Hiroshi SHIBATA).
>
> Status changed from Open to Assigned
> Assignee changed from hsbt (Hiroshi SHIBATA) to normalperson (Eric Wong)
>
> >Personally, I do not l... -
- >Personally, I do not like version guards, either.
A current implementation of webrick works with Ruby 2.3/2.4
https://api.travis-ci.org/v3/job/317931661/log.txt
But `lib/webrick/util.rb` is not supported Ruby 2.2. So, We could ... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61323 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 08:54 AM Revision 74ceabb3 (git): webrick 1.4.1 release
- * lib/webrick/version.rb: bump version
* lib/webrick/webrick.gemspec: support Ruby 2.3+
[Bug #14189]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61322 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * test/ruby/test_io.rb (test_read_command): unusable character
causes Errno::EINVAL on Windows.
From: Nobuyoshi Nakada <nobu@ruby-lang.org>
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61321 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * io.c (rb_io_open_generic): try to open the named file as usual,
if klass is not IO nor File, so that Errno::ENOENT will be
raised probably. calling on File will be same in the future.
From: Nobuyoshi Nakada <nobu@ruby-lang.org>
... -
- * io.c (rb_io_s_binread): fix r61317, unintentional change.
From: Nobuyoshi Nakada <nobu@ruby-lang.org>
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61319 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Closing. Thanks anyway!
-
06:08 AM Bug #14196: Signal.trap overrides pre-existing "SIG_IGN" handler on a process
- shyouhei (Shyouhei Urabe) wrote:
> shayonj (Shayon Mukherjee) wrote:
> ...
Thanks! I realize that `Signal.trap` returns the previously set handler, though I didn't realize, we don't wish to preserve the previously set handler. I guess ... -
- shayonj (Shayon Mukherjee) wrote:
> I believe, if a process already has a `SIG_IGN` then the same should be respected/restore.
I don't think so. Signal handlers are per-prorcess global resources. If a program decides to set one, th... -
- Came across while debugging an issue with bundler https://github.com/bundler/bundler/issues/6150
The issue is, if a process already has a `SIG_IGN` / `IGNORE` present on it, then doing a `Signal.trap` overrides the handler on the same... -
05:15 AM Feature #14187: `make test` and `make check` to run all test suites
- I think it would be good to have a table for this proposal, with three columns:
1) What is tested
2) What is the target name currently
3) What is the proposed new target name
That will be much easier to understand than a lengthy desc... -
- nobu (Nobuyoshi Nakada) wrote:
> There would be old Makefile, remove it and retry.
I removed the Makefile. When I used my usual make command (make up unicode-up install-nodoc runnable), I got the following error:
```
GNUmakefile:... -
- * test/ruby/test_file.rb (test_open_tempfile_path): skip EOPNOTSUPP
(observed on Ubuntu 16 on Docker).
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61318 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * io.c (rb_io_open_generic): when external command will be invoked
as other than IO singleton method, probably unintentionally,
warn if it is File or raise ArgumentError.
From: Nobuyoshi Nakada <nobu@ruby-lang.org>
git-svn-id: svn+... -
- * test/lib/envutil.rb (verbose_warning): flush is called on STDOUT
and STDERR sometimes.
From: Nobuyoshi Nakada <nobu@ruby-lang.org>
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61316 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- From: Nobuyoshi Nakada <nobu@ruby-lang.org>
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61315 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * io.c (open_key_args): open by rb_io_open always also when
open_args: option is given.
From: Nobuyoshi Nakada <nobu@ruby-lang.org>
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61314 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- I have just fixed the issue. I'd appreciate if you could try r61313 and tell me if the coverage is measured correctly.
Your report was *really* helpful. Thank you very much! -
- Applied in changeset trunk|r61313.
----------
iseq.c (finish_iseq_build): fix coverage leakage [Bug #14191]
Before this change, coverage.so had failed to measure some multiple-line
code fragments. This is because removing trace instru... -
- Before this change, coverage.so had failed to measure some multiple-line
code fragments. This is because removing trace instructions (#14104)
changed TracePoint's lineno (new lineno), and coverage counter array was
based on old lineno.
... -
- From: Nobuyoshi Nakada <nobu@ruby-lang.org>
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61312 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61311 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- - Followup of https://bugs.ruby-lang.org/issues/14123
From: Prathamesh Sonpatki <csonpatki@gmail.com>
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61310 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Applied in changeset trunk|r61309.
----------
Improve performance of creating Hash object
When generate Hash object, the heap area of st_table will be always allocated in internally
and seems it take a time.
To improve performance of ... -
- watson1978 (Shizuo Fujita) wrote:
> > Any chances you tried --with-jemalloc ? It might perhaps exhibit something different.
> ...
Thank you! The patch seems perfect except one thing... ccan/list is already included in ccan/list/list.h... -
- When generate Hash object, the heap area of st_table will be always allocated in internally
and seems it take a time.
To improve performance of creating Hash object,
this patch will reduce count of allocating heap areas for st_table by ... -
- I think this is a feature but a bug.
https://github.com/nobu/ruby/tree/feature/13129-refine-method_missing -
12:35 AM Feature #8257: Exception#cause to carry originating exception along with new one
- Is there a reason not to do caused-by stack trace printing? Or has it just not been implemented by anyone yet?
-
- moskkitow (Marcelo Cruz) wrote:
> shyouhei (Shyouhei Urabe) wrote:
> ...
Yes please. That is exactly what I meant.
12/17/2017
-
- normalperson@yhbt.net wrote:
> I think some ext/socket methods (sendmsg, setsockopt) may need this, too;
> and fcntl/ioctl/getsockopt will need locktmp for strings...
N/M, *sockopt do not; but I think others do.
Will work on it la... -
- Since we release GVL, we must freeze a duplicate the string buffer
to prevent other threads from modifying our buffer while we
are waiting on pwrite(2).
* io.c (rb_io_pwrite): use_rb_str_tmp_frozen_{acquire/release}
Trivial bug... - 06:43 PM Revision 73da429c (git): `BASERUBY` may be not available when building from tarball
- * common.mk ($(REVISION_H)): revert a part of r61055 because this obstructs
building ruby from tarball in clean (no ruby) environment.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61308 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- When writing specs, I discovered that coercion was failing for allbits.
I modified all three methods to apply coercion with `to_int` if needed. - 06:19 PM Revision ae1d6cdd (git): * properties.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61307 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 06:19 PM Revision 22ee6b2c (git): * 2017-12-18
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61306 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 06:19 PM Revision 907508b2 (git): Integer#{any|all|no}_bits: Fix coercion. Add specs [#12753]
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61305 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Assuming `--enable-frozen-string-literal`, `ruby runner.rb cgi`
Running without patch:
```
1) Failure:
CGIMultipartTest#test_cgi_multipart_without_tempfile [E:/GitHub/ruby/test/cgi/test_cgi_multipart.rb:353]:
1. [2/2] Assert... -
04:51 PM Bug #14193: --enable-frozen-string-literal and rubygems, erb, & rdoc
- > I'd certainly appreciate it if someone familiar with RDoc had a look, as it seems that both its code and its tests may need changes/additions.
I believe RDoc upstream is https://github.com/ruby/rdoc and it's just copied from that pl... -
-
- k0kubun (Takashi Kokubun) wrote:
> > frozen_erb.patch
> ...
You're right; I was a bit frustrated while working on it, as some work has been done in Rdoc with frozen strings.
> While it's hard to understand the actual cause of the ... -
- > frozen_erb.patch
Thank you for your work to fix it, but I'm strongly against silently suppressing all StandardError exceptions. That makes very hard to find bugs other than ones you expected.
Also, note that frozen_string_literal... -
03:02 PM Feature #14142: Add Method#===
- 返信が遅れてしまいましたが、ありがとうございました。
-
- * common.mk (exts-note): show notes of non-configured extension
libraries.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61304 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * thread.c (timeval_add): adjusted indent and parenthesized in
braces.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61303 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- nobu@ruby-lang.org wrote:
> LGTM, and `timeval_add()` and `timeval_update_expire()` seem
> to worth extracting first.
Thanks for the review and you're right; they're not needed in
the final patch to fix the problem, I did not need... -
- LGTM, and `timeval_add()` and `timeval_update_expire()` seem to worth extracting first.
- 08:26 AM Revision db9523ef (git): thread.c: fix overly long Thread#join w/ timeout
- * test/ruby/test_thread.rb (test_signal_at_join): test with timeout
* thread.c (sleep_wait_for_interrupt): remove
(thread_join_sleep): use native_sleep directly to avoid extra
missing thread status change
[Bug #14181]
git-svn-id: ... - 08:26 AM Revision 78cc1491 (git): thread.c: hoist out timeval arithmetic functions
- timeval arithmetic may be reused in other places and this
makes sleep_timeval easier-to-read.
* thread.c (timeval_add): hoist out of sleep_timeval
(timeval_update_expire): ditto
(sleep_timeval): use new functions
git-svn-id: svn+ss... - 05:35 AM Revision 1389cdab (git): * 2017-12-17
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61300 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * vm_method.c (prepare_callable_method_entry): empty method table
has no entries.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61299 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * vm_method.c (method_definition_addref_complement): fix debug
message, show complemented_count instead of alias_count.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61298 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
12/16/2017
-
- A popular gem that I use for my doc site doesn’t currently test against MinGW trunk, but I’ve got a PR there for that. Noticed that the current CI’s were failing, and took a look.
One could debate the practicality of doing so, but fo... -
04:56 PM Bug #14159: [BUG] Segmentation fault at 0x0000000000000000 ruby 2.4.2p198 (2017-09-14 revision 59899) [x86_64-linux] - Mailcatcher
- shyouhei (Shyouhei Urabe) wrote:
> moskkitow (Marcelo Cruz) wrote:
> ...
Sorry for the delay on respond to this. I was really busy. What did you mean about contact the authors? To go after the eventmachine guys and see if they have a s... -
- > Any chances you tried --with-jemalloc ? It might perhaps exhibit something different.
I tried jemalloc at https://github.com/ruby/ruby/pull/1766#issuecomment-350553062
Just used jemalloc, I got a performance improvement 4.381M -> 7... -
- normalperson (Eric Wong) wrote:
> The thing is, ruby 2.4 and earlier do not have webrick installed as a
> ...
You're correct. Considering that I have Travis & Appveyor pages that show that info, I should have checked.
I tried the ... -
- Greg.mpls@gmail.com wrote:
> Eric,
>
> Looking over 61155, it does seem rather odd to constrain updates to WEBrick to ruby >= 2.5 for two warnings. Also, I believe WEBrick is the only gem affected by it. Don't know what your thoug... -
- Eric,
Looking over 61155, it does seem rather odd to constrain updates to WEBrick to ruby >= 2.5 for two warnings. I believe WEBrick is the only gem affected by it. Don't know what your thoughts are...
Also, re users not needing ... -
- * ruby.c (process_options): fallback to the encoding of the script
name since rb_realpath_internal() cannot convert the encoding
when it is ASCII-8BIT.
* test/ruby/test_rubyoptions.rb (test___dir__encoding): explicitly
pass enviro... -
- Applied in changeset trunk|r61296.
----------
vm.c: always export rb_frame_method_id_and_class
Functions declared in include/ruby/backward.h is exported only when
the condition `!defined RUBY_EXPORT && !defined RUBY_NO_OLD_COMPATIBILIT... -
- See https://github.com/ruby/ruby/commit/857827e3eed915543ac9d4d2541179ea4ded8eee
-
- rb_frame_method_id_and_class is currently available in the header files as deprecated, but the corresponding symbol is not exported from the library.
Witness the following compile and execution log excerpts:
~~~
../../../../ext/ru... -
- Functions declared in include/ruby/backward.h is exported only when
the condition `!defined RUBY_EXPORT && !defined RUBY_NO_OLD_COMPATIBILITY`
is met (i.e. included by include/ruby/ruby.h).
So if it is not the case when ruby is built, t... -
- no longer relevant
-
- Eric Wong <normalperson@yhbt.net> wrote:
> That might be correct, but I don't like making the sleep_*
> ...
Something like below (maybe more cleanups possible,
timeval is tedious to use...):
```diff
diff --git a/test/ruby/test_thr... - 06:05 AM Revision f319aa85 (git): should install after test
- * common.mk (love): should install after test (but this change does not gurantee
the order).
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61295 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 01:56 AM Revision d837e532 (git): aliases
- * tool/merger.rb: aliases for removetag command.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61294 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_4@61293 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- 開発者会議で議論し、GVL 開放せずにループで良いだろうということになりました。
そしてさきほど r61292 で修正したので閉じます。（コミットログに書き忘れました。すみません） -
- getrandom(2) and read(2) (from /dev/urandom) may return a random buffer
whose length is shorter than required. This change makes sure that they
get enough buffer by using a loop.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61292 ... -
- * test/ruby/test_vm_dump.rb (assert_darwin_vm_dump_works): gcc seems
not to chain some frames like Apple's clang.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61291 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * string.c (undump_after_backslash): fix multiple codepoints in
braces.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61290 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * string.c (str_undump): suppress maybe-uninitialized warning by
gcc 7 and later.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61289 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
12/15/2017
-
- Thank you for the report!
I found that #14104 changed TracePoint's lineno, which broke coverage.so. I'll fix it with ko1. -
06:52 PM Bug #14191 (Closed): Coverage decreased between 2.4.3 and 2.5.0rc1
- Just ran the test suite on my Rails app on the new rc and noticed that the coverage dropped by a full 3%. After some investigation discovered a lot of lines aren't being reported as covered anymore even though they clearly are. Here are ...
-
- I'm not familiar with $SAFE, but the scope seems finer:
```
$ ruby -e 'f = proc { $SAFE = 1; p [:in_proc, $SAFE] }; f.call; p [:out_of_proc, $SAFE]'
[:in_proc, 1]
[:out_of_proc, 0]
``` -
- $SAFE is documented in many places as thread-local, but it seems more than that.
For example:
# a.rb
$SAFE=1
p $SAFE
require "#{Dir.pwd.untaint}/b.rb"
# b.rb
p [:in_b, $SAFE]
gives:
$ ruby -r.... - 09:55 PM Revision d02f2996 (git): NEWS: update for WEBrick Proc body responses
- Better late than never :x [Feature #855]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61288 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 09:49 PM Revision 3ed8d398 (git): NEWS: updates about trivial GVL release changes
- No tickets, but all pretty trivial changes which avoids
stalls on slow/non-responsive filesytems.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61287 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 08:15 PM Revision 4eac6eb3 (git): lib/erb: Update doc [ci-skip] [doc]
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61286 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- shevegen@gmail.com wrote:
> Good catch.
>
> I guess the japanese hackers all happily use ruby 2.5.x already. :)
/me is not Japanese, but yes, I mainly use 2.5.x
> 2.4.3 was recently released. Guess it is a stable variant on t... -
- Good catch.
I guess the japanese hackers all happily use ruby 2.5.x already. :)
2.4.3 was recently released. Guess it is a stable variant on the
2.4.x branch.
Webrick at https://rubygems.org/gems/webrick has the ">= 2.5.0dev"
... -
12:20 PM Bug #14189 (Closed): Webrick 1.4.0. release requires unreleased ruby version 2.5.0dev
- Hi Team!
We have just encountered a blocking bug in the Webrick gem version 1.4.0.
The gemspec is requiring an as yet unreleased version of ruby:
Gem::InstallError: webrick requires Ruby version >= 2.5.0dev.
An error occurred whi... -
- I have difficulty opening the zip files on my linux box.
It tells me:
warning [/Depot/jjjj/passenger-log.zip]: zipfile claims to be last disk of a multi-part archive;
attempting to process anyway, assuming all parts have been c... -
10:01 AM Bug #14188 (Third Party's Issue): With install Ruby 2.4.3 and Passenger 5.1.12 ALL sites will fail to open
- With install Ruby 2.4.3 and Passenger 5.1.12 ALL sites will fail to open
https://github.com/phusion/passenger/issues/2010
Answer:
**Hi, this doesn't look like an issue with Passenger, but instead with Ruby, see the error message... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61285 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 05:44 PM Revision f941bdf2 (git): * 2017-12-16
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61284 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61283 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- It works for me. How did you test?
```
$ cat t.rb
p 1
return
p 2
$ ruby -v t.rb
ruby 2.4.2p198 (2017-09-14 revision 59899) [x86_64-linux]
t.rb:3: warning: statement not reached
1
$ /tmp/local/bin/ruby -v t.rb
ruby 2.5.0rc1 ... -
02:21 PM Feature #4840: Allow returning from require
- Could someone please explain me what is the current status of this feature? I thought I would be able to return from the top-level when requiring a file, but it still seems to be an invalid syntax to this day. Am I missing something?
-
- * tool/gperf.sed: comment out arguments part only, to keep the
following declarations static. [Feature #13883]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61282 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- mame (Yusuke Endoh) wrote:
> I think when a casual user build and install ruby, s/he will expect `make test` or `make check` to run all recommended test suites because many other projects uses them as the semantics.
Eregon (Benoit Da... -
- This looks good to me.
I think we should still have a way to run each of the 3 groups individually: "basic tests", test-all and test-spec.
I often run test/ and spec/ individually while working on MRI.
Specifically, I think test-all s... -
- Yes, I (mswin-build) will be critically affected by this change.
But I'll be able to fix it.
If you really believe that this is necessary, I'll not oppose.
My only hope is that the timing of the change is appropriate.
For example, ... -
- Currently, MRI has many test suites: "`bootstraptest/`", "`KNOWNBUGS.rb`", "`basictest/`", "`test/`", and "`spec/`". And, the target name design of `make` is really complicated:
* `make test` runs the first three suites
* `make test... -
- ko1 (Koichi Sasada) wrote:
> I reconsider about this line and
> ...
Ideally, I think referring to the documentation of Thread::report_on_exception directly would be the most helpful, so something like:
#<Thread:0x000055c6660d0b1... -
- (bikeshed)
Eregon (Benoit Daloze) wrote:
> #<Thread:0x000055c6660d0b10@report.rb:3 run> terminated with exception (report_on_exception is true):
I reconsider about this line and
`#<Thread:0x000055c6660d0b10@report.rb:3 run> termi... -
12:29 PM Feature #14177: PATCH: File::Stat#dev on Windows
- > I'm curious why/how do you use rdev/ino on Windows.
I don't have actual plan to use rdev/ino. Just curious about it.
> ...
If I don't misread it, does it means that rdev/ino read in a process
may be different from that in anothe... -
- Revert part of r61278 [Bug #13655]
[ci skip]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61281 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61280 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61279 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- This seems regression caused by Bug #13547
```
% RBENV_VERSION=2.3.5 ruby -c -e 'a [] {}'
Syntax OK
% RBENV_VERSION=2.3.5 ruby -c -e '1.upto 2 {|i|p i}'
-e:1: syntax error, unexpected '{', expecting end-of-input
1.upto 2 {|i|p i}... -
- Applied in changeset trunk|r61278.
----------
IO.new doesn't recive "-" as external_encoding [Bug #13655] -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61278 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- chucke (Tiago Cardoso) wrote:
> Bitten by this as well. I'd go the route proposed earlier:
> ...
HTML's encoding is definition is bit different from usual encoding converters as described at WHATWG Encoding Standard.
https://encoding.... -
08:19 AM Revision 42c4ca63 (git): openssl: suppress report_on_exception warning
- Import a commit from upstream:
33a67ac96492 test/utils: disable Thread's report_on_exception in start_server
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61277 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- nobu@ruby-lang.org wrote:
> normalperson (Eric Wong) wrote:
> > I guess the sleep_wait_for_interrupt path when !forever has the
> > same problem and might sleep too long..
>
> How about this patch?
That might be correct, but ... -
- normalperson (Eric Wong) wrote:
> I guess the sleep_wait_for_interrupt path when !forever has the
> ...
How about this patch?
```diff
diff --git i/thread.c w/thread.c
index cc62ea3905..138c26cb09 100644
--- i/thread.c
+++ w/thr... -
- Applied in changeset trunk|r61274.
----------
thread.c: fix deadlock
* thread.c (thread_join_sleep): the target thread may exit during
`RUBY_VM_CHECK_INTS_BLOCKING`, but `sleep_forever` does not
consider the condition change to wai... -
- nobu@ruby-lang.org wrote:
> It seems the signal trap causes thread switching then `Process.waitpid` exits.
> That means the target thread status can change during `RUBY_VM_CHECK_INTS_BLOCKING`, but `sleep_forever` doesn't consider the... -
- It seems the signal trap causes thread switching then `Process.waitpid` exits.
That means the target thread status can change during `RUBY_VM_CHECK_INTS_BLOCKING`, but `sleep_forever` doesn't consider the condition to wait at that momen... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61276 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * subscript out of range
* enumerated type mixed with another type
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61275 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * thread.c (thread_join_sleep): the target thread may exit during
`RUBY_VM_CHECK_INTS_BLOCKING`, but `sleep_forever` does not
consider the condition change to wait.
[ruby-core:84248] [Bug #14181]
git-svn-id: svn+ssh://ci.ruby-lang... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61273 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61272 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61271 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61270 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 03:22 AM Revision e13d347d (git): add `removetag` command
- * tool/merger.rb (remove_tag): add `removetag` command.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61269 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * thread.c (terminate_all): fix funtion name in debug messages.
* thread.c (terminate_all, thread_join_sleep, thread_join): show
the status of the target thread in debug messages.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@612... - 03:04 AM Revision 3b10f702 (git): check the existence of specified tag
- * tool/merger.rb (tag): check the existence of specified tag before tagging to
get rid of careless mistakes.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61267 b2dd03c8-39d4-4d8f-98ff-823fe69b080e