Activity
From 09/26/2017 to 10/02/2017
10/02/2017
-
08:09 PM Feature #13958: [PATCH] Dir.empty? releases GVL
- normalperson@yhbt.net wrote:
> https://bugs.ruby-lang.org/issues/13958
Updated with benchmark:
https://80x24.org/spew/20171002183339.30098-1-e@80x24.org/raw
Benchmarks from my old Pentium M 1.6GHz:
Benchmark results show a sm... -
01:11 PM Bug #13962: Change http://unicode.org to https
- shevegen (Robert A. Heiler) wrote:
> Secure our emojis! \o/
Yeah, I've lost a few nights' sleep worrying about that...
I've got a patch to `tool/downloader.rb` that outputs the file size and URI, and I noticed it doing a local bui... -
03:15 AM Bug #13962: Change http://unicode.org to https
- Secure our emojis! \o/
-
01:03 AM Bug #13962: Change http://unicode.org to https
- MSP-Greg (Greg L) wrote:
> I believe downloads from unicode.org can be done via https.
Yes, that seems to be the case. Let me check with my contacts at the Unicode Consortium to see what they prefer (in particular for large data down... -
12:23 PM Revision 4fb1438b (git): use rb_hash_new_with_size()
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60101 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * test/ruby/test_call.rb (test_safe_call): rhs should not be
evaluated when the receiver is nil. simplified the assertion
for [Bug #13964].
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60100 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
10:14 AM Bug #13917 (Assigned): Comparable#clamp is slower than using Array#min,max.
- The main topic "Comparable#clamp is slower than using Array#min,max." is valid.
@nobu Could you check the patch? -
- Applied in changeset trunk|r60099.
----------
compile.c: fix stack consitency error
* compile.c (iseq_compile_each0): fix stack consitency error on
attr-assign with safe navigation operator when the receiver is
nil, should pop it t... -
05:51 AM Bug #13964 (Closed): [BUG] Stack consistency error
- You get "[BUG] Stack consistency error" when you run attached 'bug_repro.rb'.
If you change line 44 in the script
option_draw&.weight *= 2
to
option_draw.weight *= 2 if option_draw
you get no error.
Also if you ... -
- * compile.c (iseq_compile_each0): fix stack consitency error on
attr-assign with safe navigation operator when the receiver is
nil, should pop it too. [ruby-core:83078] [Bug #13964]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk... -
07:51 AM Revision f5740d18 (git): Revert "vm_eval.c: add rb_yield_assoc_or_values()"
- This reverts commit r60095 to prevent performance degradation.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60098 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Applied in changeset trunk|r60097.
----------
io.c: check null char
* io.c (ruby_set_inplace_mode): check if null is contained. based
on the patch by tommy (Masahiro Tomita) in [ruby-dev:50272].
[Bug #13960] -
- * io.c (ruby_set_inplace_mode): check if null is contained. based
on the patch by tommy (Masahiro Tomita) in [ruby-dev:50272].
[Bug #13960]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60097 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * test/ruby/test_argf.rb (assert_src_expected): default line
number to caller's location.
* test/ruby/test_argf.rb (test_lineno, test_lineno2): get rid of a
bug of wrong indentation after $. in Emacs 25.3 ruby-mode.el
git-svn-id: s... -
- The new function rb_yield_assoc_or_values() will reduce branching.
* vm_eval.c: add rb_yield_assoc_or_values()
* internal.h: ditto
* hash.c: use rb_yield_assoc_or_values()
* struct.c: ditto
git-svn-id: svn+ssh://ci.ruby-lang.org/rub... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60094 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
01:57 AM Revision da4f041e (git): use `ra` instead of new variables.
- * file.c (rb_file_s_rename): `struct rename_args ra` already has members
which contain C ptrs. Pointed by MSP-Greg. Thanks!
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60093 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * file.c (rb_file_s_rename): src and dst are used only on DOSISH env.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60092 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
10/01/2017
-
- Like stat(2), lstat(2) can be expensive on slow filesystems and
should not block other threads. There should be a minor, but
not significant slowdowns in single-threaded performance similar
to benchmarks around the more-portable stat... -
09:29 PM Feature #13951 (Closed): [PATCH] File#rename releases GVL - Applied in changeset trunk|r60091.
----------
NEWS: entries for GVL release in File and Dir
(more to come)
* NEWS: updates for [Bug #13941] and [Feature #13951] -
- normalperson (Eric Wong) wrote:
> I consider the performance trade off acceptable as cases are avoided.
I agree that it would be small enough.
gcc for x86_64 warns:
```
file.c: In function 'no_gvl_rename':
file.c:2886:12: war... -
- normalperson@yhbt.net wrote:
> https://bugs.ruby-lang.org/issues/13951
Updated v2 with casts for 64-bit:
https://80x24.org/spew/20170929085016.9441-1-e@80x24.org/raw
(still using 32-bit for most dev work :x) - 09:29 PM Revision 6c29f232 (git): NEWS: entries for GVL release in File and Dir
- (more to come)
* NEWS: updates for [Bug #13941] and [Feature #13951]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60091 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 09:19 PM Revision 4e602696 (git): * properties.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60090 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 09:19 PM Revision 2270eb56 (git): * 2017-10-02
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60089 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 09:19 PM Revision e552afc3 (git): File#rename releases GVL
- rename(2) requires two pathname resolution operations which can
take considerable time on slow filesystems, release the GVL so
operations on other threads may proceed.
On fast, local filesystems, this change results in some slowdown
as ... -
- I believe downloads from unicode.org can be done via https.
See attached patch.
Thank you. -
03:01 PM Bug #13961 (Closed): String#unpack の warning メッセージが SHARABLE_MIDDLE_SUBSTRING=1 を考慮していない
- String#unpack で不正なディレクティブが指定された時のwarningメッセージが指定文字列ではなくNUL終端まで出力してしまいます。
```
% ruby -we '"hoge".unpack(("o"*100)[0,24])'
-e:1: warning: unknown unpack directive 'o' in 'ooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooo... -
- SHARABLE_MIDDLE_SUBSTRING=1 でコンパイルしたRubyで、ARGF.inplace_mode= がNUL終端まで文字列を使用してしまいます。
```
% echo hoge > hoge
% ruby -e 'ARGF.inplace_mode=(".abcdefghijklmnopqrstuvwxyz"*2)[0,27]; ARGF.each_line{|line| print line.sub("hoge","fuga")}' h... - 01:44 PM Revision f01846cd (git): * properties.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60087 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * string.c (rb_strseq_index): refactor and avoid
call of str_strlen() when offset == 0.
it will improve performance of String#index and #include?
* benchmark/bm_string_index.rb: benchmark for this change
git-svn-id: svn+ssh://ci.ru... -
05:36 AM Bug #13959 (Rejected): IO.write(filename, Marshal.dump(obj), :encoding => 'binary') != File.open(filename, 'wb') { |fil| Marshal.dump(obj, fil) }
- For some complex objects,
IO.write(filename, Marshal.dump(obj), :encoding => 'binary') and File.open(filename, 'wb') { |fil| Marshal.dump(obj, fil) }
can create different file content, and these files can't load each other by
... -
- * hash.c: use rb_hash_new_with_size().
* marshal.c: ditto
* struct.c: ditto
* vm_args.c: ditto
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60085 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- This converts all slow syscalls in the Dir.empty? implementation
to release GVL. We avoid unnecessarily GVL release and
reacquire for each slow call (opendir, readdir, closedir) and
instead only release and acquire the GVL once in th... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60084 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * tool/generic_erb.rb: -i option to merge multiple template files.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60083 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- xkernigh@netscape.net wrote:
> But I might have found a different bug. I did kill -ABRT a
> spinning child and gave the core dump to gdb; it seemed that
> both threads were stuck inside OpenBSD's thread library. The
> main thread wa... -
-
-
-
- * test/ruby/test_refinement.rb (test_dsym_literal): test for
r59946, interning dynamic symbol should not be affected by
refinements too.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60082 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 01:44 AM Revision dbb55956 (git): file.c: remove unnecessary volatile use
- For apply2files, all callers use the `path' VALUE for
generating exceptions, so there is no need to guard it.
In realpath_rec, RB_GC_GUARD is already used on link_orig.
In rb_check_realpath_internal, RB_GC_GUARD is necessary and
prefera...
09/30/2017
-
- xkernigh@netscape.net wrote:
> Anyone can use Gregory's sched_yield_loop.rb to check for the
> bug. If the weaker patch from Eric Wong fixes the bug for
> Linux, I suggest to put the weaker patch in trunk, and to
> backport it to ol... - 09:50 PM Bug #13794 (Closed): Infinite loop of sched_yield
- Applied in changeset trunk|r60079.
----------
thread_pthread.c: do not wakeup inside child processes
* thread_pthread.c (rb_thread_wakeup_timer_thread): check
ownership before incrementing
(rb_thread_wakeup_timer_thread_low): ditto... -
03:21 AM Bug #13794: Infinite loop of sched_yield
- Gregory Potamianos wrote:
> `while true; do nice -n19 ruby sched_yield_loop.rb; [ $? -ne 0 ] && break; done`
With your script, it is easy to reproduce the bug.
I shortened your shell loop to
`while nice -n19 ruby sched_yield_loop.r... -
- kernigh (George Koehler) wrote:
> I had an old Makefile before I pulled this change (rename configure.in to configure.ac). The old Makefile can't find configure.in. The fix is easy: run autoconf and ./configure to get a new Makefile.
... -
- I had an old Makefile before I pulled this change (rename configure.in to configure.ac). The old Makefile can't find configure.in. The fix is easy: run autoconf and ./configure to get a new Makefile.
The error from an old Makefile loo... - 09:50 PM Revision 000169c5 (git): * 2017-10-01
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60080 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 09:50 PM Revision b860f064 (git): thread_pthread.c: do not wakeup inside child processes
- * thread_pthread.c (rb_thread_wakeup_timer_thread): check
ownership before incrementing
(rb_thread_wakeup_timer_thread_low): ditto
[Bug #13794] [ruby-core:83064]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60079 b2dd03c8-39d... -
- SHARABLE_MIDDLE_SUBSTRING=1 でコンパイルしたRubyで、Readline.insert_text の文字列が正しく扱われません。
```
% ruby -rreadline -e 'p Readline.insert_text(("a"*100)[0,24]).line_buffer'
"aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60078 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- I believe the english equivalent to `not_nil` would be `exist` (instead of exists, to follow prev use). I believe core only uses `exist?` with `Dir`, `File`, and `FileTest`.
Having it would allow showing the standard case first in an... -
05:44 AM Feature #13395: Add a method to check for not nil
- I think `Array#nitems` is like this. But it was removed since ruby 1.9.1.
In doc/NEWS-1.9.1:
> o Array#nitems was removed (use count {|i| !i.nil?}) -
- Applied in changeset trunk|r60077.
----------
eval.c: check type
* eval.c (ignored_block): check argument type, which must be
Module. [ruby-dev:50270] [Bug #13956] -
11:32 AM Bug #13956 (Closed): Segmentation fault when calling Method#using with a non-module argument and block
- Module#usingをモジュールでない引数とブロックをつけて呼び出すとクラッシュします。
再現プログラムは以下です。
~~~ ruby
def using(x)
yield x
end
using(1){ }
~~~
元々、別のメソッドに**using**と名付けてそれを呼び出すコードを書いてました（Module#usingの存在は失念していました）。
なぜそうなるのか理解していないのですが、トップレベルで定義したメソッドは... -
- * eval.c (ignored_block): check argument type, which must be
Module. [ruby-dev:50270] [Bug #13956]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60077 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- st.c was improved in r56650 that it permits deletion during iteration.
In this commit, special treatments for previous implementation are
removed.
* hash.c: don't use *_check and *_safe functions in st.c
* internal.h: remove HASH_DELET... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60075 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60074 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * configure.ac: remove --enable-pthread option.
it was obsoleted in 2009.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60073 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60072 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Applied in changeset trunk|r60071.
----------
ext: check if null byte is contained
[ruby-dev:50267] [Bug #13953] -
- SHARABLE_MIDDLE_SUBSTRING=1 でコンパイルしたRubyで、GDBM.new が指定した文字列ではなく共有元の文字列終端までファイル名として使用してしまいます。
~~~
% ruby -rgdbm -e 'GDBM.new(("0123456789"*10)[0,24])'
% ls
0123456789012345678901234567890123456789012345678901234567890123456789012345... -
- [ruby-dev:50267] [Bug #13953]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60071 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- SHARABLE_MIDDLE_SUBSTRING=1 でコンパイルしたRubyで、NKF.nkf のオプション文字列が正しく扱われません。
```
% ruby -rnkf -e 'opt="--ic=UTF-8 --oc=EUC-JISX0213 -w"[0,28]; p opt; p NKF.nkf(opt, "あ").encoding'
"--ic=UTF-8 --oc=EUC-JISX0213"
#<Encoding:UTF-8>
```
... -
- SHARABLE_MIDDLE_SUBSTRING=1 でコンパイルしたRubyで Etc.getpwnam, getgrnam が共有元の文字列終端まで使用してしまいます。
```
% sudo useradd abcdefghijklmnopqrstuvwxyz
% ruby -retc -e 'p Etc.getpwnam("abcdefghijklmnopqrstuvwxyz")'
#<struct Etc::Passwd na... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60070 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60069 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * configure.ac: use m4_version_prereq to check
running autoconf version.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60068 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
03:31 AM Revision 917bc687 (git): test_find.rb: improve branch coverage
- * test/test_find.rb (test_to_path): add a test
for to_path conversion.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60067 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Applied in changeset trunk|r60066.
----------
string.c: fix ASCII-only on succ
* string.c (str_succ): clear coderange cache when no alpha-numeric
character case, carried part may become ASCII-only.
[ruby-core:83062] [Bug #13952] -
- * string.c (str_succ): clear coderange cache when no alpha-numeric
character case, carried part may become ASCII-only.
[ruby-core:83062] [Bug #13952]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60066 b2dd03c8-39d4-4d8f-98ff-82...
09/29/2017
-
- * template/sizes.c.tmpl (Init_limits): turned a K&R style
declaration into a prototype declaration.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60065 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 05:19 PM Revision da7303e5 (git): * 2017-09-30
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60064 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
05:19 PM Revision b5b2bd86 (git): test_etc.rb: fix test_getgrnam for duplicated group names
- * test/etc/test_etc.rb: Etc.getgrnam would not return the first entry in the order of Etc.group for duplicated group names.
follow-up: [Bug #6935]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60063 b2dd03c8-39d4-4d8f-98ff-823fe69b... -
01:46 PM Bug #13952 (Closed): String#succ not updating code range
- I'm seeing some strange behavior with `String#succ` and updating code ranges. I haven't yet traced the code to see what the culprit is, but I'm reproducing my findings here so they don't get lost (and maybe someone has a better idea of w...
-
- Applied in changeset trunk|r60062.
----------
configure.ac
* configure.ac: renamed configure.in. [Feature #13946]
* Makefile.in, common.mk, ext/rbconfig/sizeof/depend: use
configure.ac.
* README.ja.md, README.md: update document f... -
- colby@taplaboratories.com wrote:
> trunk is currently using `configure.in` - so i would like to
> propose we rename `configure.in` to be the preferred
> `configure.ac`. I think this is good and will help reduce
> confusion for anyon... -
- If there are no side effects of problems then this may be fine. I can't say
though since I know next to nothing about the various files used by GNU
autoconfigure. -
- * configure.ac: renamed configure.in. [Feature #13946]
* Makefile.in, common.mk, ext/rbconfig/sizeof/depend: use
configure.ac.
* README.ja.md, README.md: update document for configure.ac.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby... - 11:00 AM Feature #13943 (Closed): Use unpack1 instead of unpack(template)[0] in erb.rb
- Applied in changeset trunk|r60061.
----------
Use unpack1 instead of unpack and `[0]`
[Feature #13943][ruby-core:83027] -
- [Feature #13943][ruby-core:83027]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60061 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
10:20 AM Bug #13794: Infinite loop of sched_yield
- Hi,
We are also affected by this bug, running Debian's ruby 2.3.3p222. We are encountering it with Exec resources of puppet agents timing out and leaving stray processes on busyloop. We have tried to reproduce it but not with much suc... -
- rename(2) requires two pathname resolution operations which can
take considerable time on slow filesystems, release the GVL so
operations on other threads may proceed.
On fast, local filesystems, this change results in some slowdown... -
- Applied in changeset trunk|r60060.
----------
string.c: ASCII-incompatible is not ASCII only
* string.c (tr_trans): ASCII-incompatible encoding strings cannot
be ASCII-only even if valid. [ruby-core:83056] [Bug #13950] -
- * string.c (tr_trans): ASCII-incompatible encoding strings cannot
be ASCII-only even if valid. [ruby-core:83056] [Bug #13950]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60060 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Applied in changeset trunk|r60059.
----------
pack.c: unpack "M" may be ASCII only
* pack.c (pack_unpack_internal): set ASCII only properly on "M",
may be ASCII only. [ruby-core:83055] [Bug #13949] -
- * pack.c (pack_unpack_internal): set ASCII only properly on "M",
may be ASCII only. [ruby-core:83055] [Bug #13949]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60059 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Applied in changeset trunk|r60057.
----------
array.c: improve operations on small arrays
[Feature #13884]
Reduce number of memory allocations for "and", "or" and "diff"
operations on small arrays
Very often, arrays are used to filte... - 07:43 AM Revision b455b839 (git): * 2017-09-29
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60058 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- [Feature #13884]
Reduce number of memory allocations for "and", "or" and "diff"
operations on small arrays
Very often, arrays are used to filter parameters and to select
interesting items from 2 collections and very often these
collect...
09/28/2017
-
- For what it's worth, I may have the root cause of this wrong. It looks like setting to `CR_7BIT` might be designed to help out the `CHECK_IF_ASCII` macro. But that macro is invoked on a byte-by-byte basis, ignoring the result's encoding ...
-
- String#tr has a curious bit of code attributable to r22547, dating back to Ruby 1.9.2. It seems to blindly change the calculated code range from `CR_VALID` to `CR_7BIT`:
From `tr_trans` in `string.c`:
```
if (cr == ENC_CODERANGE... -
- I've noticed that `String#unpack` with the `'M'` directive can create strings that should be `CR_7BIT` as `CR_VALID`. The issue appears to have been introduced in r30542, which assumes that all `ASCII-8BIT` strings must be `CR_VALID`. It...
-
08:23 PM Bug #13948 (Closed): Segfault instead of recursion depth error
- Repro instructions:
~~~ ruby
# (using Ruby 2.4.2)
# 1. $ git clone git@github.com:thoughtbot/factory_girl.git && cd factory_girl
# 2. $ bundle install
# 3. Add the code snippet under spec/acceptance/recursion.rb
# 4. $ rspec sp... -
07:44 PM Bug #13947: Incorreсt string parsing in Date.parse
- shevegen (Robert A. Heiler) wrote:
> On my system ruby 2.4.2p198 (2017-09-14 revision 59899) [x86_64-linux] I get:
> ...
This isn't a bug, it's the result of the fact that `Date.parse` has always been deliberately loose in parsing (bac... -
- On my system ruby 2.4.2p198 (2017-09-14 revision 59899) [x86_64-linux] I get:
Date.parse('Some random string')
# ArgumentError: invalid date
Date.parse('Repellendus Sint sunt quae molestiae dolor illo inventore ea')
... -
04:33 PM Bug #13947 (Rejected): Incorreсt string parsing in Date.parse
- There is no exception when parsing random lorem ipsum string to date. But if parse any another string everithing works smoothly.
The income string is - "Repellendus Sint sunt quae molestiae dolor illo inventore ea"
[0] in erb.rb
- Thank you for showing benchmark result.
While the impact is not so large with that benchmark, this would be expected usage of #unpack1 and it's good for maintainability too. So I think "not being slower in benchmark" is enough for addin... -
- Using benchmark_driver gem, `unpack1(template)` is about 1.07x faster than `unpack(template)[0]`.
```
% cat url_encode.yml
prelude: |
require 'erb'
str = "Programming Ruby: The Pragmatic Programmer's Guide"
benchmark: ERB::U... -
- I think a benchmark would be great. There are some ruby hackers/devs that almost always add benchmarks to their changes, which I think is nice.
-
03:45 PM Feature #13884: Reduce number of memory allocations for "and", "or" and "diff" operations on small arrays
- I like the idea. Nobu, could you review?
Matz.
-
03:32 PM Feature #13884: Reduce number of memory allocations for "and", "or" and "diff" operations on small arrays
- Send request to Github https://github.com/ruby/ruby/pull/1709
- 01:56 PM Bug #13642 (Closed): MinGW - Bug::Win32::TestDln#test_check_imported & misc
- Applied in changeset trunk|r60056.
----------
test_dln.rb: fix path separator on MinGW
* test/-ext-/win32/test_dln.rb (TestDln#test_check_imported):
RbConfig::CONFIG["PATH_SEPARATOR"] is : which is a separator on
msys2 shell buildi... -
01:55 PM Revision ff6573b6 (git): test_dln.rb: fix path separator on MinGW
- * test/-ext-/win32/test_dln.rb (TestDln#test_check_imported):
RbConfig::CONFIG["PATH_SEPARATOR"] is : which is a separator on
msys2 shell building ruby. Use File::PATH_SEPARATOR ; on test.
[Bug #13642] [ruby-core:81623]
git-svn-id... - 01:43 PM Bug #13856 (Closed): MinGW / mswin intermittent failure in test/socket/test_socket.rb
- Applied in changeset trunk|r60055.
----------
io.c: fix segfault with closing socket on Windows
* io.c (fptr_finalize_flush): add an argument to keep GVL.
* io.c (fptr_finalize): adjust for above change.
* io.c (io_close_fptr): closing... -
- * io.c (fptr_finalize_flush): add an argument to keep GVL.
* io.c (fptr_finalize): adjust for above change.
* io.c (io_close_fptr): closing without GVL causes another
exception while raising exception in another thread. This causes
s... -
01:35 PM Feature #13946 (Closed): Rename configure.in to configure.ac
- Hello ruby team!
In my quest to learn about Ruby-lang's src i was reading through [autoconf's documentation](http://www.gnu.org/software/autoconf/manual/autoconf.html) and got a bit confused about where the autoconf script was for rub... -
- `File[&:basename]` and `File.&basename` are valid syntax already.
-
- A colon does too many things already, a ternary operator, a symbol literal, and a keyword argument.
-
12:07 PM Feature #12125: Proposal: Shorthand operator for Object#method
- Is it possible to use a single colon for this?
object:name
File:basename
URI:parse
As far as I can see (not far, really, I don't even know C), it is currently not used for anything. -
-
- Applied via svn 60047, [GitHub commit be4bfe4](https://github.com/ruby/ruby/commit/be4bfe4a85527c047e1010af09f7cb7c7b8bad9b)
Thanks Yui,
Greg
Okay to close? -
- Applied in changeset trunk|r60054.
----------
Net::HTTP.new: Support no_proxy parameter [Feature #11195] -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60054 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- To share with Net::HTTP. see #11195
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60053 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 09:20 AM Revision e4136c7b (git): * properties.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60052 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
09:19 AM Revision 52d2636f (git): Update to ruby/spec@691755d
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60051 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60050 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Implemented as r58798
-
- Sorry, no idea about therubyracer.
-
05:02 AM Bug #13942: Illegal instruction at 0xb66d6b3b ___bug
- nobu (Nobuyoshi Nakada) wrote:
> Have you asked the therubyracer's author?
no response -
- Have you asked the therubyracer's author?
-
-
- nobu (Nobuyoshi Nakada) wrote:
> Seems a problem related to therubyracer.
> ...
nobu (Nobuyoshi Nakada) wrote:
> Seems a problem related to therubyracer.
> ...
nobu (Nobuyoshi Nakada) wrote:
> Seems a problem related to therubyracer... -
- nksr (nk sr) wrote:
> this output happens while run
> ...
shevegen (Robert A. Heiler) wrote:
> Do you think you could try other ruby versions as well, just to see whether the bug is still there? It may give the ruby core team additio... -
- Seems a problem related to therubyracer.
```
-- C level backtrace information -------------------------------------------
/usr/local/bin/ruby(rb_vm_bugreport+0x4f8) [0x8023aa88] vm_dump.c:697
/usr/local/bin/ruby(rb_bug_context+0x4f... -
- * test/io/console/test_io_console.rb: flush to ensure the second
data is sent.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60049 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- I've updated the series to support FIBER_USE_NATIVE=0 (along
with the proposed fix for [Bug #13887]).
The primary change for FIBER_USE_NATIVE=0 platforms is to move
away from cross stack linked-list manipulation and use the
heap f...
09/27/2017
-
10:25 PM Feature #13943: Use unpack1 instead of unpack(template)[0] in erb.rb
- It should implicitly be faster, as it avoids the array creation, insertion, and dereferencing that occurs with:
m.unpack("C")[0]
However, a benchmark to quantify the difference would be nice to have. -
- Could you put benchmark result?
-
- I think `unpack1(template)` is faster than `unpack(template)[0]`.
Attached patch for `lib/erb.rb`. - 09:55 PM Revision d21aab2d (git): * 2017-09-28
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60048 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- by MSP-Greg <MSP-Greg@users.noreply.github.com>
fix https://github.com/ruby/ruby/pull/1708
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60047 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- ```
vm.c: fetch retval iff necessary
* vm.c (rb_vm_make_jump_tag_but_local_jump): get rid of fetching
retval when it is not used. it is necessary for local jump
state only.
```
This caused SEGV if an application which embe... -
- Do you think you could try other ruby versions as well, just to see whether the bug is still there? It may give the ruby core team additional information.
-
- this output happens while run
rake db:blabla(any)
-
- See bug-13942.log
-
- Available at https://github.com/ruby/ruby/pull/1708
'Devkit' is use with RubyInstaller builds, but not with RubyInstaller2 builds. On Appveyor, RubyInstaller2 builds are now being used for Ruby 2.4 forward.
So, removed DevKit from... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60046 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60045 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60044 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60043 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60042 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- > Does it work? :>
For several months. Used in Appveyor testing by rubygems/rubygems and ruby/spec. Hopefully, more in the future.
Easiest link to check status is https://ci.appveyor.com/project/MSP-Greg/ruby-loco/build/messages.... -
- * complex.c (rb_complex_infinite_p): get rid of overflow and
unnecessary multiplication.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60041 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * complex.c (rb_complex_finite_p): get rid of overflow and
unnecessary multiplication.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60040 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 01:01 AM Revision 9eed577c (git): * 2017-09-27
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60039 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60038 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
09/26/2017
-
- [Fix GH-1707]
Author: hkdnet <hkdnet@users.noreply.github.com>
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60037 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- [Fix GH-1706]
Author: hkdnet <hkdnet@users.noreply.github.com>
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60036 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
02:01 PM Bug #13790: rubyspec.org domain seems to be expired
- Yay! 👏
-
- Applied in changeset trunk|r60035.
----------
Make retries for Net::HTTP configurable [Feature #10674]
by stereobooster
fix https://github.com/ruby/ruby/pull/1654 -
- by stereobooster
fix https://github.com/ruby/ruby/pull/1654
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60035 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60034 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60033 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- This seems to be unreachable from first introduction at r21286.
In ERB implementation, `#empty?` is only called for each member of
return value of `String#scan`, and `ERB::Compiler::PercentLine` is never
returned from `String#scan`.
Al... -
11:34 AM Bug #13929: TypeError: no implicit conversion of XXXX into string
- I don't understand the problem clearly. Can you explain it ?
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60031 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- test/csv/test_features.rb:357: warning: assigned but unused variable - csv
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60030 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
09:00 AM Bug #13905 (Feedback): files in gemspec
-
- As you may know, `include` inserts the module in the inheritance hierarchy. In this case, `module Extensions` is inserted above `String` in the `using Refinary` scope. That means the lexical scope of `vegetables` and `potatoes` are diffe...
-
08:31 AM Feature #13923: Idiom to release resources safely, with less indentations
- tagomoris (Satoshi TAGOMORI) wrote:
> I prefer to get resources at once, but #7 looks to work well for my use case.
> ...
No, no plan to bundle it yet. These days it's getting hard to include a new standard library unless there are ve... -
04:52 AM Feature #13923: Idiom to release resources safely, with less indentations
- shyouhei (Shyouhei Urabe) wrote:
> We looked at this issue in a developer meeting today and nobu's library solution written in comment #7 was popular there.
> ...
I prefer to get resources at once, but #7 looks to work well for my use ... -
04:59 AM Revision 732fe801 (git): run-lcov.rb: support overwritten tmpdir path
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60029 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60028 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Applied in changeset trunk|r60027.
----------
Release gvl while doing (f)stat
At the moment rb_stat function is blocking. This patch changes the
behaviour to release the gvl while waiting for OS to return from
f(stat).
There is behavi... -
- wolf@wolfsden.cz wrote:
> https://bugs.ruby-lang.org/issues/13941
Thanks, I am OK with the minor slowdown to avoid pathological
case with slow/dead FS. I'm not sure what others think... -
12:10 AM Bug #13941 (Closed): File.exist? doesn't release gvl while waiting for (f)stat to return
- When using `File.exist?`, I noticed that it doesn't release gvl while waiting for system to return from (f)stat call. This causes issues on high-latency network drives, since it freezes whole mri while waiting for system to reach the oth...
-
- At the moment rb_stat function is blocking. This patch changes the
behaviour to release the gvl while waiting for OS to return from
f(stat).
There is behaviour impact, but not significant (times are for 100000
iterations):
$ ~/relea... -
- glass.saga@gmail.com wrote:
> The main purpose of IO#writev is to make a chance for users to
> write multiple buffers atomically, not to improve performance.
IO#write on Array#join result is atomic, too; but Array#join can
result ... -
- The main purpose of IO#writev is to make a chance for users to write multiple buffers atomically, not to improve performance.
-
-
- * test/drb/test_drb.rb (TestDRbLarge#test_02_large_ary): removed
unnecessary extra spaces which make the following parentheses an
expression.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60026 b2dd03c8-39d4-4d8f-98ff-823fe69b080e