Activity
From 09/21/2017 to 09/27/2017
09/27/2017
-
10:25 PM Feature #13943: Use unpack1 instead of unpack(template)[0] in erb.rb
- It should implicitly be faster, as it avoids the array creation, insertion, and dereferencing that occurs with:
m.unpack("C")[0]
However, a benchmark to quantify the difference would be nice to have. -
01:49 PM Feature #13943: Use unpack1 instead of unpack(template)[0] in erb.rb
- Could you put benchmark result?
-
12:56 PM Feature #13943 (Closed): Use unpack1 instead of unpack(template)[0] in erb.rb
- I think `unpack1(template)` is faster than `unpack(template)[0]`.
Attached patch for `lib/erb.rb`. - 09:55 PM Revision d21aab2d (git): * 2017-09-28
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60048 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
09:55 PM Revision be4bfe4a (git): Remove DevKit path, change zlib link
- by MSP-Greg <MSP-Greg@users.noreply.github.com>
fix https://github.com/ruby/ruby/pull/1708
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60047 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- ```
vm.c: fetch retval iff necessary
* vm.c (rb_vm_make_jump_tag_but_local_jump): get rid of fetching
retval when it is not used. it is necessary for local jump
state only.
```
This caused SEGV if an application which embe... -
04:15 PM Bug #13942: Illegal instruction at 0xb66d6b3b ___bug
- Do you think you could try other ruby versions as well, just to see whether the bug is still there? It may give the ruby core team additional information.
-
12:50 PM Bug #13942: Illegal instruction at 0xb66d6b3b ___bug
- this output happens while run
rake db:blabla(any)
-
- See bug-13942.log
-
02:33 PM Bug #13944 (Closed): Appveyor fix GitHub PR 1708
- Available at https://github.com/ruby/ruby/pull/1708
'Devkit' is use with RubyInstaller builds, but not with RubyInstaller2 builds. On Appveyor, RubyInstaller2 builds are now being used for Ruby 2.4 forward.
So, removed DevKit from... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60046 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
07:47 AM Revision dbb6e0a4 (git): improve grammar in documentation of Array#bsearch [ci skip]
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60045 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
05:27 AM Revision a59837dd (git): pty.c: shrink repeated device names
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60044 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60043 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60042 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- > Does it work? :>
For several months. Used in Appveyor testing by rubygems/rubygems and ruby/spec. Hopefully, more in the future.
Easiest link to check status is https://ci.appveyor.com/project/MSP-Greg/ruby-loco/build/messages.... -
- * complex.c (rb_complex_infinite_p): get rid of overflow and
unnecessary multiplication.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60041 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * complex.c (rb_complex_finite_p): get rid of overflow and
unnecessary multiplication.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60040 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 01:01 AM Revision 9eed577c (git): * 2017-09-27
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60039 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60038 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
09/26/2017
-
- [Fix GH-1707]
Author: hkdnet <hkdnet@users.noreply.github.com>
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60037 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- [Fix GH-1706]
Author: hkdnet <hkdnet@users.noreply.github.com>
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60036 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
02:01 PM Bug #13790: rubyspec.org domain seems to be expired
- Yay! 👏
-
- Applied in changeset trunk|r60035.
----------
Make retries for Net::HTTP configurable [Feature #10674]
by stereobooster
fix https://github.com/ruby/ruby/pull/1654 -
- by stereobooster
fix https://github.com/ruby/ruby/pull/1654
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60035 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60034 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60033 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- This seems to be unreachable from first introduction at r21286.
In ERB implementation, `#empty?` is only called for each member of
return value of `String#scan`, and `ERB::Compiler::PercentLine` is never
returned from `String#scan`.
Al... -
11:34 AM Bug #13929: TypeError: no implicit conversion of XXXX into string
- I don't understand the problem clearly. Can you explain it ?
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60031 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- test/csv/test_features.rb:357: warning: assigned but unused variable - csv
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60030 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
09:00 AM Bug #13905 (Feedback): files in gemspec
-
08:34 AM Feature #12533: Refinements: allow modules inclusion, in which the module can call internal methods which it defines.
- As you may know, `include` inserts the module in the inheritance hierarchy. In this case, `module Extensions` is inserted above `String` in the `using Refinary` scope. That means the lexical scope of `vegetables` and `potatoes` are diffe...
-
08:31 AM Feature #13923: Idiom to release resources safely, with less indentations
- tagomoris (Satoshi TAGOMORI) wrote:
> I prefer to get resources at once, but #7 looks to work well for my use case.
> ...
No, no plan to bundle it yet. These days it's getting hard to include a new standard library unless there are ve... -
04:52 AM Feature #13923: Idiom to release resources safely, with less indentations
- shyouhei (Shyouhei Urabe) wrote:
> We looked at this issue in a developer meeting today and nobu's library solution written in comment #7 was popular there.
> ...
I prefer to get resources at once, but #7 looks to work well for my use ... -
04:59 AM Revision 732fe801 (git): run-lcov.rb: support overwritten tmpdir path
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60029 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60028 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Applied in changeset trunk|r60027.
----------
Release gvl while doing (f)stat
At the moment rb_stat function is blocking. This patch changes the
behaviour to release the gvl while waiting for OS to return from
f(stat).
There is behavi... -
02:21 AM Bug #13941: File.exist? doesn't release gvl while waiting for (f)stat to return
- wolf@wolfsden.cz wrote:
> https://bugs.ruby-lang.org/issues/13941
Thanks, I am OK with the minor slowdown to avoid pathological
case with slow/dead FS. I'm not sure what others think... -
12:10 AM Bug #13941 (Closed): File.exist? doesn't release gvl while waiting for (f)stat to return
- When using `File.exist?`, I noticed that it doesn't release gvl while waiting for system to return from (f)stat call. This causes issues on high-latency network drives, since it freezes whole mri while waiting for system to reach the oth...
-
- At the moment rb_stat function is blocking. This patch changes the
behaviour to release the gvl while waiting for OS to return from
f(stat).
There is behaviour impact, but not significant (times are for 100000
iterations):
$ ~/relea... -
- glass.saga@gmail.com wrote:
> The main purpose of IO#writev is to make a chance for users to
> write multiple buffers atomically, not to improve performance.
IO#write on Array#join result is atomic, too; but Array#join can
result ... -
12:28 AM Feature #9323: IO#writev
- The main purpose of IO#writev is to make a chance for users to write multiple buffers atomically, not to improve performance.
-
-
- * test/drb/test_drb.rb (TestDRbLarge#test_02_large_ary): removed
unnecessary extra spaces which make the following parentheses an
expression.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60026 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
09/25/2017
-
- Does it work? :>
-
- I decided it was time to start an Appveyor MinGW build. It's rolling, starts builds at 0:00 JST and 12:00 JST (3 & 15 UTC). Using the [MSP-Greg/ruby-loco repo](https://github.com/MSP-Greg/ruby-loco). This weekend, I've used the builds...
-
10:30 PM Feature #13927: Integrate module_function as a core language type
- phluid61 (Matthew Kerwin) wrote:
> Sounds to me like you want a new type of object which is like `Module` but can't be `include`d. If that's the case, I'd suggest a name like `Library` or `Namespace`.
> ...
Yes, something like this :) ... -
01:11 PM Feature #13927: Integrate module_function as a core language type
- Sounds to me like you want a new type of object which is like `Module` but can't be `include`d. If that's the case, I'd suggest a name like `Library` or `Namespace`.
I'm still not sold on the value of the proposition. Maybe if its me... -
- shevegen (Robert A. Heiler) wrote:
> Rocifier, can you say which ruby you have had in mind primarily?
I hadn't thought about it, just wanted to see what people thought of the idea first initially. But now that you explain this, ver... -
- rocifier (Ryan O'Connor) wrote:
> Using ruby commercially we have discovered that modules are no longer serving their original intended purpose of mixins. Another usage of the module has been shoehorned by using module_function. We have... -
- * vm.c (rb_vm_jump_tag_but_local_jump): no longer used since
r51292.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60025 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * vm.c (rb_vm_make_jump_tag_but_local_jump): get rid of fetching
retval when it is not used. it is necessary for local jump
state only.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60024 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- It's a bug in 2.4.0 and 2.4.1 only.
Braces just after a literal has caused a syntax error before, like as:
danielpclark (Daniel P. Clark) wrote:
> I apologize I wrote that earlier with a different error message. Here's what importi... -
09:19 PM Bug #13939: Ruby 2.4.2 has issue supporting Seattle.rb style for define_method
- > Perhaps the error message could be more indicative of the error or what the exact
problem is or how to solve it. I understand that the () provide additional information
that is in some way useful to the parser, or whatever is respons... -
09:10 PM Bug #13939: Ruby 2.4.2 has issue supporting Seattle.rb style for define_method
- I think this was introduced in https://github.com/ruby/ruby/commit/9987109
Basically, any call `foo arg { }` when `arg` is a literal now gives an error.
I think this is a huge breaking change, for example if you had something like:... -
- Let's ignore the "Seattle.rb style" for the moment because I don't know of such a
thing - may well be seattle-duck style. :P
But anyway, I agree with you in at the least one point, which is the warning message:
> Anyone who tries ... -
- In Ruby 2.3 & 2.4.0 you can do this
~~~ruby
define_method :some_method_name { "asdf" }
~~~
As of my trying 2.4.2 this is no longer supported. Anyone who tries to load my 'read_source' gem will get a failure message in require wi... -
06:47 PM Feature #13923: Idiom to release resources safely, with less indentations
- shyouhei (Shyouhei Urabe) wrote:
> We looked at this issue in a developer meeting today and nobu's library solution written in comment #7 was popular there.
> ...
fwiw, combined with new #12906, comment #7 makes me happy. -
- We looked at this issue in a developer meeting today and nobu's library solution written in comment #7 was popular there.
Is that OK for you, or you still want a new syntax than a library (and if that is the case; can you tell us why)? -
- naruse@airemix.jp wrote:
> As far as I understand, curses has still no active maintainer.
I am willing to maintain curses on Free Software platforms using
only Free Software, with no GUIs (because curses and Ruby
itself has no GUI... -
- As far as I understand, curses has still no active maintainer.
Ruby intends to keep wide portability; it's tough work especially for curses, the tty thing.
CRuby project gave up to maintain curses under such circumstances.
Separate ... - 05:38 PM Revision 4ea46ca0 (git): * 2017-09-26
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60023 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- patched by MSP-Greg <MSP-Greg@users.noreply.github.com>
fix https://github.com/ruby/ruby/pull/1702
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60022 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- We CRuby project doesn't handle em-http-request.
Could you ask on https://github.com/igrigorik/em-http-request ? -
04:55 PM Bug #13940 (Third Party's Issue): em-http-request (HttpConnectionOptions) over-write :sni_hostname if provided
- Breaking change introduced in 1.1.4
http_connnection_options.rb:23
@tls[:sni_hostname] = ori.host
This OVER-write the sni_hostname value which MAY have been passed in.
# Suggested Change to SET sni_hostname ONLY IF not provided
... -
04:26 PM Feature #13602 (Rejected): Optimize instance variable access if $VERBOSE is not true when compiling
- ko1 (Koichi Sasada) wrote:
> It seems 5% can not justify this kind of optimization.
> ...
I think this can be rejected then. Reverting the optimized instructions would require compiling both the unoptimized version and the optimized v... -
06:34 AM Feature #13602 (Feedback): Optimize instance variable access if $VERBOSE is not true when compiling
- It seems 5% can not justify this kind of optimization.
We can use your technique when we revert all of optimized instructions when $VERBOSE was changed. But I'm not sure this kind of modification is valuable than implementation cost (... -
- Applied in changeset trunk|r60021.
----------
HTTPHeader#add_field should allow binary [Bug #13926] -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60021 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- And refactoring.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60020 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- And now mruby does too.
Matz.
-
- We looked at this at a developer meeting today and confirmed that this is already done.
-
- This sounds in fact cleaner. However I'm afraid it is too difficult to design a transition path. Fiber#[] could be okay but changing Thread#[] seems almost impossible... Can we warn users about such change in some way?
-
- In the today's developer meeting Ko1 said that migrating fibers across threads is currently not possible. I think he would like to explain why, so let me assign this issue to him.
-
- I think it's hard to have platform-specific API extensions like this to be in-core. If atomicity is such an important feature (and I'm sure it is), it's hard to emulate this in pure-userland for people without OS that support it.
Thi... -
- nobu (Nobuyoshi Nakada) wrote:
> Glass_saga (Masaki Matsushita) wrote:
> ...
I think both `exchange:` and `noreplace:` are difficult to understand for an outside user. I think `overwrite:` is much easier to understand. -
- The proposed functionality sounds fine but no one currently have spare time to implement this; patch welcomed.
-
08:27 AM Feature #13677 (Feedback): Add more details to error "Name or service not known (SocketError)"
-
- It sounds fine.
-
- We looked at this issue at a developer meeting today.
The OP's intension is clear. We can describe how it works, but that seems to be different from how it _should_ work. Matz was there at the discussion so he understands the situat... -
- chucke (Tiago Cardoso) wrote:
> module Refinary
If possible, please change the spelling to "Refinery". -
- In following example, `ruby -w` warns `alias_after_def` and `duplicated_def` only, but rubocop warns all combinations.
```
% cat /tmp/a.rb
#!/usr/bin/ruby -w
class Foo
def m
end
def alias_after_def
end
alias alia... -
- Let me close this issue because its goal is too vague to be achieved. For instance if someone wants to add Nokogiri to core, please file a specific issue to request such thing.
-
- We looked at this issue in a developer meeting today. It seems we need to define "fatality" of each situations for requiring a library. For instance, ENOENT seems less fatal than EACCESS. For ENOENT situation we can silently ignore th...
-
- We looked at this issue several times in recent developer meeting and it seems okay to merge.
-
- It needs to keep maintainability with original Onigmo/Oniguruma.
-
- Ruby has all kinds of features that allow a programmer to look at internals, in particular for debugging. However, one important part of Ruby, regular expressions, don't have any such features yet.
Onigmo, the regular expression engin... -
- Hmm, I don't like the name `single`. Besides that, I think it may be useful for database access, but I don't see the use-case of this method for generic Enumerable.
Matz.
-
- shevegen (Robert A. Heiler) wrote:
> Martin showed this example:
> ...
Sorry, I should have used another example than Array. This issue is about aliasing class methods, and aliasing a method in a builtin class would be a problem whethe... -
- As Martin-sensei pointed out, use singleton class notation.
class Foo
class <<Foo
def foo; end
alias bar foo
end
end
I don't think it's worth adding a new method to avoid this simple thing.
Matz.
-
- We quickly discussed this issue at today's Ruby committer's meeting.
For everybody, converting exponential (scientific) notation to integer looked strange. Exponential notation is usually used to express very large numbers or very sma... -
- Is there benchmark?
What the situation that writev is actually fast? -
08:30 AM Misc #13915 (Closed): Updated docs of ThreadGroup
-
- fixed via https://github.com/ruby/ruby/pull/1700
applied in changeset r60016 -
- normalperson (Eric Wong) wrote:
> Fwiw, I'm also not convinced String#<< behavior about changing
> ...
This behavior may not be the best for this specific case, but in general, if one string is US-ASCII, and the other is UTF-8, then... -
- At the developer meeting, we discuss that byteslice! and byteslice method should take same arguments.
-
- Sounds OK to me.
Matz.
-
- The proposed solution seems to be too generic. Show us the use-case except for `nil for nil'. For example, it is acceptable that `allow_nil: true` keyword argument we see in ActiveSupport.
Matz.
-
- Applied in changeset trunk|r60019.
----------
Fix overflow detection for LLP64 arch [Bug #13748]
FIXNUMs are expected to fit into a long type, but the test is about a
VALUE type. Since long is < than VALUE on LLP64, the overflow is not... -
- FIXNUMs are expected to fit into a long type, but the test is about a
VALUE type. Since long is < than VALUE on LLP64, the overflow is not
detected. As a result "2**31" evaluates to "-2147483648" on Windows with
gcc-7.1.0.
patched by Lar... -
- Eregon (Benoit Daloze) wrote:
> vo.x (Vit Ondruch) wrote:
> ...
Therefore use `Process.pid` instead. -
-
- How about bufoffset?
-
- I like the idea but do not like the name `off_out`. Any other candidate?
Matz.
-
- Applied in changeset trunk|r60018.
----------
configure.in: install_name without teeny
* configure.in (RUBY_API_VERSION): remove teeny from install_name
to allow link extension libraries for the same minor version.
patched by kimur... -
- * configure.in (RUBY_API_VERSION): remove teeny from install_name
to allow link extension libraries for the same minor version.
patched by kimuraw (Wataru Kimura) at [ruby-dev:50262].
[Bug #13931]
git-svn-id: svn+ssh://ci.ruby-lan... -
- `Thread#current` should be enough.
-
- Applied in changeset trunk|r60017.
----------
Time#at receives 3rd argument which specifies the unit of 2nd argument [Feature #13919] -
- I agree with the new behavior (except for accepting `nil` as a unit).
Matz.
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60017 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- patched by Herwin [Fix GH-1700]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60016 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- `Array#{min,max}` are optimized because they are used frequently. I don't think `clamp` is used that much.
Matz.
-
- Hanmac (Hans Mackowiak) wrote:
> i can explain why Array#min/max isn't much slower, because it was optimized to not create Array overhead WHEN using variables
> ...
It's expected behavior.
doc/NEWS-2.4.0 says
```
* In some conditi... -
- In addition to what Matthew and Yui said, I have some more questions:
What about files with more than one module, or with code outside a module and code inside the module?
Are you planning to have actual content e.g. in Latin-1 in ... -
- lucascaton (Lucas Caton) wrote:
> Ruby allows us to access an array item by passing its index, regardless if there is or not a space between the array and the [] with the index.
> ...
This isn't a bug, you just need to understand how t... -
03:29 AM Bug #13937 (Rejected): ARGV doesn't behave like an array
- Ruby allows us to access an array item by passing its index, regardless if there is or not a space between the array and the [] with the index.
Ie.: both of the following lines work:
~~~ ruby
[][0] # nil
[] [0] # nil
~~~
**ARGV... -
12:09 AM Revision 5d12e826 (git): test/ruby/test_iseq.rb: Skip test_safe_call_chain if Coverage is running.
- Follow up to r59990.
When Coverage is running, trace2 instructions are inserted
to take branch coverages for safe method invocations.
This insertion makes safe call chains unable to be optimized
and breaks this test case.
So we test it o...
09/24/2017
-
05:14 PM Feature #13933: Add Range#empty?
- Range mixes in Enumerable so you can use #none?.
~~~
('a'..'b').none? #=> false
('b'..'a').none? #=> true
~~~
-
02:33 PM Feature #13933: Add Range#empty?
- Note that `Range#size` currently returns `nil` for ranges of string, so it's not clear what `empty?` would return for ranges of strings.
-
- Would be nice.
-
11:17 AM Feature #13933 (Rejected): Add Range#empty?
- Range already responds to #size. It would be nice if it also responded to predicate #empty? :-)
-
04:54 PM Bug #13935 (Closed): Backport openssl v2.0.7
- ruby_2_4 maintainer:
The attached patch (0001-openssl-import-v2.0.7.patch) updates the bundled openssl gem from v2.0.5 to v2.0.7. It applies on top of current ruby_2_4 (r60626). All changes are already in trunk as part of v2.1.0.
h... - 04:26 PM Revision fc8bacf9 (git): * 2017-09-25
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60014 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Sync with master branch of ruby/openssl.git to import changes in
v2.1.0.beta1..v2.0.6. The commit log since v2.1.0.beta1 which was
imported by r59734 can be found at:
https://github.com/ruby/openssl/compare/v2.1.0.beta1...e72d96... -
- If it's a method, that means you have to parse the file and execute it, before you can know how to parse it ..?
-
- Hello ruby-core team and everyone else,
I propose a "project-wide encoding" or a "toplevel namespace wide encoding".
I'll soon explain what I mean there; but first, allow me to start with a
problem description or more, a slight i... -
01:26 PM Feature #13923: Idiom to release resources safely, with less indentations
- IMHO this defer idea is not appropriate to manage resources at it just moves the release of the resources at the end of the method.
But this is often not appropriate or later than needed.
A block captures more explicitly the scope in w... -
- How about:
```ruby
class Deferred
def initialize
@list = []
yield self
ensure
@list.reverse_each do |res, clean|
clean.(res)
end
end
def defer(res = true, &clean)
@list << [res, clean||CLOS... -
- While `ensure` in ruby is a syntax and share the scope, `defer` in go dynamically registers the clean-up code with capturing local variables implicitly.
So a `defer` in a loop may registers multiple times with different objects, or may ... -
12:36 PM Feature #13884: Reduce number of memory allocations for "and", "or" and "diff" operations on small arrays
- Can anyone review this patch?
-
12:10 PM Bug #13887: test/ruby/test_io.rb may get stuck with FIBER_USE_NATIVE=0 on Linux
- normalperson (Eric Wong) wrote:
> s.wanabe@gmail.com wrote:
> ...
Thank you for your advice. I didn't care about callcc.
Your refined patch [ruby-core:82925] looks good for me, but I want to hear the opinion of Evaluator Maintainer ju... -
- * common.mk (exe/ruby): force link exe/ruby with miniruby.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60012 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * test/ruby/test_gc.rb (TestGc#test_expand_heap): relax the
criterion and compare by epsilon.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60011 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * test/rubygems/test_gem.rb: load rubygems.rb explicitly, for the
case configured as --disable-rubygems.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60010 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60009 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * tool/sync_default_gems.rb: removed ubygems.rb from sync target.
* test/rubygems/test_gem.rb: only enable "-rubygems" option when
running under the Ruby 1.9.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60008 b2dd03c8-39d4-4... -
- * load.c (rb_load_protect): fix the condition to load the found
file. fixup of r59155.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60007 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * ruby-runner.c (insert_env_path): extracted the function which
insert path list to an environment variable.
* ruby-runner.c (main): append library paths to RUBYLIB.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60006 b2dd03c8-39... -
01:45 AM Feature #5481: Gemifying Ruby standard library
- Hi, I have some feedback implying a possibility of unexpected dependency on features packaged in Ruby installation when their gem versions are intended to be used.
I use Bundler v1.13.7 provided by CentOS SCL. The version always uses ... -
- * common.mk (exe/ruby): make fixed name symbolic link exe/ruby to
exe/$(PROGRAM), to run hardcoded bundler tests.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60005 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
09/23/2017
- 11:58 PM Revision 846311a4 (git): * 2017-09-24
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60004 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Add `assert_coverage` to invoke Ruby script under coverage measurement
and to compare the result with an expected value.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60003 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- As I asked matz about the intention and then committed, this has not been backported yet.
WARNING: the condition that "Status = Closed" and "Backport is REQUIRED" is the trigger to backport, it will never get backported if you change ... -
- I wanted to write a reply but it was too long, so here just a shorter one.
Even new syntax may make a language more complex but also simpler at the same time.
People may have to learn/understand what a concept means in a language. Ne... -
- v.ondruch@tiscali.cz wrote:
> normalperson (Eric Wong) wrote:
> > Oh, check the *_STACK_SIZE #defines in vm_core.h for what the
> > defaults are, and maybe binary search until you find something
> > which works/breaks. I made t... -
- s.wanabe@gmail.com wrote:
> I guess `cont->machine.stack_src` should not contain the under thread_start_func_1() stack.
> Because this area will be used and overwritten by pthread, especially stack_list_{add,del} in nptl/allocatestack... -
- Extension libraries take precedence in checks of later `Kernel.#require` calls for features without file extensions. That behavior is inconsistent with the first call, and can cause problems.
For instance, feature `openssl` has `opens... -
11:45 AM Bug #13931 (Closed): correct install_name of libruby on macOS (libruby.2.5.0.dylib -> libruby.2.5.dylib)
- ruby-dev:50256 で質問した件です。
ruby-2.4以降ではlibrubyのファイル名に実際のリリースバージョンのTEENYが反映されるようになったようですが
macOS上でlibrubyのinstall name(linuxでのsoname相当)がTEENYを含んだもののため、
rubyを2.4.1から2.4.2など更新すると以前のバージョンで作成した拡張ライブラリでLoadErrorが発生します。
linuxなどではsonameをTEE... -
- default gems の `Gem::Specification#files` は記載されていても、実際には処理されないので、便宜上 upstream または gem としてリリースされているファイルを記載するようにしています。
こうした方が良い、という提案はありますか? -
- * string.c (rb_str_split): return duplicated receiver, when no
splits. patched by tompng (tomoya ishida) in [ruby-core:82911],
and the test case by Seiei Miyagi <hanachin@gmail.com>.
[Bug#13925] [Fix GH-1705]
git-svn-id: svn+ssh:... -
- * string.c (rb_str_rpartition): return duplicated receiver, when
no splits. [ruby-core:82911] [Bug#13925]
Author: Seiei Miyagi <hanachin@gmail.com>
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60001 b2dd03c8-39d4-4d8f-98ff-8... -
- * string.c (rb_str_partition): return duplicated receiver, when no
splits. [ruby-core:82911] [Bug#13925]
Author: Seiei Miyagi <hanachin@gmail.com>
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60000 b2dd03c8-39d4-4d8f-98ff-82... -
- * parse.y (parse_ident): leave identifier type decision (local or
const) to rb_enc_symname_type, and set the token type by ID
type.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59999 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * parse.y (stmt_or_begin): fix missing semicolon.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59998 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
06:43 AM Bug #13925: string.split(pattern, 1) should return [self.dup], but it returns [self]
- I added some tests and send a Pull Request to ruby/ruby
https://github.com/ruby/ruby/pull/1705 -
- * spec/bundler/other/*: Marked exclude tags for ruby repository.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59997 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59996 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * ext/psych/yaml/LICENSE: Integrate libyaml license to LEGAL and
removed this file from repository.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59995 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59994 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59993 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59992 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 12:17 AM Revision 4b5fb69e (git): * 2017-09-23
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59991 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59990 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
09/22/2017
-
- chucke (Tiago Cardoso) wrote:
> I have something similar to the following code that handles both tcp as well as ssl sockets. The idea is to use the #read_nonblock API which uses a buffer when passed in the argument (instead of creating ... -
05:14 PM Bug #13736 (Feedback): ruby -00 should be the same as setting $/=""
- Try:
$ printf "1\n1b\n\n\n\n\n2\n2b\n\n3\3b" | ruby -00 -F"\n" -lane 'END{p $.}'
4
vs
$ printf "1\n1b\n\n\n\n\n2\n2b\n\n3\3b" | ruby -F"\n" -lane 'BEGIN{$/=""}; END{p $.}'
3
vs
$ printf "1\n1b\... -
- This does not seem to be corrected on ruby 2.4.2p198 (2017-09-14 revision 59899) [x86_64-darwin16]
Exactly the same results as before. -
02:31 PM Bug #13930 (Closed): Exception is caught in rescue above ensure
- Given the following code:
~~~ ruby
def foo
i = 0
3.times do |n|
begin
puts "a"
i += 1
next if i > 1
puts "b"
rescue => e
puts "rescue in foo, caught #{e}"
ensure
puts "en... -
02:28 PM Bug #13757: TestBacktrace#test_caller_lev segaults on PPC
- normalperson (Eric Wong) wrote:
> v.ondruch@tiscali.cz wrote:
> ...
I passes with 262144 but fails with 131072. Should I try to find some value in between?
-
- I need to raise LocalJumpError here (for the first "J" of the
output "JUST ANOTHER RUBY HACKER"), but this `return` does
not raise error in Ruby 2.4.
[Fix GH-1703]
Author: Yutaka HARA <yutaka.hara+github@gmail.com>
git-svn-id: svn+s... -
- matz (Yukihiro Matsumoto) wrote:
> I admit modules with module_function play different role from ordinary modules, and so do refinements.
> ...
Hi Matz thanks for your reply. I think we would have a reasonably significant gain in makin... -
- I admit modules with module_function play different role from ordinary modules, and so do refinements.
I am not sure how much gain we would have by making them their own objects. Adding new syntax, keywords, or concepts may make the lan... -
08:29 AM Bug #13926: Non UTF response headers raise an Argument error since 2.4.2p198
- shevegen (Robert A. Heiler) wrote:
> Can you add a link to Net::HTTPHeader#add_header?
> ...
Apologies, I meant `Net::HTTPHeader#add_field` (https://ruby-doc.org/stdlib-2.4.2/libdoc/net/http/rdoc/Net/HTTPHeader.html#method-i-add_field)... -
- Can you add a link to Net::HTTPHeader#add_header?
I was trying to find it but I can not find it at https://ruby-doc.org/stdlib/libdoc/net/http/rdoc/Net/HTTPHeader.html - I do find []= though https://ruby-doc.org/stdlib-2.4.2/libdoc/n... -
- I tried to write a patch which just adding `strerror(errno)` to error message.
https://github.com/sonots/ruby/commit/4af8960b65aec1c4a82d81431ed812bcebcdf7f8
But, I noticed that it was very fragile.
```
$:.replace([IO::NULL])
r... -
- * numeric.c (rb_num2ll, rb_num2ull, fix_pow): turn repeated
RFLOAT_VALUE calls into local variables.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59988 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Anon92929 (Anon Ymous) wrote:
> This causes SO MANY ISSUES! Instead of CRASHING, why doesn't it just apply the `.to_s` operator in this case???
What is "this case"? -
- > This causes SO MANY ISSUES!
If you build up a `String` such as:
```ruby
x = 42
y = # String here
```
Then you can use:
```ruby
y = "The answer to everything is #{x}"
```
For global variables this is even shorter, th... -
12:23 AM Bug #13929 (Rejected): TypeError: no implicit conversion of XXXX into string
- This causes SO MANY ISSUES! Instead of CRASHING, why doesn't it just apply the .to_s operator in this case???
-
- Applied in changeset trunk|r59986.
----------
numeric.c: use NUM2DBL
* numeric.c (fix_fdiv_double), bignum.c (rb_big_fdiv_double): use
NUM2DBL on unknown object. RFLOAT_VALUE is only applicable to
T_FLOAT object. [ruby-cor... - 03:05 AM Revision d58ccfee (git): * 2017-09-22
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59987 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * numeric.c (fix_fdiv_double), bignum.c (rb_big_fdiv_double): use
NUM2DBL on unknown object. RFLOAT_VALUE is only appliicable to
T_FLOAT object. [ruby-core:82924] [Bug #13928]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@5998...
09/21/2017
-
- s.wanabe@gmail.com wrote:
> But I believe it is never correct.
> (`(char*)` cast is ugly, I want change `cont->machine.stack_src` but not `th->machine.stack_start`, ruby should change the behaviour only when `FIBER_USE_NATIVE == 0`, a... -
09:13 PM Bug #13928 (Closed): Calling Integer.fdiv with BigDecimal returns unexpected result
- After upgrading a Rails project from 2.3.1 to 2.4.2 I ran into a number of failing tests. Seems like to behaviour of fdiv and conjuction with bigdecimal is wrong.
### Reproduce by running:
```ruby
irb(main):001:0> require 'bigdecima... -
- Using ruby commercially we have discovered that modules are no longer serving their original intended purpose of mixins. Another usage of the module has been shoehorned by using module_function. We have found that when developers use mod...
-
- When setting headers using `Net::HTTPHeader#add_field` or `Net::HTTPHeader#[]=` in v2.4.2, an `ArgumentError (invalid byte sequence in UTF-8)` is raised.
In 2.4.1, this behaviour didn't exist and it looks like it was introduced in on... -
- vo.x (Vit Ondruch) wrote:
> it actually takes down the bash instance it is running within. Is this expected?
Yes, Bash interprets the $$ inside the "":
echo "$$"
17490
echo '$$'
$$
-
- naruse (Yui NARUSE) wrote:
> I can't reproduce on ruby -v: ruby 2.5.0dev (2017-09-01 trunk 59707) [aarch64-linux].
> ...
You are using way older components then we do :/ I would blame glibc, binutils or something like that, since it se... -
- Shirosaki-san,
'Breakfast build' is finished, passed `test-all`, and the following also passed:
```
ruby runner.rb -I../lib -I. --repeat-count=50 --show-skip socket/test_socket.rb -ntest_closed_read
```
This has been an intermit... -
11:39 AM Bug #13856: MinGW / mswin intermittent failure in test/socket/test_socket.rb
- Shirosaki-san, your patch seems ok.
Could you check in? -
10:36 AM Bug #13856: MinGW / mswin intermittent failure in test/socket/test_socket.rb
- I found that another exception raises while executing rb_exc_raise() in rb_threadptr_execute_interrupts().
This reentering exception would cause segfault for some reason.
Socket is closed releasing GVL before rb_exc_raise() in rb_threa... -
- Applied in changeset trunk|r59984.
----------
load.c: real path to load
* load.c (rb_construct_expanded_load_path): expand load paths to
real paths to get rid of duplicate loading from symbolic-linked
directories. [Feature #10222] -
- * defs/gmake.mk (ORDERED_TEST_TARGETS): order test-bundler too to
get rid of mixing outputs.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59985 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
09:39 AM Bug #13917: Comparable#clamp is slower than using Array#min,max.
- Thank you, Hanmac. I understand why `Array#min/max` is so fast.
I guess `clamp` would be implemented in `numeric.c` and so on to be as fast as `Array#min/max`. -
- Another instance of this bug:
http://rubyci.s3.amazonaws.com/fedora26/ruby-trunk/log/20170919T063002Z.log.html.gz -
- v.ondruch@tiscali.cz wrote:
> normalperson (Eric Wong) wrote:
> > If you have time, can you try to find larger values changed by
> > r59047 (RUBY_THREAD_MACHINE_STACK_SIZE and
> > RUBY_FIBER_MACHINE_STACK_SIZE) which do not get s... -
- normalperson (Eric Wong) wrote:
> If you have time, can you try to find larger values changed by
> ...
Any idea what should be rasonable value? I started naively with 2 and then continued with 5, 10, 100, 1000, 10000 and it is still c... -
- * load.c (rb_construct_expanded_load_path): expand load paths to
real paths to get rid of duplicate loading from symbolic-linked
directories. [Feature #10222]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59984 b2dd03c8-39d4-4d... -
- * file.c (rb_check_realpath): returns real path which has no
symbolic links. similar to rb_realpath except for returning
Qnil if any parts did not exist.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59983 b2dd03c8-39d4-4d8f-98... -
07:25 AM Feature #12637: Unified and consistent method naming for safe and dangerous methods
- duerst (Martin Dürst) wrote:
> r.smitala (Radovan Smitala) wrote:
> ...
You are right about migration. I don't count all variations of method using.
>
> ...
I think it is why Ruby popularity stagnatess or slightly decreases. No ne... -
- r.smitala (Radovan Smitala) wrote:
> I also think migration to new method naming is really easy with simple regex replacing.
It's not so easy. There may be programs with variable names such as `fill`, user written classes with meth...