Activity
From 08/31/2017 to 09/06/2017
09/06/2017
-
11:08 PM Bug #13875: segfault in Enumerable#zip after GC
- xkernigh@netscape.net wrote:
> https://bugs.ruby-lang.org/issues/13875#change-66516
<snip>
> But this trick might not be the correct fix. I fear a problem
> with fibers, because there is a fiber switch when zip_i()
> calls Enum... -
08:54 PM Bug #13875: segfault in Enumerable#zip after GC
- The problem is with `VALUE tmp;` in enum.c zip_i(). The garbage collector frees tmp too early. I try to protect it with RB_GC_GUARD(tmp), but this doesn't fix the bug. Ruby still crashes.
```diff
diff --git a/enum.c b/enum.c
index 4... -
07:28 PM Bug #13875 (Closed): segfault in Enumerable#zip after GC
- There is a chance of segmentation fault in Enumerable#zip after garbage collection. This script reproduces the crash.
```ruby
GC.stress = true
up = 1.upto(10)
down = 10.downto(1)
up.zip(down) {|a, b| a + b == 11 or fail 'oops'}
... -
10:08 PM Bug #13851: getting "can't modify string; temporarily locked" on non-frozen instances
- cardoso_tiago@hotmail.com wrote:
> > What operation(s) are you doing for "socket monitoring"?
>
> i'm using plain IO.select. So the idea is, I have a selector
> thread, which pushes ready descriptors to a queue; other
> threads pu... -
12:21 PM Bug #13851: getting "can't modify string; temporarily locked" on non-frozen instances
- > What operation(s) are you doing for "socket monitoring"?
i'm using plain IO.select. So the idea is, I have a selector thread, which pushes ready descriptors to a queue; other threads pull from that queue, and read/write from descrip... -
09:15 PM Bug #13876 (Closed): Tempfile's finalizer can be interrupted by a Timeout exception which can cause the process to hang
- Ruby hangs if a Timeout is raised when a Tempfile's finalizer is run.
This also happens on ruby 2.3.4 on OSX. I could only recreate this on linux once but not reliably. Maybe the finalizer runs at a different and unpredictable time ... -
06:29 PM Bug #13872: Duplicate assignment no longer silences "assigned but unused variable" warning
- Well, the first could be solved if there is some way to also propagate (local) variables towards ERB
or other bindings. Like to have different binding "levels" available. Copy environments and stuff. :D
(Actually ... one could probably... -
03:43 PM Bug #13872: Duplicate assignment no longer silences "assigned but unused variable" warning
- Previously, `foo = foo = "bar"` was used as a workaround. Now that the workaround is "fixed", I see incoming PRs changing the workaround to `foo = "bar"; foo = foo`.
It would be nice if we had a way to handle these false positives dir... -
02:42 PM Bug #13874: String#valid_encoding? has side effects
- 2.2.6 and later need the backport.
-
01:11 PM Bug #13874 (Closed): String#valid_encoding? has side effects
- Applied in changeset trunk|r59763.
----------
string.c: fix false coderange
* string.c (rb_enc_str_scrub): enc can differ from the actual
encoding of the string, the cached coderange is useless then.
[ruby-core:82674] [Bug #13874] -
12:12 PM Bug #13874: String#valid_encoding? has side effects
- Also reproducible on `ruby 2.4.0p0 (2016-12-24 revision 57164) [x86_64-linux]`
Not reproducible on `ruby 2.2.5p319 (2016-04-26 revision 54774) [x86_64-linux]`. Both calls result in `"\xE5"`
-
10:05 AM Bug #13874 (Closed): String#valid_encoding? has side effects
- I noticed the result of `String#encode` changes after a call to `String#valid_encoding?`. Other side effects were not visible so far.
Based on the documentation and intuition I would expect `#valid_encoding?` to be an operation withou... -
01:46 PM Revision 0f25c6d7 (git): Fix a typo [ci skip]
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59764 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
01:11 PM Revision bd10ce16 (git): string.c: fix false coderange
- * string.c (rb_enc_str_scrub): enc can differ from the actual
encoding of the string, the cached coderange is useless then.
[ruby-core:82674] [Bug #13874]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59763 b2dd03c8-39d4-4d8f-98... -
01:06 PM Bug #13853: Backport request r58323
- The patch is not patching version in json.gemspec, but it should ...
~~~diff
--- ext/json/json.gemspec
+++ ext/json/json.gemspec
@@ -1,6 +1,6 @@
Gem::Specification.new do |s|
s.name = "json"
- s.version = "1.8.3"
+ s.vers... -
12:50 PM Revision faa26f55 (git): string.c: optimize enumerate_grapheme_clusters
- * string.c (rb_str_enumerate_grapheme_clusters): optimize when
single byte only.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59762 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
10:04 AM Feature #13770: Can't create valid Cyrillic-named class/module
- As mentioned at the last committers' meeting, I think the patch will not work e.g. for upper-case characters in three-byte EUC-JP (characters from JIS X 0212) because the necessary data isn't there (see #11859).
-
09:54 AM Feature #13770: Can't create valid Cyrillic-named class/module
- sb (Sergey Borodanov) wrote:
> Same error with module creating and same behavior in **irb** (please, see attachment). At the same time Cyrillic-named constants and methods work fine.
Methods indeed should work fine, because current... -
09:45 AM Feature #13770: Can't create valid Cyrillic-named class/module
- I have checked for upper-case letters without corresponding lower-case letters, with the following short script:
```
ruby -n -e 'l=$_.split(/;/); if l[2]=="Lu" && l[13]=="" then puts l[1];end' <UnicodeData.txt
```
Somewhat contr... -
09:31 AM Feature #8948: Frozen regex
- Now we can't run `make test-all` because `test/lib/test/unit.rb` defines singleton method for a regexp object.
```ruby
def non_options(files, options)
filter = options[:filter]
if filter
pos_pat = /... -
08:19 AM Feature #13685 (Closed): Update Unicode data to Unicode Version 10.0.0
- Applied in changeset trunk|r59761.
----------
add mention of upgrade to Unicode 10.0.0 to NEWS file
(this completes [Feature #13685]; [ci skip]) -
07:56 AM Feature #13685: Update Unicode data to Unicode Version 10.0.0
- Working on this now. Just some notes for future, similar issues:
At the moment, using gperf 3.0.4 (rather than gperf 3.1) seems to be important for smooth sailing.
Also, the important make target is `all-incs`. In addition, the tar... -
08:19 AM Revision 1704e7a6 (git): add mention of upgrade to Unicode 10.0.0 to NEWS file
- (this completes [Feature #13685]; [ci skip])
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59761 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
08:12 AM Revision df155f09 (git): remove Unicode 9.0.0-related files
- We don't need these files anymore because we upgraded to Unicode 10.0.0.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59760 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
07:56 AM Revision 04547c7d (git): update Ruby to Unicode 10.0.0
- - In common.mk, set UNICODE_VERSION to 10.0.0
- Generate and add enc/unicode/10.0.0/casefold.h and
enc/unicode/10.0.0/name2ctype.h
- Update lib/unicode_normalize/tables.rb
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59759 b2dd0... -
07:46 AM Revision 3122b0ba (git): Update SimpleCov version (v0.10.0 -> v0.15.0)
- To suppress warnings of Fixnum.
Also simplecov-html updated (v0.10.0 -> v0.10.2).
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59758 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
05:34 AM Feature #13847: Gem activated problem for default gems
- We discussed this issue on last Developer Meeting.
Matz has some concerns about ruby internal.
1. Conflicts versions of a shared library like libyaml-*., libssl-*, libffi, etc...
2. Order of LOADED_FEATURE
So, This feature is d... -
05:00 AM Feature #12733: Bundle bundler to ruby core
- vo.x (Vit Ondruch) wrote:
> I don't understand it. Why is it not simple bundled gem similartly to minitest, test-unit, rake, etc? This gems broken to Ruby directories were always the worst idea. It could make sense when Ruby have not sh... -
04:39 AM Feature #12733: Bundle bundler to ruby core
- I don't understand it. Why is it not simple bundled gem similartly to minitest, test-unit, rake, etc? This gems broken to Ruby directories were always the worst idea. It could make sense when Ruby have not shipped with Rubygems, but nowa...
-
02:37 AM Feature #12733: Bundle bundler to ruby core
- I update my working branch.
https://github.com/ruby/ruby/pull/1536
Changes in this branch:
#### Directory Structure
I organized bundler integration like this:
```
root -+- lib -+- bundler/*
| |
|... -
04:29 AM Bug #12036: Enumerator's automatic rewind behavior
- I don't want Ruby to change this behavior. Enumerable#next can't continue the iteration if it raises an exception. That's why it has the automatic rewind behavior.
Here's a quick example. In this script, we handle the oops and expect ... -
03:53 AM Revision ee0b1b20 (git): Fixed compilationn error with VMDEBUG=3.
- [fix GH-1690] Patch from @musaprg(Kotaro Inoue)
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59757 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
03:39 AM Revision 7119de47 (git): accept ec instead of th.
- * vm.c: VM_EP_IN_HEAP_P() and vm_ep_in_heap_p_() only requires ec
pointed from th.
* vm.c (rb_execution_context_mark): GET_THREAD() returns current
running thread and we need to use marking thread here. Pass marking
thread's ec in... -
03:18 AM Revision e4139095 (git): th is not defined
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59755 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
02:51 AM Revision b95d9e66 (git): thread_context -> execution_context
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59754 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 02:47 AM Revision d687dc9c (git): * 2017-09-06
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59753 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
02:46 AM Revision 366157d3 (git): rb_execution_context_mark.
- * vm.c (rb_execution_context_mark): separate from thread_mark().
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59752 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
02:19 AM Bug #13865 (Closed): Triggered segfault, on Ruby2.4/OSX.
- Per your request, I have closed this.
-
01:03 AM Bug #13865: Triggered segfault, on Ruby2.4/OSX.
- Hi.
This is fixed on 2.5.0:
```
2] pry(main)> _pry_.h.deprecate_method! Object.methods.map{|m| Object.method(m) }, "everything is deprecated"
Traceback (most recent call last):
5405: from bin/pry:12:in `<main>'
5404: from ../...
09/05/2017
-
08:11 PM Bug #13851: getting "can't modify string; temporarily locked" on non-frozen instances
- cardoso_tiago@hotmail.com wrote:
> The problem is that I'm doing all socket monitoring in one
> thread, and read/write operations on another. Is there any
> thread-unsafety associated with such operations happening at
> the same tim... -
05:26 PM Bug #13851: getting "can't modify string; temporarily locked" on non-frozen instances
- I've been struggling to create a self-contained script to reproduce the problem, but can't seem to.
The problem is that I'm doing all socket monitoring in one thread, and read/write operations on another. Is there any thread-unsafety... -
05:51 PM Feature #13873 (Closed): Optimize Dir.glob with FNM_EXTGLOB
- Rails often queries Dir.glob with complex pattern.
On accessing Rails site, it calls glob as follows on querying templates.
Note that Dir[] insists File::FNM_EXTGLOB.
```ruby
def find_template_paths(query)
Dir[quer... -
05:43 PM Feature #13821: Allow fibers to be resumed across threads
- Fibers still can't move across threads in
```
ruby 2.5.0dev (2017-09-04 trunk 59742) [x86_64-openbsd6.1]
```
Because of this, I can't take an Enumerator across threads:
```ruby
count = 1.step
puts count.next #=> 1
puts c... -
05:18 PM Bug #11147 (Closed): [SEGFAULT] While looping gets
- Closing since I was never able to reproduce the issue myself
-
05:17 PM Bug #13872 (Closed): Duplicate assignment no longer silences "assigned but unused variable" warning
- On ruby 2.4.1:
`ruby -W -e 'def a; var = var = "foo"; end'`
prints no warning
On ruby 2.5.0dev (2017-09-04 trunk 59742) [x86_64-darwin16]
`ruby -W -e 'def a; var = var = "foo"; end'`
prints warning `-e:1: warning: assigned... -
04:52 PM Misc #13871 (Closed): Remove commented out code of URI::HTTP.new
- It's treated as document for URI::HTTP#request_uri:
https://ruby-doc.org/stdlib-2.4.0/libdoc/uri/rdoc/URI/HTTP.html#method-i-request_uri
It's broken, so the commented out code should be removed.
It's the same type problem of htt... -
04:37 PM Misc #13870 (Closed): Remove commented out code of SecureRandom.random_number
- It's treated as document for Random::Formatter#uuid:
https://ruby-doc.org/stdlib-2.4.0/libdoc/securerandom/rdoc/Random/Formatter.html#method-i-uuid
The commented out code should be removed. -
02:30 PM Feature #13869 (Open): Filter non directories from Dir.glob
- Dir.glob is a tool to fetch filesystem entries with filtering.
On Rails, it often query files from template directories with braces (FNM_EXTGLOB)
https://github.com/rails/rails/blob/6f1c18308ebffc97d51440cdeed7be71de58f26a/actionview... -
11:51 AM Bug #13863: RUBYLIB にカレントディレクトリを設定した場合、-E cp932:utf-8 を指定するとスクリプトが全く実行されない
- > あとは、RUBYLIB の場合だけで、-I などでは問題ないようですね。なるほど。
そうですね。
a2.rb で -I. を使用する場合だと、require が失敗するだけで、
いきなり終了する現象は出ません。
require が失敗するケースも対策されるとうれしいです。
-
07:37 AM Bug #13863: RUBYLIB にカレントディレクトリを設定した場合、-E cp932:utf-8 を指定するとスクリプトが全く実行されない
- あー、再現しました。ありがとうございます。
> カレントディレクトに日本語を含む
これがすっぽ抜けてました。
あとは、`RUBYLIB` の場合だけで、`-I` などでは問題ないようですね。なるほど。 -
04:14 AM Bug #13863: RUBYLIB にカレントディレクトリを設定した場合、-E cp932:utf-8 を指定するとスクリプトが全く実行されない
- 仕事で使用している Windows 7 64bit の環境で試しましたが、現象発生します。
こちらで確認している条件は次の2点です。
* カレントディレクトに日本語を含む
* RUBYLIB に . 設定されている
ログを貼ります(プロンプトが2行になっています)が、どうでしょうか。
~~~
C:\usr\sandbox\ruby\req\テスト
$type a.rb
puts 'a'
require'./b'
C:\usr\sa... -
11:08 AM Feature #13867: Copy offloading in IO.copy_stream
- glass.saga@gmail.com wrote:
> In linux 4.5, the copy offloading feature with copy_file_range(2) was introduced.
> This patch enables IO.copy_stream to use it.
Cool.
> If "offload" keyword argument is specified, IO.copy_stream wi... -
09:06 AM Feature #13867 (Closed): Copy offloading in IO.copy_stream
- In linux 4.5, the copy offloading feature with copy_file_range(2) was introduced.
This patch enables IO.copy_stream to use it.
If "offload" keyword argument is specified, IO.copy_stream will try copy offloading.
```ruby
IO.copy_str... -
10:46 AM Bug #13412: Infinite recursion with define_method may cause silent SEGV or cfp consistency error
- Hmm... r59630 seems to be too hard to backport.
I had to cherry-pick r58328, r58353, r58354, r58374, r58377 and r58379 before cherry-picking r59630.
They are too many.
```
$ git checkout origin/ruby_2_4 && git checkout -B work &&
... -
10:18 AM Bug #13868 (Closed): Compile error on cygwin: No rule to make 'ossl_pkcs5.h', needed by 'ossl.o'
- usa (Usaku NAKAMURA) wrote:
> try `make clean`
That seems to have solved the problem, but it looks like a very heavy tool. -
09:42 AM Bug #13868: Compile error on cygwin: No rule to make 'ossl_pkcs5.h', needed by 'ossl.o'
- try `make clean`
-
09:40 AM Bug #13868: Compile error on cygwin: No rule to make 'ossl_pkcs5.h', needed by 'ossl.o'
- The file was deleted in r59734, at ext/openssl/ossl_pkcs5.h.
Except in doc/ChangeLog-1.9.3, I cannot find any traces of the string "ossl_pkcs5", while the strings "ossl_pkcs7" and "ossl_pkcs12" appear frequently. But the error still p... -
09:29 AM Bug #13868 (Closed): Compile error on cygwin: No rule to make 'ossl_pkcs5.h', needed by 'ossl.o'
- When I try to compile my latest checkout on cygwin, I repeatedly get the following error:
```
make[2]: Entering directory '/cygdrive/c/Data/ruby/ext/openssl'
make[2]: *** No rule to make target 'ossl_pkcs5.h', needed by 'ossl.o'. S... -
09:47 AM Revision d68a6b3e (git): openssl: merge test fixes from upstream
- Fix platform-dependent or fragile test cases added by r59734. This is a
combined patch of the three commits below:
4fc17977350a test/test_fips: skip if setting FIPS mode fails
b25179fbeebf test/test_asn1: fix possible fa... -
09:05 AM Feature #13866 (Rejected): Copy offloading in IO.copy_stream
- 間違えてruby-devに投げてしまったので、rejectします。
-
08:57 AM Feature #13866 (Rejected): Copy offloading in IO.copy_stream
- In linux 4.5, the copy offloading feature with copy_file_range(2) was introduced.
This patch enables IO.copy_stream to use it.
If "offload" keyword argument is specified, IO.copy_stream will try copy offloading.
```ruby
IO.copy_str... -
08:25 AM Revision 31a447d1 (git): Update credentials for Travis/Slack integration.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59750 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
08:15 AM Revision 8c592366 (git): Hide NotImplementedError for windows
- https://github.com/ruby/ruby/commit/440dc6b7e0b3b74db221eed81871516e301d4b3e#commitcomment-24074203
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59749 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
07:52 AM Revision 813ffb8b (git): st.c: fix num_entries
- * st.c (st_insert2): should manage num_entries when the key is
undefined, as well as st_insert().
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59748 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
07:50 AM Revision 4a09333b (git): st.c: fix false assertions
- * st.c: split assertion conditions.
* st.c (rb_hash_bulk_insert): the number of arguments should be
even.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59747 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
07:28 AM Bug #11844: Please update unicode-licensed files (license issue)
- zeha (Christian Hofstaedtler) wrote:
> The non-free problem is with this line: "supplied in this file in the creation of products supporting the Unicode Standard" - which implies that you can't use this file to produce stuff not support... -
04:49 AM Revision ce7f3e13 (git): optimize rb_hash_bulk_insert to generally outperform 2.4.
- Specialized routine for small linear-probling hash instances to
boost creation of such things [Bug #13861]
Signed-off-by: Urabe, Shyouhei <shyouhei@ruby-lang.org>
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59746 b2dd03c8-39d4-4... - 04:48 AM Revision e06a6630 (git): * 2017-09-05
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59745 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
04:48 AM Revision 0eb7359c (git): add rb_hash_new_with_size()
- Sometimes, size of a hash can be calcluated a priori. By providing
such info to the constructor we can avoid unnecessary internal re-
allocations. This can boost for instance creation of hash literals.
[Bug #13861]
Signed-off-by: Urab... -
12:21 AM Bug #13864 (Assigned): Rinda multicast test failures due to missing default route
09/04/2017
-
08:49 PM Bug #13864: Rinda multicast test failures due to missing default route
- Well no surprise - the systemd guys know better than any standard ever written, too. ;)
I think 1) does not make a lot of sense if it is code within ruby that fails.
I actually thought that Rinda is abandoned since a long time... l... -
01:47 PM Bug #13864 (Closed): Rinda multicast test failures due to missing default route
- Trying to build Ruby for Fedora, we are using tool called mock [1]. This tools allows to execute the build in container, using systemd-nspawn on background [2] and this in turn allows the container to be isolated from network [3]. Howeve...
-
02:10 PM Bug #13865: Triggered segfault, on Ruby2.4/OSX.
- JRuby provides a little more useful information:
```
[1] pry(main)> _pry_.h.deprecate_method! Object.methods.map{|m| Object.method(m) }, "everything is deprecated"
DEPRECATED: everything is deprecated
.. Called from ../code/rb/pry-... -
02:05 PM Bug #13865 (Closed): Triggered segfault, on Ruby2.4/OSX.
- Hi.
I ran into a segmentation fault, the reproduction steps are here:
$ git clone https://github.com/r-obert/pry-plusplus.git
$ cd pry-plusplus
$ git checkout edf3496f425ef2512431a79b72a2a5fd930b2fcf
$ gem install bundler --no-r... -
02:04 PM Revision e5684558 (git): string.c: grapheme clusters on frozen string
- * string.c (rb_str_enumerate_grapheme_clusters): enumerate on
shared frozen string.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59743 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
02:04 PM Revision 805d6f6f (git): string.c: enumerator_element
- * string.c (enumerator_element): push or yield elements, and
return 1 if needs checks.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59742 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
01:25 PM Revision 440dc6b7 (git): Improve line covearge of ext/io/nonblock/nonblock.c from 54.5% to 95.5%
- Not so good test, but it would be better than nothing, I guess...
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59741 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
12:46 PM Bug #13861: Performance regressoion in Hash literal in Ruby 2.5.0-dev
- I think this is not 3rd party issue.
Because this regression appears since 2017-04-28
```
$ ./miniruby -v -Ilib -I../benchmark-ips/lib ~/tmp/bench.rb
ruby 2.5.0dev (2017-04-27 trunk 58469) [x86_64-linux]
/home/watson/tmp/bench.rb... -
06:58 AM Bug #13861 (Third Party's Issue): Performance regressoion in Hash literal in Ruby 2.5.0-dev
- After looking at this more closely, I now suspect it's benchmark/ips who's doing something nasty. Without it, trunk runs order of magnitude faster than 2.4.
```
zsh % time ruby@trunk --disable-gems -ve 'i=0; while i<100_000_000 do {... -
04:22 AM Bug #13861: Performance regressoion in Hash literal in Ruby 2.5.0-dev
- shyouhei (Shyouhei Urabe) wrote:
> I have to disagree.
Thank you for the thorough analysis and the reminder to always vary the length when testing anything with one... -
04:07 AM Bug #13861: Performance regressoion in Hash literal in Ruby 2.5.0-dev
- watson1978 (Shizuo Fujita) wrote:
> Hash literal performance -> 35.7 % slow down since Ruby 2.4.1
I have to disagree.
```ruby
require 'benchmark/ips'
n = 32
Benchmark.ips do |x|
# precalc literals
lit = []
(0..n).ea... -
12:15 PM Bug #13862 (Closed): typo: "nubmer" in gc.c - Applied in changeset trunk|r59739.
----------
gc.c: fix typo: nubmer -> number
Signed-off-by: Antonio Terceiro <terceiro@softwarelivre.org>
[Bug #13862] - 12:15 PM Revision b833c34f (git): * 2017-09-04
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59740 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
12:15 PM Revision b4ae7472 (git): gc.c: fix typo: nubmer -> number
- Signed-off-by: Antonio Terceiro <terceiro@softwarelivre.org>
[Bug #13862]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59739 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
12:13 PM Bug #13863: RUBYLIB にカレントディレクトリを設定した場合、-E cp932:utf-8 を指定するとスクリプトが全く実行されない
- 私の手元にあるmswin32/mswin64/mingw32/mingw64の2.3.4/2.4.1/trunkではいずれでも再現しませんでした。
他に何か再現条件があるのでしょうか? -
10:59 AM Bug #13863 (Closed): RUBYLIB にカレントディレクトリを設定した場合、-E cp932:utf-8 を指定するとスクリプトが全く実行されない
- こんにちは。
Windows 環境の ruby での話です。
http://blade.nagaokaut.ac.jp/cgi-bin/scat.rb/ruby/ruby-list/49186
https://bugs.ruby-lang.org/issues/7881
について、これは少なくとも
* ruby 2.3.3p222 (2016-11-21 revision 56859) [i386-mingw32]
* ruby 2.4.1p... -
01:45 AM Feature #13860: A proposal for a new, simpler class-method addition to Time - for the time being calling it Time.date() but another name is fine; and the ability to omit '%' tokens as arguments to it
- Is there any reasons this has to be done in-core, instead of a gem? It seems everything needed to implement such thing as a gem is available... or do we miss something?
09/03/2017
-
02:26 PM Revision cd6df5fb (git): Refactor the internal data format for coverage measurement
- To prepare new measuring targets: branch and method coverages.
So far, iseq->coverage was an array of counts executed for line coverage.
Now, it is a three-element array for each measuring target,
whose first element is an array for line... -
01:44 PM Bug #13862 (Closed): typo: "nubmer" in gc.c
- patch attached
-
01:31 PM Revision c10baca4 (git): ext/.document: follow-up r59734
- ext/openssl/ossl_pkcs5.c has been renamed to ossl_kdf.c.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59737 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
01:21 PM Revision ded7e1c2 (git): string.c: make array in WANTARRAY
- * string.c (WANTARRAY): make array for the result in method
functions and pass it to enumerator functions.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59736 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 12:35 PM Revision 5dab63aa (git): * properties.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59735 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
12:35 PM Revision 609103db (git): openssl: import v2.1.0.beta1
- Import Ruby/OpenSSL 2.1.0.beta1. The full commit log since v2.0.5
(imported by r59567) can be found at:
https://github.com/ruby/openssl/compare/v2.0.5...v2.1.0.beta1
-------------------------------------------------------------... -
12:35 PM Revision b9801bb8 (git): vm_insnhelper.c: fix opt_regexpmatch2 instruction
- A fix-up for r58390 ("split insns.def into functions", 2017-04-18) which
accidentally swapped the arguments.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59733 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
09:12 AM Bug #13844: Toplevel returns should fire ensures
- Agreed, ensure should run in all cases escaping the scope, even more so when it lexically encloses the top-level return.
-
02:08 AM Revision adac7792 (git): string.c: enumerator_wantarray
- * string.c (enumerator_wantarray): show warnings at method
functions for proper method names.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59732 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
01:47 AM Revision 71de5662 (git): string.c: fix for non-Unicode encodings
- * string.c (rb_str_enumerate_grapheme_clusters): should enumerate
chars for non-Unicode encodings. [Feature #13780]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59731 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
12:39 AM Revision fc1bf166 (git): string.c: suppress a warning
- * string.c (rb_str_enumerate_grapheme_clusters): suppress a
maybe-uninitialized warning by old gcc.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59730 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
12:32 AM Revision 442273fa (git): default.mspec: suppress warnings
- * spec/default.mspec: suppress tons of useless use of == in void
context warnings.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59729 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
12:25 AM Revision 52ec107a (git): test_io.rb: suppress a warning
- * test/ruby/test_io.rb (test_single_exception_on_close): suppress
ambiguous first argument warning with RUBYOPT=-w.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59728 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
12:13 AM Revision 0cbcb5f5 (git): test_coverage.rb: suppress warnings
- * test/coverage/test_coverage.rb (test_nonpositive_linenumber):
suppress method redefinition warnings.
* test/coverage/test_coverage.rb (test_eval): suppress literal in
void context warning.
git-svn-id: svn+ssh://ci.ruby-lang.org/r... - 12:02 AM Revision e3c271b4 (git): * 2017-09-03
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59726 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
12:02 AM Revision 3b556825 (git): test_coverage.rb: use real path
- * test/coverage/test_coverage.rb (test_restarting_coverage): use
real directory path for the case $TMPDIR contains symlinks. on
macOS, it is defaulted to a path under /var which is a symlink
to /private/var.
git-svn-id: svn+ssh:/...
09/02/2017
-
08:02 PM Bug #13861: Performance regressoion in Hash literal in Ruby 2.5.0-dev
- watson1978 (Shizuo Fujita) wrote:
> Seems Ruby 2.5.0-dev has performance regression in Hash literal.
Similar results on MinGW Win7 gcc 7.1.0 using ruby for both
```
ruby 2.5.0dev (2017-09-02 trunk 59723) [x64-mingw32]
ruby 2.4.1p1... -
07:15 PM Bug #13861 (Third Party's Issue): Performance regressoion in Hash literal in Ruby 2.5.0-dev
- Seems Ruby 2.5.0-dev has performance regressoion in Hash literal.
I've confirmed it with below benchmark script
Hash literal performance -> 35.7 % slow down since Ruby 2.4.1
### Environment
* Ubuntu 17.04
* gcc version 7.0.1
... -
02:11 PM Feature #13667 (Feedback): Add Coverage.running? to quickly check if Coverage is enabled.
- I applied the patch proposed. After that, however, I'm now considering reverting it.
I noticed that this feature may be dangerous. By using this, we can easily write a program that changes its behavior only under coverage measuremen... -
01:55 PM Revision f34090ca (git): test/coverage/test_coverage.rb: run the tests in separated processes
- The tests had been disabled under coverage measurement (during
`ENV['COVERAGE']`), since they call `Coverage.result` which stops
coverage measurement.
So, we couldn't measure both C-level and Ruby-level coverage of Ruby
simultaneously.
I... -
10:10 AM Feature #13860 (Open): A proposal for a new, simpler class-method addition to Time - for the time being calling it Time.date() but another name is fine; and the ability to omit '%' tokens as arguments to it
- Hello ruby-folks,
On reddit someone linked in this:
http://www.w3school.in/w3schools/php-tutorial/php-date-time
Just in the event that this may not be available lateron, or nobody
wants to look at external links, I'll very br... -
07:37 AM Misc #13704: [PATCH] Exclude Changelog files from documentation.
- Nice, thank you!
-
06:58 AM Bug #13769: IPAddr#ipv4_compat incorrect behavior
- I guess `::` and `::1` are the only exceptions listed because they are the only IPv6 addresses with the 80+16 bit zero prefix that already have special, conflicting meanings as IPv6 address, so I consider it was practically reasonable en...
-
06:17 AM Revision 1e9fad23 (git): proc.c: [DOC] fixup r59720
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59723 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
02:05 AM Bug #13858 (Closed): getoptlong cannot process multiple line argument with equal sign (=) version
- Applied in changeset trunk|r59722.
----------
getoptlong.rb: multiline regexps
* lib/getoptlong.rb: make regexps multiline safe.
[ruby-core:82627] [Bug #13858] -
02:05 AM Revision 0f6e7edf (git): getoptlong.rb: multiline regexps
- * lib/getoptlong.rb: make regexps multiline safe.
[ruby-core:82627] [Bug #13858]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59722 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
01:47 AM Bug #13859 (Closed): Segfault running `Fiber#inspect` on trunk
- Applied in changeset trunk|r59721.
----------
cont.c: fix root fiber to_s
* cont.c (fiber_to_s): fix Fiber#to_s on root fibers which have no
procs. [ruby-core:82629] [Bug #13859] -
01:47 AM Revision 04659165 (git): cont.c: fix root fiber to_s
- * cont.c (fiber_to_s): fix Fiber#to_s on root fibers which have no
procs. [ruby-core:82629] [Bug #13859]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59721 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
01:41 AM Revision caf92db4 (git): Add Method#original_name code example [ci skip]
- * proc.c (method_original_name): [DOC] add code example.
[Fix GH-1693]
Author: Seiei Miyagi <hanachin@gmail.com>
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59720 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
01:08 AM Bug #13855 (Closed): Hash#compact! returns nil if the hash is empty
- Applied in changeset trunk|r59719.
----------
Update Hash#compact! documentation [ci skip]
* hash.c (rb_hash_compact_bang): [DOC] update the case if no
changes were made. [ruby-core:82591] [Bug #13855] [Fix GH-1692]
Author: Luca... -
01:08 AM Revision 0118b985 (git): Update Hash#compact! documentation [ci skip]
- * hash.c (rb_hash_compact_bang): [DOC] update the case if no
changes were made. [ruby-core:82591] [Bug #13855] [Fix GH-1692]
Author: Lucas Buchala <lucasbuchala@gmail.com>
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59719 b... - 12:26 AM Revision d0501060 (git): * 2017-09-02
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59718 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
12:26 AM Revision 08d06114 (git): * ext/win32ole/win32ole.c (fole_initialize): fix typo. thanks to Gray Wolf.
- [Feature #13828]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59717 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
09/01/2017
-
10:31 PM Feature #13828: Win32ole extension should support licensed COM servers
- Looking at trunk|r59665, there a typo `keyward_ids`, dunno if it's worth fixing.
-
10:26 PM Bug #13859 (Closed): Segfault running `Fiber#inspect` on trunk
- I started encountering segfaults on ruby-head in the test suite for neovim-ruby a couple weeks ago (e.g. https://travis-ci.org/alexgenco/neovim-ruby/jobs/268931902).
After some digging, it looks like the segfaults are being caused by ... -
07:14 PM Bug #13670: [BUG] Bus Error at 0xefce7b (armv7l) (ruby 2.3.4p301)
- Could you try trunk or Ruby 2.4.1 and provide how to reproduce the issue?
I have armv7l-linux-eabihf environment and I'll try it. -
04:51 PM Bug #13858 (Closed): getoptlong cannot process multiple line argument with equal sign (=) version
- Here is the test case:
# more getopt.rb
require 'getoptlong'
a=GetoptLong.new(
[ '--user', '-u', GetoptLong::REQUIRED_ARGUMENT ],
[ '--statement', '-s', GetoptLong::REQUIRED_ARGUMENT ],
)
a.each {... -
04:09 PM Bug #13794: Infinite loop of sched_yield
- Hi Eric,
I have been testing your original patch (just the PID check) for a couple of days and it appears to have resolved the problem. I will report on this again in 1 week as the issue occurs quite randomly but I am currently hopefu... -
03:18 PM Feature #13847: Gem activated problem for default gems
- Shouldn't the focus be on why the OpenSSL is loaded at the first place?
-
02:58 PM Feature #13667 (Closed): Add Coverage.running? to quickly check if Coverage is enabled.
- Applied in changeset trunk|r59716.
----------
ext/coverage/coverage.c: add Coverage.enabled?
* ext/coverage/coverage.c (rb_coverage_running): add to quickly
check if coverage is enabled. patched by Burke Libbey <burke AT
libbey.me> in... -
02:58 PM Revision 95d949d5 (git): ext/coverage/coverage.c: add Coverage.enabled?
- * ext/coverage/coverage.c (rb_coverage_running): add to quickly
check if coverage is enabled. patched by Burke Libbey <burke AT
libbey.me> in [ruby-core:81726]. [Feature #13667]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59716 ... -
12:10 PM Bug #13857: frozen string literal: can freeze same string into two unique frozen strings
- Or maybe a String#freeze which returns an already existing frozen literal if such already exists. I think that the #downcase result makes sense, and would break existing code otherwise.
To sum it up, this is what I think could make se... -
11:19 AM Bug #13857: frozen string literal: can freeze same string into two unique frozen strings
- OK, I see what you want. So maybe what is wanted is a String#downcase variant which "inherits" frozenness of the source string. That way we can dedup them when necessary. I think there are rooms for such feature. Not sure how to achi...
-
10:54 AM Bug #13857: frozen string literal: can freeze same string into two unique frozen strings
- Please don't get me wrong, I'm not arguing that the spec for the feature is vague.
I understood that the introduction of the feature was to reduce memory consumption in template generation (like erb templates), and to avoid those `CON... -
10:08 AM Bug #13857: frozen string literal: can freeze same string into two unique frozen strings
- chucke (Tiago Cardoso) wrote:
> > These are not literals, so not subjects of frozen-string-literal.
> ...
Literals are literals. Those `c.downcase`-generated strings definitely aren't. I don't see any implementation details here. -
09:31 AM Bug #13857: frozen string literal: can freeze same string into two unique frozen strings
- chucke (Tiago Cardoso) wrote:
> According to the principle of least surprise, I'd expect them to be the same.
And proposals based on "the principle of least surprise" will be rejected in common.
It's not our "principle". -
09:28 AM Bug #13857: frozen string literal: can freeze same string into two unique frozen strings
- chucke (Tiago Cardoso) wrote:
> > These are not literals, so not subjects of frozen-string-literal.
> ...
It's not an implementation detail, but a language spec. -
09:27 AM Bug #13857: frozen string literal: can freeze same string into two unique frozen strings
- > These are not literals, so not subjects of frozen-string-literal.
I'd argue, that's an implementation detail. According to the principle of least surprise, I'd expect them to be the same. -
09:22 AM Bug #13857 (Rejected): frozen string literal: can freeze same string into two unique frozen strings
- chucke (Tiago Cardoso) wrote:
> Running an interpreter with `--enable-frozen-string-literal` on, I get the following:
> ...
These are not literals, so not subjects of frozen-string-literal.
BTW:
> ```ruby
> ...
Hash key strings ... -
07:16 AM Bug #13857 (Rejected): frozen string literal: can freeze same string into two unique frozen strings
- Running an interpreter with `--enable-frozen-string-literal` on, I get the following:
```ruby
> "bang".object_id #=> 70303434940940 GOOD!
> ...
```
This ticket concerns the last two examples. In the case of performing an operati... -
10:22 AM Bug #12598 (Closed): List files with Unicode license in LEGAL file
- Applied in changeset trunk|r59715.
----------
replace copyrights by explanatory text in data files for GB2312/GB12345 mappings
Replace the copyrights and explanatory texts in the data files used for mapping
GB2312/GB12345 to/from Unico... -
10:09 AM Bug #12598: List files with Unicode license in LEGAL file
- To give some more details on what Hiroshi wrote, what happened (actually upstreams, not at Ruby itself) is that somebody took some of the Unicode data files and used them to produce a product supporting Unicode, as permitted in the copyr...
-
05:50 AM Bug #12598: List files with Unicode license in LEGAL file
- I discussed UCD license on the Ruby language with Prof. Martin.
enc/trans/GB/*.src files have a wrong license holder message about UCD. Example: its message points another dataset.
We will put a disclaimer message into a top of enc/t... -
10:22 AM Revision 3d46d51c (git): replace copyrights by explanatory text in data files for GB2312/GB12345 mappings
- Replace the copyrights and explanatory texts in the data files used for mapping
GB2312/GB12345 to/from Unicode with short explanatory texts. [Bug #12598] [ci skip]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59715 b2dd03c8-39d4-4d... -
08:30 AM Feature #13581: Syntax sugar for method reference
- Consider the following:
~~~ ruby
def get_method(sym, object = Object)
object.send(:method, sym)
end
~~~
This allows us to write code like:
~~~ ruby
[1, 4, 9].map &get_method(:sqrt, Math)
~~~
So as an idea, how abo... -
06:36 AM Feature #13581: Syntax sugar for method reference
- What about triple colon `:::`?
```ruby
[1,2,3].map(&Math:::sqrt)
[1,2,3].each(&:::puts)
```
`::` is for looking up constants, so it kind of makes sense that `:::` is for looking up methods. -
06:15 AM Feature #13581: Syntax sugar for method reference
- Another pretty unholy idea: resemble the way Ruby docs document the methods:
```ruby
[1,2,3].map(&Math#sqrt)
%w[foo bar baz].each(&#puts)
```
Yes, it conflicts with comment syntax, but in fact, no sane person should join the com... -
12:56 AM Feature #13581: Syntax sugar for method reference
- How about `obj.{method_name}` for the syntax sugar of `obj.method(:method_name)`?
-
08:16 AM Revision fc188f16 (git): object.c: fix potential oob write in rb_str_to_dbl()
- Ensure space for the terminating NUL byte. Note that this code path is
reachable only when Ruby is compiled with SHARABLE_MIDDLE_SUBSTRING=1.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59714 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
05:57 AM Misc #13747 (Closed): MinGW trunk build available on Appveyor
- MSP-Greg (Greg L) wrote:
> I'm fine with you closing this whenever you'd like.
Done. -
01:50 AM Misc #13747: MinGW trunk build available on Appveyor
- naruse (Yui NARUSE) wrote:
> Thank you for providing CI for mingw.
> ...
Thank you, and thank you for the offer. At present, given what time I have for OSS, my priorities are:
1. Encourage more extension gems to test with MinGW bui... -
04:29 AM Feature #13563: Implement Hash#choice method.
- I vote for `Hash#slice` that is ActiveSupport compatible.
Matz.
-
04:03 AM Feature #13604 (Assigned): Exposing alternative interface of readline
- @kouji or @nobu
Can you review this patch? -
03:55 AM Feature #13822: Time.dst_changes(t=Time.now.year)
- Usually Ruby itself doesn't have such information by itself.
It just calls localtime(3).
If you want to have information related timezone database, you should use tzinfo.gem.
https://rubygems.org/gems/tzinfo -
03:39 AM Misc #13704: [PATCH] Exclude Changelog files from documentation.
- @larskanis
We discussed this issue on Developer Meeting.
There is no objection to your request.
I'm ok to merge your patch.
Thank you.
-
03:34 AM Misc #13704 (Closed): [PATCH] Exclude Changelog files from documentation.
- Applied in changeset trunk|r59713.
----------
Exclude Changelog files from documentation.
Patch from larskanis (Lars Kanis).
[Misc #13704][ruby-core:81878] -
03:34 AM Revision 99d64640 (git): Exclude Changelog files from documentation.
- Patch from larskanis (Lars Kanis).
[Misc #13704][ruby-core:81878]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59713 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
03:31 AM Feature #13849: Show --dump options in help
- Changed implementation to (1).
https://github.com/ruby/ruby/pull/1688
https://github.com/sonots/ruby/blob/d762ee5c1648da5a2b82c19c106fcc219b92df61/ruby.c -
02:52 AM Feature #13849: Show --dump options in help
- !! So, (1) was fine.
Hmm, I feel showing everything by one command makes easier to find options, so I will change implementation to (1). -
02:31 AM Feature #13849: Show --dump options in help
- sonots (Naotoshi Seo) wrote:
> I feel (2) is better based on the matz principle to keep help as compact as possible.
Compact help is `-h`, `--help` doesn't need to be.
-
12:46 AM Feature #13849: Show --dump options in help
- Sorry for raising a discussion again.
I noticed that Features list are shown bottom at --help.
```
$ ruby --help
...
--enable=feature[,...], --disable=feature[,...]
enable or disable features
--external-enc... -
02:57 AM Feature #13803: Add Socket::Ifaddr.vhid on supported platforms
- I also confirmed to build success with FreeBSD 11.0-RELEASE-p1
-
02:42 AM Bug #13856 (Closed): MinGW / mswin intermittent failure in test/socket/test_socket.rb
- Recently, there have been two Appveyor fails, [first](https://ci.appveyor.com/project/ruby/ruby/build/1.0.5036) and [second](https://ci.appveyor.com/project/ruby/ruby/build/1.0.5078).
Both listed the following as the error:
```
ru... -
02:28 AM Bug #13855: Hash#compact! returns nil if the hash is empty
- `nil` is returned if there is no change, not only if the hash is empty:
```
hash = { foo: :bar, one: :two } # => {:foo=>:bar, :one=>:two}
hash.compact! # => nil
```
This is consistent with many other bang metho... -
02:09 AM Revision ed740754 (git): skip unless PLATFORM is darwin.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59712 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
01:15 AM Bug #13566 (Closed): A process freezes at the beginning of C level backtrace when a certain SEGV is occurred
- Fixed by r59710.
- 01:13 AM Revision 5ba15ec8 (git): * properties.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59711 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
01:13 AM Revision 3bd01f99 (git): Fix C level backtrace on Darwin
- SEGV caused by invalid instruction call.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59710 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
12:58 AM Revision b8243bb8 (git): compile.c: fix loading pathobj
- * compile.c (ibf_load_iseq_each): location.pathobj may not be a
mere string now.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59709 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
12:43 AM Bug #13844 (Closed): Toplevel returns should fire ensures
- Applied in changeset trunk|r59708.
----------
compile.c: ensure after toplevel return
* compile.c (iseq_compile_each0): toplevel returns should fire
ensures. [ruby-core:82492] [Bug #13844] -
12:43 AM Revision d6347a46 (git): compile.c: ensure after toplevel return
- * compile.c (iseq_compile_each0): toplevel returns should fire
ensures. [ruby-core:82492] [Bug #13844]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59708 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
12:29 AM Bug #13758 (Feedback): TestRubyOptions#test_segv_setproctitle segfaults on AARCH64
- I can't reproduce on ruby -v: ruby 2.5.0dev (2017-09-01 trunk 59707) [aarch64-linux].
see also http://rubyci.s3.amazonaws.com/scw-ad7f67/ruby-trunk/recent.html
08/31/2017
-
10:21 PM Bug #13855: Hash#compact! returns nil if the hash is empty
- lucasbuchala (Lucas Buchala) wrote:
> Rather than a bug, I wonder if this is just a documentation omission.
> ...
Oh that's interesting - I hadn't noticed that returning nil if the object was unchanged was the actual behaviour there. I... -
06:44 PM Bug #13855: Hash#compact! returns nil if the hash is empty
- Hmm.
I had a look at class String and class Array what they do.
First Array:
array = [1,2,3] # => [1, 2, 3]
array.compact! # => nil
Next class String - it has no .compact but perhaps we can use
.delete! which may b... -
04:45 PM Bug #13855: Hash#compact! returns nil if the hash is empty
- Rather than a bug, I wonder if this is just a documentation omission.
In case of a documentation omission, I created a PR:
https://github.com/ruby/ruby/pull/1692 -
03:24 PM Bug #13855 (Closed): Hash#compact! returns nil if the hash is empty
- This behaviour feels like a bug to me.
From the documentation (with my emphasis):
> compact! → hsh
> ...
However if the hash contains no keys, the method returns nil.
~~~
irb(main):001:0> {}.compact!
=> nil
# For Compariso... - 03:41 PM Revision 3541e365 (git): * 2017-09-01
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59707 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
03:41 PM Revision e896e9b9 (git): Skip test_open_tempfile_path on EINVAL
- Looks like File::Constants::TMPFILE could be defined even when not
supported on system. Just skip the test when we get EINVAL on open(2).
* test/ruby/test_file.rb(test_open_tempfile_path):
Skip when EINVAL occured on File.open.
git-... -
02:51 PM Feature #13581: Syntax sugar for method reference
- my idea for optimising `&obj.method(:symbol)`
is that it already creates a proc (object) without going over a `Method` object,
i don't know if that would be an good idea for that. -
02:31 PM Feature #13581: Syntax sugar for method reference
- k0kubun (Takashi Kokubun) wrote:
> Another idea: `&obj:method`
Consider more complex example, `&(obj.some.method(args)):method`, not only a simple reciever.
`&` and `:` are separated too far. -
02:27 PM Feature #13581: Syntax sugar for method reference
- Hanmac (Hans Mackowiak) wrote:
> i am not sure about that:
> ...
It's different at all.
My example is a token `\.`, do not split.
> PS: when using "&obj.method(:symbol)" should that be optimized if able?
Probably, but it's not p... -
01:12 PM Feature #13581: Syntax sugar for method reference
- Oh, I'm so sad to hear `obj:method` (without `&`) is already valid. I still have hope to have it only when it's put with `&` in the last of arguments because that case is not valid for now.
```
irb(main):001:0> def obj(method); meth... -
12:56 PM Feature #13581: Syntax sugar for method reference
- k0kubun (Takashi Kokubun) wrote:
> Another idea: `&obj:method`
> ...
hm i like that idea, but think that might be a bit conflicting, that depends on if obj is an object or not?
~~~ ruby
obj = Object.new
obj:method #=> syntax error... -
12:30 PM Feature #13581: Syntax sugar for method reference
- Another idea: `&obj:method`
It just puts receiver between `&` and `:` from existing one. I'm not sure it conflicts with existing syntax or not but I feel it's consistent with `&:foo` syntax.
```ruby
roots = [1, 4, 9].map(&Math:sqr... -
12:10 PM Feature #13581: Syntax sugar for method reference
- > I am for adding syntax sugar for method reference. But I don't like proposed syntax (e.g. ->).
> ...
In my pet projects, I often alias `method` as `m`. It is readable enough, short enough and easy to remember, once you've seen it:
... -
10:10 AM Feature #13581: Syntax sugar for method reference
- nobu (Nobuyoshi Nakada) wrote:
> `obj\.method`
i am not sure about that:
~~~ ruby
obj\
.method
~~~
is already valid ruby code, so i am not sure
PS: when using "`&obj.method(:symbol)`" should that be optimized if able? -
08:48 AM Feature #13581: Syntax sugar for method reference
- `obj\.method`
-
06:31 AM Feature #13581: Syntax sugar for method reference
- I am for adding syntax sugar for method reference. But I don't like proposed syntax (e.g. `->`).
Any other idea?
Matz.
-
01:02 PM Feature #13784: Add Enumerable#filter as an alias of Enumerable#select
- matz (Yukihiro Matsumoto) wrote:
> Sounds OK. One concern left is `Hash#filter`.
> ...
I have added a bug to discuss the discrepancy in Hash's behavior: https://bugs.ruby-lang.org/issues/13795 -
09:09 AM Feature #13784: Add Enumerable#filter as an alias of Enumerable#select
- Sounds OK. One concern left is `Hash#filter`.
Matz.
-
06:37 AM Feature #13784: Add Enumerable#filter as an alias of Enumerable#select
- +1 because I like the name filter_map for #5663.
-
11:22 AM Revision de6b788f (git): add NEWS entry for [Feature #13568] r59704
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59705 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
11:16 AM Bug #13854 (Closed): `make golf` broken
- make golf が失敗します。
```
% make golf
...
compiling .../ruby/goruby.c golf_prelude.c
gcc: fatal error: cannot specify -o with -c, -S or -E with multiple files
compilation terminated.
uncommon.mk:951: ターゲット 'goruby.o' のレシピで失敗しました
``... -
11:14 AM Feature #13568 (Closed): File#path for O_TMPFILE fds has no meaning
- Applied in changeset trunk|r59704.
----------
File#path: Raise IOError when a file is O_TMPFILE
File#path for a file opened with O_TMPFILE has no meaning.
A filepath returned by this method isn't guarranteed about its accuracy,
but fi... -
07:04 AM Feature #13568: File#path for O_TMPFILE fds has no meaning
- Nobu's patch at [ruby-core:81329] fails when fd is closed... Updated the patch.
* Raise IOError when fptr->pathv is Qnil on File#path
* Set Qnil to fptr->pathv when opening file with O_TMPFILE
* File#to_path and FIle#path behave sam... -
06:05 AM Feature #13568: File#path for O_TMPFILE fds has no meaning
- I vote for raising exceptions (ENOENT?).
Matz.
-
11:14 AM Revision 75cda5e2 (git): File#path: Raise IOError when a file is O_TMPFILE
- File#path for a file opened with O_TMPFILE has no meaning.
A filepath returned by this method isn't guarranteed about its accuracy,
but files opened with O_TMPFILE are known its recorded path has no
meaning. So let them not to return an... -
09:06 AM Feature #13639: Add "RTMIN" and "RTMAX" to Signal.list
- I propose
* Signal::RTMIN
* Signal::RTMAX
instead.
Matz.
-
09:06 AM Feature #13770: Can't create valid Cyrillic-named class/module
- In the patch, I suggest adding something like
```c
if (rb_enc_islower(c, enc)) return FALSE;
```
immediately before or after
```c
if (rb_enc_isupper(c, enc)) return TRUE;
```
-
08:58 AM Bug #13769: IPAddr#ipv4_compat incorrect behavior
- Agreed with deprecating it. Other libraries like the ipaddress gem do not seem to have this, so I'll remove it by 2.5.
-
08:48 AM Feature #13789 (Rejected): Dir - methods
- Rejected. You can simply filter Dir entries. If you have concrete use-case of the method, reopen the issue, please.
Matz.
-
08:46 AM Feature #13839 (Rejected): String Interpolation Statements
- I think it should be done in the gem. Templating need not to be a part of the core.
Matz.
-
08:42 AM Misc #13747: MinGW trunk build available on Appveyor
- Thank you for providing CI for mingw.
I and branch maintainers monitors CI results by http://rubyci.org/
If you output certain index and LTSV files,
The crawler of results is implemented at https://github.com/ruby/rubyci/blob/mas... -
08:33 AM Revision 5f3c228f (git): Added NEWS for r59702
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59703 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
08:29 AM Feature #13803 (Closed): Add Socket::Ifaddr.vhid on supported platforms
- Applied in changeset trunk|r59702.
----------
Add Socket::Ifaddr.vhid on supported platforms [Feature #13803]
patched by Alan Somers -
08:18 AM Feature #13803 (Assigned): Add Socket::Ifaddr.vhid on supported platforms
-
07:19 AM Feature #13803: Add Socket::Ifaddr.vhid on supported platforms
- Although I don't tested, it seems fine except the document should use Integer instead of Fixnum.
-
08:29 AM Revision e7ddf878 (git): Add Socket::Ifaddr.vhid on supported platforms [Feature #13803]
- patched by Alan Somers
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59702 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
08:21 AM Bug #13597 (Closed): Does read_nonblock call remalloc for the buffer if does it just set the size attribute
- Applied in changeset trunk|r59701.
----------
io.c: shrink read buffer
* io.c (io_setstrbuf): return true if the buffer is newly created.
* io.c (io_set_read_length): shrink the read buffer if it is a new
object and is too large. [... -
06:59 AM Bug #13597: Does read_nonblock call remalloc for the buffer if does it just set the size attribute
- We discussed this in a developer meeting,
it is better to call realloc when outbuf is not given and
maxlen - len is bigger than 4K where len is the length actually read.
(if maxlen - len is too short, freeing memory is not worth than
... -
06:41 AM Bug #13597: Does read_nonblock call remalloc for the buffer if does it just set the size attribute
- I think that it's possible to call remalloc when
"outbuf" argument is not supplied to read_nonblock.
It makes possible to
automatically reduce memory with remalloc (without supplying "outbuf") and
reuse buffer without remalloc (wit... -
08:21 AM Revision 9f1994ed (git): io.c: shrink read buffer
- * io.c (io_setstrbuf): return true if the buffer is newly created.
* io.c (io_set_read_length): shrink the read buffer if it is a new
object and is too large. [ruby-core:81370] [Bug #13597]
git-svn-id: svn+ssh://ci.ruby-lang.org/rub... -
08:07 AM Revision bb03f028 (git): string.c: adjust indent [ci skip]
- * string.c (rb_str_enumerate_grapheme_clusters): adjust indent.
[Feature #13780]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59700 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
08:04 AM Revision 1f506de6 (git): test_syntax.rb: suppress warnings
- * test/ruby/test_syntax.rb (TestSyntax#test_return_toplevel):
suppress unreachable statement warnings.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59699 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
07:44 AM Feature #13849: Show --dump options in help
- Changed as:
```
$ ./ruby --help
Usage: ./ruby [switches] [--] [programfile] [arguments]
-0[octal] specify record separator (\0, if no argument)
-a autosplit mode with -n or -p (splits $_ into $F)
-c ... -
06:40 AM Feature #13849: Show --dump options in help
- What about `--help=dump` (`--help=feature` and so on)?
-
05:41 AM Feature #13849: Show --dump options in help
- I removed old --dump=help, and --dump=usage, and changed --dump=help to show help messages of --dump.
https://github.com/ruby/ruby/pull/1688
```
$ ./ruby --help
Usage: ./ruby [switches] [--] [programfile] [arguments]
...
-... -
07:36 AM Feature #13606 (Rejected): Enumerator equality and comparison
- Without any actual use case, there would be no effective definition of equality for enumerators.
FWIW, the initial design policy is, Enumerator is an abstract entity that only guarantees it responds to `each` for enumeration, and it's... -
07:34 AM Bug #13833: String#scanf("%a") incorrectly requires a sign on the (binary) exponent
- Hi, cabo.
I implemented to fix this bug and created PR:
https://github.com/ruby/ruby/pull/1689
Could you please check this? -
07:19 AM Feature #12733: Bundle bundler to ruby core
- It's OK as long as bundling bundler makes users happy (and I believe it would).
Matz.
-
07:02 AM Bug #12598: List files with Unicode license in LEGAL file
- Though GB2312 seems still needed, but we may be able to remove GB12345.
-
06:41 AM Bug #12598 (Assigned): List files with Unicode license in LEGAL file
-
06:59 AM Misc #12529 (Closed): LEGAL file covering all the license information within Ruby
-
06:43 AM Misc #12529: LEGAL file covering all the license information within Ruby
- >junaruga
Thanks. We reopen issue about UCD license issue: https://bugs.ruby-lang.org/issues/12598
Without UCD license, This issue is resolved.
-
06:44 AM Feature #13600 (Rejected): yield_self should be chainable/composable
- Function composition should **not** be implemented by `yield_self`.
Matz.
-
06:35 AM Feature #13780 (Closed): String#each_grapheme
- Applied in changeset trunk|r59698.
----------
String#each_grapheme_cluster and String#grapheme_clusters
added to enumerate grapheme clusters [Feature #13780] -
05:32 AM Feature #13780: String#each_grapheme
- `grapheme` sounds like an element in the grapheme cluster. How about `each_grapheme_cluster`?
If everyone gets used to the `grapheme` as an alias of `grapheme cluster`, we'd love to add an alias `each_grapheme`.
Matz.
-
06:35 AM Revision df49fc65 (git): String#each_grapheme_cluster and String#grapheme_clusters
- added to enumerate grapheme clusters [Feature #13780]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59698 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
06:26 AM Feature #6284: Add composition for procs
- Most languages do not define function composition in built-in operators, but provide them as function or method such as `compose`.
F.Y.I) https://rosettacode.org/wiki/Function_composition
In some few languages defined function comp... -
06:04 AM Feature #13618: [PATCH] auto fiber schedule for rb_wait_for_single_fd and rb_waitpid
- mame@ruby-lang.org wrote:
> I believe that this feature should be introduced with another
> name. I have no counterproposal, though. Sorry.
What about Thriber? Or Fred?
"Fread" might be confused with fread(3) function, and I ... -
05:49 AM Feature #13516 (Assigned): Improve the text of the circular require warning
-
05:48 AM Feature #13516 (Open): Improve the text of the circular require warning
- The update of the message is OK.
Matz.
-
05:47 AM Feature #13516 (Assigned): Improve the text of the circular require warning
-
05:41 AM Feature #13395: Add a method to check for not nil
- Your example is bit weak. Is there any **realistic** use-case for the method?
Matz.
-
05:31 AM Bug #13407 (Assigned): We have recv_nonblock but not send_nonblock... can we add it?
-
05:25 AM Feature #13630: :[] method should accept block in nice syntax
- The trunk accepts a block after `[]` now.
-
05:19 AM Feature #13686 (Assigned): Add states of scanner to tokens from Ripper.lex and Ripper::Filter#on_*
-
03:06 AM Revision 54217d68 (git): test_syntax.rb: assert output
- * test/ruby/test_syntax.rb (TestSyntax#test_return_toplevel):
assert expected output if given.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59697 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
03:05 AM Bug #13853 (Closed): Backport request r58323
- I picked commit from json-2.0.4 fixes.
Please backport attachment patch to ruby 2.2 and 2.3. -
02:07 AM Bug #13844: Toplevel returns should fire ensures
- The behavior was intentional.
-
01:25 AM Bug #13412: Infinite recursion with define_method may cause silent SEGV or cfp consistency error
- It seems to be fixed at trunk. Thank you.
But I guess that it is not due to r59606, but rather to r59630 and r59676.
```
$ git checkout $(git log --grep "trunk@59606" origin/trunk --format="%h") && git checkout -B work &&
make m... -
12:05 AM Revision 85603760 (git): `$=` is no longer effective. [ci skip]
- * doc/globals.rdoc: [DOC] `$=` is no longer effective.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59696 b2dd03c8-39d4-4d8f-98ff-823fe69b080e