Activity
From 06/01/2017 to 06/07/2017
06/07/2017
- 10:25 PM Revision 64ca4137 (git): * 2017-06-08
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59037 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 10:25 PM Revision 96b75bb1 (git): * tool/make-snapshot: prefer to use a make command
- set in the MAKE or make env variable.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59036 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
08:13 PM Bug #13632: Not processable interrupt queue for a thread after it's notified that FD is closed in some other thread.
- Eric Wong <normalperson@yhbt.net> wrote:
> sir.nickolas@gmail.com wrote:
> > https://bugs.ruby-lang.org/issues/13632
>
> r59020 should fix it trivially in trunk.
Make that r59028 :x r59020 interacted badly with r57422
> Back... -
- Closing to trigger backport
-
- Current rb_thread_fd_close in 2.2, 2.3, and 2.4 branches will infinite loop for
C exts and not make forward progress without rb_thread_schedule()
-
06:16 PM Bug #13635: ruby and linux-pf or linux-zen kernels
- nobu (Nobuyoshi Nakada) wrote:
> Try more recent versions, 2.3.4, 2.4.1, and the trunk if possible.
I can't compile the ruby 2.3.4. I don't know how to set custom openssl directory (--with-openssl-dir argument is ignored) -
06:16 AM Bug #13635: ruby and linux-pf or linux-zen kernels
- Thank you for the logs. While I can't find the exact location of failure at one sight, I'll make time to take a more closer look at them.
-
- and `rails server`
-
- shyouhei (Shyouhei Urabe) wrote:
> As you have already noticed the ruby process dies inside of libc, most possibly inside of malloc. Is it possible for you to run the process with valgrind? That could perhaps show something.
Yes, a... -
04:23 AM Bug #13635 (Feedback): ruby and linux-pf or linux-zen kernels
- Try more recent versions, 2.3.4, 2.4.1, and the trunk if possible.
-
- As you have already noticed the ruby process dies inside of libc, most possibly inside of malloc. Is it possible for you to run the process with valgrind? That could perhaps show something.
-
05:58 PM Bug #12203: dumper.c static int yaml_emitter_dump_scalar two variables have the same value
- shyouhei (Shyouhei Urabe) wrote:
> They are passed to a macro. I guess the author intentionally separated these two because merging them makes the code less intuitive. It seems OK to be optimized.
Maybe reassign to someone else? Or... -
03:57 PM Feature #13050: Readline: expose rl_completion_quote_character variable
- Are there any problems with applying this patch? I'm happy to make changes if something is blocking it.
Unicode support isn't going to be possible without upstream changes in Readline. -
- * load.c (rb_f_load, rb_require_internal): DTrace hooks should not
have side effects, i.e., conversion to String.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59035 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
02:18 PM Bug #13324 (Open): IRB Segmentation Fault from eval infinite loop
- The issue is not the stack overflow but the segmentation fault I described when running the same code in the above listed irb version.
-
01:02 PM Bug #13636: REXML::Document.parse_stream doesn't handle when closing tag not provided
- Thanks for your report.
I've added a validation on end of document. -
- Applied in changeset trunk|r59033.
----------
rexml: add close tag check on end of document to StreamParser
[ruby-core:81593] [Bug #13636]
Reported by Anton Sivakov. Thanks!!! - 01:01 PM Revision 0911dd2a (git): * properties.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59034 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 01:01 PM Revision d311921d (git): rexml: add close tag check on end of document to StreamParser
- [ruby-core:81593] [Bug #13636]
Reported by Anton Sivakov. Thanks!!!
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59033 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- samuel@oriontransfer.org wrote:
> Thanks for that idea.
>
> If that's the case, when appending to the write buffer:
>
> ~~~
> write_buffer = String.new.b
> unicode_string = "\u1234".force_encoding("UTF-8")
> write_buffer << un... - 12:32 AM Revision c2127d0a (git): common.mk: update dependencies after r58978
- Using "tool/update-deps --fix"
* common.mk (file.$(OBJEXT)): depend on id.h
(rational.$(OBJEXT)): ditto
(string.$(OBJEXT)): sort alphabetically
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59032 b2dd03c8-39d4-4d8f-98ff-823fe69... - 12:32 AM Revision b550b28a (git): * properties.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59031 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 12:32 AM Revision 27b8ef7f (git): thread.c: avoid busy looping on rb_thread_fd_close
- We no longer use it this function, but extensions do, and
we need to ensure it continues to work for them.
* thread.c (rb_thread_fd_close): schedule other threads in loop
* ext/-test-/thread_fd_close/thread_fd_close.c: new file
* ext/-t... -
12:12 AM Bug #13633 (Rejected): pod update crash
- You mixed rvm ruby (2.3) and system ruby(2.0.0).
06/06/2017
-
- Lets ensure none of our C functions use too much stack space and
fix all excessive stack usage before releasing the next version.
Reducing C stack usage should reduce conservative GC scanning
time and improve performance.
Hopefully... - 10:55 PM Revision 34949547 (git): * 2017-06-07
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59029 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 10:55 PM Revision 10421fb1 (git): IO#close: do not enqueue redundant interrupts (take #2)
- Enqueuing multiple errors for one event causes spurious errors
down the line, as reported by Nikolay Vashchenko in
https://bugs.ruby-lang.org/issues/13632
This should fix bad interactions with test_race_gets_and_close
in test/ruby/test_... -
-
- Expected to get exception for xml3 example
-
- I've tried to use REXML for parsing but got unexpected behavior:
Here is example:
~~~ ruby
require 'rexml/document'
require 'rexml/streamlistener'
class Handler include REXML::StreamListener end
xml1 = StringIO.new("<body><... -
- OS: ArchLinux
Kernel: 4.11.3-pf or 4.11.3-zen
ruby 2.3.1 #compiling
~~~
*** Error in `../../miniruby': corrupted double-linked list: 0x0000000001983d70 ***
*** Error in `../../miniruby': malloc(): memory corruption: 0x00007ffd2b... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59027 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
10:34 AM Revision 267323ca (git): add test_ill_formed_utf_8_replace to test recommended number of \uFFFD
- Add test method test_ill_formed_utf_8_replace to test/ruby/test_transcode.rb
to check for the recommended number of \uFFFD replacement characters.
This is the first part, using ill-formed prefixes, with suffixes up to
the length of the o... -
08:27 AM Misc #13634: NilClass is lying about respond_to?(:clone)
- @rovf: that was fixed between 2.3 and 2.4
i currently have 2.4.1 for testing, and in that:
`1.clone` and `nil.clone` just returns the object instead of TypeError -
08:12 AM Misc #13634 (Open): NilClass is lying about respond_to?(:clone)
- I put this under "Misc", because I'm not sure, whether this is a bug, a feature request, or maybe a deliberate (but for me obscure) decision in language design:
NilClass (and Fixnum) do not support clone. That's fine. However,
... -
07:14 AM Bug #13633 (Rejected): pod update crash
- P35251:OldTaiwan juan.reyes$ pod update
/Users/juan.reyes/.rvm/gems/ruby-2.4.1@global/gems/json-2.1.0/lib/json/ext/parser.bundle: [BUG] Segmentation fault
ruby 2.0.0p648 (2015-12-16 revision 53162) [universal.x86_64-darwin16]
-- Cra... -
07:11 AM Revision 7d041e87 (git): re-revert r59020
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59025 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59024 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59023 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59022 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- vmakarov@redhat.com wrote:
<snip>
Thanks for detailed response.
> I should remove -Werror=incompatible-pointer-types from the script and
> restrict added by me. They are not important.
Actually, I've discovered AC_C_RESTRICT... -
- sir.nickolas@gmail.com wrote:
> https://bugs.ruby-lang.org/issues/13632
r59020 should fix it trivially in trunk.
Backporting to <= 2.4 is only a little different due to the
data structure change:
s/wfd->fd = -1/th->waiting_f... -
12:13 AM Bug #13632 (Closed): Not processable interrupt queue for a thread after it's notified that FD is closed in some other thread. - Applied in changeset trunk|r59020.
----------
IO#close: do not enqueue redundant interrupts
Enqueuing multiple errors for one event causes spurious errors
down the line, as reported by Nikolay Vashchenko in
https://bugs.ruby-lang.org/i... - 12:13 AM Revision df05ad53 (git): * 2017-06-06
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59021 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 12:13 AM Revision 59fb9297 (git): IO#close: do not enqueue redundant interrupts
- Enqueuing multiple errors for one event causes spurious errors
down the line, as reported by Nikolay Vashchenko in
https://bugs.ruby-lang.org/issues/13632
* thread.c (rb_notify_fd_close): do not enqueue multiple interrupts
[ruby-core:...
06/05/2017
-
- sir.nickolas@gmail.com wrote:
> Bug #13632: Not processable interrupt queue for a thread after it's notified that FD is closed in some other thread.
> https://bugs.ruby-lang.org/issues/13632
Investigating. I've been looking at IO ... -
04:16 PM Bug #13632 (Closed): Not processable interrupt queue for a thread after it's notified that FD is closed in some other thread.
- In the bugfix for https://bugs.ruby-lang.org/issues/13076 has been introduced another bug, caused by a busy waiting in rb_notify_fd_close method, while the FD is being released. During this waiting, it pumps huge amounts of the ruby_erro...
-
09:32 PM Bug #12642: Net::HTTP populates host header incorrectly when using an IPv6 Address
- Below monkey patching code works for me. Is there a better way?
~~~ ruby
module MonkeyPatch
module Net
module HTTP
end
end
end
module MonkeyPatch::Net::HTTP
# workaround for https://bugs.ruby-lang.org/issues/12... -
04:32 PM Feature #13570: Using mkmf for ruby/spec C API specs
- nobu (Nobuyoshi Nakada) wrote:
> test-spec runs fine on AppVeyor, test/ruby/test_rubyoptions.rb has a failure when locale and filesystem encodings differ.
> ...
Thank you for working on that (in addition to everything else you do).
... -
- test-spec runs fine on AppVeyor, test/ruby/test_rubyoptions.rb has a failure when locale and filesystem encodings differ.
Another problem is that it consumes 15 min, vs 8 min without tests. -
06:13 AM Feature #13570: Using mkmf for ruby/spec C API specs
- MSP-Greg (Greg L) wrote:
> A few people seem to state that trunk builds and tests fine on mswin, but Appveyor doesn't run test-all or test-spec/test-rubyspec. I'd be interested to know why...
Our hero nobu is testing running test-al... -
- caschip (Aad Schippers) wrote:
> Statement '`module`' requires a name that does not exist in the scope yet.
A (small) correction: it may exist syntactically,
```
$ ruby -c -e 'X=1; module X; end'
Syntax OK
```
but a `TypeErr... -
10:02 AM Bug #13623: meta-programming, adding sub-module fails with syntax error
- Ok, you make it very clear. Indeed, in working_meta '`Bar`' is not a constant but a name when statement '`module`' is evaluated. Statement '`module`' syntactically requires a name ~~that does not exist in the scope yet.~~ That name can b...
-
-
-
- * win32/win32.c (skipspace, w32_cmdvector): get rid of iswspace(),
which is locale dependent.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59019 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59018 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * vm_eval.c (yield_under): do not inform Proc is lambda or not.
After that invoke_block_from_c_bh() checks it.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59017 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * internal.h (rb_yield_lambda): rename to rb_yield_force_blockarg()
because this function prohibt lambda arg setup (strict setup).
* vm.c (invoke_iseq_block_from_c): remove splattable argument because
it is not used.
* vm.c (invoke... - 05:43 AM Revision 88c85c88 (git): * 2017-06-05
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59015 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * vm_args.c (enum arg_setup_type): remove arg_setup_lambda because it is
same as arg_setup_method.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59014 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
03:22 AM Bug #13191 (Closed): sample/pty/shl.rb がうまく動かない
- r57530 の backport のため Backport 欄を REQUIRED に戻します。
06/04/2017
-
11:56 PM Bug #13589: unmatched opening backtick / closing quote in NoMethodError: undefined method `name' for {}:Hash
- I'm curious what Matz thinks
-
10:51 PM Bug #13605: GC bug calling `ObjectSpace.each_object`
- robertgleeson (Robert Gleeson) wrote:
> The segfault no longer happens, since https://github.com/pry/pry/pull/1611/commits/94316852f5c1114f3073876558085835f2cf5377.
> ...
Spoke too soon, i think we just got lucky, it still happens when... -
- The segfault no longer happens, since https://github.com/pry/pry/pull/1611/commits/94316852f5c1114f3073876558085835f2cf5377.
if you want to reproduce a commit before that one should work, on the `respond_to-2.4-warnings` branch. -
- Another case:
Ruby v2.4.1 (ruby), Pry v0.10.4, method_source v0.8.2, CodeRay v1.1.1, Pry::Slop v3.4.0
/home/travis/build/pry/pry/spec/pry_output_spec.rb:119: warning: assigned but unused variable - custom_io
........................... -
- robertgleeson (Robert Gleeson) wrote:
> znz (Kazuhiro NISHIYAMA) wrote:
> ...
I realise my comment isn't clear, here's very simple code to show what i mean:
deprecated_constants = [:Fixnum, :TimeoutError, :Bignum, :FALSE, :TRUE, :NI... -
- znz (Kazuhiro NISHIYAMA) wrote:
> How about `class Object; deprecate_constant :Fixnum, :Bignum; end`?
> ...
It would be nice to have `constant_deprecated?`.
To avoid all of these warnings while supporting <2.4 and >=2.4 i track ... -
05:06 PM Feature #12589: VM performance improvement proposal
- normalperson (Eric Wong) wrote:
>
> ...
Yes, I know about GNULighting, Eric. It is an old project. It is
just a portable assembler.
Using it for JIT, it is like building a car having only a wheel. To
get a good perfor... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59013 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * test/ruby/test_require.rb (test_require_with_unc): remove extra
slash. the result of File.expand_path has a slash just follows
the drive letter.
https://github.com/ruby/ruby/commit/4ef849bd9014746821402e21053a53ea61b3690d#commit...
06/03/2017
-
11:38 PM Feature #9323: IO#writev
- I think this is a great idea. It avoids a ton of string issues - e.g. concatenating strings in Ruby before writing them out. It would be great if #write could take an array, and if possible, call writev.
-
- Thanks for that idea.
If that's the case, when appending to the write buffer:
~~~
write_buffer = String.new.b
unicode_string = "\u1234".force_encoding("UTF-8")
write_buffer << unicode_string
write_buffer.encoding # Changed from... -
- samuel@oriontransfer.org wrote:
> https://bugs.ruby-lang.org/issues/13626
I used to want this, too; but then I realized IO#read and
similar methods will always return a binary string when given a
length limit.
So String#slice! ... -
- It's a common pattern in IO buffering, to read a part of a string while leaving the remainder.
~~~
# Consume only part of the read buffer:
result = @read_buffer.byteslice(0, size)
@read_buffer = @read_buffer.byteslice(size, @read_b... -
10:17 PM Misc #12935: Webrick: Update HTTP Status codes, share them
- Could the namespaces be open, thereby allowing me to only require this file instead of the whole of `net/http`? It seems to me that, if I require this file without the `Net::HTTP` constant be defined, that this will fail.
-
08:17 PM Revision 7c8a060b (git): array.c: docs for Array#{sort,sort!}
- * array.c: [DOC] make example in the docs for Array#{sort,sort!}
match the call-seq and description by using the same block vars.
Based on a patch by Roque Pinel (repinel). [Fix GH-1628]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/... - 05:11 PM Revision 4bf1fc3a (git): * 2017-06-04
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59010 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * test/ruby/test_require.rb (test_require_with_unc): ignore EPERM.
GetFileAttributes and CreateFile with backup semantics fail at a
symlink in a shared folder to another shared folder.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/tru... -
04:39 PM Feature #13630: :[] method should accept block in nice syntax
- I agree. I always wondered about this too.
I did not make a suggestion like this because I suspect that one reason may be a parser issue, as otherwise it would most likely have been done already.
In particular for elements without ... -
12:24 PM Feature #13630 (Closed): :[] method should accept block in nice syntax
- ~~~ ruby
# given
module Bam
def self.[](bam)
yield bam
end
end
# SyntaxError: unexpected keyword_do_block
Bam['bam'] do |b|
puts b
end
# SyntaxError: unexpected { arg, expecting end-of-input
Bam['bam'] { |b|
... -
02:45 PM Bug #13631 (Closed): Cannot disable site and vendor directories
- (Related to bug #12392?)
mkconfig.rb deletes directory settings passed to configure if they are set to "no". Perhaps verconf.h.tmpl should check to see if a setting is missing
instead of if it's set to "no"?
This patch corrects th... -
- * file.c (path_check_0): preserve encoding of path name in warning
message.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59008 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- The ext subdirectory Makefile's don't seem to invoke the "install-rb" rule during a static build.
As a workaround I ran this command before "make install":
find ext -name Makefile | xargs -L 1 sed -i "s/static: \\$/static: install-rb... -
- wanabe (_ wanabe) wrote:
> I guess the code snippet is from pry. https://github.com/pry/pry/blob/c18601d6a4ff97d1b6599ccd9ffc8c63b8d8fccb/lib/pry/input_completer.rb#L172
> ...
Thanks wanabe.
shyouhei (Shyouhei Urabe) wrote:
> What ... -
- * ruby.c (dladdr_path): dladdr is provided on recent cygwin, but
GetModuleFileNameW is used instead of it.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59007 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Nothing changed actually.
-
09:54 AM Bug #13629 (Rejected): Improve performance for copying array elements
- ary_memcpy0() has calculated the cache line size every time when copy array elements.
This patch will replace it with pre calculated value of cache line size.
Array#+ will be faster around 2%.
### Before
~~~
Array#+(other)... -
-
- The docs for Proc#call have been fixed with above workaround in r57767 and related backports; the bug still exists, though.
I also opened an issue on GitHub: https://github.com/rdoc/rdoc/issues/452. -
- VM_FRAME_FLAG_LAMBDA. So that lambda block frame is
VM_FRAME_MAGIC_BLOCK | VM_FRAME_FLAG_LAMBDA.
* vm_core.h: remvoe VM_FRAME_MAGIC_PROC because nobody uses it.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59006 b2dd03c8-39d4-4... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59005 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * test/ruby/test_require.rb (assert_require_insecure_path): get
rid of setting Encoding.default_internal, which affects load
path conversion.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59004 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
-
- `module` statement requires a **name**, not a constant object.
-
- So you are saying this is how it should work and not a bug? If that is true, I should close this. What do you mean when you say that `Object::const_get('Foo')::Bar` is syntactically a constant. Its contains characters that are not approp...
-
- It's my mistake. I forgot to install `make` package of i686 environment.
`configure` detected msys `make. It's caused by this issue.
After installing cygwin-i686 make, I'm done to build with cygwin i686.
Thanks nobu for your advice. -
- Attached full log of stdout
-
- Eric,
Thanks for the patch. I'll build tomorrow, isolate the test, then run it a few hundred times...
> And yeah, maybe you can figure out a way to improve Process.times for other Windows users.
After I learn c, I'll get right... -
- Greg.mpls@gmail.com wrote:
> Thanks for the response. Reminder (which I try to mention from time to time) - I'm not a c type, and I essentially just use Windows.
Maybe you'll become a "c type" anyways :)
I never set out to be, ei... -
04:11 AM Bug #13628 (Closed): rdoc json.gz files differ across builds
- lib/rdoc/generator/json_index.rb inserts the build time
into generated .gz files,
so they differ across each build,
making it hard for distributions like openSUSE's
to create bit-identical binary packages when those are using rdoc.
... -
- rdoc.rb inserts the current time into created.rid
so the file differs across each build,
making it hard for distributions like openSUSE's
to create bit-identical binary packages when those are using rdoc.
See https://reproducible-b... -
- vmakarov@redhat.com wrote:
> I've updated README.md of the project. I added performance (wall, CPU time, memory consumption) comparison of the current state of MJIT with some other MRI versions (v2.0, base) and implementations (JRuby,... -
- Is there a workaround for this? How should we connect to ipv6 servers?
- 01:04 AM Revision e6e29212 (git): test: attempt to reduce failures in assert_cpu_usage_low
- Try to make this test less fragile by taking into account
the worst case kernel timing resolution.
[ruby-core:81540]
* test/lib/test/unit/assertions.rb (assert_cpu_usage_low):
clamp measurement to minimum measurable time and warn
ab...
06/02/2017
-
- eregontp@gmail.com wrote:
> This is interesting work, I am curious to see how it will work out.
Thanks for the interest.
> This looks similar to what Crystal has [1].
Right. But actually I would use MRI 1.8 green threads as
... -
06:05 PM Feature #13618: [PATCH] auto fiber schedule for rb_wait_for_single_fd and rb_waitpid
- This is interesting work, I am curious to see how it will work out.
This looks similar to what Crystal has [1].
Does Kernel#puts potentially yields to another auto-Fiber?
I think that would be very counter-intuitive, but it would ... -
- eregontp@gmail.com wrote:
> Issue #13620 has been updated by Eregon (Benoit Daloze).
>
>
> normalperson (Eric Wong) wrote:
> > Honestly, this proposal seems so wrong and outlandish that I
> > wonder if I am misreading or misun... -
01:31 PM Feature #13620: Simplifying MRI's build system: always make install
- Just a word of encouragement here.
The ways in which ruby seems to differ between installed and in-tree testing has bitten me doing Ruby+OMR work a number of times, and I'd love to see some simplification. (In particular, I load Ruby... -
- normalperson (Eric Wong) wrote:
> Honestly, this proposal seems so wrong and outlandish that I
> ...
I see your point, but I think we have a rather different view on this question.
Let me show you my opinion to understand better.
... -
09:43 PM Bug #13548: miniruby SEGV while building with non-default CFLAGS (caused by __builtin_setjmp)
- nobu (Nobuyoshi Nakada) wrote:
> It is not assigned since r43522.
I'm sorry. What I wrote was not what I meant.
The opengroup docs say setjmp should be used as "entire controlling expression" (with slight possible modifications), ... -
- Eric,
Thanks for the response. Reminder (which I try to mention from time to time) - I'm not a c type, and I essentially just use Windows.
> Curious, do you know what the kernel timer resolution is on your system?
No idea. But... -
- Greg.mpls@gmail.com wrote:
> Bug #13624: MinGW - TestIO#test_copy_stream_no_busy_wait - new failure
> https://bugs.ruby-lang.org/issues/13624
<snip>
> Today's MinGW build had a new failure, one that I don't recall seeing before.... -
- Today's MinGW build had a new failure, one that I don't recall seeing before.
Code is (located [here](https://github.com/ruby/ruby/blob/trunk/test/ruby/test_io.rb#L535-L546)):
```ruby
def test_copy_stream_no_busy_wait
msg = 'r5... -
- Applied in changeset trunk|r59002.
----------
string.c: docs for String#split
* string.c: [DOC] clarify docs for String#split when called
with limit and capture groups.
Reported by Cichol Tsai. [ruby-core:81505] [Bug #13621] -
- * string.c: [DOC] clarify docs for String#split when called
with limit and capture groups.
Reported by Cichol Tsai. [ruby-core:81505] [Bug #13621]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59002 b2dd03c8-39d4-4d8f-98ff-823f... -
- Eregon (Benoit Daloze) wrote:
> Or do we have a way to test CI (Travis + rubyci.org) before committing?
As you know, Travis will run on a PR.
A few people seem to state that trunk builds and tests fine on mswin, but Appveyor doesn... -
- Ran a MinGW build on `ruby 2.5.0dev 2017-06-02 58998`. Ran tests three ways:
1. `make test-spec` - pkg/install bin folder in path
2. `make test-spec` - pkg/install bin folder not in path
3. `mspec` - pkg/install bin folder in path
... -
- I'll try a MinGW build shortly.
Re `IO.copy_stream`, I believe it has existed since [Ruby 1.9.3](http://ruby-doc.org/core-1.9.3/IO.html#method-c-copy_stream), which should be far enough back for current test code. Also, I've only pai... -
- Here is a version of the spec_helper.rb working on MRI 2.2 to trunk on Linux (and I would expect macOS as well).
@Greg and @nobu:
Could you test it on Windows?
Then should I commit it?
Or do we have a way to test CI (Travis + rub... -
- Sounds good, I did not know IO.copy_stream can be used with 2 path Strings as well. It's a bit of a strange name for "cp".
But I think I slightly prefer the current implementation, it uses only well-known basic functionality such as Fil... -
- Eregon (Benoit Daloze) wrote:
> MSpec's #cp should use "rb"/"wb" modes obviously.
Why not `IO.copy_stream`?
-
04:40 PM Bug #13593: Addrinfo#== behaves oddly
- I wonder if naive comparison like this is advisable?
-
04:13 PM Feature #13625 (Rejected): BigDecimal short form / shorthand
- Add a shorthand for creating a BigDecimal, similar to how 1.2r creates a Rational.
~~~ ruby
> 3.1d
=> #<BigDecimal:7fde9def71c0,'0.31E1',18(18)>
~~~
- 03:38 PM Revision cd4cbc7b (git): * 2017-06-03
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59001 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59000 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- OK, Closing. Thank you.
-
03:23 PM Feature #3719: open-uri should allow redirects from http to https
- (I have no idea why I deleted the parent task, sorry about that.)
-
- With #859 fixed (thank you!), can this now be closed?
-
- Well `const_get('Foo')` is syntactically a non-constant while `const_get('Foo')::Bar` is. This is the ultimate reason why working_meta works but failing_meta fails. If you want to meta-program you have to be explicit like `const_get('F...
-
- ~~~ruby
module Foo
end
# Failing with syntax error is the code below
module Object::const_get( 'Foo' )
module Bar
end
end
~~~ -
- The goal is to add a sub-module to a higher level module. The higher level module is derived from its name in a string. This works in one case and gives an unexpected syntax error in another case.
```
failing_meta:4: syntax error, un... -
- * test/ruby/test_require.rb (assert_require_insecure_path): more
tests for loading insecure path.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58999 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
02:08 PM Misc #13622 (Assigned): Documentation missing
- In documentation for method IO.nread important information is missing: you must do 'require "io/wait"' before using it. May be some other methods of IO in 'io/wait' are missed this IMPORTANT notice.
-
09:26 AM Bug #13616: Zlib::GzipReader#pos underflows after calling #ungetbyte or #ungetc at start of file
- Here's an attempt at a patch to check if pos will be negative and handle that scenario accordingly.
-
- @nobu Any update on this? I think your patch is OK.
-
- * test/ruby/test_require.rb (assert_require_nonascii_path):
fallback when LANG=C.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58998 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * test/ruby/test_require.rb (assert_require_nonascii_path): the
path in error message is converted to filesystem encoding.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58997 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * file.c (rb_find_file_safe): preserve encoding of path in
SecurityError messages.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58996 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Can you try with Ruby 2.4.1?
And `second run` is caused by rspec specification. It's not interpreter's bug.
-
- I attached result of `bash -x /path/to/configure`
06/01/2017
-
- eregontp@gmail.com wrote:
> https://bugs.ruby-lang.org/issues/13620
> Hello all,
>
> I've been bitten recently when modifying ruby/spec or in #13570 by the sheer number of different configurations to build and test in MRI.
> Cur... -
05:17 PM Feature #13620: Simplifying MRI's build system: always make install
- nobu (Nobuyoshi Nakada) wrote:
> Let's zap in-source-dir builds first.
I don't agree.
I hadn't see a software which denies in-source-dir builds.
> ...
Before changing something in editor, I must wait running current code.
I don'... -
- naruse (Yui NARUSE) wrote:
> I object this.
> ...
Actually the numbers above are for building just after a pull.
And if any file is touched, it takes longer than install-nodoc.
> But on developing, you need to compare with null bui... -
- nobu (Nobuyoshi Nakada) wrote:
> Let's zap in-source-dir builds first.
I want to agree with you, but every users of tarball packages run `configure` in the directory where it exists. -
- Let's zap in-source-dir builds first.
-
- I object this.
You are counting only full build.
But on developing, you need to compare with null build.
```
% time make -j8 main
CC = clang
LD = ld
LDSHARED = clang -dynamiclib
CFLAGS = -O3 -march=native -gdwarf -fno-fa... -
- I think runruby is needed for cross compilations.
By theory you can't test a cross-compiled ruby binary so I guess it might make sense to install before test. But I'm quite skeptical about the possibility of deleting runruby. -
- Hello all,
I've been bitten recently when modifying ruby/spec or in #13570 by the sheer number of different configurations to build and test in MRI.
Currently, I know 4 of them, and I can tell you it is a big headache to make it work... -
- ko1@atdot.net wrote:
> My opinion is opposite. I think "For human being using threading is too hard to use correctly" or "Rubyist shouldn't care about threading difficulties". I agree my opinion is extreme and many "advanced" programme... -
- normalperson (Eric Wong) wrote:
> I disagree. I do not recall Ruby 1.8 Threads being a big problem
> ...
...
> However, I do not believe it
> ...
...
> And yes, I think native threading bugs are trickier to track down
> ...
...
... -
- ko1@atdot.net wrote:
> Issue #13618 has been updated by ko1 (Koichi Sasada).
>
>
> Thank you for your great work.
You're welcome :)
> # summary of this comment
>
> Recent days I'm thinking about this feature's "safety" or... -
- Another idea is change this name from Fiber but thread-related name, but implementation is based on Fiber. It means resurrection of ruby 1.8 green thread without time based preemption (actually, implementation is similar).
Personally ... -
- Thank you for your great work.
# summary of this comment
Recent days I'm thinking about this feature's "safety" or "dependability".
Because of this issue, I think it is difficult to employ this feature right now.
# Non-auto-fib... -
- Pull request below for non-"git am" users...
I tried my best to add many comments throughout the code.
I realize this is a lot of new code; and not a typical or common
usage of kqueue or epoll. The kqueue code ended up being ver... -
- ```
auto fiber schedule for rb_wait_for_single_fd and rb_waitpid
Implement automatic Fiber yield and resume when running
rb_wait_for_single_fd and rb_waitpid.
The Ruby API changes for Fiber are named after existing Thread
method... -
- MSP-Greg (Greg L) wrote:
> I checked on MinGW, and there is not an issue with `File.rename` with `src` and `dest` being on different drives. Where I got that from, I don't know...
It's the semantics of the rename(2) syscall on Linux... -
- I checked on MinGW, and there is not an issue with `File.rename` with `src` and `dest` being on different drives. Where I got that from, I don't know...
Hence, on MinGW/Windows, rename will work in all situations.
> MSpec's #cp sh... -
- MSP-Greg (Greg L) wrote:
> Benoit,
> ...
Oh, wow, thanks and nice find!
MSpec's #cp should use "rb"/"wb" modes obviously.
Would it work with that?
> Hence, since we know the `src` and `dest` are on the same partition/drive, I used... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58995 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * A system port might be taken by another process at any time.
* There are no useful expectations in this spec.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58994 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58993 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * Avoids failing the spec if rubyspec_temp is not empty.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58992 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * See https://bugs.ruby-lang.org/issues/13570.
* Found by MSP-Greg (Greg L).
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58991 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * dir.c (dir_data_type): set RUBY_TYPED_WB_PROTECTED.
Insert WBs for dir_data::path.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58990 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 03:12 PM Revision 44396dbe (git): * 2017-06-02
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58989 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * proc.c (ruby_binding_data_type): set RUBY_TYPED_WB_PROTECTED.
Insert write barriers (WBs) to all of writes.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58988 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- A documentation issue.
the `limit` limits only split fields, not separators. -
01:14 PM Bug #13621 (Closed): String#split returns an array longer than given limit, when passing a regexp with groups
- The String#split documentation(http://ruby-doc.org/core-2.4.1/String.html#method-i-split) described:
> If pattern is a Regexp, str is divided where the pattern matches. Whenever the pattern matches a zero-length string, str is split i... -
- * load.c (rb_require_internal): convert to path name with the
given safe level, without setting global safe level.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58987 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58986 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- When I invoke `configure` with cygwin i686 environment, I got following error:
```
config.status: creating Makefile
/usr/bin/sed: -e expression #1, char 18: unterminated `s' command
make: *** No rule to make target 'info-program'. ... -
- * vm_eval.c (check_funcall_missing): revert r58984. should call
method_missing if respond_to_missing is not redefined.
* vm_eval.c (rb_check_funcall_default): return the default value
if respond_to_missing and method_missing are no... -
- * vm_eval.c (check_funcall_missing): basic_obj_respond_to_missing
returns Qundef if respond_to_missing is not redefined.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58984 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58983 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * debug.c (ruby_dummy_gdb_enums): add enums for RObject, RModule,
RString, RArray.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58982 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- On DOSish systems, there is a warning message for \r\n line endings on shebang line.
Improve this message from "shebang line ends with \r may cause a problem"
to "shebang line ending with \r may cause problems".
git-svn-id: svn+ssh://ci... -
- `require` searches a library across load paths.
When many unreadable files matched, do you want all of them to be reported?
I think it would not make sense unless reporting the full path name.
Maybe warnings for existent but unloadabl... -
- Could you file this issue to https://github.com/ruby/psych ?
-
- I've updated README.md of the project. I added performance (wall, CPU time, memory consumption) comparison of the current state of MJIT with some other MRI versions (v2.0, base) and implementations (JRuby, Graal, OMR) on different bench...
-
- 12:05 AM Revision eb59047e (git): * 2017-06-01
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58980 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * vm_core.h: rename absolute_path to realpath because it is expected name.
external APIs (#absolute_path methods) are remained.
* vm_core.h: remove rb_iseq_location_struct::path and
rb_iseq_location_struct::absolute_path and introdu...