Activity
From 04/23/2017 to 04/29/2017
04/29/2017
-
08:41 PM Feature #13211: Hash#delete taking a splat
- I've attached a patch of what I'm talking about, which should hopefully be more clear. The idea is that you could delete multiple values from a hash at once, which is valuable in its own right. Additionally, the return value is changed t...
- 10:50 AM Revision b7ad5496 (git): load.c: remove a redundant rb_str_freeze call
- rb_file_expand_path_fast already performs the buffer shrinking
rb_str_freeze does (via expand_path macro in file.c); the
result of rb_fstring is always frozen, and that rb_fstring
call is the last use of `expanded_path` in its scope.
lo... -
10:27 AM Revision 8a741981 (git): proc.c: recursion loop
- * proc.c (rb_block_min_max_arity, rb_method_entry_min_max_arity):
turn loop by recursion into goto.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58505 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Possible of course, but I'm not a big fan of this.
```diff
diff --git i/misc/ruby-mode.el w/misc/ruby-mode.el
index b1abd18a9e..5e8a6a1646 100644
--- i/misc/ruby-mode.el
+++ w/misc/ruby-mode.el
@@ -135,7 +135,7 @@
(concat "[?... -
- Applied in changeset trunk|r58503.
----------
node.h: sign-extend
* node.h (nd_line): should sign-extend. shifting `VALUE` extends
with zero bits if `sizeof(VALUE)` equals to `sizeof(int)`. the
zero bits are truncated if `sizeof(... - 02:58 AM Revision 4bf532ad (git): * 2017-04-29
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58504 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * node.h (nd_line): should sign-extend. shifting `VALUE` extends
with zero bits if `sizeof(VALUE)` equals to `sizeof(int)`. the
zero bits are truncated if `sizeof(VALUE)` is bigger enough.
[ruby-core:80920] [Bug #13523]
git-svn-...
04/28/2017
-
10:47 PM Bug #13496: Patches for MinGW builds - gnu_printf in 'config' & defines.h
- Hiroshi,
Good morning.
Definitely pre-release. See [ruby-loco](https://github.com/MSP-Greg/ruby-loco).
Re pgp, I haven't worked with it much. My KeyID is 77D8FA18. I don't recall whether you need that or the truncated public ... -
- Good evening Hiroshi,
I've been thinking of putting it on GitHub, but I've been dividing my OSS time between it and my doc site.
I'll try to get something by Sunday or earlier. It will probably require some setup/editing of config... -
01:29 PM Bug #13496: Patches for MinGW builds - gnu_printf in 'config' & defines.h
- Hi, Greg.
Thanks always about MinGW.
Can you give instructions to build your MinGW environment on Windows?
I will prepare MinGW environment for build ruby source. -
07:47 PM Feature #6284: Add composition for procs
- matz (Yukihiro Matsumoto) wrote:
> I want to make sure if everyone agrees with "*" instead of OP's "<<".
> ...
+1 for #*
Initially I thought of the F# convention #<< and it's counter part #>> as intuitive. But after giving it some t... -
07:31 PM Bug #13526 (Closed): Segmentation fault at 0x0055c2e58e8920 ruby 2.3.1p112 (2016-04-26 revision 54768) [x86_64-linux]
- see attached log
-
06:58 PM Feature #13518: Indented multiline comments
- I have no particular pro or con opinion here (I do not use =begin or =end anyway,
only '#') but would this even be possible? -
02:47 AM Feature #13518 (Rejected): Indented multiline comments
- I'd like to submit the idea that multiline comments could be indented. That is, `=begin` and `=end` do not have to start at column zero. That would allow for more flexibility in documenting and commenting code.
-
- I am not sure if this particular message is better or not - but I agree with you in
general. To me this was a source of frustration for a long time transitioning from
ruby 1.8.x to a higher ruby version, until I started to change the w... -
05:57 PM Bug #13523: negative line numbers in instance_eval are misinterpreted in 32-bit ruby-trunk
- Actually this also happens on older release, there are just less 32-bit builders on older versions:
http://rubyci.org/logs/www.rubyist.net/~akr/chkbuild/debian/ruby-trunk/log/20170428T070500Z.fail.html.gz -
- As can be seen on http://rubyci.org/, 32-bit ruby-trunk seems to have regressed and no longer handles negative line number in #instance_eval correctly.
Specifically, this spec fails:
~~~ ruby
it "evaluates string with given file... -
04:54 PM Misc #13525 (Closed): Expand HTTPS to lists.ruby-lang.org
- Hi ruby-lang.org admins,
while managing the new `ruby-de` list I noticed that `lists.ruby-lang.org` is not reachable via HTTPS properly. If one tries, the browser first displays a TLS certificate domain mismatch warning, and after dis... -
04:26 PM Bug #13524 (Third Party's Issue): miniruby: [BUG] Segmentation fault at 0x0055e487e00230 ruby 2.4.1p111 (2017-03-22 revision 58053) [x86_64-li
- Linux: Alpine Linux 3.5
./miniruby: [BUG] Segmentation fault at 0x0055e487e00230
ruby 2.4.1p111 (2017-03-22 revision 58053) [x86_64-linux]
-- Control frame information -----------------------------------------------
c:0001 p:0000... -
01:45 PM Feature #13508 (Assigned): How remove/refactor code related mathn library.
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
01:44 PM Bug #13397: #object_id should not be signed
- The patch is missing documentation, otherwise I love it!
-
- Such feature would be nice, but can't help libraries which support older versions.
```diff
commit 1f7154a4ae0e480774dbfe79905b21d26d5b4cbc
Author: Nobuyoshi Nakada <nobu@ruby-lang.org>
Date: Fri Apr 28 16:35:48 2017
`%I` f... -
- * Merge from ruby/gdbm.
* gdbm gem is already registered in rubygems.org. I skip shipped
version of 0.x and 1.x. Therefore We need to use 2.x.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58502 b2dd03c8-39d4-4d8f-98ff-823fe69... -
12:13 PM Bug #13522 (Closed): Solaris10上で make update-rubyspec が bad substitution で失敗
- おそらく r58467 以降、またもやSolaris 10上にて make update-rubyspec が bad substitution で失敗します。
現象は [Bug #13424] と同一ですが、原因は r58467 の変更にあると思いますので新チケットにしました。
```
$ make update-rubyspec V=1
./tool/git-refresh -C ./spec \
git://github.com/r... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58501 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58500 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
08:21 AM Bug #13521 (Third Party's Issue): [PATCH] Add fallback for DNS resolver registry key on Wine
- Wine doesn't initialize the registry key per default:
HKLM\SYSTEM\CurrentControlSet\Services\Tcpip\Parameters\DataBasePath
Therefore `gem install` fails with `Win32::Registry::Error`.
This patch uses the default path for the hos... -
08:08 AM Feature #13517: [PATCH] reduce rb_mutex_t size from 160 to 80 bytes on 64-bit
- normalperson@yhbt.net wrote:
> https://bugs.ruby-lang.org/issues/13517
For who care about 32-bit, single-core x86, here are my
Pentium M (Centrino) @ 1.6GHz numbers:
Size reduction of Mutex on 32-bit is 112 => 40 bytes
minimu... -
- ```
Instead of relying on a native condition variable and mutex for
every Ruby Mutex object, use a doubly linked-list to implement a
waiter queue in the Mutex. The immediate benefit of this is
reducing the size of every Mutex object... -
- Applied in changeset trunk|r58499.
----------
parse.y: fix line in rescue
* parse.y (set_line_body, primary): fix line number of bodystmt as
the beginning of the block. [ruby-core:79388] [Bug #13181] -
- * parse.y (set_line_body, primary): fix line number of bodystmt as
the beginning of the block. [ruby-core:79388] [Bug #13181]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58499 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
07:03 AM Bug #13520 (Rejected): backport r58495
- と思ったら、trunk側の変更が誤謬によるものだとのこと。
-
- バックポート管理用のチケットです。
-
05:16 AM Feature #13507: Improve performance of some Complex methods where call Numeric#real? internally
- Could your patch
```
-fun1(real_p)
+
+inline static VALUE
+f_real_p(VALUE x)
+{
+ if (RB_INTEGER_TYPE_P(x)) {
+ return Qtrue;
+ }
+ else if (RB_FLOAT_TYPE_P(x)) {
+ return Qtrue;
+ }
+ return r... -
- * sprintf.c (ruby_ultoa): prefixed to get rid of conflict with
a MSVC library function.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58498 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
05:07 AM Bug #13519 (Closed): Improve performance of some Time methods
- This is related to https://bugs.ruby-lang.org/issues/13503
Some Time methods will call internal quov() function and
quov() calls Numeric#quo -> Rational#quo -> ...
This patch will add rb_numeric_quo() as internal C API to call Num... -
- * sprintf.c (rb_str_format, fmt_setup): format by utility
functions in vsnprintf.c instead of `snprintf`.
* sprintf.c (rb_str_format): format and append by `rb_str_catf`
instead of formatting by `snprintf` and then copy.
git-svn-id... - 02:05 AM Revision cd946384 (git): * 2017-04-28
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58496 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * sprintf.c (rb_str_format): `CHECK` just before `FILL_`, but
after another `PUSH`. fix one-off bug.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58495 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
04/27/2017
-
10:41 PM Feature #13516 (Assigned): Improve the text of the circular require warning
- The warning currently reads:
`loading in progress, circular require considered harmful - /my/file.rb`
I think it would be more helpful like:
`Circular require: Loading of /my/file.rb is already in progress, but require was calle... -
- SASADA Koichi <ko1@atdot.net> wrote:
> On 2017/04/27 12:57, Eric Wong wrote:
> > https://80x24.org/spew/20170427034243.22272-1-e@80x24.org/raw
>
> Thank you. I understand the idea. My understanding is "Do not rely on
> native cond... -
05:12 AM Feature #13514: [PATCH] thread_pthread.c (native_sleep): preserve old unblock function
- On 2017/04/27 12:57, Eric Wong wrote:
> https://80x24.org/spew/20170427034243.22272-1-e@80x24.org/raw
Thank you. I understand the idea. My understanding is "Do not rely on
native cond, but manage sleeping threads by ourselves (mana... -
- Eric Wong <normalperson@yhbt.net> wrote:
> This is my work-in-progress patch:
>
> https://80x24.org/spew/20170427033423.19856-1-e@80x24.org/raw
>
> I am still working on fixing the failing test (but I am
> distracted by another... -
- SASADA Koichi <ko1@atdot.net> wrote:
> On 2017/04/27 8:58, Eric Wong wrote:
> > I am looking to replace lock_func in thread_sync.c with
> > native_sleep or similar. This is to reduce Mutex size and
> > complexity by using a similar... -
- On 2017/04/27 12:13, SASADA Koichi wrote:
> I'm afraid that the assumptions for native_sleep() (and other functions)
> will be break and can't control.
I don't mean we should keep current assumption. But we need to update
assumpti... -
- On 2017/04/27 8:58, Eric Wong wrote:
> I am looking to replace lock_func in thread_sync.c with
> native_sleep or similar. This is to reduce Mutex size and
> complexity by using a similar method to what I did in r52332
> with ccan/l... -
- ko1@atdot.net wrote:
> Issue #13514 has been updated by ko1 (Koichi Sasada).
>
>
> Do you expect such situation?
Not right now. I am looking at making changes related to
threading, and I noticed this weirdness.
> (1) run r... -
- Intentional fix.
-
12:19 PM Bug #9907: Abbreviated method assignment with private attr_writer/attr_reader does not work.
- This issue seems to have resurfaced. The issue is fixed in 2.2, but broken in both 2.3 and 2.4.
-
03:12 PM Bug #13509 (Closed): Ruby 2.4.1 Fails to Compile on Raspberry Pi 3, Raspbian
- It seems that the problem was the CFLAGS value
-mtune=native
which also caused the build of other applications to fail.
I'll try to report it to Raspbian.
I'm sorry for making this noise here. -
- I created PR fixing the projects listed above.
But still, this seems so generic and unexpected issue, possibly influencing libraries which are part of StdLib [3, 4], I'd like to see this improved. Couldn't the #format accept "object_i... -
- * common.mk (ext/ripper/ripper.c): fix VPATH when out-of-place
build, and id.h was created in the build directory too. it has
to include the build directory, i.e., the current directory
before `cd`.
git-svn-id: svn+ssh://ci.ruby-... -
- Thank you for the fix nobu.
I believe it should also send everything (message + backtrace) as a single String to Warning.warn.
I did that in r58493.
It would be nice to backport this to 2.4 for easier exception filtering,
but I gue... -
- * load.c: send as a single string.
* error.c: expose the string formatted by rb_warning as rb_warning_string().
* test/ruby/test_exception.rb: update tests.
[ruby-core:80850] [Bug #13505]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/tr... -
- This bug report is on a unsupported Ruby version, closing.
-
11:47 AM Feature #12886: URI#merge doesn't handle paths correctly
- I'm giving up on this ever being improved. But for anyone who is interested in what I wanted, I ended up making a gem.
https://github.com/ioquatix/build-uri
It solves all my problems - correct, transparent, handling of absolute URL... -
- Thank you nobu for fixing this, r58490 solves all my concerns for Kernel#warn.
-
10:00 AM Feature #9116: String#rsplit missing
- I find a use case.
>```
> ...
On PostgreSQL, I can retrieve databases information by SQL, and its ACL data is "datacl" column as key-value.
Its key is rolename (user/group name) and the value is the privilege, with separated "=".
T... -
09:47 AM Bug #13511: gem install fails on UNIX accounts with limited process count.
- Hello, libv8 maintainer here. This really does not look like an issue with Ruby itself. Seems to me it's due to Google's `depot_tools` spawning a bunch of processes to fetch `v8` and its dependencies' sources. Further discussion: https:/...
-
06:09 AM Bug #13515 (Closed): Pathname#join doesn't add separator on UNC paths
- When using `Pathname#join` on Windows, I have no problems when working with normal paths:
`irb(main):008:0> Pathname.new('C:/selenium').join('common')
=> #<Pathname:C:/selenium/common>`
However, when doing the same thing on UNC sh... -
- * st.c (rb_hash_bulk_insert): new API to bulk insert entries
into a hash. Given arguments are first inserted into the
table at once, then reindexed. This is faster than inserting
things using rb_hash_aset() ... - 03:16 AM Revision 42c2df99 (git): load.c: make fstrings from C strings sooner
- The underlying string objects will become fstrings anyways,
so create the fstring directly from the C string to reduce
intermediate garbage.
* load.c (rb_provide, rb_provide): create fstring
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/...
04/26/2017
-
- By the way, it's absolutely feasible to implement this correctly, simply by removing this check.
https://github.com/ruby/ruby/pull/1469/commits/7a7a33c9486c7d7b2caa7f5095bcb28fba1fe095
-
- Do you expect such situation?
(1) run ruby code # acquiring GVL
(2) run func on without_gvl() # releasing GVL
(3) run func on with_gvl() # re-acquire GVL
(4) run func on without_gvl() # releasing GVL <- here
I agree. It has a pr... -
- Do not blindly clobber UBF if one exists, emulating the
behavior of the set_unblock_function and reset_unblock_function
pair.
I think the native_sleep implementation in thread_win32.c,
can use a similar change; but I do not run non... -
10:45 PM Bug #13501: Process.kill behaviour for negative pid is not documented and may be wrong
- Negative pid will send signal to the process group.
And specifically -1 will send it nearly system wide if the process user has root privileges. -
- Agreed - the behaviour should also be documented. Not that I think anyone wants to use a
negative PID (how is that even possible) but simply because one could pass -1 or -42 or
whatever. -
- * error.c (rb_warn_m): send the arguments as a single string
concatenated with a newline, so it can be filtered easily.
[ruby-core:80875] [Feature #12944]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58490 b2dd03c8-39d4-4d8f-98... -
- hugespider (Clauss Gigantisch) wrote:
> I see issue is closed, so maybe I'm addressing wrong project and ask author(s) of libv8 ( or anything in between )?
Yes, exactly.
-
06:34 PM Bug #13511: gem install fails on UNIX accounts with limited process count.
- nobu (Nobuyoshi Nakada) wrote:
> Try `gem install --user-install`.
Like this?
````
$ gem install libv8 --user-install
WARNING: You don't have /home/spider/.gem/ruby/2.2.0/bin in your PATH,
gem executables will not run.
Bui... -
- Try `gem install --user-install`.
-
- On web hosting server ( paid remote server ) I cannot build libv8, because building system runs out of available processes.
Process limit is set to fixed value on that account.
So far I see no way to pass that limit to gem's buildi... - 08:09 PM Revision 6a4061ce (git): * 2017-04-27
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58489 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
08:09 PM Revision d786797d (git): error.c: improve docs
- * error.c: [DOC] fix rdoc formatting (make sure `Warning.warn' is
displayed verbatim; rdoc would render it as a link named `#warn'),
use capitalized "Ruby", fix a typo.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58488 b2dd03c... -
05:32 PM Bug #13513: Resolv::DNS::Message.decode hangs after detecting truncation in UDP messages
- After further consideration I had a look at rfc1035 with regard to the handling of record counts in truncated messages and it discusses ANCOUNT as being the number of answers in the answer section and not necessarily the number of answer...
-
- ruby-core:32407 introduced support for a TCP requestor in fetch_resource if Resolv::DNS::Message.decode returned RCode::NoError and a reply tc of 1.
Unfortunately Resolv::DNS::Message.decode proceeds to attempt to unpack all answers b... -
04:55 PM Bug #13510 (Closed): Problems with dependency resolution - Molinillo algo
-
- 1. go to https://rubygems.org/gems/azure and click download button.
2. `tar xfp azure-0.7.9.gem`
3. look at metadata.gz
So the gem is built that way. -
- This is the gemspec defined for the azure ruby gem (https://github.com/Azure/azure-sdk-for-ruby/blob/asm/azure.gemspec#L39)
```ruby
if RUBY_VERSION < "2.1.0"
s.add_runtime_dependency('nokogiri', '~> 1.6.0')
els... -
03:30 PM Feature #13512: System Threads
- So, I'd love to use a native thread to do compilation, however, that means compilation is cut off entirely from the interpreter: Any and all `rb_` family functions that are only callable under the GVL become out of bounds. In the short t...
-
- Sorry I can't understand your proposal. What is the problem and why System thread solve it?
As I said before, I'm not sure why you need to cooperate with Ruby threads.
Such compilation threads should run on native threads which are ind... -
- In this feature I propose creating a VM implementation feature called (for lack of a better name) *System Threads*.
Background
==========
I am working on adding asynchronous compilation to [Ruby+OMR][1] allow compilation of meth... -
- Today (2017-04-26), I built `ruby 2.5.0dev (2017-04-26 trunk 58487) [x64-mingw32]`
To complete test-all, it required additional patches for:
```
test/fileutils/test_fileutils.rb
test/ruby/test_arity.rb
test/ruby/test_keyword.rb
... -
- MSP-Greg (Greg L) wrote:
> Sorry for not being more specific. As far as you know, approximately what percentage of Japanese Windows Ruby users use MinGW builds, and what percentage use mswin builds?
Sorry, I don't know such statistics. -
- usa (Usaku NAKAMURA) wrote:
> MSP-Greg (Greg L) wrote:
> ...
Sorry for not being more specific. As far as you know, approximately what percentage of Japanese Windows Ruby users use MinGW builds, and what percentage use mswin builds? -
- MSP-Greg (Greg L) wrote:
> On the topic of Japanese Windows users, what type of Ruby builds are they using, mswin or MinGW?
Of course, we use both, as far as I know.
-
- usa (Usaku NAKAMURA) wrote:
> Come Japan and check Japanese Windows users' text files :)
On the topic of Japanese Windows users, what type of Ruby builds are they using, mswin or MinGW?
-
- nobu (Nobuyoshi Nakada) wrote:
> Nitpicking an edge case, these two are different.
I see, do you think it is important?
I think the second output is actually more natural for a warning.
r58487 is not enough, it calls Warning#writ... -
- Nitpicking an edge case, these two are different.
```ruby
puts "foo", "" #=> "foo\n" and "\n"
```
```ruby
puts ["foo", ""].join("\n") #=> "foo\n"
``` -
- It does seem to be able to compile with
GCC, if the CFLAGS=="" and
./configure --prefix=/home/mmmv_applications_set_01/applications/Ruby/v_2_4_1 --enable-shared --enable-load-relative --enable-multiarch --disable-install-doc --di... -
- shyouhei (Shyouhei Urabe) wrote:
> > configure: error: C compiler cannot create executables
> ...
Does that also apply to the LLVM based session that
does not have such an error message? -
- > configure: error: C compiler cannot create executables
It's your compiler who's dying. Report this to Raspbian. -
- The LLVM based console session, where the configure step
completes, but make step fails. -
- If the CXX=="clang++" and CC=="clang", then the configure step completes.
-
The console session:
~~~
mmmv_applications_set_01@acstorage3334:~/applications/Ruby/originals/kompil/ruby-2.4.1 $ uname -a
Linux acstorage3334 4.4.50-v7+ #970 SMP Mon Feb 20 19:18:29 GMT 2017 armv7l GNU/Linux
mmmv_applications_se...-
- * error.c (rb_warn_m): print array arguments with splatting.
it is often used with `caller`.
[ruby-core:80849] [Feature #12944]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58487 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- I got ownership of webrick gem from nahi.
I will release webrick gem after https://github.com/rubygems/rubygems.org/pull/1608 merged. -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58486 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
12:11 AM Bug #13181: Unexpected line in rescue backtrace
- I think this is parse.y issue.
The lineno of NODE_RESCUE is 1 correctly with `begin ... rescue ... end` pattern.
```
$ cat a.rb
begin
raise
rescue
raise ""
end
$ ./miniruby -v --dump=parsetree a.rb|grep -e "NODE.*line"...
04/25/2017
- 08:20 PM Revision 6e5e1b37 (git): thread_sync.c (rb_mutex_lock): spelling fix [ci skip]
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58485 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * Otherwise it would be loaded twice.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58484 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58483 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * test/ruby/test_trace.rb (test_trace_stackoverflow): sometimes this test
was stopped forever and killed by test process forcibly. However, this
test only checks if this code cause some critical failure such as SEGV.
So that we can... - 05:24 PM Revision 44011ee0 (git): * 2017-04-26
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58481 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58480 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
03:12 PM Feature #13495: add Range#count as an alias to Range#size
- Sorry, I got confused. `Enumerator` has a `size` method, not `Enumerable`.
-
02:49 PM Feature #13495: add Range#count as an alias to Range#size
- > PS: "Enumerable does not have size" is incorrect. Enumerable have a size method, although it may return nil if the result can not be calculated lazily.
I don't think that's true. The docs don't show it and it doesn't get added when ... -
- PS: "Enumerable does not have size" is incorrect. `Enumerable` have a `size` method, although it may return `nil` if the result can not be calculated lazily.
-
- `size` calculates the size lazily, without enumerating. If it can't, it returns `nil`.
`count` calculates the size by doing the actual enumeration. It never returns `nil`, but may never finish.
(1..10**8).count # => takes a few s... -
- * Otherwise it would load it twice.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58479 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * It would also #load (because .mspec cannot be #require'd) it twice.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58478 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58477 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- I attach a patch based on Jeremy "Use rb_ary_join" patch, rebased to current trunk.
I think using args.join("\n") is a good way to restore the needed compatibility as shown above and yet simple enough.
It's also what I intuitively us... -
- All rb_rescue() hiding user exceptions and/or re-raising a generic errors (mentioned above) have now been removed.
Please do not introduce rb_rescue() call in MRI, hiding user exceptions is harmful.
This changes make it much easier... -
- Applied in changeset trunk|r58474.
----------
no longer rescue exceptions in numeric comparison operations
* numeric.c (do_coerce): no more error hiding.
* test/ruby/test_numeric.rb: follow the change.
[Feature #7688] -
- * range.c (range_init): no longer hide the user exception
with a ArgumentError, just let the user exception go through.
* test/ruby/test_range.rb (test_new): add tests.
[Feature #7688]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/tru... -
- * numeric.c (num_step_negative_p): no more error hiding.
* test/ruby/test_float.rb, test/ruby/test_numeric.rb:
follow the change. [Feature #7688]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58475 b2dd03c8-39d4-4d8f-98ff-823fe69b... -
- * numeric.c (do_coerce): no more error hiding.
* test/ruby/test_numeric.rb: follow the change.
[Feature #7688]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58474 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Import gemspec and test file from ruby/webrick.
* webrick.gemspec: Update files and dependency for standalone gem.
* test/webrick/utils.rb: Added explicitly loading of EnvUtil for
test suite without ruby core test suite.
git-sv... -
- Applied in changeset trunk|r58472.
----------
Document the Warning module and warn method
* error.c (Warning): add documentation. [Feature #13504]
Author: Jeremy Evans <code@jeremyevans.net> -
- * error.c (Warning): add documentation. [Feature #13504]
Author: Jeremy Evans <code@jeremyevans.net>
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58472 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Applied in changeset trunk|r58471.
----------
load.c: backtrace of circular require
* load.c (load_lock): print backtrace of circular require via
`Warning.warn` [ruby-core:80850] [Bug #13505] -
- * load.c (load_lock): print backtrace of circular require via
`Warning.warn` [ruby-core:80850] [Bug #13505]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58471 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * gdbm.gemspec: Update basic configuraiton for standalone gdbm gem.
* test/gdbm/test_gdbm.rb: In standalone environment, It needs to
explicit loading of EnvUtil module for test suite.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/tr... -
- I removed mathn library at r58413 and r58432.
I have some concerns related mathn library. This issue is reminder for this concern.
1. Still remains conditions for mathn loaded. ex. https://github.com/ruby/ruby/blob/trunk/array.c#L5... -
- Some Complex methods call Numeric#real? at f_real_p() using rb_funcall().
This patch will provide optimization in f_real_p() when Integer/Float is given as internal objects.
### Before
~~~
Calculating ------------------------------... - 06:51 AM Revision 3c778545 (git): * 2017-04-25
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58469 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- This previous "key" macro argument accidentally replaced `(ptr)->key` part.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58468 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
05:33 AM Feature #13502: remove unused Array#to_s implementation
- Thanks for the feedback Eric. I'll work on that.
-
- At the internal calculation in Complex methods,
it will just call Ruby #{+,-,*,/} methods via rb_funcall().
This patch will provide the optimization path for calculation
using #{+,-,/,*} methods for internal Fixnum objects.
### B...
04/24/2017
-
- Thank you, this looks great.
I'll be happy to commit this tomorrow. -
06:44 PM Feature #13504 (Closed): Document the Warning module and warn method
- When I originally added the Warning module, I neglected to added RDoc documentation for it. Apologies for that, here's a patch that should fix it.
This could be backported to 2.4, but it would need slight modifications as Kernel#warn... -
- Also, similar to #13505, I think a single warning String (containing newlines) should be sent to Warning.warn.
Otherwise, `warn "my warning", caller` will appear as two different calls to Warning.warn and the second call cannot be filte... -
- It seems it is a compatibility issue.
For instance Thread.exclusive warning is now printed incorrectly:
~~~
$ ruby -ve 'def m; Thread.exclusive {}; end; m'
ruby 2.4.0p0 (2016-12-24 revision 57164) [x86_64-linux]
Thread.exclusive i... -
- The "loading in progress, circular require considered harmful" warning prints the caller backtrace directly to stderr:
~~~ c
if (RTEST(ruby_verbose)) {
rb_warning("loading in progress, circular require considered harmful - %s",... -
- I should have considered that. I was focused on the use case at hand. :(
I still feel like there needs to be a way to do this that's safe. Perhaps the solution is adding `Enumerable#size` and letting `size` be the option that's safe f... -
07:22 AM Feature #13495: add Range#count as an alias to Range#size
- we can't do that.
Enumerable#count does can take a block with you can define that you want to count.
~~~ ruby
(1..4).count(&:even?) #=> 2
~~~
so we can't make Range#count be an alias for Range#size without breaking other stuff. -
- > Precisely because it makes it easier to define Warning.warn manually and call super to get default behavior.
I see, this sounds worth documenting in the rdoc of Warning#warn then :) -
- Eregon (Benoit Daloze) wrote:
> This feature is great, thank you for introducing it!
> ...
I think this is expected. If you want to filter/process warnings, it's best to setup `Warning.warn` close to process initialization, before loa... -
- This morning, a MinGW build of
```
ruby 2.5.0dev (2017-04-24 trunk 58467) [x64-mingw32]
```
completed `test-all` with
```
16621 tests, 2227533 assertions, 8 failures, 1 errors, 114 skips
```
I've mentioned that I am not f... -
- パッチをあててみましたが、状況は変わらないようです。
Kernel.open が呼び出す rb_file_open_generic() の rb_sysopen() で「例外が発生する／発生しない」というのが
問題なのかと思っておりましたが、パッチで変更があった File.expand_path や Dir.glob の問題なのでしょうか？
-
- これでどうでしょうか。
```diff
diff --git i/dir.c w/dir.c
index e3099f4973..b02640e912 100644
--- i/dir.c
+++ w/dir.c
@@ -1528,34 +1528,52 @@ join_path(const char *path, long len, int dirsep, const char *name, size_t namle
#ifdef HAVE_... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58467 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- ### Pull Req
https://github.com/ruby/ruby/pull/1596
-
- Some Time methods will call internal quov() function.
quov() calls Rational#quo -> f_muldiv() -> i_gcd() in rational.c
i_gcd() will calculate GCD using Euclidean's Algorithm and it lose a long time in modulo method (ie "x = y % x;").
... -
- * parse.y (new_args_tail_gen): abandon parsing arguments after
error. reported by ilsani Martino Sani (ilsani) at
https://hackerone.com/reports/221201
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58466 b2dd03c8-39d4-4d8f-98ff-... -
- * parse.y (rb_parser_fatal): abort compilation on internal parser
error. rb_bug() is generic use but not useful for debugging the
parser. this function dumps internal states, and continues with
enabling yydebug output to stderr f... -
- Thanks for the report. I think we need to keep an alias for
rb_ary_to_s in intern.h for backwards-compatibility. intern.h
is (unfortunately) part of the public API which 3rd-party
extensions may depend on.
Perhaps use the RUBY_A... -
- Hello Ruby Team!
First time i've make a commit request, hopefully not the last :)
While browsing the src of ruby, specifically array.c i noticed that Array#to_s is an alias of Array#inspect but the implementation of Array#to_s stil... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58464 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- We need to fix GC bug before merging this. Revert revisions
58452, 58435, 58434, 58428, 58427 in this order.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58463 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
04/23/2017
-
- Following code will not fail and will print "TERM caught by NN" both for spawned and forked processes:
~~~ ruby
pid = spawn 'ruby', '-e', <<-'RUBY', :pgroup => true
trap('TERM'){ print "TERM caught by #{$$}\n" }
fork
sleep 1... -
- With MinGW build of `ruby 2.5.0dev (2017-04-24 trunk 58462) [x64-mingw32]`, both test-all and an external test stop in [`TestArity#test_proc_err_mess`](https://github.com/ruby/ruby/blob/b3209c258eddc093ffdcbf77ee079cdc93f094ae/test/ruby/...
-
- This feature is great, thank you for introducing it!
A couple things I noticed while using it for ruby/spec:
https://github.com/ruby/mspec/commit/954054c03da1c90c9653f238c78c888644760ab8
* Parser warnings are emitted at parse time... -
- バックポート管理用チケットです。
(ついでに r58454 も、かな) -
- Applied in changeset trunk|r58461.
----------
Allow Net::HTTP to fetch user/pass from http_proxy
Note that this feature is enabled only on environment variables are
multi-user safe. In this time the list includes Linux, FreeBSD, or
Dar... - 04:19 PM Revision b3209c25 (git): * 2017-04-24
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58462 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Note that this feature is enabled only on environment variables are
multi-user safe. In this time the list includes Linux, FreeBSD, or
Darwin. [Bug #12921]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58461 b2dd03c8-39d4-4d8f-98ff-... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58460 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58459 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58458 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
07:16 AM Bug #13498 (Closed): Weakref, Weakmap and define_finalizer don't work on frozen objects
- I'm just creating a single ticket for these issues, I guess they're actually all the same (I've seen weakref uses weakmap, not sure about define_finalizer).
```ruby
require 'weakref'
map = ObjectSpace::WeakMap.new
o = Object.ne... -
- `Kernel.open` で使用している POSIX `open` が case-sensitive と非 case-sensitive で振る舞いが違うようです。`Kernel.open` の処理を抜き出したもので試してみました。
```c
#include <stdio.h>
#include <string.h>
#include <fcntl.h>
int main()
{
const char *file = "file.tes... -
- I think it's fair to say that virtually all Ruby documentation today is created by doc generation systems based either on YARD or RDoc. Code samples/examples are common. YARD uses Ripper to parse samples for highlighting, I believe RDo...
-
- Just noticed the 2nd line of the 1st patch should be --
```
+++ b/configure.in Thu Apr 20 13:44:41 2017
```
-
- Thanks to Nobu for [58448](https://github.com/ruby/ruby/commit/27ed9f1d290a6ff6b788976ea7139c608920ee1e), which led me to the probable cause of many (but not all) of the silent SEGV's I was having in test-all, which is the patch of `defi...
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58457 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58456 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * win32/Makefile.sub (enc/jis/props.h): build it in not builddir,
but in srcdir.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58455 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * sprintf.c (rb_str_format): as for non-finite float, calculate
the exact needed size with the space flag.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58454 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * sprintf.c (rb_str_format): while `"% 2f"` and `"% 4f"` result in
`" Inf"` and `" Inf"` respectively, `"% 3f"` results in
`"Inf"` (no space).
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58453 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * hash.c (rb_hash_new_from_object): same as r58434.
Newly created frozen objects are not referred from any roots/objects.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58452 b2dd03c8-39d4-4d8f-98ff-823fe69b080e