Activity
From 04/15/2017 to 04/21/2017
04/21/2017
-
11:16 PM Bug #13493 (Closed): `make realclean` removes aclocal.m4 and enc/jis/props.h
- Applied in changeset trunk|r58438.
----------
clean autogenerated files
* enc/depend (clean, clean-srcs): fix path of name2ctype.h, and
remove casefold.h too.
* enc/jis/props.h: autogenerated file.
[ruby-core:80823] [Bug #13493] -
07:24 PM Bug #13493 (Closed): `make realclean` removes aclocal.m4 and enc/jis/props.h
- `make realclean` removes aclocal.m4 and enc/jis/props.h, which both are under version control, and probably should be kept(?).
-
- * enc/depend (clean, clean-srcs): fix path of name2ctype.h, and
remove casefold.h too.
* enc/jis/props.h: autogenerated file.
[ruby-core:80823] [Bug #13493]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58438 b2dd03c8-39d4-4d8f... -
09:00 PM Bug #13491: MinGW 58400 - TestSocket_BasicSocket#test_read_write_nonblock
- normalperson (Eric Wong) wrote:
> Can you try r58437?
Works. I guess I was staring at the case statement, I should have added the test for `:wait_readable`. I tried `IO.select`, but I left of the timeout...
Thank you. I'll clos... -
08:42 PM Bug #13491: MinGW 58400 - TestSocket_BasicSocket#test_read_write_nonblock
- Can you try r58437? I made it call IO.select on :wait_readable
instead of using your change.
Thanks. -
- Greg.mpls@gmail.com wrote:
> The test `TestSocket_BasicSocket#test_read_write_nonblock` was recently add via [58400](https://bugs.ruby-lang.org/projects/ruby-trunk/repository/revisions/58400/diff) / [c32fc82](https://github.com/ruby/ru... -
- The test `TestSocket_BasicSocket#test_read_write_nonblock` was recently add via [58400](https://bugs.ruby-lang.org/projects/ruby-trunk/repository/revisions/58400/diff) / [c32fc82](https://github.com/ruby/ruby/commit/c32fc82d0ed8bcf0d6e4d...
- 08:38 PM Revision e79ecc54 (git): test/socket/test_basicsocket: handle :wait_readable on read_nonblock
- On some systems with slower local sockets, :wait_readable may
happen and we should wait on it to drain the socket.
This is a possible fix for https://bugs.ruby-lang.org/issues/13491
* test/socket/test_basicsocket.rb (test_read_write_non... -
- By monkey patching Math.sqrt to be extremely imprecise, the general effect can be seen better, i.e. for low numbers.
Affected are Integer#prime? and Prime.each via Prime::EratosthenesSieve.
``` ruby
module Math
class << self
... -
- There is a bug in Integer#prime? that might result in the method returning `true` for (very big) numbers that are not prime. Similarly, Prime.each might yield numbers that are not prime.
Integer#prime? uses `Math.sqrt(self).to_i` to d... -
- Nice.
-
- The patch has been updated to also include doc changes.
Any thoughts on this? -
03:27 PM Misc #13486: Using rb_thread_call_without_gvl{2}
- Thinking more on this, I'm wondering if maybe I would still like to be in a situation where the compilation thread is a ruby thread (and in fact, today, have a working version that runs this way -- I got rid of `rb_thread_wait_for`--, bu...
-
- Closing. Fixed with r58432 (removing of mathn).
- 03:00 PM Revision 581c447f (git): * 2017-04-22
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58436 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
03:00 PM Revision 5f5bc068 (git): insert WB correctly.
- * hash.c (hash_insert_raw): should insert WB.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58435 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- vo.x (Vit Ondruch) wrote:
> Is there a chance to find some generic reliable solution to this? Or is it just feature and I should persuade all the project to fix their Regexps [1] or implementation of #object_id?
They seem to have the... -
09:04 AM Bug #13397: #object_id should not be signed
- Last CI build of concurrent-ruby in Fedora failed again:
https://apps.fedoraproject.org/koschei/package/rubygem-concurrent-ruby?collection=f27
https://kojipkgs.fedoraproject.org/work/tasks/6296/19116296/build.log
Is there a chance... -
- Could you try 2.4.1 (with debugging info if possible)?
-
11:59 AM Bug #13490 (Closed): segmentation fault while parsing object to time and adding to array
- While parsing Github API with Octokit.rb I get a reproducible segmentation fault.
I'm running Arch Linux 4.10.10:
~~~ text
0 ✓ user@host ~/directory $ uname -a
Linux host 4.10.10-1-ARCH #1 SMP PREEMPT Wed Apr 12 18:50:28 CEST 20... -
- * hash.c (rb_hash_new_from_values_with_klass): before this fix,
only a st table are filled with passed values. However, newly
created frozen strings are not marked correctly only reference
from st table. This patch marks such creat... -
11:00 AM Revision 34f14888 (git): Remove empty directories
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58433 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
06:16 AM Feature #10169 (Closed): It might be better to make Mathn class deprecated
- Applied in changeset trunk|r58432.
----------
Removed mathn.rb from stdlib. It's deprecated from Ruby 2.2.
[Feature #10169][[ruby-core:64553]] -
- [Feature #10169][[ruby-core:64553]]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58432 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Applied in changeset trunk|r58431.
----------
test_framework.rb: for case-sensitive filesystem
* test/mkmf/test_framework.rb (test_single_framework): fix header
file name for case-sensitive filesystem. it may not be same as
the fr... -
- watson1978 (Shizuo Fujita) wrote:
> 以下の変更をテストに加え `#include <Ruby/ruby.h>` を生成することで、`conftest.c` のコンパイルエラーは解消しました。
気になるのは、macOSの"framework"としてはどちらが本来意図されたものなのかというところですね。
1. framework名とヘッダ名に直接の関係はない
2. framework名とヘッダ名は一致しているべきであり、そ... -
03:20 AM Bug #13489: "make test-all" fails on macOS with case-sensitive filesystem
- 以下の変更をテストに加え `#include <Ruby/ruby.h>` を生成することで、`conftest.c` のコンパイルエラーは解消しました。
```diff
diff --git a/test/mkmf/test_framework.rb b/test/mkmf/test_framework.rb
index ae05b0cffc..9959437f6f 100644
--- a/test/mkmf/test_framework.rb
+++... -
- * test/mkmf/test_framework.rb (test_single_framework): fix header
file name for case-sensitive filesystem. it may not be same as
the framework name, but should be the actual file name.
[ruby-dev:50093] [Bug #13489]
* test/mkmf/te... -
06:05 AM Feature #13488 (Rejected): Set Encoding.default_external to UTF-8 on Windows
- Though it should be changed into UTF-8 in the future, I don't plan it in 2.5 too.
(If many people want to change, I may change my mind)
Anyway the patch is directly changes the `default_external`, but `default_external`'s default is ... -
06:03 AM Revision 70c9bb4b (git): Remove missing/strtol.c
- It is never used. We don't need it anyway as it's part of C89 which is
our current minimum requirement.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58430 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
05:35 AM Revision 16ffd476 (git): NEWS entry for [Feature #13302]
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58429 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58428 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Same as rb_ary_tmp_new_from_values(), it reduces vm_exec_core binary
size from 26,176 bytes to 26,080 bytes. But this time, also with a
bit of optimizations:
- Because we are allocating a new hash and no back references are
intro... -
- * common.mk (build-ext): pass variables to colorize.
* ext/extmk.rb: colorize notes with tool/colorize.rb.
* tool/colorize.rb: extract from tool/generic_erb.rb.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58426 b2dd03c8-39d4-4d8... -
- * ext/extmk.rb: split notes into header and footer, which are
common, from bodies which are unique for each extensions.
* template/exts.mk.tmpl: now each notes are not one line, should
not unique.
git-svn-id: svn+ssh://ci.ruby-lang... -
- * vm_dump.c (rb_vmdebug_stack_dump_all_threads): fix for
non-scalar thread_id platforms. c.f. [Bug #9884]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58424 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Fix a warning in ruby/win32.h which can cause failures with mkmf
The return value is implicit type casted from 'long double' to 'double', currently.
This causes a gcc warning like this:
```
In file included from C:\Ruby24-x64\include\r...
04/20/2017
-
- * test/ruby/test_thread.rb (make_handle_interrupt_test_thread1): use Queue
to use correct synchronization.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58422 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- まだテスト内容を誤解しているようで
```
/System/Library/Frameworks/Ruby.framework/Headers/ruby.h
```
を include することは意図されていて、`#include <Ruby/Ruby.h>` となっているのが問題だっただけなのでしょうか？
```
#include <Ruby/ruby.h>
```
と conftest.c に書かれていれば良いだけのような気がしてきました。 -
- clang はデフォルトで
- `/System/Library/Frameworks`
- `/Library/Frameworks`
の中からフレームワークを探索します。(以下のように確認できます)
```
$ clang -x c -v -E /dev/null
Apple LLVM version 8.1.0 (clang-802.0.42)
Target: x86_64-apple-darwin16.6.0
... snip ...
... -
- nobu (Nobuyoshi Nakada) wrote:
> Frameworkが有効な場合は `<Foo/bar.h>` は `$(FRAMEWORKSDIR)/Foo.framework/Headers/bar.h` が読まれるものと理解しているのですが
正しいと思います。
```
conftest.c:3:10: fatal error: 'Ruby/Ruby.h' file not found
#include <Ruby/Ruby.h>
... -
- Frameworkが有効な場合は `<Foo/bar.h>` は `$(FRAMEWORKSDIR)/Foo.framework/Headers/bar.h` が読まれるものと理解しているのですが、以下のソースは `clang -ObjC` でコンパイルできるでしょうか。
```c
#include <ruby/ruby.h>
int main(void) {return 0;}
```
-
- 普段使用している macOS は HFS+ case-sensitive でフォーマットしています。
"make test-all" をそのマシン上で実行すると以下のようなエラーが発生し、
どうやら conftest.c でのコンパイルエラーが原因のようです。
conftest.c には
~~~
#include <Ruby/Ruby.h>
~~~
という行が生成されるらしいのですが、
case-sensitive なファイルシステムではそ... -
-
- Ok. That makes sense.
Thanks for the tip. This can probably get closed (I can't seem to do it myself). -
- Pointed out at
<https://github.com/ruby/ruby/commit/fbc1deca89595e60af21e58b7e164f376e4bd2fc#commitcomment-21839826>
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58421 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 03:02 PM Revision df53b325 (git): * 2017-04-21
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58420 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * lib/rubygems/core_ext/kernel_require.rb: sometimes
`Kernel.send(:gem, spec.name)` can raise some errors
(Gem::MissingSpecError I observed) and this method
doesn't release RUBYGEMS_ACTIVATION_MONITOR correctly.
This patch fix th... -
12:40 PM Feature #13488: Set Encoding.default_external to UTF-8 on Windows
- larskanis (Lars Kanis) wrote:
> The current setting is a major interoperability issue and it is neither useful nor expected, because nobody seriously uses the ancient locale dependent cpXYZ encodings for file content.
Come Japan and ... -
11:32 AM Feature #13488 (Closed): Set Encoding.default_external to UTF-8 on Windows
- Currently Encoding.default_external is set to the local ANSI encoding of the Windows installation unless changed per option `-E`. This is cp850 for Western Europe. It should be changed to UTF-8.
The current setting is a major interope... -
11:38 AM Bug #13431: sample/drb/http0*.rb is not working.
- That is different from my case.
I forgot telling you the important fact.
* I copied files `http0.rb`, `http0server.rb` to working directory.
* I rewrote `http0server.rb` line 3, `require 'drb/http0'` to `require_relative './http0'... -
- * lib/irb/ruby-lex.rb (RubyLex#lex): fix conditions for continued
line; empty lines, a semicolon, first line in `begin` block,
just after `else` are not continued.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58418 b2dd03c8-39d... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58417 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Found a part where copy&paste can be eliminated. Reduces vm_exec_core
from 26,228 bytes to 26,176 bytes in size on my machine. I believe it
does not affect any runtime performance.
----
* array.c (rb_ary_tmp_new_from_values): ... -
-
- Backport ticket.
-
- mathn is deprecated from Ruby 2.2.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58415 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Note: We need to remove Math mode from irb before unbundling mathn. So it uses mathn library.
After that, We can remove mathn from ruby core. and ship rubygems.
I will do it. -
- * common.mk (build-ext): separate note from building extensions,
not to be intermingled. [ruby-core:80759] [Feature #13302]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58414 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Applied in changeset trunk|r58413.
----------
Removed deprecated extensions of mathn.
* ext/mathn/{complex,rational}: Removed from ruby core.
[fix GH-1542][Feature #13334][ruby-core:80247] -
- * ext/mathn/{complex,rational}: Removed from ruby core.
[fix GH-1542][Feature #13334][ruby-core:80247]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58413 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Applied in changeset trunk|r58412.
----------
extmk.rb: fail for mandatory libraries
* ext/extmk.rb: fail if a mandatory extension library failed to
configure. [ruby-core:80759] [Feature #13302]
* template/exts.mk.tmpl: move `exit`... -
- * ext/extmk.rb: fail if a mandatory extension library failed to
configure. [ruby-core:80759] [Feature #13302]
* template/exts.mk.tmpl: move `exit` at the end.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58412 b2dd03c8-39d4-4d8... -
- * man/ruby.1, man/erb.1, man/goruby.1, man/irb.1:
fix document title formatting and volume name,
improve "REPORTING BUGS" section: fix mdoc formatting error
(wrong macro for bullet list items), small rewordings.
git-svn-id: svn+ss... -
- * man/ri.1: update the (very outdated) ri man page:
* update document date
* fix document title formatting and volume name
* update descriptions and options to current ri --help text
* fix some mdoc formatting errors (missing esc... -
- Applied in changeset trunk|r58409.
----------
ri.1: fix errors in ri man page
* man/ri.1: fix some errors in ri man page (add missing options,
remove options that do not exist, fix formatter list).
Reported by Josh Cheek. [ruby-c... -
- * man/ri.1: fix some errors in ri man page (add missing options,
remove options that do not exist, fix formatter list).
Reported by Josh Cheek. [ruby-core:68065] [Bug #10838]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58409... -
- Unfortunately, I'm just one of Ruby users.
Could you please commit it if you agreed the changing ? -
- * vm_dump.c (rb_vmdebug_stack_dump_all_threads): dump stack dump
for all living threads.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58408 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Glad to hear that. Thank you for your cooperation.
- 01:36 AM Revision abbabbf8 (git): Move test_extlibs.rb because it's not the test of ruby itself
- * test/test_extlibs.rb: moved from test/ruby.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58407 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
04/19/2017
-
- I'm not sure what is the problem on your situation, but you can't call `rb_thread_wait_for` when you don't holding GVL.
Basically, you can't use any of `rb_...` APIs because they depend on GVL.
BTW, I'm not sure why you are using Rub... -
- I'm currently working on adding asynchronous compilation to [Ruby+OMR][1], and I'm trying to use the existing Ruby thread API. However, given that compilation shouldn't happen while holding the GVL, I've been playing with `rb_thread_call...
-
- Building `ruby 2.5.0dev (2017-04-20 trunk 58406) [x64-mingw32]`, the issue with `TestLambdaParameters#test_call_simple` passed with `test-all`, and also when run 20 times in a test framework run directly from ruby.
I'm not sure, but I... -
- The help screen was fixed hier: https://github.com/rdoc/rdoc/pull/448
The man page is WIP and will be fixed soon. -
- Re the patch needed in MinGW builds for [TestEnumerable#test_callcc](https://github.com/ruby/ruby/blob/d6873af4bdc99914f20f6184966fa840c91bdf10/test/ruby/test_enum.rb#L559-L570) (file `test/ruby/test_enum.rb`), I ran the following code w...
- 03:14 PM Revision edd063ab (git): * 2017-04-20
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58406 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * vm_insnhelper.c (vm_once_dispatch): no guarantee that tail call
is always optimized away.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58405 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- r54575 fixes a bug in ext/tk of Ruby 2.3, which was introduced by r53077.
Reference:
https://github.com/ruby/tk/pull/8
http://stackoverflow.com/questions/43011258/ruby-tks-canvas-and-shapes-are-bugging-out/43476737 -
- shyouhei (Shyouhei Urabe) wrote:
> We looked at this issue in yesterday's developer meeting.
> ...
nobu (Nobuyoshi Nakada) wrote:
> rhenium (Kazuki Yamaguchi) wrote:
> ...
Thanks for review, committed as r58404. -
02:05 PM Feature #13302 (Closed): Provide a (force) --enable-openssl switch for ruby ./configure (or similar) - Applied in changeset trunk|r58404.
----------
extmk.rb: improve message printed when configuring extensions fails
Point to the mkmf.log if configuring an extension fails so that people
can find and fix the culprit easily. [ruby-core:8... -
- rhenium (Kazuki Yamaguchi) wrote:
> This is not informative about what exactly caused the failure. Actually, everything is logged to ext/*/mkmf.log, but people would never find this without googling. Maybe a change to ext/extmk.rb somet... -
- Point to the mkmf.log if configuring an extension fails so that people
can find and fix the culprit easily. [ruby-core:80131] [Feature #13302]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58404 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
12:05 PM Feature #12573: Introduce a straightforward way to discover whether a process is running
- Ah, I see what you are saying.
`/var` isn't always available to an application, especially in a shared server situation. That's one of the reasons pretty much every one of the daemonizing gems implements the `kill(0)` mechanism. -
- will_in_wi (William Johnston) wrote:
> Yup, sometimes you have access to an NFS volume, but not enough system access to mount things.
No, I mean, /var is expected to be suitable for locking. You have already mentioned FHS, and it's ... -
- Yup, sometimes you have access to an NFS volume, but not enough system access to mount things.
-
- will_in_wi (William Johnston) wrote:
> Thanks for looking at this!
> ...
Do you really want to place a pidfile on a NFS volume? I'd rather mount a ramdisk on /var for diskless situation.
-
- We need to list library entries for default gems.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58403 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- It has already ensured inlining in where vm_getivar()
(https://github.com/ruby/ruby/blob/524fb0138b773f2ed01441abbcffeda0271175c5/vm_insnhelper.c#L908)
So,I'm guessing that there is no reason what avoid inlining at vm_setivar() -
- "set instance variable" will be faster around 14%.
## macOS 10.12 + clang-802.0.41
### Before
~~~
user system total real
1.550000 0.000000 1.550000 ( 1.555161)
~~~
### After
~~~
user ... -
- # Summary
`TracePoint#enable` with block should enable thread-local trace.
# Current behavior
`TracePoint#enable` enables TracePoint for all of threads, even if it called with `do...end` blcok.
```ruby
t1 = Thread.new{
lo... -
- Those opt_something instructions are worth refactoring. They tend to
have similar ways of executions. By extracting the common part,
generated vm_exec_core function shrinks from 26,816 bytes to 26,256
bytes (according to nm(1)).
This c... -
06:26 AM Feature #12921: Retrieve user and password for proxy from env
- kosaki (Motohiro KOSAKI) wrote:
> Linux kernel expert is here.
Hi. What do your think about this:
shyouhei (Shyouhei Urabe) wrote:
> ...
-
12:47 AM Feature #12921: Retrieve user and password for proxy from env
- Hi
Linux kernel expert is here.
wolfer (Sergey Fedosov) wrote:
> akr (Akira Tanaka) wrote:
> ...
No they dont.
All unix only have peocess scope env.
-
-
- red (Arnaud Rouyer) wrote:
> Basing myself on the GNU ls util, I propose supporting an `:ignore` key in the optional hash argument.
> ...
`ignore: :almost_all` seems like that almost all files will be ignored and only '.' and '..' wi... -
- akr@fsij.org wrote:
> I think we can try it to see the incompatibility is really minor or not.
> So, it should be described in NEWS.
OK, r58400.
I think Ruby 1.8 => 1.9 introduced similar minor incompatibility
for all pipe and ... - 01:08 AM Feature #13362 (Closed): [PATCH] socket: avoid fcntl for read/write_nonblock on Linux
- Applied in changeset trunk|r58400.
----------
socket: avoid fcntl for read/write_nonblock on Linux
On platforms where MSG_DONTWAIT works reliably on all sockets
(so far, I know of Linux), we can avoid fcntl syscalls and
implement IO#wr... - 01:08 AM Revision 0848b68a (git): * 2017-04-19
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58401 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 01:08 AM Revision c32fc82d (git): socket: avoid fcntl for read/write_nonblock on Linux
- On platforms where MSG_DONTWAIT works reliably on all sockets
(so far, I know of Linux), we can avoid fcntl syscalls and
implement IO#write_nonblock and IO#read_nonblock in terms of the
socket-specific send and recv family of syscalls.
... -
04/18/2017
-
- A MinGW build of `ruby 2.5.0dev (2017-04-18 trunk 58397) [x64-mingw32]` had a silent SEGV when running [`TestLambdaParameters#test_call_simple`](https://github.com/ruby/ruby/blob/d939fdc119ce274d50114addbc83aa6ee0bfad9c/test/ruby/test_l...
-
11:50 PM Bug #13438: Fix heap overflow due to configure.in not being updated for HEAP_* -> HEAP_PAGE_* variable renaming
- ko1 (Koichi Sasada) wrote:
> On 2017/04/19 1:23, merch-redmine@jeremyevans.net wrote:
> ...
Ah. I see. Reading more of configure.in, HEAP_ALIGN_LOG is only set to 12 or 13 support OpenBSD <5.2 and MirOS. At this point, we may want t... -
- On 2017/04/19 1:23, merch-redmine@jeremyevans.net wrote:
> I think it should be backported to 2.4, to ensure that ruby GC respects the operating system page size (as it did in ruby 2.3 and below).
Note that gc's PAGE is not relative... -
- jeremyevans0 (Jeremy Evans) wrote:
> After some more analysis and research, I don't think this patch to gc.c is necessary. I think this is a problem on OpenBSD when calling posix_memalign with allocations over 4KB that are slightly les... -
- ko1 (Koichi Sasada) wrote:
> > I think this is a problem on OpenBSD when calling posix_memalign with allocations over 4KB that are slightly less than the aligned size when using malloc canaries
> ...
I don't think we need to make any c... -
- > I think this is a problem on OpenBSD when calling posix_memalign with allocations over 4KB that are slightly less than the aligned size when using malloc canaries
OMG. Thank you for your analysis.
So you mean we should reduce `HEAP... -
- jeremyevans0 (Jeremy Evans) wrote:
> I tried increasing the size passed to `aligned_malloc` to see if I could determine the size of the overflow. It turns out that it overflows not by a single byte, but by 40 bytes. Coincidentally, th... -
11:09 PM Feature #13362: [PATCH] socket: avoid fcntl for read/write_nonblock on Linux
- I think we can try it to see the incompatibility is really minor or not.
So, it should be described in NEWS. -
- akr@fsij.org wrote:
> Issue #13362 has been updated by akr (Akira Tanaka).
>
> Status changed from Open to Feedback
>
> I think it's possible on such platforms.
>
> If some non-Ruby application depend on nonblocking flag set b... -
-
- As of recent builds (2017-04-18 trunk 58397), this SEGV no longer occurs.
PLease close. -
09:14 PM Bug #13141: Spurious Net::FTPReplyError
- shugo (Shugo Maeda) wrote:
> Please retry on FTPReplyError as a workaround.
I have implemented this workaround and it has successfully recovered several times now. FWIW the code is:
~~~ ruby
retries = 3
begin
ftp.getbinaryfi... -
- This patch is no longer needed as of builds around `ruby 2.5.0dev (2017-04-17 trunk 58383) [x64-mingw32]`. It may return when I get around to building 2.4 and 2.3 stable branches. Please close.
-
- Also, this is a bit far off; but a potential future optimization
is even being able to use readonly markers in C methods to
infer readonly args use in pure Ruby methods.
For example, Rack::Request is:
def get_header(name)
@... -
- naruse@airemix.jp wrote:
> Issue #13434 has been updated by naruse (Yui NARUSE).
> ...
Cool, I forgot about that rb_scan_args optimization. Maybe we
can use similar optimization for defining methods, too,
to speed up VM startup.
... -
- I agree with the concept.
From r55102, rb_scan_args is statically resolved by C compilers on some environment, rb_get_kwargs is still inefficient.
To allow C compilers statically resolve them, Ruby method in C should be defined in mo... -
- Would you commit it by yourself?
-
- This is similar with https://github.com/ruby/ruby/pull/1552
At least, Array#eql? will be faster around 30% with following test code.
### Before
~~~
user system total real
1.740000 0.000000 1.740000 ( ... -
- After some more thought (and the desire for a method name that could be used with other objects), I think
`#each?`
might work for many objects, including those that inherit/include `Enumerable`.
Simply defined, `each?` returns `... -
- shyouhei (Shyouhei Urabe) wrote:
> Any other ideas?
Assuming we want to stay away from prefixed or concatenated names, I might suggest -
`#content?` -
- possible name of this method:
- #present? is NG because that conflicts with ActiveSupport (AS's #present? have different semantics than what is discussed here).
- #empty? is NG because the OP wants to use it in conjunction with &.
... -
- wanabe (_ wanabe) wrote:
> nobu (Nobuyoshi Nakada) wrote:
> ...
Yes, of course.
> `__builtin_alloca()` of gcc would be useful but `alloca()` in missing/alloca.c would not, I guess.
Only when `C_ALLOCA` is not defined.
See `reser... -
- Applied in changeset trunk|r58398.
----------
compile.c: wrong optimization
* compile.c (compile_branch_condition): expression which has side
effects should not be eliminated.
[ruby-core:80740] [Bug #13444] -
11:44 AM Bug #13444: compatibility breaking change: backticks is not evalueted as shell script call while in "unless" operator context
- Or putting a warning, because optimization actually changes behavior.
-
- Might be worth documenting.
-
- yes, You are right, it was my mistake to use it in this way, as this example is actually pointless and always True. all meaningful expression (as for ex. 1==Integer(`echo 1`, 10)) are evaluated correctly. Probably you should close and de...
-
12:36 AM Bug #13444: compatibility breaking change: backticks is not evalueted as shell script call while in "unless" operator context
- `ruby` does not evaluate specific kinds of expressions at `if`/`unless` cond after r54775.
NODE_XSTR is one of them. -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58399 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * compile.c (compile_branch_condition): expression which has side
effects should not be eliminated.
[ruby-core:80740] [Bug #13444]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58398 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58397 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Surprisingly this was not a syntax error on my machine.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58396 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58395 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
-
- Seems that this was fixed at r58394.
Thank you for quickly fixing and please close this ticket. -
- ~~~
$ make
CC = clang
LD = ld
LDSHARED = clang -dynamic -bundle
CFLAGS = -O3 -fno-fast-math -ggdb3 -Wall -Wextra -Wno-unused-parameter -Wno-parentheses -Wno-long-long -Wno-missing-field-initializers -Wno-tautological-compare -Wn... -
- 以下のようにサーバーを起動して別端末で `ruby -e '$LOAD_PATH.push "sample"' -e 'require "drb/http0"' -e 'remote = DRbObject.new_with_uri "http://127.0.0.1:12346"; puts remote.test'` のように呼び出すと、以下のように `client.uri` で `NoMethodError` になるので、 r32254 の変更で動かなくなったよう...
-
- * insns.def (trace): use cast `flag` to pass compilation with clang on MacOSX.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58394 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- [Fix GH-1586] Patch by @jbampton
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58393 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Thanks for looking at this!
Locking is less reliable than kill(0) in situations such as NFS filesystems. Not all filesystems have a robust locking mechanism. So, yes, we'd need kill(0) for a robust implementation of a locking pidfile.... -
- We looked at this issue in yesterday's developer meeting.
Agreed that a locked pidfile is the best to achieve your request. One question is, do we still need to kill(0) in that case? Because if we assume locking, that should be more ... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58392 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 10:58 AM Revision ee4ce52d (git): * remove trailing spaces.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58391 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Contemporary C compilers are good at function inlining. They fold
multiple functions into one. However they are not yet smart enough to
unfold a function into several ones. So generally speaking, it is
wiser for a C programmer to manu... -
- akr (Akira Tanaka) wrote:
> environment variables are not visible from other users?
As far as I know, in almost every modern Linux distribution you can set system-wide env, per-user env and process-specific env. User can solve the pr... -
- akr (Akira Tanaka) wrote:
> How about make white-list of OSs which environment variables are not visible from other users?
It's OK to me. -
08:58 AM Feature #13382: [PATCH] Options for FTP PORT command
- shugo (Shugo Maeda) wrote:
> The name data_listening_address= seems misleading because it doesn't
> ...
I see. It is reasonable.
> And data_listening_port= is less flexible than setActivePortRange()
> ...
This is reasonable too.
B... -
- * eval.c (setup_exception): do not exit by goto inside
PUSH_TAG/POP_TAG. it causes an infinite loop.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58389 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * configure.in (--with-git): honor environment variable GIT if
set.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58388 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- We looked at this issue in yesterday's developer meeting.
Kazuki's improved log seems good so please go ahead.
Another possible way proposed there was to mandate openssl installation when configure is run with --with-ext=openssl, i... -
- We looked at this issue in yesterday's developer meeting.
While discussing, we learned that prepended ancestors are not linearizable using the C3 algorithm. When you prepend something, you normally want to override a method in a spec... -
- We looked at this issue in yesterday's developer meeting.
The use of private in evolve75/RubyTree shown in the description is in fact wrong (methods are defined in a wrong place). That example made us think that the use of private in... -
- It seems fixed already. Try a newer version. Tell us if it still happens.
-
- We looked at this issue in yesterday's developer meeting.
While extending Hash#delete is still a valid feature request, it seems to us that the OP wants something different; the example code shows that what is actually wanted is to sp... -
- No objection.
-
-
- Please close.
I fixed the issue based on looking into [tool/vsc.rb](https://github.com/ruby/ruby/blob/2103197ccebe4f6efea1e4160d46471396507d6b/tool/vcs.rb) only where my error was.
Nobu fixed the issue based on everywhere in the fi... -
- * tool/vcs.rb (VCS::SVN::COMMAND, VCS::GIT::COMMAND): customize
command paths by environment variables.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58387 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * enc/depend (enc/unicode.o): remove hardcoded Unicode versions.
this object file must be compiled by toplevel make.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58386 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
01:17 AM Bug #13446 (Closed): refinements with prepend for module has strange behavior
- ~~~ruby
using Module.new {
refine Enumerable do
alias :orig_sum :sum
end
}
module Enumerable
def sum(*args)
orig_sum(*args)
end
end
class GenericEnumerable
include Enumerable
def each
end
end
...
04/17/2017
- 11:47 PM Revision 0644c4ef (git): * 2017-04-18
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58385 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * test/ruby/test_settracefunc.rb (test_throwing_return_with_finish_frame):
should not use `return`, but should use `next`.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58384 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
11:21 PM Feature #12886: URI#merge doesn't handle paths correctly
- > In other words, in the end, only absolute URIs are actionable. So we need an absolute URI eventually. The way relative resolution is defined, this means that if we have absolute + relative1 + relative2, this is interpreted as (absolute...
-
09:17 AM Feature #12886: URI#merge doesn't handle paths correctly
- naruse (Yui NARUSE) wrote:
> [URL Standard](https://url.spec.whatwg.org/) defines partially merging, but it is base (absolute URL) + relative as you may know.
Which is exactly the same in RFC 3986.
> ...
In other words, in the end... -
- [URL Standard](https://url.spec.whatwg.org/) defines partially merging, but it is base (absolute URL) + relative as you may know.
And the base URL must be absolute.
You need to make absolute URI from request or something before join. -
- > I wonder whether there are any other languages/libraries that implement anything like the operation you propose.
This use case is already working in `addressable` gem:
~~~ruby
Addressable::URI.parse("/foo/bar")
=> #<Addressabl... -
- I'm not suggesting that the operation is defined for all URIs, just ones where it makes sense.
-
- I agree with Martin-sensei.
Defining hierarchical path operation for all URIs (including non-hierarchical URI such as mailto:) is curious. -
- note: https://github.com/ruby/ruby/pull/1469
-
- PR is 1587, but link is correct...
-
- When generating a MinGW build from a local repo, the revision.h file does not exist, and is create by [`tool/file2lastrev.rb`](https://github.com/ruby/ruby/blob/trunk/tool/file2lastrev.rb) which requires [`tool/vcs.rb`](https://github.co...
-
- Ruby versions from 2.0 to 2.3.x while executing shell script via backticks inside of "unless" construction had it executed and evalueted output as condition,
version 2.4 and onwards had condition evaluated as true but script is not exec... -
- jeremyevans0 (Jeremy Evans) wrote:
> 1) The heap overflow only happens when the operating system uses <16kb pages and ruby is set to use 16k heap pages.
> ...
I did some testing with different versions of HEAP_PAGE_ALIGN_LOG. Here's t... -
- * string.c (rb_str_splice_0): improve performace of single byte
optimizable cases, insertion 7bit string to 7bit string.
[ruby-dev:49984] [Bug #13228]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58383 b2dd03c8-39d4-4d8f-98ff-8... -
- * thread_win32.c (w32_wait_events): fix wait object index in the
case of interrupt_event is not usable.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58382 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- nobu (Nobuyoshi Nakada) wrote:
> `ALLOCA` would be useful.
Is it platform dependent?
`__builtin_alloca()` of gcc would be useful but `alloca()` in missing/alloca.c would not, I guess. -
- wanabe (_ wanabe) wrote:
> 2. Ensure enough stack before `rb_vm_push_frame()` or control SIGSEGV point
> ...
`ALLOCA` would be useful. -
- There are some choices for this "cfp consistency error".
All patches are just for description and incomplete.
1. Mark as WONTFIX
I think this is most reasonable because the issue is edge case.
2. Ensure enough stack before `rb_... -
- stomar (Marcus Stollsteimer) wrote:
> The docs _do_ appear in the generated documentation. However, **ruby-doc.org** separates core and stdlib documentation, so http://ruby-doc.org/core-2.4.1/String.html has all the methods defined in... -
- It's natural because String index access requires character counting.
If you need performance and the string is ASCII or Binary, you can set encoding of the string by String#force_encoding.
Then ruby can use direct index access.
May... -
09:36 AM Bug #13228: s[i]=c(assigning a character) for String is slower than Array on Linux
- Difference of locale configuration, not OS?
~~~
sorah@yuuki ~ $ uname -a
Linux yuuki 4.9.6-gentoo-r1 #1 SMP Sun Feb 12 01:20:31 UTC 2017 x86_64 Intel(R) Celeron(R) CPU N3050 @ 1.60GHz GenuineIntel GNU/Linux
sorah@yuuki ~ $ time e... -
-
- How about make white-list of OSs which environment variables are not visible from other users?
If ruby runs on OS in such list, setting password in an environment variable is acceptable.
So, we can support password in http_proxy with... -
- I want to use this with &.
Therefore String#empty? is not suitable.
It must returns false if it is empty.
Note that String#present? is also no good because ActiveSupport's present? returns false if its all content are space. -
08:29 AM Feature #9453: Return symbols of defined methods for `attr` and friends
- Yes, `def` and `define_method` returns symbols now.
But it does not mean `attr_*` should return symbols. Since they can define multiple methods.
Considering there's no use for private attributes, I don't think the proposal creates real... -
-
- Unfortunately RFC3986 allows "'" in host.
```
authority = [ userinfo "@" ] host [ ":" port ]
host = IP-literal / IPv4address / reg-name
reg-name = *( unreserved / pct-encoded / sub-delims )
sub-delims... -
07:36 AM Feature #12760: Optional block argument for `itself`
- I believe the situation **should** be addressed just by somebody's authority.
What do you think about appointing the name selection for next core dev meeting? You can just take a list that gathered in current ticket and do some voting... -
- how about `alter`?
at dev meeting, someone said `reform`.
-
-
-
- normalperson (Eric Wong) wrote:
> We can maybe use FL_USER{3,4,5}, and STR_NOFREE flags for
> ...
FL_USER{3,4,5} are for `RSTRING_EMBED_LEN_MASK`. -
- You haven't explained the reason behind the proposal. We don't understand why you think it's "better".
If you think you can persuade us with real-world use-case, try to reopen the issue.
Matz.
-
- OK, accepted.
Matz.
-
- I don't think "pass" is a good name for it.
Matz.
-
- I guess a some method such as Kernel#ancestor_modules, which returns all class/modules to search methods, supports your needs directly than undef'ing singleton_class.
-
- A long time has passed. I am a bit concerned about the situation.
Do we still need this, regarding the fact I am not a big fan of autoloading?
In any case, I don't like the name "NoConstantError" which should be somehow analogous to ... -
- I think it's possible on such platforms.
If some non-Ruby application depend on nonblocking flag set by Ruby,
such application will be affected, though.
It is better style that such application set nonblocking flag explicitly.
-
-
-
- Range#{min,max} will be faster around 30%.
### Before
~~~
user system total real
Range#min 1.270000 0.010000 1.280000 ( 1.279449)
Range#max 1.300000 0.000000 1.300000 ( 1.310150)
~~~
... -
- OK, now is the time to go.
Matz.
-
05:09 AM Feature #13382: [PATCH] Options for FTP PORT command
- osa (Shunsuke OSA) wrote:
> Thank you so much for your survey.
> ...
The name data_listening_address= seems misleading because it doesn't
change the address to be bound.
And data_listening_port= is less flexible than setActivePortRan... -
- * eval.c (setup_exception): copy frozen exception before setting
up a cause not only a backtrace.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58381 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * eval.c (setup_exception): consider if the exception is frozen,
but not one of special exception objects.
* gc.c (rb_memerror): copy minimum objects.
* thread.c (rb_threadptr_execute_interrupts): prepare special
exception queued b... -
- * vm_insnhelper.c (rb_threadptr_stack_overflow): move from
thread.c and integrate with vm_stackoverflow.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58379 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * parse.y (WARN_CALL, WARNING_CALL): need `##` between a comman
and `__VA_ARGS__` in the case it is empty, not to end arguments
with a comma.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58378 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * vm_backtrace.c (rb_threadptr_backtrace_object): rename and
extern.
* vm_backtrace.c (rb_threadptr_backtrace_str_ary): rename as
threadptr since the parameter is rb_thread_t*.
* vm_backtrace.c (rb_threadptr_backtrace_location_ary)... -
- * eval.c (rb_longjmp, rb_raise_jump): parameterize thread, and
share rb_longjmp.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58376 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * gc.c (rb_threadptr_stack_check): check probability of stack
overflow for the given thread, not the current thread.
* vm_eval.c (stack_check): check the given thread, not the current
thread.
git-svn-id: svn+ssh://ci.ruby-lang.org/... -
- * gc.c (PREVENT_STACK_OVERFLOW): define TRUE to try preventing
stack overflow before actually happens.
* gc.c (stack_check): parameterize thread pointer.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58374 b2dd03c8-39d4-4d8f-98ff...
04/16/2017
-
- As long as we're discussing git and the build system, do you believe the following would help (or not break) builds on *nix systems?
place after [line 7 of tools/vcs.rb](https://github.com/ruby/ruby/blob/trunk/tool/vcs.rb#L7)
```ru... - 03:54 PM Revision d2b68234 (git): * 2017-04-17
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58373 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * test/ruby/test_integer.rb: simplify test for Integer.sqrt.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58372 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * tool/rbinstall.rb (default-gems): skip gemspec if corresponding
Makefile does not exist.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58371 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * thread_win32.c (w32_wait_events): do not acquire GVL, to fix
deadlock at read/close race condition. instead, just ignore
interrupt_event if it is closed.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58370 b2dd03c8-39d4-4d8f-... -
- cf. https://github.com/ruby/ruby/commit/556e3da4216c926e71dea9ce4ea4a08dcfdc1275
-
- stomar (Marcus Stollsteimer) wrote:
> Do you mind when I simplify the test and also reduce the number of tested values (50.000 seems more than necessary, and increases the runtime for the integer tests by a considerable percentage; even... -
- Here is another stat for association between first SEGV point and process result.
```
ruby 2.5.0dev (2017-04-16 trunk 58367) [x86_64-linux]
71 bug.*.cfp.noprev.BUG.txt
71 #6 in vm_exec () at ../../vm.c:1759, #7 in invoke_b... -
- I have checked the patterns with attached .patch and .sh and .rb.
This is the result at r58331.
```
ruby 2.5.0dev (2017-04-13 trunk 58331) [x86_64-linux]
73 bug.*.cfp.noprev.BUG.txt
73 #0 __GI_raise (sig=sig@entry=6) at ..... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58369 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- jeremyevans0 (Jeremy Evans) wrote:
> ko1 (Koichi Sasada) wrote:
> ...
Koichi,
After giving this some more thought, it's possible this doesn't fix the underlying memory issue. There are two possibilities:
1) The heap overflow onl... - 02:00 AM Revision d8ea05c1 (git): * test/ruby/test_io.rb (test_race_closed_stream): separate because it stops
- entire test process on Windows.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58368 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
04/15/2017
-
- nobu,
Thank you for the info. A hardcoded string (full path) worked with the RubyGems tests. Now, I need to try the environment variable in `PKGBUILD`, which is one of several set before the build starts (many are info about the cur... -
- nobu (Nobuyoshi Nakada) wrote:
> Try `--with-git=git.exe` configuration option.
Thanks. I'll try, just started a build testing the `io.c` patch.
Should that be `git.exe` or a full path to the file? -
- I think rather `Gem::TestCase#in_path?` should consider `RbConfig::CONFIG['EXECUTABLE_EXTS']`, or `RbConfig::CONFIG['EXEEXT']` at least.
-
- Try `--with-git=git.exe` configuration option.
-
- These changes cause 37 RubyGems tests to be skipped.
-
- As I've mentioned before, I've been building and using MinGW trunk builds for several months. I've needed a few patches to stop segv issues, but recent builds have had approx ten combined failures and errors.
I've never had issues wi... -
- @nobu
Do you mind when I simplify the test and also reduce the number of tested values (50.000 seems more than necessary, and increases the runtime for the integer tests by a considerable percentage; even for only 1000 cases, i.e. ste... -
- Applied in changeset trunk|r58366.
----------
bignum.c: fix inexact estimation
* bignum.c (estimate_initial_sqrt): estimated square root is
inexact if it is not equal to its ceil, needs Newton's method.
[ruby-core:80696] [Bug #13440] -
- The new `Integer.sqrt` method produces wrong results, e.g. for
38815036599065022652481536
38904514499428047971680256
and (many) other numbers.
Note that these numbers were picked selectively (these are not the 2 smalles... - 03:29 PM Revision c747848d (git): * 2017-04-16
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58367 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * bignum.c (estimate_initial_sqrt): estimated square root is
inexact if it is not equal to its ceil, needs Newton's method.
[ruby-core:80696] [Bug #13440]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58366 b2dd03c8-39d4-4d8f-98... -
- normalperson (Eric Wong) wrote:
> I'm not sure if including new APIs in ruby/intern.h is a good
> ...
OK, moved them at https://github.com/ruby/ruby/pull/1537/commits/cfdbfb4c0d9269df9679de8793929130219e662d -
- +cc ruby-core since this post was English
watson1978@gmail.com wrote:
> Issue #13341 has been reported by watson1978 (Shizuo Fujita).
>
> ----------------------------------------
> Bug #13341: Improve performance of implicit typ... -
- +cc ruby-core since this post was English
watson1978@gmail.com wrote:
> Issue #13341 has been reported by watson1978 (Shizuo Fujita).
>
> ----------------------------------------
> Bug #13341: Improve performance of implicit typ... -
- Thank you so much for your survey.
If we translate java's `setReportActiveExternalIPAddress()` into Ruby method literally, it seems to be `report_active_external_ip_address=`.
But this name is difficult to understand for me.
("repo... - 07:13 AM Revision 5fb0f3f0 (git): * properties.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58365 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 07:13 AM Revision d6a69712 (git): fix ext/-test-/struct/ dependencies
- I started writing a template for auto-generation and
let "tool/update-deps --fix" fill in the rest.
Hopefully this fixes problems with some CI builds
after r58359. Further changes to other ext/-test-/
files should probably add or updat... -
- ko1 (Koichi Sasada) wrote:
> Just for confirmation.
> ...
This is not just a configuration issue, this patch actually solves the heap overflow issue by making sure the correct `#define` is in `config.h`. Without this patch, on OpenBSD... -
- Thank you for your survey. Great help.
Just for confirmation.
Your patch doesn't solve memory problem, but for configuration, right?
Thanks,
Koichi
-
- * signal.c (check_stack_overflow): drop the last tag when it is
close to the fault page, not same as sp page.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58363 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * include/ruby/ruby.h (rb_funcall): check if argc matches the
number of variadic arguments, and replace with rb_funcallv.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58362 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * signal.c (raise_stack_overflow): prefer pthread_sigmask to
sigprocmask, for multithreading.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58361 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 12:46 AM Bug #13439 (Closed): [PATCH] fix RSTRUCT_LEN macro in public C API
- Applied in changeset trunk|r58359.
----------
fix RSTRUCT_LEN macro in public C API
rb_struct_size returns an Integer VALUE, so it must be converted
to a `long` for compatibility with previous Ruby C API versions.
* ext/-test-/struct/... -
- rb_struct_size returns an Integer VALUE, so it must be converted
to a `long` for compatibility with previous Ruby C API versions.
* ext/-test-/struct/len.c: new
* test/-ext-/struct/test_len.rb: new
* include/ruby/ruby.h (RSTRUCT_LE... - 12:46 AM Revision fd421a9a (git): * properties.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58360 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 12:46 AM Revision 8e64799c (git): fix RSTRUCT_LEN macro in public C API
- rb_struct_size returns an Integer VALUE, so it must be converted
to a `long` for compatibility with previous Ruby C API versions.
* ext/-test-/struct/len.c: new
* test/-ext-/struct/test_len.rb: new
* include/ruby/ruby.h (RSTRUCT_LEN): u...