Activity
From 03/28/2017 to 04/03/2017
04/03/2017
-
10:58 PM Bug #13398 (Closed): segfault: Thread.new(foo, &:bar)
- Already fixed bug, try 2.4.1.
-
08:54 PM Bug #13398 (Rejected): segfault: Thread.new(foo, &:bar)
- This works:
~~~
⤑ ruby -ve "p Thread.new('abc'){|s| s.reverse}.value" ~/C/opal
ruby 2.4.0p0 (2016-12-24 r... -
08:10 PM Bug #13397: #object_id should not be signed
- Ok, you want to prevent Bignums, but what is the suggested solution here? Do some pack("l").unpack("L") to get the expected value? Or you can provide object_hexid [ [1] ]. Or provide some %p equivalent formatter?
Because I am afraid t... -
- It's not to make `object_id`s Bignum as possible.
-
- It is surprising that #object_id returns signed value. Let me explain show two examples. Working with 32b Ruby (ruby 2.4.0p0 (2016-12-24 revision 57164) [i386-linux]) to make this issue more apparent.
~~~
$ ruby << \EOR
GC.disable
... -
07:23 PM Revision 5f22cfcc (git): improve docs for #truncate, #floor, and #ceil methods
- * numeric.c: [DOC] improve and harmonize documentation
for {Float,Integer,Numeric}#{truncate,floor,ceil}.
* rational.c: [DOC] ditto for Rational#{truncate,floor,ceil}.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58244 b2dd03c8-3... - 07:19 PM Revision d9e1cfe2 (git): * 2017-04-04
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58243 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * numeric.c: [DOC] improve and harmonize documentation
for {Float,Integer,Numeric}#round.
* rational.c: [DOC] ditto for Rational#round.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58242 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
05:52 PM Feature #9999: Type Annotations (Static Type Checking)
- RDL is interesting, I wonder what the runtime overhead is like?
Another source of inspiration could be Facebook's Flow (https://flow.org/en/docs/getting-started/) for JS. In that case it's build-time type checking, mostly inferred, wi... -
- Thank you for the correction.
-
02:19 PM Feature #13395: Add a method to check for not nil
- nobu (Nobuyoshi Nakada) wrote:
> Hanmac (Hans Mackowiak) wrote:
> ...
are you sure? i am currently on ruby 2.3.3 Windows
~~~ ruby
[1, "bc", nil].count #=> 3
[1, "bc", nil].count(&:itself) #=> 2
~~~
-
- Hanmac (Hans Mackowiak) wrote:
> ~~~ ruby
> ...
IIRC, it equals to simple `array.count`. -
- ~~~ ruby
array.count(&:itself)
~~~
does work for something **similar** like that.
its not 100% what you might want, because it does ignore `false` too -
01:54 AM Feature #13395: Add a method to check for not nil
- Any ideas about the name?
-
01:25 AM Feature #13395: Add a method to check for not nil
- Many methods that take a block come in positive-negative pairs, unlike `count`. I am not sure how frequent the use case is, but if it is, I rather claim that there should be a negative version of `count`.
-
12:44 PM Bug #13277: Ruby 2.4.0 gem server 2.6.8
- Verified as fixed in [oneclick / rubyinstaller #21](https://github.com/oneclick/rubyinstaller2/issues/21#issuecomment-291074326). Please close.
-
12:30 PM Revision b16f9112 (git): Fix arguments order of IO#pwrite
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58241 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
11:32 AM Feature #13396 (Closed): Net::HTTP has no write timeout
- When sending a large request to an unresponsive server, `Net::HTTP` can hang pretty much forever.
```ruby
# server.rb
require 'socket'
server = TCPServer.new('localhost', 2345)
loop do
socket = server.accept
end
```
``... -
02:31 AM Feature #12695: File.expand_path should resolve ~/ using /etc/passwd when HOME is not set
- Does anyone know if this also fixes the Dir.home value? Currently (in 2.3) that doesn't work when HOME is unset either.
pabs@chianamo ~ $ unset HOME
pabs@chianamo /home/pabs $ ruby -e 'print Dir.home'
-e:1:in `home': cou... -
- Applied in changeset trunk|r58240.
----------
Add IO#pread and IO#pwrite methods
These methods are useful for safe/concurrent file I/O in
multi-thread/process environments and also fairly standard
nowadays especially in systems support... -
- These methods are useful for safe/concurrent file I/O in
multi-thread/process environments and also fairly standard
nowadays especially in systems supporting pthreads.
Based on patches by Avseyev <sergey.avseyev@gmail.com> at
[ruby-core...
04/02/2017
-
08:22 PM Feature #13355: [PATCH] compile.c: optimize literal String range in case/when dispatch
- Eric Wong <normalperson@yhbt.net> wrote:
> * s/iseq_add_mark_object_compile_time/iseq_add_mark_object/
> since the range lifetime is tied to the overall iseq lifetime.
Brrr.. I was wrong the second time :x
iseq_add_mark_object... - 08:16 PM Revision 78ad438f (git): * 2017-04-03
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58239 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 08:16 PM Revision 6f73c387 (git): compile.c: avoid duplicate mark entry for string literal Range
- iseq_add_mark_object is called in iseq_set_sequence later on,
so we only need to call iseq_add_mark_object_compile_time
in iseq_peephole_optimize. Without this change, there would've
been a duplicate entry in the long-lived iseq mark_ar... -
10:00 AM Feature #12063: KeyError#receiver and KeyError#name
- I think "name" is more consistent with other exceptions, such as NameError#name and NoMethodError#name (by inheritance).
-
06:23 AM Feature #12063: KeyError#receiver and KeyError#name
- Which method name is best?
"**name**" referenced from "**Name**Error".
But I think, "**key**" is also good. Because this is "**Key**Error" method.
The patch on github is using "**key**".
Thanks. -
04:53 AM Misc #13329: Creating a German ruby mailinglist on ruby-lang.org?
- I had no time to create this list last week. Please wait a few days.
(NOTE; I'm NOT a full time open source developer. )
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58237 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 01:14 AM Revision cf6ec79b (git): thread.c: comments on M:N threading [ci skip]
- I may experiment with M:N threading in coming months. Often I
find myself yearning for the old 1.8 days when spawning threads
was really cheap for network operations. But I also like to use
native blocking recv_io and accept calls for ...
04/01/2017
-
- * rational.c (nurat_round_n): [DOC] improves Integer#round
documentation as well as Float#round.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58235 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 10:18 PM Revision 42166c62 (git): test/ruby/test_optimization.rb: quiet warnings
- This quiets an old "assigned but unused variable" warning left
over after r56653 as well as two new "ambiguous first argment"
warnings introduced in r58233.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58234 b2dd03c8-39d4-4d8f-98ff... -
-
- Never mind. Setup testing
```
configure.in:533
for option in --version -v -V -qversion; do
``` -
- In my config.log file, I'm finding a few errors like:
```
x86_64-w64-mingw32-gcc.exe: error: unrecognized command line option '-V'
x86_64-w64-mingw32-gcc.exe: error: unrecognized command line option '-qversion'; did you mean '--vers... -
-
- ko1 (Koichi Sasada) wrote:
> We should use such syntax for literal syntax such as frozen one (with blue color).
OK, updated. -
- I'd like to see colors allowed in method names. In the long run, all "bang methods" could be replaced by "red methods", to even better visually signal their dangerousness.
But I guess this would probably go beyond the scope of this fe... -
09:00 AM Feature #13393: New comment syntax
- I like colours. Even on first april so I have to take it almost literally as a real proposal.
(Actually after waking up, I forgot which day it was; the Assignee set here helped me
understand the proposal. :D )
It's one of the few t... -
07:47 AM Feature #13393: New comment syntax
- We should use such syntax for literal syntax such as frozen one (with blue color).
-
- nobu@ruby-lang.org wrote:
> Turning on highlight mode (i.e., `\e[1m`) starts a comment and turning off (i.e., `\e[m`) ends it.
> This visualizes comments very much.
+1 Please commit ASAP. This speeds up the parser 300% and load
t... -
- Now ruby has 2 comment syntax, `#...` and `=begin`..`=end`, but they are line-oriented both.
This is a proposal of a new, very visible, inline comment syntax.
Turning on highlight mode (i.e., `\e[1m`) starts a comment and turning off... -
- Eric Wong <normalperson@yhbt.net> wrote:
> normalperson@yhbt.net wrote:
> > https://bugs.ruby-lang.org/issues/13355
>
> I will commit this in a few days if no response.
Caught during self review:
* Use more descriptive variab... -
09:38 PM Feature #13355 (Closed): [PATCH] compile.c: optimize literal String range in case/when dispatch - Applied in changeset trunk|r58233.
----------
compile.c: optimize literal String range in case/when dispatch
This is similar in spirit to opt_case_dispatch as the literal
Range here is guaranteed to be immutable when used for
checkmatc... - 09:38 PM Revision 120976b9 (git): compile.c: optimize literal String range in case/when dispatch
- This is similar in spirit to opt_case_dispatch as the literal
Range here is guaranteed to be immutable when used for
checkmatch.
Normal range literals with non-frozen strings are actually
mutable, as Range#begin and Range#end exposes th... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58232 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
08:24 PM Feature #13395 (Open): Add a method to check for not nil
- There does not seem to be a method in Ruby to check if an object is *not* nil.
Such a method could help with readability.
Example:
> ~~~ ruby
> ...
- 08:20 PM Revision 4675ea91 (git): * 2017-04-02
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58231 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * rational.c: [DOC] improve docs for Rational and related methods
* improve class documentation for Rational
* fix call-seq's
* simplify examples for Rational#{floor,ceil,truncate,round}
* fix wrong examples for #floor, subtracti... -
05:22 PM Misc #13329: Creating a German ruby mailinglist on ruby-lang.org?
- What's the current status? Can you give an ETA as to when you are able to create the list?
Marvin -
- I believe this should be backported to 2.4, this is notably the version the OP used.
-
- nobu (Nobuyoshi Nakada) wrote:
> OK, although I still think it is too artificial example, nobody would mind a little change of the `OpenStruct` performance.
Thank you for your consideration, I committed as r58229.
I will let usa-s... -
- Applied in changeset trunk|r58229.
----------
ostruct.rb: improve fix for OpenStruct.allocate + #respond_to?
* lib/ostruct.rb (OpenStruct#respond_to_missing?): this makes
OpenStruct#respond_to? works on any OpenStruct instance,
jus... -
- * lib/ostruct.rb (OpenStruct#respond_to_missing?): this makes
OpenStruct#respond_to? works on any OpenStruct instance,
just like Kernel#respond_to? does, without workarounds.
[ruby-core:80292] [Bug #13358]
git-svn-id: svn+ssh://ci... -
- Applied in changeset trunk|r58227.
----------
array.c: Array#append and Array#prepend
* array.c (Init_Array): Add alias "append" to Array#push, and
"prepend" to Array#unshift. [Feature #12746] [Fix GH-1574]
Author: pascbjumper2 ... - 07:38 AM Revision 8dfd1e71 (git): * 2017-04-01
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58228 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * array.c (Init_Array): Add alias "append" to Array#push, and
"prepend" to Array#unshift. [Feature #12746] [Fix GH-1574]
Author: pascbjumper2 <stowers.joshua@live.com>
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58227 b2dd0... -
- 進捗です。
https://github.com/nobu/ruby/tree/bug/13391-map-arity
03/31/2017
-
- MSP-Greg (Greg L) wrote:
> Re docs, [Time#zone](https://msp-greg.github.io/ruby_trunk/Core/Time.html#zone-instance_method) seems to indicate that a time zone abbreviation is the return.
> ...
Probably: for me it's an abbreviation (on L... -
- Re docs, [Time#zone](https://msp-greg.github.io/ruby_trunk/Core/Time.html#zone-instance_method) seems to indicate that a time zone abbreviation is the return.
On my system (`ruby 2.5.0dev (2017-03-19 trunk 58021) [x64-mingw32]`), "Cen... -
- I'd suggest
```
%Z - Equivalent to %:z (e.g. +09:00)
``` -
08:39 PM Bug #13392 (Closed): TracePoint return event location is incorrect for methods defined with define_method
**Command**
~~~ ruby
ruby tracepoint_bug.rb
~~~
**Output**
~~~
ruby-2.4.1-p111 (x86_64-linux)
tracepoint_bug_ext.rb:4 call to_s
tracepoint_bug_ext.rb:5 c_call to_s
tracepoint_bug_ext.rb:5 c_return to_s
racepoint_bug.r...-
07:14 PM Feature #12589: VM performance improvement proposal
- magaudet (Matthew Gaudet) wrote:
> > You can not implement JIT without consuming additional memory. May be
> ...
By the way, I did some memory consumption measurements using size of
max (peak) resident area for a small Ruby progr... -
05:27 PM Feature #12589: VM performance improvement proposal
- vmakarov (Vladimir Makarov) wrote:
> Sorry, Matthew. I can not find your message on
> ...
Very curious! I don't quite know what went wrong... so here I am writing
a reply in Redmine to make sure it shows up for future searchers :)
... -
08:04 AM Feature #13166: Feature Request: Byte Arrays for Ruby 3
- I agree that the OP probably is more interested in a `BitVector`/`BitArray` than a `ByteArray`, at least for the specific use case he is describing. Nonetheless, such a data type sounds useful for high-performance code; it may also make ...
-
- * template/exts.mk.tmpl: place note footer message at the end.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58226 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * debug.c (set_debug_option): check garbage and overflow.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58225 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Thanks, Matz! I've been wanting this for a while.
I've just made a PR to the Github repo with the changes: https://github.com/ruby/ruby/pull/1574 -
06:03 AM Feature #13383: [PATCH] Module#source_location
- Eregon (Benoit Daloze) wrote:
> shyouhei (Shyouhei Urabe) wrote:
> ...
Great. I didn't know this. Thank you.
> Example:
> ...
Yes, I'm not against such feature. -
03:56 AM Bug #13391 (Closed): wrong number of arguments error for Hash#map when lambda given
- ## 内容
Ruby 2.4.1 にて `Hash` オブジェクトの `#map` に 2つの引数を受け取る lambda を渡した際、
arguments error が発生します。
Ruby 2.4.0, ないし 2.3.4 では同じコードを実行した際にはエラーは発生していませんでしたが、
trunk でも同じエラーが発生します。
## 再現コード
~~~
% cat lambda.rb
hash = { a: 'hoge', b: ... -
- Just ran the test file fifty (50) times on `ruby 2.5.0dev (2017-03-29 trunk 58201) [x64-mingw32]`, and it ran fine (no comments required). I'll try to build some intermediate svn's to narrow the issue to fewer commits.
-
- * debug.c (set_debug_option): add "codepage" option to force
locale charmap on Windows.
* localeinit.c (locale_charmap): use the codepage by debug env if
given.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58224 b2dd03c8-39d4-... -
- * win32/setup.mak (-basic-vars-): pass ENABLE_DEBUG_ENV to
Makefile.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58223 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
03/30/2017
-
- Today, while building trunk (64 bit MinGW), I had a 'no output' SEGV during test-all.
I think I've had this before, but I don't recall how recently, 32 or 64, etc.
The problem is in the following test:
File ['test/ruby/test_keyw... -
- pdahorek@seznam.cz wrote:
> Yes, these APIs are very platform specific. I was just
> checking documentations and existing solutions. Maybe I'll use
> the Resolv api, but I need to check incompatibilities and also
> a performance imp... -
03:21 PM Feature #13379: [PATCH] safe IMAP connections
- Yes, these APIs are very platform specific. I was just checking documentations and existing solutions. Maybe I'll use the Resolv api, but I need to check incompatibilities and also a performance impact.
-
02:53 AM Feature #13379: [PATCH] safe IMAP connections
- ahorek (Pavel Rosický) wrote:
> Thanks for the review. I've fixed the second case.
Thanks. The additional patches look fine.
> ...
getaddrinfo_a() is glibc specific, so we need alternatives on other platforms such as FreeBSD.
Do... - 03:20 PM Revision 2446c759 (git): * 2017-03-31
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58222 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * localeinit.c (locale_charmap): fix the return value to call conv
function instead of encoding index on platforms where locale
information is not available.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58221 b2dd03c8-39d4-4d8f... -
02:45 PM Bug #13319: GC issues seen with GCC7
- Trunk works fine.
ruby-2.3.4 fails even when build with gcc-7 -O3. -
-
- shyouhei (Shyouhei Urabe) wrote:
> In modern Ruby, prior to actually requiring a library, its gemspec tends to be loaded. From what I understand, people require foo/version.rb from foo.gemspec, and this is the first time when namespace... -
- In modern Ruby, prior to actually requiring a library, its gemspec tends to be loaded. From what I understand, people require foo/version.rb from foo.gemspec, and this is the first time when namespace foo is opened.
Is this info that... -
04:34 AM Feature #13383: [PATCH] Module#source_location
- Turning this into a feature ticket.
-
- it would be happier if we can get all of source locations where a class opened?
-
- Closing. Thank you for confirmation.
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58220 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58219 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * tool/git-refresh: parse options without git-rev-parse, which is
old on travis.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58218 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * tool/git-refresh: tool to clone or update git working directory.
* Makefile.in: use git-refresh.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58217 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- shugo (Shugo Maeda) wrote:
> FTPClient of Apache Commons seems to have setActivePortRange() and setActiveExternalIPAddress().
> ...
I found setReportActiveExternalIPAddress().
https://commons.apache.org/proper/commons-net/apidocs/or... -
- osa (Shunsuke OSA) wrote:
> > The default mode of Net::FTP is now passive, but do you really need the active mode?
> ...
Understood.
> > Do you know any FTP client implementation which provides similar options?
> ...
FTPClient of A... -
04:41 AM Feature #12589: VM performance improvement proposal
- Hi Matthew,
> https://developer.ibm.com/open/2017/03/01/ruby-omr-jit-compiler-whats-next/
I was reading your article, and I would like to say that what you
present there is just fantastic in my point of view.
Why fantastic? Beca... -
- Sorry, Matthew. I can not find your message on
https://bugs.ruby-lang.org/issues/12589. So I am sending this message
through email.
On 03/29/2017 04:36 PM, Matthew Gaudet wrote:
> Hi Vladimir,
>
> First and foremost, let me ... -
- Created https://github.com/ruby/webrick .
But https://rubygems.org/gems/webrick was reserved now. I will release/update webrick gem later.
03/29/2017
-
- Thanks for the review. I've fixed the second case.
The only blocker is getaddrinfo now. It's a lowlevel system api that always blocks. I'll take a look if I can rewrite the ruby api to use getaddrinfo_a or getaddrinfo_ex (no thread is... -
- ahorek (Pavel Rosický) wrote:
> Hi,
> ...
Thanks for the patch, but it doesn't seem enough because:
1. The :connect_timeout option of Socket.tcp doesn't work when DNS lookups by getaddrinfo block.
A new thread by Timeout.timeout... -
- Already applied fix for SMTP and HTTP
https://bugs.ruby-lang.org/issues/12678
The same fix for IMAP is here
https://bugs.ruby-lang.org/issues/13379
MR
https://github.com/ruby/ruby/pull/1573 - 07:12 PM Revision a8425965 (git): * 2017-03-30
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58216 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * doc/syntax/methods.rdoc: [DOC] small improvements: fix some typos,
grammar, punctuation, consistently use capitalized "Ruby".
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58215 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Will see as soon as 2.4.1 lands in Fedora. Will keep an eye on this.
-
- I couldn't reproduce with 2.4.1 and trunk. Maybe it got a fix after 2.4.0 release.
-
- subtileos (Daniel Ferreira) wrote:
> Hi Vladimir,
> ...
You are welcomed.
> That README is priceless.
> ...
My approach to JIT is not traditional. I believe that implementing JIT in MRI should be more evolutional to be successf... -
- Hi Vladimir,
On Tue, Mar 28, 2017 at 4:26 AM, <vmakarov@redhat.com> wrote:
> You can find the code on
> https://github.com/vnmakarov/ruby/tree/rtl_mjit_branch. Please, read
> file README.md about the project first.
>
T... -
- > I think I've reached a state of the project to make its current
> code public. Most of the infrastructure for RTL insns and JIT has
> been implemented.
Hi Vladimir,
Thank you very much for this post.
That README is pricele... -
04:35 PM Feature #13166: Feature Request: Byte Arrays for Ruby 3
- Crystal allows you to create byte-arrays as below:
```
byte_array = [] of Int8
``` -
- This is a comparison of real code I have in a gem that is optimized for CRuby and JRuby.
JRuby allows you to use Java byte-arrays, which is both more memory efficient than the
CRuby version (I can create bigger arrays), but its much, m... -
03:00 PM Revision 0ad16855 (git): * hash.c (any_hash): fix CI failure on L32LLP64 architecture.
- The patch was provided by usa. [ruby-core:80484] [Bug #13376]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_3@58213 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
02:59 PM Bug #8894 (Closed): Fixnum#quo returns wrong result when given a float
-
-
06:06 AM Bug #8894: Fixnum#quo returns wrong result when given a float
- This problem seems to be solved already since I tried this by ruby 2.2 and didn't have any problem.
So we can close this issue.
▼ Result by ruby 2.2
```
2.quo(2.0) # => 1.0
```
```
Rational(6) / 2.0 # => 3.0
```
-
- Thank you usa-san. I'll merge your patch soon.
I'd like to make v2_3_4 tag after confirming the result of CI on vc12-x64. -
02:35 PM Bug #13376: Symbol#hash is deterministic on 2.3
- I've fixed it.
nagachika-san, please apply this patch:
```diff
Index: hash.c
===================================================================
--- hash.c (revision 58210)
+++ hash.c (working copy)
@@ -168,7 +168,7 @@ any_hash(... -
- nobu (Nobuyoshi Nakada) wrote:
> Accepting huge requests which could exhaust memory with too may symbols *at once* would be rarely possible in 2.3.
CVE-2011-4815 is about hash collisions, which indeed seems possible if a user can con... -
- Accepting huge requests which could exhaust memory with too may symbols *at once* would be rarely possible in 2.3.
-
02:09 PM Bug #13376: Symbol#hash is deterministic on 2.3
- should this receive a new CVE?
should this released be soon as 2.3.4? -
02:44 PM Feature #13382: [PATCH] Options for FTP PORT command
- > The default mode of Net::FTP is now passive, but do you really need the active mode?
In the real world, sometimes we have to connect FTP servers without passive mode support. But modern server environment such as clouds like AWS EC2... -
- osa (Shunsuke OSA) wrote:
> # Real use cases
> ...
The default mode of Net::FTP is now passive, but do you really need the active mode?
Do you know any FTP client implementation which provides similar options?
Python's ftplib doesn... -
- # Abstract
Add options to Net::FTP to set data listening host and port.
# Background
Net::FTP sends local address and default port to remote FTP server.
In FTP active mode, remote server will connect to client to establish data... -
02:16 PM Bug #13331 (Assigned): Inconsistent conversion of Float into Decimal
- Continue this in https://github.com/ruby/bigdecimal/issues/70
-
- takanabe (Takayuki Watanabe) wrote:
> こちらのリンク切れURLについてドキュメントの修正を送りたいのですが最新のURL候補等はございますか。
とりあえず Internet Archive に残っているのは確認しているのですが、
正式な移転先などがあればその方が良いかと思っているのですが、
誰か知らないでしょうか?
https://web-beta.archive.org/web/20161102044442/htt... -
05:51 AM Bug #13348: win32/README.win32 のアイコンがリンク切れ
- こちらのリンク切れURLについてドキュメントの修正を送りたいのですが最新のURL候補等はございますか。
-
- Seems fine.
-
09:04 AM Bug #12684: Delegator#eql? missing
- I fixed this issue and I added the specs.
Could you check it?
https://github.com/ruby/ruby/pull/1564
https://github.com/ruby/spec/pull/399 -
11:49 AM Revision e294fbaf (git): Fix two typos
- My typo checker :-) found the bugs.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58212 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Applied in changeset trunk|r58211.
----------
string.c: Supress logical-op-parentheses warning
* string.c(rb_str_upcase_bang): Supress logical-op-parentheses warning
Patch by Fukuo Kadota <fukuo-kadota@cookpad.com>,
Closes [GH-1570... -
09:47 AM Bug #13387 (Closed): [PATCH]Add parenthesis to fix compile warning to string.c
- When editing string.c and execute `make run`, below warnings showed.
```
$ make run
../ruby/string.c:6142:41: warning: '&&' within '||' [-Wlogical-op-parentheses]
...(flags&ONIGENC_CASE_ASCII_ONLY) && (enc==rb_utf8_encoding() || ... -
- * string.c(rb_str_upcase_bang): Supress logical-op-parentheses warning
Patch by Fukuo Kadota <fukuo-kadota@cookpad.com>,
Closes [GH-1570] [Bug #13387].
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58211 b2dd03c8-39d4-4d8f-98ff-... -
- 10:11 AM Bug #13312: String#casecmp raises TypeError instead of returning nil
- I agree this is not expecting behavior. then I made a patch for this.
Added test codes below.
```diff
diff --git a/test/ruby/test_string.rb b/test/ruby/test_string.rb
index 7dbf27e..3b72d25 100644
--- a/test/ruby/test_string.rb
+... -
10:03 AM Feature #13388 (Rejected): gc.c: Add GC.get_parameters and .set_parameters
- These methods are for inspecting and modifying MRI's GC parameters. It may be
useful for realtime parameter tuning with GC.stat, user requests and so on.
This work is done by Tomohiro Moro (@slightair) and me (@makimoto).
GH issue... -
10:02 AM Feature #12410 (Rejected): Process.uid= validation and casting
- As follows, it looks because BSD id(1) handles the uid argument as 32bit integer.
(Note that GNU coreutils' id(1) doesn't allow negative argument)
```sh
% id -un -- -4294967296
root
```
Therefore this behavior is considered as un... -
- Changing this ticket into a feature request because this request wants adding a new behavior into a existing method.
-
09:31 AM Feature #12410: Process.uid= validation and casting
- Wrote a patch for this ticket: https://github.com/ruby/ruby/pull/1568
It validates the argument for `Process#.uid=` using getpwuid. -
- Yes. When we use appending mode without offset, the file is not truncated.
Truncating files are occurred in write mode only. So it seems that we should just add the behaviour in write mode rather than adding behaviour in append mode.
... -
- DateTime wrongly calls timezone offset as "timezone".
It is considered as a documentation issue at this time. -
09:07 AM Bug #13231: DateTime.strftime("%Z") does not return time zone abbreviation, returns hour and minute offset from UTC with colon
- I think it contains a deep problem.
```sh
$ ruby -v
ruby 2.4.1p111 (2017-03-22 revision 58053) [x86_64-darwin16]
$ irb
irb(main):001:0> require 'date'
=> true
irb(main):002:0> Time.now.strftime('%Z')
=> "JST"
irb(main):003:0> ... -
09:52 AM Bug #13369: TracePoint gives incorrect `return_value` after rescuing error when using `return`
- By some investigations, it turned out to be caused by the result value passed in `hook_before_rewind` method .
The return value would be as expected by the batch, but it would fail in some tests. -
- Applied in changeset trunk|r58210.
----------
vsnprintf.c: prefix with precision
* vsnprintf.c (BSD_vfprintf): sign and hex-prefix should not be
counted in precision. [ruby-dev:47714] [Bug #8916] -
- * vsnprintf.c (BSD_vfprintf): sign and hex-prefix should not be
counted in precision. [ruby-dev:47714] [Bug #8916]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58210 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * test/minitest/test_minitest_unit.rb (assert_triggered): rename
to be hidden in backtraces.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58209 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Applied in changeset trunk|r58208.
----------
Add documents on Process::CLOCK_* constants
* process.c: Add documents on Process::CLOCK_* constants.
Patch by Sunao Komuro <sunao-komuro@cookpad.com>.
Closes [GH-1567] [Bug #13386] -
09:24 AM Bug #13386 (Closed): Improve Process::CLOCK_* RDoc
- ## Summary
`Process::CLOCK_*` has no RDoc comment.
https://docs.ruby-lang.org/en/trunk/Process.html
## Improvement
https://github.com/ruby/ruby/pull/1567 add `Process::CLOCK_*` description RDoc. -
- * process.c: Add documents on Process::CLOCK_* constants.
Patch by Sunao Komuro <sunao-komuro@cookpad.com>.
Closes [GH-1567] [Bug #13386]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58208 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
09:30 AM Bug #13101: Date#rfc2822 and Time#rfc2822 don't return the same format
- RFC 2822 says the date part should be 1 or 2 digits.
So current behavior doesn't violate the specification but I think it is more natural to adjust format.
ref. http://www.ietf.org/rfc/rfc2822.txt -
- I created a patch to solve this issue in https://github.com/ruby/ruby/pull/1566
I want committers to merge this patch if it's acceptable :) -
- Applied in changeset trunk|r58207.
----------
Fix `make clean` errors
Patch by Kohei Suzuki <eagletmt@gmail.com>.
* common.mk(clean-rubyspec): Supress error messages when rubyspec files
don't exist. [GH-1563] [Bug #13384]
* Makefil... -
09:11 AM Bug #13384 (Closed): [PATCH] Fix `make clean` errors
- https://github.com/ruby/ruby/pull/1563
- Fix error when running `make clean` just after `configure`
- Suppress error message when rubyspec files isn't present
## Before
```
% mkdir build1
% cd build1
% ../configure
% make c... -
- Patch by Kohei Suzuki <eagletmt@gmail.com>.
* common.mk(clean-rubyspec): Supress error messages when rubyspec files
don't exist. [GH-1563] [Bug #13384]
* Makefile.in: Fix error when files don't exist. [GH-1563] [Bug #13384]
git-svn-... -
- Modules/classes can be opened again.
Your patch seems returning the last location instead of the first, is it intentional?
As for the implementation, it's not nice to keep iseq.
It would be better to save them in (hidden) instance v... -
08:51 AM Feature #13383 (Rejected): [PATCH] Module#source_location
- # Abstract
It can inspect where the module or class is defined.
# Background
In debugging or development an application, I usually want to find out where the class definition of using library.
There is Method#source_location bu... -
09:17 AM Feature #13385 (Assigned): [PATCH] Make Resolv::DNS::Name validation similar to host and dig commands
- # Abstract
Add validations similar to **host** and **dig** commands to `Resolv::DNS::Name.create`
# Background
`Resolv::DNS::Name.create(str)` does not make any domain name validation.
So it returns false positive results for queri... -
- similar issue: https://bugs.ruby-lang.org/issues/9806
-
08:28 AM Bug #13003 (Closed): About not Random instance of random: keyword ardument of Array#shuffle!
- This bug is already fixed, close.
-
- Matz, is this intentional?
-
07:47 AM Bug #13315: Single "%" at the end of `printf` format string appears in the result
- I believe this is not intentional, so created a pull-request on GitHub.
https://github.com/ruby/ruby/pull/1560
This change makes ruby raise error for `printf("%")` though C just shows warning because this change will drop displayed "... -
- This is resolved version ruby-2.4.1.
-
07:33 AM Bug #11430: Redefining a lazy-loaded variable in child context within RSpec spec causes crash
- I believe this is related to an incorrect use of RSpec's `let`, and has nothing to do with Ruby. (=> **not a bug** here?)
When you write `let(:my_hash) { my_hash.merge!(key_two: 'val_two') }`, you **override** `:my_hash` in that local... -
- **I think this is not a bug.**
It looks like you are catching the `Timeout::Error` raised by `Net::HTTP.get_response`.
Here is a sample code to illustrate this:
~~~ ruby
require 'timeout'
require 'benchmark'
require 'net/http... -
- Confirmed fixed. cf #11964
-
- OK, I've read comments of #13077.
What do you think of renaming fstring to "deduped" string? "Deduped" strings are implicitly frozen.
- Rename `rb_fstring` to `rb_str_deduped`
- Rename `rb_fstring_new` to `rb_str_deduped_new`
- R... -
- I can understand use cases but we shouldn't expose the name "fstring".
-
- https://github.com/ruby/ruby/pull/1559
Currently, C extensions cannot use fstrings. I'd like to use
`rb_fstring_cstr` instead of `rb_str_new_cstr` for static strings in C
extensions to avoid excess allocation.
I think there's sev... -
- * parse.y (dot_or_colon): use the default action without type
casts.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58206 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Committed at r58205
-
- https://github.com/ruby/ruby/pull/1558
Init_frozen_strings definition is removed in r51511.
https://bugs.ruby-lang.org/issues/11423 -
- Init_frozen_strings definition is removed in r51511.
https://bugs.ruby-lang.org/issues/11423
Patch by Kohei Suzuki <eagletmt@gmail.com>
* internal.h: Remove declaration of unexist function
[Fix GH-1558]
git-svn-id: svn+ssh://ci.ruby... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58204 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- OK, although I still think it is too artificial example, nobody would mind a little change of the `OpenStruct` performance.
-
- 2.1.0p0 is outdated, try 2.1.9.
2.1 will end the life soon, though.
03/28/2017
-
- Hi,
I found out that using the standard IMAP library isn't very safe. It can be forced to hang the whole application.
the problem is here
```
s = @sock.gets(CRLF)
```
-> the server accepted the connection but it didn't send any d... -
- Thank you Chris for your report. And thank you Eric creating a patch for ruby_2_3!
I backported r58200 with Eric's patch into ruby_2_3 branch at r58203.
-
- For information, https://github.com/ruby/spec/pull/393 is adding such tests in ruby/spec
for Object, Integer, Float, String, Symbol, Array and Hash.
That's how the bug was discovered. -
- I also committed r58200 to trunk to prevent us from hitting
this, again. We should ensure other classes don't suffer this
fate, too, will check other cases later (or if other people send
patches).
/me goes back to hibernation - 05:14 PM Bug #13376 (Closed): Symbol#hash is deterministic on 2.3
- Applied in changeset trunk|r58200.
----------
test/ruby/test_symbol.rb: new test for nondeterminism
We need to ensure hashes for static symbols remain
non-deterministic to avoid DoS attacks. This is currently the
case since 2.4+, but... -
- Here is a 2.3-only patch.
-
- chris@chrisseaton.com wrote:
> Bug #13376: Symbol#hash is deterministic on 2.3
> https://bugs.ruby-lang.org/issues/13376
I think I broke this in:
commit 14470aa6dbf4d99bc8e0484e1334c2c6d5e68fc3 / r51582
("hash.c: improve intege... -
04:00 PM Bug #13376 (Closed): Symbol#hash is deterministic on 2.3
- I believe the Symbol#hash should probably be non-deterministic, due to CVE-2011-4815. That seems to be the behaviour on 2.2 and 2.4, but not on 2.3. Was this a conscious decision at the time? Or is it a bug?
~~~
$ 2.2.6/bin/ruby -e '... -
- * hash.c (any_hash): fix Symbol#hash to be nondeterministic.
The patch was provided by Eric Wong. [ruby-core:80433] [Bug #13376]
test/ruby/test_symbol.rb: new test for nondeterminism
We need to ensure hashes f... -
08:31 PM Feature #13378: Eliminate 4 of 8 syscalls when requiring file by absolute path
- Ah, I was too hasty with the rebase from my 2.3.3 branch. I've attached a fixed patch. Note also that trunk has already eliminated the double-fstat, so this only reduces the number of syscalls when a feature is specified by absolute path...
-
- Don't open file twice when specified by absolute path.
When invoking `require '/a.rb'` (i.e. via an absolute path), ruby generates this sequence of syscalls:
open /a.rb
fstat64 /a.rb
close /a.rb
open /a.r... - 07:37 PM Bug #13377 (Closed): Crash while running tests
- Mac OSX El Capitan - 10.11.6
To resolve a security issue, I had to update nokogiri from 1.6.8 to 1.7.1, which also forced me to update Ruby from 2.0 to 2.1. I ran into minor issue with Nokogiri which I fixed.
When I ran tests, It ... - 05:14 PM Revision 8234c571 (git): * 2017-03-29
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58201 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 05:14 PM Revision 149d43d4 (git): test/ruby/test_symbol.rb: new test for nondeterminism
- We need to ensure hashes for static symbols remain
non-deterministic to avoid DoS attacks. This is currently the
case since 2.4+, but was not for the 2.3 series.
* test/ruby/test_symbol.rb (test_hash_nondeterministic): new test
[rub... -
- > I'm ok to create German mailing list on ruby-lang.org.
Great! Thank you very much!
> ...
I have just sent you a list of the current moderators of the German Ruby forum with email addresses. These people should receive configurat... -
- Hello, I'm one of administrators of ruby-lang.org.
I'm ok to create German mailing list on ruby-lang.org.
Can you give the address list for initial members?
Please send it to hsbt at ruby-lang.org - 04:46 PM Revision 3220ce6b (git): * version.h: bump to 2.2.8.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_2@58199 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58198 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58197 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * lib/ostruct.rb (method_missing): raise an exception with proper
visibility message.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58195 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Created https://github.com/ruby/sdbm and https://rubygems.org/gems/sdbm.
-
09:01 AM Bug #13375: msfconsole up to date not work with ruby installer rvm version 2.3.3 2.4.0 2.4.1 correctly ruby kali rolling
- ./msfconsole /home/fakessh/.rvm/gems/ruby-2.4.1/gems/bit-struct-0.15.0/lib/bit-struct.rb:3: warning: constant ::Fixnum is deprecated
/home/fakessh/.rvm/gems/ruby-2.4.1/gems/activerecord-4.2.8/lib/active_record/connection_adapters/postgr... -
- ./msfconsole /home/fakessh/.rvm/gems/ruby-2.4.1/gems/bit-struct-0.15.0/lib/bit-struct.rb:3: warning: constant ::Fixnum is deprecated
/home/fakessh/.rvm/gems/ruby-2.4.1/gems/activerecord-4.2.8/lib/active_record/connection_adapters/postgr... -
- nobu (Nobuyoshi Nakada) wrote:
> No merit.
Beyond the reasons above, is there no merit for such a small and localized patch?
I thought that was quite valued in MRI. -
- nobu (Nobuyoshi Nakada) wrote:
> Eregon (Benoit Daloze) wrote:
> ...
No, `OpenStruct#respond_to?` does not:
```ruby
p Class.instance_method(:allocate).bind(OpenStruct).call.respond_to?(:foo) # or rb_obj_alloc() in C
```
Trunk:
... -
- Eregon (Benoit Daloze) wrote:
> But my main issue with this fix is it only addresses a specific use-case and not the general issue:
> ...
I can't get your point.
`OpenStruct#respond_to?` works as others, and `OpenStruct#respond_to_mis... -
08:31 AM Feature #13374 (Open): Fix one of performance regressions in method calling
- Seems that LIKELY() introduces some penalties at branching.
### Ruby 2.4.1
~~~
$ ruby -v ~/tmp/bench.rb
ruby 2.4.1p111 (2017-03-22 revision 58053) [x86_64-darwin16]
user system total real
1.460000 0.01... -
- ruby_2_2 r58193 merged revision(s) 58084.
- 06:40 AM Revision b2638c9f (git): merge revision(s) 58084: [Backport #13361]
- configure.in: syscall is deprecated on macOS
* configure.in: syscall is no longer supported on macOS since
10.12. [ruby-core:80300] [Bug #13361]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_2@58193 b2d... -
-
- Hello.
saul.rosales.b (Saul Rosales) wrote:
> Hello I am Ruby developer for qualcomm company we were creating a upload feature that is gathering text files for source code or configuraiton files from whatever platform they are writte... -
04:07 AM Bug #13372 (Closed): File class is not able to identify EOL for file text using CR character .
- Hello I am Ruby developer for qualcomm company we were creating a upload feature that is gathering text files for source code or configuraiton files from whatever platform they are written, as Windows, Mac OS all versions, Linux all vers...
-
- It's unable to tell that slash is a part of a regexp.
-
- I don't have any first-hand knowledge, but my guess is that a / followed by a space is always interpreted as a division operator, because that's the most likely result that can be obtained without looking ahead more than one character. I...
-
- ndn (Nikola Nenkov) wrote:
> Yes, but it was more of a question if it's a bug or not. Like should I use `%r//` when omitting parens as a principle? If yes - I would submit a PR in Rubocop and so on.
I can't say for sure from memory b... -
- vmakarov@redhat.com wrote:
> I think I've reached a state of the project to make its current
> code public. Most of the infrastructure for RTL insns and JIT has
> been implemented.
Thank you for the update! I was just rereadin... -
- I think I've reached a state of the project to make its current
code public. Most of the infrastructure for RTL insns and JIT has
been implemented.
Although I did a lot of performance experiments to choose the
current approach... -
- Hello Guys
I found trying to create a simple logic for copying, renaming and removing big directories (form 1 to 4 GB size) on Ubuntu Linux, that the FileUtils Module, it is not able to provide a good error or exception mechanism, to ... -
- * numeric.c (int_round): [DOC] improves Integer#round documentation
as well as Float#round.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58192 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 02:15 AM Revision ad5be359 (git): * 2017-03-28
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58191 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * numeric.c (flo_round): [DOC] improves Float#round documentation
to better highlight the half keyword. [Fix GH-1541]
Author: Evan Brodie <brodie.evan@gmail.com>
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58190 b2dd03c8-39...