Activity
From 12/27/2016 to 01/02/2017
01/02/2017
-
11:31 PM Feature #11547: remove top-level constant lookup
- I would honestly rather see it raise an exception instead of silently return nil. I'd rather KNOW my bug than hunt it.
-
- I've got a bug report on minitest/mock that I've reduced to the following:
~~~ ruby
class Object
def to_query # remove this, works fine
end
end
Object.prepend Module.new # remove this, works fine
module Object... -
10:21 PM Feature #13095: [PATCH] io.c (rb_f_syscall): remove deprecation notice
- kosaki.motohiro@gmail.com wrote:
> I disagree.
>
> http://man7.org/linux/man-pages/man2/syscall.2.html clearly explains a caller must care
> Architecture-specific requirements. But current this interface have no way Ruby core care
... -
01:14 PM Feature #13095: [PATCH] io.c (rb_f_syscall): remove deprecation notice
- I disagree.
http://man7.org/linux/man-pages/man2/syscall.2.html clearly explains a caller must care
Architecture-specific requirements. But current this interface have no way Ruby core care
alignment etc.
syscall is misdesigned i... -
- io.c (rb_f_syscall): remove deprecation notice
New, perhaps experimental syscalls appear all the time which
may not and never be be supported by the system C library.
Furthermore, on common GNU/Linux platforms, kernel development
... -
01:02 PM Bug #13094: Zlib::GzipReader eof?がfalseなのにgetsでnilが返ってくる
- たしかにFileとZlib::GzipReaderでeof?の挙動が違いますね。
Fileの方にあわせるべきかなぁ……。
さておき、現状こうなってしまっていますし、修正は2.5からだと思うのでgetsの戻り値で分岐した方がよいでしょうね。 -
03:35 AM Bug #13094 (Closed): Zlib::GzipReader eof?がfalseなのにgetsでnilが返ってくる
- 下記のように、eof?がfalseであればgetsでnilが返ってくることはないことを期待してるとエラーが起きてしまいます。
zlibでeof?は非推奨でしょうか？
~~~ ruby
require 'zlib'
o = ('!'..'~').to_a
i = 225
1000.times do
Zlib::GzipWriter.open('./s.gz') do |gz|
i.times do
gz.write(o.sam... -
12:20 PM Revision 6fca65e7 (git): lib/English.rb: Specify frozen_string_literal: true.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@57252 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
10:59 AM Bug #13092: Interpreter Bug
- Nobuyoshi Nakada wrote:
> How to reproduce it?
I have no idea what is causing the bug,
The rake task "channels:synchronize" for this repo is causing it, only with ruby 2.4.0, the 2.3.1 is fine!
Repo: http://github.com/marcelob... -
08:56 AM Bug #12613: iseq_set_sequence: adjust bug -1 < 0 (retry inside begin/rescue)
- This code has the same symptoms. Removing the second begin/rescue, the method, or the return statement makes the code work (reports SyntaxError, without crashing).
~~~
#!/usr/bin/env ruby
def test
begin
break
rescue
... -
01:40 AM Revision b70d3f67 (git): adjust spacing [ci skip]
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@57251 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
12:22 AM Revision 03b8cb95 (git): object.c: rb_class_alloc
- * object.c (rb_obj_alloc): add pathological check of klass for
extension libraries which do not check given arguments properly.
[ruby-core:78934] [Bug #13093]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@57250 b2dd03c8-39d4-4d8... -
12:22 AM Feature #13083: Regexp#{match,match?} with a nil argument are deprecated and will raise a TypeError in Ruby 3.0
- I think that the way it currently exists is logical. As `=~` is an Object method, it is worth while keeping the more permissible behavior whereas errors should be thrown for `match` and `match?` if `nil` is passed. The change that I woul...
-
- I think that a possible middle ground replacement would be to introduce truthy and falsy constants into `TrueClass` and `FalseClass` respectively. You could then do, for example,
~~~ ruby
case 1
when true then puts 'This will not ma... -
- Applied in changeset r57249.
----------
object.c: rb_class_s_new
* object.c (rb_class_new_instance): add pathological check of
klass for extension libraries which do not check given arguments
properly. [ruby-core:78934] [Bug #13093] -
- * object.c (rb_class_new_instance): add pathological check of
klass for extension libraries which do not check given arguments
properly. [ruby-core:78934] [Bug #13093]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@57249 b2dd03c...
01/01/2017
-
- I got a `NameError`.
```
-:1:in `<main>': undefined local variable or method `remplace_template' for main:Object (NameError)
``` -
10:36 PM Bug #13093 (Closed): JSON Parse
- When trying to parse a JSON file from the following format:
```
[
{"original":"yahoo.fr","replace":"yahoo.fr"},
{"original":"zahnen.cl","replace":"zahnen.cl"},
{"original":"zzion.cl","replace":"zzion.cl"}
]
```
using the foll... -
- How to reproduce it?
-
- The same project works with ruby 2.3.1.
http://github.com/marceloboeira/feedcast -
- You may have encountered a bug in the Ruby interpreter or extension libraries.
Bug reports are welcome.
For details: http://www.ruby-lang.org/bugreport.html -
- * dir.c (is_case_sensitive): use getattrlist() if fgetattrlist()
is unavailable, on OSX 10.5. [ruby-core:68829] [Bug #11054]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@57248 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- 修正しました。
#11054 は修正されたはずだけどなー、っと思ったら別の場所で分岐無しで使ってるんですね。
しかし、7世代以上前のmacOSを今サポートすべきだとは思わないのでそのままですかね。
なお、手元で動かす分にはfgetattrlistをgetattrlistで置き換えれば突破できるんじゃないかと思います。 -
- Applied in changeset r57246.
----------
fix typo [Bug #13091] -
01:53 PM Bug #13091 (Closed): 2.4.0がコンパイルできない
- 2.4.0のコンパイルができません。
（省略）
compiling array.c
array.c: In function ‘rb_ary_zip’:
array.c:3340: error: syntax error before ‘)’ token
（省略）
となります。（私の古い）Macで発生している現象ですが、nclude/ruby/ruby.hの以下の部分が原因と思われますので影響範囲はそれなりに広いのではないでしょうか。
diff... -
- Khalil Fazal wrote:
> puts [].join.encode("utf-8").encoding
`puts [].join.force_encoding("utf-8").encoding` is correct because of both semantic and performance.
String#force_encoding just overwrite the encoding of string instead of ... - 04:42 PM Revision c2ebf056 (git): * 2017-01-02
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@57247 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@57246 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
03:07 PM Feature #11547: remove top-level constant lookup
- In particular this one http://guides.rubyonrails.org/autoloading_and_reloading_constants.html#when-constants-aren-t-missed.
We'd love to base Rails autoloading on Kernel#autoload and have the exact same semantics, but that is not poss... -
02:58 PM Feature #11547: remove top-level constant lookup
- The fix is even simpler than what I was picturing: https://github.com/ruby/ruby/commit/44a2576f798b07139adde2d279e48fdbe71a0148
If it sticks, this will make a bunch of Rails autoload issues go away. Right on nobu, thanks! -
- Applied in changeset r57244.
----------
variable.c: top-level constant look-up
* variable.c (rb_const_search): [EXPERIMENTAL] remove top-level
constant look-up. [Feature #11547] -
- Sorry, missed this feature.
-
- Shyouhei Urabe wrote:
> So is it a dates_international.rb's problem?
Yes. But that file has other problems, among else that it only supports four additional languages (French, German, Italian, and Spanish).
> ...
Yes indeed. I sea... -
04:21 AM Bug #13036: Date.parse mishandling spanish months "Abril y Agosto"
- So is it a dates_international.rb's problem? Then sorry but the ruby's core do not ship that library. You might have obtained a copy of it from somewhere else. Do you remember where? Or, you might want to contact @jackrg directly. L...
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@57245 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * variable.c (rb_const_search): [EXPERIMENTAL] remove top-level
constant look-up. [Feature #11547]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@57244 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@57243 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
12/31/2016
- 10:44 PM Revision 5659843d (git): * 2017-01-01
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@57242 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
10:44 PM Revision 9043c073 (git): Update submaintainer of default gems.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@57241 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
04:40 PM Bug #13036: Date.parse mishandling spanish months "Abril y Agosto"
- Even if Ruby have never intended to parse dates other than English it works quite well parsing Spanish dates. I'm quite confident that it uses [dates_international.rb](https://gist.github.com/jackrg/2927162) for the magic. I base my beli...
-
04:37 PM Feature #13067: TrueClass,FalseClass to provide `===` to match truthy/falsy values.
- > 4) Increases the confusion of true vs "truthy" and false vs "falsey"
I think that the words "true" and "false" are a lot easier to understand than "truthy" and "falsy".
There should be some document that states the valid values f... -
- Applied in changeset r57240.
----------
vm.c: fix return in lambda
* vm.c (invoke_block_from_c_splattable): pass lambda-ness.
* vm_eval.c (yield_under): invoke lambda proc properly.
[ruby-core:78917] [Bug #13090] -
- * vm.c (invoke_block_from_c_splattable): pass lambda-ness.
* vm_eval.c (yield_under): invoke lambda proc properly.
[ruby-core:78917] [Bug #13090]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@57240 b2dd03c8-39d4-4d8f-98ff-823fe69... -
03:29 AM Bug #13080: [mingw regression] broken openssl extension in 2.4.0p0
- Your patch also works when using the rubyinstaller-built shared openssl 1.0.2j lib.
`make test-all` segfaults, but test segfaults and other unresolved testing failures are typical when building ruby on windows.
~~~
$ ruby --versio... -
- Proposed patch to temporarily freeze string while copying
~~~diff
io.c (io_fwrite): temporarily freeze string when writing
This avoids garbage from IO#write for [Bug #13085].
Memory usage from benchmark/bm_io_copy... - 12:41 AM Revision 31729338 (git): * 2016-12-31
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@57239 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 12:41 AM Revision ff4e14f0 (git): * properties.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@57238 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 12:41 AM Revision f01d3b23 (git): add benchmark for IO.copy_stream IO#write case
- I will attempt to reduce garbage in proposed fix
for https://bugs.ruby-lang.org/issues/13085
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@57237 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
12/30/2016
-
- Before you decide whether to commit your patch to support using static openssl libs, I'll double check that a 32bit build with the rubyinstaller-built openssl lib from https://bintray.com/oneclick/OpenKnapsack/openssl/1.0.2j#files also w...
-
- Yes, that was very surprising to find windows openssl using gdi32.dll.
I've got more testing to do, but your patch appears to work for both 1.0.2j and 1.1.0c on 2.4.0p0:
Thank you.
~~~
$ ruby --version
ruby 2.4.0p0 (2016-12-24... -
05:52 PM Bug #8289: [].join.encoding # => US-ASCII (I expect also UTF-8
- A work around for my own projects:
~~~ ruby
class Array
alias_method :old_join, :join
# A work around for https://bugs.ruby-lang.org/issues/8289
def join(separator = $,)
'' + old_join(separator)
end
end
puts ["... -
02:42 PM Bug #13090 (Closed): Cannot use return statement in lambdas using instance_eval (MRI 2.4)
- Hello,
I'm pretty sure I've found a bug after running specs for dry-initializer gem on MRI 2.4.
I managed to find the minimal code to reproduce the issue:
MRI 2.3.3
```
$ ruby -e "instance_eval(&lambda { |_| return })"
$
``... -
12:53 PM Bug #13078: with Integer a and b, a.fdiv(b) sometimes inaccurate than Rational(a, b).to_f
- pull requested
https://github.com/ruby/ruby/pull/1508 -
11:45 AM Feature #11547: remove top-level constant lookup
- With 2.4 released and I wasn't able to find anything related to this issue in https://github.com/ruby/ruby/blob/v2_4_0/NEWS I guess it did not make it into 2.4.
I was wondering if there are any plans regarding working on this. In almo... -
- Updated as Integer#pow, with such API.
-
- Applied in changeset r57236.
----------
rational.c: memory leak in gcd
* rational.c (rb_gcd_gmp): fix memory leak. patched by KISHIMOTO,
Makoto <ksmakoto AT dd.iij4u.or.jp> in [ruby-dev:49934].
[Bug #13089] -
- きしもとです
手元の環境で、最新版（r57227 の変更以降）で、以下のような
スクリプトを実行しながら、topコマンドでインタプリタのプロセスを
見ていると、リークがあるようで、SIZE, RES がじりじりと増えて
ゆきます。
```ruby
# fdiv_leak_sample
A = 0x4000_0000_0000_0000
B = 0x4000_0000_0000_0000
def f
A.fdiv B
end
... -
- * rational.c (rb_gcd_gmp): fix memory leak. patched by KISHIMOTO,
Makoto <ksmakoto AT dd.iij4u.or.jp> in [ruby-dev:49934].
[Bug #13089]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@57236 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
07:53 AM Bug #13069: mkmf: ignore linker warnings on OpenBSD - Thansk for addressing the warnings. Your proposed patch solves my problem.
12/29/2016
-
09:58 PM Bug #13069: mkmf: ignore linker warnings on OpenBSD
- I think this is a better fix. This keeps the `:werror` behavior in `Logging::postpone`, it just turns off the use of `:werror` by default. Users that want werror behavior by default can set `$werror = true`.
~~~ diff
--- lib/mkmf.r... -
- Some of the warnings were addressed in r57189, r57190, and r57191. However, I think we should rethink checking for an empty log file, and rely purely on the return code:
~~~ diff
--- lib/mkmf.rb.orig Sun Dec 25 09:49:06 2016
+++... - 04:16 PM Revision c922626a (git): * 2016-12-30
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@57235 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
04:16 PM Revision c326ab8c (git): test/ruby/test_pack.rb: fix test case added by r57187
- The test case for String#unpack added by r57187 is not properly testing
because the String will be filled after the block invocation.
[ruby-core:78841] [Bug #13075]
Thanks to nagachika for pointing this out:
http://d.hatena.ne.jp/nag... -
- Apparently my change broke it:
https://github.com/ruby/openssl/commit/5ba12a364fa5019f0e0f1e356087c001330097f1
I never thought OpenSSL would actually use gdi32.dll, but it does! RAND_screen() which used those gdi32.dll functions ... -
- Yes, Windows seems to ignore the value when it is not REG_SZ, too.
But I wonder if it is desirable to ignore such broken registry silently. -
12:27 PM Bug #13081: resolv.rb may be the cause of the rubygems bug on Windows
- How about ignoring the registry value if its type is not expected type?
```diff
Index: resolv.rb
===================================================================
--- resolv.rb (revision 57233)
+++ resolv.rb (working copy)
@@ -... -
- Matheus Mina wrote:
> It converts the first number in the string to integer. Is it correct?
Yes.
http://ruby-doc.org/core-2.4.0/String.html#method-i-to_i -
11:10 AM Bug #13088 (Rejected): Strange behavior in String.to_i
- When I try convert a string to integer using .to_i method it has a strange behavior.
It converts the first number in the string to integer. Is it correct?
I think the expected behavior should be convert to a integer if it has only ... -
-
11:05 AM Bug #13087 (Closed): Regression of instance_exec behaviour in ruby 2.4
- I've just caught up this running our test suite against the newly released ruby 2.4. Here is the repro gist:
```ruby
class A
def initialize(x)
@x = x ... -
- * rational.c (read_num, read_rat_nos): refactor to curtail
creating Rational objects.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@57233 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- You load the extension library for 2.2.1 from ruby 1.9.1.
-
05:40 AM Bug #13086: /usr/lib/ruby/1.9.1/rubygems/custom_require.rb:36: [BUG] Segmentation fault
- I am in a cloud9 instance.
I just updated nokogiri to 1.7.0.
I have attached the bug report. -
- require 'nokogiri'
at first, it worked ok, but as I reload my script, I encounter the SegFault.
could be an issue in the code behind nokogiri ?
-
- Applied in changeset r57232.
----------
rational.c: fix for mathn
* rational.c (read_num, read_rat_nos): dispatch by the type of numerator, for
mathn. [ruby-core:78893] [Bug #13084] -
12:21 AM Bug #13084: String cast to Rational on 2.4.0p0 results in SegFault with Mathn required
- Can be replicated on Linux via Docker
Below Segfaults
~~~
docker run -it ruby:slim ruby -e 'require "mathn"; p Rational("5/5");'
~~~
Below Returns Expected Result
~~~
docker run -it ruby:slim ruby -e 'p Rational("5/5");'
... -
- See the below example, while `mathn` is required recasting a string into a Rational causes a SegFault. Remove mathn and the code will not crash.
~~~ ruby
require 'mathn'
# Both result in Segfault
Rational("5/5")
"5/5".to_r
~~~... -
- * rational.c (read_num, read_rat_nos): dispatch by the type of numerator, for
mathn. [ruby-core:78893] [Bug #13084]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@57232 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 09:06 AM Revision 69938349 (git): * 2016-12-29
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@57231 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * rational.c (canonicalization): define always regardless CANON,
and remove unnecessary ifdefs.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@57230 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
08:46 AM Bug #13082: Regex match from position behavior with start of line/string special character
- Thanks, I didn't know about \G! It's a little hard to understand in this situation, do you think it might be helpful to add to the doc on matching with position?
"\G - Matches point where last match finished" -
- Offset 2 is not a beginning of a line, nor the beginning of the string.
Use `\G`. -
- Relying on rb_str_new_frozen for unconverted strings does not
save memory because copy-on-write is always triggered in
read-write I/O loops were subsequent IO#read calls will
clobber the given write buffer.
```ruby
buf = ''.b
...
12/28/2016
-
09:00 PM Bug #13043: Exception#cause can become recursive/infinite
- ruby_2_2 r57229 merged revision(s) 57137.
- 09:00 PM Revision d785c36b (git): merge revision(s) 57137: [Backport #13043]
- eval.c: fix circular cause
* eval.c (exc_setup_cause): always set cause of cause to get rid
of circular references. [ruby-core:78688] [Bug #13043]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_2@57229 b2dd03c8-... -
07:54 PM Feature #13067: TrueClass,FalseClass to provide `===` to match truthy/falsy values.
- 1. This would break a lot of code. As an example, I found 13 instances of `when true/false` in Rails' code that would break.
2. There is no good replacement for the current uses of `when true` and `when false`. In particular, `when tr... -
04:05 AM Feature #13067: TrueClass,FalseClass to provide `===` to match truthy/falsy values.
- Nobu, I think the benefit outpass the drawbacks.
Regarding your patch, I think `===` should be its own RDoc entries.
Matz.
-
06:34 PM Feature #13083 (Closed): Regexp#{match,match?} with a nil argument are deprecated and will raise a TypeError in Ruby 3.0
- Just for consistency
* patch: https://github.com/ruby/ruby/pull/1506
* spec: https://github.com/ruby/spec/pull/380
Currently behaves as ( ruby --version: ruby 2.5.0dev (2016-12-28 trunk 57228) [x86_64-darwin16] )
~~~ ruby
'str... -
- Hello,
Apologies in advance if this question was addressed already, I could not find any information on it.
Regexp#match [provides this behavior](https://ruby-doc.org/core-2.4.0/Regexp.html#method-i-match):
> If the second param... -
- s/repository/registry/
-
- Seems the registry is broken.
-
12:34 AM Bug #13081 (Closed): resolv.rb may be the cause of the rubygems bug on Windows
- See https://github.com/rubygems/rubygems/issues/1700
-
- Applied in changeset r57227.
----------
numeric.c: reduce fdiv
* numeric.c (rb_int_fdiv_double): reduce first for more precise
result. [ruby-core:78886] [Bug #13078] -
- I thought the reduction would be slower, but actually not significant.
```
$ ruby -rbenchmark -e 'a = 3; b = -0x20_0000_0000_0001; n=10_000_000; Benchmark.bm(13) {|x|x.report("Integer#fdiv"){n.times{a.fdiv(b)}}; x.report("Rational#to... -
03:00 AM Bug #13078: with Integer a and b, a.fdiv(b) sometimes inaccurate than Rational(a, b).to_f
- The accuracy of `Rational(a, b).to_f` seems to be due to reduction of fraction.
How about using `Rational` object, or its internal function `f_gcd()` and `f_idiv()`? - 04:40 AM Revision b1c68cfa (git): * 2016-12-28
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@57228 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * numeric.c (rb_int_fdiv_double): reduce first for more precise
result. [ruby-core:78886] [Bug #13078]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@57227 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- The bad news is that my custom openssl 1.0.2j library and the ones built by the rubyinstaller project (32 and 64bit) both have pkg-config info like the following. Openssl 1.1.0c (32 and 64bit) built with mingw64-6.2.0 also have the `-lgd...
-
- Ok. I'll play with my openssl build script https://github.com/jonforums/buildlets/blob/master/build_openssl.ps1#L62 to see if I make it work.
Strange that the same openssl 1.0.2j library works fine with 2.3.3 but not 2.4.0. -
- From https://bugs.ruby-lang.org/attachments/6316/bad_mkmf_2.4.log#L229, your ssl library has references to GDI32.dll. I'm not sure why rand_win.c needs it though.
Probably you need `--with-openssl-config` option for a proper pkg-config ... -
- nobu@ruby-lang.org wrote:
> Why not `String#-@`?
As in the following? (short patch, full below)
~~~diff
--- a/string.c
+++ b/string.c
@@ -10002,7 +9989,7 @@ Init_String(void)
rb_define_method(rb_cString, "scrub!", str_sc... -
- Why not `String#-@`?
12/27/2016
-
- eregontp@gmail.com wrote:
> So this is essentially like Java's String.intern()?
>
> There is already String#intern in Ruby but it returns a Symbol.
> Depending on the use-case, I guess this might be less convenient than getting a d... -
10:15 PM Feature #13077: [PATCH] introduce String#fstring method
- So this is essentially like Java's String.intern()?
There is already String#intern in Ruby but it returns a Symbol.
Depending on the use-case, I guess this might be less convenient than getting a de-duplicated String.
String#dedup o... -
- shevegen@gmail.com wrote:
> The only comment I have is that the name .fstring() is a bit strange. On first read, I
> assumed that it was short for "format_string" like % on class String or sprintf.
Yeah, the name isn't final, of c... -
- I have no particular pro or con opinion on the proposal in itself so feel free to ignore this.
The only comment I have is that the name .fstring() is a bit strange. On first read, I
assumed that it was short for "format_string" like... -
- introduce String#fstring method
This exposes the rb_fstring internal function to return a
deduped and frozen string. This is useful for writing all sorts
of record processing key values maybe stored, but certain keys
and values ar... -
- When building using slightly modified rubyinstaller build recipes and a msys2/mingw64-6.2.0 (32bit) toolchain, the build fails to create the openssl extension when using openssl 1.0.2j or 1.1.0c.
~~~
$ ruby --version
ruby 2.4.0p0 (2... -
- Piotr Szmielew wrote:
> In this particular example even manually rehashing internal hash doesn't quite work...
Right, looks like hash lookup (internally `st_lookup`) doesn't work with recursive values :-(
> ...
Comparing hashes is... -
08:34 AM Bug #12970: == Equality of recursive sets fails
- In this particular example even manually rehashing internal hash doesn't quite work...
~~~ ruby
s = Set.new
t = Set.new
s << [s]
t << [t]
s == t # => false
s.instance_variable_get(:@hash).rehash
t.instance_variable_get(:@hash).... -
- That's not going to cut it... There are many other counter examples....
```
s = Set.new
t = Set.new
s << [s]
t << [t]
s == t # => false
```
or similarly:
```
s = Set.new
t = Set.new
a = Set.new([s])
b = Set.new([t])
s... -
- \o/
-
- ... but reverted in `ruby_2_2` because it causes SEGV.
-
- ruby_2_2 r57222 merged revision(s) 57137.
- 02:59 PM Revision 543a8b5e (git): revert r57222 because of SEGV
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_2@57226 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- ruby_2_2 r57225 merged revision(s) 57172.
- 11:44 AM Revision 7015fcf9 (git): merge revision(s) 57172: [Backport #13066]
- time.c: fix type of usec2subsecx
* time.c (usec2subsecx): fix return type, which is a numeric
object but not a long int. [ruby-dev:49912] [Bug #13066]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_2@57225 b2dd0... -
- Applied in changeset r57224.
----------
io.c: fix race between read and close
* io.c (io_fillbuf): fix race between read and close and bail out
in the case the IO gets closed before the reading thread achieve
the lock. [ruby-core:... -
- After r57199, `IO#getch` (in `io/console`) was broken, at least on Windows.
It required two key types to get the result.
So, I reverted r57199.
Nobu, please check again. -
- * io.c (io_fillbuf): fix race between read and close and bail out
in the case the IO gets closed before the reading thread achieve
the lock. [ruby-core:78845] [Bug #13076]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@57224 b2d... -
- ruby_2_2 r57223 merged revision(s) 56884,56892.
- 11:43 AM Revision 244096b9 (git): merge revision(s) 56884,56892: [Backport #12910]
- test_fileutils.rb: Use primary group too
* test/fileutils/test_fileutils.rb (TestFileUtils#setup): Use
primary group as well as supplementary groups. based on the
patch by Vit Ondruch at [ruby-core:78053]. [Bug #12910]
... - 11:39 AM Revision 9d693b18 (git): merge revision(s) 57137: [Backport #13043]
- eval.c: fix circular cause
* eval.c (exc_setup_cause): always set cause of cause to get rid
of circular references. [ruby-core:78688] [Bug #13043]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_2@57222 b2dd03c8-... -
- Is this problem really present in ruby 2.2 ?
I've never backported `default_exclude_exts` feature. -
- ruby_2_2 r57221 merged revision(s) 57123.
- 11:14 AM Revision f82b0a39 (git): merge revision(s) 57123: [Backport #13054]
- re.c: consider the case of RMatch::regexp is nil
Follow r49675, r57098 and r57110. Don't assume RMatch::regexp always
contains a valid Regexp instance; it will be Qnil if the MatchData is
created by rb_backref_se... -
- ruby_2_2 r57220 merged revision(s) 57119.
- 11:03 AM Revision 33b36456 (git): merge revision(s) 57119: [Backport #13052]
- array.c: check array length every time after yielding
Since the Array may be modified during rb_yield(), the length before
invoking the block can't be trusted. Fix possible out-of-bounds read in
Array#combination... -
- ruby_2_2 r57219 merged revision(s) 57108.
- 10:58 AM Revision 1bd82de9 (git): merge revision(s) 57108: [Backport #13049]
- sprintf.c: fix width underflow
* sprintf.c (rb_str_format): fix memory corruption by width
underflow. https://github.com/mruby/mruby/issues/3347
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_2@57219 b2dd03c8-39... -
- ruby_2_2 r57218 merged revision(s) 57098.
- 10:55 AM Revision ea83d7fd (git): merge revision(s) 57098: [Backport #13042]
- re.c: non-regexp name reference
* re.c (rb_reg_regsub): other than regexp has no name references.
[ruby-core:78686] [Bug #13042]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_2@57218 b2dd03c8-39d4-4d8f-98ff-823f... -
- ruby_2_2 r57217 merged revision(s) 57078.
- 10:52 AM Revision 74556505 (git): merge revision(s) 57078: [Backport #13034]
- encoding.c: handle needmore error from rb_enc_precise_mbclen()
rb_enc_ascget() erroneously reports success even if the given byte
sequence is incomplete, for non-ASCII compatible encoding strings.
rb_enc_precise... -
- ruby_2_2 r57216 merged revision(s) 57020,57021.
- 10:49 AM Revision 04d79490 (git): merge revision(s) 57020,57021: [Backport #13014]
- Add clang volatile fixes from FreeBSD and NetBSD.
Use volatile instead of optnone to avoid optimization which causes
segmentation faults.
Patch by Dimitry Andric. [ruby-core:78531] [Bug #13014]
git-svn-id: svn+... -
- ruby_2_2 r57215 merged revision(s) 56980,56981.
- 10:41 AM Revision ed8c211a (git): merge revision(s) 56980,56981: [Backport #13004]
- extension.rdoc: fix rb_get_kwargs [ci skip]
* doc/extension.rdoc: [DOC] optional keyword arguments are
defaulted to Qundef. ignored keys are kept in the hash but a
new Hash is not created. [ruby-dev:49893] [Bug #13004]
gi... -
- ruby_2_2 r57214 merged revision(s) 56938.
- 10:35 AM Revision 3aed194a (git): merge revision(s) 56938: [Backport #12988]
- Stop reading past the end of `ivptr` array
If you have code like this:
```ruby
class A
def initialize
@a = nil
@b = nil
@c = nil
@d = nil
@e = nil
end
end
x = A.new
... -
- ruby_2_2 r57213 merged revision(s) 56928.
- 10:32 AM Revision 244885b6 (git): merge revision(s) 56928: [Backport #12991]
- thread.c: fix doc of abort_on_exception [ci skip]
* thread.c (rb_thread_s_abort_exc, rb_thread_s_abort_exc_set):
[DOC] the raised exception will be re-raised in the main thread,
and then follows the ordinary exception sequen... -
- ruby_2_2 r57212 merged revision(s) 56905.
- 10:30 AM Revision e44b8733 (git): merge revision(s) 56905: [Backport #12983]
- Reverse compatibility_version and current_version for Darwin
The `compatibility_version` should have an API version and the
`current_version` should have a program version of Ruby, but they have
been reversed and... -
- ruby_2_2 r57211 merged revision(s) 56894.
- 10:11 AM Revision 88c68a89 (git): merge revision(s) 56894: [Backport #12974]
- marshal.c: fix infinite recursion
* marshal.c (check_userdump_arg): marshal_dump should not return
an instance of the same class, otherwise it causes infinite
recursion. [ruby-core:78289] [Bug #12974]
git-svn-id: svn+ssh:/... -
09:55 AM Bug #13079 (Closed): linked list corruption (probable race condition)
- Hi, I am developing a binding for an external library and I encountered a problem with the ruby interpreter.
The library is made to run with threads and it randomly crashes the ruby interpreter which looks like a race codition with so... -
- ruby_2_2 r57210 merged revision(s) 56469.
- 09:34 AM Revision a078bbcc (git): merge revision(s) 56469: [Backport #12860]
- * compile.c (setup_args): duplicate splatting array if more
arguments present to obey left-to-right execution order.
[ruby-core:77701] [Bug# 12860]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_2@57210... - 09:32 AM Revision 16d03ff2 (git): * ChangeLog: for r57207 and r57208.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_2@57209 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- ruby_2_2 r57208 merged revision(s) 56832.
- 09:28 AM Revision 2706ffc7 (git): merge revision(s) 56832: [Backport #12956]
- dln.c: raise LoadError
* dln.c (dln_load): raise LoadError instead of fatal error on
recent OSX, dlclose seems fixed in El Capitan or later.
[ruby-core:78200] [Bug #12956]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branche... -
- ruby_2_2 r57207 merged revision(s) 56224.
- 09:17 AM Revision 0dddf3cb (git): merge revision(s) 56224: [Backport #12785]
- * test/misc/test_ruby_mode.rb (assert_indent): since write-region
in Emacs 25.1 no longer displays the "Wrote file" message, shows
the explicit message to check if successfully finished.
[ruby-core:77355] [B... - 09:07 AM Revision f2502cec (git): revert a part of r57199
- * io.c (io_fillbuf): revert a part of r57199 because it broke IO#getch.
see also [Bug #13076]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@57206 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 08:52 AM Revision 97e18cd8 (git): cont.c: change fiber stack size doc [ci skip]
- It's many years since we had tiny 4KB fiber stacks :<
point to the manpage instead for current, larger sizes.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@57205 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@57204 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * io.c (argf_next_argv): fix leak of fd after breaking in #each
method.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@57203 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * thread.c (rb_thread_fd_close): wait until all threads using the
fd finish the operation, not to free the buffer in use.
[ruby-core:78845] [Bug #13076]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@57202 b2dd03c8-39d4-4d8f-98ff... -
- For example,
~~~
a = 3
b = 0x20_0000_0000_0001
p a.fdiv(b)
p Rational(a, b).to_f
#=>
3.3306690738754696e-16
3.330669073875469e-16
~~~
I'm hacking to solve this problem, see diff view.
https://github.com/ruby/ruby/compare/t... -
- It's 4, I guess.
-
12:51 AM Bug #13064: Inconsistent behavior with `next` inside `begin`/`end` across different implementations.
- Yukihiro Matsumoto wrote:
> It's a REPL implementation dependent (irb uses eval() inside). Try comparing them using file execution.
I did, the samples I posted contain both script execution (`ruby -e`) and IRb interactive sessions. T... -
- Shyouhei Urabe wrote:
> Yes it is. Closing.
Second try. -
- Yes it is. Closing.
- 01:40 AM Revision 20659e00 (git): * 2016-12-27
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@57201 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@57200 b2dd03c8-39d4-4d8f-98ff-823fe69b080e