Activity
From 08/05/2016 to 08/11/2016
08/11/2016
-
07:26 PM Bug #12401: compile fails --with-static-linked-ext
- ruby_2_3 r55871 merged revision(s) 55434.
-
- * common.mk (build-ext), ext/extmk.rb: use variable EXTENCS
different than ENCOBJS, to get rid of circular dependency.
build libencs when linking encodings statically.
[ruby-core:75618] [Bug #12401]
git-sv... -
- ruby_2_3 r55870 merged revision(s) 55090,55091.
-
- io.c: conditionally used functions
* io.c (pipe_atexit): only used on Windows
* io.c (rb_execarg_fixup_v): wrapper only used fork or spawnv is
available.
* process.c (rb_execarg_commandline): build command lin... -
- ruby_2_3 r55869 merged revision(s) 54142,55500.
-
- assertions.rb: fix result of assert_nothing_raised
* test/lib/test/unit/assertions.rb (assert_nothing_raised): do not
discard the result of the given block.
* vm_method.c (vm_respond_to): try method_missing if respond_... -
- ruby_2_3 r55868 merged revision(s) 55705.
-
- * variable.c (rb_local_constants_i): exclude private constants
when excluding inherited constants too. [Bug #12345]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_3@55868 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- ruby_2_3 r55867 merged revision(s) 55008.
-
- * lib/drb/timeridconv.rb: don't use keeper thread. [Bug #12342]
* test/drb/ut_timerholder.rb: ditto.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_3@55867 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- ruby_2_3 r55866 merged revision(s) 55100.
-
- * ext/openssl/ossl_ssl.c (ossl_ssl_stop): Don't free the SSL struct
here. Since some methods such as SSLSocket#connect releases GVL,
there is a chance of use after free if we free the SSL from another
thread... - 03:00 PM Revision 6a7e766f (git): * 2016-08-12
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@55865 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
03:00 PM Revision afd800fd (git): fix a typo [ci skip]
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@55864 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
02:36 PM Bug #11846: Block passed by &block is GC-ed
- I guess this is a same problem with #11750 suggested by `git bisect`.
If so, it is since r51243 and fixed at r53144.
According to git informatin of Github,
r51243 == https://github.com/ruby/ruby/commit/a82ce7c55626086ad264a0d26de63b... -
12:30 PM Bug #12670 (Closed): Segmentation fault on `Magick::Image#get_pixels` on ruby since ruby-2.2
- 1. Create test.rb this code
~~~ ruby
require 'rmagick'
include Magick
(0..10).each do |_|
ImageList.new('1.bmp').get_pixels(0, 0, 1600, 800).each_slice(1600).to_a
end
~~~
2. Create any 1.bmp file with dimension at least 160... -
09:32 AM Bug #12669 (Closed): syntax error at assinments of command
- Related to #12402, I found other kind inconsistencies.
simple assignment and op assign of `command` cause syntax error,
while simple assignments don't.
```
$ ruby -ce 'a = b = raise "x"'
Syntax OK
```
```
$ ruby -ce 'a = b +=... -
- Applied in changeset r55863.
----------
Comparable#clamp
* compar.c (cmp_clamp): Introduce Comparable#clamp. [Feature #10594] -
- * compar.c (cmp_clamp): Introduce Comparable#clamp. [Feature #10594]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@55863 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
07:23 AM Feature #12593 (Rejected): Allow compound assignements to work when destructuring arrays
- I am not going to make multiple assignments even more complex.
The behavior of OP_ASGN for multiple assignments is not obvious.
Matz.
-
- * compar.c (rb_cmp): call comparison method by predefiend ID.
* compar.c (cmpint): returns compared result.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@55862 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- https://github.com/ruby/ruby/compare/trunk...nobu:feature/12655
-
05:18 AM Bug #12668 (Closed): Please backport r53433
- I quite often encounter error:
```
1) Failure:
TC_OpenStruct#test_accessor_defines_method [/builddir/build/BUILD/ruby-2.3.1/test/ostruct/test_ostruct.rb:173]:
<[:foo, :foo=]> expected but was
<[:foo=, :foo]>.
```
which was i... -
- * parse.y (stmt, command_asgn): unifiy parser and ripper code by
node_assign macro.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@55861 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * parse.y (backref_assign_error): unify parser and ripper code.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@55860 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * parse.y (const_decl): unify parser and ripper code.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@55859 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
01:39 AM Feature #4897: Define Math::TAU and BigMath.TAU. The "true" circle constant, Tau=2*Pi. See http://tauday.com/
- This may be of interest: Guido van Rossum recently reopened the Python version of this request and is going to add tau to Python. See https://bugs.python.org/issue12345 .
-
- * parse.y (const_path_field, top_const_field): unify parser and
ripper code.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@55858 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
08/10/2016
-
11:33 PM Bug #12667 (Closed): full_gem_path is incorrect for core modules
- `#find_full_gem_path` [assumes all gems are in `gems_dir`](https://github.com/ruby/ruby/blob/trunk/lib/rubygems/basic_specification.rb#L105). It also leverages `full_name`, which [assumes the directory includes the version](https://githu...
-
08:36 PM Feature #12512: Import Hash#transform_values and its destructive version from ActiveSupport
- Yukihiro Matsumoto wrote:
> Benoit,
> ...
Dear Matz,
Thank you for the quick reply!
I think #map_values is intuitive and consistent with other methods as well as the general terminology used in Hash.
It seems almost everyone agree... -
04:43 PM Feature #12512: Import Hash#transform_values and its destructive version from ActiveSupport
- `map_values` is good, succinct and clear. 'v' is an unclear abbreviation, made worse by the existence of other methods with the long form like `values_at`.
I guess I'm just repeating what Jan and Rodrigo said...
-
- Benoit,
The name and behavior haven't fixed yet. So we welcome discussion.
Your statement about "Ruby-like" is pretty interesting. Even though I have been designing Ruby for last 20+ years, I am not sure if I could define "Ruby-lik... -
11:53 AM Feature #12512: Import Hash#transform_values and its destructive version from ActiveSupport
- Yes, I would say the same a few days ago about map_v being a bad name... I also prefer map_values. I just didn't say anything because I prefer a map_v over not having such a method at all and didn't want to delay this feature :P
-
- Yukihiro Matsumoto wrote:
> `#map_v` accepted.
> ...
Will all due respect,
I think the name #map_v is not very Ruby-like.
Why such a short name?
#map_values seems more consistent with existing methods (#values, #values_at, #each_v... -
07:54 PM Bug #12662: rb_hash_fetch() Segmentation fault on an empty hash table
- I am confused. My C (please note C) program core dumps and libruby gives me an indication I found an error in Ruby an please report and I have to protect?
I am writing a pure C application (C not Ruby) using libruby to benchmark the R... -
- Ok. Let's not go more complicated than this though.
Thanks - 06:17 PM Revision 2bd6264c (git): * 2016-08-11
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@55857 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 06:17 PM Revision 2401c512 (git): * lib/prime.rb: Optimize prime?
- Adapted from patch by Jabari Zakiya [#12665]
* test/test_prime.rb: Improve test
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@55856 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- ruby_2_3 r55855 merged revision(s) 55380.
-
- * ext/json/lib/*.rb: Removed some comments. Because these are unnecessary
class description. [ci skip][Bug #12255][ruby-core:74835]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_3@55855 b2dd03c8-39d4-4d8f-98ff-8... -
- During build of Ruby for Fedora on PPC64, there is reported following error:
```
Fiddle::TestImport#test_io = Fatal error: glibc detected an invalid stdio handle
uncommon.mk:612: recipe for target 'yes-test-almost' failed
make: ***... -
- ruby_2_3 r55854 merged revision(s) 55573.
-
- * pack.c (pack_pack): use union instead of bare variable to ease
optimizations and avoid assigning x87 floating point number.
[ruby-core:74496] [Bug #12209]
* pack.c (pack_unpack): ditto.
git-svn-id: svn+ss... -
- * parse.y (command_rhs, arg_rhs): introduce new rules to reduce
repeated rules with rescue modifier.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@55853 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Thanks!
-
02:57 AM Feature #8643: Add Binding.from_hash
- Ticket links changed.
-
- Sorry, it's a commit miss.
-
- Applied in changeset r55852.
----------
win32/resolv: fix for cygwin
* ext/win32/resolv/resolv.c: needs windows.h for iphlpapi.h on
cygwin. [ruby-core:76791] [Bug #12663]
* ext/win32/resolv/resolv.c (w32error_make_error): use
Win... -
- These files are for `ext/win32`, not for `ext/win32/resolv`.
Could you remove `ext/win32/resolv/Makefile` and then retry? -
09:52 AM Bug #12663 (Open): Compilation error on cygwin
- I'm sorry, but r55849 did not fix this at all. I still get exactly the same error messages. I'm attaching various files that have been created in ext/win32/resolv.
-
- Applied in changeset r55849.
----------
win32/resolv: fix for cygwin
* ext/win32/resolv/resolv.c: needs windows.h for iphlpapi.h on
cygwin. [ruby-core:76791] [Bug #12663]
* ext/win32/resolv/resolv.c (w32error_make_error): use
Win3... -
- * ext/win32/resolv/resolv.c: needs windows.h for iphlpapi.h on
cygwin. [ruby-core:76791] [Bug #12663]
* ext/win32/resolv/resolv.c (w32error_make_error): use
Win32::Resolv::Error, an alias of Win32::Registry::Error.
git-svn-id: svn... -
- Applied in changeset r55851.
----------
parse.y: rescue modifier in rhs
* parse.y (command_asgn): rescue modifier in command assignment
should be limited to rhs only. [ruby-core:75621] [Bug #12402] -
- * parse.y (command_asgn): rescue modifier in command assignment
should be limited to rhs only. [ruby-core:75621] [Bug #12402]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@55851 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 06:35 AM Revision 89ab385b (git): * 2016-08-10
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@55850 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * ext/win32/resolv/resolv.c: needs windows.h for iphlpapi.h on
cygwin. [ruby-core:76791] [Bug #12663]
* ext/win32/resolv/resolv.c (w32error_make_error): use
Win32::Resolv::Error, an alias of Win32::Registry::Error.
git-svn-id: svn+... -
- We briefly looked at this issue at yesterday's developer meeting and roughly agreed that locksee should be able to be done in pure-ruby.
Sad news is we had no time to have a deeper look at it so what is actually needed was not made cl... -
- See also #12624, Matz do not want assertion by class.
-
- I heard from Koichi that he has an opinion on this. Please respond.
-
- I listed this issue to be looked at the yesterday's developer meeting but sadly no time was there to deeply inspect it. At a glance it seems possible now to reflect inclusion happened afterwards. It has a chance.
-
- We looked at this issue at yesterday's developer meeting. I wonder if this is actually useful. The Tom&Jerry example is too simplistic and we at the meeting could not imagine what "a list of hash-kept remote URLs" that the OP says woul...
-
- We looked at this issue at yesterday's developer meeting. We agreed this feature is good, but sadly no active mentor was there for Net::HTTP.
Maybe could someone propose us a patch to implement this? -
- We looked at this issue at yesterday's developer meeting. While myself was positive to this, Matz is not. He thinks that shadowing by itself is a bad habit and should be discouraged. You need to show him a good advantage of encouragin...
-
-
- We looked at this issue at yesterday's developer meeting. Developers could not locate the bug at sight because test-all log lacks C-level backtrace (was this due to hppa's architecture or just a stripped binary?).
Ruby definitely nee... -
- We looked at this issue at yesterday's developer meeting. No problem to introduce this feature was reported, except it is not implemented yet. Nobu tried this before and had technical difficulty; not sure if that could be rerouted. We...
-
- We looked at this issue at yesterday's developer meeting. This feature was once implemented, and then removed due to test failures.
The current situation is, it still renders lots of warnings when deprecation turned on. This string ...
08/09/2016
-
08:09 PM Feature #12665: Faster prime? method for prime.rb std lib
- The current version of the method `prime?` in the `prime.rb`
std lib replaced the older version starting with 2.3.0.
It uses an implementation of the P3 Strictly Prime, Prime Generator (SP PG).
It can be simplified as shown below.
... -
- The current version of the method `prime?` in the `prime.rb`
std lib replaced the older version starting with 2.3.0.
It uses an implementation of the P3 Strictly Prime, Prime Generator (SP PG).
It can be simplified as shown below.
... -
07:05 PM Feature #12512: Import Hash#transform_values and its destructive version from ActiveSupport
- Yukihiro Matsumoto wrote:
> `#map_v` accepted.
At first I thought it was an "adapted form" of Hash#map like Enumerable#grep_v is an "inverted" Enumerable#grep. Maybe the "_v" could be confusing for other people?
Why not Hash#map_v... -
08:54 AM Feature #12512 (Closed): Import Hash#transform_values and its destructive version from ActiveSupport
- Applied in changeset r55847.
----------
hash.c: implement Hash#map_v and Hash#map_v!
* hash.c (rb_hash_map_v, rb_hash_map_v_bang): impelement Hash#map_v and
Hash#map_v! [Feature #12512] [ruby-core:76095]
* test/ruby/test_hash.rb: ad... -
-
- `#map_v` accepted.
Matz.
-
- I don't persist with the name `transform_value`.
`map_v` or `map_values` are also acceptable for me. -
06:23 PM Feature #12664 (Closed): Multiline pretty-printing of multiline strings
- With following addition
~~~ ruby
class String
def pretty_print(q)
lines = self.lines
if lines.size > 1
q.group(0, '', '') do
q.seplist(lines, lambda { q.text ' +'; q.breakable }) do |v|
q.pp v
... -
05:42 PM Feature #8895: Destructuring Assignment for Hash
- the closest you can get to hash destructuring is via block params:
~~~ ruby
{a: 1, b: 2}.tap do |a:, b:|
end
~~~
but unfortunately this has its own issues (#11048), it's too strict about missing/extra keys, which doesn't make sens... -
04:41 PM Feature #12299: Add Warning module for customized warning handling
- I've added a gem for lib/warning.rb (https://rubygems.org/gems/warning).
-
- Here is a patch that uses Warning instead of Exception::Warning, and only includes the error.c change (and a test for Warning.warn). I'll work on a gem shortly for lib/warning.rb.
-
- I accept the mechanism.
I prefer `Warning` to `Exception::Warning`.
Besides that, the basic should be included in the core (i.e. the patch to error.c), but its customization (i.e. lib/warning.rb) should be a Gem at first.
Matz.
-
- Probably you want an isolated loading system like Java's or Python's. That's fine. It must be a good idea.
But I don't think it can be accomplished by modifying existing `require` or adding anything to it.
You have to design the new on... -
- It's your bug.
`rb_hash_fetch()` raises an exception if the key is not found, and you must catch it by `rb_protect()`. -
- I am writing HTM (Hash Table Machine - a C benchmark program for hash table) and libruby aborts with
ruby: [BUG] Segmentation fault at 0x00000000000018
ruby 2.3.1p112 (2016-04-26) [x86_64-linux-gnu]
while attempting to get an entr... -
- It should be named `exist?` to be consistent with other methods in the standard libraries.
Besides that, I don't see a proper use-case for this method. Even when you have pid, the process you are trying to watch may have already termina... -
- Having both `ceil` (backed by UNIX tradition) and `ceiling` (better for English natives? dunno) only introduces confusion. Is there any other buying point for `ceiling`?
Matz.
-
- The explicit use of `===` for type checking is against duck typing principle.
I don't accept syntax enhancement proposal to encourage something against duck typing in Ruby.
Matz.
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@55848 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- I get the errors below when compiling on cygwin. The problem may already be two or three days old; I'm sorry I overlooked it.
```
make[2]: Entering directory '/cygdrive/c/Data/ruby/ext/win32/resolv'
compiling resolv.c
In file inclu... - 08:54 AM Revision ea5184b9 (git): hash.c: implement Hash#map_v and Hash#map_v!
- * hash.c (rb_hash_map_v, rb_hash_map_v_bang): impelement Hash#map_v and
Hash#map_v! [Feature #12512] [ruby-core:76095]
* test/ruby/test_hash.rb: add tests for above change.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@55847 b2dd... -
- I don't think proposed `guard` syntax is more readable than `unless`.
Even if some may agree with you, I doubt it's worth adding a new keyword and introducing possible incompatibility.
Matz.
-
- Ruby is not Scheme.
The rule is simple: every bang method should have its non-bang version, which does not modify the receiver.
That does not mean every non-bang method keeps its receiver unchanged.
Matz.
-
-
- It should be consistent. Will be fixed.
Matz.
-
- Instead, I propose `pow(a)` and `pow(a,b)` where the latter works as `mod_pow()` here.
Matz.
-
- I am not sure what we gain comparing to
```ruby
def controller **context
if context.key?(:name)
...
end
end
```
Is this worth adding new syntax? If you think you can persuade me, please reopen.
Matz.
-
07:52 AM Revision cb18d4ba (git): * vm_insnhelper.c (vm_getivar): use always_inline because
- gcc7 doesn't inline this without always_inline.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@55846 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- This is kind of autoload that sometimes cause problems.
I think it can cause issues than solving problem.
If you have a concrete use-case of this feature, please reopen.
Matz.
-
- * test/ruby/test_objectspace.rb (test_finalizer_with_super):
adjust number of arguments to get rid of errors in a finalizer.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@55845 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Accepted.
Matz.
-
-
- I consider this is a bug. They should be consistent.
But I am not sure we can fix the issue soon. When in doubt, put parens.
Matz.
-
- Applied in changeset r55844.
----------
* ext/tk: Tk is removed from stdlib. [Feature #8539]
https://github.com/ruby/tk is the new upstream. -
- https://github.com/ruby/tk is the new upstream.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@55844 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- This idea sounds nice, but we have to keep compatibility.
Matz.
-
- I think we are talking about two things at once.
First, adding reverse (or descending) option to `sort_by`.
I think it may be useful for some cases, but it's only slightly better than `sort_by().reverse`.
Second, adding secondary ... -
- I don't think the idea itself is meaningless.
But its use-case is not clear to us yet.
(For the record, Singleton module is totally different story.)
If you have any real-world use-case, please reopen the issue.
Matz.
-
- I accept the idea of `#clamp` as `Comparable#clamp(min, max)`.
It would not accept ranges (for now).
Matz.
-
- * ext/tk/tcltklib.c (ip_init): get rid of repeated checks and
conversions in StringValueCStr.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@55843 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * ext/tk/tcltklib.c (set_max_block_time, tcl_protect_core,
ip_init, ip_create_slave_core, get_obj_from_str,
ip_cancel_eval_core, lib_set_system_encoding,
alloc_invoke_arguments, lib_merge_tklist): use StringValueCStr
instead of S... -
- * ext/tk/tcltklib.c (set_max_block_time): use PRIsVALUE to get rid
of dangling pointer.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@55841 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * ext/tk/tcltklib.c (set_max_block_time): fix missing break.
TclTkLib.set_max_block_time(1) works but
TclTkLib.set_max_block_time(1.0) didn't.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@55840 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * ext/tk/lib/tcltk.rb (TclTkWidget#initialize): suppress an
"assigned but unused variable" warning.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@55839 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * ext/tk/sample/tcltklib/sample2.rb (Othello::BoardView::Square):
use attr_accessor instead of attr with optional boolean
argument.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@55838 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * ext/tk/lib/tk/texttag.rb, ext/tk/sample/tcltklib/sample2.rb,
ext/tk/sample/tkline.rb, ext/tk/sample/tktimer.rb: use true and
false instead of TRUE and FALSE.
* ext/win32ole/sample/ienavi.rb (stop_msg_loop): ditto.
git-svn-id: svn...
08/08/2016
-
03:59 PM Feature #9704: Refinements as files instead of modules
- It would be interesting to be able apply a refinement to a whole app (without its gems) or inside a single gem without propagating to the rest of the app which loaded it.
Although I'm not really sure about the syntax or API to do it. - 03:16 PM Revision dfc9cb40 (git): * 2016-08-09
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@55836 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@55835 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
12:04 PM Revision 44997130 (git): * ext/win32ole/sample/excel1.rb, ext/win32ole/sample/excel2.rb,
- ext/win32ole/sample/excel3.rb, ext/win32ole/sample/ie.rb,
ext/win32ole/sample/ienavi.rb, ext/win32ole/sample/ienavi2.rb: use
true instead of deprecated TRUE. [ci skip]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@55834 b2dd03... -
07:50 AM Bug #12421: Please backport r53816, r53817
- Tomoyuki Chikanaga wrote:
> usa san how do you judge this?
I agreed with you. -
- In my opinion r53816 might be considered as spec fix but r53817 was feature change, even though there's no entry in NEWS file.
usa san how do you judge this? -
- Similar to #11928 ?
Could you try with 2.3.1 or trunk? -
- * internal.h (RBASIC_CLEAR_CLASS): fix compile error and size to
fill.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@55833 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * test/lib/test/unit.rb (Test::Unit::Parallel::Worker.launch):
disable verbose flag in worker processes, get rid of unexpected
output within marshaled results.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@55832 b2dd03c8-39d4-4d... -
- Applied in changeset r55831.
----------
* internal.h (RBASIC_CLEAR_CLASS): Reroute ANSI C's strict
aliasing rule.
[ruby-core:74427][Bug #12191][ruby-core:76747][Bug #12657] -
- `RBASIC_CLEAR_CLASS` doesn't use `RBASIC_CLEAR_CLASS_RAW`, and the former only is used with r-values.
Sorry for the noise. -
- Nobuyoshi Nakada wrote:
> Does this patch really compile?
Yes, at least to me. -
- Does this patch really compile?
`cls` in `RBASIC_CLEAR_CLASS` sometimes isn't an l-value, and should not be able to be the operand of unary '&'. -
01:46 AM Bug #12657: [PATCH] ANSI aliasing fix for XL compiler
- Shyouhei Urabe wrote:
> Thank you. I think we don't need the #else part because the memset/memcpy should just work for all ANSI-compliant compilers. Is it OK for me to merge your patch like that way?
Yes, that should work. -
- Thank you. I think we don't need the #else part because the memset/memcpy should just work for all ANSI-compliant compilers. Is it OK for me to merge your patch like that way?
-
- Applied in changeset r55831.
----------
* internal.h (RBASIC_CLEAR_CLASS): Reroute ANSI C's strict
aliasing rule.
[ruby-core:74427][Bug #12191][ruby-core:76747][Bug #12657] -
- aliasing rule.
[ruby-core:74427][Bug #12191][ruby-core:76747][Bug #12657]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@55831 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
03:39 AM Feature #9612 (Assigned): Gemify OpenSSL
-
- Rubygems に gem として push できるよう、リクエストをだしました
https://github.com/rubygems/rubygems.org/pull/1378 -
- Is there reason this is not loved? I'd like to have this.
08/07/2016
-
08:49 PM Feature #9999: Type Annotations (Static Type Checking)
- Might be worth looking at [RDL](https://github.com/plum-umd/rdl) for some inspiration.
-
05:18 PM Feature #12655: Accessing the method visibility
- Hi,
I'm the original author of looksee.
I agree that we don't need everything in the Looksee extension in ruby. Looksee was written back in 2009 when I think the situation was a little different, but now I believe Module#ancestors ... - 04:33 PM Revision 0c5fb7df (git): * 2016-08-08
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@55830 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@55829 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * basictest/runner.rb, bootstraptest/runner.rb: disable warnings.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@55828 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * tool/vcs.rb (VCS#modified): get rid of set but unused variables.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@55827 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * ext/extmk.rb: get rid of shadowing outer local variable.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@55826 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * ext/extmk.rb (sysquote): removed. unnecessary since r52161.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@55825 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Applied in changeset r55824.
----------
deprecate TRUE,FALSE,NIL
* object.c (InitVM_Object): deprecate toplevel constants TRUE,
FALSE, and NIL. [Feature #12574] -
- * object.c (InitVM_Object): deprecate toplevel constants TRUE,
FALSE, and NIL. [Feature #12574]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@55824 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
08/06/2016
-
10:08 PM Bug #12660: [PATCH] openssl: avoid undefined behavior on empty SSL_write
- k@rhe.jp wrote:
> Thanks! Looks fine to me. Please commit.
Thanks for quick review :> r55822 -
09:50 PM Bug #12660 (Closed): [PATCH] openssl: avoid undefined behavior on empty SSL_write - Applied in changeset r55822.
----------
openssl: avoid undefined behavior on empty SSL_write
SSL_write(3ssl) manpage has this in the WARNINGS section:
When calling SSL_write() with num=0 bytes to be sent the
behaviour is... -
11:38 AM Bug #12660: [PATCH] openssl: avoid undefined behavior on empty SSL_write
- Thanks! Looks fine to me. Please commit.
-
- SSL_write(3ssl) manpage has this in the WARNINGS section:
When calling SSL_write() with num=0 bytes to be sent the
behaviour is undefined.
And indeed, the new test case demonstrates failures when
empty strings are u... - 09:50 PM Revision f5f6859b (git): * 2016-08-07
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@55823 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 09:50 PM Revision 7513d546 (git): openssl: avoid undefined behavior on empty SSL_write
- SSL_write(3ssl) manpage has this in the WARNINGS section:
When calling SSL_write() with num=0 bytes to be sent the
behaviour is undefined.
And indeed, the new test case demonstrates failures when
empty strings are used. ... -
- You can't make multiple requests on a Net::HTTP instance at the same time. You have to open an HTTP connection for each thread.
As for the segmentation fault, in trunk, r55100 should have fixed it ([Bug #12292]). -
02:00 PM Bug #12661: Multithreading http get doesn't work
- on stackoverflow:
http://stackoverflow.com/questions/38805052/download-files-asynchronously -
- Hi, I was making this script that was supposed to download all files from my favourite imageboard (2ch.hk)
Everything was normal until I tried to make downloading of these files asynchronous, i.e. in different threads, to improve speed
... -
01:01 AM Feature #12659 (Closed): Readline: expose rl_char_is_quoted_p setting
- I maintain an interactive Git shell [1] built in Ruby, which made extensive use of the `Readline` module. We found we outgrew the functionality provided by the module, so we built our own `Gitsh::LineEditor` module using Ruby's `Readline...
-
- * id_table.h (rb_id_table_iterator_result): add dummy sentinel
member because C standard prohibits a trailing comma.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@55821 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Mathieu Jobin wrote:
> it uses the following macros to find the method visibility and if it has been redefined
> ...
I'd love to add the functions, but are they really needed?
> Ideally, a ruby method that would return its visibility, s...
08/05/2016
-
06:53 PM Bug #12658 (Closed): variable_name_checker
- (development) 15:45:10 ~/2016/cmdapi/collector $ rackup
[2016-08-05 15:45:12] INFO WEBrick 1.3.1
[2016-08-05 15:45:12] INFO ruby 2.3.0 (2015-12-25) [x86_64-darwin15]
[2016-08-05 15:45:12] INFO WEBrick::HTTPServer#start: pid=73891 p... -
- This is related to Bug #12191.
Changing in internal.h:983-985
from :
```diff
-#define RBASIC_CLEAR_CLASS(obj) (((struct RBasicRaw *)((VALUE)(obj)))->klass = 0)
-#define RBASIC_SET_CLASS_RAW(obj, cls) (((struct RBasicRaw... - 03:39 PM Revision b46a8a54 (git): * 2016-08-06
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@55820 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * hash.c (env_enc_str_new): make string for an environment
variable name or value.
* hash.c (env_name_new): make environment value string with the
encoding for its name.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@55819 b2dd03... -
03:25 PM Feature #12654: On Windows use UTF-8 as filesystem encoding
- Usaku NAKAMURA wrote:
> If filesystem encoding is fixed to UTF-8, it causes other (but similar) problems.
UTF-8 can be easily encoded to any other encoding but opposite isn't always true.
But yeah I agree with other points.
-
- Premises:
1. We don't introduce such breakage of compatibility until Ruby 3.
2. At Ruby 3, on Windows, we're planning to use UTF-8 as the default locale.
3. Ruby 3 will *not* force users to use UTF-8. Users will be able to choose e... -
- Nobuyoshi Nakada wrote:
> Dāvis Mosāns wrote:
> ...
I strongly disagree. WinAPI, PowerShell and cmd supports Unicode independently of used codepage, you can navigate to paths which can't be represented with active codepage. There's rea... -
- Dāvis Mosāns wrote:
> That's not really needed. For example `File.read` works with any console's codepage. But `Dir.entries` and `Dir.pwd` works only for ANSI paths no matter what console's codepage is set to. There's quite inconsistenc... - 02:19 PM Revision 549605c1 (git): * hasn.c (env_str_new): taint the string. get rid of a test failure
- introduced at r55811.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@55818 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
01:52 PM Feature #12648: `Enumerable#sort_by` with descending option
- Taking a step back, we are using arrays simply because that is a object that allows sorting via multiple criteria (if criteria a is equal, test with criteria b, etc).
It is also my understanding that sort_by creates arrays of [enum_it... -
- Nobuyoshi Nakada wrote:
> Greg L wrote:
> ...
I mentioned the fact that an array is often not returned by the block, hence, my suggestion for adding a new method.
Sorry, I should have shown a signature, below would be a possibility.... -
- Greg L wrote:
> Hence, a better solution might be adding a method like `sort_keys` or `sort_key`, where an array is returned by the block, and an array is used as the single parameter for ascending/descending info.
Could you make cl... -
- In concept, I agree, but, although it's common to return an array from the block, any object can be returned that supports <=>.
Hence, a better solution might be adding a method like `sort_keys` or `sort_key`, where an array is return... -
- * win32/win32.c (getifaddrs, rb_w32_getppid): initialize the API
pointers with an impossible value not to try everytime on old
platforms.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@55817 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * win32/win32.c (rb_w32_inet_ntop, rb_w32_inet_): make the
API pointers static not to get the address everytime.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@55816 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * win32/win32.c (get_final_path): initialize this pointer without
further comparisons.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@55815 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 08:04 AM Revision ad9d8468 (git): * 2016-08-05
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@55814 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * hash.c (w32_getenv): call rb_w32_getenv and rb_w32_ugetenv via
this pointer without further comparisons.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@55813 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
-
- I think it should be possible to implement locksee in pure-ruby. To me it seems OK to have a way to access visibility of a method.
It is not clear if locksee cannot be implemented without exposing IClass, though.