Activity
From 03/18/2016 to 03/24/2016
03/24/2016
-
11:25 PM Bug #12215: URI::HTTP.new example is incorrect
- You are right.
```ruby
uri = URI::HTTP.new('http', nil, "www.example.com", nil, "/path", "query", 'fragment')
```
Triggers the error. Should be changed. -
07:26 PM Bug #12215 (Closed): URI::HTTP.new example is incorrect
- On this page (http://ruby-doc.org/stdlib-2.3.0/libdoc/uri/rdoc/URI/HTTP.html) the example for URI::HTTP.new will result in an error (ArgumentError: wrong number of arguments (`given 7, expected 9..11)`).
A working example (2.3.0-dev)... -
04:58 PM Feature #12214: Inconsistent behaviour and lack of warnings/errors when referencing duplicated _variables
- Oh, I forgot to add the third case:
def foo _, _=2
p _
end
foo 1, 3
gives `1` (and not `3`).
-
- _, _ = [1, 2]
p _
gives `2`
def foo _, _
p _
end
foo 1, 2
gives `1`
def foo _, _=2
p _
end
foo 1
gives `2`
In other words, referencing duplicated variables starting with an underscore gives inconsiste... -
04:51 PM Bug #12118 (Closed): ruby2.3: Segfaults on m68k due to improper stack allocation
- Applied in changeset r54256.
----------
* thread_pthread.c (reserve_stack): fix reserving position where
the stack growing bottom to top. [Bug #12118] -
- As far as I understand, the fix should be following:
```diff
diff --git a/thread_pthread.c b/thread_pthread.c
index ef43b36..1fdf3f5 100644
--- a/thread_pthread.c
+++ b/thread_pthread.c
@@ -693,17 +693,31 @@ reserve_stack(volatil... -
09:30 AM Bug #12118: ruby2.3: Segfaults on m68k due to improper stack allocation
- Here's the complete backtrace:
~~~
(sid-m68k-sbuild)root@z6:/build/ruby2.3-dCWwvL/ruby2.3-2.3.0# ./miniruby -I./lib -I. -I.ext/common ./tool/runruby.rb --extout=.ext -- --disable-gems -r./m68k-linux-gnu-fake ./tool/rbinstall.rb --m... -
- Hi!
Since my first post was a bit confusing, here is for clarification:
The above patch helped with ruby2.2, but it does not help with ruby2.3, so this seems to be a different problem.
Trying to debug the issue now.
Adrian -
- the stack growing bottom to top. [Bug #12118]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@54256 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
04:30 PM Feature #12133: Ability to exclude start when defining a range
- Please accept apologies for confusion caused by non-matching parenthesis/brackets -- this notation is just a standard way of denoting intervals in mathematics (ref. [ISO 31-11](https://en.wikipedia.org/wiki/ISO_31-11) & [Wikipedia entry ...
-
04:10 PM Revision 22f1db4b (git): mkmf: Unquote directory strings
- * lib/mkmf.rb (find_executable0): On Windows, it is actually valid
to surround individual PATH directory entries with double
quotes. Remove these before joining the path as otherwise the
literal quotes would become part of the path... -
- * test/mkmf/test_find_executable.rb (each_exts): extract common
setup.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@54254 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * strftime.c (format_value): convert from Bignum to String,
instead of rb_str_format.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@54253 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * strftime.c (FMTV): set the buffer length before appending to
keep just put part.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@54252 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 03:01 PM Revision f4f7d497 (git): * 2016-03-25
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@54251 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * strftime.c (FMT_PRECISION): eliminate side effects.
[Bug #12213]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@54250 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@54249 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Applied in changeset r54248.
----------
strftime.c: remove recursive-assignments
* strftime.c (FMT, FMTV): remove recursive-assignments to get rid
of undefined behavior. [ruby-core:74532] [Bug #12213] -
09:57 AM Bug #12213 (Closed): Lots of warnings: operation on ‘precision’ may be undefined
- When compiling ruby trunk on cygwin, I get a long list of warnings starting with the following:
strftime.c:290:14: warning: operation on ‘precision’ may be undefined [-Wsequence-poin t]
precision = FMT_PRECISI... -
- * strftime.c (FMT, FMTV): remove recursive-assignments to get rid
of undefined behavior. [ruby-core:74532] [Bug #12213]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@54248 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
12:02 PM Feature #12210: Add IdentitySet class that compares members by identity
- I submitted this as a patch because the std lib already contains one subclass of Set (SortedSet) and a commented-out implementation of another (RestrictedSet).
I don’t expect that this class will change beyond the initial implementati... -
01:47 AM Feature #12210: Add IdentitySet class that compares members by identity
- If you want a new class, why not start as a separate gem for it?
-
- I think that rather than creating a new class, adding an option on Set.new (e.g. Set.new([a_str, a_str, "b", "b"], compare_by: :identity)) is more Ruby-like.
-
11:52 AM Bug #12185: Missing symbol inspect_tcpi_msec
- Backported into `ruby_2_2` branch at r54247.
-
- * ext/socket/option.c (inspect_tcpi_msec): more accurate condition
for TCPI msec member inspection function.
[ruby-core:74388] [Bug #12185]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_2@54247 b2dd03c... -
- Mark Dodwell wrote:
> Parsing a URI of "mailto:?subject=hi" with `URI.parse` raises an exception. I believe this is a valid "mailto" URI, as defined in RFC6068.
As one of the co-authors of RFC 6068, I have to agree with you. See the ... -
08:59 AM Bug #12212 (Closed): Parsing a URI of "mailto:?subject=hi" with `URI.parse` raises an exception
- Parsing a URI of "mailto:?subject=hi" with `URI.parse` raises an exception. I believe this is a valid "mailto" URI, as defined in RFC6068.
Behavior observed:
```ruby
>> URI.parse("mailto:?subject=hi")
NoMethodError: undefined met... -
09:00 AM Bug #12209: Array#pack("G") problem
- This is obviously a bug in the Ruby-side.
The original code, after swapping the bytes of a double, assigns it to a double.
~~~
d = (..., d);
~~~
At this point, bit pattern of the right-hand expression ends with f67f, which is ... -
06:08 AM Bug #12209: Array#pack("G") problem
- I am aware of the x87 vs. SSE2 differences, but I don't think this issue has anything to do with that.
Note that my example demonstrated that a given Float, when processed by pack("G") + unpack("G") is changed into another bit pattern... -
- It looks because of x87 FPU's internal calculation behavior.
x87 always calculates floating points with 80bit precision on their register, even if the number is 64bit double.
And only when the number is assigned to a 64bit double var... -
- * strftime.c (FMT_PADDING): extract format for padding.
* strftime.c (FMT_PRECISION): extract precision formula.
* strftime.c (FMTV): append formatted string to expand the result.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@54246 ... -
08:36 AM Feature #12211: introduce Date#first_of_month and Date#last_of_month
- IMHO, consistent approach would be "allow Date/Time to be rounded to any component", there are many uses for this. Maybe something like `ceil`/`floor`/`round` methods set with Symbol argument? Like `floor(:month)` and `ceil(:month)`?
-
08:23 AM Feature #12211 (Open): introduce Date#first_of_month and Date#last_of_month
- Proposes new methods Date#first_of_month and Date#last_of_month which can be very helpful in reporting applications which need the first and the last day of a month very frequently.
~~~
class Date
def first_of_month
Date.... -
- Hi Nobuyosh!
Nobuyoshi Nakada wrote:
> What constraints does `DTRACE_PROBE4` macro have?
Sorry for the late reply, I apparently didn't get a notification.
I'm not sure where to retrieve that information. Can you point me to whe... -
07:16 AM Bug #12100 (Rejected): CSV converters fail when using single arg proc
-
- * strftime.c (STRFTIME): deal with case conversion flags for
recursive formats.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@54245 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * ext/date/date_core.c (dt_lite_jisx0301): remove no longer used
variable.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@54244 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * ext/date/date_core.c (dt_lite_iso8601): strftimev() always
returns a String, so append them directly.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@54243 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * ext/date/date_core.c (d_lite_jisx0301, iso8601_timediv),
(dt_lite_jisx0301): format by the format string in local buffer
to prevent intermediate strings from GC.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@54242 b2dd03c8-39d... -
- * ext/date/date_core.c (mk_inspect_raw, mk_inspect): inspect by
"%+"PRIsVALUE, to prevent intermediate strings from GC.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@54241 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 02:43 AM Revision ec3d8950 (git): * 2016-03-24
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@54240 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * strftime.c (rb_strftime_with_timespec): remove unnecessary
check, as `s` equals to `endp` when recursed STRFTIME resized
the capacity same as the size.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@54239 b2dd03c8-39d4-4d8f-98f... -
- I think it would be great to somehow integrate the 'do_you_mean' functionality into ri.
Also, a bit more interactivity may help. As an example, if I write "ri each", I get just a concatenation of the doc for many different 'each' meth...
03/23/2016
-
- You forget that some people - like me - may use a hash because it is a lot simpler and more convenient too.
I don't have to wonder about any positional arguments ever and I don't want to have to think.
With a hash I don't have to t... -
- ri is a bit weird, perhaps it is just that I got used to it not being that hugely important back in 2003 or
2004 or so.
I had to ask on stackoverflow how to obtain information from ri/rdoc, for use in a REPL.
The API is something ... -
06:31 AM Feature #12208: Improve ri command
- We could add the `ri` commands for each method on the Ruby [doc HTML pages](http://ruby-doc.org/core-2.3.0/) at just under the method signature line (like shown in the image attached) or some place else. That way anyone who visits the R...
-
- Ruby has well documented in rdoc.
It also has a frontend CLI.
But people seems not using `ri`...
At first, write your request here to improve ri command! -
- This subclass of Set handles a use case that we ran into where we needed to track instances of objects that might compare as equal.
I was surprised that there was not a core way to do this. IdentitySet allows you to do the following (... -
05:24 PM Bug #12206: undef_method on prepended module undefines same-name method on prepending class
- Kazuhiro NISHIYAMA wrote:
> How about using `remove_method` instead of `undef_method` ?
It worked, thanks! Behavior is still confusing since I undef'd the method on the module rather than the class, but this solves my problem. -
01:36 PM Bug #12206: undef_method on prepended module undefines same-name method on prepending class
- How about using `remove_method` instead of `undef_method` ?
-
- Array#pack("G") gives incorrect result *sometimes*. The problem occurs with:
* all Ruby versions I have tried: 2.0.0, 2.3.0 and Subversion-trunk (all built from source)
* only with 32-bit builds (not 64-bit)
* only with GCC (not CLA... - 12:50 PM Revision aeb0be6a (git): * enum.c (ary_inject_op): put subtract operation out of if-clause.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@54238 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 12:41 PM Revision e324d29e (git): * enum.c (ary_inject_op): Use Kahan's compensated summation algorithm
- for summing up float values.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@54237 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * strftime.c (rb_strftime_with_timespec): append formatted results
to the given string with expanding, and also deal with NUL chars.
* strftime.c (rb_strftime, rb_strftime_timespec): return formatted
string, not the length put in the... -
- expand_name. (display_name rescues NotFoundError by itself,
the original logic looks buggy...)
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@54235 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * marshal.c (r_long): cast to `signed char`, which is used
already, instead of SIGN_EXTEND_CHAR.
* parse.y: SIGN_EXTEND_CHAR is no longer used. [Fix GH-1302]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@54234 b2dd03c8-39d4-4d8f-... -
- Applied in changeset r54233.
----------
GNUmakefile.in: fix MSYS2_ARG_CONV_EXCL
* cygwin/GNUmakefile.in (MSYS2_ARG_CONV_EXCL_PARAM):
* add missing parentheses and remove double quotes.
* rename to get rid of recursive references.
... -
-
- * cygwin/GNUmakefile.in (MSYS2_ARG_CONV_EXCL_PARAM):
* add missing parentheses and remove double quotes.
* rename to get rid of recursive references.
* as --excludes-dir option is for a path name, its argument
should be convert... -
01:39 AM Bug #12121 (Closed): 異なる名前空間にある同名の定数により Module.constans の結果の並びが変わる
- Applied in changeset r54231.
----------
* variable.c: Added documentation about order of `Module#constants`
[ci skip][Bug #12121][ruby-dev:49505][fix GH-1301] - 01:39 AM Revision ea6372de (git): * 2016-03-23
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@54232 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- [ci skip][Bug #12121][ruby-dev:49505][fix GH-1301]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@54231 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
03/22/2016
-
08:38 PM Bug #12207 (Closed): [BUG] Segmentation fault at 0x00000000000000 ruby 2.2.3p173 (2015-08-18 revision 51636) [x86_64-darwin14]
- ```
/Users/mdowns/github/partner-api/lib/demandbase/generate_response_service.rb:20: [BUG] Segmentation fault at 0x00000000000000
ruby 2.2.3p173 (2015-08-18 revision 51636) [x86_64-darwin14]
[1] 62509 abort bundle exec rspec... -
- 1. Define a class with a method
2. Define a module with a same-name method
3. Prepend the module on the class
4. Undefine the same-name method on the module, not touching the original method on the class
5. Observe the class method t... -
03:54 PM Bug #12199: About msys2 path conversion measures in make test-all
- 対応ありがとうございました。
確認したところ、期待の動作にならなかったのでデバッグしました。
パッチを添付します。
次の1～3、（および4）の修正実施により、期待通りにパス変換が抑制されることを、
MSYS2 installer環境と、RubyInstallerのmsys2化版で確認しました。
1. $() が必要でした。"$MSYS2_ARG_CONV_EXCL"は、"SYS2_ARG_CONV_EXCL"と評価されていました。
2. 1.を直... -
03:34 PM Feature #12205: update missing/strl{cat,cpy}.c
- Shyouhei Urabe wrote:
> The code is much cleaner so I would +1, but it seems the upstream has more recent revisions (strlcat.c 1.16 and strlcpy.c 1.13). Why to avoid them?
The current revisions would require defining a function-like... -
- The code is much cleaner so I would +1, but it seems the upstream has more recent revisions (strlcat.c 1.16 and strlcpy.c 1.13). Why to avoid them?
-
- The attached git diff updates `missing/strlcat.c` from 1.8 to 1.15,
`missing/strlcpy.c` from 1.5 to 1.12 and also the `LEGAL` file.
There is no important reason. But there was a license change:
new style-BSD to a less restrictive I... - 12:08 PM Revision d864828f (git): * remove trailing spaces.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@54230 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * enc/unicode/case-folding.rb, casefold.h: Using above flag in data.
* enc/unicode.c: Marking capitalized character as unmodified if it is
already titlecase.
* test/ruby/enc/test_case_mapping.rb: Tests for above functionality.
git-sv... -
- They are passed to a macro. I guess the author intentionally separated these two because merging them makes the code less intuitive. It seems OK to be optimized.
-
- This is (surprisingly) safe, because that `mimeout_state.count = 0;` line purposefully terminates outer loop. It works as expected; just in a ultimately complicated way.
-
- * parse.y (lambda_body, parser_yylex): warn mismatched indentation
of lambda block.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@54228 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * test/ruby/test_rubyoptions.rb (test_indentation_check): assert
warnings against other keyword mismatches.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@54227 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 02:41 AM Revision 15af93fc (git): * time.c (wmul): wrong condition.
- fixed many test failures on 32bit and LLP64 platforms.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@54226 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- 01:37 AM Revision 6957898a (git): * time.c (wdiv, wmod): wdivmod0() assumes the 3rd and the 4th arguments
- are valid pointers.
maybe checking them in wdivmod0() is better manner, but I guess that
passing real dummy pointers may be faster than checking and branching
in wdivmod0().
this commit fixes SEGV on 32bit and LLP64 platforms.
... - 01:24 AM Revision 0dbbcdb6 (git): * time.c (divmodv): void function never returns any value.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@54224 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * test/lib/test/unit.rb (Test::Unit::StatusLine#failed): print
failed messages only if replacing mode, otherwise defer them
until the end, to get rid of interleaving failures with progress
messages. refix r54195.
git-svn-id: svn+...
03/21/2016
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@54222 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * time.c (wmul): use MUL_OVERFLOW_FIXWV_P and only switch.
* time.c (wmul): use mul which has Fixnum optimization.
* time.c (rb_time_magnify): If WIDEVALUE_IS_WIDER, wmul() has the same
optimized logic, else mul() has also the simila... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@54220 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 06:19 PM Revision 69bedfca (git): * 2016-03-22
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@54219 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * time.c (wquo): use quo which has Fixnum optimization.
* time.c (wdivmod0): added for WIDEVALUE_IS_WIDER.
* time.c (wdivmod): use wdivmod0 and divmodv.
divmodv has Fixnum optimization.
* time.c (wdiv): use wdivmod0 and div to avoid... -
05:20 PM Feature #12026: Support warning processor
- Tsuyoshi Sawada wrote:
> Can we have additional syntax that is analogous to `rescue` (but a little different)? Maybe something that takes a regex (instead of exception class) for matching, and an optional `=>` that assigns `message` (an... -
02:00 PM Feature #12116: `Fixnum#divmod`, `Bignum#divmod` with multiple arguments
- My proposal remains as I proposed above, but I just wanted to note that there is another natural way to generalize the notion of `divmod` with multiple divisors, and that people be aware of the difference.
* The proposed generalizatio... -
- * iseq.c (rb_iseq_compile_with_option): suppress
maybe-uninitialized warning by gcc 4.8.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@54217 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- x == FIXNUM_MIN && y == -1. This must be a rare case and it is
expected compiler to handle well.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@54216 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@54215 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@54214 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * time.c (quo): c can be Fixnum except a == FIXNUM_MIN && b == -1.
Such case can be optimized out because quo()'s argument is constant.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@54213 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * internal.h (rb_fix_mul_fix): multiply converted values, not
object VALUEs.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@54212 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Applied in changeset r54211.
----------
suppress msys2 pathname conversion
* common.mk (TEST_EXCLUDES, EXCLUDE_TESTFRAMEWORK): use full spell
long option.
* cygwin/GNUmakefile.in (MSYS2_ARG_CONV_EXCL): suppress path name
conversion... -
- * common.mk (TEST_EXCLUDES, EXCLUDE_TESTFRAMEWORK): use full spell
long option.
* cygwin/GNUmakefile.in (MSYS2_ARG_CONV_EXCL): suppress path name
conversions by msys2. [ruby-dev:49525] [Bug #12199]
git-svn-id: svn+ssh://ci.ruby-lan... -
- Applied in changeset r54210.
----------
string.c: skip invalid char gap
* string.c (enc_succ_alnum_char): try to skip an invalid character
gap between GREEK CAPITAL RHO and SIGMA.
[ruby-core:74478] [Bug #12204] -
- * string.c (enc_succ_alnum_char): try to skip an invalid character
gap between GREEK CAPITAL RHO and SIGMA.
[ruby-core:74478] [Bug #12204]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@54210 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * node.c (rb_gc_mark_node): NODE_MATCH2 can have nd_args, u3,
since r54100.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@54209 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * test/lib/test/unit.rb (after_worker_down): show failed file name
if worker crashed.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@54208 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
03/20/2016
-
-
09:09 AM Bug #12200 (Closed): MRI 2.2.4 parser forces blanks for hash keys which point to an array literal
- In MRI 2.2.3 and below this was valid code:
~~~
$ ruby -v -e 'a={ name:%w(a b c) }; puts a'
ruby 2.2.3p173 (2015-08-18 revision 51636) [x86_64-darwin15]
{:name=>["a", "b", "c"]}
~~~
In MRI 2.2.4 the same code will generate a sy... -
09:18 PM Bug #12204 (Closed): Invalid range of capital letters at Greek alphabet
- Greek alphabet's first and last letter is:
* α - ω (lower case)
* Α - Ω (upper case)
So if we write on a ruby console the following script, we get:
~~~
('α'..'ω').to_a
=> ["α", "β", "γ", "δ", "ε", "ζ", "η", "θ", "ι", "κ", "λ"... - 06:28 PM Revision be40357a (git): * 2016-03-21
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@54207 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@54206 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- I myself have found Pathname harder or less elegant to use than the direct File* or Dir* methods so I am in support of the suggestion by nobu.
So to Benoit, I understand that you may consider File.dirname(path, 2) not ideal either (a ... -
- Here is Hash#rehash link:
http://ruby-doc.org/core-2.3.0/Hash.html#method-i-rehash
Perhaps the documentation could be updated regardless, to also notify the ruby user when .rehash may be useful. For instance, this is the first time... -
02:41 PM Bug #12187 (Assigned): BigDecimal.divmod failing spuriously on 2.0.0
-
12:29 PM Bug #12203 (Third Party's Issue): dumper.c static int yaml_emitter_dump_scalar two variables have the same value
- ~~~
static int
yaml_emitter_dump_scalar(
.....
int plain_implicit = (strcmp((char *)node->tag,
YAML_DEFAULT_SCALAR_TAG) == 0);
int quoted_implicit = (strcmp((char *)node->tag,
YAML_DEFAULT_SCALAR_TAG... -
- ~~~
for (i=0;i<mimeout_state.count;i++) {
if (SP<mimeout_state.buf[i] && mimeout_state.buf[i]<DEL) {
eof_mime();
for (i=0;i<mimeout_state.count;i++) {
(*o_mputc)(mimeout_state.buf[i]);
base64_count++;
}
... - 12:18 PM Revision 6d97a5de (git): * internal.h (rb_int128t2big): declare only when HAVE_INT128_T.
- fixed a compile error with VC++ introduced at r54203.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@54205 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- ~~~
/* new line */
if (fold_preserve_f) {
f_prev = c1;
f_line = 0;
fold_state = CR;
} else if ((f_prev == c1 && !fold_preserve_f)
|| (f_prev == LF && fold_preserve_f)
) { /* duplicate newline */
... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@54204 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- but LONG_LONG is always defined as 64bit), or there's int128_t.
* internal.h (DL2NUM): defined if DLONG is defined.
* internal.h (rb_fix_mul_fix): defined for `Fixnum * Fixnum`.
* insns.def (opt_mul): use rb_fix_mul_fix().
* numeric.... -
- * bignum.c (rb_big_cmp): micro optimization of Fixnum comparison.
as SIGNED_VALUE and Fixnum have same sign-bits and same order.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@54202 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * numeric.c (fix_gt, fix_ge, fix_lt, fix_le): optimize comparisons
Fixnum against Bignum by rb_big_cmp in inversed order without
new Bignum instance.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@54201 b2dd03c8-39d4-4d8f-98ff-82... -
- * time.c (sub): ditto.
* time.c (mul): ditto.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@54200 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
08:22 AM Bug #12117: UDPSocket.new crash on win32 with "rb_update_max_fd: invalid fd (xxx) given"
- Can no longer reproduce as of:
ruby 2.2.5p256 (2016-03-10 revision 54072) [i386-mswin32_100]
Seems to be fixed!
Thanks,
Bill
-
- ruby 2.3以降、make test-allの際のテスト除外の指定に正規表現リテラルを
用いるようになったと思います。
これにより、Windowsでのmsys, msys2を用いたbuild環境でmake test-allを実行した場合、
--name=!/memory_leak/ → --name=!c:/msys64/memory_leak/のようにpath変換が行われてしまい、
意図した除外が行われません。
現時点のtrunkでは全て除外され... -
- How to reproduce it?
03/19/2016
-
- * bignum.c (rb_big_eq): If normalized bignum is still bignum,
it must be larger than fixnum.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@54199 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 04:51 PM Revision fb12f40f (git): ChangeLog: fix typo [ci skip]
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@54198 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
04:24 PM Bug #12198: Hash#== sometimes returns false incorrectly
- Yes, I believe that implementing `Set#rehash` is a good idea (unless rehashing automatically when needed would be a better one). Furthermore, documentation is quite confusing on this topic. The caveat is indeed somewhat mentioned in the ...
-
- Sebastian Skalacki wrote:
>
> ...
You have to apply `Hash#rehash`.
~~~RUBY
h1.rehash
h2 == h1 # => true
~~~
And since `Set` is based on `Hash`, this carries over to `Set`.
Yusuke Endoh wrote:
>
> ...
I think this is not... -
- Actually it has nothing to do with sets:
~~~
b = []
h1 = {b => true}
b << 42
h2 = {[42] => true}
p h2 #=> {[42]=>true}
p h1 #=> {[42]=>true}
p h2 == h1 #=> false
~~~
-
03:32 PM Bug #12198 (Assigned): Hash#== sometimes returns false incorrectly
- Simplified.
~~~~
require "set"
a = []
s1 = Set[a]
a << 42
s2 = Set[[42]]
p s2 #=> #<Set: {[42]}>
p s1 #=> #<Set: {[42]}>
p s2 == s1 #=> false
~~~~
Modifying an element of a set causes this issue. I'm unsure if this ... -
- Hi!
Sorry for lack of the accuracy in the bug title. I have some trouble with pinpointing the issue.
According to documentation, "two hashes are equal if they each contain the same number of keys and if each key-value pair is equal... - 04:08 PM Revision 95922527 (git): * 2016-03-20
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@54197 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 04:08 PM Revision fa860a94 (git): * include/ruby/intern.h (rb_big_odd_p, rb_big_even_p): move to
- internal.h so that they are exported only for ruby itself.
* internal.h (rb_big_odd_p, rb_big_even_p): ditto.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@54196 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
02:45 PM Bug #11903: [BUG] vm_call_cfunc - cfp consistency error
- /home/leo/.rvm/gems/ruby-2.2.1/gems/rspec-core-3.2.3/lib/rspec/core/example.rb:247:
[BUG] vm_call_cfunc - cfp consistency error
ruby 2.2.1p85 (2015-02-26 revision 49769) [x86_64-linux]
-- Control frame information -----------------... -
- * test/lib/test/unit.rb (Test::Unit::StatusLine#failed): defer
failed messages until the end in verbose mode, to get rid of
interleaving failures with progress messages.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@54195 b2dd03... -
- * numeric.c (fix_cmp): invert the result as the comarison is
inverted.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@54194 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- rb_big_cmp handles such case smartly with big_norm.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@54193 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- I think the following definition is acceptable for a Complex:
~~~ruby
def inifinite?
self.magnitude.infinite?
end
~~~
-
- What behavior is desirable for a Complex?
- 09:43 AM Revision 5a213ee2 (git): * numeric.c (int_to_f): raise NotImplementedError when a receiver
- class is unknown.
* test/-ext-/integer/test_my_integer.rb (test_my_integer_to_f): modify
a test for the above change.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@54192 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 09:29 AM Revision 4ce02b7b (git): ChangeLog: fix filename [ci skip]
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@54191 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 09:28 AM Revision 81f65a9e (git): * bignum.c (Bignum#<=>): remove it because they are unified with
- Integer#<=>.
* numeric.c (Integer#<=>, Fixnum#<=>): move <=> method from Fixnum to
Integer.
* numeric.c (int_cmp): add this method for Integer#<=>.
* test/-ext-/integer/test_my_integer.rb (test_my_integer_cmp): add a
test to exami... -
- Applied in changeset r54189.
----------
SyntaxError message at iseq compile
* iseq.c (rb_iseq_compile_with_option): make the parser in mild
error.
* load.c (rb_load_internal0): ditto.
* parse.y (yycompile0): return the error message ... -
- https://github.com/ruby/ruby/compare/trunk...nobu:feature/11951-iseq-compile-error
-
- * iseq.c (rb_iseq_compile_with_option): make the parser in mild
error.
* load.c (rb_load_internal0): ditto.
* parse.y (yycompile0): return the error message within the error
to be raised. [Feature #11951]
* parse.y (parser_compile_e... -
- * test/ruby/test_iseq.rb (TestISeq): use the utility method to get
rid of warnings and the alias to shorten.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@54188 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
03/18/2016
-
- バックポート管理用チケットです。
struct parser_params::debug_buffer のマーク漏れ修正です。 2.3 から導入されたメンバなので 2.2 以前には不要です。 -
- * time.c (GMTIME): define only ifndef HAVE_STRUCT_TM_TM_GMTOFF.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@54187 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- define _BSD_SOURCE for time.h to define struct tm.tm_gmtoff.
* time.c: define _BSD_SOURCE at the top.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@54186 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Merged at r54172.
-
08:13 AM Bug #12192: Wrong nth_ref_max check in parse.y
- Pull requested was accepted, bug can be closed.
-
- * parse.y (parser_mark): mark debug_buffer.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@54185 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 06:05 PM Revision 06037b54 (git): * test/-ext-/time/test_new.rb (test_timespec_new): change a gmtoff
- test to a better one that does not depend on whether the current
time is in summer time or not.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@54184 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@54183 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 03:02 PM Revision 7f426ead (git): * 2016-03-19
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@54182 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 03:02 PM Revision 0d076fe4 (git): * bignum.c (rb_big_to_f, Bignum#to_f): removed them because they are
- unified with int_to_f and Integer#to_f.
* numeric.c (int_to_f): treat Bignum values directly.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@54181 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 02:52 PM Revision bb00a5c1 (git): * properties.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@54180 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 02:52 PM Revision b60a7b43 (git): * numeric.c (int_to_f, fix_to_f): rename fix_to_f to int_to_f, and add
- treatment for subclasses which don't have definitions of to_f method.
* numeric.c (Integer#to_f, Fixnum#to_f): move to_f method from Fixnum
to Integer.
* ext/-test-/integer/my_integer.rb: define helper class for testing
to_f method... - 01:33 PM Revision 2897eb11 (git): * include/ruby/intern.h (rb_big_hash): Move to internal.h.
- * internal.h: ditto.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@54178 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- From `Date::new` docs:
> The month and the day of month **should be a negative or a positive number** (as a relative month/day from the end of year/month when negative). They should not be zero.
~~~ruby
Date.new(2016,2,-1)
# => ... -
01:02 PM Bug #12196 (Closed): lib: Date.valid_date? returns incorrect response for negative day
- ~~~
require 'date'
puts RUBY_VERSION
if Date.valid_date?(2016, 2, -1)
puts "Valid"
else
puts "Invalid"
end
~~~
This reports 'Valid' for a negative day number.
- 01:11 PM Revision 18d114ef (git): * bignum.c (Bignum#eql?): remove its definition because it is unified
- with Numeric#eql?.
* numeric.c (num_eql): treat Bignum values directly.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@54177 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 12:57 PM Revision ad0b5ebc (git): * bignum.c (rb_big_to_s, Bignum#to_s): remove its definition because
- it is unified with Integer#to_s.
* numeric.c (int_to_s): treat Bignum values directly.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@54176 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 12:33 PM Revision a22ff208 (git): * numeric.c (int_to_s): Move from flo_to_s.
- * numeric.c (Integer#to_s): Move from Fixnum#to_s.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@54175 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
12:18 PM Feature #12194: File.dirname optional parameter
- Using Pathname would already make this much nicer:
Pathname(path).parent.parent
And less error prone than File.dirname if the path is not absolute.
Just my opinion, but I do not like this particular syntax. -
- As talked at the last developers' meeting, I propose an addition of an optional parameter to `File.dirname`.
Often I see the code, like
```ruby
File.dirname(File.dirname(path)) # or
File.expand_path("../..", path)
```
which are... -
- https://github.com/ruby/ruby/compare/trunk...nobu:bug/12082-tailcall_inhibited_by_rescue?expand=1
-
08:44 AM Bug #12195 (Closed): [BUG] probable buffer overflow: 4010 for 2005 (CFUNC :read)
- This causes ruby to shutdown:
[[https://github.com/minad/mimemagic/blob/master/lib/mimemagic.rb#L112]]
recursive read and seek on a file for a table of regexps.
It's a gem for mime type detection.
The code is running in a rails Sid... -
- * test/ruby/test_file_exhaustive.rb (test_dirname): assert same as
the parent directory, not ascendant directories.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@54174 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * gc.c (gc_page_sweep): use the argument objspace.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@54173 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * parse.y (parse_numvar): NTH_REF must be less than a half of
INT_MAX, as it is left-shifted to be ORed with back-ref flag.
[ruby-core:74444] [Bug#12192] [Fix GH-1296]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@54172 b2dd03c8... -
- * file.c (rb_file_s_split): use rb_file_dirname instead of
rb_file_s_dirname with unused Qnil.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@54171 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Marc-Andre Lafortune wrote:
> Just to be sure, with "propagating &. as long as explicit method chain continues", we consider that `x&.foo * 42` returns `nil`, as calling `*` is equivalent to `.*`, right?
I think so. -
05:13 AM Feature #220: test-coverage measurement
- Yusuke Endoh wrote:
> =begin
> ...
It's a nice idea! I will follow your advice and do
https://kcoleman.me everything you've said! good fix choice -
- * gc.c (tick): fix missing close parenthesis. [Fix GH-1291]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@54170 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
03:19 AM Bug #12193: ruby 2.3 on windows test-all failed
- Tsuyoshi Morita wrote:
> ~~~
> ...
You are right.
Now test-all 2.3.0p0 and 2.3.0p7 has 2 failed.
-
01:26 AM Bug #12189 (Closed): DateTime#to_time removes timezone information
- Applied in changeset r54169.
----------
* ext/date/date_core.c (datetime_to_time): preserve timezone info
[Bug #12189] [Fix GH-1295] -
- [Bug #12189] [Fix GH-1295]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@54169 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 01:22 AM Revision f8e79c84 (git): * bignum.c (rb_big_hash): make it public function to be available in
- other source files, and remove documentation comment for Bignum#hash.
* bignum.c (Bignum#hash): remove its definition because it is unified
with Object#hash.
* include/ruby/intern.h (rb_big_hash): add a prototype declaration.
* hash...