Activity
From 10/21/2015 to 10/27/2015
10/27/2015
-
11:00 PM Feature #11627 (Assigned): make `nonzero` an alias of `nonzero?` - for historic reasons `nonzero?` returns self or nil. (according to https://bugs.ruby-lang.org/issues/9123)
I like the expectation that `method?` returns true and false.
That `nonzero?` returns only truthy/falsy values would be fine,... -
10:21 PM Bug #11626: fprintf in c extension keep adding memory usage
- guchen.yang@fugawi.com wrote:
> `fprintf` will keep adding memory usage without releasing it.
>
> I was doing it in rails console, not sure if it makes any different. The code like this:
>
> ~~~c
> VALUE leak (VALUE self,... -
09:43 PM Bug #11626 (Rejected): fprintf in c extension keep adding memory usage
- `fprintf` will keep adding memory usage without releasing it.
I was doing it in rails console, not sure if it makes any different. The code like this:
~~~c
VALUE leak (VALUE self, VALUE in) {
char *str = StringValuePtr(in);
... -
09:41 PM Feature #11625: Unlock GVL for SHA1 calculations
- Hi Eric,
Thanks for the feedback. I've updated the patch will your suggestions. Thank you!
sha1.h exports SHA1_Transform, so I was worried about touching that one. -
- tenderlove@ruby-lang.org wrote:
> --- a/ext/digest/digest.c
> +++ b/ext/digest/digest.c
> @@ -624,6 +624,7 @@ rb_digest_base_update(VALUE self, VALUE str)
> TypedData_Get_Struct(self, void, &digest_type, pctx);
>
> Str... -
- I'm trying to calculate many sha1 checksums, but the current sha1 implementation doesn't unlock the GVL, so I can't do it in parallel. I've attached a patch that unlocks the GVL when calculating sha1sums so that I can do them in paralle...
-
09:00 PM Revision e5747f3e (git): * lib/rinda/ring.rb: Linux's SO_REUSEPORT is not for multicast.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52314 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52313 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52312 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52311 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 08:18 PM Revision 75a9a6ee (git): * 2015-10-28
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52310 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- some CI uses ENV['MAKE'] to specify gmake
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52309 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
05:28 PM Bug #11603: Count trace_running for internal event
- Commenting here just to confirm that this change fixes the SEGVs that [this patch](https://github.com/deivid-rodriguez/byebug/pull/160) introduces in byebug's test suite.
-
04:26 PM Feature #11624 (Rejected): ERB deserves its own commenting token
- ## Problem
- ERB is a DSL but commenting out code is not the easy workflow feature in ERB that it is in other languages.
- ERB elements were cleverly designed to look like a special kind of html element so it makes programmers unhapp... -
03:33 PM Bug #11623 (Closed): BUG] Segmentation fault at 0x00000000000000 ruby 2.2.2p95 (2015-04-13 revision 50295) [x86_64-darwin14]
- Ruby crashed right after I interrupted the rspec process.
-
03:23 PM Bug #11492: TracePoint API report extra return for defined method
- Backported into `ruby_2_2` branch at r52308.
-
- * vm.c (hook_before_rewind): prevent kicking :return event while
finishing vm_exec func because invoke_block_from_c() kick a :return
event for bmethods.
[Bug #11492]
* test/ruby/test_settracefunc.rb... -
- Backported into `ruby_2_2` branch at r52307.
-
- * configure.in: check for libunwind.h, which is not available in
very old OS X SDK. [ruby-core:71080] [Bug #11591]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_2@52307 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
02:36 PM Revision 303abc5a (git): test_marshal.rb: test_no_internal_ids
- * test/ruby/test_marshal.rb (test_no_internal_ids): test for
r52304, no internal IDs should be exposed by Marshal.dump.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52306 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Backported into `ruby_2_2` branch at r52305.
-
- * test/drb/test_drb.rb: Run Rinda/DRb tests on localhost. [Fix GH-1027]
patch by voxik.
* test/rinda/test_rinda.rb: ditto
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_2@52305 b2dd03c8-39d4-4d8f-98ff-82... -
02:31 PM Feature #11537: Introduce "Safe navigation operator"
- I don't think `u && .profile && .thumbnails && .large` is acceptable for some reasons:
* it's longer
* unclear
than proposed `.?`. Instead, `&.` or `.&` can be alternatives. But my concern for the idea is `&&` does handle false ... -
12:45 PM Feature #11537: Introduce "Safe navigation operator"
- Rodrigo Rosenfeld Rosas wrote:
> Everyday learning a new hidden feature from Ruby ;)
Me too. Ruby has infinite possibilities.
--
Yusuke Endoh <mame@ruby-lang.org> -
12:31 PM Feature #11537: Introduce "Safe navigation operator"
- Thanks for pointing me that. Everyday learning a new hidden feature from Ruby ;)
-
- "?." is a valid code. Try: `p ?. + "foo"`
--
Yusuke Endoh <mame@ruby-lang.org>
-
- I believe you are referring to implementation details and in this case I can't really opinionate, but with regards to syntax, since "?." is not a valid code, it should be interpreted as "?.+" and "foo" would be parsed as its argument.
... -
- Rodrigo Rosenfeld Rosas wrote:
> ~~~
> ...
Consider a method `+`.
`str.?+"foo"` causes no conflict, but `str ?.+"foo"` will be parsed as `str(?. + "foo")`.
--
Yusuke Endoh <mame@ruby-lang.org> -
- On the other hand, the problem with using "u?.profile" is that "u?" is a valid method, but if Ruby required an space for using the new operator, we could get it working very similarly to Groovy and CoffeeScript:
~~~
u ?.profile ?.thu... -
09:13 AM Feature #11537: Introduce "Safe navigation operator"
- Thomas Sawyer wrote:
> In this way is more an extension of the ternary operator -- the initial dot on the method signals the difference. This should also allow:
> ...
Although I agree that .? is not that intuitive to read, the extended... -
- * defs/id.def: enable anonymous IDs not to expose internal IDs for
frozen-string-literal-debug by Marshal.dump.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52304 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
01:01 PM Revision 6c2afd62 (git): add ticket number [ci skip]
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52303 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52302 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52301 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
09:17 AM Bug #11621: Date.- and Date.+ methods inconsistencies
- Right, that is clear now for me.
Thanks for explaining.
I don't know how to close the bug, so whomever has access, please close -
- If you were use `-w` option, you were warned.
~~~
$ ruby -wc -e 'Date.today -7' -e 'now = Date.today' -e 'p now -7'
-e:1: warning: ambiguous first argument; put parentheses or a space even after `-' operator
-e:3: warning: `-' afte... -
12:51 AM Bug #11621 (Rejected): Date.- and Date.+ methods inconsistencies
- Andrei Balcanasu wrote:
> Good point, but this still does not explain why in some cases ` -7` works:
> ...
If `x` is a reference to a local variable, `x -y` is interpreted as `x - y`.
Otherwise, `x -y` is interpreted as `x(-y)`.
... -
- Yes, user must check if the function is MT-safe. Probably fine
for most library functions...
Maybe releasing GVL can be optional, but I would rather avoid
exposing implementation detail or new APIs... -
- Calling function is really always MT-safe?
The user of fiddle must check whether the function is MT-safe and maintain fine grained lock if it's not MT-safe? -
- * defs/id.def: move internal IDs for frozen-string-literal-debug.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52300 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * error.c (rb_error_frozen_object): use rb_attr_get instead of
rb_ivar_get to get rid of warnings for string objects created
when frozen-string-literal-debug is disabled.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52299 b2dd0... -
- http://ruby-mswin.cloudapp.net/vc10-x64/ruby-trunk/log/20151023T062322Z.log.html.gz
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52298 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Applied at r52140.
-
- Applied in changeset r52297.
----------
logger.rb: end of week should be Saturday
* lib/logger.rb (Logger::Period#previous_period_end): as weekly
rotation shifts the log file on Sundays, the end date of the
previous period should b... -
- logger.rbで weekly rotation を指定したとき、日曜日での書き込みでログファイルが切り替えられますが、古いログファイル名に着く日付が前週の金曜日のものになっていますが、土曜日のものになるべきではないでしょうか。
以下のコードを実行すると、一回目の書き込み(`"2015-12-19 12:34:56 UTC hello-1"`)は log.20151218 に入っていて、最後に書き込まれた時刻よりも古いファイル名になっています。
~~~rub... -
- * lib/logger.rb (Logger::Period#previous_period_end): as weekly
rotation shifts the log file on Sundays, the end date of the
previous period should be Saturdays. fix r45072.
[ruby-dev:49314] [Bug #11622]
git-svn-id: svn+ssh://ci.... -
- http://rubyci.s3.amazonaws.com/unstable11s/ruby-trunk/log/20151027T043311Z.log.html.gz
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52296 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
04:21 AM Bug #11544 (Rejected): ArgumentError: Enumerable#to_set(klass, *args, &block) if specify *args.
- This is not a bug. Extra arguments are reserved for Set's subclasses.
-
-
- * proc.c (rb_block_clear_env_self): removed as deprecated at
r52129.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52295 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
-
03:05 AM Bug #11572: Urnary operator causing references to unreachable objects in 2.1.x ?
- r45576
-
02:34 AM Bug #11572: Urnary operator causing references to unreachable objects in 2.1.x ?
I can confirm that this happens in the latest 2.1.x tag and that applying 2f3b28c682fe3010ed3b8803199616c12b52512d was able to fix this issue.-
- Applied in changeset r52293.
----------
logger.rb: fix weekly rotation
* lib/logger.rb (Logger::Period#next_rotate_time): get rid of
adding to mday not to exceed the days of the month.
[ruby-core:71185] [Bug #11620] - 03:01 AM Revision 6b78bfcf (git): * 2015-10-27
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52294 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * lib/logger.rb (Logger::Period#next_rotate_time): get rid of
adding to mday not to exceed the days of the month.
[ruby-core:71185] [Bug #11620]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52293 b2dd03c8-39d4-4d8f-98ff-823fe69... -
- Hello, Lingaraj.
It seems that the response contains invalid byte-stream or the content encoding was wrongly detected or so.
For more investigation, please show us the sample code to reproduce this error.
10/26/2015
-
09:27 PM Feature #11607: [PATCH] fiddle: release GVL for ffi_call
- Nevermind. I did misinterpret your code. I'm ok either.
-
- KOSAKI Motohiro <kosaki.motohiro@gmail.com> wrote:
> On Tue, Oct 20, 2015 at 6:28 PM, <normalperson@yhbt.net> wrote:
> > Issue #11607 has been updated by Eric Wong.
> >
> > File fiddle-release-GVL-for-ffi_call-v2.patch added
> >
... -
- On Tue, Oct 20, 2015 at 6:28 PM, <normalperson@yhbt.net> wrote:
> Issue #11607 has been updated by Eric Wong.
>
> File fiddle-release-GVL-for-ffi_call-v2.patch added
>
> v2 fixes a warning I did not notice before, interdiff:
> ~~... -
05:59 PM Bug #11621: Date.- and Date.+ methods inconsistencies
- Those examples are not ambiguous. `Date.today -7` *is* ambiguous because `Date.today` takes an optional argument specifying, essentially, which calendar to use‒one of `ITALY`, `ENGLAND`, `JULIAN`, or `GREGORIAN`, if you're using the meth...
-
- Good point, but this still does not explain why in some cases ` -7` works:
```ruby
now = Date.today
=> #<Date: 2015-10-26 ((2457322j,0s,0n),+0s,2299161j)>
now -7
=> #<Date: 2015-10-19 ((2457315j,0s,0n),+0s,2299161j)>
Date.new(2... -
- This has nothing to do with `Date` in particular; observe:
```ruby
def foo n = nil
n || 48
end
p foo-6 # => 42
p foo -6 # => -6
p foo - 6 # => 42
```
This is simply a consequence of parentheses for method invocation b... -
- I noticed today some inconsistencies when using `-` and `+` methods of the `Date` class, that makes the whitespace relevant:
~~~
irb(main):001:0> require 'date'
=> true
irb(main):002:0> Date.today - 7
=> #<Date: 2015-10-19 ((24573... -
03:41 PM Bug #11620: Logger throws "ArgumentError: argument out of range" with weekly rotation when switch to standard time (DST) and last day of the week is 1st of next month
- Local timezone is CET (Europe/Germany/Berlin)
-
- What timezone are you using?
-
- We discovered a bug within the Ruby Logger. Having 'weekly' as Argument for shift_age in this year (2015) when returned from summer time to standard time (DST).
Creating a new Logger results in throwing a "ArgumentError: argument out of... -
- * lib/logger.rb ({next,previous}_rotate_time): dispatch by exact
matching shift_age instead of regexp matching.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52292 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * lib/logger.rb: freeze constant strings and array.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52291 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Yehuda Katz wrote:
> As shorthand for:
> ...
Actually, it would be a shorthand for something like:
~~~
u && (tmp1 = u.profile) && (tmp2 = tmp1.thumbnails) && tmp2.large
~~~
But I still prefer the syntax implemented in trunk as ... -
- What does sole `.profile` do?
If it requires `&&` just before it, a space should not be between them. -
12:25 PM Feature #11537: Introduce "Safe navigation operator"
- Yukihiro Matsumoto wrote:
> I like the idea. My remaining concern is ".?" is too similar to "?." which is chosen by other languages.
> ...
I agree with this concern. I also agree with the idea of trying to make it more like a tradition... -
05:10 AM Feature #11537: Introduce "Safe navigation operator"
- Yukihiro Matsumoto wrote:
> I like the idea. My remaining concern is ".?" is too similar to "?." which is chosen by other languages.
> ...
Maybe there is a better syntax by requiring a space:
u ? .profile ? .thumbnails ? .larg... -
- * test/ruby/test_module.rb (test_method_defined): Add test cases
for `public/protected/private _method_defined?`
These methods accept string as argument, so add string argument
cases. [Fix GH-1067]
git-svn-id: svn+ssh://ci.ruby-l... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52289 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * lib/racc/rdoc/grammar.en.rdoc: Grammatical errors fixed.
[Fix GH-1070]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52288 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
01:10 PM Misc #11548 (Closed): FileUtils#remove_tailing_slash is a poor method name
-
09:38 AM Revision 9b425061 (git): * vm_method.c(rb_method_entry_make):
- [DOC] [ci skip] Remove a needless space from comment
[Fixes GH-1069] Patch by @yui-knk
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52287 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52286 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- [Misc #11548]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52285 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * parse.y (call_op, call_op2): fix values on ripper. [Feature #11537]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52284 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * ChangeLog: remove duplicated entry, caused by a conflict.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52283 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * parse.y (call_op2): separate from call_op and also allow "::",
while dot_or_colon should not allow ".?". [Feature #11537]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52282 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
10/25/2015
- 04:08 PM Revision 42a0bf55 (git): * 2015-10-26
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52281 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 04:07 PM Revision f2d679c7 (git): * thread_pthread.c: fix compile erros when
- USE_SLEEPY_TIMER_THREAD is disabled.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52280 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Applied in changeset r52279.
----------
io.c: fix typo [ci skip]
* io.c (io_readpartial): fix typo, "later" to "latter".
[ruby-core:71181] [Bug #11619] -
06:27 AM Bug #11619 (Closed): IO documentation typo
- IO documentation has the phrase "The later means that readpartial...".
typo: later -> latter -
- * io.c (io_readpartial): fix typo, "later" to "latter".
[ruby-core:71181] [Bug #11619]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52279 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * test/ruby/test_io.rb (test_dup_many, test_set_lineno): use
assert_separately for more descriptive messages.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52278 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * test/ruby/test_io.rb (test_dup_many): limit FD only if possible.
* test/ruby/test_process.rb (assert_fail_too_long_path): fix the
condition for platform specific feature
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52277 b2dd0... -
- * symbol.c (op_tbl): add DOTQ for ripper. [Feature #11537]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52276 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * ext: use rb_check_arity and rb_error_arity to raise
ArgumentError. [Feature #9025]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52275 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * error.c (ArgumentError): [DOC] update document following
[Feature #9025]
* proc.c (proc_call, proc_curry): [DOC] ditto.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52274 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
10/24/2015
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52273 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 05:36 PM Revision a5301722 (git): * 2015-10-25
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52272 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52271 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
03:51 PM Feature #11599: Dump entries of hash in ObjectSpace
- What is the status of the patch? Is this ok? something to fix?
-
- I am not going to add safe navigation for aref and aset.
Maybe you can use `a.?[](x)` (method call of an operator).
Matz.
-
07:21 AM Bug #11618 (Rejected): Safe call syntax with aref or aset is
- This test pass
```ruby
# ruby -v: ruby 2.3.0dev (2015-10-24 trunk 52128) [x86_64-darwin14]
# test/ruby/test_call.rb
def test_safe_call_aref_aset
s = Struct.new(:x, :y)
o = s.new({a: 10})
assert_equal(10, o.x.?s... -
- [fix GH-984] Patch by @kallisti5
* ext/socket/getaddrinfo.c: ditto.
* ext/socket/getnameinfo.c: ditto.
* ext/socket/rubysocket.h: ditto.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52270 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * test/fileutils/test_fileutils.rb (test_uptodate): relax error
message format. [Feature #9025], [ruby-core:71178] [Bug #11617]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52269 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Reverted r45640 at r52267. Hmm...
-
- Applied in changeset r52267.
----------
* lib/mkmf.rb: Revert r45640 because it may lead to link
with different libruby. [Bug #9760] - 12:11 PM Revision 623403fa (git): * remove trailing spaces.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52268 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- with different libruby. [Bug #9760]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52267 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * vm_method.c (rb_undef): remove code almost common to proc.c.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52266 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Applied in changeset r52265.
----------
relax error message format
* bootstraptest/test_method.rb: relax error message format.
* test/ruby/test_arity.rb (err_mess): ditto.
[Feature #9025], [ruby-core:71178] [Bug #11617] -
03:49 AM Bug #11617 (Closed): Fix tests for Feature 9025
- I tried to fix the tests for this, too, but I didn't find them anywhere, sorry. Or just tell me where they are, so that I can fix them
-
- * bootstraptest/test_method.rb: relax error message format.
* test/ruby/test_arity.rb (err_mess): ditto.
[Feature #9025], [ruby-core:71178] [Bug #11617]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52265 b2dd03c8-39d4-4d8f-98ff-8... -
- Applied in changeset r52264.
----------
vm_insnhelper.c: improved error message for "wrong number
of arguments", distinguishing given and expected argument
numbers clearly. [Feature #9025] -
- of arguments", distinguishing given and expected argument
numbers clearly. [Feature #9025]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52264 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- vm_call_handler.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52263 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
10/23/2015
-
- * common.mk (incs): remove extra slash before
vm_call_iseq_optimized.inc. as nmake vpath syntax includes a
separator, don't append it.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52262 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * common.mk (incs): generate vm_call_iseq_optimized.inc too.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52261 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * parse.y (parser_magic_comment): intern canonical name.
InstructionSequence.compile_options are case-sensitive while
pragma names are case-insensitive.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52260 b2dd03c8-39d4-4d8f-98ff... -
- Applied in changeset r52259.
----------
forwardable.rb: full qualify names
* lib/forwardable.rb (def_instance_delegator, def_single_delegator):
match backtraces against ::Forwardable in case the target class
is a subclass of BasicO... -
- I think that backtrace cleanup should be removed as well as delegate.rb, [Bug #11461].
-
09:17 PM Bug #11616 (Closed): Forwardable fails to adjust backtrace when Forwardable is not reachable from the target class
- as follows:
```
$ cat t.rb
require "forwardable"
class Foo < BasicObject
extend ::Forwardable
def_delegator :bar, :baz
end
Foo.new.baz
$ ruby t.rb
/Users/guest/.rbenv/versions/trunk/lib/ruby/2.3.0/forwardable.rb:1... -
- * lib/forwardable.rb (def_instance_delegator, def_single_delegator):
match backtraces against ::Forwardable in case the target class
is a subclass of BasicObject and does not include Kernel.
[ruby-core:71176] [Bug #11616]
git-svn-... -
07:13 PM Revision 92d5da52 (git): * iseq.c (make_compile_option_value): include frozen_string_literal*
- in a made option value.
* vm_opts.h: forgot to add OPT_FROZEN_STRING_LITERAL_DEBUG
at last commit.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52258 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- If this option is enabled, the modify error will be:
can't modify frozen String (RuntimeError) =>
can't modify frozen String, created at test.rb:3 (RuntimeError)
* iseq.h: add compile option frozen_string_literal_debug.
* compi... - 05:53 PM Revision 31f21aed (git): * properties.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52256 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 05:53 PM Revision 593cf11a (git): * remove trailing spaces.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52255 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- vm_call_iseq_setup_normal_0start() is simple, however it has
some loops/conditions depends on ISeq::param.size and
ISeq::local_size (in vm_push_frame(), inlined into this function).
There are many simple methods which has a few pa... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52253 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- from vm_insnhelper.h to vm_core.h.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52252 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 04:53 PM Revision 1b5dce5a (git): * NEWS: [DOC] In the new safe call syntax, arguments are evaluated
- only if a call is made.
* doc/syntax/calling_methods.rdoc: Fix a typo.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52251 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Applied in changeset r52249.
----------
* lib/forwardable (def_instance_delegator, def_single_delegator):
rescue ::Exception instead of Exception in case Exception is
defined under the target class.
[ruby-core:71175] [Ruby trunk -... -
- Forwardable fails to adjust backtrace when Exception is defined in the target class as follows:
```
$ cat t.rb
require "forwardable"
class Foo
extend Forwardable
def_delegator :bar, :baz
class Exception
end
end
... - 03:41 PM Revision 4daa1cf7 (git): * 2015-10-24
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52250 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- rescue ::Exception instead of Exception in case Exception is
defined under the target class.
[ruby-core:71175] [Ruby trunk - Bug #11615]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52249 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * error.c (name_err_mesg_to_str): use fake string as rb_str_format
does not require T_STRING to be cannonical VALUE.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52248 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * error.c (name_err_mesg_to_str): separate class names from the
receiver description.
* vm_eval.c (make_no_method_exception, raise_method_missing): add
format specifiers for class names.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/t... -
- sorry i missed #1 comment written by wanabe-san.
if it can be reproduced yet, please reopen this ticket.
-
09:36 AM Bug #7758: Ruby on Windows crashes when active codepage is codepage 65001 and outputting unicode character
- Has this patch been applied?
Because I'm getting pretty much the same crash on 32bit 2.1.7p400 running on Win7 64x and I can reproduce. -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52246 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- when irb.rb loaded. It's affected to IDE such as Jetbrain.
[fix GH-864] Patch by @os97673
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52245 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Applied in changeset r52244.
----------
* lib/ipaddr.rb, test/test_ipaddr.rb: Reject invalid address contained
EOL string. Patch by @kachick [fix GH-942][Bug #11513] -
- EOL string. Patch by @kachick [fix GH-942][Bug #11513]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52244 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52243 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * test/ruby/test_string.rb: indent. [fix GH-975]
[ci skip] These patches are contributed from @yui-knk
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52242 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- with `gsub` method signature.
[ci skip][fix GH-1023] Patch by @danielevans
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52241 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52240 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- navigation operator.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52239 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * test_call.rb (test_safe_call): Add test cases for safe
navigation operator assignment. [Fix GH-1064]
Validate:
* can assign an attribute which is `nil`
* can "or assign" an attribute which is `nil`
git-svn-id: svn+ssh://ci.ru... -
03:58 AM Feature #11537: Introduce "Safe navigation operator"
- Thanks for the thoughtful replies guys! That definitely helps clarify the `.?` operator
Matthew Kerwin wrote:
> On 23/10/2015 2:46 AM, <merch-redmine@jeremyevans.net> wrote:
> ...
-
- * compile.c (iseq_peephole_optimize): optimize lengthy safe
navigation method chain. [Feature #11537]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52237 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 02:09 AM Revision 4f9ded5c (git): * remove trailing spaces.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52236 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- indentation to avoid a warning when the command line option -w of
ruby is specified.
* lib/matrix/eigenvalue_decomposition.rb (hessenberg_to_real_schur):
change the name of a block parameter to avoid a warning when the
command lin... -
- * compile.c (iseq_compile_each): support safe navigation of simple
attribute assignment. [Feature #11537]
* parse.y (mlhs_node, lhs, attrset_gen): ditto. keep mid
non-attrset as the sign of safe navigation.
git-svn-id: svn+ssh://c... -
- * compile.c (compile_massign_lhs): just insert topn insn instead
of popping and adding. [Feature #11537]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52233 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
10/22/2015
-
11:48 PM Feature #9025: Clarify the error message when calling a method with the wrong number of arguments
- On 23 October 2015 at 07:51, <duerst@it.aoyama.ac.jp> wrote:
> Issue #9025 has been updated by Martin Dürst.
>
> Matthew Kerwin wrote:
> > duerst (Martin Dürst) wrote:
>
> > > Ruby is all about making it easier for the programme... -
- Matthew Kerwin wrote:
> duerst (Martin Dürst) wrote:
> ...
It might have been clearer for me to write "Even the smallest reduction in the amount of debugging is worth it when it can be achieved by tweaking the error message."
Anyw... -
09:11 AM Feature #9025: Clarify the error message when calling a method with the wrong number of arguments
- "(expected: 1, provided: 0)" is excellent. This is a big usability issue. Python's message is similar, and includes the function name:
`TypeError: fun() takes exactly 1 argument (0 given)`
> I agree that someone not familiar with m... -
- * NEWS: fix wording, "Active Support" has a space in between the
words, not ActiveSupport.
https://github.com/ruby/ruby/commit/a356fe1#commitcomment-13936198
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52232 b2dd03c8-39d4-4d8f... - 10:25 PM Revision d4fd2fb0 (git): test/io/wait/test_io_wait.rb (test_wait_eof): test return value
- I wrote some code which relies on this nowadays, but Ruby <=2.2
and earlier behaved differently...
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52231 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- On 23/10/2015 2:46 AM, <merch-redmine@jeremyevans.net> wrote:
>
> Issue #11537 has been updated by Jeremy Evans.
>
>
> Tom Reznick wrote:
> > Hi,
> >
> > I think we may have found some unexpected behavior with the `.?`
operator... -
04:45 PM Feature #11537: Introduce "Safe navigation operator"
- Tom Reznick wrote:
> Hi,
> ...
I think it's completely expected that `nil.?kind_of?(NilClass)` returns `nil` and not `true`. The whole point of `.?` is to return `nil` without calling the method if the receiver is `nil`. I'm not sure... -
04:34 PM Feature #11537: Introduce "Safe navigation operator"
- I know this is already decided and the commit is out there, but since you are adding new syntax and a new feature to the language, I suggest you reconsider https://bugs.ruby-lang.org/issues/9076
With that change, instead of adding spe... -
- Hi,
I think we may have found some unexpected behavior with the `.?` operator.
If I call the following:
s = Struct.new(:x)
o = s.new()
o.x #=> nil
o.x.nil? #=> true
o.x.?nil? #=> nil
o.x.kind_of?(Nil... -
- Applied in changeset r52214.
----------
Safe navigation operator
* compile.c (iseq_peephole_optimize): peephole optimization for
branchnil jumps.
* compile.c (iseq_compile_each): generate save navigation operator
code.
* insns.def ... -
- ref: [ruby-core:71142] [ruby-core:71151]
I'm not sure if using rb_class_name in object.c is enough to prevent
breaking all existing code. Until this is sufficiently reviewed,
I have no plans to commit this patch at the moment.
v... - 08:36 PM Revision d737d576 (git): NEWS: fix typo [ci skip]
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52230 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
05:55 PM Feature #11181: Add a line directive to Ruby
- The pull request is now at https://github.com/ruby/ruby/pull/911
-
- Applied in changeset r52229.
----------
Add rlimit_nproc to avoid to create many process [Bug #11613] -
- At least on FreeBSD, spawn("echo|echo|echo|echo|echo|echo|echo| ...20000 times") success and create 20000 zombie processes.
To prevent this you can add rlimit_nproc: 1 because it tests sh itself, don't test spawned echos.
```diff
di... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52229 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Applied in changeset r52227.
----------
* ext/openssl/ossl_ssl.c (ssl_npn_select_cb): explicitly raise error
in ext/openssl instead of OpenSSL itself because LibreSSL
silently truncate the selected protocol name by casting the lengt... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52228 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- in ext/openssl instead of OpenSSL itself because LibreSSL
silently truncate the selected protocol name by casting the length
from int to unsigned char. [Bug #11369]
Patch by Jeremy Evans <merch-redmine@jeremyevans.net>
git-svn-id:... -
- a warning when the command line option -w of ruby is specified.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52226 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * string.c (rb_str_tr): [DOC] Escape backslash in String#tr
documentation. [Fix GH-1063]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52225 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * array.c (rb_ary_collect): [DOC] Fix space of code example of
Array#map. [Fix GH-1062]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52224 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 03:00 PM Revision 439c3e23 (git): * 2015-10-23
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52223 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52222 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * common.mk (showflags): do not show flags from recursive make.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52221 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Yes, it's your bug.
-
01:19 PM Bug #11604: Ruby's interpreting hash symbol keys as parts of Ruby syntax
- That is true but IMHO it should still be considered as a bug.
-
- Maciej Mensfeld wrote:
> Cannot initialize hashes with some Ruby reserved keywords like: while, until, if, unless, do. Can with other like class, end, elsif, super. Don't really get why
These syntax errors are not caused by key names... -
- * tool/generic_erb.rb: use VT100 sequence if tput does not work.
* tool/ifchange: ditto and add --color option.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52220 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Applied in changeset r52219.
----------
ifchange: ignore error
* tool/ifchange: do not exit by -e even if tput failed.
[ruby-core:71143] [Bug #11611] -
- Reopened, because I still get an error, as follows:
~~~
$ make up; make install-nodoc
Updating '.':
At revision 52218.
make[1]: Entering directory '/cygdrive/c/Data/ruby-public'
uncommon.mk:853: recipe for target '.revision.time'... -
- Applied in changeset r52215.
----------
generic_erb.rb: ignore error
* tool/generic_erb.rb: ignore error that tput is not found.
[ruby-core:71143] [Bug #11611] -
- When trying to compile Ruby trunk with
`make up; make install-nodoc`
I get the following errors:
~~~
$ make up; make install-nodoc
Updating '.':
At revision 52214.
make[1]: Entering directory '/cygdrive/c/Data/ruby-public'
unco... -
- * tool/ifchange: do not exit by -e even if tput failed.
[ruby-core:71143] [Bug #11611]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52219 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Technorama Ltd. wrote:
> The proposed Dir api must provide a way to open both files and directories in order to be useful.
> ...
I prefer the following style:
d1 = Dir.open("d1") #=> a Dir
d2 = Dir.openat(d1, "subdir") #=> ... -
- I've added a new argument `timeout` for Net::IMAP#idle to solve this problem.
For example, the following code checks the connection for each 60 seconds.
loop do
imap.idle(60) do |res|
...
end
end
-
- Applied in changeset r52216.
----------
* lib/net/imap (idle): add a new argument timeout for keep-alive.
[ruby-core:63693] [Bug #10031] -
- Applied in changeset r52218.
----------
Kernel#loop returns the result value of a finished iterator
* vm_eval.c (rb_f_loop): When a loop is stopped by a StopIteration
exception, return what the enumerator has returned instead of
ni... - 09:58 AM Revision f4c48717 (git): Kernel#loop returns the result value of a finished iterator
- * vm_eval.c (rb_f_loop): When a loop is stopped by a StopIteration
exception, return what the enumerator has returned instead of
nil. [ruby-core:71133] [Feature #11498]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52218 b2dd03c... - 09:32 AM Revision 53d6e605 (git): * remove trailing spaces.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52217 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- [ruby-core:63693] [Bug #10031]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52216 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- See also "Clarify the error message when calling a method with the wrong number of arguments", https://bugs.ruby-lang.org/issues/9025
-
- Koichi Sasada wrote:
>
> ...
Again, thanks for posting this.
I believe that some small changes can make Ruby error messages more helpful. E.g., I've just begun working on a Pull Request to change the rb_eArgError messages from e.g... -
- Thanks for starting this discussion!
> And some requests.
> ...
+1 for this. It's how Python displays backtraces. That's a good precedent to follow. I find that senior devs (like myself) and brand new developers (like my students) of... -
- * tool/generic_erb.rb: ignore error that tput is not found.
[ruby-core:71143] [Bug #11611]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52215 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- The default mode of Net::FTP is active for historical reasons, but it should be changed to passive
because active data connections might be blocked by a local firewall.
Passive data connections might also be blocked by a firewall, but ... -
- * compile.c (iseq_peephole_optimize): peephole optimization for
branchnil jumps.
* compile.c (iseq_compile_each): generate save navigation operator
code.
* insns.def (branchnil): new opcode to pop the tos and branch if
it is nil.
*... -
- * tool/generic_erb.rb: highlight result messages too.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52213 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Applied in changeset r52212.
----------
dir.c: glob brace expansion [Fix GH-1061]
* dir.c (ruby_brace_expand): glob brace expansion edge case fix.
When there are closing braces '}' before a open brace '{' it
must be ignored and con... -
12:56 AM Bug #11609 (Closed): Dir.glob brace expansion possible edge case
- I found an edge case of Dir.glob that don't work as i was expecting, and as my shell works.
It may happens on every version. I discovered it after spelunking through: ruby_brace_expand function on dir.c (https://github.com/ruby/ruby... -
- * dir.c (ruby_brace_expand): glob brace expansion edge case fix.
When there are closing braces '}' before a open brace '{' it
must be ignored and considered as literal.
[ruby-core:71138] [Bug #11609]
git-svn-id: svn+ssh://ci.ruby-... -
- Applied in changeset r52211.
----------
io.c: check ARGV element type
* io.c (argf_next_argv): check ARGV element type, and try
conversion if necessary. [ruby-core:71140] [Bug #11610] -
01:17 AM Bug #11610 (Closed): Segfault when assigning to ARGV
- This causes a segfault:
~~~
seq 3 | ruby -ne 'ARGV[$.]=$_'
~~~
These similar ones don't:
~~~
seq 3 | ruby -e 'ARGV[0] = "abc"'
seq 3 | ruby -ne 'BEGIN{a=[]}; a[$.]=$_'
~~~
Here is the output:
~~~
-e:1: [BUG] Segmenta... -
- * io.c (argf_next_argv): check ARGV element type, and try
conversion if necessary. [ruby-core:71140] [Bug #11610]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52211 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 02:21 AM Revision 23419d85 (git): * 2015-10-22
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52210 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- gettextfile.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52209 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
10/21/2015
-
- Marc-Andre Lafortune wrote:
> Just to be clear, this will check only for `nil`, right?
I think so, and my implementation too. -
07:29 PM Feature #11537: Introduce "Safe navigation operator"
- Great!
Just to be clear, this will check only for `nil`, right?
nil.?foo # => nil
false.?foo # => NoMethodError -
- Great news! Thanks! Is this going to be released on next minor or on Ruby 3 only?
-
- Oh, I made mistake. We will introduce `.?` (typo fixed already).
-
- In several languages (Groovy Swift etc.), use `?.` but we cannot use it in Ruby, because `foo?` is a valid method name.
Thus `.?` is a reasonable alternative for Ruby, I think.
Accepted.
Matz.
-
- matz@ruby-lang.org wrote:
> > I hate autoload. autoload is one of things I regret. I'm not positive about enhancing something I hate.
> -- matz in https://speakerdeck.com/skade/the-dark-side-of-matz-1
Would you like autoload if Rub... -
- > I hate autoload. autoload is one of things I regret. I'm not positive about enhancing something I hate.
-- matz in https://speakerdeck.com/skade/the-dark-side-of-matz-1
How about using `const_missing`?
Matz. -
- I like the idea. If anything bad happens by the patch, I'd love to accept this.
Matz.
-
- Applied in changeset r52208.
----------
parse.y: magic comment w/o indicators
* parse.y (parser_magic_comment): allow a sole magic comment without
indicators, neither other non-space comments. [Feature #8976] -
- Benoit Daloze wrote:
> Yusuke Endoh wrote:
> ...
+1
This issue should be discussed at the developers meeting today, and Matz should desicde whether `-*-` should be required. -
- * parse.y (parser_magic_comment): allow a sole magic comment without
indicators, neither other non-space comments. [Feature #8976]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52208 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- We will introduce `.?` #11537 which address this proposal.
Matz. -
- * aclocal.m4 (_COLORIZE_RESULT_PREPARE): force tty for reconfig.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52207 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 12:36 AM Revision 21494036 (git): * 2015-10-21
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52206 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * ext/date/extconf.rb: add strict warning flags same as ruby
itself for C99 option.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52205 b2dd03c8-39d4-4d8f-98ff-823fe69b080e