Activity
From 10/15/2015 to 10/21/2015
10/21/2015
-
11:33 PM Feature #11537: Introduce "Safe navigation operator"
- Marc-Andre Lafortune wrote:
> Just to be clear, this will check only for `nil`, right?
I think so, and my implementation too. -
07:29 PM Feature #11537: Introduce "Safe navigation operator"
- Great!
Just to be clear, this will check only for `nil`, right?
nil.?foo # => nil
false.?foo # => NoMethodError -
10:20 AM Feature #11537: Introduce "Safe navigation operator"
- Great news! Thanks! Is this going to be released on next minor or on Ruby 3 only?
-
08:05 AM Feature #11537: Introduce "Safe navigation operator"
- Oh, I made mistake. We will introduce `.?` (typo fixed already).
-
- In several languages (Groovy Swift etc.), use `?.` but we cannot use it in Ruby, because `foo?` is a valid method name.
Thus `.?` is a reasonable alternative for Ruby, I think.
Accepted.
Matz.
-
08:38 PM Feature #11415: autoload with a Proc
- matz@ruby-lang.org wrote:
> > I hate autoload. autoload is one of things I regret. I'm not positive about enhancing something I hate.
> -- matz in https://speakerdeck.com/skade/the-dark-side-of-matz-1
Would you like autoload if Rub... -
- > I hate autoload. autoload is one of things I regret. I'm not positive about enhancing something I hate.
-- matz in https://speakerdeck.com/skade/the-dark-side-of-matz-1
How about using `const_missing`?
Matz. -
- I like the idea. If anything bad happens by the patch, I'd love to accept this.
Matz.
-
- Applied in changeset r52208.
----------
parse.y: magic comment w/o indicators
* parse.y (parser_magic_comment): allow a sole magic comment without
indicators, neither other non-space comments. [Feature #8976] -
02:57 AM Feature #8976 (Assigned): file-scope freeze_string directive
- Benoit Daloze wrote:
> Yusuke Endoh wrote:
> ...
+1
This issue should be discussed at the developers meeting today, and Matz should desicde whether `-*-` should be required. -
- * parse.y (parser_magic_comment): allow a sole magic comment without
indicators, neither other non-space comments. [Feature #8976]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52208 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- We will introduce `.?` #11537 which address this proposal.
Matz. -
- * aclocal.m4 (_COLORIZE_RESULT_PREPARE): force tty for reconfig.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52207 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 12:36 AM Revision 21494036 (git): * 2015-10-21
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52206 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * ext/date/extconf.rb: add strict warning flags same as ruby
itself for C99 option.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52205 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
10/20/2015
-
- v2 fixes a warning I did not notice before, interdiff:
~~~
--- a/ext/fiddle/closure.c
+++ b/ext/fiddle/closure.c
@@ -64,7 +64,7 @@ struct callback_args {
void *ctx;
};
-static void
+static void *
with_gvl_callback(void... -
05:14 PM Bug #11598: Ruby crash when I run calabash-android
- Hello, clint.
Could you provide full error messages in your command prompt?
-
- Applied in changeset r52204.
----------
test -t
* aclocal.m4, tool/ifchange: make the fd explict.
[ruby-dev:49311] [Bug #11608] -
01:30 PM Bug #11608 (Closed): test -t without fd
- r52202 で fd 指定なしの test -t を使っていますが、
http://pubs.opengroup.org/onlinepubs/9699919799/utilities/test.html
の RATIONALE で
> The -t file_descriptor primary is shown with a mandatory argument because the grammar is ambiguous if it can be ... -
- * aclocal.m4, tool/ifchange: make the fd explict.
[ruby-dev:49311] [Bug #11608]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52204 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
12:42 PM Bug #11602: Compile error on CentOS: Segmentation fault after "linking miniruby"
- Some additional information. Version 2.2.3 didn't compiled with the same error message. But Ruby from the stable snapshot (https://ftp.ruby-lang.org/pub/ruby/stable-snapshot.tar.gz) compiled successfully:
stable-snapshot# make
...
P... -
- ruby-2.1.7 # gdb miniruby core.17835
GNU gdb (GDB) CentOS (7.0.1-45.el5.centos)
Copyright (C) 2009 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>
This is free software: yo... -
- (gdb) backtrace
#0 0x00002b739984f0bb in reserve_stack (limit=0x7fff44a7b0c0 <Address 0x7fff44a7b0c0 out of bounds>, size=10481408) at thread_pthread.c:685
#1 0x00002b739984f134 in ruby_init_stack (addr=0x7fff45479258) at thread_pthr... -
10:07 AM Bug #11603: Count trace_running for internal event
- assigning ko1 at here too, because he has self-assigned at GitHub PR
-
- * include/ruby/missing.h (bytesequence4_or_float): define by
configured result.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52203 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * aclocal.m4 (COLORIZE_RESULT): highlight result messages.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52202 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Totally agree. I hope you'll find my fix acceptable.
Thanks for creating the issue -
- Applied in changeset r52201.
----------
* lib/prime.rb: Add basic argument checking to Prime.prime?
[Bug #11606] - 03:19 AM Revision 48773664 (git): * lib/prime.rb: Add basic argument checking to Prime.prime?
- [Bug #11606]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52201 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Applied in changeset r52200.
----------
* lib/prime.rb: Optimize Integer#prime?
Patch by Nick Slocum [Bug #10354] - 03:18 AM Revision 8744d516 (git): * lib/prime.rb: Optimize Integer#prime?
- Patch by Nick Slocum [Bug #10354]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52200 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
10/19/2015
- 11:24 PM Revision 49efa668 (git): * configure.in: pthread_getattr_np is broken on AIX.
- More specifically, the stack address and size returned are
not correct.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52199 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Some external functions I wish to call may take a long time
and unnecessarily block other threads. This may lead to performance
regressions for fast functions as releasing/acquiring the GVL is not
cheap, but can improve performance f... -
09:46 PM Bug #11606 (Closed): Prime.prime? should throw error on invalid inputs
- irb(main):003:0> Prime.prime?(1,3)
=> false
irb(main):004:0> Prime.prime?(1.3)
=> false
irb(main):005:0> Prime.prime?(20.3)
=> true
Prime.prime? converts floating point numbers to integer to determine if they are prime. A prime ... - 08:56 PM Revision cfa2f954 (git): ext/fiddle/closure.c (callback): static function
- The `callback' function is not used outside of closure.c and
should not be able to cause namespace conflicts in compilers
without visibility pragmas.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52198 b2dd03c8-39d4-4d8f-98ff-823fe6... -
06:49 PM Feature #11599: Dump entries of hash in ObjectSpace
- Yosi Attias wrote:
> Nobuyoshi Nakada wrote:
> ...
Hi,
I have added to reflect the new logic:
* If the key/value are special consts - I write the "to_s" value of them (:a => "a", 1 => "1")
* If the key/value are not special consts -... -
- Nobuyoshi Nakada wrote:
> That distinction makes no sense.
> ...
Oh.. I understand what you are saying, I will fix that!
Just to make sure I understand your position, you say this distinction is not needed, and in case of this hash:
... -
- That distinction makes no sense.
Non-special-const objects (including `String`) are always shown in pointer reference form.
That `"0x007f8f3c8baf88"` is the content of a string but not the pointer, then it never appears with your patch.
-
- Nobuyoshi Nakada wrote:
> Yosi Attias wrote:
> ...
Yes, but how can you distinguish between string value which is address or address to other ruby object:
`h = {a: "0x007f8f3c8baf88"}` to `h = {a: {b: 1}}`
-
- Yosi Attias wrote:
> and to make sure there are no confusion some one did some like this:
> ...
I can't get your point here.
`{"key":":a","value":"0x007f8f3c8baf88"}` seems clear enough to me.
-
- Oh, thanks. I had no idea on how to try this. I've tried a(, 'required'). Actually, I was reading a method like a(req1, opt='opt', req2) and thought it would be impossible to use the default value, but now I understand how optional argum...
-
05:12 PM Feature #11605 (Rejected): Ruby should raise on def(a='a', b) [optional param that can't be used]
- Why did not you try actually?
~~~
irb(main):001:0> def a(opt='opt',required)
irb(main):002:1> p [opt, required]
irb(main):003:1> end
=> :a
irb(main):004:0> a('required')
["opt", "required"]
=> ["opt", "required"]
~~~ -
- Why doesn't Ruby complain when defining a method like this?
~~~
def a(opt='opt', required)
end
~~~
I believe it's impossible to call method 'a' passing only required, while sticking to the default value for 'opt', right? So, why... -
- * configure.in: check INFINITY and NAN without an option for C99
so that rb_infinity and rb_nan are respectively available
regardless that option if they may be used.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52197 b2dd03c8-... -
- * ext/socket/raddrinfo.c (rsock_fd_family): suppress a
sign-compare warning.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52196 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 03:55 PM Revision 61d51d9d (git): * 2015-10-20
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52195 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52194 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52193 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
03:35 PM Bug #11604 (Rejected): Ruby's interpreting hash symbol keys as parts of Ruby syntax
- Cannot initialize hashes with some Ruby reserved keywords like: while, until, if, unless, do. Can with other like class, end, elsif, super. Don't really get why
~~~
{ while: 1 } # Will fail
# error.rb:3: syntax error, unexpected ':'... -
02:47 PM Bug #11603 (Closed): Count trace_running for internal event
- https://github.com/ruby/ruby/pull/1059
I want to fix a crash: https://gist.github.com/k0kubun/86fd9fbff32423bd4974
I noticed that clean_hooks can be executed inside exec_hooks_body.
The hooks of list->hooks can be xfreed during e... -
- Can't you show gdb backtrace?
-
- Hi,
I can't to compile Ruby 2.1.7 on the one of our servers:
configure:
ruby-2.1.7 # ./configure
...
checking for nroff... /usr/bin/nroff
.ext/include/x86_64-linux/ruby/config.h updated
ruby library version = 2.1.0
configure: c... -
- Applied in changeset r52192.
----------
file.c: fix typos
* file.c (rb_file_expand_path_internal): fix typos.
[ruby-core:71111] [Bug #11601] -
08:50 AM Bug #11601 (Closed): error: implicit declaration of function ‘ENC_GET’
- When trying to compile Ruby trunk with
make up; make install-nodoc
I get the following errors:
compiling file.c
file.c: In function ‘rb_file_expand_path_internal’:
file.c:3561:2: error: implicit declaration of function ‘ENC_GE... -
- * file.c (rb_file_expand_path_internal): fix typos.
[ruby-core:71111] [Bug #11601]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52192 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * ext/objspace/objspace_dump.c: support special constant objects.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52191 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Applied in changeset r52190.
----------
init.c: glibc bug
* ext/socket/init.c (rsock_raise_socket_error): get rid of a glibc
bug. [ruby-core:71100] [Bug #11600] -
- Accurately, it is not a bug but an intentional crash.
Citing from [`libdispatch-442.1.4/src/source.c`](https://opensource.apple.com/tarballs/libdispatch/libdispatch-442.1.4.tar.gz):
~~~c
int err = errno;
switch (err) {
cas... -
- Erkki Eilonen wrote:
> Happens on OSX (10.10.5) as well (on 2.2.3 and earlier, presumably on latest 2_2 as well)
It's a bug of a system library.
We can do nothing for it. -
- * ext/socket/init.c (rsock_raise_socket_error): get rid of a glibc
bug. [ruby-core:71100] [Bug #11600]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52190 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
10/18/2015
-
- Nobuyoshi Nakada wrote:
> Are `is_{key,value}_address` necessary?
Yes, If the key/value are composite objects (not special consts, like string/hash/class) then the values of "key"/"value" should be address which is *pointer to other ... -
- Are `is_{key,value}_address` necessary?
- 04:30 PM Revision 3ef4dfdc (git): * 2015-10-19
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52189 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 04:29 PM Revision a01dfd47 (git): * file.c (rb_file_identical_p): not necessary to compare the paths after
- comparing the file indexes on Windows. designate by kosaki.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52188 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
03:02 PM Bug #11600: indeterministic failures on socket operations when running out of file descriptors
- Motohiro KOSAKI wrote:
> In my system, getaddrinfo() return -11(EAI_SYSTEM) and errno=0. That seems glibc's bug.
> ...
Happens on OSX (10.10.5) as well (on 2.2.3 and earlier, presumably on latest 2_2 as well)
~~~
➜ ruby test.rb
10... -
01:07 PM Bug #11600: indeterministic failures on socket operations when running out of file descriptors
- In my system, getaddrinfo() return -11(EAI_SYSTEM) and errno=0. That seems glibc's bug.
I guess this is related to https://sourceware.org/bugzilla/show_bug.cgi?id=15339.
-
12:36 PM Bug #11600: indeterministic failures on socket operations when running out of file descriptors
- Managed to get the testcase slightly simpler with a guaranteed ruby crash.
-
- We've been getting indeterministic failures on socket operations when running out of file descriptors, instead of the correct `Errno::EMFILE` being raised we've seen various failure modes, on both linux and osx:
1. This is what we're ... - 02:59 PM Revision 0bb6bf24 (git): * ruby/test_require.rb (loading_fifo): checking by defined? is meaningless about
- notimplemented method. such methods are defined, but not respond_to?. this
fixes test failures introduced at r52172.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52187 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
12:17 PM Revision 89db37cf (git): * lib/open-uri.rb: Specify frozen_string_literal: true.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52186 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * include/ruby/ruby.h (rb_data_object_{wrap,get}): move
declarations inside ifdef too.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52185 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * include/ruby/ruby.h (rb_data_object_{wrap,get,make}): warn only
if optimized, as __builtin_choose_expr() does not work fine
unless optimized.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52184 b2dd03c8-39d4-4d8f-98ff-823fe69b... -
- * random.c (fill_random_bytes_urandom): fix comment typos.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52183 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52182 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- O_NONBLOCK and O_NOCTTY.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52181 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- It is meaningless. If SYS_getrandom(GRND_NONBLOCK) return
EAGAIN, we eventually call fill_random_bytes_urandom() and
it block such as SYS_getrandom() without GRND_NONBLOCK.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52180 b2d... -
- updating try_syscall.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52179 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52178 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52177 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52176 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * ruby.c (open_load_file): disable O_NONBLOCK only when opened in
non-blocking mode, to get rid of LoadError on Windows.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52175 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52174 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * test/ruby/test_require.rb (loading_fifo): loading from FIFO is
not guaranteed, it just should not block the whole process.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52173 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * test/ruby/test_require.rb (loading_fifo): check by if FIFO is
available or not, instead of platform names.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52172 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52171 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52170 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 02:11 AM Revision 5b9f32c2 (git): * append newline at EOF.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52169 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * include/ruby/backward/rubyio.h: ditto.
* include/ruby/backward/st.h: ditto.
* include/ruby/backward/util.h: ditto.
* include/ruby/backward/rubysig.h: ditto.
* include/ruby/backward/classext.h: ditto.
* dln.c: ditto.
* gc.c: ditto.
* wi... -
- see include/ruby/defines.h
* gc.c: ditto.
* ext/sdbm/_sdbm.c: ditto.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52167 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52166 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52165 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * file.c (rb_file_s_rename): remove unmatched endif not removed at
r52161.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52164 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52163 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 01:18 AM Revision 64a08a54 (git): * append newline at EOF.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52162 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * common.mk: ditto.
* configure.in: ditto.
* dln_find.c: ditto.
* ext/Setup.emx: ditto.
* ext/extmk.rb: ditto.
* ext/socket/extconf.rb: ditto.
* ext/zlib/extconf.rb: ditto.
* file.c: ditto.
* include/ruby/defines.h: ditto.
* io.c: ditto.... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52160 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52159 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- not regular file nor FIFO.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52158 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52157 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52156 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
10/17/2015
-
- * ruby.c (open_load_file): remove unnecessary nested local
variable.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52155 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- せっかくなので、 did_you_meanが入っても 2.2.0より早くなるよう、r52152で高速化パッチを入れました。Rubyではrequireの速度が超重要であることが経験的に分かっているので、IO.close処理にそれ用の最適化を入れてみました。
$ make benchmark OPTS="-r 10 -p bm_require_t -e ruby-trunk -e ruby-2.2.2"
build-ruby: 0.171... -
- 調査してみたところ、今回のケースではGVLの所有権変更はすべてIO.closeを契機に行われており、
要するにopenの回数が変わっているのですが、それはなにかというと did_you_mean.
gem_prelude.rbから require 'did_you_mean' を削除してみたところ、以下のように性能劣化が
なくなりました。
ruby 2.0.0p598 (2014-11-13) [x86_64-linux] 1.527653928
ruby... -
- * file.c (ruby_is_fd_loadable): set proper errno.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52154 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * ruby.c (loadopen_func): suppress a warning, unused function.
* ruby.c (open_load_file): suppress warnings, results of close(2).
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52153 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- writable fd may block on close(2) when it's on NFS. But readonly
fd doesn't. [Bug #11559]
result: make benchmark OPTS="-p bm_require_t -e ruby-trunk -e ruby-2.2.2"
build-ruby: 0.171
ruby 2.3.0dev(r52151): 0.659
... -
- 修正メモ
r50887 はakrパッチにあったS_ISFIFO()のチェックが入っていないため、FIFOがemptyじゃなくなるまで待つが、待った後エラーになってしまいロードできていませんでした。
FIFOから正常にロードできるテストが存在しないのがよくないので、当該テスト足しました。
また、rb_file_load_ok()を修正するのは論理的におかしくて、rb_file_load_ok()でロードできるかどうか一度チェックしてから一旦クローズ、
再度 l... -
- Applied in changeset r52151.
----------
* ruby.c (open_load_file): reset O_NONBLOCK after open.
Even if S_ISREG() is true, the file may be file on FUSE filesystem
or something. We can't assume O_NONBLOCK is safe.
Moreover, we shou... -
- Even if S_ISREG() is true, the file may be file on FUSE filesystem
or something. We can't assume O_NONBLOCK is safe.
Moreover, we should wait if the path is point to FIFO. That's
FIFO semantics. GVL should be transparent from ruby ... - 04:40 PM Revision 9ec8d4ef (git): * 2015-10-18
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52150 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52149 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Hi,
*This is my first c code contribution :)*
I am helping developing heap-analyzer (github.com/tenderlove/heap-analyzer), and currently the dumps lacks of "type metadata" information, like:
* Hash entries - the keys and value
... -
- * test/ruby/test_const.rb (test_redefinition_memory_leak):
suppress warnings instead of redirecting to null device.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52148 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * file.c (rb_file_expand_path_internal): concatenate converted
string to the result instead of making converted string and
append it.
* string.c (rb_str_cat_conv_enc_opts): from rb_str_conv_enc_opts,
separate function to concatenat... -
- * file.c (rb_str_encode_ospath): prefer encoding index as possible
until rb_encoding is needed.
* file.c (rb_file_expand_path_internal): ditto.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52146 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * ruby.c (load_file): unify each preparations and clean-ups by
merging load_file_internal and load_file_internal2, and remove
nested rb_protect and rb_ensure.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52145 b2dd03c8-39d4-4d8... -
- * vm_insnhelper.c (vm_yield_with_cfunc): cast to suppress a
warning by VC.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52144 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * ruby.c (load_file_internal): do not use O_NONBLOCK when
conflicting with O_ACCMODE.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52143 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
12:30 AM Bug #11596: Getting [BUG] rb_vm_get_cref: unreachable
- Reproduced.
```
$ ruby -v -I lib:test test/cases/scoping/default_scoping_test.rb -n test_default_scope_select_ignored_by_grouped_aggregations
ruby 2.3.0dev (2015-10-15 trunk 52128) [x86_64-linux]
Using sqlite3
Run options: -n test...
10/16/2015
-
- * ruby.c (load_file_internal): fix potential fd leak.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52142 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 08:36 PM Revision 7a8a49d9 (git): * 2015-10-17
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52141 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 08:35 PM Revision 251b6628 (git): * test/ruby/test_symbol.rb (test_symbol_fstr_leak): add a warm-up
- code and check RSS to avoid false positive on AIX and false
negative on Mac OS X. [Bug #10686]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52140 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
10:29 AM Bug #11598 (Closed): Ruby crash when I run calabash-android
- Hi All,
I install the calabash-android. If the Chinese is included in the feature file, which is as below:
Feature: Login feature
Scenario: As a valid user I can log into my app
When I press "我的"
Then I can see "Not log... -
- `cmd` in `CreateChild()` is always allocated in heap.
win32/win32.c does not provide wchar-version `spawn` functions. -
- Applied in changeset r52139.
----------
file.c: non-blocking open
* file.c (rb_file_load_ok): open in non-blocking mode withoout
releasing GVL. don't care about others than regular files and
directories. [ruby-dev:49272] [Bug #11... -
- * file.c (rb_file_load_ok): open in non-blocking mode withoout
releasing GVL. don't care about others than regular files and
directories. [ruby-dev:49272] [Bug #11559]
* ruby.c (load_file_internal): ditto.
git-svn-id: svn+ssh://c... -
- * vm_args.c (vm_caller_setup_arg_block): store symbols instead of
ifuncs.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52138 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Benoit Daloze <eregontp@gmail.com> wrote:
> On Wed, Oct 14, 2015 at 9:56 PM, Eric Wong <normalperson@yhbt.net> wrote:
>
> > Fwiw, I mentioned in [ruby-core:70359] that I tried it for [Bug #11384]
> > without success, but Redmine + ...
10/15/2015
-
- Given Ruby already supports Kernel#syscall, I wonder if we should
support something a generated syscall.rb file in the stdlib with
all the available syscall numbers exported as constants:
SYS_setfsuid = 138
SYS_setfsgid = 139
... -
07:36 PM Feature #11597 (Open): Add Linux-specific setfsuid(2)/setfsgid(2)
- I would be helpful if you add a binding to the Linux-specific syscalls
setfsuid(2)
setfsgid(2)
Their purpose is to change the uid/gid with which filesystem access control is performed. Their main usage is simulating fs access on b... -
- * proc.c (proc_binding): merge blocks in same condition.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52137 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 03:54 PM Revision 59d0dfca (git): * 2015-10-16
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52136 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * proc.c (IS_METHOD_PROC_IFUNC): separate from IS_METHOD_PROC_ISEQ
for vm_ifunc.
* proc.c (rb_proc_get_iseq): use RUBY_VM_IFUNC_P to see if iseq is
an ifunc.
* proc.c (rb_proc_get_iseq, proc_binding): reduce redundant checsk
by I... -
- * proc.c (rb_sym_to_proc): make void env.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52134 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52133 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
11:48 AM Bug #10892: Deadlock in autoload
- On Wed, Oct 14, 2015 at 9:56 PM, Eric Wong <normalperson@yhbt.net> wrote:
> Fwiw, I mentioned in [ruby-core:70359] that I tried it for [Bug #11384]
> without success, but Redmine + list integration was broken at the
> time.
>
A... -
- * vm_dump.c (vm_stack_dump_each): remove never-used variable and
dead code for it.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52132 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * proc.c (rb_block_min_max_arity, rb_mod_define_method): use
RUBY_VM_NORMAL_ISEQ_P() to check if iseq.
* proc.c (make_curry_proc): IS_METHOD_PROC_ISEQ() includes
RUBY_VM_IFUNC_P().
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@... -
- * vm.c (env_mark): remove redundant conditions and mark block.iseq
simply unless null.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52130 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Applied in changeset r52129.
----------
proc.c: proc without env
* proc.c (rb_sym_to_proc): move from string.c and create a Proc
with no environments. [ruby-core:71088] [Bug #11594] -
- * proc.c (rb_sym_to_proc): move from string.c and create a Proc
with no environments. [ruby-core:71088] [Bug #11594]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52129 b2dd03c8-39d4-4d8f-98ff-823fe69b080e