Activity
From 09/04/2015 to 09/10/2015
09/10/2015
-
11:49 PM Misc #11520: Inconsistent behavior in Array#compact!
- Ah, I was unaware that was the intention. I guess I should use `.tap(&:compact!)` instead. This issue can be closed.
-
11:42 PM Misc #11520: Inconsistent behavior in Array#compact!
- This behavior is consistent with many other "bang methods" which return `nil` if they might have mutated the receiver but didn't:
``` ruby
[
'foo'.downcase!,
'BAR'.upcase!,
'Baz'.capitalize!,
'foo'.strip!,
'bar'.lstr... -
- I noticed that `Array#compact!` sometimes returns `self` and other times `nil`. This behavior was a bit confusing.
[].compact!
# => nil
[1].compact!
# => nil
[nil].compact!
# => []
[... -
05:22 PM Bug #11519: "#{nil}" produces string as US-ASCII rather than current encoding
- Great! This is why I love the Ruby community.
Thank you!
-
01:49 PM Bug #11519 (Closed): "#{nil}" produces string as US-ASCII rather than current encoding
- Applied in changeset r51820.
----------
parse.y: keep literal encoding
* parse.y (literal_concat_gen, evstr2dstr_gen): keep literal
encoding beginning with an interpolation same as the source file
encoding. [ruby-core:70703] [Bug ... -
08:54 AM Bug #11519: "#{nil}" produces string as US-ASCII rather than current encoding
- hm also the order is important:
"#{}#{foo}".encoding #=> US-ASCII
"#{foo}#{}".encoding #=> UTF-8
"#{}#{foo}".encoding != "#{foo}#{}".encoding #=> true
- 03:09 PM Revision a7727448 (git): * 2015-09-11
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51823 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
03:08 PM Revision e367d1e8 (git): fix a typo [ci skip]
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51822 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
02:12 PM Bug #8543: new rb_iseq_load crash
- At least r51816 should be backported into 2.1/2.2.
-
12:09 AM Bug #8543: new rb_iseq_load crash
- Addendum: Attached file in previous post also reproduces the crash
in the latest ruby trunk:
<compiled>:3: [BUG] Segmentation fault
ruby 2.3.0dev (2015-09-09 trunk 48555) [i386-mswin32_100]
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51821 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * parse.y (literal_concat_gen, evstr2dstr_gen): keep literal
encoding beginning with an interpolation same as the source file
encoding. [ruby-core:70703] [Bug #11519]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51820 b2dd03c8... -
- * process.c (rb_f_spawn): Be more specific regarding "other
values" by having "non-zero positive integers" Add nil, the
default value, as a possible value and what it means.
Try to use more consistent language.
[Fix GH-1008]
git... -
06:16 AM Revision 5c09cb9c (git): * lib/net/ftp.rb (getmultiline): refactor.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51818 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 03:18 AM Revision ffe47606 (git): * 2015-09-10
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51817 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * compile.c (iseq_build_from_ary_body): register cdhash to the
iseq constant body instead of compile time mark array, not to
get GCed. [ruby-core:70708] [Feature #8543]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51816 b2dd03...
09/09/2015
-
- Hi,
We've encountered a new crash related to RubyVM::InstructionSequence.load.
So far it has been reproducible on multiple platforms:
ruby 2.2.3p158 (2015-08-12 revision 48555) [i386-mswin32_100]
ruby 2.2.3p158 (2015-08-12 re... -
09:36 PM Bug #11483: internal.h included after math.h in complex.c
- Possible options:
1. Define M_PI and M_PI_2 in complex.c
2. Define _LARGE_FILES not in config.h but in a compiler option
3. Include ruby/config.h before math.h but keep internal.h included after math.h in complex.c
4. Any other optio... -
- Nobuyoshi Nakada wrote:
> What's and why wrong?
“#{bar}”.encoding != ‘UTF-8’ and “#{bar}#{foo}”.encoding != ‘UTF-8’ despite foo being UTF-8 and the encoding of the source file and hence the “ … “ string within the source file being U... -
- What's and why wrong?
-
- ~~~ruby
#! /usr/bin/env ruby
# encoding: utf-8
puts "Ruby version: #{RUBY_VERSION}"
puts "__ENCODING__ = #{__ENCODING__}"
puts "hello".encoding
foo = "hello"
puts "#{foo}".encoding
puts "#{"hello"}".encoding
bar = nil
puts "#... -
03:04 PM Feature #11518 (Assigned): Queue enhancement - promote! and promote_all!
- I’m submitting a patch to enhance the Queue class by adding the methods Queue#promote! and Queue#promote_all!. These methods require a block that accepts queue elements. Elements for which the block returns a truthy value are moved to th...
-
- I’m submitting a patch to enhance Queue#pop. This allows the caller to provide a block that accepts data from the queue. Queue#pop will return the first element for which the block returns a truthy value, and remove it from the queue. Wi...
- 10:07 AM Revision 868265ca (git): * ChangeLog: typo.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51815 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 09:18 AM Revision 5e262e52 (git): * lib/rubygems/stub_specification.rb (Gem::StubSpecification#data):
- should not change the value of $. when `require`ing gems.
this fixed test failures introduced by r51813.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51814 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 07:57 AM Revision 40f304e0 (git): * ruby.c (usage, enable_option, disable_option, process_options): new
- option `--disable_did_you_mean`.
* gem_prelude.rb: now requires did_you_mean gem by default if available.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51813 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- shouldnt that be fixed to "1.0.0.beta2" because "1.0.0.beta1" got yanked?
-
06:13 AM Misc #11516 (Closed): Ruby 2.3.0 release engeneering
- For the management of release blockers.
Current Phase:
Next release: preview1
Q: When ruby_2_2 branch is created?
A: On RC1
-
06:00 AM Bug #11471: min, min_by, max, max_by with optional parameter return a wrong value
- Algorithm should be based on a heap.
-
- * tool/extlibs.rb (do_patch): let "patch" command change the
working directory and open the patch file there, instead of
spawn options, so that proper error message will be shown by the
command not just "chdir" or "open".
git-svn-... -
03:01 AM Bug #11510 (Assigned): exit waits for the block form of IO.popen's child
- npbu, your change introduced a test error on mswin.
Fix it, please. - 02:57 AM Revision dbe4a7f1 (git): * test/ruby/test_process.rb (TestProcess#test_popen_exit): platform specific
- option.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51811 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 02:52 AM Revision 01762af7 (git): * test/ruby/test_process.rb (TestProcess#test_popen_exit): platform specific
- option.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51810 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * io.c: BSDs need sys/wait.h for WNOHANG.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51809 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 02:34 AM Revision 1ab8dc3d (git): * common.mk (update-gems): use BASERUBY instead of RUNRUBY.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51808 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 02:20 AM Revision 7c97533a (git): * .travis.yml: retry.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51807 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
02:13 AM Bug #11461 (Closed): Remove backtracing cleaning on Delegator methods
- Applied in changeset r51806.
----------
* lib/delegate.rb: Remove backtrace cleaning for delegated methods
This patch was provided by Rafael França and greatly improves
performance when an exception is raised. [Bug #11461]
Before... -
- This patch was provided by Rafael França and greatly improves
performance when an exception is raised. [Bug #11461]
Before:
Calculating -------------------------------------
default 86.209k i/100ms
default r... - 02:10 AM Revision 852c3454 (git): * .travis.yml: update unicode data, bundled gems, extlibs, and so on.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51805 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
01:05 AM Revision 2f227df3 (git): * test/rubygems/test_config.rb: fix broken tests for Windows platform.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51804 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
09/08/2015
-
- `CreateChild` is never called with a constant `cmd`, as it is build at the runtime.
How can you reproduce it? -
04:09 PM Bug #11515 (Rejected): CreateProcessW() can cause "Invalid access to memory location"
- The second argument for `CreateProcessW()` needs to *not* be a constant because it may be modified:
From https://msdn.microsoft.com/en-us/library/windows/desktop/ms682425(v=vs.85).aspx :
> The Unicode version of this function, Crea... - 10:47 PM Revision d0191f54 (git): * properties.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51803 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 10:47 PM Revision d42d4c1e (git): * 2015-09-09
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51802 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- this version contains new feature that warn invalid SPDX license
identifiers. https://github.com/rubygems/rubygems/pull/1249
and #1032, #1023, #1332, #1328, #1306, #1321, #1324
* test/rubygems: ditto.
git-svn-id: svn+ssh://ci.ruby-l... -
03:34 PM Bug #11268: Zlib::DataError: incorrect header check
- This patch has passed tests.
-
- I think it is issue of ruby.
Test case of `test/net/http/test_httpresponse.rb` is wrong.
That test case say "x\x9C\xCBH\xCD\xC9\xC9\a\x00\x06,\x02\x15" is raw Deflate format (at line 85) but actually that hex is Zlib format.
A case ... -
- Yasuhiro, thank you for your investigation!
So is it server side issue?
Anyway, you can specify request header via open-uri.
require "open-uri"
open('https://www.hoveround.com', "Accept-Encoding" => "plain") do |f| puts f.r... - 02:32 PM Revision 230b8d53 (git): gems/bundled_gems: Upgrade the did_you_mean gem to 1.0.0.beta2
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51800 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * test/ruby/test_file.rb (test_realdirpath_junction): fix a typo of method name.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51799 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
02:17 PM Bug #11514: AIX6.1 - Ruby 2.2.3 - Segmentation fault in :byteslice
- I had attached all the details in a file. However, I have an "internal error" when trying to look at the file.
I haven't put all details in defect because, in some other projects, we are required to not put all details at first, only a ... -
- > ~~~
> ...
Why hide here?
Please attach the whole log. -
- Testing Ruby 2.2.3 on AIX6.1 built with xlc (same with gcc) leads to a reproducible crash.
See complete trace in attached file.
Ruby version is: RUBY_PROGRAM_VERSION=2.2.3 .
~~~
# gmake V=1 test-all
...
objcopy -w -L 'Init_*' -L ... -
- Applied in changeset r51798.
----------
io.c: no wait when killed
* io.c (rb_io_s_popen): do not wait the child process during being
killed. [ruby-core:70671] [Bug #11510] -
- * io.c (rb_io_s_popen): do not wait the child process during being
killed. [ruby-core:70671] [Bug #11510]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51798 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 01:51 PM Revision 88d96a4f (git): * test/ruby/test_file.rb (TestFile#test_realdirpath_junktion): test for r51790.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51797 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 01:19 PM Revision a8b2dec5 (git): * gems/bundled_gems: revert because ruby trunk never be able to install
- the did_you_mean gem. retry after enough test.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51796 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
12:55 PM Feature #11252 (Closed): Integrated "did_you_mean" gem to ruby-core - Applied in changeset r51795.
----------
gems/bundled_gems: Automatically install the did_you_mean gem as a bunlded gem.
[Feature #11252] - 12:54 PM Revision 39fa5df0 (git): gems/bundled_gems: Automatically install the did_you_mean gem as a bunlded gem.
- [Feature #11252]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51795 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
08:21 AM Revision eec17b71 (git): * vm_core.h: remove rb_call_info_t::blockiseq.
- * insns.def (send, invokesuper): pass blockiseq explicitly.
* compile.c: catch up this fix.
* iseq.c: ditto.
* vm_args.c: ditto.
* iseq.c (ISEQ_MINOR_VERSION): 2->3 because instruction spec was
changed.
git-svn-id: svn+ssh://ci.ruby... -
- * process.c (rb_waitpid): do not release GVL when WNOHANG is set,
it should return immediately without blocking.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51793 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * process.c (rb_waitpid): refactor retry loop by interrupt.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51792 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- チケットのほうに反映されてないのでメールから引用します
> > ruby_2_1, ruby_2_2 では trunk の move_refined_method() が変更されていて多少 conflict しますが、同じ問題があるように見受けられます。
> ...
ということでしたので、わたしの確認不足でした。 DONTNEED に変更しておきます。 -
- Applied in changeset ruby-trunk:r51791.
----------
* lib/net/ftp.rb (list): fetch all the lines before yielding a block
to allow other commands in the block. [Feature #11454]
Patched by Srikanth Shreenivas. -
- to allow other commands in the block. [Feature #11454]
Patched by Srikanth Shreenivas.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51791 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
-
- [But #11404] seems the similar issue and fixed on trunk.
-
- 実際の可否はともかく、要望があるということで Backport フィールドに REQUIRED を埋めました。
r50900 を入れると(おそらく潜在的には r50900 の有無とは関係なく必要なのだと思いますが) [Bug #11265] の対応も必要になってきて、こちらがそれなりのボリュームがあり頻繁に変更のある部位の修正なのでうまくマージできないかもしれません。その時はまた悩みます。 r50900 のみ入れるというのも有意義ではあると思います。 - 03:06 AM Revision 49cbfc83 (git): * win32/win32.c (rb_w32_read_reparse_point): return correct required
- buffer size for IO_REPARSE_TAG_MOUNT_POINT.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51790 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Thank you for your report and patches.
I've confirmed that the issue exists in ruby-2.2.3 too.
akr san, please review the PR? https://github.com/ruby/ruby/pull/1005
09/07/2015
-
05:13 PM Bug #11513 (Closed): IPAddr should reject invalid formats
- Is this intended behavior?
A patch is PR#942(https://github.com/ruby/ruby/pull/942)
~~~
require 'ipaddr'
IPAddr.new "[2001:200:300::] INVALID" #=> IPAddr::InvalidAddressError: invalid address
IPAddr.new "192.168.0.1/32 INVALID... -
- Is this intended behavior?
A patch is PR#926(https://github.com/ruby/ruby/pull/926)
~~~
require 'delegate'
class Parent
def parent_public; end
protected
def parent_protected; end
end
class Child < Parent
end
... -
- * configure.in (BOOTSTRAPRUBY): avoid too old versions. current
fileutils.rb does not work with 1.8 or older, because of the
return values of Module#singleton_methods and so on.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@517... - 03:15 PM Revision 75d765de (git): * 2015-09-08
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51788 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * process.c (rb_execarg_parent_start1): raise with the target path
name when open() failed.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51787 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * process.c (rb_exec_fail): raise with the target directory name
when chdir() failed. pointed out by sorah.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51786 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51785 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- How to reproduce?
I could not reproduce with irb.
 -
12:59 PM Bug #11511: Problem with cyrillic letter И
- converted file to utf-8
set up comment
~~~ruby
# encoding: UTF-8
~~~
this does not help.
please help how to solve a problem. -
- I have problem dealing with the И letter.
'И'.encoding #>ASCII-8BIT
'И'.force_encoding('ASCII-8BIT').encode('utf-8') #> UndefinedConversionError: "\xC8" from ASCII-8BIT to UTF-8
'И'.forc... -
- * win32/win32.c (insert): should use plain strdup() instead of
ruby_strdup() at startup time, and plain free()ed in cmdglob().
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51784 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * test/mkmf/test_framework.rb (test_single_framework): use Ruby
framework, as CoreFoundation framework uses Apple extensions
unsupported by standard GCC other than Apple-patched clang.
* test/mkmf/test_framework.rb (test_multi_frame... -
- * vm_core.h (rb_vm_struct): define objspace always regardless
ENABLE_VM_OBJSPACE.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51782 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * ruby_atomic.h (ATOMIC_VALUE_CAS): fix typo.
TODO: make arguments of all CAS macros consistent.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51781 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * localeinit.c (rb_locale_charmap): [RDOC] move
Encoding.locale_charmap rdoc from encoding.c.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51780 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
09/06/2015
-
- * thread_pthread.c (async_bug_fd): show failed file descriptor too.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51779 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 03:19 PM Revision 642e7c51 (git): * 2015-09-07
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51778 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * thread_pthread.c (consume_communication_pipe, CLOSE_INVALIDATE):
adjust async bug messages.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51777 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 07:10 AM Revision 1fab35ba (git): ccan/list/list.h: suppress unused argument warnings
- ccan commit 6aaca17e07588997417a73fac19dcf0ff17ed81b
("list: suppress unused argument warnings")
by Cody P Shafer.
Signed-off-by: Cody P Schafer <dev@codyps.com>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
git-svn-id: svn+ssh:... -
- * test/ruby/test_process.rb (test_exec_close_reserved_fd):
suppress "cannot close fd before spawn" warnings.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51775 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- The new patch has passed tests.
Could you review the patch again? -
- * thread.c (do_select): suppress maybe-uninitialized warnings on
maxfd.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51774 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
09/05/2015
-
11:54 PM Bug #11510 (Closed): exit waits for the block form of IO.popen's child
- The block form of `IO.popen` waits for the child process to finish before quitting. If the parent process exits during this wait, the wait is interrupted and the exit proceeds promptly. There's a difference in behavior, however, if the...
-
- * win32/win32.c (get_attr_vsn): assume GetLastError() never return
0, to suppress a maybe-uninitialized warning in wrename().
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51773 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * include/ruby/ruby.h (ASSUME): evaluate the argument just once
everywhere.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51772 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 03:33 PM Revision 8a44c2e5 (git): * 2015-09-06
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51771 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * enc/make_encmake.rb: @srcdir@ in enc/Makefile.in needs to be
expanded.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51770 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * internal.h (rb_readlink): move the declaration.
* ruby.c (dladdr_path): rb_readlink now requires the result
encoding.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51769 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * tool/fake.rb: remove redundant dot directories from joined path.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51768 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * lib/rss/rss.rb (Time#w3cdtf): don't substitute, just search
zeros at EOS. [ruby-core:70667] [Bug #11509]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51767 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Applied in changeset r51766.
----------
rss.rb: fix usec width
* lib/rss/rss.rb (Time#w3cdtf): fix zero-trimmed width of fraction
digits. [ruby-core:70667] [Bug #11509] -
01:25 AM Bug #11509: Incorrect fraction_digits calculation in lib/rss/rss.rb:41 Time#w3cdtf
- **Sorry for broken markdown -- here I fixed it:**
Current code is:
~~~ruby
def w3cdtf
if usec.zero?
fraction_digits = 0
else
fraction_digits = Math.log10(usec.to_s.sub(/0*$/, '').to_i).floor + 1
end
... -
- Current code is:
~~~ruby
fraction_digits = Math.log10(usec.to_s.sub(/0*$/, '').to_i).floor + 1
~~~
This makes time to lose as many digits, as there are zeros right after dot:
~~~diff
< <dc:date>2014-03-04T07:37:... -
- * lib/rss/rss.rb (Time#w3cdtf): fix zero-trimmed width of fraction
digits. [ruby-core:70667] [Bug #11509]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51766 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * tool/fake.rb: builddir should be "." if it is the current
working directory.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51765 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * win32/Makefile.sub (WARNFLAGS): disable some too verbose
warnings.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51764 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
09/04/2015
-
- New ticket for a new method, please.
-
- Applied in changeset r51763.
----------
hash.c: [DOC] orders do not matter [ci skip]
* hash.c (rb_hash_equal, rb_hash_eql): [DOC] the orders of each
hashes are not compared. [Bug #11508] -
09:12 PM Bug #11508: Hash#eql? does not respect hash ordering
- ruby5 -> ruby3
maybe we should try it in rails support first. -
- ~~~ruby
{a:1,b:2}.eql?({b:2,a:1})
=> true
~~~
The `eql?` (aka `==`) operator on hashes does not compare the ordering of the compared hashes.
This behaviour is documented in `Hash#==` (and should not be touched, ever)
I'd like... -
- * hash.c (rb_hash_equal, rb_hash_eql): [DOC] the orders of each
hashes are not compared. [Bug #11508]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51763 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 03:27 PM Revision 39db484e (git): * 2015-09-05
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51762 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * tool/fake.rb: get rid of use of uninitialized global variable.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51761 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * include/ruby/win32.h: fix macro name for VC runtime version,
RT_VER is only in Makefile.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51760 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * tool/fake.rb: add extmk mode.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51759 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
09:47 AM Feature #11507 (Open): Net::HTTP should use TCP_CORK or TCP_NOPUSH to avoid fragmenting packets
- I discovered while implementing a soap client against a badly implemented http server that for sending a 723 bytes, Net::HTTP sends two packets:
~~~
Frame 185: 579 bytes on wire (4632 bits), 579 bytes captured (4632 bits) on interfac... -
- [ci skip] [fix GH-1009]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51758 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
07:48 AM Bug #11506 (Closed): Changed behavior of URI.unescape between 2.1.5 and 2.2.3
- Changed behavior of URI.unescape between 2.1.5 and 2.2.3. Why?
Is this change intended or not?
It breaks my application.
But I will use `CGI.unescape` for my application, for now.
My test script here.
```ruby
require "uri"
... -
- * lib/mkmf.rb (configuration): remove unnecessary variables,
top_srcdir is defined above, builddir is not used.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51757 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * lib/mkmf.rb (create_makefile): move r40537 from extmk.rb.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51756 b2dd03c8-39d4-4d8f-98ff-823fe69b080e