Project

General

Profile

Activity

From 07/31/2015 to 08/06/2015

08/06/2015

06:54 PM Feature #11420: Introduce ID key table into MRI
> Which implementation do you like?
The one which will be faster.
Quadratic probing is simpler, so if it is not slower (or with in couple of percents)
than coalesced chaining in usual application (big rails application :) ), then ...
funny_falcon (Yura Sokolov)
06:18 PM Feature #11420: Introduce ID key table into MRI
On 2015/08/06 23:02, funny.falcon@gmail.com wrote:
> Koichi Sasada , i've made another one "hash" for your experiments

Thank you!
Which implementation do you like?

--
// SASADA Koichi at atdot dot net
ko1 (Koichi Sasada)
02:02 PM Feature #11420: Introduce ID key table into MRI
Koichi Sasada , i've made another one "hash" for your experiments
https://github.com/ko1/ruby/pull/1
funny_falcon (Yura Sokolov)
01:42 PM Feature #11420: Introduce ID key table into MRI
Indeed, I'm using machines with 2TB or 3TB main memory, and
theoretically the upper limit of 1,374,389,534,720 = 1.3TB
can be reached today.
(though this may be very rare case in practice)
I think to prepare a compile-time option t...
ngoto (Naohisa Goto)
12:08 PM Feature #11420: Introduce ID key table into MRI
Go ahead and experiment the idea.
Matz.
matz (Yukihiro Matsumoto)
08:54 AM Feature #11420 (Closed): Introduce ID key table into MRI
Let's introduce ID key table to optimization.
# Background
Now, most of tables are implemented by st_table.
st_table is O(1) hash data structure.
MRI uses ID keys tables for many purpose like:
* method tables (mtbl) for classe...
ko1 (Koichi Sasada)
05:50 PM Bug #11048: blocks raise on missing and extra keyword args
bug hit wrote:
> another use case for this is hash destructuring
> ...
Please comment on the use case of hash destructuring via block keyword args.
bughit (bug hit)
08:10 AM Bug #11419: super_method segfaults when looking for a super_method of Object's UnboundMethod
Attached is a reproducing test case. matsuda (Akira Matsuda)
08:02 AM Bug #11419 (Closed): super_method segfaults when looking for a super_method of Object's UnboundMethod
This code segfaults on 2.3 trunk (does not segfault on 2.2 stable):
~~~
% ruby -e 'Object.instance_method(:tap).super_method'
-e:1: [BUG] Segmentation fault at 0x00000000000010
ruby 2.3.0dev (2015-08-06 trunk 51500) [x86_64-darwin1...
matsuda (Akira Matsuda)
01:56 AM Revision 95c84eac (git): gc.c: move tmp buffer functions
* gc.c (rb_alloc_tmp_buffer, rb_free_tmp_buffer): move from
node.c.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51500 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
nobu (Nobuyoshi Nakada)
01:50 AM Revision 8b6a0f73 (git): node.c: check size
* node.c (rb_alloc_tmp_buffer): round up the size and check the
range.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51499 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
nobu (Nobuyoshi Nakada)
01:44 AM Revision ec10c033 (git): ruby_atomic.h: atomic VALUE operations
* ruby_atomic.h (ATOMIC_VALUE_EXCHANGE, ATOMIC_VALUE_CAS): add
atomic operations for VALUE.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51498 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
nobu (Nobuyoshi Nakada)

08/05/2015

11:17 PM Revision ff7eb4c6 (git): * ext/openssl/lib/openssl/ssl.rb (module OpenSSL): move
SSLSocket#sysclose to Ruby.
* ext/openssl/ossl_ssl.c (ossl_ssl_close): ditto
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51497 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
tenderlovemaking (Aaron Patterson)
10:59 PM Revision 17586284 (git): * ext/openssl/lib/openssl/ssl.rb (module OpenSSL): move nonblock
enable to SSLSocket#initialize and remove Nonblock module.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51496 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
tenderlovemaking (Aaron Patterson)
10:55 PM Revision b830786f (git): * ext/openssl/lib/openssl/ssl.rb (module OpenSSL): move
OpenSSL::SSL::SSLSocket#initialize to Ruby.
* ext/openssl/ossl_ssl.c: ditto
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51495 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
tenderlovemaking (Aaron Patterson)
10:26 PM Revision 46bd8e86 (git): test/ruby/test_process.rb (test_many_args): increase timeout
Some machines take a while to run this test, apparently.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51494 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
Eric Wong
05:26 PM Bug #11418 (Closed): spawn segfaults
Applied in changeset r51492.
----------
node.c: NODE_ALLOCA for ALLOCV
* node.c (rb_alloc_tmp_buffer): use NODE_ALLOCA to mark locations
like as builtin alloca. [ruby-core:70251] [Bug #11418]
nobu (Nobuyoshi Nakada)
05:01 PM Bug #11418 (Closed): spawn segfaults
`Process.spawn` sometimes segfaults, because buffer allocated by `ALLOCV_N` is not marked, when the size exceeds 1024 bytes.
In these days, `TestEncodingConverter#test_default_external` has occasionally segfaulted by this problem.
Un...
nobu (Nobuyoshi Nakada)
05:25 PM Revision 0777dd02 (git): * 2015-08-06
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51493 b2dd03c8-39d4-4d8f-98ff-823fe69b080e svn[bot]
05:25 PM Revision fb258336 (git): node.c: NODE_ALLOCA for ALLOCV
* node.c (rb_alloc_tmp_buffer): use NODE_ALLOCA to mark locations
like as builtin alloca. [ruby-core:70251] [Bug #11418]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51492 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
nobu (Nobuyoshi Nakada)
12:32 PM Bug #11168: object allocation during garbage collection phase when rake assets:precompile on 2.2.2
+1, experiencing similar output on rake tasks on our production (linux) servers, like many other people. here is a gist of a stack trace :
https://gist.github.com/bmishkin/2766109621a6744a3311
Checkout these links too :
- https:...
salimane (Salimane Adjao Moustapha)
10:43 AM Feature #11266: [PATCH] WEBrick: allow subclassing of Response and Request
Is there still anything I can do/change? julik (Julik Tarkhanov)
09:48 AM Bug #11417 (Closed): Wrong description for `limit` parameter for IO#gets
It says:
"If the first argument is an integer, or optional second argument is given, the returning string would not be longer than the given value in bytes."
But:
~~~
require "stringio"
io = StringIO.new "こんにちは"
string = io...
asterite (Ary Borenszweig)
06:32 AM Revision 7918dc35 (git): socket.c: suppress warnings
* ext/socket/socket.c (socket_s_ip_address_list): suppress
warnings to assign pointers to literal strings.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51491 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
nobu (Nobuyoshi Nakada)
05:43 AM Revision db45ec98 (git): insns.def: redundant call
* insns.def (leave): remove redundant function call.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51490 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
nobu (Nobuyoshi Nakada)
05:40 AM Revision b55217c6 (git): transcode.c: GC guards
* transcode.c (econv_init): add guards to prevent source encoding
name and destination encoding name from GC.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51489 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
nobu (Nobuyoshi Nakada)
05:38 AM Bug #11416 (Closed): TestEncodingConverter#test_newline_option fails under GC stress
Applied in changeset r51488.
----------
transcode.c: fix dangling pointers
* transcode.c (rb_econv_open0): rb_econv_t::source_encoding_name
and rb_econv_t::destination_encoding_name should refer static
strings always or NULL. [rub...
nobu (Nobuyoshi Nakada)
05:35 AM Bug #11416 (Closed): TestEncodingConverter#test_newline_option fails under GC stress
`rb_econv_t::source_encoding_name` and `rb_econv_t::destination_encoding_name` refer dangling pointers, after creation. nobu (Nobuyoshi Nakada)
05:37 AM Revision 3969b186 (git): transcode.c: fix dangling pointers
* transcode.c (rb_econv_open0): rb_econv_t::source_encoding_name
and rb_econv_t::destination_encoding_name should refer static
strings always or NULL. [ruby-core:70247] [Bug #11416]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk...
nobu (Nobuyoshi Nakada)
02:28 AM Feature #11415 (Open): autoload with a Proc
`autoload` currently allows you to run arbitrary code when a constant is referenced, as long as that code is written to a file.
I propose extending `autoload` to also accept a Proc in place of the string filename.
Usage:
a...
matthewd (Matthew Draper)
01:48 AM Revision 4b193223 (git): ossl_ssl.c: remove unused variables
* ext/openssl/ossl_ssl.c (ossl_call_client_cert_cb),
(ossl_call_tmp_dh_callback, ossl_call_tmp_ecdh_callback),
(ossl_call_session_get_cb, ossl_call_session_new_cb): remove no
longer used variables.
git-svn-id: svn+ssh://ci.ruby-la...
nobu (Nobuyoshi Nakada)

08/04/2015

11:56 PM Revision 1cb9949f (git): * ext/openssl/lib/openssl/ssl.rb (module OpenSSL): extract callback
lookup to private Ruby methods. This means we can keep the default
DH callback logic hidden from consumers. Also, since the SSLSocket
always has a context, we can remove conditionals about that
instance.
* ext/openssl/ossl_ssl.c:...
tenderlovemaking (Aaron Patterson)
10:31 PM Bug #10968: [BUG] object allocation during garbage collection phase in /opt/rubies/ruby-2.2.1/lib/ruby/2.2.0/openssl/ssl.rb:177
Ben Mishkin wrote:
> trace: https://gist.github.com/bmishkin/2766109621a6744a3311
It's [Bug #10933].
nobu (Nobuyoshi Nakada)
05:09 PM Bug #10968: [BUG] object allocation during garbage collection phase in /opt/rubies/ruby-2.2.1/lib/ruby/2.2.0/openssl/ssl.rb:177
possibly related
Rails version 4.2.3
Ruby version 2.2.2-p95 (x86_64-linux)
RubyGems version 2.4.6
Rack version 1.6.4
Ubuntu 12.04
trace: https://gist.github.com/bmishkin/2766109621...
bmishkin1 (Ben Mishkin)
03:36 PM Revision 6373a1ac (git): * 2015-08-05
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51485 b2dd03c8-39d4-4d8f-98ff-823fe69b080e svn[bot]
03:36 PM Revision 759538da (git): fix a typo [ci skip]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51484 b2dd03c8-39d4-4d8f-98ff-823fe69b080e znz (Kazuhiro NISHIYAMA)
08:28 AM Feature #11375: Decreased Object Allocation in Pathname.rb
richard.schneeman@gmail.com wrote:
> I think I figured out why i'm not getting emails and I believe I've
> ...
No worries, I barely have Internet access the past few weeks.
I'm only subscribed to ruby-core, though.
<snip>
I unde...
normalperson (Eric Wong)
03:10 AM Feature #11375: Decreased Object Allocation in Pathname.rb
Eric Wong <normalperson@yhbt.net> wrote:
> richard.schneeman@gmail.com wrote:
> ...
NAK on my own patch to compile.c
`st_lookup` is still faster when there is no match in the `case`/`when`,
or when there's multiple "when" statement...
normalperson (Eric Wong)
07:55 AM Revision 63ee970f (git): contributing.rdoc: double quotes [ci skip]
* doc/contributing.rdoc: double quotes to expand an environment
variable.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51483 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
nobu (Nobuyoshi Nakada)
07:42 AM Feature #11414 (Closed): Relax ID table ordering
Applied in changeset r51482.
----------
* test/ruby/test_module.rb: should not expect a method table ordering.
[Feature #11414]
ko1 (Koichi Sasada)
07:24 AM Feature #11414: Relax ID table ordering
Ordering is not included in the specified behavior.
Matz.
matz (Yukihiro Matsumoto)
07:21 AM Feature #11414 (Closed): Relax ID table ordering
Can we relax ordering rule for ID table such as method table, ivar table, and so on?
I believe nobody care about method table ordering, ivar table ordering.
# background
From Ruby 1.9, Hash objects have order (insertion order).
T...
ko1 (Koichi Sasada)
07:41 AM Revision 91f20981 (git): * test/ruby/test_module.rb: should not expect a method table ordering.
[Feature #11414]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51482 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
ko1 (Koichi Sasada)
06:48 AM Revision 6ed8d39d (git): contributing.rdoc: portable substitution [ci skip]
* doc/contributing.rdoc: use portable substitution syntax
available in plain bourne shell.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51481 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
nobu (Nobuyoshi Nakada)
06:36 AM Bug #11409 (Closed): {instance,module}_eval(&:foo) segfaults since r51243.
Applied in changeset r51480.
----------
* proc.c (rb_block_clear_env_self): clear by Qfalse intead of Qnil.
[Bug #11409]
* test/ruby/test_eval.rb: add tests for this issue,
written by @0x0dea.
https://github.com/ruby/ruby/pull/988
ko1 (Koichi Sasada)
06:35 AM Revision 033e0933 (git): * proc.c (rb_block_clear_env_self): clear by Qfalse intead of Qnil.
[Bug #11409]
* test/ruby/test_eval.rb: add tests for this issue,
written by @0x0dea.
https://github.com/ruby/ruby/pull/988
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51480 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
ko1 (Koichi Sasada)
03:13 AM Revision 1e6a643f (git): variable.c: wrap long lines
Make code easier to read and hunt for bugs with my tiny terminal.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51479 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
Eric Wong
03:06 AM Bug #11380: Parser regression in 2.3?
This still needs to be backported. felixbuenemann (Felix Bünemann)
12:35 AM Revision d91e11b5 (git): * proc.c: Removing duplicate doc [fix GH-987][ci skip]
Patch by @ronakjangir47
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51478 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
hsbt (Hiroshi SHIBATA)
12:24 AM Revision 06a7b2ff (git): * 2015-08-04
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51477 b2dd03c8-39d4-4d8f-98ff-823fe69b080e svn[bot]
12:22 AM Revision 40e2bed3 (git): * doc/contributing.rdoc: fixed wrong instructions with OS X
[fix GH-989][ci skip] Patch by @schneems
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51476 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
hsbt (Hiroshi SHIBATA)

08/03/2015

10:23 PM Feature #11375: Decreased Object Allocation in Pathname.rb
I think I figured out why i'm not getting emails and I believe I've fixed the issue. Sorry again for the delayed response.
I agree we should be improving and optimizing Ruby so that the average developer can write code in the most rea...
schneems (Richard Schneeman)
07:12 PM Bug #10904: Time.strptime with %s.%N format should not ignore sec_fraction
r49788 and r49790 were backported into `ruby_2_2` branch at r51475. nagachika (Tomoyuki Chikanaga)
07:11 PM Revision 9fa59242 (git): merge revision(s) 49788,49790: [Backport #10904]
* lib/time.rb (strptime): Support %s.%N.
[ruby-core:68301] [Bug #10904] Patch by Sadayuki Furuhashi.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_2@51475 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
nagachika (Tomoyuki Chikanaga)
06:58 PM Bug #11277: "code converter not found" error with multi-thread (high occurrence rate since r50887)
Backported into `ruby_2_2` at r51474. nagachika (Tomoyuki Chikanaga)
06:57 PM Revision 43850e26 (git): merge revision(s) 51037: [Backport #11277]
* transcode.c (load_transcoder_entry): fix transcoder loading race
condition, by waiting in require. [ruby-dev:49106] [Bug #11277]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_2@51474 b2dd03c8-39d4-4d8f-98ff-8...
nagachika (Tomoyuki Chikanaga)
06:39 PM Bug #11235: [BUG] Segmentation fault
Backported into `ruby_2_2` branch at r51473. nagachika (Tomoyuki Chikanaga)
06:39 PM Revision 5758e049 (git): merge revision(s) 50827,50921: [Backport #11235]
* array.c (ary_ensure_room_for_push): check if array size will
exceed maxmum size to get rid of buffer overflow.
[ruby-dev:49043] [Bug #11235]
* array.c (ary_ensure_room_for_unshift, rb_ary_splice): ditto.
...
nagachika (Tomoyuki Chikanaga)
05:07 PM Feature #11390: Allow symbols starting with numbers
I have no particular pro or con on the suggestion itself, but I
did want to comment on one part:
> But it goes against the principle of least surprise that
> ...
As far as I can tell, there is not really a general "principle of leas...
shevegen (Robert A. Heiler)
08:20 AM Bug #11409: {instance,module}_eval(&:foo) segfaults since r51243.
> It's true that changing that Qnil to Qfalse is the "cleaner" fix this time around, but I think using RTEST() to check for both is slightly more future-proof. I've submitted a pull request which takes the latter approach, in addition to... ko1 (Koichi Sasada)
06:54 AM Bug #11409: {instance,module}_eval(&:foo) segfaults since r51243.
Koichi Sasada wrote:
> Thank you for reporting a bug and your detailed analysis.
> ...
I am happy to have been of some assistance.

> I believe `obj' should be Qfalse...
It's true that changing that `Qnil` to `Qfalse` is the "cle...
0x0dea (D.E. Akers)
06:13 AM Bug #11409: {instance,module}_eval(&:foo) segfaults since r51243.
Thank you for reporting a bug and your detailed analysis.
They help me very much.
In this case, I believe `obj' should be Qfalse or T_IMEMO objects. So that we clear by Qfalse intead of Qnil.
Reproducible code:
```ruby
class F...
ko1 (Koichi Sasada)
04:07 AM Bug #11409 (Assigned): {instance,module}_eval(&:foo) segfaults since r51243.
nobu (Nobuyoshi Nakada)
03:44 AM Bug #11409: {instance,module}_eval(&:foo) segfaults since r51243.
Upon further investigation, I've discovered why replacing `Qnil` with `Qfalse` prevents the crash.
```c
static rb_cref_t *
check_cref(VALUE obj, int can_be_svar)
{
if (obj == Qfalse) return NULL;
```
The prelude of `check_...
0x0dea (D.E. Akers)
04:35 AM Revision 745e01d3 (git): thread.c: fix message
* thread.c (thread_shield_get_mutex): fix object to be shown in
the message, NULL pointer is useless.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51472 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
nobu (Nobuyoshi Nakada)
02:24 AM Bug #10820: Win32 Registry Delete uses ANSI instead of Wide APIs
This issue is marked as ‘2.1: REQUIRED’. nobu (Nobuyoshi Nakada)
02:08 AM Bug #11410: Win32 Registry enumeration performs unnecessary string re-encoding which cause UndefinedConversionError exceptions
https://github.com/nobu/ruby/tree/bug/11410-win32-registry-encoding nobu (Nobuyoshi Nakada)
01:49 AM Bug #11410 (Feedback): Win32 Registry enumeration performs unnecessary string re-encoding which cause UndefinedConversionError exceptions
I agree that unnecessary conversions should be removed, but your code won't work yet, since the results will be expected in the locale encoding.
What do you want?
1. it's OK
2. return everything in UTF-8
3. add optional parameter...
nobu (Nobuyoshi Nakada)
02:07 AM Bug #11412 (Rejected): The default filename encoding causes errors on Windows
It's spec.
Dir.foreach returns the filenames with the filesystem encoding (in your environment, it may be cp850) for backword compatibility.
You can specify encoding option to Dir.foreach:
~~~ruby
Dir.foreach('.', encoding: 'utf-...
usa (Usaku NAKAMURA)
01:09 AM Bug #11413 (Closed): String#split with wchar string
Applied in changeset r51470.
----------
re.c: fix for wide character encodings
* re.c (rb_memsearch): should match only char boundaries in wide
character encodings. [ruby-core:70220] [Bug #11413]
nobu (Nobuyoshi Nakada)
01:00 AM Bug #11413 (Closed): String#split with wchar string
~~~
$ ruby -v -e 'p "a\0b".encode("utf-16le").split("\0".encode("utf-16le"))'
ruby 2.3.0dev (2015-08-02 trunk 51467) [universal.x86_64-darwin14]
["", "b"]
~~~
Expected to be `["a", "b"]`, same as ordinary ASCII-compatible encodings.
nobu (Nobuyoshi Nakada)
01:08 AM Revision 7ac6c5e4 (git): * 2015-08-03
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51471 b2dd03c8-39d4-4d8f-98ff-823fe69b080e svn[bot]
01:08 AM Revision 2c8986d2 (git): re.c: fix for wide character encodings
* re.c (rb_memsearch): should match only char boundaries in wide
character encodings. [ruby-core:70220] [Bug #11413]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51470 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
nobu (Nobuyoshi Nakada)

08/02/2015

11:24 PM Bug #11383: Infinite loop in str_buf_cat triggered by str_gsub
Nobu,
Thanks for fixing this issue.
On our side, the issue reproduced, not with the same arguments though. Anyway, I was able to get the value of *(struct RString *)str.
~~~
(gdb) display *(struct RString *)str
1: *(struct RSt...
lfarcy (Laurent Farcy)
10:26 PM Bug #11411 (Closed): Crash in rb_gc_mark() during Rails app boot with GC.stress=1
Seems same as #11352. nobu (Nobuyoshi Nakada)
07:09 PM Bug #11411 (Closed): Crash in rb_gc_mark() during Rails app boot with GC.stress=1
When booting a newly-initialized Rails 4.2.1 app under Ruby 2.2.2 with `GC.stress` enabled, I get a repeatable crash. The same crash happens at least as far back as 2.1.4 (haven't tried any earlier versions).
Steps to reproduce:
1....
benweint (Ben Weintraub)
08:29 PM Bug #11412 (Rejected): The default filename encoding causes errors on Windows
Ruby is apparently unable to find files it just told me are there (containing japanese characters).
Demo code:
Dir.foreach('.') do |entry|
puts "#{entry} exists? " + File.exist?(entry).to_s
end
Output:
C:\tmp\test\filenames>C:\t...
tokudan (Daniel Frank)
07:27 PM Bug #11410: Win32 Registry enumeration performs unnecessary string re-encoding which cause UndefinedConversionError exceptions
I realized that I should have included some sample code demonstrating the problem:
~~~ruby
require 'win32/registry'
ENDASH_UTF_16 = [0x2013]
TM_UTF_16 = [0x2122]
endash_utf_16_str = ENDASH_UTF_16.pack('s*').force_encoding(Enco...
Iristyle (Ethan Brown)
06:36 PM Bug #11410 (Feedback): Win32 Registry enumeration performs unnecessary string re-encoding which cause UndefinedConversionError exceptions
When enumerating keys with `Win32::Registry#each_key` / `Win32::Registry#keys` or values with `Win32::Registry#each_value` / `Win32::Registry#values`, Ruby will take a `UTF-16LE` string returned from the Windows API and convert it to the... Iristyle (Ethan Brown)
05:31 PM Bug #10820: Win32 Registry Delete uses ANSI instead of Wide APIs
Yui NARUSE wrote:
> ruby_2_2 r49622 merged revision(s) 49542.
I would like to see this backported to Ruby 2.1 as well. Without it, registry keys and values cannot be deleted at all. This is a fairly large issue on Windows.
Comme...
Iristyle (Ethan Brown)
12:29 PM Bug #11407: Net::FTP nlst method return wrong data and don't raise Error when path is wrong
Damian Giebas wrote:
> When ftp server is on Linux all is fine. Problem is when FTP is on IIS Server 8.0 (and probably with other version of IIS).
I think it's more likely a server-side problem.
Do you any other FTP client which wor...
shugo (Shugo Maeda)
08:41 AM Bug #11409 (Closed): {instance,module}_eval(&:foo) segfaults since r51243.
The segfault only occurs when the argument is a `#to_proc`'d Symbol, and the receiver needn't actually respond to the named method.
This bug was introduced in [a rather large patch](http://svn.ruby-lang.org/cgi-bin/viewvc.cgi?view=rev...
0x0dea (D.E. Akers)
05:15 AM Revision e60d35e3 (git): win32/file.c: use allocv buffer and API
* win32/file.c (rb_freopen): convert path name into allocv buffer
and get rid of conversion failure in the case non-terminated
string. [ruby-core:69780] [Bug #11320]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51469 b2dd03c8-...
nobu (Nobuyoshi Nakada)
01:27 AM Revision a2b8925a (git): tcltklib.c: check argument
* ext/tk/tcltklib.c (ip_cancel_eval_core): check argument type and
length.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51468 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
nobu (Nobuyoshi Nakada)

08/01/2015

10:08 PM Bug #11400 (Closed): IO.gets(/\x0d?\x0a\x0d?\x0a/, 4096) raises comparison of Fixnum with nil failed
Applied in changeset r51466.
----------
openssl/buffering: fix gets on EOF with limit
* ext/openssl/lib/openssl/buffering.rb (gets):
avoid comparing fixnum with nil
* test/openssl/test_pair.rb: test gets with limit when EOF is hit
...
Anonymous
10:08 PM Revision 03fcd385 (git): * 2015-08-02
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51467 b2dd03c8-39d4-4d8f-98ff-823fe69b080e svn[bot]
10:08 PM Revision 1e5a40ff (git): openssl/buffering: fix gets on EOF with limit
* ext/openssl/lib/openssl/buffering.rb (gets):
avoid comparing fixnum with nil
* test/openssl/test_pair.rb: test gets with limit when EOF is hit
Thanks to Bar Hofesh <bar.hofesh@safe-t.com> for the bug report
and testing.
[ruby-c...
Eric Wong
08:23 AM Revision 9cf11b70 (git): * lib/net/http/response.rb (Net::HTTPResponse::Inflater#finish):
fix a bug that empty gzipped response body causes Zlib::BufError.
[ruby-core:68846] [Bug #11058]
* test/net/http/test_httpresponse.rb: tests for the above.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51465 b2dd03c8-39d4-4d8f-98...
ktsj (Kazuki Tsujimoto)
08:23 AM Bug #11058 (Closed): [PATCH] Net::HTTPResponse#read_body raises TypeError when receiving empty gzipped response body
Applied in changeset r51464.
----------
* lib/net/http/response.rb (Net::HTTPResponse#inflater):
fix TypeError. An exception object might be nil.
[ruby-core:68846] [Bug #11058]
ktsj (Kazuki Tsujimoto)
08:22 AM Revision d7bb66df (git): * lib/net/http/response.rb (Net::HTTPResponse#inflater):
fix TypeError. An exception object might be nil.
[ruby-core:68846] [Bug #11058]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51464 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
ktsj (Kazuki Tsujimoto)
04:47 AM Revision 35a76874 (git): thread.c: thread_shield_get_mutex
* thread.c (thread_shield_get_mutex): explicitly check if
destroyed already.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51463 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
nobu (Nobuyoshi Nakada)
03:14 AM Bug #11393: segfault on trivial application, embedding in C app.
Thanks!
That didn't AV.
I guess I misunderstood what `rb_load_file` meant. I couldn't find a definitive reference, and there are no comments in the code.
It seems like rb_require is the correct thing to use to run a script.
I...
scorpion007 (Alex Budovski)
02:14 AM Bug #11393 (Third Party's Issue): segfault on trivial application, embedding in C app.
In short; use `rb_protect()`.
Ruby interpreter can't deal with exceptions raised outside its scope.
So you **must do it by yourself** instead.
~~~c
#include <ruby.h>
static VALUE
load_file(VALUE name)
{
return (VALUE)rb...
nobu (Nobuyoshi Nakada)
12:12 AM Revision d8225d9f (git): * ext/openssl/ossl_ssl.c (ossl_sslctx_setup): Implement
SSLContext#options and options= using SSL_CTX_set_options and
SSL_CTX_get_options. This reduces the number of ivars we need and
simplifies `ossl_sslctx_setup`.
* ext/openssl/lib/openssl/ssl.rb (module OpenSSL): Default `options`
t...
tenderlovemaking (Aaron Patterson)

07/31/2015

10:01 PM Revision bcc2641e (git): * ext/openssl/ossl_ssl.c (Init_ossl_ssl): OpenSSL declares these
constants as longs, so we should follow that and use LONG2NUM.
http://git.io/vOqxD
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51461 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
tenderlovemaking (Aaron Patterson)
09:08 PM Bug #11336: TestProcess#test_exec_fd_3_redirect failed on Solaris 10
ngotogenome@gmail.com wrote:
> I'm sorry too late.

No worries, I don't have much time for ruby these few weeks, either.

> On Solaris 10, the patch works fine, with no error/failure during make test-all (with r51450).
>
> > I'm...
normalperson (Eric Wong)
01:29 PM Bug #11336: TestProcess#test_exec_fd_3_redirect failed on Solaris 10
I'm sorry too late.
On Solaris 10, the patch works fine, with no error/failure during make test-all (with r51450).
> I'm not seeing it, did you notice/reproduce this failure?
No.
It seems the patch works correctly as you descri...
ngoto (Naohisa Goto)
07:08 PM Revision 9fefa606 (git): * ext/openssl/ossl_ssl.c (ossl_call_tmp_dh_callback): change callback
to return the Ruby dh (or ecdh) object that the caller cares about
instead of doing rb_iv_get / set to communicate. This means we can
remove an rb_iv_get call, and only use the set calls for their
intended purpose (to prevent the ...
tenderlovemaking (Aaron Patterson)
06:51 PM Revision 2abc8737 (git): * ext/openssl/ossl_ssl.c (ossl_call_tmp_dh_callback): Similarly to the
tmp_ecdh_callback, the SSLSocket instance always holds a reference
to the SSLContext object (it's always set in `initialize`). The
SSLContext holds a reference to the tmp_dh_callback. Ask the
context for the callback instead of s...
tenderlovemaking (Aaron Patterson)
06:44 PM Revision 568ba1cf (git): * ext/openssl/ossl_ssl.c (ossl_call_tmp_dh_callback): create an array
and use `rb_apply` to clean up calls to `rb_protect`.
* ext/openssl/ossl_ssl.c (ossl_tmp_dh_callback): ditto
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51458 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
tenderlovemaking (Aaron Patterson)
06:29 PM Revision cbb45e2f (git): * ext/openssl/ossl_ssl.c (ossl_call_tmp_ecdh_callback): The SSL socket
always holds a reference to the SSLContext object, which will have
the callback object. Ask the context for the callback instead of
storing the callback in two places.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51457 b2dd03c...
tenderlovemaking (Aaron Patterson)
06:20 PM Revision fa204023 (git): * 2015-08-01
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51456 b2dd03c8-39d4-4d8f-98ff-823fe69b080e svn[bot]
06:20 PM Revision 5b5d79c8 (git): * ext/openssl/lib/openssl/ssl.rb (module OpenSSL): convert
`tmp_dh_callback` to Ruby, and call it when setting up an SSL
connection. This allows us to move the "default" behavior to the
reader method.
* ext/openssl/ossl_ssl.c: call the tmp_dh_callback instead of
accessing the SSLContext'...
tenderlovemaking (Aaron Patterson)
03:03 PM Bug #10910 (Closed): NoMethodError when opening SSL connection with OpenSSL::SSL::VERIFY_PEER set and anonymous ciphers allowed
Thanks. I've applied the patch and the build is green now. tenderlovemaking (Aaron Patterson)
11:01 AM Bug #10910: NoMethodError when opening SSL connection with OpenSSL::SSL::VERIFY_PEER set and anonymous ciphers allowed
Turns out Travis ships an old, apparently broken version of `libssl`. I've attached a patch which updates it before running the build. You can see the patch running on this build: https://travis-ci.org/Sinjo/ruby/builds/73534479 Sinjo (Chris Sinjakli)
02:38 PM Revision af13f15b (git): * remove trailing spaces.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51454 b2dd03c8-39d4-4d8f-98ff-823fe69b080e svn[bot]
02:36 PM Revision 9896f469 (git): Update libssl before Travis build
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51453 b2dd03c8-39d4-4d8f-98ff-823fe69b080e tenderlovemaking (Aaron Patterson)
12:35 PM Revision d1cfb475 (git): * 2015-07-31
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51452 b2dd03c8-39d4-4d8f-98ff-823fe69b080e svn[bot]
12:34 PM Revision 9a0f5286 (git): load.c: use rb_load_internal0
* load.c (rb_require_internal): use rb_load_internal0 not to raise
a exception to be caught.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51451 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
nobu (Nobuyoshi Nakada)
11:41 AM Bug #11407: Net::FTP nlst method return wrong data and don't raise Error when path is wrong
When ftp server is on Linux all is fine. Problem is when FTP is on IIS Server 8.0 (and probably with other version of IIS). Draqun (Damian Giebas)
07:41 AM Bug #11402: Seg Fault on intensive numeric calculation
Kenta Murata wrote:
> Alexey, please give me your script to produce this issue.
It is a part of production ready app and has too many local dependencies. I have no short script to reproduce that (
laise (Alexey Chernenkov)
07:32 AM Bug #11402: Seg Fault on intensive numeric calculation
Nobuyoshi Nakada wrote:
> You load bigdecimal-1.2.5, which is out-of-date.
> ...
Ok, thanks. I'll try to update bigdecimal
laise (Alexey Chernenkov)
04:59 AM Bug #10892: Deadlock in autoload
That broken rubyspec was written by me. The problem lies with repeatedly `autoload`ing the same `.rb` file, since this should be impossible, the spec manually deletes the loaded path from `$LOADED_FEATURES` and then re-declares the `auto... thedarkone (Vit Z)
01:18 AM Bug #11408 (Third Party's Issue): Segmentation fault with SCrypt and Ruby 2.2.2p95
Maybe https://github.com/pbhogan/scrypt/issues/28 ? nobu (Nobuyoshi Nakada)
 

Also available in: Atom