Project

General

Profile

Activity

From 07/09/2015 to 07/15/2015

07/15/2015

11:58 PM Bug #10902: require("enumerator") scans LOAD_PATH 2x on every invocation
Ping? https://bugs.ruby-lang.org/issues/10902
I'd like to commit my second patch soon since this scan bothers me.
normalperson (Eric Wong)
09:17 PM Bug #11357 (Rejected): Segmentation Fault encountered ruby 2.2.1p85 (2015-02-26 revision 49769) [x86_64-darwin14]
My development machine recently upgraded to ruby 2.2.1 -- and has had the misfortune of running into a nasty segmentation fault. This has caused some significant problems in my workflow today and I wanted to notify you of the problem. ... jeffbowne (Jeff Bowne)
09:10 PM Feature #11356 (Closed): Add ECDH support to OpenSSL wrapper
FireFox wants to use ECDH on HTTP/2 connections, and there is no way to add it to the SSL context. This patch adds an ECDH callback (similar to the DH callback).
With this patch and #9390, I am able to get an HTTP/2 server running in...
tenderlovemaking (Aaron Patterson)
07:48 PM Feature #11339: [PATCH] io.c: avoid kwarg parsing in C API
normalperson@yhbt.net wrote:
> Feature #11339: [PATCH] io.c: avoid kwarg parsing in C API
> https://bugs.ruby-lang.org/issues/11339

> Note: I plan to followup commits for other *_nonblock methods
> Eventually, I even wish to depre...
normalperson (Eric Wong)
06:11 PM Revision 5522e010 (git): thread.c (thread_initialize): avoid RSTRING_PTR and NUMT2INT
Favor passing VALUE args as-is and using PRisVALUE in format strings
to prevent premature GC. In this case, we are not fixing any real
bug because location path has other references, but this makes code
easier-to-review.
git-svn-id: sv...
Eric Wong
04:59 PM Misc #11355 (Open): Exceptions inheriting from Timeout::Error should behave the same way
Bug #8730 addressed a common issue when using Timeout#timeout [*], but I think that the current behaviour is at the very least surprising.
Right now, exceptions provided to Timeout#timeout are rescuable from the inner block and that a...
astratto (Stefano Tortarolo)
04:42 PM Bug #11354 (Closed): Ruby Crash while
Hi there,
- Using rails 4.2.3
- Using Sorcery for authentication
- Running a THOR task during which creates the users. When activation tries to send the email to the user the program crashed with the log I'm attaching here. The same...
nreza (Reza Naq)
04:39 PM Revision 66a36e9b (git): * test/ruby/test_process.rb (test_exec_close_reserved_fd): test for
[Bug #11353]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51259 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
ngoto (Naohisa Goto)
04:39 PM Feature #11347: Errors with cause not reported properly to console
I rather think it is actually a bug because it hides very important information from the user. It's like showing your error cut in half or on more pieces. It's just confusing to use `causes` this way. So I call it a bug as the initial fe... akostadinov (Aleksandar Kostadinov)
04:11 PM Bug #9115: Logger traps all exceptions; breaks Timeout
Correction: providing an exception to Timeout#timeout would break it also in trunk.
It seems that by design inner blocks are able to rescue the exception provided to that method.
astratto (Stefano Tortarolo)
03:39 PM Revision 80025e95 (git): * 2015-07-16
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51258 b2dd03c8-39d4-4d8f-98ff-823fe69b080e svn[bot]
03:39 PM Revision 19c41354 (git): * .gitignore: ignore version.i. [ci skip]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51257 b2dd03c8-39d4-4d8f-98ff-823fe69b080e znz (Kazuhiro NISHIYAMA)
02:44 PM Revision 7a1413a7 (git): * test/ruby/test_process.rb (test_deadlock_by_signal_at_forking):
use RUBY (= EnvUtil.rubybin)
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51256 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
ngoto (Naohisa Goto)
02:31 PM Feature #9390: Support for the ALPN TLS extension
> I think we need to keep ‘selected’ markable by GC as long as anything
> ...
Thanks for spotting these! I've attached a new patch with these changes.
tenderlovemaking (Aaron Patterson)
03:08 AM Feature #9390: Support for the ALPN TLS extension
tenderlove@ruby-lang.org wrote:
> ~~~diff
> +ssl_alpn_select_cb(SSL *ssl, const unsigned char **out, unsigned char *outlen, const unsigned char *in, unsigned int inlen, void *arg)
> +{
> + int i = 0;
> + VALUE sslctx_obj...
normalperson (Eric Wong)
02:07 AM Feature #9390: Support for the ALPN TLS extension
Hi, I've attached a patch that adds ALPN support. I'll apply in a week if no one has objections!
Thanks!!
tenderlovemaking (Aaron Patterson)
02:26 PM Bug #11353 (Closed): ASYNC BUG after failure of Process.exec when closing FD 3 (or 4 or 5)
Applied in changeset r51255.
----------
* process.c (redirect_close, parent_redirect_close): should not close
reserved FD. It should be closed in the exec system call due to the
O_CLOEXEC or FD_CLOEXEC flag. [Bug #11353] [ruby-core:...
ngoto (Naohisa Goto)
02:23 PM Bug #11353 (Closed): ASYNC BUG after failure of Process.exec when closing FD 3 (or 4 or 5)
The following shows ASYNC BUG.
~~~
ruby -e 'Process.exec("/does_not_exist", "arg", {3=>:close})'
[ASYNC BUG] -e:1:in `exec': No such file or directory - /does_not_exist (Errno::ENOENT)
from -e:1:in `<main>'
consume_communication_...
ngoto (Naohisa Goto)
02:26 PM Revision d1bce9ec (git): * process.c (redirect_close, parent_redirect_close): should not close
reserved FD. It should be closed in the exec system call due to the
O_CLOEXEC or FD_CLOEXEC flag. [Bug #11353] [ruby-core:69977]
* process.c (close_unless_reserved): new function to close FD unless
it is reserved for internal commun...
ngoto (Naohisa Goto)
01:27 PM Revision ae406d9e (git): fix typos [ci skip]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51254 b2dd03c8-39d4-4d8f-98ff-823fe69b080e znz (Kazuhiro NISHIYAMA)
09:52 AM Bug #11088: On Exception too expensive inspect is called on recursive object graph with 3000 elements in it, swallows memory and ultimately doesn't deliver exception
After your input and directing me to inspect, I did some more testing and found that marshal has absolutely nothing to do with this problem. Writing custom inspect methods fixes the problem. Another question still remains for why is insp... kaiserprogrammer (Jürgen Bickert)
09:32 AM Revision dab4d077 (git): remove redundant NULL checks after RUBY_VM_IFUNC_P
* proc.c (proc_mark): remove redundant check
* vm.c (env_mark): ditto
This doesn't change object code size, but the unstripped
executable is smaller and the code less confusing.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51253 b...
Eric Wong
08:29 AM Revision a0908cb4 (git): remove redundant NULL check in mark functions
gc.c (gc_mark_children)only calls mark_func if the T_DATA ptr is
non-NULL, so avoid redundantly checking for that in each
mark function.
* iseq.c (iseq_mark): remove check for data pointer
* proc.c (binding_mark): ditto
* vm.c (rb_threa...
Eric Wong
07:55 AM Revision 28c42b4c (git): encoding.c: drop dummy encoding flag
* encoding.c (enc_autoload): drop dummy encoding flag from
the loaded encoding index. this flag is used only in this
source.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51251 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
nobu (Nobuyoshi Nakada)
05:43 AM Revision e262b29e (git): * vm.c (vm_make_env_each): add comments about env layout.
Do not use `i' to specify `new_ep'.
* vm.c (rb_proc_create, rb_vm_make_proc_lambda): envval is not used.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51250 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
ko1 (Koichi Sasada)
03:56 AM Revision daf7b1e4 (git): -test-/string: move
* ext/-test-/string/extconf.rb: move "-test-/string/string.so" to
"-test-/string.so".
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51249 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
nobu (Nobuyoshi Nakada)
01:29 AM Revision 4592e15e (git): string.c: remove redundant calls
* string.c (rb_str_enumerate_bytes, rb_str_enumerate_codepoints):
do not check if a block is given twice. RETURN_SIZED_ENUMERATOR
includes rb_block_given_p() check which is redundant here.
git-svn-id: svn+ssh://ci.ruby-lang.org/rub...
nobu (Nobuyoshi Nakada)
01:02 AM Bug #11351 (Closed): Random chrash [BUG] object allocation during garbage collection phase
nobu (Nobuyoshi Nakada)

07/14/2015

11:59 PM Revision bb8abf62 (git): gc.h: evaluate the macro argument only once
* gc.h (RUBY_MARK_UNLESS_NULL): evaluate the argument only once
to get rid of inadvertent side effects.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51247 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
nobu (Nobuyoshi Nakada)
11:20 PM Bug #10910: NoMethodError when opening SSL connection with OpenSSL::SSL::VERIFY_PEER set and anonymous ciphers allowed
Just wondering what the status is on this one. I noticed it got assigned to the openssl group a few months back, but there's been no word since then. Sinjo (Chris Sinjakli)
08:17 PM Bug #11352: Sample code Garbage collection dies with an address is T_NONE
> ./crash.rb
./crash.rb:5: [BUG] rb_gc_mark(): 0x85e344c is T_NONE
ruby 2.2.2p95 (2015-04-13 revision 50295) [i686-linux]
I was able to create a crash.rb file (attached) that would generate a crash. Essentially, we create a large...
fgifford (Frank Gifford)
08:11 PM Bug #11352 (Closed): Sample code Garbage collection dies with an address is T_NONE
fgifford (Frank Gifford)
06:03 PM Bug #11351 (Closed): Random chrash [BUG] object allocation during garbage collection phase
~~~
/home/jon/.rvm/gems/ruby-2.2.2/gems/newrelic_rpm-3.12.1.298/lib/new_relic/agent/transaction/developer_mode_sample_buffer.rb:47: [BUG] object allocation during garbage collection phase
ruby 2.2.2p95 (2015-04-13 revision 50295) [x86_...
jon (Jonas Jasas)
05:59 PM Revision 994460c4 (git): * vm_core.h, vm.c: remove rb_proc_t::envval because we can know it via
rb_proc_t::block::ep.
rb_vm_proc_envval(const rb_proc_t *proc) returns an Env object which
the Proc object use.
* proc.c: catch up this fix.
* vm_dump.c (rb_vmdebug_proc_dump_raw): ditto.
git-svn-id: svn+ssh://ci.ruby-lang.org/rub...
ko1 (Koichi Sasada)
05:36 PM Revision e07dad00 (git): * vm_core.h, vm.c: remvoe rb_env_t::prev_envval because we can know it
via env->ep.
rb_vm_env_prev_envval(env) returns prev_envval via env->ep.
* vm_core.h (rb_vm_env_local_variables): change parameter type
from VALUE (T_DATA/env) to `const rb_env_t *' to make same as
rb_vm_env_prev_envval().
* proc.c...
ko1 (Koichi Sasada)
04:26 PM Revision af4cbc4f (git): * remove trailing spaces.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51244 b2dd03c8-39d4-4d8f-98ff-823fe69b080e svn[bot]
04:23 PM Revision a82ce7c5 (git): * vm.c: refactoring Proc/Env related code.
* vm_core.h: remove blockprocval field from rb_proc_t and rb_binding_t.
Instead of this field, mark given block in Proc at rb_env_t::env.
* vm.c (vm_make_env_each): make an Env object with this layout.
And also simplify parameters.
*...
ko1 (Koichi Sasada)
03:09 PM Revision 50ae7506 (git): use _Static_assert with clang
* gc.c (__has_feature): move into internal.h.
* internal.h (__has_feature): ditto.
* internal.h (__has_extension): new macro.
* internal.h (STATIC_ASSERT): use _Static_assert with
clang. [ruby-core:69931] [Bug #11343]
git-svn-id: s...
znz (Kazuhiro NISHIYAMA)
03:02 PM Bug #11343 (Closed): random.c: getrandom compile error with clang
Applied in changeset r51240.
----------
fix compile error with clang
* random.c (fill_random_bytes_syscall): fix compile error with
clang. [ruby-core:69931] [Bug #11343]
Anonymous
03:01 PM Revision 0641e1fc (git): * 2015-07-15
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51241 b2dd03c8-39d4-4d8f-98ff-823fe69b080e svn[bot]
03:01 PM Revision b091903c (git): fix compile error with clang
* random.c (fill_random_bytes_syscall): fix compile error with
clang. [ruby-core:69931] [Bug #11343]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51240 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
znz (Kazuhiro NISHIYAMA)
02:31 PM Bug #11350: When Process.exec failed, redirections were still changed and not restored
On UNIX-like systems, native_stop_timer_thread(int close_anyway) in thread_pthread.c stops the timer thread, and if "int close_anyway" is true, it should close the communication pipe. However, currently, it does not close the pipe even i... ngoto (Naohisa Goto)
09:18 AM Bug #11350: When Process.exec failed, redirections were still changed and not restored
ngotogenome@gmail.com wrote:
> To avoid ASYNC BUG, is it possible to close timer-thread pipe after
> stopping the timer thread, and when Process.exec fails, to open the
> timer-thread pipe again before re-starting the timer thread?
...
normalperson (Eric Wong)
08:58 AM Bug #11350: When Process.exec failed, redirections were still changed and not restored
To avoid ASYNC BUG, is it possible to close timer-thread pipe after stopping the timer thread, and when Process.exec fails, to open the timer-thread pipe again before re-starting the timer thread?
ngoto (Naohisa Goto)
06:03 AM Bug #11350 (Open): When Process.exec failed, redirections were still changed and not restored
> Consider to create a child process using ::spawn or Kernel#system if this is
> ...
I think so, and I agree this is a spec.
I think the documentation should be added about the risk of ASYNC BUG when redirecting FDs that Ruby timer t...
ngoto (Naohisa Goto)
04:54 AM Bug #11350 (Feedback): When Process.exec failed, redirections were still changed and not restored
It is an example of the documented behavior described as follows.
```
* The modified attributes may be retained when
akr (Akira Tanaka)
04:27 AM Bug #11350 (Closed): When Process.exec failed, redirections were still changed and not restored
When Process.exec failed, redirections of file descriptors were changed and not restored.
When redirecting fd 3 or 5, ASYNC BUG occurred as below.
~~~
$ ruby -e 'begin; Process.exec("/does_not_exist", "arg", { 3=>["/dev/null", "w"...
ngoto (Naohisa Goto)
12:11 PM Bug #11342: ruby 2.2.2 will not compile on Solaris 11.2 32 or 64 bit
He managed to compile everything lately but has not yet commented here even though I suggested to him that he should. :)
I'll ask him again when I see him how he managed to compile it (he did manage to).
shevegen (Robert A. Heiler)
08:13 AM Revision 4ba1038a (git): rtname.cmd: extract at once
* win32/rtname.cmd: extract runtime DLL names at once, and other
refactoring.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51239 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
nobu (Nobuyoshi Nakada)
04:55 AM Revision f77967ad (git): test_filehandler.rb: fix UNC path failure
* test/webrick/test_filehandler.rb (test_short_filename): pass
document root path to cmd.exe instead of chdir there, as cmd.exe
does not start on UNC path.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51238 b2dd03c8-39d4-4d8f-9...
nobu (Nobuyoshi Nakada)
04:55 AM Revision 1c4fe8df (git): webrick/test_utils.rb: no timeout during assertion
* test/webrick/test_utils.rb (assert_expired): separate negated
assertion and block timeout excecptions.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51237 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
nobu (Nobuyoshi Nakada)
02:34 AM Revision cb041405 (git): timeout.rb: suppress a warning
* lib/timeout.rb (Timeout): get rid of an argument prefix warning.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51236 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
nobu (Nobuyoshi Nakada)
02:22 AM Revision 7d909eb2 (git): webrick/utils.rb: wakeup immediately
* lib/webrick/utils.rb (WEBrick::Utils::TimeoutHandler#register):
notify the handler thread of new timeout registration.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51235 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
nobu (Nobuyoshi Nakada)
02:21 AM Revision 8f6fed85 (git): webrick/utils.rb: adaptive sleep
* lib/webrick/utils.rb (WEBrick::Utils::TimeoutHandler#initialize):
make sleep intervals adaptive than fixed period intervals.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51234 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
nobu (Nobuyoshi Nakada)
02:20 AM Revision 5227d61e (git): * 2015-07-14
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51233 b2dd03c8-39d4-4d8f-98ff-823fe69b080e svn[bot]
02:20 AM Revision 18d47904 (git): test_utils.rb: split
* test/webrick/test_utils.rb (TestWEBrickUtils#do_tet_timeout):
split into tests.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51232 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
nobu (Nobuyoshi Nakada)
02:20 AM Revision 77cde58d (git): webrick/server.rb: stop immediately
* lib/webrick/server.rb (WEBrick::GenericServer#start): flush
shutdown pipe.
* lib/webrick/server.rb (WEBrick::GenericServer#stop): request the
server to stop immediately by sending data via shutdown pipe.
git-svn-id: svn+ssh://ci.r...
nobu (Nobuyoshi Nakada)

07/13/2015

05:17 PM Bug #11349 (Closed): irb crashes immediately with most (any?) REPL input
Any input to the irb REPL seems to crash it immediately. I haven't had any problems with pry or ruby itself--it seems to be just irb. I'm running Ruby 2.2.2p95 on Ubuntu 15.04. I'm using rbenv and ruby 2.2.1p85 (2015-02-26 revision 49769... deafbybeheading (Maciek Sakrejda)
02:58 PM Revision f162f207 (git): httpproxy.rb: fix typos [ci skip]
* lib/webrick/httpproxy.rb (WEBrick::HTTPProxyServer#do_CONNECT):
fix typos in debugger statements. [Fix GH-967]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51230 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
nobu (Nobuyoshi Nakada)
02:46 PM Revision f40138c5 (git): fix indent (tabify) [ci skip]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51229 b2dd03c8-39d4-4d8f-98ff-823fe69b080e znz (Kazuhiro NISHIYAMA)
02:45 PM Revision 32daf568 (git): fix indent (tabify) [ci skip]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51228 b2dd03c8-39d4-4d8f-98ff-823fe69b080e znz (Kazuhiro NISHIYAMA)
02:11 PM Bug #10968: [BUG] object allocation during garbage collection phase in /opt/rubies/ruby-2.2.1/lib/ruby/2.2.0/openssl/ssl.rb:177
Same problem for Ruby 2.2.2
Rails 4.2.3
Ruby 2.2.2 (using RVM)
Debian 7.
Stack trace: https://gist.github.com/noff/4c61cd980c098bba1041
Every cron task dies with such error, but everytime it happens in different files (ssl, new_re...
mkechinov (Michael Kechinov)
02:01 PM Feature #11348 (Feedback): TracePoint API needs events for fiber's switching
as discussed in https://github.com/deivid-rodriguez/byebug/issues/153 current implementation of byebug/debase has problem with stepping when Enumarator/Fiber is used. The problem is that Fiber completely replaces stack (w/o any events) ... os97673 (Oleg Sukhodolsky)
12:32 PM Bug #11342: ruby 2.2.2 will not compile on Solaris 11.2 32 or 64 bit
Try the following configure options.
Intel Solaris 11 64-bit compile:
~~~
% ./configure --build=x86_64-pc-solaris2.11 CFLAGS="-m64" LDFLAGS="-m64"
~~~
Intel Solaris 11 32-bit compile:
~~~
% ./configure --build=i386-pc-so...
ngoto (Naohisa Goto)
10:52 AM Revision f8fb526a (git): remove needless volatile
* array.c (rb_ary_each): remove needless volatile for outdated
clang 3.0. revert r32201.
* cont.c (cont_capture): ditto.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51227 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
nobu (Nobuyoshi Nakada)
10:11 AM Revision fa474e56 (git): timeout.rb: warn deprecated method
* lib/timeout.rb (timeout): warn as deprecated for a long time.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51226 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
nobu (Nobuyoshi Nakada)
10:07 AM Revision beb1c085 (git): use Timeout.timeout
* time: Object#timeout has been deprecated a long time ago, use
Timeout.timeout.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51225 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
nobu (Nobuyoshi Nakada)
09:36 AM Feature #11347 (Open): Errors with cause not reported properly to console
Hello, errors with `cause` are an important and very useful feature for debugging. It seems though default reporting is not showing the `cause` and nested causes to user. Here's a test file:
~~~ruby
raise "GAHGAH" rescue raise "error...
akostadinov (Aleksandar Kostadinov)
04:50 AM Revision 42f1ff12 (git): timeout.rb: internal constants
* lib/timeout.rb (Timeout): make internal constants private.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51224 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
nobu (Nobuyoshi Nakada)

07/12/2015

08:18 PM Feature #11346: New #intern_str or similarly-named method of Symbol to return a cached, frozen string (like "string".freeze)
In the description, "(assuming #to_s does)" should read "(assuming #to_s returns equivalent strings)". stevej (Steve Jorgensen)
07:11 PM Feature #11346 (Rejected): New #intern_str or similarly-named method of Symbol to return a cached, frozen string (like "string".freeze)
While I don't think it would be a good idea to change the behavior of the existing Symbol#to_s method as suggested in issue 11066, I think that it would be extremely useful to have some instance method of Symbol to perform that operation... stevej (Steve Jorgensen)
04:42 PM Bug #11345 (Closed): Failed to build standard library openssl on OSX 10.10.4
Applied in changeset r51222.
----------
* ext/openssl/ossl.c: [DOC] Backport ruby/openssl@dbb3fdb [Bug #11345]
Thanks to Tomoya Chiba for the report and help with patch.
zzak (zzak _)
04:24 PM Bug #11345 (Assigned): Failed to build standard library openssl on OSX 10.10.4
zzak (zzak _)
02:55 AM Bug #11345 (Closed): Failed to build standard library openssl on OSX 10.10.4
I failed to build standard library openssl when I use OpenSSL provided by Apple.
When I tried to build ruby by running `./configure && make`,
building of standard library openssl failed and was skipped.
I couldn't find the following e...
tomoasleep (Tomoya Chiba)
04:41 PM Revision d7de6e77 (git): * 2015-07-13
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51223 b2dd03c8-39d4-4d8f-98ff-823fe69b080e svn[bot]
04:41 PM Revision 385c0f10 (git): * ext/openssl/ossl.c: [DOC] Backport ruby/openssl@dbb3fdb [Bug #11345]
Thanks to Tomoya Chiba for the report and help with patch.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51222 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
zzak (zzak _)
01:13 PM Bug #11342: ruby 2.2.2 will not compile on Solaris 11.2 32 or 64 bit
He had more luck lately and managed to finish compilation.
There are still some problems though - he said a mixing of 32 bit and 64 bit, which
confuses him right now.
I told him to provide some more feedback; he currently recompil...
shevegen (Robert A. Heiler)
12:22 PM Bug #11342: ruby 2.2.2 will not compile on Solaris 11.2 32 or 64 bit
after ad hoc modification to tools/config.guess I am able to set correctly solaris 11.2 to x64_86 platform. but make still stumbles
dolly@vdocklab01:~/ruby-2.1.6$ autoconf
dolly@vdocklab01:~/ruby-2.1.6$ make
make: *** No targets spe...
aderium (Anthony Palermo)
12:21 AM Revision 3876d755 (git): * ext/socket/basicsocket.c: [DOC] typo (Errno::AGAIN -> Errno::EAGAIN)
* ext/socket/socket.c: ditto
* ext/socket/tcpserver.c: ditto
* ext/socket/udpsocket.c: ditto
* ext/socket/unixserver.c: ditto
* io.c: ditto
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51221 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
sorah (Sorah Fukumori)

07/11/2015

11:28 PM Bug #11344: Thread.handle_interrupt(TimeoutError => :never) が効かない
少なくとも Thread.handle_interrupt では Timeout::Error の指定は効かなかったので、しかたなく内部クラスの Timeout::ExitException を使ってたというライブラリもあるかもしれないので、
> 互換性を考えると ExitException = Timeout::Error とかしておいたほうがいいかなと思いますがどうでしょうか
に賛成です。
Mysql2 がそんな感じに使っちゃってます。 <http...
tommy (Masahiro Tomita)
12:13 AM Bug #11344: Thread.handle_interrupt(TimeoutError => :never) が効かない
`Timeout::ExitException`は内部用のクラスという認識でした。`:nodoc:`だし。 nobu (Nobuyoshi Nakada)
09:43 PM Revision 370cadcc (git): * 2015-07-12
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51220 b2dd03c8-39d4-4d8f-98ff-823fe69b080e svn[bot]
09:42 PM Revision a3d6de4a (git): Simple testing for StringIO#sysread
* test/stringio/test_stringio.rb (test_sysread): add a test for
StringIO#sysread. [Fix GH-966]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51219 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
nobu (Nobuyoshi Nakada)
08:43 PM Bug #10871: Sclass thread unsafe due to CREF sharing
Hi,
I pushed a branch containing ko1's patch onto https://github.com/nagachika/ruby/tree/ruby_2_2_singleton_class_threadsafe.
Please test your applications & libraries with it.
Regards,
nagachika (Tomoyuki Chikanaga)
12:16 PM Revision 8c0b261d (git): stringio.c: Fix an example doc [ci skip]
* ext/stringio/stringio.c (Init_stringio): [DOC] Fix an example,
StringIO#puts should be set "\n" at last. [Fix GH-965]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51218 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
nobu (Nobuyoshi Nakada)
03:55 AM Revision e7d6fc01 (git): * ChangeLog: typo.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51217 b2dd03c8-39d4-4d8f-98ff-823fe69b080e U.Nakamura
03:45 AM Revision a2b889f4 (git): timeout.rb: fix backtrace
* lib/timeout.rb (Timeout#timeout): remove regexp with wrong line
nuber and fix caller depth.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51216 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
nobu (Nobuyoshi Nakada)
12:11 AM Bug #10968: [BUG] object allocation during garbage collection phase in /opt/rubies/ruby-2.2.1/lib/ruby/2.2.0/openssl/ssl.rb:177
`crash_thin.txt` seems related to EventMachine.
Maybe it didn't acquire GVL properly.
nobu (Nobuyoshi Nakada)
12:07 AM Feature #11266 (Assigned): [PATCH] WEBrick: allow subclassing of Response and Request
nobu (Nobuyoshi Nakada)

07/10/2015

11:48 PM Revision 0d70cc5c (git): * 2015-07-11
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51215 b2dd03c8-39d4-4d8f-98ff-823fe69b080e svn[bot]
11:47 PM Revision 8d7058db (git): test_timeout.rb: add an assertion
* test/test_timeout.rb (test_custom_exception): assert that the
given exception will raise on timeout.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51214 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
nobu (Nobuyoshi Nakada)
07:14 PM Feature #11266: [PATCH] WEBrick: allow subclassing of Response and Request
Nobu, is there something else I can do? julik (Julik Tarkhanov)
06:10 PM Bug #10968: [BUG] object allocation during garbage collection phase in /opt/rubies/ruby-2.2.1/lib/ruby/2.2.0/openssl/ssl.rb:177
Upload failed for one of the stack traces I mentioned in the preceding comment. Here is that file. grey-owl (Steve Torrence)
06:09 PM Bug #10968: [BUG] object allocation during garbage collection phase in /opt/rubies/ruby-2.2.1/lib/ruby/2.2.0/openssl/ssl.rb:177
I have recently experienced two crashes (stack traces attached) that appear similar to Mr. Rigart's. Both appear to involve creation of a new array in methods called indirectly from the block passed to Thread.new.
Both occurred when ...
grey-owl (Steve Torrence)
03:39 PM Feature #10594: Comparable#clamp
Ferdinand Niedermann wrote:
> That doesn't really change anything
You're right, of course. I'm not sure why I read it as "raise unless `max > min`". The error message is still slightly ill-worded, but everything else looks good. I ho...
0x0dea (D.E. Akers)
05:32 AM Feature #10594: Comparable#clamp
D.E. Akers wrote:
> Ferdinand Niedermann wrote:
> ...
That doesn't really change anything, but I updated the pull request. I added some more tests to prove that it doesn't raise given equal `min` and `max`.
nerdinand (Ferdinand Niedermann)
03:36 PM Bug #9115: Logger traps all exceptions; breaks Timeout
I confirm that this bug is reproducible up to 2.2 and it's pretty easy to trigger.
~~~
require 'timeout'
require 'logger'
class MyExc < RuntimeError; end
def long_call(logger)
Timeout.timeout(3, MyExc) do
a = 1
lo...
astratto (Stefano Tortarolo)
03:05 PM Bug #11342: ruby 2.2.2 will not compile on Solaris 11.2 32 or 64 bit
Aderium also linked in this document for isainfo, in case that helps:
http://docs.oracle.com/cd/E19082-01/819-2380/enfli/index.html
shevegen (Robert A. Heiler)
02:57 PM Bug #11342: ruby 2.2.2 will not compile on Solaris 11.2 32 or 64 bit
Hello, some feedback in-between, from #ruby IRC.
Aderium says that uname yields wrong information because something may have
changed in between different solaris versions:
Aderium: isainfo -n
Aderium: uname -a spits out incorre...
shevegen (Robert A. Heiler)
10:32 AM Bug #11342: ruby 2.2.2 will not compile on Solaris 11.2 32 or 64 bit
Ok downloading the diff and testing compile with r50089
Make failed
./ext/extmk.rb:227:in `load': failed to load encoding (Windows-31J) (LoadError)
from ./ext/extmk.rb:227:in `block in extmake'
from /export/home/d...
aderium (Anthony Palermo)
10:31 AM Bug #11342: ruby 2.2.2 will not compile on Solaris 11.2 32 or 64 bit
make && sudo make install still fails but you are correct. I tried a couple of times and looks like the last one I forgot the sudo
option.c:886:33: error: expected declaration specifiers or ‘...’ before ‘u_int8_t’
/usr/include/sys...
aderium (Anthony Palermo)
12:59 AM Bug #11342: ruby 2.2.2 will not compile on Solaris 11.2 32 or 64 bit
this may be fixed wit h r50089 ngoto (Naohisa Goto)
01:48 PM Bug #11344: Thread.handle_interrupt(TimeoutError => :never) が効かない
一度は(それも結構長いあいだ) raise する例外が Timeout::ExitException になっていたことから、バックポート時は互換性を考えると `ExitException = Timeout::Error` とかしておいたほうがいいかなと思いますがどうでしょうか。 nagachika (Tomoyuki Chikanaga)
01:28 PM Bug #11344: Thread.handle_interrupt(TimeoutError => :never) が効かない
本題ではないですが、
2.0.0は脆弱性じゃなければ全部WONTFIXでOKです。
が、いちいち変えるの面倒なので、私も他のを変えるついで以外では変えてませんし、
特に気にせずREQUIREDにして頂いてもかまいません。
(もちろん問題の有無自体がわからなかったらUNKNOWNのままで可)
usa (Usaku NAKAMURA)
01:16 PM Bug #11344: Thread.handle_interrupt(TimeoutError => :never) が効かない
2.1にはそのままバックポートできるか分かりませんが、REQUIREDにしておきます。
2.0も動作は同じなのですが、`throw`/`catch`を使うようにするところからバックポートしないといけないので、とりあえずWONTFIXにしておきます。
nobu (Nobuyoshi Nakada)
01:06 PM Bug #11344 (Closed): Thread.handle_interrupt(TimeoutError => :never) が効かない
Applied in changeset r51213.
----------
timeout.rb: removed and use Timeout::Error
* lib/timeout.rb (ExitException): removed internal exception class
and use Timeout::Error instead, as using throw/catch to isolate
each timeouts now...
nobu (Nobuyoshi Nakada)
10:32 AM Bug #11344 (Closed): Thread.handle_interrupt(TimeoutError => :never) が効かない
るりま <http://docs.ruby-lang.org/ja/2.2.0/method/Thread/s/handle_interrupt.html> によると、`Thread.handle_interrupt(TimeoutError => :never)` で `TimeoutError` を制御できると書かれていますが、働きません。
~~~ruby
require 'timeout'
Thread.handle_interrupt(TimeoutE...
tommy (Masahiro Tomita)
01:05 PM Revision 0f663b24 (git): timeout.rb: removed and use Timeout::Error
* lib/timeout.rb (ExitException): removed internal exception class
and use Timeout::Error instead, as using throw/catch to isolate
each timeouts now. [ruby-dev:49179] [Bug #11344]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@5...
nobu (Nobuyoshi Nakada)
12:50 PM Revision 498b6f47 (git): zlib.c: GC guards
* ext/zlib/zlib.c: prevent from GC.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51212 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
nobu (Nobuyoshi Nakada)
12:49 PM Revision 41bd073d (git): zlib.c: protoize
* ext/zlib/zlib.c (do_checksum): protoize the definition.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51211 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
nobu (Nobuyoshi Nakada)
12:49 PM Revision d85096ad (git): compressed mantypes
* configure.in (--with-mantype): add compressed mantypes.
* tool/rbinstall.rb (man): compress man pages if specified.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51210 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
nobu (Nobuyoshi Nakada)
11:28 AM Bug #11336 (Closed): TestProcess#test_exec_fd_3_redirect failed on Solaris 10
Applied in changeset r51209.
----------
* process.c (rb_f_exec): rb_exec_without_timer_thread should be
used on every OS, not only on Mac OS X or Haiku, to prevent
timer thread communications using file descriptor 3 after
setting ...
ngoto (Naohisa Goto)
09:52 AM Bug #11336: TestProcess#test_exec_fd_3_redirect failed on Solaris 10
I forgot to mention that this was reproduced on x86_64 Linux. ngoto (Naohisa Goto)
09:46 AM Bug #11336: TestProcess#test_exec_fd_3_redirect failed on Solaris 10
The following example can reproduce the problem that the timer thread reads fd=3 after the redirection to fd=3 is set and before execve() is called, and then the script waits forever in b[0].read(1) and/or IO.for_fd(3).read(1).
~~~
...
ngoto (Naohisa Goto)
11:27 AM Revision 4d23a784 (git): * process.c (rb_f_exec): rb_exec_without_timer_thread should be
used on every OS, not only on Mac OS X or Haiku, to prevent
timer thread communications using file descriptor 3 after
setting redirection of the fd 3 before calling exec.
[Bug #11336] [ruby-core:69886]
git-svn-id: svn+ssh://ci.ru...
ngoto (Naohisa Goto)
08:42 AM Bug #11343 (Closed): random.c: getrandom compile error with clang

```
random.c:526:8: error: implicit conversion loses integer precision: 'long' to 'int' [-Werror,-Wshorten-64-to-32]
ret = syscall(SYS_getrandom, seed, size, 0);
```
which does make the build of clang fail
and there is a war...
Hanmac (Hans Mackowiak)
08:41 AM Revision d8f628e5 (git): dir.c: get attributes by fd
* dir.c (is_case_sensitive): get attributes by the file descriptor
of open directory, instead of using mount point name.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51208 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
nobu (Nobuyoshi Nakada)
01:46 AM Revision f7946774 (git): stringio.c: remove unnecessary check
* ext/stringio/stringio.c (writable): remove unnecessary check for
deprecated safe level 4. [Fix GH-963]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51207 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
nobu (Nobuyoshi Nakada)
01:23 AM Revision 53934115 (git): * 2015-07-10
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51206 b2dd03c8-39d4-4d8f-98ff-823fe69b080e svn[bot]
01:22 AM Revision 54d9c77c (git): extmk.rb: silently skip never-installed extensions
* ext/extmk.rb (extmake): as extension libraries start with '-'
are not installed always, no problems if no errors occurred.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51205 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
nobu (Nobuyoshi Nakada)

07/09/2015

11:44 PM Bug #11342 (Feedback): ruby 2.2.2 will not compile on Solaris 11.2 32 or 64 bit
Anthony Palermo wrote:
> make & sudo make install
> ...
You may want to run `make && sudo make install`.
You can run as `make SUDO=sudo install`.
> ~~~
> ...
Seems some more headers are needed.
Where is `uint8_t` defined on Solal...
nobu (Nobuyoshi Nakada)
10:17 PM Bug #11342: ruby 2.2.2 will not compile on Solaris 11.2 32 or 64 bit
ruby 2.1.x compiles just fine aderium (Anthony Palermo)
10:16 PM Bug #11342 (Closed): ruby 2.2.2 will not compile on Solaris 11.2 32 or 64 bit
~~~
make & sudo make install
[1] 23519
Password:
~~~
(snip)
~~~
option.c:886:33: error: expected declaration specifiers or ‘...’ before ‘u_int8_t’
option.c: In function ‘inspect_tcpi_options’:
option.c:898:5: error: ‘options’ ...
aderium (Anthony Palermo)
11:29 PM Bug #11341 (Third Party's Issue): Rails server command is not working fine
You load an extension library for 2.0 from 2.2.
Probably the usual rvm's bug.
~~~
0 ruby 0x000000010667b98b rb_vm_bugreport + 155
1 ruby 0x000000010651fe80 rb_bug_co...
nobu (Nobuyoshi Nakada)
05:03 PM Bug #11341: Rails server command is not working fine
The file which i uploaded is wrong one. sorry. This is the original one EshVal (Esh Val)
04:59 PM Bug #11341 (Third Party's Issue): Rails server command is not working fine
I wanted to run the rails server command and it's showing some log and it is crashed. EshVal (Esh Val)
11:12 PM Feature #10594: Comparable#clamp
Ferdinand Niedermann wrote:
> Here you go: https://github.com/ruby/ruby/pull/962
The failure condition should be `min > max` rather than `max < min`. It's arguably rather silly to clamp to a single value, but the operation is neverth...
0x0dea (D.E. Akers)
08:28 PM Feature #10594: Comparable#clamp
Here you go: https://github.com/ruby/ruby/pull/962 nerdinand (Ferdinand Niedermann)
07:33 AM Feature #10594: Comparable#clamp
> That `min > max` should raise an `ArgumentError` seems the only logical conclusion.
I agree. I'll send another pull request including that.
nerdinand (Ferdinand Niedermann)
07:54 AM Revision 3e972a11 (git): test_process.rb: test for [Bug #11340]
* test/ruby/test_process.rb (test_wait_exception): test for r51202
and r51203. [Bug #11340]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51204 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
nobu (Nobuyoshi Nakada)
06:38 AM Revision b3544b25 (git): * win32/win32.c (waitpid): fixed return value of previous commit. thanks, nobu!
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51203 b2dd03c8-39d4-4d8f-98ff-823fe69b080e U.Nakamura
06:11 AM Bug #11340 (Closed): Windows で Timeout.timeout を使って Process.waitpid を監視しても timeout が正しく動かない
Applied in changeset r51202.
----------
* win32/win32.c (waitpid): return immediately if interrupted.
reported by <takkanm AT gmail.com> [ruby-dev:49176] [Bug #11340]
usa (Usaku NAKAMURA)
05:00 AM Bug #11340 (Closed): Windows で Timeout.timeout を使って Process.waitpid を監視しても timeout が正しく動かない
以下のような、コードでプロセスの実行時間監視をしていたところ、
Windows とその他の環境で異なります。
~~~ruby
require 'timeout'
pid = Process.spawn('sleep', '10')
puts Time.now
begin
Timeout.timeout(1) {
Process.waitpid(pid)
}
rescue => e
p e
end
puts Time....
takkanm (三村 益隆)
06:10 AM Revision fcb79d53 (git): * win32/win32.c (waitpid): return immediately if interrupted.
reported by <takkanm AT gmail.com> [ruby-dev:49176] [Bug #11340]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51202 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
U.Nakamura
05:16 AM Feature #10829: Add to_proc method to the Array class
Have you seen Functors before?
https://www.ruby-forum.com/topic/4402886
baweaver (Brandon Weaver)
04:04 AM Revision f23adf74 (git): * vm_insnhelper.c (vm_search_super_method): use CI_SET_FASTPATH().
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51201 b2dd03c8-39d4-4d8f-98ff-823fe69b080e ko1 (Koichi Sasada)
02:10 AM Revision d53e1a79 (git): * vm_core.h: remove rb_call_info_t::klass because
rb_callable_method_entry_t has information about defined class.
* vm_insnhelper.c (vm_search_method): don't set ci->klass because
it is removed.
* vm_insnhelper.c (rb_equal_opt): ditto.
* vm_insnhelper.c (vm_search_superclass): removed...
ko1 (Koichi Sasada)
01:19 AM Revision ea67287a (git): * lib/net/http/responses.rb: Added 308 status to CODE_TO_OBJ list.
[fix GH-961] Patch by @billinghamj
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51199 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
hsbt (Hiroshi SHIBATA)
12:35 AM Revision dc2eb0c6 (git): * vm_core.h (rb_control_frame_t): fix comments (layout index).
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51198 b2dd03c8-39d4-4d8f-98ff-823fe69b080e ko1 (Koichi Sasada)
12:27 AM Bug #11327 (Closed): Improve duplicate key warning.
Applied in changeset r51196.
----------
* parse.y: Improve duplicate key warning with patch by @andremedeiros
[Fix GH-938] https://github.com/ruby/ruby/pull/938 [Bug #11327]
zzak (zzak _)
12:27 AM Revision 701024f9 (git): * 2015-07-09
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51197 b2dd03c8-39d4-4d8f-98ff-823fe69b080e svn[bot]
12:27 AM Revision d5e6c167 (git): * parse.y: Improve duplicate key warning with patch by @andremedeiros
[Fix GH-938] https://github.com/ruby/ruby/pull/938 [Bug #11327]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51196 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
zzak (zzak _)
 

Also available in: Atom