Activity
From 05/12/2015 to 05/18/2015
05/18/2015
-
09:08 PM Bug #11143: it should always be possible to return from an if
- What is the objection to providing some sort explanation when rejecting a bug report?
-
- Nobuyoshi Nakada wrote:
> Why do you need such assignment?
What does my "need" have to do with whether something should be a syntax error or not?
Just about everything in ruby is an expression and all expressions can potentially f... -
05:49 PM Feature #11158: Introduce a Symbol.count API as a more efficient alternative to Symbol.all_symbols.size
- Sounds good, I'll take a stab tonight.
-
03:52 PM Feature #11158: Introduce a Symbol.count API as a more efficient alternative to Symbol.all_symbols.size
- I'd recommend instead to introduce `Symbol.each`, which would accept a block and return an `Enumerable` when none is given.
`Symbol.each.size` would be then be an efficient (lazy) way of getting the number of symbols, and it would be ... -
04:49 PM Feature #11154 (Feedback): Postfix `!?` can use as the valid function identifier.
- Hi,
First of all, this is a proposal for incompatible change, so we have to be very careful.
Besides that, I am afraid you have two misunderstandings. (a) in Ruby, "!" is not for methods with side effect, unlike Scheme. (b) predic... -
01:30 PM Revision 53411d3e (git): fix a typo [ci skip]
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@50532 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
10:30 AM Revision 0a933cf3 (git): nonblock.c: just yield if the flag is not changed
- * ext/io/nonblock/nonblock.c (io_nonblock_set): return whether
nonblock flag was changed.
* ext/io/nonblock/nonblock.c (rb_io_nonblock_block): nothing to
restore but just yield unless nonblock flag is changed.
git-svn-id: svn+ssh:/... -
- * test/socket/test_nonblock.rb (test_accept_nonblock): refine
assertion for better failure message.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@50530 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * test/ruby/test_autoload.rb (add_autoload): use class_eval
instead of string eval.
* test/ruby/test_autoload.rb (remove_autoload_constant): ditto.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@50529 b2dd03c8-39d4-4d8f-98ff-823fe... -
- * gc.c (obj_info): remove needless ifdef, and adjust indent.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@50528 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Since this commit `TestAutoload#test_threaded_accessing_constant` continuously fails on some Linux distributions.
e.g.: http://rubyci.blob.core.windows.net/ubuntu1404/ruby-trunk/log/20150514T220002Z.fail.html.gz -
- * include/ruby/intern.h (rb_f_notimplement): should not respond to
not-implemented methods. as the address inside a DLL and the
imported address are different on Windows, use an exported
variable to share the same address.
git-sv... - 04:56 AM Revision 15b97489 (git): * 2015-05-18
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@50526 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
04:56 AM Revision 7be51698 (git): * lib/monitor.rb (mon_try_enter, mon_enter): should reset @mon_count
- just in case the previous owner thread dies without mon_exit.
[fix GH-874] Patch by @chrisberkhout
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@50525 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
05/17/2015
-
10:32 PM Bug #11160 (Closed): Subclasses of Proc converted when passed to a block
- As Subclasses of Proc are passed as-is when sent to methods as blocks, it would be expected that the same behavior occurs when passing such a subclass of Proc to a block. However, Ruby's block.call somehow converts the block to a Proc, l...
-
09:14 PM Bug #11159 (Closed): RubyVM::InstructionSequence.compile(nil) #=> segfault
- The following code causes a segfault both for Ruby 2.2.2 and Ruby 2.2.0 (I haven't tested other versions).
The trace is attached.
~~~ruby
RubyVM::InstructionSequence.compile(nil)
~~~ -
- * ext/-test-/notimplement, test/-ext-/test_notimplement.rb:
rename from bug-3662.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@50524 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
08:22 AM Feature #11136 (Closed): [PATCH] webrick: avoid fcntl module - Applied in changeset r50523.
----------
lib/webrick/utils.rb: simplify by avoiding fcntl
IO#nonblock= and IO#close_on_exec= methods are simpler-to-use
and potentially more portable to for future OSes.
IO#nonblock= and IO#close_on_exec=... - 08:22 AM Revision 29a914ff (git): lib/webrick/utils.rb: simplify by avoiding fcntl
- IO#nonblock= and IO#close_on_exec= methods are simpler-to-use
and potentially more portable to for future OSes.
IO#nonblock= and IO#close_on_exec= are also smart enough to avoid
redundantly setting flags so a syscall may be avoided.
The... -
- Applied in changeset r50522.
----------
numeric.c: Numeric#positive? and Numeric#negative?
* numeric.c (num_positive_p, num_negative_p): add methods
Numeric#positive? and Numeric#negative?.
[ruby-core:69173] [Feature #11151]
* nume... -
- * numeric.c (num_positive_p, num_negative_p): add methods
Numeric#positive? and Numeric#negative?.
[ruby-core:69173] [Feature #11151]
* numeric.c (flo_positive_p, flo_negative_p): specialiazed
functions for Float.
* complex.c (Init... -
- * test/ruby/test_numeric.rb: use separate dummy classes for each
test cases.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@50521 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 05:59 AM Feature #11137 (Closed): [PATCH] webrick: remove redundant close-on-exec setting
- Applied in changeset r50519.
----------
lib/webrick/server.rb: avoid redundant fcntl call
Sockets are close-on-exec by default since Ruby 2.0, so it
is redundant to set it again.
* lib/webrick/server.rb (accept_client): avoid redundan... -
- * numeric.c (compare_with_zero): raise TypeError when not
comparable with 0.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@50520 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 05:59 AM Revision ce34a90f (git): lib/webrick/server.rb: avoid redundant fcntl call
- Sockets are close-on-exec by default since Ruby 2.0, so it
is redundant to set it again.
* lib/webrick/server.rb (accept_client): avoid redundant fcntl call
[Feature #11137]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@50519 b2d... - 05:56 AM Feature #11138 (Closed): [PATCH] ext/socket/init.c: use SOCK_NONBLOCK if available
- Applied in changeset r50518.
----------
ext/socket/init.c: use SOCK_NONBLOCK if available
This saves a system call by allowing us to use SOCK_NONBLOCK in
Linux when accept4 is available.
Note: I do not agree accept_nonblock should alw... - 05:56 AM Revision 8ff35b81 (git): ext/socket/init.c: use SOCK_NONBLOCK if available
- This saves a system call by allowing us to use SOCK_NONBLOCK in
Linux when accept4 is available.
Note: I do not agree accept_nonblock should always make accepted
sockets non-blocking, and will propose a future API to allow
controlling w... -
- * bootstraptest/runner.rb, sample/test.rb, test/lib/test/unit.rb:
shared the default colors from test/colors file.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@50517 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * bootstraptest/runner.rb, sample/test.rb, test/lib/test/unit.rb:
reset for each colors.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@50516 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
05/16/2015
- 07:03 PM Bug #11155 (Closed): Files named 'b' cannot be autoloaded
- Applied in changeset r50515.
----------
* load.c (loaded_feature_path): stop returning false negatives for
filenames which are trailing substrings of file extensions. For
example, 'b', which a trailing substring of ".rb" should not... -
07:02 PM Revision 1fc214c0 (git): * load.c (loaded_feature_path): stop returning false negatives for
- filenames which are trailing substrings of file extensions. For
example, 'b', which a trailing substring of ".rb" should not return
false. [Bug #11155][ruby-core:69206]
* test/ruby/test_autoload.rb: test for fix
git-svn-id: svn+ss... - 03:02 PM Revision fc7711ff (git): * 2015-05-17
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@50514 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- This commit changes some of the `require` tests to run *without*
rubygems enabled. Those particular tests were removing rubygems from
$LOAD_PATH. These tests assert that a `LoadError` is raised.
Unfortunately, since RubyGems was enable... -
- Makes sense, my bad, thanks for the consideration.
-
- Lourens Naudé wrote:
> Please let me know if this is inline with an expected core API, anything I could clean up further and if there's any possibility of such a change also being backported to 2.1 as well? (happy to create a new patch ... -
- We're in the process of migrating a very large Rails codebase from a Ruby 2.1.6 runtime to Ruby 2.2.2 and as part of this migration process would like to keep track of Symbol counts and Symbol GC efficiency in our metrics system. Prefera...
-
- * ext/socket/ifaddr.c (rsock_getifaddrs): make wrapper object
before result structs allocation and manage refcount for each
elements to get rid of potential memory leak.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@50512 b2dd03... -
- * parse.y (rb_parser_new, ripper_s_allocate): allocate structs
with making new wrapper objects and get rid of potential memory
leak.
* variable.c (rb_autoload): ditto.
* ext/digest/digest.c (rb_digest_base_alloc): ditto.
* ext/str... -
- * error.c (rb_name_err_mesg_new): new wrapper object before
allocate data area and get rid of potential memory leak.
GC guards are no longer needed.
* file.c (stat_new_0): ditto.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@50... -
12:41 PM Bug #11132 (Closed): String#sub and character sequence \' in replacement string
- Applied in changeset r50509.
----------
* string.c: added documentation for character sequence \' with String#sub
[Bug #11132][ruby-core:69121][fix GH-900][ci skip] Patch by @shishir127 -
- [Bug #11132][ruby-core:69121][fix GH-900][ci skip] Patch by @shishir127
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@50509 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- [fix GH-901][ci skip]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@50508 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * proc.c (rb_proc_alloc, proc_dup): allocate rb_proc_t instead of
wrapping to get rid of potential memory leak.
* vm.c (rb_proc_create): ditto.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@50507 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * gc.c (rb_data_object_wrap, rb_data_typed_object_wrap): rename
alloc as wrap. these functions do not allocate data pointers
but just wrap the given pointers.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@50506 b2dd03c8-39d4-4d... - 11:00 AM Revision 4eb4f1fd (git): * win32/win32.c (rb_w32_accept): simplified.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@50505 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 10:45 AM Revision 23c5aa3a (git): * 2015-05-16
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@50504 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@50503 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Juan Francisco Raposeiras wrote:
> ~~~
> ...
You mix an extension library for old version ruby.
-
04:12 AM Bug #11157 (Rejected): [BUG] Segmentation fault at 0x00000000000018
- This happens whenever I try to install any gem (maybe related to #11135)
~~~
/home/frank/.gem/ruby/2.2.2/gems/json-1.8.2/lib/json/common.rb:67: [BUG] Segmentation fault at 0x00000000000018
ruby 2.2.2p95 (2015-04-13 revision 50295) [... -
08:06 AM Bug #11156: Indeterminate Behavior for Curly-braced Blocks with Function Argument Missing Parenthesis
- I'm trying to demonstrate that the syntax is very confusing and error-prone, especially given that `do ... end` blocks do not behave similarly due to precedence differences.
Consider the `travel_to` time travel method given by Rails' ... -
- What's your point?
`Time.parse` states as:
# If a block is given, the year described in +date+ is converted by the
# block. For example:
#
# Time.parse(...) {|y| 0 <= y && y < 100 ? (y >= 69 ? y + 1900 : y +... -
- Removed that garbage.
05/15/2015
-
- Given a function that takes an argument and a block, the behavior wildly varies when parenthesis are omitted from the functions argument.
Consider the following function:
~~~ruby
require 'time'
def example(arg)
puts arg
i... -
08:59 PM Bug #10268: OpenSSL::PKey::EC::Point#mul causes a segmentation fault
- This bug is due to passing null pointers to EC_POINTs_mul(). This function, in turn, does not handle null pointer arguments. Looking over the code, there are several points where the results of GetBNPtr() are used without checking for nu...
-
- I have two files:
a.rb
~~~ruby
module A
autoload :C, 'b'
end
p ::A::C
~~~
b.rb
~~~ruby
puts "START"
module A
class C
end
end
puts "FINISH"
~~~
When I run a.rb, I get an exception:
~~~
[aaron@TC xxx ... -
- Usaku NAKAMURA wrote:
> Aaron, this commit breaks some tests on `ruby/test_require.rb`.
> ...
@Usa I'm looking in to it. It seems to be a bug with looking up activated features during autoload. :( -
06:43 AM Feature #11140 (Assigned): Allow rubygems' `require` to handle `autoload` calls
- Aaron, this commit breaks some tests on `ruby/test_require.rb`.
Check [RubyCI](http://rubyci.org/). -
02:31 PM Feature #11154 (Feedback): Postfix `!?` can use as the valid function identifier.
- This patch make it possible to parse and execute such a code:
```ruby
def foo!?
true
end
foo!?
```
*When is this patch useful?*
Let's say, there are two methods. One method named `ExampleDB#exists?(id)` which is to re... -
12:42 PM Bug #11149: URI.parse keeps '?' for query and '#' for fragment even if they are empty
- Actually yes, I was wrong on this and it is expected behavior.
When one wants without '?' and '#' correct way is to set to nil and not to empty string ''
~~~
p.query = nil
p.fragment = nil
~~~ -
- * range.c (range_include): call rb_str_include_range_p on String.
* string.c (str_upto_each): extract from rb_str_upto.
* string.c (rb_str_include_range_p): move String specific code
from Range#include? in range.c.
git-svn-id: svn+s... -
- * array.c (rb_ary_assoc, rb_ary_rassoc): [DOC] the result when key
was found is the existing element, not a new array. reported by
Giau Nguyen <giaunv AT nustechnology.com>.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@50501 b... -
- * string.c (all_digits_p): extract duplicate code from
rb_str_upto.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@50500 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * range.c (r_less): merge r_le() and r_lt() and make code shorter
with less branches.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@50499 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * range.c (r_cover_p): extract from range_cover and share with
range_include.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@50498 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * lib/cgi/cookie.rb (CGI::Cookie#secure): revert part of r50496,
which is irrelevant to GH-887, as the document states that the
argument must be a boolean.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@50497 b2dd03c8-39d4-4d8f-9...
05/14/2015
- 11:27 PM Revision a4344cb5 (git): * lib/cgi/cookie.rb: Implement HttpOnly flag for cookies.
- [fix GH-887] Patch by @martinpovolny
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@50496 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 09:58 PM Feature #11140 (Closed): Allow rubygems' `require` to handle `autoload` calls
- Applied in changeset r50494.
----------
* variable.c: Change autoload to call `require` through Ruby rather
than directly calling `rb_require_safe`. This allows things like
RubyGems to intercept file loading done though `autoload`.... -
- Accepted. Could you apply the patch, Aaron?
Matz.
- 09:57 PM Revision d4011b3a (git): * 2015-05-15
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@50495 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- than directly calling `rb_require_safe`. This allows things like
RubyGems to intercept file loading done though `autoload`.
[Feature #11140]
* test/ruby/test_autoload.rb: Test for change.
git-svn-id: svn+ssh://ci.ruby-lang.org/rub... -
08:32 PM Bug #11101: Forking is killing my memory when running GC
- I have looked at the thing closely and it seems that the GC is not CoW friendly for sparse arrays. If I create an array of undefined size and populate it with random numbers in string format, the GC will launch the CoW in the fork. Howev...
-
08:13 PM Bug #10933: [BUG] object allocation during garbage collection phase
- Backported into `ruby_2_2` branch at r50493.
-
- * symbol.c (Init_sym): make dsym_fstrs a hash compared by identity
as the keys are unique fstrings, to get rid of running hash and
compare methods and causing new object allocation during garbage
collection ... -
07:48 PM Feature #11146: [PATCH] variable.c: initialize generic_iv_tbl at start
- SASADA Koichi <ko1@atdot.net> wrote:
> On 2015/05/14 5:15, Eric Wong wrote:
> > That's one, but I think generic ivar is common enough. I'll also
> > work on using ivar index + array (like T_OBJECT) to reduce hash table
> > entries ... -
10:48 AM Feature #11146: [PATCH] variable.c: initialize generic_iv_tbl at start
- On 2015/05/14 5:15, Eric Wong wrote:
> That's one, but I think generic ivar is common enough. I'll also
> work on using ivar index + array (like T_OBJECT) to reduce hash table
> entries for most generic cases.
This is just curiou... -
07:07 PM Bug #11149 (Assigned): URI.parse keeps '?' for query and '#' for fragment even if they are empty
- As URL Standard, current behavior is correct.
https://url.spec.whatwg.org/
But Google Chrome's behavior is like what you say.
I keep watching how W3C/WHATWG decide this behavior. -
06:18 PM Bug #10871: Sclass thread unsafe due to CREF sharing
- I recently opened bug #11153 which may be related. When using threads, methods defined inside `class << obj` sometimes fail to work. Feel free to close mine as a duplicate if it is the same underlying cause. In any case I would also appr...
-
- This may be a duplicate of #10871.
-
- Defining singleton methods using this syntax occasionally produces unexpected results when run in parallel with multiple threads:
~~~
class << obj
def method_one
end
def method_two
end
end
~~~
Sometimes not all of th... -
- FYI:
Kazuki Tanaka-san proposed a library Kasen.
[ruby-list:50120] [ANN] Kasen(下線) v0.1.1
Github: https://github.com/gogotanaka/_
Rubygems: https://rubygems.org/gems/kasen
It introduces special method "_" (underscore, Kasen in J... -
10:44 AM Feature #11049 (Closed): Enumerable#grep_v (inversed grep)
- Thanks, committed at r50491, r50492.
-
- `grep_v` seems OK. Accepted.
Matz.
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@50492 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Implement Enumerable#grep_v.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@50491 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- I am not positive about this syntax mostly because it appears to be set syntax, or old style hash in 1.8.
Once ES6 syntax become more popular, there will be chance for this change in the future.
Matz.
-
- Nobuyoshi Nakada wrote:
> > lexington:ruby$ ./ruby x.rb
> ...
Because I don't come up with any use case of such ugly key names.
I believe code like {a, @a} should not be used in real world applications.
-
- Realistic use-case is written. Accepted.
But it should recognize complex numbers (should raise exception).
Matz.
-
01:20 AM Feature #11151: Numeric#positive? and Numeric#negative?
- > You probably mean Integer and Float. And possibly also Rational.
Yeah.
For what I could see, probably we'll just need to publish two functions that we are already using internally. https://github.com/ruby/ruby/blob/d77f4934f8ede1... -
- It's because ** tries to pass keyword hash (this caes empty) as an argument, so that old style
```ruby
def foo(h)
end
foo(**{})
```
to work. In anyway, passing keyword arguments to a method that does not take any keyword ... -
- We haven't thought of self as a receiver. Agreed to remove warnings.
Matz.
-
- Applied in changeset r50490.
----------
* ext/pathname/lib/pathname.rb: Remove condition of RUBY_VERSION <= 1.9.
[Feature #11082] -
- [Feature #11082]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@50490 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Accepted. Go ahead.
Matz.
05/13/2015
-
10:22 PM Bug #11152 (Closed): Resolv::DNS should use Search Domains provided in /etc/resolv.conf by default
- For some reason Resolv::DNS does not use search domains. Many downstream projects rely on Resolv, and this appears broken. I'm showing this below in Kubernetes, but it's based on the search domain(s), rather than a cluster issue.
~~~
... -
10:19 PM Feature #11151: Numeric#positive? and Numeric#negative?
- On 14/05/2015, rafaelmfranca@gmail.com <rafaelmfranca@gmail.com> wrote:
> Issue #11151 has been updated by Rafael França.
>
>
> Right. Thank you for the explanation.
>
> So maybe just to `Fixnum` and `Float`?
>
You probably me... -
- Right. Thank you for the explanation.
So maybe just to `Fixnum` and `Float`? -
- In #5113, matz said
* We can use `> 0` and `< 0` for the purpose.
* Complex is Numeric, but we cannot define positive? and negative? for it.
The latter is just appropriate comment, I think.
-
- We just added [`Interger#positive?` and `Interger#negative?` to Active Support](https://github.com/rails/rails/commit/e54277a45da3c86fecdfa930663d7692fd083daa).
I was wondering if we could get that implemented in Ruby itself and searc... -
10:17 PM Feature #5480: remove GServer from stdlib
- For those that absolutely need to use GServer, it's also available on rubygems.
* https://rubygems.org/gems/gserver
* https://rubygems.org/gems/rubysl-gserver
However, GServer isn't being maintained, so users should migrate to an ... - 10:01 PM Revision f51a964d (git): * 2015-05-14
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@50489 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * variable.c (rb_set_class_path_string, rb_set_class_path): get
rid of creating intermediate IDs.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@50488 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- nobu@ruby-lang.org wrote:
> Probably, due to `@gem_prelude_index` of `$LOAD_PATH` elements?
That's one, but I think generic ivar is common enough. I'll also
work on using ivar index + array (like T_OBJECT) to reduce hash table
en... -
- Probably, due to `@gem_prelude_index` of `$LOAD_PATH` elements?
-
- I'm biased here since we already implemented part of Option #5 on Ruby on Rails but I prefer its explicitness over concision. It is not clear to me what `rekey` and `revalue` does.
-
05:57 PM Feature #11148: Add a way to require files, but not raise an exception when the file isn't found
- Aaron Patterson wrote:
> @Benoit yes, for performance, and to avoid catching load errors. If my plan is successful, rubygems would stop adding directories to the load path. That means searching *should* be relatively fast (since the l... -
- @nobu I was thinking the same, but this was the smallest patch that would accomplish what I need
@Benoit yes, for performance, and to avoid catching load errors. If my plan is successful, rubygems would stop adding directories to the... -
- Why is that exception problematic?
For performance (the cost of the search is already large I suppose)
or to only catch the LoadError from require and not accidentally from somewhere else? (this could potentially affect compatibility) -
- Although I had an idea to separate `require` into "search" and "load", this may be simpler.
-
- Backported into `ruby_2_2` branch at r50487.
-
- * parse.y (lambda): push and reset cmdarg_stack in lambda body.
[ruby-core:69017] [Bug #11107]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_2@50487 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- r50410, r50412, r50413, r50414, r50415 and r50416 were backported into `ruby_2_2` at r50486.
-
- dln.c: use EXPORT_PREFIX
* configure.in (EXPORT_PREFIX): define exported symbol prefix
string in config.h.
* dln.c (FUNCNAME_PREFIX): use configured EXPORT_PREFIX, not
hardcoded condition.
* dln.c (dln_load)... -
- Backported into `ruby_2_1` branch at r50485.
-
- * lib/fileutils.rb (FileUtils#mv): show the exact target path in
the error message instead of the destination parent directory
name. patched by Joao Britto <jabcalves AT gmail.com> at
[ruby-core:68706]. [B... -
- Backported into `ruby_2_2` branch at r50484.
-
- * thread_pthread.c (reserve_stack): keep sp safe zone to get rid
of crash by -fstack-check. [ruby-core:68740] [Bug #11030]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_2@50484 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
03:04 PM Feature #11141: new syntax suggestion for abbreviate definition on block parameters in order
- Hans Mackowiak wrote:
> my problem i got with that new syntax is what does it do when i have blocks inside of blocks, specially with different arity count ...
I'd say, such a implicit block parameters should only be possible for the ... -
06:34 AM Feature #11141: new syntax suggestion for abbreviate definition on block parameters in order
- my problem i got with that new syntax is what does it do when i have blocks inside of blocks, specially with different arity count ...
like
~~~
{key1 => value1, key2 => value2}.each { |key, value|
[obj1, obj2, obj3].each { |ob... -
08:25 AM Bug #11130: Re: [ruby-changes:38376] glass:r50457 (trunk): * enum.c (enum_to_a): Use size to set array capa when possible.
- 再入チェックを入れてパフォーマンスを比較した結果、改善が見られなかったのでrevertしました。
再入チェック付の最適化:
ruby-dev bm_enum_to_a_sized.rb 19.46s user 1.29s system 99% cpu 20.760 total
ruby-dev bm_enum_to_a_sized.rb 19.46s user 1.29s system 99% cpu 20.754 total
ruby-dev bm_e... - 08:19 AM Bug #11130 (Closed): Re: [ruby-changes:38376] glass:r50457 (trunk): * enum.c (enum_to_a): Use size to set array capa when possible.
- Applied in changeset r50483.
----------
* enum.c (enum_to_a): revert r50457.
it requires recursion check.
then, it doesn't make performance improvement.
[Bug #11130] [Feature #9118] - 08:19 AM Feature #9118 (Closed): In Enumerable#to_a, use size to set array capa when possible
- Applied in changeset r50483.
----------
* enum.c (enum_to_a): revert r50457.
it requires recursion check.
then, it doesn't make performance improvement.
[Bug #11130] [Feature #9118] -
- it requires recursion check.
then, it doesn't make performance improvement.
[Bug #11130] [Feature #9118]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@50483 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 05:33 AM Revision 0cddf1b4 (git): merge revision(s) 49095: [Backport #11144]
- * lib/resolv.rb (Resolv::DNS::Label::Str#==): Check class equality.
(Resolv::DNS::Name#initialize): Normalize labels as
Resolv::DNS::Label::Str objects.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_1@... -
- Why do you need such assignment?
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@50481 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * parse.y (parse_gvar): separate message for gvar without
non-space characters from message for invalid identitirs.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@50480 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 02:11 AM Revision 5b80ca1d (git): * 2015-05-13
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@50479 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * test/ruby/test_parse.rb (test_dstr_disallowed_variable): fix
duplicate variable name to be tested.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@50478 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
05/12/2015
-
- ~~~
p = URI.parse('http://example.com/path?query#fragment')
p.query = ''
p.fragment = ''
puts p.to_s
~~~
will output "http://example.com/path?#" but I think it should be "http://example.com/path" without '?' and '#'
-
- Hi,
I'm trying to make is so that RubyGems doesn't need to put directories on $LOAD_PATH (which is why I submitted Feature #11140). I would like the `require` implemented in RubyGems to look up the file from a cache generated when th... -
10:21 PM Bug #11147 (Closed): [SEGFAULT] While looping gets
- $ pod install
Analyzing dependencies
/Users/ssoffes/.rbenv/versions/2.2.2/lib/ruby/gems/2.2.0/gems/cocoapods-0.37.1/lib/cocoapods/executable.rb:83: [BUG] Segmentation fault at 0x00000000000000
ruby 2.2.2p95 (2015-04-13 revision 50295)... -
- Even miniruby creates one generic ivar (plain "ruby" creates 9),
so there's no point in lazily allocating the table and increasing
lines of code.
I'll commit in a few days unless there's objections.
I dumped generic ivar counts w... -
- MSG_DONTWAIT is enough to force non-blocking I/O under Linux,
so avoid changing the state of a socket. This will allow certain
threads to do a non-destructive non-blocking "peek" while others
block (without relying on an extra ppoll ... -
06:41 PM Bug #10871: Sclass thread unsafe due to CREF sharing
- I also would very much like a backport of this, as it effectively makes certain bits of "idiomatic" ruby inherently (and very unexpectedly) completely thread-unsafe - see https://github.com/puma/puma/issues/647
-
- ```
irb(main):001:0> def foo; a = if true then return end end
SyntaxError: (irb):1: void value expression
```
it should not matter that you are not producing a value for the if expression, since you are leaving the method immediate... -
- SHIBATA Hiroshi <shibata.hiroshi@gmail.com> wrote:
> Eric Wong <normalperson@yhbt.net> wrote:
> > Is it OK to email patches directly to maintainers (perhaps Cc:
> > ruby-core?). If so, can this be stated explicitly?
>
> It's ok,... -
- > How are users who refuse to use proprietary websites or refuse the
> terms-of-service expected to contribute to this (and other extracted
> gems?)
I understood your opinion.
> Is it OK to email patches directly to maintainers ... -
04:09 PM Bug #11142 (Assigned): Command line argument parser on windows handles double quotes inconsistently.
- I believe the issue is with https://github.com/ruby/ruby/blob/trunk/win32/win32.c#L1671 through 1673.
C:\Users\ksubrama>ruby -e "puts ARGV" "foo""bar"
foo"bar
C:\Users\ksubrama>ruby -e "puts ARGV" "foo"" bar"
foo"
bar
I belie... -
- Nobuyoshi Nakada wrote:
> What about `@1`?
I liked this one at first glance, but it might confuse people, because you could think the scoping would be similar to `@instance` variables.
Some brainstorming:
~~~ruby
->{ puts $a, ... -
03:08 PM Feature #11141: new syntax suggestion for abbreviate definition on block parameters in order
- It gets a bit more line-noisy, but why not a couple of sigils? Maybe:
```ruby
x.method { @[1] - @[2] }
```
---
Austin Ziegler * halostatue@gmail.com * austin@halostatue.ca
http://www.halostatue.ca/ * http://twitter.com/halostatue -
- Arnold Roa wrote:
> On method definition we can use `*args` for multiple arguments, so what about `*1`, `*2`, `*3`?
> ...
It has obvious ambiguity.
How will you interpret `foo(*1)`, a splat or the short-hand syntax? -
01:53 PM Feature #11141: new syntax suggestion for abbreviate definition on block parameters in order
- Yukihiro Matsumoto wrote:
> We cannot use `$1` etc. as they are already taken for `Regexp` match.
> ...
Yes, I just use `$1` as an example to explain the idea, by no means I think `$1` would be a good choice as `$` is for global variab... -
- What about `@1`?
-
- We cannot use `$1` etc. as they are already taken for `Regexp` match.
Short hand notation for block parameter itself is a nice idea though.
Matz.
-
- One of the most commons things I do in Ruby are small block definitions:
~~~ruby
x.each{|a| a}
~~~
One useful syntax introduced was the **`&:method`** that allows calling a method on a block if only one param is expected. It's a ... -
- Masaki Matsushita wrote:
> Enumerable#countは、実際にイテレーションを回してみて回った数を数える実装となっています。
> ...
Enumerable#countでなく自前の実装があるならそれを使い、そうでないならないものとみなせ、というくらいの意図でした。
> Enumerator#sizeがFixnumを返す場合に限っては、それに依拠して配列のサイズを決めてしまって問題ないのではないかと思います。
自前の... -
02:33 PM Bug #11130 (Assigned): Re: [ruby-changes:38376] glass:r50457 (trunk): * enum.c (enum_to_a): Use size to set array capa when possible.
- 議論は #9118 にあります。
そこでも指摘していますが、この最適化は def size; to_a.size; end という手抜きな size 実装で無限再帰になります（そういう実装はいくつも実在します）。再入チェックを入れてもなお高速か、確かめる必要があるでしょう。
まずは revert に一票です。
--
Yusuke Endoh <mame@ruby-lang.org> -
- Enumerable#countは、実際にイテレーションを回してみて回った数を数える実装となっています。
pull request ( https://github.com/ruby/ruby/pull/444 )の狙いはEnumerable#to_aの高速化なので、countは不向きです。
Enumerator#sizeがFixnumを返す場合に限っては、それに依拠して配列のサイズを決めてしまって問題ないのではないかと思います。 -
- そもそも、本件、githubのpull request以外のどこかで議論はあったのでしょうか？
sizeという、多義性のある(と実際に確認された)メソッドに依拠するのはそもそも危険なのでは、という気がしないでもないのですが、lengthやcountでなくsizeが対象として選ばれた経緯はなんでしょう？ -
- 互換性を壊すのは私の本意ではないので、以前と同じ挙動になるよう修正しました。
ご迷惑をおかけしました。 - 01:25 PM Bug #11130 (Closed): Re: [ruby-changes:38376] glass:r50457 (trunk): * enum.c (enum_to_a): Use size to set array capa when possible.
- Applied in changeset r50477.
----------
* enum.c (enum_to_a): fix incompatibility introduced in r50457.
[Bug #11130]
* test/ruby/test_enum.rb: test for above. -
10:10 AM Bug #11130: Re: [ruby-changes:38376] glass:r50457 (trunk): * enum.c (enum_to_a): Use size to set array capa when possible.
- 最適化のヒントとして使えるなら使うというのを超えて、ドキュメントなしに互換性を壊してしまったらバグではないでしょうか。
sizeがINFINITYを返すときも、eachを呼ぶことなくRangeErrorが発生します。（そのようなコードが足を撃たんとしている蓋然性は高いですが） -
- [Bug #11130]
* test/ruby/test_enum.rb: test for above.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@50477 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@50476 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * vm_dump.c (preface_dump): move the statement to include crash
report log file from REPORTBUG_MSG in error.c.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@50475 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 07:15 AM Revision dd4cf6bb (git): * ext/tk/extconf.rb: support Tcl/Tk8.6.
- * ext/tk/tcltklib.c, ext/tk/lib/tk.rb: get rid of SEGV with Tcl/Tk8.6.
[Backport #10401]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_1@50474 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 06:50 AM Revision 7f2c079e (git): * 2015-05-12
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@50473 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * vm_dump.c (preface_dump): highlight very important but very
ofhen ignored message like a Xmas tree.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@50472 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * vm_dump.c (preface_dump): move platform specific preface.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@50471 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- On 2015/05/12 12:57, Eric Wong wrote:
> nobu@ruby-lang.org wrote:
>> After requiring 'io/nonblock', no needs to see if `nonblock=` method is available.
>
> Doesn't that raise NotImplementedError on some platforms?
>
> I see this... -
- nobu@ruby-lang.org wrote:
> After requiring 'io/nonblock', no needs to see if `nonblock=` method is available.
Doesn't that raise NotImplementedError on some platforms?
I see this in ext/io/nonblock/nonblock.c:
#define rb_io_... -
- After requiring 'io/nonblock', no needs to see if `nonblock=` method is available.
And `IO#close_on_exec=` is older than `IO#nonblock=`.
-
- It sounds reasonable as `-r` option also calls `Kernel#require` method now.
-
12:46 AM Feature #11140: Allow rubygems' `require` to handle `autoload` calls
- Considering #5653, should we be making any changes to autoload to make it easier to use, if the intention is to remove it in ruby 3.0? I think before any improvements to autoload should be considered, we first need a firm decision from ...
-
- Right now, rubygems can't handle calls to `autoload` because `autoload` will directly call `rb_require_safe` rather than sending to `Kernel::require`.
For example:
~~~ruby
class A
autoload :B, 'a/b' # this is in a different Gem... -
- djberg96@gmail.com wrote:
> How about just :block ?
>
> a.accept(block: false)
> a.accept_nonblock(block: true)
I don't think that helps convey it affects the newly-accepted socket,
not the socket performing the accept.... -
12:25 AM Feature #11139: [PATCH] socket: support accept `sock_nonblock: (true|false)'
- How about just :block ?
a.accept(block: false)
a.accept_nonblock(block: true) -
- An application wanting to do non-blocking accept may want to
create a blocking accepted socket, allow it with a kwarg while
preserving default behavior.
This is analogous to the SOCK_NONBLOCK flag in the Linux `accept4'
syscall.
... -
- > How about objspace/allocation_tracer.rb?
I think that is fine.
> ...
Any reason why not? Usually I don't know where to include it while I'm debugging, and doing `ObjectSpace.allocation_sourcefile` is a lot to type. If including... -
- [PATCH 1/2] ext/socket/init.c: use SOCK_NONBLOCK if available
This saves a system call by allowing us to use SOCK_NONBLOCK in
Linux when accept4 is available.
Note: I do not agree accept_nonblock should always make accepted
socke...