Activity
From 01/04/2015 to 01/10/2015
01/10/2015
-
10:36 PM Feature #10729 (Open): Array method to subtract in place
- I request a method on array that takes another array, subtract that from self in place (= destructively), and return the subtracted elements:
a = [1, 2, 3, 4, 5]
a.some_method([2, 4, 6]) #=> [2, 4]
a #=> [1, 3, 5]
Ide... -
06:56 PM Feature #10714: Array#reject! nonlinear performance problem
- Zachary, patch fixes `reject!` and you test `select!`, ie patch fixes case when most items were deleted, and you test case when no item is deleted.
Based on numbers you present, patched version is so close to unpatched so I could not ... -
06:40 PM Feature #10714: Array#reject! nonlinear performance problem
- Using the following benchmark I compared nobu's patch vs. 2.2:
```ruby
require 'derailed_benchmarks'
require 'derailed_benchmarks/tasks'
namespace :perf do
desc "Array#select! and friends"
task :array_select => [:setup] do
... -
02:22 PM Feature #10714: Array#reject! nonlinear performance problem
- https://github.com/nobu/ruby/compare/Feature%2310714-Array-linear-performance
-
09:36 AM Feature #10714: Array#reject! nonlinear performance problem
- Now, I think this issue is a feature instead of a bug because it changes a documented behavior.
-
08:44 AM Feature #10714: Array#reject! nonlinear performance problem
- Akira Tanaka wrote:
> So the problem is which is important between the linear performance and the observability.
> ...
I fully agree. Nonlinear performance is a killer. Observability and ability to break are just nice-to-have. I thin... -
- It seems that several people found this problem.
- http://qiita.com/Nabetani/items/623df6f738864b5ed005
- https://twitter.com/grafi_tt/status/263097832158924800
- http://d.hatena.ne.jp/plonk123/20140603/1401832299
-
- > Ok, then try if something dies?
I think we should try.
We can explain the reason of this change.
It may be a good idea to describe this issue in NEWS because a documented behavior changed, though. -
- Forgot a patch of the tests
~~~diff
diff --git a/test/ruby/test_array.rb b/test/ruby/test_array.rb
index 31f33dd..33fc5d6 100644
--- a/test/ruby/test_array.rb
+++ b/test/ruby/test_array.rb
@@ -661,7 +661,7 @@ class TestArray < Te... -
- Ok, then try if something dies?
~~~diff
diff --git a/array.c b/array.c
index 0de7231..f2f7352 100644
--- a/array.c
+++ b/array.c
@@ -2824,6 +2824,48 @@ rb_ary_select(VALUE ary)
return result;
}
+struct select_bang_arg... -
- Hm.
The failed test is introduced by you after [Bug #5752].
The bug report describes as "If this is indeed the intended behaviour, ...".
It means that the reporter is not sure that the current behavior is intended or not.
Why cur... -
- I know, and `make test-all` failed.
-
- I don't think the modification must be observable from the given block.
[Bug #2545] doesn't discuss the observability in the block.
It discusses the receiver after "break".
If the modification is not required to be observable from... -
- The target of `Array#reject!` is the receiver itself, so the modification can be observed from the given block, or the block can exit by `break`.
Therefore the compaction is necessary each times.
I can't think of the way to avoid it,... -
- Apart from the performance problem, I feel following exmaple should show [7,8].
```
a = [5,6,7,8,9,10]; a.keep_if { |x| break if x > 8; x >= 7 }; p a
```
Because the method name is "keep_if", the method should keep only elements... -
- r49196 causes nonlinear performance problem.
```
% ./ruby -v -e '
20.times {|i|
a = [nil]*i*10000;
t1 = Time.now
a.keep_if { false }
t2 = Time.now
t = t2 - t1
p ["*" * (t * 20).to_i , t]
}
'
ruby 2.3.0dev (2015-... -
- Applied in changeset r49196.
----------
array.c: keep consistency
* array.c (rb_ary_select_bang): keep the array consistent by
removing unselected values soon. [ruby-dev:48805] [Bug #10722] -
01:03 PM Feature #10728: Warning for Fixnum#size to use RbConfig::SIZEOF['long']
- I took a look at `fixnum-size-search.txt` and using `RbConfig::SIZEOF['long']` instead usually isn't the correct replacement. In many lines the size of `long` in bytes isn't of interest, the min- and maximum value of a fixnum is (see fea...
-
- How about add a warning for Fixnum#size ?
```
% ./ruby -e 'p 0.size'
-e:1: warning: Use RbConfig::SIZEOF['long'] instead of Fixnum#size
8
```
Currently it returns sizeof(long) which is 4 or 8.
However it is implementation de... -
- * test/lib/test/unit.rb (ExcludesOption): allow directory list by
PATH_SEPARATOR to --excludes-dir option.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@49206 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@49205 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
10:29 AM Bug #10470: TracePoint cannot trace attr_accessor/reader/writer method
- 添付したパッチと同じ様にEXEC_EVENT_HOOKを追加して性能測定をしてみました。
測定にはbenchmark-ipsというgemを使って、100msでの実行命令数を計測しています。
測定に使ったソースコードは以下の通りです。
~~~ruby
require 'benchmark/ips'
class Foo
attr_accessor :hoge
def bar
@bar
end
def initial... -
- * test/etc/test_etc.rb (test_getgrgid, test_getgrnam): relax
comparisons. getgrent() does not return mem properly in some
circumstances (possibly, involved in Open Directory on OSX).
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trun... -
04:33 AM Bug #10727: Segfault with newlines + multibyte characters in exception message
- Thanks!
-
03:35 AM Bug #10727 (Closed): Segfault with newlines + multibyte characters in exception message
- Applied in changeset r49201.
----------
* eval_error.c (error_print): pos and len parameters of rb_str_substr()
are counted by characters, not bytes. use rb_str_subseq() instead.
[Bug #10727] [ruby-core:67473] -
01:46 AM Bug #10727 (Assigned): Segfault with newlines + multibyte characters in exception message
- I can reproduce this.
```shell
% ruby -v issue10727.rb
issue10727.rb:7:in `<main>': にほんご (E)
issue10727.rb: [BUG] Segmentation fault at 0x00000000000008
ruby 2.3.0dev (2015-01-09 trunk 49195) [x86_64-darwin13]
``` -
- In Ruby 2.2.0, this simple Ruby script results in segfault.
```ruby
class E < StandardError
def initialize
super("にほんご\n改行")
end
end
raise E
```
It's caused by r48637. -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@49203 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Applied in changeset r49202.
----------
* ext/zlib/zlib.c: fix document of method signatures.
[Bug #10668][ruby-core:67186][ci skip] -
- [Bug #10668][ruby-core:67186][ci skip]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@49202 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 03:35 AM Revision 27c679b8 (git): * eval_error.c (error_print): pos and len parameters of rb_str_substr()
- are counted by characters, not bytes. use rb_str_subseq() instead.
[Bug #10727] [ruby-core:67473]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@49201 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@49200 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@49199 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Applied in changeset r49198.
----------
* rational.c: removed commented-out code.
[Feature #10376][ruby-core:65643] -
- [Feature #10376][ruby-core:65643]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@49198 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
-
- DL has been removed from Ruby 2.2.0 or later.
but I think we need to backport this issue into Ruby 2.1 and 2.0.0
https://github.com/freebsd/freebsd-ports/blob/master/lang/ruby19/files/patch-ext__dl__extconf.rb -
01:22 AM Feature #10726 (Open): [PATCH 4/4] * New methods: Set#power
- Hi, there.
Here are 4 patches.
```
implement_set#power.patch ... Implement Set#power
update_test_set.rb.patch ... Add tests for Set#power
update_NEWS.patch ... Update NEWS for Set#power
fix_indent_NEWS.patch ... Ad... -
- We don't have the same environment equals to yours, we can't address where it happens without the debugging information.
And, as you use some extension libraries, especially ffi, it might be impossible to fix by us. -
12:11 AM Bug #10725 (Closed): Segfault with ObjectSpace::trace_object_allocations_start
While trying to pin down a memory leak issue I enabled trace_object_allocations_start but after a while my application (a daemon, not rails) crashes. I attached the output.
- 01:12 AM Revision 9f7179c5 (git): * 2015-01-10
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@49197 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * array.c (rb_ary_select_bang): keep the array consistent by
removing unselected values soon. [ruby-dev:48805] [Bug #10722]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@49196 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
12:33 AM Misc #10721: Failing test because of DNS server
- Improved the original solution by adding assert_raises.
01/09/2015
-
- * test/rubygems: ditto.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@49195 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
10:43 AM Bug #10724 (Closed): [TracePointAPI] Missing return event from initialize method when using `domain_name` gem
- The domain_name gem defines a DomainName object which has a pretty complex `initialize` method. The TracePoint API misses the return event from this method when instantiating a DomainName object.
I attach a failing test case.
Thanks!! -
09:41 AM Bug #10710: can't compile ruby 2.2.0 with gcc versions older than 4.4.0
- here's the build output:
~~~
~/src/ruby-2.2.0 $ make
CC = gcc
LD = ld
LDSHARED = gcc -shared
CFLAGS = -O3 -fno-fast-math -ggdb3 -Wall -Wextra -Wno-unused-parameter -Wno-parentheses -Wno-long-long -Wno-missing-field-initialize... -
- the problem is that the compiler accepts the warning flag but fails to compile a piece of code as soon as it tries to emit some warning.
~~~
configure:7495: checking whether -Wno-packed-bitfield-compat is accepted as CFLAGS
configur... -
- Could you show your config.log file, around checking `-Wno-packed-bitfield-compat`?
-
09:40 AM Bug #10723: [PERF] bm_tread_create_join 20% slower
- Opps it should bm_vm_thread_create_join.rb
-
- Relevant commits: https://github.com/ruby/ruby/compare/39fd4a8...5697b2f
Chart showing the regression: http://rubybench.org/ruby/ruby/commits?result_type=vm_thread_create_join
For those unable to view the chart, the benchmark resul... -
08:52 AM Bug #10722 (Closed): Array#keep_if is borked if user calls 'break'
- ref. [Bug #2545]
```
$ ruby -e 'a = [5,6,7,8,9,10]; a.keep_if { |x| break if x > 8; x >= 7 }; p a'
[7, 8, 7, 8, 9, 10]
$ ruby -e 'a = [5,6,7,8,9,10]; a.delete_if { |x| break if x > 8; x < 7 }; p a'
[7, 8, 9, 10]
```
I was expe... -
- Although `*args` includes and passes keywords too, but seems you want to add/remove/change some of keyword arguments.
It sounds reasonable to me. -
12:57 AM Bug #10708: In a function call, double splat of an empty hash still calls the function with an argument
- If I am not mistaken, even latest Ruby 2.2 selects keyword arguments as the last method's argument and of Hash type.
Let's imagine an example where both simple and keyword optional arguments are used:
~~~ruby
def call_multiargs(me... -
07:51 AM Bug #10716: Erroneous semicolon after AC_CASE
- Nobuyoshi Nakada wrote:
> Vit Ondruch wrote:
> ...
Ok, that makes sense. So I'll happily change the AC_PREREQ back to 2.63 for RHEL 6/CentOS 6 packages. Thanks for applying the patch. -
- Applied in changeset r49192.
----------
configure.in: Remove superfluous semicolon
* configure.in (RUBY_SETJMP_TYPE): Remove superfluous semicolon
which causes a syntax error with autoconf 2.63.
[ruby-core:67429] [Bug #10716] -
- Vit Ondruch wrote:
> BTW I am wondering why Ruby actually enforces autoconf 2.67 and makes plenty of RHEL 6/CentOS 6 users [1] unnecessary issues, when it builds with 2.63 just fine. If there was some justification at least [2].
Beca... -
- The following test is failing:
[ 5/52] TestNetHTTP#test_failure_message_includes_failed_domain_and_port = 0.32 s
1) Failure:
TestNetHTTP#test_failure_message_includes_failed_domain_and_port [/vagrant/test/net/http/test_http.rb:196... -
04:03 AM Revision 30253e6a (git): fix a typo [ci skip]
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@49194 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- I don't expect immediate stdlib update.
-
- I think the API is improved but I'm not sure we need to find & replace
every occurrence in the stdlib
-
02:18 AM Feature #10718: IO#close should not raise IOError on closed IO objects.
- Thank you for proposing this. I think this will simplify working with
Ruby IO and make me happier since I work with a lot of IO-related code.
Outside of test cases, I don't forsee compatibility problems either. -
- I'd like to change IO#close.
It should not raise IOError on closed IO objects.
We sometimes invoke IO#close only when the IO object is not closed as:
```
f.close if !f.closed?
```
If this issue is accepted, we can write it si... -
02:23 AM Feature #10720 (Rejected): A proposal for something like: attr_reader :foo? - with the trailing '?' question mark
- Hi guys,
Sorry to burden you with another suggestion, no problem
if it is not accepted, I wanted to just make it. :-)
We have a way to define reader methods easily, such
as in:
attr_reader :foo
This should be equivalen... -
- Applied in changeset r49193.
----------
parse.y: eliminate empty hashes
* parse.y (assocs, assoc): eliminate splatting empty literal
hashes. [ruby-core:67446] [Bug #10719]
* compile.c (compile_array_): supprt splatted hash in hash t... -
- ~~~
$ ruby -e 'foo(a: 1, **{})'
ruby: [BUG] Segmentation fault at 0x00000000000018
ruby 2.3.0dev (2015-01-09 trunk 49192) [universal.x86_64-darwin14]
~~~
-
- * parse.y (assocs, assoc): eliminate splatting empty literal
hashes. [ruby-core:67446] [Bug #10719]
* compile.c (compile_array_): supprt splatted hash in hash type.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@49193 b2dd03c8-39d... -
- * configure.in (RUBY_SETJMP_TYPE): Remove superfluous semicolon
which causes a syntax error with autoconf 2.63.
[ruby-core:67429] [Bug #10716]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@49192 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@49191 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
01/08/2015
-
10:25 PM Revision 344b8bbd (git): * ext/psych/lib/psych/visitors/yaml_tree.rb: correctly quote non-ascii
- letters. Thanks @jirutka for the patch.
* test/psych/test_string.rb: test for change
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@49190 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- subclasses. Fixes github.com/tenderlove/psych/issues/196
* test/psych/test_hash.rb: test for change
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@49189 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * ext/psych/lib/psych/visitors/yaml_tree.rb: dump hashes with ivars.
Fixes github.com/psych/issues/43
* test/psych/test_hash.rb: test for change
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@49188 b2dd03c8-39d4-4d8f-98ff-823fe69b... -
09:11 PM Bug #10708: In a function call, double splat of an empty hash still calls the function with an argument
- Just to inform everyone, this issue stems from [this post on Stack Overflow](http://stackoverflow.com/questions/27821422/how-can-i-collapse-double-splat-arguments-into-nothing).
Also, I have now idea how the ruby parser works, so if i... -
- By my subjective opinion I don't find this a bug but a feature.
> Consider this:
> ...
Here you define a method without a (keyword) argument placeholder so it does not expect a Hash argument, which is effectively used to pass keyword... -
- no. it aborts the build.
-
07:31 PM Bug #10689: `unexpected break' occurs when TracePoint#binding is called
- ありがとうございます！
頂いたパッチを元に、cfp を使うように整理してみました。
http://www.atdot.net/sp/view/e5ivhn
* vm_throw() を簡素化
* マクロっぽい名前を関数っぽく
一応、test-all/test-rubyspec は通っていますが、良さそうでしたらコミットしてもらえないでしょうか。
-
03:58 PM Bug #10697: WIN32OLE: WIN32OLE_RECORD を使用したスクリプト終了時にruby.exe がクラッシュすることがある
- ありがとうございます。
現象自体は確認しており、メモリーの二重開放まではわかっていたのですが、
COMサーバ側で開放しているとは思いませんでした。
ちょっと時間が取れてなくてパッチの方は詳しく見ていないのですが、別のアプローチの
VT_BYREF|VT_RECORDで渡したら、こちらでも現象は起こらなくなったみたいです。
わざわざ、VT_VARIANT | VT_BYREF で渡しているのは参照渡しにしたいからなので、
参照渡しをするのなら、VT_RECOR... - 03:38 PM Revision 2b2f9b75 (git): * 2015-01-09
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@49187 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@49186 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- ~~~
$ rpm -q cmake
cmake-2.6.4-5.el6.x86_64
$ make test-all TESTS=-n\ TestGemExtCmakeBuilder#test_self_build
<snip>
./miniruby -I./lib -I. -I.ext/common ./tool/runruby.rb --extout=.ext -- --disable-gems "./test/runner.rb" --... -
02:02 PM Bug #10699: m(*a, **b) doesn't recognize integer options.
- Thank you akr san for your consideration about backports.
I'll fill Backport field with 2.1: REQUIRED only for r49173. -
- Forgot to mention the actual error:
~~~
$ autoconf
$ ./configure
./configure: line 63225: syntax error near unexpected token `;'
./configure: line 63225: `; }; then'
~~~ -
- This is issue when building with autoconf 2.63 available in RHEL6/CentOS6
BTW I am wondering why Ruby actually enforces autoconf 2.67 and makes plenty of RHEL 6/CentOS 6 users [1] unnecessary issues, when it builds with 2.63 just fine... -
- DL has been removed at Ruby 2.2.0
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@49185 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
09:37 AM Bug #10715 (Closed): WEBrick::HTTPResponse#to_s calls send_response(), and make debugging quite difficult.
- WEBrick::HTTPResponse#to_s calls send_response(), and this makes debugging very difficult.
If I run webrick on debugger or just do "print" debug, and show status of the object in some point,
then debugger or "print" may calls "to_s" an... -
- According to `git bisect`, it caused by r32373 (related to [Bug #2545]) .
-
- I found Array#reject! is too slow.
I measured it and it seems the performance is nonlinear.
```
% ./ruby -v -e '
20.times {|i|
a = [nil]*i*10000;
t1 = Time.now
a.reject! { true }
t2 = Time.now
t = t2 - t1
p ["*"... -
- Applied in changeset r49184.
----------
vm_method.c: no super klass, no original method entry
* vm_method.c (rb_method_entry): if no super class, no original
method entry. [ruby-core:67389] [Bug #10707] -
- * vm_method.c (rb_method_entry): if no super class, no original
method entry. [ruby-core:67389] [Bug #10707]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@49184 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Applied in changeset r49183.
----------
ref of r49182 [Bug #10706] -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@49183 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@49182 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
07:21 AM Feature #10701: Class:Array 2 New methods
- i also would like if there are block variants of them like that
data = 0..10
data.prev_value {|o| o == 5} #=> 4
data.next_value {|o| o == 5} #=> 6
and i would use prev_value and next value instead of prev and next because it coll... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@49181 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 06:31 AM Revision a8565ad2 (git): * test/ruby/test_symbol.rb (TestSymbol#test_symbol_fstr_leak): get rid of a
- false positive on mswin CI.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@49180 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 06:26 AM Revision 93425341 (git): * test/test_open3.rb (TestOpen3#test_numeric_file_descriptors): passing FDs
- bigger than 2 is not supported on Windows.
fixed test failure introcuded at r49173.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@49179 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
04:42 AM Bug #10713: Assigning default value for a Hash as an empty Array creating unpredictable results
- Arvinder Singh wrote:
> ~~~
> ...
The `letters[:a]` part of the second line returns the "default value" of the Hash because the `:a` key does not exist in the Hash. The `<< 1` part pushes a `1` onto the end of the default value, but i... -
01:38 AM Bug #10713: Assigning default value for a Hash as an empty Array creating unpredictable results
- It's quite expected because the default array is created exactly once:
letters = Hash.new([])
letters.default.object_id # => 70310393550400
letters[:a].object_id # => 70310393550400
letters[:b].object_id # => 70310393550400
The... -
01:33 AM Bug #10713: Assigning default value for a Hash as an empty Array creating unpredictable results
- Martin Dürst wrote:
> Hiroshi SHIBATA wrote:
> ...
I would agree that this is surprising behaviour. It would appear that in this case, the append operator is not re-assigning the value, the way it does any other time it is used. And it... -
- Hiroshi SHIBATA wrote:
> It's expected behavior
Hiroshi, can you tell us why it's expected behavior? It looks quite surprising. -
- It's expected behavior
-
- Applied in changeset r49178.
----------
dir.c: OSX case-folding
* dir.c (glob_helper): match in case-folding only if the directory
resides on a case-insensitve file system, on OSX.
[ruby-core:67364] [Bug #10700] -
03:10 AM Bug #10700: On case-sensitive filesystem on OS X, Dir.glob("*.TXT") matches case-insensitively
- Nobuyoshi Nakada wrote:
> Can you try https://github.com/nobu/ruby/compare/Bug%2310700-OSX-case-folding ?
Confirmed that it works.
~~~
$ touch foo.txt foo.TXT FOO.txt FOO.TXT
$ ls -l foo* FOO* ... -
- * dir.c (glob_helper): match in case-folding only if the directory
resides on a case-insensitve file system, on OSX.
[ruby-core:67364] [Bug #10700]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@49178 b2dd03c8-39d4-4d8f-98ff-823f... -
- * lib/open3.rb (popen_run): use Hash.try_convert for duck typing.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@49177 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- [fix GH-809] Patch by @gxworld
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@49176 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
02:31 AM Feature #10119 (Feedback): [PATCH] [net/imap] Add CHANGEDSINCE FETCH modifier + complementary add MODSEQ Message Data Item in FETCH Command
- It seems to be a bug that store_internal is changed not to use flags.
What was your intention?
Could you write tests for this change?
01/07/2015
-
11:59 PM Bug #10713 (Rejected): Assigning default value for a Hash as an empty Array creating unpredictable results
- Creating a Hash with a default value works fine, unless the default value is an empty Array.
E.g. the following returns an empty Hash...
~~~
irb(main):001:0> letters = Hash.new([])
=> {}
irb(main):002:0> letters[:a] << 1
=> [1]... -
10:19 PM Bug #10712 (Closed): [PATCH] lib/resolv.rb: consider ENETUNREACH as ResolvTimeout - Applied in changeset r49175.
----------
lib/resolv.rb: consider ENETUNREACH as ResolvTimeout
This allows "gem install /path/to/local.gem" to be successful
on a machine without a network connection.
[ruby-core:67411] [Bug #10712] -
- Please commit.
-
- This allows "gem install /path/to/local.gem" to be successful
on a machine without a network connection.
I'm fairly sure this should be fixed in lib/resolv.rb instead
of inside RubyGems (and everything else which relies on rescuing
... - 10:19 PM Revision 89ba1514 (git): lib/resolv.rb: consider ENETUNREACH as ResolvTimeout
- This allows "gem install /path/to/local.gem" to be successful
on a machine without a network connection.
[ruby-core:67411] [Bug #10712]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@49175 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- do_coerce modifies x, so stashing the original before seems to fix
the problem. Maybe I missed something else. Lightly-tested patch:
--- a/numeric.c
+++ b/numeric.c
@@ -3426,10 +3426,11 @@ static int
bit_coerce(VALUE *x, VALUE... -
09:22 PM Bug #10711 (Closed): Incorrect error message in coerce failed
- ~~~
$ ruby -v -e '1 & 1.2'
ruby 2.2.0p0 (2014-12-25 revision 49005) [x86_64-darwin14]
-e:1: warning: possibly useless use of & in void context
-e:1:in `&': 1.2 can't be coerced into Float (TypeError)
from -e:1:in `<main>'
~~~
I... -
- > The compilation of a given source file fails as soon as the compiler
> needs to emit some warning:
Right, but ./configure detects that failure, disables the
-Wno-packed-bitfield-compat switch, and the rest of the build continues
... -
- ~~~
$ gcc --version
gcc (Debian 4.3.2-1.1) 4.3.2
~~~
The compilation of a given source file fails as soon as the compiler needs to emit some warning:
~~~
gcc -Wno-packed-bitfield-compat some_warning.c
some_warning.c: In functi... -
- stkaes@googlemail.com wrote:
> compilation stops because gcc before 4.4.0 does not support the flag
> ...
I'm curious what error you saw. An ancient CentOS 5.4 x86-64 machine
managed to build it using: gcc (GCC) 4.1.2 20080704 (Red H... -
- compilation stops because gcc before 4.4.0 does not support the flag -Wno-packed-bitfield-compat.
patch can be found here: https://github.com/skaes/rvm-patchsets/blob/master/patches/ruby/2.2.0/railsexpress/05-fix-packed-bitfield-compa... -
09:09 PM Bug #10708: In a function call, double splat of an empty hash still calls the function with an argument
- I think I got bitten by markdown's syntax actually, all my * * got replaced, so s/others/**others/g
-
- Tsuyoshi Sawada wrote:
> Do you mean `**others`?
Yes, sorry for the typo -
- Do you mean `**others`?
-
- Consider this:
~~~ruby
def foo; end
foo(*[]) #Splatting an empty list is ok
foo(**{}) #Double splatting an empty hash is like calling foo({}) which gives an error
~~~
This is annoying in a function that is a wrapper around anot... -
04:31 PM Bug #10709 (Rejected): Crash while loading
- I am stuck trying to upgrade my Ruby mri install
In 2.1.3 everything works fine, but with 2.1.5 and 2.2.0 it crashes while loading
I did a fresh bundle install and also made sure my gem system was up to date (gem update --system) -
04:29 PM Bug #10588: Invalid Dates
- Patch to the above bug :
~~~
class SmartTime < Time
def self.mktime year, month, day
case month
when 4, 6, 9, 11
if day == 31
raise ArgumentError, 'argument out of range _ APR, JUNE, SEP, NOV', caller
... -
- I didn't know this keyword arguments behavior.
Hm. I'm not sure the current behavior is good or not.
Anyway open3 has the problem since Ruby 2.1 and I don't expect Ruby 2.1 changes the keyword arguments behavior.
So I committed r... -
- Applied in changeset r49173.
----------
* lib/open3.rb: Open3 properly passes non-keyword hash args to spawn.
Fixed by Josh Cheek. [Fix GH-808]
Related to [ruby-core:67347] [Bug #10699] - 03:29 PM Revision 1b2276af (git): * 2015-01-08
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@49174 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Fixed by Josh Cheek. [Fix GH-808]
Related to [ruby-core:67347] [Bug #10699]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@49173 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
02:28 PM Bug #10702: Constant look up inconsistency with constants defined in included modules
- Jack Nagel wrote:
> `D` does not inherit from `C` or `A`, so it does not have access to `B`.
> ...
I looked at that blog before I posted and if constant lookup worked like it says then what I am doing would work because D is nested in ... -
- 04:59 AM Bug #10702: Constant look up inconsistency with constants defined in included modules
- `D` does not inherit from `C` or `A`, so it does not have access to `B`.
After assigning `B = B`, `E` can "see" `B` lexically.
However, if you reopen `E` as `C::E`, it will "lose" `B`:
```ruby
class C::E
B # => uninitialized... -
- https://gist.github.com/kwstannard/c0f722976ba023cc5755
```ruby
module A
module B
end
end
module C
include A
puts B.inspect # => A::B
class D
puts B.inspect rescue puts 'failed' # => failed
end
B =... -
- * tool/config_files.rb: use config.guess in gcc repo.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_1@49172 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
01:03 PM Bug #10707: Segmentation fault when get refined new method in BasicObject
- i wrote a patch for this.
-
- following code cause SEGV in ruby-trunk, 2.2.0, 2.1.5
``` ruby
module RefinementBug
refine BasicObject do
def foo
end
end
end
method(:foo)
```
it should be raise NameError like:
```
/Users/hanachin/tmp/bug... -
- I wrote a test and patch.
-
- following code cause SEGV in ruby-trunk, 2.2.0, 2.1.5, 2.0.0p598
``` ruby
module RefinementBug
refine Object do
def foo
end
end
end
private(:foo)
```
it should be raise `NameError` like:
```
/Users/sei/tmp... -
11:41 AM Bug #10705 (Closed): JSON::ParserError#message is wrong encoding (ASCII-8BIT)
- JSON::ParserError#message is wrong encoding (ASCII-8BIT). I would expect the error to be whatever the internal encoding is (in my case, utf8), perhaps inspecting the string in the error message such that all characters would be valid in ...
-
- * dir.c (replace_real_basename): use macros for getattrlist
buffer.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@49171 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * dir.c (dir_initialize): workaround of opendir failure at symlink
directories on Windows via CIFS.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@49170 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * dir.c (dir_initialize): add GC guard for retrying. the argument
of RSTRING_PTR() may be eliminated by optimization.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@49169 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- An exception should be raised if the input is not found?
-
- Applied in changeset r49168.
----------
dir.c: normalize CIFS too
* dir.c (need_normalization): not only HFS+, CIFS (SMB) is also
decomposed. [Bug #10704] -
08:26 AM Bug #10704 (Assigned): Normalization of path names on OSX
- http://blade.nagaokaut.ac.jp/cgi-bin/scat.rb/ruby/ruby-dev/38356 によると、
> 正確にはVFSドライバのレイヤーですね。
> ...
とのことなので、仰る解釈は誤りです。
思うにFSごとに判別が必要でしょう。 -
- OSXでのファイル名のUnicode normalizationは、今までHFS上の場合だけ行ってきましたが、HFS以外でも必要そうです。
## 実験
(1) Windows上でNFCとNFDのファイルを作る。
> cmd /c ver
Microsoft Windows [Version 6.1.7601]
> ruby -e '%W[\u{304c} \u{304b 3099}].each{|n| File.writ... -
- * dir.c (need_normalization): not only HFS+, CIFS (SMB) is also
decomposed. [Bug #10704]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@49168 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@49167 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Akira Tanaka:
I've highlighted this bug and offered a patch also. I love Ruby a lot. I wish I could say the same about its community.
Tsuyoshi Sawada:
It is a working solution. Instead of trolling, share your ingenious alternative. -
- Don't create a new ticket for a patch.
Use the original ticket, [Bug #10588], you reported. -
- The following is a pure Ruby-based patch to address the issues raised in [Bug 10588 Invalid Dates](http://bugs.ruby-lang.org/issues/10588):
~~~ruby
class SmartTime < Time
def self.mktime year, month, day
case month
when ... -
- * dir.c (NORMALIZE_UTF8PATH): Unicode decomposition seems to
perform in an upper layer than file systems on OSX, as all path
names are always decomposed regardless of file system types.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/tr... -
- Can you try https://github.com/nobu/ruby/compare/Bug%2310700-OSX-case-folding ?
01/06/2015
- 08:56 PM Revision bc5fd04f (git): * 2015-01-07
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@49165 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
08:56 PM Revision cd3bf498 (git): * test/ruby/test_method.rb: Add test for &-coersion of an
- UnboundMethod.
* test/ruby/test_module.rb: Add test for define_method given an
UnboundMethod.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@49164 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
04:06 PM Bug #10450: multiple assignment in conditional
- We just got a report on JRuby that we DO NOT error if masgn is in a conditional: https://github.com/jruby/jruby/issues/2433#issuecomment-68882716
My main two takeaways:
1. I don't think many people ever try to do this since it took s... -
- I just told @arsarih some of the horrific details of an environment I worked where they had case-insensitity built into a forked SVN client on a case sensitive filesystem. When people do not expect this behavior it leads to really confu...
-
- My Mac has the disk reformatted so that it is case-sensitive (HFS+):
~~~
$ touch foo.txt foo.TXT FOO.txt FOO.TXT
$ ls -li foo.* FOO.*
286444732 -rw-r--r-- 1 asari staff 0 Jan 6 08:00 FOO.TXT
286444731... -
- i think this functions might be interesting, but i would try to write them to that they are available in Enumerable too
-
02:48 PM Feature #10701 (Open): Class:Array 2 New methods
- Hi,
New to this, but this is an Array method that I use a lot and thought it might be included in a release, it's basic, but very helpful when you need to rotate certain defined values ie. log rotation with monthly timestamps
~~~ru... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@49163 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Applied in changeset r49162.
----------
* time.c (timelocalw): Set tm_isdst field -1 if vtm->isdst is
VTM_ISDST_INITVAL. This bug is introduced at packing struct
vtm (r45155).
[ruby-core:67345] [Bug #10698] Reported by Boris Ruf. -
- VTM_ISDST_INITVAL. This bug is introduced at packing struct
vtm (r45155).
[ruby-core:67345] [Bug #10698] Reported by Boris Ruf.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@49162 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- https://github.com/nobu/ruby/compare/Bug%2310699-kwrest-all
-
- #10118 is only for splat, not rest keywords argument.
-
- * ext/json/lib/json/generic_object.rb (JSON::GenericObject):
remove useless overriding methods, [] and []=.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@49161 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Yukihiro Matsumoto wrote:
> Double splat was introduced to pass a hash given from keyword arguments.
> ...
I've always considered the final hash to be a hash of options. I can't think of a reason to split the options hash in two based ... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@49160 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
01/05/2015
-
- I thought that was a feature. I proposed to extend the use of double splat, and a patch has already been provided by Nobu in #10118.
-
- It seems a method defined as m(*a, **b) doesn't recognize integer options.
```
% ./ruby -v -e '
def m(*a, **b)
p [a, b]
end
m(1, 2 => 3)
m(1, :foo => 3)
'
ruby 2.3.0dev (2015-01-06 trunk 49159) [x86_64-linux]
[[1, {2=>3}], ... -
- moving to ruby tracker
-
-
08:53 PM Bug #10698 (Closed): Time#local behaves differently during clock change
- This is probably not a bug but since it changes previous behavior it should be noted somewhere.
Ruby 2.1.5:
~~~
>> ENV['TZ'] = 'Europe/Berlin'
=> "Europe/Berlin"
> ...
=> "CET"
~~~
Ruby 2.2.0:
~~~
>> ENV['TZ'] = 'Europe/... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@49159 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Backported into ruby_2_1 branch at r49158.
-
- Applied in changeset r49148.
----------
* test/ruby/test_io.rb: added timeout for AIX environment.
[ruby-core:62983][Bug #9917] -
- * test/ruby/test_io.rb: added timeout for AIX environment.
[ruby-core:62983][Bug #9917]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_1@49158 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Applied in changeset r49157.
----------
test_handle.rb: use -test-/dln/empty
* test/fiddle/test_handle.rb (test_NEXT): use -test-/dln/empty
which is always a shared object and is not used by others.
[ruby-dev:48629] [Bug #10384] -
- * test/fiddle/test_handle.rb (test_NEXT): use -test-/dln/empty
which is always a shared object and is not used by others.
[ruby-dev:48629] [Bug #10384]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@49157 b2dd03c8-39d4-4d8f-98ff-... -
- * test/fiddle/test_handle.rb (test_static_sym, test_NEXT):
separate each rescue blocks.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@49156 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * test/fiddle/test_handle.rb (test_static_sym, test_DEFAULT):
remove useless skips.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@49155 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@49154 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 03:14 PM Revision 8ddffedb (git): * 2015-01-06
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@49153 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@49152 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 03:01 PM Revision 63f9fa6e (git): * 2015-01-06
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_1@49151 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- increase timeout for Arch Linux CI environment.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_1@49150 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
02:37 PM Bug #10697 (Closed): WIN32OLE: WIN32OLE_RECORD を使用したスクリプト終了時にruby.exe がクラッシュすることがある
- 以下のスクリプトまたは、Ruby のソース内のテスト `test/win32ole/test_win32ole_record.rb` を実行すると数回に一度程度の確率で ruby プロセスの終了時にSEGVが発生します。
```ruby
require 'win32ole'
obj = WIN32OLE.new('RbComTest.ComSrvTest')
book = WIN32OLE_RECORD.new('Book', obj)
obj.getBo... -
- * lib/mkmf.rb (create_makefile): clean timestamp files of
destination directories.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@49149 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
12:04 PM Bug #10656: mkmf have_func fails if Ruby is compiled with static libruby
- You were right. I've fixed this in Passenger 4.0.57. Thanks Nobuyoshi.
-
06:58 AM Bug #10696: Digest implementation on Windows faulty
- Yes works correclty.
Sorry for the unnecessary Bugreport. At least it is documented now. -
- [ruby-core:62983][Bug #9917]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@49148 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * lib/ostruct.rb (OpenStruct#table): revert for JSON.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@49147 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
05:05 AM Bug #10677: Regression: Time#parse no longer automatically converts to localtime
- Thank you for the explanation. I'll continue to debug and see if I can help measure it's impact. I more clearly understand the issue, and agree with the change. Unfortunately, I feel it's going to have a bigger impact than anticipated. I...
-
- It seems a small issue that no one notice before 2.2.0 released
You may know Ruby sometimes break compatibility to achieve better specs/functions.
For Time class it didn't save its time zone before.
After 1.9 whose time objects can ... - 01:57 AM Revision 32636e8e (git): * 2015-01-05
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@49146 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * lib/ostruct.rb (modifiable?, new_ostruct_member!, table!):
append suffixes to protected methods so that they will not clash
with assigned members. [Fix GH-806]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@49145 b2dd03c8-39d4... -
- DL is removed from stdlib of Ruby 2.2.0
-
- Robert A. Heiler wrote:
> File.chmod 444,'test.rb'
I think this should be
File.chmod 0444,'test.rb'
At least that's what the documentation says.
> ...
Eric Wong wrote:
> Try FileUtils.chmod instead. FileUtils is where the ...
01/04/2015
-
-
07:34 PM Bug #10696: Digest implementation on Windows faulty
- This is probably a line ending issue, with ASCII CR getting removed by File.read on Windows. You need to read the file in binary mode to get correct results on Windows:
Digest::SHA1.hexdigest(File.binread('test.file')) -
- The example I made with SHA1, but the same happens for other digests, so it seems to affect the generic implementation of the interface and not the specific hash implementations.
> Digest::SHA1.hexdigest(File.read('test.file'))
> ...... -
-
03:40 PM Bug #10695 (Closed): Segmentation fault with *args and **kwargs
- The following will raise a Segmentation fault:
~~~ruby
def foo(*args, **kwargs)
puts "args: #{args}"
puts "kwargs: #{kwargs}"
end
foo('foo' => 'bar')
~~~
Segmentation fault in [here](https://gist.github.com/tbuehlmann/5... -
- ふと検索したところ、Numeric からの継承を使っている gem はそれなりに存在するようです。
(結果を下につけます。スコープの都合により ::Numeric ではないものを参照しているのが混じっているかもしれません。)
Numeric.new をできないようにすると、こういうのは動かなくなるんでしょうか。
もし動かなくなるとしたら、その問題以上の利点が必要だと思いますが、どんな利点があるでしょうか。
```
M500-0.9.2/lib/M500... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@49144 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Applied in changeset r49143.
----------
test/unit.rb: ExcludesOption
* test/lib/test/unit.rb (ExcludesOption): add "excludes" support
to test suite, for alternative implementations and platforms.
[Feature #10682] -
- leafchecker should be used on CRuby.
But the patch comment out it so it is disabled regardless of ruby implementations.
-
- * test/lib/test/unit.rb (ExcludesOption): add "excludes" support
to test suite, for alternative implementations and platforms.
[Feature #10682]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@49143 b2dd03c8-39d4-4d8f-98ff-823fe69b... -
- * test/lib/test/unit.rb (Test::Unit): reorder modules and merge
each modules.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@49142 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * test/lib/test/unit.rb (Test::Unit): split the large class into
each modules.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@49141 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Applied in changeset r49140.
----------
parse.y: fix f_label result
* parse.y (f_label): return tLABEL value as it is.
[ruby-core:67315] [Bug #10693] -
02:09 AM Bug #10693 (Closed): Regression in Ripper for keyword arg default params
- Easy to reproduce, seems to only be present in 2.2:
```ruby
$ ruby -v
ruby 2.2.0p0 (2014-12-25 revision 49005) [x86_64-darwin14]
$ ruby -rripper -e 'p Ripper.sexp "def x(a:1) end"'
[:program, [[:def, [:@ident, "x", [1, 4]], [:pare... -
- * parse.y (f_label): return tLABEL value as it is.
[ruby-core:67315] [Bug #10693]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@49140 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
11:14 AM Bug #10694 (Closed): Improve Thread#value rubydoc
- Thread#value can also raise an exception. Document this.
Patch based on trunk b9c630f999, 04-jan-2015. -
- Ben Johnson wrote:
> I have a strong feeling this is going to be a **major** problem as people try to move forward. Adding "local" time everywhere you use Time.parse simply is not feasible. This change is also outside of the scope of a ... -
- Akira Tanaka wrote:
> There is no direct issue.
> ...
I'd also like to add that Parker's post, and the explanation in the bottom half, is spot on ( https://byparker.com/blog/2014/ruby-2-2-0-time-parse-localtime-regression/ ).
I have... -
- * test/lib/test/unit/parallel.rb (run): expand the file name to be
loaded, so that relative paths work in parallel mode.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@49139 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
04:41 AM Revision dd2d43d9 (git): * test/test_tempfile.rb: use assert_file for more descriptive message.
- following r49131.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@49138 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Applied in changeset r49137.
----------
* string.c: improve docs for String#<=>. [ruby-core:65399][Feature #10322] -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@49137 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@49136 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Applied in changeset r49135.
----------
* string.c: improve docs for String#strip and variations. [ruby-core:66081][Bug #10476] -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@49135 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * test/lib/test/unit/testcase.rb (method_added): hook methods
should call super.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@49134 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * test/lib/minitest/unit.rb (i_suck_and_my_tests_are_order_dependent!):
remove.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@49133 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * test/lib/minitest/unit.rb (UNDEFINED): remove.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@49132 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * test/test_tempfile.rb (test_default_basename): use assert_file
for more descriptive message.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@49131 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- curl, wget and apt-get supports storing passwords in .curlrc, .wgetrc, .netrc or apt.conf.
So users can store password in a file if environment variable is not appropriate.
Your patch only supports environment variable.
It encourage... -
- [fix GH-515]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@49130 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- [fix GH-523] Patch by @dissolved
* test/test_tempfile.rb: ditto.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@49129 b2dd03c8-39d4-4d8f-98ff-823fe69b080e