Activity
From 10/02/2013 to 10/08/2013
10/08/2013
-
11:43 PM Feature #9001 (Rejected): Please package better standard library
- Please package better alternative to the standard library
irb->pry,
rexml->nokogiri,
fiddle->ffi, ..
just mean include more better gem to standard install,
and use rubygem upgrade.
Ruby is designed to make programmers happ... -
11:34 PM Bug #8995: バイナリデータを文字列として encode! すると readbyte の結果が変化する
- 同じエンコーディング間では何もしていなかったので、防御にはなっていなかったんじゃないでしょうか。
-
11:14 PM Bug #8995: バイナリデータを文字列として encode! すると readbyte の結果が変化する
- rails の該当箇所は rails 3 リリース時から存在するもので、invalid な utf-8 をパラメータとして渡して攻撃するものを防御するためのコードのようです。いったん、rails 側で何とかできないか考えてきます。
-
- まぁ、そもそもバイナリデータをエンコーディング変換したら壊れるのが当然ですね。
-
- =begin
理由はr40390です。
* transcode.c (str_transcode0): If invalid: :replace is specified for
String#encode, replace invalid byte sequence even if the destination
encoding equals to the source encoding.
(({encode_params}))の... -
- =begin
最小コードはこんな感じですね。
$ ruby -E:UTF-8 -e 'p "\xff".encode.unpack("C*")'
[239, 191, 189]
(({Encoding.default_internal}))をセットしていると、同じエンコーディング同士でも変換が起きているようです。
=end
-
- =begin
Rails の以下のコードの結果が 2.0 と 2.1 とで異なるようです。
((<encode_params|URL:https://github.com/rails/rails/blob/3-2-stable/actionpack/lib/action_dispatch/http/parameters.rb#L51>))
以下が最小ケースです。
$ ruby -v
=> ruby 2.1.0dev (2013-10-07 tr... -
09:14 PM Feature #7688: Error hiding with rb_rescue() on Comparable#==, #coerce and others
- ektoric (Patrick Tou) wrote:
> http://rubyforge.org/tracker/index.php?func=detail&aid=17368&group_id=426&atid=1698
Thanks for the link.
> ...
Seems to me <=> including a "raise" still hides it:
class C; include Comparable; ... -
09:27 AM Feature #7688: Error hiding with rb_rescue() on Comparable#==, #coerce and others
- http://rubyforge.org/tracker/index.php?func=detail&aid=17368&group_id=426&atid=1698
Things have "improved" since 2008. If the <=> includes a raise, #== now also raises the exception. Unfortunately, if there is some other exception (... -
06:54 PM Feature #8998 (Closed): string keys for hash literals should use fstrings
- While we're introducing optimizations from frozen strings,
string keys inside hashes should be frozen at the compiler level
to prevent duplication.
a = { "ABC" => :t }
b = { "ABC" => :t }
# the following ought to print true
... -
06:36 PM Bug #8997 (Third Party's Issue): TestSignal#test_hup_me hangs up the test suite
- The TestSignal#test_hup_me was introduced in r39819 and there were attempt to fix some deadlock issue in r39862. However, I can still observe deadlock on Fedora Rawhide's builders. Not sure what is the cause, since I cannot reproduce it ...
-
05:43 PM Bug #8996 (Closed): pthread_mutex_lock EINVAL
- ruby crashes leaving a stacktrace. . Cause is pthread_mutex_lock EINVAL
Based on the ruby source line where the problem happens (line 121 below)
119 def stop
120 if @tcpServerThread
121 @tcpServerThread.raise... -
04:45 PM Feature #8994 (Open): add methods for Float to get if an NaN is quiet or not, also add class methods for Float to "generate" an quiet NaN and an loud NaN
- Currently its not easy possible to know of an NaN in ruby is silent or not
like Float::NAN.quiet?
there should also methods to make an new NaN like Float::quiet_nan, maybe with the possibility to set user data
also there is
... -
04:03 PM Feature #8976: file-scope freeze_string directive - "..."f might be mildly ugly, but is hard to beat.
5 minutes of my thinking did not yield any better idea.
I share mame's feeling abou the file-scope directive. -
09:29 AM Feature #8976: file-scope freeze_string directive
- 2013/10/8 mame (Yusuke Endoh) <mame@tsg.ne.jp>:
> Issue #8976 has been updated by mame (Yusuke Endoh).
>
> "...".dup looks too verbose to me.
> How about using "..." for a mutable string and '...' for an immutable?
I consid... -
08:50 AM Feature #8976: file-scope freeze_string directive
- "...".dup looks too verbose to me.
How about using "..." for a mutable string and '...' for an immutable?
I'm not so keen on a file-scope directive itself, though...
--
Yusuke Endoh <mame@tsg.ne.jp> -
- * load.c (load_lock): display backtrace to $stderr at circular
require.
* vm_backtrace.c (rb_backtrace_print_to): new function to print
backtrace to the given output.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43204 b2dd03c8-... - 03:34 PM Revision 42976d75 (git): * 2013-10-09
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43203 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * io.c (rb_io_write): use rb_funcallv() instead of rb_funcall() to get
rid of unnecessary alloca.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43202 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43201 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 12:42 PM Revision 6fa584e2 (git): Fix a typo: s/preceging/preceding/
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43200 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
12:08 PM Revision cff2b2b6 (git): * vm_backtrace.c, include/ruby/debug.h: add new APIs
- * VALUE rb_profile_frame_method_name(VALUE frame)
* VALUE rb_profile_frame_qualified_method_name(VALUE frame)
* iseq.c (rb_iseq_klass), internal.h: add new internal function
rb_iseq_method_name().
* ext/-test-/debug/profile_frames.c (p... -
- JRuby's behavior is equal to MRI older than fixing #8040.
If the last argument is a Hash, and the method defines keyword arguments, the last argument is used as the keyword arguments. -
03:01 AM Bug #8993 (Closed): Request for clarification on method argument binding for keyword arguments
- =begin
I recently fixed keyword arguments in the JRuby interpreter, and I then found an example for which MRI and JRuby have different behavior:
def foo(a, b, c=1, *d, e, f:2, **g)
[a, b, c, d, e, f, g]
end
foo(1, 2, f... -
11:25 AM Bug #8990: please disable *context on hurd
- Committed at r43193. Thank you!
-
- This issue was solved with changeset r43193.
Gabriele, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.
----------
* cont.c: disable FIBER_USE_NATIVE on GNU/Hurd because it doe... -
09:19 AM Bug #8990: please disable *context on hurd
- kosaki (Motohiro KOSAKI) wrote:
> 1. Every workaroud patch should have a comment why it is needed any which version has a problem. Even though prior work don't.
Comment might be: "GNU/Hurd doesn't fully support {get,set,make,swap}con... -
- "headius (Charles Nutter)" <headius@headius.com> wrote:
> I propose that we eliminate the new "f" suffix and just make the compiler
> smart enough to see literal strings with .frozen the same way.
>
> So this code:
>
> str... -
- I am happy to see another discussion on this, I feel "str"f is just a hack.
I strongly agree and think #freeze is the right name.
On the aesthetics side, I personally dislike prefix/suffix forms, they feel like u'str' in python whi... -
03:27 AM Feature #8992: Use String#freeze and compiler tricks to replace "str"f suffix
- =begin
I am leaning toward #frozen if we want a new name... as in "give me the frozen version of this string". I know that there was some concern that "frozen" was too similar to "freeze" in http://bugs.ruby-lang.org/issues/8977 but it ... - 03:18 AM Feature #8992: Use String#freeze and compiler tricks to replace "str"f suffix
- +1 for optimized String#freeze as it will work on previous versions of Ruby:
I've written a patch implementing this feature: https://gist.github.com/charliesome/6836600 -
03:10 AM Feature #8992: Use String#freeze and compiler tricks to replace "str"f suffix
- Optimizing the #freeze or #frozen methods to do this make a lot more sense to me
than the `""f` suffix to me.
I'm +1 on #frozen and preventing redefinition of that method, but I further
propose that we raise an error if redefining f... -
- > If we do not want to overload the existing .freeze method in this way, we could follow suggestions in http://bugs.ruby-lang.org/issues/8977 to add a new "frozen" method (or some other name) that the compiler would understand.
I li... -
- BACKGROUND:
In https://bugs.ruby-lang.org/issues/8579 @charliesome introduced the "f" suffix for creating already-frozen strings. A string like "str"f would have the following characteristics:
* It would be frozen before the expres... -
- * test/ruby/test_rubyoptions.rb (test_segv_loaded_features): leave
only one Bogus object in $LOADED_FEATURES.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43198 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * array.c (rb_ary_uniq): use rb_hash_values(), as well as the case no
block is given.
* internal.h: define rb_hash_values() as internal API.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43197 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * array.c (rb_ary_uniq): set class of the return value to the receiver
class. fix failure in TestArray#test_array_subclass.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43196 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- See also http://bugs.ruby-lang.org/issues/8992 which proposes just making "literal string".freeze do the right thing in the compiler.
FROZEN { } is not terrible syntax, but it's the longest one suggested. -
- (2013/08/31 16:20), charliesome (Charlie Somerville) wrote:
> Feature #8579: Frozen string syntax
Just another syntax idea:
FROZEN{ 'foo' }
Advantage:
* Can implement on Ruby level in 2.0 or before
* Can extend fo... -
- * array.c (rb_ary_uniq): remove no longer used local variables since
r43194.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43195 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
04:56 AM Revision 41eb48b8 (git): * array.c (rb_ary_uniq): use rb_hash_keys().
- * internal.h: define rb_hash_keys() as internal API.
* hash.c (rb_hash_keys): ditto.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43194 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- support a combination getcontext() and threads. Patch by
Gabriele Giacone (1o5g4r8o@gmail.com). [Bug #8990][ruby-core:57685]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43193 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * cont.c (FIBER_USE_NATIVE): supplement comments the reason why it is
disabled.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43192 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
12:10 AM Feature #8636: Documentation hosting on ruby-lang.org
- zzak (Zachary Scott) wrote:
> We are also working on i18n support for RDoc so the japanese documentation team will not have to maintain a separate repository. Eventually with this supported, we can move to docs.ruby-lang.org/LANG
Ref...
10/07/2013
-
- 2013/10/3 marcandre (Marc-Andre Lafortune) <ruby-core@marc-andre.ca>:
> Issue #8840 has been updated by marcandre (Marc-Andre Lafortune).
>
>
> akr (Akira Tanaka) wrote:
>> Would you explain the incompleteness concretely?
>
... -
- 2013/10/2 enebo (Thomas Enebo) <tom.enebo@gmail.com>:
> Issue #8976 has been updated by enebo (Thomas Enebo).
>
>
> I think having a pragma at the top of the file will be much more error prone than the f-syntax. As a file grows, th... -
- time Time object as Ruby 2.0 and before.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43191 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
08:41 PM Revision 9410e7e0 (git): * .travis.yml: Rebuild Travis CI's "ruby-head" version on successful
- build. Patch by Konstantin Haase. [Fixes GH-417]
https://github.com/ruby/ruby/pull/417
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43190 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- headius (Charles Nutter) wrote:
> You should use read_nonblock in combination with select, so only what is available without blocking gets read off the wire. In this case, it would be an empty result (empty string or nil) or raise EAG... - 07:29 PM Revision 20eff9bd (git): * misc/ruby-mode.el: Use preceding-char/following-char
- (returning 0 at BOF/EOF) instead of char-before/char-after
(returning nil at BOF/EOF) to avoid error from char-syntax when
at BOF/EOF.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43189 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 07:15 PM Revision 593855a0 (git): * misc/ruby-additional.el (ruby-mode-set-encoding): Add a missing
- else clause to unbreak with `cp932`, etc.
* misc/ruby-mode.el (ruby-mode-set-encoding): Ditto.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43188 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 07:03 PM Revision 449822c7 (git): * misc/ruby-additional.el (ruby-mode-set-encoding): Use
- `default-buffer-file-coding-system` if the :prefer-utf-8
property is not available.
* misc/ruby-mode.el (ruby-mode-set-encoding): Ditto.
* misc/ruby-additional.el (ruby-encoding-map): Override the
default value.
git-svn-id: svn+ss... - 06:21 PM Revision 1ecf20cd (git): misc/ruby-mode.el: Improve `ruby-mode-set-encoding`.
- * misc/ruby-additional.el (ruby-mode-set-encoding): Add support
for `prefer-utf-8` which was introduced in Emacs trunk.
* misc/ruby-additional.el (ruby-encoding-map): Add a mapping from
`japanese-cp932` to `cp932` to fix the problem... -
03:36 PM Bug #8986 (Closed): test suite error: TestNetHTTP_v1_2_chunked#test_timeout_during_HTTP_session
- This issue was solved with changeset r43167.
Vit, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.
----------
Increase open_timeout [Bug #8986] -
- 03:16 PM Revision 381784be (git): * 2013-10-08
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43185 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 03:16 PM Revision 96585420 (git): * misc/ruby-additional.el: Add a standard header and footer,
- including (provide 'ruby-additional).
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43184 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 02:47 PM Revision 1189b5fe (git): Make ruby-electric play nicely with smartparens-mode.
- * misc/ruby-electric.el (ruby-electric-space-can-be-expanded-p):
Return nil to avoid "end" insertion when in smartparens-mode
that is configured to insert "end" for the same keyword.
* misc/ruby-electric.el (ruby-electric-keywords):... - 02:47 PM Revision ae8870e9 (git): * misc/ruby-additional.el: Use preceding-char/following-char
- (returning 0 at BOF/EOF) instead of char-before/char-after
(returning nil at BOF/EOF) to avoid error from char-syntax when
at BOF/EOF.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43182 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * cont.c (FIBER_USE_NATIVE): split long conditions.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43181 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * configure.in (FIBER_USE_NATIVE): add mingw condition.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43180 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * configure.in, win32/Makefile.sub (FIBER_USE_NATIVE): move conditions
from cont.c
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43179 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
11:32 AM Revision 1956ca5d (git): * lib/time.rb: [DOC] typo in Time.rb overview by @srt32 [Fixes GH-416]
- https://github.com/ruby/ruby/pull/416
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43178 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Patch by Felipe Contreras. [ruby-core:57694]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43177 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 10:28 AM Bug #7445: strptime('%s %z') doesn't work
- +1 Patch looks good to me
-
10:05 AM Revision 5ec7e5aa (git): fix a typo
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43176 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43175 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * test/ruby/test_io.rb (test_pid_after_close_read): fix rr43164 for
platforms other than Windows.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43174 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- something long name because one test depends on absence of
class ::C.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43173 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43172 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- test/-ext-/debug/test_profile_frames.rb: add a test for new C-APIs.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43171 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * int rb_profile_frames(int start, int limit, VALUE *buff, int *lines);
Collect information of frame information.
* VALUE rb_profile_frame_path(VALUE frame);
* VALUE rb_profile_frame_absolute_path(VALUE frame);
* VALUE rb_profile_frame... -
- * win32/file.c (code_page_i, rb_w32_init_file): make encoding to code
page mapping at initialization directly.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43169 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * win32/file.c (code_page): use encoding index, which is primary
entity, instead of encoding name.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43168 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43167 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- >Could you ping okkez and sutou-san?
I send to mail their. -
- * win32/file.c (code_page): cache using st_table, not RHash.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43166 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * win32/file.c (code_page): check US-ASCII and ASCII-8bit before
ordinary mapping.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43165 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * test/ruby/test_io.rb (TestIO#test_pid_after_close_read): get rid of
broken pipe error message from invoked command, by let it exit
silently. echo in cmd.exe does not interpret double quotes.
git-svn-id: svn+ssh://ci.ruby-lang.org... -
- Type of return value of rb_iseq_first_lineno() is now VALUE.
* vm_insnhelper.c (argument_error): ditto.
* vm_method.c (rb_method_entry_make): ditto.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43163 b2dd03c8-39d4-4d8f-98ff-823fe... -
- * VALUE rb_iseq_path(VALUE iseqval);
* VALUE rb_iseq_absolute_path(VALUE iseqval);
* VALUE rb_iseq_label(VALUE iseqval);
* VALUE rb_iseq_base_label(VALUE iseqval);
* VALUE rb_iseq_first_lineno(VALUE iseqval);
And new (temporary) functi... -
- * win32/win32.c (w32_spawn, w32_aspawn_flags): make internal functions
static.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43161 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
10/06/2013
-
- Here's my TODO:
* get README's working as RDoc index page for each version
* produce a global index page to link to each version
I would prefer docs.ruby-lang.org as it is the best canonical url available for us
We are also wor... -
- I'm going to prepare docs.ruby-lang.org.
but I worried about doc.ruby-lang.org and docs.ruby-lang.org. doc is Japanese only and docs is English only. this situation is very confusion.
doc.ruby-lang.org/en is redirection of www.ruby-l... -
- I have a build script setup on github. It needs an index page and to be tested before we can get the server and dns going.
https://github.com/zzak/docs.ruby-lang.org
Anyone have some feedback on how the index.html page should look? - 06:43 PM Revision e51c6245 (git): * 2013-10-07
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43160 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * NEWS (Stdlib updates): uptdate of timeout.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43159 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * io.c (copy_stream_body): move src_io and dst_io back to top level
and use instead of stp->src and stp->dst.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43158 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * io.c (io_ascii8bit_binmode): split from rb_io_ascii8bit_binmode() to
call with rb_io_t* directly.
* io.c (copy_stream_body): move src_io and dst_io into each blocks
where those are only used.
git-svn-id: svn+ssh://ci.ruby-lang.or... -
- * signal.c (sighandler_t): get rid of clash with system provided name.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43156 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
10:17 AM Bug #7445: strptime('%s %z') doesn't work
- Also, if `'%s'` is used for UTC, then why do we get this?
~~~ruby
require 'time'
Time.strptime('0', '%s')
=> 1969-12-31 18:00:00 -0600
~~~
I'm attaching a patch that does exactly what we want:
~~~ruby
Time.strptime('0', '%s... -
- 1. Every workaroud patch should have a comment why it is needed any which version has a problem. Even though prior work don't.
2. defined(__GNU__) is unclear and confusable because a lot of people aren't familiar Hurd. So, it should be ... -
- This bug can be reproduced in Ruby 1.8 as well.
Attached patch disables *context use on hurd.
Hurd implementation is not working yet and it's hard estimating whenever it will be.
Thanks. -
- Did you try "make distclean" first?
-
03:14 AM Bug #8989: Ruby 2.1 unable to build because of problem with rdoc directory
- Also, I have just tried to build Ruby 2.0.0-p247 on the same machine and have experienced the same problem. I have never had this problem before, so it looks like something that has changed in 2.0.0-p247.
-
- Trying to build ruby-2.1.0-preview1 and am receiving the following error when running make:
Generating RDoc documentation
Directory .ext/rdoc already exists, but it looks like it isn't an RDoc directory.
Because RDoc doesn't wan... -
12:58 AM Bug #8988 (Closed): [DOC] fix incorrect documentation for SizedQueue
- The SizedQueue documentation was incorrect for both SizedQueue#pop and SizedQueue#num_waiting. This patch adds correct documentation using language that is very similar to Queue#pop and Queue#num_waiting.
* Document-method: pop
*... -
- * test/test_tempfile.rb (test_tempfile_finalizer_does_not_run_if_unlinked):
open file cannot be deleted on Windows.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43155 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * test/-ext-/old_thread_select/test_old_thread_select.rb
(test_old_select_signal_safe): ignore short wait on Windows.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43154 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
12:26 AM Feature #8987: map/collect extension which handles arguments
- In case of commutative operations like `+`, you can do it like this:
~~~ruby
[1, 2, 3, 4].map(&4.method(:+))
# => [5, 6, 7, 8]
-
- * test/ruby/test_sleep.rb (test_sleep_5sec): relax bottom on Windows.
assert_operator should test on the receiver.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43153 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * test/ruby/test_thread.rb (test_blocking_mutex_unlocked_on_fork):
ignore meaningless test on platforms where fork() is not supported.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43152 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
10/05/2013
- 11:39 PM Revision c55e4dd3 (git): * 2013-10-06
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43151 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Based on patch by @chastell https://github.com/ruby/ruby/pull/413
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43150 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
11:02 PM Feature #8987 (Open): map/collect extension which handles arguments
- Please consider extending map/collect by allowing additional arguments to be passed to proc, like:
A: `[1,2,3,4].map :+, 4`
and/or
B: `[1,2,3,4].map 4, &:+`
=> [5, 6, 7, 8]
Variant A is probably more readable. Variant B is more ... -
08:34 PM Bug #8433: Mutexes held by background threads at fork not always released
- Thank you for the quick response! Any chance this will be backported to 1.9.3?
-
- This issue was solved with changeset r43148.
Ben, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.
----------
thread.c: fix some mutexes remaining locked after forking
* threa... -
- I've submitted a proposed patch for this issue at https://github.com/ruby/ruby/pull/415 . This seems to have done the trick for me running it through some basic tests, including the one you posted.
-
- (2013/10/04 21:38), funny_falcon (Yura Sokolov) wrote:
> Any way, I like idea with additional argument to functions.
One more advantage of additional argument is we can verify passed size
argument with CALC_EXACT_MALLOC_SIZE op... -
- =begin
Recently, I started to observe following test suite error quite often:
TestNetHTTP_v1_2_chunked#test_timeout_during_HTTP_session [/builddir/build/BUILD/ruby-2.1.0-preview1/test/net/http/test_http.rb:409]:
[Net::ReadTimeout]... -
- * thread.c (terminate_atfork_i): fix locking mutexes not unlocked in
forks when not tracked in thread. [ruby-core:55102] [Bug #8433]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43149 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * thread.c (terminate_atfork_i): fix locking mutexes not unlocked in
forks when not tracked in thread. [ruby-core:55102] [Bug #8433]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43148 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
01:28 AM Bug #8616: Process.daemon messes up threads
- ... and r40534 to resolve conflict.
merged r40534,r 41886 r41903, r41910 to ruby_2_0_0 at r43142. -
- I'll backport r41886, r41903 and r41910 to ruby_2_0_0.
Thank you for your notice! -
- * common.mk (sizes.c): revert r43137 and r43145, because the former
commit made sizes.c rebuild always each build.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43147 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 12:18 AM Revision 7ea58635 (git): * 2013-10-05
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43146 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * common.mk (sizes.c): now depends on PREP, which is miniruby if
native compile or fake.rb otherwise, to run MINIRUBY [Bug #8968]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43145 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
10/04/2013
-
- (2013/10/04 21:30), SASADA Koichi wrote:
> Ah, it is synchronicity.
because we Heroku ruby team discussing about xfree2 and xrealloc2.
> ptr = xmalloc2(100); /* allocate 100 byte */
Sorry. We don't need xmalloc2(... -
- Ah, it is synchronicity.
I have another idea to approach for it.
how about another version of ruby_xfree() and ruby_xrealloc() to passing
2nd argument, which is passing same information pasing to xwill_free().
ptr = x... -
09:38 PM Feature #8985: xwillfree - promise to free memory
- SASADA Koichi wrote:
> Ah, it is synchronicity.
> ...
I mentioned that one function is tradeoff for patch simplicity - just for
idea presentation. And there is REALLOC_N: passing another one argument
to could look ugly in several place.
... -
- This patch changes semantic of RUBY_GC_MALLOC_LIMIT.
Instead of being "periodical trigger" it becomes more like "safety trigger"
which fires in allocation increase (instead of allocation amount).
So that there is less need to tune RUB... -
09:23 PM Bug #8122 (Closed): [patch] gc: GC.stat improvements and related cleanup
-
- Now, ObjectSpace.memsize_of(obj) return without sizeof(RVALUE).
For example, ObjectSpace.memsize_of('foo') returns 0 because shorter string are embedded in RVALUE.
Proposal is returning the size including sizeof(RVALUE).
If we intro... -
- I would just open a ticket, this will give you a much better chance at feedback.
On Oct 2, 2013, at 5:35 PM, James French <James.French@naturalmotion.com> wrote:
> Hi,
>
> I’ve spent some time looking into the feasibility of... -
- Thanks! I'll write a patch for this soon <3
-
-
07:32 PM Bug #8673: User rest-client PUT request core dumped
- the version is:
"OpenSSL 1.0.1c 10 May 2012" -
- This issue was solved with changeset r43138.
Aman, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.
----------
gc.c: add rb_objspace.limit
* gc.c: add rb_objspace.limit to ke... -
- Actually we already have heap.final_num. Is this the same as zombie_num?
-
- > (2) count zombie_num
> ...
I like this approach. This will be useful also for debugging finalizer leaks.
Once we replace heap_free_num with this formula, I would like to rename the existing heap.free_num counter. Do you have any s... -
- (2013/10/04 10:09), tmm1 (Aman Gupta) wrote:
> I understand the slot is removed, but `objspace_live_num` includes unfinalized objects so I included them in `heap_limit` also.
>
> Otherwise, `objspace->heap.limit - objspace_live_n... -
- I understand the slot is removed, but `objspace_live_num` includes unfinalized objects so I included them in `heap_limit` also.
Otherwise, `objspace->heap.limit - objspace_live_num(objspace)` can become negative. -
- (2013/10/03 18:29), naruse (Yui NARUSE) wrote:
> https://github.com/tmm1/ruby/compare/gc-stat-free-num.patch
One point.
> @@ -1787,6 +1791,7 @@ struct os_each_struct {
> else {
> struct heap_slot *slot = (struct hea... -
- ko1-san, if you agree with this patch I can commit it.
-
- * io.c (rb_io_close_read): keep fptr in write_io to be discarded, to
fix freed pointer access when it is in use by other threads, and get
rid of potential memory/fd leak.
* io.c (rb_io_close_write): detach ti... -
- * vm_method.c (rb_undef): raise a NameError if the original method
of a refined method is not defined.
* vm_insnhelper.c (rb_method_entry_eq): added NULL check to avoid SEGV.
* test/ruby/test_refinement.rb: re... -
- process.c: rb_daemon should not raise
* process.c (rb_daemon): should not raise exceptions, since
proc_daemon() will deal with errors.
* process.c (fork_daemon): kill the other threads all and abandon the
kep... -
03:38 PM Feature #8977: String#frozen that takes advantage of the deduping
- @nobu
You can implement a separate string pool in 2.0 using like so:
~~~ruby
require 'weakref'
class Pool
def initialize
@pool = {}
end
def get(str)
ref = @pool[str]
# GC may run between alive? and __... - 02:36 PM Feature #8977: String#frozen that takes advantage of the deduping
- > I have seen the suggestion around of having String#freeze amend the object id on the current string, so for example
> ...
C extensions aren't the only reason this wouldn't work. Consider:
a = "foo"
b = a
a.freeze
... -
- @hedius
I have seen the suggestion around of having String#freeze amend the object id on the current string, so for example
> "hi"f.object_id
10
> ...
=> 100
> a.freeze; a.object_id
=> 10
However how would such an implement... -
- (2013/10/04 9:35), nobu (Nobuyoshi Nakada) wrote:
> It differs from the original proposal, which is called explicitly by applications/libraries.
Not different. I described the implementation of String#frozen.
> I think such ... -
- It differs from the original proposal, which is called explicitly by applications/libraries.
I think such pooled strings should not go beyond app/lib domains. -
- (2013/10/04 9:14), nobu (Nobuyoshi Nakada) wrote:
> I don't think it needs a new method nor class.
>
> ~~~ruby
> frozen_pool = Hash.new {|h, s| h[s.freeze] = s}
>
> 3.times {
> p frozen_pool["foo"].object_id
> ... -
- I don't think it needs a new method nor class.
~~~ruby
frozen_pool = Hash.new {|h, s| h[s.freeze] = s}
3.times {
p frozen_pool["foo"].object_id
}
~~~
-
- I'll check r41910 to be backported later.
This ticket can be closed (for trunk)? -
- nobu (Nobuyoshi Nakada) wrote:
> Not only sizes.c, you need BASERUBY to generate some source files after touching template files.
> ...
Yes, it may happen that I may need to change some template for whatever reason, but configure.in is... -
- Not only sizes.c, you need BASERUBY to generate some source files after touching template files.
It's your responsibility. -
-
- Hello,
Thank you for your report.
Could you reproduce this issue with trunk? -
- [Fixes GH-409] https://github.com/ruby/ruby/pull/409
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43141 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * gc.c: rename heap.free_num as heap.swept_num to clarify meaning and
avoid confusion with objspace_free_num().
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43140 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * gc.c (objspace_free_num): new method for available/free slots on
heap. [ruby-core:57633] [Bug #8983]
* gc.c (gc_stat): change heap_free_num definition to use new method.
* test/ruby/test_gc.rb: test for above.... -
- * gc.c: add rb_objspace.limit to keep accurate count of total heap
slots [ruby-core:57633] [Bug #8983]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43138 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- This issue was solved with changeset r43135.
Martin, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.
----------
csv.rb: foreach enumerator
* lib/csv.rb (CSV.foreach): support... -
- another sample where the difference is shown:
CSV.foreach('test.csv').with_index { |csv,i| p i } #<< fails
CSV.to_enum(:foreach,'test.csv').with_index { |csv,i| p i } # works
i think the code from jwillie would be nearly the bes... -
- * common.mk (sizes.c): use MINIRUBY because Init_sizes() for miniruby
is defined in miniinit.c and miniruby does not depend on this file.
[Bug #8968]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43137 b2dd03c8-39d4-4d8f-98ff-82... - 12:32 AM Revision 06583e1f (git): * 2013-10-04
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43136 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * lib/csv.rb (CSV.foreach): support enumerator. based on a patch by
Hanmac (Hans Mackowiak) at [ruby-core:57643]. [ruby-core:57283]
[Feature #8929]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43135 b2dd03c8-39d4-4d8f-98ff-82... -
12:12 AM Feature #8976: file-scope freeze_string directive
- enebo (Thomas Enebo) wrote:
> naruse (Yui NARUSE) wrote:
> ...
Read "Older 2.0 libraries will not be able to read it" as "Older MRI 2.0 implementations will not be able to read libraries which use this new syntax." -
- naruse (Yui NARUSE) wrote:
> enebo (Thomas Enebo) wrote:
> ...
It is an answer but one I think is not acceptable (obviously that is only my opinion).
>
> ...
Yeah. ko1 talked to me yesterday about this. I have been trying to thin...
10/03/2013
-
11:51 PM Feature #8976: file-scope freeze_string directive
- I am mildly in favour of it so +1
As it is compatible with older ruby I see little harm in it. But please don't forget proper documentation, if this is given the thumbs up by matz! -
- duerst (Martin Dürst) wrote:
> From a more general perspective, it feels to me that introducing all
> ...
Personally, I think the more important benefit of having instantly-frozen literal strings, arrays, and hashes is for safer con... -
01:53 PM Feature #8976: file-scope freeze_string directive
- On 2013/10/03 2:27, brixen (Brian Shirai) wrote:
>
> Issue #8976 has been updated by brixen (Brian Shirai).
>> It would be a very bad idea to have a directive that completely changes the meaning of code from one file to another... -
- enebo (Thomas Enebo) wrote:
> I think having a pragma at the top of the file will be much more error prone than the f-syntax. As a file grows, the ability to notice you are in a frozen string file goes down. It would have been great if... -
- Brian since I have been able to infer you dislike both M17n and refinements that you agree with Charlie and I that this particular pragma might not be an idea you endorse? Perhaps you can elucidate a better argument against it?
-
- brixen (Brian Shirai) wrote:
> For consistency sake, it should be noted that, in fact, this is exactly what the existing encoding pragma does, and it's also the express purpose of refinements.
The encoding directive changes the inter... -
02:26 AM Feature #8976: file-scope freeze_string directive
- > It would be a very bad idea to have a directive that completely changes the meaning of code from one file to another.
For consistency sake, it should be noted that, in fact, this is exactly what the existing encoding pragma does, an... -
- I agree with Tom here. I think it's going to be almost useless to have a full-file "freeze-string" directive.
* From file to file, the meaning of a literal string would change. This would be confusing for everyone dealing with a proje... -
-
- RubyGemsのmasterではそこらへんのコードが変わっているので、いい感じにして直しておきます！
-
12:56 AM Bug #8979 (Closed): gem のプロキシ認証情報に @ を含むとエラー
- gem 実行時に認証が必要なプロキシを通す場合、プロキシの認証IDまたはパスワードに「@」を含んでいるとエラーになってしまいます。
----
% http_proxy=http://localhost:8080 http_proxy_user='foo@bar' http_proxy_pass='xxx' gem list -r mysql
*** REMOTE GEMS ***
ERROR: While executing gem ... (UR... -
- headius (Charles Nutter) wrote:
> I ran this in a loop and the object_id eventually stabilizes. I am not sure why.
I think I realize why: eventually the only GC is for the objects in the loop, which are allocated and deallocated the ... -
- sam.saffron (Sam Saffron) wrote:
> the request is all about exposing:
> ...
...
> the encoding concerns are already handled by st_lookup afaik, as is the gc concern
I went to the source to understand how this is implemented. Summar... -
- @hedius
the request is all about exposing:
~~~C
VALUE
rb_fstring(VALUE str)
{
st_data_t fstr;
if (st_lookup(frozen_strings, (st_data_t)str, &fstr)) {
str = (VALUE)fstr;
}
else {
str = rb_str_new_frozen(st... -
- After thinking a bit, I guess what your'e asking for is a method that gives you the VM-level object that would be returned for a literal frozen version of the same string. However, it's unclear to me what #frozen or #dedup or #pooled wou...
-
- How is this not just a symbol table of another sort? When do these pooled strings get GCed? Do they ever get GCed? What if the encodings differ?
There's a whole bunch of implementation details that scare me about this proposal. -
- naruse (Yui NARUSE) wrote:
> You should suggest acceptable plan.
> ...
I know, but I had to report it for the record. I stay with 'touch' for now. Hopefully other folks come later with better idea. -
- You should suggest acceptable plan.
You know such way is not acceptable. -
-
- naruse: Within what group do I need to get consensus? All ruby-core committers?
-
- Ok I have been talked out of the allowing changing contents of the literal. Without guaranteeing the values never change then it is very limited in when you can do most of the "good" optimizations. They can be done but generally only i...
-
- My take on this proposal is that deep and shallow freezing is not as important as knowing that the 'f' (which I think should mean fixed and not frozen) is that once the array literal evaluates it will not be possible to change its size. ...
-
- I have started a wiki page for the proposal: https://bugs.ruby-lang.org/projects/ruby-trunk/wiki/Frozen_Array_and_Hash_literals_proposal
Please comment here or make comments as edits there. -
- naruse (Yui NARUSE) wrote:
> headius (Charles Nutter) wrote:
> ...
It is unfortunate these meetings cannot be attended by other implementers. Was this only for Japanese-speaking contributors?
> If a feature needs more discussion, it... -
-
- In ruby 1.9 and 2.0, gc_stat() used to call rest_sweep() so heap_free_num always equals the number of free slots (ObjectSpace.count_objects[:FREE]). In 2.1 the rest_sweep() was removed, so free_num is not always accurate. This patch fixe...
-
- This issue was solved with changeset r43131.
Denis, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.
----------
win32.c: disable console colorizing
* win32/win32.c (console_em... -
- No reply.
-
03:23 PM Bug #8982 (Closed): NoMethodError#message produces surprising output when #inspect is defined on an anonymous class
- =begin
Given the following script:
def raise_no_method_error_for_anonymous_class_with_inspect(&block)
klass = Class.new do
define_method(:inspect, &block)
end
begin
instance = klass.new
puts "#inspect... -
- This issue was solved with changeset r43129.
Vit, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.
----------
common.mk: use RUNRUBY for test-sample
* common.mk (yes-test-samp... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43134 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * test/ruby/test_io.rb (test_pid_after_close_read): fix typo. pointed
out by Peter Suschlik.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43133 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
11:08 AM Bug #8975: Confusing code sample for assert_send
- To be honest, it's not so much a "legacy app" issue as a "legacy programmer" issue.
I started programming back in Ruby 1.8.6. I don't use any opinionated web development frameworks such as Rails (I don't do web development at all, act... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43132 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * win32/win32.c (console_emulator_p, constat_handle): disable built-in
console colorizing when console-emulator-like DLL is injected.
[Feature #8201]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43131 b2dd03c8-39d4-4d8f-98ff-82... -
- CALC_EXACT_MALLOC_SIZE is true.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43130 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
-
02:46 AM Bug #7984: Severe speed issues in 2.0.0 compiled with Clang
- With 2.0.0-p247 I get:
11.540000 0.010000 11.550000 ( 11.561841)
So apparently whatever the issue was got fixed either in rvm or in Clang or OSX or in the newer patch level of Ruby. -
- tobiassvn (Tobias Svensson) wrote:
> I suppose if this is being added to MonitorMixin it should probably be in Mutex_m as well?
I don't think so, since a Mutex is not reentrant and what we want is monitor semantics for #synchronized. -
- * common.mk (yes-test-sample): use RUNRUBY instead of MINIRUBY to set
runtime library path and run the built ruby. [Bug #8971]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43129 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- ko1 (Koichi Sasada) wrote:
> Sorry, it is not same, but we can consier that.
> ...
So to summarize:
* Exceptions will log when they bubble out of a thread, as with -d, unless `Thread#report_on_exception == false`
* `Thread#report_o... -
- Almost of those names are defined by C standard or POSIX, so they won't change.
I think what names are included is *not* a spec, however.
New names may be added or existing names may be deleted, without any notice.
I think all I can... -
- Ok...so hopefully we have tests for those names and we can consider them "spec".
BTW, I'm asking because we'll want to provide the same SIZEOF hash in JRuby, and I need to know the names will be consistent and not change in the future... -
- Sorry that it's unclear.
It means that type names come from a distributed file, configure.in, so they are invariant on all platforms.
As for C standard, all names will become strings as-is, even if a type is defined by macro. -
- Incorporated.
Please attach your patch here. -
02:32 AM Feature #8981 (Feedback): Suggestion for CreateProcess flags with rubyw on windows
- Hi,
I've spent some time looking into the feasibility of using rubyw in my code and at first glance it looks ideal. However there are a lot of console windows flashing up when I run external processes using Open3::popen3 (because I... -
- * thread_pthread.c (thread_timer): set timer thread name on OSX too.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43128 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
12:54 AM Bug #8182: XMLRPC request fails with "Wrong size. Was 31564, should be 1501"
- Just a reminder, this fix is not not yet in 2.1.0 rc1.
https://github.com/ruby/ruby/blob/v2_1_0_preview1/lib/xmlrpc/client.rb?source=c#L509
Would love to see it in there! - 12:43 AM Revision 0b991b65 (git): * hash.c (env_update): [DOC] fix expected output, should be 0 instead
- of 10. Patch by @yakko. [GH-411]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43127 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
12:10 AM Feature #8840: Yielder#state
- akr (Akira Tanaka) wrote:
> Would you explain the incompleteness concretely?
Sure. With your code above:
e.drop2(40).map(&:odd?) # => [true, false]
# expected lazy enumerator, as with original drop:
e.drop(40).map(&:...
10/02/2013
-
- I think having a pragma at the top of the file will be much more error prone than the f-syntax. As a file grows, the ability to notice you are in a frozen string file goes down. It would have been great if Ruby had started immutable str...
-
09:18 PM Feature #8976: file-scope freeze_string directive
- Maybe I'm too late but why not use the same object when calling String#freeze?
I mean, currently this:
> "something".freeze.object_id
=> 70273877530260
> "something".freeze.object_id
=> 70273877536840
And change the c... - 03:18 PM Feature #8976: file-scope freeze_string directive
- > I forgot to mention Akira Matsuda's presentation at RubyShift 2013:
> ...
To be fair, you wouldn't really use f-suffix strings in all the places they were used in the presentation. They're only really useful in tight loops, or in code... -
- akr (Akira Tanaka) wrote:
> There are several problems for f-suffix:
> ...
I forgot to mention Akira Matsuda's presentation at RubyShift 2013:
http://sssslide.com/speakerdeck.com/a_matsuda/rails-engines-from-the-bottom-up
(The pres... -
- (2013/10/02 13:18), sam.saffron (Sam Saffron) wrote:
> Can we also have a global switch to enable this everywhere (for debugging), it can make it simple to isolate the spots where it would fall over.
+1. It should be another tic... -
- Can we also have a global switch to enable this everywhere (for debugging), it can make it simple to isolate the spots where it would fall over.
-
- coupled with this I strongly feel we need a more usable way of using the deduping elsewhere.
Currently string#freeze will only affect the current string. If we had a string#frozen we could have it return a deduped frozen copy. From mem... -
- https://github.com/nobu/ruby/tree/frozen_string_pragma
-
- Yesterday, we had a face-to-face developer meeting.
https://bugs.ruby-lang.org/projects/ruby/wiki/DevelopersMeeting20131001Japan
Several committers attended.
matz didn't attended, though. (This means this issue is not concluded.)
... -
10:15 PM Feature #8961: Synchronizable module to easily wrap methods in a mutex
- I suppose if this is being added to MonitorMixin it should probably be in Mutex_m as well?
-
- nobu (Nobuyoshi Nakada) wrote:
> headius (Charles Nutter) wrote:
> ...
Yeah, that's not a bad option from a pure-Ruby perspective. We could add "synchronized" to classes that include MonitorMixin, perhaps?
* added to monitor.rb:
... - 10:12 PM Feature #8977: String#frozen that takes advantage of the deduping
- ko1 and I discussed this in IRC and decided that #frozen would be too easily confused with #freeze. An idea that came up was to use #dedup or #pooled instead. What do you think Sam?
-
- @nobu
"html.erb" is very unlikely to be shared cause it is a result of a parse. "base64" and "IANA" are coming from the super dodgy mime types gem here: https://github.com/halostatue/mime-types/blob/master/lib/mime/types/application i... -
- Won't those strings be shared with frozen string literal?
- 02:00 PM Feature #8977: String#frozen that takes advantage of the deduping
- I would love to see this feature in 2.1.
These are the top duplicated strings in an app I work on:
~~~ruby
irb(main):023:0> GC.start; h = ObjectSpace.each_object(String).to_a.group_by { |s| s }.map{ |s, objs| [s, objs.size] }; h.s... -
- During memory profiling I noticed that a large amount of string duplication is generated from non pre-determined strings.
Take this report for example https://gist.github.com/SamSaffron/6789005 (generated using the memory_profiler gem... -
- Hello Aaron,
Coverity Scan found a possible bug in "initialize" function of ext/fiddle/closure.c:
> result = ffi_prep_closure(pcl, cif, callback, (void *)self);
> ...
I don't understand the code completely, but the size of the poi... -
-
- Thanks for the report Andrew!
I'm really glad we got a doc bug reported for TestUnit, this confirms my suspicion that people are still using TU for legacy apps and still need accurate documentation.
I will have to reconsider how we... -
- Test::Unit::Assertsions#assert_send has the code sample
assert_send([[1, 2], :member?, 1]) # -> pass
assert_send([[1, 2], :member?, 4]) # -> fail
Having an array within an array is somewhat confusing. When I first read it,... -
- * tool/rbinstall.rb: install default targets (:local, :ext) first,
very time consuming tasks later.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43126 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43125 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43124 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Sorry, it is not same, but we can consier that.
BTW, I think it true as default is good idea.
IMO, inter-thread communication via exception with Thread#join should be bad idea.
-
- FYT:
On pthread, there is pthread_detach() which declares nobody join on this thread.
In other words, pthread_detach() is same as Thread#report_on_exception=true.
-
- akr (Akira Tanaka) wrote:
> In the yesterday's meeting,
> ...
...
> If thread exiting with exception outputs a message,
> ...
GC is a pretty fuzzy time boundary, but it's not terrible. Handling it will mean some finalization requirem... -
- In the yesterday's meeting,
https://bugs.ruby-lang.org/projects/ruby/wiki/DevelopersMeeting20131001Japan
we discussed this issue.
We found that message at thread exiting with exception have a problem.
The thread can be joined after... - 03:25 PM Revision 6bb3105d (git): * 2013-10-03
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43123 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 03:25 PM Revision 42b72a08 (git): * misc/ruby-additional.el: Properly quote the body. An unquoted
- body given to eval-after-load is evaluated immediately!
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43122 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- headius (Charles Nutter) wrote:
> It would not be hard, given the guarantee that CLOCK_REALTIME works across platforms, to provide a #timestamp that is always CLOCK_REALTIME.
> ...
We can but whether is is official or not is matz's dec... -
- It would not be hard, given the guarantee that CLOCK_REALTIME works across platforms, to provide a #timestamp that is always CLOCK_REALTIME.
Can we do that, so we have an official API? -
- headius (Charles Nutter) wrote:
> This is now provided by #8658 in 2.1, but according to matz in the developer meeting notes linked there, Process::clock_gettime is not considered "spec".
> ...
Process.clock_gettime is low level API; i... -
- I can not decide Ruby's specification.
-
- This is now provided by #8658 in 2.1, but according to matz in the developer meeting notes linked there, Process::clock_gettime is not considered "spec".
So I'm not sure if this can be closed or not...we need to decide.
Optimistica... -
- headius (Charles Nutter) wrote:
> Also, FWIW, ko1 told me to mark the bugs I was interested in as 2.1, which is why I set this bug for 2.1.
Therefore we discussed about this on RubyDeveloperMeeting20131001.
> ...
Through the meeti... -
- Also, FWIW, ko1 told me to mark the bugs I was interested in as 2.1, which is why I set this bug for 2.1.
-
- Has this already been excluded from 2.1.0? May I ask why? We have not finished discussing it and most folks on this issue believe it would be a good feature to have.
After hearing Tony's case about the value of []f and {}f being more ... -
- nobu (Nobuyoshi Nakada) wrote:
> =begin
> ...
I interpret this to mean that the names of the types should be ANSI/ISO C standard names. If that's the case, I'm satisfied.
My concern is if the type names vary across platforms; they w... -
- =begin
They are extracted from ((%configure.in%)) script automatically.
And ANSI/ISO C standard requires stringize operator to turn the argument into a string literal ((*before*)) expanding it.
=end
-
- nobu (Nobuyoshi Nakada) wrote:
> r42685
Thanks! I do have one question, though.. are the names of the types (acquired via #type in sizes.c) guaranteed to be consistent across platforms/compilers? -
- akr (Akira Tanaka) wrote:
> 2013/10/2 headius (Charles Nutter) <headius@headius.com>:
> ...
It is r42557 and other commits -
- 2013/10/2 headius (Charles Nutter) <headius@headius.com>:
> I HAVE A QUESTION, however... what about Windows? There's no mention at all in the rdoc about Windows support. I need to investigate what currentTimeMillis and nanoTime do... -
- Implementation in JRuby: https://github.com/jruby/jruby/commit/8c066241bd847b68d8d7255893edbad2d6c311d2
-
- JRuby issue for this feature: https://github.com/jruby/jruby/issues/1056
Windows information for JVM:
System.currentTimeMillis is always implemented using win32 GetSystemTimeAsFileTime function.
http://msdn.microsoft.com/en-us/l... -
- I missed the discussion on this, but here's the summary of JRuby/JVM case:
If monotonic clock is available at OS level, System.nanoTime is equivalent to clock_gettime(CLOCK_MONOTONIC). I suppose there may be some embedded systems or o... -
- When a system had no interface, this function used xmalloc for root
but did not return any reference to it. This patch fixes it by
immediately returning an empty array if no interface is found.
Coverity Scan found this bug.
git-s... -
- out of scope. Coverity Scan found this bug.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43120 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- marcandre (Marc-Andre Lafortune) wrote:
>
> ...
Would you explain the incompleteness concretely?
I couldn't understand.
-
- I'm sorry for my late reply, I'm way back on many things I want to do.
The proposition of `with_state` is interesting, but I personally find it leads to complex/convoluted solutions and is cumbersome to use. Note that the given implem... -
10:15 AM Feature #7854: New method Symbol[string]
- This was set to "next minor" a LONG time ago, but I don't see it in 2.1. ??? This would aid security in a couple of ways.
-
- * gc.c (GC_MALLOC_LIMIT_MAX): change default value
(256MB -> 512MB) and permit zero to ignore max value.
* gc.c (vm_malloc_increase, vm_xrealloc): do not cause GC on realloc.
* gc.c (gc_before_sweep): change debug messages.
git-svn-... -
- * test/ruby/test_io.rb (tesst_pid_after_close_read): test for r43117.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43118 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- I also thought that maybe you can go one step further and allow any sequence of white characters as delimiters when the parentheses/braces/brackets/pipes are not omitted:
~~~ruby
foo(:foo :bar :baz)
{foo: "bar baz: "qux"}
[:foo :ba... -
- Another case where similar syntax might be relevant is `| |` inside a block. Whether you want to do this:
~~~ruby
{|
foo
bar
baz
| ....}
~~~
should go together with whether arguments in method definition can be written ... -
05:08 AM Feature #8956: Allow hash members delimited by \n inside of {}
- I should also mention that this patch does not apply to method definitions, so these still require commas (at least, for now):
~~~ruby
def some_method(foo,
bar,
baz)
# do stuff
end
~~~
-
- Sorry, the previous patch was incorrect (add-method-arg-support.patch). Please use the attached version instead.
-
- Adding a patch for method argument support. For example, this allows the following syntaxes:
~~~ruby
Hash[
:foo, 'bar'
:baz, 'qux'
]
~~~
which becomes `{ :foo => "bar", :baz => "qux" }`, as well as
~~~ruby
puts("this i... -
- * io.c (rb_io_close_read): duplex IO should wait its child process
even after close_read.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43117 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- clang says "Note that marketing version numbers should not be used
to check for language features, as different vendors use different
numbering schemes. Instead, use the Feature Checking Macros."
http://clang.llvm.org/docs/Language... -
- Trying to wake this one up in hopes of getting it into 2.1. Is there any chance?
Forgive me if I'm breaking process somehow, but ko1 told me to mark the issues I want in 2.1 with Target version=2.1, so I've been doing that. -
- https://bugs.ruby-lang.org/issues/8568
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43115 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * io.c (rb_io_close_write): detach tied IO for writing before closing
to get rid of race condition. [ruby-list:49598]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43114 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 05:19 AM Revision 145ecb68 (git): * 2013-10-02
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43113 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * io.c (rb_io_close_read): keep fptr in write_io to be discarded, to
fix freed pointer access when it is in use by other threads, and get
rid of potential memory/fd leak.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43112 b2dd0... -
- naruse (Yui NARUSE) wrote:
> ko1 will write objection.
I look forward to reading that objection :-)