Activity
From 09/26/2013 to 10/02/2013
10/02/2013
-
11:36 PM Feature #8976: file-scope freeze_string directive
- I think having a pragma at the top of the file will be much more error prone than the f-syntax. As a file grows, the ability to notice you are in a frozen string file goes down. It would have been great if Ruby had started immutable str...
-
09:18 PM Feature #8976: file-scope freeze_string directive
- Maybe I'm too late but why not use the same object when calling String#freeze?
I mean, currently this:
> "something".freeze.object_id
=> 70273877530260
> "something".freeze.object_id
=> 70273877536840
And change the c... -
03:18 PM Feature #8976: file-scope freeze_string directive - > I forgot to mention Akira Matsuda's presentation at RubyShift 2013:
> ...
To be fair, you wouldn't really use f-suffix strings in all the places they were used in the presentation. They're only really useful in tight loops, or in code... -
03:08 PM Feature #8976: file-scope freeze_string directive
- akr (Akira Tanaka) wrote:
> There are several problems for f-suffix:
> ...
I forgot to mention Akira Matsuda's presentation at RubyShift 2013:
http://sssslide.com/speakerdeck.com/a_matsuda/rails-engines-from-the-bottom-up
(The pres... -
01:23 PM Feature #8976: file-scope freeze_string directive
- (2013/10/02 13:18), sam.saffron (Sam Saffron) wrote:
> Can we also have a global switch to enable this everywhere (for debugging), it can make it simple to isolate the spots where it would fall over.
+1. It should be another tic... -
01:18 PM Feature #8976: file-scope freeze_string directive
- Can we also have a global switch to enable this everywhere (for debugging), it can make it simple to isolate the spots where it would fall over.
-
- coupled with this I strongly feel we need a more usable way of using the deduping elsewhere.
Currently string#freeze will only affect the current string. If we had a string#frozen we could have it return a deduped frozen copy. From mem... -
11:03 AM Feature #8976: file-scope freeze_string directive
- https://github.com/nobu/ruby/tree/frozen_string_pragma
-
- Yesterday, we had a face-to-face developer meeting.
https://bugs.ruby-lang.org/projects/ruby/wiki/DevelopersMeeting20131001Japan
Several committers attended.
matz didn't attended, though. (This means this issue is not concluded.)
... -
10:15 PM Feature #8961: Synchronizable module to easily wrap methods in a mutex
- I suppose if this is being added to MonitorMixin it should probably be in Mutex_m as well?
-
02:13 AM Feature #8961: Synchronizable module to easily wrap methods in a mutex
- nobu (Nobuyoshi Nakada) wrote:
> headius (Charles Nutter) wrote:
> ...
Yeah, that's not a bad option from a pure-Ruby perspective. We could add "synchronized" to classes that include MonitorMixin, perhaps?
* added to monitor.rb:
... - 10:12 PM Feature #8977: String#frozen that takes advantage of the deduping
- ko1 and I discussed this in IRC and decided that #frozen would be too easily confused with #freeze. An idea that came up was to use #dedup or #pooled instead. What do you think Sam?
-
- @nobu
"html.erb" is very unlikely to be shared cause it is a result of a parse. "base64" and "IANA" are coming from the super dodgy mime types gem here: https://github.com/halostatue/mime-types/blob/master/lib/mime/types/application i... -
- Won't those strings be shared with frozen string literal?
- 02:00 PM Feature #8977: String#frozen that takes advantage of the deduping
- I would love to see this feature in 2.1.
These are the top duplicated strings in an app I work on:
~~~ruby
irb(main):023:0> GC.start; h = ObjectSpace.each_object(String).to_a.group_by { |s| s }.map{ |s, objs| [s, objs.size] }; h.s... -
- During memory profiling I noticed that a large amount of string duplication is generated from non pre-determined strings.
Take this report for example https://gist.github.com/SamSaffron/6789005 (generated using the memory_profiler gem... -
10:05 PM Bug #8978 (Closed): Fiddle possibly misuses mprotect
- Hello Aaron,
Coverity Scan found a possible bug in "initialize" function of ext/fiddle/closure.c:
> result = ffi_prep_closure(pcl, cif, callback, (void *)self);
> ...
I don't understand the code completely, but the size of the poi... -
09:19 PM Bug #8975 (Assigned): Confusing code sample for assert_send
-
- Thanks for the report Andrew!
I'm really glad we got a doc bug reported for TestUnit, this confirms my suspicion that people are still using TU for legacy apps and still need accurate documentation.
I will have to reconsider how we... -
07:48 AM Bug #8975 (Closed): Confusing code sample for assert_send
- Test::Unit::Assertsions#assert_send has the code sample
assert_send([[1, 2], :member?, 1]) # -> pass
assert_send([[1, 2], :member?, 4]) # -> fail
Having an array within an array is somewhat confusing. When I first read it,... -
- * tool/rbinstall.rb: install default targets (:local, :ext) first,
very time consuming tasks later.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43126 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43125 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43124 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Sorry, it is not same, but we can consier that.
BTW, I think it true as default is good idea.
IMO, inter-thread communication via exception with Thread#join should be bad idea.
-
- FYT:
On pthread, there is pthread_detach() which declares nobody join on this thread.
In other words, pthread_detach() is same as Thread#report_on_exception=true.
-
- akr (Akira Tanaka) wrote:
> In the yesterday's meeting,
> ...
...
> If thread exiting with exception outputs a message,
> ...
GC is a pretty fuzzy time boundary, but it's not terrible. Handling it will mean some finalization requirem... -
- In the yesterday's meeting,
https://bugs.ruby-lang.org/projects/ruby/wiki/DevelopersMeeting20131001Japan
we discussed this issue.
We found that message at thread exiting with exception have a problem.
The thread can be joined after... - 03:25 PM Revision 6bb3105d (git): * 2013-10-03
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43123 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 03:25 PM Revision 42b72a08 (git): * misc/ruby-additional.el: Properly quote the body. An unquoted
- body given to eval-after-load is evaluated immediately!
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43122 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
02:37 PM Feature #8096: introduce Time.current_timestamp
- headius (Charles Nutter) wrote:
> It would not be hard, given the guarantee that CLOCK_REALTIME works across platforms, to provide a #timestamp that is always CLOCK_REALTIME.
> ...
We can but whether is is official or not is matz's dec... -
- It would not be hard, given the guarantee that CLOCK_REALTIME works across platforms, to provide a #timestamp that is always CLOCK_REALTIME.
Can we do that, so we have an official API? -
- headius (Charles Nutter) wrote:
> This is now provided by #8658 in 2.1, but according to matz in the developer meeting notes linked there, Process::clock_gettime is not considered "spec".
> ...
Process.clock_gettime is low level API; i... -
- I can not decide Ruby's specification.
-
- This is now provided by #8658 in 2.1, but according to matz in the developer meeting notes linked there, Process::clock_gettime is not considered "spec".
So I'm not sure if this can be closed or not...we need to decide.
Optimistica... -
- headius (Charles Nutter) wrote:
> Also, FWIW, ko1 told me to mark the bugs I was interested in as 2.1, which is why I set this bug for 2.1.
Therefore we discussed about this on RubyDeveloperMeeting20131001.
> ...
Through the meeti... -
- Also, FWIW, ko1 told me to mark the bugs I was interested in as 2.1, which is why I set this bug for 2.1.
-
- Has this already been excluded from 2.1.0? May I ask why? We have not finished discussing it and most folks on this issue believe it would be a good feature to have.
After hearing Tony's case about the value of []f and {}f being more ... -
- nobu (Nobuyoshi Nakada) wrote:
> =begin
> ...
I interpret this to mean that the names of the types should be ANSI/ISO C standard names. If that's the case, I'm satisfied.
My concern is if the type names vary across platforms; they w... -
- =begin
They are extracted from ((%configure.in%)) script automatically.
And ANSI/ISO C standard requires stringize operator to turn the argument into a string literal ((*before*)) expanding it.
=end
-
- nobu (Nobuyoshi Nakada) wrote:
> r42685
Thanks! I do have one question, though.. are the names of the types (acquired via #type in sizes.c) guaranteed to be consistent across platforms/compilers? -
- akr (Akira Tanaka) wrote:
> 2013/10/2 headius (Charles Nutter) <headius@headius.com>:
> ...
It is r42557 and other commits -
- 2013/10/2 headius (Charles Nutter) <headius@headius.com>:
> I HAVE A QUESTION, however... what about Windows? There's no mention at all in the rdoc about Windows support. I need to investigate what currentTimeMillis and nanoTime do... -
- Implementation in JRuby: https://github.com/jruby/jruby/commit/8c066241bd847b68d8d7255893edbad2d6c311d2
-
- JRuby issue for this feature: https://github.com/jruby/jruby/issues/1056
Windows information for JVM:
System.currentTimeMillis is always implemented using win32 GetSystemTimeAsFileTime function.
http://msdn.microsoft.com/en-us/l... -
- I missed the discussion on this, but here's the summary of JRuby/JVM case:
If monotonic clock is available at OS level, System.nanoTime is equivalent to clock_gettime(CLOCK_MONOTONIC). I suppose there may be some embedded systems or o... -
- When a system had no interface, this function used xmalloc for root
but did not return any reference to it. This patch fixes it by
immediately returning an empty array if no interface is found.
Coverity Scan found this bug.
git-s... -
- out of scope. Coverity Scan found this bug.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43120 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- marcandre (Marc-Andre Lafortune) wrote:
>
> ...
Would you explain the incompleteness concretely?
I couldn't understand.
-
10:31 AM Feature #8840: Yielder#state
- I'm sorry for my late reply, I'm way back on many things I want to do.
The proposition of `with_state` is interesting, but I personally find it leads to complex/convoluted solutions and is cumbersome to use. Note that the given implem... -
10:15 AM Feature #7854: New method Symbol[string]
- This was set to "next minor" a LONG time ago, but I don't see it in 2.1. ??? This would aid security in a couple of ways.
-
- * gc.c (GC_MALLOC_LIMIT_MAX): change default value
(256MB -> 512MB) and permit zero to ignore max value.
* gc.c (vm_malloc_increase, vm_xrealloc): do not cause GC on realloc.
* gc.c (gc_before_sweep): change debug messages.
git-svn-... -
- * test/ruby/test_io.rb (tesst_pid_after_close_read): test for r43117.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43118 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
07:41 AM Feature #8956: Allow hash members delimited by \n inside of {}
- I also thought that maybe you can go one step further and allow any sequence of white characters as delimiters when the parentheses/braces/brackets/pipes are not omitted:
~~~ruby
foo(:foo :bar :baz)
{foo: "bar baz: "qux"}
[:foo :ba... -
- Another case where similar syntax might be relevant is `| |` inside a block. Whether you want to do this:
~~~ruby
{|
foo
bar
baz
| ....}
~~~
should go together with whether arguments in method definition can be written ... -
05:08 AM Feature #8956: Allow hash members delimited by \n inside of {}
- I should also mention that this patch does not apply to method definitions, so these still require commas (at least, for now):
~~~ruby
def some_method(foo,
bar,
baz)
# do stuff
end
~~~
-
- Sorry, the previous patch was incorrect (add-method-arg-support.patch). Please use the attached version instead.
-
- Adding a patch for method argument support. For example, this allows the following syntaxes:
~~~ruby
Hash[
:foo, 'bar'
:baz, 'qux'
]
~~~
which becomes `{ :foo => "bar", :baz => "qux" }`, as well as
~~~ruby
puts("this i... -
- * io.c (rb_io_close_read): duplex IO should wait its child process
even after close_read.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43117 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- clang says "Note that marketing version numbers should not be used
to check for language features, as different vendors use different
numbering schemes. Instead, use the Feature Checking Macros."
http://clang.llvm.org/docs/Language... -
- Trying to wake this one up in hopes of getting it into 2.1. Is there any chance?
Forgive me if I'm breaking process somehow, but ko1 told me to mark the issues I want in 2.1 with Target version=2.1, so I've been doing that. -
- https://bugs.ruby-lang.org/issues/8568
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43115 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * io.c (rb_io_close_write): detach tied IO for writing before closing
to get rid of race condition. [ruby-list:49598]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43114 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 05:19 AM Revision 145ecb68 (git): * 2013-10-02
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43113 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * io.c (rb_io_close_read): keep fptr in write_io to be discarded, to
fix freed pointer access when it is in use by other threads, and get
rid of potential memory/fd leak.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43112 b2dd0... -
- naruse (Yui NARUSE) wrote:
> ko1 will write objection.
I look forward to reading that objection :-)
10/01/2013
-
11:08 PM Bug #8972: TestMkmf::TestConfig#test_dir_config fails on x86_64
- It works now. Thank you!
-
- This issue was solved with changeset r43106.
Vit, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.
----------
test_config.rb: fix library path
* test/mkmf/test_config.rb (test... -
- =begin
It might be due to my configuration options, but I observe following test failure:
TestMkmf::TestConfig#test_dir_config [/builddir/build/BUILD/ruby-2.1.0-preview1/test/mkmf/test_config.rb:13]:
[Bug #8074].
<["/test/foo/in... -
- This is my configuration command:
$ ./configure --build=x86_64-redhat-linux-gnu --host=x86_64-redhat-linux-gnu --program-prefix= --disable-dependency-tracking --prefix=/usr --exec-prefix=/usr --bindir=/usr/bin --sbindir=/usr/sbin --sy... -
- How did you run `configure`?
-
- =begin
$ make check 'TESTS=-v '
CC = gcc
LD = ld
LDSHARED = gcc -shared
CFLAGS = -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong --param=ssp-buffer-size=4 -grecord-gcc-switches -mtune=generi... -
- This issue was solved with changeset r43110.
Eric, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.
----------
tempfile.rb: undefine finalizer on unlink
* lib/tempfile.rb (Tem... -
- In Ruby 2.0, when using "--with-multiarch" together with "--with-rubyarchprefix", it used ${libdir} for libruby.so library placement (i.e. /usr/lib64/). Now it is hardcoded to ${libdir}/${arch} (i.e. /usr/lib64/x86_64-linux). Hence there...
-
- Was it possible ever?
-
- Since r39347, there is impossible to configure placement of rubylib.so when build is configured with "--with-multiarch". That is probably OK for Debian, but it breaks Fedora :/ The attached patch allows to configure the archlibdir, but I...
-
- I observe the same issue on Fedora Rawhide i386.
$ ruby -v
ruby 2.1.0dev (2013-09-22 trunk 43011) [i686-linux] -
- This issue was solved with changeset r43107.
Hans, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.
----------
file.c: export rb_stat_new
* file.c (stat_new_0): constify.
* fi... -
- this is nobu's issue because this is C API.
-
- Actually, it seems to be resolved by r41293.
-
- Could this be merged for 2.1 please? It would allow Fedora to carry one less patch. Thanks.
-
- Not sure why I did not attached patch, so here it is.
-
- Thank you for your report.
I'm seeking a reason of this issue, too.
And I can't find out it now.
Helps are very welcome. -
- =begin
I did a few test build of Ruby package for Fedora 21 and suddenly TestTracepointObj#test_tracks_objspace_events failed:
4) Failure:
TestTracepointObj#test_tracks_objspace_events [/builddir/build/BUILD/ruby-2.1.0-preview1/te... -
- Could you check it?
-
- Need marcandre's reply
-
- Matz, how about it?
(no compatibility issue, we have an implementation)
-
- Maybe you want to use it for CV to make it fast.
However, we are not recommend CV because it is difficult primitive.
So we shouldn't touch it.
-
- ユースケースとして弱い・本来剣呑である非同期割り込みを増やしたくない、という理由で reject とさせて下さい。
-
- I'm negative because it causes code complex unless it has performance improvement.
-
- No conclusion.
-
- Show concrete use case.
-
- Do you mean this?
```ruby
def format(*args)
sprintf(self, *args)
end
```
or
```ruby
def format(*args)
self % args
end
```
-
05:00 PM Bug #6514 (Rejected): Abort trap: 6 running rspec on rdf.rb
- Closing this due to no feedbacks.
-
-
-
- ko1 will write objection.
-
- I implemented this and a simple test in https://github.com/ruby/ruby/pull/405
If approved, I can merge that or commit to trunk directly.
The performance impact of Monitor is a separate issue; Monitor should probably be implemented ... -
07:23 AM Feature #8556: MutexedDelegator as a trivial way to make an object thread-safe
- On Mon, Sep 30, 2013 at 5:13 PM, headius (Charles Nutter) <
headius@headius.com> wrote:
> and the code should use Monitor instead of Mutex so it can be reentrant.
I'm trying to think of a case in which this would matter. ... -
- SynchronizedDelegator is a better name, and the code should use Monitor instead of Mutex so it can be reentrant. I'll do that now.
-
- I'm positive about this feature.
Matz, what do you think about?
- 02:45 PM Revision d60c6c86 (git): * vm_core.h: use __attribute__((unused)) in UNINTIALIZED_VAR on clang
- 4.0+ instead of just on 4.2. Clang has supported the unused attribute
since before version 4, so this should be safe.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43111 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- akr, The difference between `Array#transpose` and `Array.zip` is just the same as with `Array#transpose` and `Array#zip`. That is, when any non-first array is shorter than the first, it is complemented with `nil`.
-
- 2013/10/1 sawa (Tsuyoshi Sawada) <sawadatsuyoshi@gmail.com>:
> Feature #8970: Array.zip and Array.product
> https://bugs.ruby-lang.org/issues/8970
> Most of the time when I use `Array#zip` or `Array#product`, I feel cumbursome ... -
- =begin
Most of the time when I use `Array#zip` or `Array#product`, I feel cumbursome that I have to take out the first array and pass it as a receiver. For example, if I have
a = [[:a, :b, :c], [:d, :e, :f], [:g, :h, :i]]
I ha... -
- nobu (Nobuyoshi Nakada) wrote:
> My opinion is still unchanged.
> ...
In case my opinion wasn't clear, or has been fogged over the last few months, I'll make it clear again.
WeakRef is broken when used as a delegate, because any met... -
- My opinion is still unchanged.
"It should be another new class". -
- Put my patch into an updated pull request: https://github.com/ruby/ruby/pull/406
-
- * lib/tempfile.rb (Tempfile#unlink): finalizer is no longer needed
after unlinking. patched by by normalperson (Eric Wong) at
[ruby-core:56521] [Bug #8768]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43110 b2dd03c8-39d4-4d8f-... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43109 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * ext/-test-/file/stat.c: extension library to test [Feature #8050].
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43108 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * file.c (stat_new_0): constify.
* file.c (rb_stat_new): constify and export. based on a patch by
Hanmac (Hans Mackowiak) at [ruby-core:53225]. [Feature #8050]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43107 b2dd03c8-39d4-4d... -
- * test/mkmf/test_config.rb (test_dir_config): fix expected library
path. [ruby-core:57535] [Bug #8972]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43106 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Put my patch plus a test in a PR: https://github.com/ruby/ruby/pull/408
Unfortunately the test doesn't pass, and I think it should. I'm confused as to why it fails. -
- r42685
-
- avdi (Avdi Grimm) wrote:
> That said, if you really wanted to preserve the ability to return something
> ...
That wouldn't be backward-compatible with anyone expecting last expression, but it's an excellent idea to address Shugo's con... -
09:00 AM Bug #7445: strptime('%s %z') doesn't work
- tadf (tadayoshi funaba) wrote:
> I will give written in Japanese English because I heard not hold water .
I've used Google translate which does a poor job, but you have left me no choice.
> ...
Totally unparsable.
> quoted from... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43105 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * test/ruby/test_regexp.rb (test_eq_tilde_can_be_overridden): use assert_separately
to suppress a warning.
* test/ruby/test_string.rb (test_eq_tilde_can_be_overridden): ditto.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43104 b2... -
- * include/ruby/ruby.h (ruby_safe_level_4_warning): needed by extension
libraries which check safe level 4. [ruby-dev:47517] [Bug #8652]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43103 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- I've attached a patch for array support (only between square brackets). I've also renamed the `assoc_seperator` rule to be `nl_or_comma` to make it a little more generic.
This allows for syntax similar to hashes (here's a rather compl... - 05:49 AM Revision c4be7faa (git): * 2013-10-01
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43102 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * test/ruby/test_regexp.rb (test_eq_tilde_can_be_overridden): suppress
a warning.
* test/ruby/test_string.rb (test_eq_tilde_can_be_overridden): ditto.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43101 b2dd03c8-39d4-4d8f-98ff-823...
09/30/2013
-
- On Fri, Sep 27, 2013 at 6:59 AM, headius (Charles Nutter) <
headius@headius.com> wrote:
> I propose adding MutexedDelegator as a simple way to wrap any object with
> a thread-safe wrapper, via existing delegation logic in deleg... -
- On Sat, Sep 28, 2013 at 2:39 AM, shugo (Shugo Maeda)
<redmine@ruby-lang.org>wrote:
> For example, bootstraptest/test_block.rb uses the last value of a class
> definition as follows:
The only time I've ever used the retu... -
- shugo (Shugo Maeda) wrote:
> I did a quick hack to try this proposal and found that some test failed with it:
> ...
The case given is rather contrived; I have never seen code in the wild use last expression return from a class.
> If... -
- Testing seems to indicate this is a pretty safe change, and it just makes the debug-logged exception output be logged any time abort_on_exception is not true.
-
- We do not currently log it, but the patch to do so is trivial.
https://gist.github.com/6764310
I'm running tests now to confirm it doesn't break anything. -
- (2013/09/27 20:18), headius (Charles Nutter) wrote:
> So, can we do this for 2.1? I have heard from many other users that really would like exceptions bubbling out of threads to be reported in some way. We have had numerous bug report... -
- This would indeed eliminate a huge amount of confusion for people getting
started with threads. Or for people years of experience with threads, for
that matter...
--
Avdi Grimm
http://avdi.org
I only check email twice... -
- JRuby has implementation but no tests. The test should look pretty much like Thread#backtrace_locations tests, though.
I can work on some tests if you work on impl for MRI. -
- I'll try before preview-2.
JRuby already has a implementation and tests?
-
- Can I close it?
-
- http://blade.nagaokaut.ac.jp/cgi-bin/scat.rb/ruby/ruby-core/56421
any comments? -
-
- Ruby 2.0 already has
RUBY_VM_FIBER_VM_STACK_SIZE
RUBY_FIBER_MACHINE_STACK_SIZE
is it enough?
-
- Now, Queue is trap-safe.
-
- Introduced r42464 and there are no objection.
Close this ticket as accepted feature.
-
-
- It sometimes happens, that during packaging Ruby, it is necessary to patch configure.in (we are doing so in Fedora, there are patches in Debian, RVM does so occasionally as well). Unfortunately, since rev 42685, if the configure.in is pa...
-
05:25 PM Feature #8948: Frozen regex
- ko1 (Koichi Sasada) wrote:
> 2.2 matter?
2.1 would make sense to me, so it goes along with other frozen literals.
> ...
I highly doubt it. -
- I like to freeze normal regexp literal that Eregon said.
2.2 matter?
Anyone set instance variable for each regexp? :)
-
03:28 PM Revision 210efb5c (git): merge revision(s) 42459: [Backport #8963]
- * tool/make-snapshot: Fix order of priority for option parameter.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_0_0@43100 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
02:18 PM Feature #8967 (Open): add uninclude and unextend method
- Can be add uninclude and unextend method to ruby core ?
That enable Klass include or prepend different module,
make DECORATOR design pattern is easier.
-
- issues and several duplicate grammar bugs.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43099 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43098 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- small grammar typo
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43097 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- ObjectSpace::trace_object_allocations.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43096 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * ObjectSpace::trace_object_allocations_start
* ObjectSpace::trace_object_allocations_stop
* ObjectSpace::trace_object_allocations_clear
And some refactoring.
* test/objspace/test_objspace.rb: add a test for new methods.
* NEWS: add a ... -
- * gc.c (gc_before_sweep): use PRIuSIZE instead of "%zu" directly.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43094 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * configure.in, Makefile.in (RUNRUBY_COMMAND): separate from RUNRUBY,
to use options for runruby.rb.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43093 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- This fix may solve a failure of
TestTracepointObj#test_tracks_objspace_events
[test/-ext-/tracepoint/test_tracepoint.rb:43].
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43092 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43091 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
01:49 AM Revision 59f5fa10 (git): * vm_method.c (rb_undef): raise a NameError if the original method
- of a refined method is not defined.
* vm_insnhelper.c (rb_method_entry_eq): added NULL check to avoid SEGV.
* test/ruby/test_refinement.rb: related test.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43090 b2dd03c8-39d4-4d8f-98ff-...
09/29/2013
-
- I reported this issue to ruby-dev by accident, so refiled as #8966.
-
- The following code causes SEGV:
module Foo
refine Object do
def foo
puts "foo"
end
end
end
using Foo
class Object
undef foo
end
foo
I guess undef is not aware of re... -
08:04 PM Feature #6721: Object#yield_self
May I give a name suggestion?
Does "tap!" make sense in english?
~~~Ruby
2.tap {|x| x*2 } # => 2
2.tap! {|x| x*2 } # => 4
~~~
The exclamation mark alerts that the return value is being changed.
-
06:52 PM Bug #8964: [BUG](%p is T_NONE) occurs while marking VM stack
- =begin
レビューありがとうございます。
とりあえず[ruby-dev:47730]のパッチでコミットしておきました。
=end
-
- This issue was solved with changeset r43081.
Kazuki, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.
----------
* vm_insnhelper.c (vm_callee_setup_arg_complex, vm_yield_setup_... -
- (2013/09/29 9:08), nobu (Nobuyoshi Nakada) wrote:
> これでいいんじゃないでしょうか。
と思います。
> vm_callee_setup_arg_complex()とvm_yield_setup_block_args()は共通化できるところも多そうですが。
共通箇所の括りだしはいるかもしれないですね。
--
// SASADA Koichi at atdot dot net -
- これでいいんじゃないでしょうか。
vm_callee_setup_arg_complex()とvm_yield_setup_block_args()は共通化できるところも多そうですが。 -
- =begin
不要な分岐を避けるために初期化処理はsetup_argでやったほうがよいのでないかと思い直したので、パッチを修正しました。
=end
-
- jwille,
My understanding with the case of string in your example is that the two strings would count as different strings, but for respective method calls would not create new strings. It would mean one of the string can be `"ab"` and... -
03:58 PM Revision 7eca2a43 (git): fix a typo
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43089 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 03:56 PM Revision 98729749 (git): * 2013-09-30
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43088 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43087 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * array.c (sort_2): minor performance improvement by replacing
rb_funcall() with rb_funcallv.
* array.c (rb_ary_bsearch, recursive_cmp, rb_ary_cycle_size): ditto.
* array.c (descending_factorial, binomial_coefficient): ditto.
* arra... -
- * parse.y (rb_id_attrset, intern_str): allow junk attrset ID for
Struct.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43085 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43084 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * parse.y (rb_id_attrset): fix inconsistency with literals, allow
ID_ATTRSET and return it itself, but ID_JUNK cannot make ID_ATTRSET.
and raise a NameError instead of rb_bug() for invalid argument.
git-svn-id: svn+ssh://ci.ruby-lan... - 09:50 AM Revision 3dab183c (git): * 2013-09-29
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43082 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- clear keyword arguments to prevent GC bug which occurs
while marking VM stack.
[ruby-dev:47729] [Bug #8964]
* test/ruby/test_keyword.rb: tests for the above.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43081 b2dd03c8-39d4-4d8...
09/28/2013
-
- =begin
以下のコードで (({rb_gc_mark(): 0x00555555a1ff68 is T_NONE})) のような[BUG]となります。
def m(a: [])
end
GC.stress=true
tap { m }
GC.start
tap { m }
フレームを積む際にキーワード引数用のVMスタック領域をCレベルで初期化していないため、
積んだ直後には死んだオブジェクトへの参照がスタックに残ってしまっ... -
05:06 PM Misc #8962 (Closed): [DOC] add step to enable Generational GC merits in README.EXT*
- =begin
Is there any chance to reap the benefit of new Generational GC merits for
C-extension library authors?
== Background
First of all: RGenGC is great. Ko1 showed that it could make significant
performance improvement at R... -
- I did a quick hack to try this proposal and found that some test failed with it:
https://gist.github.com/shugo/6739085
For example, bootstraptest/test_block.rb uses the last value of a class definition as follows:
~~~ruby
ass... -
- headius (Charles Nutter) wrote:
> mame (Yusuke Endoh) wrote:
> ...
Use:
~~~ruby
meta = self.singleton_class
~~~
> > It is very arguable if the new idiom should be encouraged.
> ...
Your way is too easy to overlook "`.init`" be... -
04:20 AM Feature #8839: Class and module should return the class or module that was opened
- I agree that returning the class or module makes sense (to me).
I'd also like to see "`def foo`" return a (`Unbound`)`Method` instead of a `Symbol`.
it seems like that'd also make more sense (not to derail this conversation). A (`Unbou... -
- mame (Yusuke Endoh) wrote:
> headius (Charles Nutter) wrote:
> ...
How about this:
~~~ruby
meta = class << self; end
~~~
> It is very arguable if the new idiom should be encouraged.
> ...
I respect your opinion, but I fail to ... -
- * math.c (math_log, math_log2, math_log10): fix for Bignum argument.
numbits should be add only when right shifted.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43080 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * random.c (rb_random_ulong_limited): coerce before check negative.
[Fixes GH-379]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_0_0@43079 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- slide updated
-
- slide added
-
- headius (Charles Nutter) wrote:
> Maybe. I don't like the idea of exposing this mutex/monitor, since it could be modified or locked and never released. I would be more in favor of a "tap" form that synchronizes against the same internal... -
- tobiassvn (Tobias Svensson) wrote:
> Having this as a method on Module directly would of course be ideal. However, I believe the mutex/monitor used should still be exposed as a private method so it can be used without the 'synchronized'... -
07:30 AM Bug #8797: Intermittent Segfault on 2.0.0-p247 when running 'bundle install'
- Confirming I have the same error. Running `bundle install` a few times eventually succeeds. Can I provide anything to help debug?
-
05:47 AM Revision f450dede (git): Added ticket number
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43078 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- correctly. Patch by Gabriele Giacone (1o5g4r8o@gmail.com).
* test/fiddle/helper.rb: ditto.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43077 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Formatting issue... the "synchronized" proposal is in https://bugs.ruby-lang.org/issues/8961
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43076 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- This issue was solved with changeset r43074.
Alex, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.
----------
* ext/curses/extconf.rb: check the size of chtype.
* ext/curses/... -
- Thanks for the patch, nobu. That was easier than I thought it would be; I was looking in the wrong place entirely.
sawa (Tsuyoshi Sawada) wrote:
> [...] I think it should not be just for hashes, but also for arrays, and for arguments...
09/27/2013
-
- headius (Charles Nutter) wrote:
> One use:
> ...
I fail to see why it needs to be a local variable.
Why don't you use `Foo` instead of `my_class`?
> Another:
> ...
It is very arguable if the new idiom should be encouraged.
Pers... -
09:11 PM Feature #8839: Class and module should return the class or module that was opened
- I see now. I really tried a few times to get something like your second example to work:
~~~ruby
class MyProcessor
...
end.new(params).process
~~~
I'd usually use such pattern in small scripts since methods are not hoisting li... -
- mame (Yusuke Endoh) wrote:
> How useful is this proposal?
> ...
One use:
~~~ruby
my_class = class Foo
...
end
~~~
We can get the reference to a class being created immediately without adding "`self`" at the end. It also bri... -
- Actually, I don't understand even why returning a symbol from method definition is useful...
-
- I've been wondering the same thing since I saw this ticket being created...
-
10:50 PM Feature #8931: Update URL in REPORTBUG_MSG
- I agree with zzak.
Linking to www.ruby-lang.org/whatever which redirects to bugs.ruby-lang.org/something_else sounds so wrong and will easily break (it **had** been broken for months). Links might change.
But information on bug rep... -
- I don't think redirect is acceptable, we should correct the problem at the source. Please reconsider..
> On Sep 26, 2013, at 7:35 PM, "naruse (Yui NARUSE)" <naruse@airemix.jp> wrote:
>
>
> Issue #8931 has been updated by naruse ... -
- If it is http://www.ruby-lang.org/bugreport.html, we can change redirect target if we want to change the target.
If it is http://bugs.ruby-lang.org/, we can't changet the target for example to http://bugs.ruby-lang.org/projects/ruby/wik... -
- Having this as a method on Module directly would of course be ideal. However, I believe the mutex/monitor used should still be exposed as a private method so it can be used without the 'synchronized' method.
-
- I would like to see this in 2.1, as a standard Module method. The fact that "def" returns the method name now makes this really easy.
I think this would need to be implemented natively to work, however. The prototype above has a key f... -
- =begin
I propose a Synchronizable mixin to easily wrap methods in a mutex which works together with Ruby 2.1's method name symbols returned from '(({def}))'.
The Mixin adds a new '(({synchronized}))' class method which would alias th... -
- Similar in nature to the "synchronized" module method proposed in https://bugs.ruby-lang.org/issues/8961. I like that proposal as well, but it does not help the case where you have a concurrency-unsafe object in hand that you would like ...
-
08:13 PM Feature #8556: MutexedDelegator as a trivial way to make an object thread-safe
- That would be a useful feature.
+1 -
- Any comments here? This would be pretty easy to add to delegate.rb for 2.1.
-
- I again request approval from matz to add this feature :-) Can we do it for 2.1, please?
-
- So, can we do this for 2.1? I have heard from many other users that really would like exceptions bubbling out of threads to be reported in some way. We have had numerous bug reports relating to code where threads disappear without a trace.
-
- I believe this is just waiting on approval by matz. Can we make this change in 2.1, please?
-
- https://bugs.ruby-lang.org/issues/5138 has been accepted in a slightly altered form, so I think perhaps this can be rejected. Since it is now possible to use read_nonblock with no exception raise, my proposal is unnecessary.
-
08:15 PM Feature #8948: Frozen regex
- > but it would be difficult to tell which regexes are intended to be the same
i'm not sure i understand. how is
~~~ruby
def r1; /ab/f; end
def r2; /ab/f; end
~~~
different from
~~~ruby
def s1; 'ab'f; end
def s2; 'ab'f; e... -
- Hah... I was just stopping by to suggest the keyword argument as a compromise form...and it turns out that's exactly what we went with. Excellent!
-
- I have filed https://bugs.ruby-lang.org/issues/8960 to get this feature added to MRI. It is already available in JRuby.
-
- All parties agreed this would be useful to add in https://bugs.ruby-lang.org/issues/7895 and ko1 suggested I file a feature against ruby-trunk. So here it is.
I might be able to come up with a patch, but I'm not sure when. Help wanted... -
- Any further comments here? I might be able to do part of the implementation, but I don't know how to automatically stick $! into cause. I'd like to see this in 2.1.
-
- RubyGems 2.1 incorporated my new logic for default gems while still supporting the MRI 2.0 layout for default specs.
Given that I have not maintained my cleaned-up rbinstall and no longer need the logic, I'm rejecting this. I hope at ... -
- normalperson (Eric Wong) wrote:
> So the insertion of a new class will need a namespace lock (just like
> ...
The sequence of events here sounds sorta like how autoload was made "thread safe".
Possible states for a class/module in ... -
- In for 2.1?
-
- Any possibility of getting this in for 2.1?
-
- akr (Akira Tanaka) wrote:
> 2013/9/8 headius (Charles Nutter) <headius@headius.com>:
> ...
Doing a select followed by a blocking read of more data than is actually available would block on any socket. The amount of data available in th... - 03:26 PM Revision c77d56ff (git): * 2013-09-28
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43075 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * ext/curses/curses.c (NUM2CH, CH2NUM): use proper macros for
the size of chtype.
[ruby-core:56090] [Bug #8659]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43074 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- If this proposal is going to be considered, then I think it should not be just for hashes, but also for arrays, and for arguments passed to a method.
~~~ruby
[
:foo
:bar
]
foo(
"arg1"
"arg2"
)
~~~
Also note that,... -
01:41 PM Feature #8956: Allow hash members delimited by \n inside of {}
- Same about arrays, i guess? :)
-
- Additional patch for labeled `assocs`.
~~~diff
diff --git a/parse.y b/parse.y
index b0a7cc4..63b4334 100644
--- a/parse.y
+++ b/parse.y
@@ -5013,4 +5013,7 @@ trailer : /* none */
assoc_seperator : '\n'
+ {
+ comman... -
- I feel the need to mention that at this time, my changes do not include Ruby 1.9 style symbol hashes. These still require commas, e.g.,
~~~ruby
some_hash = {
foo: 'bar',
bar: 'foo',
baz: {
qux: 'quux',
corge: 'grau... -
03:06 PM Bug #8957 (Rejected): Ruby tk control variables for radiobutton menu radiobutton and menu checkbutton not working correctly.
- It depends on bugs on the reporter's code.
--- test_control_variables.rb 2013-09-27 14:48:40.000000000 +0900
+++ test_control_variables_mod.rb 2013-09-27 14:51:26.000000000 +0900
@@ -49,12 +49,12 @@
def b_button
puts("set... -
-
03:50 AM Bug #8957 (Rejected): Ruby tk control variables for radiobutton menu radiobutton and menu checkbutton not working correctly.
- The control variables for radiobutton menu radiobutton and menu checkbutton are not working correctly. In a starter project I am coding, they do not set the variable at all, and if set, it does not affect the button that is checked. I've...
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43073 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- RUBY_GC_MALLOC_LIMIT_MAX and RUBY_GC_MALLOC_LIMIT_GROWTH_FACTOR.
See r43067 for details.
* gc.c (rb_gc_set_params): refactoring. And change verbose notation.
Mostly duplicated functions get_envparam_int/double is not cool.
Please r... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43071 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43070 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43069 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- If you enable RGENGC_PRINT_TICK to 1, then profiling results by RDTSC
(on x86/amd64 environment) are printed at last.
Thanks Yoshii-san.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43068 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Now, malloc_limit is increased/decreased by mysterious logic.
This fix simplify malloc_limit increase/decrease logic such as:
if (malloc_increase > malloc_limit) /* so many malloc */
malloc_limit += malloc_limit * (GC_MALLOC_LIMIT_... -
06:24 AM Feature #8959 (Assigned): Allow top level prepend
- Since `include` works on top level, it's reasonable to enable top level
`prepend` as well.
I've already added a patch (it was partially merged by nobu): https://github.com/ruby/ruby/pull/395 -
- * .gdbinit (rp): insert a colon between type "SYMBOL" and ID value.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43066 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- 2013/9/27 ko1 (Koichi Sasada) <redmine@ruby-lang.org>:
> Issue #8953 has been updated by ko1 (Koichi Sasada).
> And all of versions ignore the redefinition.
> I implemented 1.9 VM as this behaviour because I think it is spec.
... -
- (2013/09/27 1:13), ko1 (Koichi Sasada) wrote:
> And all of versions ignore the redefinition.
> I implemented 1.9 VM as this behaviour because I think it is spec.
>
> Could you ask matz?
I have no objection about that.
Ho... -
- I checked previous behavior.
versions/install-tags_v1_6_5_/bin/ruby
versions/install-tags_v1_6_6_/bin/ruby
versions/install-tags_v1_6_7_/bin/ruby
versions/install-tags_v1_6_8_/bin/ruby
versions/install-tags_v1_8_5_/bin/ruby
versi... -
-
- This issue was solved with changeset r43061.
Alexander, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.
----------
* re.c: [DOC] arguments of Regexp::union receive #to_regexp ... -
01:02 AM Feature #7429: Provide options for core collections to customize behavior
- Maybe combine it with https://bugs.ruby-lang.org/issues/8909
options = {klass:Hamster}
{ bug_number: 7429, status: maybe}.f(options)
node_option = {f:deep , size: 2}
[:add, [:left, :right]].f( f:node_option) -
- r42994 is backported to ruby_2_0_0 at r43060.
-
- Sutou-san has began implementation for this on rdoc tracker: https://github.com/rdoc/rdoc/pull/254
-
- This issue was solved with changeset r43058.
Prathamesh, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.
----------
* struct.c: [DOC] grammar of ArgumentError in Struct.new [B... -
- It's defined as left-to-right order, always.
-
- @nobu did you see #8905?
-
- I like RSS, I think we should provide api-level documentation for things like Feed and Channel and Entry. The entity types might not be as important though.
Would you agree? With no objection, I would like to reject this ticket and as... -
- This patch is good, thank you!
-
- I would just say "this method", instead of "the <name> method".
Otherwise, its good. Thank you!
09/26/2013
-
- Currently, hashes require members to be delimited by commas (`,`), even inside curly braces. E.g.,
~~~ruby
some_hash = {
:foo => 'bar',
:bar => 'foo',
:baz => {
:qux => 'quux',
:corge => 'grault'
}
}
~~~
In... -
- ruby_debug.gem issue.
-
09:02 PM Bug #8954 (Third Party's Issue): Execution crashed when querying twitter using the Twitter Gem
- Ruby 2.0 crashed when I was executing a script which hits the twitter search api for tweets containing certain keywords. I am on Mac OS X 10.8.5
Attaching the crash report and source code.
Just run the tweet_parser.rb file and you ... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43065 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
09:33 PM Bug #8955 (Closed): LocalJumpError - no block given (yield) after implementation of class hierarchy method cache invalidation
- Hi.
I use Ruby 2.1 on a Texas instruments C6678 DSP in a Linux environment based on uclinux and uClibc with NPTL/Pthread support. The DSP does not have an MMU.
After commit r42822/git commit 2f522b9cc6f3e184404040b12af4486520a73b26 the... -
- How useful is this proposal?
I think we should not change anything without consideration of use case.
--
Yusuke Endoh <mame@tsg.ne.jp> - 12:03 PM Feature #8839: Class and module should return the class or module that was opened
- nobu: I don't understand what you mean by "evaluated in different timings". Could you please explain?
I think this proposal is a good idea. For example, this makes no sense:
~~~ruby
class A
def foo
end
end # => :foo
~~~
... -
- No, class and def are evaluated in different timings.
This proposal makes no sense. -
- +1
-
- So...if there's no objections, can we get this into 2.1? I think with the new def return value change it really needs to happen.
-
- Please backport r43050, 43052
-
- This issue was solved with changeset r43052.
Goro, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.
----------
* insns.def (opt_regexpmatch2): Check String#=~ hasn't overridden... -
- Testing my patch on my machine for regexpmatch2
- 04:48 PM Feature #8953: `str =~ /pattern/` does not call =~ method if (1) str is a String, (2) /pattern/ is a Regexp literal
- Ah you are right. Thanks for pointing that out sorah.
-
- >The problem still exists for opt_regexpmatch1, right?
s/opt_regexpmatch1/opt_regexpmatch2/ -
- The problem still exists for opt_regexpmatch1, right?
- 04:39 PM Feature #8953 (Closed): `str =~ /pattern/` does not call =~ method if (1) str is a String, (2) /pattern/ is a Regexp literal
- This issue was solved with changeset r43050.
Goro, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.
----------
* insns.def (opt_regexpmatch1): check Regexp#=~ is not defined be... -
- hm...
ruby -e'class Regexp; def =~(o); true; end; end; p /a/ =~ "b"' #=> nil -
04:05 PM Feature #8953 (Closed): `str =~ /pattern/` does not call =~ method if (1) str is a String, (2) /pattern/ is a Regexp literal
- The expression `a =~ b` does not call the =~ method in some cases.
I think it is a bug that results from optimizations.
See the following code for details:
Code that does not work as expected (shows nothing):
$ ruby -e 's = "fo... -
- [Backport #8950]
the patch is provided by drbrain (Eric Hodel).
this update contains a security fix for CVE-2013-4363.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_0_0@43064 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * parse.y (lambda): adjust position to the beginning of the block.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_0_0@43063 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * lib/uri/generic.rb (URI::Generic.find_proxy): return nil if
http_proxy environment variable is empty string.
[ruby-core:57140] [Bug #8898]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_0_0@43062 b2dd... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43061 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * lib/gserver.rb: [DOC] correct gserver.rb license [Bug #8913]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_0_0@43060 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 03:41 PM Revision b96a432e (git): * 2013-09-27
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43059 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Patch by Prathamesh Sonpatki
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43058 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- jwille, I agree with the use case, but it would be difficult to tell which regexes are intended to be the same, so I would not request that feature.
Probably, it makes sense to have all static regexes frozen, and have the `f` flag fre... -
- This issue was solved with changeset r43047.
Ruby, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.
----------
gc.c: disable AddressSanitizer
* gc.c (mark_locations_array): di... -
02:12 PM Feature #8909: Expand "f" frozen suffix to literal arrays and hashes
- I think there's a big opportunity here for immutable collection types... at least the sort that you know at the time you declared it is immutable.
I would hate to see a syntax like this that doesn't guarantee a deeply frozen data struct... -
- Any other thoughts on this? Any other reasons why it shouldn't be done?
There are other advantages to having literal frozen array and hash:
* Alternative representation of small hashes knowing they won't need to change. Good for sm... -
- This includes fixing the capitalization of Infinity, return value of
example "BigDecimal.new('NaN') == 0.0", and code style in example.
[Fixes GH-398] https://github.com/ruby/ruby/pull/398
git-svn-id: svn+ssh://ci.ruby-lang.org/rub... -
- [Fixes GH-400] https://github.com/ruby/ruby/pull/400
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43056 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- [Fixes GH-399] https://github.com/ruby/ruby/pull/399
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43055 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- [Fixes GH-401] https://github.com/ruby/ruby/pull/401
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43054 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 12:16 PM Revision e59f453e (git): * misc/ruby-electric.el (ruby-electric-delete-backward-char): Add
- support for smartparen-mode.
* misc/ruby-electric.el (ruby-electric-cua-replace-region-maybe)
(ruby-electric-cua-delete-region-maybe): New functions that
combine `ruby-electric-cua-*-region` with
`ruby-electric-cua-*-region-p`, us... -
- Shouldn't "required keyword arguments" be described in the doc, probably in syntax/methods.rdoc?
There is only "optional keyword arguments" now.
-
- Introduced on r42743.
- 09:07 AM Feature #8951: Please add a hash-to-hash alternative of the map method to Hash
- In my private library, I have 3 map-like methods defined on hash:
Hash#with_keys
Hash#with_values
Hash#modify
They work like this:
h = { a: 1, b: 2 }
h.with_keys do |k| k.to_s end #=> { "a"=>1, "b"=>2 }
h.with_values do |v| v.to_s end... -
- before calling rb_reg_match().
* test/ruby/test_string.rb: Test for above.
* vm.c (vm_init_redefined_flag): Add BOP flag for String#=~
[ruby-core:57385] [Bug #8953]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43052 b2dd03c8-39d... - 07:50 AM Revision 26f7f7da (git): * misc/ruby-electric.el: Avoid use of the interactive function
- `self-insert-command` which fires `post-self-insert-hook` and
`post-command-hook`, to make the ruby-electric commands work
nicely with those minor modes that make use of them to do
similar input assistance, such as electric-pair-mo... - 07:39 AM Revision b18151cf (git): * insns.def (opt_regexpmatch1): check Regexp#=~ is not defined before
- calling rb_reg_match()
* test/ruby/test_regexp.rb: add test
* vm.c (ruby_vm_redefined_flag): change type to short[]
* vm.c (vm_redefinition_check_flag): return REGEXP_REDEFINED_OP_FLAG if
klass == rb_cRegexp
* vm.c (vm_init_redefin... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43049 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- if __has_feature is not defined, it can't compile
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43048 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * gc.c (mark_locations_array): disable AddressSanitizer. based on a
patch by halfie (Ruby Guy) at [ruby-core:57372].
[ruby-core:56155] [Bug #8680]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43047 b2dd03c8-39d4-4d8f-98ff-823f... - 02:31 AM Revision f1e99541 (git): * 2013-09-26
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43046 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * gc.c (gc_before_sweep, gc_after_sweep): add to increase2 atomically.
* gc.c (gc_marks): adjust indent.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43045 b2dd03c8-39d4-4d8f-98ff-823fe69b080e