Activity
From 01/31/2013 to 02/06/2013
02/06/2013
-
11:58 PM Feature #7792: Make symbols and strings the same thing
- I'd just like to highlight what performance impact we may be referring to:
https://gist.github.com/rosenfeld/4723061
I'll copy it here:
require 'benchmark'
hashes = []
1_000_000.times { hashes << { some_key_name: 1, 'some_k... -
- Em 06-02-2013 12:36, Yorick Peterse escreveu:
> You don't need to hijack any code for it, you'd just use it as
> following:
>
> require 'hashie'
>
> parsed = JSON.parse('{"name": "Ruby"}')
> hash = Hashie::Ma... -
11:53 PM Feature #7792: Make symbols and strings the same thing
- You don't need to hijack any code for it, you'd just use it as
following:
require 'hashie'
parsed = JSON.parse('{"name": "Ruby"}')
hash = Hashie::Mash.new(parsed)
hash.name # => "Ruby"
... -
- @yorickpeterse, your suggestion wouldn't work for my case. The hash is created by JSON.parse where I don't control the hash creation. And I don't like the idea of monkey patching core classes either. Specially in fundamental classes like...
-
- Although I'd really prefer that symbols and strings were the same there is an alternative that would satisfy me as well:
Make Hash behave as HashWithIndifferentAccess and create a new class StrictHash to keep the behavior of the existen... -
- Symbols and Strings both have different use cases and that's actually a
good thing. If you want to be able to use both Strings and Symbols as
your Hash keys you can use something like Hashie:
https://github.com/intridea/hashie
... -
11:22 PM Feature #7792: Make symbols and strings the same thing
- Mmm, it sounds too big to me.
@rosenfeld I know your situation. But is it really a right solution for you? How about a hash with indifferent access? Or how about changing {foo:1} to be { 'foo' => 1 }, not { :foo => 1 } ? It seems ... -
11:20 PM Feature #7792: Make symbols and strings the same thing
- rosenfeld: see #5964 for similar discussion.
-
11:13 PM Feature #7792: Make symbols and strings the same thing
- I'm not sure that's even possible. If String#hash produced the same number as Symbol#hash, then that would do the trick, but that probably lead to some unforeseen breakages.
I do know one related thing, though. I don't like having to ... -
- Recently I had to replace several of my symbols to plain strings in my project. Here is what happened:
I generated some results with some class that would add items to an array like this:
results << {id: 1, name: 'abc'}
Then I w... -
- I'd don't think the problem is an error being raised. Just handle the exception. The issue is having a process eat up all the systems memory. Isn't it?
-
- Em 06-02-2013 12:35, SASADA Koichi escreveu:
> (2013/02/06 23:21), SASADA Koichi wrote:
>> One rough idea (but not verified) is:
>>
>> Separated Symbols into two sets:
>> (a) Symbols created by rb_intern()
>> (b) Symbo... -
- Em 06-02-2013 12:21, SASADA Koichi escreveu:
> (2013/02/06 22:50), shyouhei (Shyouhei Urabe) wrote:
>> @rosenfeld do you have any conceptual patch to implement it? The reason Symbols aren't GCed is simply because the committers (in... -
11:53 PM Feature #7791: Let symbols be garbage collected
- (2013/02/06 23:21), SASADA Koichi wrote:
> One rough idea (but not verified) is:
>
> Separated Symbols into two sets:
> (a) Symbols created by rb_intern()
> (b) Symbols created from String object (String#to_sym)
Addi... -
- trans (Thomas Sawyer) wrote:
> An error would be raised.
So you would have a successful DoS attack, right? Because the attacker would cause an exception after the symbols limit has been reached. After that, any request relying on #to... -
- rosenfeld (Rodrigo Rosenfeld Rosas) wrote:
> At least now I know that you're willing to accept any patch to make them GCed. :)
Yes. I promise I vote a big +1 for such thing. It cannot be a boring patch. -
- Garbage collecting Symbols would most likely do more harm than good.
Sure, a ddos based on Symbols may no longer be possible but there's a
big chance it will introduce a significant performance penalty as a
result of having to cre... -
- (2013/02/06 22:50), shyouhei (Shyouhei Urabe) wrote:
> @rosenfeld do you have any conceptual patch to implement it? The reason Symbols aren't GCed is simply because the committers (including matz) don't have any idea how.
One ro... -
- An error would be raised.
-
- There is already a limit (memory bounded) and the problems begin after the limit is reached. If you just limit the amount of symbols using another kind of limit you won't prevent DoS attacks. What would happen once the limit is reached i...
-
- Is it possible to set a maximum size to the number of symbols allowed? An error would be raised if the limit was hit. Would that at least suffice to stop DoS attacks?
-
- Sorry @shyouhei, but I don't know Ruby's code base. But I believe I won't be able to understand how this could work if any of the core committers could get it to work :P
I didn't know this was the reason why they weren't collected by ... -
10:57 PM Feature #7791: Let symbols be garbage collected - Adding to shyouhei's comment, Symbols are actually used for quite a specific purpose inside MRI. Because they are essentially integers with names, they are used as keys in method tables/ivar tables/etc. as they speed up lookup quite a lo...
-
- @rosenfeld do you have any conceptual patch to implement it? The reason Symbols aren't GCed is simply because the committers (including matz) don't have any idea how.
-
- Lots of Denial-of-Service security vulnerabilities exploited in Ruby programs rely on symbols not being collected by garbage collector.
Ideally I'd prefer symbols and strings to behave exactly the same being just alternate ways of wri... -
- Em 05-02-2013 23:57, Aaron Patterson escreveu:
>> I really don't see this as a problem.
>>
>> What I see as a problem is having sites compromised.
> Who would argue with this? The security patches release do not allow
> YAML ... - 10:59 AM Bug #7780: Marshal & YAML should deserialize only basic types by default.
- On Wed, Feb 06, 2013 at 06:05:24AM +0900, marcandre (Marc-Andre Lafortune) wrote:
> I'll repeat that the proposal is for a migration path, giving Rails or any library using YAML at least a year of transition where they can call `load!... -
06:05 AM Bug #7780: Marshal & YAML should deserialize only basic types by default.
- > serialized objects in the database. I am very against changing this
> ...
I'll repeat that the proposal is for a migration path, giving Rails or any library using YAML at least a year of transition where they can call `load!` if YAML... -
- Em 05-02-2013 16:20, Aaron Patterson escreveu:
> On Mon, Feb 04, 2013 at 12:54:50PM +0900, marcandre (Marc-Andre Lafortune) wrote:
>> Issue #7780 has been updated by marcandre (Marc-Andre Lafortune).
>>
>>
>> mame (Yusuke Endo... - 03:23 AM Bug #7780: Marshal & YAML should deserialize only basic types by default.
- On Mon, Feb 04, 2013 at 12:54:50PM +0900, marcandre (Marc-Andre Lafortune) wrote:
>
> Issue #7780 has been updated by marcandre (Marc-Andre Lafortune).
>
>
> mame (Yusuke Endoh) wrote:
> > I think that this issue is not a... -
- After refactoring Psych to handle Tag Schema, I have to concur with @marcandre. I don't think people realize the extent to which Psych is mapping tags to classes. It's no where near YAML spec (albeit the spec is nice enough to allow you ...
-
10:29 PM Bug #5278: REXML -- Malformed comment
- 須藤です。
In <20130206132214.95E816EA62@zanzibar.garbagecollect.jp>
"[ruby-dev:46931] Re: [ruby-changes:27041] usa:r39093 (ruby_1_9_3): merge revision(s) 33210,33212: [Backport #5278]" on Wed, 6 Feb 2013 22:22:14 +0900,
"U.Naka... -
09:53 PM Bug #5278: REXML -- Malformed comment
- こんにちは、なかむら(う)です。
In message "[ruby-dev:46929] Re: [ruby-changes:27041] usa:r39093 (ruby_1_9_3): merge revision(s) 33210,33212: [Backport #5278]"
on Feb.06,2013 20:46:00, <kou@cozmixng.org> wrote:
> 須藤です。
>
> 私がお願いしていたこ... -
- 須藤です。
私がお願いしていたこのバックポートなんですが、
https://bugs.ruby-lang.org/issues/7764
ChangeLogの変更だけがバックポートされていて、実際の変更
https://bugs.ruby-lang.org/projects/ruby-trunk/repository/revisions/33210
はバックポートされていないようにみえます。
（lib/rexml/parse... -
09:59 PM Bug #7773 (Feedback): Calling send("attribute=", value) returns nil instead of value
- Why do you consider it a bug?
-
08:51 PM Revision 90eb265f (git): * doc/pty/README: Remove static documentation file
- * ext/pty/pty.c: Add License to PTY module overview
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@39122 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- This issue was solved with changeset r39109.
Hans, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.
----------
configure.in: multiarch option
* configure.in (multiarch): add o... - 05:31 PM Revision 6851ad47 (git): * vm_insnhelper.c: attr_writer should return its argument [Bug #7773]
- * test/ruby/test_basicinstructions.rb: Test for above
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@39121 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@39120 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 04:35 PM Revision efcc536b (git): * 2013-02-07
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@39119 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- nagachika
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@39118 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
03:53 PM Bug #7625: Arrayを継承したオブジェクトのcompactがArrayを返す
- > Enumerableで定義されていないArray独自のメソッドはサブクラスを返したほうが良いと思います。
> 直すタイミングはいつがいいのかな。
いまから2.0にspecレベルの変更が入るのは反対します。念のため。 -
03:38 PM Bug #7625: Arrayを継承したオブジェクトのcompactがArrayを返す
- Enumerableで定義されていないArray独自のメソッドはサブクラスを返したほうが良いと思います。
直すタイミングはいつがいいのかな。
Matz.
-
03:51 PM Bug #7787 (Feedback): ruby 1.9 regexp quantifiers behave unpredictably when stacked
- It is not considered as a bug, but if there is a reasonable patch I'll merge it.
-
04:29 AM Bug #7787 (Rejected): ruby 1.9 regexp quantifiers behave unpredictably when stacked
- Ruby (1.8 and 1.9) allows for stacked quantifiers such as /x{2}{5}/ and appears to treat them more or less as expected, i.e., modulo capturing, /x{2}{5}/ is equivalent to /(x{2}){5}/ is equivalent to /x{10}/.
However, in Ruby 1.9, suc... -
- This issue was solved with changeset r39097.
George, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.
----------
* test/ruby/test_process.rb (test_setsid): skip when platform i... -
- > The only fix is to skip the Process::getsid(pid) in the test. I wrote a patch for this.
OK. I agree with skipping test. But I would like to just skip instead of your approach.
> ...
Yeah! You are right. I'll fix this. -
-
08:31 AM Bug #7789 (Closed): test_setsid fails for OpenBSD
- =begin
TestProcess#test_setsid always fails because OpenBSD doesn't allow Process::getsid(pid) when the pid is in a different session. Quoting man getsid, "[EPERM] The current process and the process pid are not in the same session."
... -
- * ext/pty/lib/expect.rb: Documentation for IO#expect
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@39117 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
02:11 PM Bug #7790: documentation about exception in Comparable#==
- 英語をなんとかしました
-
- [ruby-dev:46910] に書いた Comparable#== の、例外に関する仕様の文書化です。
- 01:46 PM Revision e45e0641 (git): * hash.c (env_reject_bang): hide keys array from ObjectSpace
- * hash.c (env_select_bang): ditto
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@39116 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 01:03 PM Revision e52527a4 (git): merge miss of r39093.
- I don't understand why svn merge didn't merge any files and reported no errors.
terrible...
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_1_9_3@39113 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 08:40 AM Revision e5938a11 (git): * ChangeLog: forgotten to commit.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_1_9_3@39110 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * configure.in (multiarch): add option to move architecture dependent
directories. [Feature #6111]
* template/ruby.pc.in: add arch dependent paths.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@39109 b2dd03c8-39d4-4d8f-98ff-823f... -
- * configure.in (rubyarchhdrdir, sitearchhdrdir, vendorarchhdrdir): add
options to customize architecture dependent header directories.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@39108 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * configure.in (rubyarchprefix, sitearchdir, vendorarchdir): add
options to customize architecture dependent library directories.
* template/ruby.pc.in, tool/mkconfig.rb, tool/rbinstall.rb: use
configured values.
* tool/mkconfig.rb: ... -
- * configure.in (RUBY_VERSION_NAME), template/ruby.pc.in: add
substitution and define.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@39106 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * configure.in, version.c: parametric architecture name for paths.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@39105 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * configure.in (shvar_to_cpp): convert sh variable references
by replacing with string literal forms in cpp.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@39104 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
08:05 AM Revision 6d0647c3 (git): * lib/rdoc: Import RDoc 4.0.0.rc.2
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@39102 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 08:00 AM Revision fd061353 (git): * lib/rdoc: Import RDoc 3.9.5.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_1_9_3@39101 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * tool/mkconfig.rb: should match whole word.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@39100 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 06:49 AM Revision b7d6d06a (git): fixed commit miss of previous commit.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_1_9_3@39099 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Process.wait(). Reported by George Koehler. Thanks.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@39098 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- OpenBSD. Contributed from George Koehler.
[Bug #7789] [ruby-core:51889]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@39097 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Ok. One last comment on this:
> I am not positive about adding exception classes. So far, TypeError only caused by inexistence of allocator.
Assessments like "So far", are what make's a coder worry. In future that could change, the... -
- =begin
Ah, `else`. I've never used that, and forgotten about it.
So I should be able to write instead:
begin
object = type.allocate
rescue TypeError
...
else
...
end
Reads kind of funny. But okay. I w... -
- Sounds like you are reinventing begin; rescue; else; end: https://github.com/ruby/ruby/blob/trunk/doc/syntax/exceptions.rdoc
-
- =begin
But is not so nice to have to write code like this:
success = begin
object = type.allocate
true
rescue TypeError
false
end
if success
...
else
...
end
Instead of like:
... - 05:30 AM Revision ee6e1db1 (git): merge revision(s) 35474,35479,38939,38943,38963,38991,38994: [Backport #7786]
- * ext/socket/raddrinfo.c (init_unix_addrinfo): support the longest
path in sockaddr_un.
(inspect_sockaddr): ditto.
(addrinfo_mdump): ditto.
(addrinfo_mload): ditto.
(rsock_unixpath_str): ... - 05:25 AM Revision 42b13375 (git): * README: Fix typo, patch by zzak
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@39095 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 05:21 AM Revision 2618ffc5 (git): merge revision(s) 38993: [Backport #7775]
- * ext/socket/basicsocket.c (bsock_getsockname): ignore truncated
part of socket address.
(bsock_getpeername): ditto.
(bsock_local_address): ditto.
(bsock_remote_address): ditto.
* ext/sock... - 05:19 AM Revision 0297247f (git): merge revision(s) 33210,33212: [Backport #5278]
- * lib/rexml/parsers/baseparser.rb, test/rexml/test_comment.rb:
allow a single hyphen in comment. [Bug 5278]
Reported by Thomas Fritzsche. Thanks!!!
allow a single hyphen in comment. [Bug #5278] [ruby-core:39... - 05:14 AM Revision 326ce405 (git): merge revision(s) 37174: [Backport #7754]
- * file.c (realpath_rec): prevent link from GC while link_names refers
the content.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_1_9_3@39092 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 05:13 AM Revision 4be94836 (git): merge revision(s) 36151: [Backport #7746]
- * missing/setproctitle.c (environ): use (*_NSGetEnviron()) instead of
environ on Darwin for namespace cleanness, same as [ruby-core:00537].
[ruby-core:45615] [Bug #6576]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/b... - 05:06 AM Revision 10d2b5ec (git): merge revision(s) 36905: [Backport #6977]
- * dir.c (glob_make_pattern): names under recursive need to be single
basenames to match for each name. [ruby-core:47418] [Bug #6977]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_1_9_3@39090 b2dd03c8-39d4-4d8f-98... -
- =begin
I have endeavoured to add proper Schema support to Psych (see ((<YAML Spec|URL:http://www.yaml.org/spec/1.2/spec.html#Schema>)) on Schemas). The primary reasons for supporting schemas are two fold: security and global tag conflic... -
- Fixed by r39070 which removes the check on windows. If writing a file as 0600 works on windows someday we can reintroduce it.
Credentials are loaded when .gemrc is loaded. Changing when credentials are loaded is too risky. -
- * proc.c (rb_method_entry_location, rb_{mod,obj}_method_location): new
functions to obtain source location of method definition.
* vm_method.c (rb_obj_respond_to): show the location of old style
respond_to? method.
git-svn-id: svn+s... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@39088 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@39087 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 03:39 AM Revision 4ce8ede2 (git): Update README to direct questions & bug reports adequately
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@39086 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * test/ruby/test_require.rb (TestRequire#test_require_with_unc):
cannot test unless the local drive is shared.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@39085 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
01:56 AM Bug #7656: Handful of documentations
- I see, the example added to the methods is misleading. I'll revamp the docs for PP, and create a new issue.
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@39084 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@39083 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@39082 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
02/05/2013
-
11:56 PM Bug #7774: IFUNC上のbinding呼び出しでSEGV
- rb_callccから呼ばれるrb_vm_stack_to_heapでも、
同様にIFUNCの対応が必要ということのようです。
以下のパッチで直りましたがどうでしょうか。
~~~diff
diff --git a/vm.c b/vm.c
index ef5dd97..1429cce 100644
--- a/vm.c
+++ b/vm.c
@@ -556,7 +556,7 @@ void
rb_vm_stack_to_heap(rb_thre... -
- (2013/02/05 16:47), ktsj (Kazuki Tsujimoto) wrote:
> が、次のコードがSEGVするようになってしまいました。
がーん．callcc 使ったコードなんて知らん，とは言えないかなぁ．
これは何が起きている？
--
// SASADA Koichi at atdot dot net -
- ご対応ありがとうございます。
が、次のコードがSEGVするようになってしまいました。
~~~ruby
require 'continuation'
tp = TracePoint.new(:raise) do |tp|
tp.binding
end
tp.enable do
obj = Object.new
class << obj
include Enumerable
def each
... -
- > Issue #7774 has been reported by ktsj (Kazuki Tsujimoto).
>
> ----------------------------------------
> Bug #7774: IFUNC上のbinding呼び出しでSEGV
> https://bugs.ruby-lang.org/issues/7774
ご報告，ありがとうございました．多分，治ったんじゃないかと思います．
... -
- This issue was solved with changeset r39067.
Kazuki, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.
----------
* proc.c (rb_binding_new_with_cfp): permit to create binding ob... -
-
03:19 PM Bug #7784: [mingw] r39055 creates test failures and functionality loss
- it doesn't solve the issue, but why is the permissions check not being isolated to only gem push?
-
- The r39055 patch for rubygems security (lib/rubygems/config_file.rb) causes 11 `make test-all` failures
http://ci.rubyinstaller.org/job/ruby-trunk-x64-test-all/659/console
and loss of gem command functionality due to typical defa... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@39081 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@39080 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * lib/rubygems/LICENSE.txt: Include license file
* lib/rubygems.rb: Move Gem module documentation so rdoc can parse it
and link to LICENSE.txt
* lib/rubygems/*: Hide useless documentation from Gem module rdoc
git-svn-id: svn+ssh://ci... -
- was deleted in r39077
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@39078 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 06:28 PM Revision b614d782 (git): * lib/csv.rb: Remove the dangerous serialization feature.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@39077 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- I am sorry to say that cygwin is not supported currently.
Of course, we always welcome patches for cygwin (and its maintainer,
if possible).
-
03:10 AM Bug #7781: Ruby fails make test on Cygwin for test_io.rb.
- I also get these stack errors when I run rails -v (inside any app directory) or bundle install:
Chloe@dumbopc /cygdrive/c/Sites/testapp
$ rails -v
/usr/local/lib/ruby/site_ruby/1.9.1/rubygems/requirement.rb:23: stack level too deep ... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@39076 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- This issue was solved with changeset r39069.
Nobuyoshi, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.
----------
vm_method.c: drop include_all flag
* vm_method.c (rb_obj_re... -
- The issue is that `rb_obj_respond_to` sends a second argument (include private) even when the user method doesn't accept one.
It should be fixed to only send one in those cases.
This is exactly what `check_funcall_respond_to` does ... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@39075 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 03:55 PM Revision 1e32d0fc (git): * 2013-02-06
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@39074 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- instead of rb_vm_get_ruby_level_next_cfp to prevent a segfault by
calling Kernel#callcc. See r39067 for more details.
[ruby-dev:46908] [ruby-trunk - Bug #7774]
* test/ruby/test_settracefunc.rb: add a test.
git-svn-id: svn+ssh://ci.... -
- This issue was solved with changeset r39065.
py, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.
----------
* lib/matrix.rb: Fix error message, patch by pypypy [Bug #7777] -
- This issue was solved with changeset r39063.
John, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.
----------
* rational.c (nurat_expt): Deal with special cases for rationals ... -
- This issue was solved with changeset r39063.
John, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.
----------
* rational.c (nurat_expt): Deal with special cases for rationals ... -
- This issue was solved with changeset r39058.
Marc-Andre, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.
----------
* enumerator.c: Use to_enum for Enumerable methods returnin... -
- Patch updated, rdoc improved too.
Makes for a clean API for Lazy#new also, and there's even less code (~20 loc).
I'll review the patch one last time before committing it (in about 5 hours). -
- This issue was solved with changeset r39057.
Marc-Andre, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.
----------
* enumerator.c: Finalize and document Lazy.new. [Bug #7248]... -
- I am not positive about adding exception classes. So far, TypeError only caused by inexistence of allocator.
Matz.
-
- So you think rescuing the error is good enough. Ok, I'll handle it that way. Would it be prudent to make the error very specific, e.g. `UndefinedAllocatorError`. So that rescue clauses can be sure to catch that specifically?
-
- "allocator" in the error message does not mean #allocate method, but internal C function (thus TypeError not NoMethodError).
We haven't provide the way to check if a class can be allocated, except for actually allocating an object.
I d... -
- =begin
One the one hand:
>> Struct.allocate
TypeError: allocator undefined for Struct
from (irb):1:in `allocate'
from (irb):1
from /opt/Ruby/1.9.3-p327/bin/irb:12:in `<main>'
But on the other:
... -
- interesting, doing a little bootleg debugging
<patch>
diff --git a/lib/pp.rb b/lib/pp.rb
index 6e0c797..681956d 100644
--- a/lib/pp.rb
+++ b/lib/pp.rb
@@ -145,13 +145,16 @@ class PP < PrettyPrint
def pp(obj)
id = obj.... -
- Thanks.
Note that I was proposing to issue a warning once, not for every call.
Also, the most pressing issue is for YAML, and as you can read, I am not the only one wishing to adopt this migration path. -
- Oh, I am sorry, I have misread your proposal. You have posted migration path.
But still numerous warning messages might cause serious problems for programs like dRuby that use marshal extensively.
So I propose to postpone the change ... - 09:49 AM Revision 81f9052c (git): * doc/security.rdoc: add regex, eval and drb sections
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@39072 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- instead of HTTP paths were returned.
* test/rdoc/test_rdoc_servlet.rb: Test for above.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@39071 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Windows writes 0600 file as 0644 permissions making the check
useless.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@39070 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * vm_method.c (rb_obj_respond_to): drop optional include_all flag if
respond_to? method is defined in old style. [Bug #7722]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@39069 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@39068 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- of IFUNC frame.
When `rb_binding_new_with_cfp()' is called, VM finds out the first
normal (has iseq) frame and create a binding object of this frame
and create Env objects. `ep's of related frames are updated
(`ep's point Env obj... - 05:52 AM Revision 757bbe87 (git): * enumerator.c: Remove rdoc that is obsolete because of lazy
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@39066 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 05:43 AM Revision 9a912c66 (git): * lib/matrix.rb: Fix error message, patch by pypypy [Bug #7777]
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@39065 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 05:39 AM Revision d22ce4a5 (git): * numeric.c (fix_pow): Handle special cases when base is 0, -1 or +1
- [Bug #5713] [Bug #5715]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@39064 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 05:39 AM Revision 8797ebd6 (git): * rational.c (nurat_expt): Deal with special cases for rationals 0, ±1
- [bug #5713] [bug #5715]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@39063 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 05:39 AM Revision 075ae295 (git): * numeric.c: Fix rdoc for Fixnum#**
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@39062 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Anytime!
-
05:01 AM Feature #7783 (Closed): Add support for sqrt of very large numbers
- Nice find, Zachary!
I happened to talk with Santiago about this. Closing... -
04:58 AM Feature #7783: Add support for sqrt of very large numbers
- Hey zzak, had no idea about that. Thanks!
So we can close this one. -
- =begin
Hello Mr. Pastorino!
It seems to work when I use the mathn library, which implements sqrt(3)
(({irb(main):001:0> require 'mathn' #=> true}))
(({irb(main):002:0> Math.sqrt(2**6456) #=> 53067179215503898168575338070}))
=end -
- /RSA the/when/
-
- Currently ...
irb(main):001:0> Math.sqrt(2**6456)
=> Infinity
I wanted to do something like this to show an example of how RSA could break RSA the public modulus N is generated incorrectly.
In Python you can do it using http://... -
- * test/ruby/test_range.rb (TestRange#test_bsearch_with_mathn): refine
failure messages.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@39061 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * ext/io/console/console.c (rawmode_opt): use default values by `stty
raw`.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@39060 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- This would be a great thing to have +1000
- 03:51 AM Revision e29e4b55 (git): * range.c: Use div instead of / for bsearch
- * test/ruby/test_range.rb: Test showing bug when requiring mathn
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@39059 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 03:49 AM Revision 1677cbce (git): * enumerator.c: Use to_enum for Enumerable methods returning Enumerators.
- This makes Lazy#cycle no longer needed, so it was removed.
Make Enumerator#chunk and slice_before return lazy Enumerators.
[Bug #7715]
* internal.h: Remove ref to rb_enum_cycle_size; no longer needed
* enum.c: Make enum_cycle_size ... - 03:49 AM Revision 44cd5f21 (git): * enumerator.c: Finalize and document Lazy.new. [Bug #7248]
- Add Lazy#to_enum and simplify Lazy#size.
* test/ruby/test_lazy_enumerator.rb: tests for above
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@39057 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 03:49 AM Revision 5af821c6 (git): * enumerator.c: Fix and improve rdoc for to_enum
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@39056 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- `gem push --host`
* lib/rubygems/gemcutter_utilities.rb: ditto.
* test/rubygems/test_gem_commands_push_command.rb: Test for the above.
* test/rubygems/test_gem_gemcutter_utilities.rb: ditto.
* lib/rubygems/config_file.rb: Abort if t... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@39054 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Patch by Josh Bassett [Github fixes #245]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@39053 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@39052 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- See [Github tenderlove/racc@7d954b5]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@39051 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@39050 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
02/04/2013
-
- enabled irb history [ruby-core:51347] [Bug #7679]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@39049 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- auto-indentation and autocompletion using irbrc and irb_context
[ruby-core:51209] [Bug #7642] and [ruby-core:51348] [Bug #7680]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@39048 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- and their purpose or short description
* lib/README: Remove lib/README in favor of doc/standard_library.rdoc
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@39047 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@39046 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 05:59 PM Revision f691d4a5 (git): * 2013-02-05
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@39045 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@39044 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- When compiling Ruby on Cygwin.com, it fails 'make test' for test_io.rb.
Chloe@dumbopc ~/ruby-1.9.3-p374
$ uname -a
CYGWIN_NT-5.1 dumbopc 1.7.17(0.262/5/3) 2012-10-19 14:39 i686 Cygwin
$ ./ruby -v
ruby 1.9.3p374 (2013-01-15 revisi... -
- Patch almost done, which also fixes #7248
https://github.com/marcandre/ruby/compare/marcandre:master...marcandre:lazy
Still missing:
- tweak inspect
- fix .lazy.size
- couple more tests
-
- I believe I have found the key to resolve this issue, Lazy.new issue [#7248] and others.
We simply need to specialize `to_enum/enum_for` for lazy enumerators.
In the same way, RETURN_SIZED_ENUMERATOR should return a lazy enumerator... -
- matz (Yukihiro Matsumoto) wrote:
> Your proposed change will crash many programs including dRuby.
Could you please elaborate? By crash, do you mean break?
The proposed change simply adds a warning to YAML.load; do you consider tha... -
- Your proposed change will crash many programs including dRuby.
So it's too late for 2.0.0.
Don't get me wrong by rejecting this issue.
I am not against the idea of restriction itself. "secure by default" sounds nice, but this idea r... -
01:45 PM Bug #7780: Marshal & YAML should deserialize only basic types by default.
- What about using load for the safe method and load! for the non-safe method? That would be the Ruby way.
Otherwise, in particular for Yaml, I think it's way better to have load and dangerous_load rather than load and safe_load. -
- Just read the comments in the post I referred to (http://nedbatchelder.com/blog/201302/war_is_peace.html)
There's an informative comment from Nick Coghlan, a CPython core dev. He also advocates "Security by default", and gives the exa... -
- mame (Yusuke Endoh) wrote:
> I think that this issue is not a bug, but a new feature.
I would rather not argue about this.
> ...
This is worth arguing over.
What downside do you see to my proposition?
What upsides do you see t... - 12:33 PM Bug #7780: Marshal & YAML should deserialize only basic types by default.
- mame (Yusuke Endoh) wrote:
> I agree with charliesome; I think that this issue is not a bug, but a new feature.
> ...
Let me clarify what I meant.
I think Marshal.load is ok to be dangerous, as Marshal is something that it very coup... -
12:29 PM Bug #7780 (Assigned): Marshal & YAML should deserialize only basic types by default.
- Is this related to #7759?
charliesome (Charlie Somerville) wrote:
> Please note that I do not consider this a vulnerability in Ruby. Marshal is dangerous by design. This is an education problem - we need to document the fact that it ... -
- For reference, the vulnerabilities I'm referring to are the two major Rails vulnerabilities CVE-2013-0156, CVE-2013-0333, that affected the vast majority of installed rails applications, and even Rails app running locally on port 3000, t...
-
- YAML is a wonderful, powerful and expressive format to serialize data in a human readable way.
It can be used, for example, to read and write nice configuration files, to store strings, numbers, dates & times in a hash.
YAML.load w... -
02:11 PM Feature #7639: More freedom for location of comments
- It was meant to be and has been an experimental feature, so let's not take it for granted as established one.
We already have it so why not extend it is not the way to go.
If a problem is found, we need to reconsider and address downsi... -
11:20 AM Feature #7639: More freedom for location of comments
- > alexeymuranov (Alexey Muranov)
Allowing a line to start with a period was a change introduced in Ruby 1.9. It is not what I am newly proposing here. If you are against it, that would be a claim against that feature introduced in the... -
03:44 AM Feature #7639: More freedom for location of comments
- As for me, i do not like to continue a line by starting the following one with a dot: it is not clear immediately if the first line is over, and does not allow to copy-paste the code into IRB.
-
- * ext/io/console/io-console.gemspec: bump to 0.4.1.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@39043 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Fixed with r38983 (not sure why redmine didn't link the commit & close the issue).
ありがとうございます。 -
- * ext/io/console/io-console.gemspec: limit Date keyword length to get rid of locale format.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@39042 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * ext/io/console/io-console.gemspec: use Date keyword and add licenses.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@39041 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- This is low priority for my usage, and while I'm not investigating the issue anytime soon, I'm surfacing it here in case it's not my system issue and it affects 2.0.0 readiness. I didn't see anything similar on RG's GH issue tracker.
... -
- * ext/socket/init.c (cloexec_accept): fix declaration-after-statement.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@39040 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * ext/io/console/console.c (rawmode_opt): initialize options for the
case all options are not given.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@39039 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
04:36 AM Bug #7778 (Rejected): Irb loading generates 17x more open/stat system calls when a locale is set
- Hello,
I did just found out that when I have a locale set (e.g. cs_CZ in my case), irb does some extra finding for rb/so files which are being required. That slows down loading time and if you have many rubygems, loading can be really... -
- Ok the above looks like bug in lib/irb/locale.rb:
LC_ALL=C strace irb < /dev/null 2>&1 | grep ENOENT | wc -l
293
It not only triples amount of stat/open calls, it is like 17.5x faster. I am filling new bugreport for this. -
- Hello,
I am trying Ruby 2.0 RC1 which should contain this fix, but I think I still see many stat and open syscalls with ENOENT result. The number is slightly lower.
$ ruby -v
ruby 1.9.3p327 (2012-11-10 revision 37606) [x86_64-linux]
$ ... -
- if `ep' points an env object.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@39038 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * lib/English.rb (English): disable setting instead of removing after set.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@39037 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
12:28 AM Bug #7777 (Closed): wrong use of "Raise" method in matrix.rb
- =begin
"Raise" method added by e2mmap library shows customized error messages according to pre-registered formats:
$ irb
irb(main):001:0> require 'matrix'
=> true
irb(main):002:0> Matrix.Raise ArgumentError, 2, 3 rescue $!... -
12:16 AM Revision e7d6a048 (git): fix a typo
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@39036 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
02/03/2013
-
- Indeed, method chains do seem to continue beyond empty lines. The following two work:
```ruby
[1, 2, 3].
map{|x| x * 2}
```
```ruby
[1, 2, 3].
#
map{|x| x * 2}
```
But the following does not, (which I claim is strange, gi... -
- Comments are equivalent to white spaces syntactically now, so do you expect that a method chain will continue beyond empty lines?
It seems strange to me. -
- I would like to add another argument for such feature. It is common that you put each step of a chain in a new line. During debugging, it frequently happens that you want to comment out particular lines within a chain. You have no proble...
-
- paul0 (Paulo Geyer) wrote:
> fixed that, changed to $(srcdir)/complex.o the line where tells where the object to be linked is in the ext/mathn/complex/Makefile
$(srcdir)/complex.o?
I have no idea why the object file is prefixed with... -
06:11 AM Bug #7737: problem with generated rbconfig.rb for Haiku
- paul0 (Paulo Geyer) wrote:
> fixed that, changed to $(srcdir)/complex.o the line where tells where the object to be linked is in the ext/mathn/complex/Makefile
> ...
fixed other things, and finished compiling
this patch haven't solved... -
- fixed that, changed to $(srcdir)/complex.o the line where tells where the object to be linked is in the ext/mathn/complex/Makefile
had to do that with ext/mathn/rational/Makefile too -
- nobu (Nobuyoshi Nakada) wrote:
> Seems RPATHFLAG unnecessary for extconf.rb.
> ...
tried again with the latest patch, and updated my local code with the remote repository, now it can't find "complex.o"
here is the make output
lin... -
- 2013年2月3日 18:35 SASADA Koichi <ko1@atdot.net>:
> RC2 っていつ頃出します？
連絡してなくてすみません。
rubygems.org の事件に関連して Eric Hodel が何かしら rubygems に
対処が必要かを検討したいと言っていて、その具体的なプランを問い
合わせているところです。（今日中に返事よこせと言った）
明日には何かしらのアナウンスを出したいと思います。
... -
- (2013/02/03 18:14), ktsj (Kazuki Tsujimoto) wrote:
> binding呼び出しによって環境がヒープに移されますが、
> IFUNC上のepがそれに追随できていないのが原因です。
あーあーきこえなーい．
じゃなくて，ええと，IFUNC 回りはてきとーですよね．どうしようかな．
RC2 っていつ頃出します？
--
// SASADA Koichi at atdot... -
- =begin
辻本です。
以下のコードでSEGVします。
tp = TracePoint.new(:raise) do |tp|
tp.binding
end
tp.enable
@obj = Object.new
class << @obj
include Enumerable
def each
yield 1
end
end
@obj.zip({}) {}
バックト... -
- remove_const to avoid confusion. Include full list of aliases and
their associated global variable.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@39035 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
07:05 PM Bug #7522: Non-core "Type()" Kernel methods return new objects
- No apology necessary. Thanks for the help!
-
06:01 PM Bug #7762: io-console version should be bumped
- nobu (Nobuyoshi Nakada) wrote:
> I had uploaded io-console gem generated from the trunk.
> ...
Thank you. That solved my concerns.
-
- This issue was solved with changeset r39031.
Vit, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.
----------
io-console.gemspec: bump
* ext/io/console/io-console.gemspec: bum... -
- I had uploaded io-console gem generated from the trunk.
How do they differ? -
05:41 PM Bug #7773 (Closed): Calling send("attribute=", value) returns nil instead of value
- When calling an attribute writer created using either attr_accessor or attr_writer via send nil is returned from the send call instead of the new value.
I've attached a test case that is failing on current head (51794) and 2.0.0-rc1. ... - 05:40 PM Revision 63bedf5d (git): * 2013-02-04
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@39034 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- #yamler= for using the removed Syck gem as the YAML::ENGINE
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@39033 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Ah, so this has been thought of before. I agree it should not replace behaviour of private #send (although, how much sweeter the syntax if it were called #private_send ?). But as an additional method, it would be useful.
Or was there so... -
- #send had been implemented in that manner once, but reverted and #public_send was separated instead.
-
- Sorry, I should have had a look at the patch. It makes indeed sense to apply this patch.
-
- It's very well known that Quicksort may create stack overflows. But it's also very well known how to deal with them: Check which of the remaining divisions is longer, and user recursion for the sorter part, and tail recursion simulated w...
-
04:07 PM Bug #7772: Consider bumping stack size in ruby_qsort
- Patch to bump size to 64
-
- At the moment the maximum size of the stack is 32. The comment implies this should be enough for arrays with up to 2**32 elements, but it's possible to create larger arrays on some big systems.
I was not able to trigger a bug with: ([... -
- Thank you Narsimham Chelluri, this issue was resolved by r38976.
-
- This issue was solved with changeset r39025.
Kazuhiro, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.
----------
* random.c: Document range argument for Kernel#rand.
[ruby-... -
- This issue was solved with changeset r39024.
Aaron, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.
----------
* numeric.c: Document Float constants [ruby-core:51484] [Bug #7709] -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@39032 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * ext/io/console/io-console.gemspec: bump. [Bug #7762]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@39031 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * test/io/console/test_io_console.rb (test_stringio_getch): use more
descriptive assertions.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@39030 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * ext/io/console/console.c (rawmode_opt): min is minimum characters,
not tenths.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@39029 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@39028 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@39027 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 07:14 AM Revision cac38cd0 (git): * doc/security.rdoc: add first cut at a Ruby security document
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@39026 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- [ruby-core:51794] [Bug #7770]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@39025 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@39024 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * lib/profiler.rb (PROFILE_CALL_PROC, PROFILE_RETURN_PROC): add b_call
and b_return to profile block calls.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@39023 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 12:37 AM Revision 0d7a1971 (git): * 2013-02-03
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@39022 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * lib/profiler.rb (PROFILE_CALL_PROC, PROFILE_RETURN_PROC): split
PROFILE_PROC for call and return events.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@39021 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
02/02/2013
- 07:23 PM Bug #7771 (Rejected): method 'gets' crashed
- 07:23 PM Bug #7771: method 'gets' crashed
- =begin
This is by design, (({gets})) will read from (({ARGV})) by default. If you want to read from the standard input even if there is a command line argument, use:
$stdin.gets
=end -
07:17 PM Bug #7771 (Rejected): method 'gets' crashed
- method 'gets' crashed when pass arguments like "ruby test.rb hello"
example
#file test.rb only one method
gets
#end
=========
type "ruby test.rb" and enter will work well
but "ruby test.rb hello" will crash
In my machine(ubun... -
- Hello Vincent,
I've committed your patch for lib/debug. as r39019, I was reviewing your patch for lib/pp.rb and noticed the example for PPMethods::check_inspect_key doesn't work in trunk.
::check_inspect_key(obj.object_id) returns ... -
- This issue was solved with changeset r39016.
stephen, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.
----------
* lib/gserver.rb (GServer#start): fix a timing issue. patch f... -
- まあ一応反対が出たのでコミットしません。
内容的には小崎さんに全面賛成で、「あの環境でできないから」とか言ってたら
File/FileUtils 関係はほとんど何も出来なくなるんじゃないかと思いますが、
まあ今から議論するのは 2.0.0 には遅いので next minor にします。
あと自分で判断できる内容じゃない気がするので担当ははずれておきます。
対応が遅くなってすみません。
--
Yusuke Endoh <mame@tsg.ne.jp> -
- Applied at r39011.
--
Yusuke Endoh <mame@tsg.ne.jp> -
- This issue was solved with changeset r39015.
Jan, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.
----------
* lib/fileutils.rb (copy_entry, wrap_traverse): preserve attribute... -
- This issue was solved with changeset r39013.
Yoshifumi, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.
----------
* lib/uri/ftp.rb (URI::FTP.new2): remove the rdoc because it... -
- Sorry but let me postpone this to the next minor.
I'm afraid if the existing code depends on the traditional behavior.
It should have been included in rc1, which is my fault. Sorry, blame me.
--
Yusuke Endoh <mame@tsg.ne.jp> -
- This issue was solved with changeset r39010.
Charles, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.
----------
* lib/English.rb: Remove some confusing words from rdoc. [Bug... -
- This issue was solved with changeset r39008.
Marc-Andre, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.
----------
* proc.c (proc_curry): Fix arity check [Bug #5747]
* test/... -
- This issue was solved with changeset r39007.
Marc-Andre, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.
----------
* proc.c: Add {*}_min_max_arity and refactor.
[Bug #7765]... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@39020 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- patch by Vincent Batts [ruby-core:51253]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@39019 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
-
04:32 AM Bug #7766: Marshal.dump corrupts Hash data when serializing
- It only corrupted the output, although a few mins ago I realized I was on the preview and there was an RC1 out.
I just tested RC1 and the problem seems to have been fixed.
Do excuse me and please ignore this issue. -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@39018 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@39017 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Charles Nutter. [Bug #7081]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@39016 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- directories on FileUtils.cp_r. The fix was proposed by Jan
Wedekind. [Bug #7246]
* test/fileutils/test_fileutils.rb: add a test for above.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@39015 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@39014 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- well tested yet. [Bug #7301]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@39013 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- previous commit.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@39012 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- caused error in verbose mode.
* test/fileutils/test_fileutils.rb: add a test for above.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@39011 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@39010 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
01:38 AM Bug #7625: Arrayを継承したオブジェクトのcompactがArrayを返す
- r39004 (#7768) で uniq は修正されたようですね。
-
- #7625 is related to this issue.
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@39009 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
02/01/2013
-
11:57 PM Bug #7750: ＧＣ中にオブジェクトが割り当てられる
- OSはWindows8で、CPUは、Intel(R) Core(TM) i3-3220 CPU @ 3.30GHz 3.30GHzです。５分程度でスクリプト自体は死にます。再度手元で、１０回程度実行してみたところ前述したメッセージが出ませんでした。すいません。
-
- Random#rand(range) is written in RDoc of random_rand, but rand(range) is not written in RDoc of rb_f_rand.
- 11:05 PM Bug #7768 (Closed): Inherited Array class missing
- This issue was solved with changeset r39004.
Roman, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.
----------
* array.c (rb_ary_dup): make returned array the same class as th... - 09:56 PM Bug #7768: Inherited Array class missing
- =begin
Looks like a regression introduced in r26987
=end -
09:43 PM Bug #7768 (Closed): Inherited Array class missing
- Hello. I apologize if I missed something.
I found strange behavior in ruby 1.9:
```ruby
class Custom < Array; end
Custom.new(0){|i| i + 1}.uniq.class # => Array
Custom.new(2){|i| i + 1}.uniq.class # => Custom
```
while in 1... - 10:46 PM Revision f810d180 (git): * proc.c (proc_curry): Fix arity check [Bug #5747]
- * test/ruby/test_proc.rb: Test for above
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@39008 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 10:46 PM Revision 83610815 (git): * proc.c: Add {*}_min_max_arity and refactor.
- [Bug #7765]
* test/ruby/test_proc.rb: Fix wrong test
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@39007 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
09:59 PM Feature #7767: Tempfileで自動的にファイルを削除する
- 2013/2/1 kyanagi (Kouhei Yanagita) <redmine@ruby-lang.org>:
>
> しかし、Tempfile.openにブロックを渡すと自動的にcloseするところまではやってくれるのに、
> 削除をわざわざ明示的に書かないといけないというのは少し残念な気もします。
>
> Tempfile.openの類推で、ブロックを抜けると自動的にclose!してくれるメソッドがあると、
> 削除に気を使わなくて... -
09:27 PM Feature #7767 (Closed): Tempfileで自動的にファイルを削除する
- ソースコードのコメント（tempfile.rbのGood practicesの項）にも書かれている通り、
Tempfileは使用後、明示的に削除することが推奨されています。
しかし、Tempfile.openにブロックを渡すと自動的にcloseするところまではやってくれるのに、
削除をわざわざ明示的に書かないといけないというのは少し残念な気もします。
Tempfile.openの類推で、ブロックを抜けると自動的にclose!してくれるメソッドがあると、
... - 09:07 PM Bug #7766: Marshal.dump corrupts Hash data when serializing
- =begin
Does it only corrupt the output, or does it break the actual Hash object passed to it?
=end -
- =begin
Marshal.dump seems to corrupt a Hash object during serialization.
The problem is that this does not happen when the affected Hash is serialized by itself but only (as far as I could see) when it's part of a larger object.
Wor... -
- On 2013/01/31 18:07, coffeejunk (Maximilian Haack) wrote:
>
> Issue #7752 has been updated by coffeejunk (Maximilian Haack).
>
>
> The only problem I see is that ruby is lying to the user.
There is 0% lying if one claims ... -
- On current policy, strings which always include only US-ASCII characters are US-ASCII.
If there is a practical issue, I may change the policy in the future.
Note that US-ASCII string is faster than UTF-8 on getting length or index ac... - 03:46 PM Revision 4b4d889f (git): * 2013-02-02
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@39006 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 03:46 PM Revision ba5ff937 (git): * marshal.c: add security considerations to marshal overview, refer to
- overview from Marshal.load documentation [#7759]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@39005 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
-
02:31 AM Feature #7763 (Closed): add Win32::Registry#values
- hello.
In today's Win32::Registry objects, we have
#num_keys, #keys, #num_values
(and no #values method, but there is an #each_value method and #each_key method).
So this is a feature request for it to be added. I suppose it ... -
02:47 PM Feature #6626: Readline.delete_text
- feature requestだと思うのでnext minorにしておきます。
-
- luislavena (Luis Lavena) wrote:
> Attempting to compile trunk (r35415) against GCC 4.6 (4.6.3, OSX 10.6, MacPorts provided) generates the following failure:
Could you attach ext/readline/{mkmf.log,extconf.h}?
-
- This issue was solved with changeset r39002.
Zachary, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.
----------
* ext/readline/extconf.rb, ext/readline/readline.c: check
RL... - 02:05 PM Revision 86aa98fe (git): * array.c (rb_ary_dup): make returned array the same class as the original
- array [Bug #7768] [ruby-core:51792]
* test/ruby/test_array.rb (class TestArray): add test
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@39004 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * marshal.c (r_object0): prohibit setting instance variables of
exising class/module.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@39003 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- We have:
Proc.new{|a, b, c, d, e|}.arity # => 5
Matz decided [ruby-core:46515] we also have:
Proc.new{|a, b, c, d, e=0|}.arity # => 4
It looks like we currently have:
Proc.new{|a, b=0, c, d, e|}.arity # => 1, s... -
- RL_PROMPT_START_IGNORE and RL_PROMPT_END_IGNORE directly in
readline.c. Patch by Zachary Scott. [Bug #7397] [ruby-core:49561]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@39002 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
12:50 AM Bug #7172: [[Ruby 1.9:]] fix rbconfig for --enable-load-relative (v2)
- So running:
rvm install ruby-head --debug --movable
Executes:
autoreconf
./configure --disable-install-doc --prefix=/home/mpapis/.rvm/rubies/ruby-head --enable-shared --enable-load-relative --sysconfdir=/etc --with-... - 12:47 AM Revision 8df20dd7 (git): * 2013-02-01
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@39001 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@39000 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
01/31/2013
-
- BTW there should be process in place which ensures, that the libraries are properly versioned, i.e. if something is changed, it cannot have the same version as already released library (see #7761 and #7762).
-
- The io-console shipped with Ruby 2.0 claims it is version 0.3, although it is definitely different code from io-console 0.3 available on rubygems.org. bigdecimal version should be bumped prior release of Ruby 2.0.0 to prevent confusion.
-
- US-ASCII is a strict subset of UTF-8, so I don't think there's necessarily any lying involved.
-
06:07 PM Bug #7752: Rational/Float/Fixnum/Bignum `.to_s.encoding` is US-ASCII
- The only problem I see is that ruby is lying to the user. It is not severe since, as you said, there are no non-ascii characters in the resulting string, but I think ruby should respect the set encoding.
- 09:55 PM Bug #7759 (Closed): Marshal.load is not documented to be dangerous
- This issue was solved with changeset r38999.
Charlie, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.
----------
marshal.c: warn against using Marshal.load on untrusted data
... -
- (2013/01/31 8:59), charliesome (Charlie Somerville) wrote:
> Unfortunately, many developers use it inappropriately and unmarshal user input. This can lead to a wide range of vulnerabilities, including remote code execution.
Could... - 11:15 AM Bug #7759: Marshal.load is not documented to be dangerous
- > I've thought it's a common sense, isn't it?
You would imagine so, however I have seen a lot of code that does unmarshal untrusted data.
I will send an example to security@ruby-lang.org. Please note that I do not consider this a v... -
- charliesome (Charlie Somerville) wrote:
> Unfortunately, many developers use it inappropriately and unmarshal user input. This can lead to a wide range of vulnerabilities, including remote code execution.
Can't you elaborate it, prob... -
- > Marshal.load is incredibly powerful, and also incredibly dangerous.
>
> Unfortunately, many developers use it inappropriately and unmarshal user input. This can lead to a wide range of vulnerabilities, including remote code execut... - 08:59 AM Bug #7759 (Closed): Marshal.load is not documented to be dangerous
- =begin
Marshal.load is incredibly powerful, and also incredibly dangerous.
Unfortunately, many developers use it inappropriately and unmarshal user input. This can lead to a wide range of vulnerabilities, including remote code execut... -
- I am not that confident that I understand all the detail, but I vote for drop include_all flags.
Matz.
-
- 1.9.3's psych raises ArgumentError.
2.0.0's psych doesn't.
% ruby -v -r yaml -e '"-\n2000-01-02 03:04:05".to_yaml'
ruby 1.9.3p374 (2013-01-15 revision 38858) [x86_64-darwin12.2.0]
/Users/kazu/.rbenv/versions/1.9.3-p374/lib/ruby/1.9... - 12:55 PM Revision f8823475 (git): marshal.c: warn against using Marshal.load on untrusted data
- * marshal.c (marshal_load): Add documentation warning against using
Marshal.load on untrusted data [Bug #7759] [ruby-core:51765]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@38999 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
12:12 PM Bug #7758: Ruby on Windows crashes when active codepage is codepage 65001 and outputting unicode character
- I confirmed this bug occurs on Windows 7 with ruby 1.9.3p374 and 2.0 trunk.
I tested with MinGW32 gcc compiled version(mingw32) and MSVC++ compiled version(mswin32).
When the windows console font is a console with raster font, this... -
- Can you tell us more about the specific version of Windows that you're using?
Nowhere in your output says which version of Windows is.
Have you tried this against Ruby 2.0 too?
-
05:22 AM Bug #7758 (Closed): Ruby on Windows crashes when active codepage is codepage 65001 and outputting unicode character
- =begin
I have a script that contains the unicode BOX_DRAWINGS_LIGHT_VERTICAL_AND_RIGHT character (http://www.fileformat.info/info/unicode/char/251c/index.htm). When the console code page is set to 65001 (utf-8), both ruby 1.9.3 p125 and... -
- * parse.y (local_push_gen): no assigned but unused variable warnings
in eval as well as -e. [Feature #7730] [ruby-core:51580]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@38998 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- should be "STDOUT.sync".
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@38997 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Raises an IndexError if Regexp match is out of range.
Github fixes #243 Patch by Dmtiriy Budnik
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@38996 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 04:59 AM Revision 625119a3 (git): * 2013-01-31
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@38995 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- sizeof(sa_familiy_t) if path is empty. see "Autobind Feature" in
unix(7) for details.
* ext/socket/lib/socket.rb (unix_socket_abstract_name?): treat an
empty path as an abstract name.
* test/socket/test_unix.rb: related test.
git... -
- Dupe, see #3388, sorry.
Need a ram upgrade. -
- As suggested by Ilya in #5536, the following should work:
"hello".start_with? /h/ # => true, not a TypeError
-
01:19 AM Bug #5536: String#start_with? and end_with? ignore arguments convertible to a String [PATCH]
- prijutme4ty (Ilya Vorontsov) wrote:
> =begin
> ...
See #3388 for this feature (this issue is closed).
It is the approach I initially took, but building and compiling a Regexp is expensive, and so it should be cached or another way be ... -
12:30 AM Bug #5536: String#start_with? and end_with? ignore arguments convertible to a String [PATCH]
- =begin
Can you please explain, why not just make (({"str".start_with(/s/)})) behave as (({"str".match(/^s/)})) ?
=end