Project

General

Profile

Activity

From 06/18/2011 to 06/24/2011

06/24/2011

11:10 PM Bug #4072: dRubyで作成したサーバプログラムがsleepしていてもexitしてしまう
> RUBY_VM_CHECK_INTS() を抜けた後で th->status が THREAD_RUNNABLE になっていることがあるようで
この原因は rb_threadptr_check_signal() でタイマースレッドがメインスレッドの status を変更しているためではないかと思います。
mth->status = THREAD_RUNNABLE にセットしてから rb_threadptr_interrupt() でメインスレッドへシグナル送信し...
nagachika (Tomoyuki Chikanaga)
10:29 PM Bug #4072: dRubyで作成したサーバプログラムがsleepしていてもexitしてしまう
遠藤です。

2011年6月24日14:43 KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>:
> ところで、話は変わるのですが thread.stopも process.sleep の「thread.run するまで
> スリープする」と書いて有るのにシグナル受信したときの挙動が違うのはなぜなんでしょうね?
> deadlock check作った遠藤さんに聞くべきなのかも知れませんが。

...
mame (Yusuke Endoh)
10:29 PM Bug #4072: dRubyで作成したサーバプログラムがsleepしていてもexitしてしまう
遠藤です。

2011年6月24日14:43 KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>:
> ところで、話は変わるのですが thread.stopも process.sleep の「thread.run するまで
> スリープする」と書いて有るのにシグナル受信したときの挙動が違うのはなぜなんでしょうね?
> deadlock check作った遠藤さんに聞くべきなのかも知れませんが。

...
mame (Yusuke Endoh)
09:00 PM Bug #4072 (Open): dRubyで作成したサーバプログラムがsleepしていてもexitしてしまう
すみません、調査不足でした。再度 open します。
kosaki さんのご指摘の通り引数なしの Kernel#sleep がシグナルによって起きてしまうという問題は残っていました。 trunk で以下のように空のシグナルハンドラを設定して sleep すると darwin10.7.0 では SIGINT で sleep から目覚めてしまいました。
Signal.trap(:INT){}
sleep
これは spurious wakeup 対策不足という...
nagachika (Tomoyuki Chikanaga)
01:53 PM Bug #4072: dRubyで作成したサーバプログラムがsleepしていてもexitしてしまう
何度もすみません。SIG_DFL じゃなくて SIG_IGN ですね。
あと引数なしの sleep の場合は sleep_forever() で眠りますが、こちらは deadlockable 引数が 0 だと while の条件部が抜けるようになっているのでそのため一度起床するとそのまま抜けてしまってたようです。
nagachika (Tomoyuki Chikanaga)
01:28 PM Bug #4072: dRubyで作成したサーバプログラムがsleepしていてもexitしてしまう
そうですね、EINTR でのリトライじゃなく SIGPIPE が SIG_DFL になったことの影響かもしれません。
nagachika (Tomoyuki Chikanaga)
12:33 PM Bug #4072: dRubyで作成したサーバプログラムがsleepしていてもexitしてしまう
いま、Macのpthread_cond_wait()見てるんですが、
http://www.opensource.apple.com/source/Libc/Libc-594.9.4/pthreads/pthread_cond.c
/*
* Suspend waiting for a condition variable.
* Note: we have to keep a list of condition variables which ar...
kosaki (Motohiro KOSAKI)
10:04 PM Bug #4923: [ext/openssl] test_ssl.rb: test_client_auth fails
I played around a bit and it seems like this could be some kind of race condition.
At first I thought that the custom Fedora OpenSSL would probably reject some
algorithm and so I wanted to see what cipher is negotiated in the tests and...
MartinBosslet (Martin Bosslet)
04:42 AM Bug #4923: [ext/openssl] test_ssl.rb: test_client_auth fails
Strange. I tried with 0.9.8r, couldn't reproduce it. Then I tried with 1.0.0d, again the tests succeeded. It is only the customized version of 1.0.0d that ships with Fedora 15 that causes the error. I know that they disabled ECC support ... MartinBosslet (Martin Bosslet)
09:40 PM Bug #4916: [BUG] Segmentation fault - dyld: lazy symbol binding failed: Symbol not found: _ASN1_put_eoc
Hiroshi NAKAMURA wrote:
> Martin Bosslet wrote:
> ...
Infinite length support has been introduced with 1.9.3, in 1.9.2 decoding infinite length values already
worked, but they were re-encoded using a definite length value (cf. http://...
MartinBosslet (Martin Bosslet)
07:09 PM Bug #4916: [BUG] Segmentation fault - dyld: lazy symbol binding failed: Symbol not found: _ASN1_put_eoc
Martin Bosslet wrote:
> The missing ASN1_put_eoc is not the only problem with OpenSSL 0.9.7, unfortunately. ASN1_put_object and
> ...
Thanks for investigation. Hmm. I don't remember if there was such a case in ext/openssl development.
...
nahi (Hiroshi Nakamura)
04:09 AM Bug #4916: [BUG] Segmentation fault - dyld: lazy symbol binding failed: Symbol not found: _ASN1_put_eoc
The missing ASN1_put_eoc is not the only problem with OpenSSL 0.9.7, unfortunately. ASN1_put_object and ASN1_object_size behave differently in >= 0.9.8 regarding the length parameter being passed to them when dealing with infinite length... MartinBosslet (Martin Bosslet)
09:25 PM Bug #4922 (Closed): Bug in Webrick httprequest.rb using multiple proxies and fix
I close it since I replied to the original reporter at ruby-core. nahi (Hiroshi Nakamura)
04:10 PM Bug #4237 (Closed): SSL_shutdown should be called until it returns 0
Hi,
On Fri, Jun 24, 2011 at 02:13, Aaron Patterson <aaron@tenderlovemaking.com> wrote:
>> And the second part, can you remember some more details of SEGV you got? If the error you got is timeout or something, it could be caused by in...
nahi (Hiroshi Nakamura)
02:23 AM Bug #4237: SSL_shutdown should be called until it returns 0
On Thu, Jun 23, 2011 at 02:27:41PM +0900, Hiroshi NAKAMURA wrote:
>
> Issue #4237 has been updated by Hiroshi NAKAMURA.
>
>
> Thanks for the explanation. I think r30294 (fix for lib/net/smtp.rb) is good. It solved the original p...
tenderlovemaking (Aaron Patterson)
12:09 PM Feature #4924 (Assigned): mkmf have_header fails with C++ headers
=begin
When a user calls (({have_header('some_cpp_header.h')})), and then header includes a line such as(({ #include <string>})), mkmf will fail.
An example run follows:
+ extconf.rb
require 'mkmf'
have_library('stdc++')
...
adgar (Michael Edgar)
11:05 AM Revision 635d13a8 (git): * lib/webrick/httprequest.rb (setup_forwarded_info): Parsing request
header failed when the request is from 2 or more Apache reverse
proxies. It's said that all X-Forwarded-* headers will contain more
than one (comma-separated) value if the original request already
contained one of these headers. S...
Hiroshi Nakamura
08:06 AM Revision 706335aa (git): * process.c (proc_daemon): should not start timer thread
twice. fixed Bug#4920.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@32221 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
nobu (Nobuyoshi Nakada)
07:06 AM Revision dd91beb3 (git): * Typo fixed. Is it reallyl a typo? 2*2 == 2+2 == 4.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@32220 b2dd03c8-39d4-4d8f-98ff-823fe69b080e Hiroshi Nakamura
07:01 AM Revision 369b0950 (git): * ext/openssl/ossl_ssl.c (ossl_ssl_shutdown): Try to shutdown SSL
connection more gracefully. Call SSL_shutdown() max 4 times until it
returns 1 (success). Bi-directional SSL close has several states but
SSL_shutdown() kicks only 1 transition per call. Max 4 is from
mod_ssl.c of Apache httpd that...
Hiroshi Nakamura
03:59 AM Feature #4917: `NilClass#to_ary`
(2011/06/24 1:00), Benoit Daloze wrote:
> On 22 June 2011 19:55, Marc-Andre Lafortune <ruby-core@marc-andre.ca> wrote:
>> The method `to_ary` is for classes that can be implicitly converted to an Array. This doesn't apply to NilClas...
naruse (Yui NARUSE)
01:23 AM Feature #4917: `NilClass#to_ary`
On 22 June 2011 19:55, Marc-Andre Lafortune <ruby-core@marc-andre.ca> wrote:
> The method `to_ary` is for classes that can be implicitly converted to an Array. This doesn't apply to NilClass.
>
> I'm also highly sceptical as to th...
Eregon (Benoit Daloze)
12:25 AM Feature #4910: Classes as factories
Charles Nutter wrote:
> I'm not sure I agree with adding `to_proc` to `Class` instances, since it seems questionable that `#new` is what you'd always want to be called.
Hmm, but what else? I think it is a reasonable default.
> .....
rklemme (Robert Klemme)
12:12 AM Feature #1031: -U オプションの説明が --help にない
とりあえずFeatureに移動しますかね naruse (Yui NARUSE)

06/23/2011

11:54 PM Bug #4919: OpenSSL::SSL::Sesssion#time= に Bignum を渡すと ArgumentError が発生する
Hiroshi NAKAMURA wrote:
> Aaaaarhg! Sorry, 2**31 is not in a signed long value. Miserable me...
> ...
No problem, works fine now. Happens to the best of us ;)
> >>>>2) Anyone else getting the "sslv3 alert illegal parameter"? I g...
MartinBosslet (Martin Bosslet)
10:23 PM Bug #4919: OpenSSL::SSL::Sesssion#time= に Bignum を渡すと ArgumentError が発生する
2011/6/23 Martin Boßlet <martin.bosslet@googlemail.com>:
>> I modified it a little at r32211.
>
> This gives me: (Ubuntu 10.04 32bit, OpenSSL 0.9.8k)

Aaaaarhg! Sorry, 2**31 is not in a signed long value. Miserable me...
Fixed at...
nahi (Hiroshi Nakamura)
10:23 PM Bug #4919: OpenSSL::SSL::Sesssion#time= に Bignum を渡すと ArgumentError が発生する
2011/6/23 Martin Boßlet <martin.bosslet@googlemail.com>:
>> I modified it a little at r32211.
>
> This gives me: (Ubuntu 10.04 32bit, OpenSSL 0.9.8k)

Aaaaarhg! Sorry, 2**31 is not in a signed long value. Miserable me...
Fixed at...
nahi (Hiroshi Nakamura)
07:59 PM Bug #4919: OpenSSL::SSL::Sesssion#time= に Bignum を渡すと ArgumentError が発生する
2011/6/23 Hiroshi Nakamura <nakahiro@gmail.com>:
> 報告ありがとうございます。32bit環境で落ちるとか考えてませんでした。。。
> Thanks for the report. I was not aware that the code has 64bit dependency...
>
> On Wed, Jun 22, 2011 at 18:45, Tomoyuki Chikanaga <naga...
MartinBosslet (Martin Bosslet)
07:59 PM Bug #4919: OpenSSL::SSL::Sesssion#time= に Bignum を渡すと ArgumentError が発生する
2011/6/23 Hiroshi Nakamura <nakahiro@gmail.com>:
> 報告ありがとうございます。32bit環境で落ちるとか考えてませんでした。。。
> Thanks for the report. I was not aware that the code has 64bit dependency...
>
> On Wed, Jun 22, 2011 at 18:45, Tomoyuki Chikanaga <naga...
MartinBosslet (Martin Bosslet)
07:53 PM Bug #4919: OpenSSL::SSL::Sesssion#time= に Bignum を渡すと ArgumentError が発生する
報告ありがとうございます。32bit環境で落ちるとか考えてませんでした。。。
Thanks for the report. I was not aware that the code has 64bit dependency...

On Wed, Jun 22, 2011 at 18:45, Tomoyuki Chikanaga <nagachika00@gmail.com> wrote:
>>1) Is it OK if I apply the f...
nahi (Hiroshi Nakamura)
07:53 PM Bug #4919: OpenSSL::SSL::Sesssion#time= に Bignum を渡すと ArgumentError が発生する
報告ありがとうございます。32bit環境で落ちるとか考えてませんでした。。。
Thanks for the report. I was not aware that the code has 64bit dependency...

On Wed, Jun 22, 2011 at 18:45, Tomoyuki Chikanaga <nagachika00@gmail.com> wrote:
>>1) Is it OK if I apply the f...
nahi (Hiroshi Nakamura)
11:48 PM Bug #4923 (Closed): [ext/openssl] test_ssl.rb: test_client_auth fails
Hi,
I was finally able to reproduce this with Fedora 15 32 bit, OpenSSL 1.0.0d.
The error occurs only when running make test-all TESTS="openssl",
if I run test_ssl.rb independently the test succeeds.
Here is the output I get:
...
MartinBosslet (Martin Bosslet)
11:28 PM Bug #4072 (Closed): dRubyで作成したサーバプログラムがsleepしていてもexitしてしまう
これですがおそらく r31482 のあたりで native_cond_wait() が EINTR でリトライするようになったので
直っているのではないかと思います。
手元では ruby 1.9.2dev (2010-05-10 revision 27709) で再現していたのが trunk では起きなくなっていました。
ruby_1_9_2 にもマージ済みなので 1.9.2-head でも同じではないかと思います(未確認ですが)。
というわけでcloseさ...
nagachika (Tomoyuki Chikanaga)
11:04 PM Feature #4805 (Closed): Add X509::Name#hash_old for 0.9.X compat
On Thu, Jun 23, 2011 at 20:54, Martin Bosslet <Martin.Bosslet@googlemail.com> wrote:
>>  For that purpose, algorithm should be fixed so they don't get Digester
> ...
Ah, X509::Name#digest sounds good. I didn't know OCSP impl already us...
nahi (Hiroshi Nakamura)
08:53 PM Feature #4805: Add X509::Name#hash_old for 0.9.X compat
Hiroshi NAKAMURA wrote:
> They're using the hash of name for c_rehash. You see files something
> ...
OK, I see, thanks for the info! X509_NAME_hash(_old) has a special meaning
internally. I checked, there also exists X509_NAME_dige...
MartinBosslet (Martin Bosslet)
10:24 PM Revision ea9c30be (git): * lib/rake/version.rb: Fixed VERSION to work with tool/rbinstall.rb
* bin/rake: Import bin/rake from 0.9.2
* tool/rbinstall.rb (install): Rake::VERSION is now in
lib/rake/version.rb. Fixes `make install`
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@32218 b2dd03c8-39d4-4d8f-98f...
drbrain (Eric Hodel)
10:11 PM Revision d001539a (git): * lib/rake: Import Rake 0.9.2
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@32217 b2dd03c8-39d4-4d8f-98ff-823fe69b080e drbrain (Eric Hodel)
09:04 PM Feature #4918 (Closed): Make all core tests inherit from Test::Unit::TestCase
Benoit Daloze wrote:
> A quick `ack -l --invert-file-match -G 'rdoc|rubygems' MiniTest test` gives:
> ...
Thanks for the analysis, Benoit! As I don't want to fiddle around in other people's domains anyway, I suppose it's fine to agr...
MartinBosslet (Martin Bosslet)
03:29 AM Feature #4918: Make all core tests inherit from Test::Unit::TestCase
On Jun 22, 2011, at 5:41 AM, Benoit Daloze wrote:
> On 22 June 2011 07:46, Martin Bosslet <Martin.Bosslet@googlemail.com> wrote:
>> Some tests for OpenSSL inherited from Minitest::Unit::TestCase instead of
>> Test::Unit::TestCase. To...
drbrain (Eric Hodel)
08:36 PM Bug #4418: OpenSSL::PKey::DH#public_key
Hiroshi NAKAMURA wrote:
> I agree with DH interface is confusing.
Adding to the confusion is that DH implements the PKey interface in OpenSSL (OpenSSL itself, not Ruby's ext/openssl), but it conceptually is not really like the other ...
MartinBosslet (Martin Bosslet)
07:55 PM Bug #4579: SecureRandom + OpenSSL may repeat with fork
I don't understand why /dev/urandom fallback should be removed.
Is your reason the "theoretically vulnerable to a cryptographic attack on the algorithms used by the driver" (from Linux man page)?
akr (Akira Tanaka)
03:53 PM Bug #4579: SecureRandom + OpenSSL may repeat with fork
Hi,

On Thu, Jun 23, 2011 at 08:15, Akira Tanaka <akr@fsij.org> wrote:
>> We should avoid using
>> /dev/urandom every time on the env w/o OpenSSL in the future.
>
> I'd like to say "Please install OpenSSL" for such request.
...
nahi (Hiroshi Nakamura)
08:13 AM Bug #4579: SecureRandom + OpenSSL may repeat with fork
NaHi:
> We should avoid using
> ...
I'd like to say "Please install OpenSSL" for such request.
Cryptographic algorithms should be implemented/maintained by cryptographic experts but I am not a cryptographic expert.
akr (Akira Tanaka)
07:53 PM Bug #3924: Performance bug (in require?)
Hi,

2011/6/20 Jarosław Skrzypek <skrzypek.jarek@gmail.com>:
> You might be also interested in my very short patch: https://gist.github.com/1035322 Basically it reorders conditions to start with fastest ones and execute slower ones o...
nahi (Hiroshi Nakamura)
12:53 PM Bug #3924: Performance bug (in require?)
Hi,

2011/6/23 Hiroshi Nakamura <nakahiro@gmail.com>:
> Anyone can imagine a downside of this? It could not work as expected
> if the result of rb_file_expand_path *changes* during require (adding
> a new file during require s...
mame (Yusuke Endoh)
12:23 PM Bug #3924: Performance bug (in require?)
Hi all,

On Wed, Jun 1, 2011 at 09:14, Urabe Shyouhei <shyouhei@ruby-lang.org> wrote:
>> This process creates many objects, i.e., strings.  Typically,
>> $LOADED_FEATURES are already expanded, so the process is not
>> needed in no...
nahi (Hiroshi Nakamura)
05:11 PM Bug #4922: Bug in Webrick httprequest.rb using multiple proxies and fix
See also: 'Reverse Proxy Request Headers' in http://httpd.apache.org/docs/2.2/en/mod/mod_proxy.html
Be careful when using these headers on the origin server, since they will contain more than one (comma-separated)
value if the or...
nahi (Hiroshi Nakamura)
05:09 PM Bug #4922 (Closed): Bug in Webrick httprequest.rb using multiple proxies and fix
(From [ruby-core:33872])
Hi.
This is my first post to this mailing list, so please tell me, if I posted this the wrong place, or I in any other way should do something different.
I have been playing around with Webrick for some ...
nahi (Hiroshi Nakamura)
04:58 PM Bug #4841: WEBrick threading leads to infinite loop
I guess that WEBrick::Server#{start,stop,shutdown} is not designed to be thread-safe and there's no simple fix for your usage. When I used WEBrick::Server for such purpose, I created my own lock outside of WEBrick::Server instances.
I...
nahi (Hiroshi Nakamura)
03:54 PM Bug #4920: Process.daemon()呼び出しによりタイマースレッドが2つ出来てしまう
直接の原因はこのコミットのようです。
commit afbd5661a0ca041ac818c9e5732911c5db21c9f9
Author: nobu <nobu@b2dd03c8-39d4-4d8f-98ff-823fe69b080e>
Date: Tue Jul 13 12:31:17 2010 +0000
* process.c (rb_daemon): split from proc_daemon.
gi...
kosaki (Motohiro KOSAKI)
03:53 PM Bug #3866: Multipart Form Parsing bug
I take this since Fujioka-san must be busy for the meanwhile.
Can somebody point the new location of http://dev.rubyonrails.org/ticket/10886 ? I once posted a patch related to multipart form boundary parsing (http://blade.nagaokaut.ac...
nahi (Hiroshi Nakamura)
03:45 PM Revision 3fbc9440 (git): * ext/date/date_core.c (c_valid_{julian,gregorian}_p): fixed the range of month.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@32216 b2dd03c8-39d4-4d8f-98ff-823fe69b080e Tadayoshi Funaba
03:20 PM Feature #4824: Provide method Kernel#executed?
The sentence "defines" essentially the terminology:
Yukihiro Matsumoto wrote:
> I agree providing a method to tell whether it is loaded as a library or
^^^^^^^^^
"is loaded"
load...
lazaridis.com (Lazaridis Ilias)
03:15 PM Revision 838af29c (git): * 2011-06-24
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@32215 b2dd03c8-39d4-4d8f-98ff-823fe69b080e svn[bot]
03:15 PM Revision 2e83b823 (git): * ext/date/date_core.c: trivial changes on text.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@32214 b2dd03c8-39d4-4d8f-98ff-823fe69b080e Tadayoshi Funaba
02:27 PM Bug #4237: SSL_shutdown should be called until it returns 0
Thanks for the explanation. I think r30294 (fix for lib/net/smtp.rb) is good. It solved the original problem, right? Of course, ext/openssl should try to shutdown the connection gracefully to the extent possible though.
And the second...
nahi (Hiroshi Nakamura)
12:29 AM Bug #4237: SSL_shutdown should be called until it returns 0
On Wed, Jun 22, 2011 at 11:08:08PM +0900, Hiroshi NAKAMURA wrote:
>
> Issue #4237 has been updated by Hiroshi NAKAMURA.
>
>
> Aaron, I'm sorry for late response, but can you point the original report of this issue? The link 'htt...
tenderlovemaking (Aaron Patterson)
01:56 PM Feature #4921: Remove intern.h
なるほど。
ファイルを削除してしまうと問題があるケースもありえなくはないので、
実際にはruby.hをincludeするだけのファイルにする等を考えています。
naruse (Yui NARUSE)
11:13 AM Feature #4921: Remove intern.h
intern.hは「RubyインタプリタAPI(ruby.h)ではない、メソッド実装とその周辺関数だが、他のファイルから参照されている関数」プロトタイプのために用意したヘッダでした。なし崩し的に公開APIっぽくなりましたが。なくすぶんには反対しませんが、1.9の途中でなくして互換性問題が発生しませんか? matz (Yukihiro Matsumoto)
08:15 AM Feature #4921 (Rejected): Remove intern.h
まず、intern.h って何者なんでしょう。
推測としては internal の意だと思うんですが、その場合 include/ruby にいるのは
よろしくないですし、一方で公開 API っぽいのが名実ともに多い気がします。
思うに 1.9 において、intern.h の中身は include/ruby/ruby.h か、
最近新設された internal.h のどちらかにあるべきで、include/ruby/intern.h は
もう必要ないのではない...
naruse (Yui NARUSE)
01:51 PM Revision bf2e60cd (git): * ext/openssl/ossl_x509name.c: Add X509::Name#hash_old as a wrapper
for X509_NAME_hash_old in OpenSSL 1.0.0. See #4805
* test/openssl/test_x509name.rb (test_hash): Make test pass with
OpenSSL 1.0.0.
* NEWS: Add it.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@32213 b2dd03c8-39d4-4d8f-98ff-823f...
Hiroshi Nakamura
01:14 PM Feature #855: HTTP/1.1 fixes and other enhancements to webrick
r32192 is a fix for No.1. User can set HTTPResponse#chunked = true but it might not be a choice (Some client does not support chunked encoding for example.)
No.3 and No.4 should be discussed in the future...
nahi (Hiroshi Nakamura)
01:03 PM Revision 3e01a8d5 (git): * test/openssl/test_ssl_session.rb: Test parameter bug fixed. 2**31 is not in
a signed long in 32bit long env.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@32212 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
Hiroshi Nakamura
12:41 PM Bug #4658: Minitest - invalid return code when using MiniTest::Unit.after_tests
Just in case a repro comes up, the above code doesn't cover all cases correctly. I'm currently going with:
status = $!.respond_to?(:status) ? $!.status : ($! ? 1 : 0)
zenspider (Ryan Davis)
10:36 AM Revision 544daf1f (git): * ext/openssl/ossl_ssl_session.c (ossl_ssl_session_set_time): Check
argument type with NUM2LONG if the arg is not a Time object.
See #4919.
* ext/openssl/ossl_ssl_session.c (ossl_ssl_session_set_timeout): Check
type with NUM2LONG. Time as an arg is not allowed. See #4919.
* test/openssl/test_ssl_se...
Hiroshi Nakamura
09:44 AM Revision 9fe3a7c2 (git): * 2011-06-23
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_1_8_7@32210 b2dd03c8-39d4-4d8f-98ff-823fe69b080e svn[bot]
09:44 AM Revision 2f50fc74 (git): backported r26281 from ruby_1_8
* lib/webrick/accesslog.rb (WEBrick::AccessLog.format): log parameter
embedding did not work. See #4913.
* test/webrick/test_accesslog.rb: Add for test it.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_1_8_7@32209 b2dd03...
Hiroshi Nakamura
09:20 AM Revision a02504ba (git): * ChangeLog: Fix typo
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@32208 b2dd03c8-39d4-4d8f-98ff-823fe69b080e sorah (Sorah Fukumori)
07:34 AM Feature #4917: `NilClass#to_ary`
Perhaps if an optimization is needed, it could just be adding a nil check to Kernel#Array. headius (Charles Nutter)
02:55 AM Feature #4917 (Rejected): `NilClass#to_ary`
The method `to_ary` is for classes that can be implicitly converted to an Array. This doesn't apply to NilClass.
I'm also highly sceptical as to the actual real life impact of such an optimization.
marcandre (Marc-Andre Lafortune)
07:22 AM Revision 45f164ea (git): * lib/webrick/accesslog.rb: Cosmetic fix of mismatched indentation.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@32207 b2dd03c8-39d4-4d8f-98ff-823fe69b080e Hiroshi Nakamura
04:33 AM Revision b9cbe522 (git): * 2011-06-23
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@32206 b2dd03c8-39d4-4d8f-98ff-823fe69b080e svn[bot]
04:33 AM Revision e6f4c92f (git): * signal.c(ruby_atomic_exchange): Fix definement style.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@32205 b2dd03c8-39d4-4d8f-98ff-823fe69b080e sorah (Sorah Fukumori)
02:12 AM Feature #4910: Classes as factories
I'm not sure I agree with adding `to_proc` to `Class` instances, since it seems questionable that `#new` is what you'd always want to be called. Dodging that debate for now, there is another way to get the result you seek:
```ruby
cl...
headius (Charles Nutter)

06/22/2011

11:08 PM Bug #4237: SSL_shutdown should be called until it returns 0
Aaron, I'm sorry for late response, but can you point the original report of this issue? The link 'http://intertwingly.net/blog/2010/12/07/SQLite3-CorruptException-database-disk-image-is-malformed' looks not related to openssl. Am I misu... nahi (Hiroshi Nakamura)
10:53 PM Bug #4416 (Closed): OpenSSL::SSL::Session#session_new_cb
r32204で、ご提案いただいたとおりの修正を入れました。Rubyオブジェクトからの参照があり、OpenSSLに何を返しても、session_new_cbに渡されたセッションはクリアされないのですから、0や1を返し分けても無意味、なので、OpenSSL側での整合性を取るために、常に0を返して参照数を適切に調整すべき、ということですね。やっと理解しました。ありがとうございました。
結果として、session_new_cbのコールバックについて、「返す値に意味はない」...
nahi (Hiroshi Nakamura)
05:21 PM Bug #4416: OpenSSL::SSL::Session#session_new_cb
この参照追加はRubyオブジェクトからの参照で、Rubyオブジェクトの開放時にSSL_SESSION_freeを呼ぶために必要なんですが、逆に0(Rubyレベルでfalse)を返したときのOpenSSLの挙動がよくわかりませんね。。。うーむ。 nahi (Hiroshi Nakamura)
10:28 PM Bug #4919 (Closed): OpenSSL::SSL::Sesssion#time= に Bignum を渡すと ArgumentError が発生する
This issue was solved with changeset r32203.
Tomoyuki, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.
----------
* ext/openssl/ossl_ssl_session.c: Respect T_BIGNUM time value...
Anonymous
06:45 PM Bug #4919: OpenSSL::SSL::Sesssion#time= に Bignum を渡すと ArgumentError が発生する
Hi, Martin
>1) Is it OK if I apply the fix?
Yes, please apply it. :)
> ...
I can't get this error on Ubuntu 10.4 with openssl(0.9.8k-7ubuntu).
Regards,
nagachika (Tomoyuki Chikanaga)
05:59 PM Bug #4919: OpenSSL::SSL::Sesssion#time= に Bignum を渡すと ArgumentError が発生する
I get the same result for OpenSSL 0.9.8k plus an additional error when running
make test-all -TESTS="openssl"
on revision 32199.
1) Error:
test_connect_and_close(OpenSSL::TestSSL):
OpenSSL::SSL::SSLError: SSL_connect return...
MartinBosslet (Martin Bosslet)
05:34 PM Bug #4919 (Closed): OpenSSL::SSL::Sesssion#time= に Bignum を渡すと ArgumentError が発生する
掲題のような理由で make test-all TESTS="-v openssl/test_ssl_session.rb" を実行すると 1E になります。
1) Error:
test_session(OpenSSL::TestSSLSession):
ArgumentError: unknown type
/opt/ruby-trunk/src/ruby/test/openssl/test_ssl_session.rb:21:in `tim...
nagachika (Tomoyuki Chikanaga)
09:53 PM Feature #4918: Make all core tests inherit from Test::Unit::TestCase
Hello,

On 22 June 2011 07:46, Martin Bosslet <Martin.Bosslet@googlemail.com> wrote:
> Some tests for OpenSSL inherited from Minitest::Unit::TestCase instead of
> Test::Unit::TestCase. To be consistent, all tests should probably...
Eregon (Benoit Daloze)
02:46 PM Feature #4918 (Closed): Make all core tests inherit from Test::Unit::TestCase
Some tests for OpenSSL inherited from Minitest::Unit::TestCase instead of
Test::Unit::TestCase. To be consistent, all tests should probably inherit from
Test::Unit::TestCase (cf. [ruby-core:37275]).
I would scan through all tests in...
MartinBosslet (Martin Bosslet)
08:42 PM Bug #4920 (Closed): Process.daemon()呼び出しによりタイマースレッドが2つ出来てしまう
ささださんとakrさんが発見してくださったのですが、現在 trunkで
$ ./ruby -e 'Process.daemon(true,true); p Dir.entries("/proc/self/task")'
と実行すると、スレッドが3匹います(Linuxで実行してください)。何故かというと Process.daemon()
を契機にタイマースレッドが2つ出来てしまうからです。
原因は以下のコードです
---------------...
kosaki (Motohiro KOSAKI)
05:50 PM Bug #4916 (Assigned): [BUG] Segmentation fault - dyld: lazy symbol binding failed: Symbol not found: _ASN1_put_eoc
MartinBosslet (Martin Bosslet)
05:49 PM Bug #4916: [BUG] Segmentation fault - dyld: lazy symbol binding failed: Symbol not found: _ASN1_put_eoc
Sure! I would put it in openssl_missing.c ?
I'll find out whether there is more than ASN1_put_eoc missing in 0.9.7.
Regards,
Martin
MartinBosslet (Martin Bosslet)
01:38 PM Bug #4916: [BUG] Segmentation fault - dyld: lazy symbol binding failed: Symbol not found: _ASN1_put_eoc
openssl-0.9.7 does not have ASN1_put_eoc. Martin, can you handle this?
Dropping 0.9.7 support could be an option if there're other missing functions hardly replace. Users?
nahi (Hiroshi Nakamura)
01:28 PM Bug #4916 (Closed): [BUG] Segmentation fault - dyld: lazy symbol binding failed: Symbol not found: _ASN1_put_eoc
$ ruby -v -ropenssl -e 'p OpenSSL::OPENSSL_VERSION'
ruby 1.9.3dev (2011-06-22 trunk 32194) [i386-darwin9.8.0]
"OpenSSL 0.9.7l 28 Sep 2006"
$ uname -a
Darwin ... 9.8.0 Darwin Kernel Version 9.8.0: Wed Jul 15 16:55:01 PDT 2009; root:xn...
nahi (Hiroshi Nakamura)
05:46 PM Bug #4879 (Feedback): test_new(OpenSSL::TestPKeyRSA) fails on Win32
I just committed the fix for http://redmine.ruby-lang.org/issues/4885
in revision 32199.
This should solve the issue that was discovered here, and I was also
able to run the tests without Yui's fix.
Could you please confirm that it...
MartinBosslet (Martin Bosslet)
05:41 PM Bug #4885 (Closed): [ext/openssl] Use BIO_reset and ERR_get_error in conjuntion
This issue was solved with changeset r32199.
Martin, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.
----------
* ext/openssl/ossl.h: Introduced OSSL_BIO_reset macro for PEM/D...
Anonymous
03:04 PM Feature #4672 (Closed): [PATCH] openssl: enable SSL_MODE_RELEASE_BUFFERS if available
This issue was solved with changeset r32198.
Eric, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.
----------
* ext/openssl/ossl_ssl.c: Use SSL_MODE_RELEASE_BUFFERS if availab...
Anonymous
02:20 PM Feature #4917 (Rejected): `NilClass#to_ary`
`Kernel#Array`, when passed `nil`, first tries to send `to_ary`, which ends up calling `method_missing`, and then tries to send `to_a`, which finally succeeds. When `Kernel#Array` is used frequently, for example in library/gem code, this... y_feldblum (Jay Feldblum)
01:39 PM Revision dea3113a (git): * ext/openssl/ossl_ssl.c (ossl_sslctx_session_new_cb): Return 0 to
OpenSSL from the callback for SSL_CTX_sess_set_get_cb().
Returning 0 means to OpenSSL that the the session is still valid
(since we created Ruby Session object) and was not freed by us with
SSL_SESSION_free(). Call SSLContext#remov...
Hiroshi Nakamura
01:28 PM Revision 8d836a15 (git): * ext/openssl/ossl_ssl_session.c: Respect T_BIGNUM time values. Patch by
Tomoyuki Chikanaga.
[ Ruby 1.9 - Bug #4919 ] [ruby-dev:43869]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@32203 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
MartinBosslet (Martin Bosslet)
12:30 PM Revision dc8f58f6 (git): * ext/socket/depend (SOCK_HEADERS): use $(top_srcdir) instaed of
$(topdir). sorry!
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@32202 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
kosaki (Motohiro KOSAKI)
11:04 AM Bug #3817: current ruby-openssl impl wrongly utilizes CRYPTO_EX_DATA in X509_STORE
Moved target version to 1.9.x nahi (Hiroshi Nakamura)
11:00 AM Revision be953b4d (git): * cont.c (cont_capture): add volatile.
On clang -O, it is needed to avoid the optimization.
With this and llvm/clang's recent fix, clang 3.0 can
build ruby-trunk with -O option.
* cont.c (cont_capture): use for-loop.
* array.c (rb_ary_each): add volatile and use it.
* ...
naruse (Yui NARUSE)
09:24 AM Revision d8af9c85 (git): * ext/openssl/ossl_ssl.c (ossl_sslctx_session_remove_cb):
OpenSSL::SSL::SSLContext#session_remove_cb was broken. It wrongly
tried to call the session_*new*_cb callback.
* test/openssl/test_ssl_session.rb (class OpenSSL): Test it.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@32200 b2dd...
Hiroshi Nakamura
08:41 AM Revision 26cb830d (git): * ext/openssl/ossl.h: Introduced OSSL_BIO_reset macro for PEM/DER
fallback scenarios.
* ext/openssl/ossl_pkey_dsa.c
* ext/openssl/ossl_x509req.c
* ext/openssl/ossl_pkey_rsa.c
* ext/openssl/ossl_pkey_ec.c
* ext/openssl/ossl_ssl_session.c
* ext/openssl/ossl_x509crl.c
* ext/openssl/ossl_pkey.c
* ext/open...
MartinBosslet (Martin Bosslet)
07:54 AM Bug #4658: Minitest - invalid return code when using MiniTest::Unit.after_tests
I can't replicate with ruby 1.8 or 1.9.2:
require 'rubygems'
gem 'minitest' # ensure latest gem in 1.9
require 'minitest/autorun'
class TestX < MiniTest::Unit::TestCase
def test_x
flunk
en...
zenspider (Ryan Davis)
06:59 AM Bug #4814: minitest 2.2.x and test/unit do not get along
mail-to-rubymine truncated my response... Fixed:
I'm still broken:
7107 % svn st
7107 % svn info io.c | grep Revision
Revision: 31902
7108 % make -j 4 ruby19
make: `ruby19' is up to date.
7109 % make TESTS="-v testunit/test_parallel.rb...
zenspider (Ryan Davis)
06:35 AM Bug #4821: Random Segfaults (in start_thread?)
Did some further tests to find out where this (for me) hard to understand segfaults came from. I still don't know the root cause, but now I do know that using devise together with meta_search (1.1.0.pre) resulted in the segfaults. Disabl... corneverbruggen (Corné Verbruggen)
06:04 AM Revision 41c517d1 (git): * ext/openssl/ossl_ssl.c: Use SSL_MODE_RELEASE_BUFFERS if available.
Thanks, Eric Wong, for providing the patch.
[ Ruby 1.9 - Feature #4672 ] [ruby-core:36127]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@32198 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
MartinBosslet (Martin Bosslet)
05:53 AM Bug #4914: Array#index fails when used in if statement assignment
Ruby parses your code like this:

if i = (a.index(k.to_sym) && k.to_s =~ /b/)

You can fix this by using "and" or explicit parenthesis:

if i = a.index(k.to_sym) and k.to_s =~ /b/
if (i = a.index(k.to_sym)) && k.to_s =~ /b/...
judofyr (Magnus Holm)
05:39 AM Bug #4914 (Rejected): Array#index fails when used in if statement assignment
not a bug. run the following:
a = [:a, :b, :c]
for k in 'a'..'c'
if i = a.index(k.to_sym) && k.to_s =~ /b/
puts i
end
end
for k in 'a'..'c'
if i = (a.index(k.to_sym) && k.to_s =~ /b/)
puts i
end
end
for k...
matz (Yukihiro Matsumoto)
05:37 AM Bug #4914: Array#index fails when used in if statement assignment
It "works" for me if you change the `&&` to `and`; so I think it's a precedence issue you're facing here.
I think this blog post here has some good examples which I think directly apply to your case: http://blog.jayfields.com/2007/08/...
mfn (Markus Fischer)
05:28 AM Bug #4914 (Rejected): Array#index fails when used in if statement assignment
cat /etc/issue: Ubuntu 11.04
rvm -v: rvm 1.6.2
rvm 1.9.2, ruby -v: ruby 1.9.2p180 (2011-02-18 revision 30909) [x86_64-linux]
Also tested with: rvm 1.9.2-head, ruby -v: ruby 1.9.2p274 (2011-06-06 revision 31932) [x86_64-linux]
Test ...
bterkuile (Benjamin ter Kuile)
05:48 AM Revision 914a4a02 (git): * test/openssl/test_buffering.rb
* test/openssl/test_pkcs12.rb: Inherit from Test::Unit::TestCase
instead of Mintest::Unit::TestCase. [ruby-core:37275]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@32197 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
MartinBosslet (Martin Bosslet)
03:43 AM Revision bda678dc (git): * ext/openssl/ossl_ssl_session.c (ossl_ssl_session_to_der):
OpenSSL::SSL::Session#to_der was broken. Fix buffer handling.
* test/openssl/test_ssl_session.rb (test_session): Test it.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@32196 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
Hiroshi Nakamura
03:40 AM Revision 02ab6d95 (git): * test/openssl/test_ssl_session.rb: Split out SSL::Session related
tests from test_ssl.rb
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@32195 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
Hiroshi Nakamura
02:47 AM Bug #655 (Closed): Query part lost when using Net::HTTP.post_form function
mathew: Interesting read. Thanks. I decided to not decide and let users choose, by allowing to include query part as a request URI. nahi (Hiroshi Nakamura)
01:38 AM Bug #4122 (Closed): test_x509store.rbのtest_set_errorsが失敗する
r32189
* test/openssl/test_x509store.rb (test_set_errors): Redhat is
distributing a patched version of OpenSSL that allows multiple CRL
for a key (multi-crl.patch.) Make test pass on such env. See #4122,
...
nahi (Hiroshi Nakamura)

06/21/2011

08:28 PM Bug #4444 (Closed): Windowsプラットフォームでtest_parallel.rbがエラー
動くようになっているので、closeします。usaさん++ kosaki (Motohiro KOSAKI)
07:55 PM Feature #1103 (Closed): Ruby used for webrick cgi should be configurable
r26299 overrides RbConfig.ruby at test/ruby/envutil.rb for test environment. I think that fix is enough for the original intent of the patch by Aaron. Sorry for this result. nahi (Hiroshi Nakamura)
07:03 PM Bug #4912 (Feedback): Segmentation fault while HTTPS request
Hi,
thank you for reporting. but we need some additional informations to fix.
Could you provide the following things?:
* which openssl are you using?
* crash log under ~/Library/Logs/CrashReporter
* is same issue happen withou...
sorah (Sorah Fukumori)
06:51 PM Bug #4912 (Rejected): Segmentation fault while HTTPS request
Hi,
I'm throwing a SOAP request to a third party using soap4r (git://github.com/noeticpenguin/soap4r-noeticpenguin.git) and I'm getting this stacktrace. It's weird because it seems some kind of incompatibility with another gems, but i...
juandebravo (Juan de Bravo)
06:22 PM Revision 40508ede (git): * ext/psych/lib/psych/visitors/to_ruby.rb: Fix cyclic references of
objects. Thanks to CvX for reporting the bug and a test case.
* test/psych/test_object.rb: test for cyclic object references.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@32194 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
tenderlovemaking (Aaron Patterson)
06:04 PM Revision 7c5fdec0 (git): fix ambiguous argument warnings in test/psych/test_nil.rb
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@32193 b2dd03c8-39d4-4d8f-98ff-823fe69b080e tenderlovemaking (Aaron Patterson)
05:44 PM Revision 800c313b (git): * lib/net/http.rb (Net::HTTP.post_form): Do not ignore query part of
the given URI to post. See #655.
* test/net/http/test_http.rb, test/net/http/utils.rb: Test it.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@32192 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
Hiroshi Nakamura
04:34 PM Revision 7d112260 (git): * Add ref to tickets.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@32191 b2dd03c8-39d4-4d8f-98ff-823fe69b080e Hiroshi Nakamura
04:33 PM Revision 0fd46532 (git): * 2011-06-22
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@32190 b2dd03c8-39d4-4d8f-98ff-823fe69b080e svn[bot]
04:33 PM Revision 5e8aa0a1 (git): * test/openssl/test_x509store.rb (test_set_errors): Redhat is
distributing a patched version of OpenSSL that allows multiple CRL
for a key (multi-crl.patch.) Make test pass on such env.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@32189 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
Hiroshi Nakamura
02:05 PM Bug #3827: ext/readline can't handle cursor keys and cp932 chars
r32181にてパッチをコミットしました。お手数をおかけしますが、確認いただけますでしょうか。 kouji (Kouji Takao)
11:39 AM Bug #3827: ext/readline can't handle cursor keys and cp932 chars
Koichi Sasada wrote:
> 高尾さん
> ...
こちらで試せるようなWin32環境がありません。一旦取り込みますので、試してみていただけないでしょうか。 > Akio Tajima さん
kouji (Kouji Takao)
01:20 PM Feature #3375 (Closed): --disable-libedit to disable libedit
This issue was solved with changeset r32179.
Shyouhei, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.
----------
* ext/readline/extconf.rb: fixed bug, specify --disable-libed...
kouji (Kouji Takao)
11:34 AM Feature #3375: --disable-libedit to disable libedit
=begin
対応が遅くなりました。
以下の修正を入れたいと思います。
動作確認をしてからコミットします。
Index: ext/readline/extconf.rb
===================================================================
--- ext/readline/extconf.rb (revision 32178)
+++ ext/readline/extco...
kouji (Kouji Takao)
12:58 PM Revision 4ce15814 (git): * lib/webrick/httpresponse.rb (HTTPResponse#setup_header): Close
HTTP/1.1 connection when returning an IO object as response body
without setting HTTPResponse#chunked to true. See #855 no.1.
* test/webrick/test_httpserver.rb: Test it.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@32188 b2dd03...
Hiroshi Nakamura
12:31 PM Revision 908baefe (git): * internal.h: move rb_thread_io_blocking_region() declaration
from intern.h to internal.h. It's still experimental API and
need more discussion. [ruby-dev:43698]
* include/ruby/intern.h: ditto.
* ext/socket/rubysocket.h: include internal.h.
* ext/socket/depend: add internal.h dependency.
* ext/s...
kosaki (Motohiro KOSAKI)
11:52 AM Revision b9d9ea62 (git): revert r32183
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@32186 b2dd03c8-39d4-4d8f-98ff-823fe69b080e kosaki (Motohiro KOSAKI)
11:42 AM Revision 5b16ddf5 (git): * ext/date/date_core.c (datetime_s_*): canonicalize 24 o'clock.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@32185 b2dd03c8-39d4-4d8f-98ff-823fe69b080e Tadayoshi Funaba
11:29 AM Revision c9aef84c (git): add ML ref to ChangeLog
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@32184 b2dd03c8-39d4-4d8f-98ff-823fe69b080e kosaki (Motohiro KOSAKI)
10:57 AM Revision 97beed07 (git): * internal.h: move rb_thread_io_blocking_region() declaration
from intern.h to internal.h. It's still experimental API and
need more discussion.
* include/ruby/intern.h: ditto.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@32183 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
kosaki (Motohiro KOSAKI)
10:47 AM Revision cb138bba (git): * test/ruby/test_thread.rb (TestThread#test_priority): enable
this test again. Current GVL respect thread priority rather
than past.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@32182 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
kosaki (Motohiro KOSAKI)
10:33 AM Bug #4911 (Closed): timer_thread_function() が thead unsafe
どうして、これを先月気づかなかったのだろう。という罪悪感があるのですが、
target 1.9.x で起票します。
timer_thread_function()で vm->running_thread にアクセスするのは
thread unsafe な気がします
0.スレッドAがrunning_threadである
1.タイマースレッドがvm->running_threadをレジスタにのせる
(レジスタにスレッドAのアドレスがのっかる)
2...
kosaki (Motohiro KOSAKI)
09:08 AM Bug #4875: Segmentation fault in http.rb
I get this any time I try any sort of HTTP call. There is some suggestion that it might relate to the use of the 'pg' gem for Postgres, see first few results:
http://www.google.com/search?q=http.rb+678+pg
/Users/abailey/.rvm/rubi...
jeromewilson (Jerome Wilson)
05:39 AM Feature #4891 (Assigned): Vector#normalize
Sure.
I have to merge in my announced changes to Matrix & Vector in 1.9.3 as soon as I get the time, so I could include this too. Are we after the official feature freeze yet (I don't see the 1.9.3 branch)?
marcandre (Marc-Andre Lafortune)
04:30 AM Revision e49f8909 (git): * ext/readline/readline.c (readline_getc): applied a patch in
#3827 by by Akio Tajima <artonx AT yahoo.co.jp>. (see #3827)
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@32181 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
kouji (Kouji Takao)
04:20 AM Revision d2e61d22 (git): * 2011-06-21
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@32180 b2dd03c8-39d4-4d8f-98ff-823fe69b080e svn[bot]
04:20 AM Revision 1daac53c (git): * ext/readline/extconf.rb: fixed bug, specify --disable-libedit
then disable libedit, does not specify then check readline and
libedit if failed checking readline. (fixes #3375)
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@32179 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
kouji (Kouji Takao)
01:53 AM Bug #4909: trapハンドラは再入されてはいけないのではないか?
 ささだです.

(2011/06/21 1:25), Masaya TARUI wrote:
> 同意します。
> というか、いままでmaskされてないと知らなかった。

 mask するための新しい仕様が必要になると思いますが,さてこれを 1.9.3 に
入れますか? それとも,trap 中はどんな trap を再入禁止?

--
// SASADA Koichi at atdot dot net
ko1 (Koichi Sasada)
01:29 AM Bug #4909: trapハンドラは再入されてはいけないのではないか?
同意します。
というか、いままでmaskされてないと知らなかった。

2011年6月20日18:46 Motohiro KOSAKI <kosaki.motohiro@gmail.com>:
>
> Issue #4909 has been reported by Motohiro KOSAKI.
>
> ----------------------------------------
> Bug #4909: trapハンドラは再入さ...
tarui (Masaya Tarui)
01:37 AM Bug #4821: Random Segfaults (in start_thread?)
I also get the segfault when running "rails generate" and when running tests. So it does not seem to be solely a problem with webrick? Maybe the causes are multiple? corneverbruggen (Corné Verbruggen)

06/20/2011

11:29 PM Feature #4910: Classes as factories
Benoit Daloze wrote:
> Hello,
> ...
No, it was meant exactly as stated. Advantage is that you can provide parameters to #new if needed while mapping the parameterless call of `to_proc` easily to the parameterless call of `Class#new`.
...
rklemme (Robert Klemme)
10:08 PM Feature #4910: Classes as factories
Hello,
Robert Klemme wrote:
> I suggest to add these two to class Class:
> ...
Did you want to mean:
```ruby
def to_proc
lambda { |*args| new(*args) } # or maybe lambda { |args| new(*args) }
end
```
?
`#to_proc` is call...
Eregon (Benoit Daloze)
08:50 PM Feature #4910 (Rejected): Classes as factories
I suggest to add these two to class `Class`:
```ruby
class Class
alias call new
def to_proc(*args)
lambda {|*a| new(*args)}
end
end
```
Then we can use class instances where blocks are needed and can easily use t...
rklemme (Robert Klemme)
11:23 PM Feature #4893: Literal Instantiation breaks Object Model
On Fri, Jun 17, 2011 at 5:12 PM, Lazaridis Ilias <ilias@lazaridis.com> wrote:
> "Object Model" as in
>
>  * Design and implementation of a programming language's OO behaviour (classes, object, inheritance, mixin,  methods, attributes...
aprescott (Adam Prescott)
07:45 PM Feature #4672 (Assigned): [PATCH] openssl: enable SSL_MODE_RELEASE_BUFFERS if available
Excellent result. It looks like a gift from Tor project. There's no reason I can imagine not to apply this. Please apply this.
I think it's OK to commit this w/o writing a test. :)
nahi (Hiroshi Nakamura)
07:10 PM Feature #3375: --disable-libedit to disable libedit
わたしは構いませんが高尾さん的にはどうなんでしょう。
ていうか、#1823 #3827 #4635 が放置されてて何とかしてくれって感じなんですが
naruse (Yui NARUSE)
06:36 PM Feature #3375: --disable-libedit to disable libedit
これ結局自分が間違ってたと思うんですが、どうすればいいんでしょう。勝手に直していい? shyouhei (Shyouhei Urabe)
06:48 PM Bug #4419 (Closed): ext/openssl のコメントが正しくない
ありがとうございました。r32176でパッチを当てました。 nahi (Hiroshi Nakamura)
06:46 PM Bug #4909 (Closed): trapハンドラは再入されてはいけないのではないか?
以下のプログラムは
if intrap == 1
raise "trap nested"
end
が真になってしまって例外終了してしまうのですが、これは起きてはいけないのではないでしょうか。
以下の二点が問題だと考えます。
1)このプログラムのようにシグナルを連続して配送されるとスタックオーバーフローを引き起こせる
2)Rubyレベルでsigprocmask()に相当するシグナルブロッキング操作が提供されていないため、
...
kosaki (Motohiro KOSAKI)
06:23 PM Bug #4418: OpenSSL::PKey::DH#public_key
I agree with DH interface is confusing.
* DH#p ... DH parameter p
* DH#g ... DH parameter g
* DH#public_key ... DH parameter (DHParameterSpec in Java)
* DH#priv_key ... private value: S
* DH#pub_key ... exchange value: g^S mo...
nahi (Hiroshi Nakamura)
06:04 PM Bug #4908 (Rejected): #force_encoding(nil) fails on Windows
The feature is changed on 1.9.2; now nil is not a valid argument. naruse (Yui NARUSE)
04:59 PM Bug #4908 (Rejected): #force_encoding(nil) fails on Windows
I read from The Ruby Programming Language that nil can be specified as "binary" or "ascii-8bit".
The book give a sample code on Page 61:
text = stream.readline.force_encoding("utf-8")
bytes = text.dup.force_encoding(nil) # nil e...
yimutang (Joey Zhou)
06:01 PM Bug #3924: Performance bug (in require?)
You might be also interested in my very short patch: https://gist.github.com/1035322 Basically it reorders conditions to start with fastest ones and execute slower ones only if needed. Here is also some description: http://www.lunarlogi... jskrzypek (Jarosław Skrzypek)
04:54 PM Bug #3869 (Closed): Logger#log does not handle or escape new-line characters.
Sorry for keeping this ticket open.
I thought
logger.info ["User-input: %{input}", input: data]
looks good, though I like
logger.info "User-input: %{input}", input: data
better. But I cannot find the compatible way to ...
nahi (Hiroshi Nakamura)
02:28 PM Feature #4142: multipart/form-data for net/http
すいませんruby-devだった。orz
成瀬さん、NEWSになんか書きませんか。
nahi (Hiroshi Nakamura)
02:27 PM Feature #4142 (Open): multipart/form-data for net/http
Naruse-san, would you please add an explanation of this feature to NEWS file? nahi (Hiroshi Nakamura)
02:23 PM Bug #4421: [ext/openssl] Fix RSA public key encoding
On Mon, May 16, 2011 at 11:47, NARUSE, Yui <naruse@airemix.jp> wrote:
> I have another comment: nahi and emboss's commit message has extra
> header and indent like:
>
> Mon May 16 05:13:20 2011  Martin Bosslet  <Martin.Bosslet@goo...
nahi (Hiroshi Nakamura)
01:55 PM Revision 1d110a14 (git): * process.c (before_exec): use sig_do_nothing instead of SIG_DFL
for avoiding a race.
* process.c (sig_do_nothing): new function.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@32178 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
kosaki (Motohiro KOSAKI)
01:20 PM Bug #4037 (Rejected): Net/http keep alive bug
Sorry for late reply, and marking it as 'Rejected'. I'm just want to say that 'it's not a bug'. (We should have suitable label in the future.)
net/http requires to set 'use_ssl' flag manually before starting a connection.
requir...
nahi (Hiroshi Nakamura)
12:32 PM Revision 2552e428 (git): * thread_pthread.c (thread_timer): rename timeout_10ms to
time_quantum. it's no longer 10ms.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@32177 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
kosaki (Motohiro KOSAKI)
12:23 PM Feature #4805: Add X509::Name#hash_old for 0.9.X compat
Hi,

On Thu, Jun 9, 2011 at 06:14, Martin Bosslet
<Martin.Bosslet@googlemail.com> wrote:
> I think your patch is good! But there is one thing I don't like
> about OpenSSL itself here - why do they hardcode the digest algorithm
> i...
nahi (Hiroshi Nakamura)
11:29 AM Bug #4875: Segmentation fault in http.rb
Adding '-r openssl' would affect autloading but the location where an exception thrown is OpenSSL::SSL::SSLSocket#connect.
Does the SEGV always happens for you? It would help to show us a minimized reproducible code or concrete steps ...
nahi (Hiroshi Nakamura)
11:06 AM Feature #4907 (Rejected): enumerable#permutation and combination
Hello
Methods permutation and combination are defined for array but it make more sense to define them for enumerable.
Here is sample implementation which for simplicity works only with blocks.
Note that implementation works lazily.
...
neleai (Ondrej Bilka)
09:48 AM Revision c1028212 (git): * ext/openssl/ossl_cipher.c, ext/openssl/lib/openssl/cipher.rb:
Documentation fix by Ippei Obayashi. See #4419.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@32176 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
Hiroshi Nakamura
06:48 AM Revision 15e7e472 (git): * lib/webrick/cookie.rb (WEBrick::Cookie.parse): Revert r31228.
r31228 was for allowing the 'Cookie:' header which did not have no
SP after ';' for separating cookie-pairs but RFC6265 requires single
SP after ';' there. We allow multiple SPs here for compatibility
with older WEBrick version.
...
Hiroshi Nakamura
01:00 AM Revision 3fc0e0c1 (git): * 2011-06-20
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@32174 b2dd03c8-39d4-4d8f-98ff-823fe69b080e svn[bot]
01:00 AM Revision 2190c953 (git): Allow "--- \n" as a yaml dumped result for nil.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@32173 b2dd03c8-39d4-4d8f-98ff-823fe69b080e naruse (Yui NARUSE)
12:21 AM Feature #4906: rb_w32_add_socket / rb_w32_remove_socket
Thank you Greg for the work on this.
I've assigned to Mr. Nobuyoshi Nakada, hoping this can be cleared out as a w32 API specific and be allowed in 1.9.3.
I don't think Yugui's schedule has been followed (or at least was delayed) so...
luislavena (Luis Lavena)

06/19/2011

10:35 PM Feature #4906 (Closed): rb_w32_add_socket / rb_w32_remove_socket
It is currently not possible to use an externally created
SOCKET on Windows with ruby 1.9. This bug is described in
detail here ( http://www.ruby-forum.com/topic/869239 ). In
the meantime, a small pair of functions would allow gem
a...
ghazel (Greg Hazel)
11:53 AM Feature #4903 (Closed): Documentation for lib/test/unit/assertions.rb
Documentation for the assertions in lib/test/unit/assertions.rb jsc (Justin Collins)
04:32 AM Revision ee809936 (git): * NEWS: Introduce --hide-skip on test/unit.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@32172 b2dd03c8-39d4-4d8f-98ff-823fe69b080e sorah (Sorah Fukumori)
01:23 AM Feature #4824: Provide method Kernel#executed?
On Wed, Jun 15, 2011 at 4:24 PM, Gregory Brown
<gregory.t.brown@gmail.com> wrote:
> Lastly, I think `__MAIN__` is reasonable if a method is not to be used,
> though it feels a bit too magic for me.

I'll repeat what others hav...
headius (Charles Nutter)
01:12 AM Revision 4c438fd0 (git): * lib/test/unit/parallel.rb: Override Test::Unit::TestCase#on_parallel_worker?
only when $0 == __FILE__.
* lib/test/unit/parallel.rb: Run Test::Unit::Worker.run only when
$0 == __FILE__.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@32171 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
sorah (Sorah Fukumori)
12:42 AM Bug #4902 (Closed): IO#each counts lineno
The docs for IO#lineno state that:
lineno counts the number of times gets is called, rather than the number of newlines encountered.
However, IO#each also increases the lineno variable. Running this piece of code on a text file will ...
bt (Bernd Homuth)

06/18/2011

03:00 PM Revision 12efda14 (git): * 2011-06-19
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@32170 b2dd03c8-39d4-4d8f-98ff-823fe69b080e svn[bot]
03:00 PM Revision 6effaa9a (git): * io.c (fill_cbuf): finish reading at EOF, and the readconv has
been cleared by another thread while io_fillbuf() is waiting at
select(). a patch in [ruby-core:37197] by Hiroshi Shirosaki
<h.shirosaki AT gmail.com>. fixed #3840
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@32169 b2dd03c8-3...
nobu (Nobuyoshi Nakada)
12:39 PM Revision e623ceb9 (git): * thread_pthread.c: remove GVL_DEBUG
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@32168 b2dd03c8-39d4-4d8f-98ff-823fe69b080e kosaki (Motohiro KOSAKI)
12:32 PM Revision ef86308a (git): * vm.c, vm_core.h (rb_vm_stack_to_heap): remove const.
It makes compilations warnings.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@32167 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
kosaki (Motohiro KOSAKI)
12:05 PM Bug #4803 (Closed): RCLASS_SUPER won't compile for C extensions as of revision 31627
This issue was solved with changeset r32162.
Daniel, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.
----------
* include/ruby/backward/classext.h: for evil gems. fixed #4803
nobu (Nobuyoshi Nakada)
09:56 AM Revision 43681041 (git): * vm.c, vm_core.h (rb_vm_stack_to_heap): fix "const" place.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@32166 b2dd03c8-39d4-4d8f-98ff-823fe69b080e ko1 (Koichi Sasada)
09:53 AM Bug #4895: ruby crashes reproducibly on very simple rails project (rails v3.1.0rc4)
>  -- C level backtrace information -------------------------------------------
>  /home/thomas/.rvm/rubies/ruby-1.9.2-p180/lib/libruby.so.1.9(rb_vm_bugreport+0x72) [0xb76e5ac2]
>  /home/thomas/.rvm/rubies/ruby-1.9.2-p180/lib/libru...
kosaki (Motohiro KOSAKI)
09:33 AM Bug #4895 (Third Party's Issue): ruby crashes reproducibly on very simple rails project (rails v3.1.0rc4)
kosaki (Motohiro KOSAKI)
04:11 AM Bug #4895 (Third Party's Issue): ruby crashes reproducibly on very simple rails project (rails v3.1.0rc4)
=begin
((%rails server%)) crashes reproducable on my system, on a very simple rails v3.1.0rc4 project (attached). The project is only one scaffold plus two validations.
This is on a Debian squeeze system; ruby was installed via rvm.
...
tbleher (Thomas Bleher)
08:33 AM Feature #4897: Define Math::TAU and BigMath.TAU. The "true" circle constant, Tau=2*Pi. See http://tauday.com/
See http://tauday.com/
Edit: particularly http://tauday.com/tau-manifesto
sbaird (Simon Baird)
08:28 AM Feature #4897: Define Math::TAU and BigMath.TAU. The "true" circle constant, Tau=2*Pi. See http://tauday.com/
Direct link to the gist containing my patch:
https://gist.github.com/1029552
Edit: mention this is a patch (pluid61's patch is better though)
sbaird (Simon Baird)
08:26 AM Feature #4897: Define Math::TAU and BigMath.TAU. The "true" circle constant, Tau=2*Pi. See http://tauday.com/
Sorry for the too long title. Don't know how to edit. Suggested title:
Define Math::TAU and BigMath.TAU. The "true" circle constant, Tau=2*Pi
sbaird (Simon Baird)
07:46 AM Feature #4897 (Rejected): Define Math::TAU and BigMath.TAU. The "true" circle constant, Tau=2*Pi. See http://tauday.com/
Firstly please read the Tau Manifesto at http://tauday.com/ . It's quite long but essential to understanding why this is a good idea.
Here is a patch on trunk that implements this:
http://simonbaird.blogspot.com/2011/06/tau-in-ruby.h...
sbaird (Simon Baird)
08:26 AM Revision 5ed8c08a (git): * eval.c, hash.c, load.c, proc.c, range.c, thread.c, time.c: don't
declare internal functions.
* internal.h, vm_core.h: declare internal functions.
* array.c: include internal.h.
* common.mk: update dependency for array.o.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@32165 b2dd03c8-39d4-4d8f...
akr (Akira Tanaka)
06:41 AM Feature #4896 (Closed): Add newpad() support to Curses
The ruby curses library lacks support for scrolling regions via newpad(). This patch adds support for newpad() as a subclass of Curses::Window.
May I apply it?
drbrain (Eric Hodel)
04:41 AM Revision bc46292c (git): * internal.h: declarations declared in include/ruby/*.h removed.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@32164 b2dd03c8-39d4-4d8f-98ff-823fe69b080e akr (Akira Tanaka)
03:49 AM Revision 7da3ea81 (git): * method.h, internal.h iseq.h: declare internal functions.
* compile.c, eval.c, iseq.c, object.c, parse.y, proc.c, process.c,
thread.c, vm.c, vm_eval.c, vm_insnhelper.c, vm_method.c: don't
declare internal functions.
Note that rb_method_entry_eq() is defined in vm_method.c but
there was...
akr (Akira Tanaka)
03:05 AM Revision 19f38667 (git): * include/ruby/backward/classext.h: for evil gems. fixed #4803
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@32162 b2dd03c8-39d4-4d8f-98ff-823fe69b080e nobu (Nobuyoshi Nakada)
02:32 AM Revision 3b59f6c5 (git): forgot to commit.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@32161 b2dd03c8-39d4-4d8f-98ff-823fe69b080e akr (Akira Tanaka)
02:12 AM Revision 8a533011 (git): * common.mk: update dependencies.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@32160 b2dd03c8-39d4-4d8f-98ff-823fe69b080e akr (Akira Tanaka)
02:10 AM Revision 8192693c (git): * io.c: supress warnings.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@32159 b2dd03c8-39d4-4d8f-98ff-823fe69b080e akr (Akira Tanaka)
01:54 AM Revision afd7e466 (git): * internal.h: declare more internal functions.
* iseq.h (rb_method_get_iseq): declared.
* compile.c, eval.c, eval_error.c, iseq.c, parse.y, proc.c, range.c,
ruby.c, time.c, util.c, vm.c: don't declare internal functions.
* eval.c, parse.y, thread_pthread.c: non-existing function ...
akr (Akira Tanaka)
01:12 AM Feature #4893: Literal Instantiation breaks Object Model
Yukihiro Matsumoto wrote:
> Your request has been too vague for me.
> ...
I don't think so:
"Object Model" as in
* Design and implementation of a programming language's OO behaviour (classes, object, inheritance, mixin, meth...
lazaridis.com (Lazaridis Ilias)
01:12 AM Feature #4893: Literal Instantiation breaks Object Model
deleted by myself, duplicate post lazaridis.com (Lazaridis Ilias)
12:23 AM Bug #3137: complex.rb changes exceptions of Math
> グローバルなメソッドを定義し, かつ名前が悪いってことです?

俺も Object とか Numeric にごっそりメソッドを確保しておこうかなあ、他所
で取られる前に。
tadf (tadayoshi funaba)
12:23 AM Bug #3137: complex.rb changes exceptions of Math
> グローバルなメソッドを定義し, かつ名前が悪いってことです?

俺も Object とか Numeric にごっそりメソッドを確保しておこうかなあ、他所
で取られる前に。
tadf (tadayoshi funaba)
 

Also available in: Atom