Project

General

Profile

Activity

From 04/11/2011 to 04/17/2011

04/17/2011

07:05 PM Bug #4583: trace doesn't work for methods set up by attr_*
=begin
Added test for 1.9.2-head, but changes to vm_eval.c didn't make it work. Next suspect: vm_insnhelper.c
Actually, I have no clue what I'm doing :)
=end
QaDeS (Michael Klaus)
04:17 PM Bug #4583: trace doesn't work for methods set up by attr_*
=begin
Thanks for the hint on reporting properly. Here's a working patch for 1.8.7
=end
QaDeS (Michael Klaus)
12:34 PM Bug #4583 (Assigned): trace doesn't work for methods set up by attr_*
=begin
Hi Michael,
Interesting report. Assigned to ko1.
=end
kosaki (Motohiro KOSAKI)
11:50 AM Bug #4583: trace doesn't work for methods set up by attr_*
=begin
See also issue #4584 for Ruby 1.8.
=end
QaDeS (Michael Klaus)
11:44 AM Bug #4583 (Rejected): trace doesn't work for methods set up by attr_*
=begin
Methods set up with (({attr_accessor})) or alike are not traceable:
class Foo
attr_writer :bar
def baz=(value)
@baz = value
end
end

set_trace_func proc{|*args| puts args.inspect}
@foo = Foo.new # will be tr...
QaDeS (Michael Klaus)
02:42 PM Bug #4582: date_tmx.h file missing
=begin
The file has appeared - thanks!
=end
fluido (Carlo Prelz)
05:04 AM Bug #4582 (Closed): date_tmx.h file missing
=begin
I just downloaded SVN 31300: directory ext/date has appeared, but one include file seems to be missing.
File is called date_tmx.h and is required by date_strftime.c (line 51)
(ruby -v below is from debian distribution, sinc...
fluido (Carlo Prelz)
12:53 AM Feature #4528 (Closed): [PATCH] ext/io/nonblock: avoid unnecessary fcntl F_SETFL calls
=begin
r31238.
=end
kosaki (Motohiro KOSAKI)

04/16/2011

11:48 PM Bug #4581 (Closed): Documentation for Process.times is outdated
=begin
The code sample for Process.times only mentions utime and stime, even though there's cutime and sctime as well. There's also a reference to "page 388", presumably of the first edition of the Pickaxe. Should that be updated or del...
agrimm (Andrew Grimm)
08:14 PM Revision 1891d8dd (git): added date_tmx.h
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@31301 b2dd03c8-39d4-4d8f-98ff-823fe69b080e Tadayoshi Funaba
03:22 PM Revision 8459dc63 (git): * 2011-04-17
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@31300 b2dd03c8-39d4-4d8f-98ff-823fe69b080e svn[bot]
03:22 PM Revision 2b6ab9bf (git): * ext/date/date_{core,strftime}.c: use struct tmx instead of vtm.
* ext/date/date_tmx.h: new.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@31299 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
Tadayoshi Funaba
01:43 PM Revision 531dfb40 (git): typo
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@31298 b2dd03c8-39d4-4d8f-98ff-823fe69b080e Tadayoshi Funaba
01:26 PM Revision 10ce57ea (git): * ext/date/date_strftime.c (date_strftime_wo_timespec): changed
the way of validation of locale modifiers.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@31297 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
Tadayoshi Funaba
01:23 PM Bug #4579: SecureRandom + OpenSSL may repeat with fork
=begin
Hi

> Motohiro: I don't know you're serious or not about using pthread_atfork(), we should ask to change OpenSSL's "1 time initialization by RAND_poll() per process when using built-in MD based RPNG engine" strategy if we rea...
kosaki (Motohiro KOSAKI)
07:37 AM Bug #4579: SecureRandom + OpenSSL may repeat with fork
=begin
Motohiro: I don't know you're serious or not about using pthread_atfork(), we should ask to change OpenSSL's "1 time initialization by RAND_poll() per process when using built-in MD based RPNG engine" strategy if we really want.
...
nahi (Hiroshi Nakamura)
05:27 AM Bug #4579: SecureRandom + OpenSSL may repeat with fork
=begin
I think RAND_cleanup() is enough and simpler. I'm also bringing this up on the openssl-dev mailing list.
=end
normalperson (Eric Wong)
12:14 AM Bug #4579: SecureRandom + OpenSSL may repeat with fork
=begin
More paranoia patch is here.
=end
kosaki (Motohiro KOSAKI)
12:00 AM Bug #4579: SecureRandom + OpenSSL may repeat with fork
=begin
Usually openssl read /dev/urandom only once. But RAND_cleanup() lead to read /dev/urandom again. Thus attached patch fixes this issue.
This is better patch than PAND_add(/dev/urandom) because openssl can use other entropy sourc...
kosaki (Motohiro KOSAKI)
01:08 PM Revision 4c6580f8 (git): typo
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@31296 b2dd03c8-39d4-4d8f-98ff-823fe69b080e Tadayoshi Funaba
12:58 PM Revision ec01a881 (git): * ext/date/date_core.c: replacement of implementation of
_strptime. [experimental]
* ext/date/date_strptime.c: new.
* ext/date/lib/date/format.rb: removed ruby version of _strptime.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@31295 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
Tadayoshi Funaba
02:20 AM Bug #4580 (Third Party's Issue): actionpack-3.0.6/lib/action_controller/metal/renderers.rb: 74 SEGFAULT
=begin
It seems yajl's bug.
=end
naruse (Yui NARUSE)
02:16 AM Bug #4580 (Third Party's Issue): actionpack-3.0.6/lib/action_controller/metal/renderers.rb: 74 SEGFAULT
=begin
This happens in a big project. I tried to isolate it without much success :(
dblock@dblock-magenta:~/source/Gravity/dblock$ bundle exec rspec spec
No DRb server is running. Running in local process instead ...
*..............
dblock (Daniel Doubrovkine)
01:23 AM Revision b1fd9e92 (git): * 2011-04-16
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@31294 b2dd03c8-39d4-4d8f-98ff-823fe69b080e svn[bot]
01:23 AM Revision 44638b27 (git): replace reduce with suppress
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@31293 b2dd03c8-39d4-4d8f-98ff-823fe69b080e znz (Kazuhiro NISHIYAMA)
01:23 AM Revision c0b0901c (git): * vm.c (Init_VM): suppress warning: "OPT_BASIC_OPERATIONS" is not defined.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@31292 b2dd03c8-39d4-4d8f-98ff-823fe69b080e znz (Kazuhiro NISHIYAMA)

04/15/2011

09:17 PM Bug #4476 (Closed): [PATCH] URI('http://hoge/b/').route_to('http://hoge/b') wrongly returns './'
=begin
=end
knu (Akinori MUSHA)
06:19 PM Bug #4579: SecureRandom + OpenSSL may repeat with fork
=begin
I don't have an idea how OpenSSL can be 'fork-safe' for your purpose...
Call OpenSSL::Random.load_random_file("/dev/urandom" or "/dev/random" or ENV["RANDFILE"]) after each fork.
=end
nahi (Hiroshi Nakamura)
02:54 PM Bug #4579: SecureRandom + OpenSSL may repeat with fork
=begin
SecureRandom.random_bytes is just a wrapper of OpenSSL::Random.random_bytes(n) on systems with openssl.
And OpenSSL::Random.random_bytes is a wrapper of RAND_bytes(3).
You know its result depends pid and openssl ext should use...
naruse (Yui NARUSE)
11:46 AM Bug #4579 (Closed): SecureRandom + OpenSSL may repeat with fork
=begin
This could arguably be a bug in OpenSSL or the openssl extension, but
I think it's easier to fix in Ruby right now.
The PRNG in OpenSSL uses the PID to seed the PRNG. Since PIDs get
recycled over time on Unix systems, this ...
normalperson (Eric Wong)
03:08 PM Bug #4566 (Assigned): followup of [ruby-core:32747]
=begin
FYI, on FreeBSD 8.1 and gcc4.6 -O3, it wokrs.
=end
naruse (Yui NARUSE)
02:42 PM Revision 82fd7175 (git): * ruby.c (proc_options): reduce warning: "ALLOW_DEFAULT_SOURCE_ENCODING" is not defined.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@31291 b2dd03c8-39d4-4d8f-98ff-823fe69b080e znz (Kazuhiro NISHIYAMA)
12:19 PM Bug #4577: (int...float).max should not raise an error
=begin
Ranges with numbers as begin_obj and end_obj can be summarized to four(..and...):
int..int # no problem
float..float # no problem, float has no #succ, cannot iterate
float..int # act as float..float, no problem, no #succ, ...
yimutang (Joey Zhou)
11:10 AM Bug #4577: (int...float).max should not raise an error
=begin
Well, what I mean is ((*#max without block*)) and ((*#max {block}*)) should act the same way, maybe.
(1...6.3).max {|a,b| a <=> b} # 6
Why this one can iterate from 1 to 6, but not single #max ?
It seems there are two #m...
yimutang (Joey Zhou)
09:23 AM Bug #4577: (int...float).max should not raise an error
=begin
Hi,

In message "Re: [ruby-core:35754] [Ruby 1.9 - Bug #4577][Open] (int...float).max should not raise an error"
on Fri, 15 Apr 2011 00:02:07 +0900, redmine@ruby-lang.org writes:
|-------------------------------------...
matz (Yukihiro Matsumoto)
07:23 AM Bug #4577: (int...float).max should not raise an error
=begin
Hi,

I feel that 1.8's Range#max is good.

1.9's Range#max sometimes does strange behavior.
>irb
irb(main):001:0> RUBY_DESCRIPTION
=> "ruby 1.9.3dev (2011-04-11 trunk 31261) [i386-mswin32_100]"
irb(main):002:0> (1...
tarui (Masaya Tarui)
12:02 AM Bug #4577 (Rejected): (int...float).max should not raise an error
=begin
(int...float).max (without a block) will raise an error:
(({p (1...9.3).max # cannot exclude non Integer end value (TypeError)}))
I don't think it should do so.
int...float is a valid range object. When I construct such ...
yimutang (Joey Zhou)
07:39 AM Revision 09bafe3c (git): * 2011-04-15
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@31290 b2dd03c8-39d4-4d8f-98ff-823fe69b080e svn[bot]
07:23 AM Feature #4574: Numeric#within
=begin
On 14/04/2011, at 9:40 PM, Nikolai Weibull wrote:
> On Thu, Apr 14, 2011 at 12:49, <redmine@ruby-lang.org> wrote:
>> I think Numeric#within is perhaps less intuitive than something
>> like Range#bound or Range#trim. It f...
cjheath (Clifford Heath)
06:23 AM Bug #4558: TestSocket#test_closed_read fails after r31230
=begin
KOSAKI Motohiro <kosaki.motohiro@gmail.com> wrote:
> > KOSAKI Motohiro <kosaki.motohiro@gmail.com> wrote:
> >> > Issue #4558 has been updated by Eric Wong.
> following scenario should be happen too.
>
> CPU1 ...
normalperson (Eric Wong)
06:21 AM Revision 733d4294 (git): Add some more tests for the previous fix.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@31289 b2dd03c8-39d4-4d8f-98ff-823fe69b080e Akinori MUSHA
06:13 AM Revision 835693da (git): * lib/uri/generic.rb (#route_from_path): Fix a bug where
URI('http://h/b/').route_to('http://h/b') wrongly returned './'
(should be '../b'). [Bug #4476]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@31288 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
Akinori MUSHA
06:05 AM Revision 6692ef3c (git): * lib/fileutils.rb (FileUtils#touch): Fix corrupted output when
:mtime is specified in addition to :nocreate (and :verbose).
ref [ruby-dev:43401]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@31287 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
Akinori MUSHA

04/14/2011

10:46 PM Bug #4576 (Closed): Range#step miss the last value, if end-exclusive and has float number
=begin
Hi, I find that:
* if: range.exclude_end? == true
* and: any one in [begin_obj, end_obj, step] is a true Float(f.to_i != f)
* and: unless begin_obj + step*int == end_obj
* then: the result will miss the last value.
for e...
yimutang (Joey Zhou)
07:59 PM Bug #4575 (Closed): FileUtils.touch の出力が気になる
=begin
再現方法の説明がていねいでとても助かります。
r31273 としてコミットしました。
=end
kosaki (Motohiro KOSAKI)
07:49 PM Feature #4574: Numeric#within
=begin
I think Numeric#within is perhaps less intuitive than something like Range#bound or Range#trim. It feels more natural to have it be a method on Range. I like Range#clamp but it might not be so obvious that restricts the argument t...
aprescott (Adam Prescott)
12:30 PM Feature #4574: Numeric#within
=begin
More off topic. Here is very similar discussion by phthonia.
http://stackoverflow.com/questions/4092528/how-to-clamp-an-integer-to-some-range-in-python
=end
kosaki (Motohiro KOSAKI)
12:19 PM Feature #4574: Numeric#within
=begin
Gack!
simple paste made RD format error. ;-)
Let's retry.
---------------------------------------------------
Btw, Linux kernel has following macro.
/**
* clamp - return a value clamped to a given range with strict typechecki...
kosaki (Motohiro KOSAKI)
12:23 AM Feature #4574: Numeric#within
=begin
Hello,

2011/4/13 <redmine@ruby-lang.org>:
>> I like Numeric#limit and/or Numeric#clip.  I think "limit" is more mathematical, and "clip" is more easy to understand its functionality from its name.  So I believe it is accep...
mame (Yusuke Endoh)
02:50 PM Revision 9d5f651a (git): * numeric.c (ruby_float_step): wrong loop condition.
fixes [ruby-core:35753], reported by Joey Zhou.
* test/ruby/test_range.rb (TestRange#test_step_ruby_core_35753):
test above change.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@31286 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
U.Nakamura
01:48 PM Revision 716a9938 (git): * lib/test/unit.rb (Test::Unit::Options#setup_options): set possible
values for completion. no conversion is needed.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@31285 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
nobu (Nobuyoshi Nakada)
01:48 PM Revision 80020d09 (git): * lib/test/unit.rb (Test::Unit::Runner::Worker#initialize): use
positional arguments instead of keyword arguments.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@31284 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
nobu (Nobuyoshi Nakada)
01:48 PM Revision 3d41f4df (git): * lib/test/unit.rb (Test::Unit::Runner#jobs_status): io/console may
not be available. use 80 as the last resort if IO#winsize and
COLUMNS are unavailable.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@31283 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
nobu (Nobuyoshi Nakada)
01:48 PM Revision 146bedd6 (git): * lib/test/unit.rb (Test::Unit::Runner::Worker#died): rename using a
verb.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@31282 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
nobu (Nobuyoshi Nakada)
01:48 PM Revision ed1c3f56 (git): * lib/test/unit.rb (Test::Unit::Runner#_run_parallel): check if worker
is signaled and use its exit status.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@31281 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
nobu (Nobuyoshi Nakada)
01:47 PM Revision 311b3b4f (git): * lib/test/unit.rb (Test::Unit::Runner::Worker#dead): no longer @in
and @out are separated.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@31280 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
nobu (Nobuyoshi Nakada)
12:23 PM Revision af103c63 (git): * variable.c (rb_autoload_p): search superclasses as same as actual
loading. fixes [ruby-core:35679]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@31279 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
nobu (Nobuyoshi Nakada)
12:21 PM Revision d9865000 (git): * include/ruby/win32.h (frexp, modf): wrongly declared as pure in
mingw math.h.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@31278 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
nobu (Nobuyoshi Nakada)
12:21 PM Revision f777225e (git): * include/ruby/win32.h (ftruncate, truncate): mingw64 misses
prototypes.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@31277 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
nobu (Nobuyoshi Nakada)
12:20 PM Revision b8bcb647 (git): * win32/win32.c (rb_w32_read): suppress warning.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@31276 b2dd03c8-39d4-4d8f-98ff-823fe69b080e nobu (Nobuyoshi Nakada)
12:16 PM Revision b4dc41d4 (git): fix style.
* ext/stringio/stringio.c (strio_each, strio_readlines): fix style.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@31275 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
nobu (Nobuyoshi Nakada)
11:01 AM Revision f5c7d107 (git): fix ChangeLog description.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@31274 b2dd03c8-39d4-4d8f-98ff-823fe69b080e kosaki (Motohiro KOSAKI)
10:58 AM Revision 8c5961f6 (git): * lib/fileutils.rb (FileUtils#touch): fix corrupted output when
FileUtils.touch(:nocreate => true, :verbose => true) case.
The patch was written by Hiroyuki Iwatsuki. [ruby-dev:43401]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@31273 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
kosaki (Motohiro KOSAKI)
07:02 AM Revision fb7f3bf3 (git): * io.c (rb_f_syscall): reduce warning: "HAVE___SYSCALL" is not defined.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@31272 b2dd03c8-39d4-4d8f-98ff-823fe69b080e znz (Kazuhiro NISHIYAMA)
05:23 AM Bug #4558: TestSocket#test_closed_read fails after r31230
=begin
KOSAKI Motohiro <kosaki.motohiro@gmail.com> wrote:
> > Issue #4558 has been updated by Eric Wong.
> >
> > I consider either Errno::EBADF or IOError to be acceptable.
>
> Hmm...
> I can't agree this. If EBADF can be o...
normalperson (Eric Wong)

04/13/2011

11:37 PM Bug #4575 (Closed): FileUtils.touch の出力が気になる
=begin
些細な話ですが、FileUtils.touchにnocreateとverboseのオプションを付けた時に出力されるメッセージで、オプションとファイル名が連結して表示されるのが気になります。
irb(main):001:0> RUBY_DESCRIPTION
=> "ruby 1.9.3dev (2011-04-13 trunk 31269) [x86_64-darwin10.7.0]"
irb(main):002:0> require "f...
iwadon (Hiroyuki Iwatsuki)
11:31 PM Feature #4574: Numeric#within
=begin
Hello,
Kenta Murata wrote:
> I like Numeric#limit and/or Numeric#clip. I think "limit" is more mathematical, and "clip" is more easy to understand its functionality from its name. So I believe it is acceptable that the bot...
Eregon (Benoit Daloze)
10:23 PM Feature #4574: Numeric#within
=begin
Hello,

2011/4/13 <redmine@ruby-lang.org>:
> I prefer this sort of method be an instance method of Range.

I can accept Range method, but why?
I think that the subject of this feature is the limited Numeric.


> You pro...
mame (Yusuke Endoh)
09:52 PM Feature #4574: Numeric#within
=begin
For Japanese: clamp は漫画家じゃなくて万力/締め具のことです:)
=end
sakuro (Sakuro OZAWA)
09:49 PM Feature #4574: Numeric#within
=begin
I prefer this sort of method be an instance method of Range.
You propse Range#bound, but 'bound' as a verb is similar to jump/leap (and its intransitive), isn't it? Do you mean past particle form of 'bind' ?
Anyway I propos...
sakuro (Sakuro OZAWA)
09:42 PM Feature #4574: Numeric#within
=begin
I like Numeric#limit and/or Numeric#clip. I think "limit" is more mathematical, and "clip" is more easy to understand its functionality from its name. So I believe it is acceptable that the both names are provided.
In contras...
mrkn (Kenta Murata)
09:05 PM Feature #4574 (Rejected): Numeric#within
=begin
Hello,
Many people have written programs that limits an integer/float
within a range like:
v = [[v, min].max, max].min
or
v = v < min ? min : (v < max ? v : max)
or
if v < min
v = min
elsif max < ...
mame (Yusuke Endoh)
09:23 PM Bug #4558: TestSocket#test_closed_read fails after r31230
=begin
Hi

2011/4/13 U.Nakamura <usa@garbagecollect.jp>:
> Hello,
>
> In message "[ruby-core:35725] Re: [Ruby 1.9 - Bug #4558][Assigned] TestSocket#test_closed_read fails after r31230"
>    on Apr.12,2011 21:31:46, <kosaki.motoh...
kosaki (Motohiro KOSAKI)
01:29 PM Bug #4558: TestSocket#test_closed_read fails after r31230
=begin
Hello,

In message "[ruby-core:35725] Re: [Ruby 1.9 - Bug #4558][Assigned] TestSocket#test_closed_read fails after r31230"
on Apr.12,2011 21:31:46, <kosaki.motohiro@gmail.com> wrote:
> > Or, please explain grounds fro...
usa (Usaku NAKAMURA)
09:14 PM Feature #4569: Replace IPAddr with IPAddress
=begin
Jonas Pfenniger wrote:
> Hi Marco, awesome lib.
Thank you Jonas
> ...
Never thought about that, but it's a good point. IPv4#[] is an alias to IPv4#octet, just some syntax sugar, could be easily removed if we think it may...
ceresa@gmail.com (Marco Ceresa)
03:43 PM Revision b642a738 (git): * 2011-04-14
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@31271 b2dd03c8-39d4-4d8f-98ff-823fe69b080e svn[bot]
03:43 PM Revision d4d13162 (git): * thread.c (thread_fd_close_i): IOError exception should be assigned
to rb_thread_t::thrown_errinfo.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@31270 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
nagachika (Tomoyuki Chikanaga)
11:22 AM Revision a52dce92 (git): * 2011-04-13
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@31269 b2dd03c8-39d4-4d8f-98ff-823fe69b080e svn[bot]
11:22 AM Revision c5a284aa (git): * io.c (rb_io_fdatasync): remove unused variable.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@31268 b2dd03c8-39d4-4d8f-98ff-823fe69b080e znz (Kazuhiro NISHIYAMA)
08:45 AM Feature #4568: [PATCH] file.c (rb_group_member): kill 256K of stack usage
=begin
Eric Wong <normalperson@yhbt.net> wrote:
> Lowering RUBY_STACK_MIN_LIMIT to 64KB across the board in
> thread_pthread.c seems to work fine for check, test-rubyspec,
> benchmark-each.
>
> No real code, though, and I als...
normalperson (Eric Wong)

04/12/2011

10:23 PM Bug #4558: TestSocket#test_closed_read fails after r31230
=begin
> Issue #4558 has been updated by Eric Wong.
>
> I consider either Errno::EBADF or IOError to be acceptable.

Hmm...
I can't agree this. If EBADF can be observed, we can observe completely
unrelated file when a fd number wa...
kosaki (Motohiro KOSAKI)
10:23 PM Bug #4558: TestSocket#test_closed_read fails after r31230
=begin
2011/4/12 <redmine@ruby-lang.org>:
>
> Issue #4558 has been updated by Usaku NAKAMURA.
>
> Category changed from core to test
> Status changed from Closed to Assigned
> Assignee set to Motohiro KOSAKI
>
> I have ...
kosaki (Motohiro KOSAKI)
11:29 AM Bug #4558: TestSocket#test_closed_read fails after r31230
=begin
I consider either Errno::EBADF or IOError to be acceptable.
The main thing I care about is I/O for pipes/sockets being interruptable
(I only work on *nix).
By the way, test/socket/test_socket.rb has had a similar test for m...
normalperson (Eric Wong)
10:55 AM Bug #4558 (Assigned): TestSocket#test_closed_read fails after r31230
=begin
I have no opinion about this topic, but the test code which was checked in at r31260 by kosaki-san is platform dependent.
It blocks on Windows, and stops all tests.
I request to revert it.
Or, please explain grounds from whic...
usa (Usaku NAKAMURA)
09:16 PM Feature #4553: Add Set#pick and Set#pop
=begin
#pop is often associated to stack operations, which implies an order. Unless a better name is found, isn't set.delete(set.take) enough ?
#take can be an alias of #first but I'm not sure if Enumerable should be included in Set i...
zimbatm (zimba tm)
09:05 AM Feature #4553: Add Set#pick and Set#pop
=begin
The ruby-core e-mail I sent appeared to not attach to the issue on Redmine. I apologize for the noise.
-----------------------------------------------------------
The existence of `Set#first` is an artifact of Set including ...
adgar (Michael Edgar)
09:10 PM Feature #4541: Inconsistent Array.slice()
I don't see the advantage of having nil returned in any case since the empty array already expresses the "there is no object in that range".
Out of bound can be tested separately if necessary, but most of the cases you just want to ge...
zimbatm (zimba tm)
09:02 PM Bug #4573 (Closed): [BUG] Segmentation fault - Ruby interpreter (CUI) 1.9.2p180 [i386-mingw32] has stopped working
=begin
Scenario : run existing ROR application on windows 7 with Service Pack 1 installed (all windows updates were done)
(this same application works fine on xp and ubuntu)
Note: I have installed on my machine mysql 5.1
Steps follo...
rmiron (Rares Miron)
08:18 PM Bug #4515: File.each_line read all lines of file as one line
=begin
Hi,

The default line separator is a newline ("\n"), but if you want to
change it, try f.each_line("\r") instead.

matz.

In message "Re: [ruby-core:35534] [Ruby 1.9 - Bug #4515][Open] File.each_line read all...
matz (Yukihiro Matsumoto)
08:17 PM Bug #4515: File.each_line read all lines of file as one line
=begin
Hi,

The default line separator is a newline ("\n"), but if you want to
change it, try f.each_line("\r") instead.

matz.

In message "Re: [ruby-core:35534] [Ruby 1.9 - Bug #4515][Open] File.each_line read all...
matz (Yukihiro Matsumoto)
08:18 PM Bug #4463: [PATCH] release GVL for fcntl() for operations that may block
=begin
Eric Wong <normalperson@yhbt.net> wrote:
> KOSAKI Motohiro <kosaki.motohiro@gmail.com> wrote:
> > Umm..
> > I don't like its interface so much. your flock object don't mange any lock
> > state. it's merely wrapper of argu...
normalperson (Eric Wong)
08:18 PM Bug #4463: [PATCH] release GVL for fcntl() for operations that may block
=begin
KOSAKI Motohiro <kosaki.motohiro@gmail.com> wrote:
> Umm..
> I don't like its interface so much. your flock object don't mange any lock
> state. it's merely wrapper of argument of fcntl. your interface mean we need
> two ...
normalperson (Eric Wong)
08:18 PM Bug #4463: [PATCH] release GVL for fcntl() for operations that may block
=begin
Hi

>> I've commited slightly modified version today (r31025).
>> The difference is,
>>
>> 1) All IO.fcntl() and IO.iocntl() relese GVL instead only SETLCKW. because,
>>     A) if a user are using network filesystem, almo...
kosaki (Motohiro KOSAKI)
08:18 PM Bug #4463: [PATCH] release GVL for fcntl() for operations that may block
=begin
KOSAKI Motohiro <kosaki.motohiro@gmail.com> wrote:
> Hi
>
> I've commited slightly modified version today (r31025).
> The difference is,
>
> 1) All IO.fcntl() and IO.iocntl() relese GVL instead only SETLCKW. because...
normalperson (Eric Wong)
08:18 PM Bug #4463: [PATCH] release GVL for fcntl() for operations that may block
=begin
Hi

2011/3/3 KOSAKI Motohiro <kosaki.motohiro@gmail.com>:
>> Issue #4463 has been reported by Eric Wong.
>>
>> ----------------------------------------
>> Bug #4463: [PATCH] release GVL for fcntl() for operations that...
kosaki (Motohiro KOSAKI)
08:18 PM Bug #4463: [PATCH] release GVL for fcntl() for operations that may block
=begin
> Issue #4463 has been reported by Eric Wong.
>
> ----------------------------------------
> Bug #4463: [PATCH] release GVL for fcntl() for operations that may block
> http://redmine.ruby-lang.org/issues/4463
>
> Auth...
kosaki (Motohiro KOSAKI)
08:17 PM Bug #4463: [PATCH] release GVL for fcntl() for operations that may block
=begin
Eric Wong <normalperson@yhbt.net> wrote:
> KOSAKI Motohiro <kosaki.motohiro@gmail.com> wrote:
> > Umm..
> > I don't like its interface so much. your flock object don't mange any lock
> > state. it's merely wrapper of argu...
normalperson (Eric Wong)
08:17 PM Bug #4463: [PATCH] release GVL for fcntl() for operations that may block
=begin
KOSAKI Motohiro <kosaki.motohiro@gmail.com> wrote:
> Umm..
> I don't like its interface so much. your flock object don't mange any lock
> state. it's merely wrapper of argument of fcntl. your interface mean we need
> two ...
normalperson (Eric Wong)
08:17 PM Bug #4463: [PATCH] release GVL for fcntl() for operations that may block
=begin
Hi

>> I've commited slightly modified version today (r31025).
>> The difference is,
>>
>> 1) All IO.fcntl() and IO.iocntl() relese GVL instead only SETLCKW. because,
>>     A) if a user are using network filesystem, almo...
kosaki (Motohiro KOSAKI)
08:17 PM Bug #4463: [PATCH] release GVL for fcntl() for operations that may block
=begin
KOSAKI Motohiro <kosaki.motohiro@gmail.com> wrote:
> Hi
>
> I've commited slightly modified version today (r31025).
> The difference is,
>
> 1) All IO.fcntl() and IO.iocntl() relese GVL instead only SETLCKW. because...
normalperson (Eric Wong)
08:17 PM Bug #4463: [PATCH] release GVL for fcntl() for operations that may block
=begin
Hi

2011/3/3 KOSAKI Motohiro <kosaki.motohiro@gmail.com>:
>> Issue #4463 has been reported by Eric Wong.
>>
>> ----------------------------------------
>> Bug #4463: [PATCH] release GVL for fcntl() for operations that...
kosaki (Motohiro KOSAKI)
08:17 PM Bug #4463: [PATCH] release GVL for fcntl() for operations that may block
=begin
> Issue #4463 has been reported by Eric Wong.
>
> ----------------------------------------
> Bug #4463: [PATCH] release GVL for fcntl() for operations that may block
> http://redmine.ruby-lang.org/issues/4463
>
> Auth...
kosaki (Motohiro KOSAKI)
08:18 PM Bug #3972: r28668 breaks test/unit when combined with the testing rake task
=begin
On Tue, Feb 22, 2011 at 11:39:20PM +0900, Tomoyuki Chikanaga wrote:
> Issue #3972 has been updated by Tomoyuki Chikanaga.
>
>
> Hi,
>
> After r30913, make test-all output warning and testunit message in test_rake_integra...
tenderlovemaking (Aaron Patterson)
08:17 PM Bug #3972: r28668 breaks test/unit when combined with the testing rake task
=begin
On Tue, Feb 22, 2011 at 11:39:20PM +0900, Tomoyuki Chikanaga wrote:
> Issue #3972 has been updated by Tomoyuki Chikanaga.
>
>
> Hi,
>
> After r30913, make test-all output warning and testunit message in test_rake_integra...
tenderlovemaking (Aaron Patterson)
08:18 PM Feature #4568: [PATCH] file.c (rb_group_member): kill 256K of stack usage
=begin
Lowering RUBY_STACK_MIN_LIMIT to 64KB across the board in
thread_pthread.c seems to work fine for check, test-rubyspec,
benchmark-each.

No real code, though, and I also don't know what outside C extensions
do, but 64KB...
normalperson (Eric Wong)
08:17 PM Bug #4527: [PATCH] IO#close releases GVL if possible
Motohiro KOSAKI <kosaki.motohiro@gmail.com> wrote:
> Eric, I commited slightly modified version because your patch couldn't
> ...
Thanks, looks like you missed the following hunk in rb_io_reopen():
```diff
diff --git a/io.c b/io.c
...
normalperson (Eric Wong)
07:20 PM Bug #4572 (Closed): URI.encode_www_form_component and decode_www_form_component are not threadsafe
=begin
This issue was solved with changeset r31266.
John, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.
----------
* lib/uri/common.rb: avoid race condition. fixes #4572
=end
naruse (Yui NARUSE)
02:24 PM Bug #4572 (Closed): URI.encode_www_form_component and decode_www_form_component are not threadsafe
=begin
The initializations of TBLENCWWWCOMP_ and TBLDECWWWCOMP_ suffer from an obvious race condition. If multiple threads enter either the function for the first time, it may produce unexpected results. The initializations should be don...
john_firebaugh (John Firebaugh)
07:14 PM Feature #4569: Replace IPAddr with IPAddress
=begin
Hi Marco, awesome lib. I read trough it and here are the thoughts I had:
* IPAddr#[] and IPAddr#each don't hold the same elements, could it be a source of confusion ?
* Is it possible to avoid extending the ruby core ?
Cheers,
J...
zimbatm (zimba tm)
04:55 PM Feature #4569 (Assigned): Replace IPAddr with IPAddress
=begin
=end
naruse (Yui NARUSE)
12:02 AM Feature #4569 (Closed): Replace IPAddr with IPAddress
=begin
Hello,
following the discussion we had a few months ago about replacing IPAddr with IPAddress [1]. Here is the formal request.
IPAddress is now at version 0.7.5
URL: https://github.com/bluemonk/ipaddress
I think it's...
ceresa@gmail.com (Marco Ceresa)
04:58 PM Bug #4571 (Assigned): YAML.load given an ISO8601 timestamp creates an incorrect value for usec
=begin
=end
naruse (Yui NARUSE)
08:18 AM Bug #4571 (Closed): YAML.load given an ISO8601 timestamp creates an incorrect value for usec
=begin
$ ruby1.8.7 -v -ryaml -e 'p YAML.load("2011-03-22t23:32:11.000000342222+01:00").usec'
ruby 1.8.7 (2011-02-18 patchlevel 334) [i686-darwin9.8.0]
342222
$ ruby1.9.2 -v -ryaml -e 'p YAML.load("2011-03-22t23:32:11.000000342222+0...
brixen (Brian Shirai)
01:13 PM Bug #4562: [pull requested] ./config no-ssl2で作ったopensslとext/opensslが混ざらない
=begin
Yui NARUSE wrote:
> Iwamatsu さんに ext/openssl のメンテナになってもらって、
> ...
Laurent Arnoud さんのパッチ(こちらのパッチ)のほうがよいと思います。
パッチを適用して、動作確認まで行いました。
=end
iwamatsu (Nobuhiro Iwamatsu)
11:54 AM Revision 77a12692 (git): * include/ruby/st.h: parenthesize macro arguments.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@31267 b2dd03c8-39d4-4d8f-98ff-823fe69b080e akr (Akira Tanaka)
10:20 AM Revision 8553b70a (git): * lib/uri/common.rb: avoid race condition. fixes #4572
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@31266 b2dd03c8-39d4-4d8f-98ff-823fe69b080e naruse (Yui NARUSE)
09:08 AM Revision dd11a58b (git): * ext/readline/extconf.rb: --disable-libedit to disable
libedit. fixes #4550
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@31265 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
kouji (Kouji Takao)
04:17 AM Bug #4566: followup of [ruby-core:32747]
=begin
>>The patch seems wrong: first is the way check the gcc version, and the condition also wrong.
the definitive solution would be leaving only following line
:#define DECL_SC_REG(type, r, reg) register type reg_##r
> ...
to be ho...
jojelino (jojelino _)
01:51 AM Feature #4570 (Closed): [PATCH v2] io.c (rb_io_close): release GVL if possible
=begin
v2 of this change should fix issue #4558 and
be cleaner than the original proposed fixes.
Also pushed to my repo: git pull git://bogomips.org/ruby io-close-nogvl2
=end
normalperson (Eric Wong)
01:42 AM Bug #4564 (Closed): mingw-w64, truncate, ftruncate and ftello -- properly evalute it's existence
=begin
Thank you.
Committed in r31262
=end
luislavena (Luis Lavena)
01:39 AM Revision c3b81f63 (git): * include/ruby/win32.h: VC doesn't have ftruncate() and others, but
ruby needs HAVE_ macros to use our emulation functions.
(fix the problem of 31262)
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@31264 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
U.Nakamura
01:04 AM Bug #4555: [PATCH] ext/socket/init.c: rsock_connect retries on interrupt
=begin
Your patch looks reasonable to me, but maybe some platforms break under it...
I was trying to emulate rb_io_wait_writable() logic which calls
rb_thread_fd_writable() (which wraps select() if there are multiple threads).
Maybe...
normalperson (Eric Wong)

04/11/2011

11:08 PM Bug #4555: [PATCH] ext/socket/init.c: rsock_connect retries on interrupt
=begin
Hi
I'm not convinced why we can safely call select() when we get EINTR. IOW,
Why don't you choose following patch?
Index: ext/socket/init.c
===================================================================
--- ext/soc...
kosaki (Motohiro KOSAKI)
10:23 PM Bug #4558: TestSocket#test_closed_read fails after r31230
=begin
> Subject: [PATCH] io.c (rb_io_close): ensure IOError for cross-thread closes
>
> We need to inform threads to stop operations on the FD before
> closing it and also invalidate the fd member of the rb_io_t
> struct for other ...
kosaki (Motohiro KOSAKI)
09:53 PM Bug #4558 (Closed): TestSocket#test_closed_read fails after r31230
=begin
r31230 was revered by r31261.
=end
kosaki (Motohiro KOSAKI)
10:00 PM Bug #4526 (Closed): [PATCH] IO#syswrite releases GVL
=begin
Committed by r31237.
=end
kosaki (Motohiro KOSAKI)
09:54 PM Bug #4527 (Rejected): [PATCH] IO#close releases GVL if possible
The patch reverted because it made a regression (see [Bug #4558])
kosaki (Motohiro KOSAKI)
09:19 PM Feature #4568 (Closed): [PATCH] file.c (rb_group_member): kill 256K of stack usage
=begin
Commited by r31259.
=end
kosaki (Motohiro KOSAKI)
05:23 PM Feature #4568: [PATCH] file.c (rb_group_member): kill 256K of stack usage
=begin
Lowering RUBY_STACK_MIN_LIMIT to 64KB across the board in
thread_pthread.c seems to work fine for check, test-rubyspec,
benchmark-each.

No real code, though, and I also don't know what outside C extensions
do, but 64KB...
normalperson (Eric Wong)
04:01 PM Feature #4568 (Closed): [PATCH] file.c (rb_group_member): kill 256K of stack usage
=begin
It was using 256K stack on my x86_64 machine.
Found with scripts/checkstack.pl in the Linux kernel source:
objdump -D ./ruby | ~/linux-2.6/scripts/checkstack.pl x86_64
Also pushed to my repo: git pull git://bogomips....
normalperson (Eric Wong)
04:38 PM Revision ace092cb (git): * 2011-04-12
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@31263 b2dd03c8-39d4-4d8f-98ff-823fe69b080e svn[bot]
04:38 PM Revision c2bfeaa2 (git): Evaluate truncate, ftruncate and ftello existence
This corrects mingw-w64 compilation.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@31262 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
luislavena (Luis Lavena)
12:52 PM Revision 0f771e33 (git): * io.c: revert r31230.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@31261 b2dd03c8-39d4-4d8f-98ff-823fe69b080e kosaki (Motohiro KOSAKI)
12:50 PM Revision 616f70fc (git): * test/ruby/test_io.rb: Added TestIO#test_cross_thread_close_stdio
and TestIO#test_cross_thread_close_fd.
The patch was written by Eric Wong. [ruby-core:35669]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@31260 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
kosaki (Motohiro KOSAKI)
12:18 PM Revision 3b011d1a (git): * file.c (rb_group_member): kill 256K of stack usage.
the patch was written by Eric Wong. [ruby-core:35699]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@31259 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
kosaki (Motohiro KOSAKI)
11:24 AM Bug #4566: followup of [ruby-core:32747]
=begin
The patch seems wrong: first is the way check the gcc version,
and the condition also wrong.
Additional to say, I doubt that this bug is reproduced only on mingw32.
=end
naruse (Yui NARUSE)
10:27 AM Bug #4565 (Assigned): incompatible change at rev.31169 about autoload
=begin
=end
naruse (Yui NARUSE)
09:25 AM Bug #4564 (Assigned): mingw-w64, truncate, ftruncate and ftello -- properly evalute it's existence
=begin
It seems good.
Check in, please.
=end
usa (Usaku NAKAMURA)
09:23 AM Feature #4560: [PATCH] lib/net/protocol.rb: avoid exceptions in rbuf_fill
=begin
redmine@ruby-lang.org wrote:
> On JRuby master, I've made a change that does not generate backtraces
> for EAGAIN, to avoid the overhead of generating it for the expected
> case of read_nonblock having nothing available. Bu...
normalperson (Eric Wong)
07:46 AM Feature #4560: [PATCH] lib/net/protocol.rb: avoid exceptions in rbuf_fill
=begin
This is an interesting one. JRuby recently changed how we generate backtraces to using the Java backtrace as the master. This means our backtraces are as expensive to generate as a full Java backtrace for the full stack (think gen...
headius (Charles Nutter)
07:23 AM Feature #4539: Array#zip_with
=begin
Hi,

On 2011年4月10日日曜日 at 11:56, Marc-Andre Lafortune wrote:
> On Sat, Apr 9, 2011 at 4:29 AM, Kenta Murata <muraken@gmail.com> wrote:
> > I implemented the features in C, and wrote tests for them.
> > Please see the fol...
mrkn (Kenta Murata)
05:58 AM Bug #4567 (Assigned): BigDecimal::ROUND_HALF_DOWN
=begin
=end
mrkn (Kenta Murata)
02:36 AM Bug #4567 (Closed): BigDecimal::ROUND_HALF_DOWN
=begin
SImilar to the issue here [[http://redmine.ruby-lang.org/issues/3803]], BigDecimal::ROUND_HALF_DOWN does not respect all the digits involved in the rounding of a number. For example:
(({BigDecimal("1.51").round(0, BigDecimal::...
semmons99 (Shane Emmons)
 

Also available in: Atom