Ruby

How would that work, what would be a sample implementation of the hook?
Timeout.timeout must be able to interrupt non-IO operations as well.

Timeout.timeout must be able to interrupt non-IO operations as well.

Actually, that's not necessarily true, even for the current implementation, see getaddrinfo for example.

It appears that Timeout.timeout does not work when a Fiber scheduler is set, regardless of the implementation, even when Fibers are not explicitly in use.

Simple example using the sample scheduler:

require 'timeout' require 'fiber' require_relative 'scheduler' scheduler = Scheduler.new Fiber.set_scheduler scheduler Timeout.timeout 1 do puts "hello" end 

This code will print "hello" then hang.

ioquatix (Samuel Williams) wrote in #note-2:

Actually, that's not necessarily true, even for the current implementation, see getaddrinfo for example.

You're completely evading my question :p
Could you answer it please?

That's one of the very rare cases, maybe even the only case in core methods that cannot be interrupted by Thread#raise.

Is the idea to simply give up on interrupting anything that's not handled by the scheduler if there is a Fiber.scheduler, or something better?
That seems too incompatible to me.
I think a new API to interrupt only scheduler things might make more sense (related to #17363).

@Eregon (Benoit Daloze) without preemptive scheduling it won't be possible. There are other cases where the GVL is not released, e.g. the sqlite3 gem. In the case of the scheduler, Timeout.timeout is completely broken, so this is an improvement any way you cut it.

@jsc I tried your example but it seems to work fine?

 MESSAGE = "Hello World" def test_timeout_on_main_fiber message = nil thread = Thread.new do scheduler = Scheduler.new Fiber.set_scheduler scheduler Timeout.timeout(1) do message = MESSAGE end end thread.join assert_equal MESSAGE, message end