Message91073
If you call email.utils.make_msgid a number of times within the same second, the uniqueness of the results depends on random.randint(100000) returning different values each time. A little mathematics proves that you don't have to call make_msgid *that* often to get the same message id twice: if you call it 'n' times, the probability of a collision is approximately "1 - math.exp(-n*(n-1)/200000.0)", and for n == 100, that's about 5%. For n == 1000, it's over 99%. These numbers are born out by experiment: >>> def collisions(n): ... msgids = [make_msgid() for i in range(n)] ... return len(msgids) - len(set(msgids)) ... >>> sum((collisions(100)>0) for i in range(1000)) 49 >>> sum((collisions(1000)>0) for i in range(1000)) 991 I think probably having a counter in addition to the randomness would be a good fix for the problem, though I guess then you have to worry about thread safety. | |
Date | User | Action | Args | 2009-07-30 00:32:16 | mwh | set | recipients: + mwh | 2009-07-30 00:32:16 | mwh | set | messageid: <1248913936.65.0.487457323949.issue6598@psf.upfronthosting.co.za> | 2009-07-30 00:32:14 | mwh | link | issue6598 messages | 2009-07-30 00:32:13 | mwh | create | | |