Message72672
I hate to make API suggestions this late in the process, but this is the first time I've looked at this. I think the basic problem is that the context manager API is a bit weird. What I don't like is the fact that __getattr__() indexes the last item in the WarningsRecorder. I don't know the history here, but why wouldn't this be a better API? with catch_warnings(True) as w: assert len(w) > 0, 'No caught warnings' assert str(w[-1].message) == 'foo', 'blah blah' | |
| Date | User | Action | Args | | 2008-09-06 17:03:18 | barry | set | recipients: + barry, brett.cannon, exarkun, pitrou | | 2008-09-06 17:03:18 | barry | set | messageid: <1220720598.5.0.49425088757.issue3781@psf.upfronthosting.co.za> | | 2008-09-06 17:03:17 | barry | link | issue3781 messages | | 2008-09-06 17:03:17 | barry | create | | |