➜ 
This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.
Created on 2020-11-02 07:26 by samuelmarks, last changed 2022-04-11 14:59 by admin. This issue is now closed.
| Pull Requests | |||
|---|---|---|---|
| URL | Status | Linked | Edit |
| PR 23099 | closed | samuelmarks, 2020-11-02 07:26 | |
| PR 19581 | erlendaasland, 2020-11-02 08:00 | ||
| Messages (4) | |||
|---|---|---|---|
| msg380186 - (view) | Author: Samuel Marks (samuelmarks) * | Date: 2020-11-02 07:26 | |
Backports https://github.com/python/cpython/pull/19581 https://bugs.python.org/issue40318 as per https://bugs.python.org/issue42229 See also 3.9 backporting: https://bugs.python.org/issue42241 [not sure if this is how you do backporting, a new issue and GH PR for each supported release tag?] | |||
| msg380193 - (view) | Author: Erlend E. Aasland (erlendaasland) *  | Date: 2020-11-02 08:09 | |
> [not sure if this is how you do backporting, a new issue and GH PR for each supported release tag?] Backports are almost always created as backports of a specific GitHub pull request. The pull request is labelled as, for example, "needs backport to 3.9", and a bot will automatically try to cherry-pick the squashed commit to the target branch. So, if we wanted to backport GH-19581, we would do that directly from the original pull request over at GitHub. That will also preserve commit meta-data. See also: https://devguide.python.org/committing/?highlight=backport#backporting-changes-to-an-older-version | |||
| msg380195 - (view) | Author: Dong-hee Na (corona10) *  | Date: 2020-11-02 08:14 | |
We often submit the backported patch by using the backport label from the origin PR. (https://github.com/python/cpython/pull/19581) So please discuss the backporting on bpo-40318 | |||
| msg380202 - (view) | Author: Samuel Marks (samuelmarks) * | Date: 2020-11-02 09:55 | |
Done, thanks for the how-to: - https://github.com/python/cpython/pull/23103 [3.8] - https://github.com/python/cpython/pull/23102 [3.9] | |||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:59:37 | admin | set | github: 86408 |
| 2020-11-02 09:55:54 | samuelmarks | set | messages: + msg380202 |
| 2020-11-02 08:14:31 | corona10 | set | status: open -> closed nosy: + corona10 messages: + msg380195 resolution: duplicate stage: patch review -> resolved |
| 2020-11-02 08:09:03 | erlendaasland | set | messages: + msg380193 |
| 2020-11-02 08:00:58 | erlendaasland | set | keywords: + patch nosy: + erlendaasland pull_requests: + pull_request22017 stage: patch review |
| 2020-11-02 07:26:01 | samuelmarks | create | |