Renames Request::setAuth to be a bit more specific.

Author: adri

src/VCR/LibraryHooks/SoapHook.php

@@ -73,13 +73,12 @@ public function doRequest($request, $location, $action, $version, $one_way = 0,
  $vcrRequest->setHeader('Content-Type', $contentType . '; charset=utf-8; action="' . $action . '"');
  $vcrRequest->setBody($request);
 
- if (isset($options['login'])) {
- $vcrRequest->setAuth($options['login'], $options['password']);
+ if (!empty($options['login'])) {
+ $vcrRequest->setAuthorization($options['login'], $options['password']);
  }
+
+ /* @var \VCR\Response $response */
  $requestCallback = self::$requestCallback;
- /**
- * @var \VCR\Response $response
- */
  $response = $requestCallback($vcrRequest);
 
  return $response->getBody();

src/VCR/Request.php

@@ -94,7 +94,6 @@ public function toArray()
  );
  }
 
-
  /**
  * Creates a new Request from a specified array.
  *
@@ -272,12 +271,12 @@ public function setBody($body)
  }
 
  /**
- * Sets the auth credentials.
+ * Sets the authorization credentials as header.
  *
- * @param string $username
- * @param string $password
+ * @param string $username Username.
+ * @param string $password Password.
  */
- public function setAuth($username, $password)
+ public function setAuthorization($username, $password)
  {
  $this->setHeader('Authorization', 'Basic ' . base64_encode($username . ':' . $password));
  }

tests/VCR/RequestTest.php

@@ -35,6 +35,13 @@ public function testSetMethod()
  $this->assertEquals('POST', $this->request->getMethod());
  }
 
+ public function testSetAuthorization()
+ {
+ $this->request->setAuthorization('login', 'password');
+
+ $this->assertEquals('Basic bG9naW46cGFzc3dvcmQ=', $this->request->getHeader('Authorization'));
+ }
+
  public function testMatches()
  {
  $request = new Request('GET', 'http://example.com', array('User-Agent' => 'Unit-Test'));